- wine-devel - winehq.org

Re: [PATCH 2/3] winspool/tests: Add some tests for OpenPrinter with non-NULL defaults.
by Alexandre Julliard 02 Apr '12

02 Apr '12

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/winspool.drv/tests/info.c | 110 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 110 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M winspool.drv -T ../../.. -p winspool.drv_test.exe.so info.c && touch info.ok info.c:2302: Tests skipped: Level 1 not supported info.c:2302: Tests skipped: Level 3 not supported info.c:2302: Tests skipped: Level 8 not supported info.c:2969: Test failed: got 0 wine: Unhandled page fault on read access to 0x00000028 at address 0x687e23fa (thread 002a), starting debugger... Unhandled exception: page fault on read access to 0x00000028 in 32-bit code (0x687e23fa). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:687e23fa ESP:0032fb50 EBP:0032fc58 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:687ec60c ECX:687e7eac EDX:0011e180 ESI:687e7ae5 EDI:0011deb0 Stack dump: 0x0032fb50: 687e7ae5 00000b9b 00000000 0011e180 0x0032fb60: 0000012e 0032fc3c 00000012 6833fef5 0x0032fb70: 683d88e8 00000000 0011e180 0001fc40 0x0032fb80: 0011dcd0 687e7e99 687e7c3c 00000001 0x0032fb90: 00000000 00000000 00000000 00000000 0x0032fba0: 00000000 00000000 00000000 00000000 Backtrace: =>0 0x687e23fa test_OpenPrinter_defaults+0x83a() [/home/julliard/wine/wine/dlls/winspool.drv/tests/info.c:2971] in winspool.drv_test (0x0032fc58) 1 0x687e561e func_info+0x22fd() [/home/julliard/wine/wine/dlls/winspool.drv/tests/info.c:3031] in winspool.drv_test (0x0032fd18) 2 0x687e6e70 run_test+0x11f(name="info.c") [/home/julliard/wine/wine/dlls/winspool.drv/tests/../../../include/wine/test.h:556] in winspool.drv_test (0x0032fd68) 3 0x687dadf3 main+0x152(argc=0x20746f67, argv=0x78383025) [/home/julliard/wine/wine/dlls/winspool.drv/tests/../../../include/wine/test.h:624] in winspool.drv_test (0x0032fe28) 4 0x687e79d5 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in winspool.drv_test (0x0032fe70) 5 0x6848fdbc call_process_entry+0xb() in kernel32 (0x0032fe88) 6 0x68490f3f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1083] in kernel32 (0x0032fec8) 7 0x6837d200 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 8 0x6837ff0d call_thread_func+0x7c(entry=0x68490ee0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 9 0x6837d1de call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 10 0x6835530e start_process+0x1d(kernel_start=0x68490ee0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2653] in ntdll (0x0032ffe8) 11 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 12 0x68028b5b wine_switch_to_stack+0x2a(func=0x683552f0, arg=0x68490ee0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff917048) 13 0x6835ae86 LdrInitializeThunk+0x3b5(kernel_start=0x68490ee0, unknown2=0, unknown3=0, unknown4=0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2709] in ntdll (0xff9170b8) 14 0x68496e02 __wine_kernel_init+0x9e1() [/home/julliard/wine/wine/dlls/kernel32/process.c:1255] in kernel32 (0xff918258) 15 0x6835b5db __wine_process_init+0x25a() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2918] in ntdll (0xff9182d8) 16 0x68025fe8 wine_init+0x277(argc=0x3, argv=0xff918834, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:831] in libwine.so.1 (0xff918338) 17 0x7bf00e5b main+0x7a(argc=0x3, argv=0xff918834) [/home/julliard/wine/wine/loader/main.c:230] in <wine-loader> (0xff918788) 18 0x681bce46 __libc_start_main+0xe5() in libc.so.6 (0xff918808) 0x687e23fa test_OpenPrinter_defaults+0x83a [/home/julliard/wine/wine/dlls/winspool.drv/tests/info.c:2971] in winspool.drv_test: movl 0x28(%eax),%eax 2971 ok( job_info->pDevMode->dmFields == DM_PAPERSIZE, "got %08x\n", -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [04/09]strmbase: implement renderer quality control into the base renderer
by Alexandre Julliard 02 Apr '12

02 Apr '12

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/quartz/dsoundrender.c | 28 ++++++++++------------------ > dlls/quartz/nullrenderer.c | 2 +- > dlls/strmbase/renderer.c | 41 > ++++++++++++++++++++++++++++++++++++++++- > include/wine/strmbase.h | 4 ++++ > 4 files changed, 55 insertions(+), 20 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so dsoundrender.c && touch dsoundrender.ok dsoundrender.c:155: Test failed: IUnknown_Release should return 1, got 0 wine: Unhandled page fault on execute access to 0x00110118 at address 0x110118 (thread 002b), starting debugger... Unhandled exception: page fault on execute access to 0x00110118 in 32-bit code (0x00110118). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:00110118 ESP:0032fccc EBP:0032fd58 EFLAGS:00010202( R- -- I - - - ) EAX:0012e9c0 EBX:687ee314 ECX:687ea900 EDX:0012f630 ESI:687e8269 EDI:00000000 Stack dump: 0x0032fccc: 687dd8c1 0012e9c0 687ea900 0032fd38 0x0032fcdc: 00000000 687eea78 00000000 00125338 0x0032fcec: 683bd30c 687ec163 683bd30c 0032fd18 0x0032fcfc: 00000000 687ea900 687e8490 687e7e01 0x0032fd0c: 687e82c0 683702d9 684d85f0 0032fd58 0x0032fd1c: 0012e9c0 0012ebe0 00000000 0012a298 Backtrace: =>0 0x00110118 (0x0032fd58) 1 0x687db392 main+0x3a1(argc=0x56a86895, argv=0x11ce0ad4) [/home/julliard/wine/wine/dlls/quartz/tests/../../../include/wine/test.h:556] in quartz_test (0x0032fe28) 2 0x687e7c85 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in quartz_test (0x0032fe70) 3 0x6848fdbc call_process_entry+0xb() in kernel32 (0x0032fe88) 4 0x68490f3f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1083] in kernel32 (0x0032fec8) 5 0x6837d200 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 6 0x6837ff0d call_thread_func+0x7c(entry=0x68490ee0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 7 0x6837d1de call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 8 0x6835530e start_process+0x1d(kernel_start=0x68490ee0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2653] in ntdll (0x0032ffe8) 9 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 10 0x68028b5b wine_switch_to_stack+0x2a(func=0x683552f0, arg=0x68490ee0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff90f428) 11 0x6835ae86 LdrInitializeThunk+0x3b5(kernel_start=0x68490ee0, unknown2=0, unknown3=0, unknown4=0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2709] in ntdll (0xff90f498) 12 0x68496e02 __wine_kernel_init+0x9e1() [/home/julliard/wine/wine/dlls/kernel32/process.c:1255] in kernel32 (0xff910638) 13 0x6835b5db __wine_process_init+0x25a() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2918] in ntdll (0xff9106b8) 14 0x68025fe8 wine_init+0x277(argc=0x3, argv=0xff910c14, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:831] in libwine.so.1 (0xff910718) 15 0x7bf00e5b main+0x7a(argc=0x3, argv=0xff910c14) [/home/julliard/wine/wine/loader/main.c:230] in <wine-loader> (0xff910b68) 16 0x681bce46 __libc_start_main+0xe5() in libc.so.6 (0xff910be8) 0x00110118: subb %al,0x0(%ecx) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Fixed parsing /=/ regexp
by Marvin 02 Apr '12

02 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17637 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: jscript: Emit undefined statement return for switch without default clausule
by Marvin 02 Apr '12

02 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17636 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: jscript: Emit undefined statement return for switch without default clausule
by Marvin 02 Apr '12

02 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17636 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wined3d: Added PCI device IDs for AMD Radeon 6750M & 6770M
by Henri Verbeet 02 Apr '12

02 Apr '12

On 31 March 2012 21:20, Gaurav Jain <gaurav(a)gauravjain.org> wrote: > CARD_AMD_RADEON_HD6600M = 0x6741, > + CARD_AMD_RADEON_HD6750M = 0x6741, If those are actually supposed to be the same, I don't think there's much of a point in this patch.

2 6

Re: [PATCH 1/4] d3drm: Implement IDirect3DRMFrameX_AddChild.
by Jacek Caban 02 Apr '12

02 Apr '12

Hi Christian, On 04/02/12 08:54, Christian Costa wrote: > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > + LPDIRECT3DRMFRAME3 frame; > > - FIXME("(%p/%p)->(%p): stub\n", iface, This, child); > + TRACE("(%p/%p)->(%p)\n", iface, This, child); > > - return E_NOTIMPL; > + if (!child) > + return D3DRMERR_BADOBJECT; > + > + frame = &impl_from_IDirect3DRMFrame2((LPDIRECT3DRMFRAME2)child)->IDirect3DRMFrame3_iface; This should be avoided. See unsafe_impl_from_* at http://wiki.winehq.org/COMGuideline for an example. Jacek

1 0

Re: [PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.
by Christian Costa 02 Apr '12

02 Apr '12

Le 02/04/2012 00:03, Michael Stefaniuc a écrit : > --- > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime (LPDIRECTMUSICPERFORMANCE8 iface, MUSIC_TIME mtTime, REFERENCE_TIME* prtTime) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime(IDirectMusicPerformance8 *iface, > + MUSIC_TIME mtTime, REFERENCE_TIME *prtTime) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, %d, %p): stub\n", This, mtTime, prtTime); > return S_OK; > } > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime (LPDIRECTMUSICPERFORMANCE8 iface, REFERENCE_TIME rtTime, MUSIC_TIME* pmtTime) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime(IDirectMusicPerformance8 *iface, > + REFERENCE_TIME rtTime, MUSIC_TIME *pmtTime) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, 0x%s, %p): stub\n", This, wine_dbgstr_longlong(rtTime), pmtTime); > return S_OK; > } > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying (LPDIRECTMUSICPERFORMANCE8 iface, IDirectMusicSegment* pSegment, IDirectMusicSegmentState* pSegState) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying(IDirectMusicPerformance8 *iface, > + IDirectMusicSegment *pSegment, IDirectMusicSegmentState *pSegState) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, %p, %p): stub\n", This, pSegment, pSegState); > return S_FALSE; > } > > Hi Michael, While you're at it, could you put a 4 spaces indentation to whole method. Christian

2 1

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface.
by Marvin 02 Apr '12

02 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17632 Your paranoid android. === WNT4WSSP6 (32 bit d3drm) === d3drm.c:467: Test failed: Invalid refcount. Expected 3 got 2 d3drm.c:475: Test failed: Invalid refcount. Expected 4 got 3 d3drm.c:477: Test failed: Invalid refcount. Expected 3 got 2

1 0

Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.
by Henri Verbeet 02 Apr '12

02 Apr '12

This looks wrong. Is there a legitimate way that this can happen?

2 3

Wine test bot and win16 exe
by Christian Costa 01 Apr '12

01 Apr '12

Hi, I wrote a win16 exe test file using open watcom but I cannot submit it to winebot. I fails saying "Unricognized file type". This is a little annoying. Is this a known limitation of wine test bot ? Thanks Christian

2 1

Re: d3dx9: Implement D3DXCreatePolygon
by Józef Kucia 01 Apr '12

01 Apr '12

On Sun, Apr 1, 2012 at 10:43 PM, David Adam <david.adam.cnrs(a)gmail.com> wrote: > + *mesh = polygon; > + > + if (adjacency) > + { > + hr = D3DXCreateBuffer(3 * sides * sizeof(DWORD), &adjacency_tmp); > + if (FAILED(hr)) return hr; You should release the polygon mesh. Also, you probably shouldn't touch *mesh when the function fails. -- Józef Kucia

1 0

Re: shell32: Added stubs for IMarshal interface (resend)
by Jacek Caban 01 Apr '12

01 Apr '12

Hi Gaurav, On 3/31/12 9:22 PM, Gaurav Jain wrote: > shell32: Added stubs for IMarshal interface (resend) > > Resending due to previous code freeze. > > ShellLink_QueryInterface() did not have a lookup for the IMarshal Interface. This resulted in an error message popping up in the Quest for Glory II (remake) installer. Providing IMarshal interface stubs avoids this error behaviour. > IMarshal is an interface that has serious impact on how the object is handled in RPC calls and the fact that you see better behavior in an app may be very well a side effect of Wine behaving badly, but in a different (more friendly for given application) way. The first question is does the object really implements custom IMarshal implementation on Windows? Cheers, Jacek

2 1

Re: [2/2] gdi32: Simplify font cache. (try 2)
by Alexandre Julliard 01 Apr '12

01 Apr '12

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -1516,23 +1464,8 @@ static void add_face_to_cache(Face *face) > RegSetValueExW(hkey_face, face_full_name_value, 0, REG_SZ, (BYTE*)face->FullName, > (strlenW(face->FullName) + 1) * sizeof(WCHAR)); > > - reg_save_dword(hkey_face, face_index_value, face->face_index); > - reg_save_dword(hkey_face, face_italic_value, (face->ntmFlags & NTM_ITALIC) != 0); > - reg_save_dword(hkey_face, face_bold_value, (face->ntmFlags & NTM_BOLD) != 0); > - reg_save_dword(hkey_face, face_version_value, face->font_version); > - reg_save_dword(hkey_face, face_external_value, face->external); > - > - RegSetValueExW(hkey_face, face_font_sig_value, 0, REG_BINARY, (BYTE*)&face->fs, sizeof(face->fs)); > + RegSetValueExW(hkey_face, face_value, 0, REG_BINARY, (BYTE*)face, sizeof *face); I don't think that's a good idea. There are many things in the structure that don't make sense to have in the registry. Also this won't work on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3dx9_36: Implement D3DXSHDot
by Rico Schüller 01 Apr '12

01 Apr '12

Am 01.04.2012 04:33, schrieb David Adam: + * Order is not limited by D3DXSH_MINORDER and D3DXSH_MAXORDER! + * All values will work, test from 0-7 [D3DXSH_MINORDER = 2, D3DXSH_MAXORDER = 6] + * Exceptions will show up when out, in1 or in2 are NULL + */ + for (k = 0; k < 8; k++) Where is the variable out? Cheers Rico

1 0

Re: msi: add support for MSIRUNMODE_REBOOTNOW in MsiGetMode
by Hans Leidekker 31 Mar '12

31 Mar '12

On Fri, 2012-03-30 at 17:27 -0700, Austin English wrote: > + case MSIRUNMODE_REBOOTNOW: > + r = package->need_reboot; > + break; > + MSIRUNMODE_REBOOTNOW and MSIRUNMODE_REBOOTATEND are not the same thing.

2 1

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard
by Jacek Caban 31 Mar '12

31 Mar '12

On 03/30/12 17:55, Aric Stewart wrote: > diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h > index 35cd52b..d2f680c 100644 > --- a/dlls/quartz/quartz_private.h > +++ b/dlls/quartz/quartz_private.h > @@ -38,7 +38,7 @@ > #define BYTES_FROM_MEDIATIME(time) SEC_FROM_MEDIATIME(time) > #define MSEC_FROM_MEDIATIME(time) ((time) / 10000) > > -#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) > +#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=CONTAINING_RECORD(iface, impl, field) These should disappear once the clean up of affected code is done. Cheers, Jacek

3 5

Re: Wine release 1.5.1
by mike＠yurick.ca 30 Mar '12

30 Mar '12

I am no longer using this e-mail. Please contact me for my new e-mail address. Thank you, Mike

1 0

Re: jscript: Fixed jsheap_grow implementation
by Marvin 30 Mar '12

30 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17589 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

[PATCH 3/3] dmsynth: Put port caps that match native ones.
by Joerg-Cyril.Hoehle＠t-systems.com 30 Mar '12

30 Mar '12

Hi, Andrew Eikum asked Christian Costa: >Just to be clear, which "native" do you mean? Does this match Windows >7's dmusic behavior, or something else? I've been trying to target >Windows 7's behavior in the new audio design. A w7 target makes a lot of sense for mmdevapi/WASAPI. However, isn't DMusic a thing of the past? In that case, I argue that DSound and DMusic should target the "best in class" native OS of the time where apps were written using these APIs, because the app writers "optimized" their apps to the behaviour they could observe. Wouldn't "best in class" mean XP for DSound/DMusic? For similar reasons, the MCI should mimic w9x(/wxp) behaviour, because that's what was available when apps using the MCI were developed. I prefer to hear "thank you guys, app X works like a charm in Wine like it worked on my rusty w98 and later xp box, whereas it refuses to run on w7" rather than "you guys do a great job of making my app X worked as badly in Wine as in w7 :-( whereas it used to work fine on my w98/xp machine". Actually, there are quite a few AppDB comments like the first one. One reason might be that the dlls those app use were added to Wine at a time where the target OS was w9x or xp, whereas if they were written now, targeting w7, the old app would not work in Wine either. A related topic is: we have no idea what the "set compatibility for wXY" checkbox in w7 does. Recently, I discovered that "Age of Empires II - Conquerors" only plays videos on a w7 machine when you set w7 to xp compatibility. Why? The rest of the app seems to work (except for the purple grass issue, which requires a particular DirectDraw compatibility registry entry in w7). Did AoE target w7 when it was written? Obviously not. Regards, Jörg Höhle

2 1

Re: jscript: Add VT_I2 support (try 2)
by Jacek Caban 30 Mar '12

30 Mar '12

Hi Alistair, On 03/30/12 12:29, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > jscript: Add VT_I2 support > hres = IDispatchEx_InvokeEx(dispex, id, ctx->lcid, flags, dp, retv, &ei->ei, &ctx->jscaller->IServiceProvider_iface); + if(SUCCEEDED(hres) && retv) + { + if(V_VT(retv) == VT_I2) + VariantChangeType(retv, retv, 0, VT_I4); + } Since the conversion here is trivial, why not do it directly? --- a/dlls/jscript/jsutils.c +++ b/dlls/jscript/jsutils.c @@ -191,6 +191,10 @@ HRESULT to_primitive(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, VARIANT *ret case VT_R8: *ret = *v; break; + case VT_I2: + V_VT(ret) = VT_I4; + V_I4(ret) = V_I2(v); + break; I thought the findings we've discussed off-list was that internal values should never be of VT_I2 types, so this should never happen. If it's not the case, I'd like to see a test case. +function TestVT_I2() +{ + varI2 = GetShort(); + num3 = 3 + + ok(getVT(varI2) === "VT_I4", "getVT(varI2) = " + getVT(varI2)); Please include getVT(GetShort()) test I've showed you. This eliminates a lot of flow of value. + if(!strcmp_wa(bstrName, "GetShort")) { + *pid = DISPID_GLOBAL_SHORT; + return S_OK; + } Please follow JavaScript names convention (this should be getShort). Cheers, Jacek

1 0

Re: [2/2] scrrun: Add scrrun tests (try 3)
by Marvin 30 Mar '12

30 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17581 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: gdi32: Add support for loading scalable font resources.
by Dmitry Timoshkov 30 Mar '12

30 Mar '12

Huw Davies <huw(a)codeweavers.com> wrote: > + if (size.u.LowPart < sizeof( *dos )) goto fail; Testing LowPart only could not work for large sizes. -- Dmitry.

2 2

Re: [PATCH 2/3] dmsynth: Check the rigth CLSID to create the DirectMusicSynthSink object.
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17568 Your paranoid android. === WNT4WSSP6 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2KPROSP4 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80004002 dmsynth.c:42: Test failed: CoCreateInstance returned: 80004002 === W2K3R2SESP2 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2K8SE (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154

1 0

Re: [PATCH 1/3] dmsynth: Add basic tests.
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17567 Your paranoid android. === WNT4WSSP6 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2KPROSP4 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80004002 dmsynth.c:42: Test failed: CoCreateInstance returned: 80004002 === W2K3R2SESP2 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2K8SE (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154

1 0

Re: [PATCH 3/3] d3drm: Implement CreateMesh method and stubbed IDirect3DRMMesh interface.
by Michael Stefaniuc 29 Mar '12

29 Mar '12

Hello Christian, On 03/29/2012 11:57 PM, Christian Costa wrote: > +HRESULT Direct3DRMMesh_create(REFIID riid, IUnknown** ppObj) > +{ > + IDirect3DRMMeshImpl* object; > + > + TRACE("(%p)\n", ppObj); > + > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirect3DRMMeshImpl)); > + if (!object) > + { > + ERR("Out of memory\n"); > + return E_OUTOFMEMORY; > + } > + > + object->IDirect3DRMMesh_iface.lpVtbl = &Direct3DRMMesh_Vtbl; > + object->ref = 1; > + > + if (IsEqualGUID(riid, &IID_IDirect3DRMMesh)) > + *ppObj = (IUnknown*)&object->IDirect3DRMMesh_iface; > + else > + *ppObj = (IUnknown*)&object->IDirect3DRMMesh_iface; both if and else code path are the same. > + > + return S_OK; > +} > + bye michael

2 1

Would like to get some feedback on GSOC idea
by M C 29 Mar '12

29 Mar '12

Hi everyone, My name is Marek Chmiel, I am a student a NEIU. I am studying computer science and network security related topics. This semester I had spent a fair amount of time writing crypt related functions with java, and became very interested in Cryptography. After looking over the suggested ideas on SOC official wine wiki I was pleasantly surprised to see that there was already a crypt related idea suggested. I have a great understanding of c++ and java, and though I know c I have not worked with it as much as the other languages. Implementing a DSS provider sounds like an awesome task to tackle, if someone has never written code for Linux, can they take on such a task? Are there any significant issues implementing a DSS that you guys know about? Any crypt GSOC ideas would you suggest for someone who has wrote limited amount of code for Linux? What I would also like to do, besides implementing a DSS provider, is to fix most if not all of the crypt related bugs that remain in Wine. This might seem like more than most people can chew, but viewing the Bug Tracking database it appears that there aren't that many crypt related bugs and might even be caused by a lack of a DSS provider (Hopefully this wouldn't create a entire new series of bugs). Thanks for any input I might receive, and look forward to speaking with you all. I can also be found on the irc for development with the nick "MarcoVonChmiel". Marek K Chmiel.

2 1

Implementing a DSS provider
by M C 29 Mar '12

29 Mar '12

Hello everyone, I am doing some research in regards GSOC, and would like to find out if anyone besides Juan Lang is experienced enough to make suggestions in regards to bug 10506 and/or the implementation of a DSS provider.

1 0

Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.
by Alexandre Julliard 29 Mar '12

29 Mar '12

Christian Costa <titan.costa(a)gmail.com> writes: > With this patch I get exactly the same output for ports caps (except guid) as native. > I kept the comment regarding dmusic32 usage altough the native version > of dmusic I used does standard winmm calls to get port informations. > --- > dlls/dmusic/Makefile.in | 2 - > dlls/dmusic/dmusic.c | 120 ++++++++++++++++++++++++++++++++--------------- > 2 files changed, 82 insertions(+), 40 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dmime.dll -T ../../.. -p dmime_test.exe.so performance.c && touch performance.ok performance.c:111: Test failed: Got unexpected portcaps struct size: 00000004 make[1]: *** [performance.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: MsiGetFileHash
by Hans Leidekker 29 Mar '12

29 Mar '12

On Thu, 2012-03-29 at 18:29 +0200, Robert van Herk wrote: > + mapping = CreateFileMappingW( handle, NULL, PAGE_READONLY, 0, 0, NULL ); > + if (mapping) > + { > + p = MapViewOfFile( mapping, FILE_MAP_READ, 0, 0, length ); > + if (p) > + { > + MD5_CTX ctx; > + > + MD5Init( &ctx ); > + MD5Update( &ctx, p, length ); > + MD5Final( &ctx ); > + UnmapViewOfFile( p ); > + > + memcpy( pHash->dwData, ctx.digest, sizeof pHash->dwData ); > + r = ERROR_SUCCESS; > + } > + CloseHandle( mapping ); > + } > + } else { > + /* Empty file -> set hash to 0 */ > + memset( pHash->dwData, 0, sizeof pHash->dwData ); > + r = ERROR_SUCCESS; > } > + > CloseHandle( handle ); Please use 4 space indentation and put brackets on a new line like in the rest of that function. Same for the test. Please also provide a more descriptive subject line and prefix it with "msi: "

1 0

SoC 2012 Ideas
by Charles Davis 29 Mar '12

29 Mar '12

Hi, Since I graduate this year, this may be the last time I participate--or at least, attempt to participate, since last year didn't quite work out for me :(--in Summer of Code. (I realize I was supposed to email you last week, but what's done is done.) So, without further ado, here's what I'm proposing: 1) Make Wine use App Sandbox on Mac OS X. A project that used to be listed on the SoC ideas page was to implement proper sandboxing in Wine. Apparently, you think this is unrealistic, because you took it down. (Not the page, just that suggestion.) But, I think that if I narrowed my focus a bit, it could be possible to do this. I'm proposing using the Mac OS App Sandbox API--the beginnings of which were introduced in 10.5 and which came into its own in 10.7--to improve security of Wine on Mac OS. Wine is an excellent candidate for the App Sandbox, because most of its file-system activity is limited to a single directory--namely, the Wine prefix. I'm not sure what you think of this, though, so I'm throwing this out there to get feedback. At the very least, I would like to be able to limit Wine's file-system activity to the prefix. 2) HLSL compiler. Well, my D3D bytecode backend to LLVM didn't pan out like I'd hoped. Maybe an LLVM-based compiler is too complex for Wine right now. But perhaps we don't need it right now anyway. If CodeWeavers can't afford to pay me, maybe Google can. I can add a simple parser and compiler (that performs little or no optimization) that hopefully would be sufficient for Wine's purposes. 3) Integrate pieces of DCE/RPC into Wine. As you may or may not know, in Mac OS 10.7, Apple stopped using Samba (probably because it uses the GPL3 as its license) in favor of their own implementation--which just so happens to be based on the original DCE/RPC implementation (the same one that was used as a base for MS RPC). I figured we could cannibalize pieces of it for our own use. Or is that not acceptable? What do you think? I'm not sure how useful or feasible these are, so I'm posting to the list before. Chip

2 1

Re: [PATCH 3/3] (try2) gdi32: Add support for loading scalable font resources.
by Alexandre Julliard 29 Mar '12

29 Mar '12

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/gdi32/font.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 75 insertions(+), 0 deletions(-) This one doesn't build: gcc -m32 -c -I. -I. -I../../include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2 -g -O2 -o font.o font.c font.c: In function ‘AddFontResourceExW’: font.c:3498:59: error: ‘count’ may be used uninitialized in this function [-Werror=uninitialized] font.c:3475:36: note: ‘count’ was declared here cc1: all warnings being treated as errors make[1]: *** [font.o] Error 1 Admittedly count would always be initialized with the files we create, but we probably shouldn't rely on that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.
by Andrew Eikum 29 Mar '12

29 Mar '12

On Thu, Mar 29, 2012 at 08:52:45AM +0200, Christian Costa wrote: > + midiOutGetDevCapsW(index - 1, &caps, sizeof(caps)); > ... > + CoCreateInstance(&CLSID_DirectMusicSynth, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectMusicSynth8, (void**)&synth); > + IDirectMusicSynth8_GetPortCaps(synth, port_caps); Maybe I'm pickier than most people, but I like error checking on these sorts of calls. They make it easier to find what is happening when something goes terribly and unexpectedly wrong.

2 2

Re: [PATCH 5/5] dmusic: Implement partially SetDirectSound.
by Andrew Eikum 29 Mar '12

29 Mar '12

It would be nice to see some tests for this. For example, how does this IDirectSound reference relate to the one created by IDirectMusicPerformance::InitAudio()? On Thu, Mar 29, 2012 at 08:53:10AM +0200, Christian Costa wrote: > > --- > dlls/dmusic/dmusic.c | 27 +++++++++++++++++++++------ > dlls/dmusic/dmusic_private.h | 2 ++ > 2 files changed, 23 insertions(+), 6 deletions(-) > > diff --git a/dlls/dmusic/dmusic.c b/dlls/dmusic/dmusic.c > index 8f2edea..60d6b8a 100644 > --- a/dlls/dmusic/dmusic.c > +++ b/dlls/dmusic/dmusic.c > @@ -52,19 +52,22 @@ static ULONG WINAPI IDirectMusic8Impl_AddRef (LPDIRECTMUSIC8 iface) { > return refCount; > } > > -static ULONG WINAPI IDirectMusic8Impl_Release (LPDIRECTMUSIC8 iface) { > +static ULONG WINAPI IDirectMusic8Impl_Release(LPDIRECTMUSIC8 iface) > +{ > IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > ULONG refCount = InterlockedDecrement(&This->ref); > > TRACE("(%p)->(ref before=%u)\n", This, refCount + 1); > > if (!refCount) { > + if (This->dsound) > + IDirectSound_Release(This->dsound); > HeapFree(GetProcessHeap(), 0, This->ppPorts); > HeapFree(GetProcessHeap(), 0, This); > } > > DMUSIC_UnlockModule(); > - > + > return refCount; > } > > @@ -257,10 +260,22 @@ static HRESULT WINAPI IDirectMusic8Impl_GetDefaultPort (LPDIRECTMUSIC8 iface, LP > return S_OK; > } > > -static HRESULT WINAPI IDirectMusic8Impl_SetDirectSound (LPDIRECTMUSIC8 iface, LPDIRECTSOUND pDirectSound, HWND hWnd) { > - IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > - FIXME("(%p, %p, %p): stub\n", This, pDirectSound, hWnd); > - return S_OK; > +static HRESULT WINAPI IDirectMusic8Impl_SetDirectSound(LPDIRECTMUSIC8 iface, LPDIRECTSOUND dsound, HWND wnd) > +{ > + IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > + > + FIXME("(%p, %p, %p): partial implementation\n", This, dsound, wnd); > + > + if (dsound) > + { > + This->dsound = dsound; > + IDirectSound_AddRef(dsound); > + } > + > + /* If no direct sound object is given, native does not create one yet */ > + This->dsound_inited = TRUE; > + > + return S_OK; > } > > static HRESULT WINAPI IDirectMusic8Impl_SetExternalMasterClock (LPDIRECTMUSIC8 iface, IReferenceClock* pClock) { > diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h > index c05adf0..b0655d6 100644 > --- a/dlls/dmusic/dmusic_private.h > +++ b/dlls/dmusic/dmusic_private.h > @@ -96,6 +96,8 @@ struct IDirectMusic8Impl { > IReferenceClockImpl* pMasterClock; > IDirectMusicPort** ppPorts; > int nrofports; > + BOOL dsound_inited; > + IDirectSound* dsound; > }; > > /***************************************************************************** > > >

2 1

Re: [PATCH 3/3] dmsynth: Put port caps that match native ones.
by Andrew Eikum 29 Mar '12

29 Mar '12

Just to be clear, which "native" do you mean? Does this match Windows 7's dmusic behavior, or something else? I've been trying to target Windows 7's behavior in the new audio design. Also... On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote: > - obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB | DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY; > + obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB; /* DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY */ I'd just remove the unused flags. No need for crufty comments.

2 1

Re: po: Update German translation
by Julian Rüger 29 Mar '12

29 Mar '12

Hi André, Am Dienstag, den 27.03.2012, 21:43 +0200 schrieb André Hentschel: > --- > po/de.po | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > #: jscript.rc:37 >-#, fuzzy > #| msgid "Invalid parameter.\n" > msgid "Invalid character" >-msgstr "Ungültiger Parameter.\n" >+msgstr "Ungültiges Zeichen" du solltest die alte msgid auch entfernen. (Ist ein neues Feature, wurden schon andere drauf hingewiesen ;) Viele Grüsse, Julian

2 2

Re: [PATCH 1/2] vbscript: Added Mid function implementation
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17548 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Added Mid function implementation
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17548 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

SoC 2012 Ideas
by Joerg-Cyril.Hoehle＠t-systems.com 29 Mar '12

29 Mar '12

Charles Davis wrote: >1) Make Wine use App Sandbox on Mac OS X. >At the very least, I would like to be able to limit Wine's file-system activity to the prefix. I'm not familiar with Mac OS X' particular security features, but I wonder why limiting FS activity needs changes in wine? With AppArmor or the like on Linux, you'd define a set of rules living outside of the app. Limiting to the prefix won't work, because /dev/tty and /tmp/X11.socket etc. need be used. All my apps are installed in a directory outside any .wine prefix. There's a symlink from within C:\Programs. How would you take that into account? BTW, I once defined a set of iptable rules to prevent networking for Wine (or was it for a whole user?) based on the consideration that the apps I use have nothing to do with networking. Here too, nothing need be changed in Wine. Regards, Jörg Höhle

2 1

Re: [PATCH 2/3] dmsynth: Check the rigth CLSID to create the DirectMusicSynthSink object.
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17544 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] dmsynth: Add basic tests.
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17543 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] dmsynth: Add basic tests.
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17543 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] dmusic: Add some tests for enumerating and creating ports.
by Marvin 29 Mar '12

29 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17542 Your paranoid android. === WNT4WSSP6 (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80040154 dmusic: unhandled exception c0000005 at 00401347 === W2KPROSP4 (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80004002 dmusic: unhandled exception c0000005 at 00401347 === W2K3R2SESP2 (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80040154 dmusic: unhandled exception c0000005 at 00401347 === WVISTAADM (32 bit dmusic) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W2K8SE (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80040154 dmusic: unhandled exception c0000005 at 00401347

1 0

Re: winspool.drv: Update allowed driver Version
by Marvin 28 Mar '12

28 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17541 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

RFC: Duplicate in/out device naming
by Andrew Eikum 28 Mar '12

28 Mar '12

I'm working on Bug 14559 and have run into an interesting UI problem. In WinMM, there are three "classes" of devices: waveIn, waveOut, and mixer. Windows 7's WinMM implementation provides one mixer for each waveIn and waveOut device. The "WCHAR caps.szPname[32]" field for the matching mixer and waveIn/Out device are the same. Some applications, in this case Rosetta Stone 3, use the matching szPname fields to determine which mixer to associate with which device. The problem turns up when we have duplicate input and output device names. Consider: waveOut: 0: default 1: HDA Intel Analog 2: HDA Intel Digital waveIn: 0: default 1: HDA Intel Analog mixer: 0: default 1: HDA Intel Analog 2: HDA Intel Digital 3: default 4: HDA Intel Analog Rosetta Stone chooses waveIn[0] and starts iterating over the mixers' szPname fields, finding that mixer[0] matches. But, mixer[0] is actually associated with the waveOut default, not the waveIn default. Bad things happen. Windows 7 solves this problem implicitly by providing unique device names at the MMDevAPI level. For instance, the input device is Microphone and the output devices are Stereo and Headphones. Hacking the registry to force duplicate MMDevAPI device names actually does result in duplicate mixer names. But Wine's backends don't provide this kind of information, so we simply provide the ALSA device name as the device's name. As an attempt to solve this in Wine, I added a prefix to each MMDevice indicating its flow direction. The unique identifier must be a prefix, as WinMM's szPname field truncates at 31 characters. This gives WinMM device names like: waveOut: 0: Out: default 1: Out: HDA Intel Analog 2: Out: HDA Intel Digital This solves the Rosetta Stone issue, as you can see in the bug. But when testing this in other applications, it quickly becomes silly. Audacity 1.3 adds its own "Out: " prefix to WinMM device names, creating "Out: Out: default" in the UI. Dynamically adding prefixes only if a duplicate device is present causes issues with duplicates appearing/disappearing. Trying to remember if a duplicate has ever been present is quite "ugly" in code, requiring storing that kind of information in the registry. So I don't know what to do. Have ugly, redundant device names? Leave Rosetta Stone broken, as it is arguably an application bug? Try to guess at the device type, and insert names like "Speakers" and "Microphone" into the MMDevAPI device name, even if that might be wrong? Thoughts? Andrew

3 2

Re: [2/4] scrrun: Register Scripting interfaces (try 2)
by Alexandre Julliard 28 Mar '12

28 Mar '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -4,4 +4,6 @@ C_SRCS = scrrun.c > > RC_SRCS = scrrun.rc > > +IDL_TLB_SCRS = scrrun.idl This can't possibly do anything. I've fixed it up, but please test your code before sending, it's not the first time you send a registration patch that doesn't register anything. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] strmbase: Display dll in which we are searching a class to instanciate.
by Alexandre Julliard 28 Mar '12

28 Mar '12

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -360,14 +361,17 @@ HRESULT WINAPI STRMBASE_DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID * > break; > } > > + if (!GetModuleFileNameA(g_hInst, dllname, sizeof(dllname))) > + strcpy(dllname, "???"); You don't want to do that in the success case. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: strmbase: add beginnings of BaseWindow
by Alexandre Julliard 28 Mar '12

28 Mar '12

Aric Stewart <aric(a)codeweavers.com> writes: > +HRESULT WINAPI BaseWindow_Destroy(BaseWindow *This) > +{ > + if (This->hWnd) > + BaseWindowImpl_DoneWithWindow(This); > + > + UnregisterClassW(This->pClassName, NULL); You most likely don't want to unregister the class every time. > + wnd_class_registered = GetClassInfoW(This->hInstance, This->pClassName, > + &winclass); > + > + if (!wnd_class_registered) > + { There shouldn't be any reason to do this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] winex11: Use GLX_DONT_CARE instead of ~0 in ConvertAttribWGLtoGLX().
by Chris Robinson 28 Mar '12

28 Mar '12

On Tuesday, March 27, 2012 8:35:49 PM Henri Verbeet wrote: > - int pixelattrib = ~0; > + int pixelattrib = GLX_DONT_CARE; I want to say there's a reason we used ~0 instead of GLX_DONT_CARE, but it's been too long that I can't remember. I think it was because GLX_DONT_CARE didn't include all possibilities that ~0 would, like what WGL wanted.

2 1

Re: [4/4] scrrun: Add scrrun tests (try 2)
by Marvin 28 Mar '12

28 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17522 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel