- wine-devel - winehq.org

Re: [PATCH 2/2] mshtml: Added tests of handling ActiveX objects without IQuickActivate interface implemented
by Alexandre Julliard 17 Nov '11

17 Nov '11

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/tests/activex.c | 133 > ++++++++++++++++++++++++++++++------------ > 1 files changed, 95 insertions(+), 38 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so activex.c && touch activex.ok wine: Unhandled page fault on read access to 0x00000008 at address 0x6a76d2a6 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x6a76d2a6). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6a76d2a6 ESP:0032fab0 EBP:0032fac8 EFLAGS:00010206( R- -- I - -P- ) EAX:01824650 EBX:00000000 ECX:00000008 EDX:00000000 ESI:01824650 EDI:00000000 Stack dump: 0x0032fab0: 01824650 6ad31584 0182459c 018244c8 0x0032fac0: 018244c8 00000000 0032faf8 6a45f2cd 0x0032fad0: 018244c8 00000003 6ad316db 00000000 0x0032fae0: 018244c8 0032fb28 001ab708 01828bd8 0x0032faf0: 0171af60 00000000 0032fb48 6a4b7d29 0x0032fb00: 018244c8 00000000 0032fb28 6a617b0f Backtrace: =>0 0x6a76d2a6 in xul (+0xb2d2a6) (0x0032fac8) 1 0x6a45f2cd in xul (+0x81f2cc) (0x0032faf8) 2 0x6a4b7d29 in xul (+0x877d28) (0x0032fb48) 3 0x6a4b9648 in xul (+0x879647) (0x0032fb98) 4 0x6a4b73db in xul (+0x8773da) (0x0032fbc8) 5 0x555e04e7 NSContainer_Release+0x76(This=0x17978b8) [/home/julliard/wine/wine/dlls/mshtml/nsembed.c:1886] in mshtml (0x0032fbf8) 6 0x55585435 CustomDoc_Release+0x1c4(iface=0x135c8c) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2315] in mshtml (0x0032fc38) 7 0x5557f2e4 HTMLDocument_Release+0x13(iface=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:433] in mshtml (0x0032fc58) 8 0x687657a4 release_doc+0x23(doc=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:1945] in mshtml_test (0x0032fc78) 9 0x6876a445 func_activex+0x18b4() [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:2060] in mshtml_test (0x0032fd58) 10 0x68763202 main+0x3a1(argc=*** Invalid address 0x00000008 *** , argv=*** Invalid address 0x0000000c *** Internal symbol error: unable to access memory location 0xc) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe28) 11 0x687becf5 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fe70) 12 0x6848858c call_process_entry+0xb() in kernel32 (0x0032fe88) 13 0x6848953f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1090] in kernel32 (0x0032fec8) 14 0x68375dd0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 15 0x68378abd call_thread_func+0x7c(entry=0x684894e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 16 0x68375dae call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 17 0x6834dece start_process+0x1d(kernel_start=0x684894e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 18 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x6a76d2a6: call *0x8(%edx) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dinput: Delete the static critical section when unloading the dll.
by Vitaliy Margolen 17 Nov '11

17 Nov '11

On 11/16/2011 08:31 AM, Francois Gouget wrote: > --- > > I moved DllMain() to the end of the file so it comes after the variable > declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead. Hm... it seems this patch already committed. Alexadre, would you please give people at least 24 hours to review all patches sent to wine-patches before committing them? Vitaliy.

3 3

re: added remaining functions, data structures, definitions required by http api to include/http.h
by Dan Kegel 17 Nov '11

17 Nov '11

That's a lot of stuff. What needs it? Also, please avoid trivial whitespace changes.

2 1

Re: added remaining functions, data structures, definitions required by http api to include/http.h
by Frédéric Delanoy 16 Nov '11

16 Nov '11

On Wed, Nov 16, 2011 at 14:15, ArasH <arash.cordi(a)gmail.com> wrote: > --- > include/http.h | 1266 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 1251 insertions(+), 15 deletions(-) The patch should show your full name. See http://wiki.winehq.org/SubmittingPatches for more information.

1 0

Re: mshtml: Fixed some htmldoc.c tests on IE9
by Marvin 16 Nov '11

16 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15467 Your paranoid android. === TEST64_W7SP1 (32 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 === TEST64_W7SP1 (64 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37

2 1

Re: [PATCH 1/1] user32: Prioritize focus for dialog owner on EndDialog (resend).
by Marvin 16 Nov '11

16 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15456 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [PATCH 2/5] d3d10: Implement D3D10StateBlockMaskDisableCapture().
by Matteo Bruni 15 Nov '11

15 Nov '11

2011/11/15 Henri Verbeet <hverbeet(a)codeweavers.com>: > --- > + UINT end = start_idx + count; > + start_idx += 7; > + memset(&field[start_idx >> 3], 0, (end >> 3) - (start_idx >> 3)); Isn't that dangerous if count is < 7 (assuming that is a valid value)?

1 0

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc
by Henri Verbeet 15 Nov '11

15 Nov '11

On 15 November 2011 00:12, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Tests show that only LPSURFACE and PIXELFORMAT can be set, and LPSURFACE is required > + * for PIXELFORMAT to work */ This may be ok, but note that the test doesn't actually test this. (E.g. does calling SetSurfaceDesc() with the original surface desc work? What about bits not in DDSD_ALL? Etc.) Also, as a general principle, I'd be happier about the ddraw tests if they actually tested all the different interface versions.

2 4

RFH: Solaris users with IPv6
by Juan Lang 15 Nov '11

15 Nov '11

Hi all, in the tidy up I've been doing to iphlpapi, I notice that on Solaris it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got a patch written that does that, but I have no way to test it myself. If anyone here has some version of Solaris with a machine with IPv6 addresses, even autoconfigured ones, and feels like testing a patch, please let me know. I'll send the patch and a small test program. Thanks, --Juan

2 1

Re: (resend)[5/6]usp10: Devanagari danda and double danda are use for all Indic scripts
by Henri Verbeet 15 Nov '11

15 Nov '11

That's a fair amount of magic constants in there. The ones in is_indic() are probably Script_Devanagari and Script_Malayalam_Numeric, I didn't look at the other two.

2 1

Re: [4/6] msxml3/dom: Properly return node prefix from get_prefix()
by Jacek Caban 15 Nov '11

15 Nov '11

Hi Nikolay, On 11/15/11 07:19, Nikolay Sivov wrote: > - if ((ns = xmlGetNsList(This->node->doc, This->node))) > + switch (This->node->type) > { > - if (ns[0]->prefix) *prefix = bstr_from_xmlChar( ns[0]->prefix ); > - xmlFree(ns); > + case XML_ELEMENT_NODE: > + case XML_ATTRIBUTE_NODE: > + { > + xmlNsPtr ns = This->node->ns; > + if (ns&& ns->prefix) > + *prefix = bstr_from_xmlChar(ns->prefix); > + break; > } > + default: > + FIXME("unsupported type %d\n", This->node->type); > + }; The idea behind node inheritance rewrite was to avoid such switches. If other node types should be handled differently, they simply shouldn't use node_get_prefix or the differences should be moved to child objects. Jacek

2 1

Re: msvcrt: Don't hold FILE critical section in some functions
by Alexandre Julliard 15 Nov '11

15 Nov '11

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -3117,25 +3098,20 @@ int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) > */ > int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) > { > - MSVCRT__lock_file(file); > - > /* Flush output buffer */ > if(file->_bufsiz == 0 && !(file->_flag & MSVCRT__IONBF)) { > msvcrt_alloc_buffer(file); > } > if(!(file->_flag & MSVCRT__IOWRT)) { > - if(file->_flag & MSVCRT__IORW) { > + if(file->_flag & MSVCRT__IORW) > file->_flag |= MSVCRT__IOWRT; > - } else { > - MSVCRT__unlock_file(file); > + else That doesn't look safe. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: wininet: Give a name to the critical sections, make them static and delete them when unloading the dll.
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15430 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [4/4] ddraw: Size handling fixes for IDirect3DDevice::GetDesc
by Henri Verbeet 15 Nov '11

15 Nov '11

On 15 November 2011 00:13, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!HWDesc) > + { > + WARN("HWDesc is NULL, returning DDERR_INVALIDPARAMS.\n"); > + return DDERR_INVALIDPARAMS; > + } > + else if(!check_d3ddevicedesc_size(HWDesc->dwSize)) > + { > + WARN("HWDesc->dwSize is %u, returning DDERR_INVALIDPARAMS.\n", HWDesc->dwSize); > + return DDERR_INVALIDPARAMS; > + } > + else if (!HelDesc) > + { > + WARN("HelDesc is NULL, returning DDERR_INVALIDPARAMS.\n"); > + return DDERR_INVALIDPARAMS; > + } > + else if(!check_d3ddevicedesc_size(HelDesc->dwSize)) > + { > + WARN("HelDesc->dwSize is %u, returning DDERR_INVALIDPARAMS.\n", HelDesc->dwSize); > + return DDERR_INVALIDPARAMS; > + } The "else" is redundant here. Please use consistent formatting. > + hw_caps.dwSize = sizeof(hel_caps) + 1; Strictly speaking that should be "sizeof(hw_caps) + 1". > + case 172: /* DirectX 3, IDirect3DDevice1 */ > + ok(hw_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hw_caps.dwMaxTextureRepeat); > + ok(hel_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hel_caps.dwMaxTextureRepeat); > + /* drop through */ > + case 204: /* DirectX 5, IDirect3DDevice2 */ > + ok(hw_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hw_caps.dwMaxTextureRepeat); > + ok(hel_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hel_caps.dwMaxTextureRepeat); This doesn't make a lot of sense, both cases are the same.

1 0

Re: wined3d: Disable WINED3DFMT_B8G8R8_UNORM.
by Stefan Dösinger 15 Nov '11

15 Nov '11

On Tuesday 15 November 2011 14:21:09 Matteo Bruni wrote: > + case WINED3DFMT_B8G8R8_UNORM: /* Usable in <=dx7 but not > enumerated in any case */ > + TRACE_(d3d_caps)("[FAILED] - Not enumerated on Windows\n"); > + return FALSE; The comment "Usable in <=dx7" is misleading. If I remember correctly your attempts at writing a test showed that systemmem surfaces can be created, but not video memory surfaces. I wouldn't be surprised if d3d8/9 also allow systemmem or scratch B8G8R8 surfaces. You can also remove the special handling for D3DFMT_R8G8B8 from d3d8/9's CheckDeviceFormat handling implementation now that wined3d doesn't report it as supported.

1 0

Re: [PATCH 1/2] ntdll: windows refuses to load an image, if sections overlap the header size as given in the SizeOfHeaders field (resend)
by Alexandre Julliard 15 Nov '11

15 Nov '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > --- > dlls/kernel32/tests/loader.c | 79 ++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/virtual.c | 5 +++ > 2 files changed, 84 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c > index 4d420ea..bcef492 100644 > --- a/dlls/kernel32/tests/loader.c > +++ b/dlls/kernel32/tests/loader.c > @@ -692,9 +692,88 @@ static void test_section_access(void) > } > } > > +static void test_section_mapping(void) > +{ > + static const char filler[0x2000]; > + static const char section_data[] = "section data 1234567890"; > + DWORD total, written; > + HANDLE hfile; > + HMODULE hlib; > + SYSTEM_INFO si; > + char temp_path[MAX_PATH]; > + char dll_name[MAX_PATH]; > + BOOL ret; > + > + GetSystemInfo(&si); > + > + /* prevent displaying of the "Unable to load this DLL" message box */ > + SetErrorMode(SEM_FAILCRITICALERRORS); > + > + GetTempPath(MAX_PATH, temp_path); > + > + GetTempFileName(temp_path, "ldr", 0, dll_name); Please merge that test case into the existing loader tests instead of adding a new function to do the same thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 11/12] mshtml: Added more navigation tests
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15423 Your paranoid android. === TEST64_W7SP1 (32 bit htmldoc) === htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2692: Test failed: unexpected command 6058 htmldoc.c:4725: Test failed: expected Invoke_AMBIENT_PALETTE htmldoc.c:4726: Test failed: expected GetOptionKeyPath htmldoc.c:2702: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2789: Test failed: unexpected command 143 htmldoc.c:1704: Test failed: unexpected call SetStatusText === TEST64_W7SP1 (64 bit htmldoc) === htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2692: Test failed: unexpected command 6058 htmldoc.c:4725: Test failed: expected Invoke_AMBIENT_PALETTE htmldoc.c:4726: Test failed: expected GetOptionKeyPath htmldoc.c:2702: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2789: Test failed: unexpected command 143 htmldoc.c:1704: Test failed: unexpected call SetStatusText

2 1

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try3)
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15426 Your paranoid android. === WVISTAADM (32 bit userenv) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try2)
by Alexandre Julliard 15 Nov '11

15 Nov '11

Piotr Caban <piotr(a)codeweavers.com> writes: > +static void set_wow64_environment(WCHAR **env) > +{ > + static const WCHAR archW[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','C','T','U','R','E',0}; > + static const WCHAR arch6432W[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','W','6','4','3','2',0}; This stuff needs to be done depending on the 32/64 architecture of the child process, so it probably shouldn't be done here. The variables will be reset on every process startup anyway. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] urlmon: Improve parsing of SCHEME_MK URIs
by Jacek Caban 15 Nov '11

15 Nov '11

Hi Andrew, On 11/14/11 21:12, Andrew Eikum wrote: > --- > dlls/urlmon/tests/uri.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++ > dlls/urlmon/uri.c | 15 +++++++-- > 2 files changed, 93 insertions(+), 3 deletions(-) The patch looks good to me, but could you please add a simpler test using CreateUri (using uri_tests array) as follow up. Thanks, Jacek

1 0

Re: ws2_32: Fix handling of NULL and empty hostname in getaddrinfo/GetAddrInfoW.
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15418 Your paranoid android. === WNT4WSSP6 (32 bit sock) === Timeout === W2KPROSP4 (32 bit sock) === Timeout

1 0

Re: [PATCH 2/5] d3d10: Add a stub ID3D10StateBlock implementation.
by Nikolay Sivov 15 Nov '11

15 Nov '11

On 11/14/2011 23:11, Henri Verbeet wrote: > +static ULONG STDMETHODCALLTYPE d3d10_stateblock_Release(ID3D10StateBlock *iface) > +{ > + struct d3d10_stateblock *stateblock = impl_from_ID3D10StateBlock(iface); > + ULONG refcount = InterlockedIncrement(&stateblock->refcount); > + > + TRACE("%p decreasing refcount to %u.\n", stateblock, refcount); > + > + if (!refcount) > + HeapFree(GetProcessHeap(), 0, stateblock); > + > + return refcount; > +} Decrement maybe?

1 0

Vista/w2k8/w7 users, please test mmdevapi with exclusive mode disabled
by Joerg-Cyril.Hoehle＠t-systems.com 14 Nov '11

14 Nov '11

Hi, Please test mmdevapi again using testbot job #15369 with exclusive mode disabled. Brian, it seems like you had some other app use audio while performing the tests. This would explain the DEVICE_IN_USE error: render.c:427: Test failed: Initialize(exclus., 8000x 8x1) returns 8889000a and the subsequent crash. My new version of the tests should prevent crashes in such a situation. Saulius, you need not perform many tests because of random GetPosition/Padding failures. I've not yet changed that part of the tests. Thank you for repeated testing, Jörg Höhle

2 1

Re: winemaker: Be less picky when detecting the target type
by Francois Gouget 14 Nov '11

14 Nov '11

On Fri, 11 Nov 2011, André Hentschel wrote: > seen some "broken" project files which still worked with msvc but not with winemaker > --- > tools/winemaker | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/winemaker b/tools/winemaker > index 2ee79ea..921f8ef 100755 > --- a/tools/winemaker > +++ b/tools/winemaker > @@ -589,16 +589,16 @@ sub source_scan_project_file($$$) > #print $prj_name; > next; > } elsif (/^# TARGTYPE/) { > - if (/[[:space:]]0x0101$/) { > + if (/0x.*101$/) { The various .* worry me a bit. Would something like [0-9a-fA-F]* be permissive enough? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

2 1

Re: [1/5]usp10: break with a better understanding on the handling of bidi strengths
by Alexandre Julliard 14 Nov '11

14 Nov '11

Aric Stewart <aric(a)codeweavers.com> writes: > + if (strength) > + { > + str = strength[cnt]; > + if (pwcInChars[cnt] == Numeric_space) > + str_space = TRUE; > + else > + str_space = FALSE; > + } str_space is not used for anything. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: taskmgr: Give a name and statically initialize PerfDataCriticalSection.
by Francois Gouget 14 Nov '11

14 Nov '11

On Mon, 14 Nov 2011, Francois Gouget wrote: [...] > static CRITICAL_SECTION PerfDataCriticalSection; > +static CRITICAL_SECTION_DEBUG PerfDataCriticalSection_debug = > +{ > + 0, 0, &PerfDataCriticalSection, > + { &PerfDataCriticalSection_debug.ProcessLocksList, &PerfDataCriticalSection_debug.ProcessLocksList }, > + 0, 0, { (DWORD_PTR)(__FILE__ ": PerfDataCriticalSection") } > +}; [...] > + PerfDataCriticalSection.DebugInfo->Spare[0] = 0; > DeleteCriticalSection(&PerfDataCriticalSection); Actually I think unsetting Spare[0] is wrong for statically initialized critical sections because it causes RtlDeleteCriticalSection() to do an RtlFreeHeap() on DebugInfo which happens to also be statically allocated. So I'll rework this patch and some of my previous patches. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: dlls: Remove unneeded include directives in resource files.
by Marvin 14 Nov '11

14 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15373 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

re: [PATCH] ntdll: Use VALGRIND_RESIZEINPLACE_BLOCK when available
by Dan Kegel 12 Nov '11

12 Nov '11

You might want to compare with Bart's patch for the same thing, http://www.winehq.org/pipermail/wine-patches/2011-April/100570.html Bart asked for comments on it, but didn't get much feedback: http://www.winehq.org/pipermail/wine-devel/2011-May/090029.html My guess is changes like this are really hard to get in unless you can get Alexandre's full attention somehow. Maybe if it was demonstrated to find interesting bugs in wine...

1 0

Re: Include math.h in d3dx9math.inl as it uses sqrt().
by Henri Verbeet 12 Nov '11

12 Nov '11

Does the Microsoft header include math.h?

4 4

Re: d3dx9 [patch 1/2, try 4]: Implement D3DXCreatePolygon
by Rico Schüller 11 Nov '11

11 Nov '11

Am 10.11.2011 10:59, schrieb David Adam: > Hello, > > I tried to fix the remaining issues pointed by Matteo and Rico. > I kept the style of Misha Koshelev who already implemented many shapes in > the mesh.c file. > > Any more suggestions? > > David > > > Hi David, I still have some suggestions. Please review all TRACE and ok messages. I think they should mostly end with '\n' and they should not contain "useless" chars like ':' and spaces where not needed. Also you may save the ref value from the call before you compare it: + IDirect3DDevice9_Release(device); + ok(ref == 0, "Expected refcount = 0, received %d", ref); I think it is pretty useful to check the reference count in general for all release calls. Please review that part, so that it does what it should do! It's not only the line I mentioned as an example here! If you don't understand some parts and don't know exactly what to do, please ask. I'd prefer if the comparison would be within the if, otherwise you could compare to an uninitialized value, which could get bogus results (even if that only happens when other test fail, I think it's better than comparing uninitialized values): + if (polygon) ref = polygon->lpVtbl->Release(polygon); + ok(ref == 0, "Expected refcount = 0, received %d", ref); Please see my points as a suggestion. I think the answers to the patches showed a lot of issues, so please review the whole patch before sending it again, you may find some other not mentioned things. Note: Not the fastest sent patch will get in, but the "best" working solution. Cheers Rico

1 0

Re: Add dxerr.h
by Henri Verbeet 10 Nov '11

10 Nov '11

On 10 November 2011 02:27, Daniel Scharrer <dscharrer(a)gmail.com> wrote: > +#include <dxerr9.h> > + > +#define DXGetErrorStringA DXGetErrorString9A > +#define DXGetErrorStringW DXGetErrorString9W > +#define DXGetErrorString WINELIB_NAME_AW(DXGetErrorString) > + > +#define DXGetErrorDescriptionA DXGetErrorDescription9A > +#define DXGetErrorDescriptionW DXGetErrorDescription9W > +#define DXGetErrorDescription WINELIB_NAME_AW(DXGetErrorDescription) Which SDK version does this match?

2 1

Antw.: RFC: depending on getifaddrs in iphlpapi
by André Hentschel 10 Nov '11

10 Nov '11

Why? AFAIK getifaddr was added to at least openSolaris Last year and you still can use the old Code as fallback Gesendet mit meinem HTC ----- Reply message ----- Von: "Juan Lang" <juan.lang(a)gmail.com> An: "Michael Stefaniuc" <mstefani(a)redhat.com> Cc: "Wine Devel" <wine-devel(a)winehq.org> Betreff: RFC: depending on getifaddrs in iphlpapi Datum: Do., Nov. 10, 2011 18:41 >> I'm thinking of replacing the current IPv4 enumeration code, which >> uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning >> toward replacing, rather than adding side-by-side with the current >> code, is that getifaddrs is commonly available: it's available on all >> recent versions of Linux, as well as on FreeBSD and MacOS. There > recent versions of Linux as of which year? Good question. When I was writing this code in 2003, the stable version of Debian didn't support it. I haven't seen a Linux system that doesn't support it since then, but I've only checked periodically. >> might be some platform somewhere that's disenfranchised by this, but >> I'm not sure it's worth the code complexity to maintain the current >> code. > What about Solaris/OpenSolaris? That's the only other major system where > Wine can be made to run. Ah. Okay, that's an important objection. I'll go with keeping the current code, then. Thanks, --Juan

2 1

RFC: depending on getifaddrs in iphlpapi
by Juan Lang 10 Nov '11

10 Nov '11

Hi folks, right now iphlpapi uses autoconf to detect if getifaddrs is available, and only uses it to enumerate IPv6 addresses. I'm thinking of replacing the current IPv4 enumeration code, which uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning toward replacing, rather than adding side-by-side with the current code, is that getifaddrs is commonly available: it's available on all recent versions of Linux, as well as on FreeBSD and MacOS. There might be some platform somewhere that's disenfranchised by this, but I'm not sure it's worth the code complexity to maintain the current code. Any strenuous objections? Reasons to use getifaddrs rather than ioctls: 1. SIOCGIFCONF is actually pretty fiddly, and is the current code is broken on FreeBSD, or FreeBSD's support is broken (bug 27653.) 2. SIOCGIFFLAGS is apparently broken on current Linux versions. I haven't found any bug against Wine or Linux about that, I just noticed it while testing the existing code. Thanks, --Juan

2 2

RFC: ddraw: Fix conversion between D3DVIEWPORT and D3DVIEWPORT2
by Octavian Voicu 10 Nov '11

10 Nov '11

Hi, Attached is a series of patches to add better tests and fix Wine's implementation of the conversion between D3DVIEWPORT and D3DVIEWPORT2 structures in IDirect3DViewport / IDirect3DViewport2 / IDirect3DViewport3 implementation. I'm sending this to to wine-devel because next commit round will be on Monday, so I hope to get some feedback until then and fix any issues before sending to wine-patches. I'm also working on fixing IDirect3DViewport::TransformVertices, which at the very least does not work if viewport data is set using D3DVIEWPORT2. This will fix bug http://bugs.winehq.org/show_bug.cgi?id=11819, which is actually caused by Wine's buggy implementation of TransformVertices and has nothing to do with the z-buffer locking not begin implemented. I'm working on some tests and a fix, and will post them here when they are ready. Octavian -- Octavian Voicu (5): ddraw/tests: Remove some redundant d3d viewport tests. ddraw/tests: Add macro to verify viewport data bounds. ddraw/tests: Make ViewportTest loop through an array of tests. ddraw: Add error checking for IDirect3DViewportImpl_[GS]etViewport, with tests. ddraw: Add more viewport tests and make them pass under Windows and Wine. dlls/ddraw/tests/d3d.c | 329 ++++++++++++++++++++++++++++-------------------- dlls/ddraw/viewport.c | 114 ++++++++++------- 2 files changed, 260 insertions(+), 183 deletions(-)

1 0

Re: winspool.drv: Correct test for Device Capabilities (resend)
by Marvin 10 Nov '11

10 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15332 Your paranoid android. === WINEBUILD (build) === Can't determine base name

2 1

Re: [PATCH 3/3] wined3d: Report all FBO-attachable formats as suitable for render target usage.
by Matteo Bruni 10 Nov '11

10 Nov '11

2011/11/9 Matteo Bruni <mbruni(a)codeweavers.com>: > --- This patch is not correct, please ignore it...

1 0

Re: d3dx9_36/tests [patch 2/2, try 3]: Add tests for D3DXCreatePolygon
by Matteo Bruni 09 Nov '11

09 Nov '11

2011/11/9 David Adam <david.adam.cnrs(a)gmail.com>: > Better, but there are still issues: + if( polygon ) polygon->lpVtbl->Release(polygon); + if( ppBuffer ) ID3DXBuffer_Release(ppBuffer); You aren't setting those pointers to NULL (and your test shows that D3DXCreatePolygon doesn't touch them when the call fails), so those ifs actually are protecting nothing. In patch 1/2, LockVertex/IndexBuffer should not fail in normal circumstances, so it's probably better to use ERR instead of TRACE there. Also, please, try to fixup the code style. E.g. the preferred style for 'if's and loops is to have a whitespace between the keyword and the '(' and no whitespace between the parentheses and the condition. Stick with that. Don't use hungarian notation (ppBuffer ...), fix whitespaces around operators, etc

2 1

Strange window manager bug
by Alex Henrie 09 Nov '11

09 Nov '11

Does anyone have an idea of what could be causing http://bugs.winehq.org/show_bug.cgi?id=29027 ? -Alex

1 0

Re: [1/2] Revert "msi: Use MsgWaitForMultipleObjectsEx to do waits."
by Alexandre Julliard 09 Nov '11

09 Nov '11

Hans Leidekker <hans(a)codeweavers.com> writes: > This reverts commit 2556173f20ba9583044aaf31b16cbb2214d2b907. > It causes a regression in the Quicken 2011 installer. Does it really break because we are processing messages, or just because we don't wait properly? If so fixing the wait would seem a better choice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] winhttp: Convert string data to UTF-8 and add a corresponding content type header.
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15333 Your paranoid android. === W2K3R2SESP2 (32 bit winhttp) === winhttp.c:2158: Test failed: got 80072f78

1 0

Re: [PATCH 1/5] wined3d: Don't print FIXMEs for misaligned surface maps.
by Stefan Dösinger 09 Nov '11

09 Nov '11

On Tuesday 08 November 2011 20:48:55 Henri Verbeet wrote: > - FIXME("Partial block lock with %s\n", > debug_d3dpool(surface->resource.pool)); I added this fixme because we have to tests for the offset that is returned in this case. Do you have an application that triggers this fixme, or do you want to suppress the fixmes in the tests?

2 3

Re: mscoree: Implement ICorDebug CreateProcess (try 2)
by Alexandre Julliard 09 Nov '11

09 Nov '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Move DuplicateHandle to Create_Process. > Added Makefile.in (missing from first patch) > > Changelog: > mscoree: Implement ICorDebug CreateProcess You should put everything in cordebug.c, there's no need to have a separate file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] ddraw/tests: Add a test for YV12 partial block locks and lock offsets
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15324 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [4/4] ddraw: Set correct HEL and HAL color models
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15327 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] ddraw: Add more tests and fixes for SetSurfaceDesc
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15326 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Adopt a patch?
by Michael Ost 08 Nov '11

08 Nov '11

I have a patch for a bug that I won't be able to shepherd through the patch submission process for some time. The bug is that GetFileVersionInfoSize doesn't work for files with path names longer than 128 characters. The patch includes an untried unit test. And I've confirmed the behavior in Windows Vista. We use an older version of Wine, and my boss won't let me take the time right now to rework the patch for the newest Wine sources. If someone wants to they can take this patch, tweak it for the new wine, update it to wine-patch requirements and push it through the system. Otherwise I'll submit as soon as I can. Cheers, Michael Ost

2 1

Re: apphelp: add a stub for ApphelpCheckShellObject
by Dmitry Timoshkov 08 Nov '11

08 Nov '11

Austin English <austinenglish(a)gmail.com> wrote: > +BOOL WINAPI ApphelpCheckShellObject(REFCLSID ObjectCLSID, BOOL ShimIfNecessary, ULONGLONG *pullFlags) > +{ > + FIXME("stub: %s %p\n", debugstr_guid(ObjectCLSID), pullFlags ); > + return TRUE; > +} It's a common convention in Wine to avoid hungarian notation by all means. In this case naming variables something like 'clsid, shim, flags' woud be better. -- Dmitry.

1 0

Fwd: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon
by David Adam 08 Nov '11

08 Nov '11

Hello, any problem with this patch http://source.winehq.org/patches/data/80433 and this one http://source.winehq.org/patches/data/80434 Thanks in advance David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/10/30 Subject: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon To: wine-patches <wine-patches(a)winehq.org> Fix a possible crash when calling D3DXCreateMeshFVF. A+ David

3 2

Re: [10/11] ddraw/tests: Add assorted D3D3 DrawPrimitive/visual tests.
by Stefan Dösinger 08 Nov '11

08 Nov '11

On Tuesday 08 November 2011 01:14:22 Octavian Voicu wrote: > The idea behind using triangles was to fit everything in one screen so > I could debug it visually very easily. I'm thinking I can still have > that if I draw full-screen quads in a loop, like you suggest, then > blit one small rectangle to the primary surface, in different > positions for each test. I don't think that's necessary, I found those one-quad screens easier to debug than multi-quads, although that may be a matter of taste. > I think > we should cover special error cases if there are any (that is, if > D3DERR_INVALIDVERTEXTYPE is not returned for D3DVT_ constants). Well, you can't test them. D3DVT_LVERTEX is 2, and D3DFVF_XYZ is 2. The number 2 doesn't have any tags attached, so what you'd be testing is how drawPrimitive responds to D3DFVF_RESERVED0, not what it does with D3DVT_* enums. The statement in the SDK doesn't make sense with that in mind. > About the ddraw/visual tests: I think we need one structure for each > of d3d, d3d2, d3d3, d3d7, where to have most of the things we store > globally or in local vars now, and make the create/release functions > work with that. Yes, I was about to write something like that as a response to the cleanup patches. PS: You forgot to CC wine-devel, I assume this was by accident so I've added it to the reply again. You may want to resend your original mail to wine- devel.

2 2

Re: [01/11] ddraw/tests: Fix a couple of copy-paste typos in test messages.
by Stefan Dösinger 08 Nov '11

08 Nov '11

This patch is OK, the others need some discussion and work.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel