- wine-devel - winehq.org

Re: 79358: mscoree: Add ICorDebug interface support
by Dan Kegel 27 Sep '11

27 Sep '11

build failed here - did you forget a file? ../../tools/makedep -C. -S../.. -T../.. assembly.c config.c cordebug.c corruntimehost.c metadata.c metahost.c mscoree_main.c debugging.c: No such file or directory make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/mscoree/tests' make: *** [dlls/mscoree/tests/__depend__] Error 2 On Tue, Sep 27, 2011 at 4:20 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/109 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_2 > > Errors: > make[1]: *** [depend] Error 1 > make: *** [dlls/mscoree/tests/__depend__] Error 2 > >

1 0

Re: mscoree: Add ICorDebug interface support (try 2)
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14582 Your paranoid android. === W2K3R2SESP2 (32 bit debugging) === debugging.c:82: Test failed: CreateDebuggingInterfaceFromVersion returned 80070057

1 0

Re: mscoree: Add ICorDebug interface support
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14581 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msi/tests: Properly preserve pending file renames.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14578 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5996: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: wininet: Ignore the accept types array in HttpOpenRequestA if there are invalid pointers.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14577 Your paranoid android. === W7PRO (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12002

1 0

Re: shell32: Add definitions for the IEnumACString interface.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14562 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:250: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154 === W2KPROSP4 (32 bit autocomplete) === autocomplete.c:256: Test failed: obj->lpVtbl->QueryInterface(obj, &IID_IEnumACString, (LPVOID*)&unk) failed: 80004002

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14554 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:249: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14548 Your paranoid android. === WNT4WSSP6 (32 bit memallocator) === memallocator.c:34: Test failed: Unable to create memory allocator 80040154 === WNT4WSSP6 (32 bit referenceclock) === referenceclock.c:97: Test failed: Unable to create reference clock from system clock 80040154

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14540 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541 === W2KPROSP4 (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541 === W2K8SE (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541

1 0

Re: msi/tests: Avoid #if 0 to make sure code still compiles.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14533 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5998: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 6/9 (try2)] winecfg: Replace DirectSound settings with Driver Diagnostics
by Alexandre Julliard 26 Sep '11

26 Sep '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -84,10 +84,11 @@ END > > STRINGTABLE > BEGIN > - IDS_ACCEL_FULL "Full" > - IDS_ACCEL_STANDARD "Standard" > - IDS_ACCEL_BASIC "Basic" > - IDS_ACCEL_EMULATION "Emulation" > + IDS_AUDIO_REG_SETTING "Registry driver setting: %s" > + IDS_AUDIO_REG_DEFAULT "(Default)" > + IDS_AUDIO_REG_DISABLED "(Disabled)" > + IDS_AUDIO_DRIVER "Selected driver: %s" > + IDS_AUDIO_DRIVER_NONE "(None)" Showing the detected driver is a good thing, but we shouldn't need to display the registry setting. The assumption is that users shouldn't have to worry about this. If it's important enough to show in winecfg then it has to be editable in winecfg too. -- Alexandre Julliard julliard(a)winehq.org

1 0

using (or not) blocking mode with OSS4
by Joerg-Cyril.Hoehle＠t-systems.com 26 Sep '11

26 Sep '11

Hi, I've had a glance at the OSS4 mmdevapi logs attached to bug #28056. Among others, it appears that every renderer iteration takes way too much time. One possible explanation is that OSS write() takes a lot of time to return, presumably in an attempt to write more than what's possible without blocking. If you look at AudioRenderClient_ReleaseBuffer and oss_write_data, you'll see that it writes as much as it has, without querying GETOSPACE. So it can block. open() is called without O_NONBLOCK, so write() will block when given too much data. I don't know yet whether O_NONBLOCK should be used. It's not what the OSS people recommend. One can argue that NONBLOCK is superfluous when write is limited via GETOSPACE. http://manuals.opensound.com/developer/open.html http://manuals.opensound.com/developer/audio_timing.html http://manuals.opensound.com/developer/SNDCTL_DSP_NONBLOCK.html What do you think about using (or not) blocking mode with OSS? W.r.t. ALSA, I'm considering keeping non-blocking mode but switch from a periodic timer to poll(ALSA_fd, period_timeout). Given a lot of data, poll would return after the timeout, but when underrun is close, this should allow to wake up closer to when data is actually needed. Regards, Jörg Höhle

2 1

re: po: Mark translations with mismatched printf format directives as fuzzy.
by Dan Kegel 26 Sep '11

26 Sep '11

Patch fails to apply here? error: patch failed: po/ko.po:11305 error: po/ko.po: patch does not apply ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 25, 2011 at 5:35 PM Subject: Re: 79310: po: Mark translations with mismatched printf format directives as fuzzy. To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/84 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed git Errors: error: patch failed: po/ko.po:11305 error: po/ko.po: patch does not apply

4 5

Before you leave for wineconf...
by Dan Kegel 26 Sep '11

26 Sep '11

... could you run http://kegel.com/wine/loop-fail.sh.txt overnight on the hardware you plan to bring, and email me the results? It creates a log file loop-fails.log which lists each test failure and how many loops it took to get there. Thanks!

2 2

Re: [1/2] kernel32: Add a test for VirtualProtect.
by Alexandre Julliard 26 Sep '11

26 Sep '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +static void test_VirtualProtect(void) > +{ > + static const struct test_data > + { > + DWORD prot_set, prot_get; > + } td[] = > + { > + { PAGE_NOACCESS, PAGE_NOACCESS }, > + { PAGE_READONLY, PAGE_READONLY }, > + { PAGE_READWRITE, PAGE_READWRITE }, > + { PAGE_WRITECOPY, 0 }, > + { PAGE_EXECUTE, PAGE_EXECUTE }, > + { PAGE_EXECUTE_READ, PAGE_EXECUTE_READ }, > + { PAGE_EXECUTE_READWRITE, PAGE_EXECUTE_READWRITE }, > + { PAGE_EXECUTE_WRITECOPY, 0 } You should also test various invalid combinations. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH 7/9] dsound: Reimplement rendering devices on mmdevapi
by Joerg-Cyril.Hoehle＠t-systems.com 26 Sep '11

26 Sep '11

Hi, I agree that dsound -> winmm -> mmdevapi is an abomination. However, this all goes too fast for me. We don't have a fool-proof mmdevapi yet (neither ALSA, nor OSS, nor CoreAudio). We don't have a bug-free winmm->mmdevapi yet. Since June, I've done nothing than analyse code and fix bugs to help The Wine project in my free time. My wife has already signaled that she's not pleased. I've installed zero SW for the children since that time. Well, my choice, but I'm growing tired. It appears that I've a biased view on the current audio situation because I see all the bugs. The user experience does not seem that bad, from what a few users told me. Currently, having dsound -> winmm -> mmdevapi may not be satisfying, but it helps to find hairy bugs fast (more apps use dsound than winmm). After the initial winmm transition, I did not even look at dsound or winmm bugs because there's no point in doing so when they depend on a mmdevapi which is not yet robust enough. So I concentrated on mmdevapi. It's only recently that I've started to look at winmm now that I believe to know well most remaining ALSA and CoreAudio mmdevapi bugs. I'm solely starting on OSS bugs. I believe users are happy to still have dsound HW acceleration in ALSA since 1.3.25 to compare it with the new HW emulation behaviour via mmdevapi. Is a 1.4 release target this year the reason for pushing out code fast? Regards, Jörg Höhle

2 1

Warning report for wine-1.3.29-5-gf04f0b3
by Jerome Leclanche 26 Sep '11

26 Sep '11

Operating System Linux azura 3.0.0-10-generic #16-Ubuntu SMP Fri Sep 2 18:32:04 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux Configuration (32-bit) '--prefix=/usr' '--libdir=/usr/lib32' '--enable-tests' '--disable-win64' '--with-wine64=/home/adys/src/wine/build64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Configuration (64-bit) '--prefix=/usr' '--libdir=/usr/lib' '--enable-tests' '--enable-win64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' -- J. Leclanche

1 0

Quick Question
by Peter Wilson 26 Sep '11

26 Sep '11

Hi, Quick question, might be silly, but is there a version of Wine that can be installed on windows or linux to create apps for Mac? I just want to keep my mac clean and try run things in a dev environment, and apple are always so polite to make visualization a pain… Thank you very much for you help, Kind Regards, Peter Wilson

2 1

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing
by Frédéric Delanoy 25 Sep '11

25 Sep '11

This patch fails; see http://source.winehq.org/patches/ and http://source.winehq.org/patches/data/79288.testfail Got a lot of errors on NT4, and 1 on other systems batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@' You might want to use @todo_wine@ as documented on http://wiki.winehq.org/CmdConformanceTests Patches generating at least 1 error on one of testbot's systems (NT included) have 0% chance of being committed (see http://wiki.winehq.org/SubmittingPatches) [I know NT4 is sometimes $#!+... be thankful win9x is not a prerequisite anymore... ;) ] Frédéric PS: "resend" is used for unchanged patches (or only rebased); in other cases you should use "try N"

1 1

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14502 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

re: gdi32: Add traces for the gamma functions
by Dan Kegel 25 Sep '11

25 Sep '11

Looks like you forgot something: cc1: warnings being treated as errors dc.c: In function ‘GetDeviceGammaRamp’: dc.c:1289: error: too few arguments for format dc.c: In function ‘SetDeviceGammaRamp’: dc.c:1307: error: too few arguments for format make[1]: *** [dc.o] Error 1 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 25, 2011 at 12:10 PM Subject: Re: 79299: gdi32: Add traces for the gamma functions To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/69 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: make: *** [dlls/gdi32] Error 2

2 1

Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14499 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 4/5] cmd: fix handling of special characters in command line
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14498 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 3/5] cmd: improve parsing of quotes in command line
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14497 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv
by Martin Wilck 25 Sep '11

25 Sep '11

Hi Dan, (re-cc'ing wine-devel) > Running it through the buildbot now... seems ok on first two tries, so > you may have accidentally fixed the problem. I'll resubmit to wine-patches shortly, probably tonight. >> > I ran the stuff through the bot, 0 errors everywhere except on NT (NT >> > fails totally, do I really need to investigate that?). > Yes, you may need to skip these tests on nt. > >> > I don't have a i7 machine, > It's probably just mine that gets lucky. Some tests > fail better on some machines than others. > Did you test with WINEDEBUG=warn+heap ? No, I didn't. I thought you wree telling me that that made your problem go away, so I didn't bother. I can do that of course if it helps. >> but I tested on a Westmere EX server I have access to, no >> problems with the conformance test. I also did some valgrind runs on >> that machine, but I have little experience in reading valgrind output. > > Did you follow http://wiki.winehq.org/Wine_and_Valgrind ? > Feel free to ask questions. Yes, I did. I am seeing no regressions (read: additional warnings and/or errors) between the trunk and my patched version. > A few notes: > + if (!in_quotes && (*p == ' ' || *p == '\t')) { > > Could you use isspaceW() ? I suppose not in the case statement below, > but you check this in several places, and the function might be clearer > (if it's correct)? Honestly, I didn't consider it. I tried to change as little as possible of the existing code. > Is there duplication between WCMD_parameter and WCMD_parse > that could be gotten rid of productively? Yes, there is, as I noted in an early posting on this subject. Indeed the two functions have essentially the same purpose. However I don't feel bold enough to try fixing that as long as my current stuff isn't accepted. Originally, all that I wanted to fix was 'echo "Hi"'. I have gone quite a few steps ahead from there with my current patch set. When I see this getting merged I'll consider further fixes, but I won't be able to follow up *much* further. Best regards Martin

2 1

Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14496 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14495 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 51 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@')

1 0

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins 24 Sep '11

24 Sep '11

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

Re: loop fails
by Dan Kegel 24 Sep '11

24 Sep '11

2011/9/24 André Hentschel <nerv(a)dawncrow.de>: > Hey Dan, > sadly i'm not going to be at wineconf this year, but i thought the results might help anyway. maybe i'm participating per IRC and it's my desktop computer anyway, so we'll see. > the script didn't end cleanly, there was a heap related crash that made it hang so i'm not sure about it. > > ended in the urlmon test: > > Backtrace: > =>0 0x7bc48485 RtlAllocateHeap+0xb5(heap=0x110000, flags=0x2, size=0x6000) [/home/dawncrow/dev/wine/132/dlls/ntdll/../../../include/wine/list.h:99] in ntdll (0x0032e328) > 1 0x696866b7 MSVCRT_malloc+0x36(size=0x6000) [/home/dawncrow/dev/wine/132/dlls/msvcrt/../../../dlls/msvcrt/heap.c:312] in msvcrt (0x0032e348) > 2 0x702d1962 in mozjs (+0x151961) (0x02326318) > 3 0x00000000 (0x010c6740) oooh. So it only took six loops to crash in urlmon, eh? (For the record, the script ran both dlls/urlmon/tests/protocol.ok and dlls/urlmon/tests/url.ok, don't know which one crashed.) Can you install debug gecko, e.g. by running http://kegel.com/wine/dgecko.sh.txt ( which just does the steps on http://wiki.winehq.org/Gecko ) and re-run? Also, out of six loops, you got the following test failures: 6 dlls/dsound/tests/ds3d.ok 6 dlls/dsound/tests/ds3d8.ok 6 dlls/wininet/tests/urlcache.ok 6 dlls/dsound/tests/dsound.ok 6 dlls/dsound/tests/dsound8.ok 5 dlls/winhttp/tests/winhttp.ok 5 dlls/vbscript/tests/run.ok 5 dlls/mshtml/tests/style.ok 5 dlls/mshtml/tests/htmldoc.ok 5 dlls/gdi32/tests/bitmap.ok 2 dlls/ws2_32/tests/sock.ok 1 dlls/user32/tests/msg.ok The urlcache one may go away if you clear out ~/.wine. The msg one probably would go away if you had the blessed window manager (does anyone know what the procedure there is these days?) The others seem interesting. If you were attending wineconf, I would have asked you to hit the appropriate developers up for help resolving them. Maybe you still can via email or irc... I'm looking forward to seeing loop-fail results from other folks. - Dan

2 1

Re: hhctrl.ocx: Don't show unimplemented buttons.
by Erich Hoover 24 Sep '11

24 Sep '11

> + case IDTB_NOTES: > + case IDTB_CONTENTS: > + case IDTB_INDEX: > + case IDTB_SEARCH: > + case IDTB_HISTORY: > + case IDTB_FAVORITES: > + /* These are officially unimplemented as of the Windows 7 SDK */ > + break; Could you point me to a link on this behavior? I'm pretty sure that many of these buttons send a signal that applications can hook into and override the default (do-nothing) behavior. Erich Hoover ehoover(a)mines.edu

3 2

Re: [1/4] ddraw/tests: Use sizeof instead of a magic number
by Stefan Dösinger 24 Sep '11

24 Sep '11

Am 24.09.2011 um 12:48 schrieb Stefan Dösinger: > <PGP.txt> WTF? What did my Mail client do here???

1 0

Congratulations! DIB engine 421
by Keith 24 Sep '11

24 Sep '11

Hi, Amazing I'm a long time follower of the project and to see a DIB engine implemented is a huge milestone given all the trials and tribulations leading up to it. Honestly never thought it would happen everyone needs to give themselves a pat on the back today :-) Regards, Keith

1 0

Re: dpnet: fill the DPN_SP_CAPS structure in IDirectPlay8Peer_GetSPCaps with some sane values + tests
by Marvin 23 Sep '11

23 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14486 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)
by Andrew Talbot 23 Sep '11

23 Sep '11

Marcus Meissner wrote: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. > > CID 5033, 5034 > > Ciao, Marcus > --- > dlls/comdlg32/itemdlg.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c > index bc309c9..d9756c0 100644 > --- a/dlls/comdlg32/itemdlg.c > +++ b/dlls/comdlg32/itemdlg.c > @@ -1106,6 +1106,8 @@ static SIZE update_layout(FileDialogImpl *This) > SIZE ret; > > GetClientRect(This->dlg_hwnd, &dialog_rc); > + memset (&toolbar_rc, 0, sizeof(toolbar_rc)); > + memset (&filename_rc, 0, sizeof(filename_rc)); > > missing_width = max(0, 320 - dialog_rc.right); > missing_height = max(0, 200 - dialog_rc.bottom); Hi Marcus, Instead of using memset(), would it not be better to initialise the RECTs to zero when declaring them, as follows? RECT toolbar_rc = { 0 }; RECT filename_rc = { 0 }; -- Andy.

1 0

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)
by Alexandre Julliard 23 Sep '11

23 Sep '11

Marcus Meissner <meissner(a)suse.de> writes: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. It's not clear that 0 is much better. If there's really a possibility for these things to be missing the layout should take that into account. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)
by Bruno Jesus 23 Sep '11

23 Sep '11

On Fri, Sep 23, 2011 at 07:50, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Note: the 2 failing tests on test-bot that this patch will produce, are not real failures as winnt and win2000 will not run the test because of missing dpnet > > try 3: rewrote patch in a more straightforward way > > this makes previously sent tests pass, and fixes crash in bug http://bugs.winehq.org/show_bug.cgi?id=28008 Use the broken macro to skip or expect a different return from the tests that crash in NT and add a comment there. Example: http://source.winehq.org/source/dlls/ole32/tests/usrmarshal.c#L103 Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)
by Marvin 23 Sep '11

23 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14466 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: mshtml: Add IHTMLCurrentStyle2/3/4 support
by Alexandre Julliard 23 Sep '11

23 Sep '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/mshtml/Makefile.in b/dlls/mshtml/Makefile.in > index 3933645..62a2d6f 100644 > --- a/dlls/mshtml/Makefile.in > +++ b/dlls/mshtml/Makefile.in > @@ -14,6 +14,7 @@ C_SRCS = \ > htmlbody.c \ > htmlcomment.c \ > htmlcurstyle.c \ > + htmlcurstyle2.c \ Please add this to the existing file. There are already way too many source files in this dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: Highlighting Fall-throughs
by Andrew Talbot 23 Sep '11

23 Sep '11

Hi All, I am thinking of marking any unmarked places in switch statements where fall-through occurs. However, simply to do so would be to ignore the question of whether each fall-through is intentional or an oversight. I therefore propose to mark each new point with two comments (maybe separate, maybe combined): one to state that fall-through occurs and the other to point out that the validity of this particular fall-through has not yet been checked, maybe something like: select(x) { case 1: foo(); break; case 2: bar(); /* fall through */ /* unaudited */ default: baz(); } Is this all good, or is there a better way? Thanks, -- Andy.

3 4

Re: comctl32: Fix going to today with multiple calenders
by Nikolay Sivov 22 Sep '11

22 Sep '11

On 9/23/2011 00:03, André Hentschel wrote: > --- > dlls/comctl32/monthcal.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c > index 5f8a36c..b330871 100644 > --- a/dlls/comctl32/monthcal.c > +++ b/dlls/comctl32/monthcal.c > @@ -1970,9 +1970,7 @@ MONTHCAL_RButtonUp(MONTHCAL_INFO *infoPtr, LPARAM lParam) > if( TrackPopupMenu(hMenu, TPM_RIGHTBUTTON | TPM_NONOTIFY | TPM_RETURNCMD, > menupoint.x, menupoint.y, 0, infoPtr->hwndSelf, NULL)) > { > - infoPtr->calendars[0].month = infoPtr->todaysDate; > - infoPtr->minSel = infoPtr->todaysDate; > - infoPtr->maxSel = infoPtr->todaysDate; > + MONTHCAL_SetCurSel(infoPtr,&infoPtr->todaysDate); > InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); > } > This is wrong, it lacks notification calls and you have unneeded invalidate call left. Also similar case remains to be fixed. Actually I planned to work on this tomorrow, including some other issues I just spotted.

2 2

Fwd: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation
by Dan Kegel 22 Sep '11

22 Sep '11

Didn't build here, did you forget to add dependency on ole32? ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -Wno-unused-but-set-variable -Wno-unused-but-set-parameter -o vwin32.o vwin32.c global.o: In function `create_object': /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:74: undefined reference to `CLSIDFromProgID' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:92: undefined reference to `CoGetClassObject' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:114: undefined reference to `CoTaskMemFree' collect2: ld returned 1 exit status winegcc: ccache failed make[1]: *** [vbscript.dll.so] Error 2 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Thu, Sep 22, 2011 at 8:01 AM Subject: Re: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/26 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: make: *** [dlls/vbscript] Error 2

2 1

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Jacek Caban 22 Sep '11

22 Sep '11

> === WNT4WSSP6 (32 bit createobj) === > createobj.c:734: Test failed: CoCreateInstance failed: 80040154 > createobj: unhandled exception c0000005 at 00402A21 These tests fail because testbot runs them regardless that vbscript.dll is not present on the machine. Jacek

1 0

IPv6 issue on TestBot?
by Francois Gouget 22 Sep '11

22 Sep '11

Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( This makes accessing it from my desktop very annoying. $ time wget -4 --quiet http://testbot.winehq.org/ real 0m2.150s user 0m0.000s sys 0m0.000s $ time wget -6 --quiet http://testbot.winehq.org/ ... still stuck after 6+ minutes $ telnet -6 testbot.winehq.org Trying 2001:888:2000:38:1000::2... ... same thing According to http://test-ipv6.com/ my desktop is configured just fine and I only have trouble with the TestBot. Could this be a firewall problem? (testbot exposing an IPv6 address but the firewall dropping any IPv6 packets) In the mean time I'm going to use my laptop which is still IPv4 only :-/ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

6 11

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14455 Your paranoid android. === WNT4WSSP6 (32 bit createobj) === createobj.c:734: Test failed: CoCreateInstance failed: 80040154 createobj: unhandled exception c0000005 at 00402A21

1 0

Re: [PATCH 07/13] vbscript: Added exit for statement support
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14454 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/13] vbscript: Added for..in statement tests
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14453 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

crypt32(1/2): Test CertCreateCertificateContext, and fix an error code in a failure case
by Juan Lang 22 Sep '11

22 Sep '11

--Juan

1 0

Remove the legalese from start.exe?
by Francois Gouget 22 Sep '11

22 Sep '11

Start has the following lines at the end of its usage message: "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" "Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option.\n" "This is free software, and you are welcome to redistribute it\n" "under certain conditions; run 'start /L' for details.\n" And also this resource: "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" "This program is free software; you can redistribute it and/or\n" "modify it under the terms of the GNU Lesser Public License\n" "as published by the Free Software Foundation; either version 2.1\n" [...] "along with this program; if not, write to the Free Software\n" "Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.\n" "\n" "See the COPYING.LIB file for license information.\n" We also have another copy of this copyright notice in shell32 for the 'About Wine' dialog but without the 'start.exe' and 'COPYING.LIB' lines, and with 'This program' replaced with 'Wine'. One more copyright notice we have is this in msrle32.rc: "Wine MS-RLE video codec\n" "Copyright 2002 by Michael Guennewig" Now this is all legalese which is a pain to translate (weird vocabulary) and pretty scary too. And because of the small differences the copyright notice needs to be translated twice (though tools like Virtaal/Launchpad may notice the similarity and prefill a fuzzy translation). Also start.exe and msrle32.dll are the only ones to have these notices which seems pretty inconsistent. So what can we do to make this simpler? The simplest would be to remove all copyright notices from start.rc and msrle32.rc. (we would keep the ones in the source of course). I guess that would require Dan's and Michael's approval. The other options involve separating the strings that change from one tool to the next, from those that stay the same. This way the latter will only appear once in the PO file and thus need to be translated only once. The various parts can then trivially be concatenated when they are displayed. (unfortunately this does not help for the msrle32.rc case) For instance we could decide to only keep the 'COPYING.LIB' string and tack it to the end of the usage message. We could also make things more consistent by doing this in every tool. So in pseudo-code we would have something like this: /* Load the tool-specific usage message */ usage_message = load_string(IDS_USAGE); /* Load the generic copying.lib reference. This one is duplicated in * every tool but always the same. */ copying_reference = load_string(IDS_COPYING); /* Print both */ printf(usage_message); printf(copying_reference); Another option would be to reuse the exact same main copyright notice as in the About Wine dialog since we need to translate that anyway (I think it would work wrapping-wise). So the start.exe pseudo-code for showing the license would be something like this: /* Load the copyright notice header, that is: * start.exe version 0.2 Copyright (C) 2003, Dan Kegel * start.exe is part of Wine. */ notice_header = load_string(IDS_NOTICE_HEADER); /* Load the generic Wine copyright notice. Note that it * says 'Wine' like in the 'About Wine' dialog, not 'This program' * and would be the same in any other Wine tool: * Wine is free software; you can redistribute it and/or modify * ... */ notice_generic = load_string(IDS_NOTICE_GENERIC); /* Load the copyright notice trailer: * * See the COPYING.LIB file for license information. */ notice_trailer = load_string(IDS_NOTICE_TRAILER); /* Print all the parts together */ printf(notice_header); printf(notice_generic); printf(notice_trailer); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

3 4

[PATCH 3/5] winealsa.drv: Use the plughw instead of the hw interface for openening devices.
by Joerg-Cyril.Hoehle＠t-systems.com 22 Sep '11

22 Sep '11

Henri Verbeet [becoming an audio expert now?] wrote: >The default device may for example be a set of USB speakers or an USB >microphone, in which case you'd have just an output or just an input >respectively. My testcase has been to hack mmdevdrv.c and replace "default" with "plug:dmix" or "dmix" which is an output only device. Expected test result is to behave like most testbot.winehq.org and skip capture tests. Actual output (prior to your patch) last time I tried was some failures. I.e. the mmdevapi render and capture tests suggest that there's no default device for testbots that cannot capture. How does your alsa_try_open interact with devices that clang onto the underlying HW resource for several seconds? (PA does this) Regards, Jörg Höhle

2 1

winetest: Missing test.avi and msrle.avi files
by Francois Gouget 22 Sep '11

22 Sep '11

Two Wine tests are skipping tests because they are missing avi test files: * quartz:avisplitter needs a test.avi file: http://source.winehq.org/git/wine.git/?a=history;f=dlls/quartz/tests/avispl… avisplitter.c:210: Tests skipped: Could not read test file "test.avi", skipping test * winmm:mmio needs an msrle.avi file: http://test.winehq.org/data/b6153354dd28c57fb1f92f85df1f1ba751794fc1/mac_fg… mmio.c:77: Tests skipped: msrle.avi file is missing, skipping the test Interestingly there is a test.avi file in the Wine source tree: dlls/qedit/tests/test.avi So where can one procure these test files? Should quartz:avisplitter automatically find qedit:test's test.avi file? Can the missing files be added to Wine? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel