- wine-devel - winehq.org

[PATCH] ws2_32: Fix memory leaks on error paths in unix_gethostby* (scan-build)
by Alex Henrie 21 Dec '21

21 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ws2_32/unixlib.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/ws2_32/unixlib.c b/dlls/ws2_32/unixlib.c index e89ebe35248..45018199add 100644 --- a/dlls/ws2_32/unixlib.c +++ b/dlls/ws2_32/unixlib.c @@ -865,12 +865,13 @@ static NTSTATUS unix_gethostbyaddr( void *args ) unix_buffer = new_buffer; } + free( unix_buffer ); + if (!unix_host) return (locerr < 0 ? errno_from_unix( errno ) : host_errno_from_unix( locerr )); ret = hostent_from_unix( unix_host, params->host, params->size ); - free( unix_buffer ); return ret; } #else @@ -915,12 +916,13 @@ static NTSTATUS unix_gethostbyname( void *args ) unix_buffer = new_buffer; } + free( unix_buffer ); + if (!unix_host) return (locerr < 0 ? errno_from_unix( errno ) : host_errno_from_unix( locerr )); ret = hostent_from_unix( unix_host, params->host, params->size ); - free( unix_buffer ); return ret; } #else -- 2.34.1

2 1

[PATCH] ntdll: Fix memory leak on error path in NtCreateFile (scan-build)
by Alex Henrie 21 Dec '21

21 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ntdll/unix/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index 07bfa6c22c4..a3437099872 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -3785,9 +3785,9 @@ NTSTATUS WINAPI NtCreateFile( HANDLE *handle, ACCESS_MASK access, OBJECT_ATTRIBU { status = open_unix_file( handle, unix_name, access, &new_attr, attributes, sharing, disposition, options, ea_buffer, ea_length ); - free( unix_name ); } else WARN( "%s not found (%x)\n", debugstr_us(attr->ObjectName), status ); + free( unix_name ); if (status == STATUS_SUCCESS) { -- 2.34.1

2 1

[PATCH] ntdll: Remove extra call to getenv from virtual_init (scan-build)
by Alex Henrie 21 Dec '21

21 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ntdll/unix/virtual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/virtual.c b/dlls/ntdll/unix/virtual.c index 1f817cd977d..4ea33a2ef87 100644 --- a/dlls/ntdll/unix/virtual.c +++ b/dlls/ntdll/unix/virtual.c @@ -2647,7 +2647,7 @@ static int alloc_virtual_heap( void *base, SIZE_T size, void *arg ) void virtual_init(void) { const struct preload_info **preload_info = dlsym( RTLD_DEFAULT, "wine_main_preload_info" ); - const char *preload = getenv( "WINEPRELOADRESERVE" ); + const char *preload; struct alloc_virtual_heap alloc_views; size_t size; int i; -- 2.34.1

1 0

[PATCH] wlap32: Fix memory leak on error path in create_page_control (cppcheck)
by Alex Henrie 21 Dec '21

21 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/wldap32/page.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wldap32/page.c b/dlls/wldap32/page.c index 8b0ded40e35..9f4acbdaa16 100644 --- a/dlls/wldap32/page.c +++ b/dlls/wldap32/page.c @@ -96,6 +96,7 @@ static ULONG create_page_control( ULONG pagesize, struct berval *cookie, UCHAR c } if (!(ctrl->ldctl_oid = strAtoW( LDAP_PAGED_RESULT_OID_STRING ))) { + free( val ); free( ctrl ); return LDAP_NO_MEMORY; } -- 2.34.1

1 0

[PATCH] dbghelp: Fix memory leak on error path in dwarf2_read_range (cppcheck)
by Alex Henrie 21 Dec '21

21 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/dbghelp/dwarf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index 7515e540778..e086de1565e 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -1289,6 +1289,7 @@ static struct addr_range* dwarf2_get_ranges(const dwarf2_debug_info_t* di, unsig { struct attribute range; struct addr_range* ranges; + struct addr_range* new_ranges; if (dwarf2_find_attribute(di, DW_AT_ranges, &range)) { @@ -1312,8 +1313,13 @@ static struct addr_range* dwarf2_get_ranges(const dwarf2_debug_info_t* di, unsig if (*num_ranges >= alloc) { alloc *= 2; - ranges = realloc(ranges, sizeof(struct addr_range) * alloc); - if (!ranges) return NULL; + new_ranges = realloc(ranges, sizeof(struct addr_range) * alloc); + if (!new_ranges) + { + free(ranges); + return NULL; + } + ranges = new_ranges; } ranges[*num_ranges].low = di->unit_ctx->compiland->address + low; ranges[*num_ranges].high = di->unit_ctx->compiland->address + high; -- 2.34.1

1 0

[PATCH] conhost: Fix memory leak on error path in create_screen_buffer (cppcheck)
by Alex Henrie 21 Dec '21

21 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- programs/conhost/conhost.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/programs/conhost/conhost.c b/programs/conhost/conhost.c index 78f6e345170..3c8d165cbbe 100644 --- a/programs/conhost/conhost.c +++ b/programs/conhost/conhost.c @@ -100,7 +100,11 @@ static struct screen_buffer *create_screen_buffer( struct console *console, int if (screen_buffer->font.face_len) { screen_buffer->font.face_name = malloc( screen_buffer->font.face_len * sizeof(WCHAR) ); - if (!screen_buffer->font.face_name) return NULL; + if (!screen_buffer->font.face_name) + { + free( screen_buffer ); + return NULL; + } memcpy( screen_buffer->font.face_name, console->active->font.face_name, screen_buffer->font.face_len * sizeof(WCHAR) ); -- 2.34.1

1 0

[PATCH] mshtml: Avoid null pointer dereference in OmHistory_get_length (cppcheck)
by Alex Henrie 20 Dec '21

20 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/mshtml/omnavigator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/omnavigator.c b/dlls/mshtml/omnavigator.c index 70e8e568661..7788b453b8d 100644 --- a/dlls/mshtml/omnavigator.c +++ b/dlls/mshtml/omnavigator.c @@ -674,7 +674,7 @@ static HRESULT WINAPI OmHistory_get_length(IOmHistory *iface, short *p) if(This->window && This->window->base.outer_window) browser = This->window->base.outer_window->browser; - *p = browser->doc->travel_log + *p = browser && browser->doc->travel_log ? ITravelLog_CountEntries(browser->doc->travel_log, browser->doc->browser_service) : 0; return S_OK; -- 2.34.1

2 1

[PATCH] winebus.sys: Declare a variable only when used
by Gerald Pfeifer 20 Dec '21

20 Dec '21

One step towards a world with fewer warnings (GCC 12). -- udev_add_device declares a variable (product) even when it is not used on all platforms. Use the same condition for the declaration as for the code. Signed-off-by: Gerald Pfeifer <gerald(a)pfeifer.com> --- dlls/winebus.sys/bus_udev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/winebus.sys/bus_udev.c b/dlls/winebus.sys/bus_udev.c index 2269f5b904e..d3e060bf631 100644 --- a/dlls/winebus.sys/bus_udev.c +++ b/dlls/winebus.sys/bus_udev.c @@ -1245,7 +1245,9 @@ static void udev_add_device(struct udev_device *dev, int fd) if (!strcmp(subsystem, "hidraw")) { static const WCHAR hidraw[] = {'h','i','d','r','a','w',0}; +#ifdef HAVE_LINUX_HIDRAW_H char product[MAX_PATH]; +#endif if (!desc.manufacturer[0]) memcpy(desc.manufacturer, hidraw, sizeof(hidraw)); -- 2.32.0

1 0

[PATCH] msvcrt: support I width modifier in *scanf* family
by Eric Pouech 20 Dec '21

20 Dec '21

Despite what msdn states, I and I32 are supported width modifiers. V2: - better code structure - added support and tests for I32 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/msvcrt/scanf.h | 10 ++++++++-- dlls/msvcrt/tests/scanf.c | 46 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/scanf.h b/dlls/msvcrt/scanf.h index 3ab2efef13d..02284379854 100644 --- a/dlls/msvcrt/scanf.h +++ b/dlls/msvcrt/scanf.h @@ -279,13 +279,19 @@ _FUNCTION_ { *(format + 2) == '4') { I64_prefix = 1; format += 2; + break; } - break; + else if (*(format + 1) == '3' && + *(format + 2) == '2') { + format += 2; + break; + } + /* fall through */ #if _MSVCR_VER == 0 || _MSVCR_VER >= 140 case 'z': +#endif if (sizeof(void *) == sizeof(LONGLONG)) I64_prefix = 1; break; -#endif default: prefix_finished = 1; } diff --git a/dlls/msvcrt/tests/scanf.c b/dlls/msvcrt/tests/scanf.c index e175342796b..6541f5fd5cb 100644 --- a/dlls/msvcrt/tests/scanf.c +++ b/dlls/msvcrt/tests/scanf.c @@ -74,6 +74,7 @@ static void test_sscanf( void ) int hour=21,min=59,sec=20; int number,number_so_far; HMODULE hmod = GetModuleHandleA("msvcrt.dll"); + DWORD_PTR result_ptr; p_sprintf = (void *)GetProcAddress( hmod, "sprintf" ); p_sscanf = (void *)GetProcAddress( hmod, "sscanf" ); @@ -264,6 +265,51 @@ static void test_sscanf( void ) if(ret == 14) ok(!strcmp(buffer, buffer1), "got %s, expected %s\n", buffer1, buffer); + strcpy(buffer,"12345678901234"); + ret = p_sscanf(buffer, "%I64d", &result64); + ok(ret == 1, "Wrong number of arguments read: %d\n", ret); + ret = p_sprintf(buffer1, "%I64d", result64); + ok(ret==14 || broken(ret==10), "sprintf returned %d\n", ret); + if(ret == 14) + ok(!strcmp(buffer, buffer1), "got %s, expected %s\n", buffer1, buffer); + + result = 0; + strcpy(buffer,"0x123456789"); + ret = p_sscanf(buffer, "%I32x", &result); + ok(ret == 1, "Wrong number of arguments read: %d\n", ret); + ok(result == 0x23456789, "got %x, expected 0x23456789\n", result); + + result_ptr = 0; + strcpy(buffer,"0x87654321"); + ret = p_sscanf(buffer, "%Ix", &result_ptr); + ok(ret == 1, "Wrong number of arguments read: %d\n", ret); + if (sizeof(void*) == sizeof(LONGLONG)) + { + ret = p_sprintf(buffer1, "%#Ix", result_ptr); + ok(ret==9, "sprintf returned %d\n", ret); + if(ret == 9) + ok(!strcmp(buffer, buffer1), "got %s, expected %s\n", buffer1, buffer); + } + else + { + ok(result_ptr == 0x87654321, "got %x, expected 0x23456789\n", result); + } + result_ptr = 0; + strcpy(buffer,"0x123456789"); + ret = p_sscanf(buffer, "%Ix", &result_ptr); + ok(ret == 1, "Wrong number of arguments read: %d\n", ret); + if (sizeof(void*) == sizeof(LONGLONG)) + { + ret = p_sprintf(buffer1, "%#Ix", result_ptr); + ok(ret==11, "sprintf returned %d\n", ret); + if(ret == 11) + ok(!strcmp(buffer, buffer1), "got %s, expected %s\n", buffer1, buffer); + } + else + { + ok(result_ptr == 0x23456789, "got %x, expected 0x23456789\n", result); + } + /* Check %i according to bug 1878 */ strcpy(buffer,"123"); ret = p_sscanf(buffer, "%i", &result);

4 6

[PATCH 0/6] A couple of workarounds for warnings emitted by GCC11
by Eric Pouech 20 Dec '21

20 Dec '21

GCC11 implements new warnings. This serie of patches: - works around a couple of false positive - fixes a couple of bad handling of corner cases in error handling - last patch should be reviewed by D3D folks. The fix is consistent with function definition, and no regression appear in make test... A+ --- Eric Pouech (6): dlls/msvcrt*: ensure variable sse2_cw is set for all code paths in _control87 (GCC11) In tests, ensure buffers passed as const pointers are always initialized (GCC11) kernelbase: always return NULL in case of error in GetModuleHandleA (GCC11) kernel32/tests: mark pointer as volatile when reading after allocated size Workaround GCC11 complaining about sizeof(a)/sizeof(b) constructs when it's d3dx9_36/tests: fixed order of parameters dlls/d3dx9_36/mesh.c | 2 +- dlls/d3dx9_36/tests/effect.c | 4 ++-- dlls/d3dx9_36/tests/mesh.c | 4 ++-- dlls/kernel32/tests/heap.c | 3 ++- dlls/kernelbase/loader.c | 2 +- dlls/kernelbase/tests/path.c | 1 + dlls/msvcirt/tests/msvcirt.c | 5 +++-- dlls/msvcrt/math.c | 2 +- dlls/shlwapi/tests/clist.c | 1 + 9 files changed, 14 insertions(+), 10 deletions(-)

8 23

[PATCH vkd3d v3 03/12] vkd3d-shader/hlsl: Add aoffimmi modifiers on Sample sm4 instructions.
by Francisco Casas 20 Dec '21

20 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl_sm4.c | 39 ++++++++++++++++++++++++++++++++++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/libs/vkd3d-shader/hlsl_sm4.c b/libs/vkd3d-shader/hlsl_sm4.c index 07bbd376..11e1f59a 100644 --- a/libs/vkd3d-shader/hlsl_sm4.c +++ b/libs/vkd3d-shader/hlsl_sm4.c @@ -1306,14 +1306,47 @@ static void write_sm4_ld(struct hlsl_ctx *ctx, struct vkd3d_bytecode_buffer *buf static void write_sm4_sample(struct hlsl_ctx *ctx, struct vkd3d_bytecode_buffer *buffer, const struct hlsl_type *resource_type, const struct hlsl_ir_node *dst, - const struct hlsl_deref *resource, const struct hlsl_deref *sampler, const struct hlsl_ir_node *coords) + const struct hlsl_deref *resource, const struct hlsl_deref *sampler, + const struct hlsl_ir_node *coords, const struct hlsl_ir_node *texel_offset) { + struct hlsl_ir_constant *offset; struct sm4_instruction instr; unsigned int writemask; memset(&instr, 0, sizeof(instr)); instr.opcode = VKD3D_SM4_OP_SAMPLE; + if (texel_offset) + { + struct sm4_instruction_modifier modif; + int valid_aoffimmi = 1; + + if (texel_offset->type != HLSL_IR_CONSTANT) + valid_aoffimmi = 0; + else + { + offset = hlsl_ir_constant(texel_offset); + modif.type = VKD3D_SM4_MODIFIER_AOFFIMMI; + modif.aoffimmi.u = offset->value[0].i; + modif.aoffimmi.v = offset->value[1].i; + modif.aoffimmi.w = offset->value[2].i; + instr.modifiers[instr.modifier_count] = modif; + instr.modifier_count++; + + valid_aoffimmi &= -8 <= modif.aoffimmi.u && modif.aoffimmi.u <= 7; + valid_aoffimmi &= -8 <= modif.aoffimmi.v && modif.aoffimmi.v <= 7; + valid_aoffimmi &= -8 <= modif.aoffimmi.w && modif.aoffimmi.w <= 7; + } + + if (!valid_aoffimmi) + { + hlsl_error(ctx, &texel_offset->loc, VKD3D_SHADER_ERROR_HLSL_INVALID_TYPE, + "Offset must resolve to integer literal in the range -8 to 7\n"); + return; + } + + } + sm4_register_from_node(&instr.dsts[0].reg, &instr.dsts[0].writemask, NULL, dst); instr.dst_count = 1; @@ -1626,6 +1659,7 @@ static void write_sm4_resource_load(struct hlsl_ctx *ctx, { const struct hlsl_type *resource_type = load->resource.var->data_type; const struct hlsl_ir_node *coords = load->coords.node; + const struct hlsl_ir_node *texel_offset = load->texel_offset.node; if (load->sampler.var) { @@ -1657,7 +1691,8 @@ static void write_sm4_resource_load(struct hlsl_ctx *ctx, case HLSL_RESOURCE_SAMPLE: if (!load->sampler.var) hlsl_fixme(ctx, &load->node.loc, "SM4 combined sample expression."); - write_sm4_sample(ctx, buffer, resource_type, &load->node, &load->resource, &load->sampler, coords); + write_sm4_sample(ctx, buffer, resource_type, &load->node, &load->resource, &load->sampler, + coords, texel_offset); break; } } -- 2.25.1

3 5

[PATCH vkd3d v3 02/12] vkd3d-shader/hlsl: Add texel_offset field to hlsl_ir_resource_load.
by Francisco Casas 20 Dec '21

20 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl.c | 9 ++++++++- libs/vkd3d-shader/hlsl.h | 3 ++- libs/vkd3d-shader/hlsl.y | 14 ++++++++++---- libs/vkd3d-shader/hlsl_codegen.c | 2 ++ 4 files changed, 22 insertions(+), 6 deletions(-) diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c index d2ea4c34..b426e461 100644 --- a/libs/vkd3d-shader/hlsl.c +++ b/libs/vkd3d-shader/hlsl.c @@ -641,7 +641,7 @@ struct hlsl_ir_load *hlsl_new_var_load(struct hlsl_ctx *ctx, struct hlsl_ir_var struct hlsl_ir_resource_load *hlsl_new_resource_load(struct hlsl_ctx *ctx, struct hlsl_type *data_type, enum hlsl_resource_load_type type, struct hlsl_ir_var *resource, struct hlsl_ir_node *resource_offset, struct hlsl_ir_var *sampler, struct hlsl_ir_node *sampler_offset, struct hlsl_ir_node *coords, - const struct vkd3d_shader_location *loc) + struct hlsl_ir_node *texel_offset, const struct vkd3d_shader_location *loc) { struct hlsl_ir_resource_load *load; @@ -654,6 +654,7 @@ struct hlsl_ir_resource_load *hlsl_new_resource_load(struct hlsl_ctx *ctx, struc load->sampler.var = sampler; hlsl_src_from_node(&load->sampler.offset, sampler_offset); hlsl_src_from_node(&load->coords, coords); + hlsl_src_from_node(&load->texel_offset, texel_offset); return load; } @@ -1284,6 +1285,11 @@ static void dump_ir_resource_load(struct vkd3d_string_buffer *buffer, const stru dump_deref(buffer, &load->sampler); vkd3d_string_buffer_printf(buffer, ", coords = "); dump_src(buffer, &load->coords); + if (load->texel_offset.node) + { + vkd3d_string_buffer_printf(buffer, ", offset = "); + dump_src(buffer, &load->texel_offset); + } vkd3d_string_buffer_printf(buffer, ")"); } @@ -1457,6 +1463,7 @@ static void free_ir_resource_load(struct hlsl_ir_resource_load *load) hlsl_src_remove(&load->coords); hlsl_src_remove(&load->sampler.offset); hlsl_src_remove(&load->resource.offset); + hlsl_src_remove(&load->texel_offset); vkd3d_free(load); } diff --git a/libs/vkd3d-shader/hlsl.h b/libs/vkd3d-shader/hlsl.h index 57acf3a0..2396adb4 100644 --- a/libs/vkd3d-shader/hlsl.h +++ b/libs/vkd3d-shader/hlsl.h @@ -386,6 +386,7 @@ struct hlsl_ir_resource_load enum hlsl_resource_load_type load_type; struct hlsl_deref resource, sampler; struct hlsl_src coords; + struct hlsl_src texel_offset; }; struct hlsl_ir_store @@ -710,7 +711,7 @@ struct hlsl_ir_loop *hlsl_new_loop(struct hlsl_ctx *ctx, struct vkd3d_shader_loc struct hlsl_ir_resource_load *hlsl_new_resource_load(struct hlsl_ctx *ctx, struct hlsl_type *data_type, enum hlsl_resource_load_type type, struct hlsl_ir_var *resource, struct hlsl_ir_node *resource_offset, struct hlsl_ir_var *sampler, struct hlsl_ir_node *sampler_offset, struct hlsl_ir_node *coords, - const struct vkd3d_shader_location *loc); + struct hlsl_ir_node *texel_offset, const struct vkd3d_shader_location *loc); struct hlsl_ir_store *hlsl_new_simple_store(struct hlsl_ctx *ctx, struct hlsl_ir_var *lhs, struct hlsl_ir_node *rhs); struct hlsl_ir_store *hlsl_new_store(struct hlsl_ctx *ctx, struct hlsl_ir_var *var, struct hlsl_ir_node *offset, struct hlsl_ir_node *rhs, unsigned int writemask, struct vkd3d_shader_location loc); diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y index 636882c4..33bfee5b 100644 --- a/libs/vkd3d-shader/hlsl.y +++ b/libs/vkd3d-shader/hlsl.y @@ -1875,7 +1875,7 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl return false; if (!(load = hlsl_new_resource_load(ctx, object_type->e.resource_format, HLSL_RESOURCE_LOAD, - object_load->src.var, object_load->src.offset.node, NULL, NULL, coords, loc))) + object_load->src.var, object_load->src.offset.node, NULL, NULL, coords, NULL, loc))) return false; list_add_tail(instrs, &load->node.entry); return true; @@ -1885,6 +1885,7 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl const unsigned int sampler_dim = sampler_dim_count(object_type->sampler_dim); const struct hlsl_type *sampler_type; struct hlsl_ir_resource_load *load; + struct hlsl_ir_node *offset = NULL; struct hlsl_ir_load *sampler_load; struct hlsl_ir_node *coords; @@ -1894,8 +1895,6 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl "Wrong number of arguments to method 'Sample': expected 2 or 3, but got %u.", params->args_count); return false; } - if (params->args_count == 3) - FIXME("Ignoring offset parameter.\n"); sampler_type = params->args[0]->data_type; if (sampler_type->type != HLSL_CLASS_OBJECT || sampler_type->base_type != HLSL_TYPE_SAMPLER @@ -1917,9 +1916,16 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl hlsl_get_vector_type(ctx, HLSL_TYPE_FLOAT, sampler_dim), loc))) coords = params->args[1]; + if (params->args_count == 3) + { + if (!(offset = add_implicit_conversion(ctx, instrs, params->args[2], + hlsl_get_vector_type(ctx, HLSL_TYPE_INT, sampler_dim), loc))) + offset = params->args[2]; + } + if (!(load = hlsl_new_resource_load(ctx, object_type->e.resource_format, HLSL_RESOURCE_SAMPLE, object_load->src.var, object_load->src.offset.node, - sampler_load->src.var, sampler_load->src.offset.node, coords, loc))) + sampler_load->src.var, sampler_load->src.offset.node, coords, offset, loc))) return false; list_add_tail(instrs, &load->node.entry); return true; diff --git a/libs/vkd3d-shader/hlsl_codegen.c b/libs/vkd3d-shader/hlsl_codegen.c index 75716bdf..8918dc27 100644 --- a/libs/vkd3d-shader/hlsl_codegen.c +++ b/libs/vkd3d-shader/hlsl_codegen.c @@ -964,6 +964,8 @@ static void compute_liveness_recurse(struct hlsl_block *block, unsigned int loop } load->coords.node->last_read = instr->index; + if (load->texel_offset.node) + load->texel_offset.node->last_read = instr->index; break; } case HLSL_IR_SWIZZLE: -- 2.25.1

3 4

[PATCH vkd3d v3 09/12] vkd3d-shader/hlsl: Parse texture array types.
by Francisco Casas 20 Dec '21

20 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- Multisampled objects, namely Texture2DMS and Texture2DMSArray are not parsed yet since they require a different type of declaration, with the number of samples stated expicitly. Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl.l | 1 + libs/vkd3d-shader/hlsl.y | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/libs/vkd3d-shader/hlsl.l b/libs/vkd3d-shader/hlsl.l index e9281ec3..126cad30 100644 --- a/libs/vkd3d-shader/hlsl.l +++ b/libs/vkd3d-shader/hlsl.l @@ -134,6 +134,7 @@ Texture3D {return KW_TEXTURE3D; } Texture3DArray {return KW_TEXTURE3DARRAY; } textureCUBE {return KW_TEXTURECUBE; } TextureCube {return KW_TEXTURECUBE; } +TextureCubeArray {return KW_TEXTURECUBEARRAY; } true {return KW_TRUE; } typedef {return KW_TYPEDEF; } uniform {return KW_UNIFORM; } diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y index 9aa0138d..b7446454 100644 --- a/libs/vkd3d-shader/hlsl.y +++ b/libs/vkd3d-shader/hlsl.y @@ -2148,6 +2148,7 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl %token KW_TEXTURE3D %token KW_TEXTURE3DARRAY %token KW_TEXTURECUBE +%token KW_TEXTURECUBEARRAY %token KW_TRUE %token KW_TYPEDEF %token KW_UNIFORM @@ -2692,6 +2693,18 @@ texture_type: { $$ = HLSL_SAMPLER_DIM_CUBE; } + | KW_TEXTURE1DARRAY + { + $$ = HLSL_SAMPLER_DIM_1DARRAY; + } + | KW_TEXTURE2DARRAY + { + $$ = HLSL_SAMPLER_DIM_2DARRAY; + } + | KW_TEXTURECUBEARRAY + { + $$ = HLSL_SAMPLER_DIM_CUBEARRAY; + } type: KW_VECTOR '<' type ',' C_INTEGER '>' -- 2.25.1

2 3

[PATCH] quartz: Fix memory leaks on error paths in FilterMapper3_RegisterFilter (cppcheck)
by Alex Henrie 20 Dec '21

20 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/quartz/filtermapper.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c index 230273891d4..a95f0ca7832 100644 --- a/dlls/quartz/filtermapper.c +++ b/dlls/quartz/filtermapper.c @@ -894,12 +894,16 @@ static HRESULT WINAPI FilterMapper3_RegisterFilter(IFilterMapper3 *iface, if (FAILED(hr = CoCreateInstance(&CLSID_CDeviceMoniker, NULL, CLSCTX_INPROC, &IID_IParseDisplayName, (void **)&parser))) + { + free(display_name); return hr; + } if (FAILED(hr = IParseDisplayName_ParseDisplayName(parser, NULL, display_name, &eaten, &moniker))) { ERR("Failed to parse display name, hr %#x.\n", hr); IParseDisplayName_Release(parser); + free(display_name); return hr; } @@ -909,6 +913,7 @@ static HRESULT WINAPI FilterMapper3_RegisterFilter(IFilterMapper3 *iface, { ERR("Failed to get property bag, hr %#x.\n", hr); IMoniker_Release(moniker); + free(display_name); return hr; } -- 2.34.1

3 2

[PATCH] win32u: Comment out stubs for Nt functions.
by Paul Gofman 20 Dec '21

20 Dec '21

Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- The presence of the stubs may be provoking games to start using the functions. Fixes Quake Champions crash on start (in this specific case it is NtUserBuildHwndList()). We should be probably adding the stubs as soon as they help some app and as a proper syscalls, not as spec file stubs. dlls/win32u/win32u.spec | 2174 +++++++++++++++++++-------------------- 1 file changed, 1087 insertions(+), 1087 deletions(-) diff --git a/dlls/win32u/win32u.spec b/dlls/win32u/win32u.spec index e13148af633..deaea212039 100644 --- a/dlls/win32u/win32u.spec +++ b/dlls/win32u/win32u.spec @@ -1,150 +1,150 @@ @ extern -arch=win32 Wow64Transition __wine_syscall_dispatcher -@ stub NtBindCompositionSurface -@ stub NtCloseCompositionInputSink -@ stub NtCompositionInputThread -@ stub NtCompositionSetDropTarget -@ stub NtCompositorNotifyExitWindows -@ stub NtCompositorNotifyForegroundChanged -@ stub NtCompositorUpdateLastInputTime -@ stub NtConfigureInputSpace -@ stub NtCreateCompositionInputSink -@ stub NtCreateCompositionSurfaceHandle -@ stub NtCreateImplicitCompositionInputSink -@ stub NtDCompositionAddCrossDeviceVisualChild -@ stub NtDCompositionBeginFrame -@ stub NtDCompositionCommitChannel -@ stub NtDCompositionCommitSynchronizationObject -@ stub NtDCompositionConfirmFrame -@ stub NtDCompositionConnectPipe -@ stub NtDCompositionCreateAndBindSharedSection -@ stub NtDCompositionCreateChannel -@ stub NtDCompositionCreateConnection -@ stub NtDCompositionCreateDwmChannel -@ stub NtDCompositionCreateSharedResourceHandle -@ stub NtDCompositionCreateSynchronizationObject -@ stub NtDCompositionDestroyChannel -@ stub NtDCompositionDestroyConnection -@ stub NtDCompositionDiscardFrame -@ stub NtDCompositionDuplicateHandleToProcess -@ stub NtDCompositionDuplicateSwapchainHandleToDwm -@ stub NtDCompositionEnableMMCSS -@ stub NtDCompositionGetBatchId -@ stub NtDCompositionGetChannels -@ stub NtDCompositionGetConnectionBatch -@ stub NtDCompositionGetDeletedResources -@ stub NtDCompositionGetFrameLegacyTokens -@ stub NtDCompositionGetFrameStatistics -@ stub NtDCompositionGetFrameSurfaceUpdates -@ stub NtDCompositionGetMaterialProperty -@ stub NtDCompositionProcessChannelBatchBuffer -@ stub NtDCompositionReferenceSharedResourceOnDwmChannel -@ stub NtDCompositionRegisterThumbnailVisual -@ stub NtDCompositionRegisterVirtualDesktopVisual -@ stub NtDCompositionReleaseAllResources -@ stub NtDCompositionRemoveCrossDeviceVisualChild -@ stub NtDCompositionRetireFrame -@ stub NtDCompositionSetChannelCommitCompletionEvent -@ stub NtDCompositionSetChannelConnectionId -@ stub NtDCompositionSetChildRootVisual -@ stub NtDCompositionSetDebugCounter -@ stub NtDCompositionSetMaterialProperty -@ stub NtDCompositionSubmitDWMBatch -@ stub NtDCompositionSuspendAnimations -@ stub NtDCompositionSynchronize -@ stub NtDCompositionTelemetryAnimationScenarioBegin -@ stub NtDCompositionTelemetryAnimationScenarioReference -@ stub NtDCompositionTelemetryAnimationScenarioUnreference -@ stub NtDCompositionTelemetrySetApplicationId -@ stub NtDCompositionTelemetryTouchInteractionBegin -@ stub NtDCompositionTelemetryTouchInteractionEnd -@ stub NtDCompositionTelemetryTouchInteractionUpdate -@ stub NtDCompositionUpdatePointerCapture -@ stub NtDCompositionWaitForChannel -@ stub NtDesktopCaptureBits -@ stub NtDuplicateCompositionInputSink -@ stub NtDxgkCreateTrackedWorkload -@ stub NtDxgkDestroyTrackedWorkload -@ stub NtDxgkDispMgrOperation -@ stub NtDxgkDisplayPortOperation -@ stub NtDxgkDuplicateHandle -@ stub NtDxgkEnumAdapters3 -@ stub NtDxgkGetAvailableTrackedWorkloadIndex -@ stub NtDxgkGetProcessList -@ stub NtDxgkGetTrackedWorkloadStatistics -@ stub NtDxgkOutputDuplPresentToHwQueue -@ stub NtDxgkPinResources -@ stub NtDxgkRegisterVailProcess -@ stub NtDxgkResetTrackedWorkloadStatistics -@ stub NtDxgkSubmitPresentBltToHwQueue -@ stub NtDxgkSubmitPresentToHwQueue -@ stub NtDxgkUnpinResources -@ stub NtDxgkUpdateTrackedWorkload -@ stub NtDxgkVailConnect -@ stub NtDxgkVailDisconnect -@ stub NtDxgkVailPromoteCompositionSurface -@ stub NtEnableOneCoreTransformMode -@ stub NtFlipObjectAddContent -@ stub NtFlipObjectAddPoolBuffer -@ stub NtFlipObjectConsumerAcquirePresent -@ stub NtFlipObjectConsumerAdjustUsageReference -@ stub NtFlipObjectConsumerBeginProcessPresent -@ stub NtFlipObjectConsumerEndProcessPresent -@ stub NtFlipObjectConsumerPostMessage -@ stub NtFlipObjectConsumerQueryBufferInfo -@ stub NtFlipObjectCreate -@ stub NtFlipObjectDisconnectEndpoint -@ stub NtFlipObjectEnablePresentStatisticsType -@ stub NtFlipObjectOpen -@ stub NtFlipObjectPresentCancel -@ stub NtFlipObjectQueryBufferAvailableEvent -@ stub NtFlipObjectQueryEndpointConnected -@ stub NtFlipObjectQueryNextMessageToProducer -@ stub NtFlipObjectReadNextMessageToProducer -@ stub NtFlipObjectRemoveContent -@ stub NtFlipObjectRemovePoolBuffer -@ stub NtFlipObjectSetContent -@ stub NtFlipObjectSetMaximumBackchannelQueueDepth +# @ stub NtBindCompositionSurface +# @ stub NtCloseCompositionInputSink +# @ stub NtCompositionInputThread +# @ stub NtCompositionSetDropTarget +# @ stub NtCompositorNotifyExitWindows +# @ stub NtCompositorNotifyForegroundChanged +# @ stub NtCompositorUpdateLastInputTime +# @ stub NtConfigureInputSpace +# @ stub NtCreateCompositionInputSink +# @ stub NtCreateCompositionSurfaceHandle +# @ stub NtCreateImplicitCompositionInputSink +# @ stub NtDCompositionAddCrossDeviceVisualChild +# @ stub NtDCompositionBeginFrame +# @ stub NtDCompositionCommitChannel +# @ stub NtDCompositionCommitSynchronizationObject +# @ stub NtDCompositionConfirmFrame +# @ stub NtDCompositionConnectPipe +# @ stub NtDCompositionCreateAndBindSharedSection +# @ stub NtDCompositionCreateChannel +# @ stub NtDCompositionCreateConnection +# @ stub NtDCompositionCreateDwmChannel +# @ stub NtDCompositionCreateSharedResourceHandle +# @ stub NtDCompositionCreateSynchronizationObject +# @ stub NtDCompositionDestroyChannel +# @ stub NtDCompositionDestroyConnection +# @ stub NtDCompositionDiscardFrame +# @ stub NtDCompositionDuplicateHandleToProcess +# @ stub NtDCompositionDuplicateSwapchainHandleToDwm +# @ stub NtDCompositionEnableMMCSS +# @ stub NtDCompositionGetBatchId +# @ stub NtDCompositionGetChannels +# @ stub NtDCompositionGetConnectionBatch +# @ stub NtDCompositionGetDeletedResources +# @ stub NtDCompositionGetFrameLegacyTokens +# @ stub NtDCompositionGetFrameStatistics +# @ stub NtDCompositionGetFrameSurfaceUpdates +# @ stub NtDCompositionGetMaterialProperty +# @ stub NtDCompositionProcessChannelBatchBuffer +# @ stub NtDCompositionReferenceSharedResourceOnDwmChannel +# @ stub NtDCompositionRegisterThumbnailVisual +# @ stub NtDCompositionRegisterVirtualDesktopVisual +# @ stub NtDCompositionReleaseAllResources +# @ stub NtDCompositionRemoveCrossDeviceVisualChild +# @ stub NtDCompositionRetireFrame +# @ stub NtDCompositionSetChannelCommitCompletionEvent +# @ stub NtDCompositionSetChannelConnectionId +# @ stub NtDCompositionSetChildRootVisual +# @ stub NtDCompositionSetDebugCounter +# @ stub NtDCompositionSetMaterialProperty +# @ stub NtDCompositionSubmitDWMBatch +# @ stub NtDCompositionSuspendAnimations +# @ stub NtDCompositionSynchronize +# @ stub NtDCompositionTelemetryAnimationScenarioBegin +# @ stub NtDCompositionTelemetryAnimationScenarioReference +# @ stub NtDCompositionTelemetryAnimationScenarioUnreference +# @ stub NtDCompositionTelemetrySetApplicationId +# @ stub NtDCompositionTelemetryTouchInteractionBegin +# @ stub NtDCompositionTelemetryTouchInteractionEnd +# @ stub NtDCompositionTelemetryTouchInteractionUpdate +# @ stub NtDCompositionUpdatePointerCapture +# @ stub NtDCompositionWaitForChannel +# @ stub NtDesktopCaptureBits +# @ stub NtDuplicateCompositionInputSink +# @ stub NtDxgkCreateTrackedWorkload +# @ stub NtDxgkDestroyTrackedWorkload +# @ stub NtDxgkDispMgrOperation +# @ stub NtDxgkDisplayPortOperation +# @ stub NtDxgkDuplicateHandle +# @ stub NtDxgkEnumAdapters3 +# @ stub NtDxgkGetAvailableTrackedWorkloadIndex +# @ stub NtDxgkGetProcessList +# @ stub NtDxgkGetTrackedWorkloadStatistics +# @ stub NtDxgkOutputDuplPresentToHwQueue +# @ stub NtDxgkPinResources +# @ stub NtDxgkRegisterVailProcess +# @ stub NtDxgkResetTrackedWorkloadStatistics +# @ stub NtDxgkSubmitPresentBltToHwQueue +# @ stub NtDxgkSubmitPresentToHwQueue +# @ stub NtDxgkUnpinResources +# @ stub NtDxgkUpdateTrackedWorkload +# @ stub NtDxgkVailConnect +# @ stub NtDxgkVailDisconnect +# @ stub NtDxgkVailPromoteCompositionSurface +# @ stub NtEnableOneCoreTransformMode +# @ stub NtFlipObjectAddContent +# @ stub NtFlipObjectAddPoolBuffer +# @ stub NtFlipObjectConsumerAcquirePresent +# @ stub NtFlipObjectConsumerAdjustUsageReference +# @ stub NtFlipObjectConsumerBeginProcessPresent +# @ stub NtFlipObjectConsumerEndProcessPresent +# @ stub NtFlipObjectConsumerPostMessage +# @ stub NtFlipObjectConsumerQueryBufferInfo +# @ stub NtFlipObjectCreate +# @ stub NtFlipObjectDisconnectEndpoint +# @ stub NtFlipObjectEnablePresentStatisticsType +# @ stub NtFlipObjectOpen +# @ stub NtFlipObjectPresentCancel +# @ stub NtFlipObjectQueryBufferAvailableEvent +# @ stub NtFlipObjectQueryEndpointConnected +# @ stub NtFlipObjectQueryNextMessageToProducer +# @ stub NtFlipObjectReadNextMessageToProducer +# @ stub NtFlipObjectRemoveContent +# @ stub NtFlipObjectRemovePoolBuffer +# @ stub NtFlipObjectSetContent +# @ stub NtFlipObjectSetMaximumBackchannelQueueDepth @ stdcall NtGdiAbortDoc(long) @ stdcall NtGdiAbortPath(long) -@ stub NtGdiAddEmbFontToDC +# @ stub NtGdiAddEmbFontToDC @ stdcall -syscall NtGdiAddFontMemResourceEx(ptr long ptr long ptr) @ stdcall -syscall NtGdiAddFontResourceW(wstr long long long long ptr) -@ stub NtGdiAddInitialFonts -@ stub NtGdiAddRemoteFontToDC -@ stub NtGdiAddRemoteMMInstanceToDC +# @ stub NtGdiAddInitialFonts +# @ stub NtGdiAddRemoteFontToDC +# @ stub NtGdiAddRemoteMMInstanceToDC @ stdcall NtGdiAlphaBlend(long long long long long long long long long long long ptr) @ stdcall NtGdiAngleArc(long long long long float float) -@ stub NtGdiAnyLinkedFonts +# @ stub NtGdiAnyLinkedFonts @ stdcall NtGdiArcInternal(long long long long long long long long long long) -@ stub NtGdiBRUSHOBJ_DeleteRbrush -@ stub NtGdiBRUSHOBJ_hGetColorTransform -@ stub NtGdiBRUSHOBJ_pvAllocRbrush -@ stub NtGdiBRUSHOBJ_pvGetRbrush -@ stub NtGdiBRUSHOBJ_ulGetBrushColor -@ stub NtGdiBeginGdiRendering +# @ stub NtGdiBRUSHOBJ_DeleteRbrush +# @ stub NtGdiBRUSHOBJ_hGetColorTransform +# @ stub NtGdiBRUSHOBJ_pvAllocRbrush +# @ stub NtGdiBRUSHOBJ_pvGetRbrush +# @ stub NtGdiBRUSHOBJ_ulGetBrushColor +# @ stub NtGdiBeginGdiRendering @ stdcall NtGdiBeginPath(long) @ stdcall NtGdiBitBlt(long long long long long long long long long long float) -@ stub NtGdiCLIPOBJ_bEnum -@ stub NtGdiCLIPOBJ_cEnumStart -@ stub NtGdiCLIPOBJ_ppoGetPath -@ stub NtGdiCancelDC -@ stub NtGdiChangeGhostFont -@ stub NtGdiCheckBitmapBits -@ stub NtGdiClearBitmapAttributes -@ stub NtGdiClearBrushAttributes +# @ stub NtGdiCLIPOBJ_bEnum +# @ stub NtGdiCLIPOBJ_cEnumStart +# @ stub NtGdiCLIPOBJ_ppoGetPath +# @ stub NtGdiCancelDC +# @ stub NtGdiChangeGhostFont +# @ stub NtGdiCheckBitmapBits +# @ stub NtGdiClearBitmapAttributes +# @ stub NtGdiClearBrushAttributes @ stdcall NtGdiCloseFigure(long) -@ stub NtGdiColorCorrectPalette +# @ stub NtGdiColorCorrectPalette @ stdcall -syscall NtGdiCombineRgn(long long long long) -@ stub NtGdiCombineTransform +# @ stub NtGdiCombineTransform @ stdcall NtGdiComputeXformCoefficients(long) -@ stub NtGdiConfigureOPMProtectedOutput -@ stub NtGdiConvertMetafileRect +# @ stub NtGdiConfigureOPMProtectedOutput +# @ stub NtGdiConvertMetafileRect @ stdcall -syscall NtGdiCreateBitmap(long long long long ptr) -@ stub NtGdiCreateBitmapFromDxSurface -@ stub NtGdiCreateBitmapFromDxSurface2 +# @ stub NtGdiCreateBitmapFromDxSurface +# @ stub NtGdiCreateBitmapFromDxSurface2 @ stdcall -syscall NtGdiCreateClientObj(long) -@ stub NtGdiCreateColorSpace -@ stub NtGdiCreateColorTransform +# @ stub NtGdiCreateColorSpace +# @ stub NtGdiCreateColorTransform @ stdcall NtGdiCreateCompatibleBitmap(long long long) @ stdcall NtGdiCreateCompatibleDC(long) @ stdcall -syscall NtGdiCreateDIBBrush(ptr long long long long ptr) @@ -154,269 +154,269 @@ @ stdcall -syscall NtGdiCreateHalftonePalette(long) @ stdcall -syscall NtGdiCreateHatchBrushInternal(long long long) @ stdcall NtGdiCreateMetafileDC(long) -@ stub NtGdiCreateOPMProtectedOutput -@ stub NtGdiCreateOPMProtectedOutputs +# @ stub NtGdiCreateOPMProtectedOutput +# @ stub NtGdiCreateOPMProtectedOutputs @ stdcall -syscall NtGdiCreatePaletteInternal(ptr long) @ stdcall -syscall NtGdiCreatePatternBrushInternal(long long long) @ stdcall -syscall NtGdiCreatePen(long long long long) @ stdcall -syscall NtGdiCreateRectRgn(long long long long) @ stdcall -syscall NtGdiCreateRoundRectRgn(long long long long long long) -@ stub NtGdiCreateServerMetaFile -@ stub NtGdiCreateSessionMappedDIBSection +# @ stub NtGdiCreateServerMetaFile +# @ stub NtGdiCreateSessionMappedDIBSection @ stdcall -syscall NtGdiCreateSolidBrush(long long) -@ stub NtGdiDDCCIGetCapabilitiesString -@ stub NtGdiDDCCIGetCapabilitiesStringLength -@ stub NtGdiDDCCIGetTimingReport -@ stub NtGdiDDCCIGetVCPFeature -@ stub NtGdiDDCCISaveCurrentSettings -@ stub NtGdiDDCCISetVCPFeature -@ stub NtGdiDdCreateFullscreenSprite -@ stub NtGdiDdDDIAbandonSwapChain -@ stub NtGdiDdDDIAcquireKeyedMutex -@ stub NtGdiDdDDIAcquireKeyedMutex2 -@ stub NtGdiDdDDIAcquireSwapChain -@ stub NtGdiDdDDIAddSurfaceToSwapChain -@ stub NtGdiDdDDIAdjustFullscreenGamma -@ stub NtGdiDdDDICacheHybridQueryValue -@ stub NtGdiDdDDIChangeVideoMemoryReservation -@ stub NtGdiDdDDICheckExclusiveOwnership -@ stub NtGdiDdDDICheckMonitorPowerState -@ stub NtGdiDdDDICheckMultiPlaneOverlaySupport -@ stub NtGdiDdDDICheckMultiPlaneOverlaySupport2 -@ stub NtGdiDdDDICheckMultiPlaneOverlaySupport3 -@ stub NtGdiDdDDICheckOcclusion -@ stub NtGdiDdDDICheckSharedResourceAccess +# @ stub NtGdiDDCCIGetCapabilitiesString +# @ stub NtGdiDDCCIGetCapabilitiesStringLength +# @ stub NtGdiDDCCIGetTimingReport +# @ stub NtGdiDDCCIGetVCPFeature +# @ stub NtGdiDDCCISaveCurrentSettings +# @ stub NtGdiDDCCISetVCPFeature +# @ stub NtGdiDdCreateFullscreenSprite +# @ stub NtGdiDdDDIAbandonSwapChain +# @ stub NtGdiDdDDIAcquireKeyedMutex +# @ stub NtGdiDdDDIAcquireKeyedMutex2 +# @ stub NtGdiDdDDIAcquireSwapChain +# @ stub NtGdiDdDDIAddSurfaceToSwapChain +# @ stub NtGdiDdDDIAdjustFullscreenGamma +# @ stub NtGdiDdDDICacheHybridQueryValue +# @ stub NtGdiDdDDIChangeVideoMemoryReservation +# @ stub NtGdiDdDDICheckExclusiveOwnership +# @ stub NtGdiDdDDICheckMonitorPowerState +# @ stub NtGdiDdDDICheckMultiPlaneOverlaySupport +# @ stub NtGdiDdDDICheckMultiPlaneOverlaySupport2 +# @ stub NtGdiDdDDICheckMultiPlaneOverlaySupport3 +# @ stub NtGdiDdDDICheckOcclusion +# @ stub NtGdiDdDDICheckSharedResourceAccess @ stdcall NtGdiDdDDICheckVidPnExclusiveOwnership(ptr) @ stdcall -syscall NtGdiDdDDICloseAdapter(ptr) -@ stub NtGdiDdDDIConfigureSharedResource -@ stub NtGdiDdDDICreateAllocation -@ stub NtGdiDdDDICreateBundleObject -@ stub NtGdiDdDDICreateContext -@ stub NtGdiDdDDICreateContextVirtual +# @ stub NtGdiDdDDIConfigureSharedResource +# @ stub NtGdiDdDDICreateAllocation +# @ stub NtGdiDdDDICreateBundleObject +# @ stub NtGdiDdDDICreateContext +# @ stub NtGdiDdDDICreateContextVirtual @ stdcall NtGdiDdDDICreateDCFromMemory(ptr) @ stdcall -syscall NtGdiDdDDICreateDevice(ptr) -@ stub NtGdiDdDDICreateHwContext -@ stub NtGdiDdDDICreateHwQueue -@ stub NtGdiDdDDICreateKeyedMutex -@ stub NtGdiDdDDICreateKeyedMutex2 -@ stub NtGdiDdDDICreateOutputDupl -@ stub NtGdiDdDDICreateOverlay -@ stub NtGdiDdDDICreatePagingQueue -@ stub NtGdiDdDDICreateProtectedSession -@ stub NtGdiDdDDICreateSwapChain -@ stub NtGdiDdDDICreateSynchronizationObject -@ stub NtGdiDdDDIDDisplayEnum -@ stub NtGdiDdDDIDestroyAllocation -@ stub NtGdiDdDDIDestroyAllocation2 -@ stub NtGdiDdDDIDestroyContext +# @ stub NtGdiDdDDICreateHwContext +# @ stub NtGdiDdDDICreateHwQueue +# @ stub NtGdiDdDDICreateKeyedMutex +# @ stub NtGdiDdDDICreateKeyedMutex2 +# @ stub NtGdiDdDDICreateOutputDupl +# @ stub NtGdiDdDDICreateOverlay +# @ stub NtGdiDdDDICreatePagingQueue +# @ stub NtGdiDdDDICreateProtectedSession +# @ stub NtGdiDdDDICreateSwapChain +# @ stub NtGdiDdDDICreateSynchronizationObject +# @ stub NtGdiDdDDIDDisplayEnum +# @ stub NtGdiDdDDIDestroyAllocation +# @ stub NtGdiDdDDIDestroyAllocation2 +# @ stub NtGdiDdDDIDestroyContext @ stdcall NtGdiDdDDIDestroyDCFromMemory(ptr) @ stdcall NtGdiDdDDIDestroyDevice(ptr) -@ stub NtGdiDdDDIDestroyHwContext -@ stub NtGdiDdDDIDestroyHwQueue -@ stub NtGdiDdDDIDestroyKeyedMutex -@ stub NtGdiDdDDIDestroyOutputDupl -@ stub NtGdiDdDDIDestroyOverlay -@ stub NtGdiDdDDIDestroyPagingQueue -@ stub NtGdiDdDDIDestroyProtectedSession -@ stub NtGdiDdDDIDestroySynchronizationObject -@ stub NtGdiDdDDIDispMgrCreate -@ stub NtGdiDdDDIDispMgrSourceOperation -@ stub NtGdiDdDDIDispMgrTargetOperation -@ stub NtGdiDdDDIEnumAdapters -@ stub NtGdiDdDDIEnumAdapters2 +# @ stub NtGdiDdDDIDestroyHwContext +# @ stub NtGdiDdDDIDestroyHwQueue +# @ stub NtGdiDdDDIDestroyKeyedMutex +# @ stub NtGdiDdDDIDestroyOutputDupl +# @ stub NtGdiDdDDIDestroyOverlay +# @ stub NtGdiDdDDIDestroyPagingQueue +# @ stub NtGdiDdDDIDestroyProtectedSession +# @ stub NtGdiDdDDIDestroySynchronizationObject +# @ stub NtGdiDdDDIDispMgrCreate +# @ stub NtGdiDdDDIDispMgrSourceOperation +# @ stub NtGdiDdDDIDispMgrTargetOperation +# @ stub NtGdiDdDDIEnumAdapters +# @ stub NtGdiDdDDIEnumAdapters2 @ stdcall NtGdiDdDDIEscape(ptr) -@ stub NtGdiDdDDIEvict -@ stub NtGdiDdDDIExtractBundleObject -@ stub NtGdiDdDDIFlipOverlay -@ stub NtGdiDdDDIFlushHeapTransitions -@ stub NtGdiDdDDIFreeGpuVirtualAddress -@ stub NtGdiDdDDIGetAllocationPriority -@ stub NtGdiDdDDIGetCachedHybridQueryValue -@ stub NtGdiDdDDIGetContextInProcessSchedulingPriority -@ stub NtGdiDdDDIGetContextSchedulingPriority -@ stub NtGdiDdDDIGetDWMVerticalBlankEvent -@ stub NtGdiDdDDIGetDeviceState -@ stub NtGdiDdDDIGetDisplayModeList -@ stub NtGdiDdDDIGetMemoryBudgetTarget -@ stub NtGdiDdDDIGetMultiPlaneOverlayCaps -@ stub NtGdiDdDDIGetMultisampleMethodList -@ stub NtGdiDdDDIGetOverlayState -@ stub NtGdiDdDDIGetPostCompositionCaps -@ stub NtGdiDdDDIGetPresentHistory -@ stub NtGdiDdDDIGetPresentQueueEvent -@ stub NtGdiDdDDIGetProcessDeviceRemovalSupport -@ stub NtGdiDdDDIGetProcessSchedulingPriorityBand -@ stub NtGdiDdDDIGetProcessSchedulingPriorityClass -@ stub NtGdiDdDDIGetResourcePresentPrivateDriverData -@ stub NtGdiDdDDIGetRuntimeData -@ stub NtGdiDdDDIGetScanLine -@ stub NtGdiDdDDIGetSetSwapChainMetadata -@ stub NtGdiDdDDIGetSharedPrimaryHandle -@ stub NtGdiDdDDIGetSharedResourceAdapterLuid -@ stub NtGdiDdDDIGetSharedResourceAdapterLuidFlipManager -@ stub NtGdiDdDDIGetYieldPercentage -@ stub NtGdiDdDDIInvalidateActiveVidPn -@ stub NtGdiDdDDIInvalidateCache -@ stub NtGdiDdDDILock -@ stub NtGdiDdDDILock2 -@ stub NtGdiDdDDIMakeResident -@ stub NtGdiDdDDIMapGpuVirtualAddress -@ stub NtGdiDdDDIMarkDeviceAsError -@ stub NtGdiDdDDINetDispGetNextChunkInfo -@ stub NtGdiDdDDINetDispQueryMiracastDisplayDeviceStatus -@ stub NtGdiDdDDINetDispQueryMiracastDisplayDeviceSupport -@ stub NtGdiDdDDINetDispStartMiracastDisplayDevice -@ stub NtGdiDdDDINetDispStopMiracastDisplayDevice -@ stub NtGdiDdDDIOfferAllocations +# @ stub NtGdiDdDDIEvict +# @ stub NtGdiDdDDIExtractBundleObject +# @ stub NtGdiDdDDIFlipOverlay +# @ stub NtGdiDdDDIFlushHeapTransitions +# @ stub NtGdiDdDDIFreeGpuVirtualAddress +# @ stub NtGdiDdDDIGetAllocationPriority +# @ stub NtGdiDdDDIGetCachedHybridQueryValue +# @ stub NtGdiDdDDIGetContextInProcessSchedulingPriority +# @ stub NtGdiDdDDIGetContextSchedulingPriority +# @ stub NtGdiDdDDIGetDWMVerticalBlankEvent +# @ stub NtGdiDdDDIGetDeviceState +# @ stub NtGdiDdDDIGetDisplayModeList +# @ stub NtGdiDdDDIGetMemoryBudgetTarget +# @ stub NtGdiDdDDIGetMultiPlaneOverlayCaps +# @ stub NtGdiDdDDIGetMultisampleMethodList +# @ stub NtGdiDdDDIGetOverlayState +# @ stub NtGdiDdDDIGetPostCompositionCaps +# @ stub NtGdiDdDDIGetPresentHistory +# @ stub NtGdiDdDDIGetPresentQueueEvent +# @ stub NtGdiDdDDIGetProcessDeviceRemovalSupport +# @ stub NtGdiDdDDIGetProcessSchedulingPriorityBand +# @ stub NtGdiDdDDIGetProcessSchedulingPriorityClass +# @ stub NtGdiDdDDIGetResourcePresentPrivateDriverData +# @ stub NtGdiDdDDIGetRuntimeData +# @ stub NtGdiDdDDIGetScanLine +# @ stub NtGdiDdDDIGetSetSwapChainMetadata +# @ stub NtGdiDdDDIGetSharedPrimaryHandle +# @ stub NtGdiDdDDIGetSharedResourceAdapterLuid +# @ stub NtGdiDdDDIGetSharedResourceAdapterLuidFlipManager +# @ stub NtGdiDdDDIGetYieldPercentage +# @ stub NtGdiDdDDIInvalidateActiveVidPn +# @ stub NtGdiDdDDIInvalidateCache +# @ stub NtGdiDdDDILock +# @ stub NtGdiDdDDILock2 +# @ stub NtGdiDdDDIMakeResident +# @ stub NtGdiDdDDIMapGpuVirtualAddress +# @ stub NtGdiDdDDIMarkDeviceAsError +# @ stub NtGdiDdDDINetDispGetNextChunkInfo +# @ stub NtGdiDdDDINetDispQueryMiracastDisplayDeviceStatus +# @ stub NtGdiDdDDINetDispQueryMiracastDisplayDeviceSupport +# @ stub NtGdiDdDDINetDispStartMiracastDisplayDevice +# @ stub NtGdiDdDDINetDispStopMiracastDisplayDevice +# @ stub NtGdiDdDDIOfferAllocations @ stdcall -syscall NtGdiDdDDIOpenAdapterFromDeviceName(ptr) @ stdcall -syscall NtGdiDdDDIOpenAdapterFromHdc(ptr) @ stdcall -syscall NtGdiDdDDIOpenAdapterFromLuid(ptr) -@ stub NtGdiDdDDIOpenBundleObjectNtHandleFromName -@ stub NtGdiDdDDIOpenKeyedMutex -@ stub NtGdiDdDDIOpenKeyedMutex2 -@ stub NtGdiDdDDIOpenKeyedMutexFromNtHandle -@ stub NtGdiDdDDIOpenNtHandleFromName -@ stub NtGdiDdDDIOpenProtectedSessionFromNtHandle -@ stub NtGdiDdDDIOpenResource -@ stub NtGdiDdDDIOpenResourceFromNtHandle -@ stub NtGdiDdDDIOpenSwapChain -@ stub NtGdiDdDDIOpenSyncObjectFromNtHandle -@ stub NtGdiDdDDIOpenSyncObjectFromNtHandle2 -@ stub NtGdiDdDDIOpenSyncObjectNtHandleFromName -@ stub NtGdiDdDDIOpenSynchronizationObject -@ stub NtGdiDdDDIOutputDuplGetFrameInfo -@ stub NtGdiDdDDIOutputDuplGetMetaData -@ stub NtGdiDdDDIOutputDuplGetPointerShapeData -@ stub NtGdiDdDDIOutputDuplPresent -@ stub NtGdiDdDDIOutputDuplReleaseFrame -@ stub NtGdiDdDDIPollDisplayChildren -@ stub NtGdiDdDDIPresent -@ stub NtGdiDdDDIPresentMultiPlaneOverlay -@ stub NtGdiDdDDIPresentMultiPlaneOverlay2 -@ stub NtGdiDdDDIPresentMultiPlaneOverlay3 -@ stub NtGdiDdDDIPresentRedirected -@ stub NtGdiDdDDIQueryAdapterInfo -@ stub NtGdiDdDDIQueryAllocationResidency -@ stub NtGdiDdDDIQueryClockCalibration -@ stub NtGdiDdDDIQueryFSEBlock -@ stub NtGdiDdDDIQueryProcessOfferInfo -@ stub NtGdiDdDDIQueryProtectedSessionInfoFromNtHandle -@ stub NtGdiDdDDIQueryProtectedSessionStatus -@ stub NtGdiDdDDIQueryRemoteVidPnSourceFromGdiDisplayName -@ stub NtGdiDdDDIQueryResourceInfo -@ stub NtGdiDdDDIQueryResourceInfoFromNtHandle +# @ stub NtGdiDdDDIOpenBundleObjectNtHandleFromName +# @ stub NtGdiDdDDIOpenKeyedMutex +# @ stub NtGdiDdDDIOpenKeyedMutex2 +# @ stub NtGdiDdDDIOpenKeyedMutexFromNtHandle +# @ stub NtGdiDdDDIOpenNtHandleFromName +# @ stub NtGdiDdDDIOpenProtectedSessionFromNtHandle +# @ stub NtGdiDdDDIOpenResource +# @ stub NtGdiDdDDIOpenResourceFromNtHandle +# @ stub NtGdiDdDDIOpenSwapChain +# @ stub NtGdiDdDDIOpenSyncObjectFromNtHandle +# @ stub NtGdiDdDDIOpenSyncObjectFromNtHandle2 +# @ stub NtGdiDdDDIOpenSyncObjectNtHandleFromName +# @ stub NtGdiDdDDIOpenSynchronizationObject +# @ stub NtGdiDdDDIOutputDuplGetFrameInfo +# @ stub NtGdiDdDDIOutputDuplGetMetaData +# @ stub NtGdiDdDDIOutputDuplGetPointerShapeData +# @ stub NtGdiDdDDIOutputDuplPresent +# @ stub NtGdiDdDDIOutputDuplReleaseFrame +# @ stub NtGdiDdDDIPollDisplayChildren +# @ stub NtGdiDdDDIPresent +# @ stub NtGdiDdDDIPresentMultiPlaneOverlay +# @ stub NtGdiDdDDIPresentMultiPlaneOverlay2 +# @ stub NtGdiDdDDIPresentMultiPlaneOverlay3 +# @ stub NtGdiDdDDIPresentRedirected +# @ stub NtGdiDdDDIQueryAdapterInfo +# @ stub NtGdiDdDDIQueryAllocationResidency +# @ stub NtGdiDdDDIQueryClockCalibration +# @ stub NtGdiDdDDIQueryFSEBlock +# @ stub NtGdiDdDDIQueryProcessOfferInfo +# @ stub NtGdiDdDDIQueryProtectedSessionInfoFromNtHandle +# @ stub NtGdiDdDDIQueryProtectedSessionStatus +# @ stub NtGdiDdDDIQueryRemoteVidPnSourceFromGdiDisplayName +# @ stub NtGdiDdDDIQueryResourceInfo +# @ stub NtGdiDdDDIQueryResourceInfoFromNtHandle @ stdcall -syscall NtGdiDdDDIQueryStatistics(ptr) -@ stub NtGdiDdDDIQueryVidPnExclusiveOwnership -@ stub NtGdiDdDDIQueryVideoMemoryInfo -@ stub NtGdiDdDDIReclaimAllocations -@ stub NtGdiDdDDIReclaimAllocations2 -@ stub NtGdiDdDDIReleaseKeyedMutex -@ stub NtGdiDdDDIReleaseKeyedMutex2 -@ stub NtGdiDdDDIReleaseProcessVidPnSourceOwners -@ stub NtGdiDdDDIReleaseSwapChain -@ stub NtGdiDdDDIRemoveSurfaceFromSwapChain -@ stub NtGdiDdDDIRender -@ stub NtGdiDdDDIReserveGpuVirtualAddress -@ stub NtGdiDdDDISetAllocationPriority -@ stub NtGdiDdDDISetContextInProcessSchedulingPriority -@ stub NtGdiDdDDISetContextSchedulingPriority -@ stub NtGdiDdDDISetDisplayMode -@ stub NtGdiDdDDISetDodIndirectSwapchain -@ stub NtGdiDdDDISetFSEBlock -@ stub NtGdiDdDDISetGammaRamp -@ stub NtGdiDdDDISetHwProtectionTeardownRecovery -@ stub NtGdiDdDDISetMemoryBudgetTarget -@ stub NtGdiDdDDISetMonitorColorSpaceTransform -@ stub NtGdiDdDDISetProcessDeviceRemovalSupport -@ stub NtGdiDdDDISetProcessSchedulingPriorityBand -@ stub NtGdiDdDDISetProcessSchedulingPriorityClass +# @ stub NtGdiDdDDIQueryVidPnExclusiveOwnership +# @ stub NtGdiDdDDIQueryVideoMemoryInfo +# @ stub NtGdiDdDDIReclaimAllocations +# @ stub NtGdiDdDDIReclaimAllocations2 +# @ stub NtGdiDdDDIReleaseKeyedMutex +# @ stub NtGdiDdDDIReleaseKeyedMutex2 +# @ stub NtGdiDdDDIReleaseProcessVidPnSourceOwners +# @ stub NtGdiDdDDIReleaseSwapChain +# @ stub NtGdiDdDDIRemoveSurfaceFromSwapChain +# @ stub NtGdiDdDDIRender +# @ stub NtGdiDdDDIReserveGpuVirtualAddress +# @ stub NtGdiDdDDISetAllocationPriority +# @ stub NtGdiDdDDISetContextInProcessSchedulingPriority +# @ stub NtGdiDdDDISetContextSchedulingPriority +# @ stub NtGdiDdDDISetDisplayMode +# @ stub NtGdiDdDDISetDodIndirectSwapchain +# @ stub NtGdiDdDDISetFSEBlock +# @ stub NtGdiDdDDISetGammaRamp +# @ stub NtGdiDdDDISetHwProtectionTeardownRecovery +# @ stub NtGdiDdDDISetMemoryBudgetTarget +# @ stub NtGdiDdDDISetMonitorColorSpaceTransform +# @ stub NtGdiDdDDISetProcessDeviceRemovalSupport +# @ stub NtGdiDdDDISetProcessSchedulingPriorityBand +# @ stub NtGdiDdDDISetProcessSchedulingPriorityClass @ stdcall -syscall NtGdiDdDDISetQueuedLimit(ptr) -@ stub NtGdiDdDDISetStablePowerState -@ stub NtGdiDdDDISetStereoEnabled -@ stub NtGdiDdDDISetSyncRefreshCountWaitTarget -@ stub NtGdiDdDDISetVidPnSourceHwProtection +# @ stub NtGdiDdDDISetStablePowerState +# @ stub NtGdiDdDDISetStereoEnabled +# @ stub NtGdiDdDDISetSyncRefreshCountWaitTarget +# @ stub NtGdiDdDDISetVidPnSourceHwProtection @ stdcall NtGdiDdDDISetVidPnSourceOwner(ptr) -@ stub NtGdiDdDDISetYieldPercentage -@ stub NtGdiDdDDIShareObjects -@ stub NtGdiDdDDISharedPrimaryLockNotification -@ stub NtGdiDdDDISharedPrimaryUnLockNotification -@ stub NtGdiDdDDISignalSynchronizationObject -@ stub NtGdiDdDDISignalSynchronizationObjectFromCpu -@ stub NtGdiDdDDISignalSynchronizationObjectFromGpu -@ stub NtGdiDdDDISignalSynchronizationObjectFromGpu2 -@ stub NtGdiDdDDISubmitCommand -@ stub NtGdiDdDDISubmitCommandToHwQueue -@ stub NtGdiDdDDISubmitSignalSyncObjectsToHwQueue -@ stub NtGdiDdDDISubmitWaitForSyncObjectsToHwQueue -@ stub NtGdiDdDDITrimProcessCommitment -@ stub NtGdiDdDDIUnOrderedPresentSwapChain -@ stub NtGdiDdDDIUnlock -@ stub NtGdiDdDDIUnlock2 -@ stub NtGdiDdDDIUpdateAllocationProperty -@ stub NtGdiDdDDIUpdateGpuVirtualAddress -@ stub NtGdiDdDDIUpdateOverlay -@ stub NtGdiDdDDIWaitForIdle -@ stub NtGdiDdDDIWaitForSynchronizationObject -@ stub NtGdiDdDDIWaitForSynchronizationObjectFromCpu -@ stub NtGdiDdDDIWaitForSynchronizationObjectFromGpu -@ stub NtGdiDdDDIWaitForVerticalBlankEvent -@ stub NtGdiDdDDIWaitForVerticalBlankEvent2 -@ stub NtGdiDdDestroyFullscreenSprite -@ stub NtGdiDdNotifyFullscreenSpriteUpdate -@ stub NtGdiDdQueryVisRgnUniqueness +# @ stub NtGdiDdDDISetYieldPercentage +# @ stub NtGdiDdDDIShareObjects +# @ stub NtGdiDdDDISharedPrimaryLockNotification +# @ stub NtGdiDdDDISharedPrimaryUnLockNotification +# @ stub NtGdiDdDDISignalSynchronizationObject +# @ stub NtGdiDdDDISignalSynchronizationObjectFromCpu +# @ stub NtGdiDdDDISignalSynchronizationObjectFromGpu +# @ stub NtGdiDdDDISignalSynchronizationObjectFromGpu2 +# @ stub NtGdiDdDDISubmitCommand +# @ stub NtGdiDdDDISubmitCommandToHwQueue +# @ stub NtGdiDdDDISubmitSignalSyncObjectsToHwQueue +# @ stub NtGdiDdDDISubmitWaitForSyncObjectsToHwQueue +# @ stub NtGdiDdDDITrimProcessCommitment +# @ stub NtGdiDdDDIUnOrderedPresentSwapChain +# @ stub NtGdiDdDDIUnlock +# @ stub NtGdiDdDDIUnlock2 +# @ stub NtGdiDdDDIUpdateAllocationProperty +# @ stub NtGdiDdDDIUpdateGpuVirtualAddress +# @ stub NtGdiDdDDIUpdateOverlay +# @ stub NtGdiDdDDIWaitForIdle +# @ stub NtGdiDdDDIWaitForSynchronizationObject +# @ stub NtGdiDdDDIWaitForSynchronizationObjectFromCpu +# @ stub NtGdiDdDDIWaitForSynchronizationObjectFromGpu +# @ stub NtGdiDdDDIWaitForVerticalBlankEvent +# @ stub NtGdiDdDDIWaitForVerticalBlankEvent2 +# @ stub NtGdiDdDestroyFullscreenSprite +# @ stub NtGdiDdNotifyFullscreenSpriteUpdate +# @ stub NtGdiDdQueryVisRgnUniqueness @ stdcall -syscall NtGdiDeleteClientObj(long) -@ stub NtGdiDeleteColorSpace -@ stub NtGdiDeleteColorTransform +# @ stub NtGdiDeleteColorSpace +# @ stub NtGdiDeleteColorTransform @ stdcall NtGdiDeleteObjectApp(long ) @ stdcall -syscall NtGdiDescribePixelFormat(long long long ptr) -@ stub NtGdiDestroyOPMProtectedOutput -@ stub NtGdiDestroyPhysicalMonitor -@ stub NtGdiDoBanding +# @ stub NtGdiDestroyOPMProtectedOutput +# @ stub NtGdiDestroyPhysicalMonitor +# @ stub NtGdiDoBanding @ stdcall NtGdiDoPalette(long long long ptr long long) -@ stub NtGdiDrawEscape +# @ stub NtGdiDrawEscape @ stdcall -syscall NtGdiDrawStream(long long ptr) -@ stub NtGdiDwmCreatedBitmapRemotingOutput +# @ stub NtGdiDwmCreatedBitmapRemotingOutput @ stdcall NtGdiEllipse(long long long long long) -@ stub NtGdiEnableEudc +# @ stub NtGdiEnableEudc @ stdcall NtGdiEndDoc(long) -@ stub NtGdiEndGdiRendering +# @ stub NtGdiEndGdiRendering @ stdcall NtGdiEndPage(long) @ stdcall NtGdiEndPath(long) -@ stub NtGdiEngAlphaBlend -@ stub NtGdiEngAssociateSurface -@ stub NtGdiEngBitBlt -@ stub NtGdiEngCheckAbort -@ stub NtGdiEngComputeGlyphSet -@ stub NtGdiEngCopyBits -@ stub NtGdiEngCreateBitmap -@ stub NtGdiEngCreateClip -@ stub NtGdiEngCreateDeviceBitmap -@ stub NtGdiEngCreateDeviceSurface -@ stub NtGdiEngCreatePalette -@ stub NtGdiEngDeleteClip -@ stub NtGdiEngDeletePalette -@ stub NtGdiEngDeletePath -@ stub NtGdiEngDeleteSurface -@ stub NtGdiEngEraseSurface -@ stub NtGdiEngFillPath -@ stub NtGdiEngGradientFill -@ stub NtGdiEngLineTo -@ stub NtGdiEngLockSurface -@ stub NtGdiEngMarkBandingSurface -@ stub NtGdiEngPaint -@ stub NtGdiEngPlgBlt -@ stub NtGdiEngStretchBlt -@ stub NtGdiEngStretchBltROP -@ stub NtGdiEngStrokeAndFillPath -@ stub NtGdiEngStrokePath -@ stub NtGdiEngTextOut -@ stub NtGdiEngTransparentBlt -@ stub NtGdiEngUnlockSurface -@ stub NtGdiEnsureDpiDepDefaultGuiFontForPlateau +# @ stub NtGdiEngAlphaBlend +# @ stub NtGdiEngAssociateSurface +# @ stub NtGdiEngBitBlt +# @ stub NtGdiEngCheckAbort +# @ stub NtGdiEngComputeGlyphSet +# @ stub NtGdiEngCopyBits +# @ stub NtGdiEngCreateBitmap +# @ stub NtGdiEngCreateClip +# @ stub NtGdiEngCreateDeviceBitmap +# @ stub NtGdiEngCreateDeviceSurface +# @ stub NtGdiEngCreatePalette +# @ stub NtGdiEngDeleteClip +# @ stub NtGdiEngDeletePalette +# @ stub NtGdiEngDeletePath +# @ stub NtGdiEngDeleteSurface +# @ stub NtGdiEngEraseSurface +# @ stub NtGdiEngFillPath +# @ stub NtGdiEngGradientFill +# @ stub NtGdiEngLineTo +# @ stub NtGdiEngLockSurface +# @ stub NtGdiEngMarkBandingSurface +# @ stub NtGdiEngPaint +# @ stub NtGdiEngPlgBlt +# @ stub NtGdiEngStretchBlt +# @ stub NtGdiEngStretchBltROP +# @ stub NtGdiEngStrokeAndFillPath +# @ stub NtGdiEngStrokePath +# @ stub NtGdiEngTextOut +# @ stub NtGdiEngTransparentBlt +# @ stub NtGdiEngUnlockSurface +# @ stub NtGdiEnsureDpiDepDefaultGuiFontForPlateau @ stdcall NtGdiEnumFonts(long long long long wstr long ptr ptr) -@ stub NtGdiEnumObjects +# @ stub NtGdiEnumObjects @ stdcall -syscall NtGdiEqualRgn(long long) -@ stub NtGdiEudcLoadUnloadLink +# @ stub NtGdiEudcLoadUnloadLink @ stdcall NtGdiExcludeClipRect(long long long long long) @ stdcall -syscall NtGdiExtCreatePen(long long long long long long long ptr long long long) @ stdcall -syscall NtGdiExtCreateRegion(ptr long ptr) @@ -425,163 +425,163 @@ @ stdcall -syscall NtGdiExtGetObjectW(long long ptr) @ stdcall NtGdiExtSelectClipRgn(long long long) @ stdcall NtGdiExtTextOutW(long long long long ptr ptr long ptr long) -@ stub NtGdiFONTOBJ_cGetAllGlyphHandles -@ stub NtGdiFONTOBJ_cGetGlyphs -@ stub NtGdiFONTOBJ_pQueryGlyphAttrs -@ stub NtGdiFONTOBJ_pfdg -@ stub NtGdiFONTOBJ_pifi -@ stub NtGdiFONTOBJ_pvTrueTypeFontFile -@ stub NtGdiFONTOBJ_pxoGetXform -@ stub NtGdiFONTOBJ_vGetInfo +# @ stub NtGdiFONTOBJ_cGetAllGlyphHandles +# @ stub NtGdiFONTOBJ_cGetGlyphs +# @ stub NtGdiFONTOBJ_pQueryGlyphAttrs +# @ stub NtGdiFONTOBJ_pfdg +# @ stub NtGdiFONTOBJ_pifi +# @ stub NtGdiFONTOBJ_pvTrueTypeFontFile +# @ stub NtGdiFONTOBJ_pxoGetXform +# @ stub NtGdiFONTOBJ_vGetInfo @ stdcall NtGdiFillPath(long) @ stdcall NtGdiFillRgn(long long long) @ stdcall -syscall NtGdiFlattenPath(long) @ stdcall -syscall NtGdiFlush() @ stdcall NtGdiFontIsLinked(long) -@ stub NtGdiForceUFIMapping +# @ stub NtGdiForceUFIMapping @ stdcall NtGdiFrameRgn(long long long long long) -@ stub NtGdiFullscreenControl +# @ stub NtGdiFullscreenControl @ stdcall NtGdiGetAndSetDCDword(long long long ptr) @ stdcall NtGdiGetAppClipBox(long ptr) -@ stub NtGdiGetAppliedDeviceGammaRamp +# @ stub NtGdiGetAppliedDeviceGammaRamp @ stdcall -syscall NtGdiGetBitmapBits(long long ptr) @ stdcall -syscall NtGdiGetBitmapDimension(long ptr) -@ stub NtGdiGetBitmapDpiScaleValue +# @ stub NtGdiGetBitmapDpiScaleValue @ stdcall NtGdiGetBoundsRect(long ptr long) -@ stub NtGdiGetCOPPCompatibleOPMInformation -@ stub NtGdiGetCertificate -@ stub NtGdiGetCertificateByHandle -@ stub NtGdiGetCertificateSize -@ stub NtGdiGetCertificateSizeByHandle +# @ stub NtGdiGetCOPPCompatibleOPMInformation +# @ stub NtGdiGetCertificate +# @ stub NtGdiGetCertificateByHandle +# @ stub NtGdiGetCertificateSize +# @ stub NtGdiGetCertificateSizeByHandle @ stdcall NtGdiGetCharABCWidthsW(long long long ptr long ptr) -@ stub NtGdiGetCharSet +# @ stub NtGdiGetCharSet @ stdcall NtGdiGetCharWidthInfo(long ptr) @ stdcall NtGdiGetCharWidthW(long long long ptr long ptr) -@ stub NtGdiGetCharacterPlacementW +# @ stub NtGdiGetCharacterPlacementW @ stdcall -syscall NtGdiGetColorAdjustment(long ptr) -@ stub NtGdiGetColorSpaceforBitmap -@ stub NtGdiGetCurrentDpiInfo -@ stub NtGdiGetDCDpiScaleValue -@ stub NtGdiGetDCDword +# @ stub NtGdiGetColorSpaceforBitmap +# @ stub NtGdiGetCurrentDpiInfo +# @ stub NtGdiGetDCDpiScaleValue +# @ stub NtGdiGetDCDword @ stdcall -syscall NtGdiGetDCObject(long long) -@ stub NtGdiGetDCPoint -@ stub NtGdiGetDCforBitmap +# @ stub NtGdiGetDCPoint +# @ stub NtGdiGetDCforBitmap @ stdcall NtGdiGetDIBitsInternal(long long long long ptr ptr long long long) @ stdcall NtGdiGetDeviceCaps(long long) -@ stub NtGdiGetDeviceCapsAll +# @ stub NtGdiGetDeviceCapsAll @ stdcall NtGdiGetDeviceGammaRamp(long ptr) -@ stub NtGdiGetDeviceWidth -@ stub NtGdiGetDhpdev -@ stub NtGdiGetETM -@ stub NtGdiGetEmbUFI -@ stub NtGdiGetEmbedFonts -@ stub NtGdiGetEntry -@ stub NtGdiGetEudcTimeStampEx +# @ stub NtGdiGetDeviceWidth +# @ stub NtGdiGetDhpdev +# @ stub NtGdiGetETM +# @ stub NtGdiGetEmbUFI +# @ stub NtGdiGetEmbedFonts +# @ stub NtGdiGetEntry +# @ stub NtGdiGetEudcTimeStampEx @ stdcall NtGdiGetFontData(long long long ptr long) @ stdcall -syscall NtGdiGetFontFileData(long long ptr ptr long) @ stdcall -syscall NtGdiGetFontFileInfo(long long ptr long ptr) -@ stub NtGdiGetFontResourceInfoInternalW +# @ stub NtGdiGetFontResourceInfoInternalW @ stdcall NtGdiGetFontUnicodeRanges(long ptr) -@ stub NtGdiGetGammaRampCapability +# @ stub NtGdiGetGammaRampCapability @ stdcall NtGdiGetGlyphIndicesW(long wstr long ptr long) -@ stub NtGdiGetGlyphIndicesWInternal +# @ stub NtGdiGetGlyphIndicesWInternal @ stdcall NtGdiGetGlyphOutline(long long long ptr long ptr ptr long) @ stdcall NtGdiGetKerningPairs(long long ptr) -@ stub NtGdiGetLinkedUFIs -@ stub NtGdiGetMiterLimit -@ stub NtGdiGetMonitorID +# @ stub NtGdiGetLinkedUFIs +# @ stub NtGdiGetMiterLimit +# @ stub NtGdiGetMonitorID @ stdcall NtGdiGetNearestColor(long long) @ stdcall -syscall NtGdiGetNearestPaletteIndex(long long) -@ stub NtGdiGetNumberOfPhysicalMonitors -@ stub NtGdiGetOPMInformation -@ stub NtGdiGetOPMRandomNumber -@ stub NtGdiGetObjectBitmapHandle +# @ stub NtGdiGetNumberOfPhysicalMonitors +# @ stub NtGdiGetOPMInformation +# @ stub NtGdiGetOPMRandomNumber +# @ stub NtGdiGetObjectBitmapHandle @ stdcall NtGdiGetOutlineTextMetricsInternalW(long long ptr long) @ stdcall -syscall NtGdiGetPath(long ptr ptr long) -@ stub NtGdiGetPerBandInfo -@ stub NtGdiGetPhysicalMonitorDescription -@ stub NtGdiGetPhysicalMonitors +# @ stub NtGdiGetPerBandInfo +# @ stub NtGdiGetPhysicalMonitorDescription +# @ stub NtGdiGetPhysicalMonitors @ stdcall NtGdiGetPixel(long long long) -@ stub NtGdiGetProcessSessionFonts -@ stub NtGdiGetPublicFontTableChangeCookie +# @ stub NtGdiGetProcessSessionFonts +# @ stub NtGdiGetPublicFontTableChangeCookie @ stdcall NtGdiGetRandomRgn(long long long) @ stdcall NtGdiGetRasterizerCaps(ptr long) @ stdcall NtGdiGetRealizationInfo(long ptr) @ stdcall -syscall NtGdiGetRegionData(long long ptr) @ stdcall -syscall NtGdiGetRgnBox(long ptr) -@ stub NtGdiGetServerMetaFileBits +# @ stub NtGdiGetServerMetaFileBits @ stdcall -syscall NtGdiGetSpoolMessage(ptr long ptr long) -@ stub NtGdiGetStats -@ stub NtGdiGetStringBitmapW -@ stub NtGdiGetSuggestedOPMProtectedOutputArraySize +# @ stub NtGdiGetStats +# @ stub NtGdiGetStringBitmapW +# @ stub NtGdiGetSuggestedOPMProtectedOutputArraySize @ stdcall -syscall NtGdiGetSystemPaletteUse(long) @ stdcall NtGdiGetTextCharsetInfo(long ptr long) -@ stub NtGdiGetTextExtent +# @ stub NtGdiGetTextExtent @ stdcall NtGdiGetTextExtentExW(long wstr long long ptr ptr ptr long) @ stdcall NtGdiGetTextFaceW(long long ptr long) @ stdcall NtGdiGetTextMetricsW(long ptr long) @ stdcall -syscall NtGdiGetTransform(long long ptr) -@ stub NtGdiGetUFI -@ stub NtGdiGetUFIPathname -@ stub NtGdiGetWidthTable +# @ stub NtGdiGetUFI +# @ stub NtGdiGetUFIPathname +# @ stub NtGdiGetWidthTable @ stdcall NtGdiGradientFill(long ptr long ptr long long) -@ stub NtGdiHLSurfGetInformation -@ stub NtGdiHLSurfSetInformation -@ stub NtGdiHT_Get8BPPFormatPalette -@ stub NtGdiHT_Get8BPPMaskPalette +# @ stub NtGdiHLSurfGetInformation +# @ stub NtGdiHLSurfSetInformation +# @ stub NtGdiHT_Get8BPPFormatPalette +# @ stub NtGdiHT_Get8BPPMaskPalette @ stdcall -syscall NtGdiHfontCreate(ptr long long long ptr) -@ stub NtGdiIcmBrushInfo -@ stub NtGdiInit +# @ stub NtGdiIcmBrushInfo +# @ stub NtGdiInit @ stdcall -syscall NtGdiInitSpool() @ stdcall NtGdiIntersectClipRect(long long long long long) @ stdcall NtGdiInvertRgn(long long) @ stdcall NtGdiLineTo(long long long) -@ stub NtGdiMakeFontDir -@ stub NtGdiMakeInfoDC -@ stub NtGdiMakeObjectUnXferable -@ stub NtGdiMakeObjectXferable +# @ stub NtGdiMakeFontDir +# @ stub NtGdiMakeInfoDC +# @ stub NtGdiMakeObjectUnXferable +# @ stub NtGdiMakeObjectXferable @ stdcall NtGdiMaskBlt(long long long long long long long long long long long long long) -@ stub NtGdiMirrorWindowOrg +# @ stub NtGdiMirrorWindowOrg @ stdcall NtGdiModifyWorldTransform(long ptr long) -@ stub NtGdiMonoBitmap +# @ stub NtGdiMonoBitmap @ stdcall NtGdiMoveTo(long long long ptr) @ stdcall NtGdiOffsetClipRgn(long long long) @ stdcall -syscall NtGdiOffsetRgn(long long long) @ stdcall NtGdiOpenDCW(ptr ptr ptr long long ptr ptr ptr) -@ stub NtGdiPATHOBJ_bEnum -@ stub NtGdiPATHOBJ_bEnumClipLines -@ stub NtGdiPATHOBJ_vEnumStart -@ stub NtGdiPATHOBJ_vEnumStartClipLines -@ stub NtGdiPATHOBJ_vGetBounds +# @ stub NtGdiPATHOBJ_bEnum +# @ stub NtGdiPATHOBJ_bEnumClipLines +# @ stub NtGdiPATHOBJ_vEnumStart +# @ stub NtGdiPATHOBJ_vEnumStartClipLines +# @ stub NtGdiPATHOBJ_vGetBounds @ stdcall NtGdiPatBlt(long long long long long long) @ stdcall -syscall NtGdiPathToRegion(long) @ stdcall NtGdiPlgBlt(long ptr long long long long long long long long long) @ stdcall NtGdiPolyDraw(long ptr ptr long) -@ stub NtGdiPolyPatBlt +# @ stub NtGdiPolyPatBlt @ stdcall NtGdiPolyPolyDraw(long ptr ptr long long) -@ stub NtGdiPolyTextOutW +# @ stub NtGdiPolyTextOutW @ stdcall -syscall NtGdiPtInRegion(long long long) @ stdcall NtGdiPtVisible(long long long) -@ stub NtGdiQueryFontAssocInfo -@ stub NtGdiQueryFonts +# @ stub NtGdiQueryFontAssocInfo +# @ stub NtGdiQueryFonts @ stdcall -syscall NtGdiRectInRegion(long ptr) @ stdcall NtGdiRectVisible(long ptr) @ stdcall NtGdiRectangle(long long long long long) @ stdcall -syscall NtGdiRemoveFontMemResourceEx(long) @ stdcall -syscall NtGdiRemoveFontResourceW(wstr long long long long ptr) -@ stub NtGdiRemoveMergeFont +# @ stub NtGdiRemoveMergeFont @ stdcall NtGdiResetDC(long ptr ptr ptr ptr) @ stdcall NtGdiResizePalette(long long) @ stdcall NtGdiRestoreDC(long long) @ stdcall NtGdiRoundRect(long long long long long long long) -@ stub NtGdiSTROBJ_bEnum -@ stub NtGdiSTROBJ_bEnumPositionsOnly -@ stub NtGdiSTROBJ_bGetAdvanceWidths -@ stub NtGdiSTROBJ_dwGetCodePage -@ stub NtGdiSTROBJ_vEnumStart +# @ stub NtGdiSTROBJ_bEnum +# @ stub NtGdiSTROBJ_bEnumPositionsOnly +# @ stub NtGdiSTROBJ_bGetAdvanceWidths +# @ stub NtGdiSTROBJ_dwGetCodePage +# @ stub NtGdiSTROBJ_vEnumStart @ stdcall -syscall NtGdiSaveDC(long) -@ stub NtGdiScaleRgn -@ stub NtGdiScaleValues +# @ stub NtGdiScaleRgn +# @ stub NtGdiScaleValues @ stdcall NtGdiScaleViewportExtEx(long long long long long ptr) @ stdcall NtGdiScaleWindowExtEx(long long long long long ptr) @ stdcall NtGdiSelectBitmap(long long) @@ -589,34 +589,34 @@ @ stdcall NtGdiSelectClipPath(long long) @ stdcall NtGdiSelectFont(long long) @ stdcall NtGdiSelectPen(long long) -@ stub NtGdiSetBitmapAttributes +# @ stub NtGdiSetBitmapAttributes @ stdcall -syscall NtGdiSetBitmapBits(long long ptr) @ stdcall -syscall NtGdiSetBitmapDimension(long long long ptr) @ stdcall NtGdiSetBoundsRect(long ptr long) -@ stub NtGdiSetBrushAttributes +# @ stub NtGdiSetBrushAttributes @ stdcall -syscall NtGdiSetBrushOrg(long long long ptr) @ stdcall -syscall NtGdiSetColorAdjustment(long ptr) -@ stub NtGdiSetColorSpace +# @ stub NtGdiSetColorSpace @ stdcall NtGdiSetDIBitsToDeviceInternal(long long long long long long long long long ptr ptr long long long long long) @ stdcall NtGdiSetDeviceGammaRamp(ptr ptr) -@ stub NtGdiSetFontEnumeration -@ stub NtGdiSetFontXform -@ stub NtGdiSetIcmMode +# @ stub NtGdiSetFontEnumeration +# @ stub NtGdiSetFontXform +# @ stub NtGdiSetIcmMode @ stdcall NtGdiSetLayout(long long long) -@ stub NtGdiSetLinkedUFIs +# @ stub NtGdiSetLinkedUFIs @ stdcall -syscall NtGdiSetMagicColors(long long long) @ stdcall -syscall NtGdiSetMetaRgn(long) -@ stub NtGdiSetMiterLimit -@ stub NtGdiSetOPMSigningKeyAndSequenceNumbers -@ stub NtGdiSetPUMPDOBJ +# @ stub NtGdiSetMiterLimit +# @ stub NtGdiSetOPMSigningKeyAndSequenceNumbers +# @ stub NtGdiSetPUMPDOBJ @ stdcall NtGdiSetPixel(long long long long) @ stdcall -syscall NtGdiSetPixelFormat(long long) -@ stub NtGdiSetPrivateDeviceGammaRamp +# @ stub NtGdiSetPrivateDeviceGammaRamp @ stdcall -syscall NtGdiSetRectRgn(long long long long long) -@ stub NtGdiSetSizeDevice +# @ stub NtGdiSetSizeDevice @ stdcall NtGdiSetSystemPaletteUse(long long) @ stdcall -syscall NtGdiSetTextJustification(long long long) -@ stub NtGdiSetUMPDSandboxState +# @ stub NtGdiSetUMPDSandboxState @ stdcall -syscall NtGdiSetVirtualResolution(long long long long long) @ stdcall NtGdiStartDoc(long ptr ptr long) @ stdcall NtGdiStartPage(long) @@ -627,323 +627,323 @@ @ stdcall -syscall NtGdiSwapBuffers(long) @ stdcall -syscall NtGdiTransformPoints(long ptr ptr long long) @ stdcall NtGdiTransparentBlt(long long long long long long long long long long long) -@ stub NtGdiUMPDEngFreeUserMem -@ stub NtGdiUnloadPrinterDriver -@ stub NtGdiUnmapMemFont +# @ stub NtGdiUMPDEngFreeUserMem +# @ stub NtGdiUnloadPrinterDriver +# @ stub NtGdiUnmapMemFont @ stdcall NtGdiUnrealizeObject(long) @ stdcall NtGdiUpdateColors(long) -@ stub NtGdiUpdateTransform +# @ stub NtGdiUpdateTransform @ stdcall NtGdiWidenPath(long) -@ stub NtGdiXFORMOBJ_bApplyXform -@ stub NtGdiXFORMOBJ_iGetXform -@ stub NtGdiXLATEOBJ_cGetPalette -@ stub NtGdiXLATEOBJ_hGetColorTransform -@ stub NtGdiXLATEOBJ_iXlate -@ stub NtHWCursorUpdatePointer -@ stub NtInputSpaceRegionFromPoint -@ stub NtIsOneCoreTransformMode -@ stub NtMITAccessibilityTimerNotification -@ stub NtMITActivateInputProcessing -@ stub NtMITCoreMsgKOpenConnectionTo -@ stub NtMITDeactivateInputProcessing -@ stub NtMITDisableMouseIntercept -@ stub NtMITDispatchCompletion -@ stub NtMITEnableMouseIntercept -@ stub NtMITGetCursorUpdateHandle -@ stub NtMITInitMinuserThread -@ stub NtMITMinuserSetInputTransformOffset -@ stub NtMITMinuserWindowCreated -@ stub NtMITMinuserWindowDestroyed -@ stub NtMITPostMouseInputMessage -@ stub NtMITPostThreadEventMessage -@ stub NtMITPostWindowEventMessage -@ stub NtMITPrepareReceiveInputMessage -@ stub NtMITPrepareSendInputMessage -@ stub NtMITProcessDelegateCapturedPointers -@ stub NtMITSetForegroundRoutingInfo -@ stub NtMITSetInputCallbacks -@ stub NtMITSetInputDelegationMode -@ stub NtMITSetInputObservationState -@ stub NtMITSetKeyboardInputRoutingPolicy -@ stub NtMITSetKeyboardOverriderState -@ stub NtMITSetLastInputRecipient -@ stub NtMITSynthesizeKeyboardInput -@ stub NtMITSynthesizeMouseInput -@ stub NtMITSynthesizeTouchInput -@ stub NtMITUninitMinuserThread -@ stub NtMITUpdateInputGlobals -@ stub NtMapVisualRelativePoints -@ stub NtMinGetInputTransform -@ stub NtMinInteropCoreMessagingWithInput -@ stub NtMinQPeekForInput -@ stub NtMinQSuspendInputProcessing -@ stub NtMinQUpdateWakeMask -@ stub NtModerncoreBeginLayoutUpdate -@ stub NtModerncoreCreateDCompositionHwndTarget -@ stub NtModerncoreCreateGDIHwndTarget -@ stub NtModerncoreDestroyDCompositionHwndTarget -@ stub NtModerncoreDestroyGDIHwndTarget -@ stub NtModerncoreEnableResizeLayoutSynchronization -@ stub NtModerncoreGetNavigationWindowVisual -@ stub NtModerncoreGetResizeDCompositionSynchronizationObject -@ stub NtModerncoreGetWindowContentVisual -@ stub NtModerncoreIdleTimerThread -@ stub NtModerncoreIsResizeLayoutSynchronizationEnabled -@ stub NtModerncoreProcessConnect -@ stub NtModerncoreRegisterEnhancedNavigationWindowHandle -@ stub NtModerncoreRegisterNavigationWindowHandle -@ stub NtModerncoreSetNavigationServiceSid -@ stub NtModerncoreUnregisterNavigationWindowHandle -@ stub NtNotifyPresentToCompositionSurface -@ stub NtOpenCompositionSurfaceDirtyRegion -@ stub NtOpenCompositionSurfaceSectionInfo -@ stub NtOpenCompositionSurfaceSwapChainHandleInfo -@ stub NtQueryCompositionInputIsImplicit -@ stub NtQueryCompositionInputQueueAndTransform -@ stub NtQueryCompositionInputSink -@ stub NtQueryCompositionInputSinkLuid -@ stub NtQueryCompositionInputSinkViewId -@ stub NtQueryCompositionSurfaceBinding -@ stub NtQueryCompositionSurfaceHDRMetaData -@ stub NtQueryCompositionSurfaceRenderingRealization -@ stub NtQueryCompositionSurfaceStatistics -@ stub NtRIMAddInputObserver -@ stub NtRIMAreSiblingDevices -@ stub NtRIMDeviceIoControl -@ stub NtRIMEnableMonitorMappingForDevice -@ stub NtRIMFreeInputBuffer -@ stub NtRIMGetDevicePreparsedData -@ stub NtRIMGetDevicePreparsedDataLockfree -@ stub NtRIMGetDeviceProperties -@ stub NtRIMGetDevicePropertiesLockfree -@ stub NtRIMGetPhysicalDeviceRect -@ stub NtRIMGetSourceProcessId -@ stub NtRIMObserveNextInput -@ stub NtRIMOnPnpNotification -@ stub NtRIMOnTimerNotification -@ stub NtRIMQueryDevicePath -@ stub NtRIMReadInput -@ stub NtRIMRegisterForInput -@ stub NtRIMRemoveInputObserver -@ stub NtRIMSetExtendedDeviceProperty -@ stub NtRIMSetTestModeStatus -@ stub NtRIMUnregisterForInput -@ stub NtRIMUpdateInputObserverRegistration -@ stub NtSetCompositionSurfaceAnalogExclusive -@ stub NtSetCompositionSurfaceBufferUsage -@ stub NtSetCompositionSurfaceDirectFlipState -@ stub NtSetCompositionSurfaceIndependentFlipInfo -@ stub NtSetCompositionSurfaceStatistics -@ stub NtSetCursorInputSpace -@ stub NtSetPointerDeviceInputSpace -@ stub NtSetShellCursorState -@ stub NtTokenManagerConfirmOutstandingAnalogToken -@ stub NtTokenManagerCreateCompositionTokenHandle -@ stub NtTokenManagerCreateFlipObjectReturnTokenHandle -@ stub NtTokenManagerCreateFlipObjectTokenHandle -@ stub NtTokenManagerGetAnalogExclusiveSurfaceUpdates -@ stub NtTokenManagerGetAnalogExclusiveTokenEvent -@ stub NtTokenManagerOpenSectionAndEvents -@ stub NtTokenManagerThread -@ stub NtUnBindCompositionSurface -@ stub NtUpdateInputSinkTransforms -@ stub NtUserAcquireIAMKey -@ stub NtUserAcquireInteractiveControlBackgroundAccess +# @ stub NtGdiXFORMOBJ_bApplyXform +# @ stub NtGdiXFORMOBJ_iGetXform +# @ stub NtGdiXLATEOBJ_cGetPalette +# @ stub NtGdiXLATEOBJ_hGetColorTransform +# @ stub NtGdiXLATEOBJ_iXlate +# @ stub NtHWCursorUpdatePointer +# @ stub NtInputSpaceRegionFromPoint +# @ stub NtIsOneCoreTransformMode +# @ stub NtMITAccessibilityTimerNotification +# @ stub NtMITActivateInputProcessing +# @ stub NtMITCoreMsgKOpenConnectionTo +# @ stub NtMITDeactivateInputProcessing +# @ stub NtMITDisableMouseIntercept +# @ stub NtMITDispatchCompletion +# @ stub NtMITEnableMouseIntercept +# @ stub NtMITGetCursorUpdateHandle +# @ stub NtMITInitMinuserThread +# @ stub NtMITMinuserSetInputTransformOffset +# @ stub NtMITMinuserWindowCreated +# @ stub NtMITMinuserWindowDestroyed +# @ stub NtMITPostMouseInputMessage +# @ stub NtMITPostThreadEventMessage +# @ stub NtMITPostWindowEventMessage +# @ stub NtMITPrepareReceiveInputMessage +# @ stub NtMITPrepareSendInputMessage +# @ stub NtMITProcessDelegateCapturedPointers +# @ stub NtMITSetForegroundRoutingInfo +# @ stub NtMITSetInputCallbacks +# @ stub NtMITSetInputDelegationMode +# @ stub NtMITSetInputObservationState +# @ stub NtMITSetKeyboardInputRoutingPolicy +# @ stub NtMITSetKeyboardOverriderState +# @ stub NtMITSetLastInputRecipient +# @ stub NtMITSynthesizeKeyboardInput +# @ stub NtMITSynthesizeMouseInput +# @ stub NtMITSynthesizeTouchInput +# @ stub NtMITUninitMinuserThread +# @ stub NtMITUpdateInputGlobals +# @ stub NtMapVisualRelativePoints +# @ stub NtMinGetInputTransform +# @ stub NtMinInteropCoreMessagingWithInput +# @ stub NtMinQPeekForInput +# @ stub NtMinQSuspendInputProcessing +# @ stub NtMinQUpdateWakeMask +# @ stub NtModerncoreBeginLayoutUpdate +# @ stub NtModerncoreCreateDCompositionHwndTarget +# @ stub NtModerncoreCreateGDIHwndTarget +# @ stub NtModerncoreDestroyDCompositionHwndTarget +# @ stub NtModerncoreDestroyGDIHwndTarget +# @ stub NtModerncoreEnableResizeLayoutSynchronization +# @ stub NtModerncoreGetNavigationWindowVisual +# @ stub NtModerncoreGetResizeDCompositionSynchronizationObject +# @ stub NtModerncoreGetWindowContentVisual +# @ stub NtModerncoreIdleTimerThread +# @ stub NtModerncoreIsResizeLayoutSynchronizationEnabled +# @ stub NtModerncoreProcessConnect +# @ stub NtModerncoreRegisterEnhancedNavigationWindowHandle +# @ stub NtModerncoreRegisterNavigationWindowHandle +# @ stub NtModerncoreSetNavigationServiceSid +# @ stub NtModerncoreUnregisterNavigationWindowHandle +# @ stub NtNotifyPresentToCompositionSurface +# @ stub NtOpenCompositionSurfaceDirtyRegion +# @ stub NtOpenCompositionSurfaceSectionInfo +# @ stub NtOpenCompositionSurfaceSwapChainHandleInfo +# @ stub NtQueryCompositionInputIsImplicit +# @ stub NtQueryCompositionInputQueueAndTransform +# @ stub NtQueryCompositionInputSink +# @ stub NtQueryCompositionInputSinkLuid +# @ stub NtQueryCompositionInputSinkViewId +# @ stub NtQueryCompositionSurfaceBinding +# @ stub NtQueryCompositionSurfaceHDRMetaData +# @ stub NtQueryCompositionSurfaceRenderingRealization +# @ stub NtQueryCompositionSurfaceStatistics +# @ stub NtRIMAddInputObserver +# @ stub NtRIMAreSiblingDevices +# @ stub NtRIMDeviceIoControl +# @ stub NtRIMEnableMonitorMappingForDevice +# @ stub NtRIMFreeInputBuffer +# @ stub NtRIMGetDevicePreparsedData +# @ stub NtRIMGetDevicePreparsedDataLockfree +# @ stub NtRIMGetDeviceProperties +# @ stub NtRIMGetDevicePropertiesLockfree +# @ stub NtRIMGetPhysicalDeviceRect +# @ stub NtRIMGetSourceProcessId +# @ stub NtRIMObserveNextInput +# @ stub NtRIMOnPnpNotification +# @ stub NtRIMOnTimerNotification +# @ stub NtRIMQueryDevicePath +# @ stub NtRIMReadInput +# @ stub NtRIMRegisterForInput +# @ stub NtRIMRemoveInputObserver +# @ stub NtRIMSetExtendedDeviceProperty +# @ stub NtRIMSetTestModeStatus +# @ stub NtRIMUnregisterForInput +# @ stub NtRIMUpdateInputObserverRegistration +# @ stub NtSetCompositionSurfaceAnalogExclusive +# @ stub NtSetCompositionSurfaceBufferUsage +# @ stub NtSetCompositionSurfaceDirectFlipState +# @ stub NtSetCompositionSurfaceIndependentFlipInfo +# @ stub NtSetCompositionSurfaceStatistics +# @ stub NtSetCursorInputSpace +# @ stub NtSetPointerDeviceInputSpace +# @ stub NtSetShellCursorState +# @ stub NtTokenManagerConfirmOutstandingAnalogToken +# @ stub NtTokenManagerCreateCompositionTokenHandle +# @ stub NtTokenManagerCreateFlipObjectReturnTokenHandle +# @ stub NtTokenManagerCreateFlipObjectTokenHandle +# @ stub NtTokenManagerGetAnalogExclusiveSurfaceUpdates +# @ stub NtTokenManagerGetAnalogExclusiveTokenEvent +# @ stub NtTokenManagerOpenSectionAndEvents +# @ stub NtTokenManagerThread +# @ stub NtUnBindCompositionSurface +# @ stub NtUpdateInputSinkTransforms +# @ stub NtUserAcquireIAMKey +# @ stub NtUserAcquireInteractiveControlBackgroundAccess @ stdcall NtUserActivateKeyboardLayout(long long) @ stdcall -syscall NtUserAddClipboardFormatListener(long) -@ stub NtUserAddVisualIdentifier -@ stub NtUserAlterWindowStyle -@ stub NtUserAssociateInputContext +# @ stub NtUserAddVisualIdentifier +# @ stub NtUserAlterWindowStyle +# @ stub NtUserAssociateInputContext @ stdcall -syscall NtUserAttachThreadInput(long long long) -@ stub NtUserAutoPromoteMouseInPointer -@ stub NtUserAutoRotateScreen -@ stub NtUserBeginLayoutUpdate -@ stub NtUserBeginPaint -@ stub NtUserBitBltSysBmp -@ stub NtUserBlockInput -@ stub NtUserBroadcastThemeChangeEvent -@ stub NtUserBuildHimcList -@ stub NtUserBuildHwndList -@ stub NtUserBuildNameList -@ stub NtUserBuildPropList -@ stub NtUserCalcMenuBar -@ stub NtUserCalculatePopupWindowPosition -@ stub NtUserCallHwnd -@ stub NtUserCallHwndLock -@ stub NtUserCallHwndLockSafe -@ stub NtUserCallHwndOpt -@ stub NtUserCallHwndParam -@ stub NtUserCallHwndParamLock -@ stub NtUserCallHwndParamLockSafe -@ stub NtUserCallHwndSafe -@ stub NtUserCallMsgFilter -@ stub NtUserCallNextHookEx -@ stub NtUserCallNoParam +# @ stub NtUserAutoPromoteMouseInPointer +# @ stub NtUserAutoRotateScreen +# @ stub NtUserBeginLayoutUpdate +# @ stub NtUserBeginPaint +# @ stub NtUserBitBltSysBmp +# @ stub NtUserBlockInput +# @ stub NtUserBroadcastThemeChangeEvent +# @ stub NtUserBuildHimcList +# @ stub NtUserBuildHwndList +# @ stub NtUserBuildNameList +# @ stub NtUserBuildPropList +# @ stub NtUserCalcMenuBar +# @ stub NtUserCalculatePopupWindowPosition +# @ stub NtUserCallHwnd +# @ stub NtUserCallHwndLock +# @ stub NtUserCallHwndLockSafe +# @ stub NtUserCallHwndOpt +# @ stub NtUserCallHwndParam +# @ stub NtUserCallHwndParamLock +# @ stub NtUserCallHwndParamLockSafe +# @ stub NtUserCallHwndSafe +# @ stub NtUserCallMsgFilter +# @ stub NtUserCallNextHookEx +# @ stub NtUserCallNoParam @ stdcall NtUserCallOneParam(long long) @ stdcall NtUserCallTwoParam(long long long) -@ stub NtUserCanBrokerForceForeground -@ stub NtUserChangeClipboardChain +# @ stub NtUserCanBrokerForceForeground +# @ stub NtUserChangeClipboardChain @ stdcall NtUserChangeDisplaySettings(ptr ptr long long ptr) -@ stub NtUserChangeWindowMessageFilterEx -@ stub NtUserCheckAccessForIntegrityLevel -@ stub NtUserCheckMenuItem -@ stub NtUserCheckProcessForClipboardAccess -@ stub NtUserCheckProcessSession -@ stub NtUserCheckWindowThreadDesktop -@ stub NtUserChildWindowFromPointEx -@ stub NtUserClearForeground -@ stub NtUserClipCursor -@ stub NtUserCloseClipboard +# @ stub NtUserChangeWindowMessageFilterEx +# @ stub NtUserCheckAccessForIntegrityLevel +# @ stub NtUserCheckMenuItem +# @ stub NtUserCheckProcessForClipboardAccess +# @ stub NtUserCheckProcessSession +# @ stub NtUserCheckWindowThreadDesktop +# @ stub NtUserChildWindowFromPointEx +# @ stub NtUserClearForeground +# @ stub NtUserClipCursor +# @ stub NtUserCloseClipboard @ stdcall -syscall NtUserCloseDesktop(long) @ stdcall -syscall NtUserCloseWindowStation(long) -@ stub NtUserCompositionInputSinkLuidFromPoint -@ stub NtUserCompositionInputSinkViewInstanceIdFromPoint -@ stub NtUserConfigureActivationObject -@ stub NtUserConfirmResizeCommit -@ stub NtUserConsoleControl -@ stub NtUserConvertMemHandle -@ stub NtUserCopyAcceleratorTable +# @ stub NtUserCompositionInputSinkLuidFromPoint +# @ stub NtUserCompositionInputSinkViewInstanceIdFromPoint +# @ stub NtUserConfigureActivationObject +# @ stub NtUserConfirmResizeCommit +# @ stub NtUserConsoleControl +# @ stub NtUserConvertMemHandle +# @ stub NtUserCopyAcceleratorTable @ stdcall NtUserCountClipboardFormats() -@ stub NtUserCreateAcceleratorTable -@ stub NtUserCreateActivationGroup -@ stub NtUserCreateActivationObject -@ stub NtUserCreateCaret -@ stub NtUserCreateDCompositionHwndTarget +# @ stub NtUserCreateAcceleratorTable +# @ stub NtUserCreateActivationGroup +# @ stub NtUserCreateActivationObject +# @ stub NtUserCreateCaret +# @ stub NtUserCreateDCompositionHwndTarget @ stdcall -syscall NtUserCreateDesktopEx(ptr ptr ptr long long long) -@ stub NtUserCreateEmptyCursorObject -@ stub NtUserCreateInputContext -@ stub NtUserCreateLocalMemHandle -@ stub NtUserCreatePalmRejectionDelayZone -@ stub NtUserCreateWindowEx -@ stub NtUserCreateWindowGroup +# @ stub NtUserCreateEmptyCursorObject +# @ stub NtUserCreateInputContext +# @ stub NtUserCreateLocalMemHandle +# @ stub NtUserCreatePalmRejectionDelayZone +# @ stub NtUserCreateWindowEx +# @ stub NtUserCreateWindowGroup @ stdcall -syscall NtUserCreateWindowStation(ptr long long long long long long) -@ stub NtUserCtxDisplayIOCtl -@ stub NtUserDdeInitialize -@ stub NtUserDefSetText -@ stub NtUserDeferWindowDpiChanges -@ stub NtUserDeferWindowPosAndBand -@ stub NtUserDelegateCapturePointers -@ stub NtUserDelegateInput -@ stub NtUserDeleteMenu -@ stub NtUserDeleteWindowGroup -@ stub NtUserDestroyAcceleratorTable -@ stub NtUserDestroyActivationGroup -@ stub NtUserDestroyActivationObject -@ stub NtUserDestroyCursor -@ stub NtUserDestroyDCompositionHwndTarget -@ stub NtUserDestroyInputContext -@ stub NtUserDestroyMenu -@ stub NtUserDestroyPalmRejectionDelayZone -@ stub NtUserDestroyWindow -@ stub NtUserDisableImmersiveOwner -@ stub NtUserDisableProcessWindowFiltering -@ stub NtUserDisableThreadIme -@ stub NtUserDiscardPointerFrameMessages -@ stub NtUserDispatchMessage -@ stub NtUserDisplayConfigGetDeviceInfo -@ stub NtUserDisplayConfigSetDeviceInfo -@ stub NtUserDoSoundConnect -@ stub NtUserDoSoundDisconnect -@ stub NtUserDownlevelTouchpad -@ stub NtUserDragDetect -@ stub NtUserDragObject -@ stub NtUserDrawAnimatedRects -@ stub NtUserDrawCaption -@ stub NtUserDrawCaptionTemp -@ stub NtUserDrawIconEx -@ stub NtUserDrawMenuBarTemp -@ stub NtUserDwmGetRemoteSessionOcclusionEvent -@ stub NtUserDwmGetRemoteSessionOcclusionState -@ stub NtUserDwmKernelShutdown -@ stub NtUserDwmKernelStartup -@ stub NtUserDwmValidateWindow -@ stub NtUserEmptyClipboard -@ stub NtUserEnableChildWindowDpiMessage -@ stub NtUserEnableIAMAccess -@ stub NtUserEnableMenuItem -@ stub NtUserEnableMouseInPointer -@ stub NtUserEnableMouseInPointerForWindow -@ stub NtUserEnableMouseInputForCursorSuppression -@ stub NtUserEnableNonClientDpiScaling -@ stub NtUserEnableResizeLayoutSynchronization -@ stub NtUserEnableScrollBar -@ stub NtUserEnableSoftwareCursorForScreenCapture -@ stub NtUserEnableTouchPad -@ stub NtUserEnableWindowGDIScaledDpiMessage -@ stub NtUserEnableWindowGroupPolicy -@ stub NtUserEnableWindowResizeOptimization -@ stub NtUserEndDeferWindowPosEx -@ stub NtUserEndMenu -@ stub NtUserEndPaint +# @ stub NtUserCtxDisplayIOCtl +# @ stub NtUserDdeInitialize +# @ stub NtUserDefSetText +# @ stub NtUserDeferWindowDpiChanges +# @ stub NtUserDeferWindowPosAndBand +# @ stub NtUserDelegateCapturePointers +# @ stub NtUserDelegateInput +# @ stub NtUserDeleteMenu +# @ stub NtUserDeleteWindowGroup +# @ stub NtUserDestroyAcceleratorTable +# @ stub NtUserDestroyActivationGroup +# @ stub NtUserDestroyActivationObject +# @ stub NtUserDestroyCursor +# @ stub NtUserDestroyDCompositionHwndTarget +# @ stub NtUserDestroyInputContext +# @ stub NtUserDestroyMenu +# @ stub NtUserDestroyPalmRejectionDelayZone +# @ stub NtUserDestroyWindow +# @ stub NtUserDisableImmersiveOwner +# @ stub NtUserDisableProcessWindowFiltering +# @ stub NtUserDisableThreadIme +# @ stub NtUserDiscardPointerFrameMessages +# @ stub NtUserDispatchMessage +# @ stub NtUserDisplayConfigGetDeviceInfo +# @ stub NtUserDisplayConfigSetDeviceInfo +# @ stub NtUserDoSoundConnect +# @ stub NtUserDoSoundDisconnect +# @ stub NtUserDownlevelTouchpad +# @ stub NtUserDragDetect +# @ stub NtUserDragObject +# @ stub NtUserDrawAnimatedRects +# @ stub NtUserDrawCaption +# @ stub NtUserDrawCaptionTemp +# @ stub NtUserDrawIconEx +# @ stub NtUserDrawMenuBarTemp +# @ stub NtUserDwmGetRemoteSessionOcclusionEvent +# @ stub NtUserDwmGetRemoteSessionOcclusionState +# @ stub NtUserDwmKernelShutdown +# @ stub NtUserDwmKernelStartup +# @ stub NtUserDwmValidateWindow +# @ stub NtUserEmptyClipboard +# @ stub NtUserEnableChildWindowDpiMessage +# @ stub NtUserEnableIAMAccess +# @ stub NtUserEnableMenuItem +# @ stub NtUserEnableMouseInPointer +# @ stub NtUserEnableMouseInPointerForWindow +# @ stub NtUserEnableMouseInputForCursorSuppression +# @ stub NtUserEnableNonClientDpiScaling +# @ stub NtUserEnableResizeLayoutSynchronization +# @ stub NtUserEnableScrollBar +# @ stub NtUserEnableSoftwareCursorForScreenCapture +# @ stub NtUserEnableTouchPad +# @ stub NtUserEnableWindowGDIScaledDpiMessage +# @ stub NtUserEnableWindowGroupPolicy +# @ stub NtUserEnableWindowResizeOptimization +# @ stub NtUserEndDeferWindowPosEx +# @ stub NtUserEndMenu +# @ stub NtUserEndPaint @ stdcall NtUserEnumDisplayDevices(ptr long ptr long) @ stdcall NtUserEnumDisplayMonitors(long ptr ptr long) @ stdcall NtUserEnumDisplaySettings(ptr long ptr long) -@ stub NtUserEvent -@ stub NtUserExcludeUpdateRgn -@ stub NtUserFillWindow -@ stub NtUserFindExistingCursorIcon -@ stub NtUserFindWindowEx -@ stub NtUserFlashWindowEx -@ stub NtUserForceWindowToDpiForTest -@ stub NtUserFrostCrashedWindow -@ stub NtUserFunctionalizeDisplayConfig -@ stub NtUserGetActiveProcessesDpis -@ stub NtUserGetAltTabInfo -@ stub NtUserGetAncestor -@ stub NtUserGetAppImeLevel -@ stub NtUserGetAsyncKeyState -@ stub NtUserGetAtomName -@ stub NtUserGetAutoRotationState -@ stub NtUserGetCIMSSM -@ stub NtUserGetCPD -@ stub NtUserGetCaretBlinkTime -@ stub NtUserGetCaretPos -@ stub NtUserGetClassInfoEx -@ stub NtUserGetClassName -@ stub NtUserGetClipCursor -@ stub NtUserGetClipboardAccessToken -@ stub NtUserGetClipboardData +# @ stub NtUserEvent +# @ stub NtUserExcludeUpdateRgn +# @ stub NtUserFillWindow +# @ stub NtUserFindExistingCursorIcon +# @ stub NtUserFindWindowEx +# @ stub NtUserFlashWindowEx +# @ stub NtUserForceWindowToDpiForTest +# @ stub NtUserFrostCrashedWindow +# @ stub NtUserFunctionalizeDisplayConfig +# @ stub NtUserGetActiveProcessesDpis +# @ stub NtUserGetAltTabInfo +# @ stub NtUserGetAncestor +# @ stub NtUserGetAppImeLevel +# @ stub NtUserGetAsyncKeyState +# @ stub NtUserGetAtomName +# @ stub NtUserGetAutoRotationState +# @ stub NtUserGetCIMSSM +# @ stub NtUserGetCPD +# @ stub NtUserGetCaretBlinkTime +# @ stub NtUserGetCaretPos +# @ stub NtUserGetClassInfoEx +# @ stub NtUserGetClassName +# @ stub NtUserGetClipCursor +# @ stub NtUserGetClipboardAccessToken +# @ stub NtUserGetClipboardData @ stdcall -syscall NtUserGetClipboardFormatName(long ptr long) @ stdcall -syscall NtUserGetClipboardOwner() @ stdcall -syscall NtUserGetClipboardSequenceNumber() @ stdcall -syscall NtUserGetClipboardViewer() -@ stub NtUserGetComboBoxInfo -@ stub NtUserGetControlBrush -@ stub NtUserGetControlColor -@ stub NtUserGetCurrentDpiInfoForWindow -@ stub NtUserGetCurrentInputMessageSource +# @ stub NtUserGetComboBoxInfo +# @ stub NtUserGetControlBrush +# @ stub NtUserGetControlColor +# @ stub NtUserGetCurrentDpiInfoForWindow +# @ stub NtUserGetCurrentInputMessageSource @ stdcall -syscall NtUserGetCursor() -@ stub NtUserGetCursorFrameInfo -@ stub NtUserGetCursorInfo -@ stub NtUserGetDC -@ stub NtUserGetDCEx -@ stub NtUserGetDManipHookInitFunction -@ stub NtUserGetDesktopID -@ stub NtUserGetDisplayAutoRotationPreferences -@ stub NtUserGetDisplayAutoRotationPreferencesByProcessId +# @ stub NtUserGetCursorFrameInfo +# @ stub NtUserGetCursorInfo +# @ stub NtUserGetDC +# @ stub NtUserGetDCEx +# @ stub NtUserGetDManipHookInitFunction +# @ stub NtUserGetDesktopID +# @ stub NtUserGetDisplayAutoRotationPreferences +# @ stub NtUserGetDisplayAutoRotationPreferencesByProcessId @ stdcall NtUserGetDisplayConfigBufferSizes(long ptr ptr) @ stdcall -syscall NtUserGetDoubleClickTime() -@ stub NtUserGetDpiForCurrentProcess +# @ stub NtUserGetDpiForCurrentProcess @ stdcall -syscall NtUserGetDpiForMonitor(long long ptr ptr) -@ stub NtUserGetExtendedPointerDeviceProperty -@ stub NtUserGetForegroundWindow -@ stub NtUserGetGUIThreadInfo -@ stub NtUserGetGestureConfig -@ stub NtUserGetGestureExtArgs -@ stub NtUserGetGestureInfo -@ stub NtUserGetGuiResources -@ stub NtUserGetHDevName -@ stub NtUserGetHimetricScaleFactorFromPixelLocation -@ stub NtUserGetIconInfo -@ stub NtUserGetIconSize -@ stub NtUserGetImeHotKey -@ stub NtUserGetImeInfoEx -@ stub NtUserGetInputContainerId -@ stub NtUserGetInputLocaleInfo -@ stub NtUserGetInteractiveControlDeviceInfo -@ stub NtUserGetInteractiveControlInfo -@ stub NtUserGetInteractiveCtrlSupportedWaveforms -@ stub NtUserGetInternalWindowPos +# @ stub NtUserGetExtendedPointerDeviceProperty +# @ stub NtUserGetForegroundWindow +# @ stub NtUserGetGUIThreadInfo +# @ stub NtUserGetGestureConfig +# @ stub NtUserGetGestureExtArgs +# @ stub NtUserGetGestureInfo +# @ stub NtUserGetGuiResources +# @ stub NtUserGetHDevName +# @ stub NtUserGetHimetricScaleFactorFromPixelLocation +# @ stub NtUserGetIconInfo +# @ stub NtUserGetIconSize +# @ stub NtUserGetImeHotKey +# @ stub NtUserGetImeInfoEx +# @ stub NtUserGetInputContainerId +# @ stub NtUserGetInputLocaleInfo +# @ stub NtUserGetInteractiveControlDeviceInfo +# @ stub NtUserGetInteractiveControlInfo +# @ stub NtUserGetInteractiveCtrlSupportedWaveforms +# @ stub NtUserGetInternalWindowPos @ stdcall NtUserGetKeyNameText(long ptr long) @ stdcall -syscall NtUserGetKeyState(long) @ stdcall -syscall NtUserGetKeyboardLayout(long) @@ -951,370 +951,370 @@ @ stdcall -syscall NtUserGetKeyboardLayoutName(ptr) @ stdcall -syscall NtUserGetKeyboardState(ptr) @ stdcall -syscall NtUserGetLayeredWindowAttributes(long ptr ptr ptr) -@ stub NtUserGetListBoxInfo -@ stub NtUserGetMenuBarInfo -@ stub NtUserGetMenuIndex -@ stub NtUserGetMenuItemRect -@ stub NtUserGetMessage +# @ stub NtUserGetListBoxInfo +# @ stub NtUserGetMenuBarInfo +# @ stub NtUserGetMenuIndex +# @ stub NtUserGetMenuItemRect +# @ stub NtUserGetMessage @ stdcall -syscall NtUserGetMouseMovePointsEx(long ptr ptr long long) @ stdcall -syscall NtUserGetObjectInformation(long long long long ptr) -@ stub NtUserGetOemBitmapSize +# @ stub NtUserGetOemBitmapSize @ stdcall -syscall NtUserGetOpenClipboardWindow() -@ stub NtUserGetOwnerTransformedMonitorRect -@ stub NtUserGetPhysicalDeviceRect -@ stub NtUserGetPointerCursorId -@ stub NtUserGetPointerDevice -@ stub NtUserGetPointerDeviceCursors -@ stub NtUserGetPointerDeviceInputSpace -@ stub NtUserGetPointerDeviceOrientation -@ stub NtUserGetPointerDeviceProperties -@ stub NtUserGetPointerDeviceRects -@ stub NtUserGetPointerDevices -@ stub NtUserGetPointerFrameTimes -@ stub NtUserGetPointerInfoList -@ stub NtUserGetPointerInputTransform -@ stub NtUserGetPointerProprietaryId -@ stub NtUserGetPointerType -@ stub NtUserGetPrecisionTouchPadConfiguration +# @ stub NtUserGetOwnerTransformedMonitorRect +# @ stub NtUserGetPhysicalDeviceRect +# @ stub NtUserGetPointerCursorId +# @ stub NtUserGetPointerDevice +# @ stub NtUserGetPointerDeviceCursors +# @ stub NtUserGetPointerDeviceInputSpace +# @ stub NtUserGetPointerDeviceOrientation +# @ stub NtUserGetPointerDeviceProperties +# @ stub NtUserGetPointerDeviceRects +# @ stub NtUserGetPointerDevices +# @ stub NtUserGetPointerFrameTimes +# @ stub NtUserGetPointerInfoList +# @ stub NtUserGetPointerInputTransform +# @ stub NtUserGetPointerProprietaryId +# @ stub NtUserGetPointerType +# @ stub NtUserGetPrecisionTouchPadConfiguration @ stdcall NtUserGetPriorityClipboardFormat(ptr long) @ stdcall -syscall NtUserGetProcessDpiAwarenessContext(long) -@ stub NtUserGetProcessUIContextInformation +# @ stub NtUserGetProcessUIContextInformation @ stdcall -syscall NtUserGetProcessWindowStation() @ stdcall -syscall NtUserGetProp(long wstr) -@ stub NtUserGetQueueStatus -@ stub NtUserGetQueueStatusReadonly -@ stub NtUserGetRawInputBuffer -@ stub NtUserGetRawInputData -@ stub NtUserGetRawInputDeviceInfo -@ stub NtUserGetRawInputDeviceList -@ stub NtUserGetRawPointerDeviceData -@ stub NtUserGetRegisteredRawInputDevices -@ stub NtUserGetRequiredCursorSizes -@ stub NtUserGetResizeDCompositionSynchronizationObject -@ stub NtUserGetScrollBarInfo -@ stub NtUserGetSharedWindowData +# @ stub NtUserGetQueueStatus +# @ stub NtUserGetQueueStatusReadonly +# @ stub NtUserGetRawInputBuffer +# @ stub NtUserGetRawInputData +# @ stub NtUserGetRawInputDeviceInfo +# @ stub NtUserGetRawInputDeviceList +# @ stub NtUserGetRawPointerDeviceData +# @ stub NtUserGetRegisteredRawInputDevices +# @ stub NtUserGetRequiredCursorSizes +# @ stub NtUserGetResizeDCompositionSynchronizationObject +# @ stub NtUserGetScrollBarInfo +# @ stub NtUserGetSharedWindowData @ stdcall -syscall NtUserGetSystemDpiForProcess(long) -@ stub NtUserGetSystemMenu +# @ stub NtUserGetSystemMenu @ stdcall -syscall NtUserGetThreadDesktop(long) -@ stub NtUserGetThreadState -@ stub NtUserGetTitleBarInfo -@ stub NtUserGetTopLevelWindow -@ stub NtUserGetTouchInputInfo -@ stub NtUserGetTouchValidationStatus -@ stub NtUserGetUniformSpaceMapping -@ stub NtUserGetUpdateRect -@ stub NtUserGetUpdateRgn +# @ stub NtUserGetThreadState +# @ stub NtUserGetTitleBarInfo +# @ stub NtUserGetTopLevelWindow +# @ stub NtUserGetTouchInputInfo +# @ stub NtUserGetTouchValidationStatus +# @ stub NtUserGetUniformSpaceMapping +# @ stub NtUserGetUpdateRect +# @ stub NtUserGetUpdateRgn @ stdcall NtUserGetUpdatedClipboardFormats(ptr long ptr) -@ stub NtUserGetWOWClass -@ stub NtUserGetWindowBand -@ stub NtUserGetWindowCompositionAttribute -@ stub NtUserGetWindowCompositionInfo -@ stub NtUserGetWindowDC -@ stub NtUserGetWindowDisplayAffinity -@ stub NtUserGetWindowFeedbackSetting -@ stub NtUserGetWindowGroupId -@ stub NtUserGetWindowMinimizeRect -@ stub NtUserGetWindowPlacement -@ stub NtUserGetWindowProcessHandle -@ stub NtUserGetWindowRgnEx -@ stub NtUserGhostWindowFromHungWindow -@ stub NtUserHandleDelegatedInput -@ stub NtUserHardErrorControl -@ stub NtUserHideCaret -@ stub NtUserHidePointerContactVisualization -@ stub NtUserHiliteMenuItem -@ stub NtUserHungWindowFromGhostWindow -@ stub NtUserHwndQueryRedirectionInfo -@ stub NtUserHwndSetRedirectionInfo -@ stub NtUserImpersonateDdeClientWindow -@ stub NtUserInheritWindowMonitor -@ stub NtUserInitTask -@ stub NtUserInitialize -@ stub NtUserInitializeClientPfnArrays -@ stub NtUserInitializeGenericHidInjection -@ stub NtUserInitializeInputDeviceInjection -@ stub NtUserInitializePointerDeviceInjection -@ stub NtUserInitializePointerDeviceInjectionEx -@ stub NtUserInitializeTouchInjection -@ stub NtUserInjectDeviceInput -@ stub NtUserInjectGenericHidInput -@ stub NtUserInjectGesture -@ stub NtUserInjectKeyboardInput -@ stub NtUserInjectMouseInput -@ stub NtUserInjectPointerInput -@ stub NtUserInjectTouchInput -@ stub NtUserInteractiveControlQueryUsage -@ stub NtUserInternalGetWindowIcon -@ stub NtUserInternalGetWindowText -@ stub NtUserInternalToUnicode -@ stub NtUserInvalidateRect -@ stub NtUserInvalidateRgn -@ stub NtUserIsChildWindowDpiMessageEnabled +# @ stub NtUserGetWOWClass +# @ stub NtUserGetWindowBand +# @ stub NtUserGetWindowCompositionAttribute +# @ stub NtUserGetWindowCompositionInfo +# @ stub NtUserGetWindowDC +# @ stub NtUserGetWindowDisplayAffinity +# @ stub NtUserGetWindowFeedbackSetting +# @ stub NtUserGetWindowGroupId +# @ stub NtUserGetWindowMinimizeRect +# @ stub NtUserGetWindowPlacement +# @ stub NtUserGetWindowProcessHandle +# @ stub NtUserGetWindowRgnEx +# @ stub NtUserGhostWindowFromHungWindow +# @ stub NtUserHandleDelegatedInput +# @ stub NtUserHardErrorControl +# @ stub NtUserHideCaret +# @ stub NtUserHidePointerContactVisualization +# @ stub NtUserHiliteMenuItem +# @ stub NtUserHungWindowFromGhostWindow +# @ stub NtUserHwndQueryRedirectionInfo +# @ stub NtUserHwndSetRedirectionInfo +# @ stub NtUserImpersonateDdeClientWindow +# @ stub NtUserInheritWindowMonitor +# @ stub NtUserInitTask +# @ stub NtUserInitialize +# @ stub NtUserInitializeClientPfnArrays +# @ stub NtUserInitializeGenericHidInjection +# @ stub NtUserInitializeInputDeviceInjection +# @ stub NtUserInitializePointerDeviceInjection +# @ stub NtUserInitializePointerDeviceInjectionEx +# @ stub NtUserInitializeTouchInjection +# @ stub NtUserInjectDeviceInput +# @ stub NtUserInjectGenericHidInput +# @ stub NtUserInjectGesture +# @ stub NtUserInjectKeyboardInput +# @ stub NtUserInjectMouseInput +# @ stub NtUserInjectPointerInput +# @ stub NtUserInjectTouchInput +# @ stub NtUserInteractiveControlQueryUsage +# @ stub NtUserInternalGetWindowIcon +# @ stub NtUserInternalGetWindowText +# @ stub NtUserInternalToUnicode +# @ stub NtUserInvalidateRect +# @ stub NtUserInvalidateRgn +# @ stub NtUserIsChildWindowDpiMessageEnabled @ stdcall NtUserIsClipboardFormatAvailable(long) -@ stub NtUserIsMouseInPointerEnabled -@ stub NtUserIsMouseInputEnabled -@ stub NtUserIsNonClientDpiScalingEnabled -@ stub NtUserIsResizeLayoutSynchronizationEnabled -@ stub NtUserIsTopLevelWindow -@ stub NtUserIsTouchWindow -@ stub NtUserIsWindowBroadcastingDpiToChildren -@ stub NtUserIsWindowGDIScaledDpiMessageEnabled -@ stub NtUserKillTimer -@ stub NtUserLayoutCompleted -@ stub NtUserLinkDpiCursor -@ stub NtUserLoadKeyboardLayoutEx -@ stub NtUserLockCursor -@ stub NtUserLockWindowStation -@ stub NtUserLockWindowUpdate -@ stub NtUserLockWorkStation -@ stub NtUserLogicalToPerMonitorDPIPhysicalPoint -@ stub NtUserLogicalToPhysicalDpiPointForWindow -@ stub NtUserLogicalToPhysicalPoint -@ stub NtUserMNDragLeave -@ stub NtUserMNDragOver -@ stub NtUserMagControl -@ stub NtUserMagGetContextInformation -@ stub NtUserMagSetContextInformation -@ stub NtUserMapPointsByVisualIdentifier +# @ stub NtUserIsMouseInPointerEnabled +# @ stub NtUserIsMouseInputEnabled +# @ stub NtUserIsNonClientDpiScalingEnabled +# @ stub NtUserIsResizeLayoutSynchronizationEnabled +# @ stub NtUserIsTopLevelWindow +# @ stub NtUserIsTouchWindow +# @ stub NtUserIsWindowBroadcastingDpiToChildren +# @ stub NtUserIsWindowGDIScaledDpiMessageEnabled +# @ stub NtUserKillTimer +# @ stub NtUserLayoutCompleted +# @ stub NtUserLinkDpiCursor +# @ stub NtUserLoadKeyboardLayoutEx +# @ stub NtUserLockCursor +# @ stub NtUserLockWindowStation +# @ stub NtUserLockWindowUpdate +# @ stub NtUserLockWorkStation +# @ stub NtUserLogicalToPerMonitorDPIPhysicalPoint +# @ stub NtUserLogicalToPhysicalDpiPointForWindow +# @ stub NtUserLogicalToPhysicalPoint +# @ stub NtUserMNDragLeave +# @ stub NtUserMNDragOver +# @ stub NtUserMagControl +# @ stub NtUserMagGetContextInformation +# @ stub NtUserMagSetContextInformation +# @ stub NtUserMapPointsByVisualIdentifier @ stdcall NtUserMapVirtualKeyEx(long long long) -@ stub NtUserMarkWindowForRawMouse -@ stub NtUserMenuItemFromPoint -@ stub NtUserMessageCall -@ stub NtUserMinInitialize -@ stub NtUserMinMaximize -@ stub NtUserModifyUserStartupInfoFlags -@ stub NtUserModifyWindowTouchCapability -@ stub NtUserMoveWindow -@ stub NtUserMsgWaitForMultipleObjectsEx -@ stub NtUserNavigateFocus -@ stub NtUserNotifyIMEStatus -@ stub NtUserNotifyProcessCreate -@ stub NtUserNotifyWinEvent -@ stub NtUserOpenClipboard +# @ stub NtUserMarkWindowForRawMouse +# @ stub NtUserMenuItemFromPoint +# @ stub NtUserMessageCall +# @ stub NtUserMinInitialize +# @ stub NtUserMinMaximize +# @ stub NtUserModifyUserStartupInfoFlags +# @ stub NtUserModifyWindowTouchCapability +# @ stub NtUserMoveWindow +# @ stub NtUserMsgWaitForMultipleObjectsEx +# @ stub NtUserNavigateFocus +# @ stub NtUserNotifyIMEStatus +# @ stub NtUserNotifyProcessCreate +# @ stub NtUserNotifyWinEvent +# @ stub NtUserOpenClipboard @ stdcall -syscall NtUserOpenDesktop(ptr long long) @ stdcall -syscall NtUserOpenInputDesktop(long long long) -@ stub NtUserOpenThreadDesktop +# @ stub NtUserOpenThreadDesktop @ stdcall -syscall NtUserOpenWindowStation(ptr long) -@ stub NtUserPaintDesktop -@ stub NtUserPaintMenuBar -@ stub NtUserPaintMonitor -@ stub NtUserPeekMessage -@ stub NtUserPerMonitorDPIPhysicalToLogicalPoint -@ stub NtUserPhysicalToLogicalDpiPointForWindow -@ stub NtUserPhysicalToLogicalPoint -@ stub NtUserPostKeyboardInputMessage -@ stub NtUserPostMessage -@ stub NtUserPostThreadMessage -@ stub NtUserPrintWindow -@ stub NtUserProcessConnect -@ stub NtUserProcessInkFeedbackCommand -@ stub NtUserPromoteMouseInPointer -@ stub NtUserPromotePointer -@ stub NtUserQueryActivationObject -@ stub NtUserQueryBSDRWindow -@ stub NtUserQueryDisplayConfig -@ stub NtUserQueryInformationThread -@ stub NtUserQueryInputContext -@ stub NtUserQuerySendMessage -@ stub NtUserQueryWindow -@ stub NtUserRealChildWindowFromPoint -@ stub NtUserRealInternalGetMessage -@ stub NtUserRealWaitMessageEx -@ stub NtUserRedrawWindow -@ stub NtUserRegisterBSDRWindow -@ stub NtUserRegisterClassExWOW -@ stub NtUserRegisterDManipHook -@ stub NtUserRegisterEdgy -@ stub NtUserRegisterErrorReportingDialog -@ stub NtUserRegisterHotKey -@ stub NtUserRegisterManipulationThread -@ stub NtUserRegisterPointerDeviceNotifications -@ stub NtUserRegisterPointerInputTarget -@ stub NtUserRegisterRawInputDevices -@ stub NtUserRegisterServicesProcess -@ stub NtUserRegisterSessionPort -@ stub NtUserRegisterShellPTPListener -@ stub NtUserRegisterTasklist -@ stub NtUserRegisterTouchHitTestingWindow -@ stub NtUserRegisterTouchPadCapable -@ stub NtUserRegisterUserApiHook -@ stub NtUserRegisterWindowMessage -@ stub NtUserReleaseDC -@ stub NtUserReleaseDwmHitTestWaiters -@ stub NtUserRemoteConnect -@ stub NtUserRemoteRedrawRectangle -@ stub NtUserRemoteRedrawScreen -@ stub NtUserRemoteStopScreenUpdates +# @ stub NtUserPaintDesktop +# @ stub NtUserPaintMenuBar +# @ stub NtUserPaintMonitor +# @ stub NtUserPeekMessage +# @ stub NtUserPerMonitorDPIPhysicalToLogicalPoint +# @ stub NtUserPhysicalToLogicalDpiPointForWindow +# @ stub NtUserPhysicalToLogicalPoint +# @ stub NtUserPostKeyboardInputMessage +# @ stub NtUserPostMessage +# @ stub NtUserPostThreadMessage +# @ stub NtUserPrintWindow +# @ stub NtUserProcessConnect +# @ stub NtUserProcessInkFeedbackCommand +# @ stub NtUserPromoteMouseInPointer +# @ stub NtUserPromotePointer +# @ stub NtUserQueryActivationObject +# @ stub NtUserQueryBSDRWindow +# @ stub NtUserQueryDisplayConfig +# @ stub NtUserQueryInformationThread +# @ stub NtUserQueryInputContext +# @ stub NtUserQuerySendMessage +# @ stub NtUserQueryWindow +# @ stub NtUserRealChildWindowFromPoint +# @ stub NtUserRealInternalGetMessage +# @ stub NtUserRealWaitMessageEx +# @ stub NtUserRedrawWindow +# @ stub NtUserRegisterBSDRWindow +# @ stub NtUserRegisterClassExWOW +# @ stub NtUserRegisterDManipHook +# @ stub NtUserRegisterEdgy +# @ stub NtUserRegisterErrorReportingDialog +# @ stub NtUserRegisterHotKey +# @ stub NtUserRegisterManipulationThread +# @ stub NtUserRegisterPointerDeviceNotifications +# @ stub NtUserRegisterPointerInputTarget +# @ stub NtUserRegisterRawInputDevices +# @ stub NtUserRegisterServicesProcess +# @ stub NtUserRegisterSessionPort +# @ stub NtUserRegisterShellPTPListener +# @ stub NtUserRegisterTasklist +# @ stub NtUserRegisterTouchHitTestingWindow +# @ stub NtUserRegisterTouchPadCapable +# @ stub NtUserRegisterUserApiHook +# @ stub NtUserRegisterWindowMessage +# @ stub NtUserReleaseDC +# @ stub NtUserReleaseDwmHitTestWaiters +# @ stub NtUserRemoteConnect +# @ stub NtUserRemoteRedrawRectangle +# @ stub NtUserRemoteRedrawScreen +# @ stub NtUserRemoteStopScreenUpdates @ stdcall -syscall NtUserRemoveClipboardFormatListener(long) -@ stub NtUserRemoveInjectionDevice -@ stub NtUserRemoveMenu +# @ stub NtUserRemoveInjectionDevice +# @ stub NtUserRemoveMenu @ stdcall -syscall NtUserRemoveProp(long wstr) -@ stub NtUserRemoveVisualIdentifier -@ stub NtUserReportInertia -@ stub NtUserRequestMoveSizeOperation -@ stub NtUserResolveDesktopForWOW -@ stub NtUserRestoreWindowDpiChanges -@ stub NtUserSBGetParms +# @ stub NtUserRemoveVisualIdentifier +# @ stub NtUserReportInertia +# @ stub NtUserRequestMoveSizeOperation +# @ stub NtUserResolveDesktopForWOW +# @ stub NtUserRestoreWindowDpiChanges +# @ stub NtUserSBGetParms @ stdcall NtUserScrollDC(long long long ptr ptr long ptr) -@ stub NtUserScrollWindowEx +# @ stub NtUserScrollWindowEx @ stdcall NtUserSelectPalette(long long long) -@ stub NtUserSendEventMessage -@ stub NtUserSendInput -@ stub NtUserSendInteractiveControlHapticsReport -@ stub NtUserSetActivationFilter -@ stub NtUserSetActiveProcessForMonitor -@ stub NtUserSetActiveWindow -@ stub NtUserSetAppImeLevel -@ stub NtUserSetAutoRotation -@ stub NtUserSetBridgeWindowChild -@ stub NtUserSetBrokeredForeground -@ stub NtUserSetCalibrationData -@ stub NtUserSetCapture -@ stub NtUserSetChildWindowNoActivate -@ stub NtUserSetClassLong -@ stub NtUserSetClassLongPtr -@ stub NtUserSetClassWord -@ stub NtUserSetClipboardData -@ stub NtUserSetClipboardViewer -@ stub NtUserSetCoreWindow -@ stub NtUserSetCoreWindowPartner -@ stub NtUserSetCursor -@ stub NtUserSetCursorContents -@ stub NtUserSetCursorIconData -@ stub NtUserSetCursorPos -@ stub NtUserSetDesktopColorTransform -@ stub NtUserSetDesktopVisualInputSink -@ stub NtUserSetDialogControlDpiChangeBehavior -@ stub NtUserSetDisplayAutoRotationPreferences -@ stub NtUserSetDisplayConfig -@ stub NtUserSetDisplayMapping -@ stub NtUserSetFallbackForeground -@ stub NtUserSetFeatureReportResponse -@ stub NtUserSetFocus -@ stub NtUserSetForegroundWindowForApplication -@ stub NtUserSetFullscreenMagnifierOffsetsDWMUpdated -@ stub NtUserSetGestureConfig -@ stub NtUserSetImeHotKey -@ stub NtUserSetImeInfoEx -@ stub NtUserSetImeOwnerWindow -@ stub NtUserSetInformationThread -@ stub NtUserSetInputServiceState -@ stub NtUserSetInteractiveControlFocus -@ stub NtUserSetInteractiveCtrlRotationAngle -@ stub NtUserSetInternalWindowPos +# @ stub NtUserSendEventMessage +# @ stub NtUserSendInput +# @ stub NtUserSendInteractiveControlHapticsReport +# @ stub NtUserSetActivationFilter +# @ stub NtUserSetActiveProcessForMonitor +# @ stub NtUserSetActiveWindow +# @ stub NtUserSetAppImeLevel +# @ stub NtUserSetAutoRotation +# @ stub NtUserSetBridgeWindowChild +# @ stub NtUserSetBrokeredForeground +# @ stub NtUserSetCalibrationData +# @ stub NtUserSetCapture +# @ stub NtUserSetChildWindowNoActivate +# @ stub NtUserSetClassLong +# @ stub NtUserSetClassLongPtr +# @ stub NtUserSetClassWord +# @ stub NtUserSetClipboardData +# @ stub NtUserSetClipboardViewer +# @ stub NtUserSetCoreWindow +# @ stub NtUserSetCoreWindowPartner +# @ stub NtUserSetCursor +# @ stub NtUserSetCursorContents +# @ stub NtUserSetCursorIconData +# @ stub NtUserSetCursorPos +# @ stub NtUserSetDesktopColorTransform +# @ stub NtUserSetDesktopVisualInputSink +# @ stub NtUserSetDialogControlDpiChangeBehavior +# @ stub NtUserSetDisplayAutoRotationPreferences +# @ stub NtUserSetDisplayConfig +# @ stub NtUserSetDisplayMapping +# @ stub NtUserSetFallbackForeground +# @ stub NtUserSetFeatureReportResponse +# @ stub NtUserSetFocus +# @ stub NtUserSetForegroundWindowForApplication +# @ stub NtUserSetFullscreenMagnifierOffsetsDWMUpdated +# @ stub NtUserSetGestureConfig +# @ stub NtUserSetImeHotKey +# @ stub NtUserSetImeInfoEx +# @ stub NtUserSetImeOwnerWindow +# @ stub NtUserSetInformationThread +# @ stub NtUserSetInputServiceState +# @ stub NtUserSetInteractiveControlFocus +# @ stub NtUserSetInteractiveCtrlRotationAngle +# @ stub NtUserSetInternalWindowPos @ stdcall -syscall NtUserSetKeyboardState(ptr) -@ stub NtUserSetLayeredWindowAttributes -@ stub NtUserSetMagnificationDesktopMagnifierOffsetsDWMUpdated -@ stub NtUserSetManipulationInputTarget -@ stub NtUserSetMenu -@ stub NtUserSetMenuContextHelpId -@ stub NtUserSetMenuDefaultItem -@ stub NtUserSetMenuFlagRtoL -@ stub NtUserSetMirrorRendering -@ stub NtUserSetMonitorWorkArea -@ stub NtUserSetMouseInputRateLimitingTimer +# @ stub NtUserSetLayeredWindowAttributes +# @ stub NtUserSetMagnificationDesktopMagnifierOffsetsDWMUpdated +# @ stub NtUserSetManipulationInputTarget +# @ stub NtUserSetMenu +# @ stub NtUserSetMenuContextHelpId +# @ stub NtUserSetMenuDefaultItem +# @ stub NtUserSetMenuFlagRtoL +# @ stub NtUserSetMirrorRendering +# @ stub NtUserSetMonitorWorkArea +# @ stub NtUserSetMouseInputRateLimitingTimer @ stdcall -syscall NtUserSetObjectInformation(long long ptr long) -@ stub NtUserSetParent -@ stub NtUserSetPrecisionTouchPadConfiguration +# @ stub NtUserSetParent +# @ stub NtUserSetPrecisionTouchPadConfiguration @ stdcall -syscall NtUserSetProcessDpiAwarenessContext(long long) -@ stub NtUserSetProcessInteractionFlags -@ stub NtUserSetProcessMousewheelRoutingMode -@ stub NtUserSetProcessRestrictionExemption -@ stub NtUserSetProcessUIAccessZorder +# @ stub NtUserSetProcessInteractionFlags +# @ stub NtUserSetProcessMousewheelRoutingMode +# @ stub NtUserSetProcessRestrictionExemption +# @ stub NtUserSetProcessUIAccessZorder @ stdcall -syscall NtUserSetProcessWindowStation(long) @ stdcall -syscall NtUserSetProp(long wstr ptr) -@ stub NtUserSetScrollInfo -@ stub NtUserSetSensorPresence -@ stub NtUserSetSharedWindowData -@ stub NtUserSetShellWindowEx +# @ stub NtUserSetScrollInfo +# @ stub NtUserSetSensorPresence +# @ stub NtUserSetSharedWindowData +# @ stub NtUserSetShellWindowEx @ stdcall NtUserSetSysColors(long ptr ptr) -@ stub NtUserSetSystemCursor -@ stub NtUserSetSystemMenu -@ stub NtUserSetSystemTimer -@ stub NtUserSetTargetForResourceBrokering +# @ stub NtUserSetSystemCursor +# @ stub NtUserSetSystemMenu +# @ stub NtUserSetSystemTimer +# @ stub NtUserSetTargetForResourceBrokering @ stdcall -syscall NtUserSetThreadDesktop(long) -@ stub NtUserSetThreadInputBlocked -@ stub NtUserSetThreadLayoutHandles -@ stub NtUserSetThreadState -@ stub NtUserSetTimer -@ stub NtUserSetWinEventHook -@ stub NtUserSetWindowArrangement -@ stub NtUserSetWindowBand -@ stub NtUserSetWindowCompositionAttribute -@ stub NtUserSetWindowCompositionTransition -@ stub NtUserSetWindowDisplayAffinity -@ stub NtUserSetWindowFNID -@ stub NtUserSetWindowFeedbackSetting -@ stub NtUserSetWindowGroup -@ stub NtUserSetWindowLong -@ stub NtUserSetWindowLongPtr -@ stub NtUserSetWindowPlacement -@ stub NtUserSetWindowPos -@ stub NtUserSetWindowRgn -@ stub NtUserSetWindowRgnEx -@ stub NtUserSetWindowShowState -@ stub NtUserSetWindowStationUser -@ stub NtUserSetWindowWord -@ stub NtUserSetWindowsHookAW -@ stub NtUserSetWindowsHookEx -@ stub NtUserShowCaret +# @ stub NtUserSetThreadInputBlocked +# @ stub NtUserSetThreadLayoutHandles +# @ stub NtUserSetThreadState +# @ stub NtUserSetTimer +# @ stub NtUserSetWinEventHook +# @ stub NtUserSetWindowArrangement +# @ stub NtUserSetWindowBand +# @ stub NtUserSetWindowCompositionAttribute +# @ stub NtUserSetWindowCompositionTransition +# @ stub NtUserSetWindowDisplayAffinity +# @ stub NtUserSetWindowFNID +# @ stub NtUserSetWindowFeedbackSetting +# @ stub NtUserSetWindowGroup +# @ stub NtUserSetWindowLong +# @ stub NtUserSetWindowLongPtr +# @ stub NtUserSetWindowPlacement +# @ stub NtUserSetWindowPos +# @ stub NtUserSetWindowRgn +# @ stub NtUserSetWindowRgnEx +# @ stub NtUserSetWindowShowState +# @ stub NtUserSetWindowStationUser +# @ stub NtUserSetWindowWord +# @ stub NtUserSetWindowsHookAW +# @ stub NtUserSetWindowsHookEx +# @ stub NtUserShowCaret @ stdcall NtUserShowCursor(long) -@ stub NtUserShowScrollBar -@ stub NtUserShowSystemCursor -@ stub NtUserShowWindow -@ stub NtUserShowWindowAsync -@ stub NtUserShutdownBlockReasonCreate -@ stub NtUserShutdownBlockReasonQuery -@ stub NtUserShutdownReasonDestroy -@ stub NtUserSignalRedirectionStartComplete -@ stub NtUserSlicerControl -@ stub NtUserSoundSentry -@ stub NtUserStopAndEndInertia -@ stub NtUserSwitchDesktop +# @ stub NtUserShowScrollBar +# @ stub NtUserShowSystemCursor +# @ stub NtUserShowWindow +# @ stub NtUserShowWindowAsync +# @ stub NtUserShutdownBlockReasonCreate +# @ stub NtUserShutdownBlockReasonQuery +# @ stub NtUserShutdownReasonDestroy +# @ stub NtUserSignalRedirectionStartComplete +# @ stub NtUserSlicerControl +# @ stub NtUserSoundSentry +# @ stub NtUserStopAndEndInertia +# @ stub NtUserSwitchDesktop @ stdcall NtUserSystemParametersInfo(long long ptr long) @ stdcall NtUserSystemParametersInfoForDpi(long long ptr long long) -@ stub NtUserTestForInteractiveUser -@ stub NtUserThunkedMenuInfo -@ stub NtUserThunkedMenuItemInfo +# @ stub NtUserTestForInteractiveUser +# @ stub NtUserThunkedMenuInfo +# @ stub NtUserThunkedMenuItemInfo @ stdcall NtUserToUnicodeEx(long long ptr ptr long long long) -@ stub NtUserTrackMouseEvent -@ stub NtUserTrackPopupMenuEx -@ stub NtUserTransformPoint -@ stub NtUserTransformRect -@ stub NtUserTranslateAccelerator -@ stub NtUserTranslateMessage -@ stub NtUserUndelegateInput -@ stub NtUserUnhookWinEvent -@ stub NtUserUnhookWindowsHookEx -@ stub NtUserUnloadKeyboardLayout -@ stub NtUserUnlockWindowStation -@ stub NtUserUnregisterClass +# @ stub NtUserTrackMouseEvent +# @ stub NtUserTrackPopupMenuEx +# @ stub NtUserTransformPoint +# @ stub NtUserTransformRect +# @ stub NtUserTranslateAccelerator +# @ stub NtUserTranslateMessage +# @ stub NtUserUndelegateInput +# @ stub NtUserUnhookWinEvent +# @ stub NtUserUnhookWindowsHookEx +# @ stub NtUserUnloadKeyboardLayout +# @ stub NtUserUnlockWindowStation +# @ stub NtUserUnregisterClass @ stdcall NtUserUnregisterHotKey(long long) -@ stub NtUserUnregisterSessionPort -@ stub NtUserUnregisterUserApiHook -@ stub NtUserUpdateDefaultDesktopThumbnail -@ stub NtUserUpdateInputContext -@ stub NtUserUpdateInstance -@ stub NtUserUpdateLayeredWindow -@ stub NtUserUpdatePerUserSystemParameters -@ stub NtUserUpdateWindowInputSinkHints -@ stub NtUserUpdateWindowTrackingInfo -@ stub NtUserUserHandleGrantAccess -@ stub NtUserValidateRect -@ stub NtUserValidateTimerCallback +# @ stub NtUserUnregisterSessionPort +# @ stub NtUserUnregisterUserApiHook +# @ stub NtUserUpdateDefaultDesktopThumbnail +# @ stub NtUserUpdateInputContext +# @ stub NtUserUpdateInstance +# @ stub NtUserUpdateLayeredWindow +# @ stub NtUserUpdatePerUserSystemParameters +# @ stub NtUserUpdateWindowInputSinkHints +# @ stub NtUserUpdateWindowTrackingInfo +# @ stub NtUserUserHandleGrantAccess +# @ stub NtUserValidateRect +# @ stub NtUserValidateTimerCallback @ stdcall NtUserVkKeyScanEx(long long) -@ stub NtUserWOWCleanup -@ stub NtUserWaitAvailableMessageEx -@ stub NtUserWaitForInputIdle -@ stub NtUserWaitForMsgAndEvent -@ stub NtUserWaitForRedirectionStartComplete -@ stub NtUserWaitMessage -@ stub NtUserWindowFromDC -@ stub NtUserWindowFromPhysicalPoint -@ stub NtUserWindowFromPoint -@ stub NtUserYieldTask -@ stub NtValidateCompositionSurfaceHandle -@ stub NtVisualCaptureBits +# @ stub NtUserWOWCleanup +# @ stub NtUserWaitAvailableMessageEx +# @ stub NtUserWaitForInputIdle +# @ stub NtUserWaitForMsgAndEvent +# @ stub NtUserWaitForRedirectionStartComplete +# @ stub NtUserWaitMessage +# @ stub NtUserWindowFromDC +# @ stub NtUserWindowFromPhysicalPoint +# @ stub NtUserWindowFromPoint +# @ stub NtUserYieldTask +# @ stub NtValidateCompositionSurfaceHandle +# @ stub NtVisualCaptureBits # extern gDispatchTableValues ################################################################ -- 2.33.1

1 0

[PATCH 1/4] dinput: Keep action names when converting back to ansi.
by Rémi Bernon 20 Dec '21

20 Dec '21

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52198 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/dinput/ansi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/dinput/ansi.c b/dlls/dinput/ansi.c index 3c7b6ced169..a773dacbec5 100644 --- a/dlls/dinput/ansi.c +++ b/dlls/dinput/ansi.c @@ -150,7 +150,6 @@ static void diactionformat_wtoa( const DIACTIONFORMATW *in, DIACTIONFORMATA *out out->rgoAction[i].guidInstance = in->rgoAction[i].guidInstance; out->rgoAction[i].dwObjID = in->rgoAction[i].dwObjID; out->rgoAction[i].dwHow = in->rgoAction[i].dwHow; - out->rgoAction[i].lptszActionName = 0; } out->guidActionMap = in->guidActionMap; -- 2.34.0

1 3

[PATCH 1/3] concrt140: Add ?_Byte_reverse_table@details@Concurrency@@3QBEB data export.
by Paul Gofman 20 Dec '21

20 Dec '21

Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- Halo Infinite needs this export with Wine 7.0-rc. The export was also absent in the previous Wine versions so the absence of it is not a regression of course and I don't know what exactly change made it start depending on it. But since the adding of the data export is trivial I guess that maybe doing it is ok during the code freeze. dlls/concrt140/concrt140.spec | 2 +- dlls/concrt140/details.c | 21 +++++++++++++++++++++ dlls/concrt140/tests/concrt140.c | 24 ++++++++++++++++++++++++ 3 files changed, 46 insertions(+), 1 deletion(-) diff --git a/dlls/concrt140/concrt140.spec b/dlls/concrt140/concrt140.spec index 364a1ad8d84..50db9348327 100644 --- a/dlls/concrt140/concrt140.spec +++ b/dlls/concrt140/concrt140.spec @@ -433,7 +433,7 @@ @ stub -arch=arm ?_Assign@_Concurrent_queue_iterator_base_v4@details@Concurrency@@IAAXABV123@@Z @ stub -arch=i386 ?_Assign@_Concurrent_queue_iterator_base_v4@details@Concurrency@@IAEXABV123@@Z @ stub -arch=win64 ?_Assign@_Concurrent_queue_iterator_base_v4@details@Concurrency@@IEAAXAEBV123@@Z -# extern ?_Byte_reverse_table@details@Concurrency@@3QBEB +@ extern ?_Byte_reverse_table@details@Concurrency@@3QBEB byte_reverse_table @ stub -arch=arm ?_Cancel@_StructuredTaskCollection@details@Concurrency@@QAAXXZ @ stub -arch=i386 ?_Cancel@_StructuredTaskCollection@details@Concurrency@@QAEXXZ @ stub -arch=win64 ?_Cancel@_StructuredTaskCollection@details@Concurrency@@QEAAXXZ diff --git a/dlls/concrt140/details.c b/dlls/concrt140/details.c index 27cdd911ad2..3f5d2008358 100644 --- a/dlls/concrt140/details.c +++ b/dlls/concrt140/details.c @@ -1103,6 +1103,27 @@ __ASM_BLOCK_BEGIN(concurrency_details_vtables) VTABLE_ADD_FUNC(_Runtime_object__GetId)); __ASM_BLOCK_END +/* ?_Byte_reverse_table@details@Concurrency@@3QBEB */ +const BYTE byte_reverse_table[256] = +{ + 0x00, 0x80, 0x40, 0xc0, 0x20, 0xa0, 0x60, 0xe0, 0x10, 0x90, 0x50, 0xd0, 0x30, 0xb0, 0x70, 0xf0, + 0x08, 0x88, 0x48, 0xc8, 0x28, 0xa8, 0x68, 0xe8, 0x18, 0x98, 0x58, 0xd8, 0x38, 0xb8, 0x78, 0xf8, + 0x04, 0x84, 0x44, 0xc4, 0x24, 0xa4, 0x64, 0xe4, 0x14, 0x94, 0x54, 0xd4, 0x34, 0xb4, 0x74, 0xf4, + 0x0c, 0x8c, 0x4c, 0xcc, 0x2c, 0xac, 0x6c, 0xec, 0x1c, 0x9c, 0x5c, 0xdc, 0x3c, 0xbc, 0x7c, 0xfc, + 0x02, 0x82, 0x42, 0xc2, 0x22, 0xa2, 0x62, 0xe2, 0x12, 0x92, 0x52, 0xd2, 0x32, 0xb2, 0x72, 0xf2, + 0x0a, 0x8a, 0x4a, 0xca, 0x2a, 0xaa, 0x6a, 0xea, 0x1a, 0x9a, 0x5a, 0xda, 0x3a, 0xba, 0x7a, 0xfa, + 0x06, 0x86, 0x46, 0xc6, 0x26, 0xa6, 0x66, 0xe6, 0x16, 0x96, 0x56, 0xd6, 0x36, 0xb6, 0x76, 0xf6, + 0x0e, 0x8e, 0x4e, 0xce, 0x2e, 0xae, 0x6e, 0xee, 0x1e, 0x9e, 0x5e, 0xde, 0x3e, 0xbe, 0x7e, 0xfe, + 0x01, 0x81, 0x41, 0xc1, 0x21, 0xa1, 0x61, 0xe1, 0x11, 0x91, 0x51, 0xd1, 0x31, 0xb1, 0x71, 0xf1, + 0x09, 0x89, 0x49, 0xc9, 0x29, 0xa9, 0x69, 0xe9, 0x19, 0x99, 0x59, 0xd9, 0x39, 0xb9, 0x79, 0xf9, + 0x05, 0x85, 0x45, 0xc5, 0x25, 0xa5, 0x65, 0xe5, 0x15, 0x95, 0x55, 0xd5, 0x35, 0xb5, 0x75, 0xf5, + 0x0d, 0x8d, 0x4d, 0xcd, 0x2d, 0xad, 0x6d, 0xed, 0x1d, 0x9d, 0x5d, 0xdd, 0x3d, 0xbd, 0x7d, 0xfd, + 0x03, 0x83, 0x43, 0xc3, 0x23, 0xa3, 0x63, 0xe3, 0x13, 0x93, 0x53, 0xd3, 0x33, 0xb3, 0x73, 0xf3, + 0x0b, 0x8b, 0x4b, 0xcb, 0x2b, 0xab, 0x6b, 0xeb, 0x1b, 0x9b, 0x5b, 0xdb, 0x3b, 0xbb, 0x7b, 0xfb, + 0x07, 0x87, 0x47, 0xc7, 0x27, 0xa7, 0x67, 0xe7, 0x17, 0x97, 0x57, 0xd7, 0x37, 0xb7, 0x77, 0xf7, + 0x0f, 0x8f, 0x4f, 0xcf, 0x2f, 0xaf, 0x6f, 0xef, 0x1f, 0x9f, 0x5f, 0xdf, 0x3f, 0xbf, 0x7f, 0xff, +}; + void init_concurrency_details(void *base) { #ifdef __x86_64__ diff --git a/dlls/concrt140/tests/concrt140.c b/dlls/concrt140/tests/concrt140.c index 55b200c6c78..7b3300a3d59 100644 --- a/dlls/concrt140/tests/concrt140.c +++ b/dlls/concrt140/tests/concrt140.c @@ -90,6 +90,8 @@ static void (__thiscall *p__Timer_dtor)(_Timer*); static void (__thiscall *p__Timer__Start)(_Timer*); static void (__thiscall *p__Timer__Stop)(_Timer*); +static const BYTE *p_byte_reverse_table; + #define SETNOFAIL(x,y) x = (void*)GetProcAddress(module,y) #define SET(x,y) do { SETNOFAIL(x,y); ok(x != NULL, "Export '%s' not found\n", y); } while(0) @@ -142,6 +144,7 @@ static BOOL init(void) } init_thiscall_thunk(); + SET(p_byte_reverse_table, "?_Byte_reverse_table@details@Concurrency@@3QBEB"); return TRUE; } @@ -217,9 +220,30 @@ static void test_Timer(void) CloseHandle(callback_called); } +static BYTE byte_reverse(BYTE b) +{ + b = ((b & 0xf0) >> 4) | ((b & 0x0f) << 4); + b = ((b & 0xcc) >> 2) | ((b & 0x33) << 2); + b = ((b & 0xaa) >> 1) | ((b & 0x55) << 1); + return b; +} + +static void test_data_exports(void) +{ + unsigned int i; + + ok(IsBadWritePtr((BYTE *)p_byte_reverse_table, 256), "byte_reverse_table is writeable.\n"); + for (i = 0; i < 256; ++i) + { + ok(p_byte_reverse_table[i] == byte_reverse(i), "Got unexpected byte %#x, expected %#x.\n", + p_byte_reverse_table[i], byte_reverse(i)); + } +} + START_TEST(concrt140) { if (!init()) return; test_CurrentContext(); test_Timer(); + test_data_exports(); } -- 2.33.1

2 5

[PATCH] ntdll: Always try searching apiset DLLs in the default directories.
by Paul Gofman 20 Dec '21

20 Dec '21

This is a temporary workaround until we have a correct apisets implementation. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- Previously builtin DLLs could always be loaded regardless of the dll search path options provided by the applications. That has changed and now, e. g., with LOAD_LIBRARY_SEARCH_APPLICATION_DIR flag the DLLs residing in the system paths won't be loaded. Which is correct for normal system DLLs but not for apisets pseudo dlls. The full solution would be to implement apisets properly but we should probably workaround that for now to fix 7.0 regressions. dlls/kernel32/tests/module.c | 23 +++++++++++++++++++++++ dlls/ntdll/loader.c | 12 ++++++++++++ 2 files changed, 35 insertions(+) diff --git a/dlls/kernel32/tests/module.c b/dlls/kernel32/tests/module.c index 2ee23595f55..8ec3a5433ee 100644 --- a/dlls/kernel32/tests/module.c +++ b/dlls/kernel32/tests/module.c @@ -466,6 +466,7 @@ static void testLoadLibraryEx(void) static void test_LoadLibraryEx_search_flags(void) { + static const char apiset_dll[] = "api-ms-win-shcore-obsolete-l1-1-0.dll"; static const struct { int add_dirs[4]; @@ -684,6 +685,28 @@ static void test_LoadLibraryEx_search_flags(void) for (k = 0; tests[j].add_dirs[k]; k++) pRemoveDllDirectory( cookies[k] ); } + mod = GetModuleHandleA( apiset_dll ); + if (mod) + { + win_skip( "%s already referenced, skipping test.\n", apiset_dll ); + } + else + { + mod = LoadLibraryA( apiset_dll ); + if (mod) + { + FreeLibrary(mod); + mod = LoadLibraryExA( apiset_dll, NULL, LOAD_LIBRARY_SEARCH_APPLICATION_DIR ); + ok( !!mod, "Got NULL module, error %u.\n", GetLastError() ); + ok( !!GetModuleHandleA( apiset_dll ), "Got NULL handle.\n" ); + ret = FreeLibrary( mod ); + ok( ret, "FreeLibrary failed, error %u.\n", GetLastError() ); + } + else + { + win_skip( "%s not found, skipping test.\n", apiset_dll ); + } + } done: for (i = 1; i <= 6; i++) { diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index d11f3f0f79d..8a4a7258eac 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -2905,6 +2905,16 @@ done: return status; } +/*********************************************************************** + * is_apiset_dll_name + * + */ +static BOOL is_apiset_dll_name( const WCHAR *name ) +{ + static const WCHAR name_prefix[] = L"api-ms-win-"; + + return !wcsnicmp( name, name_prefix, ARRAY_SIZE(name_prefix) - 1 ); +} /*********************************************************************** * find_dll_file @@ -2948,6 +2958,8 @@ static NTSTATUS find_dll_file( const WCHAR *load_path, const WCHAR *libname, UNI if (RtlDetermineDosPathNameType_U( libname ) == RELATIVE_PATH) { status = search_dll_file( load_path, libname, nt_name, pwm, mapping, image_info, id ); + if (status == STATUS_DLL_NOT_FOUND && load_path && is_apiset_dll_name( libname )) + status = search_dll_file( NULL, libname, nt_name, pwm, mapping, image_info, id ); if (status == STATUS_DLL_NOT_FOUND) status = find_builtin_without_file( libname, nt_name, pwm, mapping, image_info, id ); } -- 2.33.1

1 0

[PATCH] winetest: Send the tests output to stdout when given "-o -".
by Francois Gouget 20 Dec '21

20 Dec '21

This makes it easier to use WineTest with tools that capture stdout, such as the TestBot. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- In particular this allows checking whether a test fails when run through WineTest as opposed to running standalone by sending winetest.exe to the TestBot and specifying "-c -o - -t foo test:unit" as the arguments. --- programs/winetest/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 7ced565447b..0c431a903d7 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -1051,7 +1051,8 @@ run_tests (char *logname, char *outdir) sa.lpSecurityDescriptor = NULL; sa.bInheritHandle = TRUE; - logfile = CreateFileA( logname, GENERIC_READ|GENERIC_WRITE, + logfile = strcmp(logname, "-") == 0 ? GetStdHandle( STD_OUTPUT_HANDLE ) : + CreateFileA( logname, GENERIC_READ|GENERIC_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, &sa, CREATE_ALWAYS, 0, NULL ); @@ -1175,7 +1176,7 @@ run_tests (char *logname, char *outdir) report (R_DELTA, 0, "Running: Done"); report (R_STATUS, "Cleaning up - %u failures", failures); - CloseHandle( logfile ); + if (strcmp(logname, "-") != 0) CloseHandle( logfile ); logfile = 0; if (newdir) remove_dir (tempdir); -- 2.30.2

1 0

[PATCH] programs/cmd: don't crash on 'if exist' without parameter
by Eric Pouech 20 Dec '21

20 Dec '21

fixes BZ #51598 https://bugs.winehq.org/show_bug.cgi?id=51598 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- programs/cmd/builtins.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index d0a954d90fa..d14e69e072a 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -2811,8 +2811,9 @@ int evaluate_if_condition(WCHAR *p, WCHAR **command, int *test, int *negate) WCHAR *param = WCMD_parameter(p, 1+(*negate), NULL, FALSE, FALSE); int len = lstrlenW(param); + if (!len) goto syntax_err; /* FindFirstFile does not like a directory path ending in '\', append a '.' */ - if (len && param[len-1] == '\\') lstrcatW(param, L"."); + if (param[len-1] == '\\') lstrcatW(param, L"."); hff = FindFirstFileW(param, &fd); *test = (hff != INVALID_HANDLE_VALUE );

1 0

[RFC] msxml3: Fix crashes due to access to invalid context pointer.
by Bernhard Übelacker 20 Dec '21

20 Dec '21

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52073 In function xslt_doc_default_loader a pointer of the stack based variable "xmlParserInputPtr input" is given to bind_url. Later in function import_loader_onDataAvailable this pointer appears as parameter "void *ctxt" which correctly gets casted to "xmlParserInputPtr *input", but in my opinion incorrectly given to xmlNewIOInputStream as parameter "xmlParserCtxtPtr ctxt". In the next call to xmlNewInputStream this xmlParserCtxtPtr is used to increment the input_id member. By accident this input_id member contains the pointer which causes in xmlXPathNodeCollectAndTest the segfault. --- dlls/msxml3/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c index 721ad54e379..272e438e773 100644 --- a/dlls/msxml3/node.c +++ b/dlls/msxml3/node.c @@ -1329,7 +1329,7 @@ static HRESULT import_loader_onDataAvailable(void *ctxt, char *ptr, DWORD len) inputbuffer = xmlParserInputBufferCreateIO(import_loader_io_read, import_loader_io_close, buffer, XML_CHAR_ENCODING_NONE); - *input = xmlNewIOInputStream(ctxt, inputbuffer, XML_CHAR_ENCODING_NONE); + *input = xmlNewIOInputStream(NULL, inputbuffer, XML_CHAR_ENCODING_NONE); if (!*input) xmlFreeParserInputBuffer(inputbuffer); -- 2.34.1

2 2

[PATCH] win32u: Fix memory leak on error path in PATH_WidenPath (cppcheck)
by Alex Henrie 20 Dec '21

20 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/win32u/path.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/win32u/path.c b/dlls/win32u/path.c index 05123a2f2e4..ada76bb4a7a 100644 --- a/dlls/win32u/path.c +++ b/dlls/win32u/path.c @@ -1616,7 +1616,7 @@ BOOL WINAPI NtGdiFlattenPath( HDC hdc ) static struct gdi_path *PATH_WidenPath(DC *dc) { INT i, j, numStrokes, penWidth, penWidthIn, penWidthOut, size, penStyle; - struct gdi_path *flat_path, *pNewPath, **pStrokes = NULL, *pUpPath, *pDownPath; + struct gdi_path *flat_path, *pNewPath, **pStrokes = NULL, **pNewStrokes, *pUpPath, *pDownPath; EXTLOGPEN *elp; BYTE *type; DWORD obj_type, joint, endcap, penType; @@ -1681,12 +1681,14 @@ static struct gdi_path *PATH_WidenPath(DC *dc) case PT_MOVETO: numStrokes++; j = 0; - pStrokes = realloc( pStrokes, numStrokes * sizeof(*pStrokes) ); - if(!pStrokes) + pNewStrokes = realloc( pStrokes, numStrokes * sizeof(*pStrokes) ); + if(!pNewStrokes) { free_gdi_path(flat_path); + free(pStrokes); return NULL; } + pStrokes = pNewStrokes; pStrokes[numStrokes - 1] = alloc_gdi_path(0); /* fall through */ case PT_LINETO: -- 2.34.1

2 1

[PATCH v2] win32u: Fix memory leak on error path in PATH_WidenPath (cppcheck)
by Huw Davies 20 Dec '21

20 Dec '21

From: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> --- dlls/win32u/path.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/win32u/path.c b/dlls/win32u/path.c index 05123a2f2e4..a87a7ab06c2 100644 --- a/dlls/win32u/path.c +++ b/dlls/win32u/path.c @@ -1616,7 +1616,7 @@ BOOL WINAPI NtGdiFlattenPath( HDC hdc ) static struct gdi_path *PATH_WidenPath(DC *dc) { INT i, j, numStrokes, penWidth, penWidthIn, penWidthOut, size, penStyle; - struct gdi_path *flat_path, *pNewPath, **pStrokes = NULL, *pUpPath, *pDownPath; + struct gdi_path *flat_path, *pNewPath, **pStrokes = NULL, **new_strokes, *pUpPath, *pDownPath; EXTLOGPEN *elp; BYTE *type; DWORD obj_type, joint, endcap, penType; @@ -1681,12 +1681,14 @@ static struct gdi_path *PATH_WidenPath(DC *dc) case PT_MOVETO: numStrokes++; j = 0; - pStrokes = realloc( pStrokes, numStrokes * sizeof(*pStrokes) ); - if(!pStrokes) + new_strokes = realloc( pStrokes, numStrokes * sizeof(*pStrokes) ); + if (!new_strokes) { free_gdi_path(flat_path); + free(pStrokes); return NULL; } + pStrokes = new_strokes; pStrokes[numStrokes - 1] = alloc_gdi_path(0); /* fall through */ case PT_LINETO: -- 2.23.0

1 0

[PATCH] nsiproxy: Fix memory leaks on error paths in get_ipv6_addr_scope_table (cppcheck)
by Alex Henrie 20 Dec '21

20 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/nsiproxy.sys/tcp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/nsiproxy.sys/tcp.c b/dlls/nsiproxy.sys/tcp.c index 6dd0aaa9b45..0cd81ae86e5 100644 --- a/dlls/nsiproxy.sys/tcp.c +++ b/dlls/nsiproxy.sys/tcp.c @@ -235,7 +235,7 @@ static inline MIB_TCP_STATE tcp_state_to_mib_state( int state ) struct ipv6_addr_scope *get_ipv6_addr_scope_table( unsigned int *size ) { - struct ipv6_addr_scope *table = NULL; + struct ipv6_addr_scope *table = NULL, *new_table; unsigned int table_size = 0, num = 0; #ifdef __linux__ @@ -260,11 +260,12 @@ struct ipv6_addr_scope *get_ipv6_addr_scope_table( unsigned int *size ) { if (!table_size) table_size = 4; else table_size *= 2; - if (!(table = realloc( table, table_size * sizeof(table[0]) ))) + if (!(new_table = realloc( table, table_size * sizeof(table[0]) ))) { fclose( fp ); goto failed; } + table = new_table; } entry = table + num - 1; @@ -292,11 +293,12 @@ struct ipv6_addr_scope *get_ipv6_addr_scope_table( unsigned int *size ) { if (!table_size) table_size = 4; else table_size *= 2; - if (!(table = realloc( table, table_size * sizeof(table[0]) ))) + if (!(new_table = realloc( table, table_size * sizeof(table[0]) ))) { freeifaddrs( addrs ); goto failed; } + table = new_table; } sin6 = (struct sockaddr_in6 *)cur->ifa_addr; -- 2.34.1

2 1

[PATCH] win32u: Use null driver to handle virtual display devices.
by Jacek Caban 20 Dec '21

20 Dec '21

All drivers support UpdateDisplayDevices now, so we can avoid a server call by being explicit in the null driver. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52180 Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/win32u/driver.c | 1 + dlls/win32u/sysparams.c | 48 ++++++++++++----------------------------- 2 files changed, 15 insertions(+), 34 deletions(-)

2 1

[PATCH] ole32: Don't change attr->ObjectName in create_key (cppcheck)
by Alex Henrie 20 Dec '21

20 Dec '21

ObjectName can't point to a local variable because it is used later outside of this function. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ole32/compobj.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index 815fdcb11d0..66cc81470b1 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -216,18 +216,16 @@ static NTSTATUS create_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES HANDLE subkey, root = attr->RootDirectory; WCHAR *buffer = attr->ObjectName->Buffer; DWORD attrs, pos = 0, i = 0, len = attr->ObjectName->Length / sizeof(WCHAR); - UNICODE_STRING str; while (i < len && buffer[i] != '\\') i++; if (i == len) return status; attrs = attr->Attributes; - attr->ObjectName = &str; while (i < len) { - str.Buffer = buffer + pos; - str.Length = (i - pos) * sizeof(WCHAR); + attr->ObjectName->Buffer = buffer + pos; + attr->ObjectName->Length = (i - pos) * sizeof(WCHAR); status = NtCreateKey( &subkey, access, attr, 0, NULL, 0, NULL ); if (attr->RootDirectory != root) NtClose( attr->RootDirectory ); if (status) return status; @@ -236,8 +234,8 @@ static NTSTATUS create_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES pos = i; while (i < len && buffer[i] != '\\') i++; } - str.Buffer = buffer + pos; - str.Length = (i - pos) * sizeof(WCHAR); + attr->ObjectName->Buffer = buffer + pos; + attr->ObjectName->Length = (i - pos) * sizeof(WCHAR); attr->Attributes = attrs; status = NtCreateKey( (PHANDLE)retkey, access, attr, 0, NULL, 0, NULL ); if (attr->RootDirectory != root) NtClose( attr->RootDirectory ); -- 2.34.1

1 0

[PATCH] ws2_32: Fix memory leak on error path in get_local_ips (cppcheck)
by Alex Henrie 20 Dec '21

20 Dec '21

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ws2_32/protocol.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/ws2_32/protocol.c b/dlls/ws2_32/protocol.c index 867e9513ca2..56b7379cccc 100644 --- a/dlls/ws2_32/protocol.c +++ b/dlls/ws2_32/protocol.c @@ -806,7 +806,7 @@ static struct hostent *get_local_ips( char *hostname ) IP_ADAPTER_INFO *adapters = NULL, *k; struct hostent *hostlist = NULL; MIB_IPFORWARDTABLE *routes = NULL; - struct route *route_addrs = NULL; + struct route *route_addrs = NULL, *new_route_addrs; DWORD adap_size, route_size, n; /* Obtain the size of the adapter list and routing table, also allocate memory */ @@ -852,9 +852,10 @@ static struct hostent *get_local_ips( char *hostname ) } if (exists) continue; - route_addrs = realloc( route_addrs, (numroutes + 1) * sizeof(struct route) ); - if (!route_addrs) + new_route_addrs = realloc( route_addrs, (numroutes + 1) * sizeof(struct route) ); + if (!new_route_addrs) goto cleanup; + route_addrs = new_route_addrs; route_addrs[numroutes].interface = ifindex; route_addrs[numroutes].metric = ifmetric; route_addrs[numroutes].default_route = ifdefault; -- 2.34.1

1 0

[PATCH] mountmgr: Change scope of variable pvd in VOLUME_GetSuperblockLabel (cppcheck)
by Alex Henrie 20 Dec '21

20 Dec '21

The data in pvd was being accessed through the label_ptr variable after pvd went out of scope. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/mountmgr.sys/device.c | 43 ++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/dlls/mountmgr.sys/device.c b/dlls/mountmgr.sys/device.c index d4f77012bbe..b8a0040195d 100644 --- a/dlls/mountmgr.sys/device.c +++ b/dlls/mountmgr.sys/device.c @@ -398,6 +398,7 @@ static void VOLUME_GetSuperblockLabel( struct volume *volume, HANDLE handle, con { const BYTE *label_ptr = NULL; DWORD label_len; + BYTE pvd[BLOCK_SIZE]; switch (volume->fs_type) { @@ -435,32 +436,28 @@ static void VOLUME_GetSuperblockLabel( struct volume *volume, HANDLE handle, con break; } case FS_UDF: + if(!UDF_Find_PVD(handle, pvd)) { - BYTE pvd[BLOCK_SIZE]; - - if(!UDF_Find_PVD(handle, pvd)) - { - label_len = 0; - break; - } + label_len = 0; + break; + } - /* [E] 3/10.1.4 and [U] 2.1.1 */ - if(pvd[24]==8) - { - label_ptr = pvd + 24 + 1; - label_len = pvd[24+32-1]; - break; - } - else - { - unsigned int i; + /* [E] 3/10.1.4 and [U] 2.1.1 */ + if(pvd[24]==8) + { + label_ptr = pvd + 24 + 1; + label_len = pvd[24+32-1]; + break; + } + else + { + unsigned int i; - label_len = 1 + pvd[24+32-1]; - for (i = 0; i < label_len; i += 2) - volume->label[i/2] = (pvd[24+1+i] << 8) | pvd[24+1+i+1]; - volume->label[label_len] = 0; - return; - } + label_len = 1 + pvd[24+32-1]; + for (i = 0; i < label_len; i += 2) + volume->label[i/2] = (pvd[24+1+i] << 8) | pvd[24+1+i+1]; + volume->label[label_len] = 0; + return; } } if (label_len) RtlMultiByteToUnicodeN( volume->label, sizeof(volume->label) - sizeof(WCHAR), -- 2.34.1

1 0

[PATCH] winedbg: Fix disassemble with end addresses exceeding 32-bit.
by Bernhard Übelacker 18 Dec '21

18 Dec '21

Signed-off-by: Bernhard Übelacker <bernhardu(a)mailbox.org> --- Otherwise winedbg continues disassembling and does not stop at the desired address. --- programs/winedbg/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/winedbg/memory.c b/programs/winedbg/memory.c index 5e01bef5607..0c8e1ee0d19 100644 --- a/programs/winedbg/memory.c +++ b/programs/winedbg/memory.c @@ -769,7 +769,7 @@ void memory_disassemble(const struct dbg_lvalue* xstart, const struct dbg_lvalue* xend, int instruction_count) { static ADDRESS64 last = {0,0,0}; - int stop = 0; + dbg_lgint_t stop = 0; int i; if (!xstart && !xend) -- 2.34.1

1 0

[PATCH] winealsa.drv: use separate port for each output device.
by Jacek Konieczny 18 Dec '21

18 Dec '21

This fixes use of multiple MIDI outputs while keeping the flexibility of proper ALSA sequencer port subscriptions. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52220 Signed-off-by: Jacek Konieczny <jajcus(a)jajcus.net> --- dlls/winealsa.drv/midi.c | 48 ++++++++++++++++++++++++++-------------- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c index f2fe6307bb2..e34b5b47b64 100644 --- a/dlls/winealsa.drv/midi.c +++ b/dlls/winealsa.drv/midi.c @@ -85,6 +85,7 @@ typedef struct { void* lpExtra; /* according to port type (MIDI, FM...), extra data when needed */ MIDIOUTCAPSW caps; snd_seq_addr_t addr; + int port_out; } WINE_MIDIOUT; static WINE_MIDIIN MidiInDev [MAX_MIDIINDRV ]; @@ -108,7 +109,6 @@ static int numOpenMidiSeq = 0; static int numStartedMidiIn = 0; static int port_in; -static int port_out; static CRITICAL_SECTION crit_sect; /* protects all MidiIn buffer queues */ static CRITICAL_SECTION_DEBUG critsect_debug = @@ -247,14 +247,6 @@ static int midiOpenSeq(BOOL create_client) /* Setting the client name is the only init to do */ snd_seq_set_client_name(midiSeq, "WINE midi driver"); - port_out = snd_seq_create_simple_port(midiSeq, "WINE ALSA Output", - SND_SEQ_PORT_CAP_READ|SND_SEQ_PORT_CAP_SUBS_READ|SND_SEQ_PORT_CAP_SUBS_WRITE, - SND_SEQ_PORT_TYPE_MIDI_GENERIC|SND_SEQ_PORT_TYPE_APPLICATION); - if (port_out < 0) - TRACE("Unable to create output port\n"); - else - TRACE("Outport port %d created successfully\n", port_out); - port_in = snd_seq_create_simple_port(midiSeq, "WINE ALSA Input", SND_SEQ_PORT_CAP_WRITE|SND_SEQ_PORT_CAP_SUBS_READ|SND_SEQ_PORT_CAP_SUBS_WRITE, SND_SEQ_PORT_TYPE_MIDI_GENERIC|SND_SEQ_PORT_TYPE_APPLICATION); @@ -276,7 +268,6 @@ static int midiCloseSeq(void) { EnterCriticalSection(&midiSeqLock); if (--numOpenMidiSeq == 0) { - snd_seq_delete_simple_port(midiSeq, port_out); snd_seq_delete_simple_port(midiSeq, port_in); snd_seq_close(midiSeq); midiSeq = NULL; @@ -738,6 +729,8 @@ static DWORD modGetDevCaps(WORD wDevID, LPMIDIOUTCAPSW lpCaps, DWORD dwSize) static DWORD modOpen(WORD wDevID, LPMIDIOPENDESC lpDesc, DWORD dwFlags) { int ret; + int port_out; + char port_out_name[32]; TRACE("(%04X, %p, %08X);\n", wDevID, lpDesc, dwFlags); if (lpDesc == NULL) { @@ -784,12 +777,30 @@ static DWORD modOpen(WORD wDevID, LPMIDIOPENDESC lpDesc, DWORD dwFlags) MidiOutDev[wDevID].bufsize = 0x3FFF; MidiOutDev[wDevID].midiDesc = *lpDesc; - /* Connect our app port to the device port */ EnterCriticalSection(&midiSeqLock); - ret = snd_seq_connect_to(midiSeq, port_out, MidiOutDev[wDevID].addr.client, - MidiOutDev[wDevID].addr.port); + /* Create a port dedicated to a specific device */ + /* Keep the old name without a number for the first port */ + if (wDevID) + sprintf(port_out_name, "WINE ALSA Output #%d", wDevID); + + port_out = snd_seq_create_simple_port(midiSeq, wDevID?port_out_name:"WINE ALSA Output", + SND_SEQ_PORT_CAP_READ|SND_SEQ_PORT_CAP_SUBS_READ|SND_SEQ_PORT_CAP_SUBS_WRITE, + SND_SEQ_PORT_TYPE_MIDI_GENERIC|SND_SEQ_PORT_TYPE_APPLICATION); + + if (port_out < 0) { + TRACE("Unable to create output port\n"); + MidiOutDev[wDevID].port_out = -1; + } else { + TRACE("Outport port %d created successfully\n", port_out); + MidiOutDev[wDevID].port_out = port_out; + + /* Connect our app port to the device port */ + ret = snd_seq_connect_to(midiSeq, port_out, MidiOutDev[wDevID].addr.client, + MidiOutDev[wDevID].addr.port); + } LeaveCriticalSection(&midiSeqLock); - if (ret < 0) + + if (port_out < 0 || ret < 0) return MMSYSERR_NOTENABLED; TRACE("Output port :%d connected %d:%d\n",port_out,MidiOutDev[wDevID].addr.client,MidiOutDev[wDevID].addr.port); @@ -825,7 +836,9 @@ static DWORD modClose(WORD wDevID) case MOD_MIDIPORT: case MOD_SYNTH: EnterCriticalSection(&midiSeqLock); - snd_seq_disconnect_to(midiSeq, port_out, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port); + TRACE("Deleting port :%d, connected to %d:%d\n", MidiOutDev[wDevID].port_out, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port); + snd_seq_delete_simple_port(midiSeq, MidiOutDev[wDevID].port_out); + MidiOutDev[wDevID].port_out = -1; LeaveCriticalSection(&midiSeqLock); midiCloseSeq(); break; @@ -870,7 +883,7 @@ static DWORD modData(WORD wDevID, DWORD dwParam) snd_seq_event_t event; snd_seq_ev_clear(&event); snd_seq_ev_set_direct(&event); - snd_seq_ev_set_source(&event, port_out); + snd_seq_ev_set_source(&event, MidiOutDev[wDevID].port_out); snd_seq_ev_set_subs(&event); switch (evt & 0xF0) { @@ -1039,7 +1052,7 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) } snd_seq_ev_clear(&event); snd_seq_ev_set_direct(&event); - snd_seq_ev_set_source(&event, port_out); + snd_seq_ev_set_source(&event, MidiOutDev[wDevID].port_out); snd_seq_ev_set_subs(&event); snd_seq_ev_set_sysex(&event, lpMidiHdr->dwBufferLength + len_add, lpNewData ? lpNewData : lpData); EnterCriticalSection(&midiSeqLock); @@ -1201,6 +1214,7 @@ static void ALSA_AddMidiPort(snd_seq_client_info_t* cinfo, snd_seq_port_info_t* MidiOutDev[MODM_NumDevs].caps.wNotes = 16; } MidiOutDev[MODM_NumDevs].bEnabled = TRUE; + MidiOutDev[MODM_NumDevs].port_out = -1; TRACE("MidiOut[%d]\tname='%s' techn=%d voices=%d notes=%d chnMsk=%04x support=%d\n" "\tALSA info: midi dev-type=%x, capa=0\n", -- 2.25.1

1 0

[PATCH] dinput8/tests: Don't test value again if it wasn't touched.
by Rémi Bernon 18 Dec '21

18 Dec '21

From: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- Supersedes: 222335 Thanks, I fixed up the commit title. dlls/dinput8/tests/hid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/dinput8/tests/hid.c b/dlls/dinput8/tests/hid.c index 35d72409af5..82657c2e235 100644 --- a/dlls/dinput8/tests/hid.c +++ b/dlls/dinput8/tests/hid.c @@ -1730,7 +1730,6 @@ static void test_hidp( HANDLE file, HANDLE async_file, int report_id, BOOL polle status = HidP_SetScaledUsageValue( HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_RY, 0, preparsed_data, report, caps.InputReportByteLength ); ok( status == HIDP_STATUS_BAD_LOG_PHY_VALUES, "HidP_GetScaledUsageValue returned %#x\n", status ); - ok( value == 0, "got value %x, expected %#x\n", value, 0 ); value = HidP_MaxUsageListLength( HidP_Feature + 1, 0, preparsed_data ); ok( value == 0, "HidP_MaxUsageListLength(HidP_Feature + 1, 0) returned %d, expected %d\n", value, 0 ); -- 2.34.0

1 0

[PATCH] kernelbase: don't hardcode magic constants
by Eric Pouech 18 Dec '21

18 Dec '21

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/kernelbase/process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/kernelbase/process.c b/dlls/kernelbase/process.c index 0e4a3eb9b6b..12187b92e5c 100644 --- a/dlls/kernelbase/process.c +++ b/dlls/kernelbase/process.c @@ -33,6 +33,7 @@ #include "kernelbase.h" #include "wine/debug.h" +#include "wine/condrv.h" WINE_DEFAULT_DEBUG_CHANNEL(process); @@ -189,7 +190,7 @@ static RTL_USER_PROCESS_PARAMETERS *create_process_params( const WCHAR *filename RtlFreeUnicodeString( &newdirW ); if (flags & CREATE_NEW_PROCESS_GROUP) params->ConsoleFlags = 1; - if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = (HANDLE)1; /* KERNEL32_CONSOLE_ALLOC */ + if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = CONSOLE_HANDLE_ALLOC; else if (!(flags & DETACHED_PROCESS)) params->ConsoleHandle = NtCurrentTeb()->Peb->ProcessParameters->ConsoleHandle; if (startup->dwFlags & STARTF_USESTDHANDLES)

1 0

Wine staging 7.0-rc2 release
by Alistair Leslie-Hughes 18 Dec '21

18 Dec '21

Binary packages for various distributions will be available from: https://www.winehq.org/download Notes: dwarf4 debug information is now the default for wine-staging. Summary since last release * Rebased to current wine 7.0-rc2 (552 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * None Added: * None Updated: * None Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

[PATCH] dinput8/tests: Don'te test value again if it wasn't touched
by Michael Stefaniuc 17 Dec '21

17 Dec '21

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/dinput8/tests/hid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/dinput8/tests/hid.c b/dlls/dinput8/tests/hid.c index 35d72409af5..82657c2e235 100644 --- a/dlls/dinput8/tests/hid.c +++ b/dlls/dinput8/tests/hid.c @@ -1730,7 +1730,6 @@ static void test_hidp( HANDLE file, HANDLE async_file, int report_id, BOOL polle status = HidP_SetScaledUsageValue( HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_RY, 0, preparsed_data, report, caps.InputReportByteLength ); ok( status == HIDP_STATUS_BAD_LOG_PHY_VALUES, "HidP_GetScaledUsageValue returned %#x\n", status ); - ok( value == 0, "got value %x, expected %#x\n", value, 0 ); value = HidP_MaxUsageListLength( HidP_Feature + 1, 0, preparsed_data ); ok( value == 0, "HidP_MaxUsageListLength(HidP_Feature + 1, 0) returned %d, expected %d\n", value, 0 ); -- 2.31.1

2 1

[PATCH vkd3d v3 06/12] vkd3d-shader/hlsl: Fix wrong conditional in compare_param_hlsl_types().
by Francisco Casas 17 Dec '21

17 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c index 82820daf..c664d5b1 100644 --- a/libs/vkd3d-shader/hlsl.c +++ b/libs/vkd3d-shader/hlsl.c @@ -791,8 +791,7 @@ static int compare_param_hlsl_types(const struct hlsl_type *t1, const struct hls } if (t1->base_type != t2->base_type) return t1->base_type - t2->base_type; - if ((t1->base_type == HLSL_TYPE_SAMPLER || t1->base_type == HLSL_TYPE_TEXTURE) - && t1->sampler_dim != t2->sampler_dim) + if (t1->base_type == HLSL_TYPE_SAMPLER || t1->base_type == HLSL_TYPE_TEXTURE) { if (t1->sampler_dim != t2->sampler_dim) return t1->sampler_dim - t2->sampler_dim; -- 2.25.1

2 1

[PATCH vkd3d v3 04/12] vkd3d-shader/hlsl: Add tests for Sample method with offset.
by Francisco Casas 17 Dec '21

17 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- Makefile.am | 2 ++ tests/sampler-offset.shader_test | 51 ++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) create mode 100644 tests/sampler-offset.shader_test diff --git a/Makefile.am b/Makefile.am index 20fee06d..16848f5a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -94,6 +94,7 @@ vkd3d_shader_tests = \ tests/preproc-misc.shader_test \ tests/round.shader_test \ tests/sampler.shader_test \ + tests/sampler-offset.shader_test \ tests/saturate.shader_test \ tests/swizzle-0.shader_test \ tests/swizzle-1.shader_test \ @@ -306,6 +307,7 @@ XFAIL_TESTS = \ tests/hlsl-vector-indexing-uniform.shader_test \ tests/max.shader_test \ tests/sampler.shader_test \ + tests/sampler-offset.shader_test \ tests/texture-load.shader_test \ tests/texture-load-typed.shader_test \ tests/trigonometry.shader_test diff --git a/tests/sampler-offset.shader_test b/tests/sampler-offset.shader_test new file mode 100644 index 00000000..83900c55 --- /dev/null +++ b/tests/sampler-offset.shader_test @@ -0,0 +1,51 @@ +[sampler 0] +filter point point point +address clamp clamp clamp + +[texture 0] +size (3, 3) +0.0 0.0 0.0 0.4 0.1 0.0 0.5 0.0 0.2 0.0 0.0 0.4 +0.0 0.1 0.5 0.0 0.1 0.1 0.0 0.4 0.2 0.1 0.5 0.0 +0.0 0.2 0.0 0.4 0.1 0.2 0.5 0.0 0.2 0.2 0.0 0.4 + + +[pixel shader] +sampler s; +Texture2D t; + +float4 main() : sv_target +{ + return t.Sample(s, float2(0.5, 0.5), int2(0, 1)); +} + +[test] +draw quad +probe all rgba (0.1, 0.2, 0.5, 0.0) + + +[pixel shader] +sampler s; +Texture2D t; + +float4 main() : sv_target +{ + return t.Sample(s, float2(0.1, 0.5), int2(2, 1)); +} + +[test] +draw quad +probe all rgba (0.2, 0.2, 0.0, 0.4) + + +[pixel shader] +sampler s; +Texture2D t; + +float4 main() : sv_target +{ + return t.Sample(s, float2(0.9, 0.5), int2(-2, 1)); +} + +[test] +draw quad +probe all rgba (0.0, 0.2, 0.0, 0.4) -- 2.25.1

2 1

[PATCH 1/2] user32: Test Get/SetWindowPlacement with invalid length.
by Esme Povirk 17 Dec '21

17 Dec '21

Signed-off-by: Esme Povirk <esme(a)codeweavers.com> --- dlls/user32/tests/win.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 0156987f529..7ebba960951 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -11965,6 +11965,17 @@ static void test_window_placement(void) GetWindowRect(hwnd, &rect); ok(EqualRect(&rect, &orig), "got window rect %s\n", wine_dbgstr_rect(&rect)); + ret = SetWindowPlacement(hwnd, &wp); + ok(ret, "failed to set window placement, error %u\n", GetLastError()); + + wp.length = 0; + SetLastError(0xdeadbeef); + ret = SetWindowPlacement(hwnd, &wp); +todo_wine { + ok(!ret, "SetWindowPlacement should have failed\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "wrong error %u\n", GetLastError()); +} + DestroyWindow(hwnd); } @@ -12124,7 +12135,7 @@ static void test_arrange_iconic_windows(void) static void other_process_proc(HWND hwnd) { HANDLE window_ready_event, test_done_event; - WINDOWPLACEMENT wp; + WINDOWPLACEMENT wp = {0}; DWORD ret; window_ready_event = OpenEventA(EVENT_ALL_ACCESS, FALSE, "test_opw_window"); -- 2.30.2

2 3

[PATCH vkd3d 1/6] vkd3d-shader/hlsl: Write SM4 equality instructions.
by Giovanni Mascellani 17 Dec '21

17 Dec '21

Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> --- libs/vkd3d-shader/hlsl_sm4.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/libs/vkd3d-shader/hlsl_sm4.c b/libs/vkd3d-shader/hlsl_sm4.c index 2458018f..37a51125 100644 --- a/libs/vkd3d-shader/hlsl_sm4.c +++ b/libs/vkd3d-shader/hlsl_sm4.c @@ -1489,6 +1489,39 @@ static void write_sm4_expr(struct hlsl_ctx *ctx, break; } + case HLSL_TYPE_BOOL: + { + switch (expr->op) + { + case HLSL_OP2_EQUAL: + { + const struct hlsl_type *src_type = arg1->data_type; + + switch (src_type->base_type) + { + case HLSL_TYPE_FLOAT: + write_sm4_binary_op(buffer, VKD3D_SM4_OP_EQ, &expr->node, arg1, arg2); + break; + + case HLSL_TYPE_BOOL: + case HLSL_TYPE_INT: + case HLSL_TYPE_UINT: + write_sm4_binary_op(buffer, VKD3D_SM4_OP_IEQ, &expr->node, arg1, arg2); + break; + + default: + break; + } + break; + } + + default: + hlsl_fixme(ctx, &expr->node.loc, "SM4 bool \"%s\" expression.\n", debug_hlsl_expr_op(expr->op)); + break; + } + break; + } + default: { struct vkd3d_string_buffer *string; -- 2.34.1

2 9

[PATCH vkd3d v3 12/12] vkd3d-shader/hlsl: Check texture dimension type on method calls.
by Francisco Casas 17 Dec '21

17 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl.y | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y index 389ff057..04854577 100644 --- a/libs/vkd3d-shader/hlsl.y +++ b/libs/vkd3d-shader/hlsl.y @@ -1837,7 +1837,9 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl /* Only HLSL_IR_LOAD can return an object. */ object_load = hlsl_ir_load(object); - if (!strcmp(name, "Load")) + if (!strcmp(name, "Load") + && object_type->sampler_dim != HLSL_SAMPLER_DIM_CUBE + && object_type->sampler_dim != HLSL_SAMPLER_DIM_CUBEARRAY) { const unsigned int sampler_dim = sampler_dim_count(object_type->sampler_dim); struct hlsl_ir_resource_load *load; @@ -1863,7 +1865,9 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl list_add_tail(instrs, &load->node.entry); return true; } - else if (!strcmp(name, "Sample")) + else if (!strcmp(name, "Sample") + && object_type->sampler_dim != HLSL_SAMPLER_DIM_2DMS + && object_type->sampler_dim != HLSL_SAMPLER_DIM_2DMSARRAY) { const unsigned int sampler_dim = sampler_dim_count(object_type->sampler_dim); const struct hlsl_type *sampler_type; @@ -1913,8 +1917,16 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl list_add_tail(instrs, &load->node.entry); return true; } - else if (!strcmp(name, "Gather") || !strcmp(name, "GatherRed") || !strcmp(name, "GatherBlue") - || !strcmp(name, "GatherGreen") || !strcmp(name, "GatherAlpha")) + else if ((!strcmp(name, "Gather") + || !strcmp(name, "GatherRed") + || !strcmp(name, "GatherBlue") + || !strcmp(name, "GatherGreen") + || !strcmp(name, "GatherAlpha") + ) && ( + object_type->sampler_dim == HLSL_SAMPLER_DIM_2D + || object_type->sampler_dim == HLSL_SAMPLER_DIM_2DMSARRAY + || object_type->sampler_dim == HLSL_SAMPLER_DIM_CUBE + || object_type->sampler_dim == HLSL_SAMPLER_DIM_CUBEARRAY)) { const unsigned int sampler_dim = sampler_dim_count(object_type->sampler_dim); enum hlsl_resource_load_type load_type; -- 2.25.1

1 0

[PATCH vkd3d v3 11/12] vkd3d-shader/hlsl: Handle mipmap level for texture arrays in sm4 ld instruction.
by Francisco Casas 17 Dec '21

17 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl_sm4.c | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/libs/vkd3d-shader/hlsl_sm4.c b/libs/vkd3d-shader/hlsl_sm4.c index 1b8d9c25..f5c3dd6d 100644 --- a/libs/vkd3d-shader/hlsl_sm4.c +++ b/libs/vkd3d-shader/hlsl_sm4.c @@ -1287,6 +1287,7 @@ static void write_sm4_ld(struct hlsl_ctx *ctx, struct vkd3d_bytecode_buffer *buf { struct sm4_instruction instr; unsigned int writemask; + unsigned int dim_count; memset(&instr, 0, sizeof(instr)); instr.opcode = VKD3D_SM4_OP_LD; @@ -1299,23 +1300,11 @@ static void write_sm4_ld(struct hlsl_ctx *ctx, struct vkd3d_bytecode_buffer *buf /* Mipmap level is in the last component in the IR, but needs to be in the W * component in the instruction. */ - switch (resource_type->sampler_dim) - { - case HLSL_SAMPLER_DIM_1D: - instr.srcs[0].swizzle = hlsl_combine_swizzles(instr.srcs[0].swizzle, HLSL_SWIZZLE(X, X, X, Y), 4); - break; - - case HLSL_SAMPLER_DIM_2D: - instr.srcs[0].swizzle = hlsl_combine_swizzles(instr.srcs[0].swizzle, HLSL_SWIZZLE(X, Y, X, Z), 4); - break; - - case HLSL_SAMPLER_DIM_3D: - case HLSL_SAMPLER_DIM_CUBE: - break; - - default: - assert(0); - } + dim_count = sampler_dim_count(resource_type->sampler_dim); + if (dim_count == 1) + instr.srcs[0].swizzle = hlsl_combine_swizzles(instr.srcs[0].swizzle, HLSL_SWIZZLE(X, X, X, Y), 4); + if (dim_count == 2) + instr.srcs[0].swizzle = hlsl_combine_swizzles(instr.srcs[0].swizzle, HLSL_SWIZZLE(X, Y, X, Z), 4); sm4_register_from_deref(ctx, &instr.srcs[1].reg, &writemask, &instr.srcs[1].swizzle_type, resource, resource_type); -- 2.25.1

1 0

[PATCH vkd3d v3 08/12] vkd3d-shader/hlsl: Account for new texture dimension types when writing sm4 definitions.
by Francisco Casas 17 Dec '21

17 Dec '21

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl_sm4.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/libs/vkd3d-shader/hlsl_sm4.c b/libs/vkd3d-shader/hlsl_sm4.c index cefe173d..1b8d9c25 100644 --- a/libs/vkd3d-shader/hlsl_sm4.c +++ b/libs/vkd3d-shader/hlsl_sm4.c @@ -424,6 +424,7 @@ static D3D_RESOURCE_RETURN_TYPE sm4_resource_format(const struct hlsl_type *type static D3D_SRV_DIMENSION sm4_rdef_resource_dimension(const struct hlsl_type *type) { + assert(type->base_type == HLSL_TYPE_TEXTURE); /* for now, until other resources are handled. */ switch (type->sampler_dim) { case HLSL_SAMPLER_DIM_1D: @@ -434,6 +435,16 @@ static D3D_SRV_DIMENSION sm4_rdef_resource_dimension(const struct hlsl_type *typ return D3D_SRV_DIMENSION_TEXTURE3D; case HLSL_SAMPLER_DIM_CUBE: return D3D_SRV_DIMENSION_TEXTURECUBE; + case HLSL_SAMPLER_DIM_1DARRAY: + return D3D_SRV_DIMENSION_TEXTURE1DARRAY; + case HLSL_SAMPLER_DIM_2DARRAY: + return D3D_SRV_DIMENSION_TEXTURE2DARRAY; + case HLSL_SAMPLER_DIM_2DMS: + return D3D_SRV_DIMENSION_TEXTURE2DMS; + case HLSL_SAMPLER_DIM_2DMSARRAY: + return D3D_SRV_DIMENSION_TEXTURE2DMSARRAY; + case HLSL_SAMPLER_DIM_CUBEARRAY: + return D3D_SRV_DIMENSION_TEXTURECUBEARRAY; default: assert(0); return D3D_SRV_DIMENSION_UNKNOWN; @@ -711,6 +722,7 @@ static void write_sm4_rdef(struct hlsl_ctx *ctx, struct dxbc_writer *dxbc) static enum vkd3d_sm4_resource_type sm4_resource_dimension(const struct hlsl_type *type) { + assert(type->base_type == HLSL_TYPE_TEXTURE); /* for now, until other resources are handled. */ switch (type->sampler_dim) { case HLSL_SAMPLER_DIM_1D: @@ -721,6 +733,16 @@ static enum vkd3d_sm4_resource_type sm4_resource_dimension(const struct hlsl_typ return VKD3D_SM4_RESOURCE_TEXTURE_3D; case HLSL_SAMPLER_DIM_CUBE: return VKD3D_SM4_RESOURCE_TEXTURE_CUBE; + case HLSL_SAMPLER_DIM_1DARRAY: + return VKD3D_SM4_RESOURCE_TEXTURE_1DARRAY; + case HLSL_SAMPLER_DIM_2DARRAY: + return VKD3D_SM4_RESOURCE_TEXTURE_2DARRAY; + case HLSL_SAMPLER_DIM_2DMS: + return VKD3D_SM4_RESOURCE_TEXTURE_2DMS; + case HLSL_SAMPLER_DIM_2DMSARRAY: + return VKD3D_SM4_RESOURCE_TEXTURE_2DMSARRAY; + case HLSL_SAMPLER_DIM_CUBEARRAY: + return VKD3D_SM4_RESOURCE_TEXTURE_CUBEARRAY; default: assert(0); return 0; -- 2.25.1

1 0

[PATCH v2] ntdll: Don't set socket IO status after queuing async.
by Paul Gofman 17 Dec '21

17 Dec '21

Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- Supersedes 222236-222237. Currently NtDeviceIoControlFile() always sets the io comletion status after sock_ioctl(). This may happen after the application has received and processed the completion already and rightfully freed or reused IOSB (OVERLAPPED) pointer and result in data corruption. Fixes random crashes in Forza Horizon 4 when connected to online. v2: - Process IOCTL_AFD_WINE_TRANSMIT, IOCTL_AFD_WINE_COMPLETE_ASYNC, IOCTL_AFD_WINE_FIONREAD, IOCTL_AFD_WINE_SIOCATMARK, IOCTL_AFD_WINE_GET_INTERFACE_LIST, IOCTL_AFD_WINE_KEEPALIVE_VALS similarly; - Fix fd leaks; - Fix double fd close. dlls/ntdll/unix/file.c | 1 + dlls/ntdll/unix/socket.c | 135 ++++++++++++++++++++++----------------- 2 files changed, 79 insertions(+), 57 deletions(-) diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index 51c92df57e3..07bfa6c22c4 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -5712,6 +5712,7 @@ NTSTATUS WINAPI NtDeviceIoControlFile( HANDLE handle, HANDLE event, PIO_APC_ROUT case FILE_DEVICE_BEEP: case FILE_DEVICE_NETWORK: status = sock_ioctl( handle, event, apc, apc_context, io, code, in_buffer, in_size, out_buffer, out_size ); + if (status != STATUS_NOT_SUPPORTED && status != STATUS_BAD_DEVICE_TYPE) return status; break; case FILE_DEVICE_DISK: case FILE_DEVICE_CD_ROM: diff --git a/dlls/ntdll/unix/socket.c b/dlls/ntdll/unix/socket.c index 92374e39db7..f82c7ae1ddf 100644 --- a/dlls/ntdll/unix/socket.c +++ b/dlls/ntdll/unix/socket.c @@ -1106,6 +1106,7 @@ static NTSTATUS sock_transmit( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, * actually currently impossible to get STATUS_SUCCESS. The server will * either return STATUS_PENDING or an error code, and in neither case * should the iosb be filled. */ + if (!status) FIXME( "Unhandled success status." ); } SERVER_END_REQ; @@ -1142,7 +1143,11 @@ static NTSTATUS do_getsockopt( HANDLE handle, IO_STATUS_BLOCK *io, int level, ret = getsockopt( fd, level, option, out_buffer, &len ); if (needs_close) close( fd ); if (ret) return sock_errno_to_status( errno ); - if (io) io->Information = len; + if (io) + { + io->Status = STATUS_SUCCESS; + io->Information = len; + } return STATUS_SUCCESS; } @@ -1159,7 +1164,9 @@ static NTSTATUS do_setsockopt( HANDLE handle, IO_STATUS_BLOCK *io, int level, ret = setsockopt( fd, level, option, optval, optlen ); if (needs_close) close( fd ); - return ret ? sock_errno_to_status( errno ) : STATUS_SUCCESS; + if (ret) return sock_errno_to_status( errno ); + if (io) io->Status = STATUS_SUCCESS; + return STATUS_SUCCESS; } @@ -1287,10 +1294,10 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc unix_flags |= MSG_PEEK; if (params.msg_flags & AFD_MSG_WAITALL) FIXME( "MSG_WAITALL is not supported\n" ); - status = sock_recv( handle, event, apc, apc_user, io, fd, params.buffers, params.count, NULL, NULL, NULL, NULL, unix_flags, !!(params.recv_flags & AFD_RECV_FORCE_ASYNC) ); - break; + if (needs_close) close( fd ); + return status; } case IOCTL_AFD_WINE_RECVMSG: @@ -1314,12 +1321,12 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc unix_flags |= MSG_PEEK; if (*ws_flags & WS_MSG_WAITALL) FIXME( "MSG_WAITALL is not supported\n" ); - status = sock_recv( handle, event, apc, apc_user, io, fd, u64_to_user_ptr(params->buffers_ptr), params->count, u64_to_user_ptr(params->control_ptr), u64_to_user_ptr(params->addr_ptr), u64_to_user_ptr(params->addr_len_ptr), ws_flags, unix_flags, params->force_async ); - break; + if (needs_close) close( fd ); + return status; } case IOCTL_AFD_WINE_SENDMSG: @@ -1342,10 +1349,10 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc WARN( "ignoring MSG_PARTIAL\n" ); if (params->ws_flags & ~(WS_MSG_OOB | WS_MSG_PARTIAL)) FIXME( "unknown flags %#x\n", params->ws_flags ); - status = sock_send( handle, event, apc, apc_user, io, fd, u64_to_user_ptr( params->buffers_ptr ), params->count, u64_to_user_ptr( params->addr_ptr ), params->addr_len, unix_flags, params->force_async ); - break; + if (needs_close) close( fd ); + return status; } case IOCTL_AFD_WINE_TRANSMIT: @@ -1360,9 +1367,9 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc status = STATUS_BUFFER_TOO_SMALL; break; } - status = sock_transmit( handle, event, apc, apc_user, io, fd, params ); - break; + if (needs_close) close( fd ); + return status; } case IOCTL_AFD_WINE_COMPLETE_ASYNC: @@ -1372,7 +1379,7 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc status = *(NTSTATUS *)in_buffer; complete_async( handle, event, apc, apc_user, io, status, 0 ); - break; + return status; } case IOCTL_AFD_WINE_FIONREAD: @@ -1396,9 +1403,9 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc if (!getsockopt( fd, SOL_SOCKET, SO_ACCEPTCONN, &value, &len ) && value) { *(int *)out_buffer = 0; - status = STATUS_SUCCESS; - complete_async( handle, event, apc, apc_user, io, status, 0 ); - break; + if (needs_close) close( fd ); + complete_async( handle, event, apc, apc_user, io, STATUS_SUCCESS, 0 ); + return STATUS_SUCCESS; } } #endif @@ -1409,9 +1416,9 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc break; } *(int *)out_buffer = value; - status = STATUS_SUCCESS; - complete_async( handle, event, apc, apc_user, io, status, 0 ); - break; + if (needs_close) close( fd ); + complete_async( handle, event, apc, apc_user, io, STATUS_SUCCESS, 0 ); + return STATUS_SUCCESS; } case IOCTL_AFD_WINE_SIOCATMARK: @@ -1448,9 +1455,9 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc /* windows is reversed with respect to unix */ *(int *)out_buffer = !value; } - status = STATUS_SUCCESS; - complete_async( handle, event, apc, apc_user, io, status, 0 ); - break; + if (needs_close) close( fd ); + complete_async( handle, event, apc, apc_user, io, STATUS_SUCCESS, 0 ); + return STATUS_SUCCESS; } case IOCTL_AFD_WINE_GET_INTERFACE_LIST: @@ -1461,9 +1468,6 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc unsigned int count = 0; ULONG ret_size; - if ((status = server_get_unix_fd( handle, 0, &fd, &needs_close, NULL, NULL ))) - return status; - if (getifaddrs( &ifaddrs ) < 0) { status = sock_errno_to_status( errno ); @@ -1478,10 +1482,9 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc ret_size = count * sizeof(*info); if (out_size < ret_size) { - status = STATUS_PENDING; - complete_async( handle, event, apc, apc_user, io, STATUS_BUFFER_TOO_SMALL, 0 ); freeifaddrs( ifaddrs ); - break; + complete_async( handle, event, apc, apc_user, io, STATUS_BUFFER_TOO_SMALL, 0 ); + return STATUS_PENDING; } memset( out_buffer, 0, ret_size ); @@ -1530,8 +1533,8 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc } freeifaddrs( ifaddrs ); - status = STATUS_PENDING; complete_async( handle, event, apc, apc_user, io, STATUS_SUCCESS, ret_size ); + return STATUS_PENDING; #else FIXME( "Interface list queries are currently not supported on this platform.\n" ); status = STATUS_NOT_SUPPORTED; @@ -1584,9 +1587,9 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc #endif } - status = STATUS_SUCCESS; - complete_async( handle, event, apc, apc_user, io, status, 0 ); - break; + if (needs_close) close( fd ); + complete_async( handle, event, apc, apc_user, io, STATUS_SUCCESS, 0 ); + return STATUS_SUCCESS; } case IOCTL_AFD_WINE_GETPEERNAME: @@ -1638,7 +1641,6 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc return status; ret = getsockopt( fd, SOL_SOCKET, SO_LINGER, &unix_linger, &len ); - if (needs_close) close( fd ); if (!ret) { ws_linger->l_onoff = unix_linger.l_onoff; @@ -1646,7 +1648,8 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc io->Information = sizeof(*ws_linger); } - return ret ? sock_errno_to_status( errno ) : STATUS_SUCCESS; + status = ret ? sock_errno_to_status( errno ) : STATUS_SUCCESS; + break; } case IOCTL_AFD_WINE_SET_SO_LINGER: @@ -1674,8 +1677,6 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc * most programmers assume, anyway */ case IOCTL_AFD_WINE_SET_SO_REUSEADDR: { - int fd, needs_close = FALSE; - NTSTATUS status; int ret; if ((status = server_get_unix_fd( handle, 0, &fd, &needs_close, NULL, NULL ))) @@ -1685,8 +1686,8 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc #ifdef __APPLE__ if (!ret) ret = setsockopt( fd, SOL_SOCKET, SO_REUSEPORT, in_buffer, in_size ); #endif - if (needs_close) close( fd ); - return ret ? sock_errno_to_status( errno ) : STATUS_SUCCESS; + status = ret ? sock_errno_to_status( errno ) : STATUS_SUCCESS; + break; } case IOCTL_AFD_WINE_SET_IP_ADD_MEMBERSHIP: @@ -1725,10 +1726,16 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc ret = 0; /* fake success */ } #endif - if (needs_close) close( fd ); - if (ret) return sock_errno_to_status( errno ); - io->Information = len; - return STATUS_SUCCESS; + if (ret) + { + status = sock_errno_to_status( errno ); + } + else + { + io->Information = len; + status = STATUS_SUCCESS; + } + break; } case IOCTL_AFD_WINE_SET_IP_DONTFRAGMENT: @@ -1746,7 +1753,8 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc if (!once++) FIXME( "IP_DONTFRAGMENT is not supported on this platform\n" ); - return STATUS_SUCCESS; /* fake success */ + status = STATUS_SUCCESS; /* fake success */ + break; } #endif @@ -1931,10 +1939,16 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc ret = 0; /* fake success */ } #endif - if (needs_close) close( fd ); - if (ret) return sock_errno_to_status( errno ); - io->Information = len; - return STATUS_SUCCESS; + if (ret) + { + status = sock_errno_to_status( errno ); + } + else + { + io->Information = len; + status = STATUS_SUCCESS; + } + break; } case IOCTL_AFD_WINE_SET_IPV6_DONTFRAG: @@ -2070,10 +2084,8 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc case IOCTL_AFD_WINE_SET_IPV6_V6ONLY: { - int fd, needs_close = FALSE; union unix_sockaddr addr; socklen_t len = sizeof(addr); - NTSTATUS status; int ret; if ((status = server_get_unix_fd( handle, 0, &fd, &needs_close, NULL, NULL ))) @@ -2083,12 +2095,13 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc { /* changing IPV6_V6ONLY succeeds on an unbound IPv4 socket */ WARN( "ignoring IPV6_V6ONLY on an unbound IPv4 socket\n" ); - return STATUS_SUCCESS; + status = STATUS_SUCCESS; + break; } ret = setsockopt( fd, IPPROTO_IPV6, IPV6_V6ONLY, in_buffer, in_size ); - if (needs_close) close( fd ); - return ret ? sock_errno_to_status( errno ) : STATUS_SUCCESS; + status = ret ? sock_errno_to_status( errno ) : STATUS_SUCCESS; + break; } #ifdef SOL_IPX @@ -2100,7 +2113,6 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc #elif defined(SO_DEFAULT_HEADERS) case IOCTL_AFD_WINE_GET_IPX_PTYPE: { - int fd, needs_close = FALSE; struct ipx value; socklen_t len = sizeof(value); int ret; @@ -2109,10 +2121,16 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc return status; ret = getsockopt( fd, 0, SO_DEFAULT_HEADERS, &value, &len ); - if (needs_close) close( fd ); - if (ret) return sock_errno_to_status( errno ); - *(DWORD *)out_buffer = value.ipx_pt; - return STATUS_SUCCESS; + if (ret) + { + status = sock_errno_to_status( errno ); + } + else + { + *(DWORD *)out_buffer = value.ipx_pt; + status = STATUS_SUCCESS; + } + break; } case IOCTL_AFD_WINE_SET_IPX_PTYPE: @@ -2134,7 +2152,6 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc socklen_t len = sizeof(buffer); DEVICELIST *ws_list = out_buffer; int fd, needs_close = FALSE; - NTSTATUS status; unsigned int i; int ret; @@ -2164,7 +2181,8 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc ws_dev->irdaDeviceHints2 = unix_dev->hints[1]; ws_dev->irdaCharSet = unix_dev->charset; } - return STATUS_SUCCESS; + status = STATUS_SUCCESS; + break; } #endif @@ -2192,5 +2210,8 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc } if (needs_close) close( fd ); + + if (status != STATUS_PENDING && !NT_ERROR(status)) io->Status = status; + return status; } -- 2.33.1

2 1

[PATCH v2] wined3d: Add WINED3DFMT_R11G11B10_FLOAT vertex format.
by Andrey Gusev 17 Dec '21

17 Dec '21

Used by Dark Souls: Remastered. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> --- dlls/d3d10core/tests/d3d10core.c | 2 ++ dlls/d3d11/tests/d3d11.c | 2 ++ dlls/wined3d/adapter_gl.c | 2 ++ dlls/wined3d/utils.c | 2 ++ dlls/wined3d/wined3d_gl.h | 1 + 5 files changed, 9 insertions(+) diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c index a4729f9d2d3..a1c4be46b7f 100644 --- a/dlls/d3d10core/tests/d3d10core.c +++ b/dlls/d3d10core/tests/d3d10core.c @@ -12370,6 +12370,7 @@ static void test_create_input_layout(void) DXGI_FORMAT_R16G16_FLOAT, DXGI_FORMAT_R16G16_UINT, DXGI_FORMAT_R16G16_SINT, + DXGI_FORMAT_R11G11B10_FLOAT, DXGI_FORMAT_R32_FLOAT, DXGI_FORMAT_R32_UINT, DXGI_FORMAT_R32_SINT, @@ -13649,6 +13650,7 @@ static void test_format_support(void) static const struct format_support vertex_buffers[] = { {DXGI_FORMAT_R8G8_UINT}, + {DXGI_FORMAT_R11G11B10_FLOAT}, {DXGI_FORMAT_R16_FLOAT}, }; diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 53087684acf..5a8affbf75a 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -18549,6 +18549,7 @@ static void test_create_input_layout(void) DXGI_FORMAT_R16G16_FLOAT, DXGI_FORMAT_R16G16_UINT, DXGI_FORMAT_R16G16_SINT, + DXGI_FORMAT_R11G11B10_FLOAT, DXGI_FORMAT_R32_FLOAT, DXGI_FORMAT_R32_UINT, DXGI_FORMAT_R32_SINT, @@ -20623,6 +20624,7 @@ static void test_format_support(const D3D_FEATURE_LEVEL feature_level) static const struct format_support vertex_buffers[] = { {DXGI_FORMAT_R8G8_UINT, D3D_FEATURE_LEVEL_10_0}, + {DXGI_FORMAT_R11G11B10_FLOAT, D3D_FEATURE_LEVEL_10_0}, {DXGI_FORMAT_R16_FLOAT, D3D_FEATURE_LEVEL_10_0}, }; diff --git a/dlls/wined3d/adapter_gl.c b/dlls/wined3d/adapter_gl.c index 6cc2f0cd9a8..5511a70a8ff 100644 --- a/dlls/wined3d/adapter_gl.c +++ b/dlls/wined3d/adapter_gl.c @@ -159,6 +159,7 @@ static const struct wined3d_extension_map gl_extension_map[] = {"GL_ARB_vertex_buffer_object", ARB_VERTEX_BUFFER_OBJECT }, {"GL_ARB_vertex_program", ARB_VERTEX_PROGRAM }, {"GL_ARB_vertex_shader", ARB_VERTEX_SHADER }, + {"GL_ARB_vertex_type_10f_11f_11f_rev", ARB_VERTEX_TYPE_10F_11F_11F_REV}, {"GL_ARB_vertex_type_2_10_10_10_rev", ARB_VERTEX_TYPE_2_10_10_10_REV}, {"GL_ARB_viewport_array", ARB_VIEWPORT_ARRAY }, {"GL_ARB_texture_barrier", ARB_TEXTURE_BARRIER }, @@ -3385,6 +3386,7 @@ static BOOL wined3d_adapter_init_gl_caps(struct wined3d_adapter *adapter, {ARB_CLEAR_TEXTURE, MAKEDWORD_VERSION(4, 4)}, {ARB_QUERY_BUFFER_OBJECT, MAKEDWORD_VERSION(4, 4)}, {ARB_TEXTURE_MIRROR_CLAMP_TO_EDGE, MAKEDWORD_VERSION(4, 4)}, + {ARB_VERTEX_TYPE_10F_11F_11F_REV, MAKEDWORD_VERSION(4, 4)}, {ARB_CLIP_CONTROL, MAKEDWORD_VERSION(4, 5)}, {ARB_CULL_DISTANCE, MAKEDWORD_VERSION(4, 5)}, diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index ef2e28b545a..5e375f43a48 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -709,6 +709,8 @@ static const struct wined3d_format_vertex_info format_vertex_info[] = {WINED3DFMT_R16G16B16A16_SNORM, WINED3D_FFP_EMIT_SHORT4N, GL_SHORT}, {WINED3DFMT_R16G16_UNORM, WINED3D_FFP_EMIT_USHORT2N, GL_UNSIGNED_SHORT}, {WINED3DFMT_R16G16B16A16_UNORM, WINED3D_FFP_EMIT_USHORT4N, GL_UNSIGNED_SHORT}, + {WINED3DFMT_R11G11B10_FLOAT, WINED3D_FFP_EMIT_INVALID, GL_UNSIGNED_INT_10F_11F_11F_REV, + ARB_VERTEX_TYPE_10F_11F_11F_REV}, {WINED3DFMT_R10G10B10X2_UINT, WINED3D_FFP_EMIT_UDEC3, GL_UNSIGNED_SHORT}, {WINED3DFMT_R10G10B10X2_SNORM, WINED3D_FFP_EMIT_DEC3N, GL_SHORT}, {WINED3DFMT_R10G10B10A2_UNORM, WINED3D_FFP_EMIT_INVALID, GL_UNSIGNED_INT_2_10_10_10_REV, diff --git a/dlls/wined3d/wined3d_gl.h b/dlls/wined3d/wined3d_gl.h index 2dbc56ab79d..7b6fa50c5f0 100644 --- a/dlls/wined3d/wined3d_gl.h +++ b/dlls/wined3d/wined3d_gl.h @@ -143,6 +143,7 @@ enum wined3d_gl_extension ARB_VERTEX_BUFFER_OBJECT, ARB_VERTEX_PROGRAM, ARB_VERTEX_SHADER, + ARB_VERTEX_TYPE_10F_11F_11F_REV, ARB_VERTEX_TYPE_2_10_10_10_REV, ARB_VIEWPORT_ARRAY, ARB_TEXTURE_BARRIER, -- 2.33.1

3 2

[PATCH] server/console: ensure conhost has created the TTY input stream before waiting
by Eric Pouech 17 Dec '21

17 Dec '21

some PE executables (like mingw's gdb port) just do something like: - WaitForSingleObject(GetStdHandle(STD_INPUT_HANDLE), INFINITE) and hang for ever (the read operations are done *after* the wait operation succeeds) (of course, the real wait operation is more complex, but the problematic part boils down to that) this hangs for ever because conhost's main input thread hasn't been started yet this patch sends once a peek IOCTL before waiting, hence ensuring conhost's main input stream has been started this lets i686 and x64_86 mingw's gdb port to accept user's input (this is second attempt to fix this bug, based on Jacek's feedback on first try) A+ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- server/console.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/server/console.c b/server/console.c index 977c428cf9f..b4ef1d21874 100644 --- a/server/console.c +++ b/server/console.c @@ -136,6 +136,7 @@ struct console_server struct list read_queue; /* blocking read queue */ int busy; /* flag if server processing an ioctl */ int term_fd; /* UNIX terminal fd */ + int once_input; /* flag if input thread has already been requested */ struct termios termios; /* original termios */ }; @@ -892,6 +893,7 @@ static struct object *create_console_server( void ) server->console = NULL; server->busy = 0; server->term_fd = -1; + server->once_input = 0; list_init( &server->queue ); list_init( &server->read_queue ); server->fd = alloc_pseudo_fd( &console_server_fd_ops, &server->obj, FILE_SYNCHRONOUS_IO_NONALERT ); @@ -1310,11 +1312,19 @@ static void console_input_dump( struct object *obj, int verbose ) static int console_input_add_queue( struct object *obj, struct wait_queue_entry *entry ) { + struct console_server* server; if (!current->process->console) { set_error( STATUS_ACCESS_DENIED ); return 0; } + server = current->process->console->server; + /* before waiting, ensure conhost's input thread has been started */ + if ( server && !server->once_input ) + { + queue_host_ioctl( server, IOCTL_CONDRV_PEEK, 0, NULL, NULL); + server->once_input = 1; + } return add_queue( &current->process->console->obj, entry ); }

2 5

[PATCH] wined3d: Release the allocator lock on error in wined3d_allocator_chunk_vk_map().
by Henri Verbeet 17 Dec '21

17 Dec '21

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- Ideally we'd never get there, of course. dlls/wined3d/context_vk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wined3d/context_vk.c b/dlls/wined3d/context_vk.c index 06162d0c0e8..fd6d810f0e2 100644 --- a/dlls/wined3d/context_vk.c +++ b/dlls/wined3d/context_vk.c @@ -273,6 +273,7 @@ void *wined3d_allocator_chunk_vk_map(struct wined3d_allocator_chunk_vk *chunk_vk chunk_vk->vk_memory, 0, VK_WHOLE_SIZE, 0, &chunk_vk->c.map_ptr))) < 0) { ERR("Failed to map chunk memory, vr %s.\n", wined3d_debug_vkresult(vr)); + wined3d_allocator_chunk_vk_unlock(chunk_vk); return NULL; } -- 2.30.2

1 0

[PATCH 1/3] winepulse.drv: Stop writing the same data again on underflow.
by Rémi Bernon 17 Dec '21

17 Dec '21

Data in [lcl_offs_bytes;lcl_offs_bytes+held_bytes] is the data we've received from the client and that we consider being used by pulse, regardless of how we write it to it. A subset of this is [pa_offs_bytes;pa_offs_bytes+pa_held_bytes], which is the data we have received from the client but not yet written to pulse. If pulsed has underflown it means that it has used all the data we've written already, and resetting pa_offs_bytes and pa_held_bytes like here will only make us write the same data again (in addition to silence) to mend the underflow, ending up with potentially duplicate audio frames being played. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52225 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/winepulse.drv/pulse.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/dlls/winepulse.drv/pulse.c b/dlls/winepulse.drv/pulse.c index bce70ac358c..c329e8c423c 100644 --- a/dlls/winepulse.drv/pulse.c +++ b/dlls/winepulse.drv/pulse.c @@ -260,9 +260,6 @@ static void pulse_underflow_callback(pa_stream *s, void *userdata) struct pulse_stream *stream = userdata; WARN("%p: Underflow\n", userdata); stream->just_underran = TRUE; - /* re-sync */ - stream->pa_offs_bytes = stream->lcl_offs_bytes; - stream->pa_held_bytes = stream->held_bytes; } static void pulse_started_callback(pa_stream *s, void *userdata) -- 2.34.0

2 6

[PATCH v2] winmm: Instanciate DirectInput8 class using CoCreateInstance.
by Rémi Bernon 17 Dec '21

17 Dec '21

Instead of linking with dinput8.dll and creating the class at load time, which causes some native hooks to fail loading. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52222 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- v2: Reset dinput to NULL in case of creation failure, so that we don't release it or call CoUninitialize twice. dlls/winmm/Makefile.in | 2 +- dlls/winmm/joystick.c | 30 ++++++++++++++++++++++++++---- dlls/winmm/winemm.h | 1 - dlls/winmm/winmm.c | 2 -- 4 files changed, 27 insertions(+), 8 deletions(-) diff --git a/dlls/winmm/Makefile.in b/dlls/winmm/Makefile.in index 5439ae21678..3036526c14e 100644 --- a/dlls/winmm/Makefile.in +++ b/dlls/winmm/Makefile.in @@ -1,7 +1,7 @@ EXTRADEFS = -D_WINMM_ MODULE = winmm.dll IMPORTLIB = winmm -IMPORTS = uuid user32 advapi32 ole32 msacm32 dinput8 +IMPORTS = uuid user32 advapi32 ole32 msacm32 C_SRCS = \ driver.c \ diff --git a/dlls/winmm/joystick.c b/dlls/winmm/joystick.c index 5f5683e3e35..d055b3c9deb 100644 --- a/dlls/winmm/joystick.c +++ b/dlls/winmm/joystick.c @@ -152,11 +152,28 @@ static BOOL CALLBACK enum_instances( const DIDEVICEINSTANCEW *instance, void *co return DIENUM_CONTINUE; } -void joystick_load( HINSTANCE instance ) +static BOOL WINAPI joystick_load( INIT_ONCE *once, void *param, void **context ) { - HRESULT hr = DirectInput8Create( instance, DIRECTINPUT_VERSION, &IID_IDirectInput8W, - (void **)&dinput, NULL ); - if (FAILED(hr)) WARN( "could not create dinput instance, hr %#x\n", hr ); + HRESULT hr; + + CoInitialize( NULL ); + + hr = CoCreateInstance( &CLSID_DirectInput8, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectInput8W, + (void **)&dinput ); + if (FAILED(hr)) goto failed; + + hr = IDirectInput8_Initialize( dinput, hWinMM32Instance, DIRECTINPUT_VERSION ); + if (FAILED(hr)) goto failed; + + return TRUE; + +failed: + if (dinput) IDirectInput8_Release( dinput ); + dinput = NULL; + + WARN( "Could not create dinput instance, hr %#x\n", hr ); + CoUninitialize(); + return FALSE; } void joystick_unload() @@ -173,15 +190,20 @@ void joystick_unload() } IDirectInput8_Release( dinput ); + CoUninitialize(); } static void find_joysticks(void) { + static INIT_ONCE init_once = INIT_ONCE_STATIC_INIT; + IDirectInputDevice8W *device; HANDLE event; DWORD index; HRESULT hr; + InitOnceExecuteOnce( &init_once, joystick_load, NULL, NULL ); + if (!dinput) return; index = 0; diff --git a/dlls/winmm/winemm.h b/dlls/winmm/winemm.h index 3459c2a85ef..52cab64b1c5 100644 --- a/dlls/winmm/winemm.h +++ b/dlls/winmm/winemm.h @@ -153,7 +153,6 @@ MMRESULT WINMM_CheckCallback(DWORD_PTR dwCallback, DWORD fdwOpen, BOOL mixer) DE void WINMM_DeleteWaveform(void) DECLSPEC_HIDDEN; -void joystick_load( HMODULE instance ) DECLSPEC_HIDDEN; void joystick_unload( void ) DECLSPEC_HIDDEN; /* Global variables */ diff --git a/dlls/winmm/winmm.c b/dlls/winmm/winmm.c index aab8bfb51a9..aa2dd50c4c1 100644 --- a/dlls/winmm/winmm.c +++ b/dlls/winmm/winmm.c @@ -144,8 +144,6 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID fImpLoad) if (!WINMM_CreateIData(hInstDLL)) return FALSE; - - joystick_load( hInstDLL ); break; case DLL_PROCESS_DETACH: if(fImpLoad) -- 2.34.0

2 2

[PATCH 1/2] ntdll: use proper names for magic constants
by Eric Pouech 17 Dec '21

17 Dec '21

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/ntdll/unix/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/process.c b/dlls/ntdll/unix/process.c index 23aa340359e..99c8e37053c 100644 --- a/dlls/ntdll/unix/process.c +++ b/dlls/ntdll/unix/process.c @@ -444,7 +444,7 @@ static NTSTATUS spawn_process( const RTL_USER_PROCESS_PARAMETERS *params, int so if (!(pid = fork())) /* grandchild */ { if (params->ConsoleFlags || - params->ConsoleHandle == (HANDLE)1 /* KERNEL32_CONSOLE_ALLOC */ || + params->ConsoleHandle == CONSOLE_HANDLE_ALLOC || (params->hStdInput == INVALID_HANDLE_VALUE && params->hStdOutput == INVALID_HANDLE_VALUE)) { setsid();

3 4

[PATCH] ntdll: Don't use inline assembly in do_cpuid.
by Jacek Caban 17 Dec '21

17 Dec '21

Avoids problems on old GCC. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51862 Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntdll/unix/system.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-)

2 1

[PATCH v2] ntdll: Don't use inline assembly in do_cpuid.
by Jacek Caban 17 Dec '21

17 Dec '21

Avoids problems on old GCC. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51862 Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- v2: add DECLSPEC_HIDDEN dlls/ntdll/unix/system.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-)

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel