- wine-devel - winehq.org

Re: [PATCH 1/5] ws2_32/tests: Add more tests for SO_CONNECT_TIME.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119152 Your paranoid android. === debian11 (32 bit Japanese:Japan report) === ws2_32: sock.c:6295: Test succeeded inside todo block: expected timeout

1 0

Re: [PATCH v2 7/7] shell32: Implement SHOpenFolderAndSelectItems().
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119127 Your paranoid android. === w1064_2qxl (64 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w10pro64 (64 bit report) === shell32: shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ja (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_zh_CN (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000

1 0

Re: [PATCH v2 6/7] shell32/tests: Add SHOpenFolderAndSelectItems() tests.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119126 Your paranoid android. === w1064v1809 (32 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w1064v1809 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w1064 (64 bit report) === shell32: shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_en_AE_u8 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_ja (64 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2)

1 0

Re: [PATCH v3 1/5] ws2_32: Add ipv4 raw socket protocol info.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119099 Your paranoid android. === w1064v1507 (32 bit report) === ws2_32: protocol.c:2067: Test failed: wait failed protocol.c:2069: Test failed: overlapped result is 10036 protocol.c:2071: Test failed: overlapped.Internal = 2734 protocol.c:2073: Test failed: got 0

1 0

Re: [PATCH v3 3/5] ntdll: Support SOCK_RAW / IPPROTO_ICMP fallback over SOCK_DGRAM.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119101 Your paranoid android. === debian11 (64 bit WoW report) === ntdll: change.c:241: Test failed: should be ready

1 0

Re: [PATCH 5/5] dlls/msvcrt: fix demangling of variables being an array
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119098 Your paranoid android. === w7u_2qxl (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_adm (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_el (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8 (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8adm (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (32 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_2qxl (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_adm (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_en_AE_u8 (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ar (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ja (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_zh_CN (64 bit report) === msvcrt: cpp.c:1308: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1311: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)"

1 0

Re: [PATCH 4/5] dlls/msvcrt: add support for restrict and unaligned qualifiers in demangling
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119097 Your paranoid android. === w7u_2qxl (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_adm (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_el (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8 (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8adm (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (32 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_2qxl (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_adm (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_en_AE_u8 (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ar (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ja (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_zh_CN (64 bit report) === msvcrt: cpp.c:1307: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1310: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)"

1 0

Re: [PATCH 3/5] dlls/msvcrt: fix and cleanup undecoration of templatized functions and methods
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119096 Your paranoid android. === w7u_2qxl (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_adm (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_el (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8 (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8adm (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (32 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_2qxl (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_adm (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_en_AE_u8 (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ar (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ja (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_zh_CN (64 bit report) === msvcrt: cpp.c:1306: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1309: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)"

1 0

Re: [PATCH 2/5] msvcrt: add support for C++11 operator "" in demangling
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119095 Your paranoid android. === w7u_2qxl (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_adm (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w7u_el (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8 (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w8adm (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (32 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w864 (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1507 (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064v1809 (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064 (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_2qxl (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_adm (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w1064_tsign (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64 (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_en_AE_u8 (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ar (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_ja (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)" === w10pro64_zh_CN (64 bit report) === msvcrt: cpp.c:1305: Test failed: 132: Got name "??__K_l@@YA?AUCC@@I@Z" cpp.c:1308: Test failed: 132: Expected "struct CC __cdecl operator "" _l(unsigned int)"

1 0

[PATCH v2] winspool.drv: Implement OpenPrinter2.
by Dmitry Timoshkov 15 Jul '22

15 Jul '22

v2: Forward OpenPrinter() to OpenPrinter2(). Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/winspool.drv/info.c | 96 +++++++++++++++++++---------- dlls/winspool.drv/winspool.drv.spec | 2 + include/winspool.h | 29 ++++++++- 3 files changed, 92 insertions(+), 35 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index 482f70a2235..e1cd0338207 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -1990,32 +1990,9 @@ BOOL WINAPI IsValidDevmodeW(PDEVMODEW dm, SIZE_T size) * See OpenPrinterW. * */ -BOOL WINAPI OpenPrinterA(LPSTR lpPrinterName,HANDLE *phPrinter, - LPPRINTER_DEFAULTSA pDefault) +BOOL WINAPI OpenPrinterA(LPSTR name, HANDLE *printer, PRINTER_DEFAULTSA *defaults) { - UNICODE_STRING lpPrinterNameW; - UNICODE_STRING usBuffer; - PRINTER_DEFAULTSW DefaultW, *pDefaultW = NULL; - PWSTR pwstrPrinterNameW; - BOOL ret; - - TRACE("%s,%p,%p\n", debugstr_a(lpPrinterName), phPrinter, pDefault); - - pwstrPrinterNameW = asciitounicode(&lpPrinterNameW,lpPrinterName); - - if(pDefault) { - DefaultW.pDatatype = asciitounicode(&usBuffer,pDefault->pDatatype); - DefaultW.pDevMode = pDefault->pDevMode ? GdiConvertToDevmodeW(pDefault->pDevMode) : NULL; - DefaultW.DesiredAccess = pDefault->DesiredAccess; - pDefaultW = &DefaultW; - } - ret = OpenPrinterW(pwstrPrinterNameW, phPrinter, pDefaultW); - if(pDefault) { - RtlFreeUnicodeString(&usBuffer); - HeapFree(GetProcessHeap(), 0, DefaultW.pDevMode); - } - RtlFreeUnicodeString(&lpPrinterNameW); - return ret; + return OpenPrinter2A(name, printer, defaults, NULL); } /****************************************************************** @@ -2045,22 +2022,73 @@ BOOL WINAPI OpenPrinterA(LPSTR lpPrinterName,HANDLE *phPrinter, *| pDefaults is ignored * */ -BOOL WINAPI OpenPrinterW(LPWSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAULTSW pDefault) +BOOL WINAPI OpenPrinterW(LPWSTR name, HANDLE *printer, PRINTER_DEFAULTSW *defaults) +{ + return OpenPrinter2W(name, printer, defaults, NULL); +} + +BOOL WINAPI OpenPrinter2A(LPSTR name, HANDLE *printer, + PRINTER_DEFAULTSA *defaults, PRINTER_OPTIONSA *options) +{ + UNICODE_STRING nameU; + UNICODE_STRING datatypeU; + PRINTER_DEFAULTSW defaultsW, *p_defaultsW = NULL; + PRINTER_OPTIONSW optionsW, *p_optionsW = NULL; + WCHAR *nameW; + BOOL ret; + + TRACE("(%s,%p,%p,%p)\n", debugstr_a(name), printer, defaults, options); + + nameW = asciitounicode(&nameU, name); + + if (options) + { + optionsW.cbSize = sizeof(optionsW); + optionsW.dwFlags = options->dwFlags; + p_optionsW = &optionsW; + } + + if (defaults) + { + defaultsW.pDatatype = asciitounicode(&datatypeU, defaults->pDatatype); + defaultsW.pDevMode = defaults->pDevMode ? GdiConvertToDevmodeW(defaults->pDevMode) : NULL; + defaultsW.DesiredAccess = defaults->DesiredAccess; + p_defaultsW = &defaultsW; + } + + ret = OpenPrinter2W(nameW, printer, p_defaultsW, p_optionsW); + + if (p_defaultsW) + { + RtlFreeUnicodeString(&datatypeU); + HeapFree(GetProcessHeap(), 0, defaultsW.pDevMode); + } + RtlFreeUnicodeString(&nameU); + + return ret; +} + +BOOL WINAPI OpenPrinter2W(LPWSTR name, HANDLE *printer, + PRINTER_DEFAULTSW *defaults, PRINTER_OPTIONSW *options) { HKEY key; - TRACE("(%s, %p, %p)\n", debugstr_w(lpPrinterName), phPrinter, pDefault); + TRACE("(%s,%p,%p,%p)\n", debugstr_w(name), printer, defaults, options); - if(!phPrinter) { + if (options) + FIXME("flags %08lx ignored\n", options->dwFlags); + + if(!printer) + { /* NT: FALSE with ERROR_INVALID_PARAMETER, 9x: TRUE */ - SetLastError(ERROR_INVALID_PARAMETER); + SetLastError( ERROR_INVALID_PARAMETER ); return FALSE; } /* Get the unique handle of the printer or Printserver */ - *phPrinter = get_opened_printer_entry(lpPrinterName, pDefault); + *printer = get_opened_printer_entry( name, defaults ); - if (*phPrinter && WINSPOOL_GetOpenedPrinterRegKey( *phPrinter, &key ) == ERROR_SUCCESS) + if (*printer && WINSPOOL_GetOpenedPrinterRegKey( *printer, &key ) == ERROR_SUCCESS) { DWORD deleting = 0, size = sizeof( deleting ), type; DWORD status; @@ -2070,12 +2098,12 @@ BOOL WINAPI OpenPrinterW(LPWSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAU set_reg_DWORD( key, L"Status", status & ~PRINTER_STATUS_DRIVER_UPDATE_NEEDED ); ReleaseMutex( init_mutex ); if (!deleting && (status & PRINTER_STATUS_DRIVER_UPDATE_NEEDED)) - update_driver( *phPrinter ); + update_driver( *printer ); RegCloseKey( key ); } - TRACE("returning %d with %lu and %p\n", *phPrinter != NULL, GetLastError(), *phPrinter); - return (*phPrinter != 0); + TRACE("returning %d with %lu and %p\n", *printer != NULL, GetLastError(), *printer); + return (*printer != NULL); } /****************************************************************** diff --git a/dlls/winspool.drv/winspool.drv.spec b/dlls/winspool.drv/winspool.drv.spec index d7bb49bd34b..39c2613a4a0 100644 --- a/dlls/winspool.drv/winspool.drv.spec +++ b/dlls/winspool.drv/winspool.drv.spec @@ -149,6 +149,8 @@ @ stdcall IsValidDevmodeW(ptr long) @ stdcall OpenPrinterA(str ptr ptr) @ stdcall OpenPrinterW(wstr ptr ptr) +@ stdcall OpenPrinter2A(str ptr ptr ptr) +@ stdcall OpenPrinter2W(wstr ptr ptr ptr) @ stdcall PerfClose() @ stdcall PerfCollect(wstr ptr ptr ptr) @ stdcall PerfOpen(wstr) diff --git a/include/winspool.h b/include/winspool.h index db8773ec418..ef39104ea30 100644 --- a/include/winspool.h +++ b/include/winspool.h @@ -1143,6 +1143,30 @@ typedef struct _BIDI_RESPONSE_CONTAINER { BIDI_RESPONSE_DATA aData[1]; } BIDI_RESPONSE_CONTAINER, *LPBIDI_RESPONSE_CONTAINER, *PBIDI_RESPONSE_CONTAINER; +typedef enum _PRINTER_OPTION_FLAGS +{ + PRINTER_OPTION_NO_CACHE = 1 << 0, + PRINTER_OPTION_CACHE = 1 << 1, + PRINTER_OPTION_CLIENT_CHANGE = 1 << 2, + PRINTER_OPTION_NO_CLIENT_DATA = 1 << 3, +} PRINTER_OPTION_FLAGS; + +typedef struct _PRINTER_OPTIONSA +{ + UINT cbSize; + DWORD dwFlags; +} PRINTER_OPTIONSA, *PPRINTER_OPTIONSA, *LPPRINTER_OPTIONSA; + +typedef struct _PRINTER_OPTIONSW +{ + UINT cbSize; + DWORD dwFlags; +} PRINTER_OPTIONSW, *PPRINTER_OPTIONSW, *LPPRINTER_OPTIONSW; + +DECL_WINELIB_TYPE_AW(PRINTER_OPTIONS) +DECL_WINELIB_TYPE_AW(PPRINTER_OPTIONS) +DECL_WINELIB_TYPE_AW(LPPRINTER_OPTIONS) + /* string constants */ #define SPLREG_DEFAULT_SPOOL_DIRECTORYA "DefaultSpoolDirectory" @@ -1400,9 +1424,12 @@ BOOL WINAPI OpenPrinterA(LPSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAULTSA pDefault); BOOL WINAPI OpenPrinterW(LPWSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAULTSW pDefault); - #define OpenPrinter WINELIB_NAME_AW(OpenPrinter) +BOOL WINAPI OpenPrinter2A(LPSTR,HANDLE *,PRINTER_DEFAULTSA *,PRINTER_OPTIONSA *); +BOOL WINAPI OpenPrinter2W(LPWSTR,HANDLE *,PRINTER_DEFAULTSW *,PRINTER_OPTIONSW *); +#define OpenPrinter2 WINELIB_NAME_AW(OpenPrinter2) + BOOL WINAPI ResetPrinterA(HANDLE hPrinter, LPPRINTER_DEFAULTSA pDefault); BOOL WINAPI ResetPrinterW(HANDLE hPrinter, LPPRINTER_DEFAULTSW pDefault); #define ResetPrinter WINELIB_NAME_AW(ResetPrinter) -- 2.36.1

2 1

[PATCH] programs/services: Start service dependencies.
by Dmitry Timoshkov 15 Jul '22

15 Jul '22

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- programs/services/services.c | 39 +++++++++++++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/programs/services/services.c b/programs/services/services.c index 2edc02d300c..08b7488473b 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -1190,12 +1190,49 @@ static DWORD process_send_start_message(struct process_entry *process, BOOL shar return result; } +static DWORD start_service_deps(struct service_entry *service) +{ + struct service_entry *entry; + LPWSTR name; + DWORD err; + + if (!service->dependOnServices) + return ERROR_SUCCESS; + + for (name = service->dependOnServices; *name; name += lstrlenW(name) + 1) + { + entry = scmdatabase_find_service(service->db, name); + if (!entry) + { + WINE_ERR("Service %s depends on %s which doesn't exist\n", debugstr_w(service->name), debugstr_w(name)); + return ERROR_SERVICE_DEPENDENCY_DELETED; + } + + err = service_start(entry, 0, NULL); + if (err != ERROR_SUCCESS && err != ERROR_SERVICE_ALREADY_RUNNING) + { + WINE_FIXME("Dependent on service %s failed to start: %lu\n", + wine_dbgstr_w(entry->name), err); + return ERROR_SERVICE_DEPENDENCY_FAIL; + } + } + + return ERROR_SUCCESS; +} + DWORD service_start(struct service_entry *service, DWORD service_argc, LPCWSTR *service_argv) { struct process_entry *process = NULL; BOOL shared_process; DWORD err; + err = start_service_deps(service); + if (err != ERROR_SUCCESS) + { + WINE_TRACE("returning %lu\n", err); + return err; + } + err = service_start_process(service, &process, &shared_process); if (err == ERROR_SUCCESS) { @@ -1221,7 +1258,7 @@ DWORD service_start(struct service_entry *service, DWORD service_argc, LPCWSTR * release_process(process); } - WINE_TRACE("returning %ld\n", err); + WINE_TRACE("returning %lu\n", err); return err; } -- 2.36.1

2 4

[PATCH] winspool.drv: Implement OpenPrinter2.
by Dmitry Timoshkov 15 Jul '22

15 Jul '22

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/winspool.drv/info.c | 18 ++++++++++++++++++ dlls/winspool.drv/winspool.drv.spec | 2 ++ include/winspool.h | 29 ++++++++++++++++++++++++++++- 3 files changed, 48 insertions(+), 1 deletion(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index 482f70a2235..c536253317b 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -2078,6 +2078,24 @@ BOOL WINAPI OpenPrinterW(LPWSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAU return (*phPrinter != 0); } +BOOL WINAPI OpenPrinter2A(LPSTR name, HANDLE *printer, + PRINTER_DEFAULTSA *defaults, PRINTER_OPTIONSA *options) +{ + if (options) + FIXME("flags %08lx ignored\n", options->dwFlags); + + return OpenPrinterA(name, printer, defaults); +} + +BOOL WINAPI OpenPrinter2W(LPWSTR name, HANDLE *printer, + PRINTER_DEFAULTSW *defaults, PRINTER_OPTIONSW *options) +{ + if (options) + FIXME("flags %08lx ignored\n", options->dwFlags); + + return OpenPrinterW(name, printer, defaults); +} + /****************************************************************** * AddMonitorA [WINSPOOL.@] * diff --git a/dlls/winspool.drv/winspool.drv.spec b/dlls/winspool.drv/winspool.drv.spec index d7bb49bd34b..39c2613a4a0 100644 --- a/dlls/winspool.drv/winspool.drv.spec +++ b/dlls/winspool.drv/winspool.drv.spec @@ -149,6 +149,8 @@ @ stdcall IsValidDevmodeW(ptr long) @ stdcall OpenPrinterA(str ptr ptr) @ stdcall OpenPrinterW(wstr ptr ptr) +@ stdcall OpenPrinter2A(str ptr ptr ptr) +@ stdcall OpenPrinter2W(wstr ptr ptr ptr) @ stdcall PerfClose() @ stdcall PerfCollect(wstr ptr ptr ptr) @ stdcall PerfOpen(wstr) diff --git a/include/winspool.h b/include/winspool.h index db8773ec418..ef39104ea30 100644 --- a/include/winspool.h +++ b/include/winspool.h @@ -1143,6 +1143,30 @@ typedef struct _BIDI_RESPONSE_CONTAINER { BIDI_RESPONSE_DATA aData[1]; } BIDI_RESPONSE_CONTAINER, *LPBIDI_RESPONSE_CONTAINER, *PBIDI_RESPONSE_CONTAINER; +typedef enum _PRINTER_OPTION_FLAGS +{ + PRINTER_OPTION_NO_CACHE = 1 << 0, + PRINTER_OPTION_CACHE = 1 << 1, + PRINTER_OPTION_CLIENT_CHANGE = 1 << 2, + PRINTER_OPTION_NO_CLIENT_DATA = 1 << 3, +} PRINTER_OPTION_FLAGS; + +typedef struct _PRINTER_OPTIONSA +{ + UINT cbSize; + DWORD dwFlags; +} PRINTER_OPTIONSA, *PPRINTER_OPTIONSA, *LPPRINTER_OPTIONSA; + +typedef struct _PRINTER_OPTIONSW +{ + UINT cbSize; + DWORD dwFlags; +} PRINTER_OPTIONSW, *PPRINTER_OPTIONSW, *LPPRINTER_OPTIONSW; + +DECL_WINELIB_TYPE_AW(PRINTER_OPTIONS) +DECL_WINELIB_TYPE_AW(PPRINTER_OPTIONS) +DECL_WINELIB_TYPE_AW(LPPRINTER_OPTIONS) + /* string constants */ #define SPLREG_DEFAULT_SPOOL_DIRECTORYA "DefaultSpoolDirectory" @@ -1400,9 +1424,12 @@ BOOL WINAPI OpenPrinterA(LPSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAULTSA pDefault); BOOL WINAPI OpenPrinterW(LPWSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAULTSW pDefault); - #define OpenPrinter WINELIB_NAME_AW(OpenPrinter) +BOOL WINAPI OpenPrinter2A(LPSTR,HANDLE *,PRINTER_DEFAULTSA *,PRINTER_OPTIONSA *); +BOOL WINAPI OpenPrinter2W(LPWSTR,HANDLE *,PRINTER_DEFAULTSW *,PRINTER_OPTIONSW *); +#define OpenPrinter2 WINELIB_NAME_AW(OpenPrinter2) + BOOL WINAPI ResetPrinterA(HANDLE hPrinter, LPPRINTER_DEFAULTSA pDefault); BOOL WINAPI ResetPrinterW(HANDLE hPrinter, LPPRINTER_DEFAULTSW pDefault); #define ResetPrinter WINELIB_NAME_AW(ResetPrinter) -- 2.36.1

2 2

Re: [PATCH v4 2/2] win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119088 Your paranoid android. === w10pro64_ja (64 bit report) === user32: win.c:189: Test failed: didn't get start_event win.c:10399: Test failed: WindowFromPoint returned 0000000000020338, expected 0000000000000000 win.c:10407: Test failed: WindowFromPoint returned 0000000000040336, expected 0000000000000000 win.c:10336: Test failed: transparent window didn't get WM_NCHITTEST message === debian11 (32 bit report) === user32: win.c:8992: Test failed: Unexpected event was delivered === debian11 (32 bit Hebrew:Israel report) === user32: win.c:8992: Test failed: Unexpected event was delivered === debian11 (32 bit Hindi:India report) === user32: win.c:8992: Test failed: Unexpected event was delivered

1 0

Re: [PATCH v4 1/2] user32/tests: Check that message-only windows ignore WS_EX_TOPMOST.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119087 Your paranoid android. === w10pro64_ja (64 bit report) === user32: win.c:4558: Test failed: hwnd 00000000000C032A/00000000000C032A message 0200 win.c:4563: Test failed: hwnd 00000000000C032A/00000000000C032A message 0203 win.c:4567: Test failed: message 0202 available

1 0

[PATCH] include: Add dxcore.idl.
by Biswapriyo Nath 15 Jul '22

15 Jul '22

4 8

Re: [PATCH v2 1/1] po: Update Korean translation.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119078 Your paranoid android. === debian11 (build log) === error: patch failed: po/ko.po:3972 Task: Patch failed to apply === debian11 (build log) === error: patch failed: po/ko.po:3972 Task: Patch failed to apply

1 0

Re: [PATCH 1/1] po: Update Korean translation.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119077 Your paranoid android. === debian11 (build log) === error: patch failed: po/ko.po:3972 Task: Patch failed to apply === debian11 (build log) === error: patch failed: po/ko.po:3972 Task: Patch failed to apply

1 0

[PATCH vkd3d 08/12] vkd3d-shader/hlsl: Print index paths in dump_deref().
by Francisco Casas 15 Jul '22

15 Jul '22

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c index c7416054..924121f0 100644 --- a/libs/vkd3d-shader/hlsl.c +++ b/libs/vkd3d-shader/hlsl.c @@ -1562,10 +1562,23 @@ static void dump_ir_var(struct hlsl_ctx *ctx, struct vkd3d_string_buffer *buffer static void dump_deref(struct vkd3d_string_buffer *buffer, const struct hlsl_deref *deref) { + unsigned int i; + if (deref->var) { vkd3d_string_buffer_printf(buffer, "%s", deref->var->name); - if (deref->offset.node) + if (deref->path_len) + { + vkd3d_string_buffer_printf(buffer, "["); + for (i = 0; i < deref->path_len; ++i) + { + vkd3d_string_buffer_printf(buffer, "["); + dump_src(buffer, &deref->path[i]); + vkd3d_string_buffer_printf(buffer, "]"); + } + vkd3d_string_buffer_printf(buffer, "]"); + } + else if (deref->offset.node) { vkd3d_string_buffer_printf(buffer, "["); dump_src(buffer, &deref->offset); -- 2.34.1

2 2

[PATCH vkd3d 11/12] vkd3d-shader/hlsl: Replace register offsets with index paths in input/output copies.
by Francisco Casas 15 Jul '22

15 Jul '22

Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- The recursive structure of prepend_input_var_copy() and append_output_var_copy() could be preserved creating additional loads to complete the paths. Otherwise we would be requiring passing whole paths as arguments. These additional loads should be handled by DCE. Still, matrix vectors are copied iteratively instead of recursively now, to avoid the boilerplate of creating new loads in this last step. Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl_codegen.c | 188 +++++++++++++++++++------------ 1 file changed, 114 insertions(+), 74 deletions(-) diff --git a/libs/vkd3d-shader/hlsl_codegen.c b/libs/vkd3d-shader/hlsl_codegen.c index 07c11f3f..0276fb89 100644 --- a/libs/vkd3d-shader/hlsl_codegen.c +++ b/libs/vkd3d-shader/hlsl_codegen.c @@ -239,59 +239,73 @@ static struct hlsl_ir_var *add_extern_var(struct hlsl_ctx *ctx, struct hlsl_ir_v return ext_var; } -static void prepend_input_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_var *var, - struct hlsl_type *type, unsigned int field_offset, unsigned int modifiers, const struct hlsl_semantic *semantic) +static void prepend_input_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_load *lhs, + struct hlsl_type *type, unsigned int modifiers, const struct hlsl_semantic *semantic) { - struct hlsl_ir_constant *offset; - struct hlsl_ir_store *store; - struct hlsl_ir_load *load; - struct hlsl_ir_var *input; + struct hlsl_type *vector_type = hlsl_get_vector_type(ctx, type->base_type, hlsl_type_minor_size(type)); + struct hlsl_ir_var *var = lhs->src.var; + unsigned int i; - if (type->type == HLSL_CLASS_MATRIX) + for (i = 0; i < hlsl_type_major_size(type); ++i) { - struct hlsl_type *vector_type = hlsl_get_vector_type(ctx, type->base_type, hlsl_type_minor_size(type)); - struct hlsl_semantic vector_semantic = *semantic; - unsigned int i; + struct hlsl_semantic semantic_copy = *semantic; + struct hlsl_ir_store *store; + struct hlsl_ir_constant *c; + struct hlsl_ir_var *input; + struct hlsl_ir_load *load; - for (i = 0; i < hlsl_type_major_size(type); ++i) - { - prepend_input_copy(ctx, instrs, var, vector_type, 4 * i, modifiers, &vector_semantic); - ++vector_semantic.index; - } - - return; - } + semantic_copy.index = semantic->index + i; - if (!(input = add_extern_var(ctx, var, type, modifiers, semantic, false))) - return; + if (!(input = add_extern_var(ctx, var, vector_type, modifiers, &semantic_copy, false))) + return; - if (!(load = hlsl_new_var_load(ctx, input, var->loc))) - return; - list_add_head(instrs, &load->node.entry); + if (!(load = hlsl_new_var_load(ctx, input, var->loc))) + return; + list_add_after(&lhs->node.entry, &load->node.entry); - if (!(offset = hlsl_new_uint_constant(ctx, field_offset, &var->loc))) - return; - list_add_after(&load->node.entry, &offset->node.entry); + if (type->type == HLSL_CLASS_MATRIX) + { + if (!(c = hlsl_new_uint_constant(ctx, i, &var->loc))) + return; + list_add_after(&load->node.entry, &c->node.entry); - if (!(store = hlsl_new_store(ctx, var, &offset->node, &load->node, 0, var->loc))) - return; - list_add_after(&offset->node.entry, &store->node.entry); + if (!(store = hlsl_new_store_index(ctx, &lhs->src, &c->node, &load->node, 0, var->loc))) + return; + list_add_after(&c->node.entry, &store->node.entry); + } + else + { + if (!(store = hlsl_new_store_index(ctx, &lhs->src, NULL, &load->node, 0, var->loc))) + return; + list_add_after(&load->node.entry, &store->node.entry); + } + } } -static void prepend_input_struct_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_var *var, - struct hlsl_type *type, unsigned int field_offset) +static void prepend_input_struct_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_load *lhs, + struct hlsl_type *type) { + struct hlsl_ir_var *var = lhs->src.var; size_t i; for (i = 0; i < type->e.record.field_count; ++i) { const struct hlsl_struct_field *field = &type->e.record.fields[i]; + struct hlsl_ir_load *field_load; + struct hlsl_ir_constant *c; + + if (!(c = hlsl_new_uint_constant(ctx, i, &var->loc))) + return; + list_add_after(&lhs->node.entry, &c->node.entry); + + if (!(field_load = hlsl_new_load_index(ctx, &lhs->src, &c->node, var->loc))) + return; + list_add_after(&c->node.entry, &field_load->node.entry); if (field->type->type == HLSL_CLASS_STRUCT) - prepend_input_struct_copy(ctx, instrs, var, field->type, field_offset + field->reg_offset); + prepend_input_struct_copy(ctx, instrs, field_load, field->type); else if (field->semantic.name) - prepend_input_copy(ctx, instrs, var, field->type, - field_offset + field->reg_offset, field->modifiers, &field->semantic); + prepend_input_copy(ctx, instrs, field_load, field->type, field->modifiers, &field->semantic); else hlsl_error(ctx, &field->loc, VKD3D_SHADER_ERROR_HLSL_MISSING_SEMANTIC, "Field '%s' is missing a semantic.", field->name); @@ -302,65 +316,85 @@ static void prepend_input_struct_copy(struct hlsl_ctx *ctx, struct list *instrs, * and copy the former to the latter, so that writes to input variables work. */ static void prepend_input_var_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_var *var) { + struct hlsl_ir_load *load; + + if (!(load = hlsl_new_var_load(ctx, var, var->loc))) + return; + list_add_head(instrs, &load->node.entry); + if (var->data_type->type == HLSL_CLASS_STRUCT) - prepend_input_struct_copy(ctx, instrs, var, var->data_type, 0); + prepend_input_struct_copy(ctx, instrs, load, var->data_type); else if (var->semantic.name) - prepend_input_copy(ctx, instrs, var, var->data_type, 0, var->modifiers, &var->semantic); + prepend_input_copy(ctx, instrs, load, var->data_type, var->modifiers, &var->semantic); } -static void append_output_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_var *var, - struct hlsl_type *type, unsigned int field_offset, unsigned int modifiers, const struct hlsl_semantic *semantic) +static void append_output_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_load *rhs, + struct hlsl_type *type, unsigned int modifiers, const struct hlsl_semantic *semantic) { - struct hlsl_ir_constant *offset; - struct hlsl_ir_store *store; - struct hlsl_ir_var *output; - struct hlsl_ir_load *load; + struct hlsl_type *vector_type = hlsl_get_vector_type(ctx, type->base_type, hlsl_type_minor_size(type)); + struct hlsl_ir_var *var = rhs->src.var; + unsigned int i; - if (type->type == HLSL_CLASS_MATRIX) + for (i = 0; i < hlsl_type_major_size(type); ++i) { - struct hlsl_type *vector_type = hlsl_get_vector_type(ctx, type->base_type, hlsl_type_minor_size(type)); - struct hlsl_semantic vector_semantic = *semantic; - unsigned int i; - - for (i = 0; i < hlsl_type_major_size(type); ++i) - { - append_output_copy(ctx, instrs, var, vector_type, 4 * i, modifiers, &vector_semantic); - ++vector_semantic.index; - } + struct hlsl_semantic semantic_copy = *semantic; + struct hlsl_ir_store *store; + struct hlsl_ir_constant *c; + struct hlsl_ir_var *output; + struct hlsl_ir_load *load; - return; - } + semantic_copy.index = semantic->index + i; - if (!(output = add_extern_var(ctx, var, type, modifiers, semantic, true))) - return; + if (!(output = add_extern_var(ctx, var, vector_type, modifiers, &semantic_copy, true))) + return; - if (!(offset = hlsl_new_uint_constant(ctx, field_offset, &var->loc))) - return; - list_add_tail(instrs, &offset->node.entry); + if (type->type == HLSL_CLASS_MATRIX) + { + if (!(c = hlsl_new_uint_constant(ctx, i, &var->loc))) + return; + list_add_tail(instrs, &c->node.entry); - if (!(load = hlsl_new_load(ctx, var, &offset->node, type, var->loc))) - return; - list_add_after(&offset->node.entry, &load->node.entry); + if (!(load = hlsl_new_load_index(ctx, &rhs->src, &c->node, var->loc))) + return; + list_add_tail(instrs, &load->node.entry); + } + else + { + if (!(load = hlsl_new_load_index(ctx, &rhs->src, NULL, var->loc))) + return; + list_add_tail(instrs, &load->node.entry); + } - if (!(store = hlsl_new_store(ctx, output, NULL, &load->node, 0, var->loc))) - return; - list_add_after(&load->node.entry, &store->node.entry); + if (!(store = hlsl_new_simple_store(ctx, output, &load->node))) + return; + list_add_tail(instrs, &store->node.entry); + } } -static void append_output_struct_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_var *var, - struct hlsl_type *type, unsigned int field_offset) +static void append_output_struct_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_load *rhs, + struct hlsl_type *type) { + struct hlsl_ir_var *var = rhs->src.var; size_t i; for (i = 0; i < type->e.record.field_count; ++i) { const struct hlsl_struct_field *field = &type->e.record.fields[i]; + struct hlsl_ir_load *field_load; + struct hlsl_ir_constant *c; + + if (!(c = hlsl_new_uint_constant(ctx, i, &var->loc))) + return; + list_add_tail(instrs, &c->node.entry); + + if (!(field_load = hlsl_new_load_index(ctx, &rhs->src, &c->node, var->loc))) + return; + list_add_tail(instrs, &field_load->node.entry); if (field->type->type == HLSL_CLASS_STRUCT) - append_output_struct_copy(ctx, instrs, var, field->type, field_offset + field->reg_offset); + append_output_struct_copy(ctx, instrs, field_load, field->type); else if (field->semantic.name) - append_output_copy(ctx, instrs, var, field->type, - field_offset + field->reg_offset, field->modifiers, &field->semantic); + append_output_copy(ctx, instrs, field_load, field->type, field->modifiers, &field->semantic); else hlsl_error(ctx, &field->loc, VKD3D_SHADER_ERROR_HLSL_MISSING_SEMANTIC, "Field '%s' is missing a semantic.", field->name); @@ -372,10 +406,16 @@ static void append_output_struct_copy(struct hlsl_ctx *ctx, struct list *instrs, * variables work. */ static void append_output_var_copy(struct hlsl_ctx *ctx, struct list *instrs, struct hlsl_ir_var *var) { + struct hlsl_ir_load *load; + + if (!(load = hlsl_new_var_load(ctx, var, var->loc))) + return; + list_add_tail(instrs, &load->node.entry); + if (var->data_type->type == HLSL_CLASS_STRUCT) - append_output_struct_copy(ctx, instrs, var, var->data_type, 0); + append_output_struct_copy(ctx, instrs, load, var->data_type); else if (var->semantic.name) - append_output_copy(ctx, instrs, var, var->data_type, 0, var->modifiers, &var->semantic); + append_output_copy(ctx, instrs, load, var->data_type, var->modifiers, &var->semantic); } static bool transform_ir(struct hlsl_ctx *ctx, bool (*func)(struct hlsl_ctx *ctx, struct hlsl_ir_node *, void *), @@ -2029,8 +2069,6 @@ int hlsl_emit_bytecode(struct hlsl_ctx *ctx, struct hlsl_ir_function_decl *entry list_move_head(&body->instrs, &ctx->static_initializers); - transform_ir(ctx, transform_deref_paths_into_offsets, body, NULL); /* TODO: move forward, remove when no longer needed */ - LIST_FOR_EACH_ENTRY(var, &ctx->globals->vars, struct hlsl_ir_var, scope_entry) { if (var->modifiers & HLSL_STORAGE_UNIFORM) @@ -2064,6 +2102,8 @@ int hlsl_emit_bytecode(struct hlsl_ctx *ctx, struct hlsl_ir_function_decl *entry append_output_var_copy(ctx, &body->instrs, entry_func->return_var); } + transform_ir(ctx, transform_deref_paths_into_offsets, body, NULL); /* TODO: move forward, remove when no longer needed */ + transform_ir(ctx, lower_broadcasts, body, NULL); while (transform_ir(ctx, fold_redundant_casts, body, NULL)); do -- 2.34.1

2 2

Re: [PATCH v2 4/5] ntdll: Fixup ICMP packet id if SOCK_DGRAM fallback is used.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119060 Your paranoid android. === build (build log) === error: patch failed: dlls/ntdll/unix/socket.c:675 error: patch failed: dlls/ntdll/unix/socket.c:581 Task: Patch failed to apply

1 0

[PATCH vkd3d 09/12] vkd3d-shader/hlsl: Move hlsl_new_offset_from_path_index() to hlsl_codegen.c.
by Francisco Casas 14 Jul '22

14 Jul '22

This can be done now, to help removing register offsets from hlsl.c and hlsl.h. Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com> --- libs/vkd3d-shader/hlsl.c | 76 ------------------------------- libs/vkd3d-shader/hlsl.h | 3 -- libs/vkd3d-shader/hlsl_codegen.c | 77 ++++++++++++++++++++++++++++++++ 3 files changed, 77 insertions(+), 79 deletions(-) diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c index 924121f0..3454e5ee 100644 --- a/libs/vkd3d-shader/hlsl.c +++ b/libs/vkd3d-shader/hlsl.c @@ -392,82 +392,6 @@ struct hlsl_type *hlsl_get_type_from_path_index(struct hlsl_ctx *ctx, const stru return NULL; } -struct hlsl_ir_node *hlsl_new_offset_from_path_index(struct hlsl_ctx *ctx, struct hlsl_block *block, - struct hlsl_type *type, struct hlsl_ir_node *offset, struct hlsl_ir_node *idx, - const struct vkd3d_shader_location *loc) -{ - struct hlsl_ir_node *idx_offset = NULL; - struct hlsl_ir_constant *c; - - list_init(&block->instrs); - - switch (type->type) - { - case HLSL_CLASS_VECTOR: - { - idx_offset = idx; - break; - } - - case HLSL_CLASS_MATRIX: - { - if (!(c = hlsl_new_uint_constant(ctx, 4, loc))) - return NULL; - list_add_tail(&block->instrs, &c->node.entry); - - if (!(idx_offset = hlsl_new_binary_expr(ctx, HLSL_OP2_MUL, &c->node, idx))) - return NULL; - list_add_tail(&block->instrs, &idx_offset->entry); - - break; - } - - case HLSL_CLASS_ARRAY: - { - unsigned int size = hlsl_type_get_array_element_reg_size(type->e.array.type); - - if (!(c = hlsl_new_uint_constant(ctx, size, loc))) - return NULL; - list_add_tail(&block->instrs, &c->node.entry); - - if (!(idx_offset = hlsl_new_binary_expr(ctx, HLSL_OP2_MUL, &c->node, idx))) - return NULL; - list_add_tail(&block->instrs, &idx_offset->entry); - - break; - } - - case HLSL_CLASS_STRUCT: - { - unsigned int field_i = hlsl_ir_constant(idx)->value[0].u; - struct hlsl_struct_field *field = &type->e.record.fields[field_i]; - - if (!(c = hlsl_new_uint_constant(ctx, field->reg_offset, loc))) - return NULL; - list_add_tail(&block->instrs, &c->node.entry); - - idx_offset = &c->node; - - break; - } - - default: - { - assert(0); - return NULL; - } - } - - if (offset) - { - if (!(idx_offset = hlsl_new_binary_expr(ctx, HLSL_OP2_ADD, offset, idx_offset))) - return NULL; - list_add_tail(&block->instrs, &idx_offset->entry); - } - - return idx_offset; -} - struct hlsl_type *hlsl_new_array_type(struct hlsl_ctx *ctx, struct hlsl_type *basic_type, unsigned int array_size) { struct hlsl_type *type; diff --git a/libs/vkd3d-shader/hlsl.h b/libs/vkd3d-shader/hlsl.h index d3885540..dd5ea1d7 100644 --- a/libs/vkd3d-shader/hlsl.h +++ b/libs/vkd3d-shader/hlsl.h @@ -737,9 +737,6 @@ struct hlsl_ir_var *hlsl_get_var(struct hlsl_scope *scope, const char *name); struct hlsl_type *hlsl_get_type_from_path_index(struct hlsl_ctx *ctx, const struct hlsl_type *type, struct hlsl_ir_node *node); -struct hlsl_ir_node *hlsl_new_offset_from_path_index(struct hlsl_ctx *ctx, struct hlsl_block *block, - struct hlsl_type *type, struct hlsl_ir_node *offset, struct hlsl_ir_node *idx, - const struct vkd3d_shader_location *loc); struct hlsl_type *hlsl_new_array_type(struct hlsl_ctx *ctx, struct hlsl_type *basic_type, unsigned int array_size); struct hlsl_ir_node *hlsl_new_binary_expr(struct hlsl_ctx *ctx, enum hlsl_ir_expr_op op, struct hlsl_ir_node *arg1, diff --git a/libs/vkd3d-shader/hlsl_codegen.c b/libs/vkd3d-shader/hlsl_codegen.c index 513e599e..67229195 100644 --- a/libs/vkd3d-shader/hlsl_codegen.c +++ b/libs/vkd3d-shader/hlsl_codegen.c @@ -21,6 +21,83 @@ #include "hlsl.h" #include <stdio.h> +/* TODO: remove when no longer needed, only used for replace_deref_path_with_offset() */ +static struct hlsl_ir_node *hlsl_new_offset_from_path_index(struct hlsl_ctx *ctx, struct hlsl_block *block, + struct hlsl_type *type, struct hlsl_ir_node *offset, struct hlsl_ir_node *idx, + const struct vkd3d_shader_location *loc) +{ + struct hlsl_ir_node *idx_offset = NULL; + struct hlsl_ir_constant *c; + + list_init(&block->instrs); + + switch (type->type) + { + case HLSL_CLASS_VECTOR: + { + idx_offset = idx; + break; + } + + case HLSL_CLASS_MATRIX: + { + if (!(c = hlsl_new_uint_constant(ctx, 4, loc))) + return NULL; + list_add_tail(&block->instrs, &c->node.entry); + + if (!(idx_offset = hlsl_new_binary_expr(ctx, HLSL_OP2_MUL, &c->node, idx))) + return NULL; + list_add_tail(&block->instrs, &idx_offset->entry); + + break; + } + + case HLSL_CLASS_ARRAY: + { + unsigned int size = hlsl_type_get_array_element_reg_size(type->e.array.type); + + if (!(c = hlsl_new_uint_constant(ctx, size, loc))) + return NULL; + list_add_tail(&block->instrs, &c->node.entry); + + if (!(idx_offset = hlsl_new_binary_expr(ctx, HLSL_OP2_MUL, &c->node, idx))) + return NULL; + list_add_tail(&block->instrs, &idx_offset->entry); + + break; + } + + case HLSL_CLASS_STRUCT: + { + unsigned int field_i = hlsl_ir_constant(idx)->value[0].u; + struct hlsl_struct_field *field = &type->e.record.fields[field_i]; + + if (!(c = hlsl_new_uint_constant(ctx, field->reg_offset, loc))) + return NULL; + list_add_tail(&block->instrs, &c->node.entry); + + idx_offset = &c->node; + + break; + } + + default: + { + assert(0); + return NULL; + } + } + + if (offset) + { + if (!(idx_offset = hlsl_new_binary_expr(ctx, HLSL_OP2_ADD, offset, idx_offset))) + return NULL; + list_add_tail(&block->instrs, &idx_offset->entry); + } + + return idx_offset; +} + /* TODO: remove when no longer needed, only used for transform_deref_paths_into_offsets() */ static void replace_deref_path_with_offset(struct hlsl_ctx *ctx, struct hlsl_deref *deref, struct hlsl_ir_node *instr) -- 2.34.1

3 5

Re: [PATCH 1/1] shell32: Return stub bitmap in IShellItemImageFactory::GetImage.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119036 Your paranoid android. === w1064 (32 bit report) === shell32: shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w10pro64 (32 bit report) === shell32: shlfolder.c:4967: Test failed: Expected PIDL to be NULL shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w1064v1809 (64 bit report) === shell32: shlfolder.c:4959: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_en_AE_u8 (64 bit report) === shell32: shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) shlfolder.c:4959: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4959: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_ja (64 bit report) === shell32: shlfolder.c:4959: Test failed: MKDIR: expected notification type 8, got: 40000

1 0

Re: [PATCH v3 2/2] win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119031 Your paranoid android. === w1064_tsign (64 bit report) === user32: win.c:10918: Test failed: pos = 014a015e === debian11 (32 bit report) === user32: win.c:8969: Test failed: Unexpected event was delivered === debian11 (32 bit German report) === user32: win.c:8969: Test failed: Unexpected event was delivered === debian11 (32 bit Hindi:India report) === user32: win.c:8969: Test failed: Unexpected event was delivered === debian11 (32 bit Japanese:Japan report) === user32: win.c:8969: Test failed: Unexpected event was delivered === debian11 (32 bit WoW report) === user32: win.c:8969: Test failed: Unexpected event was delivered === debian11 (64 bit WoW report) === user32: win.c:8969: Test failed: Unexpected event was delivered

1 0

Re: [PATCH v3 1/2] user32/tests: Check that message-only windows ignore WS_EX_TOPMOST.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119030 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === user32: win.c:4400: Test failed: message 0200 available === debian11 (32 bit report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Arabic:Morocco report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit German report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit French report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Hebrew:Israel report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Hindi:India report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Japanese:Japan report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit Chinese:China report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (32 bit WoW report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0 === debian11 (64 bit WoW report) === user32: win.c:8961: Test failed: Last error unexpectedly set to 0

1 0

Re: [PATCH v2 1/2] rpcrt4/tests: Add I_RpcBindingInqLocalClientPID() tests.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119010 Your paranoid android. === w1064_tsign (32 bit report) === rpcrt4: server.c:2270: Test failed: RpcBindingFree === w1064_tsign (64 bit report) === rpcrt4: server.c:2270: Test failed: RpcBindingFree === w10pro64_ja (64 bit report) === rpcrt4: 14fc:server: unhandled exception 000006be at 00007FFA40864F69 === w10pro64_zh_CN (64 bit report) === rpcrt4: 2048:server: unhandled exception 000006be at 00007FFD3A124F69

1 0

Re: [PATCH v2 2/2] rpcrt4: Implement I_RpcBindingInqLocalClientPID().
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119011 Your paranoid android. === w8adm (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w1064 (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w1064_tsign (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w10pro64 (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w1064_adm (64 bit report) === rpcrt4: 1ae0:server: unhandled exception 000006be at 00007FFAE69F4F69 === w1064_tsign (64 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w10pro64_en_AE_u8 (64 bit report) === rpcrt4: 0460:server: unhandled exception 000006be at 00007FF99B7B4F69 === w10pro64_zh_CN (64 bit report) === rpcrt4: 16a8:server: unhandled exception 000006be at 00007FFD3A124F69

1 0

Re: [PATCH 1/2] rpcrt4/tests: Add I_RpcBindingInqLocalClientPID() tests.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118991 Your paranoid android. === w1064_tsign (32 bit report) === rpcrt4: server.c:2270: Test failed: RpcBindingFree === w1064 (64 bit report) === rpcrt4: server.c:2270: Test failed: RpcBindingFree === w1064_2qxl (64 bit report) === rpcrt4: server.c:2270: Test failed: RpcBindingFree === w1064_tsign (64 bit report) === rpcrt4: server.c:2270: Test failed: RpcBindingFree === w10pro64 (64 bit report) === rpcrt4: server.c:2270: Test failed: RpcBindingFree === w10pro64_en_AE_u8 (64 bit report) === rpcrt4: 0958:server: unhandled exception 000006be at 00007FF99B7B4F69 === w10pro64_ja (64 bit report) === rpcrt4: 0ef4:server: unhandled exception 000006be at 00007FFA40864F69

1 0

Re: [PATCH 7/7] shell32: Implement SHOpenFolderAndSelectItems().
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118986 Your paranoid android. === w1064v1809 (32 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w1064 (32 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w1064_tsign (32 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w1064v1809 (64 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w1064 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_en_AE_u8 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 4000000 shlfolder.c:4999: Test failed: Expected PIDL to be NULL shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000

1 0

Re: [PATCH 6/7] shell32/tests: Add SHOpenFolderAndSelectItems() tests.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118985 Your paranoid android. === w1064v1809 (32 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w1064 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 4000000 shlfolder.c:4999: Test failed: Expected PIDL to be NULL === w10pro64_en_AE_u8 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ja (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000

1 0

Re: [PATCH v2 6/6] kernelbase: Implement PrefetchVirtualMemory.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118952 Your paranoid android. === debian11 (build log) === error: patch failed: include/winbase.h:1760 error: patch failed: include/winnt.h:788 error: patch failed: include/winternl.h:1993 error: patch failed: tools/winapi/win32.api:3245 error: patch failed: dlls/ntdll/tests/virtual.c:41 error: patch failed: dlls/ntdll/ntdll.spec:388 error: patch failed: dlls/ntdll/unix/loader.c:310 error: patch failed: dlls/wow64/struct32.h:650 error: patch failed: dlls/wow64/syscall.h:211 error: patch failed: dlls/wow64/virtual.c:33 error: patch failed: dlls/kernel32/tests/virtual.c:37 error: patch failed: dlls/kernel32/tests/virtual.c:4231 error: patch failed: dlls/kernelbase/memory.c:415 Task: Patch failed to apply === debian11 (build log) === error: patch failed: include/winbase.h:1760 error: patch failed: include/winnt.h:788 error: patch failed: include/winternl.h:1993 error: patch failed: tools/winapi/win32.api:3245 error: patch failed: dlls/ntdll/tests/virtual.c:41 error: patch failed: dlls/ntdll/ntdll.spec:388 error: patch failed: dlls/ntdll/unix/loader.c:310 error: patch failed: dlls/wow64/struct32.h:650 error: patch failed: dlls/wow64/syscall.h:211 error: patch failed: dlls/wow64/virtual.c:33 error: patch failed: dlls/kernel32/tests/virtual.c:37 error: patch failed: dlls/kernel32/tests/virtual.c:4231 error: patch failed: dlls/kernelbase/memory.c:415 Task: Patch failed to apply

1 0

Re: [PATCH v8 7/7] ntoskrnl: Set device ContainerID from driver
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118939 Your paranoid android. === debian11 (32 bit Hebrew:Israel report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events.

1 0

Re: [PATCH 1/4] ws2_32/tests: Add some tests for NtReadFile() and NtWriteFile() on sockets.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118995 Your paranoid android. === debian11 (32 bit Hebrew:Israel report) === ws2_32: afd.c:2716: Test failed: got size 5

1 0

Re: [PATCH 2/2] rpcrt4: Implement I_RpcBindingInqLocalClientPID().
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118992 Your paranoid android. === w864 (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w1064 (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w1064_tsign (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w10pro64 (32 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w1064_tsign (64 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w10pro64 (64 bit report) === rpcrt4: server.c:2263: Test failed: RpcBindingFree === w10pro64_en_AE_u8 (64 bit report) === rpcrt4: 0e54:server: unhandled exception 000006be at 00007FF99B7B4F69

1 0

Re: [PATCH v8 2/7] ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118934 Your paranoid android. === debian11 (32 bit Hindi:India report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events.

1 0

Re: [PATCH v7 7/7] ntoskrnl: Set device ContainerID from driver
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118932 Your paranoid android. === w7u_2qxl (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 78 === w7u_el (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 78 === w8 (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 78 === w1064_tsign (64 bit report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 78 === debian11 (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 driver_pnp.c:706: Test failed: Got 1 remove events. === debian11 (32 bit Arabic:Morocco report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 === debian11 (32 bit German report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 === debian11 (32 bit French report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 driver_pnp.c:706: Test failed: Got 1 remove events. === debian11 (32 bit Hebrew:Israel report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 === debian11 (32 bit Hindi:India report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 === debian11 (32 bit Japanese:Japan report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 === debian11 (32 bit Chinese:China report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39 === debian11 (64 bit WoW report) === ntoskrnl.exe: ntoskrnl.c:1655: Test failed: got size 39

1 0

Re: [PATCH v7 2/7] ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118927 Your paranoid android. === debian11 (32 bit French report) === ntoskrnl.exe: driver_pnp.c:736: Test failed: expected IRP_MN_REMOVE_DEVICE === debian11 (32 bit Hebrew:Israel report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events. === debian11 (32 bit Hindi:India report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events.

1 0

Re: [PATCH v4 4/5] mshtml: Implement overrideMimeType for XMLHttpRequest.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118924 Your paranoid android. === w7u_adm (32 bit report) === mshtml: script.c:644: Test failed: L"/index.html?es5.js:date_now: unexpected Date.now() result 1657738156862 expected 1657738156925"

1 0

Re: [PATCH 1/1] win32u: Send WM_NCPAINT as notify message in send_ncpaint().
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118970 Your paranoid android. === w1064_2qxl (64 bit report) === user32: win.c:4579: Test failed: hwnd 000000000001024C/000000000001024C message 0200 win.c:4583: Test failed: hwnd 000000000001024C/000000000001024C message 0201 win.c:4592: Test failed: hwnd 00000000001002B8/00000000001002B8 message 0202 win.c:4595: Test failed: hwnd 00000000001002B8/00000000001002B8 message 0201

1 0

Re: [PATCH v4 3/5] mshtml: Check for valid XML Content-Type for responseXML in IE10+ modes.
by Marvin 14 Jul '22

14 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118923 Your paranoid android. === w10pro64 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH v4 2/5] mshtml: Respect LOAD_CALL_CONTENT_SNIFFERS when using detected mime type.
by Marvin 13 Jul '22

13 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118922 Your paranoid android. === w10pro64_ar (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH v3 4/5] mshtml: Implement overrideMimeType for XMLHttpRequest.
by Marvin 13 Jul '22

13 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118919 Your paranoid android. === w10pro64_ja (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE === w10pro64_zh_CN (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE === w7u_adm (32 bit report) === mshtml: script.c:644: Test failed: L"/index.html?es5.js:date_now: unexpected Date.now() result 1657734051954 expected 1657734052016"

1 0

[PATCH 1/5] msvcr120/tests: Add missing newlines to messages.
by Torge Matthies 13 Jul '22

13 Jul '22

Signed-off-by: Torge Matthies <tmatthies(a)codeweavers.com> --- dlls/msvcr120/tests/msvcr120.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcr120/tests/msvcr120.c b/dlls/msvcr120/tests/msvcr120.c index 88a32b382ef..ac35076af03 100644 --- a/dlls/msvcr120/tests/msvcr120.c +++ b/dlls/msvcr120/tests/msvcr120.c @@ -1375,7 +1375,7 @@ static void __cdecl chore_proc(_UnrealizedChore *_this) MSVCRT_bool canceling = call_func1( p__StructuredTaskCollection__IsCanceling, chore->chore.task_collection); - ok(!canceling, "Task is already canceling"); + ok(!canceling, "Task is already canceling\n"); } if (!chore->wait_event) @@ -1399,7 +1399,7 @@ static void __cdecl chore_proc(_UnrealizedChore *_this) MSVCRT_bool canceling = call_func1( p__StructuredTaskCollection__IsCanceling, chore->chore.task_collection); - ok(canceling, "Task is not canceling"); + ok(canceling, "Task is not canceling\n"); } } -- 2.37.0

3 9

Building with MSVC
by Gisle Vanem 13 Jul '22

13 Jul '22

Hello list. My first post here. First off, I'm not using Linux and does not want to. I'm on Win-10 and would (just for fun) try to build e.g. Wine's 'explorer.exe' and other tool using MSVC-2022 and/or clang-cl v.13. I see that the sources are full of '_MSC_VER' and assume it would be possible. I've built all 'tools/' program just fine with a set of home-brewed GNU-makefiles. But have some problems with missing symbols during link. For example these: _NtUserMessageCall@28 _DrawCaptionTempW@28 MSDN came up blank for these. But I see that 'NtUserMessageCall@28' is exported from my normal 'win32u.dll' on Win-10. But there's no entry for them in any Win-Kit library AFAICS. So are we supposed to use Wine's 'win32u.dll' as a trampoline to the real and undocumented functions? Then there is 'DrawCaptionTempW'. I find no prototype for it in the Win-Kit SDK. But I find it in TDM-MinGW's 'libuser32.a'. Ref: https://gist.github.com/wbenny/123a41973af776df9c7d5610586b9e9d I've read the FAQ so I'm not sure my effort is supported at all. Or if some MinGW-distro is required. -- --gv

2 2

Re: [PATCH v6 7/7] ntoskrnl: Set device ContainerID from driver
by Marvin 13 Jul '22

13 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118911 Your paranoid android. === w7u_2qxl (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w7u_el (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w8 (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w1064_tsign (64 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{"

1 0

Re: [PATCH v6 2/7] ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver
by Marvin 13 Jul '22

13 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118906 Your paranoid android. === debian11 (32 bit report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events.

1 0

Re: [PATCH 2/2] ddraw/tests: Build ddraw7.c without -DWINE_NO_LONG_TYPES.
by Marvin 13 Jul '22

13 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118887 Your paranoid android. === w8adm (32 bit report) === ddraw: ddraw7.c:18840: Test failed: Got unexpected color 0x00000040.

1 0

[PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Paul Gofman (＠gofman) 13 Jul '22

13 Jul '22

ICMP over SOCK_DGRAM is already used in ndispproxy.sys. But apps may also use ICMP directly over SOCK_RAW (Hardspace: Shipbreaker is an example) and that requires admin privileges on Linux (or setcap cap_net_raw+ep on wineserver). AF_INET / SOCK_RAW / IPPROTO_ICMP works on Windows without admin privileges. Comments: - IP, ICMP header structures and chksum() functions are taken from ndisproxy.sys:icmp_echo.c; - ICMP over DGRAM, while designed specifically to allow ICMP without admin permissions, still needs some setup Linux, /proc/sys/net/ipv4/ping_group_range controls that. Such socket creation fails on Testbot Debian machines so I left skip() path in test_icmp(); - Linux substitute local port number instead of provided ICMP packet id, while the referenced game depends on reply id matching the id it provided in request. So the last part performs the fixup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384

6 14

Re: [PATCH v5 7/8] ntoskrnl: Set device ContainerID from driver
by Marvin 12 Jul '22

12 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118863 Your paranoid android. === w7u_2qxl (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w7u_el (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w8 (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w1064_tsign (64 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === debian11 (32 bit Hebrew:Israel report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events. === debian11 (32 bit Hindi:India report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events.

1 0

Re: [PATCH v4 9/9] ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver
by Marvin 12 Jul '22

12 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118840 Your paranoid android. === w7u_2qxl (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w7u_el (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === w8 (32 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" ntoskrnl.c:1702: Test failed: got 0 child removal messages ntoskrnl.c:1719: Test failed: got 0 child removal messages === w1064_tsign (64 bit report) === ntoskrnl.exe: ntoskrnl.c:1654: Test failed: got size 78 ntoskrnl.c:1655: Test failed: got container ID "{" === debian11 (32 bit Hebrew:Israel report) === ntoskrnl.exe: driver_pnp.c:706: Test failed: Got 1 remove events.

1 0

Re: [PATCH v2 3/5] mshtml: Check for valid XML Content-Type for responseXML in IE10+ modes.
by Marvin 12 Jul '22

12 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=118824 Your paranoid android. === w10pro64 (32 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel