- wine-devel - winehq.org

Re: CommandLineToArgvW fix
by Uwe Bonnes 15 Oct '02

15 Oct '02

>>>>> "steve" == steve lustbader <steve.lustbader(a)philips.com> writes: steve> ChangeLog: - fix off-by-one error in determining number of steve> arguments Writing a test case for our test suite for such problems is a good idea. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: PATCH: dlls/comctl32/listview.c
by Dimitrie O. Paun 14 Oct '02

14 Oct '02

On October 14, 2002 04:09 pm, Gerald Pfeifer wrote: > ChangeLog: > Avoid GCC-specific language extension. This is fixed in my latest patch. -- Dimi.

1 0

RE: PATCH: dlls/comctl32/listview.c
by Patrik Stridvall 14 Oct '02

14 Oct '02

> On Mon, Oct 14, 2002 at 10:09:12PM +0200, Gerald Pfeifer wrote: > > This is not ANSI/ISO C as far as I (and current GCC) know, so I hope > > this straightforward fix is fine. > > > > Gerald > > > > ChangeLog: > > Avoid GCC-specific language extension. > > > > Index: listview.c > > =================================================================== > > RCS file: /home/wine/wine/dlls/comctl32/listview.c,v > > retrieving revision 1.224 > > diff -u -3 -p -r1.224 listview.c > > --- listview.c 11 Oct 2002 23:34:32 -0000 1.224 > > +++ listview.c 14 Oct 2002 20:04:57 -0000 > > @@ -4467,6 +4467,7 @@ static LRESULT LISTVIEW_GetColumnWidth(L > > break; > > default: > > /* we don't have a 'column' in [SMALL]ICON mode */ > > + ; > Warum nicht einfach ein break; ? Sieht irgendwie "korrekter" aus... [Since when did we become a german speaking list? :-) I CAN read german to some extent but still...] Because its (1) 5 characters shorter (2) Some compilers generate better code. An unnessary "branch" might be generated. But sure, semantically it is not different (providing of course the default is LAST of course). Anyway, I don't really care either way. Do as you wish.

1 0

Re: PATCH: dlls/comctl32/listview.c
by Andreas Mohr 14 Oct '02

14 Oct '02

On Mon, Oct 14, 2002 at 10:09:12PM +0200, Gerald Pfeifer wrote: > This is not ANSI/ISO C as far as I (and current GCC) know, so I hope > this straightforward fix is fine. > > Gerald > > ChangeLog: > Avoid GCC-specific language extension. > > Index: listview.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/listview.c,v > retrieving revision 1.224 > diff -u -3 -p -r1.224 listview.c > --- listview.c 11 Oct 2002 23:34:32 -0000 1.224 > +++ listview.c 14 Oct 2002 20:04:57 -0000 > @@ -4467,6 +4467,7 @@ static LRESULT LISTVIEW_GetColumnWidth(L > break; > default: > /* we don't have a 'column' in [SMALL]ICON mode */ > + ; Warum nicht einfach ein break; ? Sieht irgendwie "korrekter" aus...

1 0

Re: Fixed garbage in toolbar buttons
by Dimitrie O. Paun 14 Oct '02

14 Oct '02

On October 13, 2002 12:57 pm, Carlos wrote: > Changelog: > * Changed SRCPAINT to SRCCOPY, the first time what > it paints in hImageDC. > } else if (himl->hbmMask) { > BitBlt( hImageDC, 0, 0, cx, cy, hMaskListDC, lx, ly, SRCAND ); > - BitBlt( hImageDC, 0, 0, cx, cy, hImageListDC, lx, ly, SRCPAINT ); > + if (!bIsTransparent && himl->hbmMask) { > + BitBlt( hImageDC, 0, 0, cx, cy, hImageListDC, lx, ly, SRCPAINT ); > + } else { > + BitBlt( hImageDC, 0, 0, cx, cy, hImageListDC, lx, ly, SRCCOPY ); > + } This can not be right. It is equivalent to: PatBlt( hImageDC, 0, 0, cx, cy, PATCOPY); SelectObject(hImageDC, hOldBrush); } - } else if (himl->hbmMask) { + } else if (himl->hbmMask && !(fStyle & ILD_TRANSPARENT) && clrBk != CLR_NONE) { BitBlt( hImageDC, 0, 0, cx, cy, hMaskListDC, lx, ly, SRCAND ); BitBlt( hImageDC, 0, 0, cx, cy, hImageListDC, lx, ly, SRCPAINT ); } else { /* the image is opaque, just copy it */ TRACE(" - Image is opaque\n"); BitBlt( hImageDC, 0, 0, cx, cy, hImageListDC, lx, ly, SRCCOPY); } That is, if we have ILD_TRANSPARENT set, or clrBk == CLR_NONE, we go the SRCCOPY route, ignoring the mask, which is just the opposite of what we need to do! Alexandre, please do not apply it. -- Dimi.

3 3

Re: Changes in dlls/urlmon/umon.c
by Dimitrie O. Paun 14 Oct '02

14 Oct '02

On October 13, 2002 08:34 am, Carlos wrote: > Changelog: > * dlls/urlmon/umon.c > Changed some calls from W to A type. Please don't do that. Better implement the W functions in wininet. -- Dimi.

1 0

Re: alsa driver configuration
by Sylvain Petreolle 14 Oct '02

14 Oct '02

Set "Drivers=winealsa.drv" at section [WinMM]. Documentation is outdated about this. Developers : Whats's needeed to edit sgml files ? --- "Gabriel A. Arcos A." <gabrielarcos(a)cantv.net> a écrit : > Hi all !! I have intalled wine-20021007 and I want to use the alsa > driver on it. I have search all the documentation but I have not > found > any info. there are something to change in the ~/.wine/conf file? I'm > trying to play Counter Strike but I can't ( I have installed > propertly > the opengl stuff in compilation time of wine). > > thanks in advance. Gabriel Arcos. > > > > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.com > http://www.winehq.com/mailman/listinfo/wine-users ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

3 3

Re: Fix disabled toolbar button actions
by Duane Clark 13 Oct '02

13 Oct '02

Carlos wrote: > Hello, > > Testing 12zip.exe, found that you can click in a > toolbar button what is disabled, and it shows a window. > The next patch fixes the problem, please if someone > is working in the toolbar code, check if it is a correct fix. > > Changelog: > * Fix disabled toolbar button actions. On one of my apps, fpga_editor, this completely breaks the main toolbar. The active buttons no longer work at all. Oddly enough, this app has a popup window with it's own toolbar. The buttons on this window have always appeared to be disabled, even though only some of them should be. But despite their appearance, the buttons work correctly, both before and after this patch.

1 0

Compilation errors
by Shachar Shemesh 13 Oct '02

13 Oct '02

make[2]: Entering directory `/home/sun/sources/wine/wine/dlls/d3d8' ../../tools/makedep -I. -I. -I../../include -I../../include -I/usr/X11R6/include -C. basetexture.c cubetexture.c d3d8_main.c device.c directx.c indexbuffer.c resource.c surface.c swapchain.c texture.c vertexbuffer.c volume.c volumetexture.c math.h: No such file or directory math.h was first included from device.c:26 make[2]: *** [depend] Error 1 make[2]: Leaving directory `/home/sun/sources/wine/wine/dlls/d3d8' make[1]: *** [d3d8/__depend__] Error 2 make[1]: Leaving directory `/home/sun/sources/wine/wine/dlls' make: *** [dlls/__depend__] Error 2 The strange thing is that /usr/include/math.h exists, and seems ok. Then again, it does not appear to be in the include path provided for the command. Explanations? Shachar

5 5

Changes in Bitmap behaviour
by Uwe Bonnes 13 Oct '02

13 Oct '02

Hallo, Xilinx webpack 4.2 running with native Common Controls shows an artefact in the display of bitmaps associated with the listview widget. This behaviour changed with http://cvs.winehq.com/patch.py?id=5720 by Michael Stefaniuc <mstefani(a)redhat.de>, but still is not right. Appended I have jpegs of the error. The first file (comctl32-builtin.jpeg) shows the behaviour with builtin commctl32, which looks good. The second file (comctl32-native-prepatch.jpeg) shows the behaviour with todays cvs, Michael's patch reversed and native comctl32/commctrl (NT4). We get a discontinous black background of the bitmap The last file (comctl32-native-prepatch.jpeg) is with native comctl32/commctrl (NT4) and todays unmodified cvs version. No we have a all black background. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

4 9

OpenGL textures are wrong under HalfLife
by David D. Hagood 13 Oct '02

13 Oct '02

My old motherboard died, and so I upgraded from a single P3 to a dual P3 system. I went to run HalfLife, which had been running beautifully under Wine, and now all the wall textures are screwed up. There is nothing of the proper textures in them - it's not like the colors are screwed up, more like the actual data is screwed up. However, it IS consistent from run to run - the same patterns on the same vertexes each time. The various "humans" in the level are fine - it is just the environment that is screwed. This is running the OpenGL setting in HL - I thought I'd try the DirectX setting, but all I get there is "This is not supported by your card". Now, I have upgraded XFree to the latest CVS pull, I rebuilt my kernel, and upgraded Wine, so it COULD be any of the above. However, I pulled an older version of Wine from another machine with the same results. Native GL programs like Q3A, RTCW, and UT all look fine, so the native GL layer is running well. Could this be an artifact of SMP? Or is there something that Wine does differently in accessing the GL libraries from a native app that would explain this?

1 0

Re: wine/dlls/avifil32: implemented many functions
by Dmitry Timoshkov 13 Oct '02

13 Oct '02

"Michael GЭnnewig" <MichaelGuennewig(a)gmx.de> wrote: > + LPWSTR szExt = strrchrW(szFile, L'.'); > +#define SLASH(w) ((w) == L'/' || (w) == L'\\') As were discussed many times using L prefix in order to create unicode chars/strings is wrong due to difference in size of unicode characters between windows and unix (2 vs. 4). We forced to create unicode strings explicitly: static const WCHAR fooW[] = { 'f','o','o',0 }; static const WCHAR dotW[] = { '.',0 }; static const WCHAR slashW[] = { '/',0 }; static const WCHAR bkslashW[] = { '\\',0 }; That's somewhat ugly and awkward, but it's really needed for portability. -- Dmitry.

4 5

help! latest cvs build of wine crashes every time
by Graham Stoney 13 Oct '02

13 Oct '02

Hi winers, I've built the latest cvs version of wine on my Debian stable system, and it crashes every time I run it. Here's an example: greyham@fred:/tmp$ wine notepad wine: Unhandled exception, starting debugger... wine: Unhandled exception, starting debugger... wine: Unhandled exception, starting debugger... (messages continue indefinitely; the debugger never gets started) It appears to be dying in X11DRV_CreateDC at the call to wine_tsx11_lock; but I suspect this is due to a stack frame corruption. Here's a gdb backtrace at the point of failure: 121 wine_tsx11_lock(); (gdb) where #0 X11DRV_CreateDC (dc=0x40393e48, pdev=0x40393e5c, driver=0x406c2c20 "DISPLAY", device=0x0, output=0x0, initData=0x0) at ../../graphics/x11drv/init.c:121 #1 0x40a72ff9 in CreateDCA (driver=0x409e19a0 "DISPLAY", device=0x0, output=0x0, initData=0x0) at ../../objects/dc.c:586 #2 0x409a622b in SYSMETRICS_Init () at ../../windows/sysmetrics.c:119 #3 0x409cf5aa in process_attach () at user_main.c:229 #4 0x409cf725 in UserClientDllInitialize (inst=1083441152, reason=1, reserved=0x1) at user_main.c:327 #5 0x40088e9f in PE_InitDLL (module=1083441152, type=1, lpReserved=0x1) at ../../loader/pe_image.c:628 #6 0x40085a6b in MODULE_InitDLL (wm=0x403718e8, type=1, lpReserved=0x1) at ../../loader/module.c:157 #7 0x40085b89 in MODULE_DllProcessAttach (wm=0x403718e8, lpReserved=0x1) at ../../loader/module.c:228 #8 0x40085b65 in MODULE_DllProcessAttach (wm=0x40371518, lpReserved=0x1) at ../../loader/module.c:223 #9 0x40085b65 in MODULE_DllProcessAttach (wm=0x40371288, lpReserved=0x1) at ../../loader/module.c:223 #10 0x40085b65 in MODULE_DllProcessAttach (wm=0x40370ff8, lpReserved=0x1) at ../../loader/module.c:223 #11 0x40085b65 in MODULE_DllProcessAttach (wm=0x0, lpReserved=0x1) at ../../loader/module.c:223 #12 0x400bd088 in start_process () at ../../scheduler/process.c:540 #13 0x400c128d in call_on_thread_stack (func=0x400bcef4) at ../../scheduler/sysdeps.c:112 (gdb) s Program received signal SIGSEGV, Segmentation fault. 0x53e58955 in ?? () Other apps fair as badly; always crashing on startup. I'm running XF86 version 4.2; there must be something about my system that is triggering the failure; otherwise you guys would be hitting it all the time. Any hints where I should start looking? Thanks, Graham

3 4

Re: Listview N5
by Dimitrie O. Paun 13 Oct '02

13 Oct '02

If you haven't checked in N5, please ignore it. I'll resubmit it when I move all of the custom draw around. -- Dimi.

2 2

Re: 16 shell seperation
by Michael Stefaniuc 12 Oct '02

12 Oct '02

You forgot to do the right HKEY <--> HKEY16 conversions with HKEY_16() and HKEY_32(), examples how to do it should be in the code. bye michael On Sat, Oct 12, 2002 at 05:20:31PM -0000, György 'Nog' Jeney wrote: > Is it possible to move all of the resources in the shell32 directory to a > sub directory inside shell32 like resources (just like gdi)? Its quite > confusing the way it is now. > > Changelog: > * dlls/shell32/shell32_main.h > * dlls/shell32/shell.c > * dlls/shell32/shellreg.c > * dlls/shell32/Makefile.in > * dlls/shell32/shlexec.c > Seperate out 16-bit funvtions into seperate file. > > nog. > > Index: dlls/shell32/shell.c > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/shell.c,v > retrieving revision 1.46 > diff -u -r1.46 shell.c > --- dlls/shell32/shell.c 10 Oct 2002 21:22:11 -0000 1.46 > +++ dlls/shell32/shell.c 12 Oct 2002 17:07:39 -0000 > @@ -2,6 +2,7 @@ > * Shell Library Functions > * > * Copyright 1998 Marcus Meissner > + * Copyright 2000 Juergen Schmied > * Copyright 2002 Eric Pouech > * > * This library is free software; you can redistribute it and/or > @@ -526,4 +527,115 @@ > break; > } > return ret; > +} > + > + > +/* 0 and 1 are valid rootkeys in win16 shell.dll and are used by > + * some programs. Do not remove those cases. -MM > + */ > +static inline void fix_win16_hkey( HKEY *hkey ) > +{ > + if (*hkey == 0 || *hkey == (HKEY)1) *hkey = HKEY_CLASSES_ROOT; > +} > + > +/****************************************************************************** > + * RegOpenKey [SHELL.1] > + */ > +DWORD WINAPI RegOpenKey16( HKEY hkey, LPCSTR name, PHKEY retkey ) > +{ > + fix_win16_hkey( &hkey ); > + return RegOpenKeyA( hkey, name, retkey ); > +} > + > +/****************************************************************************** > + * RegCreateKey [SHELL.2] > + */ > +DWORD WINAPI RegCreateKey16( HKEY hkey, LPCSTR name, PHKEY retkey ) > +{ > + fix_win16_hkey( &hkey ); > + return RegCreateKeyA( hkey, name, retkey ); > +} > + > +/****************************************************************************** > + * RegCloseKey [SHELL.3] > + */ > +DWORD WINAPI RegCloseKey16( HKEY hkey ) > +{ > + fix_win16_hkey( &hkey ); > + return RegCloseKey( hkey ); > +} > + > +/****************************************************************************** > + * RegDeleteKey [SHELL.4] > + */ > +DWORD WINAPI RegDeleteKey16( HKEY hkey, LPCSTR name ) > +{ > + fix_win16_hkey( &hkey ); > + return RegDeleteKeyA( hkey, name ); > +} > + > +/****************************************************************************** > + * RegSetValue [SHELL.5] > + */ > +DWORD WINAPI RegSetValue16( HKEY hkey, LPCSTR name, DWORD type, LPCSTR data, DWORD count ) > +{ > + fix_win16_hkey( &hkey ); > + return RegSetValueA( hkey, name, type, data, count ); > +} > + > +/****************************************************************************** > + * RegQueryValue [SHELL.6] > + * > + * NOTES > + * Is this HACK still applicable? > + * > + * HACK > + * The 16bit RegQueryValue doesn't handle selectorblocks anyway, so we just > + * mask out the high 16 bit. This (not so much incidently) hopefully fixes > + * Aldus FH4) > + */ > +DWORD WINAPI RegQueryValue16( HKEY hkey, LPCSTR name, LPSTR data, LPDWORD count > +) > +{ > + fix_win16_hkey( &hkey ); > + if (count) *count &= 0xffff; > + return RegQueryValueA( hkey, name, data, count ); > +} > + > +/****************************************************************************** > + * RegEnumKey [SHELL.7] > + */ > +DWORD WINAPI RegEnumKey16( HKEY hkey, DWORD index, LPSTR name, DWORD name_len ) > +{ > + fix_win16_hkey( &hkey ); > + return RegEnumKeyA( hkey, index, name, name_len ); > +} > + > + > +/************************************************************************* > + * ShellExecute [SHELL.20] > + */ > +HINSTANCE16 WINAPI ShellExecute16( HWND16 hWnd, LPCSTR lpOperation, > + LPCSTR lpFile, LPCSTR lpParameters, > + LPCSTR lpDirectory, INT16 iShowCmd ) > +{ > + SHELLEXECUTEINFOA sei; > + HANDLE hProcess = 0; > + > + sei.cbSize = sizeof(sei); > + sei.fMask = 0; > + sei.hwnd = HWND_32(hWnd); > + sei.lpVerb = lpOperation; > + sei.lpFile = lpFile; > + sei.lpParameters = lpParameters; > + sei.lpDirectory = lpDirectory; > + sei.nShow = iShowCmd; > + sei.lpIDList = 0; > + sei.lpClass = 0; > + sei.hkeyClass = 0; > + sei.dwHotKey = 0; > + sei.hProcess = hProcess; > + > + ShellExecuteExA32 (&sei, FALSE); > + return (HINSTANCE16)sei.hInstApp; > } > Index: dlls/shell32/Makefile.in > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/Makefile.in,v > retrieving revision 1.53 > diff -u -r1.53 Makefile.in > --- dlls/shell32/Makefile.in 27 Aug 2002 01:34:34 -0000 1.53 > +++ dlls/shell32/Makefile.in 12 Oct 2002 17:07:42 -0000 > @@ -27,7 +27,6 @@ > iconcache.c \ > memorystream.c \ > pidl.c \ > - shell.c \ > shell32_main.c \ > shelllink.c \ > shellole.c \ > @@ -50,6 +49,7 @@ > > RC_SRCS= shres.rc > RC_SRCS16 = version16.rc > +C_SRCS16 = shell.c > > SUBDIRS = tests > > Index: dlls/shell32/shell32_main.h > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/shell32_main.h,v > retrieving revision 1.53 > diff -u -r1.53 shell32_main.h > --- dlls/shell32/shell32_main.h 10 Oct 2002 21:22:11 -0000 1.53 > +++ dlls/shell32/shell32_main.h 12 Oct 2002 17:07:48 -0000 > @@ -202,4 +202,7 @@ > #define HINSTANCE_32(h16) ((HINSTANCE)(ULONG_PTR)(h16)) > #define HWND_32(h16) ((HWND)(ULONG_PTR)(h16)) > > +/* needed by 16-bit shell code in shell.c */ > +BOOL WINAPI ShellExecuteExA32 (LPSHELLEXECUTEINFOA sei, BOOL is32); > + > #endif > Index: dlls/shell32/shellreg.c > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/shellreg.c,v > retrieving revision 1.14 > diff -u -r1.14 shellreg.c > --- dlls/shell32/shellreg.c 3 Oct 2002 19:46:27 -0000 1.14 > +++ dlls/shell32/shellreg.c 12 Oct 2002 17:07:52 -0000 > @@ -147,86 +147,3 @@ > TRACE("0x%04x\n",hkey); > return RegCloseKey( hkey ); > } > - > - > -/* 16-bit functions */ > - > -/* 0 and 1 are valid rootkeys in win16 shell.dll and are used by > - * some programs. Do not remove those cases. -MM > - */ > -static inline void fix_win16_hkey( HKEY *hkey ) > -{ > - if (*hkey == 0 || *hkey == (HKEY)1) *hkey = HKEY_CLASSES_ROOT; > -} > - > -/****************************************************************************** > - * RegOpenKey [SHELL.1] > - */ > -DWORD WINAPI RegOpenKey16( HKEY hkey, LPCSTR name, PHKEY retkey ) > -{ > - fix_win16_hkey( &hkey ); > - return RegOpenKeyA( hkey, name, retkey ); > -} > - > -/****************************************************************************** > - * RegCreateKey [SHELL.2] > - */ > -DWORD WINAPI RegCreateKey16( HKEY hkey, LPCSTR name, PHKEY retkey ) > -{ > - fix_win16_hkey( &hkey ); > - return RegCreateKeyA( hkey, name, retkey ); > -} > - > -/****************************************************************************** > - * RegCloseKey [SHELL.3] > - */ > -DWORD WINAPI RegCloseKey16( HKEY hkey ) > -{ > - fix_win16_hkey( &hkey ); > - return RegCloseKey( hkey ); > -} > - > -/****************************************************************************** > - * RegDeleteKey [SHELL.4] > - */ > -DWORD WINAPI RegDeleteKey16( HKEY hkey, LPCSTR name ) > -{ > - fix_win16_hkey( &hkey ); > - return RegDeleteKeyA( hkey, name ); > -} > - > -/****************************************************************************** > - * RegSetValue [SHELL.5] > - */ > -DWORD WINAPI RegSetValue16( HKEY hkey, LPCSTR name, DWORD type, LPCSTR data, DWORD count ) > -{ > - fix_win16_hkey( &hkey ); > - return RegSetValueA( hkey, name, type, data, count ); > -} > - > -/****************************************************************************** > - * RegQueryValue [SHELL.6] > - * > - * NOTES > - * Is this HACK still applicable? > - * > - * HACK > - * The 16bit RegQueryValue doesn't handle selectorblocks anyway, so we just > - * mask out the high 16 bit. This (not so much incidently) hopefully fixes > - * Aldus FH4) > - */ > -DWORD WINAPI RegQueryValue16( HKEY hkey, LPCSTR name, LPSTR data, LPDWORD count ) > -{ > - fix_win16_hkey( &hkey ); > - if (count) *count &= 0xffff; > - return RegQueryValueA( hkey, name, data, count ); > -} > - > -/****************************************************************************** > - * RegEnumKey [SHELL.7] > - */ > -DWORD WINAPI RegEnumKey16( HKEY hkey, DWORD index, LPSTR name, DWORD name_len ) > -{ > - fix_win16_hkey( &hkey ); > - return RegEnumKeyA( hkey, index, name, name_len ); > -} > Index: dlls/shell32/shlexec.c > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/shlexec.c,v > retrieving revision 1.8 > diff -u -r1.8 shlexec.c > --- dlls/shell32/shlexec.c 16 Sep 2002 19:27:51 -0000 1.8 > +++ dlls/shell32/shlexec.c 12 Oct 2002 17:07:59 -0000 > @@ -673,35 +673,6 @@ > return TRUE; > } > > - > -/************************************************************************* > - * ShellExecute [SHELL.20] > - */ > -HINSTANCE16 WINAPI ShellExecute16( HWND16 hWnd, LPCSTR lpOperation, > - LPCSTR lpFile, LPCSTR lpParameters, > - LPCSTR lpDirectory, INT16 iShowCmd ) > -{ > - SHELLEXECUTEINFOA sei; > - HANDLE hProcess = 0; > - > - sei.cbSize = sizeof(sei); > - sei.fMask = 0; > - sei.hwnd = HWND_32(hWnd); > - sei.lpVerb = lpOperation; > - sei.lpFile = lpFile; > - sei.lpParameters = lpParameters; > - sei.lpDirectory = lpDirectory; > - sei.nShow = iShowCmd; > - sei.lpIDList = 0; > - sei.lpClass = 0; > - sei.hkeyClass = 0; > - sei.dwHotKey = 0; > - sei.hProcess = hProcess; > - > - ShellExecuteExA32 (&sei, FALSE); > - return (HINSTANCE16)sei.hInstApp; > -} > - > /************************************************************************* > * ShellExecuteA [SHELL32.290] > */ > -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 1

Re: improve scanf
by György 'Nog' Jeney 12 Oct '02

12 Oct '02

Ooops, that patch has got an error in it, use this one instead. > ChangeLog: > * dlls/msvcrt/scanf.c > * dlls/msvcrt/scanf.h > Implement [ format specifier. > > nog.

1 0

Re: MZ_Exec() patch, try 2
by Jukka Heinonen 12 Oct '02

12 Oct '02

> This look more reasonable? Yep. Only a few bugs left. Because cmdline buffer belongs to the calling application you should not modify the buffer. Use of memcpy or something like that would be recommended. Also, use of variable "status" is a mystery to me. If CreateProcessA fails, it might not initialize handles and even if it does not fail, they might be null handles (I don't know if that matters, though). -- Jukka Heinonen <http://www.iki.fi/jhei/>

1 0

configuring wine under mingw
by David Fraser 12 Oct '02

12 Oct '02

When running configure on wine under mingw, I had problems creating secure temporary directories... The configure code has two options for creating a secure temporary directory. If the first method fails the second is used. The difficulty with the first one is that mktemp returns a Windows-style path ("C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\cscP2080") instead of a Unix-style one (/tmp/cscP2080) Since the backslashes are not escaped this then causes problems later when the temporary path is passed to sed as it cannot find C:DOCUME~1ADMINI~1LOCALS~1TempcscP2080/subs.sed This is actually because mingw/msys converts the unix-style path passed in to mktemp to a Windows-style one in the first place. Actually mingw does not have mktemp and the reason it was finding mktemp is that the cygwin directory was in my path. Removing the cygwin path fixes this problem, but then I don't have access to bison and yacc, so configure fails As an alternate solution, If I disallow the first of the two options on cygwin, then the tmp variable is set to /tmp/cs* and so it proceeds fine --- configure 10 Oct 2002 17:54:27 -0000 1.349 +++ configure 11 Oct 2002 13:55:36 -0000 @@ -14315,9 +14315,17 @@ } # Create a (secure) tmp directory for tmp files. +host_os=`echo $ac_cv_host | sed 's/^$[^-]*$-$[^-]*$-$.*$$/\3/'` +# disallow mktemp on mingw +case $MSYSTEM in + MINGW32*) + allowmktemp= ;; + *) + allowmktemp=yes ;; +esac : ${TMPDIR=/tmp} { - tmp=`(umask 077 && mktemp -d -q "$TMPDIR/csXXXXXX") 2>/dev/null` && + [ $allowmktemp ] && tmp=`(umask 077 && mktemp -d -q "$TMPDIR/csXXXXXX") 2>/dev/null` && test -n "$tmp" && test -d "$tmp" } || { I thought the logical thing to check was $host_os to see if we were running mingw. But when I tried it didn't seem to work :-) Not sure if this configure is autogenerated or if this patch is applicable, but thought others trying the same thing might find this helpful... David Fraser

3 2

Different window handles
by Medland, Bill 11 Oct '02

11 Oct '02

What is the difference between window handles 100nn and 200nn? I am trying to figure out why our program behaves differently between KDE and Gnome. One fundamental difference is a particular window is allocated as 20033 under kde (and behaves correctly) whereas it comes back as 1003f under Gnome (and behaves incorrectly) Bill

2 1

Problem in file dlls/commdlg/filedlg.c
by Lozano, Carlos A. 11 Oct '02

11 Oct '02

Hello, In the line 655, there is a test for when ofnW->lpstrFile is null > if (ofnW->lpstrFile) but a bit later in line 689,690 there is not the same check, then if ofnW->nMaxFile is 0 because ofnW->lpstrFile is null, then the line 690 write in a negative pos: > lfs->ofnA->lpstrFile[ofnW->nMaxFile-1] = 0; so mirc591t.exe installer crashes when tries change the drive in the browse option. Can someone fix it? Regards, Carlos. -- _______________________________________________________ _/_ / / \/ ANDAGO |-- [ Infraestructuras - Andago.com ] \____/\ [ email:carlos.lozano@andago.com ] ______\__\_____________________________________________

1 0

Re: wine/dlls/avifil32: implemented many functions
by Greg Turner 11 Oct '02

11 Oct '02

On Friday 11 October 2002 04:49 pm, Michael Günnewig wrote: > Hallo. > > This patch adds many functionality to the avifil32.dll. It's now > possible to use the wine/programs/avitools/aviinfo programm. > > - added DllCanUnloadNow, DllGetClassObject to avifil32.spec > - implemented AVIFileOpenW > - implemented many functions of the AVI filehandler. > - added resources to avifil32 > - added FIND_* consts to include/vfw.h > - added registry entries for avifile.dll and avifil32.dll Without bothering to properly look into it for myself, might I ask what this does? + /* adjust permissions if copyrighted material in file */ + if (MainAVIHdr.dwFlags & AVIFILEINFO_COPYRIGHTED) { + This->uMode &= ~MMIO_RWMODE; -- gmt "It has been well said that really up-to-date liberals do not care what people do, as long as it is compulsory." -George F. Will

1 0

Re: winapi_test update
by Alexandre Julliard 11 Oct '02

11 Oct '02

Patrik Stridvall <ps(a)leissner.se> writes: > *** include_test_generated > > * include/wine/test_generated.h: > New include file with helpers for the generated tests. I think it would be better to put these macros in each generated C file. The code duplication doesn't hurt since it's all generated code anyway, and I'd rather avoid creating yet another global include. -- Alexandre Julliard julliard(a)winehq.com

1 0

Exception with ocx not caught
by Fabian Cenedese 11 Oct '02

11 Oct '02

Hi I already posted about this problem, now maybe someone else is able to help me. Creating ocx: http://www.winehq.com/hypermail/wine-devel/2002/09/0021.html Catching MFC exception: http://www.winehq.com/hypermail/wine-devel/2002/09/0057.html I now have a simple ocx and an exe that has nothing else than this ocx in it. The ocx appears as black circle on white ground in the upper left corner (right, the wizard made ocx) In Windows it works without a problem but in wine there's an exception upon creating the ocx. It happens with both builtin and native msvcrt.dll. I can see that some exceptions are raised about missing properties in the ocx, they also appear on Windows (debug output) and get caught before doing any harm. I sometimes had problems reproducing it. Then the dialog came up but without ocx. Both exe and ocx are made with MSVC6 (Project and binaries, debug/release): http://www.indel.ch/ftp/TestException.zip Also here is a backtrace at the moment of the exception: http://www.indel.ch/ftp/TestException.txt Alexandre once asked for an example, maybe he or someone else can use this here. I'm using actual wine from cvs on SuSE8, original dlls tried from NT4. Thanks bye Fabi

3 3

building ntdll on cygwin
by Steven Edwards 11 Oct '02

11 Oct '02

we get much futher now when building ntdll on cygwin. when linking I am getting the following error ntdll.exp(.edata+0xe4c):fake: undefined reference to `NTDLL_alloca_probe@0' ntdll.exp(.edata+0xe5c):fake: undefined reference to `NTDLL_chkstk@0' there are some other warnings but this is the only major thing with ntdll. Thanks Steven

4 6

Building setupapi under Mingw
by Steven Edwards 11 Oct '02

11 Oct '02

Hola, I noticed some work was going on in setupapi so I figured now would be a good time to ask for some help on the Windows/Mingw port. When I try to build under mingw I get this Info: resolving _wine_ldt_copy by linking to __imp__wine_ldt_copy (auto-import) setupapi.dll.glue.o(.text+0x82):setupapi.dll.glue.c: undefined reference to `win e_call_to_16_word@8' fu000001.o(.idata$3+0xc): undefined reference to `libwine_a_iname' nmth000000.o(.idata$4+0x0): undefined reference to `_nm__wine_ldt_copy' C:\mingw\bin\dllwrap.exe: C:\mingw\bin\gcc exited with status 1 make: *** [setupapi.dll] Error 1 Any hints as to how to fix? Thanks Steven

1 0

Re: wine/dlls Makefile.in rpcrt4/Makefile.in rpcrt ...
by Greg Turner 11 Oct '02

11 Oct '02

On Thursday 10 October 2002 06:36 pm, Alexandre Julliard wrote: > ChangeSet ID: 5742 > Patch: http://cvs.winehq.com/patch.py?id=5742 >--- wine/dlls/Makefile.in:1.155 Thu Oct 10 23:54:58 2002 >+++ wine/dlls/Makefile.in Thu Oct 10 23:54:58 2002 >@@ -821,7 +821,7 @@ > quartz: kernel32.dll$(DLLEXT) > rasapi32: kernel32.dll$(DLLEXT) > richedit: user32.dll$(DLLEXT) kernel32.dll$(DLLEXT) >-rpcrt4: kernel32.dll$(DLLEXT) >+rpcrt4: advapi32.dll$(DLLEXT) kernel32.dll$(DLLEXT) > serialui: user32.dll$(DLLEXT) advapi32.dll$(DLLEXT) kernel32.dll$(DLLEXT) > setupapi: user32.dll$(DLLEXT) advapi32.dll$(DLLEXT) kernel32.dll$(DLLEXT) ntdll.dll$(DLLEXT) > shdocvw: ole32.dll$(DLLEXT) kernel32.dll$(DLLEXT) > >Index: wine/dlls/rpcrt4/Makefile.in >diff -u wine/dlls/rpcrt4/Makefile.in:1.15 wine/dlls/rpcrt4/Makefile.in:1.16 >--- wine/dlls/rpcrt4/Makefile.in:1.15 Thu Oct 10 23:54:58 2002 >+++ wine/dlls/rpcrt4/Makefile.in Thu Oct 10 23:54:58 2002 >@@ -4,7 +4,7 @@ > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = rpcrt4.dll >-IMPORTS = kernel32 >+IMPORTS = advapi32 kernel32 > EXTRALIBS = $(LIBUUID) > > LDDLLFLAGS = @LDDLLFLAGS@ Alexandre, thank you for continuing to make up for my ignorance of the inner workings of the makefiles! Amongst other things, I noticed that instead of IMPORTS += ntdll, you did EXTRALIBS = ($LIBUUID). So, this makes me wonder, how on earth does one know what all these dependencies are? It's all-too-easy to suck in some .h file and call methods without knowing what dll dependencies you've really created... and unfortunately, the darn thing seems all-too-happy to compile despite this. Is there, aside from "just knowing," or tracing down API's one-by-one, a task which isn't always obvious to me anyhow, a systematic way to check for broken dll dependencies? I also presume there are some rules about what is allowed to depend on what, which I also don't know... I'd rather not create superfluous work for you because I don't know what I'm doing, so I figure it's time to educate myself, especially if I plan to go beyond just feeding you patches from Ove. Thanks, -- gmt "If ye love wealth better than liberty, the tranquility of servitude better than the animating contest of freedom, go home from us in peace. We ask not your counsels or your arms. Crouch down and lick the hands, which feed you. May your chains set lightly upon you, and may posterity forget that ye were our countrymen." -Samuel Adams

2 2

Re : wine/programs/wcmd wcmdmain.c
by Sylvain Petreolle 10 Oct '02

10 Oct '02

> Log message: > Try CreateProcess even if SHGetFileInfo fails so that we can > launch Unix binaries. Isn't that dangerous ? A windows program could gain access to some commands that shouldn't launch into normal windows. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

6 6

MZ_Exec() patch, try 2
by chrismorgan＠rcn.com 10 Oct '02

10 Oct '02

This look more reasonable? Thanks, Chris * dlls/winedos/module.c: Chris Morgan <cmorgan(a)alum.wpi.edu> Call CreateProcessA() when executing non-dos applications from a dos application. Index: dlls/winedos/module.c =================================================================== RCS file: /home/wine/wine/dlls/winedos/module.c,v retrieving revision 1.21 diff -u -r1.21 module.c --- dlls/winedos/module.c 30 Aug 2002 00:03:25 -0000 1.21 +++ dlls/winedos/module.c 10 Oct 2002 22:08:48 -0000 @@ -339,17 +339,68 @@ /*********************************************************************** * MZ_Exec + * + * this may only be called from existing DOS processes */ BOOL WINAPI MZ_Exec( CONTEXT86 *context, LPCSTR filename, BYTE func, LPVOID paramblk ) { - /* this may only be called from existing DOS processes - * (i.e. one DOS app spawning another) */ - /* FIXME: do we want to check binary type first, to check - * whether it's a NE/PE executable? */ + DWORD binType; + STARTUPINFOA st; + PROCESS_INFORMATION pe; + BOOL status; + HANDLE hFile = CreateFileA( filename, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); BOOL ret = FALSE; + + if(!GetBinaryTypeA(filename, &binType)) /* determine what kind of binary this is */ + { + return FALSE; /* binary is not an executable */ + } + if (hFile == INVALID_HANDLE_VALUE) return FALSE; + + /* handle non-dos executables */ + if(binType != SCS_DOS_BINARY) + { + if(func == 0) /* load and execute */ + { + BYTE fullCmdLine[512]; + LPBYTE psp_start = (LPBYTE)((DWORD)DOSVM_psp << 4); + PDB16 *psp = (PDB16 *)psp_start; + ExecBlock *blk = (ExecBlock *)paramblk; + LPBYTE cmdline = PTR_REAL_TO_LIN(SELECTOROF(blk->cmdline),OFFSETOF(blk->cmdline)); + LPBYTE envblock = PTR_REAL_TO_LIN(psp->environment, 0); + BYTE cmdLength = cmdline[0]; + cmdline[cmdLength + 1] = 0; /* null terminate and remove the \r at the end */ + cmdline++; /* the first character contains the length of the command line */ + + snprintf(fullCmdLine, sizeof(fullCmdLine), "%s %s", filename, cmdline); /* build the full command line */ + + ZeroMemory (&st, sizeof(STARTUPINFOA)); + st.cb = sizeof(STARTUPINFOA); + status = CreateProcessA (NULL, fullCmdLine, NULL, NULL, TRUE, + 0, envblock, NULL, &st, &pe); + + /* wait here until the child process is complete */ + WaitForSingleObject(pe.hProcess, INFINITE); + + /* clean up PROCESS_INFORMATION handles */ + CloseHandle(pe.hProcess); + CloseHandle(pe.hThread); + + ret = TRUE; + } else + { + FIXME("EXEC type of %d not implemented for non-dos executables\n", func); + ret = FALSE; + } + + CloseHandle(hFile); + return ret; + } /* if(binType != SCS_DOS_BINARY) */ + + /* handle dos executables */ switch (func) { case 0: /* load and execute */ case 1: /* load but don't execute */

1 0

Re: Scrollbar clean up part 1
by Alexandre Julliard 10 Oct '02

10 Oct '02

"Andrew M. Johnston" <johnstonam(a)logica.com> writes: > This interim patch will do a little more drawing than is strictly necessary. > (I hear what you asked re not changing names of things but in the interest of > producing something this version does make the structure names lower case > as is common else where and hence there are some irrelevant changes in > SCROLL_GetScrollBarRect) I still don't see much reason for renaming these things, but if you really want to do it, again a separate patch with just that change would be nicer. Also if you could avoid changing all the indentation it would make it a lot easier to see the real changes. Your patch breaks the scrollbars in notepad for me, but there are so many irrelevant differences that finding the bug is a lot more painful than it should be. -- Alexandre Julliard julliard(a)winehq.com

2 2

Load .so error
by Fabian Cenedese 10 Oct '02

10 Oct '02

Hi I already managed to load a .so recently but I can't get it to work on my new PC. The Windows dll was MyDll.dll which I turned now into a .so. ELF_LoadLibraryExA is looking for a libMyDll.so but returns with error=2. I couldn't find out what this error means. I have my .so with same spelling and case in various places (local to exe, windows\system, /usr/lib, /usr/local/lib) but nothing helped. I take it that this is a Linux problem and not from wine. Maybe something with rights? Thanks bye Fabi

3 4

Using a DLL from a linux shared lib
by Descalzi Carlos 10 Oct '02

10 Oct '02

Hi. I'm trying to use a DLL from a linux shared lib and i'm having the next error in the initialization: err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000!

2 1

focus and auto-raise
by Thorsten Kranzkowski 10 Oct '02

10 Oct '02

Hello! We're running quite successful the Lotus Notes Client under wine here. However there's one entry on my wishlist: Would it be possible to teach wine to _not_ auto raise windows when they get focus? We're using wine in managed mode so that it is possible to use several desktops etc. We prefer to use focus-when-mouse-enters-window mode but without automatically raising the windows. Unfortunately wine raises itself when it's getting focus. This leads to some undesireable effects like garbled popup-windows (when focus switches for the fraction of a second to the underlying main window - not much but enough to redraw the background) or oscillations (two main windows are on top of each other, due to 'lucky' timing and not being able drawing fast enough the lower window gets focus - so it gets raised and during drawing the new lower one gets focus ...) These effects are greatly reduced by using click-to-focus mode, but we don't want that :-) BTW: Many thanks for working printer support! Bye, Thorsten PS: please CC: me on reply -- | Thorsten Kranzkowski phone: +49 5402 9844-32 fax: -99 | | CCE Systemhaus GmbH & Co. KG office: tkranzkowski(a)cce.de | | Gewerbepark 18, D-49143 Bissendorf private: dl8bcu(a)dl8bcu.de |

1 0

Problems with multiple Wine programs at once
by David D. Hagood 10 Oct '02

10 Oct '02

I have the misfortune of needing to use Windows based DSP compilers for a project I am working on. Fortunately, they run under Wine just fine. So, the actual makefile is executed by a native GNU/Linux make, but the compile and assemble parts are Windows programs running under Wine (using Linux's binfmt_misc to launch them.) If I do a normal make, all is well. However, if I try to do a "make -j2" then after a few moments all the wine processes will freeze. Doing a ps -o wchan shows all the wine processes stuck in pipe_wait, and the wineserver process in do_poll. Has any body else seen this sort of behavior?

2 1

Re : wine/programs/wcmd wcmdmain.c
by Sylvain Petreolle 10 Oct '02

10 Oct '02

> Log message: > Try CreateProcess even if SHGetFileInfo fails so that we can > launch Unix binaries. Isn't that dangerous ? A windows program could gain access to some commands that shouldn't launch into normal windows. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Please ignore previous posting
by Matthew Davison 09 Oct '02

09 Oct '02

Please ignore my previous posting (if it even showed up), the fault was nothing to do with wine. -- Matthew Davison

1 0

Office XP bug in cvs
by Matthew Davison 09 Oct '02

09 Oct '02

a week or so ago word and excel XP started working on my machine under wine, after updating from cvs they will not start. They did work with CVS at lunchtime today, however. -- Matthew Davison

1 0

Re: wine/dlls/msvideo/msrle32: Some minor bugfixes.
by Eric Pouech 09 Oct '02

09 Oct '02

Michael Günnewig a écrit : > > Hallo. > > The following patch prevents some segfaults in the msrle32. > > It adds also the necessary line to the sample system.ini for using > this video codec. arrgh, I just sent your patch to wine-patches... for next patches (if there will be some more ;-), can we assume you'll send them to both rewind & wine ? (just to avoid doing twice the same job) A+

1 0

winedbg - walk wnd broken?
by Roger Eisenecher 09 Oct '02

09 Oct '02

Hi List I am using winedbg with the commands "walk wnd" or "info wnd <handle>". But unfortunately both functions seems to have problems to retrieve the registered window classes. I get always the class "-- Unknown --" expect for the top window (desktop). Could some one explain me why this happen or if this is a known "feature" of winedbg? kindly regards roger

2 3

Re: [Fwd: Registry problem]
by steve.lustbader＠philips.com 09 Oct '02

09 Oct '02

>On Wed, Oct 09, 2002 at 01:55:00PM -0400, twickline2(a)triad.rr.com wrote: >> > Reply and cut out what you don't need...... >> > Posted from Lotus Notes Build V60_M13_04032002 >> > >> > Tom >> >> Sorry... You need to reply with ( Internet Style History ) >Aah ! If only I had known that this is indeed possible when I was forced >to use Notes ! >Oh, and yes, Notes' email representation is CRAPPY. >(not to mention that it has other bugs which are laughable) > >Thanks for this hint ! > Unfortunately, they added this feature in V6, and v5 (which I'm stuck with) has no such feature (I did the quoting by hand for this reply).

1 0

Documentation and tools
by Steven Edwards 09 Oct '02

09 Oct '02

Hola, I would like to do some work on documentation for cygwin, mingw and MS_VC but need the sgml docbook tools. I could reboot in to Linux to work on it but I would like to be able to be able to build/support the docs under cygwin and mingw. What and where are the tools I need to build wines dtd? I have tried to port the sgml-tools package but have had issues building it with cygwin so I am thinking I am missing something. Anyone care to help? Thanks Steven

1 0

Re: Registry problem
by steve.lustbader＠philips.com 09 Oct '02

09 Oct '02

Yup, this patch solved the bad file descriptor problem, but WinAmp gives me this output when I run it (with a backtrace): Unhandled exception: unimplemented function msvcrt.dll._i64toa called in 32-bit code (0x40cb0052). In 32-bit mode. Symbol __strtol_internal is invalid 0x40cb0052 (__wine_unimplemented+0x52 [msvcrt.spec.c:47] in msvcrt.dll.so): jmp 0x40cb004c (__wine_unimplemented+0x4c [msvcrt.spec.c:47] in msvcrt.dll.so) 50 void __wine_stub_msvcrt_dll_24(void) { __wine_unimplemented("??_7__non_rtti_object@@6B@"); } Wine-dbg>bt Backtrace: =>0 0x40cb0052 (__wine_unimplemented+0x52(func=0x40cc6851) [msvcrt.spec.c:47] in msvcrt.dll.so) (ebp=406dfc5c) 1 0x40cb0604 (__wine_stub_msvcrt_dll_275 [msvcrt.spec.c:102] in msvcrt.dll.so) (ebp=406dfc6c) 2 0x10076730 (OUT_DS.DLL.winampGetOutModule+0x22a8 in C:\PROGRAM FILES\WINAMP\PLUGINS\OUT_DS.DLL) (ebp=406dfce8) 3 0x100766a0 (OUT_DS.DLL.winampGetOutModule+0x2218 in C:\PROGRAM FILES\WINAMP\PLUGINS\OUT_DS.DLL) (ebp=406e0358) 4 0x00418994 (winamp.exe..text+0x17994 in C:\Program Files\Winamp\winamp.exe) (ebp=403d46da) 5 0x002e0000 (ebp=00240000) *** Invalid address 0x00240000 (I don't really need to use winamp, but it was an easy example of the previous problem.) -Steve PS - Uwe, I'd love to be able to quote email correctly, but I'm forced to use Lotus Notes at work, which doesn't seem to know how to reply very well. If anyone knows how to make Notes behave like a normal mail client, let me know. Alexandre Julliard To: Steve Lustbader/ANR/MS/PHILIPS@AMEC <julliard@winehq cc: Sylvain Petreolle <spetreolle(a)yahoo.fr> .com> wine-devel(a)winehq.com Sent by: Subject: Re: Registry problem julliard@winehq. com Classification: 10/09/2002 12:25 PM steve.lustbader(a)philips.com writes: > When I try to run WinAmp, it exits immediately with that same error. > It doesn't run at all, unlike the installer, which runs but then ends > with the error (probably when it tries to run winamp itself). Does this help? Index: dlls/winmm/wineoss/audio.c =================================================================== RCS file: /opt/cvs-commit/wine/dlls/winmm/wineoss/audio.c,v retrieving revision 1.62 diff -u -r1.62 audio.c --- dlls/winmm/wineoss/audio.c 7 Oct 2002 18:23:40 -0000 1.62 +++ dlls/winmm/wineoss/audio.c 9 Oct 2002 16:23:52 -0000 @@ -245,7 +245,7 @@ if ((fd = open(ossdev->dev_name, ossdev->open_access|O_NDELAY, 0)) == -1) { WARN("Couldn't open out %s (%s)\n", ossdev->dev_name, strerror(errno)); - return (errno == EBUSY) ? MMSYSERR_ALLOCATED : MMSYSERR_ERROR; + return -1; } fcntl(fd, F_SETFD, 1); /* set close on exec flag */ /* turn full duplex on if it has been requested */ @@ -373,7 +373,7 @@ } TRACE("Changing fd from %d to ", ossdev->fd); close(ossdev->fd); - OSS_RawOpenDevice(ossdev, &ossdev->audio_fragment); + ossdev->fd = OSS_RawOpenDevice(ossdev, &ossdev->audio_fragment); TRACE("%d\n", ossdev->fd); return ossdev->fd; } -- Alexandre Julliard julliard(a)winehq.com

2 1

wrong size under gnome
by Medland, Bill 09 Oct '02

09 Oct '02

Any ideas before I spend lots of time? Our application has a right mix of technologies involved. This problem manifests itself with a container application hosting an OCX generated from Visual Basic. The container sizes itself as it loads the ocx. Under kde everything is fine; the dialog that is hosted is fully displayed. However under Gnome it seems that the size of the whole window is too small by the height of the window title bar, so that the bottom 18 pixels are hidden. any ideas? Bill

1 0

Re: [Fwd: Registry problem]
by twickline2＠triad.rr.com 09 Oct '02

09 Oct '02

> Reply and cut out what you don't need...... > Posted from Lotus Notes Build V60_M13_04032002 > > Tom Sorry... You need to reply with ( Internet Style History ) And cut out what you dont want/need... Now ill go away :) Tom

2 1

Re: Registry problem
by steve.lustbader＠philips.com 09 Oct '02

09 Oct '02

I'm using the latest cvs source (I update every day). I tried using a native advapi32 (from WinXP, which is all I have access to), but that just resulted in lots of other problems (unimplemented functions in ntdll.dll, etc. When I try to run WinAmp, it exits immediately with that same error. It doesn't run at all, unlike the installer, which runs but then ends with the error (probably when it tries to run winamp itself). Is it possible that sound isn't set up properly on my system? I don't really need sound on it, so I haven't played around with it too much. It's just the normal Redhat 7.2 install, with whatever sound settings it picked. I can listen to mp3's with xmms, though. -Steve Sylvain Petreolle To: Steve Lustbader/ANR/MS/PHILIPS@AMEC <spetreolle@yaho wine-devel(a)winehq.com o.fr> cc: Subject: Re: Registry problem 10/09/2002 02:18 AM Classification: What version of wine did you use ? With CVS of Oct 08, I install without problem. --- steve.lustbader(a)philips.com a écrit : > I started having a problem with today's source that appears > to be either registry or sound related. When I tried to > install Winamp (v 2.81 lite) in wine, I get this error: > > wine client error:8091280: sendmsg: Bad file descriptor > > Output from +reg,+relay ends with > > 08091280:Call > ntdll.NtQueryValueKey(00000048,40124878,00000002,406e2acc,00000100,406e2ac0) > ret=40977acc > trace:reg:NtQueryValueKey (0x48,L"WaveMapper",2,0x406e2acc,256) > wine client error:8091280: sendmsg: Bad file descriptor > > (the last 100 lines of the output can be seen at > http://www.lustbader.net/winamp.txt) > > I tried getting rid of my ~/fake_c and ~/.wine directories > and running wineinstall again, but that didn't help. > > -Steve > > ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

3 2

Registry problem
by twickline2＠triad.rr.com 09 Oct '02

09 Oct '02

-Steve PS - Uwe, I'd love to be able to quote email correctly, but I'm forced to use Lotus Notes at work, which doesn't seem to know how to reply very well. If anyone knows how to make Notes behave like a normal mail client, let me know. Reply and cut out what you don't need...... Posted from Lotus Notes Build V60_M13_04032002 Tom

1 0

Re: Registry problem
by steve.lustbader＠philips.com 09 Oct '02

09 Oct '02

I tried the cvs source from October 7, and the problem doesn't occur (although winamp does crash with an unimplemented MSVCRT function when I try to run it). steve.lustbader+FromInterNet@ philips.com To: Sylvain Petreolle <spetreolle(a)yahoo.fr> Sent by: cc: wine-devel(a)winehq.com wine-devel-admin(a)winehq.com (bcc: Steve Lustbader/ANR/MS/PHILIPS) Subject: Re: Registry problem 10/09/2002 10:42 AM Classification: I'm using the latest cvs source (I update every day). I tried using a native advapi32 (from WinXP, which is all I have access to), but that just resulted in lots of other problems (unimplemented functions in ntdll.dll, etc. When I try to run WinAmp, it exits immediately with that same error. It doesn't run at all, unlike the installer, which runs but then ends with the error (probably when it tries to run winamp itself). Is it possible that sound isn't set up properly on my system? I don't really need sound on it, so I haven't played around with it too much. It's just the normal Redhat 7.2 install, with whatever sound settings it picked. I can listen to mp3's with xmms, though. -Steve Sylvain Petreolle To: Steve Lustbader/ANR/MS/PHILIPS@AMEC <spetreolle@yaho wine-devel(a)winehq.com o.fr> cc: Subject: Re: Registry problem 10/09/2002 02:18 AM Classification: What version of wine did you use ? With CVS of Oct 08, I install without problem. --- steve.lustbader(a)philips.com a écrit : > I started having a problem with today's source that appears > to be either registry or sound related. When I tried to > install Winamp (v 2.81 lite) in wine, I get this error: > > wine client error:8091280: sendmsg: Bad file descriptor > > Output from +reg,+relay ends with > > 08091280:Call > ntdll.NtQueryValueKey(00000048,40124878,00000002,406e2acc,00000100,406e2ac0) > ret=40977acc > trace:reg:NtQueryValueKey (0x48,L"WaveMapper",2,0x406e2acc,256) > wine client error:8091280: sendmsg: Bad file descriptor > > (the last 100 lines of the output can be seen at > http://www.lustbader.net/winamp.txt) > > I tried getting rid of my ~/fake_c and ~/.wine directories > and running wineinstall again, but that didn't help. > > -Steve > > ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 1

Re: Major tidy up of Scroll.c to add foundations for flatscroll bars
by Alexandre Julliard 09 Oct '02

09 Oct '02

"Andrew M. Johnston" <johnstonam(a)logica.com> writes: > controls.h - improve the scroll bar nonclient separation > nonclient.c - remove NC_TrackScrollBar and use scrollbar WINAPI routine > scrollbar.c - complete rewrite using similar structure and logic > - unified drawing code > - simpler event processing logic > - minimised drawing > - better conformance to windows on LINEUP and LINEDOWN events All the flat scrollbar stuff has nothing to do in scroll.c, the normal scrollbars shouldn't need to know anything about flatsb at all. The flatsb control should intercept messages it needs to change by subclassing the windows, and call down to the normal scrollbar where necessary. > Note: it is possible to split the scroll changes up into three consistent parts if > really necessary That would be nice. Also if you could avoid unnecessary changes like renaming SCROLLBAR_INFO to SCROLL_INFO that would make it easier to see what is really being changed. -- Alexandre Julliard julliard(a)winehq.com

3 5

Listview
by Dimitrie O. Paun 09 Oct '02

09 Oct '02

Hi folks, Here's a quick status update on the listview. Currently, the listview goes through a major cleanup. It is required -- the file is huge (over 10000 lines when I started, now it's 9200 with more features!), and has accumulated a lot of cruft over the last few years. This is very normal for such a complex control as listview, and we need to prep the code to add more features. At the same time, I go over the code, review it for correctness, fix bugs, and implement the missing functionality. While it may look I do mostly code reorganizations, this is not the case: a lot of corner bugs have been fixed, functionality has been enhanced, code has been cleaned up, and simplified. Due to the cleaner code base, we are in a better position to fix problem, and add features. The downside of all this is that (1) old bugs, and missing functionality is exposed, (2) new bugs are introduced. On top of it all, two major efforts were happening simultaneously: Guy's ICON mode work, and mine. Guy did a wonderful job at fixing some of the issues in ICON mode, unfortunately my changes interacted with his in a nasty way. So we have some problems. I am aware of some of them, and I'm working to fix them. But it will take some time, as I trying to fix a problem, I see some cleanup that needs doing _before_ I work on the bug itself. Currently, I am aware of the following problems: -- selection (clicking on items sometimes does not select them) -- drawing (focus, background, etc.) -- calculating item rectangles If you are experience problems with the listview, I'd like to hear from you. If you want to help, some test cases will help quite a bit. -- Dimi.

3 10

wine on sparc solaris
by Juraj Hercek 09 Oct '02

09 Oct '02

Hi, Since no one had similar problems as I did on sparc solaris (no reply to my previous email sent to wine-devel on /Wed Oct 02 2002 - 09:38:12 CDT/ ). I started to debug it. First problem lies here: $WINE_ROOT/dlls/ntdll/virtual.c:986 There is a condition that says: (char *)base + size > (char *)ADDRESS_SPACE_LIMIT If base+size is above address space limit, NtAllocateVirtualMemory fails. Problem is, that addresses returned by wine_anon_mmap function ($WINE_ROOT/library/port.c:458) - which in turn calls system mmap - are far behind ADDRESS_SPACE_LIMIT (ADDRESS_SPACE_LIMIT=0xc0000000, definition in $WINE_ROOT/dlls/ntdll/virtual.c:110). Just to be precise, they are around 0xfe000000 and higher. I changed address space limit to -1, just to avoid this problem (I know, this is probably not the best solution, but I didn't find better one at the moment). After this change NtAllocateVirtualMemory passed. When I run it again, I got stuck in setup_dos_mem() function ($WINE_ROOT/msdos/dosmem.c:489) where is error saying: "Cannot use first megabyte for DOS address space, please report." After deeper insight I figured out that try_mmap_fixed() function failed ($WINE_ROOT/library/port.c:431), because memory page we were trying to allocate was alredy mapped. So, question is: Is there any way how to solve these two problems (address space limit, already mapped pages) correctly? Thanks for reply. Juraj

1 0

LoadLibrary during PROCESS_ATTACH
by Uwe Bonnes 09 Oct '02

09 Oct '02

Hallo, I am trying to debug Xilinx webpack version 5.1. If I understand things right, the "ise" application crashed because it unloads a dll, but later still accesses this dll. This seems to happen, because during MODULE_InitDLL of the dll it calls a Loadlibrary on itself. As MODULE_InitDLL sets WINE_MODREF_MARKER, and the flow of execution in LoadLibrary checks for WINE_MODREF_MARKER before incrementing the RefCount, the refcount gets wrong and the application unloaded. Forcing the increment of RefCount in MODULE_LoadLibraryExA unconditional of WINE_MODREF_MARKER makes the application continue. Do we need the check for WINE_MODREF_MARKER in MODULE_LoadLibraryEx? Do we still need MODULE_LoadLibraryEx at all? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel