- wine-devel - winehq.org

Re: Implementation of SPI_GETSHOWSOUNDS action in SystemParametersInfo
by Gerard Patel 20 Sep '01

20 Sep '01

At 02:34 PM 20/09/2001 -0400, you (Andriy Palamarchuk <apa3a(a)yahoo.com>) wrote: >File: windows/sysparams.c <snip> use diff -u See: http://www.winehq.com/dev.shtml (section : patches) Gerard

1 0

Re: min/max and types
by Francois Gouget 20 Sep '01

20 Sep '01

On Tue, 18 Sep 2001, eric pouech wrote: [...] > however, comparaisons like min(short, int) or min(size_t, DWORD) don't > provide lots of errors. integral promotions are straightforward, and > behave as expected by any programmer. so it would be rather ugly IMO > to write something like min((int)s, i) (s being short and i int) But in this last example, wouldn't it be better to declare s as an int or i as a short? Then we would not need a cast. I believe we would rarely be forced to really compare integers of different sizes. Of course the only way to be sure is to really look at the actual warnings... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.

3 2

GetSystemMetrics / SetSystemMetrics ?
by Andriy Palamarchuk 20 Sep '01

20 Sep '01

Question: How to update metrics data returned by GetSystemMetrics function? Problem: Currently I'm implementing some easiest FIXMEs (e.g. SPI_GETSHOWSOUNDS) in function SystemParametersInfo. GetSystemMetrics is used to return information for a few types of SPI_GETxxx actions from this function, including the action I'm working on. Logic for corresponding SPI_SETxxx actions is not implemented and contains commented out calls to SetSystemMetrics. As I understand this comment is a mark that corresponding GetSystemMetrics data should be updated in this place. GetSystemMetrics returns data from array sysMetrics. I did not find any function which provides update access to the array. Can you advise how to deal with this problem? Regards, Andriy Palamarchuk

1 0

Quicktime 5.0.x / XVideo usage
by Matthias Dahl 20 Sep '01

20 Sep '01

Hey there... ]) powered by Linux 2.4.8 ([ I have discovered some strange behavior with WINE and Quicktime 5.0.x. As long as the "time slider" and the "audio bars" are being updated the video runs quite sluggish. But if you open a menu or a dialog box both the "time slider" and the "audio bars" stop updating - which is normal. BUT the video itself runs at full speed as long as both are not being updated. Which is kinda strange I guess. Even those animation content which is included with some movs doesn't slow the playback down, so it cannot be a performance issue. (on PIII with 500 Mhz, 256 MB ram and X 4.1.x (G400MAX)) Also if you maximize the video to full screen or anything that is not its original size, the playback also becomes very sluggish. Doesn't WINE use the XVideo protocol for such operations? By the way. I am using yesterday's CVS checkout without any windows DLLs. I'll happily provide more informations - just let me know what you need. Last but not least. All you guys are doing a great job -- and I wanted to take the opportunity to say THANK YOU to you all. :-) -- So long, Matt ]) matthew2k(a)web.de, GPG key available at public keyservers ([

3 4

[Problem report] SetWindowWord creates infinite loop
by Gerard Patel 20 Sep '01

20 Sep '01

The following change in SetWindowWord + + WIN_ReleaseWndPtr(wndPtr); + switch(offset) { - case GWW_ID: ptr = (WORD *)&wndPtr->wIDmenu; break; - case GWW_HINSTANCE: ptr = (WORD *)&wndPtr->hInstance; break; - case GWW_HWNDPARENT: retval = SetParent( hwnd, newval ); - goto end; - default: - WARN("Invalid offset %d\n", offset ); - retval = 0; - goto end; + case GWL_ID: + case GWL_HINSTANCE: + case GWL_HWNDPARENT: + return SetWindowLongW( hwnd, offset, (UINT)newval ); + default: + WARN("Invalid offset %d\n", offset ); + return 0; } creates an infinite loop as SetWindowLong calls WIN_SetWindowLong, that calls SetWindowWord for the GWL_HINSTANCE case. Gerard

1 0

Re: [Problem report] SetWindowWord creates infinite loop
by Alexandre Julliard 19 Sep '01

19 Sep '01

Gerard Patel <gerard.patel(a)nerim.net> writes: > The following change in SetWindowWord > [...] > creates an infinite loop as SetWindowLong calls WIN_SetWindowLong, > that calls SetWindowWord for the GWL_HINSTANCE case. Oops, sorry about that. It should be fixed now. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: min/max and types
by Eric Pouech 19 Sep '01

19 Sep '01

> > however, comparaisons like min(short, int) or min(size_t, DWORD) don't > > provide lots of errors. integral promotions are straightforward, and > > behave as expected by any programmer. so it would be rather ugly IMO > > to write something like min((int)s, i) (s being short and i int) > > But in this last example, wouldn't it be better to declare s as an > int or i as a short? Then we would not need a cast. > I believe we would rarely be forced to really compare integers of > different sizes. Of course the only way to be sure is to really look at > the actual warnings... well, the warnings I looked at come of three kinds (for that's for from being exhaustive): - comparing the dwSize of a struct with the sizeof of the struct. The first being a DWORD, the second of type size_t. Using the macro means using a cast here, which I find rather ugly - comparing an unsigned int with an explicit integer : min(4, u). This could be rewritten easily into min(4u, u) for example - real potential problems with comparing unsigned char with signed short for example. IMO, the first two ones shouldn't require type casts. last but not least, I think that the basic issue here is that gcc should report a sign mismatch in the comparison... and it doesn't. If it did, we wouldn't be arguing on the matter... A+ > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly. > > > > --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle __________________________________________________ Voila vous propose une boite aux lettres gratuite sur Voila Mail: http://mail.voila.fr

1 0

Re: DDE and postmessage
by eric pouech 18 Sep '01

18 Sep '01

Alexandre Julliard wrote: > > eric pouech <eric.pouech(a)wanadoo.fr> writes: > > > I've started looking at the inter-process DDE message management > > as of today, PostMessage doesn't use the packing strategy used by > > SendMessage (rightfully because of possible dangling pointer issue > > if pointers are used in message parameters) > > > > however, some DDE messages need to send additional information > > even when posting (copying all data), and DDE protocol requires > > posting messages (SendMessage is banned) > > > > do you have any plan to handle this ? > > I don't really have any plan yet. We clearly need to do a special case > for posted DDE messages; a possibility would be to use an internal > message with SendMessage to send the data across before posting the > actual DDE message. There is an undocumented message similar to > WM_COPYDATA that can be used to transfer a global memory block across > processes, which is used for stuff like WM_DROPFILES; it doesn't work > right now but I'm planning to implement it soon. This would add a > synchronisation point that may defeat the purpose of the PostMessage > though. If this is a problem we can probably add a DDE-specific server > call to transfer the data what I had in mind was somehow reusing the message packing capabilities of SendMessage for PostMessage. Moreover, we need to handle large memory chunks to be exchanged in SendMessage, so we could kill two birds with one stone. A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

Re: Dialog painting
by Gerard Patel 18 Sep '01

18 Sep '01

At 12:35 AM 11/09/2001 +0300, you wrote: > >I took a closer look at this. I just ripped out the interesting parts >from Speak freely in order to find a simple program exhibiting the >problems. What I ended up with was a program which does nothing >interesting except to show a simple dialg using CreateDialog(). It >still doesn't work under Wine. The source is attached. I have looked at your source. With current Wine, expose X events are retrieved from the X server when Wine has nothing else to do. These events are setting the update region. CreateWindow does not set the update region in current Wine, even if the window is visible. This is the point that matters for your problem I think. hSplash = CreateDialog (hInstance, MAKEINTRESOURCE(IDD_SPLASH), NULL, Splash_DlgProc); SetForegroundWindow(hSplash); // here the update region is nil (Wine problem !) UpdateWindow(hSplash); // --> nothing is displayed. Sleep(5000); // events are retrieved from the X server queue. printf("Removing splash.\n"); DestroyWindow(hSplash); Your code does not display anything because no message is retrieved from the message queue. After the Sleep call, WM_PAINT messages are available, but as you don't retrieve them by calling PeekMessage or something like that, nothing is shown. I don't want to say that your app code is wrong, of course. There is a problem in Wine, but I don't know what to do about it. My first thought would be to scan the X queue and retrieve the expose events as was done before the great changes of this summer, but this may be somewhat difficult to do right. I prefer to waste my time searching for other problems, because I have no doubt that Alexandre Julliard is aware of this one and it's clear that he is not finished yet with X code reorganization. Gerard

2 1

RE: dlls/advapi32/crypt.c
by Patrik Stridvall 17 Sep '01

17 Sep '01

> Vladimir Vukicevic <vladimir(a)ximian.com> writes: > > > I think that the discussion of OpenSSL vs. libgcrypt isn't really > > necessary -- there's no reason why two implementations of CryptoAPI > > can't be done, one using the gcrypt backend, one using OpenSSL. > > Granted, this is a duplication of effort, but I think there > is enough > > interest that it shouldn't be too difficult to do both. > Also, it's easy > > enough to ship two different advapi32.so's, or even create an > > intermediate cryptoapi layer that supports plugins, so that > the option > > always remains with the distributor or user whether to go with a GPL > > implementation, a BSD implementation, or even a commercial > > implementation. > > As far as the main tree is concerned, everything has to be under the > Wine license (or compatible). It's not acceptable to depend on a > library that would impose extra conditions on the Wine/Winelib > user. The problem is what constitutes extra conditions is extremly vague. If you have a Winelib application that don't for example use say any crypto functions, you really can't be said either to use or to derive a new work from a completely unused and/or unnessary library. If you do use any crypto function, well, whether that imposes any extra conditions is an extremely difficult legal issue that really can't be answered without a real court case. It might depend on whether the use is optional but it might not. That is what I have been trying to point out in my recent messages. So just saying that "I don't want any libraries that imposed extra conditions on the Wine/Winelib user" is not really a very informative answer. What you mean is (I guess): 1. No use of libraries under the GPL or other viral licenses 2. No use of commersial libraries (end user and/or developer must pay for it) Or do you mean something else? Anyway see below. > And this is not solved by having a choice between two different > sets of extra conditions. Note that you always have the choice of NOT using crypto. If Wine didn't include a working crypto implementation that would be the only choice wouldn't it? As long as it doesn't effect the performance or maintainabillity of Wine in negative way more choices are always better than less IMHO.

1 0

Monkey Island 3 install
by Johan Gill 17 Sep '01

17 Sep '01

After some testing, I've found that the installation of Curse of Monkey Island works fine if winver=win98 is specified. What made the win95 install break was this: --- /opt/cvs-commit/wine/misc/version.c 2001/07/02 19:59:49 1.43 +++ /opt/cvs-commit/wine/misc/version.c 2001/07/27 23:57:38 1.44 @@ -75,7 +75,7 @@ }, /* WIN95 */ { - 0x07005F03, + 0x07000304, 0xC0000004, { sizeof(OSVERSIONINFOA), 4, 0, 0x40003B6, If that is a correct fix, the real problem is to be found somewhere else. /Johan Gill, johane(a)lysator.liu.se

1 0

RE: dlls/advapi32/crypt.c
by Patrik Stridvall 17 Sep '01

17 Sep '01

> On Sat, 2001-09-15 at 02:12, Patrik Stridvall wrote: > > In short. GPL:ed Winelib applications is not our concern > > and we shouldn't IMHO make it one beyond making sure > > that all linking to non GPL compatible libraries is optional. > > > > GPL:ed libraries is, as said above, a different story, that > > from a legal point of view is an unresolved issue. The "answer" > > of that question regardless of what it will be, will, be very > > important since it might, unless it is too vague, define the > > boundaries of copyright in a more definite way. > > I think that the discussion of OpenSSL vs. libgcrypt isn't really > necessary -- there's no reason why two implementations of CryptoAPI > can't be done, one using the gcrypt backend, one using OpenSSL. > Granted, this is a duplication of effort, but I think there is enough > interest that it shouldn't be too difficult to do both. > Also, it's easy > enough to ship two different advapi32.so's, or even create an > intermediate cryptoapi layer that supports plugins, so that the option > always remains with the distributor or user whether to go with a GPL > implementation, a BSD implementation, or even a commercial > implementation. It is not the effort that is the real problem. The problem is that since ADVAPI32 might use libgcrypt (that is GPL:ed library) it possible to for a non-GPL:ed Winelib application to indirectly via the ADVAPI to "link" to libgrypt. This would violate the GPL:ed in some meaning. Of course the authors of the Winelib application might be entirely unaware of this fact but it is still teoretical violation. This is, of course, in some meaning absurd, but ask yourself this: What meaning have the GPL for libraries if you can just wrap a intermediate library with a GPL compatible license (like Winelib:s ADVAPI "library") around it and circumvent the GPL? Of course a distinct possibility exists that a court of law will find that the GPL (as applied to libraries) is meaningless or at least meaningless in the case of Wine. But are you willing to be the defendent in a test case? Alexandre is not. Still IMHO even in the worst case what will likely happend is that. 1. Richard Stallman (or somebody else) sends a GPL violation notice. 2. Slashdot debate the case and possibly hang us out. :-) 3. We will discuss on the list what to do and possible remove the offending code. 4. If we do not the debate on Slashdot and elsewhere will continue 5. If we still persist the chances that we will be sued is still quite small since A) The cases of winning is close to zero B) There is little or no chance to profit even regardless of this. Of course there is moral aspect of this but ask yourself this: "Is it immoral to shatter somebodies unrealistic expectations?" In short there is no legal risk at all IMHO but Alexandre has said earlier that he doesn't want code using GPL:ed libraries if not to protect himself or the Wine project, so to protect possible users of Wine if not from legal issues so from bad PR. > There's also something to be said for following Microsoft's API for > crypto back-ends, so that proprietary back-ends (i.e. those > dealing with > hardware keys, etc.) could function within the wine cryptoapi > framework. > In this case, each individual provider (RSA, DSS, etc.) would then be > implemented either in terms of gcrypt, or OpenSSL, or libcrypt, or any > other. That is probably a good idea. But you can't use libgcrypt at least not without asking the libgcrypt authors if it is OK that Wine(lib) uses libgcrypt despite the fact that it makes it possible for non-GPL:ed Winelib applications to indirectly use libgcrypt. And you better ask Alexandre whether is OK with him to include the code under such circumstances.

1 0

RE: dlls/advapi32/crypt.c
by Patrik Stridvall 17 Sep '01

17 Sep '01

> Patrik Stridvall wrote: > > > > > On another note, however, I was re-reading the CryptoAPI > > > thread and I don't > > > think that Vladimir Vukicevic's questions were really > > > answered from September > > > 3rd. > > > > Can you be a little more specific? > > > > As far using GPL:ed libraries, that is a question that > > really can't be properly answered without a real court > > case. > > I think that Vladimir's suggestion that OpenSSL could be > used as an alternative back end did not recieve sufficient > attention. He wasn't sure that that was a good approach > given the fact that it would arguably cause difficulty for > people who wanted to run GPLed apps on top of Wine+OpenSSL. Well. If we only permit linking with libraries that have GPL compatible licenses, we will seriously limit our choices. Sure I, since GPL is a dominant license, fully agree that all linking to non-GPL:ed libraries should be optional. Of course the question of what is optional is vague too. See below. Also note that this is an entirely different issue than the issues concerning GPL:ed libraries. In the case above it is 100% clear that only the distributor of the GPL:ed application can have any legal liabillities for possible violation of the GPL. It is not out immediate concern. Beside since they, because of the GPL, must have the source code they can always disable things like crypto that might not have a 100% GPL compatible Winelib implementation. In short. GPL:ed Winelib applications is not our concern and we shouldn't IMHO make it one beyond making sure that all linking to non GPL compatible libraries is optional. GPL:ed libraries is, as said above, a different story, that from a legal point of view is an unresolved issue. The "answer" of that question regardless of what it will be, will, be very important since it might, unless it is too vague, define the boundaries of copyright in a more definite way. However, I'm a little afraid of that for the GPL to be truely meaningful, especially in the case of Wine, you will have define the boundaries of copyright a little to strict for my liking. > Since the number of GPLed Windows apps that do not have Linux > counterparts is vanishingly small, the OpenSSL option seems to > me more appropriate than using a libgcrypt back end. The > OpenSSL license does not have the viral properties that the > GPL has (it's an old-style BSD-type license, complete with the > advertising clause), and therefore we should be able to weak-link > Wine with libOpenSSL without any license contamination. Agreed. > Packagers > who distribute libOpenSSL with Wine would then be responsible > for meeting the OpenSSL license requirements for advertising > and attribution. Of course but that is not our immediate concern, the same would be if we link with any proprietary library. Any distributor of such libraries whether in conjuction with Wine(lib) or seperately must of course fullfull the licensing requirements of such libraries (including but not limited to pay any license fees). Actually in some meaning we already do, since proprietary implemenatations of both X Windows and OpenGL exists and Wine(lib) will happily dynamically link with them and use them if they exists. Wine(lib):s use of them obviously do not gives any license to distribute them, but that is not our concern. This of course raises they question if we mandatorily link to libraries, like X Windows or OpenGL, that both have GPL and non-GPL compatible implemtations: Do we optionally or mandatorily link to a non GPL compatible library? Does this matter from a legal perspetive as concerning whether a Winelib user violate the GPL or not? In addition does it matter whether the GPL compatible library is: 1. Complete 2. Close to complete 3. Has only basic functionallity 4. Unusably buggy 5. Unimplemented stubs 6. In the planing state 7. A theoretical construction In that case why?

2 1

DDE and postmessage
by eric pouech 16 Sep '01

16 Sep '01

(mainly for Alexandre) I've started looking at the inter-process DDE message management as of today, PostMessage doesn't use the packing strategy used by SendMessage (rightfully because of possible dangling pointer issue if pointers are used in message parameters) however, some DDE messages need to send additional information even when posting (copying all data), and DDE protocol requires posting messages (SendMessage is banned) do you have any plan to handle this ? A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

RE: dlls/advapi32/crypt.c
by Patrik Stridvall 16 Sep '01

16 Sep '01

> On another note, however, I was re-reading the CryptoAPI > thread and I don't > think that Vladimir Vukicevic's questions were really > answered from September > 3rd. Can you be a little more specific? As far using GPL:ed libraries, that is a question that really can't be properly answered without a real court case. Regardless of this if you want any code using a GPL:ed library in the CVS you need to convince Alexandre to change his mind. What other questions are unanswered?

5 4

min/max and types
by eric pouech 15 Sep '01

15 Sep '01

just for fun, I tried compiling Wine with Linux latest min/max macros definitions Index: include/windef.h =================================================================== RCS file: /usr/share/cvs/cvsroot/wine/wine/include/windef.h,v retrieving revision 1.58 diff -u -r1.58 windef.h --- include/windef.h 2001/07/30 18:57:18 1.58 +++ include/windef.h 2001/09/14 18:06:53 @@ -133,6 +133,27 @@ #define min(a,b) (((a) < (b)) ? (a) : (b)) #endif #endif /* NOMINMAX */ +#if defined(__WINE__) && defined(__GNUC__) +#undef max +#undef min +#define min(x,y) \ + ({ const typeof(x) _x = x; \ + const typeof(y) _y = y; \ + \ + (void) (&_x == &_y); \ + \ + _x < _y ? _x : _y; \ + }) + +#define max(x,y) \ + ({ const typeof(x) _x = x; \ + const typeof(y) _y = y; \ + \ + (void) (&_x == &_y); \ + \ + _x > _y ? _x : _y; \ + }) +#endif #ifndef _MAX_PATH /* FIXME: These are supposed to be in stdlib.h only */ here's the output (the list of types mismatches in min/max calls...) to whomever feels like fixing them (if needed) registry.c:386: warning: comparison of distinct pointer types lacks a cast registry.c:1246: warning: comparison of distinct pointer types lacks a cast trace.c:69: warning: comparison of distinct pointer types lacks a cast trace.c:147: warning: comparison of distinct pointer types lacks a cast reg.c:177: warning: comparison of distinct pointer types lacks a cast reg.c:195: warning: comparison of distinct pointer types lacks a cast reg.c:209: warning: comparison of distinct pointer types lacks a cast reg.c:224: warning: comparison of distinct pointer types lacks a cast reg.c:232: warning: comparison of distinct pointer types lacks a cast reg.c:306: warning: comparison of distinct pointer types lacks a cast reg.c:318: warning: comparison of distinct pointer types lacks a cast reg.c:328: warning: comparison of distinct pointer types lacks a cast reg.c:379: warning: comparison of distinct pointer types lacks a cast reg.c:416: warning: comparison of distinct pointer types lacks a cast reg.c:496: warning: comparison of distinct pointer types lacks a cast dos_fs.c:2201: warning: comparison of distinct pointer types lacks a cast dos_fs.c:2202: warning: comparison of distinct pointer types lacks a cast drive.c:926: warning: comparison of distinct pointer types lacks a cast file.c:1884: warning: comparison of distinct pointer types lacks a cast profile.c:120: warning: comparison of distinct pointer types lacks a cast module.c:1644: warning: comparison of distinct pointer types lacks a cast module.c:1645: warning: comparison of distinct pointer types lacks a cast heap.c:645: warning: comparison of distinct pointer types lacks a cast local.c:401: warning: comparison of distinct pointer types lacks a cast local.c:891: warning: comparison of distinct pointer types lacks a cast registry.c:507: warning: comparison of distinct pointer types lacks a cast version.c:477: warning: comparison of distinct pointer types lacks a cast int21.c:857: warning: comparison of distinct pointer types lacks a cast int21.c:861: warning: comparison of distinct pointer types lacks a cast ole2nls.c:435: warning: comparison of distinct pointer types lacks a cast process.c:1251: warning: comparison of distinct pointer types lacks a cast process.c:1276: warning: comparison of distinct pointer types lacks a cast process.c:1312: warning: comparison of distinct pointer types lacks a cast process.c:1345: warning: comparison of distinct pointer types lacks a cast console.c:170: warning: comparison of distinct pointer types lacks a cast console.c:429: warning: comparison of distinct pointer types lacks a cast console.c:982: warning: comparison of distinct pointer types lacks a cast console.c:984: warning: comparison of distinct pointer types lacks a cast console.c:1294: warning: comparison of distinct pointer types lacks a cast console.c:1345: warning: comparison of distinct pointer types lacks a cast registry.c:785: warning: comparison of distinct pointer types lacks a cast registry.c:1001: warning: comparison of distinct pointer types lacks a cast registry.c:1082: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:203: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:229: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:230: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:1702: warning: comparison of distinct pointer types lacks a cast dde/misc.c:1963: warning: comparison of distinct pointer types lacks a cast message.c:962: warning: comparison of distinct pointer types lacks a cast resource.c:320: warning: comparison of distinct pointer types lacks a cast resource.c:370: warning: comparison of distinct pointer types lacks a cast text.c:318: warning: comparison of distinct pointer types lacks a cast menu.c:847: warning: comparison of distinct pointer types lacks a cast menu.c:849: warning: comparison of distinct pointer types lacks a cast menu.c:917: warning: comparison of distinct pointer types lacks a cast menu.c:918: warning: comparison of distinct pointer types lacks a cast menu.c:931: warning: comparison of distinct pointer types lacks a cast cursoricon.c:519: warning: comparison of distinct pointer types lacks a cast timer.c:155: warning: comparison of distinct pointer types lacks a cast winpos.c:1811: warning: comparison of distinct pointer types lacks a cast winpos.c:1812: warning: comparison of distinct pointer types lacks a cast winproc.c:1755: warning: comparison of distinct pointer types lacks a cast winproc.c:1768: warning: comparison of distinct pointer types lacks a cast winproc.c:1901: warning: comparison of distinct pointer types lacks a cast winpos.c:1733: warning: comparison of distinct pointer types lacks a cast winpos.c:1734: warning: comparison of distinct pointer types lacks a cast winpos.c:1738: warning: comparison of distinct pointer types lacks a cast winpos.c:1739: warning: comparison of distinct pointer types lacks a cast winpos.c:1743: warning: comparison of distinct pointer types lacks a cast winpos.c:1744: warning: comparison of distinct pointer types lacks a cast winpos.c:1748: warning: comparison of distinct pointer types lacks a cast winpos.c:1749: warning: comparison of distinct pointer types lacks a cast winpos.c:1815: warning: comparison of distinct pointer types lacks a cast winpos.c:1816: warning: comparison of distinct pointer types lacks a cast winpos.c:1817: warning: comparison of distinct pointer types lacks a cast winpos.c:1818: warning: comparison of distinct pointer types lacks a cast xfont.c:3336: warning: comparison of distinct pointer types lacks a cast xfont.c:3339: warning: comparison of distinct pointer types lacks a cast lolvldrv.c:106: warning: comparison of distinct pointer types lacks a cast mmsystem.c:986: warning: comparison of distinct pointer types lacks a cast comboex.c:395: warning: comparison of distinct pointer types lacks a cast listview.c:723: warning: comparison of distinct pointer types lacks a cast listview.c:780: warning: comparison of distinct pointer types lacks a cast listview.c:3123: warning: comparison of distinct pointer types lacks a cast listview.c:7940: warning: comparison of distinct pointer types lacks a cast propsheet.c:145: warning: comparison of distinct pointer types lacks a cast propsheet.c:1998: warning: comparison of distinct pointer types lacks a cast rebar.c:1476: warning: comparison of distinct pointer types lacks a cast rebar.c:1490: warning: comparison of distinct pointer types lacks a cast tab.c:1080: warning: comparison of distinct pointer types lacks a cast toolbar.c:1086: warning: comparison of distinct pointer types lacks a cast treeview.c:1500: warning: comparison of distinct pointer types lacks a cast treeview.c:1594: warning: comparison of distinct pointer types lacks a cast treeview.c:2514: warning: comparison of distinct pointer types lacks a cast treeview.c:2516: warning: comparison of distinct pointer types lacks a cast treeview.c:4218: warning: comparison of distinct pointer types lacks a cast treeview.c:4351: warning: comparison of distinct pointer types lacks a cast treeview.c:4356: warning: comparison of distinct pointer types lacks a cast midi.c:117: warning: comparison of distinct pointer types lacks a cast audio.c:774: warning: comparison of distinct pointer types lacks a cast audio.c:1759: warning: comparison of distinct pointer types lacks a cast midi.c:618: warning: comparison of distinct pointer types lacks a cast midi.c:968: warning: comparison of distinct pointer types lacks a cast internet.c:489: warning: comparison of distinct pointer types lacks a cast -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

2 2

Winsock API
by Robert Lunnon 15 Sep '01

15 Sep '01

I have Converted WSAIOCTL to use SIOCGETIFCONF ioctl calls rather than parse /proc which is to linux-centric but I was asked by Francois Gouget to look at trying to make WsControl unix independent by implementing it using other windows APIs rather than by using unix calls directly. Unfortunately this API is a bit of a mess because WsControl can return the MAC Adress but WSAIoctl doesn't appear to implement that functionality. To get The MAC Address we then need to make an appropriate UNIX IOCTL call for which we need the interface name, which isn't available from WSAIoctl either. There are other ways in windows to getthe MAC address via an SNMP call but I'm not sure how that is implemented (Possibly with a call back to WSControl) I don't see then how WSControl can be implemented without the present hacks and duplicated code between WSAIoclt and WSControl helper functions. My proposal then would be... 1.) Separate out all the unix centric helper functions for WSControl and WSAIoctl into a common ancestor source file with no windows dependencies. This should remove the ugly socket hack in WSControl, both libraries still end up with private copies of the common helper functions but since they are all derived from the same common source file it will at least be encapsulated and easier to maintain. 2.) The doco for WSIoctl indicate the encoding for the Ioctl op-code allows for a "Standard" unix IOCTL to be passed to WSIoctl ostensibly for FIONREAD,FIONBIO et al, with predictable results. If I were to implement SIOCGETIFCONF in WsIoctl then this would allow a pass-through so I could get what I need from the host OS without disturbing current windows programs. Because windows doesn't define SIOCGETIFCONF whatever we choose for the value of the op-code might end up being used by Microsoft later, breaking Wine. (Possible but not very likely) Opinions ?

1 0

Information Request For Porting WINE
by Lucien LaCroix 15 Sep '01

15 Sep '01

I would like to find out if the development of WINE supports it being ported to Windows 16-Bit OS. Currently, I am developing a Windows Clone and would very much ike to work on Porting WINE to Win16. However, I am not 100% sure if the way WINE operates wether it would work. WINE will work if it is a complete re-written library system that merely interfaces with the host system. WINE won't work if it serves as a translater from host system system calls to the guest application. Any information on this plus a good compiler that is usefull for someone who knows a bit, but not everything, hopefully one with a good GUI. Thank-You. David Scherer, lacroixlucien(a)hotmail.com _________________________________________________________________ Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp

2 1

Re: Bug: loss of mousepointer
by Alexandre Julliard 14 Sep '01

14 Sep '01

Marcus Meissner <marcus(a)jet.franken.de> writes: > After last nights CVS commits, the Mousepointer appears not to be visible > in some applications in both managed and unmanaged mode. > > Reproducable for me with sol.exe and winmine.exe (16bit) for instance. This should fix it I think: Index: windows/nonclient.c =================================================================== RCS file: /opt/cvs-commit/wine/windows/nonclient.c,v retrieving revision 1.84 diff -u -r1.84 nonclient.c --- windows/nonclient.c 2001/08/24 00:26:59 1.84 +++ windows/nonclient.c 2001/09/14 17:20:00 @@ -1729,7 +1729,8 @@ */ LONG NC_HandleSetCursor( HWND hwnd, WPARAM wParam, LPARAM lParam ) { - if (hwnd != (HWND)wParam) return 0; /* Don't set the cursor for child windows */ + if (hwnd != WIN_GetFullHandle( (HWND)wParam )) + return 0; /* Don't set the cursor for child windows */ switch(LOWORD(lParam)) { -- Alexandre Julliard julliard(a)winehq.com

1 0

IE 5.01
by Nick Hudson 14 Sep '01

14 Sep '01

Greetings, Well i know ill get flamed for this but has anyone got IE 5.01 installed on wine? Everytime I try it gives me an error that "Some programs hasnt finished and that I need to let it finish and restart my computer" Then it closes. So any ideo on getting any version of IE installed? Thanks Nick Hudson

2 1

GDI_CheckNotLock strikes again
by Dmitry Timoshkov 14 Sep '01

14 Sep '01

Hello. Decided to try sample program which uses GetGlyphOutline. Backtrace: =>0 0x400d2ae1 (_CheckNotSysLevel+0x51(lock=0x407bb6a4) [syslevel.c:153] in libntdll.so) (ebp=405b6734) 1 0x407a2667 (GDI_CheckNotLock+0x1b [gdiobj.c:446] in libgdi32.so) (ebp=405b6744) 2 0x40798a1c (DeleteDC+0x48(hdc=0x8bc) [dc.c:784] in libgdi32.so) (ebp=405b6764) 3 0x407983b9 (RestoreDC+0x13d(hdc=0x8a0, level=0x1) [dc.c:541] in libgdi32.so) (ebp=405b6790) 4 0x4078ba4b (PATH_StrokePath+0x28b(dc=0x403a1640, pPath=0x403a16a0) [path.c:1511] in libgdi32.so) (ebp=405b67b4) 5 0x4078baf0 (StrokeAndFillPath+0x64(hdc=0x8a0) [path.c:1547] in libgdi32.so) (ebp=405b67d4) 6 0x004016c6 (DrawPath+0xb6(hDC=0x8a0) [C:\DevStudio\Projects\Glyph\Glyph.c:434] in C:\Glyph.exe) (ebp=405b683c) 7 0x00401c77 (DrawTTOutline+0x527(hDC=0x8a0, lpHeader=0x403a1c10, size=0xffffffff) [C:\DevStudio\Projects\Glyph\Glyph.c:618] in C:\Glyph.exe) (ebp=405b68c8) 8 0x00402023 (OutputGlyph+0x243(hDC=0x8a0, letter=0x21, x=0x0, y=0x0, ascent=0x78) [C:\DevStudio\Projects\Glyph\Glyph.c:724] in C:\Glyph.exe) (ebp=405b6970) 9 0x0040225f (PaintIt+0x14f(hWnd=0x10021, hDC=0x8a0) [C:\DevStudio\Projects\Glyph\Glyph.c:806] in C:\Glyph.exe) (ebp=405b6a48) 10 0x00402701 (MainWndProc+0x351(hWnd=0x10021, message=0xf, wParam=0x0, lParam=0x0) [C:\DevStudio\Projects\Glyph\Glyph.c:958] in C:\Glyph.exe) (ebp=405b6b30) 11 0x406e8507 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405b6b54) 12 0x406e85a0 (WINPROC_CallWndProc+0x8c(proc=0x401028, hwnd=0x10021, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:172] in libuser32.so) (ebp=405b6b84) 13 0x406edcfd (WINPROC_CallProc32WTo32A+0x8d(func=0x401028, hwnd=0x10021, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2434] in libuser32.so) (ebp=405b6bac) 14 0x406ee237 (CallWindowProcW+0x93(func=0x40f80871, hwnd=0x10021, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2685] in libuser32.so) (ebp=405b6bd4) 15 0x4068a6c9 (call_window_proc+0xb5(hwnd=0x10021, msg=0xf, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1108] in libuser32.so) (ebp=405b6c24) 16 0x4068b23c (SendMessageTimeoutW+0xc4(hwnd=0x10021, msg=0xf, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405b6ca8) [message.c:1508] in libuser32.so) (ebp=405b6c78) 17 0x4068b4b0 (SendMessageW+0x38(hwnd=0x10021, msg=0xf, wparam=0x0, lparam=0x0) [message.c:1577] in libuser32.so) (ebp=405b6cac) 18 0x406d6a03 (RDW_Paint+0xbf(wndPtr=0x4039f0cc, hrgn=0x0, flags=0x180, ex=0x0) [painting.c:780] in libuser32.so) (ebp=405b6ce0) 19 0x406d6f40 (RedrawWindow+0x398(hwnd=0x10021, rectUpdate=0x0, hrgnUpdate=0x0, flags=0x180) [painting.c:974] in libuser32.so) (ebp=405b6d4c) 20 0x406d703d (UpdateWindow+0x21(hwnd=0x10021) [painting.c:1006] in libuser32.so) (ebp=405b6d68) 21 0x0040297e (InitInstance+0x6e(hInstance=0x400000, nCmdShow=0xa) [C:\DevStudio\Projects\Glyph\Glyph.c:1051] in C:\Glyph.exe) (ebp=405b6dc4) 22 0x004029e0 (WinMain+0x30(hInstance=0x400000, hPrevInstance=0x0, lpCmdLine=0x40360c45, nCmdShow=0xa) [C:\DevStudio\Projects\Glyph\Glyph.c:1087] in C:\Glyph.exe) (ebp=405b6e3c) 23 0x00402f53 (WinMainCRTStartup+0x113 [crt0.c:198] in C:\Glyph.exe) (ebp=405b6ecc) 24 0x400cec3d (start_process+0x195 [process.c:390] in libntdll.so) (ebp=405b6f30) 25 0x400d252c (SYSDEPS_DoCallOnStack+0x20(func=0x400ceaa8, arg=0x0) [sysdeps.c:183] in libntdll.so) (ebp=405b6ff0) 26 0x400d25d3 (SYSDEPS_CallOnStack+0x2f in libntdll.so) (ebp=bffffa3c) 27 0x400d2680 (SYSDEPS_SwitchToThreadStack+0x94(func=0x400ceaa8) [sysdeps.c:238] in libntdll.so) (ebp=bffffa78) 28 0x400cefce (PROCESS_InitWine+0x1ca(argc=0x2, argv=0xbffffaf4, win16_exe_name=0x804c620, win16_exe_file=0x804c724) [process.c:522] in libntdll.so) (ebp=bffffa90) 29 0x0804b1e6 (Letext [main.c] in wine) (ebp=bffffaa8) 30 0x402769cb (__libc_start_main+0xff(main=0x804b1cc, argc=0x2, argv=0xbffffaf4, init=0x80486d4, fini=0x804b224, rtld_fini=0x4000aea0, stack_end=0xbffffaec) [libc-start.c:92] in libc.so.6) (ebp=bffffac8) 31 0x08049021 (_start+0x21 in wine) (ebp=00000000) -- Dmitry.

2 3

Bug: loss of mousepointer
by Marcus Meissner 14 Sep '01

14 Sep '01

Hi, After last nights CVS commits, the Mousepointer appears not to be visible in some applications in both managed and unmanaged mode. Reproducable for me with sol.exe and winmine.exe (16bit) for instance. Ciao, Marcus

1 0

Re: unmanaged windows
by Alexandre Julliard 14 Sep '01

14 Sep '01

Bobby Bingham <uhmmmm(a)ameritech.net> writes: > I think there was a discussion a while back about possibly rewriting the > "unmanaged" mode (or adding a new mode, I don't recall which) to make it more > like XMMS, but I can't find it now. This would really help on my system, as > with KDE 2.2, wine windows are always on top and on every desktop and XMMS > fits in a little better. I was wondering what the result if any, of that > discussion was. I was planning to implement that as part of the new window management stuff. But this is on hold at the moment while I'm finishing the shared window handles. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Problem with specmaker
by Guy L. Albertelli 13 Sep '01

13 Sep '01

-----Original Message----- From: Patrik Stridvall <ps(a)leissner.se> To: 'eric pouech' <eric.pouech(a)wanadoo.fr>; Guy L. Albertelli <galberte(a)neo.lrun.com> Cc: Wine Devel <wine-devel(a)winehq.com> Date: Thursday, September 06, 2001 5:59 PM Subject: RE: Problem with specmaker > >Hmm. Thinking, modifying etc. > >What about this? > >Index: wine/tools/specmaker/function_grep.pl >=================================================================== >RCS file: /home/wine/wine/tools/specmaker/function_grep.pl,v >retrieving revision 1.1 >diff -u -u -r1.1 function_grep.pl >--- wine/tools/specmaker/function_grep.pl 2001/01/04 19:45:50 1.1 >+++ wine/tools/specmaker/function_grep.pl 2001/09/06 21:50:26 <snip> No the above patch merely resulted in an infinite loop. After much consultation with "Perl in a Nutshell", I came up with the following patch. The header file in question is "shlobj.h". The patch has two sections. First gets rid of the \n imbeded with the lookahead for preprocessor statements. The second gets rid of the ICOM_DEFINE statement (poorly I know) because it has no ";". This seems to make things work and generate correct headers. Thanks, Guy

1 0

dlls/advapi32/crypt.c
by Morten Welinder 13 Sep '01

13 Sep '01

Someone added code to CryptGenRandom so that it generates very bad random data (with <10 bits randomness in them). Don't do that. It's a known security risk. Read from /dev/urandom instead. If that does not succeed, just abort(). Linux and newer Solaris have /dev/urandom. I would guess the BSDs have it too. Morten

2 1

wcs* functions within Wine
by Huw D M Davies 13 Sep '01

13 Sep '01

Hi, I want to use wcsrchr and wcstrol in oleaut32.dll . If I just use them then we do indeed call the ntdll versions rather than libc which is all very nice. The question is, what include file am I supposed to use to get their protoypes? Huw.

1 0

unmanaged windows
by Bobby Bingham 13 Sep '01

13 Sep '01

I think there was a discussion a while back about possibly rewriting the "unmanaged" mode (or adding a new mode, I don't recall which) to make it more like XMMS, but I can't find it now. This would really help on my system, as with KDE 2.2, wine windows are always on top and on every desktop and XMMS fits in a little better. I was wondering what the result if any, of that discussion was. Bobby Bingham -- Microsoft Windows: Made for the internet The Internet: Made for UNIX

1 0

Re: negative listview column width in WinZip 8.0
by Malte Starostik 13 Sep '01

13 Sep '01

Am Thursday 13 September 2001 03:37 schrieben Sie: > WinZip 8.0 requests a negative column width for one of the columns in > the WinZip classic Zip file contents list. This stuffs up the list, > causing the other columns to be overwritten, and resulting in a blank > list. > > This patch prevents column widths from being negative. AFAIK, -1 and -2 and maybe others are special values that tell the list view to adjust the contents to the widest item and something else I cannot remember exactly (sorry, no Windows available ATM). -- Malte Starostik PGP: 1024D/D2F3C787 [C138 2121 FAF3 410A 1C2A 27CD 5431 7745 D2F3 C787] http://malte.homeip.net/justice-not-war.html M0ò0ò0

1 0

winedump prints a strange export table
by Francois Gouget 13 Sep '01

13 Sep '01

If I run 'winedump dump ws2_32.dll -j export' I get a strange result: ... 00000000 125 <by ordinal> 00000000 126 <by ordinal> 00000000 127 <by ordinal> 00000000 128 <by ordinal> ... Are these really significant? It seems like they go all the way up to the highest ordinal of a 'real' exported function, here 500, WEP. Also if I run 'winedump dump msvcrt.dll -j export -C' winedump seems to crash. It looks like it tries to interpret mangled names as glibc mangled names? Hmm, '-C' seems to have trouble even with other dlls. Christian Jiresjö expressed interest in working on winedump (see bug #91), maybe these would be good bugs for him to takle. Btw eric, thanks for the thread patch in winedbg. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

1 0

HAVE_IPX cleanup
by Francois Gouget 12 Sep '01

12 Sep '01

This patch attempts to clean up the ws_sockaddr_ipx to sockaddr_ipx conversions (and vice versa). I would really like if people could try this out: I don't have a working IPX network here. At least my very rudimentary tests indicate that this should still work for the TCP/IP case. More details on the patch: * all ws_sockaddr structures must be considered to have a potentially different layout from their Unix counterparts. Sure for now we just borrow the Unix structs anyway but even sockaddr_in does not have the exact same fields on FreeBSD and Linux (although the binary layout is the same). And hopefully we will not borrow the Unix structs for long anyway. FreeBSD testing is another aspect I would appreciate help with (sin_len worries me). * the ws_sockaddr_ipx fields did not match those used by windows. Also ws_sockaddr_ipx was declared in the wrong header. * all conversions are now done in two functions: ws_sockaddr_ws2u and ws_sockaddr_u2ws. If there is a conversion to do then these are the only two places that should be affected. SUPPORTED_PF returns whether a given protocol family is supported or not. * the sockaddr* pointers may point to structures that are more than 16 bytes, typically 28 bytes for IP v6. I tried to take this into account, I hope I did not mess up (but I'm not sure Wine would support TCP/IP v6 anyway). * I modified WSOCK32_accept to call WSOCK32_getpeername thus avoiding the conversion issue entirely in WSOCK32_accept. * all other functions that were doing such conversions were modified to use the above functions. I also tried to make the error handling code more consistent wrt. WSAENOTSOCK, WSAEAFNOSUPPORT, etc. * removed ugly casts in the traces -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

1 0

Russian keyboard layout
by Andriy Palamarchuk 12 Sep '01

12 Sep '01

Hello everybody, I want to fix message about not found keyboard layout for my configuration. The FIXME message is not shown after I add a phantom key definition to russian keyboard layout main_key_RU in file windows/x11drv/keyboard.c I need your advise how to do it correctly. Should I change existing layout - main_key_RU or it is better to add a separate one with phantom key - main_key_RU_phantom, like it is presently done for US layouts? I could not suppress the FIXME message by changing keyboard model in XF86Config from "pc102" to "pc101". My system: Wine release 20010824, installed without Windows, gcc version 2.96 20000731 (Red Hat Linux 7.1 2.96-81) The layout, defined in XF86Config is "ru(winkeys)". Thank you, Andriy Palamarchuk

1 0

Solaris winsock support
by Robert Lunnon 12 Sep '01

12 Sep '01

Trying Eudora 4.3 on Solaris solicits this error err:winsock:WsControl Unable to open /proc filesystem to determine number of network interfaces! Looking about in the code WsControl grubs about in the /proc filesystem to get the names of, and count the number of network interfaces. Since /Proc only hosts processes on Solaris this constitutes a linux dependancy we don't need. Studying the ifconfig source gives another possibility instead which look like it may be more portable using ioctl SIOCGIFCONF on an arbitrary IP socket The return from this call is a structure containing the length of the reply buffer, which seems to contains an array of ifreq structures (one for each interface) which contains among other things the name of the interface. By dividing the size of the buffer by the size of the returned objects we know how many interfaces there are... Questions Anyone know if this is Is this workable ? Is this workable on linux, (I ask because I don't have linux and don't know linux ioctl implementation details)?

3 2

X output problem while displaying splash screen
by Andreas Schuldei 12 Sep '01

12 Sep '01

The part of the screen where the splash screen of the internet explorer should be displayed freezes, but the debug messages keep scrolling for some time. That is why I send the whole output. I used the command line wine -dll=ole2,ole2conv,ole2disp,ole2nls,ole32,oleaut32,olecli,olecli32,olecnv32,oledlg,olepro32,olesvr,olesvr32,olethk32,compobj,rpcrt4,shell,shell32,shfolder,shdocvw,commdlg,comdlg32,commctrl,comctl32,urlmon,SHLWAPI=n .wine/fake_windows/Program\ Files/Internet\ Explorer/IEXPLORE.EXE --debugmsg +relay,+x11

1 0

Re: Focus livelock
by Alexandre Julliard 11 Sep '01

11 Sep '01

Gerard Patel <gerard.patel(a)nerim.net> writes: > Now, when after all this the X events are processed, Wine handles a X > focusin event for A, that is generating a WM_GETFOCUS, then a focusout > for A, generating other WM_KILLFOCUS and WM_ GETFOCUS, > focusin for B, etc..; the sequence of events when creating windows is > perfect, but there are extra events after. > > IMO what's wrong is that X focus events are not ignored when they are the > following of program action. IMO the right fix is to add support for the take focus window manager protocol, and avoid messing with the X focus ourselves. This is somewhere on my todo list... -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Dialog painting
by Niclas Karlsson MATE 10 Sep '01

10 Sep '01

> Wine currently seems to have a problem painting splash dialogs properly > (or at all). I took a closer look at this. I just ripped out the interesting parts from Speak freely in order to find a simple program exhibiting the problems. What I ended up with was a program which does nothing interesting except to show a simple dialg using CreateDialog(). It still doesn't work under Wine. The source is attached. I'm somewhat at a loss about what to do now. I'm just not clear about what should happen and why it doesn't. Some browsing around in the source suggests that it may related to the focus problems Gerard has been talking about, but I'm far from sure. Any comments? Nicke -- -[ nkarlsso(a)abo.fi ]- Seek simplicity, and distrust it. (A. Whitehead)

1 0

Developer offering to help.
by Marco Bizzarri 10 Sep '01

10 Sep '01

Hi all. I've seen in the recent past a task list for newbie developer for wine. I would like to know what are still open, how I could contribute. I've very few skills in Windows development. However, I've good knowledge of development under linux, and usage of gnu tools (autoconf). Bye Marco -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588

2 1

Re: Focus livelock
by Gerard Patel 10 Sep '01

10 Sep '01

At 10:09 AM 09/09/2001 +0300, you wrote: >I posted a patch that would fix a focus related livelock. >However, I have to admit that the patch is quite hacky and likely >not to be included in Wine. Since I would like to get this bug fixed, >I thought to ask opinions about the correct way to fix the bug. > >The short description of the bug is that setting >active/foreground/focus window in Wine calls >X11DRV_SetFocus, which calls XSetInputFocus. >This makes Wine receive FocusIn event, the handler of >which calls SetForegroundWindow. Even though SetForegroundWindow >does nothing if its parameter matches current foreground window, >it can be easily seen that having more than one window can lead >into livelock. I think that the problem with focus is that when a window is shown by Wine, synthetic WM_GETFOCUS and WM_SETFOCUS events are generated, that are themselves generating X focus events. The X events are kept in the X queue until Wine finds time to handle them. Wine creates window A : WM_GETFOCUS for A Wine creates window B : WM_KILLFOCUS for A, WM_GETFOCUS for B Wine creates window C : WM_KILLFOCUS for B, WM_GETFOCUS for C Now, when after all this the X events are processed, Wine handles a X focusin event for A, that is generating a WM_GETFOCUS, then a focusout for A, generating other WM_KILLFOCUS and WM_ GETFOCUS, focusin for B, etc..; the sequence of events when creating windows is perfect, but there are extra events after. IMO what's wrong is that X focus events are not ignored when they are the following of program action. The following hack disables focus handling in this case. I have no clue on its value since I am currently struggling with other bugs. and I will not come to these problems until some time - maybe a lot of time if current Wine progress (aka regressions :-)) continues. --- event.c.orig Fri Aug 24 09:30:46 2001 +++ event.c Mon Sep 10 13:00:28 2001 @@ -534,6 +534,8 @@ if (!hWnd) return; + if (!event->send_event) return; + bIsDisabled = GetWindowLongA( hWnd, GWL_STYLE ) & WS_DISABLED; /* If the window has been disabled and we are in managed mode, HTH Gerard

1 0

Re: Monkey Island 3
by Gerard Patel 10 Sep '01

10 Sep '01

At 03:11 PM 09/09/2001 +0200, you wrote: >The installation of Curse of Monkey Island seems to be broken in latest >CVS. All I get is a dialog saying that setup requires a different version >of Windows. > >A trace is available on the web at >http://www.lysator.liu.se/~johane/monkey3.txt > >/Johan Gill, johane(a)lysator.liu.se > I have looked at your trace -the app is trying to use a Win32s function. Maybe the problem is that it succeeds. However, Win32s is present in Wine since years and has not been touched since a long time. I think unlikely that it could be a new problem - when was the last working Wine version before current Cvs ? You can find in documentation/cvs-regression a few tips on how to search for the exact date of a regression. FYI the Wine app database list this game as 'playing perfectly directly off the CD' :-) Gerard

1 0

Re: [PATCH] DestroyWindow16
by Gerard Patel 10 Sep '01

10 Sep '01

At 06:40 PM 30/08/2001 +0200, you wrote: >Gerard Patel wrote: >> >> As DestroyWindow does a lot of handle comparaisons, it is necessary >> to give it a real 32 bit handle. This avoids a systematic crash when >> ForteFreeAgent 16 bit exits. I have not looked for other places where >> this can be necessary - but it would not be surprising that this happens. >perhaps as an extension of the relay code ? >(it would mean typing >correctly >windows handles in spec files though) What do you mean by typing ? There is no hwnd type in the spec files, AFAICT. That's not a matter of typing GetWindow(hwnd word) instead of GetWindow(word word) - I think it is necessary to actually change winebuild to define a new type and write a bunch of code to support it. I have looked at the points where it current cvs crashes and it's necessary to fix 16 to 32 bits handles and I have found that 2 changes cure all my new crashes : the one in DestroyWindow16 and another in DefWindowProc16 The reason for these problems is the same : Wine is keeping window handles in several variables (active window, focus window) and Wine code does several comparisons between applications provided handles and these values. In the last case for example, the test /* activate hwndTop if needed. */ if (hwndTop != GetActiveWindow()) { in focus.c fails because of the high word part (and creates an infinite focus loop) I'd say that by adding also handle fixes in SetWindowPos16, SetFocus16 and SetActiveWindow16 as well as fixing the handles setters in queue.c, everything would be covered. IMO your solution is 1) somewhat complex for a fix to apps not widely used anymore 2) overkill because it's not necessary to convert window handles for each and every Api. OTOH your solution is more elegant. I don't know what to do. Gerard

1 0

Dialog painting
by Niclas Karlsson MATE 10 Sep '01

10 Sep '01

Hello! Wine currently seems to have a problem painting splash dialogs properly (or at all). Is this a known problem (with a known cause)? An open source program exhibiting problems of this kind would be Speak Freely (http://www.fourmilab.ch/speakfree/windows/). I will try to single out the cause of the problem when I get a little spare time, unless the cause is already known that is. Also, I haven't used Wine for some time so I don't know if this is a long-standing problem. The version I used was a cvs snapshot from last friday before the commits. Cheers, Nicke -- -[ nkarlsso(a)abo.fi ]- Seek simplicity, and distrust it. (A. Whitehead)

1 0

Monkey Island 3
by Johan Gill 09 Sep '01

09 Sep '01

The installation of Curse of Monkey Island seems to be broken in latest CVS. All I get is a dialog saying that setup requires a different version of Windows. A trace is available on the web at http://www.lysator.liu.se/~johane/monkey3.txt /Johan Gill, johane(a)lysator.liu.se

1 0

what if MS is forced to publish all API's?
by Scott Bradford 09 Sep '01

09 Sep '01

with all the discussion going on in the press about what to do with Microsoft to remove their Monopoly power or at least see to it that they don't abuse their power, how to folks here feel about forcing them to release all their API's? I'm not a programmer myself, but it's my understanding that not having access to the API's is what makes wine such a challenge. If this is the case, would getting access to the MS API's allow Wine to be completed? I feel that a MS breakup wouldn't have done much to change things because they can still give information only to whom they choose, leaving MS to decide who can play and who can't. Having other ways to run the application base of windows software would remove the need to run windows itself, and in my mind, this is the easiest way to remove monopoly power of MS. What do you folks, the Wine developers, think should be done to MS?

1 0

Focus livelock
by Jukka Heinonen 09 Sep '01

09 Sep '01

I posted a patch that would fix a focus related livelock. However, I have to admit that the patch is quite hacky and likely not to be included in Wine. Since I would like to get this bug fixed, I thought to ask opinions about the correct way to fix the bug. The short description of the bug is that setting active/foreground/focus window in Wine calls X11DRV_SetFocus, which calls XSetInputFocus. This makes Wine receive FocusIn event, the handler of which calls SetForegroundWindow. Even though SetForegroundWindow does nothing if its parameter matches current foreground window, it can be easily seen that having more than one window can lead into livelock. This happens repeatably every time you start Colonization for Windows. I'm currently thinking about calling directly some WINPOS_* routine from X11 FocusIn handler instead of SetForegroundWindow. If the routine acted exactly like SetForegroundWindow except it made sure that it causes no calls to X11DRV_SetFocus, focus problem would be fixed. Unfortunately I have not figured any good way to pass an extra flag to default handler for WM_ACTIVATE, so that the routine would call something like SetFocus_DontCallDriver instead of regular SetFocus... -- Jukka Heinonen <http://www.iki.fi/jhei/>

1 0

Re: Option to disable XVidMode
by Ove Kaaven 08 Sep '01

08 Sep '01

On Fri, 7 Sep 2001, François Gouget wrote: > > I had a report of a crash and it turned out to happen during the > XVidMode initialization. > What happened is that for some unknown reason XF86VidModeGetAllModeLines > returned a single mode with a width and/or height of zero > (htotal/vtotal). This caused a division by zero in convert_modeline. Last time this happened, we considered this a bug in the X server, as under these circumstances, xvidtune also crashes. > Then will come the work of trying to reproduce the problem and see > how best to deal with this server (XFree86-SVGA 4.1.0 apparently). I don't think such a server exists. There's either XFree86 4.x with loadable driver modules, or there's XFree86-SVGA 3.x. The latter sounds more likely to have this kind of bug.

2 2

Re: ukrainian layout
by Dmitry Timoshkov 08 Sep '01

08 Sep '01

"Andy Rysin" <arysin(a)yahoo.com> wrote: > Also I had to modify unicode/cp20866.c (KOI8-R) to allow conversion > of additional 4 pair of letters in Ukrainian language (KOI8-U, > RFC2319) as well as one additional pair of letters for Belorussian > language (AKA KOI8-RU, which does not have RFC though). > Strictly speaking KOI8-R is a subset (if not to take to account > pseudographics) of KOI8-U wich is a subset of KOI8-RU. > That's why I applied it to cp20866.c instead of creating smth new. > (I took it from my patches for linux kernel nls system) You can't modify cp*.c files, they are auto generated from the unicode.org file set. You need to send your patch to the unicode.org maintainers and hopefully it will be included in the next Unicode Standard release. > Another problem is that I could not test it practiacally because for > some reason Win32 programs under wine does not input cyrillic > letters, but if I swicth to X program and then back it stops input at > all if layout is cyrillic. If I swicth back to latin everything's ok. It's a known problem, that Wine's x11 keyboard driver does not work with "non-sticky" switches. I have tested cyrillic input with XFree86 3.3.6, 4.0.3 and 4.1.0 with KDE and KiKbd, all works fine for me. Proper support for non-sticky modifiers, dead-keys and the real keyboard layout support requires almost complete keyboard driver rewrite. > BTW, why not to take layouts from X system itself? > Those wich are under /etc/X11/xkb/symbols Because XFree86 is not the only X11 implementation out there. -- Dmitry.

2 2

Re: Make cmdline writable (cmdline4)
by Alexandre Julliard 08 Sep '01

08 Sep '01

Francois Gouget <fgouget(a)free.fr> writes: > In the case below. Works on Win98 but not in Wine. I believe the > reason is that Windows does not need to modify the command line anyway. In some cases it does; for instance your test program should fail under NT when using Unicode. Do you have a real app that requires this? -- Alexandre Julliard julliard(a)winehq.com

3 2

WM_[LR]BUTTON{DOWN,DBLCLK} in menus
by Bobby Bingham 08 Sep '01

08 Sep '01

I was writing a stupid app to help my friend learn to use menus in windows apps. It would call TrackPopupMenu on a WM_LBUTTONDOWN message. After some experimentation, I found that if I leftclicked in the client are, the menu would appear, as it should. But if, while the menu was still active, I leftclicked in the window's nonclient area (titlebar), the menu would appear elsewhere. By clicking the menu receives a WM_LBUTTONDOWN message, and determines that it should close the menu as it's not inside the menu, and it doesn't remove the message. This is normally fine, but if the click falls on the nonclient area of a window, the message should not be passed through. I believe this also applies to WM_LBUTTONDBLCLK, and the right button equivalents. Is there an easy way to determine what window the click would be passed through to, so we can check if it'll be in the client area or not? Bobby Bingham -- Microsoft Windows: Made for the internet The Internet: Made for UNIX

1 0

Re: Problems with WM_PAINT and threads
by Alexandre Julliard 07 Sep '01

07 Sep '01

Ove Kaaven <ovehk(a)ping.uio.no> writes: > After Wine dispatches this WM_PAINT message from the wrong thread, > 3DMark2000 fails to locate its thread-local data, gets confused, and > crashes. Does this help? Index: windows/win.c =================================================================== RCS file: /opt/cvs-commit/wine/windows/win.c,v retrieving revision 1.147 diff -u -r1.147 win.c --- windows/win.c 2001/08/29 00:16:00 1.147 +++ windows/win.c 2001/09/07 19:34:24 @@ -387,15 +387,17 @@ hwndRet = pWnd->hwndSelf; /* look among siblings if we got a transparent window */ - while (pWnd && ((pWnd->dwExStyle & WS_EX_TRANSPARENT) || - !(pWnd->hrgnUpdate || (pWnd->flags & WIN_INTERNAL_PAINT)))) + while (pWnd) { + if (!(pWnd->dwExStyle & WS_EX_TRANSPARENT) && + (pWnd->hrgnUpdate || (pWnd->flags & WIN_INTERNAL_PAINT)) && + GetWindowThreadProcessId( pWnd->hwndSelf, NULL ) == GetCurrentThreadId()) + { + hwndRet = pWnd->hwndSelf; + WIN_ReleaseWndPtr(pWnd); + break; + } WIN_UpdateWndPtr(&pWnd,pWnd->next); - } - if (pWnd) - { - hwndRet = pWnd->hwndSelf; - WIN_ReleaseWndPtr(pWnd); } TRACE("found %04x\n",hwndRet); return hwndRet; -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Bugs involving returning strings from API functions
by Alexandre Julliard 07 Sep '01

07 Sep '01

"Justin Santa Barbara" <justinsb(a)hotmail.com> writes: > As I see it, the advantage of a helper function is that for about the same > amount of work of fixing GetSystemDirectory and GetCurrentDirectory, all the > functions should work the same way meaning any bugs would quickly be found. > It might also be possible to optimize the case where buflen=0, while this > isn't practical per-function. Should I offer a patch only for wine/files/* > ? I'm afraid there are too many variations to make this useful. It would be nice if all APIs that return strings behaved the same way, but unfortunately this is not the case: some count the terminating null, some don't, some copy partial strings when the buffer is too small, some don't copy anything, etc. We would need about as many helpers as there are API functions. Also be aware that the MSDN doc cannot be trusted at all on this matter, the correct behavior needs to be verified for each function. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Make cmdline writable (cmdline4)
by Alexandre Julliard 07 Sep '01

07 Sep '01

Francois Gouget <fgouget(a)free.fr> writes: > No I don't have a 'real world' exemple where this is a problem. I > became aware of the issue because of warnings when I was working on > dlls/msvcrt/process.c: system is const char* so I made msvcrt_spawn > const char* but then I had to add a cast when calling CreateProcessA > (see second hunk of cmdline3). The cast is wrong, we should do a copy there. CreateProcess takes a char*, not a const char*. Casting off the const and relying on CreateProcess to not modify the string is broken. Even better would be to convert the string to Unicode and call CreateProcessW; this would avoid a copy (well, right now it will cost an extra copy, but that's because CreateProcess should be fixed to do everything in Unicode). -- Alexandre Julliard julliard(a)winehq.com

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel