- wine-devel - winehq.org

[PATCH 0/1] MR172: dlls/win32u: fix gcc12's warnings (UB)
by eric pouech (＠epo) 16 Jun '22

16 Jun '22

GCC12.* emits tons of warnings when compiling win32'u sysparam bits These warnings stem from: - a union of different structures - allocating one instance of these structure and casting its address to a pointer to the union. This is UB as the whole union should be allocated in order to be a valid object. I tried to keep the original goals: - don't overallocate individual structures - have an OO design (and avoid casting back & forth arguments in methods) and implemented this fix by transforming (as argument to most of the methods) - a pointer to an union of structs into - an union (passed by value) of pointers to structs Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/172

3 4

[PATCH v4 0/6] MR73: Improvement in PDB's types record handling
by eric pouech (＠epo) 16 Jun '22

16 Jun '22

This serie tackles several issues encountered while loading PDB files through dbghelp. It happens that PDB allows to have several type records for user defined types (struct / enums) with the same name. This seems to be generated by a) compiler (when modifying a structure definition between several compilation phases), b) the incremental linker (likely an optimisation of previous case, but not 100% certain when it's triggered). Wine's dbghelp ended up not picking the right record, hence generating errneous outputs. This series: - cleans up some PDB related code - update winedump to display the PDB hash table internals - fixes dbghelp to preserve in Wine's dbghelp hash table the partial order between type records of same name. v2: - rebased - removed a bunch of stray comments -- v4: dlls/dbghelp{pdb}: use remap table from PDB hash stream dlls/dbghelp{pdb}: ensure dbghelp's list order in hash table matches PDB's dlls/dbghelp{pdb}: clearly separate the type loading into two passes include/wine/mscvpdb.h: redefine property with bitfields dlls/dbghelp{pdb}: rely on first/last index from type header tools/winedump{pdb}: explore a bit more TPI hash elements https://gitlab.winehq.org/wine/wine/-/merge_requests/73

2 8

[PATCH 0/3] MR224: Fix GCC12 warnings
by eric pouech (＠epo) 16 Jun '22

16 Jun '22

Fixes a couple of warnings emitted by GCC12 compiler -- https://gitlab.winehq.org/wine/wine/-/merge_requests/224

2 4

Wiki guidance on taking function prototypes from ReactOS
by Alex Henrie 16 Jun '22

16 Jun '22

Yesterday I came across a bug report [1] with an attached patch to stub out the function RtlGetFullPathName_UEx, which is not documented by Microsoft, based on its prototype in ReactOS. Alexandre left the comment: [2] "You should not look at ReactOS code at all, a lot of it is reverse-engineered using methods that are not appropriate for Wine. It's not a usable source of information for us." The patch author, Ben, replied: [3] "I just want the WIKI to be MUCH more definitive/precise on what IS and IS NOT allowed." I took a look and as it currently stands, the wiki clearly encourages collaboration with ReactOS in at least one place: [4] "If you're still resisting the switch to unix for some reason though, you may have some luck investigating ReactOS (they cooperate with us on API issues too)." And it clearly discourages collaboration with ReactOS in at least one place: [5] "it appears that all such documentation is derived from ReactOS, which is not considered a legally safe source for use in Wine." Mention of ReactOS is conspicuously absent from the page that outlines Wine's "clean room" guidelines. [6] Since Alexandre says that Wine developers shouldn't look at ReactOS code at all, I think we should remove from the wiki all references that might be construed to encourage it and add some more that discourage it. Does anyone have any further thoughts before I start editing? -Alex [1] https://bugs.winehq.org/show_bug.cgi?id=50464 [2] https://bugs.winehq.org/show_bug.cgi?id=50464#c6 [3] https://bugs.winehq.org/show_bug.cgi?id=50464#c7 [4] https://wiki.winehq.org/Cygwin_and_More [5] https://wiki.winehq.org/AFD [6] https://wiki.winehq.org/Clean_Room_Guidelines

2 1

[PATCH 0/1] MR256: ntdll: Do not open directory file when setting the same directory path.
by Paul Gofman (＠gofman) 16 Jun '22

16 Jun '22

Fixes The Rising of The Shield Hero: Relieve the Animation hangs on start (and maybe something else with ENIGMA protector). The protector implements virtual file system which hotpatches a lot of file related functions, in particular, NtOpenFile(). When NtOpenFile() is called from RtlSetCurrentDirectory_U() with peb lock held the hotpatcher takes its own lock and that can deadlock with other threads performing file / path operations ending up in get_full_path_helper() which also takes PEB lock. Once the hotpatcher is initialized the game only sets "." or the same full path as current and may do that rather often. It seems that reopening the file handle for the same directory is redundant anyway, so probably makes sense to just avoid that part. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/256

3 2

[PATCH 0/4] MR233: win32u: Partially move raw input APIs.
by Zebediah Figura (＠zfigura) 16 Jun '22

16 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/233

5 26

[PATCH v4 0/1] MR134: ntdll: Don't hard-code the battery and AC adapter names on Linux
by Alex Henrie (＠alexhenrie) 16 Jun '22

16 Jun '22

Look through all of the devices in /sys/class/power_supply and take the statistics from the first battery and the first AC adapter. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52831 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- v4: ntdll: Don't hard-code the battery and AC adapter names on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/134

2 3

[PATCH v2 0/5] MR131: wined3d: Introduce wined3d_device_check_format_support().
by Chip Davis (＠cdavis5e) 15 Jun '22

15 Jun '22

Signed-off-by: Chip Davis <cdavis5x(a)gmail.com> -- v2: wined3d: Record format UAV capabilities. d3d11: Support D3D11_FEATURE_FORMAT_SUPPORT2. d3d11: Support D3D11_FEATURE_FORMAT_SUPPORT. d3d11: Reimplement ID3D11Device::CheckFormatSupport() using wined3d_device_check_format_support(). wined3d: Introduce wined3d_device_check_format_support(). https://gitlab.winehq.org/wine/wine/-/merge_requests/131

6 16

[PATCH v6 0/1] MR167: d3drm: IDirect3DRMMeshBuilder3::Load support loading from resource
by Alistair Leslie-Hughes (＠alesliehughes) 15 Jun '22

15 Jun '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v6: d3drm: Pass all D3DRM_LOAD* flags directly through to CreateEnumObject() in IDirect3DRMMeshBuilder3::Load(). https://gitlab.winehq.org/wine/wine/-/merge_requests/167

4 3

[PATCH 0/1] MR254: winex11.drv: Change order register_extension for WGL_ARB_pixel_format_float.
by Sebastián Aedo (＠saedo) 15 Jun '22

15 Jun '22

Some processes use very naive string matching when detecting extensions, for example, Cossacks III checks if the extension is "contained" in the current extension is checking, causing that `WGL_ARB_pixel_format` is contained in `WGL_ARB_pixel_format_float`, but it ends up with the flag deactivated because they aren't the same. This makes it consistent with the behavior on winemac.drv/opengl.c too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/254

2 1

[PATCH 1/4] httpapi/tests: Move sleep statement.
by Julian Klemann 15 Jun '22

15 Jun '22

The mentioned bug randomly occurred after some subsequent patches, so the sleep should happen before GetOverlappedResult is called. Signed-off-by: Julian Klemann <jklemann(a)codeweavers.com> --- dlls/httpapi/tests/httpapi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/httpapi/tests/httpapi.c b/dlls/httpapi/tests/httpapi.c index be1d31c12ad..9d344f26d02 100644 --- a/dlls/httpapi/tests/httpapi.c +++ b/dlls/httpapi/tests/httpapi.c @@ -228,10 +228,6 @@ static void test_v1_server(void) ret = send(s, req_text, strlen(req_text), 0); ok(ret == strlen(req_text), "send() returned %d.\n", ret); - ret = GetOverlappedResult(queue, &ovl, &ret_size, TRUE); - ok(ret, "Got error %lu.\n", GetLastError()); - ok(ret_size > sizeof(*req), "Got size %lu.\n", ret_size); - /* Various versions of Windows (observed on 64-bit Windows 8 and Windows 10 * version 1507, but probably affecting others) suffer from a bug where the * kernel will report success before completely filling the buffer or @@ -239,6 +235,10 @@ static void test_v1_server(void) * around this. */ Sleep(100); + ret = GetOverlappedResult(queue, &ovl, &ret_size, TRUE); + ok(ret, "Got error %lu.\n", GetLastError()); + ok(ret_size > sizeof(*req), "Got size %lu.\n", ret_size); + ok(!req->Flags, "Got flags %#lx.\n", req->Flags); ok(req->ConnectionId, "Expected nonzero connection ID.\n"); ok(req->RequestId, "Expected nonzero connection ID.\n"); -- 2.36.1

2 7

[PATCH v5 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v5: uiautomationcore: Add basic IAccessible2 support. ia2comproxy: Introduce new proxy stub DLL for IAccessible2. include: Import IAccessible2 headers. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 4

Re: [PATCH v5 0/6] MR228: d3dx: improvements to texture creation functions - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/228

1 0

Re: [PATCH v5 0/7] MR212: d3d11: Create dxgi resource objects for textures and buffers. - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/212

1 0

Re: [PATCH v2 0/8] MR250: win32u: user32 conversion - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/250

1 0

Re: [PATCH v2 0/3] MR251: cryptnet: - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/251

1 0

[PATCH v3 0/9] MR180: misc: Fixes and workarounds for UAF warnings. (GCC12)
by Rémi Bernon (＠rbernon) 15 Jun '22

15 Jun '22

The mscoree one is a genuine UAF bug, other are more arguably false positive but GCC doesn't like freed pointer value to be used in any way. -- v3: server: Avoid using pointer value after realloc. d3drm: Avoid using pointer value after free. dsound: Avoid using pointer value after free. notepad: Avoid using pointer value after free. msi: Avoid using pointer value after free. user32/tests: Workaround use after free warnings. oleaut32/tests: Workaround use after free warnings. mshtml/tests: Avoid using pointer value after free. mscoree: Avoid using pointer after free. https://gitlab.winehq.org/wine/wine/-/merge_requests/180

3 10

Re: [PATCH v2 0/1] MR245: iphlpapi: Return ERROR_NO_DATA from GetIpNetTable() if no entries are found. - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/245

1 0

[PATCH v3 0/1] MR134: ntdll: Don't hard-code the battery and AC adapter names on Linux
by Alex Henrie (＠alexhenrie) 15 Jun '22

15 Jun '22

Look through all of the devices in /sys/class/power_supply and take the statistics from the first battery and the first AC adapter. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52831 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- v3: ntdll: Don't hard-code the battery and AC adapter names on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/134

4 5

[PATCH v4 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v4: uiautomationcore: Add basic IAccessible2 support. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 5

[PATCH v4 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) 15 Jun '22

15 Jun '22

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v4: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 8

[PATCH v3 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v3: uiautomationcore: Add basic IAccessible2 support. ia2comproxy: Introduce new proxy stub DLL for IAccessible2. include: Import IAccessible2 headers. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 6

Re: [PATCH v4 0/7] MR212: d3d11: Create dxgi resource objects for textures and buffers. - approved
by Zebediah Figura (＠zfigura) 15 Jun '22

15 Jun '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/212

1 0

[PATCH] include: Remove duplicate ICodecAPI::GetParameterValues function
by Andrew Eikum 15 Jun '22

15 Jun '22

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- include/icodecapi.idl | 1 - 1 file changed, 1 deletion(-) diff --git a/include/icodecapi.idl b/include/icodecapi.idl index 7954b3fc2f6..dc31daf2e2c 100644 --- a/include/icodecapi.idl +++ b/include/icodecapi.idl @@ -42,7 +42,6 @@ interface ICodecAPI : IUnknown HRESULT GetParameterRange ([in] const GUID *api, [out] VARIANT *min, [out] VARIANT *max, [out] VARIANT *delta); HRESULT GetParameterValues ([in] const GUID *api, [out, size_is(,*count)] VARIANT **values, [out] ULONG *count); - HRESULT GetParameterValues ([in] const GUID *api, [out, size_is(,*count)] VARIANT **values, [out] ULONG *count); HRESULT GetDefaultValue ([in] const GUID *api, [out] VARIANT *value); HRESULT GetValue ([in] const GUID *api, [out] VARIANT *value); -- 2.36.1

1 0

[PATCH 0/1] MR249: include: Emit CFI directives when building on Mac with gcc.
by Stefan Dösinger (＠stefan) 15 Jun '22

15 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53157 Building with FSF gcc on mac is possible and the only way to get a --without-mingw build since clang does not support -mabi=ms. (Some hacks are needed to build winemac.drv.so though.) Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- No, FSF gcc on macos does not define __GCC_HAVE_DWARF2_CFI_ASM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/249

3 3

[tools 0/6] Known failures tracking
by Francois Gouget 15 Jun '22

15 Jun '22

This patchset provides support for tracking known failures in the TestBot results. The main goal is to avoid false positives but there are some side benefits as well: * The job reports sent to developers link to the relevant WineHQ bugs which gives them more exposure and may help get them fixed faster. * The failure details pages will eventually link to all the tasks where the failure happened, which could be valuable to find patterns. * The failure page tracks when it was last seen. This simplifies spotting bugs which are fixed and could be closed. (Or failures where the regular expression needs to be updated / fixed) The patchset mostly follows the scheme described in bug 48912: https://bugs.winehq.org/show_bug.cgi?id=48912 There are some differences though: * The bug envisionned this scheme purely as a blacklist to avoid false positives. The implementation can certainly be used in this way but it is not limited to failures that cause false positives. Tracking other failures can provide the side benefits mentionned above. The only limit is the maintenance work required to track more failures. * As a consequence the FailureBlacklist class was renamed to Failure, and the FailureBlacklistUses was renamed to TaskFailures since it links Tasks with the related Failures. * The FailureBlacklistVMs purpose is not really described in the bug but I think the goal was to provide a way to deckare that the failure is expected to only happen on specific test configurations. Instead the Failures class has a ConfigRegExp regular expression which specifies which test configurations the failure applies to. The test 'configuration name' is of the form 'VM:logfile' which allows matching specific Windows versions (thanks to the TestBot VM naming scheme), specific Windows locales (part of the VM name), specific bitnesses (part of the log filename), or specific Wine locales (part of the log filename). For instance: ^w8 -> all Windows 8 VMs :exe -> all Windows tests (exe32.report and exe64.report) ^w10.*_ja.*: -> all Windows 10 Japanese test configurations win|wow -> all Wine test configurations (win32.report, ...) (win|wow).*_fr -> French Wine test configurations * Changes in FailureBlacklists -> Failures - Primary key: (Bug, TestModule, TestUnit) -> Id Some issues generate quite a few failures. So in case trying to match them all results in a regular expression that's too long (either because of the database limit or for readability), this change makes it possible to add multiple Failure objects to track them all. - TestModule -> ErrorGroup The .errors files split the errors in groups. Each group corresponds to a test module, but extra errors (too much output, missing summary lines, etc) are in a separate group. So I renamed TestModule to ErrorGroup as a reminder to the coder that this is meant to match the .errors group names, not just test modules. - Name -> (BugStatus, BugDescription) Instead of having a name describing the failure, this patchset uses the corresponding WineHQ bug description. The TestBot also retrieves the bug status which allows checking that closed bugs dont happen anymore, or open bugs that should be closed. - LastUsed -> (LastNew, LastOld) The LastUse field was split into LastNew and LastOld to track whether the failure would cause false positives without the known failures support. * Changes in FailureBlacklistUses -> TaskFailures - (Bug, TestModule, TestUnit) -> FailureId This is a consequence of the Failure primary key change described above. - () -> (TaskLog) This allows tracking which task log the failure was found in. This is quite important for Wine tasks since they run all the test configurations in just one task. - () -> (NewCount, OldCount) This provides a count of matching failures and whether they would have been tagged as old or new without this patchset. This provides a quick way to know whether there is the same number of failures every time or whether the number of failures changes from one run to the next. It also provides a quick way to know how many failures to look for when jumping to the log. Francois Gouget (6): testbot: Add tables to track the test failures. testbot/web: Add pages to add, edit and show known failures. testbot: Match the failures with the test logs. testbot/web: Link job details to the related known failures. testbot/WineSendLog: Take into account the known failures. testbot/UpdateFailures: Add a script to refresh the failures' bug information. testbot/bin/UpdateFailures.pl | 192 ++++++ testbot/bin/WineSendLog.pl | 78 ++- testbot/ddl/update47.sql | 33 + testbot/ddl/winetestbot.sql | 32 + testbot/doc/INSTALL.txt | 5 + testbot/doc/winetestbot-schema.dia | 852 +++++++++++++++++++++--- testbot/lib/WineTestBot/CGI/PageBase.pm | 1 + testbot/lib/WineTestBot/Config.pm | 6 +- testbot/lib/WineTestBot/Failures.pm | 184 +++++ testbot/lib/WineTestBot/Jobs.pm | 6 + testbot/lib/WineTestBot/LogUtils.pm | 180 ++++- testbot/lib/WineTestBot/TaskFailures.pm | 120 ++++ testbot/lib/WineTestBot/Tasks.pm | 4 + testbot/web/FailureDetails.pl | 119 ++++ testbot/web/FailuresList.pl | 160 +++++ testbot/web/JobDetails.pl | 54 +- testbot/web/WineTestBot.css | 3 + 17 files changed, 1907 insertions(+), 122 deletions(-) create mode 100755 testbot/bin/UpdateFailures.pl create mode 100644 testbot/ddl/update47.sql create mode 100644 testbot/lib/WineTestBot/Failures.pm create mode 100644 testbot/lib/WineTestBot/TaskFailures.pm create mode 100644 testbot/web/FailureDetails.pl create mode 100644 testbot/web/FailuresList.pl -- 2.30.2

1 6

[PATCH v4 0/1] MR190: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail).
by Jinoh Kang (＠iamahuman) 15 Jun '22

15 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52673 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v4: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail). https://gitlab.winehq.org/wine/wine/-/merge_requests/190

3 2

[PATCH v3 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) 15 Jun '22

15 Jun '22

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v3: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. d3dx10/tests: Add D3DX10CreateTextureFromMemory HRESULT argument tests. d3dx10: Don't ignore HRESULT parameter in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 9

[PATCH 0/8] MR250: win32u: user32 conversion
by Jacek Caban (＠jacek) 15 Jun '22

15 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/250

4 14

[PATCH v2 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v2: uiautomationcore: Add basic IAccessible2 support. ia2comproxy: Introduce new proxy stub DLL for IAccessible2. include: Import IAccessible2 headers. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

4 8

[PATCH 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 8

[PATCH 0/3] MR251: cryptnet:
by Hans Leidekker (＠hans) 15 Jun '22

15 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/251

2 3

[PATCH v2 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) 15 Jun '22

15 Jun '22

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v2: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 17

[PATCH v2 0/1] MR190: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail).
by Jinoh Kang (＠iamahuman) 15 Jun '22

15 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52673 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail). https://gitlab.winehq.org/wine/wine/-/merge_requests/190

3 2

Re: [PATCH v2 0/1] MR248: winhttp: Release object on allocation failure. - closed
by Hans Leidekker (＠hans) 15 Jun '22

15 Jun '22

This merge request was closed by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/248

1 0

[PATCH 0/1] MR248: winhttp: Release object on allocation failure.
by Hans Leidekker (＠hans) 15 Jun '22

15 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/248

2 1

[PATCH v2 0/1] MR134: ntdll: Don't hard-code the battery and AC adapter names on Linux
by Alex Henrie (＠alexhenrie) 15 Jun '22

15 Jun '22

Look through all of the devices in /sys/class/power_supply and take the statistics from the first battery and the first AC adapter. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52831 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- v2: ntdll: Don't hard-code the battery and AC adapter names on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/134

4 5

[PATCH 0/1] MR245: iphlpapi: Return ERROR_NO_DATA from GetIpNetTable() if no entries are found.
by Paul Gofman (＠gofman) 15 Jun '22

15 Jun '22

Fixes SCP: Secret Laboratory crash on launch after recent game update. Windows normally returns some entries even if there is no active network connection. I however was able to test no data case on the up to date Windows 10 by disabling all the network adapters and clearing arp cache with 'arp -d *'. So GetIpNetTable() returns ERROR_INSUFFICIENT_BUFFER when called without buffer (first time in test) with some excessive buffer size. But then when called with the buffer it returns ERROR_NO_DATA and sets number of entries in the table to 0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/245

3 2

[PATCH v3 1/5] d2d1/tests: Add more test xml.
by Ziqing Hui 15 Jun '22

15 Jun '22

Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> --- dlls/d2d1/tests/d2d1.c | 120 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 112 insertions(+), 8 deletions(-) diff --git a/dlls/d2d1/tests/d2d1.c b/dlls/d2d1/tests/d2d1.c index bc662b4f8ae..970706bc569 100644 --- a/dlls/d2d1/tests/d2d1.c +++ b/dlls/d2d1/tests/d2d1.c @@ -99,6 +99,17 @@ L"<?xml version='1.0'?> \ </Effect> \ "; +static const WCHAR *effect_xml_inputs_attribute = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs min='1' max='10' deadbeef='abcdef'/> \ + </Effect> \ +"; + static const WCHAR *effect_xml_without_version = L"<Effect> \ <Property name='DisplayName' type='string'/> \ @@ -170,6 +181,90 @@ L"<?xml version='1.0'?> \ </Effect> \ "; +static const WCHAR *effect_xml_wrong_type = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string' value='TestEffect'/> \ + <Property name='Author' type='uint32' value='32'/> \ + <Property name='Category' type='string' value='Test'/> \ + <Property name='Description' type='string' value='Test effect.'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_duplicate_property = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_lower_case_effect = +L"<?xml version='1.0'?> \ + <effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs/> \ + </effect> \ +"; + +static const WCHAR *effect_xml_lower_case_property = +L"<?xml version='1.0'?> \ + <Effect> \ + <property name='DisplayName' type='string'/> \ + <property name='Author' type='string'/> \ + <property name='Category' type='string'/> \ + <property name='Description' type='string'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_lower_case_inputs = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_min_max_inputs_a = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Property name='MinInputs' type='uint32' value='1'/> \ + <Property name='MaxInputs' type='uint32' value='2'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_min_max_inputs_b = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs> \ + <Property name='Min' type='uint32' value='1'/> \ + <Property name='Max' type='uint32' value='2'/> \ + </Inputs> \ + </Effect> \ +"; + + static const DWORD test_vs[] = { #if 0 @@ -10604,10 +10699,11 @@ static void test_effect_register(BOOL d3d11) } xml_tests[] = { - {effect_xml_a, S_OK}, - {effect_xml_b, S_OK}, - {effect_xml_c, S_OK}, - {effect_xml_minimum, S_OK}, + {effect_xml_a, S_OK}, + {effect_xml_b, S_OK}, + {effect_xml_c, S_OK}, + {effect_xml_minimum, S_OK}, + {effect_xml_inputs_attribute, S_OK}, {effect_xml_without_version, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, {effect_xml_without_inputs, E_INVALIDARG}, {effect_xml_without_name, E_INVALIDARG}, @@ -10615,6 +10711,13 @@ static void test_effect_register(BOOL d3d11) {effect_xml_without_category, E_INVALIDARG}, {effect_xml_without_description, E_INVALIDARG}, {effect_xml_without_type, E_INVALIDARG}, + {effect_xml_wrong_type, E_INVALIDARG}, + {effect_xml_duplicate_property, E_INVALIDARG}, + {effect_xml_lower_case_effect, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, + {effect_xml_lower_case_property, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, + {effect_xml_lower_case_inputs, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, + {effect_xml_min_max_inputs_a, E_INVALIDARG}, + {effect_xml_min_max_inputs_b, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, }; const D2D1_PROPERTY_BINDING binding[] = @@ -10926,10 +11029,11 @@ static void test_effect_properties(BOOL d3d11) } system_property_tests[] = { - {effect_xml_a, L"TestEffectA", effect_author, effect_category, effect_description, 1, 1}, - {effect_xml_b, L"TestEffectB", effect_author, effect_category, effect_description, 1, 1}, - {effect_xml_c, L"TestEffectC", effect_author, effect_category, effect_description, 1, 1}, - {effect_xml_minimum, L"", L"" ,L"", L"", 0, 0}, + {effect_xml_a, L"TestEffectA", effect_author, effect_category, effect_description, 1, 1}, + {effect_xml_b, L"TestEffectB", effect_author, effect_category, effect_description, 1, 1}, + {effect_xml_c, L"TestEffectC", effect_author, effect_category, effect_description, 1, 1}, + {effect_xml_minimum, L"", L"" ,L"", L"", 0, 0}, + {effect_xml_inputs_attribute, L"", L"" ,L"", L"", 0, 0}, }; if (!init_test_context(&ctx, d3d11)) -- 2.25.1

2 6

[PATCH v6 0/9] MR217: windows.media.speech: ISpeechSynthesisStream stub implementation.
by Bernhard Kölbl (＠besentv) 14 Jun '22

14 Jun '22

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v6: windows.media.speech: Add stub ISpeechSynthesisStream iface. windows.media.speech: Return IAsyncOperation from synthesizer_SynthesizeSsmlToStreamAsync. windows.media.speech: Return IAsyncOperation from synthesizer_SynthesizeTextToStreamAsync. windows.media.speech/tests: Add basic tests for ssml/text to stream functions. windows.media.speech/tests: Handle a possible race condition. windows.media.speech/tests: Remove a useless thread id trace. include/windows.media.speechsynthesis.idl: Update file to newer formatting. include/windows.media.idl: Move IMediaMarker collections from speechsynthesis. include/windows.media.idl: Update file to newer formatting. https://gitlab.winehq.org/wine/wine/-/merge_requests/217

4 15

Re: [PATCH v3 0/3] MR241: uiautomationcore: Test fix and MSAA provider navigation patches. - approved
by Alexandre Julliard (＠julliard) 14 Jun '22

14 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/241

1 0

Re: [PATCH v2 0/1] MR243: winhttp: Fix default port corner cases in WinHttpCrackUrl(). - approved
by Alexandre Julliard (＠julliard) 14 Jun '22

14 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/243

1 0

Re: [PATCH v3 0/5] MR240: win32u: menu conversion - approved
by Alexandre Julliard (＠julliard) 14 Jun '22

14 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/240

1 0

Re: [PATCH v2 0/6] MR226: winegstreamer: Leave stream_cs when calling the async reader callbacks. - approved
by Alexandre Julliard (＠julliard) 14 Jun '22

14 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/226

1 0

Re: [PATCH v2 0/1] MR149: user32: Plug icon handle leak in MDI_AugmentFrameMenu (Coverity). - approved
by Alexandre Julliard (＠julliard) 14 Jun '22

14 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/149

1 0

[PATCH 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu (＠insn) 14 Jun '22

14 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/246

2 1

[PATCH v5 0/9] MR217: windows.media.speech: ISpeechSynthesisStream stub implementation.
by Bernhard Kölbl (＠besentv) 14 Jun '22

14 Jun '22

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v5: windows.media.speech: Add stub ISpeechSynthesisStream iface. windows.media.speech: Return IAsyncOperation from synthesizer_SynthesizeSsmlToStreamAsync. windows.media.speech: Return IAsyncOperation from synthesizer_SynthesizeTextToStreamAsync. windows.media.speech/tests: Add basic tests for ssml/text to stream functions. windows.media.speech/tests: Handle a possible race condition. windows.media.speech/tests: Remove a useless thread id trace. include/windows.media.speechsynthesis.idl: Update file to newer formatting. include/windows.media.idl: Move IMediaMarker collections from speechsynthesis. include/windows.media.idl: Update file to newer formatting. https://gitlab.winehq.org/wine/wine/-/merge_requests/217

3 10

[PATCH 0/2] MR244: winex11.drv: Keep GLX pbuffer alive while its drawable is used
by Paul Gofman (＠gofman) 14 Jun '22

14 Jun '22

Other drawable types are ref counted and destroyed only when nothing (e. g., existing contexts) reference them anymore, making sure that if we have a context referencing drawable the GLX drawable is still valid. That was probably left behind for PBuffers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/244

2 2

[tools] testbot/WineSendLog: Tweak the job report emails.
by Francois Gouget 14 Jun '22

14 Jun '22

Don't assume that jobs coming from the patches website necessarily have a sender email address. Update the patches website in all cases. Also mark a patch as failed in the patches website when the job has skipped tasks or TestBot errors. Clearly identify the new failures in the report sent to the developer. Provide more details about the job result, particularly TestBot errors, the presence of skipped tasks, and consequences. Call for help fixing preexisting failures. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/bin/WineSendLog.pl | 340 ++++++++++++++++++++++++------------- testbot/tests/TestWTBS | 7 +- 2 files changed, 226 insertions(+), 121 deletions(-) diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl index 9351d5d6f..3897ac034 100755 --- a/testbot/bin/WineSendLog.pl +++ b/testbot/bin/WineSendLog.pl @@ -173,146 +173,220 @@ sub SendLog($) { my ($Job) = @_; - my $To = $WinePatchToOverride || $Job->GetEMailRecipient(); - if (! defined($To)) - { - return; - } - - my $StepsTasks = CreateStepsTasks(undef, $Job); - my $SortedStepsTasks = $StepsTasks->GetSortedItems(); - - my $JobURL = MakeOfficialURL("/JobDetails.pl?Key=". $Job->GetKey()); - - # - # Send a job summary and all the logs as attachments to the developer + # Collect and count the new and old failures, etc. # - Debug("-------------------- Developer email --------------------\n"); - my $Sendmail; - if ($Debug) - { - open($Sendmail, ">>&=", 1); - } - else - { - open($Sendmail, "|-", "/usr/sbin/sendmail -oi -t -odq"); - } - print $Sendmail "From: $RobotEMail\n"; - print $Sendmail "To: $To\n"; - my $Subject = "TestBot job " . $Job->Id . " results"; - my $Description = $Job->GetDescription(); - if ($Description) - { - $Subject .= ": " . $Description; - } - print $Sendmail "Subject: $Subject\n"; - if ($Job->Patch and $Job->Patch->MessageId) - { - print $Sendmail "In-Reply-To: ", $Job->Patch->MessageId, "\n"; - print $Sendmail "References: ", $Job->Patch->MessageId, "\n"; - } + my (@New, $JobInfo); + my ($NewCount, $OldCount, $BotCount, $NotRun) = (0, 0, 0, 0); + my $FileType = "test executable"; - print $Sendmail "\n"; - print $Sendmail "VM Status Failures Command\n"; + my $StepsTasks = CreateStepsTasks(undef, $Job); + my $SortedStepsTasks = $StepsTasks->GetSortedItems(); foreach my $StepTask (@$SortedStepsTasks) { - my $TestFailures = $StepTask->TestFailures; - $TestFailures = "" if (!defined $TestFailures); - my $Status = $StepTask->Status; - $Status = $TestFailures ? "failed" : "success" if ($Status eq "completed"); - my $Cmd = ""; - $Cmd = $StepTask->FileName ." " if ($StepTask->FileType =~ /^exe/); - $Cmd .= $StepTask->CmdLineArg if (defined $StepTask->CmdLineArg); - - printf $Sendmail "%-20s %-8s %-8s %s\n", $StepTask->VM->Name, $Status, - $TestFailures, $Cmd; - } - - print $Sendmail "\nThe full results can be found at:\n$JobURL\n\n"; + if ($StepTask->Status =~ /^(?:canceled|skipped)$/) + { + $NotRun++; + next; + } - # Print the job summary - my $JobErrors; - foreach my $StepTask (@$SortedStepsTasks) - { - my $Id = $StepTask->Id; my $TaskDir = $StepTask->GetTaskDir(); my $LogNames = GetLogFileNames($TaskDir); - $JobErrors->{$Id}->{LogNames} = $LogNames; + $JobInfo->{$StepTask->Id}->{LogNames} = $LogNames; + $JobInfo->{$StepTask->Id}->{NewCount} = 0; + $JobInfo->{$StepTask->Id}->{OldCount} = 0; + if ($StepTask->Status eq "boterror") + { + $JobInfo->{$StepTask->Id}->{BotCount} = 1; + $BotCount++; + } + $FileType = "patch" if ($StepTask->FileType eq "patch"); + foreach my $LogName (@$LogNames) { my $LogInfo = LoadLogErrors("$TaskDir/$LogName"); next if (!defined $LogInfo->{BadLog} and !$LogInfo->{ErrCount}); - $JobErrors->{$Id}->{HasErrors} = 1; - $JobErrors->{$Id}->{$LogName} = $LogInfo; - - print $Sendmail "\n=== ", GetTitle($StepTask, $LogName), " ===\n"; - print $Sendmail "$LogInfo->{BadLog}\n" if (defined $LogInfo->{BadLog}); + $JobInfo->{$StepTask->Id}->{$LogName} = $LogInfo; + my $HasLogHeader; foreach my $GroupName (@{$LogInfo->{ErrGroupNames}}) { - print $Sendmail ($GroupName ? "\n$GroupName:\n" : "\n"); + my $HasGroupHeader; my $Group = $LogInfo->{ErrGroups}->{$GroupName}; - print $Sendmail "$_\n" for (@{$Group->{Errors}}); + foreach my $ErrIndex (0..$#{$Group->{Errors}}) + { + if ($Group->{IsNew}->[$ErrIndex]) + { + if (!$HasLogHeader) + { + push @New, "\n=== ". GetTitle($StepTask, $LogName) ." ===\n"; + $HasLogHeader = 1; + } + if (!$HasGroupHeader) + { + push @New, ($GroupName ? "\n$GroupName:\n" : "\n"); + $HasGroupHeader = 1; + } + push @New, "$Group->{Errors}->[$ErrIndex]\n"; + $JobInfo->{$StepTask->Id}->{NewCount}++; + } + else + { + $JobInfo->{$StepTask->Id}->{OldCount}++; + } + } } + $NewCount += $JobInfo->{$StepTask->Id}->{NewCount}; + $OldCount += $JobInfo->{$StepTask->Id}->{OldCount}; } } - close($Sendmail); - - # This is all for jobs submitted from the website - if (!defined $Job->Patch) - { - Debug("Not a mailing list patch -> all done.\n"); - return; - } - # - # Build a job summary with only the new errors + # Send a job summary to the developer # - # Note that this may be a bit inaccurate right after a Wine commit if this - # job's patch got compiled on top of the new Wine before all the reference - # WineTest results were updated. This is made more likely by the job - # priorities: high for Wine updates, and low for WineTest runs. - # However in practice this would only be an issue if the patch reintroduced - # an error that just disappeared in the latest Wine which is highly unlikely. - my @Messages; - foreach my $StepTask (@$SortedStepsTasks) + my $JobURL = MakeOfficialURL("/JobDetails.pl?Key=". $Job->GetKey()); + my $To = $WinePatchToOverride || $Job->GetEMailRecipient(); + if (defined $To) { - my $Id = $StepTask->Id; - next if (!$JobErrors->{$Id}->{HasErrors}); + Debug("-------------------- Developer email --------------------\n"); + my $Sendmail; + if ($Debug) + { + open($Sendmail, ">>&=", 1); + } + else + { + open($Sendmail, "|-", "/usr/sbin/sendmail -oi -t -odq"); + } + print $Sendmail "From: $RobotEMail\n"; + print $Sendmail "To: $To\n"; + my $Subject = "TestBot job " . $Job->Id . " results"; + my $Description = $Job->GetDescription(); + if ($Description) + { + $Subject .= ": " . $Description; + } + print $Sendmail "Subject: $Subject\n"; + if ($Job->Patch and $Job->Patch->MessageId) + { + print $Sendmail "In-Reply-To: ", $Job->Patch->MessageId, "\n"; + print $Sendmail "References: ", $Job->Patch->MessageId, "\n"; + } + print $Sendmail "\nHi,\n\n"; - # Note: We could check $StepTask->Status for TestBot errors. However, - # whether they are caused by the patch or not, they prevent the TestBot - # from checking for new errors which justifies sending an email to the - # mailing list so that the patch receives greater scrutiny. + if ($NewCount) + { + print $Sendmail <<"EOF"; +It looks like your $FileType introduces some new failures. Please +investigate and fix them if they are indeed new. Note that rare +failures and failures with always changing text (e.g. because of memory +addresses) can cause false positives. If this is what happened, then +fixing those would really help. - foreach my $LogName (@{$JobErrors->{$Id}->{LogNames}}) +EOF + } + if ($BotCount) { - my $LogInfo = $JobErrors->{$Id}->{$LogName}; - # Skip if there are no errors - next if (!$LogInfo->{NewCount}); + print $Sendmail <<"EOF"; +$BotCount TestBot errors prevented a full analysis of your $FileType. +If the test caused the operating system (e.g. Windows) to crash or +reboot you will probably have to modify it to avoid that. +Other issues should be reported to the TestBot administrators. - push @Messages, "\n=== ". GetTitle($StepTask, $LogName) ." ===\n"; +EOF + } + elsif (!$NewCount and !$NotRun) + { + print $Sendmail <<"EOF"; +Congratulations! +It looks like your $FileType passed the tests with flying colors. - foreach my $GroupName (@{$LogInfo->{ErrGroupNames}}) +EOF + } + if ($OldCount) + { + print $Sendmail <<"EOF"; +Some preexisting failures (not caused by your $FileType) happened. +If you know how to fix them that would be helpful. + +EOF + } + + print $Sendmail " Failures\n"; + print $Sendmail "VM Status New / Old Command\n"; + foreach my $StepTask (@$SortedStepsTasks) + { + next if ($StepTask->Status =~ /^(?:canceled|skipped)$/); + + my $TestFailures = $StepTask->TestFailures; + $TestFailures = "" if (!defined $TestFailures); + my $Status = $StepTask->Status ne "completed" ? $StepTask->Status : + $TestFailures ? "failed" : + "success"; + my $Cmd = ""; + $Cmd = $StepTask->FileName ." " if ($StepTask->FileType =~ /^exe/); + $Cmd .= $StepTask->CmdLineArg if (defined $StepTask->CmdLineArg); + + printf $Sendmail "%-20s %-8s %4s / %4s %s\n", $StepTask->VMName, + $Status, $JobInfo->{$StepTask->Id}->{NewCount}, + $JobInfo->{$StepTask->Id}->{OldCount}, $Cmd; + } + if ($NotRun) + { + print $Sendmail <<"EOF"; + +Note that $NotRun additional tasks could not be run due to previous +errors. A full run may uncover more issues. + +EOF + } + + print $Sendmail <<"EOF"; + +The full results can be found at: +$JobURL + +Your paranoid android. + +EOF + + # Print the failures + foreach my $StepTask (@$SortedStepsTasks) + { + my $TaskInfo = $JobInfo->{$StepTask->Id}; + my $TaskDir = $StepTask->GetTaskDir(); + foreach my $LogName (@{$TaskInfo->{LogNames}}) { - my $Group = $LogInfo->{ErrGroups}->{$GroupName}; - next if (!$Group->{NewCount}); + my $LogInfo = LoadLogErrors("$TaskDir/$LogName"); + next if (!defined $LogInfo->{BadLog} and !$LogInfo->{ErrCount}); - push @Messages, ($GroupName ? "\n$GroupName:\n" : "\n"); - foreach my $ErrIndex (0..$#{$Group->{Errors}}) + print $Sendmail "\n=== ", GetTitle($StepTask, $LogName), " ===\n"; + print $Sendmail "$LogInfo->{BadLog}\n" if (defined $LogInfo->{BadLog}); + + foreach my $GroupName (@{$LogInfo->{ErrGroupNames}}) { - if ($Group->{IsNew}->[$ErrIndex]) + print $Sendmail ($GroupName ? "\n$GroupName:\n" : "\n"); + my $Group = $LogInfo->{ErrGroups}->{$GroupName}; + foreach my $ErrIndex (0..$#{$Group->{Errors}}) { - push @Messages, "$Group->{Errors}->[$ErrIndex]\n"; + my $Prefix = $Group->{IsNew}->[$ErrIndex] ? "new" : "old"; + print $Sendmail "[$Prefix] $Group->{Errors}->[$ErrIndex]\n"; } } } } + + close($Sendmail); + } + + # This is all for jobs submitted from the website + if (!defined $Job->Patch) + { + Debug("Not a mailing list patch -> all done.\n"); + return; } @@ -322,8 +396,13 @@ sub SendLog($) Debug("\n-------------------- Mailing list email --------------------\n"); - if (@Messages) + if (!$NewCount) { + Debug("Found no error to report to the mailing list\n"); + } + else + { + my $Sendmail; if ($Debug) { open($Sendmail, ">>&=", 1); @@ -333,36 +412,63 @@ sub SendLog($) open($Sendmail, "|-", "/usr/sbin/sendmail -oi -t -odq"); } print $Sendmail "From: $RobotEMail\n"; - print $Sendmail "To: $To\n"; - print $Sendmail "Cc: $WinePatchCc\n"; + if (defined $To) + { + print $Sendmail "To: $To\n"; + print $Sendmail "Cc: $WinePatchCc\n"; + } + else + { + print $Sendmail "To: $WinePatchCc\n"; + } print $Sendmail "Subject: Re: ", $Job->Patch->Subject, "\n"; if ($Job->Patch->MessageId) { print $Sendmail "In-Reply-To: ", $Job->Patch->MessageId, "\n"; print $Sendmail "References: ", $Job->Patch->MessageId, "\n"; } - print $Sendmail <<"EOF"; + print $Sendmail "\nHi,\n\n"; -Hi, + if ($NewCount) + { + print $Sendmail <<"EOF"; +It looks like your $FileType introduced the new failures shown below. +Please investigate and fix them if they are indeed new. Note that rare +failures and failures with always changing text (e.g. because of memory +addresses) can cause false positives. If this is what happened, then +fixing those would really help. -While running your changed tests, I think I found new failures. -Being a bot and all I'm not very good at pattern recognition, so I might be -wrong, but could you please double-check? +EOF + } + if ($BotCount) + { + print $Sendmail <<"EOF"; +$BotCount TestBot errors prevented a full analysis of your $FileType. +If the test caused the operating system (e.g. Windows) to crash or +reboot you will probably have to modify it to avoid that. +Other issues should be reported to the TestBot administrators. -Full results can be found at: +EOF + } + if ($OldCount) + { + print $Sendmail <<"EOF"; +The tests also ran into some preexisting test failures. If you know how +to fix them that would be helpful. See the TestBot job for the details: + +EOF + } + print $Sendmail <<"EOF"; +The full results can be found at: $JobURL Your paranoid android. EOF - print $Sendmail $_ for (@Messages); + print $Sendmail $_ for (@New); close($Sendmail); } - else - { - Debug("Found no error to report to the mailing list\n"); - } # @@ -379,14 +485,14 @@ EOF { # Only take into account new errors to decide whether the job was # successful or not. - DebugTee($Result, "Status: ". (@Messages ? "Failed" : "OK") ."\n"); + DebugTee($Result, "Status: ". ($NewCount + $BotCount + $NotRun ? "Failed" : "OK") ."\n"); DebugTee($Result, "Job-ID: ". $Job->Id ."\n"); DebugTee($Result, "URL: $JobURL\n"); foreach my $StepTask (@$SortedStepsTasks) { my $TaskDir = $StepTask->GetTaskDir(); - foreach my $LogName (@{$JobErrors->{$StepTask->Id}->{LogNames}}) + foreach my $LogName (@{$JobInfo->{$StepTask->Id}->{LogNames}}) { print $Result "=== ", GetTitle($StepTask, $LogName), " ===\n"; DumpLogAndErr($Result, "$TaskDir/$LogName"); diff --git a/testbot/tests/TestWTBS b/testbot/tests/TestWTBS index 139f011ef..5663f956c 100755 --- a/testbot/tests/TestWTBS +++ b/testbot/tests/TestWTBS @@ -611,13 +611,12 @@ sub LoadMbox($) $State->{JobIdLine} = $LineNo; } } - elsif ($Line =~ /^Content-Disposition: attachment; filename=([^-]+)-/) + elsif ($Line =~ /^([a-zA-Z0-9_]+)\s+(?:success|failed)\s+\d+/) { my $VM = $1; - # This could match attachments in other emails $State->{ResVMs}->{$VM}++ if ($State->{HasResEmail}); } - elsif ($Line =~ /I found new failures/) + elsif ($Line =~ /\bintroduces .* new failures\b/) { $State->{HasFailedEmail} = $LineNo; } @@ -1190,7 +1189,7 @@ sub CheckJobTree($;$) my $VMName = $Task->VM->Name; if ($Task->Status !~ /^(?:canceled|skipped)$/ and $Email->{HasResEmail}) { - ok($Email->{ResVMs}->{$VMName}, "Expecting $VMName logs / reports in the job $JobId results email"); + ok($Email->{ResVMs}->{$VMName}, "Expecting a $VMName error summary in the job $JobId results email"); } } -- 2.30.2

1 0

[PATCH v2 0/3] MR241: uiautomationcore: Test fix and MSAA provider navigation patches.
by Connor McAdams (＠cmcadams) 14 Jun '22

14 Jun '22

Opened the previous merge request before the testbot had updated, so it failed to run the tests. Should be updated by now :) -- v2: uiautomationcore: Implement NavigateDirection_{Previous/Next}Sibling for MSAA providers. uiautomationcore: Implement NavigateDirection_{First/Last}Child for MSAA Providers. https://gitlab.winehq.org/wine/wine/-/merge_requests/241

3 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel