- wine-devel - winehq.org

D3D Shaders - how does it work?
by Thomas Berger 17 Jul '17

17 Jul '17

Hi, i'm digging in the shader code for some hours right now, to understand what must be done to fix #41173 [1] and #40873 [2]. Right now, i don't really understand how the declaration of variables works in detail. Is there any documentation how the handling and registering of variables works, or should the could be documentation enough? [1] https://bugs.winehq.org/show_bug.cgi?id=41173 [2] https://bugs.winehq.org/show_bug.cgi?id=40873 Greetings, Thomas

4 5

Re: [PATCH] rsaenh: do not use stack variables out of frame (Coverity)
by Jacek Caban 17 Jul '17

17 Jul '17

On 15.07.2017 10:07, Marcus Meissner wrote: > 1414721 Pointer to local outside scope > > These harmless looking assignments are of the form: > > algid = BCRYPT_SHA512_ALGORITHM; > > with ../../include/bcrypt.h:#define BCRYPT_SHA512_ALGORITHM (const WCHAR []){'S','H','A','5','1','2',0} > this is > algid = temporary allocated stack variable > > The stack array however goes invalid as soon as it leaves the "switch" case. > > Use a stack temporary array to avoid this confusion. This actually shows a huge problem with using (const WCHAR []){ .... } casts in Wine. In this case it's meant to replace L"..." for wide strings and that in mind, affected code is perfectly fine. It's definition in header that is not compatible. Sadly, I don't see a good solution for that. We could just not not use such casts and use static const variables in headers like we do in many other cases, but that has its own problems. Jacek

1 0

Wineconf sponsorship
by Jeremy White 17 Jul '17

17 Jul '17

Hi folks, This is a reminder that the Wine Project uses it's donations to sponsor travel to the annual Wine conference for contributors to Wine. So if you think Wineconf sounds cool, but you can't afford to go, please think again. I can't promise that we'll sponsor everyone, or that we can cover the full cost, but we are very cheerful to try! I'd also invite people that contribute, but perhaps not as developers, to also write in. We are interested in expanding the voices at the conference, and you would be very welcome. You can email me directly to request a sponsorship (or, if you prefer, hit up any of the other committee members - Alexandre, Austin, Marcus, or Michael). Cheers, Jeremy

1 0

Re: [PATCH 3/3] dwrite: Explicitly check rendering parameters pointer passed to DrawGlyphRun()
by Marvin 17 Jul '17

17 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32333 Your paranoid android. === wvistau64 (32 bit font) === font.c:1348: Test failed: Unexpected hr 0. === w2008s64 (32 bit font) === font.c:1348: Test failed: Unexpected hr 0. === w8 (32 bit font) === font.c:5017: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0f04:font: unhandled exception c0000005 at 004278C7 === w864 (32 bit font) === font.c:5017: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0eb0:font: unhandled exception c0000005 at 004278C7 === wvistau64 (64 bit font) === font.c:1348: Test failed: Unexpected hr 0. === w2008s64 (64 bit font) === font.c:1348: Test failed: Unexpected hr 0. === w864 (64 bit font) === font.c:5017: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0e8c:font: unhandled exception c0000005 at 00000000004235C2

1 0

Re: [PATCH 2/3] dwrite: Use antialias mode set for bitmap render target
by Marvin 17 Jul '17

17 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32332 Your paranoid android. === wvistau64 (32 bit font) === font.c:1349: Test failed: Unexpected hr 0. === w2008s64 (32 bit font) === font.c:1349: Test failed: Unexpected hr 0. === w8 (32 bit font) === font.c:5018: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0f54:font: unhandled exception c0000005 at 004278F7 === w864 (32 bit font) === font.c:5018: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0f74:font: unhandled exception c0000005 at 004278F7 === wvistau64 (64 bit font) === font.c:1349: Test failed: Unexpected hr 0. === w2008s64 (64 bit font) === font.c:1349: Test failed: Unexpected hr 0. === w864 (64 bit font) === font.c:5018: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0f9c:font: unhandled exception c0000005 at 00000000004235F2

1 0

Re: [PATCH 1/3] dwrite: Improve rendering parameters validation
by Marvin 17 Jul '17

17 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32331 Your paranoid android. === w8 (32 bit font) === font.c:4957: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0ed8:font: unhandled exception c0000005 at 00427387 === w864 (32 bit font) === font.c:4957: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0f54:font: unhandled exception c0000005 at 00427387 === w864 (64 bit font) === font.c:4957: Test failed: Failed to create glyph run analysis, hr 0x80070057. 0e88:font: unhandled exception c0000005 at 0000000000423152

1 0

Re: [PATCH 2/6 v2] gdiplus: Test drawing metafile image to emf+ file
by Marvin 15 Jul '17

15 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32319 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:54: Test failed: draw image metafile.2: Expected record type 0x4008, got 0x4025 metafile.c:54: Test failed: draw image metafile.3: Expected record type 0x1, got 0x402c metafile.c:54: Test failed: draw image metafile.4: Expected record type 0x4001, got 0x4008 metafile.c:54: Test failed: draw image metafile.5: Expected record type 0x4008, got 0x1 metafile.c:54: Test failed: draw image metafile.6: Expected record type 0x4008, got 0x4001 metafile.c:54: Test failed: draw image metafile.7: Expected record type 0x401b, got 0x4008 metafile.c:54: Test failed: draw image metafile.8: Expected record type 0x21, got 0x4008 metafile.c:54: Test failed: draw image metafile.9: Expected record type 0x62, got 0x4008 metafile.c:54: Test failed: draw image metafile.10: Expected record type 0x4c, got 0x4008 metafile.c:54: Test failed: draw image metafile.11: Expected record type 0x22, got 0x4008 metafile.c:54: Test failed: draw image metafile.12: Expected record type 0x4002, got 0x4008 metafile.c:54: Test failed: draw image metafile.13: Expected record type 0xe, got 0x401b metafile.c:54: Test failed: draw image metafile.14: Expected record type 0x401b, got 0x21 metafile.c:54: Test failed: draw image metafile.15: Expected record type 0x21, got 0x62 metafile.c:54: Test failed: draw image metafile.16: Expected record type 0x62, got 0x4c metafile.c:54: Test failed: draw image metafile.17: Expected record type 0x4c, got 0x22 metafile.c:54: Test failed: draw image metafile.18: Expected record type 0x22, got 0x4002 metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x401a record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4026 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x21 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x62 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x4c record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x22 record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4002 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0xe record === w2003std (32 bit metafile) === metafile.c:54: Test failed: draw image metafile.2: Expected record type 0x4008, got 0x4025 metafile.c:54: Test failed: draw image metafile.3: Expected record type 0x1, got 0x402c metafile.c:54: Test failed: draw image metafile.4: Expected record type 0x4001, got 0x4008 metafile.c:54: Test failed: draw image metafile.5: Expected record type 0x4008, got 0x1 metafile.c:54: Test failed: draw image metafile.6: Expected record type 0x4008, got 0x4001 metafile.c:54: Test failed: draw image metafile.7: Expected record type 0x401b, got 0x4008 metafile.c:54: Test failed: draw image metafile.8: Expected record type 0x21, got 0x4008 metafile.c:54: Test failed: draw image metafile.9: Expected record type 0x62, got 0x4008 metafile.c:54: Test failed: draw image metafile.10: Expected record type 0x4c, got 0x4008 metafile.c:54: Test failed: draw image metafile.11: Expected record type 0x22, got 0x4008 metafile.c:54: Test failed: draw image metafile.12: Expected record type 0x4002, got 0x4008 metafile.c:54: Test failed: draw image metafile.13: Expected record type 0xe, got 0x401b metafile.c:54: Test failed: draw image metafile.14: Expected record type 0x401b, got 0x21 metafile.c:54: Test failed: draw image metafile.15: Expected record type 0x21, got 0x62 metafile.c:54: Test failed: draw image metafile.16: Expected record type 0x62, got 0x4c metafile.c:54: Test failed: draw image metafile.17: Expected record type 0x4c, got 0x22 metafile.c:54: Test failed: draw image metafile.18: Expected record type 0x22, got 0x4002 metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x401a record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4026 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x21 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x62 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x4c record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x22 record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4002 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0xe record === wvistau64 (32 bit metafile) === metafile.c:54: Test failed: draw image metafile.2: Expected record type 0x4008, got 0x4025 metafile.c:54: Test failed: draw image metafile.3: Expected record type 0x1, got 0x402c metafile.c:54: Test failed: draw image metafile.4: Expected record type 0x4001, got 0x4008 metafile.c:54: Test failed: draw image metafile.5: Expected record type 0x4008, got 0x1 metafile.c:54: Test failed: draw image metafile.6: Expected record type 0x4008, got 0x4001 metafile.c:54: Test failed: draw image metafile.7: Expected record type 0x401b, got 0x4008 metafile.c:54: Test failed: draw image metafile.8: Expected record type 0x21, got 0x4008 metafile.c:54: Test failed: draw image metafile.9: Expected record type 0x62, got 0x4008 metafile.c:54: Test failed: draw image metafile.10: Expected record type 0x4c, got 0x4008 metafile.c:54: Test failed: draw image metafile.11: Expected record type 0x22, got 0x4008 metafile.c:54: Test failed: draw image metafile.12: Expected record type 0x4002, got 0x4008 metafile.c:54: Test failed: draw image metafile.13: Expected record type 0xe, got 0x401b metafile.c:54: Test failed: draw image metafile.14: Expected record type 0x401b, got 0x21 metafile.c:54: Test failed: draw image metafile.15: Expected record type 0x21, got 0x62 metafile.c:54: Test failed: draw image metafile.16: Expected record type 0x62, got 0x4c metafile.c:54: Test failed: draw image metafile.17: Expected record type 0x4c, got 0x22 metafile.c:54: Test failed: draw image metafile.18: Expected record type 0x22, got 0x4002 metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x401a record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4026 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x21 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x62 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x4c record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x22 record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4002 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0xe record === w2008s64 (32 bit metafile) === metafile.c:54: Test failed: draw image metafile.2: Expected record type 0x4008, got 0x4025 metafile.c:54: Test failed: draw image metafile.3: Expected record type 0x1, got 0x402c metafile.c:54: Test failed: draw image metafile.4: Expected record type 0x4001, got 0x4008 metafile.c:54: Test failed: draw image metafile.5: Expected record type 0x4008, got 0x1 metafile.c:54: Test failed: draw image metafile.6: Expected record type 0x4008, got 0x4001 metafile.c:54: Test failed: draw image metafile.7: Expected record type 0x401b, got 0x4008 metafile.c:54: Test failed: draw image metafile.8: Expected record type 0x21, got 0x4008 metafile.c:54: Test failed: draw image metafile.9: Expected record type 0x62, got 0x4008 metafile.c:54: Test failed: draw image metafile.10: Expected record type 0x4c, got 0x4008 metafile.c:54: Test failed: draw image metafile.11: Expected record type 0x22, got 0x4008 metafile.c:54: Test failed: draw image metafile.12: Expected record type 0x4002, got 0x4008 metafile.c:54: Test failed: draw image metafile.13: Expected record type 0xe, got 0x401b metafile.c:54: Test failed: draw image metafile.14: Expected record type 0x401b, got 0x21 metafile.c:54: Test failed: draw image metafile.15: Expected record type 0x21, got 0x62 metafile.c:54: Test failed: draw image metafile.16: Expected record type 0x62, got 0x4c metafile.c:54: Test failed: draw image metafile.17: Expected record type 0x4c, got 0x22 metafile.c:54: Test failed: draw image metafile.18: Expected record type 0x22, got 0x4002 metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x401a record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4026 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x21 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x62 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x4c record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x22 record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4002 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0xe record === wvistau64 (64 bit metafile) === metafile.c:54: Test failed: draw image metafile.2: Expected record type 0x4008, got 0x4025 metafile.c:54: Test failed: draw image metafile.3: Expected record type 0x1, got 0x402c metafile.c:54: Test failed: draw image metafile.4: Expected record type 0x4001, got 0x4008 metafile.c:54: Test failed: draw image metafile.5: Expected record type 0x4008, got 0x1 metafile.c:54: Test failed: draw image metafile.6: Expected record type 0x4008, got 0x4001 metafile.c:54: Test failed: draw image metafile.7: Expected record type 0x401b, got 0x4008 metafile.c:54: Test failed: draw image metafile.8: Expected record type 0x21, got 0x4008 metafile.c:54: Test failed: draw image metafile.9: Expected record type 0x62, got 0x4008 metafile.c:54: Test failed: draw image metafile.10: Expected record type 0x4c, got 0x4008 metafile.c:54: Test failed: draw image metafile.11: Expected record type 0x22, got 0x4008 metafile.c:54: Test failed: draw image metafile.12: Expected record type 0x4002, got 0x4008 metafile.c:54: Test failed: draw image metafile.13: Expected record type 0xe, got 0x401b metafile.c:54: Test failed: draw image metafile.14: Expected record type 0x401b, got 0x21 metafile.c:54: Test failed: draw image metafile.15: Expected record type 0x21, got 0x62 metafile.c:54: Test failed: draw image metafile.16: Expected record type 0x62, got 0x4c metafile.c:54: Test failed: draw image metafile.17: Expected record type 0x4c, got 0x22 metafile.c:54: Test failed: draw image metafile.18: Expected record type 0x22, got 0x4002 metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x401a record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4026 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x21 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x62 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x4c record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x22 record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4002 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0xe record === w2008s64 (64 bit metafile) === metafile.c:54: Test failed: draw image metafile.2: Expected record type 0x4008, got 0x4025 metafile.c:54: Test failed: draw image metafile.3: Expected record type 0x1, got 0x402c metafile.c:54: Test failed: draw image metafile.4: Expected record type 0x4001, got 0x4008 metafile.c:54: Test failed: draw image metafile.5: Expected record type 0x4008, got 0x1 metafile.c:54: Test failed: draw image metafile.6: Expected record type 0x4008, got 0x4001 metafile.c:54: Test failed: draw image metafile.7: Expected record type 0x401b, got 0x4008 metafile.c:54: Test failed: draw image metafile.8: Expected record type 0x21, got 0x4008 metafile.c:54: Test failed: draw image metafile.9: Expected record type 0x62, got 0x4008 metafile.c:54: Test failed: draw image metafile.10: Expected record type 0x4c, got 0x4008 metafile.c:54: Test failed: draw image metafile.11: Expected record type 0x22, got 0x4008 metafile.c:54: Test failed: draw image metafile.12: Expected record type 0x4002, got 0x4008 metafile.c:54: Test failed: draw image metafile.13: Expected record type 0xe, got 0x401b metafile.c:54: Test failed: draw image metafile.14: Expected record type 0x401b, got 0x21 metafile.c:54: Test failed: draw image metafile.15: Expected record type 0x21, got 0x62 metafile.c:54: Test failed: draw image metafile.16: Expected record type 0x62, got 0x4c metafile.c:54: Test failed: draw image metafile.17: Expected record type 0x4c, got 0x22 metafile.c:54: Test failed: draw image metafile.18: Expected record type 0x22, got 0x4002 metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x401a record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4026 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x21 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x62 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x4c record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0x22 record metafile.c:140: Test failed: draw image metafile: Unexpected EMF+ 0x4002 record metafile.c:177: Test failed: draw image metafile: Unexpected EMF 0xe record

1 0

Re: [PATCH v2 1/3] explorerframe: Implement ITaskbarList::AddTab() and ::DeleteTab().
by Alexandre Julliard 14 Jul '17

14 Jul '17

Zebediah Figura <zfigura(a)codeweavers.com> writes: > ITaskbarList is an interface which allows applications to manually > control which windows appear on the taskbar, as well as what state > they are in (e.g. activated, flashing, progress bar). It also exposes > a function to "redirect" activation to other windows in a process. > > In particular, when using multiple documents in Excel 2010, the > application will delete the button for its main window, and redirect > activation of dummy windows to the child windows containing the > documents. > > Version 2 of this patch: use an internal window message instead of > calling the graphics driver directly. This is necessary because the > interface allows modifying the buttons attached to other processes' > windows. This looks very ad-hoc. I'd like to see a design that would show a credible path towards implementing the entire interface. We can't add new private messages for every bit of functionality. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] gdiplus: Add support for creating image object containing metafile
by Vincent Povirk 14 Jul '17

14 Jul '17

This could use a test, just to verify that native can read the emf we create. On Fri, Jul 14, 2017 at 8:18 AM, Piotr Caban <piotr(a)codeweavers.com> wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/gdiplus/metafile.c | 47 > ++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 44 insertions(+), 3 deletions(-) > > > > >

1 0

Re: [PATCH 1/2] msvcp140: Implement _Stat and _Lstat (v3).
by Piotr Caban 14 Jul '17

14 Jul '17

Hi Stefan, On 07/13/17 17:40, Stefan Dösinger wrote: > +enum msvcp140_file_type { > + msvcp140_file_type_not_found = -1, msvcp140_file_type_none, msvcp140_file_type_regular, > + msvcp140_file_type_directory, msvcp140_file_type_symlink, msvcp140_file_type_block, > + msvcp140_file_type_character, msvcp140_file_type_fifo, msvcp140_file_type_socket, msvcp140_file_type_unknown > +}; Did you consider changing current structure instead of defining new one? I'm talking about something like: enum file_type { #if _MSVCP_VER < 140 status_unknown, file_not_found, #else file_not_found = -1, status_unknown, #endif regular_file, directory_file, ... } Thanks to it you will be able to use the same implementation of _Open_dir/_Read_dir in msvcp120 and msvcp140. > + *permissions = (attr & FILE_ATTRIBUTE_READONLY)?0555:0777; You should also handle permission==NULL case. Thanks, Piotr

2 2

Re: [PATCH 2/2] winhttp/tests: Make sure that all notifications were called before the end of a test.
by Marvin 14 Jul '17

14 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32295 Your paranoid android. === w8 (32 bit notification) === notification.c:602: Test failed: some notifications were missing: 800

1 0

Re: [PATCH 1/2] winhttp/tests: Use notification flags to explicitly mark notifications that should signal an event.
by Marvin 14 Jul '17

14 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32294 Your paranoid android. === w8 (32 bit notification) === notification.c:272: Test failed: got 00000102 notification.c:290: Test failed: unexpected function 8, expected 1. probably some notifications were missing notification.c:90: Test failed: 290: expected status 0x00000800 got 0x00000400 notification.c:91: Test failed: 290: expected function 8 got 1 notification.c:294: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:90: Test failed: 294: expected status 0x00000800 got 0x00000400 notification.c:91: Test failed: 294: expected function 8 got 2 notification.c:301: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:90: Test failed: 301: expected status 0x00000800 got 0x00000010 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:90: Test failed: 301: expected status 0x00000800 got 0x00000020 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:91: Test failed: 301: expected function 8 got 3 notification.c:311: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:90: Test failed: 311: expected status 0x00000800 got 0x00000040 notification.c:91: Test failed: 311: expected function 8 got 4 notification.c:90: Test failed: 311: expected status 0x00000800 got 0x00000080 notification.c:91: Test failed: 311: expected function 8 got 4

1 0

wine-2.0.2-rc3 Available
by Michael Stefaniuc 13 Jul '17

13 Jul '17

Hello guys, I have pushed wine-2.0.2-rc3 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Changes since rc2: - Added Steam fix bye michael

1 0

Re: [PATCH 2/6] gdiplus: Add helper for saving path objects in metafile
by Dmitry Timoshkov 13 Jul '17

13 Jul '17

Piotr Caban <piotr(a)codeweavers.com> wrote: > +typedef struct EmfPlusPath > +{ > + DWORD Version; > + DWORD PathPointCount; > + DWORD PathPointFlags; > + /* PathPoints[] */ > + /* PathPointTypes[] */ > + /* AlignmentPadding */ > + BYTE data[1]; > +} EmfPlusPath; ... > +static GpStatus METAFILE_AddPathObject(GpMetafile *metafile, GpPath *path, DWORD *id) > +{ ... > + object_record->ObjectData.path.Version = 0xDBC01002; > + object_record->ObjectData.path.PathPointCount = path->pathdata.Count; > + object_record->ObjectData.path.PathPointFlags = 0; This looks very similar to the buffer format returned by GdipGetRegionData(), is it possible to use that API instead of a custom generator? -- Dmitry.

3 2

Meson buildsystem - does make it sense for Wine?
by David Heidelberg 13 Jul '17

13 Jul '17

As I recently discovered Meson build system [1] (compatible with Linux, FreeBSD, Windows, Android etc.) which tends to be preferred replacement for autotools (at least recently by many projects). [2] I didn't found any discussion regarding to porting Wine build system. I wounder what is your opinion, could Meson can improve wine build times? Also maybe simplified crossbuilds? Thank you David [1] http://mesonbuild.com/ [2] https://www.youtube.com/watch?v=ae9_rNuFaQM

2 1

Re: [4/5] [v2] ntdll: Provide more accurate virtual memory counters. (rebased)
by Alex Henrie 13 Jul '17

13 Jul '17

I don't think this patch is going to be accepted without showing that it makes some application usable that previously was not. -Alex

2 3

Re: [PATCH v2 1/2] explorer: Improve tray sizing and style.
by Alexandre Julliard 13 Jul '17

13 Jul '17

Zebediah Figura <zfigura(a)codeweavers.com> writes: > v2: use appropriate system metrics. > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > --- > programs/explorer/systray.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) It's mainly a matter of taste, but this doesn't look better to me. In particular having buttons remain pushed when active feels wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcp140: Implement _Stat and _Lstat (v2).
by Stefan Dösinger 13 Jul '17

13 Jul '17

Am 2017-07-13 um 15:05 schrieb Stefan Dösinger: +enum msvcp140_file_type { + file_type_not_found = -1, file_type_none, file_type_regular, + file_type_directory, file_type_symlink, file_type_block, + file_type_character, file_type_fifo, file_type_socket, file_type_unknown +}; Please skip this patch for now, with the changes needed to handle _Open_dir I feel it'd be better to consistently use msvcp140_file_type for the name of the enum type and the enum values. I don't plan any functional changes beyond this cosmetic one, so it should be good to review though.

1 0

Re: [2/6] wsdapi: Add code to create SOAP envelope from header and body elements.
by Alexandre Julliard 13 Jul '17

13 Jul '17

Owen Rudge <orudge(a)codeweavers.com> writes: > +#define WCHAR_URN_COLON 'u','r','n',':' > +#define WCHAR_HTTP_COLON_SLASH_SLASH 'h','t','t','p',':','/','/' > +#define WCHAR_SCHEMAS 's','c','h','e','m','a','s' > +#define WCHAR_SOAP 's','o','a','p' > +#define WCHAR_XMLSOAP 'x','m','l',WCHAR_SOAP > +#define WCHAR_ORG 'o','r','g' > +#define WCHAR_WS_SLASH 'w','s','/' > +#define WCHAR_SCHEMAS_DOT_XML_SOAP_DOT_ORG WCHAR_SCHEMAS,'.',WCHAR_XMLSOAP,'.',WCHAR_ORG > +#define WCHAR_DISCOVERY 'd','i','s','c','o','v','e','r','y' > +#define WCHAR_MESSAGE 'M','e','s','s','a','g','e' > +#define WCHAR_SEQUENCE 'S','e','q','u','e','n','c','e' > + > +static const WCHAR addressingNsUri[] = { > + WCHAR_HTTP_COLON_SLASH_SLASH, > + WCHAR_SCHEMAS_DOT_XML_SOAP_DOT_ORG,'/', > + WCHAR_WS_SLASH,'2','0','0','4','/','0','8','/','a','d','d','r','e','s','s','i','n','g', 0 }; > + > +static const WCHAR discoveryNsUri[] = { > + WCHAR_HTTP_COLON_SLASH_SLASH, > + WCHAR_SCHEMAS_DOT_XML_SOAP_DOT_ORG,'/', > + WCHAR_WS_SLASH,'2','0','0','5','/','0','4','/',WCHAR_DISCOVERY, 0 }; > + > +static const WCHAR envelopeNsUri[] = { > + WCHAR_HTTP_COLON_SLASH_SLASH, > + 'w','w','w','.','w','3','.',WCHAR_ORG,'/', > + '2','0','0','3','/','0','5','/',WCHAR_SOAP,'-','e','n','v','e','l','o','p','e', 0 }; > + > +static const WCHAR addressingPrefix[] = { 'w','s','a', 0 }; > +static const WCHAR discoveryPrefix[] = { 'w','s','d', 0 }; > +static const WCHAR envelopePrefix[] = { WCHAR_SOAP, 0 }; > +static const WCHAR headerString[] = { 'H','e','a','d','e','r', 0 }; > +static const WCHAR actionString[] = { 'A','c','t','i','o','n', 0 }; > +static const WCHAR messageIdString[] = { WCHAR_MESSAGE,'I','D', 0 }; > +static const WCHAR toString[] = { 'T','o', 0 }; > +static const WCHAR relatesToString[] = { 'R','e','l','a','t','e','s','T','o', 0 }; > +static const WCHAR appSequenceString[] = { 'A','p','p',WCHAR_SEQUENCE, 0 }; > +static const WCHAR instanceIdString[] = { 'I','n','s','t','a','n','c','e','I','d', 0 }; > +static const WCHAR messageNumberString[] = { WCHAR_MESSAGE,'N','u','m','b','e','r', 0 }; > +static const WCHAR sequenceIdString[] = { WCHAR_SEQUENCE,'I','d', 0 }; > +static const WCHAR emptyString[] = { 0 }; I think this would be more readable (and more greppable) without the #defines. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ws2_32: Set return size when calling WSAIoctl with WS_SIO_GET_EXTENSION_FUNCTION_POINTER.
by Sebastian Lackner 13 Jul '17

13 Jul '17

On 13.07.2017 06:20, Alistair Leslie-Hughes wrote: > This is a backbort of the above change, borrowed from Codeweavers. :) > > Target: 2.0.* branch. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/ws2_32/socket.c | 1 + > 1 file changed, 1 insertion(+) > It probably does not matter in practice (and I don't think we have any tests for it yet), but please note that this not equivalent to the code we have in the development branch. It also changes error handling in a completely unrelated situation (when a extension is not found). Why not just backport 914e401aa9d5401893c3807d51e3f19fc7a7ab38 plus the fix?

2 1

Re: [PATCH 4/5 v3] msvcr120: Add acosh.
by Alex Henrie 12 Jul '17

12 Jul '17

Alexandre, when you apply these patches, you don't have to keep the "From: Alex Henrie" line. The acosh and atanh implementations are now more Piotr's work than they are mine, although I'm happy to sign off on them. -Alex

1 0

Re: [PATCH 4/5 v2] msvcr120: Add acosh.
by Alex Henrie 12 Jul '17

12 Jul '17

/********************************************************************* + * acosh (MSVCR120.@) + */ +double CDECL MSVCR120_acosh(double x) +{ + if (x < 1) { + *MSVCRT__errno() = MSVCRT_EDOM; + return NAN; + } +#ifdef HAVE_ACOSH + return acosh(x); +#else + if (!isfinite(x*x)) return log(2) + log(x); + return log(x + sqrt(x*x-1)); +#endif +} + +/********************************************************************* + * acoshf (MSVCR120.@) + */ +float CDECL MSVCR120_acoshf(float x) +{ +#ifdef HAVE_ACOSHF + return acoshf(x); +#else + return MSVCR120_acosh(x); +#endif +} Thanks for the help. Are you sure that acosh and atanh require bounds checking, but acoshf and atanhf do not? Also, aren't they supposed to set an exception flag if x is less than 1? -Alex

2 1

wine-2.0.2-rc2 Available
by Michael Stefaniuc 12 Jul '17

12 Jul '17

Hello guys, I have pushed wine-2.0.2-rc2 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Changes rc1: - Added the commit "ddraw: Validate the "surface" pointer before creating the surface in CreateSurface()." Required by patches included in rc1 that were trading crashes for mem leaks (Thanks Sebastian and Henri). Please let me if you feel strongly about the inclusion of the outstanding Steam fix into wine-2.0.2. As it isn't in devel yet I would tend to defer it to 2.0.3 and I'm not opposed to do an earlier release for that in early to mid August. thanks bye michael

1 0

Re: [PATCH 8/9] msvcr120: Add expm1.
by Piotr Caban 12 Jul '17

12 Jul '17

On 07/10/17 06:55, Alex Henrie wrote: > +float CDECL MSVCR120_expm1f(float x) > +{ > +#ifdef HAVE_EXPM1F > + return expm1f(x); > +#else > + return exp(x) - 1; > +#endif > +} Please set errno on invalid arguments. Thanks, Piotr

1 0

Re: [PATCH 2/3] Add mfuuid.lib
by Alexandre Julliard 11 Jul '17

11 Jul '17

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +DEFINE_GUID(CLSID_MFReadWriteClassFactory, 0x48e2ed0f, 0x98c2, 0x4a37, 0xbe, 0xd5, 0x16, 0x63, 0x12, 0xdd, 0xd8, 0x3f); > +DEFINE_GUID(CLSID_MFSourceReader, 0x1777133c, 0x0881, 0x411b, 0xa5, 0x77, 0xad, 0x54, 0x5f, 0x07, 0x14, 0xc4); > +DEFINE_GUID(CLSID_MFSinkWriter, 0xa3bbfb17, 0x8273, 0x4e52, 0x9e, 0x0e, 0x97, 0x39, 0xdc, 0x88, 0x79, 0x90); > + > +DEFINE_GUID(MF_SINK_WRITER_ASYNC_CALLBACK, 0x48cb183e, 0x7b0b, 0x46f4, 0x82, 0x2e, 0x5e, 0x1d, 0x2d, 0xda, 0x43, 0x54); > +DEFINE_GUID(MF_SINK_WRITER_DISABLE_THROTTLING, 0x08b845d8, 0x2b74, 0x4afe, 0x9d, 0x53, 0xbe, 0x16, 0xd2, 0xd5, 0xae, 0x4f); > +DEFINE_GUID(MF_SINK_WRITER_D3D_MANAGER, 0xec822da2, 0xe1e9, 0x4b29, 0xa0, 0xd8, 0x56, 0x3c, 0x71, 0x9f, 0x52, 0x69); > +DEFINE_GUID(MF_SINK_WRITER_ENCODER_CONFIG, 0xad91cd04, 0xa7cc, 0x4ac7, 0x99, 0xb6, 0xa5, 0x7b, 0x9a, 0x4a, 0x7c, 0x70); > + > +DEFINE_GUID(MF_READWRITE_DISABLE_CONVERTERS, 0x98d5b065, 0x1374, 0x4847, 0x8d, 0x5d, 0x31, 0x52, 0x0f, 0xee, 0x71, 0x56); > +DEFINE_GUID(MF_READWRITE_ENABLE_HARDWARE_TRANSFORMS, 0xa634a91c, 0x822b, 0x41b9, 0xa4, 0x94, 0x4d, 0xe4, 0x64, 0x36, 0x12, 0xb0); > +DEFINE_GUID(MF_READWRITE_MMCSS_CLASS, 0x39384300, 0xd0eb, 0x40b1, 0x87, 0xa0, 0x33, 0x18, 0x87, 0x1b, 0x5a, 0x53); > +DEFINE_GUID(MF_READWRITE_MMCSS_PRIORITY, 0x43ad19ce, 0xf33f, 0x4ba9, 0xa5, 0x80, 0xe4, 0xcd, 0x12, 0xf2, 0xd1, 0x44); > +DEFINE_GUID(MF_READWRITE_MMCSS_CLASS_AUDIO, 0x430847da, 0x0890, 0x4b0e, 0x93, 0x8c, 0x05, 0x43, 0x32, 0xc5, 0x47, 0xe1); > +DEFINE_GUID(MF_READWRITE_MMCSS_PRIORITY_AUDIO, 0x273db885, 0x2de2, 0x4db2, 0xa6, 0xa7, 0xfd, 0xb6, 0x6f, 0xb4, 0x0b, 0x61); > +DEFINE_GUID(MF_READWRITE_D3D_OPTIONAL, 0x216479d9, 0x3071, 0x42ca, 0xbb, 0x6c, 0x4c, 0x22, 0x10, 0x2e, 0x1d, 0x18); I don't see any of these in the PSDK mfuuid library. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v2 2/2] user32: Activate another window upon minimizing.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32251 Your paranoid android. === w7u (32 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00AC013C fg 000301B4 in hook HCBT_MINMAX win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000500D8 fg 000301B4 in hook HCBT_MINMAX === w7pro64 (32 bit win) === win.c:9852: Test failed: expected 000A015E, got 0006011E win.c:9858: Test failed: expected 000A015E, got 0006011E win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070134 fg 00070160 in hook HCBT_MINMAX === w7pro64 (64 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000007015A fg 0000000000070160 in hook HCBT_MINMAX

1 0

Re: [PATCH v2 1/2] user32/tests: Add tests for activating windows.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32250 Your paranoid android. === w7pro64 (32 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070106 fg 00070160 in hook HCBT_MINMAX === w864 (32 bit win) === win.c:2331: Test failed: expected !100 win.c:2331: Test failed: expected !100 === w7pro64 (64 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0000000000070106 fg 0000000000070160 in hook HCBT_MINMAX

1 0

Re: [PATCH 3/3] user32/tests: Use todo_wine for failing z-order tests.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32243 Your paranoid android. === wxppro (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 00020152 win.c:9961: Test failed: GetFocus() = 00020152 === w2003std (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 000400F6 win.c:9961: Test failed: GetFocus() = 000400F6 === wvistau64 (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 00050120 win.c:9961: Test failed: GetFocus() = 00050120 === w2008s64 (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 00080124 win.c:9961: Test failed: GetFocus() = 00080124 === w7u (32 bit win) === win.c:3001: Test failed: 0011013C: expected next 00000000, got 000301B8 win.c:3003: Test failed: 00100192: expected prev 000301AC, got 000A01B6 win.c:3004: Test failed: 000301AC: expected next 00100192, got 00000000 win.c:3005: Test failed: 000901BA: expected prev 000A01B6, got 0011013C win.c:3006: Test failed: 000A01B6: expected next 000901BA, got 00100192 win.c:3015: Test failed: 0011013C: expected next 00000000, got 000301B8 win.c:3016: Test failed: 00100192: expected prev 000301AC, got 000A01B6 win.c:3017: Test failed: 000301AC: expected next 00100192, got 00000000 win.c:3018: Test failed: 000901BA: expected prev 000A01B6, got 0011013C win.c:3019: Test failed: 000A01B6: expected next 000901BA, got 00100192 win.c:3001: Test failed: 0012013C: expected next 00000000, got 000301B8 win.c:3003: Test failed: 000B01B6: expected prev 000301AC, got 009E015A win.c:3004: Test failed: 000301AC: expected next 000B01B6, got 00000000 win.c:3005: Test failed: 000901BA: expected prev 009E015A, got 0012013C win.c:3006: Test failed: 009E015A: expected next 000901BA, got 000B01B6 win.c:3015: Test failed: 0012013C: expected next 00000000, got 000301B8 win.c:3016: Test failed: 000B01B6: expected prev 000301AC, got 009E015A win.c:3017: Test failed: 000301AC: expected next 000B01B6, got 00000000 win.c:3018: Test failed: 000901BA: expected prev 009E015A, got 0012013C win.c:3019: Test failed: 009E015A: expected next 000901BA, got 000B01B6 === w7pro64 (32 bit win) === win.c:9968: Test failed: expected 000B015E, got 00050024 === w8 (32 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009012E fg 000400FA in hook HCBT_MINMAX === wvistau64 (64 bit win) === win.c:9961: Test failed: GetActiveWindow() = 0000000000050120 win.c:9961: Test failed: GetFocus() = 0000000000050120 === w2008s64 (64 bit win) === win.c:9961: Test failed: GetActiveWindow() = 0000000000080124 win.c:9961: Test failed: GetFocus() = 0000000000080124 === w7pro64 (64 bit win) === win.c:9968: Test failed: expected 00000000000B015E, got 000000000006011E === w864 (64 bit win) === win.c:9968: Test failed: expected 00000000000B015C, got 0000000000050028

1 0

Re: [PATCH 2/3] user32: Activate another window upon minimizing.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32242 Your paranoid android. === wxppro (32 bit win) === win.c:9939: Test failed: GetActiveWindow() = 00020152 win.c:9939: Test failed: GetFocus() = 00020152 === w2003std (32 bit win) === win.c:9939: Test failed: GetActiveWindow() = 000400F6 win.c:9939: Test failed: GetFocus() = 000400F6 === wvistau64 (32 bit win) === win.c:9939: Test failed: GetActiveWindow() = 00050120 win.c:9939: Test failed: GetFocus() = 00050120 === w2008s64 (32 bit win) === win.c:9939: Test failed: GetActiveWindow() = 00080124 win.c:9939: Test failed: GetFocus() = 00080124 === w7pro64 (32 bit win) === win.c:9946: Test failed: expected 000B00FC, got 0006011E === w8 (32 bit win) === win.c:9946: Test failed: expected 000B0132, got 0006011A === w864 (32 bit win) === win.c:9946: Test failed: expected 000B015C, got 0004001C === wvistau64 (64 bit win) === win.c:9939: Test failed: GetActiveWindow() = 0000000000050120 win.c:9939: Test failed: GetFocus() = 0000000000050120 === w2008s64 (64 bit win) === win.c:9939: Test failed: GetActiveWindow() = 0000000000080124 win.c:9939: Test failed: GetFocus() = 0000000000080124 === w7pro64 (64 bit win) === win.c:9852: Test failed: expected 00000000000A015A, got 0000000000050024 win.c:9858: Test failed: expected 00000000000A015A, got 0000000000050024 win.c:9946: Test failed: expected 00000000000B015A, got 0000000000050024 === w864 (64 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0000000000050192 fg 0000000000050020 in hook HCBT_MINMAX === w1064 (64 bit win) === win.c:9946: Test failed: expected 0000000000080042, got 000000000003002E

1 0

Re: [PATCH 1/3] user32/tests: Add tests for activating windows.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32241 Your paranoid android. === wxppro (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 00020152 win.c:9940: Test failed: GetFocus() = 00020152 === w2003std (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 000400F6 win.c:9940: Test failed: GetFocus() = 000400F6 === wvistau64 (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 00050120 win.c:9940: Test failed: GetFocus() = 00050120 === w2008s64 (32 bit win) === win.c:9940: Test failed: GetActiveWindow() = 00080124 win.c:9940: Test failed: GetFocus() = 00080124 === w7u (32 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00A70144 fg 000B0188 in hook HCBT_MINMAX win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000700F8 fg 000B0188 in hook HCBT_MINMAX win.c:9962: Test failed: expected 000B00F0, got 000801AA win.c:9981: Test failed: expected 000B00F0, got 000801AA === wvistau64 (64 bit win) === win.c:9940: Test failed: GetActiveWindow() = 0000000000050120 win.c:9940: Test failed: GetFocus() = 0000000000050120 === w2008s64 (64 bit win) === win.c:9940: Test failed: GetActiveWindow() = 0000000000080124 win.c:9940: Test failed: GetFocus() = 0000000000080124 === w7pro64 (64 bit win) === win.c:9947: Test failed: expected 00000000000B015E, got 0000000000050024

1 0

Re: [PATCH 3/6] gdiplus: Support GdipSetSmoothingMode in metafiles
by Vincent Povirk 11 Jul '17

11 Jul '17

According to the spec, SmoothingModeHighSpeed also does no antialiasing.

2 1

Re: [PATCH 7/9] msvcr120: Add erfc.
by Piotr Caban 11 Jul '17

11 Jul '17

On 07/10/17 06:55, Alex Henrie wrote: > /********************************************************************* > + * erfc (MSVCR120.@) > + */ > +double CDECL MSVCR120_erfc(double x) > +{ > +#ifdef HAVE_ERFC > + return erfc(x); > +#else > + FIXME( "not implemented\n" ); > + return 0.0; > +#endif You can return 1.0 - MSVCR120_erf(x) if erfc is not available. Thanks, Piotr

2 2

Re: winhttp/tests: Make notification tests more strict.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32231 Your paranoid android. === w7pro64 (32 bit notification) === notification.c:219: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 219: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 219: expected function 8 got 2 notification.c:226: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:236: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:248: Test failed: unexpected function 2, expected 8. probably some notifications were missing notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:282: Test failed: unexpected function 2, expected 1. probably some notifications were missing notification.c:90: Test failed: 282: expected function 2 got 1 notification.c:315: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 315: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 315: expected function 8 got 2 notification.c:322: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:332: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 332: expected function 8 got 4 notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 332: expected function 8 got 4 notification.c:89: Test failed: 341: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 341: expected function 1 got 8 === w1064 (64 bit notification) === notification.c:219: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 219: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 219: expected function 8 got 2 notification.c:226: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:89: Test failed: 226: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 226: expected function 8 got 3 notification.c:90: Test failed: 219: expected function 8 got 2 notification.c:236: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:89: Test failed: 236: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 236: expected function 8 got 4 notification.c:248: Test failed: unexpected function 2, expected 8. probably some notifications were missing notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:89: Test failed: 248: expected status 0x00000400 got 0x00000800 notification.c:90: Test failed: 248: expected function 2 got 8 notification.c:282: Test failed: unexpected function 2, expected 1. probably some notifications were missing notification.c:90: Test failed: 282: expected function 2 got 1 notification.c:315: Test failed: unexpected function 8, expected 2. probably some notifications were missing notification.c:89: Test failed: 315: expected status 0x00000800 got 0x00000400 notification.c:90: Test failed: 315: expected function 8 got 2 notification.c:322: Test failed: unexpected function 8, expected 3. probably some notifications were missing notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000010 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:89: Test failed: 322: expected status 0x00000800 got 0x00000020 notification.c:90: Test failed: 322: expected function 8 got 3 notification.c:332: Test failed: unexpected function 8, expected 4. probably some notifications were missing notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000040 notification.c:90: Test failed: 332: expected function 8 got 4 notification.c:89: Test failed: 332: expected status 0x00000800 got 0x00000080 notification.c:90: Test failed: 332: expected function 8 got 4

1 0

Re: [PATCH 4/4] msvcp140: Implement _Stat and _Lstat.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32230 Your paranoid android. === wvistau64 (32 bit msvcp140) === 0504:msvcp140: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit msvcp140) === 0504:msvcp140: unhandled exception c0000005 at 0000000000000000

1 0

Re: [PATCH 1/2] advapi32/tests: Statically link to ConvertSidToStringSidA()
by Dmitry Timoshkov 11 Jul '17

11 Jul '17

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -static BOOL (WINAPI *pConvertSidToStringSidA)( PSID pSid, LPSTR *str ); > static BOOL (WINAPI *pConvertStringSidToSidA)( LPCSTR str, PSID pSid ); ... > - pConvertSidToStringSidA = (void *)GetProcAddress(hmod, "ConvertSidToStringSidA"); > pConvertStringSidToSidA = (void *)GetProcAddress(hmod, "ConvertStringSidToSidA"); ... > - if( !pConvertSidToStringSidA || !pConvertStringSidToSidA ) > + if( !pConvertStringSidToSidA ) What's so special about ConvertSidToStringSidA and why same logic won't apply to ConvertStringSidToSidA and possibly others? -- Dmitry.

2 2

Re: [PATCH 7/7] gdiplus: Add EMF+ properties records tests
by Piotr Caban 11 Jul '17

11 Jul '17

On 07/11/17 11:42, Piotr Caban wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/gdiplus/tests/metafile.c | 78 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 78 insertions(+) > I've sent it incorrectly so it wasn't picked by testbot. Here are the results: https://testbot.winehq.org/JobDetails.pl?Key=32226 Thanks, Piotr

1 0

Re: [PATCH 2/6] gdiplus: Support GdipSetPixelOffsetMode in metafiles
by Dmitry Timoshkov 11 Jul '17

11 Jul '17

Piotr Caban <piotr(a)codeweavers.com> wrote: > + if(graphics->pixeloffset == mode) > + return Ok; This particular change would need an approproate test case to confirm that repetitive GdipSetPixelOffsetMode() calls with the same value won't generate new records. Same applies to other patches in the series. -- Dmitry.

1 1

Re: [PATCH 1/7] d3dx9/tests: Add test for skip_constants effect parameter.
by Matteo Bruni 11 Jul '17

11 Jul '17

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +static void test_effect_skip_constants(IDirect3DDevice9 *device) > +{ > + HRESULT hr; > + ID3DXEffect *effect; > + unsigned int passes_count; > + D3DXVECTOR4 fvect; > + unsigned int i; > + > + hr = D3DXCreateEffectEx(device, test_effect_skip_constants_blob, sizeof(test_effect_skip_constants_blob), > + NULL, NULL, "v3", 0, NULL, &effect, NULL); > + todo_wine > + ok(hr == D3DERR_INVALIDCALL, "Got result %#x.\n", hr); > + if (SUCCEEDED(hr)) > + effect->lpVtbl->Release(effect); > + hr = D3DXCreateEffectEx(device, test_effect_skip_constants_blob, sizeof(test_effect_skip_constants_blob), > + NULL, NULL, "v4", 0, NULL, &effect, NULL); > + todo_wine > + ok(hr == D3DERR_INVALIDCALL, "Got result %#x.\n", hr); > + if (SUCCEEDED(hr)) > + effect->lpVtbl->Release(effect); > + > + hr = D3DXCreateEffectEx(device, test_effect_skip_constants_blob, sizeof(test_effect_skip_constants_blob), > + NULL, NULL, " v1#,.+-= &\t\nv2*/!\"'v5 v6[1]", 0, NULL, &effect, NULL); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); Maybe also add a test with the "expected" syntax for the skip_constants parameters? MSDN mentions a semicolon-separated list. Of course it's not strictly needed, given this test... > + > + todo_wine > + ok(!effect->lpVtbl->IsParameterUsed(effect, "v1", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + todo_wine > + ok(!effect->lpVtbl->IsParameterUsed(effect, "v2", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + ok(effect->lpVtbl->IsParameterUsed(effect, "v3", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + ok(effect->lpVtbl->IsParameterUsed(effect, "v4", "tech0"), > + "Unexpected IsParameterUsed result.\n"); > + ok(!effect->lpVtbl->IsParameterUsed(effect, "v5", "tech0"), > + "Unexpected IsParameterUsed result.\n"); What about "v6"?

2 1

Re: [PATCH 5/7] d3dx9: Fail effect creation when shader parameter evaluator creation fails.
by Matteo Bruni 11 Jul '17

11 Jul '17

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > @@ -6099,8 +6100,9 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * > { > if (FAILED(hr = d3dx9_create_object(base, object))) > return hr; > - d3dx_create_param_eval(base, object->data, object->size, param->type, > - &param->param_eval, get_version_counter_ptr(base)); > + if (FAILED(hr = d3dx_create_param_eval(base, object->data, object->size, param->type, > + &param->param_eval, get_version_counter_ptr(base)))) > + return hr; > } > break; > > @@ -6138,8 +6140,11 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * It looks like you missed another call to d3dx_create_param_eval() in between these two.

2 1

Re: [PATCH 2/5] regedit: Use 'return' statements in delete_registry_key() to allow for memory clean-up
by Alexandre Julliard 11 Jul '17

11 Jul '17

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > @@ -1593,11 +1593,11 @@ void delete_registry_key(WCHAR *reg_key_name) > > if (!(key_class = parse_key_name(reg_key_name, &key_name))) { > output_message(STRING_INCORRECT_REG_CLASS, reg_key_name); > - exit(1); > + return; > } > if (!*key_name) { > output_message(STRING_DELETE_REG_CLASS_FAILED, reg_key_name); > - exit(1); > + return; If the process is going to exit anyway, freeing memory is a waste of time. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 3/9] msvcr120: Remove precompiler check for asinh.
by Piotr Caban 11 Jul '17

11 Jul '17

On 07/10/17 06:55, Alex Henrie wrote: > asinh is part of C89, so it is guaranteed to be present. Are you sure about it? As far as I know it's part of C99. The manual for asinh looks strange (it says that it conforms to C89 and gives test macro that checks for never standards). Thanks, Piotr

4 7

Re: [PATCH 6/7] d3dx9: Implement d3dx_shader_get_raw_constant_info() function.
by Matteo Bruni 10 Jul '17

10 Jul '17

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/d3dx9_private.h | 3 +++ > dlls/d3dx9_36/shader.c | 18 ++++++++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/dlls/d3dx9_36/d3dx9_private.h b/dlls/d3dx9_36/d3dx9_private.h > index db80490..bfb3909 100644 > --- a/dlls/d3dx9_36/d3dx9_private.h > +++ b/dlls/d3dx9_36/d3dx9_private.h > @@ -355,4 +355,7 @@ HRESULT d3dx_param_eval_set_shader_constants(ID3DXEffectStateManager *manager, s > struct d3dx_param_eval *peval, BOOL update_all) DECLSPEC_HIDDEN; > BOOL is_param_eval_input_dirty(struct d3dx_param_eval *peval, ULONG64 update_version) DECLSPEC_HIDDEN; > > +const D3DXSHADER_CONSTANTINFO *d3dx_shader_get_raw_constant_info(ID3DXConstantTable *iface, > + D3DXHANDLE constant) DECLSPEC_HIDDEN; > + > #endif /* __WINE_D3DX9_PRIVATE_H */ > diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c > index 4dbecb1..11527c8 100644 > --- a/dlls/d3dx9_36/shader.c > +++ b/dlls/d3dx9_36/shader.c > @@ -682,6 +682,7 @@ HRESULT WINAPI D3DXPreprocessShaderFromResourceW(HMODULE module, const WCHAR *re > } > > struct ctab_constant { > + const D3DXSHADER_CONSTANTINFO *raw_constant_info; > D3DXCONSTANT_DESC desc; > struct ctab_constant *constants; > }; > @@ -946,6 +947,22 @@ static HRESULT WINAPI ID3DXConstantTableImpl_GetDesc(ID3DXConstantTable *iface, > return D3D_OK; > } > > +const D3DXSHADER_CONSTANTINFO *d3dx_shader_get_raw_constant_info(ID3DXConstantTable *iface, D3DXHANDLE constant) > +{ > + struct ID3DXConstantTableImpl *const_table = impl_from_ID3DXConstantTable(iface); > + struct ctab_constant *c = get_valid_constant(const_table, constant); > + > + TRACE("const_table %p, constant %p.\n", const_table, constant); > + > + if (!c) > + { > + WARN("Invalid argument specified.\n"); > + return NULL; > + } > + > + return c->raw_constant_info; > +} > + > static HRESULT WINAPI ID3DXConstantTableImpl_GetConstantDesc(ID3DXConstantTable *iface, D3DXHANDLE constant, > D3DXCONSTANT_DESC *desc, UINT *count) > { > @@ -2052,6 +2069,7 @@ HRESULT WINAPI D3DXGetShaderConstantTableEx(const DWORD *byte_code, DWORD flags, > { > object->constants[i].desc.RegisterCount = constant_info[i].RegisterCount; > } > + object->constants[i].raw_constant_info = &constant_info[i]; > } > > *constant_table = &object->ID3DXConstantTable_iface; I don't like this all that much. If you need access to the original D3DXSHADER_CONSTANTINFO only for the Reserved field, as in the next patch, I'd say just store that one in struct ctab_constant. Then, for the retrieval part, I don't think it makes much sense to hide our internals from ourselves. You could move the definition of struct ctab_constant to d3dx9_private.h and introduce an internal function to return it from the constant table. You could then entirely replace the use of ID3DXConstantTable_GetConstantDesc(), if you want. Otherwise you can keep that part as-is for the time being and make use of the new function only to get to the Reserved data. Actually, if you go with the latter, it probably makes sense to merge this patch into the next.

1 0

Re: [PATCH 4/7] d3dx9: Get rid of init_set_constants() function.
by Matteo Bruni 10 Jul '17

10 Jul '17

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 58 ++++++++++++++--------------------------------- > 1 file changed, 17 insertions(+), 41 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index cabddcd..1aaf59d 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -305,7 +305,8 @@ static unsigned int get_reg_components(unsigned int table) > > #define PRES_BITMASK_BLOCK_SIZE (sizeof(unsigned int) * 8) > > -static HRESULT init_set_constants(struct d3dx_const_tab *const_tab, ID3DXConstantTable *ctab); > +static HRESULT init_set_constants_param(struct d3dx_const_tab *const_tab, ID3DXConstantTable *ctab, > + D3DXHANDLE hc, struct d3dx_parameter *param); With some function reordering this forward declaration shouldn't be necessary at all.

1 0

Re: [PATCH 3/7] d3dx9: Simplify init and cleanup in get_constants_desc().
by Matteo Bruni 10 Jul '17

10 Jul '17

2017-07-06 13:15 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index 2fb14ab..cabddcd 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -618,10 +618,6 @@ static HRESULT get_constants_desc(unsigned int *byte_code, struct d3dx_const_tab > D3DXHANDLE hc; > unsigned int i; > > - out->inputs = cdesc = NULL; > - out->inputs_param = NULL; > - out->input_count = 0; > - inputs_param = NULL; > hr = D3DXGetShaderConstantTable(byte_code, &ctab); > if (FAILED(hr) || !ctab) > { > @@ -635,8 +631,8 @@ static HRESULT get_constants_desc(unsigned int *byte_code, struct d3dx_const_tab > goto err_out; > } > > - cdesc = HeapAlloc(GetProcessHeap(), 0, sizeof(*cdesc) * desc.Constants); > - inputs_param = HeapAlloc(GetProcessHeap(), 0, sizeof(*inputs_param) * desc.Constants); > + out->inputs = cdesc = HeapAlloc(GetProcessHeap(), 0, sizeof(*cdesc) * desc.Constants); > + out->inputs_param = inputs_param = HeapAlloc(GetProcessHeap(), 0, sizeof(*inputs_param) * desc.Constants); > if (!cdesc || !inputs_param) > { > hr = E_OUTOFMEMORY; > @@ -678,16 +674,9 @@ static HRESULT get_constants_desc(unsigned int *byte_code, struct d3dx_const_tab > } > } > out->input_count = desc.Constants; > - out->inputs = cdesc; > - out->inputs_param = inputs_param; > hr = init_set_constants(out, ctab); > - ID3DXConstantTable_Release(ctab); > - return hr; > err_out: > - HeapFree(GetProcessHeap(), 0, cdesc); > - HeapFree(GetProcessHeap(), 0, inputs_param); > - if (ctab) > - ID3DXConstantTable_Release(ctab); > + ID3DXConstantTable_Release(ctab); > return hr; > } It would be a nice cleanup to rename the err_out: label to cleanup:, done: or similar.

1 0

Re: [PATCH 1/2] widl: Only generate Proxy Stubs when functions have the call_as attribute
by Nikolay Sivov 10 Jul '17

10 Jul '17

On 10.07.2017 7:43, Alistair Leslie-Hughes wrote: > Fixes: https://bugs.winehq.org/show_bug.cgi?id=43302 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > tools/widl/header.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/widl/header.c b/tools/widl/header.c > index 7b97158..e48b488 100644 > --- a/tools/widl/header.c > +++ b/tools/widl/header.c > @@ -1172,7 +1172,7 @@ static void write_method_proto(FILE *header, const type_t *iface) > { > const var_t *func = stmt->u.var; > > - if (!is_local(func->attrs)) { > + if (is_callas(func->attrs)) { > const char *callconv = get_attrp(func->type->attrs, ATTR_CALLCONV); > if (!callconv) callconv = "STDMETHODCALLTYPE"; > /* proxy prototype */ > This is wrong, 'call_as' is used to map different method to be used for remote calls. Midl certainly does not limit prototype generation like that. You mentioned 'odl' attribute on bug report, it's irrelevant too.

2 2

Re: [v2 PATCH] widl: Only generate Proxy Stubs when functions have the call_as attribute
by Huw Davies 10 Jul '17

10 Jul '17

On Mon, Jul 10, 2017 at 10:11:42AM +0000, Alistair Leslie-Hughes wrote: > Fixes: https://bugs.winehq.org/show_bug.cgi?id=43302 > > v2: Merge two matches together. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > include/unknwn.idl | 10 ++++++++++ > tools/widl/header.c | 2 +- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/unknwn.idl b/include/unknwn.idl > index 78a2d9db18..7856a7f504 100644 > --- a/include/unknwn.idl > +++ b/include/unknwn.idl > @@ -46,6 +46,16 @@ interface IUnknown > ULONG Release(); > } > > +cpp_quote("HRESULT STDMETHODCALLTYPE IUnknown_QueryInterface_Proxy(IUnknown* This, REFIID riid, void **ppvObject);") > +cpp_quote("void __RPC_STUB IUnknown_QueryInterface_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > +cpp_quote("ULONG STDMETHODCALLTYPE IUnknown_AddRef_Proxy(IUnknown* This);") > +cpp_quote("void __RPC_STUB IUnknown_AddRef_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > +cpp_quote("ULONG STDMETHODCALLTYPE IUnknown_Release_Proxy(IUnknown* This);") > +cpp_quote("void __RPC_STUB IUnknown_Release_Stub(IRpcStubBuffer* This, IRpcChannelBuffer* pRpcChannelBuffer,") > +cpp_quote(" PRPC_MESSAGE pRpcMessage, DWORD* pdwStubPhase);") > + > cpp_quote("#ifdef SAVE_WIDL_C_INLINE_WRAPPERS") > cpp_quote("#define WIDL_C_INLINE_WRAPPERS") > cpp_quote("#endif") > diff --git a/tools/widl/header.c b/tools/widl/header.c > index 7b971582db..e48b488ae3 100644 > --- a/tools/widl/header.c > +++ b/tools/widl/header.c > @@ -1172,7 +1172,7 @@ static void write_method_proto(FILE *header, const type_t *iface) > { > const var_t *func = stmt->u.var; > > - if (!is_local(func->attrs)) { > + if (is_callas(func->attrs)) { > const char *callconv = get_attrp(func->type->attrs, ATTR_CALLCONV); > if (!callconv) callconv = "STDMETHODCALLTYPE"; > /* proxy prototype */ On further testing with midl v7, /Os does emit Proxy/Stub prototypes for all functions. Since widl essentially runs in this mode, I'd prefer to keep this behaviour if possible. In the bug you mention redefinition errors in qmgrprxy. How are you getting these? Huw.

1 1

Wine appimage request
by Dpto Catastro Topografia MuniSantaCruz 10 Jul '17

10 Jul '17

Hello, I have used this software and it has been very useful to me, I am a surveyor engineer and free software user. A year ago in the world linux have agreed to generate universal packages self-contained with everything they need to install on any linux distribution. Of which there are today 3; Simon Peter's appimage, Gnome flatpak and Canonical snaps. The advantage of these packages is that they use everything in the same package to work, libraries and so on. Hence they can be installed in any linux distribution. It would be great to see the WINE in appimage or in flatpak or snap, and avoid using the terminal for new users. I somehow defend myself with the terminal but sometimes it is still somewhat annoying and tedious. I leave you the links of these new packaging technologies, so that you can analyze them and may in the not too distant future offer some of these simple packages. In fact I prefer appimage, I downloaded several of these applications with this type of package and is simple to use and distribute. Flatpak and snap are still using the terminal to install them, the snaps are fairly simple (it will be installed in the gnome and kde software center in 2018), flatpak the gnome desktop and kde install it from the software center to install packages Flatpak. Appimage has its own charm and does not use the terminal, just make executable and run. Thank you Links Http://appimage.org/ Http://flatpak.org/ Https://snapcraft.io/ atte Luis V --

1 0

Re: [PATCH 5/5] d3drm: Assign animation key ids
by Henri Verbeet 10 Jul '17

10 Jul '17

On 10 July 2017 at 12:40, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static BOOL d3drm_animation_get_next_key_id(struct d3drm_animation_keys *keys, DWORD *id) > +{ > + DWORD i; > + > + if (keys->next_unused <= keys->last_id) > + { > + *id = keys->next_unused++; > + return TRUE; > + } > + > + if (keys->next_free <= keys->last_id) > + { > + *id = keys->next_free; > + keys->next_free = ~0u; > + return TRUE; > + } > + > + if (keys->count == keys->last_id - keys->first_id + 1) > + return FALSE; > + > + /* Worst case, look for the spot from the beginning. */ > + for (i = 0, *id = keys->first_id; i < keys->count; i++, ++*id) > + { > + if (*id != keys->keys[i].id) > + break; > + } Does that work? The keys aren't necessarily ordered by ID, right? Regardless, it may be easier to make use of the fact that we never shrink the keys array.

1 0

Re: server: Don't allow APCs on objects associated with completion port.
by Marvin 10 Jul '17

10 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32203 Your paranoid android. === w7u (32 bit sock) === sock.c:6121: Test failed: Expected event sequence [FD_WRITE(0)], got [] sock.c:6142: Test failed: Expected event sequence [FD_READ(0) FD_CLOSE(0)], got [FD_WRITE(0) FD_CLOSE(10053)] sock.c:6145: Test failed: Failed to empty buffer: -1 - 10054 sock.c:6146: Test failed: Expected event sequence [FD_READ(0)], got [] sock.c:6149: Test failed: Failed to empty buffer: -1 - 10054

1 0

Re: [PATCH 2/2] msvcp140: Implement _File_size.
by Piotr Caban 10 Jul '17

10 Jul '17

On 07/09/17 22:14, Stefan Dösinger wrote: > static int (__cdecl *p_To_wide)(const char *src, WCHAR *dst); > +static ULONGLONG(__cdecl *p_File_size)(WCHAR const*); Please add a space after ULONGLONG. > +static void test_File_size(void) > +{ > + ULONGLONG val; > + HANDLE file; > + LARGE_INTEGER file_size; > + WCHAR test_f1_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r','/','f','1',0}; > + WCHAR test_f2_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r','/','f','2',0}; > + WCHAR test_dir_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r',0}; > + WCHAR test_ne_W[] = {'t','r','2','_','t','e','s','t','_','d','i','r','/','n','e',0}; > + CreateDirectoryW(test_dir_W, NULL); Could you please create the test files in temp directory? Also please rename the directory (these are no longer tr2 namespace tests). > +/* _File_size, msvcp140 version. Different error handling. */ > +ULONGLONG __cdecl _File_size(WCHAR const* path) > +{ > + WIN32_FILE_ATTRIBUTE_DATA fad; > + > + TRACE("(%s)\n", debugstr_w(path)); > + if(!GetFileAttributesExW(path, GetFileExInfoStandard, &fad)) > + return ~0ULL; > + if(fad.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) > + return 0; We don't need to handle the directory separately here. It will have file size set to 0 anyway. Thanks, Piotr

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel