- wine-devel - winehq.org

Re: [PATCH] ddraw: Avoid break in __TRY blocks.
by Sebastian Lackner 15 Feb '17

15 Feb '17

On 14.02.2017 22:56, Stefan Dösinger wrote: > This fixes compilation on Visual Studio with native compiler exceptions. > > Signed-off-by: Stefan Dösinger <stefandoesinger(a)gmx.at> While you are just at it, please note that this code also contains a leak when the exception is triggered. Actually, it would probably be easier to test if the pointer is writeable in advance, and exit early without creating the surface at all. > --- > dlls/ddraw/ddraw.c | 36 ++++++++++++++++++++++-------------- > 1 file changed, 22 insertions(+), 14 deletions(-) > > diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c > index 254dae7..54f3817 100644 > --- a/dlls/ddraw/ddraw.c > +++ b/dlls/ddraw/ddraw.c > @@ -2836,11 +2836,13 @@ static HRESULT WINAPI ddraw7_CreateSurface(IDirectDraw7 *iface, DDSURFACEDESC2 * > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface7_iface; > - IDirectDraw7_AddRef(iface); > - impl->ifaceToRelease = (IUnknown *)iface; > + else > + { > + *surface = &impl->IDirectDrawSurface7_iface; > + IDirectDraw7_AddRef(iface); > + impl->ifaceToRelease = (IUnknown *)iface; > + } > } > __EXCEPT_PAGE_FAULT > { > @@ -2898,11 +2900,13 @@ static HRESULT WINAPI ddraw4_CreateSurface(IDirectDraw4 *iface, > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface4_iface; > - IDirectDraw4_AddRef(iface); > - impl->ifaceToRelease = (IUnknown *)iface; > + else > + { > + *surface = &impl->IDirectDrawSurface4_iface; > + IDirectDraw4_AddRef(iface); > + impl->ifaceToRelease = (IUnknown *)iface; > + } > } > __EXCEPT_PAGE_FAULT > { > @@ -2962,10 +2966,12 @@ static HRESULT WINAPI ddraw2_CreateSurface(IDirectDraw2 *iface, > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface_iface; > - impl->ifaceToRelease = NULL; > + else > + { > + *surface = &impl->IDirectDrawSurface_iface; > + impl->ifaceToRelease = NULL; > + } > } > __EXCEPT_PAGE_FAULT > { > @@ -3022,10 +3028,12 @@ static HRESULT WINAPI ddraw1_CreateSurface(IDirectDraw *iface, > if (FAILED(hr)) > { > *surface = NULL; > - break; > } > - *surface = &impl->IDirectDrawSurface_iface; > - impl->ifaceToRelease = NULL; > + else > + { > + *surface = &impl->IDirectDrawSurface_iface; > + impl->ifaceToRelease = NULL; > + } > } > __EXCEPT_PAGE_FAULT > { >

3 4

Re: [PATCH 2/3] dpnet: Add basic validation in IDirectPlay8Peer EnumHosts
by Marvin 15 Feb '17

15 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28626 Your paranoid android. === wvistau64 (64 bit client) === client.c:645: Test failed: got 0x80004005

1 0

Re: [PATCH] Made ODBC function signatures 64-bit compliant
by Alistair Leslie-Hughes 15 Feb '17

15 Feb '17

On 15/02/17 05:55, Andreas Damm wrote: > From: Andreas Damm <andreas(a)insightsoftware.com> > > --- > dlls/odbc32/proxyodbc.c | 108 +++++++++++++++++++++++----------------------- > include/sql.h | 36 ++++++++-------- > include/sqlext.h | 22 +++++----- > 3 files changed, 83 insertions(+), 83 deletions(-) ~/wine$ patch -p1 < \[PATCH\]\ Made\ ODBC\ function\ signatures\ 64-bit\ compliant.txt This fails to apply against git. patching file dlls/odbc32/proxyodbc.c Hunk #11 succeeded at 1095 with fuzz 2. Hunk #14 succeeded at 1408 with fuzz 2. Hunk #15 succeeded at 1420 with fuzz 2. Hunk #16 succeeded at 1445 with fuzz 2. Hunk #19 succeeded at 1546 with fuzz 2. Hunk #29 succeeded at 2412 with fuzz 2. patching file include/sql.h Hunk #1 FAILED at 506. Hunk #7 FAILED at 669. 2 out of 11 hunks FAILED -- saving rejects to file include/sql.h.rej patching file include/sqlext.h Hunk #1 FAILED at 1455. Hunk #2 FAILED at 1472. Hunk #3 FAILED at 1515. Hunk #5 FAILED at 1578. Hunk #6 succeeded at 1629 with fuzz 1. 4 out of 6 hunks FAILED -- saving rejects to file include/sqlext.h.rej Best Regards Alistair Leslie-Hughes

3 2

Re: [3/4] Use CP 1200 (Unicode) for Win32/Win64 version info.
by Alexandre Julliard 14 Feb '17

14 Feb '17

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> > --- > dlls/version/tests/info.c | 2 -- > include/wine/wine_common_ver.rc | 10 +++++++++- > 2 files changed, 9 insertions(+), 3 deletions(-) This is breaking some tests: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so activex && touch activex.ok activex.c:2426: Test failed: expected CreateInstance activex.c:2429: Test failed: expected QuickActivate activex.c:2432: Test failed: expected IPersistPropertyBag_Load activex.c:2433: Test failed: expected Invoke_READYSTATE activex.c:2434: Test failed: expected Invoke_SECURITYCTX activex.c:2435: Test failed: expected Invoke_SCRIPTCALL activex.c:2440: Test failed: expected DoVerb activex.c:2443: Test failed: expected InPlaceObject_GetWindow activex.c:2444: Test failed: expected SetObjectRects wine: Unhandled page fault on read access to 0x00000000 at address 0x7ecb5d28 (thread 0072), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] Made ODBC function signatures 64-bit compliant
by Alistair Leslie-Hughes 14 Feb '17

14 Feb '17

On 15/02/17 05:55, Andreas Damm wrote: > From: Andreas Damm <andreas(a)insightsoftware.com> > > --- > dlls/odbc32/proxyodbc.c | 108 +++++++++++++++++++++++----------------------- > include/sql.h | 36 ++++++++-------- > include/sqlext.h | 22 +++++----- > 3 files changed, 83 insertions(+), 83 deletions(-) ~/wine$ patch -p1 < \[PATCH\]\ Made\ ODBC\ function\ signatures\ 64-bit\ compliant.txt This fails to apply against git. patching file dlls/odbc32/proxyodbc.c Hunk #11 succeeded at 1095 with fuzz 2. Hunk #14 succeeded at 1408 with fuzz 2. Hunk #15 succeeded at 1420 with fuzz 2. Hunk #16 succeeded at 1445 with fuzz 2. Hunk #19 succeeded at 1546 with fuzz 2. Hunk #29 succeeded at 2412 with fuzz 2. patching file include/sql.h Hunk #1 FAILED at 506. Hunk #7 FAILED at 669. 2 out of 11 hunks FAILED -- saving rejects to file include/sql.h.rej patching file include/sqlext.h Hunk #1 FAILED at 1455. Hunk #2 FAILED at 1472. Hunk #3 FAILED at 1515. Hunk #5 FAILED at 1578. Hunk #6 succeeded at 1629 with fuzz 1. 4 out of 6 hunks FAILED -- saving rejects to file include/sqlext.h.rej Best Regards Alistair Leslie-Hughes

1 0

Re: [v3 PATCH] d2d1: Added support for ID2D1GdiInteropRenderTarget interface
by Jacek Caban 14 Feb '17

14 Feb '17

Hi Nikolay, It looks correct to me now. On 14.02.2017 16:19, Nikolay Sivov wrote: > --- a/dlls/d2d1/bitmap_render_target.c > +++ b/dlls/d2d1/bitmap_render_target.c > @@ -32,6 +32,8 @@ static inline struct d2d_bitmap_render_target *impl_from_ID2D1BitmapRenderTarget > static HRESULT STDMETHODCALLTYPE d2d_bitmap_render_target_QueryInterface(ID2D1BitmapRenderTarget *iface, > REFIID iid, void **out) > { > + struct d2d_bitmap_render_target *render_target = impl_from_ID2D1BitmapRenderTarget(iface); > + > TRACE("iface %p, iid %s, out %p.\n", iface, debugstr_guid(iid), out); > > if (IsEqualGUID(iid, &IID_ID2D1BitmapRenderTarget) > @@ -43,6 +45,8 @@ static HRESULT STDMETHODCALLTYPE d2d_bitmap_render_target_QueryInterface(ID2D1Bi > *out = iface; > return S_OK; > } > + else if (IsEqualGUID(iid, &IID_ID2D1GdiInteropRenderTarget)) > + return ID2D1RenderTarget_QueryInterface(render_target->dxgi_target, iid, out); You could just call QI on dxgi_target unconditionally here. It will handle failure for you as well. Also by having this logic in one place, if there are any more interfaces that you'd like to expose from dxgi_target in the future, only dxgi_target QI change would be needed. That's not very important at the moment and I don't really know relevant code, so feel free to ignore that comment :) Thanks, Jacek

2 1

Re: [4/4] version: Replace kernel32 translation info in non-US locales.
by Alexandre Julliard 14 Feb '17

14 Feb '17

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -1078,6 +1086,67 @@ BOOL WINAPI VerQueryValueW( LPCVOID pBlock, LPCWSTR lpSubBlock, > return VersionInfo32_QueryValue(info, lpSubBlock, lplpBuffer, puLen, NULL); > } > > +/* replace translation info as some apps requires localised info from kernel32 */ > +static void replace_translation_info( void *info, DWORD len ) > +{ > + static const WCHAR product_nameW[] = {'\\','S','t','r','i','n','g', > + 'F','i','l','e','I','n','f','o', > + '\\','0','4','0','9','0','4','B','0', > + '\\','P','r','o','d','u','c','t', > + 'N','a','m','e',0}; > + static const WCHAR original_filenameW[] = {'\\','S','t','r','i','n','g', > + 'F','i','l','e','I','n','f','o', > + '\\','0','4','0','9','0','4','B','0', > + '\\','O','r','i','g','i','n','a','l', > + 'F','i','l','e','n','a','m','e',0}; > + static const WCHAR wineW[] = {'W','i','n','e', 0}; > + static const WCHAR kernel32W[] = {'k','e','r','n','e','l','3','2','.','d','l','l',0}; That's very hackish, we need a more general solution. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 3/9] server: Allow creating async objects without associated queue.
by Alexandre Julliard 14 Feb '17

14 Feb '17

Jacek Caban <jacek(a)codeweavers.com> writes: > Creating async object also validates and resets passed event, which (at > least in some cases) should be done too early to queue the async. That's > what following patches do for read and write to match error handling > pattern. > > Also, it seems nice to pass ready to use async object instead of > async_data_t pointer to fd ops. Maybe, but then please clean this up some more. Instead of adding a bunch of optional arguments, please split the functionality into separate functions. For instance, if create_async() is not always queuing, then make queuing a separate step in all cases. Also if we pass the async object we shouldn't need to pass the async data or iosb. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v5 1/3] storage.dll16: Simplify operations in IStream16::Seek.
by Alexandre Julliard 14 Feb '17

14 Feb '17

Zebediah Figura <z.figura12(a)gmail.com> writes: > + case SEEK_END: > + if (offset.QuadPart > This->stde.pps_size) > + return STG_E_INVALIDFUNCTION; > + > + This->offset.QuadPart = This->stde.pps_size-offset.QuadPart; I know the previous code was doing this too, but it doesn't look right. The offset should be added, not subtracted. > + /* offset must be ==0 (<0 is invalid, and >0 cannot be handled > + * right now. > + */ > + assert(This->offset.u.HighPart == 0); You should get rid of the assert while you are at it, that's not appropriate for parameters passed from the application. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] crypt32: Test CryptStringToBinary with weird base64.
by Alexandre Julliard 14 Feb '17

14 Feb '17

Lauri Kenttä <lauri.kentta(a)gmail.com> writes: > +static void decodeBase64WithLenFmt(LPCSTR str, int len, DWORD fmt, LPCSTR expected, int le, BOOL isBroken) > +{ > + BYTE buf[8] = {0}; > + DWORD bufLen = sizeof(buf), fmtUsed; > + BOOL ret; > + SetLastError(0); Something like 0xdeadbeef would be better. > + ret = pCryptStringToBinaryA(str, len, fmt, buf, &bufLen, NULL, &fmtUsed); > + buf[bufLen] = 0; This will overflow the buffer if the length hasn't been set. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/4 v2] gdiplus: Reimplement GdipCreateHBITMAPFromBitmap so it can work on locked bitmaps
by Vincent Povirk 14 Feb '17

14 Feb '17

+ GdipGetImageFlags(&bitmap->image, &flags); The result here is unused.

1 0

Re: [v4 1/4] ntdll: Proper handling of debug regs on x86-64.
by Sebastian Lackner 13 Feb '17

13 Feb '17

On 12.02.2017 23:41, Andrew Wesie wrote: > Based on existing code for i386. Code is shared when possible to avoid too > much duplication, even though this leads to more ifdefs. > > Signed-off-by: Andrew Wesie <awesie(a)gmail.com> > --- > dlls/ntdll/ntdll_misc.h | 28 ++++++++++---------- > dlls/ntdll/signal_x86_64.c | 64 +++++++++++++++++++++++++++++++++++++++++++--- > dlls/ntdll/thread.c | 12 +++++++-- > 3 files changed, 85 insertions(+), 19 deletions(-) > > diff --git a/dlls/ntdll/ntdll_misc.h b/dlls/ntdll/ntdll_misc.h > index 5e4c39e..5c5cbd2 100644 > --- a/dlls/ntdll/ntdll_misc.h > +++ b/dlls/ntdll/ntdll_misc.h > @@ -215,25 +215,27 @@ struct debug_info > /* thread private data, stored in NtCurrentTeb()->SpareBytes1 */ > struct ntdll_thread_data > { > +#if defined(__i386__) || defined(__x86_64__) > + DWORD_PTR dr0; /* 1bc/2e8 Debug registers */ > + DWORD_PTR dr1; /* 1c0/2f0 */ > + DWORD_PTR dr2; /* 1c4/2f8 */ > + DWORD_PTR dr3; /* 1c8/300 */ > + DWORD_PTR dr6; /* 1cc/308 */ > + DWORD_PTR dr7; /* 1d0/310 */ > +#endif > #ifdef __i386__ > - DWORD dr0; /* 1bc Debug registers */ > - DWORD dr1; /* 1c0 */ > - DWORD dr2; /* 1c4 */ > - DWORD dr3; /* 1c8 */ > - DWORD dr6; /* 1cc */ > - DWORD dr7; /* 1d0 */ > DWORD fs; /* 1d4 TEB selector */ > DWORD gs; /* 1d8 libc selector; update winebuild if you move this! */ > void *vm86_ptr; /* 1dc data for vm86 mode */ > #else > - void *exit_frame; /* /2e8 exit frame pointer */ > + void *exit_frame; /* /318 exit frame pointer */ > #endif > - struct debug_info *debug_info; /* 1e0/2f0 info for debugstr functions */ > - int request_fd; /* 1e4/2f8 fd for sending server requests */ > - int reply_fd; /* 1e8/2fc fd for receiving server replies */ > - int wait_fd[2]; /* 1ec/300 fd for sleeping server requests */ > - BOOL wow64_redir; /* 1f4/308 Wow64 filesystem redirection flag */ > - pthread_t pthread_id; /* 1f8/310 pthread thread id */ > + struct debug_info *debug_info; /* 1e0/320 info for debugstr functions */ > + int request_fd; /* 1e4/328 fd for sending server requests */ > + int reply_fd; /* 1e8/32c fd for receiving server replies */ > + int wait_fd[2]; /* 1ec/330 fd for sleeping server requests */ > + BOOL wow64_redir; /* 1f4/338 Wow64 filesystem redirection flag */ > + pthread_t pthread_id; /* 1f8/340 pthread thread id */ > #ifdef __i386__ > WINE_VM86_TEB_INFO vm86; /* 1fc vm86 private data */ > void *exit_frame; /* 204 exit frame pointer */ Adding those fields should work, but it is a bit dangerous because we only have limited space. I would suggest adding asserts to ensure we never make this struct too big. Something like this should work: C_ASSERT( FIELD_OFFSET(TEB, SpareBytes1) + sizeof(struct ntdll_thread_data) <= FIELD_OFFSET(TEB, GdiTebBatch) + sizeof(((TEB *)0)->GdiTebBatch) ); Probably we should also use it for important i386 fields, to ensure they are not moved. #ifdef __i386__ C_ASSERT( FIELD_OFFSET(TEB, SpareBytes1) + FIELD_OFFSET(struct ntdll_thread_data, vm86) == FIELD_OFFSET(TEB, GdiTebBatch) ); C_ASSERT( FIELD_OFFSET(TEB, SpareBytes1) + FIELD_OFFSET(struct ntdll_thread_data, vm86) == 0x1fc ); C_ASSERT( FIELD_OFFSET(TEB, SpareBytes1) + FIELD_OFFSET(struct ntdll_thread_data, gs) == 0x1d8 ); #endif > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index f33fe4c..d2b040e 100644 > --- a/dlls/ntdll/signal_x86_64.c > +++ b/dlls/ntdll/signal_x86_64.c > @@ -1649,7 +1649,9 @@ static inline BOOL is_inside_signal_stack( void *ptr ) > */ > static void save_context( CONTEXT *context, const ucontext_t *sigcontext ) > { > - context->ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_SEGMENTS; > + struct ntdll_thread_data * const regs = ntdll_get_thread_data(); > + > + context->ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_SEGMENTS | CONTEXT_DEBUG_REGISTERS; > context->Rax = RAX_sig(sigcontext); > context->Rcx = RCX_sig(sigcontext); > context->Rdx = RDX_sig(sigcontext); > @@ -1686,6 +1688,12 @@ static void save_context( CONTEXT *context, const ucontext_t *sigcontext ) > #else > __asm__("movw %%ss,%0" : "=m" (context->SegSs)); > #endif > + context->Dr0 = regs->dr0; > + context->Dr1 = regs->dr1; > + context->Dr2 = regs->dr2; > + context->Dr3 = regs->dr3; > + context->Dr6 = regs->dr6; > + context->Dr7 = regs->dr7; > if (FPU_sig(sigcontext)) > { > context->ContextFlags |= CONTEXT_FLOATING_POINT; > @@ -1702,6 +1710,14 @@ static void save_context( CONTEXT *context, const ucontext_t *sigcontext ) > */ > static void restore_context( const CONTEXT *context, ucontext_t *sigcontext ) > { > + struct ntdll_thread_data * const regs = ntdll_get_thread_data(); > + > + regs->dr0 = context->Dr0; > + regs->dr1 = context->Dr1; > + regs->dr2 = context->Dr2; > + regs->dr3 = context->Dr3; > + regs->dr6 = context->Dr6; > + regs->dr7 = context->Dr7; > RAX_sig(sigcontext) = context->Rax; > RCX_sig(sigcontext) = context->Rcx; > RDX_sig(sigcontext) = context->Rdx; > @@ -1861,6 +1877,16 @@ __ASM_GLOBAL_FUNC( set_full_cpu_context, > void set_cpu_context( const CONTEXT *context ) > { > DWORD flags = context->ContextFlags & ~CONTEXT_AMD64; > + > + if (flags & CONTEXT_DEBUG_REGISTERS) > + { > + ntdll_get_thread_data()->dr0 = context->Dr0; > + ntdll_get_thread_data()->dr1 = context->Dr1; > + ntdll_get_thread_data()->dr2 = context->Dr2; > + ntdll_get_thread_data()->dr3 = context->Dr3; > + ntdll_get_thread_data()->dr6 = context->Dr6; > + ntdll_get_thread_data()->dr7 = context->Dr7; > + } > if (flags & CONTEXT_FULL) > { > if (!(flags & CONTEXT_CONTROL)) > @@ -2559,7 +2585,7 @@ static void raise_segv_exception( EXCEPTION_RECORD *rec, CONTEXT *context ) > } > break; > } > - status = raise_exception( rec, context, TRUE ); > + status = NtRaiseException( rec, context, TRUE ); > if (status) raise_status( status, rec ); NtRaiseException will always return a status != 0, so there is no need for the check anymore. > done: > set_cpu_context( context ); > @@ -2567,13 +2593,43 @@ done: > > > /********************************************************************** > + * raise_trap_exception > + */ > +static void raise_trap_exception( EXCEPTION_RECORD *rec, CONTEXT *context ) > +{ > + NTSTATUS status; > + > + if (rec->ExceptionCode == EXCEPTION_SINGLE_STEP) > + { > + /* when single stepping can't tell whether this is a hw bp or a > + * single step interrupt. try to avoid as much overhead as possible > + * and only do a server call if there is any hw bp enabled. */ > + > + if( !(context->EFlags & 0x100) || (ntdll_get_thread_data()->dr7 & 0xff) ) > + { > + /* (possible) hardware breakpoint, fetch the debug registers */ > + DWORD saved_flags = context->ContextFlags; > + context->ContextFlags = CONTEXT_DEBUG_REGISTERS; > + NtGetContextThread(GetCurrentThread(), context); > + context->ContextFlags |= saved_flags; /* restore flags */ > + } > + > + context->EFlags &= ~0x100; /* clear single-step flag */ > + } > + > + status = NtRaiseException( rec, context, TRUE ); > + raise_status( status, rec ); > +} > + > + > +/********************************************************************** > * raise_generic_exception > * > * Generic raise function for exceptions that don't need special treatment. > */ > static void raise_generic_exception( EXCEPTION_RECORD *rec, CONTEXT *context ) > { > - NTSTATUS status = raise_exception( rec, context, TRUE ); > + NTSTATUS status = NtRaiseException( rec, context, TRUE ); > if (status) raise_status( status, rec ); > set_cpu_context( context ); Similar to above, this can be simplified because status is always != 0. > } > @@ -2684,7 +2740,7 @@ static void segv_handler( int signal, siginfo_t *siginfo, void *sigcontext ) > */ > static void trap_handler( int signal, siginfo_t *siginfo, void *sigcontext ) > { > - EXCEPTION_RECORD *rec = setup_exception( sigcontext, raise_generic_exception ); > + EXCEPTION_RECORD *rec = setup_exception( sigcontext, raise_trap_exception ); > > switch (siginfo->si_code) > { > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index c9a5da6..934ada1 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -744,10 +744,14 @@ NTSTATUS WINAPI NtSetContextThread( HANDLE handle, const CONTEXT *context ) > DWORD dummy, i; > BOOL self; > > -#ifdef __i386__ > +#if defined(__i386__) || defined(__x86_64__) > /* on i386 debug registers always require a server call */ > self = (handle == GetCurrentThread()); > +#ifdef __i386__ > if (self && (context->ContextFlags & (CONTEXT_DEBUG_REGISTERS & ~CONTEXT_i386))) > +#elif defined(__x86_64__) > + if (self && (context->ContextFlags & (CONTEXT_DEBUG_REGISTERS & ~CONTEXT_AMD64))) > +#endif > { > self = (ntdll_get_thread_data()->dr0 == context->Dr0 && > ntdll_get_thread_data()->dr1 == context->Dr1 && > @@ -903,9 +907,13 @@ NTSTATUS WINAPI NtGetContextThread( HANDLE handle, CONTEXT *context ) > copy_context( context, &ctx, ctx.ContextFlags & needed_flags ); > context->ContextFlags |= ctx.ContextFlags & needed_flags; > } > -#ifdef __i386__ > +#if defined(__i386__) || defined(__x86_64__) > /* update the cached version of the debug registers */ > +#ifdef __i386__ > if (context->ContextFlags & (CONTEXT_DEBUG_REGISTERS & ~CONTEXT_i386)) > +#elif defined(__x86_64__) > + if (context->ContextFlags & (CONTEXT_DEBUG_REGISTERS & ~CONTEXT_AMD64)) > +#endif > { > ntdll_get_thread_data()->dr0 = context->Dr0; > ntdll_get_thread_data()->dr1 = context->Dr1; > -- 2.7.4 >

2 2

Re: [v4 3/4] ntdll: Save rdi and rsi in raise_func_trampoline.
by Sebastian Lackner 13 Feb '17

13 Feb '17

On 12.02.2017 23:41, Andrew Wesie wrote: > On Windows, RDI and RSI are callee-saved registers, but on Linux > they are caller-saved registers. As such, raise_func_trampoline > needs to explicitly unwind them. > > Signed-off-by: Andrew Wesie <awesie(a)gmail.com> > --- > dlls/ntdll/signal_x86_64.c | 12 +++++++++--- > dlls/ntdll/tests/exception.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 3 deletions(-) > > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index d2b040e..2370cf4 100644 > --- a/dlls/ntdll/signal_x86_64.c > +++ b/dlls/ntdll/signal_x86_64.c > @@ -2092,9 +2092,11 @@ NTSTATUS context_from_server( CONTEXT *to, const context_t *from ) > extern void raise_func_trampoline( EXCEPTION_RECORD *rec, CONTEXT *context, raise_func func ); > __ASM_GLOBAL_FUNC( raise_func_trampoline, > __ASM_CFI(".cfi_signal_frame\n\t") > - __ASM_CFI(".cfi_def_cfa %rbp,144\n\t") /* red zone + rip + rbp */ > - __ASM_CFI(".cfi_rel_offset %rip,8\n\t") > - __ASM_CFI(".cfi_rel_offset %rbp,0\n\t") > + __ASM_CFI(".cfi_def_cfa %rbp,160\n\t") /* red zone + rip + rbp + rdi + rsi */ > + __ASM_CFI(".cfi_rel_offset %rip,24\n\t") > + __ASM_CFI(".cfi_rel_offset %rbp,16\n\t") > + __ASM_CFI(".cfi_rel_offset %rdi,8\n\t") > + __ASM_CFI(".cfi_rel_offset %rsi,0\n\t") > "call *%rdx\n\t" > "int $3") > > @@ -2111,6 +2113,8 @@ static EXCEPTION_RECORD *setup_exception( ucontext_t *sigcontext, raise_func fun > { > CONTEXT context; > EXCEPTION_RECORD rec; > + ULONG64 rsi; > + ULONG64 rdi; > ULONG64 rbp; > ULONG64 rip; > ULONG64 red_zone[16]; > @@ -2180,6 +2184,8 @@ static EXCEPTION_RECORD *setup_exception( ucontext_t *sigcontext, raise_func fun > rsp_ptr = (ULONG64 *)RSP_sig(sigcontext) - 16; > *(--rsp_ptr) = RIP_sig(sigcontext); > *(--rsp_ptr) = RBP_sig(sigcontext); > + *(--rsp_ptr) = RDI_sig(sigcontext); > + *(--rsp_ptr) = RSI_sig(sigcontext); > > /* now modify the sigcontext to return to the raise function */ > RIP_sig(sigcontext) = (ULONG_PTR)raise_func_trampoline; > diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c > index 183cf18..15973ce 100644 > --- a/dlls/ntdll/tests/exception.c > +++ b/dlls/ntdll/tests/exception.c > @@ -2073,6 +2073,47 @@ static DWORD run_exception_test(void *handler, const void* context, > return result; > } > > +static DWORD WINAPI unwind_rdi_rsi_handler( EXCEPTION_RECORD *rec, ULONG64 frame, > + CONTEXT *context, DISPATCHER_CONTEXT *dispatcher ) > +{ > + if (rec->ExceptionCode != STATUS_BREAKPOINT) > + return ExceptionContinueSearch; > + > + RtlUnwind( (PVOID)context->Rsp, (PVOID)(context->Rip + 1), rec, NULL ); Doesn't this suffer from the same problem as before? We might not have unwinding information for the unwind_rdi_rsi_handler function if it is not supported by all x86_64 compilers. Actually, I believe the change itself would also be acceptable even without tests. > + return ExceptionContinueSearch; > +} > + > +static const BYTE unwind_rdi_test_code[] = { > + 0x57, /* push %rdi */ > + 0x48, 0xc7, 0xc7, 0x55, 0x55, 0x55, 0x55, /* mov $0x55555555, %rdi */ > + 0xcc, /* int3 */ > + 0x48, 0x89, 0xf8, /* mov %rdi, %rax */ > + 0x5f, /* pop %rdi */ > + 0xc3, /* ret */ > +}; > + > +static const BYTE unwind_rsi_test_code[] = { > + 0x56, /* push %rsi */ > + 0x48, 0xc7, 0xc6, 0x33, 0x33, 0x33, 0x33, /* mov $0x33333333, %rsi */ > + 0xcc, /* int3 */ > + 0x48, 0x89, 0xf0, /* mov %rsi, %rax */ > + 0x5e, /* pop %rsi */ > + 0xc3, /* ret */ > +}; > + > +static void test_unwind_rdi_rsi(void) > +{ > + DWORD result; > + > + result = run_exception_test(unwind_rdi_rsi_handler, NULL, unwind_rdi_test_code, > + sizeof(unwind_rdi_test_code), 0); > + ok( result == 0x55555555, "expected %x, got %x\n", 0x55555555, result ); > + > + result = run_exception_test(unwind_rdi_rsi_handler, NULL, unwind_rsi_test_code, > + sizeof(unwind_rsi_test_code), 0); > + ok( result == 0x33333333, "expected %x, got %x\n", 0x33333333, result ); > +} > + > #endif /* __x86_64__ */ > > #if defined(__i386__) || defined(__x86_64__) > @@ -2653,6 +2694,7 @@ START_TEST(exception) > test_virtual_unwind(); > test___C_specific_handler(); > test_restore_context(); > + test_unwind_rdi_rsi(); > > if (pRtlAddFunctionTable && pRtlDeleteFunctionTable && pRtlInstallFunctionTableCallback && pRtlLookupFunctionEntry) > test_dynamic_unwind(); > -- 2.7.4 >

2 1

Re: [PATCH 01/14] mshtml/tests: Added body event setters tests.
by Marvin 13 Feb '17

13 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28575 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [v3 1/5] compobj.dll16: Implement CoLoadLibrary16 and CoFreeLibrary16.
by Alexandre Julliard 13 Feb '17

13 Feb '17

Zebediah Figura <z.figura12(a)gmail.com> writes: > +static HRESULT dll_list_add(LPCSTR library_name, struct open_dll **ret) > +{ > + struct open_dll *dll; > + HMODULE16 library; > + FARPROC16 DllCanUnloadNow; > + > + LIST_FOR_EACH_ENTRY(dll, &open_dll_list, struct open_dll, entry) > + { > + if(!strcasecmp(library_name, dll->library_name)) > + { > + TRACE("found %s already loaded\n", debugstr_a(library_name)); > + InterlockedIncrement(&dll->refs); > + *ret = dll; > + return S_OK; > + } > + } I don't think that comparing file names is appropriate for 16-bit, only the module name matters. You should probably call LoadLibrary16 in all cases. > + > + library = LoadLibrary16(library_name); > + if (!library) > + { > + ERR("couldn't load in-process dll %s\n", debugstr_a(library_name)); > + return E_ACCESSDENIED; /* FIXME: or should this be CO_E_DLLNOTFOUND? */ > + } You'd need to check again if the dll already exists, like the 32-bit code does. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [v7 5/6] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Fabian Maurer 13 Feb '17

13 Feb '17

> msg.c:5233: Test failed: RedrawWindow:show_popup_extreme_location: > 12: the msg 0x001c was expected, but got msg 0x0085 instead Can't reproduce the error.

1 0

Re: [v7 5/6] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Marvin 13 Feb '17

13 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28573 Your paranoid android. === w7u (32 bit msg) === msg.c:5233: Test failed: RedrawWindow:show_popup_extreme_location: 12: the msg 0x001c was expected, but got msg 0x0085 instead

1 0

Re: advapi32: add LookupSecurityDescriptorPartsA/W stubs (resend)
by Sebastian Lackner 13 Feb '17

13 Feb '17

On 13.02.2017 09:23, Austin English wrote: > Originally sent in November, with no comments: > https://source.winehq.org/patches/data/127657 > > Fixes https://bugs.winehq.org/show_bug.cgi?id=41682 > > -- -Austin GPG: 14FB D7EA A041 937B > > > 0001-advapi32-add-LookupSecurityDescriptorPartsA-W-stubs.patch > > > From eebe82acd3fd4828a74b38c97f260ddfd2143b83 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 9 Nov 2016 21:43:18 -0600 > Subject: [PATCH] advapi32: add LookupSecurityDescriptorPartsA/W stubs > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > dlls/advapi32/advapi32.spec | 4 ++-- > dlls/advapi32/security.c | 24 ++++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec > index 6c57c88..88d8634 100644 > --- a/dlls/advapi32/advapi32.spec > +++ b/dlls/advapi32/advapi32.spec > @@ -415,8 +415,8 @@ > @ stdcall LookupPrivilegeNameW(wstr ptr ptr ptr) > @ stdcall LookupPrivilegeValueA(ptr ptr ptr) > @ stdcall LookupPrivilegeValueW(ptr ptr ptr) > -# @ stub LookupSecurityDescriptorPartsA > -# @ stub LookupSecurityDescriptorPartsW > +@ stdcall LookupSecurityDescriptorPartsA(ptr ptr ptr ptr ptr ptr ptr) > +@ stdcall LookupSecurityDescriptorPartsW(ptr ptr ptr ptr ptr ptr ptr) > @ stdcall LsaAddAccountRights(ptr ptr ptr long) > @ stub LsaAddPrivilegesToAccount > # @ stub LsaClearAuditLog > diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c > index 7e41c0a..b094015 100644 > --- a/dlls/advapi32/security.c > +++ b/dlls/advapi32/security.c > @@ -6087,3 +6087,27 @@ BOOL WINAPI SaferSetLevelInformation(SAFER_LEVEL_HANDLE handle, SAFER_OBJECT_INF > FIXME("(%p %u %p %u) stub\n", handle, infotype, buffer, size); > return FALSE; > } > + > +/****************************************************************************** > + * LookupSecurityDescriptorPartsA [ADVAPI32.@] > + */ > +DWORD WINAPI LookupSecurityDescriptorPartsA(TRUSTEEA *owner, TRUSTEEA *group, ULONG *access_count, > + EXPLICIT_ACCESSA *access_list, ULONG *audit_count, > + EXPLICIT_ACCESSA *audit_list, SECURITY_DESCRIPTOR *descriptor) > +{ > + FIXME("stub:%p %p %p %p %p %p %p\n", owner, group, access_count, > + access_list, audit_count, audit_list, descriptor); > + return ERROR_SUCCESS; It would be better to return failure when the stub doesn't do anything useful. > +} > + > +/****************************************************************************** > + * LookupSecurityDescriptorPartsW [ADVAPI32.@] > + */ > +DWORD WINAPI LookupSecurityDescriptorPartsW(TRUSTEEW *owner, TRUSTEEW *group, ULONG *access_count, > + EXPLICIT_ACCESSW *access_list, ULONG *audit_count, > + EXPLICIT_ACCESSW *audit_list, SECURITY_DESCRIPTOR *descriptor) > +{ > + FIXME("stub:%p %p %p %p %p %p %p\n", owner, group, access_count, > + access_list, audit_count, audit_list, descriptor); > + return ERROR_SUCCESS; > +} > -- 2.10.2 > > >

1 0

Re: qcap: Fix Query IID_PPin Interface return not found
by Andrew Eikum 13 Feb '17

13 Feb '17

I wrote a quick test for this, and Windows doesn't behave this way. diff --git a/dlls/qcap/tests/qcap.c b/dlls/qcap/tests/qcap.c index d7fe288f4a..eed101cee3 100644 --- a/dlls/qcap/tests/qcap.c +++ b/dlls/qcap/tests/qcap.c @@ -1990,6 +1990,8 @@ static void test_COM_vfwcapture(void) todo_wine ok(hr == E_NOINTERFACE, "QueryInterface for IID_IAMVideoProcAmp failed: %08x\n", hr); hr = IBaseFilter_QueryInterface(bf, &IID_IOverlayNotify, (void**)&unk); ok(hr == E_NOINTERFACE, "QueryInterface for IID_IOverlayNotify failed: %08x\n", hr); + hr = IBaseFilter_QueryInterface(bf, &IID_IPin, (void**)&unk); + ok(hr == E_NOINTERFACE, "QueryInterface for IID_IPin failed: %08x\n", hr); while (IBaseFilter_Release(bf)); } On Thu, Feb 09, 2017 at 02:25:33PM +0800, 谢威 wrote: > ------------------ > ------------------ > > > > 武汉深之度科技有限公司 > Wuhan Deepin Technology Co., Ltd. > > 　　谢威　　 > > 手机：18038104349 > > > 武汉：武汉市光谷大道77号光谷金融港B18栋6楼 > 北京：北京市海淀区知春路锦秋国际大厦B座501室 > 上海：上海市长宁区愚园路1258号15A01室 > > > 官网：www.deepin.com　官博：深度操作系统 >

1 0

Re: [PATCH 01/12] mshtml/tests: Added body event setters tests.
by Marvin 13 Feb '17

13 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28563 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [PATCH 02/12] mshtml: Use inner window's event target for body element.
by Jacek Caban 13 Feb '17

13 Feb '17

Hi, Please ignore the series for now, I will send a better version later. Jacek

1 0

Re: [PATCH 2/7] gdiplus: Initialize bitmap bits for reading in GdipBitmapLockBits when ImageFlagsReadOnly is specified
by Vincent Povirk 13 Feb '17

13 Feb '17

This is very strange behavior. I think you at least need a comment making it clear this is intentional, and some tests. Your test in 7/7 isn't sufficient because it doesn't make it clear that the bits are being converted. I think you should test that the bitmap format is different from the one you use to lock, and add another test with ImageLockModeUserInputBuf. On Wed, Feb 8, 2017 at 9:56 AM, Piotr Caban <piotr(a)codeweavers.com> wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/gdiplus/image.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > >

2 1

Re: [PATCH 2/2] mfreadwrite: Add MFCreateSourceReaderFromMediaSource stub
by Andrew Eikum 13 Feb '17

13 Feb '17

> +WINE_DEFAULT_DEBUG_CHANNEL(mfreadwrite); > There are a bunch of Media Foundation DLLs, I count roughly 12 on my Win7 VM. I think we should stick to just one debug channel in Wine. I suggest "mfplat" since we already have it. Andrew

1 0

Re: [v6 4/6] user32: Add WM_NCPAINT tests for windows crossing screen or maximized
by Alexandre Julliard 13 Feb '17

13 Feb '17

Fabian Maurer <dark.shadow4(a)web.de> writes: > @@ -4580,6 +4643,18 @@ static void test_showwindow(void) > DestroyWindow(hwnd); > flush_sequence(); > > + /* Test again, this time the NC_PAINT message */ > + hwnd = CreateWindowExA(0, "TestWindowClass", "Test popup", WS_POPUP | WS_MAXIMIZE, > + 100, 100, 200, 200, 0, 0, 0, NULL); > + ok (hwnd != 0, "Failed to create popup window\n"); > + SetWindowPos(hwnd, 0, 10, 10, 200, 200, SWP_NOZORDER | SWP_NOACTIVATE); > + flush_sequence(); > + ShowWindow(hwnd, SW_SHOWMAXIMIZED); > + ok_sequence(WmShowMaxPopupResizedSeq_todo, > + "ShowWindow(SW_SHOWMAXIMIZED):invisible maximized and resized popup TODO", TRUE); > + DestroyWindow(hwnd); > + flush_sequence(); This one is already succeeding here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so msg && touch msg.ok msg.c:4654: Test succeeded inside todo block: ShowWindow(SW_SHOWMAXIMIZED):invisible maximized and resized popup TODO: marked "todo_wine" but succeeds msg.c:13361: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:13677: Tests skipped: Unable to load Greek keyboard layout Makefile:482: recipe for target 'msg.ok' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v2 PATCH 2/3] d2d1: Added support for ID2D1GdiInteropRenderTarget interface
by Jacek Caban 13 Feb '17

13 Feb '17

Hi Nikolay, On 12.02.2017 20:14, Nikolay Sivov wrote: > diff --git a/dlls/d2d1/bitmap_render_target.c b/dlls/d2d1/bitmap_render_target.c > index 67b0713376..3ac5c77d36 100644 > --- a/dlls/d2d1/bitmap_render_target.c > +++ b/dlls/d2d1/bitmap_render_target.c > @@ -32,6 +32,8 @@ static inline struct d2d_bitmap_render_target *impl_from_ID2D1BitmapRenderTarget > static HRESULT STDMETHODCALLTYPE d2d_bitmap_render_target_QueryInterface(ID2D1BitmapRenderTarget *iface, > REFIID iid, void **out) > { > + struct d2d_bitmap_render_target *render_target = impl_from_ID2D1BitmapRenderTarget(iface); > + > TRACE("iface %p, iid %s, out %p.\n", iface, debugstr_guid(iid), out); > > if (IsEqualGUID(iid, &IID_ID2D1BitmapRenderTarget) > @@ -43,6 +45,8 @@ static HRESULT STDMETHODCALLTYPE d2d_bitmap_render_target_QueryInterface(ID2D1Bi > *out = iface; > return S_OK; > } > + else if (IsEqualGUID(iid, &IID_ID2D1GdiInteropRenderTarget)) > + return ID2D1RenderTarget_QueryInterface(render_target->dxgi_target, iid, out); AFAICS this won't work. If you call QueryInterface(IID_ID2D1BitmapRenderTarget) on returned ID2D1GdiInteropRenderTarget, it will fail. There are a few solutions for that. The most generic is COM aggregation with separated 'inner' IUnknown for dxgi_target. Thanks, Jacek

2 1

Re: [PATCH 2/3] wined3d: Marge common code between texture3d_load_location() and surface_load_location().
by Henri Verbeet 13 Feb '17

13 Feb '17

On 13 February 2017 at 13:13, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > dlls/wined3d/surface.c | 60 ++------------------------------------ > dlls/wined3d/texture.c | 79 ++++++++++++++++++++++++++++++-------------------- > 2 files changed, 50 insertions(+), 89 deletions(-) > That should have read "Merge" instead of "Marge".

1 0

Re: [PATCH] include: Make break out of __TRY blocks work with compiler exceptions.
by Alexandre Julliard 13 Feb '17

13 Feb '17

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > ddraw.dll uses this. I am using compiler exceptions for my Visual Studio > build setup. A ddraw.dll compiled with this passes the test added by > commit d9f2b4627. I manually tested the functionality of __TRY-__FINALLY, > __EXCEPT_ALL and __EXCEPT(func). It would be better to avoid break, and ideally find a way to disallow it in the Wine macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v4 1/3] storage.dll16: Fix negation in IStream::Seek.
by Huw Davies 13 Feb '17

13 Feb '17

On Sun, Feb 12, 2017 at 12:03:20PM -0600, Zebediah Figura wrote: > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/storage.dll16/storage.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dlls/storage.dll16/storage.c b/dlls/storage.dll16/storage.c > index 74aa7f9..7a5b367 100644 > --- a/dlls/storage.dll16/storage.c > +++ b/dlls/storage.dll16/storage.c > @@ -1196,9 +1196,8 @@ HRESULT CDECL IStream16_fnSeek(IStream16 *iface, LARGE_INTEGER offset, DWORD whe > break; > case SEEK_CUR: > if (offset.u.HighPart < 0) { > - /* FIXME: is this negation correct ? */ > - offset.u.HighPart = -offset.u.HighPart; > - offset.u.LowPart = (0xffffffff ^ offset.u.LowPart)+1; > + offset.u.HighPart = ~offset.u.HighPart + (offset.u.LowPart ? 0 : 1); > + offset.u.LowPart = -offset.u.LowPart; > > assert(offset.u.HighPart==0); > assert(This->offset.u.LowPart >= offset.u.LowPart); > -- Couldn't you just replace the whole SEEK_CUR branch with: This->offset.QuadPart += offset.QuadPart; Huw.

1 0

Re: [PATCH v2 1/3] storage.dll16: Fix negation in IStream::Seek.
by Henri Verbeet 12 Feb '17

12 Feb '17

On 11 February 2017 at 23:54, Zebediah Figura <z.figura12(a)gmail.com> wrote: > @@ -1196,9 +1196,8 @@ HRESULT CDECL IStream16_fnSeek(IStream16 *iface, LARGE_INTEGER offset, DWORD whe > break; > case SEEK_CUR: > if (offset.u.HighPart < 0) { > - /* FIXME: is this negation correct ? */ > - offset.u.HighPart = -offset.u.HighPart; > - offset.u.LowPart = (0xffffffff ^ offset.u.LowPart)+1; > + offset.u.HighPart = ~offset.u.HighPart; > + offset.u.LowPart = -offset.u.LowPart; > I don't think that's quite correct either. Consider e.g. 0xffffffff00000000, the negation of which would be 0x0000000100000000.

2 1

Re: [PATCH] include: Make break out of __TRY blocks work with compiler exceptions.
by Dmitry Timoshkov 12 Feb '17

12 Feb '17

Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > +#define __TRY __try { do > +#define __EXCEPT(func) while(0); } __except((func)(GetExceptionInformation())) { do > +#define __FINALLY(func) while(0); } __finally { (func)(!AbnormalTermination()); } > +#define __ENDTRY while(0); } > +#define __EXCEPT_PAGE_FAULT while(0); } __except(GetExceptionCode() == EXCEPTION_ACCESS_VIOLATION) { do > +#define __EXCEPT_ALL while(0); } __except(EXCEPTION_EXECUTE_HANDLER) { do Perhaps add another '{' after 'do' and and '}' before 'while(0)' ? -- Dmitry.

2 2

Re: kernel32: Avoid two potential buffer overflows of cStr in create_hardware_branch.
by Sebastian Lackner 12 Feb '17

12 Feb '17

On 08.10.2016 22:31, Gerald Pfeifer wrote: > + char cStr[sizeof(dent->d_name)+sizeof(procname_ide_media)], http://man7.org/linux/man-pages/man3/readdir.3.html says: """The standard also notes that the use of sizeof(d_name) is incorrect; use strlen(d_name) instead. (On some systems, this field is defined as char d_name[1]!)""" This means your solution will not work on all systems.

3 4

Re: [PATCH 1/2] RFC: Implement XInputEnable based on MSDN
by Bruno Jesus 12 Feb '17

12 Feb '17

On Sat, Feb 11, 2017 at 9:05 PM, Christoph Brill <egore911(a)gmail.com> wrote: > --- > dlls/xinput1_3/xinput1_3_main.c | 45 ++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 44 insertions(+), 1 deletion(-) Hi, thanks for the patch but currently Wine is aiming at a different direction of reimplementing the 3 joystick API's (winmm, dinput and xinput) using a single HID library so that the OS dependent parts stay in one place. I believe Wine is only months away of having all these working with current Aric Stewart work. Other people (including me) already have suggested at wine-devel/wine-patches more or less completed versions of xinput using SDL, dinput and event libraries before/during the HID model adoption. IMO the best thing that can be done for now is to ensure the winmm driver (in the progress of being commited [1]) works fine so help testing is very welcome. After that we will have a standard to implement the other 2 API's. [1] http://source.winehq.org/patches/data/129688 Best wishes, Bruno

1 0

Re: [PATCH] storage.dll16: Set OpenStorage/OpenStream output to NULL on failure.
by Nikolay Sivov 12 Feb '17

12 Feb '17

On 12.02.2017 2:40, Zebediah Figura wrote: > As per MSDN: https://msdn.microsoft.com/en-us/library/windows/desktop/aa380025(v=vs.85).… > This page covers Win32 variant, it doesn't necessary match how Win16 works, or Win32 too for that matter.

2 1

Re: [PATCH 1/3] storage.dll16: Fix negation in IStream::Seek.
by Alex Henrie 11 Feb '17

11 Feb '17

@@ -1196,9 +1196,8 @@ HRESULT CDECL IStream16_fnSeek(IStream16 *iface, LARGE_INTEGER offset, DWORD whe break; case SEEK_CUR: if (offset.u.HighPart < 0) { - /* FIXME: is this negation correct ? */ - offset.u.HighPart = -offset.u.HighPart; - offset.u.LowPart = (0xffffffff ^ offset.u.LowPart)+1; + offset.u.HighPart = ~offset.u.HighPart; + offset.u.LowPart = -offset.u.LowPart; assert(offset.u.HighPart==0); assert(This->offset.u.LowPart >= offset.u.LowPart); You're mixing tabs and spaces. -Alex

1 0

Re: [v4 2/3] ntdll: Implement FileIdInformation class support in NtQueryInformationFile (resend).
by Sebastian Lackner 10 Feb '17

10 Feb '17

On 07.02.2017 16:11, Jonathan Doron wrote: > Signed-off-by: Jonathan Doron <jond(a)wizery.com> > --- > configure.ac | 2 +- > dlls/ntdll/file.c | 28 ++++++++++++++++++++++- > dlls/ntdll/tests/file.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/winternl.h | 9 ++++++++ > 4 files changed, 97 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index c6d63b2..f66bf44 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2262,7 +2262,7 @@ fi > dnl **** FIXME: what about mixed cases, where we need two of them? *** > > dnl Check for statfs members > -AC_CHECK_MEMBERS([struct statfs.f_bfree, struct statfs.f_bavail, struct statfs.f_frsize, struct statfs.f_ffree, struct statfs.f_favail, struct statfs.f_namelen],,, > +AC_CHECK_MEMBERS([struct statfs.f_bfree, struct statfs.f_bavail, struct statfs.f_frsize, struct statfs.f_ffree, struct statfs.f_favail, struct statfs.f_namelen, struct statfs.f_fsid.__val],,, > [#include <sys/types.h> > #ifdef HAVE_SYS_PARAM_H > # include <sys/param.h> > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index a6c1098..c6ff371 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -2377,7 +2377,7 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io, > 0, /* FileRenameInformationBypassAccessCheck */ > 0, /* FileLinkInformationBypassAccessCheck */ > 0, /* FileVolumeNameInformation */ > - 0, /* FileIdInformation */ > + sizeof(FILE_ID_INFORMATION), /* FileIdInformation */ > 0, /* FileIdExtdDirectoryInformation */ > 0, /* FileReplaceCompletionInformation */ > 0, /* FileHardLinkFullIdInformation */ > @@ -2619,6 +2619,32 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io, > } > } > break; > + case FileIdInformation: > + { > + FILE_ID_INFORMATION *info = ptr; > + memset(info, 0, sizeof(*info)); > + if (fstat(fd, &st) == -1) > + { > + io->u.Status = FILE_GetNtStatus(); > + } > + else > + { > +#if defined(linux) && defined(HAVE_FSTATFS) && defined(HAVE_STRUCT_STATFS_F_FSID___VAL) > + struct statfs volstats; > + if (fstatfs(fd, &volstats) == -1) > + { > + io->u.Status = FILE_GetNtStatus(); > + break; > + } > + > + memcpy(&info->VolumeSerialNumber, > + &volstats.f_fsid.__val, > + min(sizeof(info->VolumeSerialNumber), sizeof(volstats.f_fsid.__val))); I didn't think about this earlier, but if you are planning to use memcpy anyway, wouldn't it be easier to just copy f_fsid directly, instead of f_fsid.__val? When you do not make any assumptions about f_fsid it would work on all platforms. > +#endif > + ((LARGE_INTEGER *)&info->FileId)->QuadPart = st.st_ino; > + } > + } > + break; > default: > FIXME("Unsupported class (%d)\n", class); > io->u.Status = STATUS_NOT_IMPLEMENTED; > diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c > index 57d7df9..00856ab 100644 > --- a/dlls/ntdll/tests/file.c > +++ b/dlls/ntdll/tests/file.c > @@ -1444,6 +1444,65 @@ static void test_file_basic_information(void) > CloseHandle( h ); > } > > +static void test_file_id_information(void) > +{ > + IO_STATUS_BLOCK io; > + FILE_ID_INFORMATION fid1, fid2; > + HANDLE h = INVALID_HANDLE_VALUE; > + NTSTATUS res; > + char path[MAX_PATH], buffer[MAX_PATH]; > + > + /* Generate a temp file name */ Not all of these steps need an explanation, so you could remove some of the comments for things which are obvious. > + GetTempPathA(MAX_PATH, path); > + GetTempFileNameA(path, "foo", 0, buffer); > + > + /* Create the temp file */ > + h = CreateFileA(buffer, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0); > + ok(h != INVALID_HANDLE_VALUE, "CreateFile error %d\n", GetLastError()); > + > + /* Query the temp file unique id */ > + memset(&fid1, 0, sizeof(fid1)); > + res = pNtQueryInformationFile(h, &io, &fid1, sizeof fid1, FileIdInformation); Here you are mixing two styles for sizeof, one with "()" and one without. The same also applies to a couple of other places below. > + if ((res == STATUS_NOT_IMPLEMENTED) || (res == STATUS_INVALID_INFO_CLASS)) The extra "()" is not really necessary. > + { > + CloseHandle(h); > + DeleteFileA(buffer); > + win_skip("FileIdInformation not supported\n"); > + return; > + } > + > + ok(res == STATUS_SUCCESS, "can't get fid1, res %x\n", res); > + > + CloseHandle(h); > + > + /* Open the file again */ > + h = CreateFileA(buffer, GENERIC_WRITE, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0); > + ok(h != INVALID_HANDLE_VALUE, "CreateFile error %d\n", GetLastError()); > + > + /* Query again the temp file unique id */ > + memset(&fid2, 0, sizeof(fid2)); > + res = pNtQueryInformationFile(h, &io, &fid2, sizeof fid2, FileIdInformation); > + ok(res == STATUS_SUCCESS, "can't get fid2, res %x\n", res); > + > + /* Verify we got the same unique id for the file */ > + ok(memcmp(&fid1, &fid2, sizeof fid1) == 0, "file id is not unique\n"); > + > + CloseHandle(h); > + > + h = create_temp_file(0); > + ok(h != NULL, "error creating new file %d\n", GetLastError()); > + > + memset(&fid2, 0, sizeof(fid2)); > + res = pNtQueryInformationFile(h, &io, &fid2, sizeof fid2, FileIdInformation); > + ok(res == STATUS_SUCCESS, "can't get new fid2, res %x\n", res); > + > + /* Verify we got the different unique id for the new file */ > + ok(memcmp(&fid1, &fid2, sizeof fid1) != 0, "file id is not unique\n"); > + > + CloseHandle(h); > + DeleteFileA(buffer); > +} > + > static void test_file_all_information(void) > { > IO_STATUS_BLOCK io; > @@ -4262,4 +4321,5 @@ START_TEST(file) > test_file_disposition_information(); > test_query_volume_information_file(); > test_query_attribute_information_file(); > + test_file_id_information(); > } > diff --git a/include/winternl.h b/include/winternl.h > index 891b6a7..2f2ea86 100644 > --- a/include/winternl.h > +++ b/include/winternl.h > @@ -571,6 +571,15 @@ typedef struct _FILE_INTERNAL_INFORMATION { > LARGE_INTEGER IndexNumber; > } FILE_INTERNAL_INFORMATION, *PFILE_INTERNAL_INFORMATION; > > +typedef struct _FILE_ID_128 { > + UCHAR Identifier[16]; > +} FILE_ID_128, *PFILE_ID_128; > + > +typedef struct _FILE_ID_INFORMATION { > + ULONGLONG VolumeSerialNumber; > + FILE_ID_128 FileId; > +} FILE_ID_INFORMATION, *PFILE_ID_INFORMATION; > + > typedef struct _FILE_EA_INFORMATION { > ULONG EaSize; > } FILE_EA_INFORMATION, *PFILE_EA_INFORMATION; > -- 2.9.3 >

1 0

RE: [PATCH 8/9] server: Added server side mamed pipe read and write implementation and use it for message mode pipes.
by wylda＠volny.cz 10 Feb '17

10 Feb '17

Hi, mamed vs. named? W.

1 0

Re: ntdll: Fixed LdrUnloadDll may recursion unload same dll
by Sebastian Lackner 10 Feb '17

10 Feb '17

On 09.02.2017 10:39, 谢威 wrote: > From 3b5efb522f3ef46b009e6a159a605e087e8841a9 Mon Sep 17 00:00:00 2001 > From: Wei xie <xiewei(a)linuxdeepin.com> > Date: Thu, 19 Jan 2017 14:55:44 +0800 > Subject: [PATCH] ntdll: Fixed LdrUnloadDll may recursion unload same dll > > Signed-off-by: Wei xie <xiewei(a)linuxdeepin.com> > --- > dlls/ntdll/loader.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index 74feb97..8762917 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -64,7 +64,7 @@ WINE_DECLARE_DEBUG_CHANNEL(pid); > typedef DWORD (CALLBACK *DLLENTRYPROC)(HMODULE,DWORD,LPVOID); > > static BOOL process_detaching = FALSE; /* set on process detach to avoid deadlocks with thread detach */ > -static int free_lib_count; /* recursion depth of LdrUnloadDll calls */ > +static int free_lib_count = 0; /* recursion depth of LdrUnloadDll calls */ This isn't really necessary, all static variables are initialized to zero. > > static const char * const reason_names[] = > { > @@ -2859,7 +2859,7 @@ static void MODULE_FlushModrefs(void) > * > * The loader_section must be locked while calling this function. > */ > -static void MODULE_DecRefCount( WINE_MODREF *wm ) > +static void MODULE_DecRefCount( WINE_MODREF *wm , BOOL bDeps) > { > int i; > > @@ -2872,13 +2872,13 @@ static void MODULE_DecRefCount( WINE_MODREF *wm ) > --wm->ldr.LoadCount; > TRACE("(%s) ldr.LoadCount: %d\n", debugstr_w(wm->ldr.BaseDllName.Buffer), wm->ldr.LoadCount ); > > - if ( wm->ldr.LoadCount == 0 ) > + if ( wm->ldr.LoadCount == 0 && bDeps) > { > wm->ldr.Flags |= LDR_UNLOAD_IN_PROGRESS; > > for ( i = 0; i < wm->nDeps; i++ ) > if ( wm->deps[i] ) > - MODULE_DecRefCount( wm->deps[i] ); > + MODULE_DecRefCount( wm->deps[i] , TRUE ); > > wm->ldr.Flags &= ~LDR_UNLOAD_IN_PROGRESS; > } > @@ -2893,6 +2893,7 @@ NTSTATUS WINAPI LdrUnloadDll( HMODULE hModule ) > { > WINE_MODREF *wm; > NTSTATUS retv = STATUS_SUCCESS; > + static HMODULE first_recursion_module = 0; > > if (process_detaching) return retv; > > @@ -2900,13 +2901,19 @@ NTSTATUS WINAPI LdrUnloadDll( HMODULE hModule ) > > RtlEnterCriticalSection( &loader_section ); > > + if (0 == free_lib_count) > + first_recursion_module = hModule; > + > free_lib_count++; > if ((wm = get_modref( hModule )) != NULL) > { > TRACE("(%s) - START\n", debugstr_w(wm->ldr.BaseDllName.Buffer)); > > /* Recursively decrement reference counts */ > - MODULE_DecRefCount( wm ); > + if (0 != free_lib_count && first_recursion_module == hModule) > + MODULE_DecRefCount( wm , FALSE ); > + else > + MODULE_DecRefCount( wm , TRUE ); At the location above free_lib_count will always be != 0 - this means that your patch basically disables unloading of dependencies completely. Do you have a small testcase for the problem you are trying to fix? > > /* Call process detach notifications */ > if ( free_lib_count <= 1 ) > @@ -2922,6 +2929,9 @@ NTSTATUS WINAPI LdrUnloadDll( HMODULE hModule ) > > free_lib_count--; > > + if (0 == free_lib_count) > + first_recursion_module = 0; > + > RtlLeaveCriticalSection( &loader_section ); > > return retv; > -- 2.10.2 > > >

1 0

Re: [PATCH 06/16] ntdll: Added support for immediate success returns in server_read_file.
by Alexandre Julliard 10 Feb '17

10 Feb '17

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -588,10 +588,22 @@ static NTSTATUS server_read_file( HANDLE handle, HANDLE event, PIO_APC_ROUTINE a > if (wait_handle) > { > NtWaitForSingleObject( wait_handle, (options & FILE_SYNCHRONOUS_IO_ALERT), NULL ); > - status = io->u.Status; > NtClose( wait_handle ); > + return io->u.Status; > + } > + > + if (status == STATUS_SUCCESS || status == STATUS_BUFFER_OVERFLOW) > + { > + io->u.Status = status; > + io->Information = total; > + if (event) NtSetEvent( event, NULL ); > + if (apc) NtQueueApcThread( GetCurrentThread(), (PNTAPCFUNC)apc, > + (ULONG_PTR)apc_context, (ULONG_PTR)io, 0 ); > } > + else if (status != STATUS_PENDING && event) > + NtResetEvent( event, NULL ); > > + if (cvalue && status != STATUS_PENDING) NTDLL_AddCompletion( handle, cvalue, status, total ); I think it would be cleaner to do these on the server-side, the same way it's done for the asynchronous case. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/2] d2d1: Added support for ID2D1GdiInteropRenderTarget interface
by Henri Verbeet 10 Feb '17

10 Feb '17

On 10 February 2017 at 13:00, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static HRESULT STDMETHODCALLTYPE d2d_gdi_interop_render_target_GetDC(ID2D1GdiInteropRenderTarget *iface, > + D2D1_DC_INITIALIZE_MODE mode, HDC *dc) > +{ > + struct d2d_d3d_render_target *render_target = impl_from_ID2D1GdiInteropRenderTarget(iface); > + IDXGISurface1 *surface; > + HRESULT hr; > + > + TRACE("iface %p, mode %d, dc %p.\n", iface, mode, dc); > + > + if (FAILED(hr = d2d_d3d_render_target_get_surface(render_target, &surface))) > + return hr; > + > + hr = IDXGISurface1_GetDC(surface, mode != D2D1_DC_INITIALIZE_MODE_COPY, dc); > + IDXGISurface1_Release(surface); > + > + return hr; > +} > + > +static HRESULT STDMETHODCALLTYPE d2d_gdi_interop_render_target_ReleaseDC(ID2D1GdiInteropRenderTarget *iface, > + const RECT *update) > +{ > + struct d2d_d3d_render_target *render_target = impl_from_ID2D1GdiInteropRenderTarget(iface); > + IDXGISurface1 *surface; > + HRESULT hr; > + > + TRACE("iface %p, update rect %s.\n", iface, wine_dbgstr_rect(update)); > + > + if (FAILED(hr = d2d_d3d_render_target_get_surface(render_target, &surface))) > + return hr; > + > + hr = IDXGISurface1_ReleaseDC(surface, update); This discards "const". > + IDXGISurface1_Release(surface); > + > + return hr; > +} > + Should this sync/flush in case of e.g. a WIC bitmap render target?

1 0

Re: [PATCH 1/7] gdiplus: Make GpBitmap->bitmapbits access thread safe
by Vincent Povirk 10 Feb '17

10 Feb '17

Copying the lock value in move_bitmap seems wrong to me, as it breaks any locks on the destination. Locking the source doesn't make sense because the caller is supposed to control the only reference to it. I'm not sure it makes sense in free_image_data either, as it leaves the image in an invalid state. Anything calling it should have a lock if this is important. I think it is possible to get unlock != true, when GdipImageRotateFlip calls GdipBitmapLockBits.

2 1

Re: [PATCH 2/7] gdiplus: Initialize bitmap bits for reading in GdipBitmapLockBits when ImageFlagsReadOnly is specified
by Dmitry Timoshkov 10 Feb '17

10 Feb '17

Piotr Caban <piotr(a)codeweavers.com> wrote: > /* Make sure we can convert to the requested format. */ > - if (flags & ImageLockModeRead) > + if ((flags & ImageLockModeRead) || (bitmap->image.flags & ImageFlagsReadOnly)) Is there a test for this behaviour? -- Dmitry.

2 3

Re: Participating in Outreachy
by Austin English 10 Feb '17

10 Feb '17

Thanks all! -- -Austin GPG: 14FB D7EA A041 937B On Feb 9, 2017 6:55 AM, "Aric Stewart" <aric(a)codeweavers.com> wrote: On 2/9/17 2:16 AM, Michael Stefaniuc wrote: > On 02/08/2017 11:07 PM, Jeremy White wrote: >> On 02/08/2017 03:45 PM, Marcus Meissner wrote: >>> On Wed, Feb 08, 2017 at 11:12:08AM -0700, Erich E. Hoover wrote: >>>> On Wed, Feb 8, 2017 at 11:00 AM, André Hentschel <nerv(a)dawncrow.de> wrote: >>>>> ... >>>>> The website says 6500$ or sponsored by another org: >>>>> https://wiki.gnome.org/Outreachy/Admin/InfoForOrgs#Action >>>> >>>> Clearly I should have read further ;) I don't know how our benevolent >>>> funding overlords feel about this, but it seems like a good idea to >>>> me. We did spend a lot of time at WineConf trying to figure out ways >>>> to get more people to participate, maybe this project can help. >>> >>> If the 6500 US$ figure is the minimum amount of money, then I would say no. >> >> Sorry, I was coy earlier; I was waiting on some feedback from Karen. >> >> To be clear, CodeWeavers will sponsor it and provide the $6,500. So if > Thank you very much! > >> we have someone to volunteer to coordinate, and a few people willing to >> mentor, we should be good. (I already have Stefan, so we have game >> related stuff covered). > I can mentor too and/or be a backup for Austin on the coordination part. > Though for the mentoring part the usual disclaimer applies: my Wine > technical knowledge is rather broad but very shallow. > > bye > michael > > I am willing and interested in mentoring. I have not been as active recently but still feel like I could help. Sign me up. -aric

1 0

Re: [PATCH 6/7] gdiplus: Reimplement GdipCreateHBITMAPFromBitmap so it can work on locked bitmaps
by Vincent Povirk 10 Feb '17

10 Feb '17

This should probably also be tested with ImageLockModeUserInputBuf.

1 0

Re: [v6 5/6] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Marvin 09 Feb '17

09 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28472 Your paranoid android. === w7u (32 bit msg) === msg.c:11986: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:11988: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:11988: Test failed: wrong tme.hwndTrack 0023014C, expected 00000000 msg.c:11988: Test failed: wrong tme.dwHoverTime 400, expected 0

1 0

Re: [v6 2/6] user32: Add tests for windows when first shown with SetWindowPos
by Marvin 09 Feb '17

09 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28469 Your paranoid android. === w7u (32 bit msg) === msg.c:11881: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:11883: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:11883: Test failed: wrong tme.hwndTrack 000F018E, expected 00000000 msg.c:11883: Test failed: wrong tme.dwHoverTime 400, expected 0

1 0

Re: [PATCH] user32: Add tests for disabled buttons receiving WM_LBUTTONUP
by Marvin 09 Feb '17

09 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28465 Your paranoid android. === w7u (32 bit msg) === msg.c:11637: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:11639: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:11639: Test failed: wrong tme.hwndTrack 000D018C, expected 00000000 msg.c:11639: Test failed: wrong tme.dwHoverTime 400, expected 0

1 0

Re: [v5 6/6] user32: Only send position-change messages when needed
by Marvin 09 Feb '17

09 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28464 Your paranoid android. === wxppro (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w2003std (32 bit msg) === msg.c:5705: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 1: in msg 0x0046 expecting wParam 0x8170 got 0x8160 msg.c:5705: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 4: the msg 0x0047 was expected, but got msg 0x0022 instead msg.c:5705: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:5705: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:5705: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 11: the msg sequence is not complete: expected 0000 - actual 0005 === wvistau64 (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7u (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7pro64 (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === wvistau64 (64 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7pro64 (64 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint

1 0

Re: [v5 5/6] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Marvin 09 Feb '17

09 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28463 Your paranoid android. === wxppro (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === wvistau64 (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7u (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7pro64 (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === wvistau64 (64 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7pro64 (64 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint

1 0

Re: [v5 4/6] user32: Add WM_NCPAINT tests for windows crossing screen or maximized
by Marvin 09 Feb '17

09 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28462 Your paranoid android. === wxppro (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === wvistau64 (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7u (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint msg.c:7885: Test failed: destroy child on thread exit: 0: the msg 0x0082 was expected, but got msg 0x000f instead msg.c:7885: Test failed: destroy child on thread exit: 1: the msg 0x000f was expected, but got msg 0x0014 instead msg.c:7885: Test failed: destroy child on thread exit: 2: the msg 0x0014 was expected, but got msg 0x0082 instead msg.c:7885: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 000f === w7pro64 (32 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === wvistau64 (64 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7pro64 (64 bit msg) === msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5223: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint

1 0

Re: [v5 3/6] user32: Add tests for windows when first shown if they have children
by Marvin 09 Feb '17

09 Feb '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28461 Your paranoid android. === wxppro (32 bit msg) === msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === wvistau64 (32 bit msg) === msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7u (32 bit msg) === msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7pro64 (32 bit msg) === msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === wvistau64 (64 bit msg) === msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint === w7pro64 (64 bit msg) === msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 2: the msg 0x0085 should have been sent by BeginPaint msg.c:5148: Test failed: SetWindowPos:show_popup_first_show_window_child2: 3: the msg 0x0014 should have been sent by BeginPaint

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel