- wine-devel - winehq.org

Re: [PATCH 2/2] regedit: Only allow value renaming via the Edit or Popup menus
by Nikolay Sivov 29 Dec '16

29 Dec '16

On 28.12.2016 14:47, Hugh McMaster wrote: > @@ -485,7 +494,7 @@ HWND CreateListView(HWND hwndParent, UINT id) > /* Get the dimensions of the parent window's client area, and create the list view control. */ > GetClientRect(hwndParent, &rcClient); > hwndLV = CreateWindowExW(WS_EX_CLIENTEDGE, WC_LISTVIEWW, ListView, > - WS_VISIBLE | WS_CHILD | WS_TABSTOP | LVS_REPORT | LVS_EDITLABELS, > + WS_VISIBLE | WS_CHILD | WS_TABSTOP | LVS_REPORT, > 0, 0, rcClient.right, rcClient.bottom, > hwndParent, ULongToHandle(id), hInst, NULL); > if (!hwndLV) return NULL; Clean way to do that is to block edit operation using LVN_BEGINLABELEDIT notification. So basically you should always return TRUE from it, except for the case when edit is triggered with UI command, in this case you can temporarily enable edit, and block it back when done. But I'm curious, why do you want to do that in a first place, what's wrong with the ability to click-rename items?

2 2

Re: [PATCH] winmm: RegQueryValueExW wants the size in bytes, not the size in characters.
by Andrew Eikum 28 Dec '16

28 Dec '16

Thanks. These look good but we're in code freeze. I'll be happy to sign-off on them after the freeze is over. Andrew On Mon, Dec 26, 2016 at 04:25:22PM +0100, Carlo Bramini wrote: > There is a bug into dlls/winmm/playsound.c > Function RegQueryValueExW accepts the size in bytes as parameter, not the size > in characters. > > See: > https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911(v=vs.85). > aspx > > Sincerely. > > Signed-off-by: Carlo Bramini <carlo_bramini(a)users.sourceforge.net> > > diff --git a/dlls/winmm/playsound.c b/dlls/winmm/playsound.c > index 5d9aed0..6525db5 100644 > --- a/dlls/winmm/playsound.c > +++ b/dlls/winmm/playsound.c > @@ -140,7 +140,7 @@ static HMMIO get_mmioFromProfile(UINT uFlags, LPCWSTR lpszName) > if (err != 0) > goto none; > } > - count = sizeof(str)/sizeof(str[0]); > + count = sizeof(str); > err = RegQueryValueExW(hSnd, NULL, 0, &type, (LPBYTE)str, &count); > RegCloseKey(hSnd); > if (err != 0 || !*str) goto none; >

1 0

wined3d Add Amd rx 480 binary driver
by Jarkko Korpi 26 Dec '16

26 Dec '16

http://source.winehq.org/git/wine.git/commit/c63e3261f37e8116e59c70b9bed20a… Since that commit Rx 480 supposed to be recognized, but I am using closed source drivers, because the audio patches arent in upstream yet. I found a real problem from SC2 appdatabase and I could confirm it myself. When you start SC2 and go to options it limits your GPU graphics options and complains not enough memory. With the attached patch here the options are not limited anymore.

2 1

(no subject)
by Jarkko Korpi 26 Dec '16

26 Dec '16

http://source.winehq.org/git/wine.git/commit/c63e3261f37e8116e59c70b9bed20a… Since that commit Rx 480 supposed to be recognized, but I am using closed source drivers, because the audio patches arent in upstream yet. I found a real problem from SC2 appdatabase and I could confirm it myself. When you start SC2 and go to options it limits your GPU graphics options. With the attached patch here the options are not limited anymore.

1 0

RE: msvcirt: Avoid "array subscript above array bounds" warnings in test_ostrstream and test_strstreambuf.
by Filip Frackiewicz 24 Dec '16

24 Dec '16

Hi Gerald, In wine-1.9.22-129-g906e770 I see the array subscript warnings in the following location: ../../../../wine/dlls/msvcirt/tests/msvcirt.c: In function ‘test_strstream’: ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6861:34: warning: array subscript is above array bounds [-Warray-bounds] ok(pssb->base.ebuf == buffer + 0x7fffffff || pssb->base.ebuf == (char*) -1, ~~~~~~~^~~~~~~~~~~~ ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6868:35: warning: array subscript is above array bounds [-Warray-bounds] ok(pssb->base.epptr == buffer + 0x7fffffff || pssb->base.epptr == (char*) -1, Thought I'd let you know as I just encountered this while compiling the 64-bit version of Wine. Cheers, Filip

2 1

Re: [PATCH] mscoree: Free argument buffer on error (Coverity)
by Vincent Povirk 22 Dec '16

22 Dec '16

I'm out visiting family and don't have access to a machine that can build or run Wine. I'll be able to do reviews again next year. FWIW, by purely visual inspection this looks fine to me.

1 0

Re: [PATCH] msvcrt: Pass WCHAR strings to MessageBoxIndirectW.
by Nikolay Sivov 22 Dec '16

22 Dec '16

On Thu, 22 Dec 2016 14:38:19 -0700 Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Cc: Piotr Caban <piotr(a)codeweavers.com> > Cc: Nikolay Sivov <bunglehead(a)gmail.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=42057 > > I figured this would be a good time to get rid of the misleading > Hungarian notation and move the string into the single function that > uses it. > > v2: Switch to WCHAR type. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/msvcrt/exit.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c > index 9ba0891806..ad5a78d54d 100644 > --- a/dlls/msvcrt/exit.c > +++ b/dlls/msvcrt/exit.c > @@ -41,8 +41,6 @@ typedef struct MSVCRT__onexit_table_t > MSVCRT__onexit_t *_end; > } MSVCRT__onexit_table_t; > > -static const char szMsgBoxTitle[] = "Wine C++ Runtime Library"; > - > extern int MSVCRT_app_type; > extern MSVCRT_wchar_t *MSVCRT__wpgmptr; > > @@ -112,10 +110,12 @@ void CDECL MSVCRT__exit(int exitcode) > /* Print out an error message with an option to debug */ > static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *message) > { > - static const MSVCRT_wchar_t message_format[] = {'%','s','\n','\n','P','r','o','g','r','a','m',':',' ','%','s','\n', > + static const WCHAR message_format[] = {'%','s','\n','\n','P','r','o','g','r','a','m',':',' ','%','s','\n', > '%','s','\n','\n','P','r','e','s','s',' ','O','K',' ','t','o',' ','e','x','i','t',' ','t','h','e',' ', > 'p','r','o','g','r','a','m',',',' ','o','r',' ','C','a','n','c','e','l',' ','t','o',' ','s','t','a','r','t',' ', > 't','h','e',' ','W','i','n','e',' ','d','e','b','b','u','g','e','r','.','\n',0}; > + static const WCHAR title[] = > + {'W','i','n','e',' ','C','+','+',' ','R','u','n','t','i','m','e',' ','L','i','b','r','a','r','y',0}; 'message_format' is used with MSVCRT__snwprintf, so it should be wchar_t strictly speaking. > > MSGBOXPARAMSW msgbox; > MSVCRT_wchar_t text[2048]; Another existing bug is wrong buffer length here: --- MSVCRT__snwprintf(text,sizeof(text),message_format, lead, MSVCRT__wpgmptr, message); --- Could be a separate patch I guess. > @@ -126,8 +126,8 @@ static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *mess > msgbox.cbSize = sizeof(msgbox); > msgbox.hwndOwner = GetActiveWindow(); > msgbox.hInstance = 0; > - msgbox.lpszText = (LPCWSTR)text; > - msgbox.lpszCaption = (LPCWSTR)szMsgBoxTitle; > + msgbox.lpszText = text; > + msgbox.lpszCaption = title; What I meant is that you can remove 'text' cast without changing its type. > msgbox.dwStyle = MB_OKCANCEL|MB_ICONERROR; > msgbox.lpszIcon = NULL; > msgbox.dwContextHelpId = 0;

1 0

Re: [PATCH] msvcrt: Pass wide char caption string to MessageBoxIndirectW.
by Nikolay Sivov 22 Dec '16

22 Dec '16

On Thu, 22 Dec 2016 14:20:26 -0700 Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Cc: Piotr Caban <piotr(a)codeweavers.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=42057 > > I figured this would be a good time to get rid of the misleading > Hungarian notation and move the string into the single function that > uses it. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/msvcrt/exit.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c > index 9ba0891806..3bfcd15967 100644 > --- a/dlls/msvcrt/exit.c > +++ b/dlls/msvcrt/exit.c > @@ -41,8 +41,6 @@ typedef struct MSVCRT__onexit_table_t > MSVCRT__onexit_t *_end; > } MSVCRT__onexit_table_t; > > -static const char szMsgBoxTitle[] = "Wine C++ Runtime Library"; > - > extern int MSVCRT_app_type; > extern MSVCRT_wchar_t *MSVCRT__wpgmptr; > > @@ -116,6 +114,8 @@ static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *mess > '%','s','\n','\n','P','r','e','s','s',' ','O','K',' ','t','o',' ','e','x','i','t',' ','t','h','e',' ', > 'p','r','o','g','r','a','m',',',' ','o','r',' ','C','a','n','c','e','l',' ','t','o',' ','s','t','a','r','t',' ', > 't','h','e',' ','W','i','n','e',' ','d','e','b','b','u','g','e','r','.','\n',0}; > + static const MSVCRT_wchar_t title[] = > + {'W','i','n','e',' ','C','+','+',' ','R','u','n','t','i','m','e',' ','L','i','b','r','a','r','y',0}; I think this should be WCHAR, because it will be used with regular API. > > MSGBOXPARAMSW msgbox; > MSVCRT_wchar_t text[2048]; > @@ -127,7 +127,7 @@ static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *mess > msgbox.hwndOwner = GetActiveWindow(); > msgbox.hInstance = 0; > msgbox.lpszText = (LPCWSTR)text; > - msgbox.lpszCaption = (LPCWSTR)szMsgBoxTitle; > + msgbox.lpszCaption = (LPCWSTR)title; Looks like these two casts could be removed. > msgbox.dwStyle = MB_OKCANCEL|MB_ICONERROR; > msgbox.lpszIcon = NULL; > msgbox.dwContextHelpId = 0;

1 0

Re: [PATCH 2/2] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Marvin 22 Dec '16

22 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27468 Your paranoid android. === w7u (32 bit msg) === msg.c:9126: Test failed: did not get zero count as expected (1). msg.c:9129: Test failed: did not get one count as expected (2). msg.c:9133: Test failed: killing replaced timer did not work (2). msg.c:9146: Test failed: did not get expected count for minimum timeout (12 != ~100). === w7pro64 (64 bit msg) === msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 5: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 6: the msg 0x0003 was expected, but got msg 0x0009 instead msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 7: the msg 0x0005 was expected, but got msg 0x0047 instead msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 13: the msg sequence is not complete: expected 0000 - actual 0003

2 1

Re: [PATCH 1/2] user32: Fix WM_NCPAINT for windows crossing screen boarders and add tests
by Marvin 22 Dec '16

22 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27467 Your paranoid android. === w7pro64 (64 bit msg) === msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 4: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 7: the msg sequence is not complete: expected 0000 - actual 0005

2 1

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind) (try 2)
by Austin English 21 Dec '16

21 Dec '16

On Wed, Dec 14, 2016 at 4:45 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Assigned". > > This means that the patch has been assigned to a reviewer. If the > reviewer signs off on the patch, it will be committed, otherwise > you'll receive advice on how to improve it. If you don't hear anything > after a couple of weeks, please resend the patch. This shows in the tracker as assigned to Hans, but Hans signed off a week ago. -- -Austin GPG: 14FB D7EA A041 937B

3 3

Can't build crosstests
by Fabian Maurer 20 Dec '16

20 Dec '16

Hello, I'm trying to build the tests for windows, but I can't get it working anymore. I have mingw installed and it does work for cross-compiling with code-blocks, but wine says it's broken. The configure script fails with >checking for i686-w64-mingw32-gcc... i686-w64-mingw32-gcc >checking whether i686-w64-mingw32-gcc works... no An idea how to find out what's going wrong?

3 4

Re: user32/tests: Disable automatic shell restart during SetShellWindow tests.
by Marvin 20 Dec '16

20 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27438 Your paranoid android. === w864 (32 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100 === w864 (64 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100

2 1

Re: [PATCH] gdiplus/tests: Test for initial properties of adjustable arrow caps
by Vincent Povirk 19 Dec '16

19 Dec '16

On Fri, Dec 16, 2016 at 6:21 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + stat = GdipGetCustomLineCapBaseInset((GpCustomLineCap*)cap, &inset); > + ok(stat == Ok, "Unexpected return code, %d\n", stat); > + It isn't enough to reject the patch, but I'm curious why you don't test this value.

2 1

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.
by Nikolay Sivov 19 Dec '16

19 Dec '16

On 19.12.2016 13:38, Hans Leidekker wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/shell32/tests/shlfileop.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > index 0e502fc..776da98 100644 > --- a/dlls/shell32/tests/shlfileop.c > +++ b/dlls/shell32/tests/shlfileop.c > @@ -819,7 +819,7 @@ static void test_rename(void) > retval == DE_DIFFDIR || /* Vista */ > broken(retval == DE_OPCANCELLED) || /* Win9x */ > broken(retval == 65652), /* NT4 */ > - "Expected ERROR_CANCELLED or DE_DIFFDIR\n"); > + "Expected ERROR_CANCELLED or DE_DIFFDIR, got %u\n", retval); > ok(file_exists("test1.txt"), "Expected test1.txt to exist\n"); > > /* pFrom is empty */ > @@ -2516,6 +2516,11 @@ static void test_unicode(void) > skip("Unicode tests skipped on non-unicode system\n"); > return; > } > + if (GetLastError()==ERROR_ACCESS_DENIED) > + { > + skip("test needs admin rights\n"); > + return; > + } > CloseHandle(file); > > /* Try to delete a file with unicode filename */ > @@ -2574,6 +2579,7 @@ static void test_unicode(void) > ok(GetLastError() == ERROR_SUCCESS || > broken(GetLastError() == ERROR_INVALID_HANDLE), /* WinXp, win2k3 */ > "Expected ERROR_SUCCESS, got %d\n", GetLastError()); > + DeleteFileW(UNICODE_PATH_TO); > > /* Check last error after a failed file operation. */ > DeleteFileW(UNICODE_PATH); Will it work if user temp directory was used instead of current directory or C: root?

2 1

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.
by Marvin 19 Dec '16

19 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27406 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128 === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128

2 1

Re: [PATCH] webservices: free the potentially allocated pointer (Coverity)
by Hans Leidekker 19 Dec '16

19 Dec '16

On Sat, 2016-12-17 at 12:48 +0100, Marcus Meissner wrote: > 1374356 Resource leak > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/webservices/reader.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c > index d67c47a701..219683b2af 100644 > --- a/dlls/webservices/reader.c > +++ b/dlls/webservices/reader.c > @@ -4701,15 +4701,33 @@ static ULONG get_field_size( const WS_FIELD_DESCRIPTION *desc ) > > static HRESULT read_param( struct reader *reader, const WS_FIELD_DESCRIPTION *desc, WS_HEAP *heap, void *ret ) > { > - if (!ret && !(ret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > - return read_type_struct_field( reader, desc, heap, ret, 0 ); > + HRESULT hr; > + VOID *xret = NULL; > + > + if (!ret) > + { > + if (!(xret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > + ret = xret; > + } > + hr = read_type_struct_field( reader, desc, heap, ret, 0 ); > + ws_free( heap, xret); > + return hr; > } It's not a leak. The memory is allocated on the heap passed to this function and it will be released when the heap is destroyed. I guess Coverity doesn't see that.

2 1

Re: [PATCH 2/4] ddraw: Subtract framebuffer size from reported available video memory.
by Henri Verbeet 19 Dec '16

19 Dec '16

On 18 December 2016 at 00:22, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + INT64 total_vidmem, free_vidmem; ... > + free_vidmem = wined3d_device_get_available_texture_mem(ddraw->wined3d_device); > + *free = max(0, free_vidmem - framebuffer_size); This works, but it seems a little silly to use INT64 to avoid writing something along the lines of "*free = framebuffer_size > free_vidmem ? 0 : free_vidmem - framebuffer_size;".

1 0

Wined3d textureless rendering
by Bruno Jesus 18 Dec '16

18 Dec '16

Hello everyone. Following my email last year email asking if rendering in wireframe could speedup a game (answer was no in many different ways) I have a new idea after playing Totaly Accurate Battle Simulator with its red and blue army. What if I skip applying every texture to every object? Probably everything would be black so I would need to use different incremental solid color to distinguish stuff in the screen. Would that save memory and also make games faster? Remembering that my 3D knowledge didn't change much so, basically zero + wireframe knowledge from previous email ;-) Best wishes, Bruno

2 2

[OT] Machine learning for automatical GUI testing
by Qian Hong 18 Dec '16

18 Dec '16

Hi folks, I was falling into machine learning recently and I think I'd like to share some ideas. Here is one of them: quote: ``` Universe allows an AI agent to use a computer like a human does: by looking at screen pixels and operating a virtual keyboard and mouse. We must train AI systems on the full range of tasks we expect them to solve, and Universe lets us train a single agent on any task a human can complete with a computer. ``` Reference: https://openai.com/blog/universe/ Reinforcement Learning is the powerful algorithm used by AlphaGo which won the Go chess game this year against world class master. OpenAI Universe is a good environment to train Reinforcement Learning program's skill on software UI testing. We might want to follow the latest progress from OpenAI Universe community to see if there is anything useful for Wine development / testing. I know people tried GUI auto testing years ago but was not very happy with that, however this time with the revolution of machine learning, interesting thing could happen, finally. Any one want to discover more potential on using machine learning to improve Wine? This might not be practical in one month, but could be very powerful in long term, like 3 years or more. There could be multiple possible ways, not only GUI testing, but none is easy today. Other interesting reading: https://openai.com/blog/universe/ https://gym.openai.com/ Cheers! -- Regards, Qian Hong

1 0

Re: [Tools] testbot: Skip ntdll:exception on the Windows 10 VM.
by Francois Gouget 16 Dec '16

16 Dec '16

On Fri, 16 Dec 2016, Francois Gouget wrote: [...] > - $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\"\r\n" . > + my $Ignore = ($VM->Name eq "w1064" ? "-n ntdll:exception" : ""); > + $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\" $Ignore\r\n" . > "$FileName -q -s $RptFileName\r\n"; This should not be needed after all. The trick is not to upgrade QEMU, Windows 10, the host kernel, change the emulated CPU or switch to emulating USB 3. The trick is: echo 1 >/sys/module/kvm/parameters/ignore_msrs Once you've noticed the following lines in the host's kernel log and done a Google search: Dec 16 13:43:48 vm3 kernel: [ 191.624802] kvm [2064]: vcpu0, guest rIP: 0xfffff803cb3c0bf3 kvm_set_msr_common: MSR_IA32_DEBUGCTLMSR 0x1, nop Dec 16 13:43:48 vm3 kernel: [ 191.624835] kvm [2064]: vcpu0, guest rIP: 0xfffff803cb3c0c5c unhandled rdmsr: 0x1c9 https://www.reddit.com/r/VFIO/comments/42dj7n/some_games_crash_to_biosboot_… Now as to why another Windows 10 VM seemed to get magically fixed by the AEMU upgrade (from 2.1 to 2.7) and did not require this hack is another mystery. But one I can live with. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH 3/7] d3d11/tests: Add workaround for bug in AMD Windows driver.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 59 +++++++++++++++++++++++++++--------------------- > 1 file changed, 33 insertions(+), 26 deletions(-) > Unfortunately this makes it fail on Wine for me, probably because the initial texture data is undefined.

2 2

Re: [PATCH 7/7] wined3d: Make total video memory limit optional.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > It's enough to enable this workaround for ddraw. > So would it then also be enough to just fixup things in ddraw7_GetAvailableVidMem()? In fact, the documentation suggests that's actually the proper place, and that this shouldn't be specific to the Windows version. You could probably use wined3d_get_adapter_display_mode() together with wined3d_calculate_format_pitch() to calculate the primary surface size.

2 2

Re: [PATCH v2 14/18] d3d11/tests: Add test for depth/stencil shader resource views.
by Henri Verbeet 15 Dec '16

15 Dec '16

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The test was slightly changed. If it still fails the failures should be more > clear now after "d3d11/tests: Print expected result in case of failures in > check_texture_sub_resource_*() functions." > Still fails: d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. So I investigated this a little, and the issue seems to be that as soon as D3D11_BIND_SHADER_RESOURCE is in the bind flags, reads from the depth texture return stale values. E.g., the failure at line 6563 is from the 0.6f written by the clear at line 6544. This can also be reproduced by calling check_texture_float() directly on the depth texture, and is not specific to typeless formats. I'd guess at a driver bug related to e.g. compressed depth or fast clear handling. Regardless, I'd expect that using separate resources for the clear and the shader reads would fix the failures, although it would perhaps weaken the test a little.

3 4

Re: [PATCH] d3dx9: Fix a typo in TRACE() message.
by Matteo Bruni 15 Dec '16

15 Dec '16

2016-12-12 11:21 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > @@ -750,7 +750,7 @@ D3DXMATRIX* WINAPI D3DXMatrixTransformation(D3DXMATRIX *pout, const D3DXVECTOR3 > D3DXQUATERNION prc; > D3DXVECTOR3 psc, pt; > > - TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcentr %p, protation %p, ptranslation %p\n", > + TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcenter %p, protation %p, ptranslation %p\n", > pout, pscalingcenter, pscalingrotation, pscaling, protationcenter, protation, ptranslation); > > if ( !pscalingcenter ) It would be nice to clean up the function while at it (add the missing period at the end of the trace, drop the useless 'p' prefix from all the parameters and most of the local variables, fix and split the function prototype over multiple lines, remove the spaces around the if condition, ...) IMO better if you send a v2 with the cleanups after Wine 2.0.

1 0

Re: [PATCH v2 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban 15 Dec '16

15 Dec '16

Hi, On 12/14/16 18:18, Lauri Kenttä wrote: > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i] + 4, zeros[i], zeros[i] + 5, 0}; > + res = p_wcstoi64(tmp, NULL, 0); > + todo_wine ok(res == 405, "with zero = U+%04X: got %d, expected 405\n", zeros[i], (int)res); > + tmp[1] = zeros[i] + 10; > + res = p_wcstoi64(tmp, NULL, 0); Please change the line to: res = p_wcstoi64(tmp, NULL, 16); Currently you don't test if zeros[i]+10 is recognized as valid digit. Except of that the patches are looking good for me. Are these patches fixing any bugs? Is any application working thanks to them (I'm asking because of the code freeze)? Thank you, Piotr

2 2

Re: [PATCH] appwiz.cpl: Remove list entries left over from an earlier uninstall
by Dmitry Timoshkov 15 Dec '16

15 Dec '16

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > -IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 > +IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 shlwapi ... > +#include <shlwapi.h> ... > - info->regroot = root; > + info->regroot = SHRegDuplicateHKey(root); Adding a whole new import just because of a simple RegOpenKeyEx() wrapper is not really justified. -- Dmitry.

2 1

Re: [v3] winex11: Use XIAllDevices to select for XI_RawMotion
by Carlos Garnacho 15 Dec '16

15 Dec '16

Hi all, Got this message from Marvin about "formatting", but I'm not sure what could have triggered this. Getting picky I see the parens at the update_relative_valuators function aren't alright given surrounding code style, but I see nothing specifically against https://wiki.winehq.org/Submitting_Patches#Code_guidelines or https://source.winehq.org/patches/#legend Is there anything actually wrong? I'll be happy to send an updated patch. Cheers, Carlos On Mon, Dec 12, 2016 at 11:15 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Formatting". > > This means that there are some formatting issues with your > patch. Either the author's full name, email address, or Signed-off-by > headers are missing, indentation is messed up (usually from editing > with a non-standard tab size), or there are gratuitous formatting > changes to the code. You need to resend a fixed patch. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email.

2 2

wine-staging status
by Michael Cronenworth 14 Dec '16

14 Dec '16

Hi, Is Wine Staging on hiatus? MIA? DIA? It has been one month since the last release with no signs of any new commits. I sent an e-mail to Sebastian but no response yet. Thanks, Michael

3 2

Re: [PATCH 3/3] msvcrt: Make wcstoi64 support various Unicode digits.
by Henri Verbeet 14 Dec '16

14 Dec '16

On 13 December 2016 at 19:48, Lauri Kenttä <lauri.kentta(a)gmail.com> wrote: > @@ -2027,6 +2027,19 @@ static int wctoint(WCHAR c, int base) > v = c - 'A' + 10; > else if ('a' <= c && c <= 'z') > v = c - 'a' + 10; > + else { > + /* Unicode points that contain digits 0-9; keep this sorted! */ > + static const WCHAR zeros[] = { > + 0x660, 0x6f0, 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, > + 0xd66, 0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0xff10 > + }; > + int i; > + for (i = 0; i < sizeof(zeros)/sizeof(zeros[0]) && c >= zeros[i]; ++i) { > + if (zeros[i] <= c && c < zeros[i] + base) { Using "base" here seems questionable. That would imply that e.g. with base 16, "\x6f2\x6fa"/"۲ۺ" would return "42". Is that really the case? For what it's worth, note also that Wine has wine_fold_string(), which should be consistent with FoldString().

4 8

Re: [PATCH 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban 14 Dec '16

14 Dec '16

Hi Lauri, On 12/13/16 19:48, Lauri Kenttä wrote: > + static const WCHAR zeros[] = { > + 0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0x660, 0x6f0, 0xff10, > + 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, 0xd66 > + }; Please also add a test for Tibetan digits range: https://unicode-table.com/en/0F20/ > + /* Test various unicode digits */ > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i]+4, zeros[i], zeros[i]+5, 0}; > + res = p_wcstoi64(tmp, NULL, 0); > + todo_wine ok(res == 405, "with zero = %#x: got %d, expected 405\n", zeros[i], (int)res); Could you please also add following test: tmp[1] = zeros[i]+10; res = p_wcstoi64(tmp, NULL, 16); ok(res == 4, ...); Thank you, Piotr

2 1

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind) (try 2)
by Henri Verbeet 14 Dec '16

14 Dec '16

On 13 December 2016 at 20:17, Austin English <austinenglish(a)gmail.com> wrote: > + /* buf was originally [24], increased to 48 to prevent a stack smashing error when running tests under Valgrind */ > + unsigned char buf[48]; /* "-1.1111111111111111E-308". */ The more interesting comment would perhaps be what actually happens and why this helps. One thing I do notice is that while 24 chars would be enough to hold "-1.1111111111111111E-308", that doesn't leave any room for the \0 terminator, while the other cases above this one do seem to include space for that.

2 5

Re: [PATCH] shlwapi: Changed UrlEscapeW error paths and add tests
by Jacek Caban 14 Dec '16

14 Dec '16

Hi Fabian, On 13.12.2016 22:53, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=41956 > > Also changed wininet:HTTP_HandleRedirect to not break it. > On windows output buffer must not be NULL, > and size must not be NULL or zero, > or it won't return the number of needed characters. Please send wininet changes as separated patch. They don't depend on shlwapi, so may be applied separately, before shlwapi patch. Other than that and one small comment bellow, the patch looks good. Thanks. > + /* Check error paths */ > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); You set and test size although the actual call doesn't use it. Please remove lines with size. Same in a few more cases. > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_POINTER, "got %x, expected %x\n", ret, E_POINTER); > + ok(size == 6, "got %d, expected %d\n", size, 6); Thanks, Jacek

3 2

Wine Swag and Promotion
by Aric Stewart 13 Dec '16

13 Dec '16

Hello all, So at this last wineconf we had a great discussion around promotion of the wine project and how we get more interaction with the broader open source developer and user community. As part of that we really wanted people to step up and volunteer to attend conferences, Linux user groups, shows and wherever they can to talk about wine. Jeremy reminded everyone that there is money in the wine project budget to compensate people for expenses around this. The job I volunteered to take on was that of swag master. It was agreed that we should have some things to give away at these events. Many projects have stickers and other goodies that they distribute, sell or otherwise get out into the community to increase visible footprint. The expense of these will come out of the wine project funds and we need to discuss the best way to manage it. Right now, I still have a number of leftover badge flags from FOSDEM, probably about 100 of them. If you are attending a conference with badges and you want some to distribute contact me and I can get that sent out. My first thought was that we should have a sticker stockpile. Stickers seem like a good first step. Here I have brought in Jana from CodeWeavers Marketing to help. She has agreed to design some stickers for us when she has free time (probably prototypes in early Jan) and talk to her production contacts on quotes for production of the stickers. We are thinking 2" x 4" oval or die-cut stickers. The price per sticker drops so dramatically with volume that doing smaller on demand printings seems counter productive. This would mean that there would be a mailing expense to ship the stickers from St. Paul, MN to each event. But with enough time, less expensive shipping can be selected and it just seems like the shipping expense would be out-weighted by production savings. The question I am posing out to you, the broader community, is if this sounds like a good first step plan? Also, what else do you think we should have a swag? Should I reorder badge flags when we run out? I know t-shirts are always popular but they tend to be enough more expensive that they are not really give-away items. Thoughts? I will send more info when Jana produces the sticker prototypes. Finally, I do have the flags, so right now, if you are off to an event and want to start with that as swag feel free to contact me! Thanks! -aric

2 1

Re: winhttp: Handle EINTR from connect and poll.
by Bruno Jesus 13 Dec '16

13 Dec '16

On Tue, Dec 13, 2016 at 7:33 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/winhttp/net.c | 47 +++++++++++++++++++++++++++++++++-------------- > 1 file changed, 33 insertions(+), 14 deletions(-) Hi, Isn't it better to make winhttp use ws2_32 just like wininet change [1]? Then we would have a single point for all networking code and EINTR is already covered in ws2_32. [1] http://source.winehq.org/git/wine.git/commitdiff/5436fef80722fe7896aed5e659… Best Regards, Bruno

2 3

Re: [PATCH 3/3] wined3d: Filter messages for fullscreen mode changes.
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27335 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 2/3] d3d9/tests: Add test showing WM_SIZE is not sent during fullscreen mode change.
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27334 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind)
by Hans Leidekker 13 Dec '16

13 Dec '16

On Mon, 2016-12-12 at 16:20 -0600, Austin English wrote: > This avoids a stack smashing error when running > dlls/webservices/tests/writer.c under Valgrind. > > diff --git a/dlls/webservices/writer.c b/dlls/webservices/writer.c > index c1f1b0c..07b32d8 100644 > --- a/dlls/webservices/writer.c > +++ b/dlls/webservices/writer.c > @@ -1369,7 +1369,7 @@ static HRESULT text_to_utf8text( const WS_XML_TEXT *text, WS_XML_UTF8_TEXT **ret > case WS_XML_TEXT_TYPE_DOUBLE: > { > const WS_XML_DOUBLE_TEXT *double_text = (const WS_XML_DOUBLE_TEXT *)text; > - unsigned char buf[24]; /* "-1.1111111111111111E-308" */ > + unsigned char buf[48]; /* "-1.1111111111111111E-308" */ > unsigned short fpword; > ULONG len; Please add a comment with motivation for the increased buffer size.

1 0

Re: [PATCH] advapi32: Add tests for StartTrace().
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27322 Your paranoid android. === wxppro (32 bit eventlog) === eventlog.c:1170: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1216: Test failed: Expected success, got 161 eventlog.c:1220: Test failed: Expected ERROR_ALREADY_EXISTS, got 161 === w2003std (32 bit eventlog) === eventlog.c:1170: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1220: Test failed: Expected ERROR_ALREADY_EXISTS, got 32

1 0

Re: [PATCH] mmdevapi: Fix pointer type cast
by Andrew Eikum 12 Dec '16

12 Dec '16

On Sat, Dec 10, 2016 at 08:54:51AM +0300, Nikolay Sivov wrote: > diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c > index 221fb39..b189e8e 100644 > --- a/dlls/mmdevapi/devenum.c > +++ b/dlls/mmdevapi/devenum.c > @@ -613,7 +613,7 @@ static HRESULT WINAPI MMDevice_Activate(IMMDevice *iface, REFIID riid, DWORD cls > if (SUCCEEDED(hr)) > { > IPersistPropertyBag *ppb; > - hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void*)&ppb); > + hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void **)&ppb); > if (SUCCEEDED(hr)) > { > /* ::Load cannot assume the interface stays alive after the function returns, Seems like this (and other similar cleanup patches) should be deferred until after freeze, right? Andrew

3 2

Re: [2/2 v2] winex11: Use XIAllDevices to select for XI_RawMotion
by Henri Verbeet 12 Dec '16

12 Dec '16

On 18 November 2016 at 12:43, Carlos Garnacho <carlosg(a)gnome.org> wrote: > Change the strategy used to get raw motion from slave devices. Instead > of selecting for XI2 events for every slave device individually, do it > for XIAllDevices, and store the current device's relative X/Y valuators > so they can be quickly looked up in the XI_RawMotion events received. > I think this makes sense, and in my (limited) testing this correctly handles the case of attaching a new input device. I do have a few minor comments though: > +static void update_relative_valuators(XIAnyClassInfo **valuators, > + int n_valuators) This should probably just be "static void update_relative_valuators( XIAnyClassInfo **valuators, int n_valuators )" > + free( thread_data->x_rel_valuator ); > + free( thread_data->y_rel_valuator ); ... > + thread_data->x_rel_valuator = malloc( sizeof(XIValuatorClassInfo) ); > + memcpy ( thread_data->x_rel_valuator, class, sizeof(XIValuatorClassInfo) ); We generally avoid malloc()/free() in Wine code and use HeapAlloc()/HeapFree() instead. The main consideration has to do with the way address space is allocated for Win32 applications, effectively making malloc() space a bit more scarce than HeapAlloc() space. We'd probably prefer the sizeof as "sizeof(*thread_data->x_rel_valuator)", or perhaps "sizeof(*class)". I'm not sure how much we should worry about this in practice, but when multiple slaves are attached to the master, and they're not completely idle, update_relative_valuators() can end up getting called quite a bit. It doesn't seem hard to at least do the allocation only once, and only update the data in update_relative_valuators(). Perhaps it's also fine the way it is though. > - XISetMask( mask_bits, XI_ButtonPress ); This was added intentionally (see also https://bugs.winehq.org/show_bug.cgi?id=27522#c18). Perhaps it's no longer needed, but that would need to be a separate patch. > + pointer_info = pXIQueryDevice( data->display, data->xi2_core_pointer, &count ); > + update_relative_valuators( pointer_info->classes, pointer_info->num_classes ); > + pXIFreeDeviceInfo( pointer_info ); ... > + pXISelectEvents( data->display, DefaultRootWindow( data->display ), &mask, 1 ); I'm not too concerned about it, but can this race? I.e. switching slaves between when update_relative_valuators() is called above and when XISelectEvents() takes effect. Applies to querying the devices list as well. > + if (thread_data->xi2_current_slave == 0) We'd typically write that "if (!thread_data->xi2_current_slave)", although I don't think anyone would be overly concerned about it. > + for (i = 0; i <= max ( x_rel->number, y_rel->number ); i++) > + { > +»······if (!XIMaskIsSet( event->valuators.mask, i )) continue; > +»······val = *values++; > +»······if (i == x_rel->number) > +»······{ > + input.u.mi.dx = dx = val; > +»······ if (x_rel->min < x_rel->max) > + input.u.mi.dx = val * (virtual_rect.right - virtual_rect.left) > + / (x_rel->max - x_rel->min); > +»······} > +»······if (i == y_rel->number) > +»······{ > +»······ input.u.mi.dy = dy = val; > +»······ if (y_rel->min < y_rel->max) You're using tabs for indentation here.

2 1

Re: [PATCH] shlwapi: Avoid 'else if' for IStream_fnQueryInterface.
by Nikolay Sivov 12 Dec '16

12 Dec '16

On Mon, 12 Dec 2016 13:24:38 +0200 Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/shlwapi/regstream.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/dlls/shlwapi/regstream.c b/dlls/shlwapi/regstream.c > index 1b0ca4e..d886c0c 100644 > --- a/dlls/shlwapi/regstream.c > +++ b/dlls/shlwapi/regstream.c > @@ -67,9 +67,7 @@ static HRESULT WINAPI IStream_fnQueryInterface(IStream *iface, REFIID riid, LPVO > > *ppvObj = NULL; > > - if(IsEqualIID(riid, &IID_IUnknown)) /*IUnknown*/ > - *ppvObj = This; > - else if(IsEqualIID(riid, &IID_IStream)) /*IStream*/ > + if(IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, &IID_IStream)) > *ppvObj = This; > > if(*ppvObj) Please return interface pointer, to IStream_iface. Also TRACE() for this method needs simplification, but it could be a separate change.

1 0

Re: [PATCH resend 13/18] wined3d: Use depth/stencil formats for typeless resources only when WINED3DUSAGE_DEPTHSTENCIL is set.
by Henri Verbeet 12 Dec '16

12 Dec '16

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > const struct wined3d_format *wined3d_get_format(const struct wined3d_gl_info *gl_info, > - enum wined3d_format_id format_id) > + enum wined3d_format_id format_id, unsigned int resource_usage) > { > + const struct wined3d_format *format; > int idx = get_format_idx(format_id); > + unsigned int i; > > if (idx == -1) > { > - FIXME("Can't find format %s (%#x) in the format lookup table\n", > + FIXME("Can't find format %s (%#x) in the format lookup table.\n", > + debug_d3dformat(format_id), format_id); > + return &gl_info->formats[get_format_idx(WINED3DFMT_UNKNOWN)]; > + } > + > + format = &gl_info->formats[idx]; > + > + if (resource_usage & WINED3DUSAGE_DEPTHSTENCIL && wined3d_format_is_typeless(format)) > + { > + for (i = 0; i < ARRAY_SIZE(typeless_depth_stencil_formats); ++i) > + { > + if (typeless_depth_stencil_formats[i].typeless_id == format_id) > + return &gl_info->formats[WINED3D_FORMAT_COUNT + i]; > + } > + > + FIXME("Cannot find depth/stencil typeless format %s (%#x).\n", > debug_d3dformat(format_id), format_id); > - /* Get the caller a valid pointer */ > - idx = get_format_idx(WINED3DFMT_UNKNOWN); > + return &gl_info->formats[get_format_idx(WINED3DFMT_UNKNOWN)]; > } > > - return &gl_info->formats[idx]; > + return format; > } > I do have some concerns about whether returning different wined3d_format structures for different usages/bind flags is better than having different GL internal formats for different usages/bind flags within the same wined3d_format structure, but lets give it a try.

1 0

Re: [v2] preloader: Allow a debugger to find ld.so's rendezvous-struct
by Alexandre Julliard 12 Dec '16

12 Dec '16

Keno Fischer <keno(a)juliacomputing.com> writes: > @@ -123,6 +123,18 @@ static struct wine_preload_info preload_info[] = > { 0, 0 } /* end of list */ > }; > > +/* A fake .dynamic section through which we can inform the debugger of the > + address of the chain-loaded dynamic linker's rendezvous struct */ > +__asm__( > +".section .dynamic,\"aw\"\n" > +".global _DYNAMIC\n" > +"_DYNAMIC: .quad 21\n" // DT_DEBUG > +".quad 0\n" > +".quad 0\n" > +".quad 0\n" > +".previous\n" > +); This is causing a warning here: gcc -m32 -c -o preloader.o preloader.c -I. -I../include -D__WINESRC__ -fno-builtin -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Werror -g -O2 -fno-diagnostics-show-caret {standard input}: Assembler messages: {standard input}:5: Warning: setting incorrect section attributes for .dynamic -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [PATCH] po: Update Simplified Chinese translation.
by Jactry Zeng 11 Dec '16

11 Dec '16

This looks good to me. Thank you, Mingcong! 2016-12-11 0:12 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 588 ++++++++++++++++++++++++++++++ > +++--------------------------- > 1 file changed, 324 insertions(+), 264 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Source.winehq.org down?
by Filip Frackiewicz 10 Dec '16

10 Dec '16

Sorry for the bother but is source.winehq.org down for anyone? Filip

3 2

Re: [PATCH] ws2_32: Add support to disable networking with envvar WINENONET=1
by Stefan Dösinger 10 Dec '16

10 Dec '16

Am 2016-12-07 um 06:27 schrieb Bruno Jesus: > @@ -2433,6 +2438,12 @@ static int WS2_send( int fd, struct ws2_async *wsa, int flags ) > union generic_unix_sockaddr unix_addr; > int n, ret; > > + if (network_disabled) > + { > + errno = EHOSTUNREACH; > + return -1; > + } > + Shouldn't it be possible to achieve a similar effect with a LD_PRELOAD library?

2 2

WineTest reference Linux machines
by Francois Gouget 09 Dec '16

09 Dec '16

CodeWeavers has two machines that I have been running WineTest on, in Linux, Windows 8.1 and Windows 10, in 32 and 64 bit. They are identical except for the graphics cards: AMD HD6800 for cw1 and Nvidia GTX560 for cw2. During WineConf we decided that these should be able to run WineTest on Linux without any errors and thus become reference WineTest machines. We are not quite there yet so here is the current status starting with the 32 bit tests. * crypt32:chain Some of the certificates used by this test are present on Windows but missing on Linux, thus causing the error. Hans is looking into it and either the test will be modified to use other certificates present on both platforms, or the certificates will be added to these boxes. In the latter case this will be documented on the Wiki: https://wiki.winehq.org/Conformance_Tests#Running_WineTest_in_Wine * d2d1:d2d1, d3d10core:device These tests only fails on the GTX560. The reason is unknown. We need someone to look into it. * d3d8:device, d3d9:d3d9ex, d3d9:device, d3d9:visual Matteo fixed the radeon driver configuration and is looking into these failures, at least for the HD6800 case. It is possible some of these failures are caused by the window manager (currently xfwm from Xfce). Replacing the windows manager is no issue, we just need to know which one to pick. fvwm2? * kernel32:console, kernel32:process These failures happen because the tests are being run from cron, with their output redirected to a log file and thus they have no real terminal to work with. Interestingly the 64 bit tests are not failing. Vincent is investigating whether the tests should be modified or whether the test should be run from an xterm, screen session or some equivalent. * user32:winstation winstation.c:959: Test succeeded inside todo block: unexpected foreground window (nil) The cause for this failure has not been identified. Another window manager issue? * ws2_32:sock sock.c:2811: Test succeeded inside todo block: Test[2]: expected 0, got 0 We need someone to investigate this failure. It looks like it's random and relatively rare. Some tests just cannot be made to work reliably on Linux due to the asynchronous nature of X11 messaging. So another decision that was made that tests should be run up to 3 times until they succeed. It's not entirely clear if that applies to all tests or just to specific tests that are known to be flaky. The practical upshot is that people running 'make test' can re-run it a couple of times if it fails at first, and if it succeeds after 3 tries then you can consider that it's all good. These machines run WineTest so the results can be uploaded to test.winehq.org (with the relevant header describing the machine, the dlls, etc). So WineTest may need to be updated to deal with flaky tests according to policy. Here is more detail about these machines: * i7-2600K (4 cores+hyperthreading at 3.4GHz) * 16 GB of RAM * 768 GB of spinning disk * Debian 8.2 64 bit * cw1: AMD HD6800 running the open-source radeon driver. * cw2: Nvidia GTX560 running the proprietary driver. -- Francois Gouget <fgouget(a)codeweavers.com>

4 9

Code freeze
by Alexandre Julliard 09 Dec '16

09 Dec '16

Folks, The release of 2.0-rc1 marks the beginning of code freeze towards 2.0. Most of you probably know the drill already, but from now on, only targeted bug fixes and other "safe" changes, like test fixes, translation updates, etc. will be accepted. I know that many people will soon be out for the holidays, but I hope we can still make significant progress with the open bugs, particularly with the bugs from the regression list. Now would also be a good time to retest your favorite applications to make sure that there are no regressions that we have missed. As usual, I'll be making release candidates every week, until we run out of bugs... Thank you all for helping make Wine 2.0 as good as we can! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/7] server: Added support for message mode named pipes.
by Alexandre Julliard 09 Dec '16

09 Dec '16

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/kernel32/tests/pipe.c | 74 ++----- > dlls/ntdll/file.c | 7 +- > dlls/ntdll/tests/file.c | 2 +- > server/async.c | 15 ++ > server/file.h | 2 + > server/named_pipe.c | 499 > ++++++++++++++++++++++++++++++++++++++++++--- > 6 files changed, 510 insertions(+), 89 deletions(-) This is causing various random failures during make test. I don't have a good reproducible case, but it seems to randomly break communication with services. For instance I see mountmgr-related errors, or hangs in the msi tests. -- Alexandre Julliard julliard(a)winehq.org

3 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel