- wine-devel - winehq.org

Re: dsound: Avoid casts from COM object to interface.
by Andrew Eikum 09 Dec '16

09 Dec '16

On Thu, Dec 08, 2016 at 11:29:42AM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index 43b252d..d11c864 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -452,8 +452,8 @@ static HRESULT DirectSoundDevice_CreateSoundBuffer( > > if (device->primary) { > WARN("Primary Buffer already created\n"); > - IDirectSoundBuffer_AddRef((LPDIRECTSOUNDBUFFER8)(device->primary)); > - *ppdsb = (LPDIRECTSOUNDBUFFER)(device->primary); > + *ppdsb = (IDirectSoundBuffer *)&device->primary->IDirectSoundBuffer8_iface; > + IDirectSoundBuffer_AddRef(*ppdsb); > } else { Changing the order of these statements makes me nervous. Some applications use the returned pointers before the function returns, see 6a7c2f66e0569d2419eb9619e78716a9a5f94966. Andrew

1 0

[PATCH][RFC] msctf: Remove incorrect dereference of double pointer.
by Brock York 09 Dec '16

09 Dec '16

This is my attempt at a fix for Helldivers crashing on startup. This is my first Wine patch and I don't know the msctf system. I'm removing a dereference because it *seems* like the right thing to do. It seems to pass the msctf tests on my Arch box. If someone with more knowledge of msctf can give this a review and see if it's sane that would be appreciated. --------Patch below-------- Fixes https://bugs.winehq.org/show_bug.cgi?id=41252 ThreadMgr_QueryInterface is expecting ppvOut to be a pointer to a pointer. When UIElementMgr_QueryInterface calls the ThreadMgr_QueryInterface function it derefences the void **ppvOut making it a void *ppvOut when passing it in. When ThreadMgr_QueryInterface attempts to dereference this pointer to assign a pointer to it, it is instead accessing the value ppvOut is suppose to be pointing at. When the pointer ppvOut points to is NULL this causes a null pointer dereference Tested on Arch Linux Signed-off-by: Brock York <twunknown(a)gmail.com> --- dlls/msctf/threadmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index e1f56f1..62ddfd2 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -1187,7 +1187,7 @@ static HRESULT WINAPI UIElementMgr_QueryInterface(ITfUIElementMgr *iface, REFIID { ThreadMgr *This = impl_from_ITfUIElementMgr(iface); - return ITfThreadMgrEx_QueryInterface(&This->ITfThreadMgrEx_iface, iid, *ppvOut); + return ITfThreadMgrEx_QueryInterface(&This->ITfThreadMgrEx_iface, iid, ppvOut); } static ULONG WINAPI UIElementMgr_AddRef(ITfUIElementMgr *iface) -- 2.10.2

2 1

Re: [website] German translation for release 1.9.24
by Henri Verbeet 09 Dec '16

09 Dec '16

On 8 December 2016 at 16:06, Julian Rüger <jr98(a)gmx.net> wrote: > Dear D3D guys (esp. Stefan), do you have any suggestions or better translations for "unordered access views"? > Thanks! > My German isn't great, but "ungeordneten View-Zugriffen" sounds like "unordered view access" to me, which would be something else. (An UAV is a resource view that allows unordered/random read/write access to a resource from a shader, as opposed to e.g. shader resource views that only allow read access, or e.g. render target views that allow write access but only to a specific location.) You should probably check if Microsoft has an official translation for this, but lacking that I'd expect something along the lines of "ungeordnete Zugriffsview". Or whatever the appropriate translation of "view" would be in this context.

3 2

Re: [PATCH] ws2_32: Fix build failure on Mac
by Bruno Jesus 09 Dec '16

09 Dec '16

On Fri, Dec 9, 2016 at 3:11 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/ws2_32/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 3cdeade..6bf3c9d 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -1230,7 +1230,7 @@ static BOOL get_dont_fragment(SOCKET s, int level, BOOL *out) > static int once; > if (!once++) > FIXME("IP_DONTFRAGMENT for IPv6 not supported in this platform\n"); > - return TRUE /* fake success */ > + return TRUE; /* fake success */ > #endif Sorry for that, I tested the defines before cloning the block and for some reason I messed the last block.

1 0

Re: [PATCH] user32/tests: Add tests for LockWindowUpdate.
by Alexandre Julliard 08 Dec '16

08 Dec '16

Lauri Kenttä <lauri.kentta(a)gmail.com> writes: > v2: Win8 and Win10 give different results (sometimes even > different different results), so mark some cases as broken. > Also simplify the patch overall. I don't think that painting on the desktop window is a very useful test, and it can fail for various reasons. If the goal is to test LockWindowUpdate, you should do that with top-level windows instead. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: [PATCH 09/11] wined3d: Recognize dynamic linking shader instructions.
by Henri Verbeet 08 Dec '16

08 Dec '16

On 7 December 2016 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > This patch was written while testing the ret instruction in subroutines. Sets > of function bodies/tables are not parsed yet. If preferred, it can be split > into 5 patches (one for each instruction). > Not enough to make you redo it, but yes, split would have been preferred.

1 0

Re: [PATCH 08/11] d3d11/tests: Add test for primitive restart.
by Henri Verbeet 08 Dec '16

08 Dec '16

On 7 December 2016 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + get_texture_readback(test_context.backbuffer, 0, &rb); > + for (y = 0; y < 480; ++y) > + { > + for (x = 0; x < 640; ++x) > + { > + DWORD color = get_readback_color(&rb, x, y); > + DWORD expected_color; > + if (x < 240) > + expected_color = 0xffffff00; > + else if (x >= 640 - 240) > + expected_color = 0xff0000ff; > + else > + expected_color = 0x00000000; > + ok(compare_color(color, expected_color, 1), > + "Test %u: Got 0x%08x, expected 0x%08x at (%u, %u).\n", > + i, color, expected_color, x, y); > + } > + } > + release_resource_readback(&rb); For what it's worth, if we'll have more tests like this in the future, adding an optional rectangle argument to check_texture_color() may be useful.

1 0

Re: [PATCH] wincodecs: Remove some of error handling duplication in InitializePredefined()
by Dmitry Timoshkov 08 Dec '16

08 Dec '16

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > case WICBitmapPaletteTypeFixedHalftone125: > colors = generate_halftone125_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone216: > colors = generate_halftone216_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone252: > colors = generate_halftone252_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone256: > colors = generate_halftone256_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > default: > @@ -406,6 +417,9 @@ static HRESULT WINAPI PaletteImpl_InitializePredefined(IWICPalette *iface, > return E_INVALIDARG; > } > > + if (!colors) > + return E_OUTOFMEMORY; That's hardly an improvement, at best this is a personal preference. When I wrote this code I was considering other versions as well, and current variant I like better. Please leave this code as it is. -- Dmitry.

1 0

Re: [PATCH] uxtheme: Return E_POINTER if RECT pointer is NULL.
by Nikolay Sivov 08 Dec '16

08 Dec '16

On Tue, 6 Dec 2016 08:37:32 +0100 Hadrien Boizard <h.boizard(a)gmail.com> wrote: > DrawTextW(hdc, pszText, iCharCount, &rt, dwTextFlags|DT_CALCRECT); > + if(!pExtentRect) > + return E_POINTER; > *pExtentRect = rt; This needs a test.

1 0

Re: [PATCH v3] winemapi: Directly use xdg-email if available, enabling file attachments.
by Bruno Jesus 08 Dec '16

08 Dec '16

On Tue, Nov 22, 2016 at 5:46 PM, Jeremy White <jwhite(a)codeweavers.com> wrote: > Signed-off-by: Jeremy White <jwhite(a)codeweavers.com> > --- > This addresses https://bugs.winehq.org/show_bug.cgi?id=11770 for systems with xdg-email. Hi, for unknown reasons I did not receive the v4 email so I'm replying here. Is there any way to test this without Microsoft Office? Best wishes, Bruno

2 1

Re: [PATCH] msacm32: Support conversion from 24-bit PCM
by Lauri Kenttä 07 Dec '16

07 Dec '16

On 2016-12-05 19:28, Andrew Eikum wrote: > +static inline short C2416(int s) > +{ > + return HIWORD(s); > +} > + Just wondering: Is it true that msacm32 doesn't do any dithering? -- Lauri Kenttä

2 1

Re: [PATCH] kernel32/tests: Mask out FILE_ATTRIBUTE_COMPRESSED to prevent failures.
by Marvin 07 Dec '16

07 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27243 Your paranoid android. === wxppro (32 bit file) === file.c:2389: Test failed: open failed for modes 40/2/40010000/2 file.c:2393: Test failed: wrong error code 32

1 0

Re: [TEST v2] user32/tests: Add tests for LockWindowUpdate.
by Marvin 07 Dec '16

07 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27238 Your paranoid android. === wvistau64 (32 bit win) === win.c:8981: Test failed: GetActiveWindow() = 000200E0 win.c:8981: Test failed: GetFocus() = 000200E0 === w8 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00222200 === w864 (64 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (64 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00222200

1 0

Re: [TEST] user32/tests: Add tests for LockWindowUpdate.
by Marvin 07 Dec '16

07 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27237 Your paranoid android. === w8 (32 bit win) === win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (32 bit win) === win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (32 bit win) === win.c:9386: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (64 bit win) === win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (64 bit win) === win.c:9386: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff

1 0

Re: [PATCH] ws2_32: Add support to disable networking with envvar WINENONET=1
by Jens Reyer 07 Dec '16

07 Dec '16

On 07.12.2016 07:27, Bruno Jesus wrote: > I have used this in some situations to check how network enabled applications react to not having network access. IMO it is useful but if nobody cares I don't mind it being rejected. I like it. Can you document it in a manpage? Greets jre

2 2

Re: [PATCH] d2d1/tests: Change rotation angle in test_bitmap_brush().
by Henri Verbeet 07 Dec '16

07 Dec '16

On 7 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Fixes the test failure with Nvidia binary driver. > Well yes, but that's a much less interesting rotation.

1 0

Re: [PATCH] user32/tests: Add tests for LockWindowUpdate.
by Marvin 06 Dec '16

06 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27177 Your paranoid android. === w8 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w864 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w1064 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w864 (64 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w1064 (64 bit win) === win.c:9388: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff

1 0

WineHQ packages for 1.9.24
by Rosanne DiMesio 06 Dec '16

06 Dec '16

WineHQ packages for 1.9.24 still haven't been built for any of the distros, and users are asking about them. What's going on? -- Rosanne DiMesio dimesio(a)earthlink.net

3 2

Serial port sniffing problem
by Bill Lionheart 06 Dec '16

06 Dec '16

Using Wine version 1.8 on Ubuntu 14.04.5 I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a serial interface. The device is supplied with a Prolific USB serial converter which comes up as /dev/ttyUSB0 which I have sym linked to COM1 The bundled GPRS tracker config software installs and runs OK under Wine. But my attempts to sniff the serial port traffic fails using all the standard Linux methods I know. I also tried using the Windows program Serial Port Monitor under Wine http://www.eltima.com/products/serial-port-monitor/ . This program says it cannot detect any serial ports. Under Windows 7 the config program and Serial Port Monitor both work well and I can intercept all the serial traffic Any ideas please folks? Bill

3 4

Calling msvcp90 (C++) functions from Wine code
by Lauri Kenttä 06 Dec '16

06 Dec '16

Hey, In a patch [1] I ended up recreating a function that practically exists already in msvcp90 as tr2_sys__Equivalent_wchar. However, I'm guessing it's not okay to call tr2_sys__Equivalent_wchar directly, since it's really a C++ function. Is there some valid and portable way to use this tr2_sys__Equivalent_wchar within another part of Wine (in this case, cmd.exe), to avoid duplicate code? [1] http://source.winehq.org/patches/data/128310 -- Lauri Kenttä

3 3

Re: [PATCH] user32: Handle WM_SYSKEYDOWN in MENU_SuspendPopup.
by Alexandre Julliard 06 Dec '16

06 Dec '16

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Technically, all the stuff about WM_SYSKEYDOWN is unnecessary. All we > really need to do is fix the error handling, or remove this questionable > optimization altogether. I'm not sure what you mean by that. Also you are essentially reverting d75b0cdc986f464f3067767cd53aca6b85feb366, I'd like to hear some justification for that. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: [PATCH v3] cmd: Fix copying when the dest is one of the sources.
by Marvin 05 Dec '16

05 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27154 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: [PATCH v2] cmd: Fix copying when the dest is one of the sources.
by Marvin 05 Dec '16

05 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27152 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: kernel32: Implement Process thread attribute lists.
by Dmitry Timoshkov 05 Dec '16

05 Dec '16

Huw Davies <huw(a)codeweavers.com> wrote: > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 3c25286..224e6ae 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec ... > +@ stdcall DeleteProcThreadAttributeList(ptr) ... > +@ stdcall InitializeProcThreadAttributeList(ptr long long ptr) ... > +@ stdcall UpdateProcThreadAttribute(ptr long long ptr long ptr ptr) UMS (User Mode Scheduler) stuff should be implemented in ntdll and kernel32 APIs should be either forwards or thin wrappers around the ntdll exports. So, to avoid duplicate efforts this all from the start needs to be implemeted in ntdll. -- Dmitry.

2 5

Re: [PATCH] ws2_32: Implement automatic broadcast for UDP sockets on sendto() (try 2)
by Hans Leidekker 05 Dec '16

05 Dec '16

On Sat, 2016-12-03 at 00:15 -0200, Bruno Jesus wrote: > @@ -2446,8 +2476,32 @@ static int WS2_send( int fd, struct ws2_async *wsa, int flags ) > return -1; > } > > + if (wsa->addr->sa_family == WS_AF_INET) > + { > + /* When the target IPv4 address ends in 255 we are going to check if > + * it matches the broadcast address. Trying to send the packet without > + * setting SO_BROADCAST results in EACCES, to avoid that we will enable > + * the flag and send the packet, after that we will restore the flag > + * This is the most common estimate to reduce the number of UDP packets > + * that we need to check. */ > + struct sockaddr_in *addr = (struct sockaddr_in*) hdr.msg_name; > + in_addr_t address = addr->sin_addr.s_addr; > + > + if (address != INADDR_BROADCAST && (address & 0xFF000000) == 0xFF000000) This doesn't work for a /25 network, for example. You really need to use the network mask here to calculate the broadcast address. > +/* required for broadcast tests */ > +static void disable_firewall(void) > +{ > + system("netsh firewall set opmode disable"); /* XP */ > + system("netsh Advfirewall set allprofiles state off"); /* >= Vista*/ > +} > + > +static void enable_firewall(void) > +{ > + system("netsh firewall set opmode enable"); /* XP */ > + system("netsh Advfirewall set allprofiles state on"); /* >= Vista*/ > +} This will not work if the test is run as an unprivileged user. It would be better to use an API like INetFwMgr and skip the affected tests when you can't modify the firewall. I'm working on a fix for a similar problem in the rpcrt4 test. I can share a patch if you're interested.

3 6

Re: [PATCH v2] wined3d: Implement SM5 atomic_umax/min instructions.
by Józef Kucia 05 Dec '16

05 Dec '16

On Sun, Dec 4, 2016 at 6:49 PM, Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote: > @@ -897,6 +899,8 @@ static const struct wined3d_sm4_opcode_info opcode_table[] = > {WINED3D_SM5_OP_LD_STRUCTURED, WINED3DSIH_LD_STRUCTURED, "u", "iiR"}, > {WINED3D_SM5_OP_STORE_STRUCTURED, WINED3DSIH_STORE_STRUCTURED, "U", "iiu"}, > {WINED3D_SM5_OP_ATOMIC_IADD, WINED3DSIH_ATOMIC_IADD, "U", "ii"}, >+ {WINED3D_SM5_OP_ATOMIC_UMAX, WINED3DSIH_ATOMIC_UMAX, "U", "uu"}, >+ {WINED3D_SM5_OP_ATOMIC_UMIN, WINED3DSIH_ATOMIC_UMIN, "U", "uu"}, This is wrong. The generated GLSL code will produce compiler errors. FWIW, I should have patches for various atomics with some tests soon.

2 1

Re: [PATCH 03/18] d3d11/tests: Add test for depth/stencil shader resource views.
by Henri Verbeet 05 Dec '16

05 Dec '16

On 5 December 2016 at 12:04, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 335 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 335 insertions(+) > This fails here on Windows: d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6578: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6582: Test failed: Got unexpected value 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6590: Test failed: Got unexpected value 2.55199997e+002 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got unexpected value 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6598: Test failed: Got unexpected value 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6578: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6582: Test failed: Got unexpected value 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6590: Test failed: Got unexpected value 2.55199997e+002 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got unexpected value 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6598: Test failed: Got unexpected value 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0.

1 0

Re: [PATCH 02/18] wined3d: Set default sampler minification filter to GL_NEAREST.
by Józef Kucia 05 Dec '16

05 Dec '16

On Mon, Dec 5, 2016 at 12:04 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > This seems to be required for reading stencil values. The GL spec says > "When sampling the stencil index only NEAREST filtering is supported.". > The GL spec is inconsistent about this, but Mesa refuses to sample > stencil index values with the GL_NEAREST_MIPMAP_NEAREST filter. The NEAREST_MIPMAP_NEAREST is going to be allowed in Mesa (there is a patch for this [1]). However, the ARB_stencil_texturing spec was never updated, and an implementation of OpenGL which does not expose GL 4.5 doesn't have to allow using NEAREST_MIPMAP_NEAREST for stencil texturing. [1] - https://lists.freedesktop.org/archives/mesa-dev/2016-December/137309.html

1 0

Re: [PATCH] user32: Fix handling of invert_y in DrawTextExW.
by Dmitry Timoshkov 05 Dec '16

05 Dec '16

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > From: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> 1. this needs some tests 2. are you planning to fix any regressions caused by this patch without relying on Sebastian's help? -- Dmitry.

2 2

Windows 2008 does not support MP3 correctly in msacm32.dll?
by Bruno Jesus 05 Dec '16

05 Dec '16

Hi, in an attempt to add MP3 tests from Michael Müller it looks like the only machine that has trouble is Windows 2008 [1]. Around half of the tests are rejected while in all other versions it worked fine. Could there be a simple explanation to this? [1] https://testbot.winehq.org/JobDetails.pl?Key=27009 Best wishes, Bruno

2 2

Re: [PATCH] Updated Readme with Github Markdown
by Alex Henrie 04 Dec '16

04 Dec '16

Hello Varunram, and thanks for your interest in contributing to Wine. The patch you submitted is very unlikely to be accepted because we, like the Linux kernel and many other projects, optimize our READMEs for terminal text editors rather than for GitHub. Also, if you submit any more patches in the future, please be sure to use your real name and include a Signed-off-by line. -Alex

1 0

WineHQ Forums: Slackware multi-lib Wine build issues
by Bob Wya 04 Dec '16

04 Dec '16

Hiya, I've gotten really stuck trying to help out a Slackware user (yes they still exist!) on the WineHQ forums... Been bashing away at this problem for over a month now. He's trying to build a Shared WoW64 Wine. The build logs look clean. But the 32-bit half of Wine is segfaulting immediately. The 64-bit half appears to function as normal. I feel like I've hit a brick wall now... Anyone able to help? See: https://forum.winehq.org/viewtopic.php?f=8&t=27879 -- All the best, Robert

1 0

Re: [v2 1/2] wined3d: Implement primitive restart index.
by Józef Kucia 04 Dec '16

04 Dec '16

On Fri, Nov 18, 2016 at 4:44 AM, Andrew Wesie <awesie(a)gmail.com> wrote: > @@ -8602,6 +8602,16 @@ static void shader_glsl_init_context_state(struct wined3d_context *context) > > gl_info->gl_ops.gl.p_glEnable(GL_PROGRAM_POINT_SIZE); > checkGLcall("GL_PROGRAM_POINT_SIZE"); > + if (gl_info->supported[ARB_ES3_COMPATIBILITY]) > + { > + /* We prefer this method because it correctly handles 16-bit and 32-bit indices. */ > + gl_info->gl_ops.gl.p_glEnable(GL_PRIMITIVE_RESTART_FIXED_INDEX); > + checkGLcall("GL_PRIMITIVE_RESTART_FIXED_INDEX"); > + } Is it really safe to enable the primitive restart for all D3D versions? Shouldn't we enable it just for D3D10+? See, e.g., e47a735f762ebe1545bb366c7e9e2b90db7c7f80, if it's decided that this should be enabled just for D3D10+. > + else > + { > + WARN("Missing support for primitive restart index.\n"); > + } This is not important, but ideally this would be a FIXME() for D3D10+ feature level >= 10_0 and nothing otherwise. > } > > static void shader_glsl_get_caps(const struct wined3d_gl_info *gl_info, struct shader_caps *caps) > diff --git a/dlls/wined3d/wined3d_gl.h b/dlls/wined3d/wined3d_gl.h > index b71190d..7bd2d6a 100644 > --- a/dlls/wined3d/wined3d_gl.h > +++ b/dlls/wined3d/wined3d_gl.h > @@ -55,6 +55,7 @@ enum wined3d_gl_extension > ARB_DRAW_ELEMENTS_BASE_VERTEX, > ARB_DRAW_INSTANCED, > ARB_ES2_COMPATIBILITY, > + ARB_ES3_COMPATIBILITY, > ARB_EXPLICIT_ATTRIB_LOCATION, > ARB_FRAGMENT_COORD_CONVENTIONS, > ARB_FRAGMENT_PROGRAM, The extension has to be also added to the "core_extensions" table.

2 2

Re: [PATCH v2] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Lauri Kenttä 03 Dec '16

03 Dec '16

On 2016-12-03 22:27, Lauri Kenttä wrote: > Inspired by bug 7961. > > v2: Apparently Windows has much more strict limits for file names on > native file systems (compared to VirtualBox shared folders), so this > version of the patch leaves out some of the more problematic ones. > Tested on Windows 2003 Server with NTFS. The remaining TestBot failures are not my fault, again. Also, the "much more strict limits" part was a bit exaggerated. There were simply two file names ending with dots, even though I knew they wouldn't work on FAT32 or NTFS. I thought I had removed them already. Anyway, that's fixed in this v2. -- Lauri Kenttä

1 0

Re: [PATCH v2] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Marvin 03 Dec '16

03 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27101 Your paranoid android. === wxppro (32 bit file) === file.c:2388: Test failed: open failed for modes 0/2/c0000000/2 file.c:2392: Test failed: wrong error code 32 === wvistau64 (32 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [PATCH] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Marvin 03 Dec '16

03 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27099 Your paranoid android. === wxppro (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2003std (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === wvistau64 (32 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2008s64 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7u (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7pro64 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w8 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w864 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w1064 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === wvistau64 (64 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2008s64 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7pro64 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w864 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w1064 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none

1 0

Re: [PATCH] ws2_32: Implement automatic broadcast for UDP sockets on sendto() (try 2)
by Marvin 03 Dec '16

03 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27089 Your paranoid android. === w2003std (32 bit sock) === An error occurred while retrieving the test report: network read got a premature EOF (getfile:ListSize:0/4) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH 7/7] bcrypt: Mostly implement AES decryption
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27082 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] bcrypt: Implement AES encryption
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27081 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/7] bcrypt: Beginnings of the AES provider
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27080 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] bcrypt: Implement BCryptGenerateSymmetricKey function
by Bruno Jesus 02 Dec '16

02 Dec '16

OOps, sorry for that. I pasted the wrong command in the terminal. This is the real deal but was only supposed to be sent if the previous 5 test patches were commited. On Fri, Dec 2, 2016 at 8:28 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > From: Hans Leidekker <hans(a)codeweavers.com> > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/bcrypt/bcrypt_main.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/dlls/bcrypt/bcrypt_main.c b/dlls/bcrypt/bcrypt_main.c > index 6023c94..50c05c0 100644 > --- a/dlls/bcrypt/bcrypt_main.c > +++ b/dlls/bcrypt/bcrypt_main.c > @@ -138,6 +138,8 @@ NTSTATUS WINAPI BCryptEnumAlgorithms(ULONG dwAlgOperations, ULONG *pAlgCount, > > #define MAGIC_ALG (('A' << 24) | ('L' << 16) | ('G' << 8) | '0') > #define MAGIC_HASH (('H' << 24) | ('A' << 16) | ('S' << 8) | 'H') > +#define MAGIC_KEY (('K' << 24) | ('E' << 16) | ('Y' << 8) | '0') > + > struct object > { > ULONG magic; > @@ -172,6 +174,8 @@ struct algorithm > BOOL hmac; > }; > > +static ULONG get_block_size( enum alg_id alg ); > + > NTSTATUS WINAPI BCryptGenRandom(BCRYPT_ALG_HANDLE handle, UCHAR *buffer, ULONG count, ULONG flags) > { > const DWORD supported_flags = BCRYPT_USE_SYSTEM_PREFERRED_RNG; > @@ -541,6 +545,37 @@ static NTSTATUS hmac_finish( struct hash *hash, UCHAR *output, ULONG size ) > pgnutls_hmac_deinit( hash->u.hmac_handle, output ); > return STATUS_SUCCESS; > } > + > +struct key > +{ > + struct object hdr; > + enum alg_id alg_id; > + ULONG block_size; > + gnutls_cipher_hd_t handle; > + UCHAR *secret; > + ULONG secret_len; > +}; > + > +static NTSTATUS key_init( struct key *key, enum alg_id id, UCHAR *secret, ULONG secret_len ) > +{ > + if (!libgnutls_handle) return STATUS_INTERNAL_ERROR; > + > + switch (id) > + { > + default: > + FIXME( "algorithm %u not supported\n", id ); > + return STATUS_NOT_SUPPORTED; > + } > + > + if (!(key->block_size = get_block_size( id ))) return STATUS_INVALID_PARAMETER; > + > + key->alg_id = id; > + key->handle = 0; /* initialized on first use */ > + key->secret = secret; > + key->secret_len = secret_len; > + > + return STATUS_SUCCESS; > +} > #else > struct hash > { > @@ -584,6 +619,17 @@ static NTSTATUS hmac_finish( struct hash *hash, UCHAR *output, ULONG size ) > ERR( "support for hashes not available at build time\n" ); > return STATUS_NOT_IMPLEMENTED; > } > + > +struct key > +{ > + struct object hdr; > +}; > + > +static NTSTATUS key_init( struct key *key, enum alg_id id, const UCHAR *secret, ULONG secret_len ) > +{ > + ERR( "support for keys not available at build time\n" ); > + return STATUS_NOT_IMPLEMENTED; > +} > #endif > > #define OBJECT_LENGTH_MD5 274 > @@ -694,6 +740,13 @@ static NTSTATUS get_alg_property( enum alg_id id, const WCHAR *prop, UCHAR *buf, > return STATUS_SUCCESS; > } > > +static ULONG get_block_size( enum alg_id alg ) > +{ > + ULONG ret = 0, size = sizeof(ret); > + get_alg_property( alg, BCRYPT_BLOCK_LENGTH, (UCHAR *)&ret, sizeof(ret), &size ); > + return ret; > +} > + > static NTSTATUS get_hash_property( enum alg_id id, const WCHAR *prop, UCHAR *buf, ULONG size, ULONG *ret_size ) > { > NTSTATUS status; > @@ -854,6 +907,32 @@ NTSTATUS WINAPI BCryptHash( BCRYPT_ALG_HANDLE algorithm, UCHAR *secret, ULONG se > return BCryptDestroyHash( handle ); > } > > +NTSTATUS WINAPI BCryptGenerateSymmetricKey( BCRYPT_ALG_HANDLE algorithm, BCRYPT_KEY_HANDLE *handle, > + UCHAR *object, ULONG object_len, UCHAR *secret, ULONG secret_len, > + ULONG flags ) > +{ > + struct algorithm *alg = algorithm; > + struct key *key; > + NTSTATUS status; > + > + TRACE( "%p, %p, %p, %u, %p, %u, %08x\n", alg, handle, object, object_len, secret, secret_len, flags ); > + > + if (!alg || alg->hdr.magic != MAGIC_ALG) return STATUS_INVALID_HANDLE; > + if (object) FIXME( "ignoring object buffer\n" ); > + > + if (!(key = HeapAlloc( GetProcessHeap(), 0, sizeof(*key) ))) return STATUS_NO_MEMORY; > + key->hdr.magic = MAGIC_KEY; > + > + if ((status = key_init( key, alg->id, secret, secret_len ))) > + { > + HeapFree( GetProcessHeap(), 0, key ); > + return status; > + } > + > + *handle = key; > + return STATUS_SUCCESS; > +} > + > BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) > { > switch (reason) > -- > 2.9.3 >

1 0

Re: [PATCH v3] winemapi: Directly use xdg-email if available, enabling file attachments.
by André Hentschel 02 Dec '16

02 Dec '16

Hi, comments inline Am 22.11.2016 um 20:46 schrieb Jeremy White: > -ULONG WINAPI MAPISendMail(LHANDLE session, ULONG_PTR uiparam, > +static ULONG BrowserSendMail(LHANDLE session, ULONG_PTR uiparam, > lpMapiMessage message, FLAGS flags, ULONG reserved) > { > ULONG ret = MAPI_E_FAILURE; > @@ -291,6 +370,129 @@ exit: > return ret; > } Do you need all those parameters? > +/************************************************************************** > + * XDGSendMail > + * > + * Send a message using xdg-email mail client. > + * > + */ > +ULONG XDGSendMail(LHANDLE session, ULONG_PTR uiparam, > + lpMapiMessage message, FLAGS flags, ULONG reserved) Same here Also should be a static function > + > + TRACE("(0x%08lx 0x%08lx %p 0x%08x 0x%08x)\n", session, uiparam, message, flags, reserved); I'd keep the TRACE in the WINAPI function > + > + if (!message) > + return MAPI_E_FAILURE; maybe this check, too > + max_args = 1 + (2 + message->nRecipCount + message->nFileCount) * 2; > + argv = HeapAlloc(GetProcessHeap(), 0, (max_args + 1) * sizeof(*argv)); > + if (!argv) > + return MAPI_E_INSUFFICIENT_MEMORY; > + > + ret = add_argument(argv, &argc, "xdg-email", NULL); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + > + if (message->lpOriginator) > + TRACE("From: %s (unused)\n", debugstr_a(message->lpOriginator->lpszAddress)); Why is the TRACE message different from the original function? > + > + for (i = 0; i < message->nRecipCount; i++) > + { > + if (!message->lpRecips) > + { > + WARN("Recipient %d missing\n", i); > + ret = MAPI_E_FAILURE; > + goto exit; > + } > + > + if (message->lpRecips[i].lpszAddress) > + { > + ret = add_target(argv, &argc, message->lpRecips[i].ulRecipClass, add_target is only used in one place, no need for a helper function IMO > + message->lpRecips[i].lpszAddress); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + } > + else > + FIXME("Name resolution and entry identifiers not supported\n"); > + } > + > + for (i = 0; i < message->nFileCount; i++) > + { > + TRACE("File Path: %s, name %s\n", debugstr_a(message->lpFiles[i].lpszPathName), > + debugstr_a(message->lpFiles[i].lpszFileName)); > + ret = add_file(argv, &argc, message->lpFiles[i].lpszPathName, message->lpFiles[i].lpszFileName); Same for add_file Hope that helps

2 1

Re: [PATCH 5/5] bcrypt/tests: Add BCryptEncrypt/Decrypt tests
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27070 Your paranoid android. === wvistau64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w2008s64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w7pro64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 622 bcrypt.c:848: Test failed: got 622 === w864 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654 === w1064 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654

2 2

Re: [PATCH 4/5] bcrypt/tests: Add BCryptGenerateSymmetricKey tests
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27069 Your paranoid android. === wvistau64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w2008s64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w7pro64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 622 bcrypt.c:848: Test failed: got 622 === w864 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654 === w1064 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654

1 0

Re: [PATCH 3/5] bcrypt/tests: Add AES provider tests
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27068 Your paranoid android. === wvistau64 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 598 === w2008s64 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 598 === w7pro64 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 622 === w864 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 654 === w1064 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 654

1 0

Re: [PATCH 1/3] server: Introduced iosb struct for server-side IO_STATUS_BLOCK representation and use it in irp_call.
by Alexandre Julliard 02 Dec '16

02 Dec '16

Jacek Caban <jacek(a)codeweavers.com> writes: > +/* release iosb reference */ > +void release_iosb( struct iosb *iosb ) > +{ > + if (--iosb->refcount) return; > + > + free( iosb->in_data ); > + free( iosb->out_data ); > + free( iosb ); > +} I think you should use a proper server object instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Signal pipe server fd in create_pipe_server.
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27047 Your paranoid android. === w2008s64 (32 bit pipe) === Unable to set the VM system time: the "nc -q0 '10.42.42.136' '4242'" command returned 1 (settime/connect). Maybe the TestAgentd process is missing the required privileges. The test VM is powered off! Did the test shut it down?

1 0

Re: [PATCH] dxgi: Silence a noisy fixme
by Henri Verbeet 02 Dec '16

02 Dec '16

On 2 December 2016 at 10:26, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > static HRESULT STDMETHODCALLTYPE dxgi_output_WaitForVBlank(IDXGIOutput *iface) > { > - FIXME("iface %p stub!\n", iface); > + BOOL once = FALSE; > + > + if (!once++) > + FIXME("iface %p stub!\n", iface); > > return E_NOTIMPL; > } Did you test that this does what you think it does? Leaving that issue aside for the moment, while printing the FIXME only once is probably fine, not tracing anything on subsequent calls isn't.

1 0

Re: [PATCH] dxgi: Silence a noisy fixme
by Hans Leidekker 02 Dec '16

02 Dec '16

On Fri, 2016-12-02 at 09:26 +0000, Alistair Leslie-Hughes wrote: > diff --git a/dlls/dxgi/output.c b/dlls/dxgi/output.c > index 0cf8084..61a7043 100644 > --- a/dlls/dxgi/output.c > +++ b/dlls/dxgi/output.c > @@ -268,7 +268,10 @@ static HRESULT STDMETHODCALLTYPE dxgi_output_FindClosestMatchingMode(IDXGIOutput > > static HRESULT STDMETHODCALLTYPE dxgi_output_WaitForVBlank(IDXGIOutput *iface) > { > - FIXME("iface %p stub!\n", iface); > + BOOL once = FALSE; > + > + if (!once++) > + FIXME("iface %p stub!\n", iface); > > return E_NOTIMPL; > } static BOOL once;

1 0

Call for tests - GNU/Linux & specially OSX - iphlpapi
by Bruno Jesus 02 Dec '16

02 Dec '16

Hello all, in order to exercise an IP ordering problem from bug 40247 (OSX) [1] I would like to request help for testing the crosstest at [2]. Valid testers must have at least 1 network interface with a valid IP and a the loopback interface up. A good test should result in 1 error, if not send me the results anyway, only the traces from lines 262 and 266 are needed (first in the log, 10 lines should be enough). If you find the lines I'm expecting just paste them, if you don't have patience just attach the whole results, pĺease. Sample output: bruno@Note:~/programs/wine32/dlls/iphlpapi/tests$ wine iphlpapi_crosstest.exe iphlpapi.c:262: Entry[0]: addr 127.0.0.1, dwIndex 1, wType 0x1 iphlpapi.c:266: Test failed: Loopback interface wrongly at position 0/3 iphlpapi.c:262: Entry[1]: addr 192.168.1.34, dwIndex 3, wType 0x1 iphlpapi.c:262: Entry[2]: addr 192.168.112.1, dwIndex 4, wType 0x1 iphlpapi.c:262: Entry[3]: addr 192.168.27.1, dwIndex 5, wType 0x1 [1] https://bugs.winehq.org/show_bug.cgi?id=40247 [2] https://testbot.winehq.org/JobDetails.pl?Key=27012 Thanks in advance, Bruno

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel