- wine-devel - winehq.org

Testing Direct3D
by Fabian Maurer 01 Dec '16

01 Dec '16

Hello Wine-Devel, It might be a stupid question, but how do you test the Direct3D implementation? I don't mean the conformance tests, these too need to get the data somewhere. So you probably have a windows running somewhere. I currently I don't have a windows machine to test on though. Only a Virtualbox VM, and this doesn't offer (reliable) 3D acceleration for DX > 9. Do you have your own windows machine dedicated to this, or how do you do it?

3 5

Re: [PATCH 2/2] winmm: Use a thread to send driver messages on Win9x (try 2)
by Andrew Eikum 01 Dec '16

01 Dec '16

This seems like something you should be able to write a test for. I'm also curious how this manages to work on Windows >= XP You need to be more careful about thread shutdown. See WINMM_StartDevicesThread and WINMM_DevicesThreadProc. I think you could use the same logic, including WINMM_DevicesThreadDone, to determine when to quit your new thread. Andrew On Thu, Dec 01, 2016 at 11:32:35AM -0200, Bruno Jesus wrote: > try 2: > Use a better way to detect Win9x (thanks Dmitry) > Use a single point of config/teardown and a pointer to callback (thanks Nikolay) > > More detailed explanation in the patch comments. Basically the games use a DLL that calls SuspendThread from inside the WinMM callback, this makes the program hang as we use the "main thread" to dispatch callbacks. > > Games tested in Win95 config: > Heroes of Might & Magic (well known affected) > Deadlock (well known affected) > Worms 2 (just to ensure things still work) > Age of Empires (just to ensure things still work) > Shivers (just to ensure things still work) > > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=3930 > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/winmm/waveform.c | 117 ++++++++++++++++++++++++++++++++++++++++++-------- > dlls/winmm/winemm.h | 1 + > dlls/winmm/winmm.c | 2 +- > 3 files changed, 101 insertions(+), 19 deletions(-) > > diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c > index 7308519..4387c44 100644 > --- a/dlls/winmm/waveform.c > +++ b/dlls/winmm/waveform.c > @@ -134,6 +134,13 @@ struct _WINMM_MMDevice { > WINMM_Device *devices[MAX_DEVICES]; > }; > > +static struct { > + HANDLE thread, event_main, event_thread; > + WINMM_CBInfo *info; > + WORD msg; > + DWORD_PTR param1, param2; > +} win9x; > + > static WINMM_MMDevice *g_out_mmdevices; > static WINMM_MMDevice **g_out_map; > static UINT g_outmmdevices_count; > @@ -192,6 +199,77 @@ static LRESULT WID_Open(WINMM_OpenInfo *info); > static LRESULT WID_Close(HWAVEIN hwave); > static MMRESULT WINMM_BeginPlaying(WINMM_Device *device); > > +static void (*pWINMM_NotifyClient)(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > + DWORD_PTR param2); > + > + > +static DWORD WINAPI win9x_callback_thread(LPVOID param) > +{ > + while(WaitForSingleObject(win9x.event_thread, INFINITE) == WAIT_OBJECT_0) > + { > + if (!win9x.info->hwave) break; > + DriverCallback(win9x.info->callback, win9x.info->flags, (HDRVR)win9x.info->hwave, > + win9x.msg, win9x.info->user, win9x.param1, win9x.param2); > + SetEvent(win9x.event_main); > + } > + return 0; > +} > + > +/* Note: NotifyClient should never be called while holding the device lock > + * since the client may call wave* functions from within the callback. */ > +static inline void WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > + DWORD_PTR param2) > +{ > + DriverCallback(info->callback, info->flags, (HDRVR)info->hwave, > + msg, info->user, param1, param2); > +} > + > +static inline void WINMM_NotifyClient9x(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > + DWORD_PTR param2) > +{ > + /* Prepare callback data for the thread, dispatch and wait response */ > + win9x.info = info; > + win9x.msg = msg; > + win9x.param1 = param1; > + win9x.param2 = param2; > + SetEvent(win9x.event_thread); > + WaitForSingleObject(win9x.event_main, INFINITE); > +} > + > +void WINMM_SetupCallback(void) > +{ > + pWINMM_NotifyClient = WINMM_NotifyClient; > + if (!(GetVersion() & 0x80000000)) > + return; > + > + /* WAIL32.DLL from Rad Game Tools is an audio helper DLL that simplifies the > + * use of sound effects in an application. It seems to be released in 1996 and > + * is used at least by Heroes of Might and Magic and Deadlock. Unfortunately > + * during a callback to the DLL it calls SuspendThread on the main thread and > + * keeps doing some stuff from inside the callback until it does a ResumeThread > + * and returns from the callback. This works in Windows 95/98 because they use > + * a separate thread to send callback messages. XP changed this by going back > + * to a single thread but the games still works due to shim. > + */ > + TRACE("Using old behavior of WinMM callbacks\n"); > + win9x.event_thread = CreateEventA(NULL, FALSE, FALSE, NULL); > + win9x.event_main = CreateEventA(NULL, FALSE, FALSE, NULL); > + win9x.thread = CreateThread(NULL, 0, win9x_callback_thread, NULL, 0, NULL); > + if (win9x.event_thread && win9x.event_main && win9x.thread) > + pWINMM_NotifyClient = WINMM_NotifyClient9x; > + else > + { > + ERR("Failed to create resources for callback, expect problems!\n"); > + TerminateThread(win9x.thread, 0); > + CloseHandle(win9x.event_main); > + CloseHandle(win9x.event_thread); > + CloseHandle(win9x.thread); > + win9x.event_main = win9x.event_thread = win9x.thread = NULL; > + return; > + } > +} > + > +/* tear down function for DLL process detach */ > void WINMM_DeleteWaveform(void) > { > UINT i, j; > @@ -241,6 +319,18 @@ void WINMM_DeleteWaveform(void) > HeapFree(GetProcessHeap(), 0, g_device_handles); > HeapFree(GetProcessHeap(), 0, g_handle_devices); > > + if (win9x.thread) > + { > + /* warn the thread so it can die gracefully */ > + win9x.info->hwave = 0; > + SetEvent(win9x.event_thread); > + > + CloseHandle(win9x.event_main); > + CloseHandle(win9x.event_thread); > + CloseHandle(win9x.thread); > + win9x.event_main = win9x.event_thread = win9x.thread = NULL; > + } > + > DeleteCriticalSection(&g_devthread_lock); > } > > @@ -370,15 +460,6 @@ static WINMM_Device *WINMM_GetDeviceFromHWAVE(HWAVE hwave) > return device; > } > > -/* Note: NotifyClient should never be called while holding the device lock > - * since the client may call wave* functions from within the callback. */ > -static inline void WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > - DWORD_PTR param2) > -{ > - DriverCallback(info->callback, info->flags, (HDRVR)info->hwave, > - msg, info->user, param1, param2); > -} > - > static MMRESULT hr2mmr(HRESULT hr) > { > switch(hr){ > @@ -1753,7 +1834,7 @@ exit: > WAVEHDR *next = first->lpNext; > first->dwFlags &= ~WHDR_INQUEUE; > first->dwFlags |= WHDR_DONE; > - WINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > first = next; > } > } > @@ -1929,7 +2010,7 @@ exit: > WAVEHDR *next = first->lpNext; > first->dwFlags &= ~WHDR_INQUEUE; > first->dwFlags |= WHDR_DONE; > - WINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > first = next; > } > } > @@ -2022,9 +2103,9 @@ static LRESULT WINMM_Reset(HWAVE hwave) > first->dwFlags &= ~WHDR_INQUEUE; > first->dwFlags |= WHDR_DONE; > if(is_out) > - WINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > else > - WINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > first = next; > } > > @@ -2774,7 +2855,7 @@ MMRESULT WINAPI waveOutOpen(LPHWAVEOUT lphWaveOut, UINT uDeviceID, > cb_info.user = dwInstance; > cb_info.hwave = info.handle; > > - WINMM_NotifyClient(&cb_info, WOM_OPEN, 0, 0); > + pWINMM_NotifyClient(&cb_info, WOM_OPEN, 0, 0); > > return res; > } > @@ -2802,7 +2883,7 @@ UINT WINAPI waveOutClose(HWAVEOUT hWaveOut) > res = SendMessageW(g_devices_hwnd, WODM_CLOSE, (WPARAM)hWaveOut, 0); > > if(res == MMSYSERR_NOERROR) > - WINMM_NotifyClient(&cb_info, WOM_CLOSE, 0, 0); > + pWINMM_NotifyClient(&cb_info, WOM_CLOSE, 0, 0); > > return res; > } > @@ -3410,7 +3491,7 @@ MMRESULT WINAPI waveInOpen(HWAVEIN* lphWaveIn, UINT uDeviceID, > cb_info.user = dwInstance; > cb_info.hwave = info.handle; > > - WINMM_NotifyClient(&cb_info, WIM_OPEN, 0, 0); > + pWINMM_NotifyClient(&cb_info, WIM_OPEN, 0, 0); > > return res; > } > @@ -3438,7 +3519,7 @@ UINT WINAPI waveInClose(HWAVEIN hWaveIn) > res = SendMessageW(g_devices_hwnd, WIDM_CLOSE, (WPARAM)hWaveIn, 0); > > if(res == MMSYSERR_NOERROR) > - WINMM_NotifyClient(&cb_info, WIM_CLOSE, 0, 0); > + pWINMM_NotifyClient(&cb_info, WIM_CLOSE, 0, 0); > > return res; > } > @@ -3586,7 +3667,7 @@ UINT WINAPI waveInStop(HWAVEIN hWaveIn) > if(buf){ > buf->dwFlags &= ~WHDR_INQUEUE; > buf->dwFlags |= WHDR_DONE; > - WINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)buf, 0); > + pWINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)buf, 0); > } > > return MMSYSERR_NOERROR; > diff --git a/dlls/winmm/winemm.h b/dlls/winmm/winemm.h > index d7bab0f..10cd0f4 100644 > --- a/dlls/winmm/winemm.h > +++ b/dlls/winmm/winemm.h > @@ -151,6 +151,7 @@ void TIME_MMTimeStop(void) DECLSPEC_HIDDEN; > > MMRESULT WINMM_CheckCallback(DWORD_PTR dwCallback, DWORD fdwOpen, BOOL mixer) DECLSPEC_HIDDEN; > > +void WINMM_SetupCallback(void) DECLSPEC_HIDDEN; > void WINMM_DeleteWaveform(void) DECLSPEC_HIDDEN; > > /* Global variables */ > diff --git a/dlls/winmm/winmm.c b/dlls/winmm/winmm.c > index 0f3cd5d..358f139 100644 > --- a/dlls/winmm/winmm.c > +++ b/dlls/winmm/winmm.c > @@ -139,7 +139,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID fImpLoad) > > if (!WINMM_CreateIData(hInstDLL)) > return FALSE; > - > + WINMM_SetupCallback(); > break; > case DLL_PROCESS_DETACH: > if(fImpLoad) > -- > 2.9.3 > > >

2 8

Re: [PATCH 1/2] server: Store async list in process object and use that to find async in cansel_async request.
by Alexandre Julliard 01 Dec '16

01 Dec '16

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -614,6 +615,7 @@ static void process_destroy( struct object *obj ) > > /* we can't have a thread remaining */ > assert( list_empty( &process->thread_list )); > + assert( list_empty( &process->asyncs )); I don't think that this is guaranteed, I believe that there can still be asyncs in the queues of shared files. We'd probably need to clear them explicitly at process exit. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] iphlpapi: Ensure GetIpAddrTable returns loopback addresses in the end
by Alexandre Julliard 01 Dec '16

01 Dec '16

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Manually tested by other people in GNU/Linux and OSX, in every case > loopback was returned first while in all testbot Windows machines and > my Windows machines the loopback comes after everything. > > Fixes https://bugs.winehq.org/show_bug.cgi?id=40247 > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/iphlpapi/iphlpapi_main.c | 27 +++++++++++++++++++++------ > dlls/iphlpapi/tests/iphlpapi.c | 4 ++++ > 2 files changed, 25 insertions(+), 6 deletions(-) This breaks the tests here: ../../../tools/runtest -q -P wine -T ../../.. -M ws2_32.dll -p ws2_32_test.exe.so sock && touch sock.ok sock.c:2489: Tests skipped: SOCK_RAW is not supported sock.c:6947: Test failed: got 11002 expected WSAHOST_NOT_FOUND sock.c:6948: Test failed: expected 11001, got 11002 sock.c:7197: Test failed: got 11002 expected WSAHOST_NOT_FOUND sock.c:7198: Test failed: expected 11001, got 11002 sock.c:8648: Tests skipped: Cannot test SIO_ADDRESS_LIST_CHANGE, interactive tests must be enabled Makefile:208: recipe for target 'sock.ok' failed make: *** [sock.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] winspool.drv: Clear last error when creating mutex
by Alexandre Julliard 01 Dec '16

01 Dec '16

"A. Wilcox" <AWilcox(a)Wilcox-Tech.com> writes: > A stale error may reside in thread-local storage that causes > WINSPOOL_LoadSystemPrinters to believe initialisation has already > occurred. CreateMutex always sets last error, so this can't make any difference. There must be something else going on. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winmm: Use a thread to send driver messages on Win9x
by Nikolay Sivov 01 Dec '16

01 Dec '16

On Thu, 1 Dec 2016 04:40:22 -0200 Bruno Jesus <00cpxxx(a)gmail.com> wrote: > More detailed explanation in the patch comments. Basically the games use a DLL that calls SuspendThread from inside the WinMM callback, this makes the program hang as we use the "main thread" to dispatch callbacks. > > Games tested in Win95 config: > Heroes of Might & Magic (well known affected) > Deadlock (well known affected) > Worms 2 (just to ensure things still work) > Age of Empires (just to ensure things still work) > Shivers (just to ensure things still work) > > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=3930 > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/winmm/waveform.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 76 insertions(+), 2 deletions(-) > > diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c > index 7308519..24d7e30 100644 > --- a/dlls/winmm/waveform.c > +++ b/dlls/winmm/waveform.c > @@ -134,6 +134,14 @@ struct _WINMM_MMDevice { > WINMM_Device *devices[MAX_DEVICES]; > }; > > +static struct { > + BOOL is, checked; > + HANDLE thread, event_main, event_thread; > + WINMM_CBInfo *info; > + WORD msg; > + DWORD_PTR param1, param2; > +} win9x; > + > static WINMM_MMDevice *g_out_mmdevices; > static WINMM_MMDevice **g_out_map; > static UINT g_outmmdevices_count; > @@ -286,6 +294,13 @@ static WINMM_Device *WINMM_FindUnusedDevice(WINMM_Device **devices, > { > UINT i; > > + if (!win9x.checked) > + { > + win9x.checked = TRUE; > + if ((GetVersion() & 0xFF) < 5) > + win9x.is = TRUE; > + } > + This only needs to happen during dll initialization. I think cleaner way for a change you're proposing will be two separate vtable structures, one for win9x and another one for the rest. This way you can select appropriate vtable once on dll initialization, and keep this selection forever as a global pointer for example. > /* Note: NotifyClient should never be called while holding the device lock > * since the client may call wave* functions from within the callback. */ > static inline void WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > DWORD_PTR param2) > { > - DriverCallback(info->callback, info->flags, (HDRVR)info->hwave, > - msg, info->user, param1, param2); > + if (win9x.is) > + { > > HeapFree(GetProcessHeap(), 0, device->orig_fmt); > + if (win9x.thread) > + { > + /* warn the thread so it can die gracefully */ > + win9x.info->hwave = 0; > + SetEvent(win9x.event_thread); > + > + CloseHandle(win9x.event_main); > + CloseHandle(win9x.event_thread); > + CloseHandle(win9x.thread); > + win9x.event_main = win9x.event_thread = win9x.thread = NULL; > + } > > return S_OK; > } This will also let you to get rid of conditional implementation like above.

1 0

Re: [PATCH] winmm: Use a thread to send driver messages on Win9x
by Dmitry Timoshkov 01 Dec '16

01 Dec '16

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > + if ((GetVersion() & 0xFF) < 5) > + win9x.is = TRUE; A more correct check for win9x would be if ((GetVersion() & 0x80000000) win9x.is = TRUE; -- Dmitry.

1 0

wine-1.8.6-rc1 Available
by Michael Stefaniuc 30 Nov '16

30 Nov '16

Hello guys, I have pushed wine-1.8.6-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ After introducing a regression into 1.8.5 I got a little bit risk averse so just 51 cherry-picks this time. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. But that might change as I'm travelling at the moment. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Fix a regression introduced in 1.8.5 (#41627) - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.6 (total 35): 27671 ComboFix fails to install 29661 wineboot unable to create win32 prefix if the directory already exists 29916 ElsterFormular cannot make use of default PDF viewer (e. g. Okular) 30368 AMD Radeon 6480g detected as ATI Radeon 3200 30673 Smart Cutter 1.9.4 crashes when the button OPEN is pressed 32694 NVIDIA GTX 690 not in the list of recognized cards. 33636 wine cmd: invalid behaviour of '&' operator 35025 Max Payne 2 Demo: checkboxes in options dialog have missing window styles 35658 Anthem Room Correction 2 v1.0.1 reports 'Unknown COM error 0x80004001' (needs IAudioEndpointVolume::GetVolumeRange method implementation) 36101 Wow Hangs at login screen when coming from battle.net launcher (only with gxapi Opengl) 39447 Unimplemented function hid.dll.HidP_TranslateUsagesToI8042ScanCodes 39734 ProtectDisc Driver 11: acedrv11.sys crashes 40448 Final Fantasy XI: Missing character models, potential black screen and crashes 40540 ReadIntervalTimeout is ignored if there is data in the buffer when ReadFile is called and no data arrives after that 40746 Microsoft Expression Web 4 crashes when opening site, needs rpcrt4.dll.NdrAsyncServerCall 40861 Kingsoft Office 2012 needs ntoskrnl.exe.IoAttachDevice 40999 Epic Games Launcher needs ws2_32.InetNtopW 41021 Zombie Army trilogy needs msvcr100.dll._fpieee_flt 41050 Age of Mythology: Extended Edition needs api-ms-win-crt-stdio-l1-1-0.dll.__stdio_common_vswscanf 41090 Multiple games (Starcraft 2, UE4 games) require vcruntime140.dll.__intrinsic_setjmp 41142 gcc6: server build warnings 41224 WineD3D8 crashes on Windows with GTAVC and i915-class video 41284 dbghelp_dwarf: parse_cie_details unknown CIE version 4 (clang/mesa/valgrind) 41308 iconfig.exe needs msvcr120.??0_Condition_variable@details@Concurrency@@QAE@XZ 41343 Ellisys Visual USB needs unimplemented function newdev.dll.DiInstallDriverA 41389 ComboFix fails to install: complains about missing HKLM\System\CurrentControlSet\Control\hivelist 41405 Hornbill Supportworks Client 7.6.0: crashes with ExtFloodFill when open 'Incident Details' pane 41428 The Forest: Terminal gets spammed with errors if Steam is running 41570 Xenia emulator needs unimplemented function api-ms-win-core-rtlsupport-l1-1.RtlLookupFunctionEntry called in 64-bit code 41602 Videos do not play in Age of Empires 41627 MS Word 2010 crash when exiting on Wine stable 1.8.5. 41640 add rx 480 into directx.c 41642 S3CC921 programmer app needs ntoskrnl.exe.KeSetTimerEx 41651 WScript object name on wine is case sensitive which should not be the case (vbscript) 41705 Build fails in dpnet: redefinition of typedef 'SOCKADDR' ---------------------------------------------------------------- Changes since 1.8.5: Alex Henrie (1): ntdll: Skip synchronous read if a serial read interval timeout is set. Alexandre Julliard (2): server: Avoid some compiler warnings when EWOULDBLOCK == EAGAIN. ntdll: Add a helper function for registering a file read async I/O. Alistair Leslie-Hughes (2): comdlg32/tests: Test when a directory is passed to OpenFileName Dialog. dpnet: Header files cleanup. Andrew Eikum (1): mmdevapi: Implement IAudioEndpointVolume::GetVolumeRange. Andrew Kanaber (1): wined3d: Add id for Broadwell Xeon E3 GPU. Andrey Gusev (1): user32: Add support for WS_EX_RIGHT style. André Hentschel (1): loader/wine.inf: Open pdf files using winebrowser. Aric Stewart (1): hid: Stub HidP_TranslateUsagesToI8042ScanCodes. Austin English (5): wine.inf: Add HKLM\System\CurrentControlSet\Control\hivelist key. newdev: Add DiInstallDriverA/W stubs. api-ms-win-core-rtlsupport-l1-1-0: Add missing forwards. ntoskrnl.exe: Add IoAttachDevice stub. ntoskrnl.exe: Add KeSetTimerEx stub. Bernhard Übelacker (1): ntoskrnl.exe: Make IoAllocateIrp not crash on negative values. Bruno Jesus (3): xinput1_3: Prefer builtin DLL. comdlg32: Avoid crash when a path is passed into Open File Dialog. msvfw32/tests: Add tests for ICInfo(). Carlos Rafael Ramirez (1): cmd: When 'if' condition is not met, ignore the next commands in the list. Daniel Lehman (2): ucrtbase: Add __stdio_common_vfwprintf. ucrtbase: Add __stdio_common_vfwscanf. Filip Frąckiewicz (5): wined3d: Add NVIDIA GTX 690 (GK104) to the GPU list. wined3d: Add AMD Radeon HD 6480G IGP. wined3d: Add NVIDIA GTX 980 Ti. wined3d: Add NVIDIA GTX 675MX to the GPU list. wined3d: Add NVIDIA GTX 760 Ti to the GPU list. Grazvydas Ignotas (1): wined3d: Add Polaris GPUs and their driver. Huw D. M. Davies (3): ucrtbase: Add __stdio_common_vswscanf(). gdi32: Check that ExtFloodFill()'s initial co-ordinates lie within the dib. fonts: Fix typo in glyph name. Jacek Caban (4): msctf: Don't call ITextStoreACP::UnadviseSink in context destructor. msctf: Added Push/Pop context tests. vbscript: Call GetItemInfo() with original item name. secur32: Use %LATEST_RECORD_VERSION gnutls priority. Józef Kucia (1): wined3d: Improve advertized driver version for Windows 10. Matteo Bruni (2): wined3d: Recognize a couple of Haswell / Broadwell GPUs on macOS. wined3d: Add a bunch of Broadwell and Skylake PCI ids and descriptions. Michael Müller (2): ntdll: Open current working directory with FILE_TRAVERSE access. msvfw32: Use case insensitive compare in ICInfo for fourcc codes. Nikolay Sivov (3): dbghelp: Support CIE version 4 in parse_cie_details(). rpcrt4: Added NdrAsyncServerCall stub. ucrtbase: Fix some spec file entries. Philipp Hoppermann (1): ws2_32: Implement InetNtopW. Piotr Caban (5): ucrtbase: Add __intrinsic_setjmp implementation. msvcrt: Add _fpieee_flt stub. msvcrt: Support fdiv m64fp in i386 _fpieee_flt. msvcr110: Add Concurrency::details::_Condition_variable class stub. msvcr120: Add _Condition_variable implementation. Ruslan Kabatsayev (1): wined3d: Initialise p_wglGetPixelFormat when USE_WIN32_OPENGL is defined. Sebastian Lackner (1): server: Allow to create win32 prefix when directory already exists. -- Michael Stefaniuc mstefani(a)winehq.org

1 0

Re: [PATCH 8/9] d3d10core/tests: Add test for two sided stencil.
by Henri Verbeet 30 Nov '16

30 Nov '16

On 30 November 2016 at 12:47, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + ds_desc.FrontFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilFunc = D3D10_COMPARISON_NEVER; > + ds_desc.BackFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilFunc = D3D10_COMPARISON_ALWAYS; It's fine for a start, but note that this test doesn't do much for front/back stencil ops. Also, fwiw, in d3d9:visual there's stencil_cull_test() that's similar.

1 0

Re: [PATCH 03/10] server: Use async object to transfer IRP result to client.
by Alexandre Julliard 30 Nov '16

30 Nov '16

Jacek Caban <jacek(a)codeweavers.com> writes: > diff --git a/server/file.h b/server/file.h > index c0a53a2..75a2e03 100644 > --- a/server/file.h > +++ b/server/file.h > @@ -53,6 +53,8 @@ struct fd_ops > void (*reselect_async)( struct fd *, struct async_queue *queue ); > /* cancel an async operation */ > int (*cancel_async)(struct fd *, struct process *process, struct thread *thread, client_ptr_t iosb); > + /* find an async operation in queues */ > + struct async *(*find_async)( struct fd *fd, struct process *process, client_ptr_t client_async ); > }; I think a per-process list of async/iosb would make more sense. There should be nothing file type specific about finding an async. It could probably be used to get rid of cancel_async() too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Github mirror seems to be out-of-sync
by Akihiro Sagawa 30 Nov '16

30 Nov '16

Source code admin, Official Github mirror, https://github.com/wine-mirror/wine, seems to be not updated for a few days. Could you take a look? Thanks in advance. Akihiro Sagawa

2 2

Re: [resend] fusion: Avoid buffer overflow in enum_gac_assemblies.
by Alexandre Julliard 29 Nov '16

29 Nov '16

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > [ Marvin indicated testing went fine, and I did not see any feedback > for two weeks. Only the description below has changed a little. ] > > In enum_gac_assemblies we have the following > > sprintf(buf, ", Version=%s, Culture=%s, PublicKeyToken=%s", > ffd.cFileName, culture, ptr); > > culture is declared as char[MAX_PATH], and WIN32_FIND_DATAA.cFileName > is CHAR[260], so a mere size of MAX_PATH for the output buffer buf is > not sufficient. > > (We need to double sizeof(ffd.cFileName) since ptr also points > into it.) They all point into the same path, so the total size is not going to exceed MAX_PATH (modulo the additionally printed chars). And it doesn't make sense to fix this buffer but not the other ones, you are just moving the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Serial port sniffing problem
by Christopher Harrington 29 Nov '16

29 Nov '16

(copying list again, below edited for brevity) On Tue, Nov 29, 2016 at 12:39 PM Bill Lionheart <billlionheart(a)gmail.com> wrote: > $ ls -Fl > lrwxrwxrwx 1 bill bill 10 May 11 2014 c: -> ../drive_c/ > lrwxrwxrwx 1 bill bill 12 Jan 6 2016 com1 -> /dev/ttyUSB0 > > $ id -a > uid=1001(bill) gid=1001(bill) > groups=1001(bill),20(dialout) > $ ls -l /dev/ttyUSB0 > crw-rw---- 1 root dialout 188, 0 Nov 29 18:27 /dev/ttyUSB0 > > > All of this definitely looks correct. Here are a couple more suggestions: 1. Try creating a brand new wine prefix. Yours certainly has a beard on it and there may be artifacts of older copies of Wine that could be impacting your testing. Anyway, this essentially would look like moving ~/.wine to somewhere else, installing your test application again, and re-creating your com1 file in dosdevices/. You can always move your .wine directory back if it has important stuff in it. 2. See if using a more current version of Wine improves anything. You say you're on Wine 1.8; if you could be more specific (try running wine --version) that might give someone a lightbulb. 3. Crossover from Codeweavers is appallingly affordable if you haven't looked into that yet, and it comes with professional support. Anyway, wine-devel is more for discussion of development of Wine itself, not a support forum. What you're probably looking for is wine-users. I'm not subscribed to wine-users, so I can't copy your email there, but you can subscribe here: https://www.winehq.org/mailman/listinfo/wine-users Good luck. > > On 29 November 2016 at 17:57, Christopher Harrington > <ironiridis+winehq(a)gmail.com> wrote: > > On Tue, Nov 29, 2016 at 1:22 AM Bill Lionheart <billlionheart(a)gmail.com> > > wrote: > >> > >> Using Wine version 1.8 on Ubuntu 14.04.5 > >> I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a > >> serial interface. The device is supplied with a Prolific USB serial > >> converter which comes up as /dev/ttyUSB0 which > >> I have sym linked to COM1 > > > > > > Can you please cd into your dosdevices folder and run this command? > > > > ls -Fl > > > > (that's an uppercase F and a lowercase L) > > > > Then we will also need to see permissions of the serial device, so run > this: > > > > ls -l /dev/ttyUSB0 > > > > That's a lowercase L again... and run this too: > > > > id -a > > > > With all this info we can rule out a couple problems, chief among them: > > 1. Is the symlink named correctly and actually pointing to something that > > exists > > 2. Do you actually have permissions to access the serial port > > > > If you provide the output of all three of these commands, we should be > able > > to help. > > > > -Chris > > > >> > >> > > > > > > -- > Professor of Applied Mathematics > University of Manchester > http://www.maths.manchester.ac.uk/bl >

1 0

Re: [PATCH v2] ws2_32/tests: Add IDN resolution tests for GetAddrInfoW
by Marvin 29 Nov '16

29 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26981 Your paranoid android. === w7u (32 bit sock) === sock.c:8270: Test failed: Overlapped TransmitFile failed. sock.c:8272: Test failed: Overlapped TransmitFile sent an unexpected number of bytes (219 != 209).

1 0

Re: [PATCH 9/9] d3d11/tests: Add test for typed UAV loads.
by Henri Verbeet 29 Nov '16

29 Nov '16

On 29 November 2016 at 12:06, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 326 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 326 insertions(+) > This fails for me on Windows: d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 5: Got 0x00000010, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 3).

2 1

Re: [PATCH 4/5] d3d11/tests: Add test for shader input register limits.
by Henri Verbeet 29 Nov '16

29 Nov '16

On 25 November 2016 at 12:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The "ps_many_resources_code" shader bytecode is very big because texture > resources cannot be indexed and the loop is unrolled. > > --- > dlls/d3d11/tests/d3d11.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 221 insertions(+) > This doesn't work here. In particular: fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #5: fixme:d3d_shader:print_glsl_info_log error: Too many fragment shader texture samplers ... fixme:d3d:context_bind_shader_resources Shader 0x18bb10 needs 21 samplers, but only 16 are supported.

2 3

Re: [PATCH] ws2_32/tests: Add IDN resolution test for GetAddrInfoW
by Alexandre Julliard 29 Nov '16

29 Nov '16

Bruno Jesus <00cpxxx(a)gmail.com> writes: > I'm using €.linux.it because I could not find any standard domain name > for validation. Maybe winehq.org could have a IDN sub-domain name to > test. I created テスト.winehq.org for this purpose. > Also instead of broken'ing every test to catch Windows <= 7 I'm > skipping before, so real failures are not lost due to broken covering > them in Win >= 8. I still think it's better to avoid version checks. You can do broken() on the first test and skip the others if you detect the Win 7 behavior. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32/tests: Add some uuids present on Windows 10.
by Nikolay Sivov 29 Nov '16

29 Nov '16

On 29.11.2016 16:43, Huw Davies wrote: > +DEFINE_GUID(IID_UnknownInterface22, 0x42f85136, 0xdb7e, 0x439c, 0x85,0xf1, 0xe4,0x07,0x5d,0x13,0x5f,0xc8); This one is IID_IFileDialog.

2 1

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Nikolay Sivov 29 Nov '16

29 Nov '16

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > Since put_ProcessImageFileName appears to validate the image name that is > supplied, the normal put/get/compare was excluded because it returned > E_INVALIDARG even for a fully qualified filename. An investigation for another > day. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/tests/Makefile.in | 2 +- > dlls/hnetcfg/tests/policy.c | 32 +++++++++++++++++++++++++++++++- > 2 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/tests/Makefile.in b/dlls/hnetcfg/tests/Makefile.in > index aa4062a..5e1ce91 100644 > --- a/dlls/hnetcfg/tests/Makefile.in > +++ b/dlls/hnetcfg/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = hnetcfg.dll > -IMPORTS = ole32 uuid > +IMPORTS = ole32 uuid oleaut32 > > C_SRCS = \ > policy.c > diff --git a/dlls/hnetcfg/tests/policy.c b/dlls/hnetcfg/tests/policy.c > index a3ed4b2..a05b02e 100644 > --- a/dlls/hnetcfg/tests/policy.c > +++ b/dlls/hnetcfg/tests/policy.c > @@ -65,6 +65,36 @@ static void test_interfaces(void) > INetFwMgr_Release(manager); > } > > +static void test_NetFwAuthorizedApplication(void) > +{ > + INetFwAuthorizedApplication *app; > + HRESULT hr; > + > + hr = CoCreateInstance(&CLSID_NetFwAuthorizedApplication, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > + &IID_INetFwAuthorizedApplication, (void**)&app); > + ok(hr == S_OK, "got: %08x\n", hr); > + if(hr == S_OK) > + { It's not really necessary to protect it like that. If creation consistently fails test or all tests should be skipped. > + static WCHAR empty[] = {0}; > + BSTR bstr; > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, NULL); > + ok(hr == E_POINTER, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, &bstr); > + ok(hr == S_OK, "got: %08x\n", hr); > + ok(!bstr, "got: %s\n", wine_dbgstr_w(bstr)); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, NULL); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, empty); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); Please use actual BSTR here. > + > + INetFwAuthorizedApplication_Release(app); > + } > +} > + > START_TEST(policy) > { > INetFwMgr *manager; > @@ -84,7 +114,7 @@ START_TEST(policy) > INetFwMgr_Release(manager); > > test_interfaces(); > - > + test_NetFwAuthorizedApplication(); > > CoUninitialize(); > } >

1 0

Re: [v2 PATCH 1/2] hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Nikolay Sivov 29 Nov '16

29 Nov '16

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > From: Michael Müller <michael(a)fds-team.de> > > v2: > Corrected error return values. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/apps.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/apps.c b/dlls/hnetcfg/apps.c > index 2b8d78c..a89e6a7 100644 > --- a/dlls/hnetcfg/apps.c > +++ b/dlls/hnetcfg/apps.c > @@ -38,6 +38,7 @@ typedef struct fw_app > { > INetFwAuthorizedApplication INetFwAuthorizedApplication_iface; > LONG refs; > + BSTR filename; > } fw_app; > > static inline fw_app *impl_from_INetFwAuthorizedApplication( INetFwAuthorizedApplication *iface ) > @@ -60,6 +61,7 @@ static ULONG WINAPI fw_app_Release( > if (!refs) > { > TRACE("destroying %p\n", fw_app); > + if (fw_app->filename) SysFreeString( fw_app->filename ); There's no need for this check. > HeapFree( GetProcessHeap(), 0, fw_app ); > } > return refs; > @@ -252,7 +254,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_POINTER; > + > + if (!This->filename) > + { > + *imageFileName = NULL; > + return S_OK; > + } > + > + *imageFileName = SysAllocString( This->filename ); > + return *imageFileName ? S_OK : E_OUTOFMEMORY; > } You can reduce this to --- *imageFileName = SysAllocString( This->filename ); return *imageFileName || !This->filename ? S_OK : E_OUTOFMEMORY; --- > > static HRESULT WINAPI fw_app_put_ProcessImageFileName( > @@ -262,7 +275,12 @@ static HRESULT WINAPI fw_app_put_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %s\n", This, debugstr_w(imageFileName)); > - return S_OK; > + > + if (!imageFileName || !imageFileName[0]) > + return E_INVALIDARG; > + > + This->filename = SysAllocString( imageFileName ); > + return This->filename ? S_OK : E_OUTOFMEMORY; > } What happens if you call put_ProcessImageFileName() repeatedly?

1 0

Re: hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Alistair Leslie-Hughes 29 Nov '16

29 Nov '16

On 24/11/16 07:22, Bruno Jesus wrote: > From: Michael Müller <michael(a)fds-team.de> > > Manually tested using vbscript. > > @@ -250,7 +252,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_INVALIDARG; The return value here is incorrect. I've sent an updated patch+tests to wine-patches Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Marvin 29 Nov '16

29 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26959 Your paranoid android. === wxppro (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === w2003std (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === wvistau64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w2008s64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7u (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7pro64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w8 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w864 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w1064 (32 bit policy) === policy.c:92: Test failed: got: 80070003

1 0

Re: [PATCH] wincodecs: Trigger conversion to target format in WriteSource()
by Dmitry Timoshkov 28 Nov '16

28 Nov '16

Vincent Povirk <madewokherd(a)gmail.com> wrote: > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Does this even fix a real application? What exactly this patch is supposed to fix? -- Dmitry.

1 0

Re: [v3] cmd/tests: chaining rules of pipe and else
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26946 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Undocumented function prototype
by Marco Savelli 28 Nov '16

28 Nov '16

Hi everybody! I'm new to this list. I found this page (in deutsch) which seems to document an otherwise undocumented function, namely GetPermLayers from aphelp.dll. I don't know where they got it, but seems a realistic definition. Hope it helps. And thanks for your development effort, go on this way! :D P.S. It' in delphi, there's a "var" keyword, which should means (from google, I'm not a delphist) an optional argument. IDA PRO gives error when given the last two args. Hope you can figure out where's the problem

3 4

Re: [PATCH 3/3] wintrust/tests: Remove a test that crashes on Windows 8 amd 10.
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26944 Your paranoid android. === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001

1 0

Re: [PATCH 2/3] wintrust/tests: Initialize the pSigState member to prevent Windows 8 and 10 from crashing.
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26943 Your paranoid android. === w8 (32 bit softpub) === softpub: unhandled exception c0000005 at 7511A63B === w864 (32 bit softpub) === softpub: unhandled exception c0000005 at 7772A63B === w1064 (32 bit softpub) === softpub: unhandled exception c0000005 at 768B0B90 === w864 (64 bit softpub) === softpub: unhandled exception c0000005 at 00007FFB7AFF9B8F === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001 softpub: unhandled exception c0000005 at 00007FFC77A7F593

1 0

Re: [2/5] strmbase: Add validation checks when updating source rectangle.
by Andrew Eikum 28 Nov '16

28 Nov '16

On Sun, Nov 20, 2016 at 03:33:22PM +0900, Akihiro Sagawa wrote: > @@ -53,6 +53,26 @@ HRESULT WINAPI BaseControlVideo_Destroy(BaseControlVideo *pControlVideo) > return BaseDispatch_Destroy(&pControlVideo->baseDispatch); > } > > +static HRESULT BaseControlVideoImpl_CheckSourceRect(BaseControlVideo *This, RECT *pSourceRect) > +{ > + LONG VideoWidth, VideoHeight; > + HRESULT hr; > + > + if (pSourceRect->top < 0 || pSourceRect->left < 0 || > + pSourceRect->top >= pSourceRect->bottom || > + pSourceRect->left >= pSourceRect->right) > + return E_INVALIDARG; I'm not opposed to spelling it out, but you could use IsRectEmpty() here instead. > + > + hr = BaseControlVideoImpl_GetVideoSize((IBasicVideo *)This, &VideoWidth, &VideoHeight); > + if (FAILED(hr)) > + return hr; > + > + if (pSourceRect->bottom > VideoHeight || pSourceRect->right > VideoWidth) > + return E_INVALIDARG; > + Shouldn't these use (bottom - top) and (right - left)? Andrew

2 2

Do we delete spammers accounts from bugzilla?
by Bruno Jesus 28 Nov '16

28 Nov '16

Today we had one more piece of spam, the bot registered the account a few moments before creating a bug. In this case should we use bugzilla's admin features to delete the user? Best wishes, Bruno

3 3

Re: [v2] cmd/tests: chaining rules of pipe and else
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26937 Your paranoid android. === wxppro (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w2003std (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w7u (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w7pro64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w8 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w864 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w1064 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w7pro64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w864 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w1064 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]')

1 0

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Lauri Kenttä 26 Nov '16

26 Nov '16

Testbot reports a failure on Vista, but that is not related to my patch. -- Lauri Kenttä

1 0

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Marvin 26 Nov '16

26 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26929 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: [PATCH v2 2/5] d3d9/tests: Add test for occlusion query with result bigger than UINT32_MAX.
by Marvin 25 Nov '16

25 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26917 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: ntdll/tests: The fpu exception offset is broken on 32-bit Windows 8 too.
by Marvin 25 Nov '16

25 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26914 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x2e0000/0x2e0001 exception: unhandled exception 80000004 at 002E0000 exception.c:551: Test failed: 42: Unexpected eip 0x77baed97/0x2e0001 === w7u (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x300000/0x300001 exception: unhandled exception 80000004 at 00300000 exception.c:551: Test failed: 42: Unexpected eip 0x77cde34f/0x300001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH] winspool: Use all Fields from DRIVER_INFO_8A when we add a Printer Driver.
by Huw Davies 25 Nov '16

25 Nov '16

On Fri, Nov 25, 2016 at 12:49:40AM +0100, Detlef Riekenberg wrote: > + if ((Level > 7) && diA->pszzColorProfiles) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, NULL, 0); > + diW.pszzColorProfiles = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, diW.pszzColorProfiles, len); > + } This is a 'multi-sz' string, so you need the same handling as 'pDependentFiles' here. > + if ((Level > 7) && diA->pszInfPath) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, NULL, 0); > + diW.pszInfPath = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, diW.pszInfPath, len); > + } > + > + if ((Level > 7) && diA->pszzCoreDriverDependencies) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, NULL, 0); > + diW.pszzCoreDriverDependencies = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, diW.pszzCoreDriverDependencies, len); > + } The same goes for pszzCoreDriverDependencies. > if (Level > 7) { > - FIXME("level %u is incomplete\n", Level); > + diW.dwPrinterDriverAttributes = diA->dwPrinterDriverAttributes; > + diW.ftMinInboxDriverVerDate = diA->ftMinInboxDriverVerDate; > + diW.dwlMinInboxDriverVerVersion = diA->dwlMinInboxDriverVerVersion; > } > > res = AddPrinterDriverExW(nameW, Level, (LPBYTE) &diW, dwFileCopyFlags); > @@ -7018,6 +7061,11 @@ BOOL WINAPI AddPrinterDriverExA(LPSTR pName, DWORD Level, LPBYTE pDriverInfo, DW You're leaking pHelpFile. > HeapFree(GetProcessHeap(), 0, diW.pszOEMUrl); > HeapFree(GetProcessHeap(), 0, diW.pszHardwareID); > HeapFree(GetProcessHeap(), 0, diW.pszProvider); > + HeapFree(GetProcessHeap(), 0, diW.pszPrintProcessor); > + HeapFree(GetProcessHeap(), 0, diW.pszVendorSetup); > + HeapFree(GetProcessHeap(), 0, diW.pszzColorProfiles); > + HeapFree(GetProcessHeap(), 0, diW.pszInfPath); > + HeapFree(GetProcessHeap(), 0, diW.pszzCoreDriverDependencies); > > TRACE("=> %u with %u\n", res, GetLastError()); > return res;

1 0

Re: 2 of 13 [PATCH] po: Update Simplified Chinese translation (v3).
by Jactry Zeng 24 Nov '16

24 Nov '16

This looks good to me. Thanks for your contribution! 2016-11-23 0:09 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 1202 ++++++++++++++++++++++++++++++ > ++++------------------------- > 1 file changed, 687 insertions(+), 515 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 1/2] shlwapi: Remove dot segments for URLs starting with /
by Jacek Caban 24 Nov '16

24 Nov '16

Hi Daniel, On 24.11.2016 00:44, Daniel Lehman wrote: > diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c > index 879a734..5de9076 100644 > --- a/dlls/shlwapi/url.c > +++ b/dlls/shlwapi/url.c > @@ -372,6 +372,9 @@ HRESULT WINAPI UrlCanonicalizeW(LPCWSTR pszUrl, LPWSTR pszCanonicalized, > dwFlags |= URL_ESCAPE_UNSAFE; > state = 5; > is_file_url = TRUE; > + } else if(url[0] == '/') { > + state = 2; Wouldn't state 5 be more appropriate? > + is_file_url = TRUE; It would be interesting to have tests using URL_WININET_COMPATIBILITY and URL_FILE_USE_PATHURL flags. is_file_url usually affects slashes conversion in such cases, but you set it too late to take such effect. It may be right, but tests would be nice. Thanks, Jacek

1 0

Re: [PATCH 04/11] wined3d: Introduce wined3d_device_set_unordered_access_view().
by Henri Verbeet 24 Nov '16

24 Nov '16

On 23 November 2016 at 14:36, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + FIXME("Unordered access view unsupported yet (layers %u-%u).\n", > + desc->u.texture.layer_idx, desc->u.texture.layer_count); I don't think you can do that in English. You'd either have "UAV unsupported" or "UAV not supported yet". In the specific case here, I'd probably use something like "Unsupported layer selection %u+%u.\n" or something along those lines though.

1 0

Re: [PATCH] d2d1: Implement retrieving dash pattern data for stroke styles
by Henri Verbeet 24 Nov '16

24 Nov '16

On 23 November 2016 at 18:09, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 count) > +static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 dash_count) > { > - FIXME("iface %p, dashes %p, count %u stub!\n", iface, dashes, count); > + struct d2d_stroke_style *style = impl_from_ID2D1StrokeStyle(iface); > + > + TRACE("iface %p, dashes %p, count %u.\n", iface, dashes, dash_count); > + > + memcpy(dashes, style->dashes, min(style->dash_count, dash_count) * sizeof(*dashes)); > + if (dash_count > style->dash_count) > + memset(dashes, 0, (dash_count - style->dash_count) * sizeof(*dashes)); That doesn't look right.

2 2

Re: [PATCH v2] msvcrt: Add _lfind_s
by Piotr Caban 24 Nov '16

24 Nov '16

Hi Daniel, it fails to compile: ../../tools/winegcc/winegcc -o api-ms-win-crt-utility-l1-1-0.dll.so -B../../tools/winebuild -m32 -fasynchronous-unwind-tables -shared ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec \ ../../libs/port/libwine_port.a ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec:6: function '_lfind_s' not defined winegcc: ../../tools/winebuild/winebuild failed Makefile:166: recipe for target 'api-ms-win-crt-utility-l1-1-0.dll.so' failed make[1]: *** [api-ms-win-crt-utility-l1-1-0.dll.so] Error 2 Thank you, Piotr

1 0

Wineconf wrap up
by Jeremy White 24 Nov '16

24 Nov '16

Hi Folks, I thought I would take a minute to write a summary of the events of the weekend, and that start a thread where others could chime in. It was a great event; a traditional wineconf with cheer and conversations, and even sometimes productive meetings. Here were our working notes for the weekend: https://www.winehq.org/~jwhite/wineconf_2016.pdf The plan for next year is to have the Wine conference in Poland next fall. We are going to try to broaden our reach; inviting users and others to come to the conference as well. Aric is going to try to help coordinate that structural growth. Mechanically, we did decide that the Google hangout was not intrusive, so we will likely try to repeat that next year. (We would like it to not require us to manually accept each person, if possible). Many others volunteered to help in a variety of ways; I did not take rigorous notes of this during the conference, so hopefully others will step forward with that information (or we'll all shame them into remembering <evil grin>). It was a joy to see you all! Cheers, Jeremy p.s. For my part, one key part is that we are going to attempt to make one or two of the Debian Jessie systems hosted here at CodeWeavers run make test to successful completion. We are going to accept the fact that we have several timing dependent tests; so 'success' is going to be something like the following: make test -o make test -o make test -o make test In a similar vein, we are going to try to establish a 'diffing' logic for the winetest bot. So if there are n failures that happen routinely, and a new patch arrives, so long as only those same failures remain, the patch will be considered suitable. The advantage to that approach is that we can also apply it to platforms such as the Mac, where we are no where close to running green. Michael will help Francois with this once he is done with his travels. I agreed to lock Francois and the d3d guys in the server room until we saw progress on the make test front; I think that was the sum total of what I volunteered to do.

4 5

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.
by Huw Davies 24 Nov '16

24 Nov '16

> On 21 Nov 2016, at 21:28, Alexandre Julliard <julliard(a)winehq.org> wrote: > > Module: wine > Branch: master > Commit: 8a4508cecc4a6e46da200c85aa7d62515041f6e2 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a4508cecc4a6e46da200c85a… > > Author: Donat Enikeev <donat(a)enikeev.net> > Date: Sat Nov 19 21:12:30 2016 +0300 > > crypt32/tests: Fix chain tests failure with cs.standford.edu certificates. > > Signed-off-by: Donat Enikeev <donat(a)enikeev.net> > Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> > > --- > > dlls/crypt32/tests/chain.c | 658 ++++++++++++++++++++++++--------------------- > 1 file changed, 352 insertions(+), 306 deletions(-) > > Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8a4508cecc4a6e46da200… Hi Donat, This has caused failures on some of Francois’ XP VMs. For example: http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-… Could you take a look? Thanks, Huw.

6 12

Re: [PATCH] wincodecs: Trigger conversion to target format in WriteSource()
by Dmitry Timoshkov 23 Nov '16

23 Nov '16

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > - if (!IsEqualGUID(&src_format, format)) > - { > - /* FIXME: should use WICConvertBitmapSource to convert */ > - ERR("format %s unsupported\n", debugstr_guid(&src_format)); > - return E_FAIL; > + hr = IWICBitmapFrameEncode_SetPixelFormat(iface, &src_format); > + if (FAILED(hr)) return hr; > } Despite the removing a questionable FIXME this part of the code won't do what you think it does. Besides, since there is no a single todo_wine removed with this patch adding a bunch of tests for different encoders is needed to show that the automatic conversion is really supposed to happen, and that it doesn't depend on the implementation detail in some of the encoders. According to my testing not every encoder does this kind of thing, especially when a conversion needs a palette. -- Dmitry.

2 2

Re: [PATCH] wincodecs: Recognize FilterOption property in PNG encoder
by Vincent Povirk 23 Nov '16

23 Nov '16

We should either set this option when encoding, or print a fixme. I think setting it is easy enough.

1 0

Re: [PATCH] quartz: Use straight assignments instead of CopyRect().
by Michael Stefaniuc 23 Nov '16

23 Nov '16

On 11/22/2016 08:01 PM, Hadrien Boizard wrote: > Signed-off-by: Hadrien Boizard <h.boizard(a)gmail.com> > --- > dlls/quartz/videorenderer.c | 8 ++++---- > dlls/quartz/vmr9.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > > 0001-quartz-Use-straight-assignments-instead-of-CopyRect.patch > > > diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c > index 61f08f5..6631ccd 100644 > --- a/dlls/quartz/videorenderer.c > +++ b/dlls/quartz/videorenderer.c > @@ -483,7 +483,7 @@ static const BaseWindowFuncTable renderer_BaseWindowFuncTable = { > static HRESULT WINAPI VideoRenderer_GetSourceRect(BaseControlVideo* iface, RECT *pSourceRect) > { > VideoRendererImpl *This = impl_from_BaseControlVideo(iface); > - CopyRect(pSourceRect,&This->SourceRect); > + *pSourceRect = This->SourceRect; NACK, this is not a no-op change. CopyRect() also checks for NULL rect pointers so it protects against NULL pSourceRect. With your change apps would crash if they do that. The proper fix is to add tests for NULL rects and return the proper error in those functions. Or at least add code like: if (!pSourceRect) return E_POINTER; No clue if Andrew Eikum is willing to accept that without tests. E_INVALIDARG would be also a plausible error code. bye michael

1 0

Re: user32/tests: Mark built-in wndproc auto-detection behaviour as broken on Windows 8 and 10.
by Dmitry Timoshkov 23 Nov '16

23 Nov '16

Huw Davies <huw(a)codeweavers.com> wrote: > + SendMessageW(hwnd, WM_GETTEXT, sizeof(buf) / sizeof(buf[0]), (LPARAM)buf); > + if (IsWindowUnicode(hwnd)) > + ok(memcmp(buf, unistring, sizeof(unistring)) == 0, "WM_GETTEXT invalid return\n"); > + else > + ok(memcmp(buf, unistring, sizeof(unistring)) != 0, "WM_GETTEXT invalid return\n"); This doesn't look right. SendMessageW(WM_GETTEXT) is supposed to always return a unicode string regardless of wheather IsWindowUnicode() is broken or not, otherwise a lot of applications would misbehave in weird ways. This needs further investigation. -- Dmitry.

2 7

Re: [PATCH 09/10] kernel32/tests: Added more named pipe tests.
by Marvin 23 Nov '16

23 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26858 Your paranoid android. === w864 (64 bit pipe) === pipe.c:2575: Test failed: FlushFileBuffers failed: 87 pipe.c:2575: Test failed: FlushFileBuffers failed: 87

1 0

Re: [PATCH] msvcrt: Add _lfind_s
by Piotr Caban 23 Nov '16

23 Nov '16

Hi, On 11/22/16 16:36, Daniel Lehman wrote: > dlls/msvcrt/misc.c | 26 +++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/tests/misc.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++++ Please also update other spec files. > + /* simple samples */ > + /* simple sample - not found */ Could you please also remove these comments? They are not very useful. Thank you, Piotr

1 0

Re: [08/23] wined3d: Allow viewport to be out-of-bounds if using offscreen target.
by Andrew Wesie 23 Nov '16

23 Nov '16

Assuming that viewport_test in d3d9/tests/visual.c is wrong only when render_offscreen is true, is there anyway to fix that test? Or should viewport_test be removed? The reason for the patch is that Overwatch renders to a 2D texture some UI elements. If the viewport is not what is expected, then the output is wrong (e.g. the UI elements are the wrong size or drawn at the wrong place on the texture). -Andrew On Sun, Nov 13, 2016 at 12:35 PM, Andrew Wesie <awesie(a)gmail.com> wrote: > Signed-off-by: Andrew Wesie <awesie(a)gmail.com> > --- > dlls/wined3d/state.c | 42 ++++++++++++++++++++++-------------------- > 1 file changed, 22 insertions(+), 20 deletions(-) > > diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c > index cd3763c..ed20e325 100644 > --- a/dlls/wined3d/state.c > +++ b/dlls/wined3d/state.c > @@ -4617,26 +4617,6 @@ static void viewport_miscpart(struct > wined3d_context *context, const struct wine > struct wined3d_viewport vp = state->viewport; > unsigned int width, height; > > - if (target) > - { > - if (vp.width > target->width) > - vp.width = target->width; > - if (vp.height > target->height) > - vp.height = target->height; > - > - wined3d_rendertarget_view_get_drawable_size(target, context, > &width, &height); > - } > - else if (depth_stencil) > - { > - width = depth_stencil->width; > - height = depth_stencil->height; > - } > - else > - { > - FIXME("No attachments draw calls not supported.\n"); > - return; > - } > - > gl_info->gl_ops.gl.p_glDepthRange(vp.min_z, vp.max_z); > checkGLcall("glDepthRange"); > /* Note: GL requires lower left, DirectX supplies upper left. This is > @@ -4644,7 +4624,29 @@ static void viewport_miscpart(struct > wined3d_context *context, const struct wine > if (context->render_offscreen) > gl_info->gl_ops.gl.p_glViewport(vp.x, vp.y, vp.width, vp.height); > else > + { > + if (target) > + { > + if (vp.width > target->width) > + vp.width = target->width; > + if (vp.height > target->height) > + vp.height = target->height; > + > + wined3d_rendertarget_view_get_drawable_size(target, context, > &width, &height); > + } > + else if (depth_stencil) > + { > + width = depth_stencil->width; > + height = depth_stencil->height; > + } > + else > + { > + FIXME("No attachments draw calls not supported.\n"); > + return; > + } > + > gl_info->gl_ops.gl.p_glViewport(vp.x, (height - (vp.y + > vp.height)), vp.width, vp.height); > + } > checkGLcall("glViewport"); > } > > -- > 2.7.4 > >

2 3

Re: [v2 1/3] wined3d: Implement return instruction.
by Józef Kucia 23 Nov '16

23 Nov '16

On Fri, Nov 18, 2016 at 6:46 AM, Andrew Wesie <awesie(a)gmail.com> wrote: > --- a/dlls/wined3d/shader.c > +++ b/dlls/wined3d/shader.c > @@ -2028,6 +2028,7 @@ void shader_generate_main(const struct wined3d_shader *shader, struct wined3d_st > struct wined3d_shader_tex_mx tex_mx; > struct wined3d_shader_context ctx; > const DWORD *ptr = byte_code; > + enum WINED3D_SHADER_INSTRUCTION_HANDLER last_opcode = WINED3DSIH_TABLE_SIZE; > > /* Initialize current parsing state. */ > tex_mx.current_row = 0; > @@ -2062,6 +2063,16 @@ void shader_generate_main(const struct wined3d_shader *shader, struct wined3d_st > > /* Call appropriate function for output target */ > device->shader_backend->shader_handle_instruction(&ins); > + last_opcode = ins.handler_idx; > + } > + > + if (last_opcode != WINED3DSIH_RET) > + { > + /* Force a return instruction at the end of function body. */ > + memset(&ins, 0, sizeof(ins)); > + ins.ctx = &ctx; > + ins.handler_idx = WINED3DSIH_RET; > + device->shader_backend->shader_handle_instruction(&ins); > } > } Would it make sense to always generate a shader epilogue for shader model <= 3, and handle the RET instruction in a special way for shader model >= 4?

2 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel