- wine-devel - winehq.org

Compilation with winegcc vs compilation in Wine source
by Ruslan Kabatsayev 17 Aug '16

17 Aug '16

Hello all, I'm trying to integrate my program into Wine source and having some difficulties with doing OpenGL calls. Namely, when I compile the program with mingw and with winegcc, it works flawlessly. But when I integrate it into Wine source tree (taking regedit as an example), stack appears smashed after OpenGL calls. Here's what my command line looks like with winegcc (written by me manually): # compilation winegcc -c wgl.c -o wgl.o -g -m32 -municode -DUNICODE -D_UNICODE -g # linking winegcc main.o wgl.o d3d8.o d3d9.o texture.o common.o demo-res.o -lopengl32 -ld3d8 -ld3d9 -ld3dx9 -lgdi32 -lgdiplus -lglu32 -lole32 -lshell32 -lmsvcrt -o 3d-demo.exe -g -m32 -municode And the function where the crash happens looks like: 00012839 <initLightAndMaterial>: 12839: 55 push ebp 1283a: 89 e5 mov ebp,esp 1283c: 53 push ebx 1283d: 83 ec 24 sub esp,0x24 12840: e8 02 f1 ff ff call 11947 <__i686.get_pc_thunk.bx> 12845: 81 c3 17 5f 00 00 add ebx,0x5f17 1284b: b8 00 00 00 00 mov eax,0x0 12850: 89 45 e8 mov DWORD PTR [ebp-0x18],eax 12853: b8 00 00 00 00 mov eax,0x0 12858: 89 45 ec mov DWORD PTR [ebp-0x14],eax 1285b: b8 00 00 00 00 mov eax,0x0 12860: 89 45 f0 mov DWORD PTR [ebp-0x10],eax 12863: b8 00 00 80 3f mov eax,0x3f800000 12868: 89 45 f4 mov DWORD PTR [ebp-0xc],eax 1286b: 8d 45 e8 lea eax,[ebp-0x18] 1286e: 89 44 24 04 mov DWORD PTR [esp+0x4],eax 12872: c7 04 24 53 0b 00 00 mov DWORD PTR [esp],0xb53 12879: e8 92 f1 ff ff call 11a10 <glLightModelfv> 1287e: 83 ec 08 sub esp,0x8 12881: 8b 5d fc mov ebx,DWORD PTR [ebp-0x4] 12884: c9 leave 12885: c3 ret And here's the command from Wine tree (generated by its build system): # compilation /usr/lib/ccache/gcc-4.5 -c -o wgl.o wgl.c -I. -I../../include -I../../include/msvcrt -D__WINESRC__ -D_REENTRANT -fPIC \ -fno-builtin -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g # linking ../../tools/winegcc/winegcc -o 3d-demo.exe.so -B../../tools/winebuild -fasynchronous-unwind-tables -mwindows \ -municode -mno-cygwin d3d8.o d3d9.o wgl.o main.o common.o texture.o demo.res -luser32 -lgdi32 \ -lgdiplus -lopengl32 -lglu32 -ld3d8 -ld3d9 -ld3dx9 -lole32 -lshell32 -lmsvcrt \ ../../libs/port/libwine_port.a And the resulting function looks like 00014f8e <initLightAndMaterial>: 14f8e: 55 push ebp 14f8f: 89 e5 mov ebp,esp 14f91: 53 push ebx 14f92: 83 ec 24 sub esp,0x24 14f95: e8 8d c9 ff ff call 11927 <__i686.get_pc_thunk.bx> 14f9a: 81 c3 be 42 00 00 add ebx,0x42be 14fa0: b8 00 00 00 00 mov eax,0x0 14fa5: 89 45 e8 mov DWORD PTR [ebp-0x18],eax 14fa8: b8 00 00 00 00 mov eax,0x0 14fad: 89 45 ec mov DWORD PTR [ebp-0x14],eax 14fb0: b8 00 00 00 00 mov eax,0x0 14fb5: 89 45 f0 mov DWORD PTR [ebp-0x10],eax 14fb8: b8 00 00 80 3f mov eax,0x3f800000 14fbd: 89 45 f4 mov DWORD PTR [ebp-0xc],eax 14fc0: 8d 45 e8 lea eax,[ebp-0x18] 14fc3: 89 44 24 04 mov DWORD PTR [esp+0x4],eax 14fc7: c7 04 24 53 0b 00 00 mov DWORD PTR [esp],0xb53 14fce: e8 9d cb ff ff call 11b70 <glLightModelfv> 14fd3: 83 c4 24 add esp,0x24 14fd6: 5b pop ebx 14fd7: 5d pop ebp 14fd8: c3 ret The C code for the function looked like static void initLightAndMaterial(void) { const GLfloat globalAmbient[4]={0,0,0,1}; glLightModelfv(GL_LIGHT_MODEL_AMBIENT,globalAmbient); } And this is my Makefile.in (the function is defined in wgl.c): #--------------------------------------------- MODULE = 3d-demo.exe APPMODE = -mwindows -municode -mno-cygwin IMPORTS = user32 gdi32 gdiplus opengl32 glu32 d3d8 d3d9 d3dx9 ole32 shell32 msvcrt C_SRCS = \ d3d8.c \ d3d9.c \ wgl.c \ main.c \ common.c \ texture.c RC_SRCS = demo.rc INSTALL_LIB = 3d-demo.exe 3d-demo #--------------------------------------- Apparently in-tree compilation assumes another calling convention for glLightModelfv here... What could be the reason for this? How should I set up my Makefile.in so that it generated a result compatible with opengl32 calling convention? Thanks, Ruslan

2 7

Re: gdiplus: Reimplement metafile loading using gdi32 instead of IPicture.
by Nikolay Sivov 17 Aug '16

17 Aug '16

On 17.08.2016 11:26, Sebastian Lackner wrote: > +static GpStatus load_wmf(IStream *stream, GpMetafile **metafile) > +{ > + WmfPlaceableFileHeader pfh; > + GpStatus status = GenericError; > + BOOL is_placeable = FALSE; > + LARGE_INTEGER seek; > + METAHEADER mh; > + HMETAFILE hmf; > + HRESULT hr; > + UINT size; > + void *buf; > + > + hr = IStream_Read(stream, &mh, sizeof(mh), &size); > + if (hr != S_OK || size != sizeof(mh)) > + return GenericError; > + > + if (mh.mtType == 0xcdd7 && mh.mtHeaderSize == 0x9ac6) It'd be more readable to test this as UINT32 it's supposed to be, and having this constant defined to GDIP_WMF_PLACEABLEKEY (locally in gdiplus, it's only mentioned in comment in SDK) will help looking it up. > + { > + is_placeable = TRUE; > + > + seek.QuadPart = 0; > + hr = IStream_Seek(stream, seek, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) return hresult_to_status(hr); > + > + hr = IStream_Read(stream, &pfh, sizeof(pfh), &size); > + if (hr != S_OK || size != sizeof(pfh)) > + return GenericError; > + > + hr = IStream_Read(stream, &mh, sizeof(mh), &size); > + if (hr != S_OK || size != sizeof(mh)) > + return GenericError; > + } > + > + seek.QuadPart = is_placeable ? sizeof(pfh) : 0; > + hr = IStream_Seek(stream, seek, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) return hresult_to_status(hr); > + > + buf = heap_alloc(mh.mtSize * 2); > + if (!buf) return OutOfMemory; > + > + hr = IStream_Read(stream, buf, mh.mtSize * 2, &size); > + if (hr == S_OK && size == mh.mtSize * 2) > + { > + hmf = SetMetaFileBitsEx(mh.mtSize * 2, buf); > + if (hmf) > + { > + status = GdipCreateMetafileFromWmf(hmf, TRUE, is_placeable ? &pfh : NULL, metafile); > + if (status != Ok) > + DeleteMetaFile(hmf); > + } > + } > + > + heap_free(buf); > + return status; > +} > + > +static GpStatus decode_image_wmf(IStream *stream, GpImage **image) > { > - IPicture *pic; > + GpMetafile *metafile; > + GpStatus status; > > TRACE("%p %p\n", stream, image); > > - if(!stream || !image) > + if (!stream || !image) > return InvalidParameter; > > - if(OleLoadPicture(stream, 0, FALSE, &IID_IPicture, > - (LPVOID*) &pic) != S_OK){ > - TRACE("Could not load picture\n"); > + status = load_wmf(stream, &metafile); > + if (status != Ok) > + { > + TRACE("Could not load metafile\n"); > + return status; > + } > + > + *image = (GpImage *)metafile; > + TRACE("<-- %p\n", *image); > + > + return Ok; > +} > + > +static GpStatus load_emf(IStream *stream, GpMetafile **metafile) > +{ > + GpStatus status = GenericError; > + LARGE_INTEGER seek; > + ENHMETAHEADER emh; > + HENHMETAFILE hemf; > + HRESULT hr; > + UINT size; > + void *buf; > + > + hr = IStream_Read(stream, &emh, sizeof(emh), &size); > + if (hr != S_OK || size != sizeof(emh) || emh.dSignature != ENHMETA_SIGNATURE) > return GenericError; > + > + seek.QuadPart = 0; > + hr = IStream_Seek(stream, seek, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) return hresult_to_status(hr); > + > + buf = heap_alloc(emh.nBytes); > + if (!buf) return OutOfMemory; > + > + hr = IStream_Read(stream, buf, emh.nBytes, &size); > + if (hr == S_OK && size == emh.nBytes) > + { > + hemf = SetEnhMetaFileBits(emh.nBytes, buf); > + if (hemf) > + { > + status = GdipCreateMetafileFromEmf(hemf, TRUE, metafile); > + if (status != Ok) > + DeleteEnhMetaFile(hemf); > + } > } > > - /* FIXME: missing initialization code */ > - *image = heap_alloc_zero(sizeof(GpMetafile)); > - if(!*image) return OutOfMemory; > - (*image)->type = ImageTypeMetafile; > - (*image)->decoder = NULL; > - (*image)->picture = pic; > - (*image)->flags = ImageFlagsNone; > - (*image)->frame_count = 1; > - (*image)->current_frame = 0; > - (*image)->palette = NULL; > - list_init(&(*(GpMetafile**)image)->containers); > + heap_free(buf); > + return status; > +} > + > +static GpStatus decode_image_emf(IStream *stream, GpImage **image) > +{ > + GpMetafile *metafile; > + GpStatus status; > + > + TRACE("%p %p\n", stream, image); > + > + if (!stream || !image) > + return InvalidParameter; > + > + status = load_emf(stream, &metafile); > + if (status != Ok) > + { > + TRACE("Could not load metafile\n"); > + return status; > + } > > + *image = (GpImage *)metafile; > TRACE("<-- %p\n", *image); > > return Ok; > @@ -4721,7 +4750,7 @@ static const struct image_codec codecs[NUM_CODECS] = { > /* SigMask */ emf_sig_mask, > }, > NULL, > - decode_image_olepicture_metafile, > + decode_image_emf, > NULL > }, > { > @@ -4741,7 +4770,7 @@ static const struct image_codec codecs[NUM_CODECS] = { > /* SigMask */ wmf_sig_mask, > }, > NULL, > - decode_image_olepicture_metafile, > + decode_image_wmf, > NULL > }, > { > diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c > index a854e55..8b93e81 100644 > --- a/dlls/gdiplus/metafile.c > +++ b/dlls/gdiplus/metafile.c > @@ -317,7 +317,6 @@ GpStatus WINGDIPAPI GdipRecordMetafile(HDC hdc, EmfType type, GDIPCONST GpRectF > } > > (*metafile)->image.type = ImageTypeMetafile; > - (*metafile)->image.picture = NULL; > (*metafile)->image.flags = ImageFlagsNone; > (*metafile)->image.palette = NULL; > (*metafile)->image.xres = dpix; > diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c > index ad84feb..cabd2fce 100644 > --- a/dlls/gdiplus/tests/image.c > +++ b/dlls/gdiplus/tests/image.c > @@ -1446,19 +1446,19 @@ static void test_loadwmf(void) > > stat = GdipGetImageBounds(img, &bounds, &unit); > expect(Ok, stat); > - todo_wine expect(UnitPixel, unit); > + expect(UnitPixel, unit); > expectf(0.0, bounds.X); > expectf(0.0, bounds.Y); > - todo_wine expectf(320.0, bounds.Width); > - todo_wine expectf(320.0, bounds.Height); > + expectf(320.0, bounds.Width); > + expectf(320.0, bounds.Height); > > stat = GdipGetImageHorizontalResolution(img, &res); > expect(Ok, stat); > - todo_wine expectf(1440.0, res); > + expectf(1440.0, res); > > stat = GdipGetImageVerticalResolution(img, &res); > expect(Ok, stat); > - todo_wine expectf(1440.0, res); > + expectf(1440.0, res); > > memset(&header, 0, sizeof(header)); > stat = GdipGetMetafileHeaderFromMetafile((GpMetafile*)img, &header); >

2 1

Re: [PATCH 1/2] user32/tests: Add more tests for setting window styles.
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25155 Your paranoid android. === w7u (32 bit win) === win.c:8644: Test failed: assigned and retrieved update regions are different win.c:8645: Test failed: has invalid area after ValidateRgn(NULL) win.c:8662: Test failed: wrong update region win.c:8667: Test failed: wrong update region win.c:8674: Test failed: wrong update region

2 1

Re: [PATCH] d3d11: Support D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS in ID3D11Device CheckFeatureSupport
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25138 Your paranoid android. === build (build) === Make failed

3 2

Re: [PATCH] d3d11: Support D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS in ID3D11Device CheckFeatureSupport
by Józef Kucia 17 Aug '16

17 Aug '16

This patch is probably fine because I don't expect that we will expose compute shaders in SM4 (at least initially). On Wed, Aug 17, 2016 at 8:52 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3d11/device.c | 12 ++++++++++++ > dlls/d3d11/tests/d3d11.c | 18 ++++++++++++++++++ > include/d3d11.idl | 5 +++++ > 3 files changed, 35 insertions(+) > > diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c > index df5a4ac..6142ac0 100644 > --- a/dlls/d3d11/device.c > +++ b/dlls/d3d11/device.c > @@ -3463,6 +3463,18 @@ static HRESULT STDMETHODCALLTYPE d3d11_device_CheckFeatureSupport(ID3D11Device * > threading_data->DriverCommandLists = FALSE; > return S_OK; > } > + case D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS: > + { > + D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS *options = feature_support_data; > + if (feature_support_data_size != sizeof(*options)) > + { > + WARN("Invalid data size.\n"); > + return E_INVALIDARG; > + } > + > + options->ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x = FALSE; > + return S_OK; > + } > > default: > FIXME("Unhandled feature %#x.\n", feature); > diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c > index 330a960..962682d 100644 > --- a/dlls/d3d11/tests/d3d11.c > +++ b/dlls/d3d11/tests/d3d11.c > @@ -9188,6 +9188,7 @@ static void test_null_sampler(void) > static void test_check_feature_support(void) > { > D3D11_FEATURE_DATA_THREADING threading[2]; > + D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS hwopts; This is not important but I would name it d3d10_hw_opts or d3d10_opts. > ID3D11Device *device; > ULONG refcount; > HRESULT hr; > @@ -9229,6 +9230,23 @@ static void test_check_feature_support(void) > ok(threading->DriverCommandLists == TRUE || threading->DriverCommandLists == FALSE, > "Got unexpected command lists %#x.\n", threading->DriverCommandLists); > > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, NULL, 0); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, 0); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) - 1); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) / 2); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) + 1); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) * 2); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts)); > + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); > + trace("Shader support %#x.\n", hwopts.ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4); It should be "ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x". Besides, the trace() message could more clear, e.g. "Compute shader support via SM4". > + > refcount = ID3D11Device_Release(device); > ok(!refcount, "Device has %u references left.\n", refcount); > } > diff --git a/include/d3d11.idl b/include/d3d11.idl > index cd177c2..767321b 100644 > --- a/include/d3d11.idl > +++ b/include/d3d11.idl > @@ -445,6 +445,11 @@ typedef struct D3D11_FEATURE_DATA_THREADING > BOOL DriverCommandLists; > } D3D11_FEATURE_DATA_THREADING; > > +typedef struct D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS > +{ > + BOOL ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x; > +} D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS; > + > typedef struct D3D11_FEATURE_DATA_D3D11_OPTIONS > { > BOOL OutputMergerLogicOp; > -- > 2.8.1 > > >

1 0

Re: [3/4] msvcirt: Add predefined streams.
by Piotr Caban 17 Aug '16

17 Aug '16

Hi, On 08/17/16 12:57, Iván Matellanes wrote: > + if ((fb = MSVCRT_operator_new(sizeof(filebuf)))) { > + filebuf_fd_ctor(fb, 0); > + istream_sb_ctor(&cin.is, &fb->base, TRUE); > + } else > + istream_sb_ctor(&cin.is, NULL, TRUE); > + Iostream_init_ios_ctor(NULL, &cin.vbase, 0); You should use istream_withassign_sb_ctor here. Thanks, Piotr

1 0

Re: [PATCH 4/6] ntdll: Add support for exceptions inside termination handlers in __C_specific_handler
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25148 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:516: Test failed: 42: Unexpected eip 0x340000/0x340001 exception: unhandled exception 80000004 at 00340000 exception.c:516: Test failed: 42: Unexpected eip 0x77baed97/0x340001 === w7u (32 bit exception) === exception.c:516: Test failed: 42: Unexpected eip 0x3d0000/0x3d0001 exception: unhandled exception 80000004 at 003D0000 exception.c:516: Test failed: 42: Unexpected eip 0x77cde34f/0x3d0001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

2 1

Re: [1/4] gdiplus: Implement playback/recording for SetClipRect.
by Sebastian Lackner 17 Aug '16

17 Aug '16

On 16.08.2016 23:00, Vincent Povirk wrote: > diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c > index a854e55..643d3c4 100644 > --- a/dlls/gdiplus/metafile.c > +++ b/dlls/gdiplus/metafile.c > @@ -70,6 +70,12 @@ typedef struct EmfPlusFillRects > DWORD Count; > } EmfPlusFillRects; > > +typedef struct EmfPlusSetClipRect > +{ > + EmfPlusRecordHeader Header; > + GpRectF ClipRect; There is a small whitespace error in the line above. > +} EmfPlusSetClipRect; > + > typedef struct EmfPlusSetPageTransform > { > EmfPlusRecordHeader Header;

1 0

Re: [PATCH] server/console: Allow waiting on console_input
by Alexandre Julliard 17 Aug '16

17 Aug '16

Keno Fischer <keno(a)juliacomputing.com> writes: > Please see attached. This fixes console input under wine for julia and > probably other programs using libuv. I am not particularly familiar > with wine internals, so please review closely. The right way is probably to fix RegisterWaitForSingleObject to handle console handles the same way WaitForSingleObject does. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/4] gdiplus: Load EMF images directly instead of through olepicture.
by Dmitry Timoshkov 17 Aug '16

17 Aug '16

Vincent Povirk <madewokherd(a)gmail.com> wrote: > @@ -4721,7 +4767,7 @@ static const struct image_codec codecs[NUM_CODECS] = { > /* SigMask */ emf_sig_mask, > }, > NULL, > - decode_image_olepicture_metafile, > + decode_image_emf, > NULL > }, This patch is very incomplete, and probably won't pass the 'make test'. wine-staging contains a pretty full and well tested patch that reimplements metafile loading in gdiplus using gdi32 APis: https://github.com/wine-compholio/wine-staging/blob/master/patches/oleaut32… it should be possible to either use it directly or as a base for your work. There are some other related patches in staging that touch the metafile loading in gdiplus. -- Dmitry.

3 2

Re: [PATCH 2/2] kernel32: Implement GetConsoleScreenBufferInfoEx
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25126 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3964615102 console.c:1445: Test failed: [15] Expected output count to be 0, got 3964615102 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3964615102 console.c:1689: Test failed: [13] Expected output count to be 0, got 3964615102 console.c:1689: Test failed: [15] Expected output count to be 0, got 3964615102 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3964615102 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 4007961408 console.c:1445: Test failed: [15] Expected output count to be 0, got 4007961408 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 4007961408 console.c:1689: Test failed: [13] Expected output count to be 0, got 4007961408 console.c:1689: Test failed: [15] Expected output count to be 0, got 4007961408 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 4007961408 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 564791309 console.c:1445: Test failed: [15] Expected output count to be 0, got 564791309 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 564791309 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 564791309 console.c:1689: Test failed: [15] Expected output count to be 0, got 564791309 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 564791309 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [PATCH 1/2] kernel32/tests: Add tests for GetConsoleScreenBufferInfoEx
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25125 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2191869370 console.c:1445: Test failed: [15] Expected output count to be 0, got 2191869370 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2191869370 console.c:1689: Test failed: [13] Expected output count to be 0, got 2191869370 console.c:1689: Test failed: [15] Expected output count to be 0, got 2191869370 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2191869370 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3647870754 console.c:1445: Test failed: [15] Expected output count to be 0, got 3647870754 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3647870754 console.c:1689: Test failed: [13] Expected output count to be 0, got 3647870754 console.c:1689: Test failed: [15] Expected output count to be 0, got 3647870754 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3647870754 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 3382944356 console.c:1445: Test failed: [15] Expected output count to be 0, got 3382944356 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3382944356 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 3382944356 console.c:1689: Test failed: [15] Expected output count to be 0, got 3382944356 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3382944356 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [PATCH] server/console: Allow waiting on console_input
by Marvin 16 Aug '16

16 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25120 Your paranoid android. === w8 (32 bit console) === console.c:1480: Test failed: [13] Expected output count to be 0, got 1510596369 console.c:1480: Test failed: [15] Expected output count to be 0, got 1510596369 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 1510596369 console.c:1724: Test failed: [13] Expected output count to be 0, got 1510596369 console.c:1724: Test failed: [15] Expected output count to be 0, got 1510596369 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 1510596369 === w864 (32 bit console) === console.c:1480: Test failed: [13] Expected output count to be 0, got 1764633039 console.c:1480: Test failed: [15] Expected output count to be 0, got 1764633039 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 1764633039 console.c:1724: Test failed: [13] Expected output count to be 0, got 1764633039 console.c:1724: Test failed: [15] Expected output count to be 0, got 1764633039 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 1764633039 === w1064 (32 bit console) === console.c:2602: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2608: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2615: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2622: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1305: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1480: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [13] Expected output count to be 0, got 2775085592 console.c:1480: Test failed: [15] Expected output count to be 0, got 2775085592 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 2775085592 console.c:1724: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [13] Expected output count to be 0, got 2775085592 console.c:1724: Test failed: [15] Expected output count to be 0, got 2775085592 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 2775085592 console.c:2183: Test failed: [7] Expected count to be 0, got 1 console.c:2249: Test failed: [7] Expected count to be 0, got 1 console.c:2315: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2602: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2608: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2615: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2622: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1305: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1480: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2183: Test failed: [7] Expected count to be 0, got 1 console.c:2249: Test failed: [7] Expected count to be 0, got 1 console.c:2315: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2602: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2608: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2615: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2622: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1305: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1480: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2183: Test failed: [7] Expected count to be 0, got 1 console.c:2249: Test failed: [7] Expected count to be 0, got 1 console.c:2315: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH] server/console: Allow waiting on console_input
by Sebastian Lackner 16 Aug '16

16 Aug '16

On 16.08.2016 20:47, Keno Fischer wrote: > Please see attached. This fixes console input under wine for julia and > probably other programs using libuv. I am not particularly familiar > with wine internals, so please review closely. > > Thanks, > Keno > > > 0001-server-console-Allow-waiting-on-console_input.patch > > > From 5fe78027f0034b83145c879adb17531e9487c6f7 Mon Sep 17 00:00:00 2001 > From: Keno Fischer <keno(a)juliacomputing.com> > Date: Tue, 16 Aug 2016 14:35:27 -0400 > Subject: [PATCH] server/console: Allow waiting on console_input > > It appears that Windows allows this for notification of new input > events in the console. This functionality was used e.g., by the libuv > I/O library, causing any users thereof to not receive input under wine, > e.g. fixes https://github.com/JuliaLang/julia/issues/18006. Thanks for working on this. I think the implementation is fine, however there are some small things which could be improved a bit. > > Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> > --- > dlls/kernel32/tests/console.c | 37 +++++++++++++++++++++++++++++++++++++ > server/console.c | 16 +++++++++++++--- > 2 files changed, 50 insertions(+), 3 deletions(-) > > diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c > index 5b66d9f..f97b415 100644 > --- a/dlls/kernel32/tests/console.c > +++ b/dlls/kernel32/tests/console.c > @@ -908,6 +908,41 @@ static void testScreenBuffer(HANDLE hConOut) > SetConsoleOutputCP(oldcp); > } > > +static void CALLBACK signaled_function(PVOID p, BOOLEAN TimerOrWaitFired) > +{ Usually wine prefers "void *" instead of PVOID and also lowercase variable names, so for example just "timeout" instead of "TimerOrWaitFired" as on MSDN. > + HANDLE event = p; > + SetEvent(event); > + ok(!TimerOrWaitFired, "wait shouldn't have timed out\n"); > +} > + > +static void testWaitForConsoleInput(HANDLE input_handle) > +{ > + HANDLE wait_handle; > + HANDLE complete_event; > + INPUT_RECORD record; > + DWORD events_written; > + DWORD wait_ret; > + BOOL ret; > + > + complete_event = CreateEventW(NULL, FALSE, FALSE, NULL); > + > + ret = RegisterWaitForSingleObject(&wait_handle, input_handle, signaled_function, complete_event, INFINITE, WT_EXECUTEONLYONCE); > + ok(ret == TRUE, "Expected RegisterWaitForSingleObject to return TRUE, got %d\n", ret); To keep the testcase similar to the original code thats probably fine, however I would like to point out that you do not really need an asynchronous wait here. You could basically test the same with WaitForSingleObject(input_handle, INFINITE). > + /* give worker thread a chance to start up */ > + Sleep(100); > + record.EventType = KEY_EVENT; > + record.Event.KeyEvent.bKeyDown = 1; > + record.Event.KeyEvent.wRepeatCount = 1; > + record.Event.KeyEvent.wVirtualKeyCode = VK_RETURN; > + record.Event.KeyEvent.wVirtualScanCode = VK_RETURN; > + record.Event.KeyEvent.uChar.AsciiChar = '\r'; If I don't miss anything this does not initialize the upper byte of the union. > + record.Event.KeyEvent.dwControlKeyState = 0; > + ret = WriteConsoleInputW(input_handle, &record, 1, &events_written); > + ok(ret == TRUE, "Expected WriteConsoleInputW to return TRUE, got %d\n", ret); > + wait_ret = WaitForSingleObject(complete_event, INFINITE); > + ok(wait_ret == WAIT_OBJECT_0, "Expected the handle to be signaled"); There is a linebreak missing in the line above. For completeness, it also wouldn't hurt to add another test after calling FlushConsoleInputBuffer() to make sure it times out as expected. If you want to keep the asynchronous wait, please also add cleanup of the complete_event and the wait_handle. > +} > + > static void test_GetSetConsoleInputExeName(void) > { > BOOL ret; > @@ -3044,6 +3079,8 @@ START_TEST(console) > testScroll(hConOut, sbi.dwSize); > /* will test sb creation / modification / codepage handling */ > testScreenBuffer(hConOut); > + /* Test waiting for a console handle */ > + testWaitForConsoleInput(hConIn); > > /* clear duplicated console font table */ > CloseHandle(hConIn); > diff --git a/server/console.c b/server/console.c > index 93f785a..376395d 100644 > --- a/server/console.c > +++ b/server/console.c > @@ -67,6 +67,7 @@ struct console_input > > static void console_input_dump( struct object *obj, int verbose ); > static void console_input_destroy( struct object *obj ); > +static int console_input_signaled( struct object *obj, struct wait_queue_entry *entry ); > static struct fd *console_input_get_fd( struct object *obj ); > > static const struct object_ops console_input_ops = > @@ -74,9 +75,9 @@ static const struct object_ops console_input_ops = > sizeof(struct console_input), /* size */ > console_input_dump, /* dump */ > no_get_type, /* get_type */ > - no_add_queue, /* add_queue */ > - NULL, /* remove_queue */ > - NULL, /* signaled */ > + add_queue, /* add_queue */ > + remove_queue, /* remove_queue */ > + console_input_signaled, /* signaled */ > no_satisfied, /* satisfied */ > no_signal, /* signal */ > console_input_get_fd, /* get_fd */ > @@ -543,6 +544,14 @@ static struct console_input* console_input_get( obj_handle_t handle, unsigned ac > return console; > } > > +/* the console input is signaled when it's not empty */ > +static int console_input_signaled( struct object *obj, struct wait_queue_entry *entry ) > +{ > + struct console_input *console = (struct console_input *)obj; > + assert( obj->ops == &console_input_ops ); > + return (console->recnum != 0); > +} > + > struct console_signal_info > { > struct console_input *console; > @@ -677,6 +686,7 @@ static int write_console_input( struct console_input* console, int count, > } > if (!console->recnum && count) set_event( console->event ); > console->recnum += count; > + wake_up( &console->obj, 0 ); > return count; > } > > -- 2.7.4 > > >

2 1

Re: kernel32/tests: Fill in the delay IAT to succeed on Win10
by Marvin 16 Aug '16

16 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25081 Your paranoid android. === wvistau64 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w2008s64 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w7pro64 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w864 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w1064 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784

1 0

Re: [PATCH 3/9] d3d9/tests: Add test for regression in IDirect3DDevice9_Reset().
by Marvin 16 Aug '16

16 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25061 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (32 bit d3d9ex) === d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=1.

1 0

Re: d3dx9: Add D3DXFrameFind stub.
by Nikolay Sivov 16 Aug '16

16 Aug '16

On 12.08.2016 13:00, Andrey Gusev wrote: > +D3DXFRAME * WINAPI D3DXFrameFind(const D3DXFRAME *frame_root, const char *name) > +{ > + FIXME("frame_root %p, name %s stub!\n", frame_root, debugstr_a(name)); > + > + return NULL; > +} This looks trivial enough to implement. It's probably just going from pFrameFirstChild -> pFrameSibling. The question is does it check grandchildren, but it's easy to test.

2 1

Re: [PATCH 2/2] d3drm: Implement IDirect3DRMViewport*::Clear. (v3 resend)
by Henri Verbeet 16 Aug '16

16 Aug '16

On 15 August 2016 at 21:50, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + memcpy(&driver, &IID_IDirect3DRGBDevice, sizeof(GUID)); Why not "driver = IID_IDirect3DRGBDevice;"? It probably also makes sense to introduce a helper function to create d3drm devices at some point. > + hr = IDirect3DMaterial_SetMaterial(viewport->material, &mat); > + > + return hr; "return IDirect3DMaterial_SetMaterial(viewport->material, &mat);" > + if (FAILED(hr = IDirect3DViewport_Clear(viewport->d3d_viewport, 1, &clear_rect, clear_flags))) > + return hr; Formatting.

1 0

Re: [PATCH] po: Update Simplified Chinese translation.
by Jactry Zeng 16 Aug '16

16 Aug '16

It looks good to me. Thanks! 2016-08-16 14:28 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 342 ++++++++++++++++++++++++++++++ > ------------------------------ > 1 file changed, 171 insertions(+), 171 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 2/9] d3d8/tests: Add test for regression in IDirect3DDevice8_Reset().
by Henri Verbeet 16 Aug '16

16 Aug '16

On 16 August 2016 at 12:51, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > Or well, maybe I should hold off on that for a bit. It works here though.

2 1

Re: [PATCH] msvcrt: Add _wcreate_locale (try2)
by Piotr Caban 16 Aug '16

16 Aug '16

On 08/15/16 22:02, Daniel Lehman wrote: > + lcl = p_wcreate_locale(LC_ALL, german); You should probably skip this test on systems that doesn't support German locale. Thanks, Piotr

1 0

[v2 PATCH] inetcomm: Add MimeOleObjectFromMoniker stub
by Andrey Gusev 15 Aug '16

15 Aug '16

> FIXME("(0x%08x, %p, %p, %s, %p %p) stub\n", bindf, moniker, binding, debugstr_guid(riid), out, moniker_new); You missed a comma.

1 0

Re: [v4] riched20: allow setting background text color
by Huw Davies 15 Aug '16

15 Aug '16

On Sun, Aug 14, 2016 at 03:07:25PM -0600, Kenneth Haley wrote: > fixes https://bugs.winehq.org/show_bug.cgi?id=36625 Actually I missed that you hadn't added a Signed-off-by: line, git format-patch -s will do this for you. Please resend with one. Thanks, Huw.

1 0

Re: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext
by Sebastian Lackner 15 Aug '16

15 Aug '16

On 11.08.2016 19:27, Daniel Lehman wrote: > Some tests will fail but are unrelated to this patch: > https://urldefense.proofpoint.com/v2/url?u=http-3A__test.winehq.org_data_88… > https://urldefense.proofpoint.com/v2/url?u=http-3A__test.winehq.org_data_88… > https://urldefense.proofpoint.com/v2/url?u=http-3A__test.winehq.org_data_88… > > > 0001-ntdll-Set-Rip-in-for-longjmp-in-RtlRestoreContext.txt > > > From eaab70ee4ddc866526df0341853ccdb599cf7674 Mon Sep 17 00:00:00 2001 > From: Daniel Lehman <dlehman(a)esri.com> > Date: Mon, 1 Aug 2016 14:52:32 -0700 > Subject: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext > > Signed-off-by: Daniel Lehman <dlehman(a)esri.com> > --- > dlls/ntdll/signal_x86_64.c | 1 + > dlls/ntdll/tests/exception.c | 202 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 203 insertions(+) > > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index 4c88536..598e08a 100644 > --- a/dlls/ntdll/signal_x86_64.c > +++ b/dlls/ntdll/signal_x86_64.c > @@ -3513,6 +3513,7 @@ void WINAPI RtlRestoreContext( CONTEXT *context, EXCEPTION_RECORD *rec ) > context->R13 = jmp->R13; > context->R14 = jmp->R14; > context->R15 = jmp->R15; > + context->Rip = jmp->Rip; > context->u.s.Xmm6 = jmp->Xmm6; > context->u.s.Xmm7 = jmp->Xmm7; > context->u.s.Xmm8 = jmp->Xmm8; Please note that this also modifies the behavior of RtlUnwindEx (which gets the target_ip passed directly as a function argument). With your change it will be ignored, which might need additional (at least manual) tests to make sure this is correct. > diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c > index a086436..4846769 100644 > --- a/dlls/ntdll/tests/exception.c > +++ b/dlls/ntdll/tests/exception.c > @@ -53,10 +53,44 @@ static NTSTATUS (WINAPI *pNtSetInformationProcess)(HANDLE, PROCESSINFOCLASS, PV > static BOOL (WINAPI *pIsWow64Process)(HANDLE, PBOOL); > > #if defined(__x86_64__) > +typedef struct _SETJMP_FLOAT128 > +{ > + unsigned __int64 DECLSPEC_ALIGN(16) Part[2]; > +} SETJMP_FLOAT128; > + > +typedef struct _JUMP_BUFFER > +{ > + unsigned __int64 Frame; > + unsigned __int64 Rbx; > + unsigned __int64 Rsp; > + unsigned __int64 Rbp; > + unsigned __int64 Rsi; > + unsigned __int64 Rdi; > + unsigned __int64 R12; > + unsigned __int64 R13; > + unsigned __int64 R14; > + unsigned __int64 R15; > + unsigned __int64 Rip; > + unsigned __int64 Spare; > + SETJMP_FLOAT128 Xmm6; > + SETJMP_FLOAT128 Xmm7; > + SETJMP_FLOAT128 Xmm8; > + SETJMP_FLOAT128 Xmm9; > + SETJMP_FLOAT128 Xmm10; > + SETJMP_FLOAT128 Xmm11; > + SETJMP_FLOAT128 Xmm12; > + SETJMP_FLOAT128 Xmm13; > + SETJMP_FLOAT128 Xmm14; > + SETJMP_FLOAT128 Xmm15; > +} _JUMP_BUFFER; > + > static BOOLEAN (CDECL *pRtlAddFunctionTable)(RUNTIME_FUNCTION*, DWORD, DWORD64); > static BOOLEAN (CDECL *pRtlDeleteFunctionTable)(RUNTIME_FUNCTION*); > static BOOLEAN (CDECL *pRtlInstallFunctionTableCallback)(DWORD64, DWORD64, DWORD, PGET_RUNTIME_FUNCTION_CALLBACK, PVOID, PCWSTR); > static PRUNTIME_FUNCTION (WINAPI *pRtlLookupFunctionEntry)(ULONG64, ULONG64*, UNWIND_HISTORY_TABLE*); > +static VOID (WINAPI *pRtlCaptureContext)(CONTEXT*); > +static VOID (CDECL *pRtlRestoreContext)(CONTEXT*, EXCEPTION_RECORD*); > +static int (CDECL *p_setjmp)(_JUMP_BUFFER*); > #endif > > #ifdef __i386__ > @@ -1631,6 +1665,164 @@ static void test_virtual_unwind(void) > call_virtual_unwind( i, &tests[i] ); > } > > +static int consolidate_dummy_called; > +static PVOID CALLBACK test_consolidate_dummy(EXCEPTION_RECORD *rec) > +{ > + CONTEXT *ctx = (CONTEXT *)rec->ExceptionInformation[1]; > + consolidate_dummy_called = 1; > + ok(ctx->Rip == 0xdeadbeef, "test_consolidate_dummy failed for Rip, expected: 0xdeadbeef, got: %lx\n", ctx->Rip); > + return (PVOID)rec->ExceptionInformation[2]; > +} > + > +static void test_restore_context(void) > +{ > + XMM_SAVE_AREA32 *fltsave; > + EXCEPTION_RECORD rec; > + volatile int done; /* gcc 4.5.2 rearranges 'done' and RtlCaptureContext */ > + volatile int pass; A better way to make sure the compiler does not rearrange the code would be to use Interlocked*() functions. > + _JUMP_BUFFER buf; > + CONTEXT ctx; > + > + if (!pRtlRestoreContext || !pRtlCaptureContext || !p_setjmp) > + { > + skip("RtlCaptureContext/RtlRestoreContext/_setjmp not found\n"); > + return; > + } > + > + /* RtlRestoreContext(NULL, NULL); crashes on Windows */ > + > + /* test simple case of capture and restore context */ > + pass = 0; > + done = 0; > + pRtlCaptureContext(&ctx); > + switch (pass) > + { > + case 0: > + ok(!done, "done on first pass\n"); > + break; > + case 1: > + ok(done, "not done on second pass\n"); > + break; > + default: > + ok(0, "bad pass = %i done = %i\n", pass, done); > + break; > + } > + ++pass; > + if (done) goto test_longjmp; > + done = 1; I don't think the second variable adds much value here. A simplified version like below would test the same things: pass = 0; pRtlCaptureContext(&ctx); ok(pass < 2, "unexpected pass = %d\n", pass); if (!pass++) pRtlRestoreContext(&ctx, NULL); > + > + pRtlRestoreContext(&ctx, NULL); > + > +test_longjmp: I do not see any need to use goto here, regular if () checks would also do the job. > + fltsave = (XMM_SAVE_AREA32 *)((char*)&ctx + 0x100); It is better to avoid such hardcoded constants. Why not access the field directly? > + done = 0; > + pRtlCaptureContext(&ctx); What is the purpose of the RtlCaptureContext call here? The result does not seem to be used. After RtlRestoreContext() the ctx struct has been filled with the jump buffer values. > + p_setjmp(&buf); > + if (done) > + { > + ok(buf.Rbx == ctx.Rbx, "RtlRestoreContext:longjump failed for Rbx, expected: %lx, got: %lx\n", buf.Rbx, ctx.Rbx); > + ok(buf.Rsp == ctx.Rsp, "RtlRestoreContext:longjump failed for Rsp, expected: %lx, got: %lx\n", buf.Rsp, ctx.Rsp); > + ok(buf.Rbp == ctx.Rbp, "RtlRestoreContext:longjump failed for Rbp, expected: %lx, got: %lx\n", buf.Rbp, ctx.Rbp); > + ok(buf.Rsi == ctx.Rsi, "RtlRestoreContext:longjump failed for Rsi, expected: %lx, got: %lx\n", buf.Rsi, ctx.Rsi); > + ok(buf.Rdi == ctx.Rdi, "RtlRestoreContext:longjump failed for Rdi, expected: %lx, got: %lx\n", buf.Rdi, ctx.Rdi); > + ok(buf.R12 == ctx.R12, "RtlRestoreContext:longjump failed for R12, expected: %lx, got: %lx\n", buf.R12, ctx.R12); > + ok(buf.R13 == ctx.R13, "RtlRestoreContext:longjump failed for R13, expected: %lx, got: %lx\n", buf.R13, ctx.R13); > + ok(buf.R14 == ctx.R14, "RtlRestoreContext:longjump failed for R14, expected: %lx, got: %lx\n", buf.R14, ctx.R14); > + ok(buf.R15 == ctx.R15, "RtlRestoreContext:longjump failed for R15, expected: %lx, got: %lx\n", buf.R15, ctx.R15); > + > + ok(buf.Xmm6.Part[1] == fltsave->XmmRegisters[6].High && buf.Xmm6.Part[0] == fltsave->XmmRegisters[6].Low, > + "RtlRestoreContext:longjump failed for Xmm6, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm6.Part[1], buf.Xmm6.Part[0], fltsave->XmmRegisters[6].High, fltsave->XmmRegisters[6].Low); > + ok(buf.Xmm7.Part[1] == fltsave->XmmRegisters[7].High && buf.Xmm7.Part[0] == fltsave->XmmRegisters[7].Low, > + "RtlRestoreContext:longjump failed for Xmm7, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm7.Part[1], buf.Xmm7.Part[0], fltsave->XmmRegisters[7].High, fltsave->XmmRegisters[7].Low); > + ok(buf.Xmm8.Part[1] == fltsave->XmmRegisters[8].High && buf.Xmm8.Part[0] == fltsave->XmmRegisters[8].Low, > + "RtlRestoreContext:longjump failed for Xmm8, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm8.Part[1], buf.Xmm8.Part[0], fltsave->XmmRegisters[8].High, fltsave->XmmRegisters[8].Low); > + ok(buf.Xmm9.Part[1] == fltsave->XmmRegisters[9].High && buf.Xmm9.Part[0] == fltsave->XmmRegisters[9].Low, > + "RtlRestoreContext:longjump failed for Xmm9, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm9.Part[1], buf.Xmm9.Part[0], fltsave->XmmRegisters[9].High, fltsave->XmmRegisters[9].Low); > + ok(buf.Xmm10.Part[1] == fltsave->XmmRegisters[10].High && buf.Xmm10.Part[0] == fltsave->XmmRegisters[10].Low, > + "RtlRestoreContext:longjump failed for Xmm10, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm10.Part[1], buf.Xmm10.Part[0], fltsave->XmmRegisters[10].High, fltsave->XmmRegisters[10].Low); > + ok(buf.Xmm11.Part[1] == fltsave->XmmRegisters[11].High && buf.Xmm11.Part[0] == fltsave->XmmRegisters[11].Low, > + "RtlRestoreContext:longjump failed for Xmm11, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm11.Part[1], buf.Xmm11.Part[0], fltsave->XmmRegisters[11].High, fltsave->XmmRegisters[11].Low); > + ok(buf.Xmm12.Part[1] == fltsave->XmmRegisters[12].High && buf.Xmm12.Part[0] == fltsave->XmmRegisters[12].Low, > + "RtlRestoreContext:longjump failed for Xmm12, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm12.Part[1], buf.Xmm12.Part[0], fltsave->XmmRegisters[12].High, fltsave->XmmRegisters[12].Low); > + ok(buf.Xmm13.Part[1] == fltsave->XmmRegisters[13].High && buf.Xmm13.Part[0] == fltsave->XmmRegisters[13].Low, > + "RtlRestoreContext:longjump failed for Xmm13, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm13.Part[1], buf.Xmm13.Part[0], fltsave->XmmRegisters[13].High, fltsave->XmmRegisters[13].Low); > + ok(buf.Xmm14.Part[1] == fltsave->XmmRegisters[14].High && buf.Xmm14.Part[0] == fltsave->XmmRegisters[14].Low, > + "RtlRestoreContext:longjump failed for Xmm14, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm14.Part[1], buf.Xmm14.Part[0], fltsave->XmmRegisters[14].High, fltsave->XmmRegisters[14].Low); > + ok(buf.Xmm15.Part[1] == fltsave->XmmRegisters[15].High && buf.Xmm15.Part[0] == fltsave->XmmRegisters[15].Low, > + "RtlRestoreContext:longjump failed for Xmm15, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm15.Part[1], buf.Xmm15.Part[0], fltsave->XmmRegisters[15].High, fltsave->XmmRegisters[15].Low); > + > + goto test_consolidate; Similar to above, it would be better to avoid goto. All the code below could just be moved to an else branch. > + } > + done = 1; > + > + rec.ExceptionCode = STATUS_LONGJUMP; > + rec.NumberParameters = 1; > + rec.ExceptionInformation[0] = (DWORD64)&buf; > + > + ctx.Rbx = 0xdeadbeef; > + ctx.Rsp = 0xdeadbeef; > + ctx.Rbp = 0xdeadbeef; > + ctx.Rsi = 0xdeadbeef; > + ctx.Rdi = 0xdeadbeef; > + ctx.R12 = 0xdeadbeef; > + ctx.R13 = 0xdeadbeef; > + ctx.R14 = 0xdeadbeef; > + ctx.R15 = 0xdeadbeef; > + > + fltsave->XmmRegisters[6].High = 0xbaadf00d; > + fltsave->XmmRegisters[6].Low = 0xdeadbeef; > + fltsave->XmmRegisters[7].High = 0xbaadf00d; > + fltsave->XmmRegisters[7].Low = 0xdeadbeef; > + fltsave->XmmRegisters[8].High = 0xbaadf00d; > + fltsave->XmmRegisters[8].Low = 0xdeadbeef; > + fltsave->XmmRegisters[9].High = 0xbaadf00d; > + fltsave->XmmRegisters[9].Low = 0xdeadbeef; > + fltsave->XmmRegisters[10].High = 0xbaadf00d; > + fltsave->XmmRegisters[10].Low = 0xdeadbeef; > + fltsave->XmmRegisters[11].High = 0xbaadf00d; > + fltsave->XmmRegisters[11].Low = 0xdeadbeef; > + fltsave->XmmRegisters[12].High = 0xbaadf00d; > + fltsave->XmmRegisters[12].Low = 0xdeadbeef; > + fltsave->XmmRegisters[13].High = 0xbaadf00d; > + fltsave->XmmRegisters[13].Low = 0xdeadbeef; > + fltsave->XmmRegisters[14].High = 0xbaadf00d; > + fltsave->XmmRegisters[14].Low = 0xdeadbeef; > + fltsave->XmmRegisters[15].High = 0xbaadf00d; > + fltsave->XmmRegisters[15].Low = 0xdeadbeef; It would look better if you would use a loop or just a memset() for something like that. > + > + pRtlRestoreContext(&ctx, &rec); > + > +test_consolidate: > + done = 0; > + > + pRtlCaptureContext(&ctx); > + if (done) > + { > + ok(consolidate_dummy_called, "test_consolidate_dummy not called\n"); > + return; > + } > + done = 1; > + > + rec.ExceptionCode = STATUS_UNWIND_CONSOLIDATE; > + rec.NumberParameters = 3; > + rec.ExceptionInformation[0] = (DWORD64)test_consolidate_dummy; > + rec.ExceptionInformation[1] = (DWORD64)&ctx; > + rec.ExceptionInformation[2] = ctx.Rip; > + ctx.Rip = 0xdeadbeef; > + > + pRtlRestoreContext(&ctx, &rec); > +} > + > static RUNTIME_FUNCTION* CALLBACK dynamic_unwind_callback( DWORD64 pc, PVOID context ) > { > static const int code_offset = 1024; > @@ -2155,6 +2347,9 @@ static void test_vectored_continue_handler(void) > START_TEST(exception) > { > HMODULE hntdll = GetModuleHandleA("ntdll.dll"); > +#if defined(__x86_64__) > + HMODULE hmsvcrt = LoadLibraryA("msvcrt.dll"); > +#endif > > code_mem = VirtualAlloc(NULL, 65536, MEM_RESERVE | MEM_COMMIT, PAGE_EXECUTE_READWRITE); > if(!code_mem) { > @@ -2267,6 +2462,12 @@ START_TEST(exception) > "RtlInstallFunctionTableCallback" ); > pRtlLookupFunctionEntry = (void *)GetProcAddress( hntdll, > "RtlLookupFunctionEntry" ); > + pRtlCaptureContext = (void *)GetProcAddress( hntdll, > + "RtlCaptureContext" ); > + pRtlRestoreContext = (void *)GetProcAddress( hntdll, > + "RtlRestoreContext" ); > + p_setjmp = (void *)GetProcAddress( hmsvcrt, > + "_setjmp" ); > > test_debug_registers(); > test_outputdebugstring(1, FALSE); > @@ -2275,6 +2476,7 @@ START_TEST(exception) > test_breakpoint(1); > test_vectored_continue_handler(); > test_virtual_unwind(); > + test_restore_context(); > > if (pRtlAddFunctionTable && pRtlDeleteFunctionTable && pRtlInstallFunctionTableCallback && pRtlLookupFunctionEntry) > test_dynamic_unwind(); > -- 1.9.5 > > >

1 0

RE: TestBot job 25000 results: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext
by Daniel Lehman 15 Aug '16

15 Aug '16

> ntdll: > exception.c:523: Test failed: 42: Unexpected eip 0x2d0000/0x2d0001 > exception: unhandled exception 80000004 at 002D0000 > exception.c:520: Test failed: 42: Wrong exception code > c0000027/80000004 > exception.c:523: Test failed: 42: Unexpected eip 0x77baed97/0x2d0001 ... > > ntdll: > exception.c:1233: Test failed: Got exception offset 0x1b, expected 0x19 > exception.c:1242: Test failed: Got exception offset 0x19, expected 0x17 these are existing failures

1 0

Re: [PATCH 2/9] d3d8/tests: Add test for regression in IDirect3DDevice8_Reset().
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25060 Your paranoid android. === w864 (32 bit device) === device.c:1374: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1416: Test failed: Reset failed, hr 0x88760868. device.c:1418: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1422: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1427: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1428: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1429: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1430: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1431: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1432: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1436: Test failed: Screen width is 640, expected 800. device.c:1437: Test failed: Screen height is 480, expected 600. device.c:1443: Test failed: Back buffer width is 640, expected 800. device.c:1445: Test failed: Back buffer height is 480, expected 600. device.c:1472: Test failed: Screen width is 640, expected 1024. device.c:1473: Test failed: Screen height is 480, expected 768. device.c:1501: Test failed: Reset failed, hr 0x80070057. device.c:1503: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1515: Test failed: D3DVIEWPORT->Width = 400. device.c:1516: Test failed: D3DVIEWPORT->Height = 300. device: unhandled exception c0000005 at 75095D5B

2 1

Re: [PATCH] [preloader] Add proper CFI instructions to _start functions
by Alexandre Julliard 15 Aug '16

15 Aug '16

Keno Fischer <keno(a)juliacomputing.com> writes: > diff --git a/loader/preloader.c b/loader/preloader.c > index db0e998..8a86311 100644 > --- a/loader/preloader.c > +++ b/loader/preloader.c > @@ -212,6 +212,7 @@ struct > void _start(void); > extern char _end[]; > __ASM_GLOBAL_FUNC(_start, > + "\t.cfi_undefined %eip\n" > "\tmovl $243,%eax\n" /* SYS_set_thread_area */ > "\tmovl $thread_ldt,%ebx\n" > "\tint $0x80\n" /* allocate gs segment */ Looks OK, but it would need to be wrapped with the __ASM_CFI macro. Also could you please make sure to include your signoff? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v6)
by Henri Verbeet 15 Aug '16

15 Aug '16

On 12 August 2016 at 01:09, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface); Actually, sorry, you probably shouldn't do that in d3drm. The d3drm headers are written by hand, so IDirect3DRMFrame3_AddRef() is a macro instead of an inline function. That means that when this expands the assignment happens twice.

2 3

Re: [PATCH v4 1/3] shell32/tests: Add more tests for FolderItems.
by Alex Henrie 15 Aug '16

15 Aug '16

2016-08-14 22:20 GMT-06:00 Alex Henrie <alexhenrie24(a)gmail.com>: > v4 does not include any tests that are not necessary to demonstrate the > correctness of the FolderItems_Item implementation. This makes the > patches much smaller, and hopefully more likely to be accepted. I have > also simplified the test for FolderItems_Item with VT_ERROR, and I've > added a small test to show that FolderItems_Item doesn't accept VT_BSTR > file names. Crud, I just realized that FolderItems_Item does accept VT_BSTR file names after all. I thought I'd tested this, sorry. Please do not ignore this patchset for another 3 weeks because of this mistake. -Alex

1 0

Re: [PATCH v4 3/3] shell32: Implement FolderItems_get_Count.
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25033 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH v4 2/3] shell32: Implement FolderItems_Item.
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25032 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH v4 1/3] shell32/tests: Add more tests for FolderItems.
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25031 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH] po: Update Simplified Chinese translation (v2).
by Jactry Zeng 14 Aug '16

14 Aug '16

Hi, It looks good to me. Thanks for your contribution! :) 2016-08-14 21:52 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Reverted a translated string to the existing upstream translation, and > unmarked two extra fuzzies. > > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 927 ++++++++++++++++++++++++++++++ > +----------------------------- > 1 file changed, 477 insertions(+), 450 deletions(-) > > > > > -- Regards, Jactry Zeng

1 0

Where is winegstreamer used?
by Bruno Jesus 14 Aug '16

14 Aug '16

After looking for gstreamer related source code in Wine I could not find a place that calls winegstreamer to actually do something like video/audio decode/output. I think it should be somewhere amstream/quartz related but I'm not sure. My question is basically what I need to do (preferably with source example or documentation) to get a mpg movie to play and that ends up using winegstreamer, for example. For example with AVI files I can simply do some avifil32/msvfw32 calls and get the video output to a window. Thanks in advance, Bruno

3 5

Re: [PATCH 1/2] dwrite: Sanitize specified stretch value, valid range is [1, 9]
by Ken Thomases 13 Aug '16

13 Aug '16

On Aug 13, 2016, at 4:47 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/dwrite/opentype.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/dwrite/opentype.c b/dlls/dwrite/opentype.c > index b35f1df..ff23f51 100644 > --- a/dlls/dwrite/opentype.c > +++ b/dlls/dwrite/opentype.c > @@ -1291,8 +1291,9 @@ void opentype_get_font_properties(struct file_stream_desc *stream_desc, struct d > USHORT version = GET_BE_WORD(tt_os2->version); > USHORT fsSelection = GET_BE_WORD(tt_os2->fsSelection); > USHORT usWeightClass = GET_BE_WORD(tt_os2->usWeightClass); > + USHORT usWidthClass = GET_BE_WORD(tt_os2->usWidthClass); > > - if (GET_BE_WORD(tt_os2->usWidthClass) <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > + if (usWidthClass > DWRITE_FONT_STRETCH_UNDEFINED && usWidthClass <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > props->stretch = GET_BE_WORD(tt_os2->usWidthClass); Shouldn't you use the new usWidthClass variable in the assignment here, too? -Ken

1 0

Re: [PATCH] gdi32: Support special 'ttcf' tag in GetFontData(), fix individual collection item offset
by Huw Davies 12 Aug '16

12 Aug '16

On Fri, Aug 12, 2016 at 01:47:39AM +0300, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/gdi32/freetype.c | 53 ++++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 44 insertions(+), 9 deletions(-) > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 5ddfc6a..f4aab0b 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -394,6 +396,8 @@ struct tagGdiFont { > int codepage; > BOOL fake_italic; > BOOL fake_bold; > + BOOL is_ttc_item; > + ULONG ttc_item_offset; Since ttc_item_offset can never be zero in a ttc, you don't need the boolean. > BYTE underline; > BYTE strikeout; > INT orientation; > @@ -2189,7 +2193,7 @@ static FT_Face new_ft_face( const char *file, void *font_data_ptr, DWORD font_da > !pFT_Get_Sfnt_Table( ft_face, ft_sfnt_hhea ) || > !pFT_Get_Sfnt_Table( ft_face, ft_sfnt_head )) > { > - TRACE("Font %s/%p lacks either an OS2, HHEA or HEAD table.\n" > + TRACE("Font %s/%p lacks either an OS/2, hhea or head table.\n" > "Skipping this font.\n", debugstr_a(file), font_data_ptr); > goto fail; > } Unrelated. > @@ -4535,6 +4539,9 @@ static FT_Face OpenFontFace(GdiFont *font, Face *face, LONG width, LONG height) > font->ft_face = ft_face; > > if(FT_IS_SCALABLE(ft_face)) { > + FT_ULong len; > + DWORD header; > + > /* load the VDMX table if we have one */ > font->ppem = load_VDMX(font, height); > if(font->ppem == 0) > @@ -4543,6 +4550,22 @@ static FT_Face OpenFontFace(GdiFont *font, Face *face, LONG width, LONG height) > > if((err = pFT_Set_Pixel_Sizes(ft_face, 0, font->ppem)) != 0) > WARN("FT_Set_Pixel_Sizes %d, %d rets %x\n", 0, font->ppem, err); > + > + /* see if it's a TTC */ > + len = sizeof(header); > + if (!pFT_Load_Sfnt_Table(ft_face, 0, 0, (void*)&header, &len)) { > + const DWORD ttcf = 0x66637474; Please define and use the 'ttcf' tag. > @@ -4638,12 +4661,18 @@ static void free_font(GdiFont *font) > HeapFree(GetProcessHeap(), 0, font); > } > > +#define MS_MAKE_TAG( _x1, _x2, _x3, _x4 ) \ > + ( ( (FT_ULong)_x4 << 24 ) | \ > + ( (FT_ULong)_x3 << 16 ) | \ > + ( (FT_ULong)_x2 << 8 ) | \ > + (FT_ULong)_x1 ) We already have this define later on, we should probably move it to the top of the file (under the GET_BE_(D)WORD defines looks like a good place) and move all the various tag definitions up there too. This should be done as a separate, preliminary patch. > static DWORD get_font_data( GdiFont *font, DWORD table, DWORD offset, LPVOID buf, DWORD cbData) > { > FT_Face ft_face = font->ft_face; > FT_ULong len; > FT_Error err; > + DWORD tag; > > if (!FT_IS_SFNT(ft_face)) return GDI_ERROR; > > @@ -4652,7 +4681,17 @@ static DWORD get_font_data( GdiFont *font, DWORD table, DWORD offset, LPVOID buf > else > len = cbData; > > - table = RtlUlongByteSwap( table ); /* MS tags differ in endianness from FT ones */ > + table = RtlUlongByteSwap( tag = table ); /* MS tags differ in endianness from FT ones */ > + > + /* if font is a member of TTC, 'ttcf' tag allows reading from beginning of TTC file, > + 0 tag means to read from start of collection member data. */ > + if (font->is_ttc_item) > + { > + if (tag == MS_MAKE_TAG('t','t','c','f')) > + table = 0; > + else if (tag == 0) > + offset += font->ttc_item_offset; > + } I find the introduction of tag here confusiong. You should be able to do this without the second variable. > return GDI_ERROR; > } > return len; > @@ -8246,9 +8282,8 @@ static DWORD freetype_GetFontData( PHYSDEV dev, DWORD table, DWORD offset, LPVOI > return dev->funcs->pGetFontData( dev, table, offset, buf, cbData ); > } > > - TRACE("font=%p, table=%c%c%c%c, offset=0x%x, buf=%p, cbData=0x%x\n", > - physdev->font, LOBYTE(LOWORD(table)), HIBYTE(LOWORD(table)), > - LOBYTE(HIWORD(table)), HIBYTE(HIWORD(table)), offset, buf, cbData); > + TRACE("font=%p, table=%s, offset=0x%x, buf=%p, cbData=0x%x\n", > + physdev->font, debugstr_an((char*)&table, 4), offset, buf, cbData); Doesn't this print the tag backwards? Huw.

1 0

Re: [PATCH] ucrtbase: Add __stdio_common_vfwscanf
by Piotr Caban 12 Aug '16

12 Aug '16

On 08/11/16 19:27, Daniel Lehman wrote: > + if (options & ~UCRTBASE_SCANF_MASK) > + FIXME("options %s not handled\n", wine_dbgstr_longlong(options)); > + if (options & UCRTBASE_SCANF_SECURECRT) It would be better to compare options with UCRTBASE_SCANF_SECURECRT when printing FIXME message. Your implementation doesn't support any other options. Thanks, Piotr

1 0

Re: [PATCH] msvcrt: Add _wcreate_locale
by Piotr Caban 12 Aug '16

12 Aug '16

On 08/11/16 19:27, Daniel Lehman wrote: > + len = MSVCRT_wcstombs(NULL, locale, 0); > + if (!(str = MSVCRT_malloc(len))) return NULL; Please handle string conversion error. The allocated buffer is not big enough. Something like this should work: len = MSVCRT_wcstombs(NULL, locale, 0); if(len == -1) { ... } if(!(str = MSVCRT_malloc(len+1)) ... It may be even better to call wcstombs_s so invalid parameter handler is called (I didn't test if it should be called). Thanks, Piotr

1 0

Re: [v3] riched20: allow setting background text color
by Huw Davies 12 Aug '16

12 Aug '16

On Thu, Aug 11, 2016 at 12:22:21PM -0600, Kenneth Haley wrote: > fixes https://bugs.winehq.org/show_bug.cgi?id=36625 > > Tested on Arch Linux. Now the background is correctly painted, but there's still the issue of the background disappearing when selecting a range within a run of text that has a background. It's easy to test this using Wine's wordpad. Huw.

1 0

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v5)
by Józef Kucia 11 Aug '16

11 Aug '16

On Fri, Aug 12, 2016 at 12:48 AM, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v4: Shorter implementation. > v3: Directly traverse through parent frames instead of using GetParent. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/frame.c | 43 +++++++++++++++++++++++++++++++++++++------ > dlls/d3drm/tests/d3drm.c | 24 ++++++++++++++++++++++++ > 2 files changed, 61 insertions(+), 6 deletions(-) > > diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c > index 2ff0241..4d7ab42 100644 > --- a/dlls/d3drm/frame.c > +++ b/dlls/d3drm/frame.c > @@ -1339,23 +1339,54 @@ static HRESULT WINAPI d3drm_frame1_GetRotation(IDirect3DRMFrame *iface, > > static HRESULT WINAPI d3drm_frame3_GetScene(IDirect3DRMFrame3 *iface, IDirect3DRMFrame3 **scene) > { > - FIXME("iface %p, scene %p stub!\n", iface, scene); > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame3(iface); > > - return E_NOTIMPL; > + TRACE("iface %p, scene %p.\n", iface, scene); > + > + if (!scene) > + return D3DRMERR_BADVALUE; > + > + *scene = &frame->IDirect3DRMFrame3_iface; Do you really need this assignment? > + > + while (frame->parent) > + frame = frame->parent; > + > + IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface); > + > + return D3DRM_OK; > }

2 1

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v4)
by Henri Verbeet 11 Aug '16

11 Aug '16

On 10 August 2016 at 17:41, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + *scene = &frame->IDirect3DRMFrame3_iface; > + > + while ((frame = frame->parent)) > + *scene = &frame->IDirect3DRMFrame3_iface; > + > + IDirect3DRMFrame3_AddRef(*scene); How about: while (frame->parent) frame = frame->parent; IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface);

2 1

Re: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext
by Marvin 11 Aug '16

11 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25000 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:523: Test failed: 42: Unexpected eip 0x2d0000/0x2d0001 exception: unhandled exception 80000004 at 002D0000 exception.c:523: Test failed: 42: Unexpected eip 0x77baed97/0x2d0001 === w7u (32 bit exception) === exception.c:523: Test failed: 42: Unexpected eip 0x280000/0x280001 exception: unhandled exception 80000004 at 00280000 exception.c:523: Test failed: 42: Unexpected eip 0x77cde34f/0x280001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH 2/2] include: cpp_quote D3D10CreateDeviceAndSwapChain1.
by Henri Verbeet 11 Aug '16

11 Aug '16

On 7 August 2016 at 21:22, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > D3D10_DRIVER_TYPE is defined in d3d10misc.h, so MIDL complains that it > doesn't know about it. Would introducing d3d10misc.idl help?

2 3

xaudio2: More than 256 audio sources
by Fabian Maurer 11 Aug '16

11 Aug '16

Some applications run out of sources when using xaudio2 so I'm working on a patch that allows more than the 256 sources provided by OpenAL. I've tried a few different methods, and the current should be the easiest and most compatible. Still, I'm not perfectly familiar with the implementation of xaudio2, and I ran into lots of hard to resolve issues, so I figured I'd ask for feedback before submitting the patch. Any feedback or mistakes regarding my implementation?

2 1

Re: [PATCH 3/5] programs/services: Break services into Loader groups
by Sebastian Lackner 11 Aug '16

11 Aug '16

On 09.08.2016 18:40, Aric Stewart wrote: > > Sort the groups by the service's tag to start in order > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > programs/services/services.c | 101 ++++++++++++++++++++++++++++++++----------- > 1 file changed, 75 insertions(+), 26 deletions(-) > I believe this can be solved a bit easier. Why not just a sort function callback which sorts for both group and tag?

2 3

Re: [PATCH 2/5] programs/winedevice.exe: allow loading multiple devices on the command line
by Sebastian Lackner 11 Aug '16

11 Aug '16

On 09.08.2016 18:40, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > programs/winedevice/device.c | 92 ++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 75 insertions(+), 17 deletions(-) > I am not sure if I'm missing something, but where is this functionality used? Is it only for manual testing, or where are the corresponding changes to programs/services to pass multiple drivers in the commandline?

2 1

Re: [PATCH 4/6] d3d10core/tests: Add test for swapchain views.
by Marvin 11 Aug '16

11 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24991 Your paranoid android. === wvistau64 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w2008s64 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w8 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w864 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w1064 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === wvistau64 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4 === w2008s64 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4 === w864 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4 === w1064 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4

1 0

Re: [PATCH 4/6] d3d10core/tests: Add test for swapchain views.
by Józef Kucia 11 Aug '16

11 Aug '16

On Thu, Aug 11, 2016 at 12:57 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d10core/tests/device.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) Please ignore this patch. It seems that this is a D3D11-only feature. I'll send other test for d3d10core in the next patch series.

1 0

Re: user32: Avoid -Wmisleading-indentation warnings and fix comments in comments in test_AppendMenu.
by Dmitry Timoshkov 11 Aug '16

11 Aug '16

Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > diff --git a/dlls/user32/tests/menu.c b/dlls/user32/tests/menu.c > index 33d8eb8..ea965cd 100644 > --- a/dlls/user32/tests/menu.c > +++ b/dlls/user32/tests/menu.c > @@ -3992,13 +3992,15 @@ static void test_AppendMenu(void) > mii.wID = 206; > ret = InsertMenuItemA(hmenu, 0, TRUE, &mii); > ok(ret, "InsertMenuItem failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 206, MF_SEPARATOR, MFS_GRAYED); > +} > mii.wID = 207; > ret = SetMenuItemInfoA(hmenu, 0, TRUE, &mii); > ok(ret, "SetMenuItemInfo failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 207, MF_SEPARATOR, MFS_GRAYED); > +} > DestroyMenu(hmenu); > > hbmp = CreateBitmap(1, 1, 1, 1, NULL); Please don't make the code look uglier than it already is. I'd personally argue that checking and forcing indentation rules by a C compiler is pretty disappointing and actually misleading. That warning should be turned off by default IMHO. -- Dmitry.

3 2

Re: [PATCH] msvcr120: Add lgamma
by Piotr Caban 11 Aug '16

11 Aug '16

Hi, On 08/10/16 18:54, Daniel Lehman wrote: > +/********************************************************************* > + * lgamma (MSVCR120.@) > + */ > +double CDECL MSVCR120_lgamma(double x) > +{ > + return lgamma(x); > +} lgamma function is not a C89 function. It probably shouldn't be used without appropriate configure checks. On the other hand there are some other non C89 functions calls in this file. I don't know why/if it's OK in other cases (like e.g. y0). Thanks, Piotr

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel