- wine-devel - winehq.org

Re: [PATCH v2] secur32/tests: Don't load advapi32.dll function dynamically.
by Marvin 10 Jun '16

10 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23510 Your paranoid android. === w1064 (32 bit schannel) === schannel.c:856: Test failed: Got unexpected status 0x80090308. schannel.c:864: Test failed: Got unexpected status 0x80090308. === w1064 (64 bit schannel) === schannel.c:856: Test failed: Got unexpected status 0x80090308. schannel.c:864: Test failed: Got unexpected status 0x80090308.

1 0

Re: [PATCH 3/3] msscript: Implement Language() property
by Jacek Caban 10 Jun '16

10 Jun '16

Hi Nikolay, On 06/09/2016 07:40 PM, Nikolay Sivov wrote: > static HRESULT WINAPI ScriptControl_put_Language(IScriptControl *iface, BSTR language) > { > ScriptControl *This = impl_from_IScriptControl(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(language)); > - return E_NOTIMPL; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(language)); > + > + if (!lstrcmpiW(language, vbscriptW)) > + This->language = LANGUAGE_VBSCRIPT; > + else if (!lstrcmpiW(language, jscriptW)) > + This->language = LANGUAGE_JSCRIPT; > + else if (!language) > + This->language = LANGUAGE_UNDEFINED; > + else > + return CTL_E_INVALIDPROPERTYVALUE; Are you sure it's limited to those two languages? It counters the point of active script technology. I don't see why it couldn't handle other registered languages. See register_script_engine from MSHTML script.c tests to see how additional languages may be added. Thanks, Jacek

1 0

Re: secur32/tests: Don't load advapi32.dll function dynamically.
by Marvin 10 Jun '16

10 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23509 Your paranoid android. === w1064 (32 bit schannel) === schannel.c:854: Test failed: Got unexpected status 0x80090308. schannel.c:862: Test failed: Got unexpected status 0x80090308. === w1064 (64 bit schannel) === schannel.c:854: Test failed: Got unexpected status 0x80090308. schannel.c:862: Test failed: Got unexpected status 0x80090308.

1 0

Re: d3d9/tests: Use wine_dbgstr_rect() to print RECTs.
by Marvin 10 Jun '16

10 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23495 Your paranoid android. === w864 (64 bit device) === device.c:4351: Test failed: cw is 0xf60, expected 0x7f. device.c:4360: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4351: Test failed: cw is 0xf60, expected 0x7f. device.c:4360: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (32 bit d3d9ex) === d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=1.

2 1

Re: [PATCH 5/5] usp10: Replace zero-width glyphs with 0x20 when psa->fNoGlyphIndex is set in ScriptShapeOpenType().
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23487 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 4/5] usp10: Replace more control characters with blanks.
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23486 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 3/5] usp10: Don't replace control characters with blanks when psa->fNoGlyphIndex is set.
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23485 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 2/5] usp10: Don't modify psa->fNoGlyphIndex in ScriptShapeOpenType().
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23484 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 1/5] usp10: Set fZeroWidth when replacing control characters with blanks.
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23483 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw7 tests.
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23462 Your paranoid android. === w864 (32 bit ddraw7) === ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw7) === ddraw7.c:2270: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw7) === ddraw7.c:2270: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result.

3 3

Re: ddraw/tests: Finish the move to use wine_dbgstr_rect().
by Henri Verbeet 09 Jun '16

09 Jun '16

On 8 June 2016 at 22:38, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > Though this is more likely one of those "to be fixed by moving to > ddraw[1247].c... I'm afraid so. > I did check and there are set_display_mode() tests in those files > already. They look different but parts seem to be the same. > So something for somebody that knows that code. > For what it's worth, note that setdisplaymode() is only called by testdisplaymodes(), which is guarded by "if (winetest_interactive)". Practically speaking, that means I've run that test twice in the past 10 years, one of which was today. It fails with "ddrawmodes.c:576: Test succeeded inside todo block: Fullscreen window has wrong size", so I doubt a lot of other people are running this regularly either.

1 0

Re: [PATCH 2/4] d3drm: Fix frame object creation method.
by André Hentschel 09 Jun '16

09 Jun '16

Am 08.06.2016 um 23:49 schrieb Aaryaman Vasishta: > There is a warning generated while compiling this. It's because IDirect3DRMFrame stubs aren't in yet. I'll be adding them next patch. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- Hi Aaryaman, You should rather not send patches which generate Warnings at compile/link time...

3 3

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw4 tests.
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23461 Your paranoid android. === w864 (32 bit ddraw4) === ddraw4.c:7999: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw4) === ddraw4.c:2540: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw4.c:7999: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw4) === ddraw4.c:2540: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw4.c:7999: Test failed: Got unexpected P8 color key blit result.

1 0

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw2 tests.
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23460 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:6472: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw2) === ddraw2.c:2355: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw2.c:6472: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw2) === ddraw2.c:2355: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw2.c:6472: Test failed: Got unexpected P8 color key blit result.

1 0

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw1 tests.
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23459 Your paranoid android. === w864 (32 bit ddraw1) === ddraw1.c:5415: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw1) === ddraw1.c:2204: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw1.c:5415: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw1) === ddraw1.c:2204: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw1.c:5415: Test failed: Got unexpected P8 color key blit result.

1 0

Re: [PATCH 2/2 v3] server: Generate mouse move message when window position is changed
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23454 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:7065: Test failed: WmParentPaint: 2: the msg sequence is not complete: expected 0000 - actual 001a msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

1 0

Re: [PATCH 1/2 v3] user32: Show that mouse move message is generated every time window position is changed
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23453 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

1 0

Re: [PATCH 1/2 v2] user32: Show that mouse move message is generated every time window position is changed
by Dmitry Timoshkov 08 Jun '16

08 Jun '16

Piotr Caban <piotr(a)codeweavers.com> wrote: > v2: > - only patch 2 was changed (fixed detection when message should be > generated) If only the patch 2 was changed that means that the tests don't really cover the implementation. That rises the questions: how the logic in the patch 2 was actually discovered, and what else is missing in the tests and the implementation? -- Dmitry.

2 3

Re: [PATCH 2/2 v2] server: Generate mouse move message when window position is changed
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23452 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6731: Test failed: WmEmptySeq: 0: the msg sequence is not complete: expected 0000 - actual 001a msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === The test timed out

1 0

Re: [PATCH 1/2 v2] user32: Show that mouse move message is generated every time window position is changed
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23451 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

1 0

Re: [PATCH 2/2] server: Generate mouse move message when window position is changed
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23433 Your paranoid android. === w7u (32 bit msg) === msg.c:8922: Test failed: did not get expected count for minimum timeout (23 != ~100). msg.c:8992: Test failed: did not get expected count for minimum timeout (22 != ~100). === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:7439: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 001a === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

1 0

Re: [PATCH 1/2] user32: Show that mouse move message is generated every time window position is changed
by Marvin 08 Jun '16

08 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23432 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

1 0

Re: [PATCH 2/2] server: Generate mouse move message when window position is changed
by Piotr Caban 08 Jun '16

08 Jun '16

On 06/08/16 12:31, Piotr Caban wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/user32/tests/msg.c | 10 +++++----- > server/queue.c | 2 +- > server/user.h | 1 + > server/window.c | 3 +++ > 4 files changed, 10 insertions(+), 6 deletions(-) Please ignore this patch, it needs some improvements.

1 0

Re: [PATCH] wined3d: Add Nvidia GeForce GTS 250.
by Henri Verbeet 08 Jun '16

08 Jun '16

On 7 June 2016 at 20:22, Béla Gyebrószki <gyebro69(a)gmail.com> wrote: > --- > dlls/wined3d/directx.c | 3 ++- > dlls/wined3d/wined3d_private.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > The patch seems fine, but is missing a "Signed-off-by:" line.

1 0

Re: [PATCH 5/5] ddraw/tests: Remove p8_primary_test.
by Henri Verbeet 07 Jun '16

07 Jun '16

On 5 June 2016 at 20:45, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Other than being in the old place, this test doesn't initialize Surface1 > and randomly crashes when SetDisplayMode fails. > --- That's likely all true, but those would be reasons for fixing the test instead of removing it. Do the previous two tests in the series cover all the functionality tested by this test?

2 2

Re: [PATCH 4/5] usp10: Set the base embedding level for Script_Arabic_Numeric to 2.
by Marvin 07 Jun '16

07 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23413 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 3/5] usp10: Arabic numerals are written left-to-right.
by Marvin 07 Jun '16

07 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23412 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1473: Test failed: 0: uJustification incorrect (0) usp10.c:1473: Test failed: 1: uJustification incorrect (0) usp10.c:1473: Test failed: 2: uJustification incorrect (0) usp10.c:1473: Test failed: 3: uJustification incorrect (0) usp10.c:1473: Test failed: 4: uJustification incorrect (0) usp10.c:1473: Test failed: 5: uJustification incorrect (0) usp10.c:1473: Test failed: 6: uJustification incorrect (0) usp10.c:1473: Test failed: 7: uJustification incorrect (0) usp10.c:1473: Test failed: 8: uJustification incorrect (0) usp10.c:1473: Test failed: 9: uJustification incorrect (0) usp10.c:1489: Test failed: 3: uJustification incorrect (0) usp10.c:1489: Test failed: 5: fDiacritic incorrect (1) usp10.c:1489: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1489: Test failed: 15: fDiacritic incorrect (1) usp10.c:1489: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1473: Test failed: 0: uJustification incorrect (0) usp10.c:1473: Test failed: 1: uJustification incorrect (0) usp10.c:1473: Test failed: 2: uJustification incorrect (0) usp10.c:1473: Test failed: 3: uJustification incorrect (0) usp10.c:1473: Test failed: 4: uJustification incorrect (0) usp10.c:1473: Test failed: 5: uJustification incorrect (0) usp10.c:1473: Test failed: 6: uJustification incorrect (0) usp10.c:1473: Test failed: 7: uJustification incorrect (0) usp10.c:1473: Test failed: 8: uJustification incorrect (0) usp10.c:1473: Test failed: 9: uJustification incorrect (0) usp10.c:1489: Test failed: 3: uJustification incorrect (0) usp10.c:1489: Test failed: 5: fDiacritic incorrect (1) usp10.c:1489: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1489: Test failed: 15: fDiacritic incorrect (1) usp10.c:1489: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 1/5] ddraw/tests: Remove A4R4G4B4 ckey tests (v2).
by Henri Verbeet 07 Jun '16

07 Jun '16

On 5 June 2016 at 23:56, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > They're more broken on Nvidia + Win10 than they used to be on Nvidia + > Win7. I can't find a way to detect the problem without putting the driver > into a broken state. > > The annoying part of this is that we lose 4 bit precision tests. X4R4G4B4 > doesn't seem to exist everywhere. > --- I don't suppose there's any chance of getting the driver fixed. Would something along the lines of adapter_is_warp() work here perhaps? With recent Windows versions, I'm getting the impression that there may come a point where we'll have a maximum version to run the ddraw tests on.

2 2

Re: [PATCH 2/5] usp10: Handle C2_ARABICNUMBER as numeric.
by Marvin 07 Jun '16

07 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23411 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1473: Test failed: 0: uJustification incorrect (0) usp10.c:1473: Test failed: 1: uJustification incorrect (0) usp10.c:1473: Test failed: 2: uJustification incorrect (0) usp10.c:1473: Test failed: 3: uJustification incorrect (0) usp10.c:1473: Test failed: 4: uJustification incorrect (0) usp10.c:1473: Test failed: 5: uJustification incorrect (0) usp10.c:1473: Test failed: 6: uJustification incorrect (0) usp10.c:1473: Test failed: 7: uJustification incorrect (0) usp10.c:1473: Test failed: 8: uJustification incorrect (0) usp10.c:1473: Test failed: 9: uJustification incorrect (0) usp10.c:1489: Test failed: 3: uJustification incorrect (0) usp10.c:1489: Test failed: 5: fDiacritic incorrect (1) usp10.c:1489: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1489: Test failed: 15: fDiacritic incorrect (1) usp10.c:1489: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1473: Test failed: 0: uJustification incorrect (0) usp10.c:1473: Test failed: 1: uJustification incorrect (0) usp10.c:1473: Test failed: 2: uJustification incorrect (0) usp10.c:1473: Test failed: 3: uJustification incorrect (0) usp10.c:1473: Test failed: 4: uJustification incorrect (0) usp10.c:1473: Test failed: 5: uJustification incorrect (0) usp10.c:1473: Test failed: 6: uJustification incorrect (0) usp10.c:1473: Test failed: 7: uJustification incorrect (0) usp10.c:1473: Test failed: 8: uJustification incorrect (0) usp10.c:1473: Test failed: 9: uJustification incorrect (0) usp10.c:1489: Test failed: 3: uJustification incorrect (0) usp10.c:1489: Test failed: 5: fDiacritic incorrect (1) usp10.c:1489: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1489: Test failed: 15: fDiacritic incorrect (1) usp10.c:1489: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 1/5] usp10/tests: Add an itemisation test for Arabic numerals and punctuation.
by Marvin 07 Jun '16

07 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23410 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1473: Test failed: 0: uJustification incorrect (0) usp10.c:1473: Test failed: 1: uJustification incorrect (0) usp10.c:1473: Test failed: 2: uJustification incorrect (0) usp10.c:1473: Test failed: 3: uJustification incorrect (0) usp10.c:1473: Test failed: 4: uJustification incorrect (0) usp10.c:1473: Test failed: 5: uJustification incorrect (0) usp10.c:1473: Test failed: 6: uJustification incorrect (0) usp10.c:1473: Test failed: 7: uJustification incorrect (0) usp10.c:1473: Test failed: 8: uJustification incorrect (0) usp10.c:1473: Test failed: 9: uJustification incorrect (0) usp10.c:1489: Test failed: 3: uJustification incorrect (0) usp10.c:1489: Test failed: 5: fDiacritic incorrect (1) usp10.c:1489: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1489: Test failed: 15: fDiacritic incorrect (1) usp10.c:1489: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1473: Test failed: 0: uJustification incorrect (0) usp10.c:1473: Test failed: 1: uJustification incorrect (0) usp10.c:1473: Test failed: 2: uJustification incorrect (0) usp10.c:1473: Test failed: 3: uJustification incorrect (0) usp10.c:1473: Test failed: 4: uJustification incorrect (0) usp10.c:1473: Test failed: 5: uJustification incorrect (0) usp10.c:1473: Test failed: 6: uJustification incorrect (0) usp10.c:1473: Test failed: 7: uJustification incorrect (0) usp10.c:1473: Test failed: 8: uJustification incorrect (0) usp10.c:1473: Test failed: 9: uJustification incorrect (0) usp10.c:1489: Test failed: 3: uJustification incorrect (0) usp10.c:1489: Test failed: 5: fDiacritic incorrect (1) usp10.c:1489: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1489: Test failed: 15: fDiacritic incorrect (1) usp10.c:1489: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 1/2] d3drm/tests: Add tests for IDirect3DRM*::CreateViewport. (v2)
by Henri Verbeet 07 Jun '16

07 Jun '16

On 6 June 2016 at 15:40, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + /* Test all failures together */ > + hr = IDirect3DRM_CreateViewport(d3drm1, NULL, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > + todo_wine ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, NULL, rc.left, rc.top, rc.right, rc.bottom, &viewport); > + todo_wine ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, rc.left, rc.top, rc.right + 1, rc.bottom + 1, &viewport); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, rc.left, rc.top, rc.right + 1, rc.bottom, &viewport); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, rc.left, rc.top, rc.right, rc.bottom + 1, &viewport); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); Am I missing something, or is this test just going to leak a lot of viewport objects on Wine? > + if (FAILED(hr)) > + { > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, rc.left, rc.top, rc.right, rc.bottom, NULL); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); > + } Why the "if (FAILED(hr))"? If it's just to keep the test from crashing on Wine, it's probably easier to just fix Direct3DRMViewport_create().

1 0

Re: [PATCH 2/3] shell32/tests: Use wine_dbgstr_rect() to print RECTs.
by Marvin 07 Jun '16

07 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23394 Your paranoid android. === w1064 (32 bit ebrowser) === ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {2e228ba3-ea25-4378-97b6-d574faeba356}, riid: {2e228ba3-ea25-4378-97b6-d574faeba356} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} === w1064 (64 bit ebrowser) === ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {2e228ba3-ea25-4378-97b6-d574faeba356}, riid: {2e228ba3-ea25-4378-97b6-d574faeba356} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832}

2 1

Re: [PATCH 2/2] msscript: Implement SetClientSite()/GetClientSite()
by Marvin 07 Jun '16

07 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23391 Your paranoid android. === w2003std (32 bit msscript) === msscript: unhandled exception c0000005 at 5738B8CA

1 0

Re: [PATCH 1/2] msscript: Implement GetMiscStatus()
by Marvin 07 Jun '16

07 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23390 Your paranoid android. === w2003std (32 bit msscript) === msscript: unhandled exception c0000005 at 5738B8CA

1 0

Re: [PATCH 2/2] advapi32: add some advapi32 wmi functions (try 2)
by Sebastian Lackner 06 Jun '16

06 Jun '16

On 03.06.2016 03:53, Austin English wrote: > -- -Austin GPG: 14FB D7EA A041 937B > > > 0002-advapi32-add-some-advapi32-wmi-functions-try-2.patch > > > From 43b496fab6de5cfa6521555d2c09c9d970a0e7ec Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 1 Jun 2016 23:02:02 -0500 > Subject: [PATCH 2/2] advapi32: add some advapi32 wmi functions (try 2) > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > dlls/advapi32/Makefile.in | 3 +- > dlls/advapi32/advapi32.spec | 30 ++++---- > dlls/advapi32/eventlog.c | 9 --- > dlls/advapi32/wmi.c | 174 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 191 insertions(+), 25 deletions(-) > create mode 100644 dlls/advapi32/wmi.c > > diff --git a/dlls/advapi32/Makefile.in b/dlls/advapi32/Makefile.in > index 6b54295..ff6452a 100644 > --- a/dlls/advapi32/Makefile.in > +++ b/dlls/advapi32/Makefile.in > @@ -18,7 +18,8 @@ C_SRCS = \ > lsa.c \ > registry.c \ > security.c \ > - service.c > + service.c \ > + wmi.c > > IDL_SRCS = svcctl.idl > > diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec > index 3f32aa3..d278d67 100644 > --- a/dlls/advapi32/advapi32.spec > +++ b/dlls/advapi32/advapi32.spec > @@ -795,35 +795,35 @@ > # @ stub WmiDevInstToInstanceNameA > # @ stub WmiDevInstToInstanceNameW > # @ stub WmiEnumerateGuids > -# @ stub WmiExecuteMethodA > -# @ stub WmiExecuteMethodW > +@ stdcall WmiExecuteMethodA(long str long long ptr ptr ptr) > +@ stdcall WmiExecuteMethodW(long wstr long long ptr ptr ptr) > # @ stub WmiFileHandleToInstanceNameA > # @ stub WmiFileHandleToInstanceNameW > -# @ stub WmiFreeBuffer > +@ stdcall WmiFreeBuffer(ptr) > # @ stub WmiGetFirstTraceOffset > # @ stub WmiGetNextEvent > # @ stub WmiGetTraceHeader > -# @ stub WmiMofEnumerateResourcesA > -# @ stub WmiMofEnumerateResourcesW > -# @ stub WmiNotificationRegistrationA > -# @ stub WmiNotificationRegistrationW > -@ stdcall WmiOpenBlock(ptr long ptr) > +@ stdcall WmiMofEnumerateResourcesA(long ptr ptr) > +@ stdcall WmiMofEnumerateResourcesW(long ptr ptr) > +@ stdcall WmiNotificationRegistrationA(ptr long ptr ptr long) > +@ stdcall WmiNotificationRegistrationW(ptr long ptr ptr long) > +@ stdcall WmiOpenBlock(ptr long long) > # @ stub WmiOpenTraceWithCursor > # @ stub WmiParseTraceEvent > -# @ stub WmiQueryAllDataA > +@ stdcall WmiQueryAllDataA(long ptr ptr) > # @ stub WmiQueryAllDataMultipleA > # @ stub WmiQueryAllDataMultipleW > -# @ stub WmiQueryAllDataW > -# @ stub WmiQueryGuidInformation > +@ stdcall WmiQueryAllDataW(long ptr ptr) > +@ stdcall WmiQueryGuidInformation(long ptr) > # @ stub WmiQuerySingleInstanceA > # @ stub WmiQuerySingleInstanceMultipleA > # @ stub WmiQuerySingleInstanceMultipleW > @ stub WmiQuerySingleInstanceW > # @ stub WmiReceiveNotificationsA > # @ stub WmiReceiveNotificationsW > -# @ stub WmiSetSingleInstanceA > -@ stub WmiSetSingleInstanceW > -# @ stub WmiSetSingleItemA > -# @ stub WmiSetSingleItemW > +@ stdcall WmiSetSingleInstanceA(long str long long ptr) > +@ stdcall WmiSetSingleInstanceW(long wstr long long ptr) > +@ stdcall WmiSetSingleItemA(long str long long long ptr) > +@ stdcall WmiSetSingleItemW(long wstr long long long ptr) > # @ stub Wow64Win32ApiEntry > @ stdcall WriteEncryptedFileRaw(ptr ptr ptr) > diff --git a/dlls/advapi32/eventlog.c b/dlls/advapi32/eventlog.c > index 93c164d..7274d98 100644 > --- a/dlls/advapi32/eventlog.c > +++ b/dlls/advapi32/eventlog.c > @@ -964,12 +964,3 @@ ULONG WINAPI EnumerateTraceGuids(PTRACE_GUID_PROPERTIES *propertiesarray, > FIXME("%p %d %p: stub\n", propertiesarray, arraycount, guidcount); > return ERROR_INVALID_PARAMETER; > } > - > -/****************************************************************************** > - * WmiOpenBlock [ADVAPI32.@] > - */ > -NTSTATUS WINAPI WmiOpenBlock(GUID *guid, ULONG access, PVOID *datablock) > -{ > - FIXME("%s %d %p: stub\n", debugstr_guid(guid), access, datablock); > - return ERROR_SUCCESS; > -} > diff --git a/dlls/advapi32/wmi.c b/dlls/advapi32/wmi.c > new file mode 100644 > index 0000000..16b6094 > --- /dev/null > +++ b/dlls/advapi32/wmi.c > @@ -0,0 +1,174 @@ > +/* > + * Win32 advapi/wmi functions > + * > + * Copyright 2016 Austin English > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "winerror.h" > +#include "winternl.h" > +#include "wmistr.h" You should define _WMI_SOURCE_ before including the wmium header file. > +#include "wmium.h" > + > +#include "wine/unicode.h" > +#include "wine/debug.h" > + > +#include "advapi32_misc.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(wmi); > + > +/****************************************************************************** > + * WmiExecuteMethodA [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiExecuteMethodA(WMIHANDLE handle, const char *instance, ULONG method, ULONG inputsize, > + void *inputbuffer, ULONG *outputsize, void *outputbuffer) > +{ > + FIXME(": %p %s %u %u %p %p %p stub\n", handle, debugstr_a(instance), method, inputsize, inputbuffer, > + outputsize, outputbuffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiExecuteMethodW [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiExecuteMethodW(WMIHANDLE handle, const WCHAR *instance, ULONG method, ULONG inputsize, > + void *inputbuffer, ULONG *outputsize, void *outputbuffer) > +{ > + FIXME(": %p %s %u %u %p %p %p stub\n", handle, debugstr_w(instance), method, inputsize, inputbuffer, > + outputsize, outputbuffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiFreeBuffer [ADVAPI32.@] > + */ > +void WMIAPI WmiFreeBuffer(void *buffer) > +{ > + HeapFree(GetProcessHeap(), 0, buffer); Currently there are no functions to allocate memory, so a stub here would probably be preferred. > +} > + > +/****************************************************************************** > + * WmiMofEnumerateResourcesA [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiMofEnumerateResourcesA(MOFHANDLE handle, ULONG *count, MOFRESOURCEINFOA **resource) > +{ > + FIXME(": %p %p %p stub\n", handle, count, resource); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiMofEnumerateResourcesW [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiMofEnumerateResourcesW(MOFHANDLE handle, ULONG *count, MOFRESOURCEINFOW **resource) > +{ > + FIXME(": %p %p %p stub\n", handle, count, resource); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiNotificationRegistrationA [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiNotificationRegistrationA(GUID *guid, BOOLEAN enable, void *info, ULONG_PTR *context, ULONG flags) > +{ > + FIXME(": %p %u %p %p 0x%08x stub\n", guid, enable, info, context, flags); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiNotificationRegistrationW [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiNotificationRegistrationW(GUID *guid, BOOLEAN enable, void *info, ULONG_PTR *context, ULONG flags) > +{ > + FIXME(": %p %u %p %p 0x%08x stub\n", guid, enable, info, context, flags); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiOpenBlock [ADVAPI32.@] > + */ > +ULONG WINAPI WmiOpenBlock(GUID *guid, ULONG access, WMIHANDLE *handle) > +{ > + FIXME("%s %d %p: stub\n", debugstr_guid(guid), access, handle); > + return ERROR_SUCCESS; > +} > + > +/****************************************************************************** > + * WmiQueryAllDataA [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiQueryAllDataA(WMIHANDLE handle, ULONG *buffersize, void *buffer) > +{ > + FIXME(": %p %p %p stub\n", handle, buffersize, buffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiQueryAllDataW [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiQueryAllDataW(WMIHANDLE handle, ULONG *buffersize, void *buffer) > +{ > + FIXME(": %p %p %p stub\n", handle, buffersize, buffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiQueryGuidInformation [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiQueryGuidInformation(WMIHANDLE handle, WMIGUIDINFORMATION *guidinfo) > +{ > + FIXME(": %p %p stub\n", handle, guidinfo); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiSetSingleInstanceA [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiSetSingleInstanceA(WMIHANDLE handle, const char *name, ULONG reserved, ULONG size, void *buffer) > +{ > + FIXME(": %p %s %u %u %p stub\n", handle, debugstr_a(name), reserved, size, buffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiSetSingleInstanceW [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiSetSingleInstanceW(WMIHANDLE handle, const WCHAR *name, ULONG reserved, ULONG size, void *buffer) > +{ > + FIXME(": %p %s %u %u %p stub\n", handle, debugstr_w(name), reserved, size, buffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiSetSingleItemA [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiSetSingleItemA(WMIHANDLE handle, const char *name, ULONG id, ULONG reserved, ULONG size, void *buffer) > +{ > + FIXME(": %p %s %u %u %p stub\n", handle, debugstr_a(name), reserved, size, buffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WmiSetSingleItemW [ADVAPI32.@] > + */ > +ULONG WMIAPI WmiSetSingleItemW(WMIHANDLE handle, const WCHAR *name, ULONG id, ULONG reserved, ULONG size, void *buffer) > +{ > + FIXME(": %p %s %u %u %p stub\n", handle, debugstr_w(name), reserved, size, buffer); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > -- 2.7.3 > > >

1 0

Re: [PATCH 1/2] include: add wmium.h (try 2)
by Sebastian Lackner 06 Jun '16

06 Jun '16

On 03.06.2016 03:52, Austin English wrote: > -- -Austin GPG: 14FB D7EA A041 937B > > > 0001-include-add-wmium.h-try-2.patch > > > From 9e8d9cfd169c5233958ba0f6a1b7ec0a0559ec92 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 1 Jun 2016 22:57:12 -0500 > Subject: [PATCH 1/2] include: add wmium.h (try 2) > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > include/Makefile.in | 1 + > include/wmium.h | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 117 insertions(+) > create mode 100644 include/wmium.h > > diff --git a/include/Makefile.in b/include/Makefile.in > index 250166d..a9e0565 100644 > --- a/include/Makefile.in > +++ b/include/Makefile.in > @@ -666,6 +666,7 @@ HEADER_SRCS = \ > winver.h \ > wlanapi.h \ > wmistr.h \ > + wmium.h \ > wnaspi32.h \ > wownt32.h \ > ws2def.h \ > diff --git a/include/wmium.h b/include/wmium.h > new file mode 100644 > index 0000000..cb75ae0 > --- /dev/null > +++ b/include/wmium.h > @@ -0,0 +1,116 @@ > +/* > + * Copyright (C) 2016 Austin English > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > +#ifndef _WMIUM_ > +#define _WMIUM_ > + > +#ifdef _WMI_SOURCE_ > +#define WMIAPI __stdcall > +#else > +#define WMIAPI DECLSPEC_IMPORT __stdcall > +#endif > + > +#include <guiddef.h> > +#include <basetsd.h> > +#include <wmistr.h> > + > +typedef PVOID WMIHANDLE, *PWMIHANDLE, MOFHANDLE, *PMOFHANDLE; > + > +#define MOFCI_reserved0 0x00000001 > +#define MOFCI_reserved1 0x00000002 > +#define MOFCI_reserved2 0x00000004 Based on my header files, the "reserved" should be uppercase here. > + > +typedef struct > +{ > + char *ImagePath; > + char *ResourceName; > + ULONG ResourceSize; > + UCHAR *Resourcebuffer; Buffer should start with an uppercase letter here. > +} MOFRESOURCEINFOA, *PMOFRESOURCEINFOA; > + > +typedef struct > +{ > + WCHAR *ImagePath; > + WCHAR *ResourceName; > + ULONG ResourceSize; > + UCHAR *Resourcebuffer; Here too. > +} MOFRESOURCEINFOW, *PMOFRESOURCEINFOW; > + > +DECL_WINELIB_TYPE_AW(MOFRESOURCEINFO); > +DECL_WINELIB_TYPE_AW(PMOFRESOURCEINFO); > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +#define NOTIFICATION_TRACE_FLAG 0x00010000 > +#define NOTIFICATION_CALLBACK_DIRECT 0x00000004 > +#define NOTIFICATION_CHECK_ACCESS 0x00000008 > + > +typedef void (WINAPI *NOTIFICATIONCALLBACK)(WNODE_HEADER *, UINT_PTR); > + > +typedef struct _WMIGUIDINFORMATION > +{ > + ULONG Size; > + BOOLEAN IsExpensive; > + BOOLEAN IsEventOnly; > +} WMIGUIDINFORMATION, *PWMIGUIDINFORMATION; > + > +DEFINE_GUID(GUID_REGISTRATION_CHANGE_NOTIFICATION, 0xb48d49a1, 0xe777, 0x11d0, 0xa5, 0xc, 0x0, 0xa0, 0xc9, 0x6, 0x29, 0x10); > +DEFINE_GUID(GUID_MOF_RESOURCE_ADDED_NOTIFICATION, 0xb48d49a2, 0xe777, 0x11d0, 0xa5, 0xc, 0x0, 0xa0, 0xc9, 0x6, 0x29, 0x10); > +DEFINE_GUID(GUID_MOF_RESOURCE_REMOVED_NOTIFICATION, 0xb48d49a3, 0xe777, 0x11d0, 0xa5, 0xc, 0x0, 0xa0, 0xc9, 0x6, 0x29, 0x10); > + > +ULONG WMIAPI WmiCloseBlock(WMIHANDLE); > +ULONG WMIAPI WmiDevInstToInstanceNameA(char *, ULONG, char *, ULONG); > +ULONG WMIAPI WmiDevInstToInstanceNameW(WCHAR *, ULONG, WCHAR *, ULONG); > +ULONG WMIAPI WmiEnumerateGuids(LPGUID, ULONG *); > +ULONG WMIAPI WmiExecuteMethodA(WMIHANDLE, const char *, ULONG, ULONG, void *, ULONG *, void *); > +ULONG WMIAPI WmiExecuteMethodW(WMIHANDLE, const WCHAR *, ULONG, ULONG, void *, ULONG *, void *); > +ULONG WMIAPI WmiFileHandleToInstanceNameA(WMIHANDLE, HANDLE, ULONG *, char *); > +ULONG WMIAPI WmiFileHandleToInstanceNameW(WMIHANDLE, HANDLE, ULONG *, WCHAR *); > +void WMIAPI WmiFreeBuffer(void *); > +#define WmiInsertTimestamp(WnodeHeader) GetSystemTimeAsFileTime((FILETIME *)&((*WNODE_HEADER)WnodeHeader)->TimeStamp) I believe you wanted to write "WNODE_HEADER *" instead of "*WNODE_HEADER". > +ULONG WMIAPI WmiMofEnumerateResourcesA(MOFHANDLE, ULONG *, PMOFRESOURCEINFOA *); > +ULONG WMIAPI WmiMofEnumerateResourcesW(MOFHANDLE, ULONG *, PMOFRESOURCEINFOW *); > +ULONG WMIAPI WmiNotificationRegistrationA(LPGUID, BOOLEAN, void *, ULONG_PTR *, ULONG); > +ULONG WMIAPI WmiNotificationRegistrationW(LPGUID, BOOLEAN, void *, ULONG_PTR *, ULONG); The ULONG_PTR argument is no pointer here. > +ULONG WMIAPI WmiOpenBlock(GUID *, ULONG, WMIHANDLE *); > +ULONG WMIAPI WmiQueryAllDataA(WMIHANDLE, ULONG *, void *); > +ULONG WMIAPI WmiQueryAllDataW(WMIHANDLE, ULONG *, void *); > +ULONG WMIAPI WmiQueryGuidInformation(WMIHANDLE, PWMIGUIDINFORMATION); > +ULONG WMIAPI WmiQuerySingleInstanceA(WMIHANDLE, const char *, ULONG *, void *); > +ULONG WMIAPI WmiQuerySingleInstanceW(WMIHANDLE, const WCHAR *, ULONG *, void *); > +ULONG WMIAPI WmiSetSingleInstanceA(WMIHANDLE, const char *, ULONG, ULONG, void *); > +ULONG WMIAPI WmiSetSingleInstanceW(WMIHANDLE, const WCHAR *, ULONG, ULONG, void *); > +ULONG WMIAPI WmiSetSingleItemA(WMIHANDLE, const char *, ULONG, ULONG, ULONG, void *); > +ULONG WMIAPI WmiSetSingleItemW(WMIHANDLE, const WCHAR *, ULONG, ULONG, ULONG, void *); > + > +DECL_WINELIB_TYPE_AW(WmiDevInstToInstanceName) > +DECL_WINELIB_TYPE_AW(WmiExecuteMethod) > +DECL_WINELIB_TYPE_AW(WmiFileHandleToInstanceName) > +DECL_WINELIB_TYPE_AW(WmiMofEnumerateResources) > +DECL_WINELIB_TYPE_AW(WmiNotificationRegistration) > +DECL_WINELIB_TYPE_AW(WmiQueryAllData) > +DECL_WINELIB_TYPE_AW(WmiQuerySingleInstance) > +DECL_WINELIB_TYPE_AW(WmiSetSingleInstance) > +DECL_WINELIB_TYPE_AW(WmiSetSingleItem) > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif /* _WMIUM_ */ > -- 2.7.3 > > >

1 0

Re: [PATCH 4/6] wined3d: Create texture views for shader resource views.
by Henri Verbeet 06 Jun '16

06 Jun '16

On 6 June 2016 at 11:39, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static BOOL gl_internal_format_equal(const struct wined3d_format *format1, > + const struct wined3d_format *format2) > +{ > + return format1->id == format2->id > + || (format1->glInternal == format2->glInternal > + && format1->glGammaInternal == format2->glGammaInternal > + && format1->rtInternal == format2->rtInternal); > +} When would you use this? I was under the impression that Direct3D views were a bit more restricted then OpenGL views and only work between formats based on the same typeless format. > +static void wined3d_shader_resource_view_create_texture_view(struct wined3d_shader_resource_view *view, > + const struct wined3d_shader_resource_view_desc *desc, const struct wined3d_format *view_format, > + struct wined3d_texture *texture) > +{ > + struct wined3d_context *context = context_acquire(texture->resource.device, NULL); > + const struct wined3d_gl_info *gl_info = context->gl_info; > + struct gl_texture *gl_texture; This is fairly minor, but context_acquire() potentially does real work. It seems somewhat inappropriate to "hide" it in the declarations.

2 1

Re: [03/10] msvcirt: Implement ostream::flush
by Piotr Caban 06 Jun '16

06 Jun '16

On 06/06/16 13:52, Iván Matellanes wrote: > DEFINE_THISCALL_WRAPPER(ostream_flush, 4) > ostream* __thiscall ostream_flush(ostream *this) > { > - FIXME("(%p) stub\n", this); > + ios *base = ostream_get_ios(this); > + > + TRACE("(%p)\n", this); > + > + if (call_streambuf_sync(base->sb) == EOF) > + ios_clear(base, base->state | IOSTATE_failbit); This function should be thread-safe. Please use ios_lockbuf and ios_unlockbuf. Thanks, Piotr

1 0

Re: [PATCH 1/6] wined3d: Add wined3d_shader_resource_view_desc.
by Henri Verbeet 06 Jun '16

06 Jun '16

On 6 June 2016 at 11:39, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +enum wined3d_view_type > +{ > + WINED3D_VTYPE_BUFFER = 1, > + WINED3D_VTYPE_TEXTURE_1D = 2, > + WINED3D_VTYPE_TEXTURE_1D_ARRAY = 3, > + WINED3D_VTYPE_TEXTURE_2D = 4, > + WINED3D_VTYPE_TEXTURE_2D_ARRAY = 5, > + WINED3D_VTYPE_TEXTURE_3D = 6, > + WINED3D_VTYPE_TEXTURE_CUBE = 7, > + WINED3D_VTYPE_TEXTURE_CUBE_ARRAY = 8, > +}; > + Not a fan of the "VTYPE" in the enum elements. It does match "RTYPE" from enum wined3d_resource_type, but that is itself a leftover from when it more closely matched D3DRESOURCETYPE. > +struct wined3d_shader_resource_view_desc > +{ > + enum wined3d_format_id format_id; > + enum wined3d_view_type view_type; > + union > + { > + struct > + { > + unsigned int start_idx; > + unsigned int count; > + unsigned int flags; > + } buffer; > + struct > + { > + unsigned int level_idx; > + unsigned int level_count; > + unsigned int layer_idx; > + unsigned int layer_count; > + } texture; > + } u; > +}; Is the "view_type" field needed? I seem to remember that the view type needs to match the resource type, so you shouldn't be able to e.g. create a texture view on a buffer resource. The main other reasons I can imagine for having the field are cube views, and perhaps shaders making a distinction between array textures with a single layer and non-array textures. The latter could easily be handled by setting "layer_count" to ~0u for non-array textures, but since we have a "flags" field with plenty of extra bits, I think we could just use that to mark both cube and array views.

2 1

Re: [01/10] msvcirt: Add stub for class ostream
by Piotr Caban 06 Jun '16

06 Jun '16

On 06/06/16 13:52, Iván Matellanes wrote: > +DEFINE_THISCALL_WRAPPER(ostream_vector_dtor, 8) > +ostream* __thiscall ostream_vector_dtor(ostream *this, unsigned int flags) ostream_vector_dtor should probably take ios* as first argument. > +/* ??_Gostream@@UAEPAXI@Z */ > +DEFINE_THISCALL_WRAPPER(ostream_scalar_dtor, 8) > +ostream* __thiscall ostream_scalar_dtor(ostream *this, unsigned int flags) The same here. Thanks, Piotr

1 0

Re: [02/10] msvcirt: Implement ostream constructors/destructors
by Piotr Caban 06 Jun '16

06 Jun '16

On 06/06/16 13:52, Iván Matellanes wrote: > DEFINE_THISCALL_WRAPPER(ostream_copy_ctor, 12) > ostream* __thiscall ostream_copy_ctor(ostream *this, const ostream *copy, BOOL virt_init) > { > - FIXME("(%p %p %d) stub\n", this, copy, virt_init); > + ios *base, *copy_base; > + > + TRACE("(%p %p %d)\n", this, copy, virt_init); > + > + if (virt_init) > + this->vbtable = ostream_vbtable; > + base = ostream_get_ios(this); > + copy_base = ostream_get_ios(copy); > + ios_sb_ctor(base, copy_base->sb); > + base->vtable = &MSVCP_ostream_vtable; This is wrong if virt_init == FALSE. There should be something like: copy_base = ostream_get_ios(copy); if (virt_init) { this->vbtable = ostream_vbtable; base = ostream_get_ios(thjs); ios_sb_ctor(base, copy_base->sb); } else { base = ostream_get_ios(this); ios_init(base, copy_base->sb); } Keep in mind that this code was not tested. Please also add a test for ostream_copy_ctor(..., FALSE) call. Thanks, Piotr

1 0

Re: [PATCH 2/2] wined3d: Add some more Intel GPUs.
by Henri Verbeet 06 Jun '16

06 Jun '16

On 4 June 2016 at 22:07, Grazvydas Ignotas <notasas(a)gmail.com> wrote: > For HD Graphics 520 or newer, the whole system RAM seems to be reported > as VRAM. For now I've chosen 2048MB based on assumption that systems as > new as this will have at least 2GB of RAM. > > Signed-off-by: Grazvydas Ignotas <notasas(a)gmail.com> > --- > dlls/wined3d/directx.c | 5 +++++ > dlls/wined3d/wined3d_private.h | 5 +++++ > 2 files changed, 10 insertions(+) > This is fine, but could you also please add a generic "Skylake" fallback to cards_intel[] for cards with a different device ID?

1 0

Re: [PATCH 2/6] d3d11: Normalize more fields in SRV descriptions.
by Henri Verbeet 06 Jun '16

06 Jun '16

On 6 June 2016 at 11:39, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + case D3D11_SRV_DIMENSION_TEXTURE2DARRAY: > + if (desc->u.Texture2DArray.MipLevels == -1 && desc->u.Texture2DArray.MostDetailedMip < miplevel_count) > + desc->u.Texture2DArray.MipLevels = miplevel_count - desc->u.Texture2DArray.MostDetailedMip; > + if (desc->u.Texture2DArray.ArraySize == -1 && desc->u.Texture2DArray.FirstArraySlice < layer_count) > + desc->u.Texture2DArray.ArraySize = layer_count - desc->u.Texture2DArray.FirstArraySlice; > + break; Does that work for render target views as well?

1 0

Re: [PATCH 2/3] d3drm/tests: Add tests for IDirect3DRM*::CreateViewport.
by Stefan Dösinger 06 Jun '16

06 Jun '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-05 um 19:28 schrieb Aaryaman Vasishta: > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, 0, 0, 0, 0, &viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > + ref4 = get_refcount((IUnknown *)d3drm1); > + todo_wine ok(ref4 > ref1, "Expected ref4 > ref1, got ref1 = %u, ref4 = %u.\n", ref1, ref4); > + ref4 = get_refcount((IUnknown *)d3drm2); > + ok(ref4 == ref2, "Expected ref4 == ref2, got ref2 = %u, ref4 = %u.\n", ref2, ref4); > + ref4 = get_refcount((IUnknown *)d3drm3); > + ok(ref4 == ref3, "Expected ref4 == ref3, got ref3 = %u, ref4 = %u.\n", ref3, ref4); Does creating the viewport have any influence of the device's or the frame's refcount? > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, -1, 0, 0, 0, &viewport); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); x, y, width and height are DWORDs. -1 only makes limited sense here. It is probably better to test width and height = 0 and test x and (x + width) against the device's render target size. (smaller, matching, larger. Also obviously the same with y + height). -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXVKOEAAoJEN0/YqbEcdMwKvsP/jzDXf0eCqtCjXtfEiOlknWL iaBRAFHJnFz7fhFX1yZDX63HScoksoWw3TAby6LDX8zA0oVMWP7IYLXk+lx4xPTg mj8+lhvyPNPDl+PQ4feU/1sAwByBVR9qn6kwxgF6nsW0RXqalCeztcMxLOkC5kXZ bGbt/t4ZaCNVyZLjv5tYOcUHq+MP9Q8cKnbq3cGaivsd/cab4ORfpFccstBqLlL+ LJD65/oCtq9A+OGORVxuin7CFszSP9OR3/vFiCDMvJFjIFMWSss4gTxF4vvamD9+ Fie3E85DBWr3fBomKlKEPeky7LW0QBv5NcdzJhLaXiaCkxgKd5s54v70+2C4OSEE /N1P5v4vCjfJ8ZhFKyXJmTa6NPO0qXTnGY+HREmhva/aemTG706DaS58mWacovr1 +xx5uvMcuG2dQUGqDjp3KVKz+wLnPovfn3WoEtQ82Tvgq3g2aJbsEKHhFUjkscpG l/Ck0NcZMnQA7OxREO8+D2R7rSI+WdLyKHTrPmWc8HJ/5EWL2LE2YkdwNvjzpbTI 7fWHd5PE1NFdw7xzcHajq62485fZe1T+vt1qkMO70qjRkvlGgW/OI1VzVr7GyhSp UBxXTHrb32rQn3UD36SAYiGh6pF5HAszSAUVeesUx0VEAsP/CazZS0HHOP5fksrc MmZ1+t0cL04S8q0bGxLc =9s0i -----END PGP SIGNATURE-----

2 1

Re: user32/tests: Use EqualRect() instead of open coding it.
by Marvin 06 Jun '16

06 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23360 Your paranoid android. === w7u (32 bit msg) === msg.c:4773: Test failed: ShowWindow(SW_RESTORE):overlapped: 18: the msg sequence is not complete: expected 0000 - actual 0088 === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

2 1

Re: [PATCH] wined3d: Add #defines and logs for missing new SM5 modifiers.
by Józef Kucia 06 Jun '16

06 Jun '16

This patch isn't very useful on its own. It just changes FIXME() messages. It would be much better to save the decoded modifiers in wined3d_shader_instruction and print them in the shader tracing backend (see shader_trace_init() in shader.c). Other than that, the patch has some coding style issues. On Thu, Jun 2, 2016 at 3:49 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > --- > dlls/wined3d/shader_sm4.c | 78 ++++++++++++++++++++++++++++++++--------------- > 1 file changed, 54 insertions(+), 24 deletions(-) > > diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c > index eb8e4e5..3adaf70 100644 > --- a/dlls/wined3d/shader_sm4.c > +++ b/dlls/wined3d/shader_sm4.c > @@ -25,6 +25,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3d_shader); > WINE_DECLARE_DEBUG_CHANNEL(d3d_bytecode); > > #define WINED3D_SM4_INSTRUCTION_MODIFIER (0x1u << 31) > +#define WINED3D_SM4_MODIFIER_TYPE_MASK 0x3f > > #define WINED3D_SM4_MODIFIER_AOFFIMMI 0x1 > #define WINED3D_SM4_AOFFIMMI_U_SHIFT 9 > @@ -34,6 +35,22 @@ WINE_DECLARE_DEBUG_CHANNEL(d3d_bytecode); > #define WINED3D_SM4_AOFFIMMI_W_SHIFT 17 > #define WINED3D_SM4_AOFFIMMI_W_MASK (0xfu << WINED3D_SM4_AOFFIMMI_W_SHIFT) > > +#define WINED3D_SM5_MODIFIER_RESDIM 0x2 > +#define WINED3D_SM5_RESDIM_RES_TYPE_SHIFT 6 > +#define WINED3D_SM5_RESDIM_RES_TYPE_MASK (0x1fu << WINED3D_SM5_RESDIM_RES_TYPE_SHIFT) > +#define WINED3D_SM5_RESDIM_BUF_STRIDE_SHIFT 11 > +#define WINED3D_SM5_RESDIM_BUF_STRIDE_MASK (0xfffu << WINED3D_SM5_RESDIM_BUF_STRIDE_SHIFT) > + > +#define WINED3D_SM5_MODIFIER_RETTYPE 0x3 > +#define WINED3D_SM5_RETTYPE_X_SHIFT 6 > +#define WINED3D_SM5_RETTYPE_X_MASK (0xfu << WINED3D_SM5_RETTYPE_X_SHIFT) > +#define WINED3D_SM5_RETTYPE_Y_SHIFT 10 > +#define WINED3D_SM5_RETTYPE_Y_MASK (0xfu << WINED3D_SM5_RETTYPE_Y_SHIFT) > +#define WINED3D_SM5_RETTYPE_Z_SHIFT 14 > +#define WINED3D_SM5_RETTYPE_Z_MASK (0xfu << WINED3D_SM5_RETTYPE_Z_SHIFT) > +#define WINED3D_SM5_RETTYPE_W_SHIFT 18 > +#define WINED3D_SM5_RETTYPE_W_MASK (0xfu << WINED3D_SM5_RETTYPE_W_SHIFT) > + > #define WINED3D_SM4_INSTRUCTION_LENGTH_SHIFT 24 > #define WINED3D_SM4_INSTRUCTION_LENGTH_MASK (0x1fu << WINED3D_SM4_INSTRUCTION_LENGTH_SHIFT) > > @@ -1163,32 +1180,45 @@ static BOOL shader_sm4_read_dst_param(struct wined3d_sm4_data *priv, const DWORD > > static void shader_sm4_read_instruction_modifier(DWORD modifier, struct wined3d_shader_instruction *ins) > { > - static const DWORD recognized_bits = WINED3D_SM4_INSTRUCTION_MODIFIER > - | WINED3D_SM4_MODIFIER_AOFFIMMI > - | WINED3D_SM4_AOFFIMMI_U_MASK > - | WINED3D_SM4_AOFFIMMI_V_MASK > - | WINED3D_SM4_AOFFIMMI_W_MASK; > - > - if (modifier & ~recognized_bits) > + switch (modifier & WINED3D_SM4_MODIFIER_TYPE_MASK) > { > - FIXME("Unhandled modifier 0x%08x.\n", modifier); > - } > - else > - { > - /* Bit fields are used for sign extension */ > - struct > + case WINED3D_SM4_MODIFIER_AOFFIMMI: > { > - int u : 4; > - int v : 4; > - int w : 4; > - } > - aoffimmi; > - aoffimmi.u = (modifier & WINED3D_SM4_AOFFIMMI_U_MASK) >> WINED3D_SM4_AOFFIMMI_U_SHIFT; > - aoffimmi.v = (modifier & WINED3D_SM4_AOFFIMMI_V_MASK) >> WINED3D_SM4_AOFFIMMI_V_SHIFT; > - aoffimmi.w = (modifier & WINED3D_SM4_AOFFIMMI_W_MASK) >> WINED3D_SM4_AOFFIMMI_W_SHIFT; > - ins->texel_offset.u = aoffimmi.u; > - ins->texel_offset.v = aoffimmi.v; > - ins->texel_offset.w = aoffimmi.w; > + /* Bit fields are used for sign extension */ > + struct { > + int u : 4; > + int v : 4; > + int w : 4; > + } aoffimmi; Generally, in wined3d, curly braces should be put on their own line, i.e. struct { ... } aoffimmi; The unnamed structs seem to be an exception. The following formatting is acceptable as well: struct { ... } aofimmi; > + > + aoffimmi.u = (modifier & WINED3D_SM4_AOFFIMMI_U_MASK) >> WINED3D_SM4_AOFFIMMI_U_SHIFT; > + aoffimmi.v = (modifier & WINED3D_SM4_AOFFIMMI_V_MASK) >> WINED3D_SM4_AOFFIMMI_V_SHIFT; > + aoffimmi.w = (modifier & WINED3D_SM4_AOFFIMMI_W_MASK) >> WINED3D_SM4_AOFFIMMI_W_SHIFT; > + ins->texel_offset.u = aoffimmi.u; > + ins->texel_offset.v = aoffimmi.v; > + ins->texel_offset.w = aoffimmi.w; > + break; > + }; Please remove stray ";". > + > + case WINED3D_SM5_MODIFIER_RESDIM: > + FIXME("Unhandled modifier 0x%08x (WINED3D_SM5_MODIFIER_RESDIM, res_type=0x%02x).\n", > + modifier, > + (modifier & WINED3D_SM5_RESDIM_RES_TYPE_MASK) >> WINED3D_SM5_RESDIM_RES_TYPE_SHIFT > + ); Please avoid leaving ");" on its own line. > + break; > + > + case WINED3D_SM5_MODIFIER_RETTYPE: > + FIXME("Unhandled modifier 0x%08x (WINED3D_SM5_MODIFIER_RETTYPE, x=0x%01x, y=0x%01x, z=0x%01x, w=0x%01x).\n", > + modifier, > + (modifier & WINED3D_SM5_RETTYPE_X_MASK) >> WINED3D_SM5_RETTYPE_X_SHIFT, > + (modifier & WINED3D_SM5_RETTYPE_Y_MASK) >> WINED3D_SM5_RETTYPE_Y_SHIFT, > + (modifier & WINED3D_SM5_RETTYPE_Z_MASK) >> WINED3D_SM5_RETTYPE_Z_SHIFT, > + (modifier & WINED3D_SM5_RETTYPE_W_MASK) >> WINED3D_SM5_RETTYPE_W_SHIFT > + ); > + break; > + > + default: > + FIXME("Unhandled modifier 0x%08x.\n", modifier); > } > } > > -- > 2.7.4 > > > Thanks for working on this.

1 0

Re: [PATCH resend] wined3d : Set texture target of WINED3DFMT_NULL to 0
by Józef Kucia 06 Jun '16

06 Jun '16

On Sun, Jun 5, 2016 at 2:02 AM, Max Qian <public(a)maxqia.com> wrote: > This fixes https://bugs.winehq.org/show_bug.cgi?id=40624 > Signed-off-by: Max Qian <public(a)maxqia.com> > --- > dlls/wined3d/context.c | 4 ++-- > dlls/wined3d/wined3d_private.h | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c > index 845ca1d..323e7ac 100644 > --- a/dlls/wined3d/context.c > +++ b/dlls/wined3d/context.c > @@ -397,14 +397,14 @@ static inline void context_set_fbo_key_for_surface(const struct wined3d_context > { > case WINED3D_LOCATION_TEXTURE_RGB: > key->objects[idx].object = surface_get_texture_name(surface, context, FALSE); > - key->objects[idx].target = surface->texture_target; > + key->objects[idx].target = surface_get_texture_target(surface); > key->objects[idx].level = surface->texture_level; > key->objects[idx].layer = surface->texture_layer; > break; > > case WINED3D_LOCATION_TEXTURE_SRGB: > key->objects[idx].object = surface_get_texture_name(surface, context, TRUE); > - key->objects[idx].target = surface->texture_target; > + key->objects[idx].target = surface_get_texture_target(surface); > key->objects[idx].level = surface->texture_level; > key->objects[idx].layer = surface->texture_layer; > break; > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index f9a8ffa..00d46c0 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -3600,6 +3600,11 @@ static inline struct wined3d_surface *context_get_rt_surface(const struct wined3 > return texture->sub_resources[context->current_rt.sub_resource_idx].u.surface; > } > > +static inline GLuint surface_get_texture_target(const struct wined3d_surface *surface) > +{ > + return surface->container->resource.format->id == WINED3DFMT_NULL ? 0 : surface->texture_target; > +} > + > /* The WNDCLASS-Name for the fake window which we use to retrieve the GL capabilities */ > #define WINED3D_OPENGL_WINDOW_CLASS_NAME "WineD3D_OpenGL" > > -- > 2.8.3 > > This produces a GL error when glFramebufferTexture2D() is called.

1 0

wine-1.8.3-rc1 Available
by Michael Stefaniuc 06 Jun '16

06 Jun '16

grrr... subject copy and paste fail Hello guys, I have pushed yesterday night an informal wine-1.8.3-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ As 1.8.2 was "too big" Alexandre wanted a smaller stable release, "around 50 commits". So I've limited myself to bugs fixed up to 1.9.9. But please let me know if you have a pet bug fixed afterwards that should go into 1.8.3. Even with the limit to bugs fixed up to 1.9.9 these release still got big: - 88 commits, but a good part of them are trivial: - 16 commits to the GPU description table - 10 commits adding stubs - 15 commits to the NLS files - 55 bugs fixed of which 5 are regressions - Bigger patch series: - xaudio2 - t2embed/fontsub (includes a regression with the fix for it) - The first true backported patch (Thanks to Henri for the tip): - wined3d: Sanitise map flags in wined3d_surface_map(). - The NLS file changes skew the the diffstat numbers so here is just the dirstat: 68.5% dlls/kernel32/nls/ 5.1% dlls/kernel32/ 3.2% dlls/user32/ 5.9% dlls/xaudio2_7/ 13.2% dlls/ For the release I would follow the same procedure like the last time: Have this week for feedback, tests, etc with a hopefully final rc on Sunday so Alexandre can push out the release early / mid next week. And last but not least an excerpt from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A lot of NVidia cards added to the GPU description table. - Updates to the National Language Support files. ---------------------------------------------------------------- Bugs fixed in 1.8.3 (total 55): 10063 wineconsole run fail on korean locale. 16971 Windows Movie Maker 2.x needs ole32.dll.StgOpenPropStg 17257 TeX2Word will not install 20695 Cannot scroll documents being compared in winmerge 23768 winhelp: Some images not shown in certain 16-bit Help files 24421 MJ's Help Diagnostics crashes on startup (app provided MonitorEnumProc callback relies on ECX = lprcMonitor) 25790 WM_SETTEXT handler for the user32 buttons generates WM_CTLCOLOR* inconsistent with Windows user32 26978 tokenadmin.exe crash : Unimplemented function winscard.dll.SCardListReadersA 27680 Multiple 64-bit applications crash on startup (violation of the Windows 64-bit ABI, stack pointer (RSP) must be 16-byte aligned when making a call to Win64 API) 28082 OCCT Perestroïka needs hal.dll.READ_PORT_ULONG 28177 Adventure games from Kheops Studio hang after the logo screen (Safecracker, Destination: Treasure Island, Nostradamus: Lost Prophecy, Dracula 3, Return to Mysterious Island 2) 28825 Mystic Diary - Haunted Island: Multiple sprite-related bugs in hidden object scenes 29979 ElsterFormular crashes when trying to print already sent income tax return 31662 Office 2010 font embedding when exporting to PDF 32451 Multiple GOG.com installer bundles show a broken/unresponsive dialog window during installation (installer process running out of wndproc slots) 32979 Metal Gear Solid Crash 34070 Simutronics 'StormFront.exe' runs out of wndproc slots (ActiveSkin control) 34851 Multiple applications need kernel32 GetFinalPathNameByHandleA/W (64-bit Autodesk Fusion 360, Microsoft OneDrive) 35054 Dragon Age 2 system diagnostics tool fails to recognize GeForce GT 425M 35092 Multiple 64-bit applications need __CxxFrameHandler implementation (Ableton Live 9.1, Adobe Cloud apps) 35711 Winelib: compile error in wincon.h if NOGDI is defined before #include <windows.h> 36031 GeForce 9700M incorrectly detected as 9400 37087 Gothic 2 english demo fails with 'Conflict: a hook process was found. Please deactivate all Antivirus and Anti-Trojan programs and debuggers.' 38102 Process Hacker 2.x needs winsta.dll.WinStationEnumerateW 39092 Regression introduced with xaudio2_8 39215 Nvidia GeForce GTX960M detected as GTX470 39543 Multiple games and applications crash on unimplemented function KERNEL32.dll.FreeUserPhysicalPages (Microsoft Office 2007 diagnosis service, Eden Eternal) 39657 Tencent QQ 7.6 crashes on unimplemented function ntoskrnl.exe.PsRemoveLoadImageNotifyRoutine 39667 dinput: MotoGP 3 demo launcher crashes on leaving key configuration dialog. 39681 Unimplemented function crypt32.dll.CryptMsgVerifyCountersignatureEncoded 39730 FillRect() confuses 16bit brush handles with color constants 39759 Add support for detect Nvidia TITAN Black in wine3d/device list 39786 GoodSync crashes, needs oleaut32.OleLoadPictureFile 39796 SCP Containment Breach page fault 39918 Mail.Ru GameCenter installer does not work 39940 Stars! tooltips have wrong background color 40048 Camtasia Studio 8 : crashes on unimplemented function dwmapi.dll.DwmSetPresentParameters 40081 CLM Explorer needs fontsub.dll.CreateFontPackage 40108 kernel32:process regression 40135 msvcirt.c:1386:5: warning: comparison of unsigned expression < 0 is always false 40244 PostThreadMessage with WM_NOTIFY message should succeed 40246 Please document WINEBUILD in the winegcc manpage 40286 Geforce 980 maxwell card is not properly detected 40297 Multiple app crashes in macdrv_EnumDisplayMonitors 40304 EveHQ2 crashes with builtin gdiplus 40348 Nvidia 800 series cards not detected correctly 40389 cmd.exe (native): Unimplemented function KERNEL32.dll.GetConsoleAliasExesLengthW 40396 Windows SDK DirectWrite sample crashes on uninitialized parameter 40456 NFS MW + NFS Carbon: Car is flying above/under the track (D3DXVec3Transform needs arguments aliasing) 40466 Midnight Commander needs KERNEL32.dll.GetConsoleFontInfo 40473 wine fails to compile with >=glibc-2.23 40487 3dmark Vantage Benchmark: unimplemented functions hal.dll.READ and WRITE PORT 40493 Prison Tycoon 4 crashes on start up needing msvcp71.dll.??$?5DU?$char_traits@D@std@@@std@@YAAAV?$basic_istream@DU?$char_traits@D@std@@@0@AAV10@AAC@Z 40517 Office 2007 shows error message "Unexpected error during export" when trying to export document as PDF file 40525 schannel:main does not recognize package version 0x400000 ---------------------------------------------------------------- Changes since 1.8.2: Alex Henrie (2): ole32: Implement StgCreatePropStg. ole32: Implement StgOpenPropStg. Alexander Lakhin (2): user32: Send the correct WM_CTLCOLOR* message in button WM_SETTEXT handler. user32: Send WM_CTLCOLOR* message only for visible buttons. Alexandre Julliard (2): wineconsole: If necessary, fallback to a font without the right properties instead of failing. kernel32/nls: Convert remaining files to UTF-8. Alistair Leslie-Hughes (2): wined3d: Add detection for NVIDIA GTX TITAN. wined3d: Add detection for NVIDIA GTX TITAN Series. Andrew Eikum (6): xaudio2: Explicitly version the 2.7 coclasses. xaudio2_8: Use shared source. xaudio2: Remove run-time version checks for XAudio2 object. xaudio2: Report incoming underruns to the application. xaudio2: Protect access to source voice during creation (Coverity). xaudio2: Protect access to submix voice during creation (Coverity). Andrey Gusev (1): kernel32/nls: Update currency name and fix a typo. André Hentschel (2): xaudio2_7: Check return of IAudioClient_Start (Coverity). shell32: Provide helper function a buffer of correct size. Aurimas Fišeras (1): kernel32/nls: Update currency for Baltic states. Austin English (8): include: Fix GetCurrentConsoleFontEx/SetCurrentConsoleFontEx definition. oleaut32: Add OleLoadPictureFile stub. wine.inf: Create Microsoft Shared/TextConv directory. kernel32: Add GetConsoleFontInfo stub. winscard: Add stubs for SCardListReadersA/W. crypt32: Add CryptMsgVerifyCountersignatureEncoded stub. ntoskrnl.exe: Add PsRemoveLoadImageNotifyRoutine stub. ntoskrnl.exe: Add KeDelayExecutionThread stub. Bernhard Übelacker (1): dinput: Implement device property DIPROP_USERNAME. Caron Wills (9): wined3d: Add Nvidia GeForce GTX 860. wined3d: Add Nvidia GeForce 820M. wined3d: Add Nvidia GeForce 830M. wined3d: Add Nvidia GeForce 840M. wined3d: Add Nvidia GeForce 845M. wined3d: Add Nvidia GeForce GTX 850M. wined3d: Add Nvidia GeForce GTX 870M. wined3d: Add Nvidia GeForce GTX 880M. wined3d: Add Nvidia GeForce GT 730M. François Gouget (1): schannel: Add declarations for SECPKG version 7. Henri Verbeet (11): wined3d: Sanitise map flags in wined3d_surface_map(). wined3d: Recognise Intel Ivybridge on MacOS. kernel32/nls: Persian uses a right-to-left writing system. kernel32/nls: Use Persian characters to write Persian. kernel32/nls: Use ZWNJ where appropriate in far.nls. kernel32/nls: Persian is called Persian in English. kernel32/nls: Store LOCALE_SNATIVEDIGITS as UTF-8 in far.nls. kernel32/nls: Use Persian punctuation for LANG_PERSIAN. kernel32/nls: Fix LOCALE_IFIRSTDAYOFWEEK for LANG_PERSIAN. kernel32/nls: Return CAL_GREGORIAN_XLIT_FRENCH for LOCALE_ICALENDARTYPE for LANG_PERSIAN. kernel32/nls: Fix LOCALE_SMONTHNAME5/LOCALE_SABBREVMONTHNAME5 for LANG_PERSIAN. Iván Matellanes (1): msvcirt: Avoid superfluous comparison in some compilers. Jarkko Korpi (1): wined3d: Add detection for NVIDIA GeForce 425M. Jean-Christophe Cardot (1): winhlp32: Fix some images not shown in certain 16-bit help files. Jens Reyer (2): winegcc: Document WINEBUILD in the manpage. msiexec: Fix a typo in the manpage. Ken Thomases (1): user32: Call the EnumDisplayMonitors callback using a wrapper. Kerstin Noa (1): wined3d: Add NVIDIA GeForce GTX 980 GPU information. Kim Malmo (1): wined3d: Add Nvidia 9700M GT. Louis Lenders (4): gdiplus: GdipTransformPath should return Ok if matrix = NULL. ntdll: Add stub for RtlAddAuditAccessObjectAce and forward to AddAuditAccessObjectAce in advapi32. ntdll: Add stub for RtlAddAccessAllowedObjectAce and forward to AddAccessAllowedObjectAce in advapi32. ntdll: Add stub for RtlAddAccessDeniedObjectAce and forward to AddAccessDeniedObjectAce in advapi32. Michael Müller (2): winex11: Add 320x240 as supported resolution in desktop mode. kernel32: Implement GetFinalPathNameByHandle. Nikolay Sivov (11): user32: For EnableScrollBar() always go through EnableWindow() in SB_CTL case. t2embed: Implement TTGetEmbeddingType(). fontsub: Added CreateFontPackage() stub. fontsub: Improve CreateFontPackage() stub for TTFCFP_SUBSET case. t2embed: Implement TTIsEmbeddingEnabledForFacename(). t2embed: Implement TTIsEmbeddingEnabled(). gdi32: Increase first gdi handle value. dwrite: Always initialize context and font table pointers. kernel32/nls: Convert most of the locale data files to UTF-8. kernel32/nls: Added SSHORTESTDAYNAME* entries. kernel32/nls: Fix shortest day names for Thai and Vietnamese. Paul Gofman (1): d3dx9: D3DXVec3Transform should support input and output parameter overlap. Piotr Caban (4): msvcrt: Dump exception information in x86_64 __CxxFrameHandler. msvcrt: Handle frames with CXX_FRAME_MAGIC_VC6 and CXX_FRAME_MAGIC_VC7 magic value. user32: Call window procedure even if we're out of winproc handles. msvcp71: Add basic_istream<char>::operator>> export. Rob Walker (1): wined3d: Add Nvidia GPU SKUs 950,950M,960,960M. Sebastian Lackner (8): xaudio2_7: Unset DebugInfo->Spare[0] before destroying critical sections. user32: Set %ecx to address of rect in EnumDisplayMonitors callback. user32/tests: Add tests for button WM_CTLCOLOR* messages. user32: Do not block sending/posting WM_NOTIFY messages. kernel32/tests: Add test for process object destruction. kernel32/tests: Disable Windows version dependent test for pcPriClassBase. server: Do not hold reference on parent process. ntoskrnl.exe: Add missing linebreak to FIXME in KeDelayExecutionThread. Seong-ho Cho (1): configure: Add AC_HEADER_MAJOR to find where major() is defined. bye michael -- Michael Stefaniuc mstefani(a)winehq.org

1 0

wine-1.8.2-rc1 Available
by Michael Stefaniuc 06 Jun '16

06 Jun '16

Hello guys, I have pushed yesterday night an informal wine-1.8.3-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ As 1.8.2 was "too big" Alexandre wanted a smaller stable release, "around 50 commits". So I've limited myself to bugs fixed up to 1.9.9. But please let me know if you have a pet bug fixed afterwards that should go into 1.8.3. Even with the limit to bugs fixed up to 1.9.9 these release still got big: - 88 commits, but a good part of them are trivial: - 16 commits to the GPU description table - 10 commits adding stubs - 15 commits to the NLS files - 55 bugs fixed of which 5 are regressions - Bigger patch series: - xaudio2 - t2embed/fontsub (includes a regression with the fix for it) - The first true backported patch (Thanks to Henri for the tip): - wined3d: Sanitise map flags in wined3d_surface_map(). - The NLS file changes skew the the diffstat numbers so here is just the dirstat: 68.5% dlls/kernel32/nls/ 5.1% dlls/kernel32/ 3.2% dlls/user32/ 5.9% dlls/xaudio2_7/ 13.2% dlls/ For the release I would follow the same procedure like the last time: Have this week for feedback, tests, etc with a hopefully final rc on Sunday so Alexandre can push out the release early / mid next week. And last but not least an excerpt from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A lot of NVidia cards added to the GPU description table. - Updates to the National Language Support files. ---------------------------------------------------------------- Bugs fixed in 1.8.3 (total 55): 10063 wineconsole run fail on korean locale. 16971 Windows Movie Maker 2.x needs ole32.dll.StgOpenPropStg 17257 TeX2Word will not install 20695 Cannot scroll documents being compared in winmerge 23768 winhelp: Some images not shown in certain 16-bit Help files 24421 MJ's Help Diagnostics crashes on startup (app provided MonitorEnumProc callback relies on ECX = lprcMonitor) 25790 WM_SETTEXT handler for the user32 buttons generates WM_CTLCOLOR* inconsistent with Windows user32 26978 tokenadmin.exe crash : Unimplemented function winscard.dll.SCardListReadersA 27680 Multiple 64-bit applications crash on startup (violation of the Windows 64-bit ABI, stack pointer (RSP) must be 16-byte aligned when making a call to Win64 API) 28082 OCCT Perestroïka needs hal.dll.READ_PORT_ULONG 28177 Adventure games from Kheops Studio hang after the logo screen (Safecracker, Destination: Treasure Island, Nostradamus: Lost Prophecy, Dracula 3, Return to Mysterious Island 2) 28825 Mystic Diary - Haunted Island: Multiple sprite-related bugs in hidden object scenes 29979 ElsterFormular crashes when trying to print already sent income tax return 31662 Office 2010 font embedding when exporting to PDF 32451 Multiple GOG.com installer bundles show a broken/unresponsive dialog window during installation (installer process running out of wndproc slots) 32979 Metal Gear Solid Crash 34070 Simutronics 'StormFront.exe' runs out of wndproc slots (ActiveSkin control) 34851 Multiple applications need kernel32 GetFinalPathNameByHandleA/W (64-bit Autodesk Fusion 360, Microsoft OneDrive) 35054 Dragon Age 2 system diagnostics tool fails to recognize GeForce GT 425M 35092 Multiple 64-bit applications need __CxxFrameHandler implementation (Ableton Live 9.1, Adobe Cloud apps) 35711 Winelib: compile error in wincon.h if NOGDI is defined before #include <windows.h> 36031 GeForce 9700M incorrectly detected as 9400 37087 Gothic 2 english demo fails with 'Conflict: a hook process was found. Please deactivate all Antivirus and Anti-Trojan programs and debuggers.' 38102 Process Hacker 2.x needs winsta.dll.WinStationEnumerateW 39092 Regression introduced with xaudio2_8 39215 Nvidia GeForce GTX960M detected as GTX470 39543 Multiple games and applications crash on unimplemented function KERNEL32.dll.FreeUserPhysicalPages (Microsoft Office 2007 diagnosis service, Eden Eternal) 39657 Tencent QQ 7.6 crashes on unimplemented function ntoskrnl.exe.PsRemoveLoadImageNotifyRoutine 39667 dinput: MotoGP 3 demo launcher crashes on leaving key configuration dialog. 39681 Unimplemented function crypt32.dll.CryptMsgVerifyCountersignatureEncoded 39730 FillRect() confuses 16bit brush handles with color constants 39759 Add support for detect Nvidia TITAN Black in wine3d/device list 39786 GoodSync crashes, needs oleaut32.OleLoadPictureFile 39796 SCP Containment Breach page fault 39918 Mail.Ru GameCenter installer does not work 39940 Stars! tooltips have wrong background color 40048 Camtasia Studio 8 : crashes on unimplemented function dwmapi.dll.DwmSetPresentParameters 40081 CLM Explorer needs fontsub.dll.CreateFontPackage 40108 kernel32:process regression 40135 msvcirt.c:1386:5: warning: comparison of unsigned expression < 0 is always false 40244 PostThreadMessage with WM_NOTIFY message should succeed 40246 Please document WINEBUILD in the winegcc manpage 40286 Geforce 980 maxwell card is not properly detected 40297 Multiple app crashes in macdrv_EnumDisplayMonitors 40304 EveHQ2 crashes with builtin gdiplus 40348 Nvidia 800 series cards not detected correctly 40389 cmd.exe (native): Unimplemented function KERNEL32.dll.GetConsoleAliasExesLengthW 40396 Windows SDK DirectWrite sample crashes on uninitialized parameter 40456 NFS MW + NFS Carbon: Car is flying above/under the track (D3DXVec3Transform needs arguments aliasing) 40466 Midnight Commander needs KERNEL32.dll.GetConsoleFontInfo 40473 wine fails to compile with >=glibc-2.23 40487 3dmark Vantage Benchmark: unimplemented functions hal.dll.READ and WRITE PORT 40493 Prison Tycoon 4 crashes on start up needing msvcp71.dll.??$?5DU?$char_traits@D@std@@@std@@YAAAV?$basic_istream@DU?$char_traits@D@std@@@0@AAV10@AAC@Z 40517 Office 2007 shows error message "Unexpected error during export" when trying to export document as PDF file 40525 schannel:main does not recognize package version 0x400000 ---------------------------------------------------------------- Changes since 1.8.2: Alex Henrie (2): ole32: Implement StgCreatePropStg. ole32: Implement StgOpenPropStg. Alexander Lakhin (2): user32: Send the correct WM_CTLCOLOR* message in button WM_SETTEXT handler. user32: Send WM_CTLCOLOR* message only for visible buttons. Alexandre Julliard (2): wineconsole: If necessary, fallback to a font without the right properties instead of failing. kernel32/nls: Convert remaining files to UTF-8. Alistair Leslie-Hughes (2): wined3d: Add detection for NVIDIA GTX TITAN. wined3d: Add detection for NVIDIA GTX TITAN Series. Andrew Eikum (6): xaudio2: Explicitly version the 2.7 coclasses. xaudio2_8: Use shared source. xaudio2: Remove run-time version checks for XAudio2 object. xaudio2: Report incoming underruns to the application. xaudio2: Protect access to source voice during creation (Coverity). xaudio2: Protect access to submix voice during creation (Coverity). Andrey Gusev (1): kernel32/nls: Update currency name and fix a typo. André Hentschel (2): xaudio2_7: Check return of IAudioClient_Start (Coverity). shell32: Provide helper function a buffer of correct size. Aurimas Fišeras (1): kernel32/nls: Update currency for Baltic states. Austin English (8): include: Fix GetCurrentConsoleFontEx/SetCurrentConsoleFontEx definition. oleaut32: Add OleLoadPictureFile stub. wine.inf: Create Microsoft Shared/TextConv directory. kernel32: Add GetConsoleFontInfo stub. winscard: Add stubs for SCardListReadersA/W. crypt32: Add CryptMsgVerifyCountersignatureEncoded stub. ntoskrnl.exe: Add PsRemoveLoadImageNotifyRoutine stub. ntoskrnl.exe: Add KeDelayExecutionThread stub. Bernhard Übelacker (1): dinput: Implement device property DIPROP_USERNAME. Caron Wills (9): wined3d: Add Nvidia GeForce GTX 860. wined3d: Add Nvidia GeForce 820M. wined3d: Add Nvidia GeForce 830M. wined3d: Add Nvidia GeForce 840M. wined3d: Add Nvidia GeForce 845M. wined3d: Add Nvidia GeForce GTX 850M. wined3d: Add Nvidia GeForce GTX 870M. wined3d: Add Nvidia GeForce GTX 880M. wined3d: Add Nvidia GeForce GT 730M. François Gouget (1): schannel: Add declarations for SECPKG version 7. Henri Verbeet (11): wined3d: Sanitise map flags in wined3d_surface_map(). wined3d: Recognise Intel Ivybridge on MacOS. kernel32/nls: Persian uses a right-to-left writing system. kernel32/nls: Use Persian characters to write Persian. kernel32/nls: Use ZWNJ where appropriate in far.nls. kernel32/nls: Persian is called Persian in English. kernel32/nls: Store LOCALE_SNATIVEDIGITS as UTF-8 in far.nls. kernel32/nls: Use Persian punctuation for LANG_PERSIAN. kernel32/nls: Fix LOCALE_IFIRSTDAYOFWEEK for LANG_PERSIAN. kernel32/nls: Return CAL_GREGORIAN_XLIT_FRENCH for LOCALE_ICALENDARTYPE for LANG_PERSIAN. kernel32/nls: Fix LOCALE_SMONTHNAME5/LOCALE_SABBREVMONTHNAME5 for LANG_PERSIAN. Iván Matellanes (1): msvcirt: Avoid superfluous comparison in some compilers. Jarkko Korpi (1): wined3d: Add detection for NVIDIA GeForce 425M. Jean-Christophe Cardot (1): winhlp32: Fix some images not shown in certain 16-bit help files. Jens Reyer (2): winegcc: Document WINEBUILD in the manpage. msiexec: Fix a typo in the manpage. Ken Thomases (1): user32: Call the EnumDisplayMonitors callback using a wrapper. Kerstin Noa (1): wined3d: Add NVIDIA GeForce GTX 980 GPU information. Kim Malmo (1): wined3d: Add Nvidia 9700M GT. Louis Lenders (4): gdiplus: GdipTransformPath should return Ok if matrix = NULL. ntdll: Add stub for RtlAddAuditAccessObjectAce and forward to AddAuditAccessObjectAce in advapi32. ntdll: Add stub for RtlAddAccessAllowedObjectAce and forward to AddAccessAllowedObjectAce in advapi32. ntdll: Add stub for RtlAddAccessDeniedObjectAce and forward to AddAccessDeniedObjectAce in advapi32. Michael Müller (2): winex11: Add 320x240 as supported resolution in desktop mode. kernel32: Implement GetFinalPathNameByHandle. Nikolay Sivov (11): user32: For EnableScrollBar() always go through EnableWindow() in SB_CTL case. t2embed: Implement TTGetEmbeddingType(). fontsub: Added CreateFontPackage() stub. fontsub: Improve CreateFontPackage() stub for TTFCFP_SUBSET case. t2embed: Implement TTIsEmbeddingEnabledForFacename(). t2embed: Implement TTIsEmbeddingEnabled(). gdi32: Increase first gdi handle value. dwrite: Always initialize context and font table pointers. kernel32/nls: Convert most of the locale data files to UTF-8. kernel32/nls: Added SSHORTESTDAYNAME* entries. kernel32/nls: Fix shortest day names for Thai and Vietnamese. Paul Gofman (1): d3dx9: D3DXVec3Transform should support input and output parameter overlap. Piotr Caban (4): msvcrt: Dump exception information in x86_64 __CxxFrameHandler. msvcrt: Handle frames with CXX_FRAME_MAGIC_VC6 and CXX_FRAME_MAGIC_VC7 magic value. user32: Call window procedure even if we're out of winproc handles. msvcp71: Add basic_istream<char>::operator>> export. Rob Walker (1): wined3d: Add Nvidia GPU SKUs 950,950M,960,960M. Sebastian Lackner (8): xaudio2_7: Unset DebugInfo->Spare[0] before destroying critical sections. user32: Set %ecx to address of rect in EnumDisplayMonitors callback. user32/tests: Add tests for button WM_CTLCOLOR* messages. user32: Do not block sending/posting WM_NOTIFY messages. kernel32/tests: Add test for process object destruction. kernel32/tests: Disable Windows version dependent test for pcPriClassBase. server: Do not hold reference on parent process. ntoskrnl.exe: Add missing linebreak to FIXME in KeDelayExecutionThread. Seong-ho Cho (1): configure: Add AC_HEADER_MAJOR to find where major() is defined. bye michael -- Michael Stefaniuc mstefani(a)winehq.org

1 0

Re: [PATCH v2 1/2] msi/tests: Test for ErrorControl-flag
by Hans Leidekker 06 Jun '16

06 Jun '16

On Fri, 2016-06-03 at 19:03 +0200, Andreas Maier wrote: > This test expands a already existing test. > A Service is installed with the special ErrorControl-flag > 0x8000 (msidbServiceInstallErrorControlVital). > The flag should be filtered out be msi. The test checks, > if the service is created without this flag. Looks good. > Besides it fixes a bug in test_delete_services. > TestService was not deleted after testing. Please submit this as a separate patch and resend the whole set labeled [1/3], [2/3] and [3/3]. You also need put the fix first or mark the test todo_wine because tests should never fail on Wine between two patches.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel