- wine-devel - winehq.org

Re: [PATCH 1/8] ddraw/tests: Add some tests for draw parameter validation.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22460 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

How do I register a DirectShow class?
by Alex Henrie 22 Apr '16

22 Apr '16

Hi, I've been trying to fix <https://bugs.winehq.org/show_bug.cgi?id=32473>, you can see my work at <https://github.com/alexhenrie/wine/commits/master>. I defined the AMTimeline class and its interfaces and I added a complete stub implementation, but I'm still getting the same error: err:ole:CoGetClassObject class {78530b75-61f9-11d2-8cad-00a024580902} not registered err:ole:CoGetClassObject no class object {78530b75-61f9-11d2-8cad-00a024580902} could be created for context 0x1 What am I missing? -Alex

3 3

Re: [PATCH] qedit: List parameters in order in create function traces.
by Andrew Eikum 22 Apr '16

22 Apr '16

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Thanks. Just for my own information, are you working in this area? I'm working on video embedding in Office 2010 (Bug 40179) at the moment. Andrew On Fri, Apr 22, 2016 at 12:18:00AM -0600, Alex Henrie wrote: > Cc: Andrew Eikum <aeikum(a)codeweavers.com> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/qedit/mediadet.c | 2 +- > dlls/qedit/samplegrabber.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c > index 9098223..53ab75a 100644 > --- a/dlls/qedit/mediadet.c > +++ b/dlls/qedit/mediadet.c > @@ -640,7 +640,7 @@ static const IMediaDetVtbl IMediaDet_VTable = > HRESULT MediaDet_create(IUnknown * pUnkOuter, LPVOID * ppv) { > MediaDetImpl* obj = NULL; > > - TRACE("(%p,%p)\n", ppv, pUnkOuter); > + TRACE("(%p,%p)\n", pUnkOuter, ppv); > > obj = CoTaskMemAlloc(sizeof(MediaDetImpl)); > if (NULL == obj) { > diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c > index e9e4906..946dba9 100644 > --- a/dlls/qedit/samplegrabber.c > +++ b/dlls/qedit/samplegrabber.c > @@ -1262,7 +1262,7 @@ HRESULT SampleGrabber_create(IUnknown *pUnkOuter, LPVOID *ppv) > ISeekingPassThru *passthru; > HRESULT hr; > > - TRACE("(%p,%p)\n", ppv, pUnkOuter); > + TRACE("(%p,%p)\n", pUnkOuter, ppv); > > obj = CoTaskMemAlloc(sizeof(SG_Impl)); > if (NULL == obj) { > -- > 2.8.0 >

2 1

Re: [v6 PATCH] comctl32/tooltip: Protect TTM_ADDTOOLW from invalid text pointers
by Nikolay Sivov 22 Apr '16

22 Apr '16

On 22.04.2016 10:55, Alistair Leslie-Hughes wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=10347 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/comctl32/tests/tooltips.c | 39 +++++++++++++++++++++++++++++++++++++++ > dlls/comctl32/tooltips.c | 5 ++++- > 2 files changed, 43 insertions(+), 1 deletion(-) > > diff --git a/dlls/comctl32/tests/tooltips.c b/dlls/comctl32/tests/tooltips.c > index 3382fce..db3d3c4 100644 > --- a/dlls/comctl32/tests/tooltips.c > +++ b/dlls/comctl32/tests/tooltips.c > @@ -446,6 +446,45 @@ static void test_gettext(void) > r = SendMessageW(hwnd, TTM_ADDTOOLW, 0, (LPARAM)&toolinfoW); > ok(!r, "Adding the tool to the tooltip succeeded!\n"); > > + /* lpszText with an invalid address */ > + toolinfoW.cbSize = sizeof(TTTOOLINFOW); > + toolinfoW.hwnd = notify; > + toolinfoW.hinst = GetModuleHandleA(NULL); > + toolinfoW.uFlags = 0; > + toolinfoW.uId = 0; > + toolinfoW.lpszText = (LPWSTR)0xdeadbeef; > + toolinfoW.lParam = 0; > + GetClientRect(hwnd, &toolinfoW.rect); > + r = SendMessageA(hwnd, TTM_ADDTOOLW, 0, (LPARAM)&toolinfoW); > + ok(!r, "Adding the tool to the tooltip succeeded!\n"); > + > + /* lpszText with an callback address */ > + toolinfoW.cbSize = sizeof(TTTOOLINFOW); > + toolinfoW.hwnd = notify; > + toolinfoW.hinst = GetModuleHandleA(NULL); > + toolinfoW.uFlags = 0; > + toolinfoW.uId = 0; > + toolinfoW.lpszText = LPSTR_TEXTCALLBACKW; > + toolinfoW.lParam = 0; > + GetClientRect(hwnd, &toolinfoW.rect); > + r = SendMessageA(hwnd, TTM_ADDTOOLW, 0, (LPARAM)&toolinfoW); > + todo_wine ok(!r, "Adding the tool to the tooltip succeeded!\n"); > + This is broken, 'notify' is invalid at this point, take a look at a patch I sent couple days ago. Also these tests don't work for me even with valid string pointers, and with reduce cbSize and invalid pointers they crash on Windows. So the whole idea might be wrong. > if (0) /* crashes on NT4 */ > { > toolinfoW.hwnd = NULL; > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index 8bf6919..804e9ed 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1038,7 +1038,10 @@ TOOLTIPS_AddToolT (TOOLTIPS_INFO *infoPtr, const TTTOOLINFOW *ti, BOOL isW) > infoPtr->hwndSelf, ti->hwnd, ti->uId, > (ti->uFlags & TTF_IDISHWND) ? " TTF_IDISHWND" : ""); > > - if (ti->cbSize >= TTTOOLINFOW_V2_SIZE && !ti->lpszText && isW) > + if (ti->cbSize >= TTTOOLINFOW_V2_SIZE && isW > + && !TOOLTIPS_IsCallbackString(ti->lpszText, isW) > + && !(ti->lpszText && IS_INTRESOURCE(ti->lpszText)) > + && IsBadStringPtrW(ti->lpszText, sizeof(WCHAR)) ) > return FALSE; Text check is wrong.

1 0

Re: [PATCH] kernel32/tests: Add initial tests for GetConsoleFontInfo (v2)
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22458 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2703919542 console.c:1445: Test failed: [15] Expected output count to be 0, got 2703919542 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2703919542 console.c:1689: Test failed: [13] Expected output count to be 0, got 2703919542 console.c:1689: Test failed: [15] Expected output count to be 0, got 2703919542 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2703919542 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 1919911434 console.c:1445: Test failed: [15] Expected output count to be 0, got 1919911434 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1919911434 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 1919911434 console.c:1689: Test failed: [15] Expected output count to be 0, got 1919911434 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1919911434 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 418781008 console.c:1445: Test failed: [15] Expected output count to be 0, got 418781008 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 418781008 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 418781008 console.c:1689: Test failed: [15] Expected output count to be 0, got 418781008 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 418781008 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH v4 5/7] wined3d: Implement readback from 2D array textures using glGet[Compressed]TexImage().
by Henri Verbeet 22 Apr '16

22 Apr '16

On 22 April 2016 at 11:18, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + if (surface->texture_target == GL_TEXTURE_2D_ARRAY) > + { > + /* We don't expect to ever need to emulate NP2 textures when we have EXT_texture_array. */ > + if (texture->flags & WINED3D_TEXTURE_COND_NP2_EMULATED) > + { > + FIXME("Cannot download surface %p, level %u, layer %u.\n", > + surface, surface->texture_level, surface->texture_layer); > + return; > + } Note that you can enforce that in texture_init(). It currently checks for WINED3DUSAGE_LEGACY_CUBEMAP, but it would be easy to check the layer count instead.

1 0

Re: [PATCH] dwrite: Implement newer version of CreateFontFromLOGFONT()
by Jacek Caban 22 Apr '16

22 Apr '16

Hi Nikolay, On 04/21/16 19:48, Nikolay Sivov wrote: > + hr = IDWriteFontCollection_FindFamilyName(collection, logfont->lfFaceName, &index, &exists); > + if (FAILED(hr)) { > + IDWriteFontCollection_Release(collection); > + goto done; > + } You release collection twice in error path. Cheers, Jacek

1 0

Re: [04/10] webservices: Add support for reading double values.
by Hans Leidekker 22 Apr '16

22 Apr '16

On Fri, 2016-04-22 at 09:42 +0200, Hans Leidekker wrote: Please disregard this patch, Henri pointed out a problem with the use of strtod.

1 0

Re: kernel32/tests: Add initial tests for GetConsoleFontInfo
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22421 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 851146013 console.c:1445: Test failed: [15] Expected output count to be 0, got 851146013 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 851146013 console.c:1689: Test failed: [13] Expected output count to be 0, got 851146013 console.c:1689: Test failed: [15] Expected output count to be 0, got 851146013 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 851146013 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 844049133 console.c:1445: Test failed: [15] Expected output count to be 0, got 844049133 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 844049133 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 844049133 console.c:1689: Test failed: [15] Expected output count to be 0, got 844049133 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 844049133 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 3107847202 console.c:1445: Test failed: [15] Expected output count to be 0, got 3107847202 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3107847202 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 3107847202 console.c:1689: Test failed: [15] Expected output count to be 0, got 3107847202 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3107847202 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [PATCH] wined3d: Add detection for NVIDIA GTX TITAN Series
by Henri Verbeet 22 Apr '16

22 Apr '16

On 22 April 2016 at 09:55, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > @@ -1764,7 +1768,9 @@ cards_nvidia_binary[] = > {"GeForce 830M", CARD_NVIDIA_GEFORCE_830M}, /* GeForce 800 - mobile */ > {"GeForce 820M", CARD_NVIDIA_GEFORCE_820M}, /* GeForce 800 - mobile */ > {"GTX 780 Ti", CARD_NVIDIA_GEFORCE_GTX780TI}, /* Geforce 700 - highend */ > - {"GTX TITAN Black", CARD_NVIDIA_GEFORCE_GTXTITAN}, /* Geforce 700 - highend */ > + {"GTX TITAN", CARD_NVIDIA_GEFORCE_GTXTITAN}, /* Geforce 700 - highend */ > + {"GTX TITAN Black", CARD_NVIDIA_GEFORCE_GTXTITANB}, /* Geforce 700 - highend */ > + {"GTX TITAN Z", CARD_NVIDIA_GEFORCE_GTXTITANZ}, /* Geforce 700 - highend */ That doesn't work. The strings are matched in order, so once "GTX TITAN" is matched, "GTX TITAN Black" and "GTX TITAN Z" won't even be tried.

1 0

Re: Use todo_wine_if() in tests.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22441 Your paranoid android. === w7u (32 bit capture) === capture.c:181: Test failed: Position 1719 expected 0 capture.c:231: Test failed: Position 3063 expected 2167 capture.c:262: Test failed: Position 3063 expected 2167 capture.c:324: Test failed: Position 4407 gap 1792 capture.c:348: Test failed: Position 5751 expected 4855 capture.c:373: Test failed: Position 7095 expected 5303 === w7pro64 (32 bit capture) === capture.c:424: Test failed: Valid IAudioCaptureClient_GetBuffer returns 08890001 === w8 (32 bit capture) === capture.c:231: Test failed: Position 2167 expected 567 capture.c:262: Test failed: Position 2167 expected 567 capture.c:324: Test failed: Position 3191 gap 2176 capture.c:328: Test failed: GCP 13440 vs. BufferSize 21996 capture.c:348: Test failed: Position 4279 expected 3639 capture.c:373: Test failed: Position 5303 expected 4087 capture.c:374: Test failed: flags 1 === w864 (32 bit capture) === capture.c:181: Test failed: Position 1015 expected 0 capture.c:231: Test failed: Position 2167 expected 1463 capture.c:262: Test failed: Position 2167 expected 1463 capture.c:324: Test failed: Position 3191 gap 1280 capture.c:328: Test failed: GCP 13888 vs. BufferSize 21996 capture.c:348: Test failed: Position 4343 expected 3639 capture.c:349: Test failed: flags 1 capture.c:373: Test failed: Position 4791 expected 4087 === w1064 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:262: Test failed: Position 2167 expected 1527 capture.c:324: Test failed: Position 4151 gap 2176 capture.c:328: Test failed: GCP 11648 vs. BufferSize 21996 capture.c:348: Test failed: Position 5239 expected 4599 capture.c:349: Test failed: flags 1 capture.c:373: Test failed: Position 5687 expected 5047 === w864 (64 bit capture) === capture.c:181: Test failed: Position 1015 expected 0 capture.c:231: Test failed: Position 2167 expected 1463 capture.c:262: Test failed: Position 2167 expected 1463 capture.c:324: Test failed: Position 3127 gap 1216 capture.c:348: Test failed: Position 4215 expected 3575 capture.c:373: Test failed: Position 5303 expected 4023 === w1064 (64 bit capture) === capture.c:181: Test failed: Position 1143 expected 0 capture.c:231: Test failed: Position 2167 expected 1591 capture.c:262: Test failed: Position 2167 expected 1591 capture.c:324: Test failed: Position 4215 gap 2176 capture.c:328: Test failed: GCP 11648 vs. BufferSize 21996 capture.c:348: Test failed: Position 5303 expected 4663 capture.c:349: Test failed: flags 1 capture.c:373: Test failed: Position 7287 expected 5111 capture.c:374: Test failed: flags 1

1 0

Re: [1/2] shell32: Check IsWow64Process() before calling Wow64 functions.
by Nikolay Sivov 22 Apr '16

22 Apr '16

On 21.04.2016 3:12, Olivier F. R. Dierick wrote: > See bug 36838 for comments and discussion. > > Supersedes patch submission 121402. > > Better version of the patch. Call IsWow64Process() only once on dll > initialization and setup a global variable. > >>From e7b7317755faff75b960f9143b2195344113a9a4 Mon Sep 17 00:00:00 2001 > From: "Olivier F. R. Dierick" <o.dierick(a)piezo-forte.be> > Date: Wed, 20 Apr 2016 06:45:38 +0200 > Subject: shell32: Check IsWow64Process() before calling Wow64 functions. > > Signed-off-by: Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> > --- > dlls/shell32/shell32_main.c | 3 +++ > dlls/shell32/shell32_main.h | 1 + > dlls/shell32/shfldr_unixfs.c | 6 ++++-- > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c > index 74deecd..98e7fbf 100644 > --- a/dlls/shell32/shell32_main.c > +++ b/dlls/shell32/shell32_main.c > @@ -1255,6 +1255,7 @@ HRESULT WINAPI DllGetVersion (DLLVERSIONINFO > *pdvi) > * > */ > HINSTANCE shell32_hInstance = 0; > +BOOL is_wow64 = FALSE; > > > /************************************************************************* > @@ -1277,6 +1278,8 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD > fdwReason, LPVOID fImpLoad) > GetModuleFileNameW(hinstDLL, swShell32Name, MAX_PATH); > swShell32Name[MAX_PATH - 1] = '\0'; > > + if (!IsWow64Process( GetCurrentProcess(), &is_wow64 )) is_wow64 > = FALSE; > + > InitChangeNotifications(); > break; > > diff --git a/dlls/shell32/shell32_main.h b/dlls/shell32/shell32_main.h > index 492f79f..7a4d9b2 100644 > --- a/dlls/shell32/shell32_main.h > +++ b/dlls/shell32/shell32_main.h > @@ -42,6 +42,7 @@ > */ > extern HMODULE huser32 DECLSPEC_HIDDEN; > extern HINSTANCE shell32_hInstance DECLSPEC_HIDDEN; > +extern BOOL is_wow64 DECLSPEC_HIDDEN; > > /* Iconcache */ > #define INVALID_INDEX -1 > diff --git a/dlls/shell32/shfldr_unixfs.c b/dlls/shell32/shfldr_unixfs.c > index be1ba81..d9b1320 100644 > --- a/dlls/shell32/shfldr_unixfs.c > +++ b/dlls/shell32/shfldr_unixfs.c > @@ -414,7 +414,8 @@ static BOOL UNIXFS_get_unix_path(LPCWSTR pszDosPath, > char *pszCanonicalPath) > dospath_end = dospath + lstrlenW(dospath); > /* search for the most valid UNIX path possible, then append > missing > * path parts */ > - Wow64DisableWow64FsRedirection(&redir); > + if(is_wow64) > + Wow64DisableWow64FsRedirection(&redir); > while(!(pszUnixPath = wine_get_unix_file_name(dospath))){ > if(has_failed){ > *dospath_end = '/'; > @@ -428,7 +429,8 @@ static BOOL UNIXFS_get_unix_path(LPCWSTR pszDosPath, > char *pszCanonicalPath) > } > *dospath_end = '\0'; > } > - Wow64RevertWow64FsRedirection(redir); > + if(is_wow64) > + Wow64RevertWow64FsRedirection(redir); > if(dospath_end < dospath) > return FALSE; > strcat(szPath, pszUnixPath + cDriveSymlinkLen); > Like I said in bug comment, doing this is depending on a side effect. SHFileOperation() could do anything internally, if you want to have consistent ERROR_SUCCESS last error (even though it's kind of wrong to check it, since it returns error code already), why not force it in SHFileOperation() directly? Changing internal path is wrong in my opinion.

3 5

Re: shell32/tests: A spelling fix for an shlfolder ok() message.
by Marvin 21 Apr '16

21 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22438 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

1 0

Re: urlmon/tests: Fix a spelling error in a uri comment.
by Marvin 21 Apr '16

21 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22436 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

1 0

Re: msctf/tests: Spelling fixes for inputprocessor ok() messages.
by Marvin 21 Apr '16

21 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22434 Your paranoid android. === w864 (32 bit inputprocessor) === inputprocessor.c:793: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH 7/8] ddraw: Require exclusive mode only for primary surface flips.
by Marvin 21 Apr '16

21 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22426 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 6/8] ddraw: Allow DDSCAPS_FLIP without DDSCAPS_PRIMARYSURFACE.
by Marvin 21 Apr '16

21 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22425 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH ] msvcr120/tests: Add critical section test.(try 2)
by Piotr Caban 21 Apr '16

21 Apr '16

Hi, On 04/20/16 16:52, YongHao Hu wrote: > try 2: > Rewrite/improve the test according to Piotr's advice. > > Signed-off-by: YongHao Hu <christopherwuy(a)gmail.com> > --- > dlls/msvcr120/tests/msvcr120.c | 272 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 272 insertions(+) > The 64-bit tests are not working on Windows. I didn't look on the patch yet. Thanks, Piotr

1 0

wine 64bit support on mac.
by Diego Vicioso 21 Apr '16

21 Apr '16

Hello. So, I have tested 64bit support on os X. So far, I have encountered one problem, gta iv 64bit refuses to load a command line file I have placed in the gta iv folder. This is only in the 64bit version of wine. In the 32bit version, it works well. I have a linux ubuntu partition partition so I’ll test on that. thanks Sent from my mac

1 0

Re: [PATCH] hidclass.sys: add missing case/missing heapfree (Coverity)
by Aric Stewart 21 Apr '16

21 Apr '16

On 4/20/16 1:16 PM, Marcus Meissner wrote: > 1358558 Resource leak > > (actually switch on the enum, then the compiler will see missing cases) > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/pnp.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/pnp.c b/dlls/hidclass.sys/pnp.c > index d97184f..9ada261 100644 > --- a/dlls/hidclass.sys/pnp.c > +++ b/dlls/hidclass.sys/pnp.c > @@ -295,7 +295,7 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) > ULONG type = irpsp->Parameters.QueryId.IdType; > WCHAR *id = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(WCHAR)*REGSTR_VAL_MAX_HCID_LEN); > TRACE("IRP_MN_QUERY_ID[%i]\n", type); > - switch (type) > + switch (irpsp->Parameters.QueryId.IdType) > { > case BusQueryHardwareIDs: > case BusQueryCompatibleIDs: > @@ -326,6 +326,10 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) > irp->IoStatus.Information = (ULONG_PTR)id; > rc = STATUS_SUCCESS; > break; > + case BusQueryDeviceSerialNumber: > + FIXME("BusQueryDeviceSerialNumber not implemented\n"); > + HeapFree(GetProcessHeap(), 0, id); > + break; > } > break; > } > If we are switching on the irpsp->Parameters.QueryId.IdType then maybe we should remove the "type" variable all together? It is only used in the TRACE statement then. -aric

1 0

Re: [PATCH] winex11.drv: Use GMEM_FIXED memory for storing clipboard data.
by Alexandre Julliard 21 Apr '16

21 Apr '16

Rafał Harabień <rafalh1992(a)o2.pl> writes: > Tested behavior in Win 10. MSDN says clipboard uses GMEM_SHARED handles but its not true. > Some applications depends on GetClipboardData returning valid pointer to data instead of handle. > Commit fixes pasting from clipboard in Multi Theft Auto: San Andreas. > > Signed-off-by: Rafał Harabień <rafalh1992(a)o2.pl> > --- > dlls/user32/tests/clipboard.c | 58 ++++++++++++++++++++++++++++++++ > dlls/winex11.drv/clipboard.c | 77 +++++++++++++++++++++++++++++++++---------- > 2 files changed, 117 insertions(+), 18 deletions(-) This breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M ole32.dll -p ole32_test.exe.so clipboard && touch clipboard.ok clipboard.c:897: Test failed: got 0x145048 clipboard.c:914: Test failed: got 0x145048 Makefile:184: recipe for target 'clipboard.ok' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] gdi32/enhmfdrv: Don't drop viewport/window transformation in StretchBlt
by Huw Davies 21 Apr '16

21 Apr '16

On Wed, Apr 20, 2016 at 06:35:19PM +0200, Piotr Caban wrote: > diff --git a/dlls/gdi32/enhmfdrv/bitblt.c b/dlls/gdi32/enhmfdrv/bitblt.c > index d6d0fe7..ed03c1f 100644 > --- a/dlls/gdi32/enhmfdrv/bitblt.c > +++ b/dlls/gdi32/enhmfdrv/bitblt.c > @@ -122,7 +122,7 @@ BOOL EMFDRV_StretchBlt( PHYSDEV devDst, struct bitblt_coords *dst, > pEMR->dwRop = rop; > pEMR->xSrc = src->log_x; > pEMR->ySrc = src->log_y; > - GetWorldTransform(devSrc->hdc, &pEMR->xformSrc); > + GetTransform(devSrc->hdc, 0x204, &pEMR->xformSrc); > pEMR->crBkColorSrc = GetBkColor(devSrc->hdc); > pEMR->iUsageSrc = DIB_RGB_COLORS; > pEMR->offBmiSrc = emrSize; > This really needs a test, particularly as the docs say it should be the World -> Page transform. I agree, World -> Device makes more sense though. Huw.

1 0

Re: [2/2] shell32/tests: Check if error status is reset after successful file copy
by Marvin 21 Apr '16

21 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22410 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:297: Test failed: SHGetFileInfoA(test4.txt/) should return 1, got 0x0 shlfileop.c:2439: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2448: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2452: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2455: Test failed: does not end with .lnk shlfileop.c:83: Test failed: Failure to open file shlfileop.c:2461: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2465: Test failed: s does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2468: Test failed: s does not end with .lnk === wvistau64 (64 bit shlfileop) === shlfileop.c:297: Test failed: SHGetFileInfoA(test4.txt/) should return 1, got 0x0 shlfileop.c:2439: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2448: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2452: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2455: Test failed: does not end with .lnk shlfileop.c:83: Test failed: Failure to open file shlfileop.c:2461: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2465: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2468: Test failed: does not end with .lnk shlfileop.c:2470: Test failed: and are the same

2 1

Re: [2/2] shell32/tests: Check if error status is reset after successful file copy
by Marvin 21 Apr '16

21 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22409 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: mmdevapi/tests: Use RegQueryValueExW() for compatibility with Windows XP.
by Andrew Eikum 20 Apr '16

20 Apr '16

mmdevapi doesn't exist on winxp. I'm not opposed to this change, but does it matter? Andrew On Wed, Apr 20, 2016 at 11:52:11AM +0200, Francois Gouget wrote: > RegGetValueW() was added later and should be avoided in the conformance tests. > > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > dlls/mmdevapi/tests/propstore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/mmdevapi/tests/propstore.c b/dlls/mmdevapi/tests/propstore.c > index 06fe690..665136f 100644 > --- a/dlls/mmdevapi/tests/propstore.c > +++ b/dlls/mmdevapi/tests/propstore.c > @@ -173,7 +173,7 @@ static void test_setvalue_on_wow64(IPropertyStore *store) > > /* Note: the registry key exists even without calling IPropStore::Commit */ > size = sizeof(regval); > - ret = RegGetValueW(props, NULL, bogusW, RRF_RT_DWORD, &type, &regval, &size); > + ret = RegQueryValueExW(props, bogusW, NULL, &type, (LPBYTE)&regval, &size); > ok(ret == ERROR_SUCCESS, "Couldn't get bogus propertykey value: %u\n", ret); > ok(type == REG_DWORD, "Got wrong value type: %u\n", type); > ok(regval == 0xAB, "Got wrong value: 0x%x\n", regval); > -- > 2.8.0.rc3 > >

2 2

Re: [PATCH 4/7] wined3d: Allocate system memory for complete textures.
by Marvin 20 Apr '16

20 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22399 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 4/7] wined3d: Allocate system memory for complete textures.
by Marvin 20 Apr '16

20 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22398 Your paranoid android. === w8 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480.

1 0

Re: [PATCH v2 1/8] wined3d: Alpha test emulation for core profile contexts.
by Henri Verbeet 20 Apr '16

20 Apr '16

On 19 April 2016 at 18:56, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + /* alpha_func is the PASS condition, not the DISCARD condition. Instead of > + * flipping all the operators here, just negate the comparison below. */ As an aside, note that in general inverting operators isn't safe if there are potential NaNs involved. > + static const char *comparison_operator[] = > + { > + "", /* WINED3D_CMP_NEVER */ > + "<", /* WINED3D_CMP_LESS */ > + "==", /* WINED3D_CMP_EQUAL */ > + "<=", /* WINED3D_CMP_LESSEQUAL */ > + ">", /* WINED3D_CMP_GREATER */ > + "!=", /* WINED3D_CMP_NOTEQUAL */ > + ">=", /* WINED3D_CMP_GREATEREQUAL */ > + "" /* WINED3D_CMP_ALWAYS */ > + }; I should have noticed the first time, but I think you'll want to make the string pointers const as well. > @@ -3091,6 +3091,13 @@ void find_ps_compile_args(const struct wined3d_state *state, const struct wined3 > args->pointsprite = state->render_states[WINED3D_RS_POINTSPRITEENABLE] > && state->gl_primitive_type == GL_POINTS; > > + if (gl_info->supported[WINED3D_GL_LEGACY_CONTEXT]) > + args->alpha_test_func = WINED3D_CMP_ALWAYS - 1; > + else > + args->alpha_test_func = (state->render_states[WINED3D_RS_ALPHATESTENABLE] > + ? wined3d_sanitize_cmp_func(state->render_states[WINED3D_RS_ALPHAFUNC]) > + : WINED3D_CMP_ALWAYS) - 1; For what it's worth, what I originally had in mind was mapping WINED3D_CMP_ALWAYS to 0. I.e., masking with 7. This works as well.

2 2

Re: [PATCH 5/8] wined3d: Fixup vertex position in geometry shaders.
by Henri Verbeet 20 Apr '16

20 Apr '16

Do we need this if we have GLSL 1.50 / ARB_fragment_coord_conventions?

2 1

Re: [PATCH 3/8] wined3d: Simplify shader interface matching for SM4+ vertex shaders.
by Henri Verbeet 20 Apr '16

20 Apr '16

On 19 April 2016 at 18:56, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > After some testing it looks like, with SM4+ on Windows: > 1. Output registers have to match with input registers from the > following shader stage (register index and mask). There is no "smart" > matching of semantics like in SM3. > 2. Using uninitialized varyings in SM4+ shaders doesn't give consistent > results. > That means we can simplify the relevant code quite a bit. Applications > shouldn't be able to depend on particular values for uninitialized > varyings so we can avoid explicitly initializing them. > Does that mean we don't need the separate "reorder" shader between the stages? (Even more so if we have separate shader objects.) On 19 April 2016 at 18:56, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > -static void shader_glsl_setup_shader_output(struct shader_glsl_priv *priv, > +static void shader_glsl_setup_vs3_output(struct shader_glsl_priv *priv, > const struct wined3d_gl_info *gl_info, const DWORD *map, > const struct wined3d_shader_signature *input_signature, > const struct wined3d_shader_reg_maps *reg_maps_in, > const struct wined3d_shader_signature *output_signature, > - const struct wined3d_shader_reg_maps *reg_maps_out, const char *out_array_name) > + const struct wined3d_shader_reg_maps *reg_maps_out) > { > struct wined3d_string_buffer *destination = string_buffer_get(&priv->string_buffers); > BOOL legacy_context = gl_info->supported[WINED3D_GL_LEGACY_CONTEXT]; > @@ -5191,7 +5191,7 @@ static void shader_glsl_setup_shader_output(struct shader_glsl_priv *priv, > else if (in_idx == in_count + 1) > string_buffer_sprintf(destination, "gl_FrontSecondaryColor"); > else > - string_buffer_sprintf(destination, "%s[%u]", out_array_name, in_idx); > + string_buffer_sprintf(destination, "%s[%u]", "ps_link", in_idx); > > if (!set[in_idx]) > set[in_idx] = ~0u; > @@ -5243,7 +5243,7 @@ static void shader_glsl_setup_shader_output(struct shader_glsl_priv *priv, > else if (i == in_count + 1) > string_buffer_sprintf(destination, "gl_FrontSecondaryColor"); > else > - string_buffer_sprintf(destination, "%s[%u]", out_array_name, i); > + string_buffer_sprintf(destination, "%s[%u]", "ps_link", i); > > if (size == 1) > shader_addline(buffer, "%s.%s = 0.0;\n", destination->buffer, reg_mask); This looks like you should have just kept it the way it was in the previous patch.

2 1

Re: [PATCH 8/8] d3d11/tests: Add a geometry shader test.
by Józef Kucia 20 Apr '16

20 Apr '16

On Tue, Apr 19, 2016 at 6:56 PM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 232 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 232 insertions(+) > > diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c > index 713c9cf..0fafaaf 100644 > --- a/dlls/d3d11/tests/d3d11.c > +++ b/dlls/d3d11/tests/d3d11.c > @@ -6569,6 +6569,237 @@ static void test_getdc(void) > ok(!refcount, "Device has %u references left.\n", refcount); > } > > +static void test_geometry_shader(void) > +{ > + static const struct > + { > + struct vec4 position; > + unsigned int color; > + } > + vertex[] = > + { > + {{0.0f, 0.0f, 1.0f, 1.0f}, 0xffffff00}, > + }; > + static const D3D11_INPUT_ELEMENT_DESC layout_desc[] = > + { > + {"SV_POSITION", 0, DXGI_FORMAT_R32G32B32A32_FLOAT, 0, 0, D3D10_INPUT_PER_VERTEX_DATA, 0}, > + {"COLOR", 0, DXGI_FORMAT_R8G8B8A8_UNORM, 0, 16, D3D10_INPUT_PER_VERTEX_DATA, 0}, It would be better to use D3D11 constants. > + static const D3D_FEATURE_LEVEL feature_level = D3D_FEATURE_LEVEL_10_0; Why should we limit this test to feature level 10_0? > + buffer_desc.ByteWidth = sizeof(vertex); > + buffer_desc.Usage = D3D11_USAGE_DEFAULT; > + buffer_desc.BindFlags = D3D11_BIND_VERTEX_BUFFER; > + buffer_desc.CPUAccessFlags = 0; > + buffer_desc.MiscFlags = 0; The "StructureByteStride" field is uninitialized. I suppose it doesn't matter in practice because this field is used only for structured buffers.

2 1

Re: [PATCH ] msvcr120/tests: Add critical section test.(try 2)
by Marvin 20 Apr '16

20 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22393 Your paranoid android. === w2008s64 (64 bit msvcr120) === Found no trace of the test summary line or of a crash

1 0

Re: [PATCH 1/2] d3drm: Implement IDirect3DRM*::CreateObject (v2).
by Henri Verbeet 20 Apr '16

20 Apr '16

On 18 April 2016 at 19:00, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index a8f9c40..2b0174d 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1269,7 +1269,8 @@ static void test_destroy_callback(unsigned int test_idx, REFCLSID clsid, REFIID > context.test_idx = test_idx; > context.obj = obj; > > - hr = IDirect3DRMObject_AddDestroyCallback(obj, NULL, &context); > + if ((hr = IDirect3DRMObject_AddDestroyCallback(obj, NULL, &context)) != D3DRMERR_BADVALUE) > + return; I don't think we want that. Doing this means we won't notice when the function starts returning the wrong value, and the following tests get effectively disabled too in that case. > + hr = IDirect3DRM_CreateObject(d3drm1, &CLSID_DirectDraw, NULL, &IID_IDirectDraw, (void **)&unknown); > + ok(hr == CLASSFACTORY_E_FIRST, "Expected hr == CLASSFACTORY_E_FIRST, got %#x.\n", hr); > + ok(!unknown, "Expected object returned == NULL, got %p.\n", unknown); It would be better to initialise "unknown" with some known value before calling CreateObject(). Like this, if CreateObject() doesn't touch the value, the test may randomly pass or fail depending on what the initial value of "unknown" ends up being.

2 3

Re: [PATCH] comctl32/tooltips: Protect TTM_ADDTOOLW from invalid text pointers
by Marvin 20 Apr '16

20 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22377 Your paranoid android. === wxppro (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w2003std (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === wvistau64 (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w2008s64 (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w7u (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w7pro64 (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w8 (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w864 (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w1064 (32 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === wvistau64 (64 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w2008s64 (64 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w7pro64 (64 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w864 (64 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed! === w1064 (64 bit tooltips) === tooltips.c:471: Test failed: Adding the tool to the tooltip failed!

2 1

Re: [PATCH v3 2/8] wined3d: Implement readback from 2D array textures using glGet[Compressed]TexImage().
by Henri Verbeet 20 Apr '16

20 Apr '16

On 20 April 2016 at 11:42, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -874,7 +879,31 @@ static void surface_download_data(struct wined3d_surface *surface, const struct > return; > } > > - wined3d_texture_get_memory(texture, surface_get_sub_resource_idx(surface), &data, dst_location); > + sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx); Actually, don't use wined3d_texture_get_sub_resource() if you know the index is valid. It does extra validation that's only useful when the index comes from outside of wined3d. > + wined3d_texture_bind_and_dirtify(texture, context, !(sub_resource->locations & WINED3D_LOCATION_TEXTURE_RGB)); This is an unrelated change. In itself it's probably fine to make surface_download_data() bind the texture, but if you do that it becomes inconsistent with surface_upload_data(), wined3d_volume_download_data() and wined3d_volume_upload_data().

1 0

Re: [PATCH 05/10] wined3d: Try to avoid glGetTexImage() for 2D array textures.
by Henri Verbeet 20 Apr '16

20 Apr '16

On 19 April 2016 at 00:01, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > It's inefficient to download a complete miplevel to copy just a single layer from it. > --- Does this happen much in practice? Do you have performance numbers? The patch doesn't really make sense in its current form. surface_download_data() is meant for downloading the data from the texture. If that's not what you want, don't call it. (Also, does this actually work? It looks like it's just reading from the current drawable.)

2 4

Re: [3/3] services: Track services and processes separately.
by Alexandre Julliard 20 Apr '16

20 Apr '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > programs/services/rpc.c | 37 ++++--- > programs/services/services.c | 199 ++++++++++++++++++++++++++----------------- > programs/services/services.h | 4 > 3 files changed, 147 insertions(+), 93 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M taskschd.dll -p taskschd_test.exe.so scheduler && touch scheduler.ok scheduler.c:78: Test failed: Connect error 0x80041315 scheduler.c:101: Test failed: Connect error 0x80041315 scheduler.c:151: Test failed: Connect error 0x80041315 scheduler.c:162: Test failed: GetFolder error 0x800704e3 wine: Unhandled page fault on read access to 0x00000000 at address 0x7eff3a5e (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/5] dwrite/tests: Added GetFontSignature() test (resend)
by Sebastian Lackner 20 Apr '16

20 Apr '16

On 19.04.2016 19:10, Nikolay Sivov wrote: > + ok(fontsig.fsUsb[3] == expected_signature.fsUsb[3], "%s: fsUsb[3] %#x, expected %#x\n", wine_dbgstr_w(nameW), > + fontsig.fsUsb[0], expected_signature.fsUsb[3]); ^^^ There is a small typo here.

2 1

Re: msi/tests: Spelling fixes for some action and package ok() messages.
by Marvin 20 Apr '16

20 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22354 Your paranoid android. === wvistau64 (32 bit action) === The test timed out

1 0

Re: [PATCH 2/5] dwrite/tests: Some basic tests for fontface references
by Sebastian Lackner 20 Apr '16

20 Apr '16

On 19.04.2016 19:10, Nikolay Sivov wrote: > + hr = IDWriteFactory3_CreateFontFaceReference_(factory3, file, 0, DWRITE_FONT_SIMULATIONS_NONE, &ref); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + > + hr = IDWriteFontFaceReference_GetFontFile(ref, &file1); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + ok(file != file1, "got %p, previous file %p\n", file1, file); Also not really critical, but you might be leaking a reference to "ref" here. > + > + IDWriteFontFile_Release(file); > + IDWriteFontFile_Release(file1); > +} > IDWriteFactory3_Release(factory3); > DELETE_FONTFILE(path); > }

1 0

Re: taskschd/tests: Fix a use-after-free in scheduler tests.
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22349 Your paranoid android. === w1064 (32 bit scheduler) === scheduler.c:159: Test failed: expected ERROR_INVALID_NAME, got 0x80070002 scheduler.c:204: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:354: Test failed: expected ERROR_FILE_NOT_FOUND, got 0 scheduler.c:767: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:773: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:941: Test failed: expected ERROR_FILE_NOT_FOUND, got 0 === w1064 (64 bit scheduler) === scheduler.c:159: Test failed: expected ERROR_INVALID_NAME, got 0x80070002 scheduler.c:204: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:354: Test failed: expected ERROR_FILE_NOT_FOUND, got 0 scheduler.c:767: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:773: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:941: Test failed: expected ERROR_FILE_NOT_FOUND, got 0

2 1

Re: [3/3] user32: Send WM_CTLCOLOR* message only for visible buttons.
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22346 Your paranoid android. === w864 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different

2 1

Re: [2/3] user32/tests: Add tests for button WM_CTLCOLOR* messages.
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22345 Your paranoid android. === w864 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:7438: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 001a

1 0

Re: [PATCH 1/5] dwrite/tests: Added GetFontSignature() test
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22328 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: user32: Do not block sending/posting WM_NOTIFY messages. (v2)
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22327 Your paranoid android. === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

2 1

Re: [PATCH 5/5] dwrite: Initial implementation of IDWriteFontFaceReference
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22332 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] dwrite: Accept local loader in CreateCustomFontFileReference()
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22331 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] dwrite: Handle NULL path in CreateFontFileReference()
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22330 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] dwrite/tests: Some basic tests for fontface references
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22329 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Ignore invalid exit_frame when exiting thread.
by Alexandre Julliard 19 Apr '16

19 Apr '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > When applications switch to a custom stack, exit_frame is not necessarily > valid anymore. How does it become invalid? Does the app unmap the previous stack? -- Alexandre Julliard julliard(a)winehq.org

2 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel