- wine-devel - winehq.org

Re: ntoskrnl.exe: Fix SIB_INDEX() to use REX_X, not REX_R.
by Sebastian Lackner 12 Apr '16

12 Apr '16

On 12.04.2016 08:19, Ken Thomases wrote: > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > See <http://source.winehq.org/source/programs/winedbg/db_disasm64.c#0992> or > <http://wiki.osdev.org/X86-64_Instruction_Encoding#Encoding>, for confirmation. > > dlls/ntoskrnl.exe/instr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Good catch, thanks.

1 0

Re: [PATCH 4/5] d3d9/tests: Add some tests for the properties of the DC returned by surface GetDC().
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22131 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 3/5] ddraw/tests: Add some tests for the properties of the DC returned by surface GetDC().
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22130 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 1/5] wined3d: Be more lenient with wined3d_texture_get_dc() calls from ddraw.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22126 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 2/5] wined3d: Be more strict with wined3d_texture_get_dc() calls from d3d9.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22128 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 1/5] wined3d: Be more lenient with wined3d_texture_get_dc() calls from ddraw.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22127 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: shell32/tests: Use SetRect instead of open coding it.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22120 Your paranoid android. === w1064 (32 bit ebrowser) === ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {2e228ba3-ea25-4378-97b6-d574faeba356}, riid: {2e228ba3-ea25-4378-97b6-d574faeba356} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} === w1064 (64 bit ebrowser) === ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {2e228ba3-ea25-4378-97b6-d574faeba356}, riid: {2e228ba3-ea25-4378-97b6-d574faeba356} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} === wxppro (32 bit shlview) === shlview.c:684: Test failed: hwnd 00020126 still valid shlview.c:699: Test failed: expected 18 > 18

2 1

Re: [PATCH] d3dx9: D3DXVec3Transform should support input and output parameter overlap.
by Henri Verbeet 12 Apr '16

12 Apr '16

On 12 April 2016 at 12:09, Paul Gofman <gofmanp(a)gmail.com> wrote: > Fixes #40456. > > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/math.c | 11 +++++++---- > dlls/d3dx9_36/tests/math.c | 8 ++++++-- > 2 files changed, 13 insertions(+), 6 deletions(-) > For what it's worth, the technical term is "aliasing". And yeah, I'd expect this to be an issue in more places, so if you have the time it would be good the check the entire DLL, particularly for things working on vectors, quaternions, matrices, etc.

2 2

Re: [PATCH 1/2] d3drm/tests: Add tests for IDirect3DRM*::CreateObject (v2).
by Henri Verbeet 12 Apr '16

12 Apr '16

On 11 April 2016 at 20:04, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + hr = IDirect3DRM_CreateObject(d3drm1, NULL, NULL, tests[i].iid, (void **)&unknown); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Test %u: expected hr == D3DRMERR_BADVALUE, got %#x.\n", i, hr); Note that mentioning the expected value is mostly redundant here. It's obvious as soon as you look at the test source, and test output isn't generally useful without that. > + hr = IDirect3DRM_CreateObject(d3drm1, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > + todo_wine ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > + if (SUCCEEDED(hr)) > + { I'll point out that if you had done a "continue" on failure instead, you wouldn't need to change the indentation when you remove the todo_wine.

2 1

Re: [PATCH 05/11] dxgi: Partially implement dxgi_swapchain_GetContainingOutput().
by Henri Verbeet 12 Apr '16

12 Apr '16

On 12 April 2016 at 12:29, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > This implementation works properly for adapters that have got 1 output. > --- I could probably live with this, considering winex11 and wined3d don't properly report multiple outputs anyway, but at the same time I think it shouldn't be hard to implement this properly.

1 0

Re: [PATCH 2/4] d3d10core: Support NULL DepthStecilView pointer in ClearDepthStencilView
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22096 Your paranoid android. === wvistau64 (32 bit device) === device: unhandled exception c0000005 at 740CCE1D === w2008s64 (32 bit device) === device: unhandled exception c0000005 at 7397CE1D === wvistau64 (64 bit device) === device: unhandled exception c0000005 at 0000000074AB253F === w2008s64 (64 bit device) === device: unhandled exception c0000005 at 0000000073DB253F

2 1

Re: [PATCH 4/4] d3d10core: Support NULL RenderTargetView pointer in ClearRenderTargetView
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22098 Your paranoid android. === wvistau64 (32 bit device) === device: unhandled exception c0000005 at 73F9CBBD === w2008s64 (32 bit device) === device: unhandled exception c0000005 at 7384CBBD === wvistau64 (64 bit device) === device: unhandled exception c0000005 at 0000000074AB22BF === w2008s64 (64 bit device) === device: unhandled exception c0000005 at 00000000739B22BF

1 0

Re: [PATCH 3/4] d3d11: Support NULL RenderTargetView pointer in ClearRenderTargetView
by Józef Kucia 12 Apr '16

12 Apr '16

On Tue, Apr 12, 2016 at 9:52 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > @@ -4897,6 +4898,9 @@ static void test_update_subresource(void) > ID3D11DeviceContext_ClearRenderTargetView(context, test_context.backbuffer_rtv, red); > check_texture_color(test_context.backbuffer, 0x7f0000ff, 1); > > + ID3D11DeviceContext_ClearRenderTargetView(context, NULL, green); > + check_texture_color(test_context.backbuffer, 0x7f0000ff, 1); > + > draw_quad(&test_context); > check_texture_color(test_context.backbuffer, 0x00000000, 0); The "test_clear_render_target_view" function would be much better place for this test.

1 0

Re: user32/tests: Add some tests for dialog owner disabled state. (v3)
by Jacek Caban 12 Apr '16

12 Apr '16

Hi Dmitry, On 04/06/16 13:15, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/user32/tests/win.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 96 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c > index 957e8a1d..528669e 100644 > --- a/dlls/user32/tests/win.c > +++ b/dlls/user32/tests/win.c > @@ -4258,6 +4258,78 @@ static INT_PTR WINAPI empty_dlg_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM > return 0; > } > > +static INT_PTR WINAPI empty_dlg_proc3(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + if (msg == WM_INITDIALOG) > + EndDialog(hwnd, 0); > + > + return 0; > +} > + > +struct dialog_param > +{ > + HWND parent, grand_parent; > + DLGTEMPLATE *dlg_data; > +}; > + > +static INT_PTR WINAPI empty_dlg_proc2(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + if (msg == WM_INITDIALOG) > + { > + DWORD style = GetWindowLongA(hwnd, GWL_STYLE); > + struct dialog_param *param = (struct dialog_param *)lparam; > + BOOL parent_is_child; > + HWND disabled_hwnd; > + > + parent_is_child = (GetWindowLongA(param->parent, GWL_STYLE) & (WS_POPUP | WS_CHILD)) == WS_CHILD; > + > + ok(IsWindowEnabled(hwnd), "wrong state for %p\n", hwnd); > + if (parent_is_child) > + { > + ok(IsWindowEnabled(param->parent), "wrong state for %08x\n", style); > + disabled_hwnd = param->grand_parent; > + } > + else > + { > + ok(!IsWindowEnabled(param->parent), "wrong state for %08x\n", style); > + disabled_hwnd = param->parent; > + } > + > + if (param->grand_parent) > + { > + if (parent_is_child) > + ok(!IsWindowEnabled(param->grand_parent), "wrong state for %08x\n", style); > + else > + ok(IsWindowEnabled(param->grand_parent), "wrong state for %08x\n", style); > + } > + > + DialogBoxIndirectParamA(GetModuleHandleA(NULL), param->dlg_data, disabled_hwnd, empty_dlg_proc3, 0); > + todo_wine_if ((style & (WS_CHILD|WS_POPUP)) == WS_CHILD) > + ok(IsWindowEnabled(disabled_hwnd), "wrong state for %08x\n", style); If you ensured that disabled_hwnd is enabled here, then testing it later, after dialog is done, has very little value. Maybe you'd disable it by EnableWindow() call here? > + > + ok(IsWindowEnabled(hwnd), "wrong state for %p\n", hwnd); > + ok(IsWindowEnabled(param->parent), "wrong state for %p\n", param->parent); > + if (param->grand_parent) > + todo_wine_if ((style & (WS_CHILD|WS_POPUP)) == WS_CHILD) > + ok(IsWindowEnabled(param->grand_parent), "wrong state for %p (%08x)\n", param->grand_parent, style); > + > + DialogBoxIndirectParamA(GetModuleHandleA(NULL), param->dlg_data, hwnd, empty_dlg_proc3, 0); > + ok(IsWindowEnabled(hwnd), "wrong state for %p\n", hwnd); > + ok(IsWindowEnabled(param->parent), "wrong state for %p\n", param->parent); > + if (param->grand_parent) > + todo_wine_if ((style & (WS_CHILD|WS_POPUP)) == WS_CHILD) > + ok(IsWindowEnabled(param->grand_parent), "wrong state for %p (%08x)\n", param->grand_parent, style); Why do you put those tests inside WM_INITDIALOG? Wouldn't separated tests be cleaner? > + param->dlg_data->style |= WS_CHILD; > + DialogBoxIndirectParamA(GetModuleHandleA(NULL), param->dlg_data, hwnd, empty_dlg_proc3, 0); > + todo_wine_if (!(style & (WS_CHILD|WS_POPUP))) > + ok(IsWindowEnabled(hwnd), "wrong state for %p (%08x)\n", hwnd, style); > + > + EndDialog(hwnd, 0); Testing that EndDialog enables window would be nice (given that it's disabled as I said above). > + } > + return 0; > +} > + > static void check_dialog_style(DWORD style_in, DWORD ex_style_in, DWORD style_out, DWORD ex_style_out) > { > struct > @@ -4269,11 +4341,19 @@ static void check_dialog_style(DWORD style_in, DWORD ex_style_in, DWORD style_ou > WCHAR caption[1]; > } dlg_data; > DWORD style, ex_style; > - HWND hwnd, parent = 0; > + HWND hwnd, grand_parent = 0, parent = 0; > + struct dialog_param param; > > if (style_in & WS_CHILD) > - parent = CreateWindowExA(0, "static", NULL, WS_OVERLAPPEDWINDOW, > + { > + grand_parent = CreateWindowExA(0, "static", NULL, WS_OVERLAPPEDWINDOW, > 0, 0, 0, 0, NULL, NULL, NULL, NULL); > + ok(grand_parent != 0, "grand_parent creation failed\n"); > + } > + > + parent = CreateWindowExA(0, "static", NULL, style_in, > + 0, 0, 0, 0, grand_parent, NULL, NULL, NULL); > + ok(parent != 0, "parent creation failed, style %#x\n", style_in); Always creating window here changes existing tests. It's not a big deal, I wouldn't expect it to change much, but still, the case that's currently tested will no longer be tested. Jacek

3 6

Re: [PATCH 2/3] ole32: Fix memory leak in CompositeMonikerImpl_Construct.
by Alexandre Julliard 12 Apr '16

12 Apr '16

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -1848,8 +1848,10 @@ CompositeMonikerImpl_Construct(IMoniker **ppMoniker, IMoniker *pmkFirst, IMonike > IMoniker_Release(This->tabMoniker[This->tabLastIndex-1]); > > This->tabMoniker[This->tabLastIndex-1]=tempMk; > - } else > + } else{ > + HeapFree(GetProcessHeap(), 0, This); > return res; > + } You'd need to free the contents too, at least This->tabMoniker and its references. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-1.8.2-rc3 Available
by Michael Stefaniuc 11 Apr '16

11 Apr '16

Hello Alexandre, I have just pushed commit 74dbed07afbeda2e707424f1def138ec857da2b8 Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Thu Apr 7 14:25:40 2016 +0200 Release 1.8.2. as wine-1.8.2-rc3. It needs the configure change and your rubber stamp to call it 1.8.2. The only additions on top of 1.8.2-rc2 are your make_announce patch and the release commit. thanks bye michael

1 2

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22089 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22088 Your paranoid android. === wvistau64 (32 bit action) === The test timed out

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22087 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22082 Your paranoid android. === w1064 (64 bit chain) === The test timed out

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22080 Your paranoid android. === w864 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22074 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22072 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

1 0

Re: [PATCH 7/7] d3d8/tests: Add a system memory miptree layout test.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22069 Your paranoid android. === w8 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480. === w1064 (32 bit device) === device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 6/7] d3d9/tests: Add a system memory miptree layout test.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22068 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

EVE using Wine on Mac
by Snorri Sturluson 11 Apr '16

11 Apr '16

About a month ago CCP announced support for running EVE Online on Mac using Wine (https://forums.eveonline.com/default.aspx?g=posts&m=6380823#post6380823) I am the primary developer on this project, and wanted to express my gratitude to the Wine community for making this possible. This experiment is going well - there have been some issues with getting Wine to run on all the different OS X versions and different hardware configurations out there, but that has largely been resolved (I think) with proper configuration of the build machine producing the Wine build. My plan is to proactively hunt down and fix any issues our Mac players run into, whether the fix entails digging into Wine source or our own codebase. Ideally everything we do in EVE should just work under Wine, but sometimes a workaround in our code may be easier than hunting down why Wine behaves different from Windows, but being able to debug both sides makes finding workarounds easier. Any fixes I come up with I will contribute to Wine, of course - it remains to be seen if they end up being very EVE specific, as EVE will of course be my main focus. My plan is also to document my experience along the way at http://ccpsnorlax.blogspot.is/ - if you find this interesting, please leave comments there. I hope that my initiative with this project meets with your approval, and look forward to working with the Wine codebase and you, the Wine developers in the future. Snorri Sturluson, Software Architect, CCP Games @CCP_Snorlax - http://ccpsnorlax.blogspot.is/

2 1

Re: [PATCH 1/2] ieframe: Simplify IPersist_Load, make error handling more straightforward (Coverity)
by Jacek Caban 11 Apr '16

11 Apr '16

Hi Nikolay, On 04/08/16 21:56, Nikolay Sivov wrote: > + /* Now we're going to read in the iconfile and iconindex. > + If we don't find them, that's not a failure case -- it's possible > + that they just aren't in there. */ > + hr = IPropertySetStorage_Open(This->property_set_storage, &FMTID_Intshcut, > + STGM_READWRITE | STGM_SHARE_EXCLUSIVE, &pPropStg); It's an already existing bug, but we should handle Open failure here. Thanks, Jacek

2 2

Re: [PATCH 2/2] ieframe: Convert to integer without additional string buffer allocation
by Jacek Caban 11 Apr '16

11 Apr '16

On 04/08/16 21:56, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/ieframe/intshcut.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dlls/ieframe/intshcut.c b/dlls/ieframe/intshcut.c > index 385b059..79458ac 100644 > --- a/dlls/ieframe/intshcut.c > +++ b/dlls/ieframe/intshcut.c > @@ -511,12 +511,11 @@ static HRESULT WINAPI PersistFile_Load(IPersistFile *pFile, LPCOLESTR pszFileNam > > if (get_profile_string(str_header, str_iconindex, pszFileName, &iconindexstring) == S_OK) > { > + WCHAR *end; > int iconindex; > PROPSPEC ps; > PROPVARIANT pv; > - char *iconindexastring = co_strdupWtoA(iconindexstring); > - sscanf(iconindexastring, "%d", &iconindex); > - CoTaskMemFree(iconindexastring); > + iconindex = strtolW(iconindexstring, &end, 10); If you don't need end value, you could pass NULL instead. Thanks, Jacek

2 1

Re: [PATCH 3/5] user32: Don't enable owner in DIALOG_DoDialogBox.
by Dmitry Timoshkov 11 Apr '16

11 Apr '16

Jacek Caban <jacek(a)codeweavers.com> wrote: > --- a/dlls/user32/controls.h > +++ b/dlls/user32/controls.h > @@ -241,7 +241,6 @@ typedef struct tagDIALOGINFO > } DIALOGINFO; > > #define DF_END 0x0001 > -#define DF_OWNERENABLED 0x0002 As I already mentioned during our conversation in wine-devel my (not yet submitted) tests show that completely removing DF_OWNERENABLED handling is wrong. And once again I'd like to see the tests submitted first with todo_wine statements in appropriate places, and the patches sent only after that with separate fixes for every failure found by the tests. Sending a bunch of tests as the final patch doesn't show what didn't actually work before, and what exactly has been fixed by the patch series. -- Dmitry.

2 8

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22037 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22051 Your paranoid android. === wvistau64 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22050 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22042 Your paranoid android. === w864 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22036 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22052 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

2 1

Experimental 64 bit OS X packages ready for testing
by Michael Müller 10 Apr '16

10 Apr '16

Hi all, recently there were multiple requests to provide experimental OS X 64 bit packages. I decided to give it a try and updated our build system and cross compiling toolchain during the last days. Luckily the whole idea turned out to be less difficult than I thought, and I can now present you the first 64-bit Wine packages for testing. It would be great to have some testers to find out if I made a mistake during the packaging and to evaluate how good the OS X 64 bit support already works, despite the GS segment / TEB problem. You can find the test packages at https://repos.wine-staging.com/macosx/beta/. I didn't use the WineHQ url because those packages are really in a very early stage, so I would like to have some more testers first before we push it to the users. The pkg installer will now provide you with an option to enable 64 bit support. The files of the 32-bit and 64-bit build are merged during the installation depending on your choice. Please test both options to ensure that a pure 32-bit build also still works as expected. The wine devel package is a pure 1.9.7 build without any additional patches applied, while the staging package contains a small hack to work around at least some of the GS segment issues (it fixed 64 bit VLC and TS3 for me). If you stumble upon any differences between both packages (besides the staged bugs), feel free to tell them to me. This way I can find out how much the hack breaks ;-). Anyway, I am looking forward to your feedback. The checksums are: 272d0fc6ccc390c99b8457c8a433953555f517e0ebbdfe68d7070de377c9fcb4 winehq-devel-1.9.7.pkg eb381ff8aec9e3c82576f941b9918f36185c17f921f0c6c93d6d97033cc0b303 winehq-staging-1.9.7.pkg BTW: Are there any news regarding the developer certificate, so we can sign the packages? I have not heard anything since about four months ago when there was the idea to ask the SFC. Regards, Michael

4 6

Re: [PATCH 5/6] d3d9/tests: Add some more surface GetDC() tests to test_getdc().
by Marvin 10 Apr '16

10 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22024 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 4/6] ddraw/tests: Add some more surface GetDC() tests to test_getdc().
by Marvin 10 Apr '16

10 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22023 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === The test timed out === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w864 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (64 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 3/6] ddraw/tests: Rewrite GetDCFormatTest().
by Marvin 10 Apr '16

10 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22022 Your paranoid android. === w864 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (64 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] d3d11: Support NULL DepthStecilView pointer in ClearDepthStencilView
by Henri Verbeet 10 Apr '16

10 Apr '16

On 10 April 2016 at 12:15, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > --- > dlls/d3d11/device.c | 3 +++ > dlls/d3d11/tests/d3d11.c | 3 +++ > 2 files changed, 6 insertions(+) > Before you resend this with the proper sign-off, could you please check d3d10 and the other clears (uav, rtv) as well?

1 0

Re: [PATCH 2/2] d3drm/tests: Add tests for IDirect3DRMObject::Add/DeleteDestroyCallback (v2).
by Stefan Dösinger 09 Apr '16

09 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, A few questions / suggestions: *) What happens if you register the same callback with different context pointers? *) The test already does some testing of the call order. I think you could extend it a bit if you store arrays of expected callback functions and context pointers in the structure and compare them when the callbacks are invoked. *) Does DeleteDestroyCallback return an error when no matching callback is found? *) The last one is mostly curiosity / a bad feeling: Is there a difference between callbacks added with IDirect3DRMObject (and its derived interfaces) and IDirect3DRMObject2? I am asking because Object2 is a separate interface and might be implemented in a separate object and then aggregated. If Microsoft screwed up (they never do that, right? ;-) ) then it'll have its own list of added callbacks... Stefan Am 2016-04-03 um 20:42 schrieb Aaryaman Vasishta: > v2: Fixed commit message. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/tests/d3drm.c | 203 ++++++++++++++++++----------------------------- > 1 file changed, 79 insertions(+), 124 deletions(-) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 1abfed3..1f197b8 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1219,6 +1219,7 @@ static void test_Frame(void) > struct destroy_context > { > IDirect3DRMObject *obj; > + unsigned int test_idx; > int called; > }; > > @@ -1238,6 +1239,81 @@ static void CDECL destroy_callback1(IDirect3DRMObject *obj, void *arg) > ctxt->called++; > } > > +static void test_destroy_callback(unsigned int test_idx, REFCLSID clsid, REFIID iid) > +{ > + struct destroy_context context; > + IDirect3DRMObject *obj; > + IUnknown *unknown; > + IDirect3DRM *d3drm; > + HRESULT hr; > + > + hr = Direct3DRMCreate(&d3drm); > + ok(SUCCEEDED(hr), "Test %u: Cannot get IDirect3DRM interface (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRM_CreateObject(d3drm, clsid, NULL, iid, (void **)&unknown); > + ok(hr == D3DRM_OK, "Test %u: Cannot get IDirect3DRMObject interface (hr = %x).\n", test_idx, hr); > + hr = IUnknown_QueryInterface(unknown, &IID_IDirect3DRMObject, (void**)&obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IUnknown_Release(unknown); > + > + context.called = 0; > + context.test_idx = test_idx; > + context.obj = obj; > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, NULL, &context); > + ok(hr == D3DRMERR_BADVALUE, "Test %u: expected D3DRMERR_BADVALUE (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + /* same callback added twice */ > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback1, NULL); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + /* add one more */ > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, NULL, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Test %u: expected D3DRM_BADVALUE (hr = %x).\n", test_idx, hr); > + > + context.called = 0; > + IDirect3DRMObject_Release(obj); > + ok(context.called == 3, "Test %u: got %d, expected 3.\n", test_idx, context.called); > + > + /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > + hr = IDirect3DRM_CreateObject(d3drm, clsid, NULL, iid, (void **)&unknown); > + ok(hr == D3DRM_OK, "Test %u: Cannot get IDirect3DRMObject interface (hr = %x).\n", test_idx, hr); > + hr = IUnknown_QueryInterface(unknown, &IID_IDirect3DRMObject, (void**)&obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IUnknown_Release(unknown); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + context.called = 0; > + hr = IDirect3DRMObject_QueryInterface(obj, &IID_IDirect3DRMObject, (void**)&context.obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IDirect3DRMObject_Release(context.obj); > + IUnknown_Release(unknown); > + ok(context.called == 2, "Test %u: got %d, expected 2.\n", test_idx, context.called); > +} > + > static void test_object(void) > { > static const struct > @@ -1292,6 +1368,9 @@ static void test_object(void) > ref2 = get_refcount((IUnknown *)d3drm1); > ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > > + /* test Add/Destroy callbacks */ > + test_destroy_callback(i, tests[i].clsid, tests[i].iid); > + > hr = IDirect3DRM2_CreateObject(d3drm2, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > ref2 = get_refcount((IUnknown *)d3drm1); > @@ -1325,7 +1404,6 @@ static void test_object(void) > > static void test_Viewport(void) > { > - struct destroy_context context; > IDirectDrawClipper *pClipper; > HRESULT hr; > IDirect3DRM *d3drm; > @@ -1411,129 +1489,6 @@ static void test_Viewport(void) > ok(data == 1, "got %x\n", data); > IDirect3DRMViewport2_Release(viewport2); > > - /* destroy callback */ > - context.called = 0; > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, NULL, &context); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRMERR_BADVALUE (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* same callback added twice */ > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback1, NULL); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* add one more */ > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, NULL, NULL); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRM_BADVALUE (hr = %x)\n", hr); > - > - context.called = 0; > - IDirect3DRMViewport_Release(viewport); > - ok(context.called == 3, "got %d, expected 3\n", context.called); > - > - /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - context.called = 0; > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - IDirect3DRMViewport_Release(viewport); > - ok(context.called == 2, "got %d, expected 2\n", context.called); > - > - /* destroy from Viewport2 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMViewport2, (void**)&viewport2); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMViewport_Release(viewport); > - > - context.called = 0; > - hr = IDirect3DRMViewport2_QueryInterface(viewport2, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, NULL, &context); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRMERR_BADVALUE (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* same callback added twice */ > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback1, NULL); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* add one more */ > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, NULL, NULL); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRM_BADVALUE (hr = %x)\n", hr); > - > - context.called = 0; > - IDirect3DRMViewport2_Release(viewport2); > - ok(context.called == 3, "got %d, expected 3\n", context.called); > - > - /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMViewport2, (void**)&viewport2); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMViewport_Release(viewport); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - context.called = 0; > - hr = IDirect3DRMViewport2_QueryInterface(viewport2, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - IDirect3DRMViewport2_Release(viewport2); > - ok(context.called == 2, "got %d, expected 2\n", context.called); > - > IDirect3DRMFrame_Release(frame); > IDirect3DRMDevice_Release(device); > IDirectDrawClipper_Release(pClipper); > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXAXjPAAoJEN0/YqbEcdMwaCAP/R0jPTn4638NJY+4kpdtREkT pmpe3+RAx7XQXqJd7baFP1Ge5A8+UyH0GC5jraqneelZ4tjIePY9weFtTI0dPlbO W5Ptty2lIqI5e79S9BC9RYn6HOVVcLqWZTbArBwfRLWCDmHFDKIvLzzg1CmgVoZQ rL8pPiqzE0qanj7UnAZXt8/N5Dz8Uy3aY2tXimnn/ao/ET4Tpi2rp6CRuFGXo71I n7ydIj+spggC6GSk1HmOiAsHLOoKwmmxd83XOrQE+awlYJVxe/jrKZu6Du/29eYa /J+xfD9iHvm2oXAvQKNy8Tca3KaynCTB0aLPzZzZ1E/UXZsI3CPYWeEzXNxkyvQv yrSVRWyUjhAegPB3DUB4JWZq8sDiEjZw6y8hRwibN3NCGTZYtjsK2AuFAK5zUmlH H4k6BFtYRyVNvOUARA5UHO+bJ9wzr0nak14DZbiWoDYISLFKm77nieWR4EU03TNh cZWOpQde/CngNRXIr1mth/WAabPm8WN1IXRcayDAh5GfTC3bVLiRvrjT/vlpm8AH G+9qVEUTmH7HRpSXJpQ4vjAnZJkpJa/ixJazz9cxcNYucPD1LMg/ZbvTGLjKRFhF 1yR9UWOFKBAZyKolehBwRuDFFzw0cXpsUJW9gW/CFyoxtoL6qV+BmmZLN2Gy6Yoe XQJAPbjrbZ4oxHyyGsGp =BxYw -----END PGP SIGNATURE-----

2 2

Re: How to change Wine DLL search path for "built-in" DLLs?
by Vladimir Panteleev 09 Apr '16

09 Apr '16

Thanks Theodore. As I have mentioned, I have already tried DLL overrides, which did not provide the desired effect. Also, as I have mentioned, I'm looking for a programmatic solution, without involving user intervention. On Fri, Apr 8, 2016 at 11:21 PM, Vladimir Panteleev <vladimir(a)thecybershadow.net> wrote: > Thanks Theodore. As I have mentioned, I have already tried DLL > overrides, which did not provide the desired effect. Also, as I have > mentioned, I'm looking for a programmatic solution, without involving > user intervention. > > On Fri, Apr 8, 2016 at 11:19 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >> Use DLL overrides. Open winecfg, go to the Libraries tab, type msvcr120, click add, click edit, click native, click ok. >> >> ~Theodore >> >>> On Apr 8, 2016, at 2:52 PM, Vladimir Panteleev <vladimir(a)thecybershadow.net> wrote: >>> >>> (reposting from wine-users, which seems to be dead) >>> >>> I'm trying to get the VS2012 C++ compiler (cl.exe) running under Wine >>> - stand-alone, as a component for a different larger project. The >>> project works fine on Windows without affecting any global system >>> settings or files (i.e. it unpacks DLLs etc. to private subdirs >>> instead of installing them system-wide). I'd like it to "just work" >>> under Wine as well, without user intervention or persistent >>> modifications to bottle settings or system files. >>> >>> Wine has a msvcr120.dll, however it is incomplete, at least as far as >>> cl.exe is concerned: >>> >>> wine: Call from 0x7b44ee37 to unimplemented function >>> msvcr120.dll.??0reader_writer_lock@Concurrency@@QEAA@XZ, aborting >>> Internal Compiler Error in >>> Z:\home\vladimir\work\Digger\work-wine\dl\vs2013-community\Program >>> Files (x86)\Microsoft Visual Studio 12.0\VC\bin\amd64\cl.exe. You >>> will be prompted to send an error report to Microsoft later. >>> >>> The problem is that it attempts to load its builtin DLL even if I >>> place the native Microsoft's DLL in PATH before system32/syswow64. >>> WINEDLLPATH seems to have no effect, and adding a DLL override has no >>> effect other than changing whether it loads Wine's DLL on fails to >>> load a DLL at all (even though it's in PATH!). Yes, the model >>> (bitness) is correct. >>> >>> I remember reading somewhere that Wine uses the value of PATH from the >>> registry. I guess I could also just delete or overwrite Wine's DLL in >>> system32/syswow64. But is it possible to change the DLL search path >>> for one Wine invocation, without any permanent modifications to the >>> bottle? >>> >>> Partially related, but I noticed that Wine does not skip over DLLs of >>> wrong bitness as Windows does. Instead, the program fails to >>> initialize. This means you can't add 32-bit and 64-bit DLL directories >>> to PATH and let the programs' bitness sort out which to use. That's >>> definitely a bug I guess. >>> >>> >>

2 2

Fwd: How to change Wine DLL search path for "built-in" DLLs?
by Vladimir Panteleev 08 Apr '16

08 Apr '16

(reposting from wine-users, which seems to be dead) I'm trying to get the VS2012 C++ compiler (cl.exe) running under Wine - stand-alone, as a component for a different larger project. The project works fine on Windows without affecting any global system settings or files (i.e. it unpacks DLLs etc. to private subdirs instead of installing them system-wide). I'd like it to "just work" under Wine as well, without user intervention or persistent modifications to bottle settings or system files. Wine has a msvcr120.dll, however it is incomplete, at least as far as cl.exe is concerned: wine: Call from 0x7b44ee37 to unimplemented function msvcr120.dll.??0reader_writer_lock@Concurrency@@QEAA@XZ, aborting Internal Compiler Error in Z:\home\vladimir\work\Digger\work-wine\dl\vs2013-community\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin\amd64\cl.exe. You will be prompted to send an error report to Microsoft later. The problem is that it attempts to load its builtin DLL even if I place the native Microsoft's DLL in PATH before system32/syswow64. WINEDLLPATH seems to have no effect, and adding a DLL override has no effect other than changing whether it loads Wine's DLL on fails to load a DLL at all (even though it's in PATH!). Yes, the model (bitness) is correct. I remember reading somewhere that Wine uses the value of PATH from the registry. I guess I could also just delete or overwrite Wine's DLL in system32/syswow64. But is it possible to change the DLL search path for one Wine invocation, without any permanent modifications to the bottle? Partially related, but I noticed that Wine does not skip over DLLs of wrong bitness as Windows does. Instead, the program fails to initialize. This means you can't add 32-bit and 64-bit DLL directories to PATH and let the programs' bitness sort out which to use. That's definitely a bug I guess.

2 2

Re: [PATCH 1/4] dsound: Rework ugly mixer logic
by Henri Verbeet 08 Apr '16

08 Apr '16

On 8 April 2016 at 20:37, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > From: Maarten Lankhorst <maarten.lankhorst(a)canonical.com> > > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > dlls/dsound/dsound.c | 1 - > dlls/dsound/dsound_main.c | 6 -- > dlls/dsound/dsound_private.h | 6 +- > dlls/dsound/mixer.c | 252 +++++++++++-------------------------------- > dlls/dsound/primary.c | 107 ++++++++---------- > 5 files changed, 108 insertions(+), 264 deletions(-) > You're the one that has to maintain this, so I don't care all too much, but this looks like it's doing a bunch of different things under a pretty vague commit message.

2 1

Winegstreamer entry on Wine FAQ Wiki Page
by NP-Hardass 08 Apr '16

08 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello, About a month ago, I created a Wine Wiki account and requested that it be activated, explicitly so that I could add an entry to the FAQ page [1]. After going to reference this new entry to someone today, I noticed that my changes were reverted soon after my submission and the page was subsequently locked [2]. This submission was made after consulting wine developer, Sebastian Lackner. I think this information would be very useful to users starting to adopt Winegstreamer, now that Andrew Eikum has updated it to gstreamer 1.0 and it is functioning again. I'd like to inquire why the change was reverted, if my content is deemed unnecessary, and if not, why it was not moved elsewhere. - -- NP-Hardass Gentoo Wine maintainer [1] https://wiki.winehq.org/index.php?title=FAQ [2] https://wiki.winehq.org/index.php?title=FAQ&action=history -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXBgQkAAoJEBzZQR2yrxj7Q6gP/27bv0ZQSiRYVgaoWu4SUOsu TXeZyPLTbKs+KbYuScyMmE1fv8d6FetSNdubUw0ZYKyryu7qUqm/19hhhrs3T6Oo j7hXa7QPmsejtRkM3kCWNItPS6M5olEEqBJq2Ics84DrfFiEaUxPdeJwFgiJLwvX erNgf5600OJHzhDxSCa0UfMdEBWBs7DsdVFncgAWyv3s4dnp4L7aaYGgv2vlpkXI QrhbUCzqWy5grjf9HOsmix4Zz9SSwk6xvEMBjRi9RHiAAOTx2f9Gussiwq2N1Dbe VYoZpxtGaEFt+UKtNJds5vZXaSQlWFg+IT8aeh/VglJJp7avM8Hi6gGFQ22CvwUr M31oU3t/adH3EzyKC0eVBrNjiicnRyzFbrTrkWwokKV+LjV/C8/SfexzHqzn40Vi T4yQrMBoHZcjT6YhLXFjVIE4RSIXbmT5TrCA6oAqKgbueGcfiEvLaz8ti/XUnsyO fgiCNrdSV1hPvAi+5yI2l+BE9xxxhrS2DOXyJlxYMflxXctbRnQ0KFjBzs24x4Qj CXXrXavrP8MhMoemzMuBZMEt7hui0+z4WUGZdjc+oT0Cso8VLrdnE93wJdBJOlbD G/K3cQb6hNr387pKcUXTEq1KDTyrH5LCzxOAjS4TOuhFti8jMbSdKRea9flfR2bp pVoJARXzVNeQla7n7+ox =3Bex -----END PGP SIGNATURE-----

4 7

Re: [PATCH 2/2] cmd: Add support for || and &&.
by Sebastian Lackner 07 Apr '16

07 Apr '16

On 07.04.2016 22:12, Qian Hong wrote: > Slightly improved based on Mikhail Bystryantsev's patch, add support for those built-in commands which does not change %ERRORLEVEL%. > > Signed-off-by: Qian Hong <qhong(a)codeweavers.com> > --- > programs/cmd/builtins.c | 14 +++++++++++--- > programs/cmd/tests/test_builtins.cmd | 13 +++++++++++++ > programs/cmd/tests/test_builtins.cmd.exp | 13 ++++++++++++- > programs/cmd/tests/test_cmdline.cmd | 20 ++++++++++++++++++++ > programs/cmd/tests/test_cmdline.cmd.exp | 22 ++++++++++++++++++++++ > programs/cmd/wcmd.h | 1 + > programs/cmd/wcmdmain.c | 26 ++++++++++++++++++++++++-- > 7 files changed, 103 insertions(+), 6 deletions(-) > Has it really something to do with builtin-commands which do not change %ERRORLEVEL%? I think the tests only cover one of those commands, a couple of additional tests would probably not hurt. The lack of tests is also the reason why I haven't merged this into Staging yet. If this turns out to be right way to solve it, I would suggest to define a function check_errorlevel() which checks 'errorlevel' and 'changed' at once.

1 0

Re: [PATCH 2/2] cmd: Add support for || and &&.
by Qian Hong 07 Apr '16

07 Apr '16

I should add "From Mikhail Bystryantsev." in commit message, but something was wrong with my mail client. (Could you please use git send-email to send patches in the future? --- from Henri. :D) On Fri, Apr 8, 2016 at 4:12 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Slightly improved based on Mikhail Bystryantsev's patch, add support for > those built-in commands which does not change %ERRORLEVEL%. > > Signed-off-by: Qian Hong <qhong(a)codeweavers.com> > --- > programs/cmd/builtins.c | 14 +++++++++++--- > programs/cmd/tests/test_builtins.cmd | 13 +++++++++++++ > programs/cmd/tests/test_builtins.cmd.exp | 13 ++++++++++++- > programs/cmd/tests/test_cmdline.cmd | 20 ++++++++++++++++++++ > programs/cmd/tests/test_cmdline.cmd.exp | 22 ++++++++++++++++++++++ > programs/cmd/wcmd.h | 1 + > programs/cmd/wcmdmain.c | 26 ++++++++++++++++++++++++-- > 7 files changed, 103 insertions(+), 6 deletions(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 1/2] user32/tests: Message filtering tests for broadcast messages
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21970 Your paranoid android. === w864 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

2 1

Re: [PATCH 2/2] user32: Limit broadcast messages to system and registered ones
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21971 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:11018: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:11030: Test failed: msg.message = 275 instead of WM_USER msg.c:11032: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:11041: Test failed: msg.message = 1024 instead of WM_TIMER msg.c:11043: Test failed: expected PeekMessage to return FALSE, got 1 === w864 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

1 0

Re: [PATCH 3/3] mshtml: Added more IHTMLXMLHttpRequst::send tests.
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21965 Your paranoid android. === w1064 (64 bit xmlhttprequest) === The test timed out

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel