- wine-devel - winehq.org

Re: [PATCH] t2embed: Implement TTGetEmbeddingType()
by Marvin 30 Mar '16

30 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21774 Your paranoid android. === build (build) === Make failed

2 1

Re: ntoskrnl.exe: Make IoAllocateIrp not crash on negative values.
by Sebastian Lackner 29 Mar '16

29 Mar '16

On 27.03.2016 20:27, Bernhard Übelacker wrote: > https://bugs.winehq.org/show_bug.cgi?id=39734 > > Changes should avoid crash in acedrv11.sys. > IoAllocateIrp is called with a stack_size of -128. > > Tested against Windows XP. > (See the test based on wine-staging "driver testing framework".) For reference, here a testbot run which confirms that the change is correct (for XP/2003): https://newtestbot.winehq.org/JobDetails.pl?Key=21722 > > Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c > index 36488a7..f2ccc61 100644 > --- a/dlls/ntoskrnl.exe/ntoskrnl.c > +++ b/dlls/ntoskrnl.exe/ntoskrnl.c > @@ -592,15 +592,20 @@ PIRP WINAPI IoAllocateIrp( CCHAR stack_size, BOOLEAN charge_quota ) > { > SIZE_T size; > PIRP irp; > + CCHAR _stack_size = stack_size; > > TRACE( "%d, %d\n", stack_size, charge_quota ); > > - size = sizeof(IRP) + stack_size * sizeof(IO_STACK_LOCATION); > + if (_stack_size <= 0 || (_stack_size > 1 && stack_size < 8)) > + _stack_size = 8; I would suggest to use a different variable, its very easy to mix up "stack_size" and "_stack_size". You even mixed it up yourself in the if() condition above. ;) If you want, you can also simplify the condition to (stack_size < 8 && stack_size != 1). > + > + size = sizeof(IRP) + _stack_size * sizeof(IO_STACK_LOCATION); > irp = ExAllocatePool( NonPagedPool, size ); > if (irp == NULL) > return NULL; > IoInitializeIrp( irp, size, stack_size ); > - irp->AllocationFlags = IRP_ALLOCATED_FIXED_SIZE; > + if (stack_size >= 1 && stack_size <= 8) > + irp->AllocationFlags = IRP_ALLOCATED_FIXED_SIZE; > if (charge_quota) > irp->AllocationFlags |= IRP_LOOKASIDE_ALLOCATION; > return irp; >

2 1

Re: [PATCH] d3drm: Partially Implement IDirect3DRM*::LoadTexture(v3).
by Henri Verbeet 29 Mar '16

29 Mar '16

On 28 March 2016 at 20:02, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v3: Add bitmap verification, use InitFromFile and other minor improvements. > Implementing InitFromFile() should be a separate patch from implementing LoadTexture(). > if (FAILED(hr = d3drm_texture_create(&object))) > return hr; > > + if (FAILED(hr = IDirect3DRMTexture_InitFromFile(&object->IDirect3DRMTexture_iface, filename))) > + { > + d3drm_texture_destroy(object); > + return hr; > + } > + > + object->d3drm = iface; > + IDirect3DRM_AddRef(iface); It would be good to back this up with tests. It would seem more natural to pass the IDirect3DRM interface to d3drm_texture_create(). If that's how it's supposed to work, you can make that change in a separate patch. > @@ -39,6 +40,9 @@ struct d3drm_texture > IDirect3DRMTexture IDirect3DRMTexture_iface; > IDirect3DRMTexture2 IDirect3DRMTexture2_iface; > IDirect3DRMTexture3 IDirect3DRMTexture3_iface; > + IDirect3DRM *d3drm; > + D3DRMIMAGE *image; > + BOOL internal_image_created; You don't really need internal_image_created, you can probably just add a destroy callback. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, > + BOOL load_upside_down) DECLSPEC_HIDDEN; > + > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) DECLSPEC_HIDDEN; These are internal helper functions now. > @@ -4109,36 +4111,94 @@ static void test_load_texture(void) > > hr = IDirect3DRM_LoadTexture(d3drm1, filename, &texture1); > ok(SUCCEEDED(hr), "Test %u: Failed to load texture, hr %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 > ref1, "Test %u: expected ref2 > ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + > + hr = IDirect3DRMTexture_InitFromFile(texture1, filename); > + ok(hr == D3DRMERR_BADOBJECT, "Test %u: Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", i, hr); > + /* It's odd, but InitFromFile seems to AddRef IDirect3DRM even if it fails. */ So a test for the refcounts would be appropriate here. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) > +{ This is an internal helper function now and should be static. You never use "d3drm". > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) > +{ > + D3DRMPALETTEENTRY *colors; > + D3DRMIMAGE *image; > + BOOL black_used = FALSE; > + LONG w = info->bmiHeader.biWidth; > + LONG h = abs(info->bmiHeader.biHeight); > + int i, j, k; > + unsigned int idx, buffer1_idx; > + unsigned char *buffer1; > + int bpp = info->bmiHeader.biBitCount == 24 ? 32 : info->bmiHeader.biBitCount; > + int bpl = palette ? w : ((w + 3) & ~3) * bpp / 8; > + int num_colors = 0; There's not reason to use signed types for any of these. > + struct colors_24bpp > + { > + BYTE red; > + BYTE green; > + BYTE blue; > + } *color; > + color = (struct colors_24bpp *)buffer; > + > + if (bpl * h > UINT_MAX) > + { > + return NULL; > + } This doesn't work. If "bpl * h" would be larger than UINT_MAX it would overflow before the comparison. In fact, strictly speaking things become implementation defined above INT_MAX already, since you're using signed types for "bpl" and "h". What you'd typically do is something like "if (h > UINT_MAX / bpl)". Note that the calculation of "bpl" itself can overflow as well. So you'd need something like "if (align(w, 4) > UINT_MAX / (bpp / 8))" there as well. > + if (!(colors = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 256 * sizeof(*colors)))) > + { > + WARN("Not enough memory to allocate palette, returning NULL.\n"); > + return NULL; > + } > + > + > + if (!(image = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*image)))) > + { > + WARN("Not enough memory to allocate image struct, returning NULL.\n"); > + return NULL; > + } You probably don't need HEAP_ZERO_MEMORY for either of these. You certainly don't for "colors", and you should probably just initialise the few fields in "image" that you don't already. You also leak "colors" if the allocation for "image" fails. The indentation for the WARN is wrong. > + if (!(image->buffer1 = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, bpl * h))) > + { > + WARN("Not enough memory to allocate image buffer, returning NULL.\n"); > + return NULL; > + } You don't need HEAP_ZERO_MEMORY here if you're going to memset() it again below. You leak "colors" and "image" on failure. > + buffer1 = image->buffer1; > + memset(buffer1, 255, sizeof(unsigned char) * bpl * h); I think 0xff is clearer than 255. The "sizeof(unsigned char)" doesn't add much. > + if (!(image->palette = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, num_colors * sizeof(*image->palette)))) > + { > + WARN("Not enough memory to allocate image palette, returning NULL.\n"); > + return NULL; > + } Like above, you use HEAP_ZERO_MEMORY here, but immediately memcpy() over it. You leak on error. > + if (!(image->palette = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 256 * sizeof(*image->palette)))) > + { > + WARN("Not enough memory to allocate image palette, returning NULL.\n"); > + return NULL; > + } Leak on error. > static HRESULT WINAPI d3drm_texture1_InitFromFile(IDirect3DRMTexture *iface, const char *filename) > { > - FIXME("iface %p, filename %s stub!\n", iface, debugstr_a(filename)); > + struct d3drm_texture *object = impl_from_IDirect3DRMTexture(iface); I'd suggest "texture" instead of "object". > + if (object->d3drm) > + { > + /* InitFromFile seems to AddRef IDirect3DRM even if it fails. */ > + IDirect3DRM_AddRef(object->d3drm); > + } This is very suspicious, since you always assign "object->d3drm" after calling InitFromFile(). It's not backed up by tests either.

2 4

Re: [v7 2/7] d3dx9: Implement preshader parsing.
by Matteo Bruni 29 Mar '16

29 Mar '16

2016-03-28 9:20 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > Changes > - Changed opcode function to take double arguments and return double Good catch. > +static struct op_info pres_op_info[] = > +{ > + {0x000, "nop", 0, 0, NULL }, /* PRESHADER_OP_NOP */ > + {0x100, "mov", 1, 0, pres_mov}, /* PRESHADER_OP_MOV */ > +}; I think this can be const. > +struct d3dx_pres_ins > +{ > + enum pres_ops op; > + /* first input argument is scalar, > + scalar component is propagated */ > + BOOL scalar_op; > + unsigned int component_count; > + struct d3dx_pres_operand inputs[3]; The maximum number of input operands could use a #define. Not a huge deal though. > +static void regstore_free_tables(struct d3dx_regstore *rs) > +{ > + unsigned int i; > + > + for (i = PRES_REGTAB_FIRST; i <= PRES_REGTAB_LAST; ++i) > + { > + if (rs->tables[i]) > + HeapFree(GetProcessHeap(), 0, rs->tables[i]); > + if (rs->table_value_set[i]) > + HeapFree(GetProcessHeap(), 0, rs->table_value_set[i]); > + } > +} You don't need to check for non-NULL, HeapFree() handles NULL arguments just fine. > +static unsigned int *find_bytecode_comment(unsigned int *ptr, unsigned int fourcc) > +{ > + while ((*ptr & 0xffff) == 0xfffe) > + { > + if (*(ptr + 1) == fourcc) > + return ptr + 2; > + ptr += 1 + (*ptr >> 16); > + } > + return NULL; > +} This is probably paranoid but in theory a broken or malicious effect could send you rummaging outside of the bytecode buffer so all the offsets should be checked. I don't think it's critical in practice i.e. I'll probably sleep just fine if you decide to ignore this issue... > +static unsigned int *parse_pres_arg(unsigned int *ptr, struct d3dx_pres_operand *opr) > +{ > + static const enum pres_reg_tables reg_table[8] = > + { > + PRES_REGTAB_COUNT, PRES_REGTAB_IMMED, PRES_REGTAB_CONST, PRES_REGTAB_COUNT, > + PRES_REGTAB_OCONST, PRES_REGTAB_OBCONST, PRES_REGTAB_OICONST, PRES_REGTAB_REG Matter of taste, so feel free to ignore this, but PRES_REGTAB_REG sounds a bit vague to me. I'd go with something like PRES_REGTAB_TEMP. > + if (input_count != pres_op_info[i].input_count) > + { > + FIXME("Actual input args %u, expected %u, instruction %s.\n", input_count, > + pres_op_info[i].input_count, pres_op_info[i].mnem); > + return NULL; > + } > + for (i = 0; i < input_count; ++i) > + { > + ptr = parse_pres_arg(ptr, &ins->inputs[i]); > + if (!ptr) > + return NULL; > + } Another pretty paranoid potential check, here you could verify that input_count is < ARRAY_SIZE(ins->inputs). Of course that could only fail if we encounter some instruction with more than 3 components AND we update pres_op_info BUT we forget to update struct d3dx_pres_ins, but I don't think it would hurt to be safe... > + for (i = 0; i < pres->ins_count; ++i) > + { > + unsigned int table; > + > + for (j = 0; j < pres_op_info[pres->ins[i].op].input_count; ++j) > + { > + table = pres->ins[i].inputs[j].table; > + max_offset = get_reg_offset(table, pres->ins[i].inputs[j].offset + pres->ins[i].component_count - 1); > + pres->regs.table_sizes[table] = max(pres->regs.table_sizes[table], max_offset + 1); > + } > + table = pres->ins[i].output.table; > + max_offset = get_reg_offset(table, pres->ins[i].output.offset + pres->ins[i].component_count - 1); > + pres->regs.table_sizes[table] = max(pres->regs.table_sizes[table], max_offset + 1); > + } > + update_table_sizes_consts(pres->regs.table_sizes, &pres->inputs); It probably makes sense to add a small update_table_size() helper (or similar), the "same" 3 lines are repeated in the loop for the input operands, for the output operand and in update_table_sizes_consts(). > + for (i = PRES_REGTAB_IMMED + 1; i <= PRES_REGTAB_LAST; ++i) It depends on what is coming up next but maybe it would make sense to add an enum for "PRES_REGTAB_IMMED + 1" (incidentally, PRES_REGTAB_FIRST is never used in this patch series). > + { > + TRACE("table_sizes[%u] %u.\n", i, peval->pres.regs.table_sizes[i]); That trace looks a bit like a debugging leftover. > + if (FAILED(regstore_alloc_table(&peval->pres.regs, i))) > + { > + hr = E_OUTOFMEMORY; > + goto err_out; > + } > + } > + > + if (TRACE_ON(d3dx)) > + dump_bytecode(byte_code, byte_code_size); > + > + *peval_out = peval; > + TRACE("retval %u, *peval_out %p.\n", D3D_OK, *peval_out); Same with this. This one in particular doesn't seem worth keeping. > + return D3D_OK; > + > +err_out: > + FIXME("Error creating parameter evaluator.\n"); > + d3dx_free_param_eval(peval); > *peval_out = NULL; > - return E_NOTIMPL; > + TRACE("retval %u, *peval_out %p.\n", hr, *peval_out); > + return hr; > +} You could print the HRESULT in the FIXME (e.g. FIXME("Error creating parameter evaluator, returning %#x.\n", hr)). Tracing the value of *peval_out doesn't seem particularly worthwhile. > +static void d3dx_free_const_tab(struct d3dx_const_tab *ctab) > +{ > + if (ctab->inputs) > + HeapFree(GetProcessHeap(), 0, ctab->inputs); > + if (ctab->inputs_param) > + HeapFree(GetProcessHeap(), 0, ctab->inputs_param); > + if (ctab->ctab) > + ID3DXConstantTable_Release(ctab->ctab); > +} > + > +static void d3dx_free_preshader(struct d3dx_preshader *pres) > +{ > + if (pres->ins) > + HeapFree(GetProcessHeap(), 0, pres->ins); > + > + regstore_free_tables(&pres->regs); > + d3dx_free_const_tab(&pres->inputs); > } You can drop all those ifs (I think there are a few more of them in the middle of the patch I haven't specifically mentioned).

2 5

Re: [v2 PATCH 2/3] d2d1/tests: Basic test for ID2D1DCRenderTarget creation
by Henri Verbeet 29 Mar '16

29 Mar '16

On 29 March 2016 at 01:21, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + static D2D1_PIXEL_FORMAT invalid_formats[] = > + { > + { DXGI_FORMAT_UNKNOWN, D2D1_ALPHA_MODE_PREMULTIPLIED }, > + { DXGI_FORMAT_B8G8R8A8_UNORM, D2D1_ALPHA_MODE_UNKNOWN }, > + { DXGI_FORMAT_R8G8B8A8_UNORM, D2D1_ALPHA_MODE_PREMULTIPLIED }, > + }; I should have noticed before, but this should be const.

2 1

Re: [PATCH 2/5] ddraw/tests: Add a test for color varyings clamping.
by Henri Verbeet 29 Mar '16

29 Mar '16

On 28 March 2016 at 23:03, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + hr = IDirect3DDevice7_GetDirect3D(device, &d3d); > + ok(SUCCEEDED(hr), "Failed to get d3d interface, hr %#x.\n", hr); I suppose this is borrowed from test_shademode() where it's used to create the vertex buffers, but you're not using "d3d" anywhere here.

1 0

Re: [PATCH] msvcr120/tests: Add critical section test.
by Piotr Caban 29 Mar '16

29 Mar '16

Hi YongHao, On 03/18/16 17:24, YongHao Hu wrote: > dlls/msvcr120/tests/msvcr120.c | 300 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 300 insertions(+) I don't think this is a good approach for adding tests of critical_section class. Executing tons of enter/leave calls is not really testing much. Your test_critical_section_lock tests will probably pass if you comment all critical section related calls out (it passed on my computer in 10 consecutive runs, never failed, probably it's because the code was optimized during compilation). Testing 5s/6s timeouts is also not a good idea. Because of it the tests are running much longer. It would be much better if you test following things: - just check some basic functionality of enter/leave: enter cs in main thread, start new thread that tries to enter it as well, wait for 100ms and check that it was not able to enter the cs, then leave cs in main thread and wait for thread to enter cs and finish - check some basic functionality of try_lock: use it to lock the cs, check if it fails on locked cs Also the tests failed on testbot, I was not checking why. Thanks, Piotr

3 3

Re: [PATCH 2/5] ddraw/tests: Add a test for color varyings clamping.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21748 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 2/3] d2d1/tests: Basic test for ID2D1DCRenderTarget creation
by Henri Verbeet 28 Mar '16

28 Mar '16

On 28 March 2016 at 22:18, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + hr = ID2D1Factory_CreateDCRenderTarget(factory, &desc, &rt); > + todo_wine > + ok(hr == D2DERR_UNSUPPORTED_PIXEL_FORMAT, "Failed to create target, hr %#x.\n", hr); ... > + hr = ID2D1DCRenderTarget_EndDraw(rt, NULL, NULL); > + ok(hr == D2DERR_WRONG_STATE, "EndDraw() failed, hr %#x.\n", hr); Those messages are a bit misleading. (For what it's worth, we usually use "Got unexpected hr %#x.\n" for those.)

1 0

Re: [PATCH] d2d1: Added a stub implementation for ID2D1DCRenderTarget
by Nikolay Sivov 28 Mar '16

28 Mar '16

Please ignore this one for now.

1 0

Re: [PATCH 2/2] d3drm: Partially Implement IDirect3DRM*::LoadTexture(v2).
by Henri Verbeet 28 Mar '16

28 Mar '16

On 20 March 2016 at 19:24, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > - FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > + TRACE("iface %p, filename %s, texture %p\n", iface, debugstr_a(filename), texture); Missing period. > @@ -853,15 +859,19 @@ static HRESULT WINAPI d3drm2_CreateUserVisual(IDirect3DRM2 *iface, > static HRESULT WINAPI d3drm2_LoadTexture(IDirect3DRM2 *iface, > const char *filename, IDirect3DRMTexture2 **texture) > { > - struct d3drm_texture *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM2(iface); > + IDirect3DRMTexture3 *texture3; > HRESULT hr; > > - FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > + TRACE("iface %p, filename %s, texture %p.\n", iface, debugstr_a(filename), texture); > > - if (FAILED(hr = d3drm_texture_create(&object))) > + if (FAILED(hr = IDirect3DRM3_LoadTexture(&d3drm->IDirect3DRM3_iface, filename, &texture3))) > return hr; > > - *texture = &object->IDirect3DRMTexture2_iface; > + hr = IDirect3DRMTexture3_QueryInterface(texture3, &IID_IDirect3DRMTexture2, (void**)texture); > + IDirect3DRMTexture3_Release(texture3); > + if (FAILED(hr)) > + return hr; > > return D3DRM_OK; > } This is probably ok, but you may want to consider just introducing a helper function instead. I.e.: if (FAILED(hr = d3drm_load_texture(d3drm, filename, TRUE, &object))) return hr; IDirect3DRMTexture2_AddRef(*texture = &object->IDirect3DRMTexture2_iface); return D3DRM_OK; What happens when d3drm_texture_load() is called multiple times on the same texture? Should that be possible? > +void d3drm_texture_destroy(struct d3drm_texture *texture); Missing DECLSPEC_HIDDEN. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) DECLSPEC_HIDDEN; This line is a bit long. Try to stick to 120 columns as a maximum, preferably a bit less. > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down); Missing DECLSPEC_HIDDEN. > @@ -4103,24 +4105,34 @@ static void test_load_texture(void) > > hr = IDirect3DRM_LoadTexture(d3drm1, filename, &texture1); > ok(SUCCEEDED(hr), "Test %u: Failed to load texture, hr %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u, ref2 = %u.\n", ref1, ref2); The message should mention which test (i.e., "i") failed. > d3drm_img = IDirect3DRMTexture_GetImage(texture1); > - todo_wine ok(!!d3drm_img, "Test %u: Failed to get image.\n", i); > + ok(!!d3drm_img, "Test %u: Failed to get image.\n", i); > if (d3drm_img) > test_bitmap_data(i * 4, d3drm_img, FALSE, tests[i].w, tests[i].h, tests[i].palettized); Now that IDirect3DRMTexture_GetImage() succeeds, you can remove the "if (d3drm_img)". > +void d3drm_texture_destroy(struct d3drm_texture *texture) > +{ > + if (texture->image) > + { > + TRACE("Releasing attached members.\n"); > + HeapFree(GetProcessHeap(), 0, texture->image->buffer1); > + if(texture->image->palette) Missing space between "if" and "(". > + HeapFree(GetProcessHeap(), 0, texture->image->palette); > + HeapFree(GetProcessHeap(), 0, texture->image); This seems a bit suspicious. Supposedly the "image" argument to d3drm3_CreateTexture() can be used to create a texture on an existing image. The documentation isn't very explicit about it, but suggests that the image data isn't copied in that case. So I'm not sure the texture is supposed to be responsible for destroying the image. In general I think it's not entirely clear how things like CreateTexture(), LoadTexture() and InitFromFile() etc. are supposed to interact. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) > +{ > + BITMAPINFO *info; > + BITMAPFILEHEADER *bmp_header; > + unsigned char *buffer; > + DWORD size; > + HANDLE hfile, hmapping; > + > + hfile = CreateFileA(path, GENERIC_READ, FILE_SHARE_READ, 0, OPEN_EXISTING, 0, 0); > + if (hfile == INVALID_HANDLE_VALUE) > + return D3DRMERR_BADFILE; > + > + size = GetFileSize(hfile, NULL); > + if (size == INVALID_FILE_SIZE) > + { > + DeleteObject(hfile); > + return D3DRMERR_BADVALUE; > + } You never use "size" after this, but you probably should. I also think you meant CloseHandle() instead of DeleteObject(). > + buffer = MapViewOfFile(hmapping, FILE_MAP_READ, 0, 0, 0); > + if (buffer == NULL) "if (!buffer)", or even "if (!(buffer = MapViewOfFile(...)))" > + bmp_header = (BITMAPFILEHEADER *)buffer; > + info = (BITMAPINFO *) (buffer + sizeof(*bmp_header)); Or just "info = (BITMAPINFO *)bmp_header + 1;". You should validate that this is actually a BMP file. You should also check which version of the BITMAPINFOHEADER structure the file has. > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) > +{ > + D3DRMPALETTEENTRY *colors = (D3DRMPALETTEENTRY *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 257 * sizeof(*colors)); Is "257" there intentional? The cast is unnecessary. HeapAlloc() can fail. Do you need HEAP_ZERO_MEMORY here? > + D3DRMIMAGE *image; > + BOOL black_used = FALSE; > + LONG w = info->bmiHeader.biWidth; > + LONG h = abs(info->bmiHeader.biHeight); > + int i, j, k; > + unsigned int idx, buffer1_idx; > + unsigned char *buffer1; > + int bpp = info->bmiHeader.biBitCount == 24 ? 32 : info->bmiHeader.biBitCount; > + int bpl = palette ? w : ((w + 3) & ~3) * bpp / 8; > + int num_colors = 0; > + struct colors_24bpp > + { > + BYTE red; > + BYTE green; > + BYTE blue; > + } *color; > + color = (struct colors_24bpp *)buffer; > + > + image = (D3DRMIMAGE *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*image)); > + image->buffer1 = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(unsigned char) * bpl * h); This is unsafe. Consider e.g. what happens when the header gives you 0x10000 for width and height. > + buffer1 = image->buffer1; > + memset(buffer1, 255, sizeof(unsigned char) * bpl * h); You just initialised the memory with HEAP_ZERO_MEMORY, and now you're overwriting it again. At least one of these two initialisations is unnecessary, and quite possibly both of them.

3 21

Re: [PATCH 10/10] jscript: Find Function.arguments on the stack instead of storing it in FunctionInstance object.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21743 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

RE: regedit: Display REG_DWORD_BIG_ENDIAN values
by Hugh McMaster 28 Mar '16

28 Mar '16

On Monday, March 28 2016, 21:05 UTC+11, Nikolay Sivov wrote: >On 28.03.2016 12:52, Hugh McMaster wrote: >> Signed-off-by: Hugh McMaster >> --- >> programs/regedit/listview.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c >> index c0119ff..5b1bd80 100644 >> --- a/programs/regedit/listview.c >> +++ b/programs/regedit/listview.c >> @@ -174,6 +174,19 @@ static void AddEntryToList(HWND hwndLV, LPWSTR Name, DWORD dwValType, >> ListView_SetItemTextW(hwndLV, index, 2, buf); >> } >> break; >> + case REG_DWORD_BIG_ENDIAN: { >> + DWORD i, value = 0; >> + BYTE *data = ValBuf; >> + WCHAR buf[64]; >> + WCHAR fmt[] = {'0','x','%','0','8','x',' ','(','%','u',')',0}; >> + for (i = 0; i < dwCount; i++) { >> + value <<= 8; >> + value |= data[i]; >> + } >> + sprintfW(buf, fmt, value, value); >> + ListView_SetItemTextW(hwndLV, index, 2, buf); >> + } >> + break; >> case REG_BINARY: { >> unsigned int i; >> LPBYTE pData = ValBuf; >> >dwCount is always 1 in this case, dwCount is 4 for REG_DWORD and REG_DWORD_BIG_ENDIAN. >so it could be simplified to the point of swapping 'value' and >falling through to REG_DWORD case. I didn't check tests, but >you sure you need to modify what RegQueryValueExW() returns? On Windows, regedit displays the REG_DWORD type in little endian order and the REG_DWORD_BIG_ENDIAN type in big endian order. But both "reg query" and RegQueryValueEx() return any type of DWORD in little endian order. While it is true that there is common code in REG_DWORD and the BIG_ENDIAN case, I'm not sure there is a clean way to handle the endianness without checking for and handling the value type a second time.

1 0

[GSoC] Mailinglist discussions
by André Hentschel 28 Mar '16

28 Mar '16

Hi, This year it's not possible to communicate with the GSoC Students over the GSoC-Project site. I guess the reason is to force communication with the community. Thus I suggest to move the discussions to wine-devel and prefix them with [GSoC] Thx

3 2

Re: msvcirt: Avoid superfluous comparison in some compilers
by Henri Verbeet 28 Mar '16

28 Mar '16

On 27 March 2016 at 13:57, Iván Matellanes <matellanesivan(a)gmail.com> wrote: > - if (dir < SEEKDIR_beg || dir > SEEKDIR_end || !(mode & (OPENMODE_in|OPENMODE_out))) > + if ((dir != SEEKDIR_beg && dir != SEEKDIR_cur && dir != SEEKDIR_end) || !(mode & (OPENMODE_in|OPENMODE_out))) I'm not sure you're really making it better by adding another comparison. One alternative you may want to consider is just "(unsigned int)dir > SEEKDIR_end".

2 1

Re: regedit: Display REG_DWORD_BIG_ENDIAN values
by Nikolay Sivov 28 Mar '16

28 Mar '16

On 28.03.2016 12:52, Hugh McMaster wrote: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/listview.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c > index c0119ff..5b1bd80 100644 > --- a/programs/regedit/listview.c > +++ b/programs/regedit/listview.c > @@ -174,6 +174,19 @@ static void AddEntryToList(HWND hwndLV, LPWSTR Name, DWORD dwValType, > ListView_SetItemTextW(hwndLV, index, 2, buf); > } > break; > + case REG_DWORD_BIG_ENDIAN: { > + DWORD i, value = 0; > + BYTE *data = ValBuf; > + WCHAR buf[64]; > + WCHAR fmt[] = {'0','x','%','0','8','x',' ','(','%','u',')',0}; > + for (i = 0; i < dwCount; i++) { > + value <<= 8; > + value |= data[i]; > + } > + sprintfW(buf, fmt, value, value); > + ListView_SetItemTextW(hwndLV, index, 2, buf); > + } > + break; > case REG_BINARY: { > unsigned int i; > LPBYTE pData = ValBuf; > dwCount is always 1 in this case, so it could be simplified to the point of swapping 'value' and falling through to REG_DWORD case. I didn't check tests, but you sure you need to modify what RegQueryValueExW() returns?

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21718 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21717 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21714 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w864 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w1064 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w864 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w1064 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21712 Your paranoid android. === w864 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21705 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21704 Your paranoid android. === wvistau64 (32 bit action) === The test timed out

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21702 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

[GSoC] Support of pluggable theming engines
by André Hentschel 28 Mar '16

28 Mar '16

Hi Ivan, all, You say in your proposal that you want to start with rewriting 30% of comctl32. Why so much? Is it currently needed for the gtk3 code in wine-staging?

4 11

Re: [v6 1/7] d3dx9: Introduce preshaders in effect.
by Matteo Bruni 27 Mar '16

27 Mar '16

2016-03-23 18:02 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: Sorry, I thought about this only now: > @@ -5569,7 +5579,15 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * > param->referenced_param = get_parameter_by_name(base, NULL, object->data); > if (param->referenced_param) > { > - TRACE("Mapping to parameter %p.\n", param->referenced_param); > + struct d3dx_parameter *refpar = param->referenced_param; > + > + TRACE("Mapping to parameter %p, having object id %u.\n", refpar, refpar->object_id); > + if (refpar->type == D3DXPT_VERTEXSHADER || refpar->type == D3DXPT_PIXELSHADER) > + { > + struct d3dx_object *refobj = &base->objects[refpar->object_id]; > + > + d3dx_create_param_eval(base, refobj->data, refobj->size, refpar->type, &refpar->param_eval); > + } If a parameter is referenced multiple times in an effect this probably allocates the param_eval structure more than once, leaking all but the last copy (well, it depends on the implementation of d3dx_create_param_eval(), but it should be the case here). I haven't tested that directly but I have tested that two references to the vs_arr array seem to lead to a similar issue WRT the array elements (i.e. the vertex shaders).

2 3

Re: d3d8: Unlock already unlocked surface does not fail
by Stefan Dösinger 27 Mar '16

27 Mar '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-03-27 um 13:05 schrieb David Adam: > Signed-off-by: David Adam <david.adam.cnrs(a)gmail.com> > --- > dlls/d3d8/surface.c | 9 ++++----- > dlls/d3d8/tests/visual.c | 14 ++++++++++++++ > 2 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/dlls/d3d8/surface.c b/dlls/d3d8/surface.c > index 565f642..376bc6f 100644 > --- a/dlls/d3d8/surface.c > +++ b/dlls/d3d8/surface.c > @@ -271,11 +271,10 @@ static HRESULT WINAPI d3d8_surface_UnlockRect(IDirect3DSurface8 *iface) > hr = wined3d_resource_unmap(wined3d_texture_get_resource(surface->wined3d_texture), surface->sub_resource_idx); > wined3d_mutex_unlock(); > > - switch(hr) > - { > - case WINEDDERR_NOTLOCKED: return D3DERR_INVALIDCALL; > - default: return hr; > - } > + if (hr == WINEDDERR_NOTLOCKED) > + return D3D_OK; I suspect that similarly to lock validation the behavior of double unlocks depends on the resource type (surface vs texture). > @@ -178,6 +178,8 @@ static D3DCOLOR get_surface_color(IDirect3DSurface8 *surface, UINT x, UINT y) > > hr = IDirect3DSurface8_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr=%#x.\n", hr); > + hr = IDirect3DSurface8_UnlockRect(surface); > + ok(SUCCEEDED(hr), "Failed to double unlock surface, hr=%#x.\n", hr); We have test_surface_double_unlock() in device.c and test_lockrect_invalid(). The test fits there better than sprinkled all around visual.c. (I have a preference for merging test_surface_double_unlock into test_lockrect_invalid, but I haven't looked closely how well that'll work) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW+AcxAAoJEN0/YqbEcdMwSYMP/ifDlI7N/z6QcEL6lRo9WsDr C+WfvTA6R4SRY+Wc/rWihX821b1mApv+kk9CSnZDSV96tpXKikjQdsMM5pB91oDW PDXxNkuoGpo1AR6gS5rve3fWc3vgRXSy7XzPLXAOlL6PF/lxbDcD/jixj8PjI6NZ Oel1ukbYuAr8dINKS8oB4tTZg59Pq/devXepJNlxxzfg11lgnoiF2kBYAlKZp+qC e59bWeZMixzB7ChzSUpAxlpjd+yipdtnVLKrq2codNYZn2Z+tV959MAZO+YYB35I BtHoSFNF16omLJ6qu9ZDZISOesep4YAlHyicERkZKR6kikaGI1/ezkxZtzD9zREn EDK5L+Trhar+XW/WgEYwJtIk9PAkJgLU53W5hgoq9TeDguMEtszvFj2GTStGEVnd M+dNN/4DQNg1aqCj1yRoom7N7WCVExWxdw9PlgqOFW68EjlNxZM2uO8S5pTNKx95 cBfxLYCI+agYj/aw3xOL3/yzNe4tI/pp+thsDlTqQZaXXTb3/S+ilChGEED9pQOz rHRQCP8yTsV9YtjWa2F+a/uSYP/LkZ9qFMkVzV9/nRw9GxpD0s2F7RdZVqhdW+VY eXW/YSDN+Mm8YF7MkWCKCeodDHL/VVqlDiEx8e+XQ96uELoiV2WP/GiVCwtjVMmb 9fib0jMQDGufm0Txe57H =pNWk -----END PGP SIGNATURE-----

1 0

Re: [1/3] user32/tests: Test loading monochrome icons.
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21687 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0.

2 1

Re: [3/3] user32: Correctly determine bit count for BITMAPCOREINFO in is_dib_monochrome.
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21689 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0.

1 0

Re: [2/3] user32: Handle BITMAPCOREINFO when loading icons.
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21688 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0.

1 0

Re: d3d8: Unlock already unlocked surface does not fail
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21685 Your paranoid android. === w8 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. === w864 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. === w1064 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c.

1 0

Re: [PATCH] winex11: Don't put a default icon on modal dialogs.
by Alexandre Julliard 26 Mar '16

26 Mar '16

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -611,7 +612,7 @@ static void fetch_icon_data( HWND hwnd, HICON icon_big, HICON icon_small ) > if (!icon_small) icon_small = (HICON)GetClassLongPtrW( hwnd, GCLP_HICONSM ); > } > > - if (!GetIconInfo(icon_big, &ii)) return; > + if (!GetIconInfo(icon_small, &ii) && !GetIconInfo(icon_big, &ii)) return; This doesn't make sense. What are you trying to do? -- Alexandre Julliard julliard(a)winehq.org

2 5

[GSOC] Implement rendering for Direct3D Retained Mode
by Aaryaman Vasishta 26 Mar '16

26 Mar '16

Hi, I have applied to GSoC this year, and I'm intending to continue my work on d3drm over this summer. Please review the proposal and provide feedback/comments, it would be very appreciated :) Cheers, Aaryaman

1 1

Re: [PATCH 1/3] msvcrt: Call C structured exception translator in x86_64 __CxxFrameHandler
by Piotr Caban 26 Mar '16

26 Mar '16

Please ignore this patches for now, they are too buggy. It was working quite well in my tests but crashes with most real applications. Looks like local unwinding is implemented incorrectly. Thanks, Piotr

1 0

Re: [PATCH 5/5] d3d9/tests: Add a test for color varyings clamping.
by Marvin 25 Mar '16

25 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21679 Your paranoid android. === w8 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w864 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w1064 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w864 (64 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w1064 (64 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1.

1 0

Re: Need some advice on shell32
by Mathy Vanvoorden 25 Mar '16

25 Mar '16

2016-03-25 16:15 GMT+01:00 Vincent Povirk <madewokherd(a)gmail.com>: > You didn't copy the list. Was that intentional? > Sorry, it was not, I recently switched to gmail and didn't notice the mailinglist fell off the CC list. > Related: While doing the research I came across some people trying to find > > out if the user is showing hidden files and there are some references to > > checking > Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\Hidden, > > would it not make sense to store the setting there in the same way > instead > > of the wine config? I'm not sure what the policy on this is. > > I'd consider "Are dotfiles hidden files?" and "Should shell views > display hidden files?" two distinct questions that should have > distinct settings. > I agree, they are.

1 0

Question about wine XWindow to HWND mapping
by Brandon Adkins 25 Mar '16

25 Mar '16

Hi guys. I am working on porting a Windows application over to Linux, and my hope is to use Wine to make that go as quickly as possible. In my research, I have found one possible hangup, and hopefully you guys can answer it in a few minutes, vs the week or so of work for me to test it out myself. Long story short, I have an application which creates child HWNDs. The application also launches separate processes. When WM_PAINT messages come in for those child HWNDs, it passes the HWND to one of the other processes, and that other process is the one that actually draws on it. This works great on Windows. But I have found out that Wine only makes XWindows for top level HWNDs. So my question is: Can an application in wine perform operations (like drawing, BitBlting) onto a child HWND owned by another process? Any tips or guidance you can give will be greatly appreciated. Best regards!

2 2

Re: [PATCH] riched20: Implement ITextRange::ScrollIntoView.
by Huw Davies 24 Mar '16

24 Mar '16

On Fri, Mar 18, 2016 at 11:59:52AM -0700, Adam Buchbinder wrote: > diff --git a/dlls/riched20/tests/richole.c b/dlls/riched20/tests/richole.c > index 7c6c5d5..de3c7a0 100644 > --- a/dlls/riched20/tests/richole.c > +++ b/dlls/riched20/tests/richole.c > @@ -53,6 +53,7 @@ static HWND new_window(LPCSTR lpClassName, DWORD dwStyle, HWND parent) > HWND hwnd = CreateWindowA(lpClassName, NULL, > dwStyle | WS_POPUP | WS_HSCROLL | WS_VSCROLL | WS_VISIBLE, > 0, 0, 200, 60, parent, NULL, hmoduleRichEdit, NULL); > + ok(hwnd != NULL, "class: %s, error: %d\n", lpClassName, (int) GetLastError()); > return hwnd; > } > > @@ -761,6 +762,66 @@ static void test_ITextRange_GetChar(void) > ITextRange_Release(txtRge); > } > > +/* Helper function for testing ITextRange_ScrollIntoView */ > +static void check_range(HWND w, ITextDocument* doc, int first, int lim, > + LONG bStart, int expected_nonzero) { Please put the opening brace on a new line. More importantly, I get a test failure: richole.c:785: Test failed: Moved scrollbar is at 60, should be 0. (Range 0-160.) Huw.

2 3

Re: [PATCH] wined3d: Support D3DFMT_L8 format as render target when supported by GPU.
by Henri Verbeet 24 Mar '16

24 Mar '16

On 23 March 2016 at 09:56, Paul Gofman <gofmanp(a)gmail.com> wrote: > Tested on Intel HD 4000 (L8 rt is not supported) and NVIDIA GeForce 650M > (L8 rt supported). Changes in query_internal_format are for avoiding > ERR in output when format is not supported as render target (RENDERTARGET > flag is cleared in check_fbo_compat which is called later). Is this needed by an application? Luminance formats aren't supposed to be color-renderable according to the OpenGL spec, and that's why you're getting GL_INVALID_ENUM in query_internal_format(). Does NVIDIA have some extension that allows this? > @@ -11279,6 +11279,7 @@ static void pixelshader_blending_test(void) > {"D3DFMT_R32F", D3DFMT_R32F, 0x0018ffff, 0x0020ffff}, > {"D3DFMT_G32R32F", D3DFMT_G32R32F, 0x001818ff, 0x002010ff}, > {"D3DFMT_A32B32G32R32F", D3DFMT_A32B32G32R32F, 0x00181800, 0x00201000}, > + {"D3DFMT_L8", D3DFMT_L8, 0x00181818, 0x002010ff}, The 0x002010ff there doesn't look right. It's also not exactly ideal that the red and green channels end up with the same values after blending, although that's and existing issue with the test.

3 7

Re: jscript: Added a few more arguments tests.
by Sebastian Lackner 24 Mar '16

24 Mar '16

On 24.03.2016 16:39, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/jscript/tests/lang.js | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Was it intentional that the newly added function is never called?

2 1

Re: jscript: Added a few more arguments tests.
by Marvin 24 Mar '16

24 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21665 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [v3] bcrypt: Added BCryptHash function.
by Patrick Armstrong 24 Mar '16

24 Mar '16

Thanks for all the help with the reviews! > On Mar 24, 2016, at 2:53 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > > > >

1 0

Possible security bug with unmount
by Cédric Picard 24 Mar '16

24 Mar '16

Hi, I find that DIR_unmount_device in wine/dlls/ntdll/directory.c (latest git) is looking like an unsafe use of system(). If a device was mounted to a point such as ";ls" I think it would be passed to system and cause a command injection. I didn't open a bug because I wasn't able to really test it due to my lack of knowledge of wine and because I can't think of a real world attack based on this as it needs to mount a device first but I think it's worth at least a thorough check. Cédric Picard

5 6

Re: [PATCH 1/4] xmllite/writer: Handle initial and ready states in the rest of tested Write* methods
by Dmitry Timoshkov 24 Mar '16

24 Mar '16

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + switch (This->state) > + { > + case XmlWriterState_Initial: > + return E_UNEXPECTED; > + case XmlWriterState_DocClosed: > + return WR_E_INVALIDACTION; > + default: > + ; > + } What's wrong with explicit 'break;' instead of weird ';'? -- Dmitry.

1 0

Re: oleaut32: add OleLoadPictureFile stub (try 2)
by Dmitry Timoshkov 24 Mar '16

24 Mar '16

Austin English <austinenglish(a)gmail.com> wrote: > -422 stub OleLoadPictureFile > +422 stdcall OleLoadPictureFile(long ptr) ... > +HRESULT WINAPI OleLoadPictureFile(VARIANT file, LPDISPATCH *picture) > +{ > + FIXME("(%p),stub!\n", picture); > + return E_NOTIMPL; > +} Is passing VARIANT by value supposed to be represented like this in a .spec file? -- Dmitry.

2 1

Re: oleaut32: add OleLoadPictureFile stub
by Andrew Eikum 24 Mar '16

24 Mar '16

> + * OleLoadPictureFile (OLEAUT32.422) > + */ > +HRESULT WINAPI OleLoadPictureFile(VARIANT file, LPDISPATCH *picture) > +{ > + FIXME("(%p),stub!\n", picture); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/*********************************************************************** This should return an HRESULT, right? Probably E_NOTIMPL. Andrew

2 1

Re: [v2] d3d9: Add test for D3DFMT_L8 format as render target.
by Henri Verbeet 23 Mar '16

23 Mar '16

On 23 March 2016 at 17:17, Paul Gofman <gofmanp(a)gmail.com> wrote: > @@ -11295,10 +11296,10 @@ static void pixelshader_blending_test(void) > /* Quad with R=0x10, G=0x20 */ > quad1[] = > { > - {{-1.0f, -1.0f, 0.1f}, 0x80102000}, > - {{-1.0f, 1.0f, 0.1f}, 0x80102000}, > - {{ 1.0f, -1.0f, 0.1f}, 0x80102000}, > - {{ 1.0f, 1.0f, 0.1f}, 0x80102000}, > + {{-1.0f, -1.0f, 0.1f}, 0x80103000}, > + {{-1.0f, 1.0f, 0.1f}, 0x80103000}, > + {{ 1.0f, -1.0f, 0.1f}, 0x80103000}, > + {{ 1.0f, 1.0f, 0.1f}, 0x80103000}, > }, The patch looks fine at first sight, but you should probably either update the comment or just remove it.

1 0

XInput and HID - architecture
by Juan Jose Gonzalez 23 Mar '16

23 Mar '16

Hi, I got a bit stuck and would like to hear your opinion on the XInput HID backend, specifically on the mappings, i.e. the code that "accepts" a certain device based on its properties and then maps its buttons and axes to XInput buttons and axes. As long as the mappings are fixed, i.e. are not supposed to be extended or edited by the user, everything can be compiled into xinput1_3.dll. However, I would like to provide a "xinput.cpl" control panel node for xinput similar to "joy.cpl", where the user can not only test the XInput gamepads, but also manage the XInput-HID backend mappings. The first part can be accomplished by using xinput1_3.dll. However, in order to load and persist different mappings, the second part requires access to the functions that serialize and deserialize the mappings. It also needs some way of getting raw capabilities and changes in HID devices in order to be able to create new mappings. Here are some possible ways of solving it: * Extend xinput1_3.dll with the required management functions and add a "wine/xinput_hid_mgmt.h" or similar header that declares those methods. xinput.cpl could then simply use xinput1_3.dll to perform all management functions. I'm not sure if this would break anything due to the additional exports in the dll. * Extract the mapping load and store logic into a separate "xinputhid.dll" or similar. I this case both xinput1_3.dll and xinput.cpl would access this library to load and store mappings. * Move the xinput core and backends into a driver and let xinput1_3.dll access it via IOCTLs. I believe this is the way it works on windows, although there doesn't seem to be any freely available documentation regarding the internal architecture. The XInput-HID backend could then create its own kernel object as a management interface, which could be accessed by xinput.cpl. This would have the added effect of having a single instance managing the xinput devices if several programs are running at the same time, which mimics the behavior of windows. What do you think would be the best option? Is there another way I haven't mentioned? - Juan

6 24

Re: [PATCH 2/5] d3d11/tests: Add test for ClearRenderTargetView().
by Marvin 23 Mar '16

23 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21619 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d10core/tests: Add test for ClearRenderTargetView().
by Marvin 23 Mar '16

23 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21618 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] xmllite/writer: Fix WriteEndElement()/WriteFullEndElement() on ready state
by Marvin 23 Mar '16

23 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21608 Your paranoid android. === build (build) === Patch failed to apply

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel