- wine-devel - winehq.org

Bored waiting for Wine 1.8?
by Jeremy White 15 Dec '15

15 Dec '15

Have I just got the thing for you! We are *this* close to having what I consider a rational set of Windows VMs running the tests cleanly: https://www.winehq.org/~jwhite/latest.html (As a reminder, that just scrapes all the testbot vms, excludes win2k, win8 and win10, and reports any ones that are not consistently green). We have a record low of 12 failures. Woohoo! I want to remind Andrew, Francois, Jacek, Aric, Bruno, Hans, Stefan and Jacek that they agreed to work on items on this … [View More]

1 0

d3d software cursor test
by Stefan Dösinger 15 Dec '15

15 Dec '15

Hi, I've written a test for d3d9 software cursors, but I'll need some help testing it on Windows. The behavior on Windows 10 is different from the one I remember from Windows 7. It doesn't affect the visual appearance of the cursor, but it does change how the test can verify the output. Please give the attached test a try on Windows. I am without my test machines right now (except for one with Win10 on it), so my abilities are somewhat limited at the moment. What I am interested in is the … [View More]

3 3

Re: [PATCH 3/5] wined3d: Add a real implementation of wined3d_check_device_multisample_type().
by Henri Verbeet 15 Dec '15

15 Dec '15

On 14 December 2015 at 23:37, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 70857c9..f798f1d 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -185,6 +185,7 @@ void wined3d_rb_free(void *ptr) DECLSPEC_HIDDEN; > #define MAX_SAMPLER_OBJECTS 16 > #define MAX_SHADER_RESOURCE_VIEWS 128 > #define MAX_VERTEX_BLENDS 4 > +#… [View More]

1 0

Re: [PATCH 5/5] d3d8/tests: Port test_checkdevicemultisampletype() to d3d8.
by Marvin 14 Dec '15

14 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18979 Your paranoid android. === w1064 (32 bit device) === device.c:2659: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2664: Test failed: The focus window is active. device.c:2672: Test … [View More]

1 0

Re: ddraw/tests: Rename mips to mipmaps
by Henri Verbeet 14 Dec '15

14 Dec '15

On 13 December 2015 at 22:33, André Hentschel <nerv(a)dawncrow.de> wrote: > GCC for mips defines mips to 1, thus this file won't build with a mips compiler without this patch > I think -std=c90 should help with that, although there may be some instances of e.g. "inline" and "typeof" we'd need to fix. Still, I like "mipmaps" better than "mips", even though it's supposed to be called "mipmap_count".

1 0

Re: ddraw/tests: Rename mips to mipmaps
by Marvin 13 Dec '15

13 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18975 Your paranoid android. === w1064 (32 bit dsurface) === dsurface.c:296: Test failed: Destination data after blitting is not correct dsurface.c:330: Test failed: Destination data after blitting is not correct dsurface.c:… [View More]

1 0

Re: [PATCH] Support -march in winegcc and winebuild
by André Hentschel 13 Dec '15

13 Dec '15

Am 13.12.2015 um 19:17 schrieb Stephen Kitt: > Since -mcpu is already supported, it seems to make sense to also support > -march. Having -march simplifies building for ARM platforms... > > Signed-off-by: Stephen Kitt <steve(a)sk2.org> > --- > tools/winebuild/build.h | 1 + > tools/winebuild/main.c | 2 ++ > tools/winebuild/utils.c | 1 + > tools/winegcc/winegcc.c | 2 +- > 4 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/… [View More]winebuild/build.h b/tools/winebuild/build.h > index 4a71eed..e32e7a9 100644 > --- a/tools/winebuild/build.h > +++ b/tools/winebuild/build.h > @@ -362,6 +362,7 @@ extern struct strarray *cc_command; > extern struct strarray *ld_command; > extern struct strarray *nm_command; > extern char *cpu_option; > +extern char *arch_option; > extern int thumb_mode; > > #endif /* __WINE_BUILD_H */ > diff --git a/tools/winebuild/main.c b/tools/winebuild/main.c > index d1717c0..08c8c2c 100644 > --- a/tools/winebuild/main.c > +++ b/tools/winebuild/main.c > @@ -89,6 +89,7 @@ struct strarray *cc_command = NULL; > struct strarray *ld_command = NULL; > struct strarray *nm_command = NULL; > char *cpu_option = NULL; > +char *arch_option = NULL; > > #ifdef __thumb__ > int thumb_mode = 1; > @@ -408,6 +409,7 @@ static char **parse_options( int argc, char **argv, DLLSPEC *spec ) > else if (!strcmp( optarg, "arm" )) thumb_mode = 0; > else if (!strcmp( optarg, "thumb" )) thumb_mode = 1; > else if (!strncmp( optarg, "cpu=", 4 )) cpu_option = xstrdup( optarg + 4 ); > + else if (!strncmp( optarg, "arch=", 5 )) arch_option = xstrdup( optarg + 5 ); > else fatal_error( "Unknown -m option '%s'\n", optarg ); > break; > case 'M': > diff --git a/tools/winebuild/utils.c b/tools/winebuild/utils.c > index 83eb803..4860a19 100644 > --- a/tools/winebuild/utils.c > +++ b/tools/winebuild/utils.c > @@ -388,6 +388,7 @@ struct strarray *get_as_command(void) > if (force_pointer_size) > strarray_add_one( args, (force_pointer_size == 8) ? "-m64" : "-m32" ); > if (cpu_option) strarray_add_one( args, strmake("-mcpu=%s", cpu_option) ); > + if (arch_option) strarray_add_one( args, strmake("-march=%s", arch_option) ); > return args; > } > > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index c07243b..1326afe 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -1525,7 +1525,7 @@ int main(int argc, char **argv) > strarray_add(opts.winebuild_args, argv[i]); > raw_linker_arg = 1; > } > - else if (strncmp("-mcpu=", argv[i], 6) == 0) > + else if (strncmp("-mcpu=", argv[i], 6) == 0 || strncmp("-march=", argv[i], 7) == 0) > strarray_add(opts.winebuild_args, argv[i]); > break; > case 'n': > Hi, please first change winebuild to support it, make the subject something like "[1/2] winebuild: Add support for -march" and please update tools/winebuild/winebuild.man.in In the second patch make use of that new feature in winegcc Otherwise it looks good, maybe mention why this is needed for Debian/armel [View Less]

2 1

Re: [PATCH 1/2] d3dx9_36/tests: Add D3DXSaveSurfaceToFileInMemory D3DXIFF_DDS tests (try 4)
by Matteo Bruni 11 Dec '15

11 Dec '15

2015-12-11 10:59 GMT+01:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > The DDS_CAPS_TEXTURE | DDSCAPS_ALPHA caps check was to address testbot failures > http://testbot.winehq.org/JobDetails.pl?Key=18888 Yes, I understand that. What I meant is that I don't get the header->caps == DDS_CAPS_TEXTURE case ever, except on Wine, so the check should be simply: todo_wine ok(header->caps == (DDS_CAPS_TEXTURE | DDSCAPS_ALPHA), "Got unexpected caps %x.\n", header-&… [View More]

2 7

Random err:winediag:nulldrv_CreateWindow errors related to windows and explorer
by Bruno Jesus 10 Dec '15

10 Dec '15

I believe that since code freeze started (or maybe 1.7.55) a random behavior was introduced related to these 2 messages: err:winediag:nulldrv_CreateWindow Application tried to create a window, but no driver could be loaded. err:winediag:nulldrv_CreateWindow The explorer process failed to start. Sometimes together there is also: err:ole:apartment_createwindowifneeded CreateWindow failed with error 0 I'm not seeing this alone. at November 23 there was a mention to it in bug https://bugs.winehq.… [View More]

5 8

Re: [PATCH] wined3d: Set WINED3D_BUFFER_DOUBLEBUFFER for managed buffers as well.
by Stefan Dösinger 10 Dec '15

10 Dec '15

> Am 08.12.2015 um 20:42 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > > - if (device->create_parms.flags & WINED3DCREATE_SOFTWARE_VERTEXPROCESSING) > + if (device->create_parms.flags & WINED3DCREATE_SOFTWARE_VERTEXPROCESSING || pool == WINED3D_POOL_MANAGED) This also helps bugs like 29878, or the Crysis bug that was I think incorrectly closed. However, the reason why I've never made this seemingly obvious change is that you'll get other … [View More]

3 4

Re: winepulse.drv: Add a winediag message when buffer is too small.
by Andrew Eikum 10 Dec '15

10 Dec '15

On Thu, Dec 10, 2015 at 03:27:24PM +0100, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > After pulseaudio was added, a lot of Debian people complained about missing sound. As it turns out, > this was the result of a packaging "mistake". Debian wrapper scripts set PULSE_LATENCY_MSEC to small > value by default, which worked fine with winealsa. > More than "worked fine," it actually made winealsa work better for some … [View More]

1 0

Re: [PATCH 1/2] d3dx9_36/tests: Add D3DXSaveSurfaceToFileInMemory D3DXIFF_DDS tests (try 3)
by Matteo Bruni 10 Dec '15

10 Dec '15

2015-12-09 5:35 GMT+01:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Also updates the structure dds_header to be the same as d3dx9_36/surface.c. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- Thank you for improving the patches according to our comments. I've found more though. > dlls/d3dx9_36/tests/surface.c | 45 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 44 insertions(+), 1 deletion(-) > &… [View More]gt; diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index 1697a03..eaab0f74 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -211,7 +211,9 @@ struct dds_header > struct dds_pixel_format pixel_format; > DWORD caps; > DWORD caps2; > - DWORD reserved2[3]; > + DWORD caps3; > + DWORD caps4; > + DWORD reserved2; > }; > > /* fills dds_header with reasonable default values */ > @@ -1231,6 +1233,8 @@ static void test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > RECT rect; > ID3DXBuffer *buffer; > IDirect3DSurface9 *surface; > + struct dds_header *header; > +#define BROKEN_CAPS (DDS_CAPS_TEXTURE | 0x02) You don't need a define for this, I'd just put the expression in the ok() or maybe use a const DWORD variable for this kind of situation. FWIW 0x2 is probably DDSCAPS_ALPHA (see ddraw.h). Notice though that I always get 0x1002 in the caps field on Windows (7 and XP tested) so probably it isn't right to consider that result as broken. Did you actually get header->caps == DDS_CAPS_TEXTURE on any Windows version (and if so, which one)? If not I'd only accept (DDSCAPS_TEXTURE | DDSCAPS_ALPHA) as a valid result and add a todo_wine to the relevant ok() call. You don't need a define or const for the broken caps then and you can just put the expected result in the ok(). > > hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device, 4, 4, D3DFMT_A8R8G8B8, D3DPOOL_SCRATCH, &surface, NULL); > if (FAILED(hr)) { > @@ -1248,6 +1252,45 @@ static void test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > ID3DXBuffer_Release(buffer); > } > > + SetRectEmpty(&rect); > + hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, NULL, &rect); > + todo_wine ok(hr == D3D_OK, "Got unexpected hr %#x\n", hr); Missing period. > + if (SUCCEEDED(hr)) > + { > + header = ID3DXBuffer_GetBufferPointer(buffer); > + > + ok(header->magic == MAKEFOURCC('D','D','S',' '), "Invalid DDS signature.\n"); > + ok(header->size == 124, "Invalid DDS size %u.\n", header->size); > + ok(!header->height, "Got unexpected height %u.\n", header->height); > + ok(!header->width, "Got unexpected width %u.\n", header->width); > + ok(!header->depth, "Got unexpected depth %u.\n", header->depth); > + ok(!header->miplevels, "Got unexpected miplevels %u.\n", header->miplevels); > + ok(!header->pitch_or_linear_size, "Got unexpected pitch_or_linear_size %u.\n", header->pitch_or_linear_size); > + ok(header->caps == DDS_CAPS_TEXTURE || broken(header->caps == BROKEN_CAPS), > + "Got unexpected caps %x.\n", header->caps); Indentation. > + ok(header->flags == (DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT), > + "Got unexpected flags %x.\n", header->flags); > + ID3DXBuffer_Release(buffer); > + } > + > + hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, NULL, NULL); > + ok(hr == D3D_OK, "Got unexpected hr %#x\n", hr); Missing period. > + header = ID3DXBuffer_GetBufferPointer(buffer); > + > + ok(header->magic == MAKEFOURCC('D','D','S',' '), "Invalid DDS signature.\n"); > + todo_wine ok(header->size == 124, "Invalid DDS size %u.\n", header->size); > + ok(header->height == 4, "Got unexpected height %u.\n", header->height); > + ok(header->width == 4, "Got unexpected width %u.\n", header->width); > + todo_wine ok(!header->depth, "Got unexpected depth %u.\n", header->depth); > + todo_wine ok(!header->miplevels, "Got unexpected miplevels %u.\n", header->miplevels); > + todo_wine ok(!header->pitch_or_linear_size, "Got unexpected pitch_or_linear_size %u.\n", header->pitch_or_linear_size); > + ok(header->caps == DDS_CAPS_TEXTURE || broken(header->caps == BROKEN_CAPS), > + "Got unexpected caps %x.\n", header->caps); > + todo_wine ok(header->flags == (DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT), > + "Got unexpected flags %x.\n", header->flags); > + ID3DXBuffer_Release(buffer); > + > +#undef BROKEN_CAPS > IDirect3DSurface9_Release(surface); > } Looks good to me otherwise. [View Less]

1 0

Release status
by Alexandre Julliard 10 Dec '15

10 Dec '15

Folks, I'm pleased with the progress we've made since code freeze started, with about 40 regressions and many other bugs fixed. Thanks to everybody for taking the time to fix them! At this point it looks like we are running out of easily fixable bugs, so my plan is that rc4 is going to be the last release candidate, and that 1.8 will be released next week. Note also that rc4 is going to be a little delayed since I'm travelling on Friday; it will be out during the weekend. Thank you all for … [View More]

1 0

Re: [PATCH] msvcrt: Add tmpnam_s() and _wtmpnam_s() with tests.
by Piotr Caban 10 Dec '15

10 Dec '15

Hi, it this patch fixing any application or is it only letting it execute a little further? It doesn't compile: ../../../wine_src/dlls/msvcr71/msvcr71.spec:667: function 'MSVCRT_wtmpnam' not defined ../../../wine_src/dlls/msvcr70/msvcr70.spec:671: function 'MSVCRT_wtmpnam' not defined ... On 12/10/15 00:08, lejcik wrote: > /********************************************************************* > + * tmpnam_s (MSVCRT.@) > + */ > +int CDECL MSVCRT_tmpnam_s(char *s, … [View More]

1 0

Re: winhttp/tests: Add an authentication test using IWinHttpRequest.
by Hans Leidekker 10 Dec '15

10 Dec '15

It doesn't build cleanly for me: winhttp.c: In function ‘test_IWinHttpRequest’: winhttp.c:3631:5: warning: implicit declaration of function ‘sprintf’ [-Wimplicit-function-declaration] sprintf( buf, "http://localhost:%d/auth", port ); ^ winhttp.c:3631:5: warning: incompatible implicit declaration of built-in function ‘sprintf’

1 0

Re: programs/iexplore: sync registry and program resource values
by Alexandre Julliard 10 Dec '15

10 Dec '15

Austin English <austinenglish(a)gmail.com> writes: > From: Austin English <austinenglish(a)gmail.com> > Date: Tue, 8 Dec 2015 17:05:28 -0600 > Subject: [PATCH] programs/iexplore: sync registry and program resource values > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > programs/iexplore/iexplore.rc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Which bug is this for? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] wined3d: Restore WINEDDBLT_ALPHATEST support.
by Henri Verbeet 09 Dec '15

09 Dec '15

On 7 December 2015 at 23:36, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > -static void arbfp_blit_surface(struct wined3d_device *device, DWORD filter, > +static void arbfp_blit_surface(enum wined3d_blit_op op, struct wined3d_device *device, DWORD filter, I think I'd prefer "device" to stay the first parameter for consistency with the other blitter ops. It's probably not a big deal though. > @@ -7881,6 +7885,9 @@ static void arbfp_blit_surface(struct wined3d_device *device,… [View More]

2 3

Re: [PATCH 3/3] bthprops.cpl: add BluetoothFindFirstRadio/BluetoothFindRadioClose stubs
by Bruno Jesus 09 Dec '15

09 Dec '15

On Sat, Dec 5, 2015 at 7:21 AM, Austin English <austinenglish(a)gmail.com> wrote: > > +HBLUETOOTH_RADIO_FIND WINAPI BluetoothFindFirstRadio(BLUETOOTH_FIND_RADIO_PARAMS *params, HANDLE *radio) > +{ > + FIXME("(%p %p): stub!\n", params, radio); > + *radio = NULL; > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return NULL; > +} Please set the last error to ERROR_NO_MORE_ITEMS. This is the common return when no devices are found and will make other … [View More]

1 0

Re: [1/2] riched32/tests: Add selection tests.
by Jactry Zeng 09 Dec '15

09 Dec '15

2015-12-08 21:55 GMT+08:00 Jactry Zeng <jzeng(a)codeweavers.com>: > > This patch try to reproduce reason of bug 32112: https://bugs.winehq.org/show_bug.cgi?id=32112 > riched32's selection is different to riched20's. It'll count some multibyte characters as two when riched20 count them as two. Sorry, a typo here: riched32's selection is different to riched20's. It'll count some multibyte characters as two when riched20 counts them as *one*. -- Regards, Jactry Zeng

1 0

Re: [PATCH] Programs: fix extrac32 heap leak
by Alex Henrie 08 Dec '15

08 Dec '15

> diff --git a/programs/extrac32/extrac32.c b/programs/extrac32/extrac32.c > index 63205e8..a6e7438 100644 > --- a/programs/extrac32/extrac32.c > +++ b/programs/extrac32/extrac32.c > @@ -207,6 +207,8 @@ static LPWSTR *get_extrac_args(LPWSTR cmdline, int *pargc) > str++; > } > > + HeapFree(GetProcessHeap(), 0, str); > + > argv[argc] = NULL; > *pargc = argc; I don't think this is right. Pointers to str are returned in the argv array, and … [View More]

1 0

Re: [PATCH] wined3d: Set WINED3D_BUFFER_DOUBLEBUFFER for managed buffers as well.
by Marvin 08 Dec '15

08 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18871 Your paranoid android. === w1064 (32 bit device) === device.c:2613: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2618: Test failed: The focus window is active. device.c:2626: Test … [View More]

1 0

Re: advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
by Marvin 08 Dec '15

08 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18853 Your paranoid android. === w1064 (32 bit security) === security.c:3740: Test failed: MACHINE\Software owner SID != Administrators SID. security.c:3780: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) … [View More]

1 0

Re: [PATCH] ddraw: Mark surfaces as lost on mode changes.
by Marvin 08 Dec '15

08 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18845 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2337: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2186: Test failed: Expected {0, 0, 512, 384}, … [View More]

1 0

Re: po: Use lowercase+underscore names for the replaceable parts of the French usage messages.
by Alexandre Julliard 08 Dec '15

08 Dec '15

Francois Gouget <fgouget(a)free.fr> writes: > This brings consistency and this format keeps the spellchecker happy. > > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > po/fr.po | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) I figured it out this time, but when sending patches that depend on each other, could you please number them so I don't have to try all possible orderings? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Call the EnumChildWindows callback using a wrapper.
by Sebastian Lackner 08 Dec '15

08 Dec '15

On 08.12.2015 09:53, Dmitry Timoshkov wrote: > +extern LRESULT WNDENUMPROC_wrapper( WNDENUMPROC proc, HWND hwnd, LPARAM lparam ); > +__ASM_GLOBAL_FUNC( WNDENUMPROC_wrapper, > + "pushl %ebp\n\t" > + __ASM_CFI(".cfi_adjust_cfa_offset 4\n\t") > + __ASM_CFI(".cfi_rel_offset %ebp,0\n\t") > + "movl %esp,%ebp\n\t" > + __ASM_CFI(".cfi_def_cfa_register %ebp\n\t") > + "pushl … [View More]

2 1

Re: [PATCH 2/2] d3dx9_36: Fix several issues in save_dds_surface_to_memory. (try 2)
by Henri Verbeet 08 Dec '15

08 Dec '15

Any time you find yourself writing something along the lines of "Fix several issues ..." in a patch description, that's an indication you should probably be writing several patches instead. On 7 December 2015 at 07:53, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > From: Christian Costa <titan.costa(a)gmail.com> > > This makes the default values line up with native. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> I … [View More]

1 0

Re: [PATCH 1/2] d3dx9_36/tests: Add D3DXSaveSurfaceToFileInMemory D3DXIFF_DDS tests (try 2)
by Henri Verbeet 08 Dec '15

08 Dec '15

On 7 December 2015 at 07:53, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > + SetRect(&rect, 0, 0, 0, 0); It's not a bit deal, but "SetRectEmpty(&rect);". > + hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, NULL, &rect); > + todo_wine ok(hr == D3D_OK, "D3DXSaveSurfaceToFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); Just write something like "Got unexpected hr %#x.\n". You can easily tell what the expected … [View More]

1 0

Re: po: Add a couple of missing ellipses to the Catalan translation.
by Alex Henrie 07 Dec '15

07 Dec '15

I'm attaching screenshots so you can see exactly what the problem is. I agree that having ellipses would be ideal, but would you please submit patches to fix this properly instead of breaking it in a different way? -Alex

2 1

Re: [3/4] winhttp/tests: Send a not empty payload in the server authorization response, check the received data on the client side.
by Hans Leidekker 07 Dec '15

07 Dec '15

On Mon, 2015-12-07 at 13:16 +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/winhttp/tests/winhttp.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) It fails here: winhttp.c:2389: Test failed: expected 11, got 15

3 4

Re: [PATCH 2/3] include: add bluetoothapis.h
by Nikolay Sivov 04 Dec '15

04 Dec '15

On 05.12.2015 2:21, Austin English wrote: > +typedef struct _BLUETOOTH_ADDRESS { > + union { > + BTH_ADDR ullLong; > + BYTE rgBytes[ 6 ]; > + }; > +} BLUETOOTH_ADDRESS_STRUCT; > +#define BLUETOOTH_NULL_ADDRESS ( (ULONGLONG) 0x0) > +typedef struct _BLUETOOTH_FIND_RADIO_PARAMS { > + DWORD dwSize; > +} BLUETOOTH_FIND_RADIO_PARAMS; > +typedef struct _BLUETOOTH_DEVICE_SEARCH_PARAMS { > + DWORD dwSize; > + BOOL … [View More]

1 0

Re: [PATCH 1/3] include: add bthsdpdef.h
by Nikolay Sivov 04 Dec '15

04 Dec '15

> +struct SDP_LARGE_INTEGER_16 { > + ULONGLONG LowPart; > + LONGLONG HighPart; > +}; > + > +struct SDP_ULARGE_INTEGER_16 { > + ULONGLONG LowPart; > + ULONGLONG HighPart; > +}; > + > +typedef struct SDP_LARGE_INTEGER_16 SDP_LARGE_INTEGER_16, *PSDP_LARGE_INTEGER_16, *LPSDP_LARGE_INTEGER_16; > +typedef struct SDP_ULARGE_INTEGER_16 SDP_ULARGE_INTEGER_16, *PSDP_ULARGE_INTEGER_16, *LPSDP_ULARGE_INTEGER_16; > +enum SDP_TYPE { > + … [View More]

1 0

Re: [PATCH] configure: Create d3dx10.lib
by Matteo Bruni 04 Dec '15

04 Dec '15

2015-12-03 8:13 GMT+01:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 2d2a168..187c963 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2791,7 +2791,7 @@ WINE_CONFIG_DLL(d3dx10_39) > WINE_CONFIG_DLL(d3dx10_40) > WINE_CONFIG_DLL(… [View More]

2 1

Re: [PATCH 2/2] d3dx9_36: Fix several issues in save_dds_surface_to_memory.
by Matteo Bruni 04 Dec '15

04 Dec '15

2015-12-03 7:55 GMT+01:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > From: Christian Costa <titan.costa(a)gmail.com> > > The different fixes are: > - Fix header size of the DDS file > - Remove DDS_MIPMAPCOUNT as mipmap levels are not supported yet That's okay but not for the the right reason (a good reason is matching native, as the test in the previous patch shows). > - Do not set depth and miplevels fields as their flags are not set (to match … [View More]native) That's not really significant, the DDS_MIPMAPCOUNT flag is effectively ignored when loading DDS files (see test_dds_header_handling()). Again, setting depth and miplevels to 0 matches native so that's fine for now. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3dx9_36/surface.c | 7 +++---- > dlls/d3dx9_36/tests/surface.c | 8 ++++---- > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c > index b14f5e7..6857c56 100644 > --- a/dlls/d3dx9_36/surface.c > +++ b/dlls/d3dx9_36/surface.c > @@ -487,13 +487,12 @@ static HRESULT save_dds_surface_to_memory(ID3DXBuffer **dst_buffer, IDirect3DSur > > memset(header, 0, sizeof(*header)); Idea for a possible followup, we allocate the ID3DXBuffer objects data with HEAP_ZERO_MEMORY so that memset is unnecessary. There might be more of that kind of unnecessary explicit zeroing in d3dx9. This requires a test for D3DXCreateBuffer() (probably in test_ID3DXBuffer()) to check that we're actually supposed to zero the memory in the first place. > header->signature = MAKEFOURCC('D','D','S',' '); > - header->size = sizeof(*header); > - header->flags = DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PITCH | DDS_PIXELFORMAT | DDS_MIPMAPCOUNT; > + /* The signature is not really part of the DDS header */ > + header->size = sizeof(*header) - sizeof(header->signature); > + header->flags = DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT; > header->height = src_desc.Height; > header->width = src_desc.Width; > header->pitch_or_linear_size = dst_pitch; > - header->depth = 1; > - header->miplevels = 1; > header->caps = DDS_CAPS_TEXTURE; > hr = d3dformat_to_dds_pixel_format(&header->pixel_format, src_desc.Format); > if (FAILED(hr)) > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index 1c85ca3..b735af0 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -1274,12 +1274,12 @@ static void test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > header = ID3DXBuffer_GetBufferPointer(buffer); > > ok(header->magic == MAKEFOURCC('D','D','S',' '), "Invalid DDS signature\n"); > - todo_wine ok(header->size == 124, "Invalid DDS size %d\n", header->size); > + ok(header->size == 124, "Invalid DDS size %d\n", header->size); > ok(header->height == 4, "Wrong height %d\n", header->height); > ok(header->width == 4, "Wrong width %d\n", header->width); > - todo_wine ok(header->depth == 0, "Wrong depth %d\n", header->depth); > - todo_wine ok(header->miplevels == 0, "Wrong miplevels %d\n", header->miplevels); > - todo_wine ok(header->flags == (DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT), > + ok(header->depth == 0, "Wrong depth %d\n", header->depth); > + ok(header->miplevels == 0, "Wrong miplevels %d\n", header->miplevels); > + ok(header->flags == (DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT), > "Wrong flags %x\n", header->flags); > ID3DXBuffer_Release(buffer); > } > -- > 1.9.1 [View Less]

1 0

Re: [PATCH 1/2] d3dx9_36/tests: Add D3DXSaveSurfaceToFileInMemory D3DXIFF_DDS tests
by Matteo Bruni 04 Dec '15

04 Dec '15

2015-12-03 7:55 GMT+01:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Also updates the structure dds_header to be the same as d3dx9_36/surface.c. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3dx9_36/tests/surface.c | 38 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 37 insertions(+), 1 deletion(-) > > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index … [View More]1697a03..1c85ca3 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -211,7 +211,9 @@ struct dds_header > struct dds_pixel_format pixel_format; > DWORD caps; > DWORD caps2; > - DWORD reserved2[3]; > + DWORD caps3; > + DWORD caps4; > + DWORD reserved2; > }; > > /* fills dds_header with reasonable default values */ > @@ -1231,6 +1233,7 @@ static void test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > RECT rect; > ID3DXBuffer *buffer; > IDirect3DSurface9 *surface; > + struct dds_header *header; > > hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device, 4, 4, D3DFMT_A8R8G8B8, D3DPOOL_SCRATCH, &surface, NULL); > if (FAILED(hr)) { > @@ -1248,6 +1251,39 @@ static void test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > ID3DXBuffer_Release(buffer); > } > > + SetRect(&rect, 0, 0, 0, 0); > + hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, NULL, &rect); > + todo_wine ok(hr == D3D_OK || broken(hr == D3DERR_INVALIDCALL), "D3DXSaveSurfaceToFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); If the broken() predicate is there for the same reason as the previous test (i.e. failure with the debug d3d9 runtime) I think it should be dropped. If that's not the case, where does this fail for you? Please put a period at the end of the ok() string. > + if (SUCCEEDED(hr)) { '{' on the next line please. > + header = ID3DXBuffer_GetBufferPointer(buffer); > + > + ok(header->magic == MAKEFOURCC('D','D','S',' '), "Invalid DDS signature\n"); > + ok(header->size == 124, "Invalid DDS size %d\n", header->size); > + ok(header->height == 0, "Wrong height %d\n", header->height); We usually do something like "!header->height" in d3d code in similar cases. > + ok(header->width == 0, "Wrong width %d\n", header->width); > + ok(header->depth == 0, "Wrong depth %d\n", header->depth); > + ok(header->miplevels == 0, "Wrong miplevels %d\n", header->miplevels); > + ok(header->flags == (DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT), > + "Wrong flags %x\n", header->flags); Please use 8 spaces indents for line continuations. > + ID3DXBuffer_Release(buffer); > + } > + > + hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, NULL, NULL); > + ok(hr == D3D_OK || broken(hr == D3DERR_INVALIDCALL), "D3DXSaveSurfaceToFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) { You can avoid the 'if' here if you don't need the broken() above. > + header = ID3DXBuffer_GetBufferPointer(buffer); > + > + ok(header->magic == MAKEFOURCC('D','D','S',' '), "Invalid DDS signature\n"); > + todo_wine ok(header->size == 124, "Invalid DDS size %d\n", header->size); > + ok(header->height == 4, "Wrong height %d\n", header->height); > + ok(header->width == 4, "Wrong width %d\n", header->width); > + todo_wine ok(header->depth == 0, "Wrong depth %d\n", header->depth); > + todo_wine ok(header->miplevels == 0, "Wrong miplevels %d\n", header->miplevels); > + todo_wine ok(header->flags == (DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT), > + "Wrong flags %x\n", header->flags); > + ID3DXBuffer_Release(buffer); > + } > + > IDirect3DSurface9_Release(surface); > } > > -- > 1.9.1 [View Less]

1 0

Re: [PATCH 1/2] wined3d: Correctly parse SM4 dcl_immediateConstantBuffer opcode.
by Henri Verbeet 04 Dec '15

04 Dec '15

On 3 December 2015 at 11:04, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > This fixes infinite loop when dcl_immediateConstantBuffer is parsed. > > Unfortunately, I had to reindent whole wined3d_sm4_opcode enum in order to make > space for WINED3D_SM4_OP_DCL_IMMEDIATE_CONSTANT_BUFFER. I was also considering > to use a shorter name: WINED3D_SM4_OP_DCL_IMMEDIATE_BUFFER. > --- It's fine, if perhaps … [View More]

2 3

Re: [PATCH 2/2] wined3d: Print opcode names instead of enum values.
by Henri Verbeet 04 Dec '15

04 Dec '15

On 3 December 2015 at 11:04, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +const char *debug_d3dshaderinstructionhandler(enum WINED3D_SHADER_INSTRUCTION_HANDLER handler_idx) > +{ > + if (handler_idx >= sizeof(shader_opcode_names) / sizeof(*shader_opcode_names)) > + { > + FIXME("Unrecognized shader instruction handler %#x.\n", handler_idx); > + return "UNRECOGNIZED"; You can do something like "wine_dbg_sprintf("UNRECOGNIZED(%#x)", handler_idx);" … [View More]

2 1

Re: [PATCH 3/3] ddraw: Do not mark surfaces as lost unconditionally when setting the cooperative level.
by Marvin 04 Dec '15

04 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18780 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2337: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2186: Test failed: Expected {0, 0, 512, 384}, … [View More]

1 0

Re: [PATCH 2/3] ddraw: Mark surfaces as lost when the device window is deactivated.
by Marvin 04 Dec '15

04 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18779 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2337: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2186: Test failed: Expected {0, 0, 512, 384}, … [View More]

1 0

Re: fusion: add a stub for CopyPDBs
by Sebastian Lackner 04 Dec '15

04 Dec '15

On 02.12.2015 07:19, Austin English wrote: > +void WINAPI CopyPDBs(const WCHAR *module) Did you find the prototype somewhere? The output doesn't really look a WCHAR string: fixme:fusion:CopyPDBs (L"\4141\636a\304d\7257\5355\666c\4262\3552\7445\5063\3353\5338\3533\5656\6f63\7674\427a\7457\6249\4d41\7858\7362\5135\6164\6b36\4c71\5277\3351\642f\796c\5755\7452\3735\6a50\3658\5a59\546d\5763\4276\7a45\4b43\5362\7655\5132\4b39\4339\4d37\5131\4f79\5645\452b\5364\4272\4a51\3832\4458\5435\6b77\3454\… [View More]

2 1

Re: mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (try 3)
by Jacek Caban 03 Dec '15

03 Dec '15

Hi Zhenbo, On 12/03/15 02:34, Zhenbo Li wrote: > Thanks for the reply. The patch looks good to me now, thanks. However, we're in the code freeze, so the patch can't be committed now. Please resend the patch after 1.8 is released. Jacek

1 0

programs/xcopy: Fix casing of usage message
by Hugh McMaster 03 Dec '15

03 Dec '15

On Wednesday, 18 Nov 2015 19:08:29 -0600, Austin English wrote: >- STRING_SIMCOPY, "%1!d! file(s) would be copied\n" >- STRING_COPY, "%1!d! file(s) copied\n" >+ STRING_SIMCOPY, "%1!d! File(s) would be copied\n" >+ STRING_COPY, "%1!d! File(s) copied\n" Hi Austin, You should probably patch all of the po files as well. It's a simple change, and it means Alexandre doesn't have to regenerate everything. -- Hugh McMaster

3 6

Simplified local IP reordering patch for default routes
by Bruno Jesus 03 Dec '15

03 Dec '15

Hi, Jamie and Joachim and list. This is a short version of a long patch I'm working on, it orders the IP list with the default routes on top and it supports more than one default route. It fixes the problem on Linux and FreeBSD, could anyone also test it on OSX, please? This patch does not touch the magic IP so the loopback route will still return the IP 127.12.34.56 but at least it won't be the first one anymore. Thanks in advance, Bruno

3 6

Re: winedbg: Print windows version in system info.
by Austin English 02 Dec '15

02 Dec '15

On Wed, Dec 2, 2015 at 5:20 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > From: Michael Müller <michael(a)fds-team.de> > > Signed-off-by: Michael Müller <michael(a)fds-team.de> > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > ... for those who don't have a crystal ball while triaging bug reports. :) > > programs/winedbg/tgt_active.c | 58 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 … [View More]insertions(+) > > diff --git a/programs/winedbg/tgt_active.c b/programs/winedbg/tgt_active.c > index 989e433..07edccc 100644 > --- a/programs/winedbg/tgt_active.c > +++ b/programs/winedbg/tgt_active.c > @@ -678,6 +678,63 @@ static HANDLE create_temp_file(void) > NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL | FILE_FLAG_DELETE_ON_CLOSE, 0 ); > } > > +static const struct > +{ > + int type; > + int platform; > + int major; > + int minor; > + const char *str; > +} > +version_table[] = > +{ > + { 0, VER_PLATFORM_WIN32s, 2, 0, "2.0" }, > + { 0, VER_PLATFORM_WIN32s, 3, 0, "3.0" }, > + { 0, VER_PLATFORM_WIN32s, 3, 10, "3.1" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 0, "95" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 10, "98" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 90, "ME" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 3, 51, "NT 3.51" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 4, 0, "NT 4.0" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 0, "2000" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 1, "XP" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 2, "XP" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 5, 2, "Server 2003" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 0, "Vista" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 0, "Server 2008" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 1, "7" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 1, "Server 2008 R2" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 2, "8" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 2, "Server 2012" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 3, "8.1" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 3, "Server 2012 R2" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 10, 0, "10" }, > +}; > + > +static const char *get_windows_version(void) > +{ > + OSVERSIONINFOEXW info = { sizeof(OSVERSIONINFOEXW) }; > + static char str[64]; > + int i; > + > + GetVersionExW( (OSVERSIONINFOW *)&info ); > + > + for (i = 0; i < sizeof(version_table) / sizeof(version_table[0]); i++) > + { > + if (version_table[i].type == info.wProductType && > + version_table[i].platform == info.dwPlatformId && > + version_table[i].major == info.dwMajorVersion && > + version_table[i].minor == info.dwMinorVersion) > + { > + return version_table[i].str; > + } > + } > + > + snprintf( str, sizeof(str), "%d.%d (%d)", info.dwMajorVersion, > + info.dwMinorVersion, info.wProductType ); > + return str; > +} > + > static void output_system_info(void) > { > #ifdef __i386__ > @@ -705,6 +762,7 @@ static void output_system_info(void) > dbg_printf( "System information:\n" ); > if (wine_get_build_id) dbg_printf( " Wine build: %s\n", wine_get_build_id() ); > dbg_printf( " Platform: %s%s\n", platform, is_wow64 ? " (WOW64)" : "" ); > + dbg_printf( " Version: Windows %s\n", get_windows_version() ); > if (wine_get_host_version) > { > const char *sysname, *release; > -- > 2.6.2 > > With my bugzilla hat on: Thank you!! -- -Austin [View Less]

1 0

Re: loader/wine.inf.in: add 'HKLM\Software\Classes\Applications\iexplore.exe\shell\open\command' key
by Jacek Caban 02 Dec '15

02 Dec '15

Hi Austin, On 12/02/15 07:31, Austin English wrote: > > From a8309f37269bc374359e6ee473e66465551b867f Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 2 Dec 2015 01:27:15 -0500 > Subject: [PATCH] loader/wine.inf.in: add > 'HKLM\Software\Classes\Applications\iexplore.exe\shell\open\command' key > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > loader/wine.inf.in | 1 + > 1 file changed, 1 … [View More]

2 1

Re: [PATCH 3/3] ntdll/tests: Restore old value in a more context independent way.
by Marvin 02 Dec '15

02 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18722 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002D0000/002D0001 exception: unhandled exception 80000004 at 002D0000 exception.c:485: Test failed: … [View More]

1 0

Re: [PATCH 1/3] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 4).
by Marvin 02 Dec '15

02 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18721 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: … [View More]

1 0

Re: [PATCH 4/4 v2] dsound: Fail to create a version 8 3d buffer with DSBCAPS_CTRLPAN
by Andrew Eikum 02 Dec '15

02 Dec '15

This looks fine, but since it doesn't fix a bug, I think this one should be deferred. As Michael knows, dsound applications can be fragile... Andrew On Tue, Dec 01, 2015 at 02:49:45PM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 5 +++++ > dlls/dsound/tests/ds3d8.c | 1 - > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c … [View More]

1 0

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).
by Alexandre Julliard 02 Dec '15

02 Dec '15

Qian Hong <qhong(a)codeweavers.com> writes: > Try 3: > - Correctly revert side effect of previous ldmxcsr, change 0x200 to > 0x80, 0x80 & 0xff7f = 0, 0x200 & 0xfdff = 0. It would be even better to restore the original value, without making assumptions about the previous contents. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).
by Marvin 02 Dec '15

02 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18719 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: … [View More]

1 0

Re: [PATCH] ntdll: Fix valgrind heap realloc notifications.
by Alexandre Julliard 02 Dec '15

02 Dec '15

Thomas Faller <tfaller1(a)gmx.de> writes: > Valgrind can't handle a realloc, if the new size is zero. > Fix for bug https://bugs.winehq.org/show_bug.cgi?id=37646 I'd suggest fixing valgrind, or if not possible, using a size of 1. Your change seems like it would make notifications less useful in several cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel