- wine-devel - winehq.org

Re: [PATCH] ddraw/tests: 64-bit ddraw doesn't support textures.
by Marvin 01 Dec '15

01 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18683 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2184: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] ole2disp: Implement VariantInit()
by Alexandre Julliard 01 Dec '15

01 Dec '15

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -39,4 +39,43 @@ INT16 WINAPI SysReAllocString16(LPBSTR16,LPCOLESTR16); > int WINAPI SysReAllocStringLen16(BSTR16*, const char*, int); > int WINAPI SysStringLen16(BSTR16); > > +typedef struct tagVARIANT16 { > + VARTYPE vt; > + WORD wReserved1; > + WORD wReserved2; > + WORD wReserved3; > + union { > + BYTE bVal; > + SHORT iVal; > + LONG lVal; > + FLOAT fltVal; > + DOUBLE dblVal; > + VARIANT_BOOL boolVal; > + SCODE scode; > + DATE date; > + BSTR16 bstrVal; > + CY cyVal; > + IUnknown *punkVal; > + IDispatch *pdispVal; > + SAFEARRAY *parray; > + BYTE *pbVal; > + SHORT *piVal; > + LONG *plVal; > + FLOAT *pfltVal; > + DOUBLE *pdblVal; > + VARIANT_BOOL *pboolVal; > + SCODE *pscode; > + DATE *pdate; > + BSTR16 *pbstrVal; > + struct tagVARIANT16 *pvarVal; > + void *byref; > + CY *pcyVal; > + IUnknown **ppunkVal; > + IDispatch **ppdispVal; > + SAFEARRAY **pparray; > + } u; > +} VARIANT16; The pointers should all be SEGPTR. Some of the existing definitions like BSTR16 probably need to be fixed too. In any case this will have to wait until after code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

Make a 16-bit test in wine for krnl386.exe16
by Bruno Jesus 01 Dec '15

01 Dec '15

Hi all, I'm trying to create tests for GetPrivateProfileString16 but it is not working as expected because the test is calling the kernel32 version of the function instead of the krnl386.exe16. Is there any way to make a test that compiles and runs against krnl386 instead of kernel32? I tried a few different things and the attached patch is the last attempt (the tests are wrong but that is not the point yet). Any help is appreciated, thanks in advance, Bruno

7 11

Re: mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (try 2)
by Jacek Caban 30 Nov '15

30 Nov '15

Hi Zhenbo, On 11/04/15 15:34, Zhenbo Li wrote: > Try 2: > Thanks Nikolay & Jacek > Making the ERR() less verbose > > > Signed-off-by: Zhenbo Li <litimetal(a)gmail.com> > --- > dlls/mshtml/tests/xmlhttprequest.c | 41 +++++++++++++++++++++++++++++ > dlls/mshtml/xmlhttprequest.c | 53 > ++++++++++++++++++++++++++++++++++++-- > 2 files changed, 92 insertions(+), 2 deletions(-) Sorry for the delay, I was waiting for wine-devel discussion to come to conclusion, but failed to reply when it did. It would be nice to move it from pending state, although I'm not sure we can do that before code freeze. + + hres = IXMLDOMDocument_loadXML(xmldoc, str, &vbool); + SysFreeString(str); + if(hres != S_OK || vbool != VARIANT_TRUE) { + ERR("loadXML failed: %08x\n", hres); + IXMLDOMDocument_Release(xmldoc); + return hres; + } Note that if loadXML fails, you will return S_FALSE here, which I'm sure is desired. It would be nice to have a test for that. Also discussion with Nikolay convinced me that assert() would be a better way to handle IObjectSafety errors. Thanks, Jacek

3 4

Learning to Develop for the Wine Project
by David Reinert 30 Nov '15

30 Nov '15

Hello Friends, I am a current undergraduate senior Computer Science major looking to become familiar with and contribute to Wine. I just want to make sure I am doing all the best things I can do to familiarize myself with the project. I have over 3 years of experience coding in C/C++ and I have taken a course in Operating systems, but my familiarity with any MS-DOS/Windows based OS(DLLs, etc.) is next to none and I understand that the learning curve for Wine development is very steep. I've started by reading through the Wine Developer's Guide Wine Architecture section to try and gain an understanding of how the whole process operates. is this useful? Is there anything else that anyone would recommend I do to gain to good understanding of the project or should I just start writing patches and dive in head first? Any and all suggestions are welcome and Iwould appreciate any advice. Thanks, David Reinert

2 1

Wine devel packages ready for testing
by Michael Müller 30 Nov '15

30 Nov '15

Hi, at WineConf we discussed about providing binary packages and the idea was that Sebastian and I take care of this, since we already build packages for Wine Staging. We now altered our build system to work in a more general way and you can now try out the first packages. We already tested them shortly, but since we do not use all those distros on a daily basis, we might still have missed something. Before I tell you the distribution specific installation instructions, first a more general overview about how the packages work. There are already a lot of different Wine packages out there, so our goal was to choose names which are not yet used on any system. To keep the risk of name collisions as small as possible, we decided for the following approach: winehq-devel winehq-staging These are the names of the packages which are most suitable for average users. The package will provide programs in /usr/bin (or some other distro-specific default installation path) and provide all the usual wine-specifc commands, like "wine", "winegcc", "wineserver", ... and so on. It will also contain the manpages, and desktop files. In the background, those packages do not really contain the binaries but instead pull in additional dependencies, on Debian/Ubuntu the "wine-devel" package and on Fedora/Mageia the "wine-development" package. Those packages install wine in /opt/wine-devel. On the one hand this makes clear, that its not a distribution provided package, as all files reside in /opt, on the other hand it gives much more flexibility. A user can now decide whether to install the winehq-devel package, which symlinks all files to their usual locations in /usr/{bin, share} etc. or whether he wants to install multiple wine versions at the same time by using the underlying wine-devel/wine-development package. Besides the possibility of having multiple wine versions installed at the same time, this way we could even ship additional dynamically linked libraries without messing around with the rest of the system, for example if distribution packages are incompatible with wine. Below are the instructions how to install those packages on various distributions. Executing wine --version (or /opt/wine-devel/bin/wine --version) should afterwards show 1.8rc-1. If you find any bugs, please report them so that we can fix them. You can also take a look at the packaging files at https://github.com/wine-compholio/wine-packaging (or send a pull request if you want to contribute with your improvements). In case everything is working fine, we should add those packages on the download page, so that more users can try out the release candidates for 1.8. So, as a short summary, about what is already working, and what still needs to be done: - We'll now be able to provide 8 Ubuntu, 8 Debian, 4 Mageia and 2 Fedora packages per release (which means about 44 build tasks per week). - Fedora 23 packages are still missing, but will be added soon. - Crosscompiled Mac OS X packages will also be added soon. - Additional distributions can be added on request - but please try to contact your distribution first! ---- Ubuntu ---- # Add repository sudo add-apt-repository ppa:wine/wine-builds # Update packages sudo apt-get update sudo apt-get install --install-recommends winehq-devel # Advanced users can instead install the wine-devel package # directly, in parallel to their regular Wine versions. ---- Debian ---- # Enable 32 bit packages sudo dpkg --add-architecture i386 # Install key which was used to sign packages wget https://dl.winehq.org/wine-builds/Release.key sudo apt-key add Release.key # Add repository to /etc/apt/sources.list or create a *.list # under /etc/apt/sources.list.d/ with the following content: deb https://dl.winehq.org/wine-builds/debian/ DISTRO main # with DISTRO being either wheezy, jessie, stretch or sid # Update packages sudo apt-get update sudo apt-get install winehq-devel # Advanced users can instead install the wine-devel package # directly, in parallel to their regular Wine versions. ---- Fedora ---- # Currently only Fedora 22 is supported, 23 will be added soon # Add repository dnf config-manager --add-repo https://dl.winehq.org/wine-builds/fedora/22/winehq.repo dnf apt-get install winehq-devel # Advanced users can instead install the wine-development package # directly, in parallel to their regular Wine versions. ---- Mageia ---- # Install key which was used to sign packages wget https://dl.winehq.org/wine-builds/Release.key sudo rpm --import Release.key # If you are using Mageia 4 sudo urpmi.addmedia "WineHQ 32-bit" https://dl.winehq.org/wine-builds/mageia/4/i586/ # If you are using 64-bit Mageia 4, also add sudo urpmi.addmedia "WineHQ 64-bit" https://dl.winehq.org/wine-builds/mageia/4/x86_64/ # If you are using Mageia 5 sudo urpmi.addmedia "WineHQ 32-bit" https://dl.winehq.org/wine-builds/mageia/5/i586/ # If you are using 64-bit Mageia 5, also add sudo urpmi.addmedia "WineHQ 64-bit" https://dl.winehq.org/wine-builds/mageia/4/x86_64/ sudo urpmi.update -a sudo urpmi winehq-devel # Advanced users can instead install the wine-development package # directly, in parallel to their regular Wine versions. ------------------ Regards, Michael

4 7

Re: [PATCH] ddraw/tests: Test color keys on cube map surfaces.
by Marvin 30 Nov '15

30 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18665 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2252: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

1 0

(OT) code siging on Mac OSX Re: Wine devel packages ready for testing
by Hin-Tak Leung 30 Nov '15

30 Nov '15

(going off topic) -------------------------------------------- On Mon, 30/11/15, Michael Müller <michael(a)fds-team.de> wrote: ... It is indeed difficult to sign executables without using any proprietary tools by Apple, but it seems like I found one which works. "codesign -vd wine" seems to like my signature, except that the tool slightly messed up the timestamp of the signature which now lies before the creation date of my self signed certificate. ... Can you tell me more about the open tool used for signing Mac OS X executables? I have been working on font signing in the recently open-sourced microsoft font validator (there is an official windows-only tool for signing fonts, but apparently an open-toolchain based tool also exist in somebody's hard disk) That although is part of an ISO standard for fonts, borrows heavily from microsoft's authenticode excutable signing infrastructure. For those who want to know. Hin-Tak

1 0

Re: rsaenh: Remove dead assignments (Clang)
by Nikolay Sivov 30 Nov '15

30 Nov '15

On 30.11.2015 0:31, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/rsaenh/sha2.c | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/dlls/rsaenh/sha2.c b/dlls/rsaenh/sha2.c > index 76e7184..71ebf23 100644 > --- a/dlls/rsaenh/sha2.c > +++ b/dlls/rsaenh/sha2.c > @@ -369,9 +369,6 @@ void SHA256_Transform(SHA256_CTX* context, const sha2_word32* data) { > context->state[5] += f; > context->state[6] += g; > context->state[7] += h; > - > - /* Clean up */ > - a = b = c = d = e = f = g = h = T1 = 0; > } > > #else /* SHA2_UNROLL_TRANSFORM */ > @@ -449,9 +446,6 @@ void SHA256_Transform(SHA256_CTX* context, const sha2_word32* data) { > context->state[5] += f; > context->state[6] += g; > context->state[7] += h; > - > - /* Clean up */ > - a = b = c = d = e = f = g = h = T1 = T2 = 0; > } > > #endif /* SHA2_UNROLL_TRANSFORM */ > @@ -483,8 +477,6 @@ void SHA256_Update(SHA256_CTX* context, const sha2_byte *data, size_t len) { > /* The buffer is not yet full */ > MEMCPY_BCOPY(&context->buffer[usedspace], data, len); > context->bitcount += len << 3; > - /* Clean up: */ > - usedspace = freespace = 0; > return; > } > } > @@ -500,8 +492,6 @@ void SHA256_Update(SHA256_CTX* context, const sha2_byte *data, size_t len) { > MEMCPY_BCOPY(context->buffer, data, len); > context->bitcount += len << 3; > } > - /* Clean up: */ > - usedspace = freespace = 0; > } > > void SHA256_Final(sha2_byte digest[], SHA256_CTX* context) { > @@ -564,7 +554,6 @@ void SHA256_Final(sha2_byte digest[], SHA256_CTX* context) { > > /* Clean up state data: */ > MEMSET_BZERO(context, sizeof(*context)); > - usedspace = 0; > } > > char *SHA256_End(SHA256_CTX* context, char buffer[]) { > @@ -693,9 +682,6 @@ void SHA512_Transform(SHA512_CTX* context, const sha2_word64* data) { > context->state[5] += f; > context->state[6] += g; > context->state[7] += h; > - > - /* Clean up */ > - a = b = c = d = e = f = g = h = T1 = 0; > } > > #else /* SHA2_UNROLL_TRANSFORM */ > @@ -771,9 +757,6 @@ void SHA512_Transform(SHA512_CTX* context, const sha2_word64* data) { > context->state[5] += f; > context->state[6] += g; > context->state[7] += h; > - > - /* Clean up */ > - a = b = c = d = e = f = g = h = T1 = T2 = 0; > } > > #endif /* SHA2_UNROLL_TRANSFORM */ > @@ -805,8 +788,6 @@ void SHA512_Update(SHA512_CTX* context, const sha2_byte *data, size_t len) { > /* The buffer is not yet full */ > MEMCPY_BCOPY(&context->buffer[usedspace], data, len); > ADDINC128(context->bitcount, len << 3); > - /* Clean up: */ > - usedspace = freespace = 0; > return; > } > } > @@ -822,8 +803,6 @@ void SHA512_Update(SHA512_CTX* context, const sha2_byte *data, size_t len) { > MEMCPY_BCOPY(context->buffer, data, len); > ADDINC128(context->bitcount, len << 3); > } > - /* Clean up: */ > - usedspace = freespace = 0; > } > > void SHA512_Last(SHA512_CTX* context) { > This and advapi32 looks like was done on purpose. Why are you removing that?

4 3

Re: secur32: Remove a dead assignment (Clang)
by Lauri Kenttä 30 Nov '15

30 Nov '15

On 2015-11-29 23:31, André Hentschel wrote: > - pfQOP = &fQOP; Surely nobody would write that kind of dead assignment if there wasn't some intended function for it. I wonder if this was supposed to be: if (pfQOP) *pfQOP = fQOP; After all, the parameter is designated as _Out_ in MSDN. -- Lauri Kenttä

2 1

Re: wininet: Fix allocation error handling (Clang)
by Jacek Caban 30 Nov '15

30 Nov '15

Hi André, On 11/29/15 19:53, André Hentschel wrote: > diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c > index 4784b33..0b7f5e1 100644 > --- a/dlls/wininet/cookie.c > +++ b/dlls/wininet/cookie.c > @@ -713,7 +713,8 @@ DWORD get_cookie_header(const WCHAR *host, const WCHAR *path, WCHAR **ret) > > *ret = header; > }else { > - res = ERROR_NOT_ENOUGH_MEMORY; > + LeaveCriticalSection(&cookie_cs); > + return ERROR_NOT_ENOUGH_MEMORY; How about returning res in the bottom of the function? Thanks, Jacek

2 1

Re: README: add a note about 64-bit Wine needing 32-bit Wine to work
by Dmitry Timoshkov 30 Nov '15

30 Nov '15

Austin English <austinenglish(a)gmail.com> wrote: > + http://wiki.winehq.org/Wine64 for details. Note that a 64-bit Wine > + build will not work without also building 32-bit Wine. This statement is not true in general. Actually 64-bit Wine build works just fine without any 32-bit part. That's just a useless configuration, but it's a minor detail. -- Dmitry.

5 10

Re: [PATCH] oleaut32/tests: Some tests for SafeArrayDestroyData()
by Marvin 30 Nov '15

30 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18658 Your paranoid android. === wvistau64 (64 bit safearray) === No test summary line found === w2008s64 (64 bit safearray) === No test summary line found === w7pro64 (64 bit safearray) === No test summary line found === w864 (64 bit safearray) === No test summary line found === w1064 (64 bit safearray) === No test summary line found

1 0

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 2).
by Marvin 30 Nov '15

30 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18657 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/003D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault.
by Marvin 30 Nov '15

30 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18654 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/003D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/003D0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Fwd: rsaenh: Remove dead assignments (Clang)
by Henri Verbeet 30 Nov '15

30 Nov '15

On 29 November 2015 at 23:39, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > This and advapi32 looks like was done on purpose. Why are you removing that? > Regardless of the merit of the various patches in this series, I think at best this kind of thing should get a "Deferred".

1 0

Re: [v2] ieframe: Don't release the advise sink in IOleObject::SetClientSite.
by Jacek Caban 30 Nov '15

30 Nov '15

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

1 0

Re: kernel32/tests: Fix the argument order in some console font tests
by Marvin 30 Nov '15

30 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18627 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2037567264 console.c:1445: Test failed: [15] Expected output count to be 0, got 2037567264 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2037567264 console.c:1689: Test failed: [13] Expected output count to be 0, got 2037567264 console.c:1689: Test failed: [15] Expected output count to be 0, got 2037567264 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2037567264

2 1

contribute to wine
by Abhijeet Panda 30 Nov '15

30 Nov '15

hello everyone, I am a undergrad student and have been using wine on my linux for a while. I am a big fan of this program and I want to contribute a lot to this. I have been through the getting started page. Is there anyone who could tell me the projects which are open and I could contribute to. thank you

3 2

Re: [v3] po: Update Simplified Chinese translation.
by Jactry Zeng 30 Nov '15

30 Nov '15

Hi Boyuan, Thanks for update! > #: oleacc.rc:99 > #, fuzzy > -#| msgid "Select" > msgctxt "object state" > msgid "selected" > msgstr "选择" I think "selected" here can be translated as "已选择". -- Regards, Jactry Zeng

1 0

Re: Revert "opengl32: Return a NULL pointer for functions requiring unsupported or disabled extensions.".
by Henri Verbeet 29 Nov '15

29 Nov '15

This is wrong. I we really want to add hacks for specific combinations of broken drivers and applications, we should be adding exceptions for specific extensions / functions. In the specific example of bug 38480, it should be easy enough to implement the required functionality on top of the core functionality in OpenGL 1.2 if the extension is not available.

6 16

Re: winspool: Remove dead code (Clang)
by Alex Henrie 29 Nov '15

29 Nov '15

- if(WINSPOOL_GetStringFromReg(hkeyPrinter, NameW, ptr, left, &size)) { - if(space && size <= left) { - pi4->pPrinterName = (LPWSTR)ptr; - ptr += size; - left -= size; - } else + if(WINSPOOL_GetStringFromReg(hkeyPrinter, NameW, buf, left, &size)) { + if(space && size <= left) + pi4->pPrinterName = (LPWSTR)buf; + else Could you indent this better? -Alex

1 0

Scan-build report uploaded
by André Hentschel 29 Nov '15

29 Nov '15

Hi, in case someone is interested, i've uploaded a scan-build here: http://dawncrow.de/scan-build-2015-11-28-143038-14935-1/index.html Wine source is 1.8-rc2

1 0

Re: [PATCH 1/7] msctf: Add a partial implementation of ITfThreadMgrEx_ActivateEx().
by Marvin 27 Nov '15

27 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18605 Your paranoid android. === w1064 (32 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

2 1

Re: winedbg: suppress bogus clone() frames in backtrace
by Alexandre Julliard 27 Nov '15

27 Nov '15

Daniel Santos <daniel.santos(a)pobox.com> writes: > Signed-off-by: Daniel Santos <daniel.santos(a)pobox.com> > --- > programs/winedbg/stack.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) This is only hiding the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winedbg: suppress bogus clone() frames in backtrace
by Ralf Habacker 27 Nov '15

27 Nov '15

Am 26.11.2015 um 09:25 schrieb Daniel Santos: > Signed-off-by: Daniel Santos <daniel.santos(a)pobox.com> > --- > programs/winedbg/stack.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) > > diff --git a/programs/winedbg/stack.c b/programs/winedbg/stack.c > index f49480a..8ef2dbc 100644 > --- a/programs/winedbg/stack.c > +++ b/programs/winedbg/stack.c > @@ -307,6 +307,11 @@ static void stack_print_addr_and_args(int nf) > im.ModuleName, (DWORD_PTR)(ihsf.InstructionOffset - im.BaseOfImage)); > } > > +static int addr_is_nonzero(const ADDRESS64 *addr) > +{ > + return addr->Offset && (addr->Mode != AddrModeFlat || addr->Segment); > +} > + > /****************************************************************** > * backtrace > * > @@ -322,12 +327,24 @@ static void backtrace(void) > dbg_curr_thread->curr_frame < dbg_curr_thread->num_frames; > dbg_curr_thread->curr_frame++) > { > - dbg_printf("%s%d ", > - (cf == dbg_curr_thread->curr_frame ? "=>" : " "), > - dbg_curr_thread->curr_frame); > - stack_print_addr_and_args(dbg_curr_thread->curr_frame); > + const unsigned nf = dbg_curr_thread->curr_frame; > + const ADDRESS64 *addr = &dbg_curr_thread->frames[nf].addr_frame; > + > + /* suppress bogus clone() frames from repeating */ Hi, any idea if the mentioned bug have the same reason https://bugs.winehq.org/show_bug.cgi?id=39606 Regards Ralf

1 0

Re: Fix warning: logical not is only applied to the left hand side of this comparison
by Bruno Jesus 27 Nov '15

27 Nov '15

On Fri, Nov 27, 2015 at 4:49 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Thanks Bruno for the critics. > Now I rebase the patches to recent wine-1.8-rc1-89-g4a315cd > and split them to separate commits. > Now only two files because third is already corrected. You are almost there, but each patch must have it's own email with the correct subject.

1 0

Re: po: Update Simplified Chinese translation.
by Jactry Zeng 27 Nov '15

27 Nov '15

Hi Boyuan, Thanks for your contribution! This patch looks fine to me, but I'm not sure should we add translation which is fuzzy: > #: cryptui.rc:286 > +#, fuzzy > > #: cryptui.rc:376 > +#, fuzzy -- Regards, Jactry Zeng

2 2

Re: [PATCH] Assorted typos fixes
by Marvin 26 Nov '15

26 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18579 Your paranoid android. === w1064 (32 bit misc) === misc.c:756: Test failed: [52] wrong mime: L"image/x-icon"

1 0

What is the meaning of the 200 __clone lines in backtraces?
by Bruno Jesus 26 Nov '15

26 Nov '15

Hi all, this is something I have been curious for a long time. When an application crashes it is very common to see that the backtraces at some point start showing: 42 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) 43 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) 44 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) 45 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) Up to 200. Is this a bug or it is just not possible to identify when the backtrace ends and 200 is a hard limit or what else could it be? Best wishes, Bruno

3 2

Re: Fix warning: logical not is only applied to the left hand side of this comparison
by Bruno Jesus 26 Nov '15

26 Nov '15

On Thu, Nov 26, 2015 at 3:11 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > It may cause a mistake if will work not as intended. > > Signed-off-by: Sergey Isakov <isakov-sl(a)bk.ru> Hi, Sergey. Please split your changes to 1 patch per DLL and adjust the subject line according to the guidelines (http://wiki.winehq.org/SubmittingPatches) for example: msi/tests: Simplify the logic in a if condition tapi32: Simplify the logic in a if condition winex11.drv: Simplify the logic in a if condition

3 2

Request for help from Conservancy - be nice if we could respond
by Jeremy White 26 Nov '15

26 Nov '15

Hey Folks, The Software Freedom Conservancy is making a strong push to move away from dependence on large corporate donors to be sustained by more individual donations. They are asking individual projects to do a bit of advertising for them. The Conservancy has been nothing but good for us and to us; if we can help spread this word, I think that would be a good. So please share their plea, which is here: http://sfconservancy.org/supporter/ If someone found a good way to insert that into the web site as well, that might be a nice thing as well. Cheers, Jeremy -------- Forwarded Message -------- Subject: Conservancy fundraiser launching on Monday Date: Sun, 22 Nov 2015 00:46:16 -0500 From: Karen Sandler <karen(a)sfconservancy.org> Reply-To: karen(a)sfconservancy.org To: project-reps(a)sfconservancy.org Hi project reps! I wanted to give you all a heads up that Conservancy is launching a big fundraiser on Monday. As many of you know, it's been difficult to find financial stability for Conservancy... the 10% that you all contribute is very much appreciated but doesn't cover even one staffer plus basic overhead and the services we provide are greater than our peer fiscal sponsorship organizations. We need additional support to be able to survive, and while we've relied on corporate donations to do that (and will continue to seek that support) it's too capricious to serve as our primary funding source. We've concluded that we need a base of individual supporters we can rely on annually in order to close that gap. We launched our Supporter program last December but without an urgent message behind it we've been unable to get the number of donors that we need. We have structured the campaign with two levels - a lower level that will sustain the organization for a 'bare minimum' service plan to you, our member projects, and a separate, higher level to continue doing license enforcement and other more complex legal work in service to our projects. While our campaign focuses on GPL enforcement, we know many of you are not invested in copyleft at all. Not meeting this goal means we'll scale back much of the licensing, trademark and patent-related services we provide. The message we have for the campaign frames the problem as urgent, but the urgency relates to the next fiscal year (since that's how we plan our budget). Given the commitments we've lined up we have about a year to reassess if the fundraiser fails, and we'll have time to work with you to figure out how we transition to the next phase, whether it's reducing our services or moving to a volunteer model relying a lot more on all of you. We hope you will help us to meet our goal. Our effective number, given the small base we already have signed up as supporters, will be around 500 new sign ups. If each project can get just 15-20 people to sign up for just $10 per month, we'll meet the bottom goal easily. Conservancy still gets a lot done with very little, so our urgent needs really are attainable if you all help us get there. Please promote the campaign when it launches, blog and microblog about your positive experiences with Conservancy and encourage your contributors and users to sign up. Thanks so much for all of your hard work, and I hope we can continue with uninterrupted support for your excellent projects which inspire us every day! karen Karen M. Sandler Executive Director, Software Freedom Conservancy __________ Become a Supporter today! http://sfconservancy.org/supporter/

3 2

Re: Re: ieframe: Don't release the advise sink in IOleObject::SetClientSite.
by Marvin 26 Nov '15

26 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18568 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ieframe: Don't release the advise sink in IOleObject::SetClientSite.
by Jacek Caban 26 Nov '15

26 Nov '15

Hi Hans, On 11/26/15 10:53, Hans Leidekker wrote: > diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c > index c8dfa5b..f62a943 100644 > --- a/dlls/ieframe/tests/webbrowser.c > +++ b/dlls/ieframe/tests/webbrowser.c > @@ -148,6 +148,7 @@ DEFINE_EXPECT(ControlSite_TranslateAccelerator); > DEFINE_EXPECT(OnFocus_TRUE); > DEFINE_EXPECT(OnFocus_FALSE); > DEFINE_EXPECT(GetExternal); > +DEFINE_EXPECT(AdviseSink_Release); > > static const WCHAR wszItem[] = {'i','t','e','m',0}; > > @@ -3955,6 +3956,7 @@ static ULONG WINAPI sink_AddRef(IAdviseSink *iface) > > static ULONG WINAPI sink_Release(IAdviseSink *iface) > { > + CHECK_EXPECT2(AdviseSink_Release); > return 1; > } IMO checking GetAdvise result after SetClientSite() call would be cleaner than checking Release calls. > @@ -4003,6 +4005,7 @@ static void test_SetAdvise(void) > IWebBrowser2 *browser; > IViewObject2 *view; > IAdviseSink *sink; > + IOleObject *oleobj; > DWORD aspects, flags; > > if (!(browser = create_webbrowser())) return; > @@ -4031,9 +4034,22 @@ static void test_SetAdvise(void) > ok(!flags, "got %08x\n", aspects); > ok(sink == &test_sink, "got %p\n", sink); > > + hr = IWebBrowser2_QueryInterface(browser, &IID_IOleObject, (void **)&oleobj); > + ok(hr == S_OK, "got %08x\n", hr); > + > + SET_EXPECT(GetContainer); > + SET_EXPECT(Site_GetWindow); > + SET_EXPECT(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); > + SET_EXPECT(Invoke_AMBIENT_SILENT); > + hr = IOleObject_SetClientSite(oleobj, &ClientSite); > + ok(hr == S_OK, "got %08x\n", hr); You can't do it that way. All SET_EXPECT()s need CHECK_CALLED() or alike. Otherwise you leave tests in an inconsistent state. > + > + SET_EXPECT(AdviseSink_Release); > hr = IViewObject2_SetAdvise(view, 0, 0, NULL); > ok(hr == S_OK, "got %08x\n", hr); > + CHECK_CALLED(AdviseSink_Release); It would be also interesting to see what happens in SetClientSite(NULL) call. Thanks, Jacek

1 0

Re: [PATCH] wininet/test: Add tests on host value for InternetConnectW (try 3)
by Marvin 26 Nov '15

26 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18567 Your paranoid android. === w1064 (32 bit http) === http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1773: Test failed: Expected 2, got 4 http.c:1774: Test failed: Expected CRLF, got ' http.c:2408: Test failed: count was wrong http.c:2409: Test failed: http data wrong, got: Garbage: Header http.c:3072: Test failed: HttpAddRequestHeaders succeeded http.c:3073: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [PATCH] wininet/test: Add tests on host value for InternetConnectW
by Marvin 26 Nov '15

26 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18566 Your paranoid android. === w1064 (32 bit http) === http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1773: Test failed: Expected 2, got 4 http.c:1774: Test failed: Expected CRLF, got ' http.c:2408: Test failed: count was wrong http.c:2409: Test failed: http data wrong, got: Garbage: Header http.c:3072: Test failed: HttpAddRequestHeaders succeeded http.c:3073: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: ws2_32: Update WS_get_local_ips to not return a bogus IP address.
by Bruno Jesus 26 Nov '15

26 Nov '15

On Sat, Nov 21, 2015 at 2:12 PM, Jamie Taylor <Jamie.Taylor(a)pobox.com> wrote: > There were many shortcomings in the previous behavior, but most > importantly it resulted in the first IP address in the > returned hostent structure being the magic loopback address in > the default network configuration on Mac OS X. The new behavior > returns all IP addresses from non-loopback network adapters, and > ensures that the addresses from the adapter for the default route > are at the front of the list. Testing confirmed this behavior > on Mac OS X. > > This will most likely fix https://bugs.winehq.org/show_bug.cgi?id=37271 > and https://bugs.winehq.org/show_bug.cgi?id=22819 > but I do not have the programs under test in those bugs, so I can't > verify. > > I also do not have convenient access to a linux machine with an > equivalent network configuration (i.e., at least two interfaces > with default routes) to test. Hi, Jamie. Thanks for your effort, as you may have observed in the patches list your patch is marked as deferred because we are in code freeze for Wine 1.8 release. This code was touched a few times in attempts to fix this same issue you are addressing so maybe this time it will be the definitive fix =) I have a similar (not so robust) old patch that I used on FreeBSD (and also works in Linux), could you try it in OSX just out of curiosity, please? It has printf to help showing the results so a make test in the ws2_32/tests folder is enough to check if it works. About your patch I just would like to say that you should follow the surrounding code style, so the { goes in the next line. I tested it on Linux and it works for Heroes of Might & Magic 2 (https://bugs.winehq.org/show_bug.cgi?id=22819). Best wishes, Bruno

3 10

Re: [2/2] oleaut32: Implement a better stub for IPicture::SaveAsFile.
by Alexandre Julliard 25 Nov '15

25 Nov '15

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Based on OLEPictureImpl_Save implementation. Surely you don't need to duplicate all of it. -- Alexandre Julliard julliard(a)winehq.org

3 7

Re: [PATCH 1/5] d3d10core/tests: Multisampled render targets are zeroed on creation.
by Henri Verbeet 25 Nov '15

25 Nov '15

On 24 November 2015 at 22:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static void test_multisample_init(void) > +{ > + D3D10_TEXTURE2D_DESC desc; > + ID3D10Texture2D *single, *multi; > + ID3D10Device *device; > + ULONG refcount; > + DWORD color; > + HRESULT hr; > + unsigned int x, y; > + struct texture_readback rb; > + BOOL all_zero = TRUE; > + > + if (!(device = create_device())) > + { > + skip("Failed to create device, skipping tests.\n"); > + return; > + } > + > + desc.Width = 640; > + desc.Height = 480; > + desc.MipLevels = 1; > + desc.ArraySize = 1; > + desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; > + desc.SampleDesc.Count = 2; > + desc.SampleDesc.Quality = 0; > + desc.Usage = D3D10_USAGE_DEFAULT; > + desc.BindFlags = D3D10_BIND_RENDER_TARGET; > + desc.CPUAccessFlags = 0; > + desc.MiscFlags = 0; > + hr = ID3D10Device_CreateTexture2D(device, &desc, NULL, &multi); > + ok(SUCCEEDED(hr), "Failed to create texture, hr %#x.\n", hr); > + You should check if the sample count is supported with CheckMultisampleQualityLevels(). > + /* CopyResource from a multisampled to a sysmem texture works, but leaks memory on Windows > + * (Nvidia, not checked on AMD). Use a single sampled buffer to work around. */ Direct3D 10+ doesn't have sysmem textures. You can make resources accessible to the CPU, but you can't prevent the GPU from reading from them. How did you verify that the CopyResource() works? > + desc.SampleDesc.Count = 1; > + hr = ID3D10Device_CreateTexture2D(device, &desc, NULL, &single); > + ok(SUCCEEDED(hr), "Failed to create texture, hr %#x.\n", hr); Note that you're creating a texture here, contrary to what the comment above claims. > + ID3D10Device_CopyResource(device, (ID3D10Resource *)single, (ID3D10Resource *)multi); At least according to the documentation, CopyResource() doesn't work at all with multi-sampled resources, and this should use ResolveSubresource() instead. It's possible the documentation is wrong about that, but that would need a more convincing test. Right now it looks like the test only tests that the initial contents of "single" are zeroes.

2 1

Re: [PATCH 4/5] dxgi/tests: Test DXGI_SWAP_EFFECT_FLIP_DISCARD.
by Henri Verbeet 25 Nov '15

25 Nov '15

On 24 November 2015 at 22:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - {TRUE, 0, 4 /* undefined */, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, > - {TRUE, 1, 4 /* undefined */, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, > - {TRUE, 2, 4 /* undefined */, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, > + {TRUE, 0, DXGI_SWAP_EFFECT_FLIP_DISCARD, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, > + {TRUE, 1, DXGI_SWAP_EFFECT_FLIP_DISCARD, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, > + {TRUE, 2, DXGI_SWAP_EFFECT_FLIP_DISCARD, S_OK, DXGI_ERROR_INVALID_CALL, 0}, > + {TRUE, 0, 5 /* undefined */, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, > + {TRUE, 1, 5 /* undefined */, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, > + {TRUE, 2, 5 /* undefined */, DXGI_ERROR_INVALID_CALL, DXGI_ERROR_INVALID_CALL, 0}, I don't mind too much, but I'm not a real fan of testing undefined values like that, at least until applications start depending on an error value being returned. It's not that much of a stretch that "5", like "4", will become a valid value with a defined meaning in a future dxgi version.

1 0

Re: [PATCH 2/6 v2] msxml3: Update xmlNode reference count when nodes are merged in node_insert_before
by Nikolay Sivov 25 Nov '15

25 Nov '15

Let's wait until 1.8 with the rest.

1 0

Re: ws2_32/tests: Check if the first IP is a default route in gethostbyname
by Marvin 25 Nov '15

25 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18529 Your paranoid android. === w2008s64 (32 bit sock) === sock.c:4482: Test failed: failed to find interface index 12 sock.c:4485: Test failed: failed to find the first IP from gethostbyname! === w2008s64 (64 bit sock) === sock.c:4482: Test failed: failed to find interface index 12 sock.c:4485: Test failed: failed to find the first IP from gethostbyname!

1 0

Re: shlwapi: Don't bother trying to duplicate nil handle
by Bruno Jesus 25 Nov '15

25 Nov '15

On Wed, Nov 25, 2015 at 3:17 PM, Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> wrote: > Fix one of the error leak source that prevents the installer to succeed > (bug 36838). > > The original code did try to duplicate the handle even though it is > null, and that causes last error to be set to ERROR_INVALID_HANDLE. The > game installer chokes at some point when the last error is anything but > zero and fails to complete the installation. Returning a null handle > value is sufficient to indicate that error condition. The SHMapHandle is > not supposed to set last error on failure. A test wouldn't hurt, like the attached patch. Maybe to make this more convincing the test should be sent separate to prove current wine behavior is wrong.

1 0

Re: Shell32: Check if is_wow64 before calling wow64 functions
by Nikolay Sivov 25 Nov '15

25 Nov '15

Hi, Olivier. > + pIsWow64Process = (void*)GetProcAddress(GetModuleHandleA("kernel32"), "IsWow64Process"); There's no reason to do that, just use it in a normal static way.

1 0

Good way to use custom .dll.so ?
by lemonsqueeze 25 Nov '15

25 Nov '15

Hi, Working on a regression bug with a specific app atm https://bugs.winehq.org/show_bug.cgi?id=38137 I've traced the problem to ieframe.dll.so and came up with a version that fixes it : overwriting /usr/lib/i386-linux-gnu/wine/ieframe.dll.so with it problem is gone. Now I have no idea what side effects this could have for other apps, so I'd rather leave the system lib alone and override it just for this app. How do I do this ?? I've come across http://wine-wiki.org/index.php/WINEDLLPATH which seems to be what I'm looking for but it's not working. (setting WINEDLLPATH new dll.so is not used) Bottom of page also mentions that : > For DLLs at least, you should be able to rename the .dll.so to a > .dll and stick it in the application's directory. That doesn't work either. There's got to be a clean way of doing this, am I missing something here ? In case that matters, working with wine 1.6 atm (Looking for Ubuntu Trusty fix) Cheers

2 3

Re: Shell32: Check if is_wow64 before calling wow64 functions
by Dmitry Timoshkov 25 Nov '15

25 Nov '15

"Olivier F. R. Dierick" <o.dierick(a)piezo-forte.be> wrote: > + static BOOL (WINAPI *pIsWow64Process)(HANDLE, PBOOL); There is no need to make it static; -- Dmitry.

1 0

Good way to use custom .dll.so ?
by river 25 Nov '15

25 Nov '15

Hi, Working on a regression bug with a specific app atm https://bugs.winehq.org/show_bug.cgi?id=38137 I've traced the problem to ieframe.dll.so and came up with a version that fixes it : overwriting /usr/lib/i386-linux-gnu/wine/ieframe.dll.so with it problem is gone. Now I have no idea what side effects this could have for other apps, so I'd rather leave the system lib alone and override it just for this app. How do I do this ?? I've come across http://wine-wiki.org/index.php/WINEDLLPATH which seems to be what I'm looking for but it's not working. (setting WINEDLLPATH new dll.so is not used). Bottom of page also mentions that : > For DLLs at least, you should be able to rename the .dll.so to a > .dll and stick it in the application's directory. That doesn't work either. Sure there's got to be a clean way of doing this, am I missing something here ? In case that matters, working with wine 1.6 atm (Looking for Ubuntu Trusty fix) Cheers

1 0

Re: ws2_32/tests: Add more tests related to WSACleanup
by Marvin 25 Nov '15

25 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18520 Your paranoid android. === w7pro64 (64 bit sock) === sock.c:7622: Test failed: bytesReturned isn't supposed to be 1 sock.c:7668: Test failed: Waiting for timeout failed with 0 + errno 997

1 0

A new attempt on WSACleanup
by Bruno Jesus 25 Nov '15

25 Nov '15

Hi all, a possible way to solve the WSACleanup in the DLL side is to retrieve all existing sockets from the current process in a server call and then closing then inside winsock. Is it possible to make a wine server call that returns variable length data? If yes, can anyone show an example? Such function would also allow for a proper implementation of SetTcpEntry (iphlpapi) which would make firewalls that like to close TCP connections happy.

4 8

Re: msacm32/tests: Add some acmStreamPrepareHeader and acmStreamConvert tests (try 2)
by Andrew Eikum 25 Nov '15

25 Nov '15

On Tue, Nov 24, 2015 at 05:08:00PM +0800, Bruno Jesus wrote: > + hdr.cbSrcLengthUsed = 12345; > + hdr.cbDstLengthUsed = 12345; The rest looks OK, but I don't understand why these are set. Does the application really set them to this value after Prepare and before Convert? The tests seem to behave the same if I leave them at 0. Andrew

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel