- wine-devel - winehq.org

Re: [PATCH] dxgi: Implement dxgi_output_GetDesc().
by Marvin 24 Nov '15

24 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18498 Your paranoid android. === w1064 (32 bit device) === device.c:1147: Test failed: Got unexpected hr 0, test 16. device.c:1147: Test failed: Got unexpected hr 0x87a0001, test 39.

1 0

Re: shell32: Improved IDataObject::QueryGetData implementation
by Marvin 24 Nov '15

24 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18490 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1578: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

2 1

Re: [PATCH] add test on host value of InternetConnectW
by Marvin 24 Nov '15

24 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18485 Your paranoid android. === w2003std (32 bit http) === http.c:5896: Test failed: HttpQueryInfoA failed 12019 http.c:5897: Test failed: header missing === w1064 (32 bit http) === http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1773: Test failed: Expected 2, got 4 http.c:1774: Test failed: Expected CRLF, got ' http.c:2408: Test failed: count was wrong http.c:2409: Test failed: http data wrong, got: Garbage: Header http.c:3072: Test failed: HttpAddRequestHeaders succeeded http.c:3073: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [PATCH] add test on host value of InternetConnectW
by Nikolay Sivov 24 Nov '15

24 Nov '15

On 24.11.2015 16:02, Hao Peng wrote: > Add a test on giving host value of InternetConnectionW. > > Some App fill host param with port number when calling InternetConnectionW. it will still operate successfull on system brove windows 2000. > > I tested to connect to [www.winehq.org], but I got GetLastError with 2 on WinXP and Win2003, other systems were fine. > (See https://testbot.winehq.org/JobDetails.pl?Key=18484) > All fine when I tested to connecting to [www.bing.com]. > (https://testbot.winehq.org/JobDetails.pl?Key=18482) > And I didn't get what happened. > > I plan to send a patch to fix this later. > > Any comments are welcome. > > Signed-off-by: Hao Peng <penghao(a)linuxdeepin.com> > --- > dlls/wininet/tests/http.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > + connect = InternetConnectA(session, "www.bing.com:21", INTERNET_DEFAULT_HTTPS_PORT, NULL, NULL, > + INTERNET_SERVICE_HTTP, 0, 0); > + ok(connect != NULL, "InternetConnect failed\n"); I think we prefer winehq.org as test url domain. > + SetLastError(0xdeadbeef); > + ret = HttpSendRequestA(request, NULL, 0, NULL, 0); > + error = GetLastError(); > + ok(ret || broken(!ret /* win2000 */), "HttpSendRequest failed\n"); > + ok(error == 0 || broken(error == ERROR_INTERNET_NAME_NOT_RESOLVED /* win2000 */), "got %u\n", error); Windows 2000 is not in a base set of tested versions anymore, you can probably drop special handling for it. > I plan to send a patch to fix this later. What this patch will fix? I don't see any todos or other ways to skip in your test patch.

1 0

Re: [PATCH 1/6 v2] msxml3/tests: Run IXMLDOMNode::get_text whitespace tests on other msxml versions
by Nikolay Sivov 24 Nov '15

24 Nov '15

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

1 0

Re: [2/4] comctl32: Accept touchscreen-related messages in monthcal test.
by Nikolay Sivov 24 Nov '15

24 Nov '15

Maybe it's better to filter them? If they are sent internally by default procedure it's not an appropriate place to test for them, and as long as we only want to fix comctl32 tests I think it's easier to filter. And please add a comment directly in test code about system configuration it applies to.

1 0

Re: [1/4] comctl32: Accept touchscreen-related messages in button test.
by Nikolay Sivov 24 Nov '15

24 Nov '15

BM_GETSTATE doesn't use message parameters, so I don't think it makes sense to test them. Otherwise it's fine, if it fixes real failures.

1 0

Re: [PATCH 1/2] d3d11: Make blend_factor optional in d3d11_immediate_context_OMSetBlendState(). (try 2)
by Henri Verbeet 24 Nov '15

24 Nov '15

On 23 November 2015 at 11:14, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > static void STDMETHODCALLTYPE d3d11_immediate_context_OMSetBlendState(ID3D11DeviceContext *iface, > - ID3D11BlendState *blend_state, const FLOAT blend_factor[4], UINT sample_mask) > + ID3D11BlendState *blend_state, const FLOAT arg_blend_factor[4], UINT sample_mask) > { > struct d3d_device *device = device_from_immediate_ID3D11DeviceContext(iface); > + static const FLOAT default_blend_factor[4] = {1.0f, 1.0f, 1.0f, 1.0f}; Please just use "float". (Yeah, there are a couple of other places in d3d11 that use "FLOAT", but it's silly.) > + const FLOAT *blend_factor; ... > + blend_factor = arg_blend_factor ? arg_blend_factor : default_blend_factor; You don't need this. You can just do: if (!blend_factor) blend_factor = default_blend_factor;

1 0

Re: d3d8: Accept CURSOR_SUPPRESSED as cursor flags.
by Henri Verbeet 24 Nov '15

24 Nov '15

Please send patches inline. (I.e., use git send-email.) On 23 November 2015 at 22:36, Vincent Povirk <madewokherd(a)gmail.com> wrote: > > Subject: [PATCH] d3d8: Accept CURSOR_SUPPRESSED as cursor flags. This is not wrong, but please use "d3d8/tests: " as prefix if you're not touching the dll itself. > - ok(info.flags & CURSOR_SHOWING, "The gdi cursor is hidden (%08x)\n", info.flags); > + ok((info.flags & CURSOR_SHOWING) != 0 || info.flags == CURSOR_SUPPRESSED, > + "The gdi cursor is hidden (%08x)\n", info.flags); Why introduce the redundant comparison with 0? Anyway, the test should probably be something like "ok(info.flags & (CURSOR_SHOWING | CURSOR_SUPPRESSED), ...);" or perhaps just "ok(info.flags, ...);". The test is really just about showing that the cursor isn't hidden, and not so much about the exact combination of flags. Line continuations should use double indentation. There's an equivalent test for d3d9 in dlls/d3d9/tests/device.c, I'd expect that to have the same issue.

1 0

Re: [PATCH] user32: Allow WM_CAPTURECHANGE indicating SetCapture() parameter.
by Marvin 24 Nov '15

24 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18463 Your paranoid android. === w1064 (32 bit msg) === msg.c:6094: Test failed: Update region shouldn't be empty msg.c:6328: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6330: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6100: Test failed: Regions are different msg.c:6100: Test failed: Regions are different msg.c:6100: Test failed: Regions are different

1 0

gcc doesn't love us anymore
by Daniel Santos 24 Nov '15

24 Nov '15

I was tuning some of my code looking by at the disassembly and I noticed a disturbing thing -- my NtReleaseSemaphore had a really ugly epilogue and prologue! 000000007bc9d150 <NtReleaseSemaphore> push %rdi 000000007bc9d151 <NtReleaseSemaphore+0x1> push %rsi 000000007bc9d152 <NtReleaseSemaphore+0x2> mov %rcx,%r9 000000007bc9d155 <NtReleaseSemaphore+0x5> push %rbx 000000007bc9d156 <NtReleaseSemaphore+0x6> mov $0x8,%ecx 000000007bc9d15b <NtReleaseSemaphore+0xb> mov %r8,%rbx 000000007bc9d15e <NtReleaseSemaphore+0xe> sub $0x150,%rsp 000000007bc9d165 <NtReleaseSemaphore+0x15> mov %fs:0x28,%rax 000000007bc9d16e <NtReleaseSemaphore+0x1e> mov %rax,0xa8(%rsp) 000000007bc9d176 <NtReleaseSemaphore+0x26> xor %eax,%eax 000000007bc9d178 <NtReleaseSemaphore+0x28> mov %rsp,%rdi 000000007bc9d17b <NtReleaseSemaphore+0x2b> movl $0x0,0x40(%rsp) 000000007bc9d183 <NtReleaseSemaphore+0x33> movaps %xmm6,0xb0(%rsp) 000000007bc9d18b <NtReleaseSemaphore+0x3b> movaps %xmm7,0xc0(%rsp) 000000007bc9d193 <NtReleaseSemaphore+0x43> movaps %xmm8,0xd0(%rsp) 000000007bc9d19c <NtReleaseSemaphore+0x4c> movaps %xmm9,0xe0(%rsp) 000000007bc9d1a5 <NtReleaseSemaphore+0x55> movaps %xmm10,0xf0(%rsp) 000000007bc9d1ae <NtReleaseSemaphore+0x5e> movaps %xmm11,0x100(%rsp) 000000007bc9d1b7 <NtReleaseSemaphore+0x67> movaps %xmm12,0x110(%rsp) 000000007bc9d1c0 <NtReleaseSemaphore+0x70> movaps %xmm13,0x120(%rsp) 000000007bc9d1c9 <NtReleaseSemaphore+0x79> movaps %xmm14,0x130(%rsp) 000000007bc9d1d2 <NtReleaseSemaphore+0x82> movaps %xmm15,0x140(%rsp) (55 bytes of actual work) 000000007bc9d227 <NtReleaseSemaphore+0xd7> movaps 0xb0(%rsp),%xmm6 000000007bc9d22f <NtReleaseSemaphore+0xdf> movaps 0xc0(%rsp),%xmm7 000000007bc9d237 <NtReleaseSemaphore+0xe7> movaps 0xd0(%rsp),%xmm8 000000007bc9d240 <NtReleaseSemaphore+0xf0> movaps 0xe0(%rsp),%xmm9 000000007bc9d249 <NtReleaseSemaphore+0xf9> movaps 0xf0(%rsp),%xmm10 000000007bc9d252 <NtReleaseSemaphore+0x102> movaps 0x100(%rsp),%xmm11 000000007bc9d25b <NtReleaseSemaphore+0x10b> movaps 0x110(%rsp),%xmm12 000000007bc9d264 <NtReleaseSemaphore+0x114> movaps 0x120(%rsp),%xmm13 000000007bc9d26d <NtReleaseSemaphore+0x11d> movaps 0x130(%rsp),%xmm14 000000007bc9d276 <NtReleaseSemaphore+0x126> movaps 0x140(%rsp),%xmm15 000000007bc9d27f <NtReleaseSemaphore+0x12f> add $0x150,%rsp 000000007bc9d286 <NtReleaseSemaphore+0x136> pop %rbx 000000007bc9d287 <NtReleaseSemaphore+0x137> pop %rsi 000000007bc9d288 <NtReleaseSemaphore+0x138> pop %rdi 000000007bc9d289 <NtReleaseSemaphore+0x139> retq So I looked at the rest of the file and all of the WINAPI functions were thus. So I looked at the rest of the build and the same thing, all WINAPI (i.e., __attribute__((ms_abi))) functions had these horribly bloated epilogues and prologues. I built ntdll again with -Dms_abi=sysv_abi and the problem went away (but of course wouldn't work). Surely this cannot be an inherent requirement of ms_abi!? I'm hoping that this is just some bug that has slipped through the cracks because not many people use ms_abi on Linux. Daniel

1 1

Re: [PATCH] user32: Allow WM_CAPTURECHANGE indicating SetCapture() parameter.
by Dmitry Timoshkov 24 Nov '15

24 Nov '15

Christopher Thielen <cthielen(a)gmail.com> wrote: > +// Not const in order to set lParam during test Using c++ comment in Wine code is forbidden. Also it should not be needed to test lparam, everything is clear enough, and I'd suggest to make the structure 'const'. Looks good to me otherwise. -- Dmitry.

2 4

Re: ole32: Print error message when IPersistStorage_Load fails (Coverity)
by Nikolay Sivov 23 Nov '15

23 Nov '15

On 23.11.2015 22:26, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > CID 1336207 > > dlls/ole32/compobj.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index 2f55076..b146376 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -3443,7 +3443,9 @@ HRESULT WINAPI CoGetInstanceFromIStorage( > > if (ps) > { > - IPersistStorage_Load(ps, storage); > + hr = IPersistStorage_Load(ps, storage); > + if (FAILED(hr)) > + ERR("failed to load storage\n"); > IPersistStorage_Release(ps); > } > > The question is what to do on this failure, that's a point of Coverity warning.

2 1

Re: msacm32/tests: Add some acmStreamPrepareHeader and acmStreamConvert tests
by Marvin 23 Nov '15

23 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18454 Your paranoid android. === wvistau64 (64 bit msacm) === msacm.c:621: Test failed: prepare failed: 0xb msacm.c:622: Test failed: header wasn't prepared: 0x0 msacm.c:628: Test failed: convert failed: 0x202 msacm.c:629: Test failed: conversion was not done: 0x0 msacm.c:630: Test failed: expected 512, got 12345 msacm.c:632: Test failed: expected 1010, got 12345 msacm.c:635: Test failed: unprepare failed: 0x202 msacm.c:636: Test failed: header wasn't unprepared: 0x0 === w2008s64 (64 bit msacm) === msacm.c:621: Test failed: prepare failed: 0xb msacm.c:622: Test failed: header wasn't prepared: 0x0 msacm.c:628: Test failed: convert failed: 0x202 msacm.c:629: Test failed: conversion was not done: 0x0 msacm.c:630: Test failed: expected 512, got 12345 msacm.c:632: Test failed: expected 1010, got 12345 msacm.c:635: Test failed: unprepare failed: 0x202 msacm.c:636: Test failed: header wasn't unprepared: 0x0 === w7pro64 (64 bit msacm) === msacm.c:621: Test failed: prepare failed: 0xb msacm.c:622: Test failed: header wasn't prepared: 0x0 msacm.c:628: Test failed: convert failed: 0x202 msacm.c:629: Test failed: conversion was not done: 0x0 msacm.c:630: Test failed: expected 512, got 12345 msacm.c:632: Test failed: expected 1010, got 12345 msacm.c:635: Test failed: unprepare failed: 0x202 msacm.c:636: Test failed: header wasn't unprepared: 0x0 === w864 (64 bit msacm) === msacm.c:621: Test failed: prepare failed: 0xb msacm.c:622: Test failed: header wasn't prepared: 0x0 msacm.c:628: Test failed: convert failed: 0x202 msacm.c:629: Test failed: conversion was not done: 0x0 msacm.c:630: Test failed: expected 512, got 12345 msacm.c:632: Test failed: expected 1010, got 12345 msacm.c:635: Test failed: unprepare failed: 0x202 msacm.c:636: Test failed: header wasn't unprepared: 0x0 === w1064 (64 bit msacm) === msacm.c:621: Test failed: prepare failed: 0xb msacm.c:622: Test failed: header wasn't prepared: 0x0 msacm.c:628: Test failed: convert failed: 0x202 msacm.c:629: Test failed: conversion was not done: 0x0 msacm.c:630: Test failed: expected 512, got 12345 msacm.c:632: Test failed: expected 1010, got 12345 msacm.c:635: Test failed: unprepare failed: 0x202 msacm.c:636: Test failed: header wasn't unprepared: 0x0

2 1

question about deferred patches
by Jamie Taylor 23 Nov '15

23 Nov '15

I have a question about the patch management system. The description of the "deferred" status is: > This means that the patch is deferred because of code freeze for an > upcoming release. You need to either resend after the release, make > the patch less intrusive, or make a convincing argument that it needs > to be included in the release. Why do patches have to be resubmitted after a release rather than just marking all deferred patches as "New" after the release? Thanks, Jamie Taylor

3 2

Re: [PATCH] user32: Allow WM_CAPTURECHANGE indicating SetCapture() parameter.
by Marvin 23 Nov '15

23 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18446 Your paranoid android. === w1064 (32 bit msg) === msg.c:6094: Test failed: Update region shouldn't be empty msg.c:6328: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6330: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6100: Test failed: Regions are different msg.c:6100: Test failed: Regions are different msg.c:6100: Test failed: Regions are different

1 0

Re: msacm32: Avoid attempts to convert data when available output is negative in acmStreamConvert
by Andrew Eikum 23 Nov '15

23 Nov '15

This doesn't seem right to me. The test succeeds even without your changes to msacm32/stream.c because cbDstLength != cbPreparedDstLength in acmStreamConvert. I tried moving cbDstLength=-4 before PrepareHeader, and both PrepareHeader and Convert succeed on my Win7 VM. Can you look further into this? Andrew On Sun, Nov 22, 2015 at 11:46:33PM +0800, Bruno Jesus wrote: > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > > The game Lost Horizon passes a negative value in cbDstLength while > calling acmStreamConvert, this means we can't do the conversion > because there is no output buffer available. Cast required since the > value is DWORD. > > Fixes https://bugs.winehq.org/show_bug.cgi?id=24723 > diff --git a/dlls/msacm32/stream.c b/dlls/msacm32/stream.c > index bdfc3cc..67c5ce9 100644 > --- a/dlls/msacm32/stream.c > +++ b/dlls/msacm32/stream.c > @@ -88,20 +88,25 @@ MMRESULT WINAPI acmStreamConvert(HACMSTREAM has, PACMSTREAMHEADER pash, > > if ((was = ACM_GetStream(has)) == NULL) { > WARN("invalid handle\n"); > - return MMSYSERR_INVALHANDLE; > + return MMSYSERR_INVALHANDLE; > } > if (!pash || pash->cbStruct < sizeof(ACMSTREAMHEADER)) { > WARN("invalid parameter\n"); > - return MMSYSERR_INVALPARAM; > + return MMSYSERR_INVALPARAM; > } > if (!(pash->fdwStatus & ACMSTREAMHEADER_STATUSF_PREPARED)) { > WARN("unprepared header\n"); > - return ACMERR_UNPREPARED; > + return ACMERR_UNPREPARED; > } > > pash->cbSrcLengthUsed = 0; > pash->cbDstLengthUsed = 0; > > + if ((LONG) pash->cbDstLength < 0) { > + WARN("invalid output length\n"); > + return MMSYSERR_INVALPARAM; > + } > + > /* Note: the ACMSTREAMHEADER and ACMDRVSTREAMHEADER structs are of same > * size. some fields are private to msacm internals, and are exposed > * in ACMSTREAMHEADER in the dwReservedDriver array > diff --git a/dlls/msacm32/tests/msacm.c b/dlls/msacm32/tests/msacm.c > index 4c9dca0..3b5a446 100644 > --- a/dlls/msacm32/tests/msacm.c > +++ b/dlls/msacm32/tests/msacm.c > @@ -527,7 +527,7 @@ static void test_prepareheader(void) > WAVEFORMATEX dst; > MMRESULT mr; > ACMSTREAMHEADER hdr; > - BYTE buf[sizeof(WAVEFORMATEX) + 32], pcm[512], input[512]; > + BYTE buf[sizeof(WAVEFORMATEX) + 32], pcm[2048], input[512]; > ADPCMCOEFSET *coef; > > src = (ADPCMWAVEFORMAT*)buf; > @@ -567,6 +567,7 @@ static void test_prepareheader(void) > mr = acmStreamOpen(&has, NULL, (WAVEFORMATEX*)src, &dst, NULL, 0, 0, 0); > ok(mr == MMSYSERR_NOERROR, "open failed: 0x%x\n", mr); > > + memset(input, 0, sizeof(input)); > memset(&hdr, 0, sizeof(hdr)); > hdr.cbStruct = sizeof(hdr); > hdr.pbSrc = input; > @@ -594,10 +595,37 @@ static void test_prepareheader(void) > ok(mr == MMSYSERR_NOERROR, "prepare failed: 0x%x\n", mr); > ok(hdr.fdwStatus == (ACMSTREAMHEADER_STATUSF_PREPARED | ACMSTREAMHEADER_STATUSF_DONE), "header wasn't prepared: 0x%x\n", hdr.fdwStatus); > > + hdr.fdwStatus &= ~ACMSTREAMHEADER_STATUSF_DONE; > + mr = acmStreamConvert(has, &hdr, ACM_STREAMCONVERTF_BLOCKALIGN); > + ok(mr == MMSYSERR_NOERROR, "convert failed: 0x%x\n", mr); > + ok(hdr.fdwStatus & ACMSTREAMHEADER_STATUSF_DONE, "conversion was not done: 0x%x\n", hdr.fdwStatus); > + > mr = acmStreamUnprepareHeader(has, &hdr, 0); > ok(mr == MMSYSERR_NOERROR, "unprepare failed: 0x%x\n", mr); > ok(hdr.fdwStatus == ACMSTREAMHEADER_STATUSF_DONE, "header wasn't unprepared: 0x%x\n", hdr.fdwStatus); > > + memset(&hdr, 0, sizeof(hdr)); > + hdr.cbStruct = sizeof(hdr); > + hdr.pbSrc = input; > + hdr.cbSrcLength = sizeof(input); > + hdr.pbDst = pcm; > + hdr.cbDstLength = sizeof(pcm); > + > + mr = acmStreamPrepareHeader(has, &hdr, 0); > + ok(mr == MMSYSERR_NOERROR, "prepare failed: 0x%x\n", mr); > + ok(hdr.fdwStatus == ACMSTREAMHEADER_STATUSF_PREPARED, "header wasn't prepared: 0x%x\n", hdr.fdwStatus); > + > + hdr.cbDstLength = -4; /* Test for Lost Horizon (bug 24723) */ > + hdr.cbDstLengthUsed = 12345; > + mr = acmStreamConvert(has, &hdr, ACM_STREAMCONVERTF_BLOCKALIGN); > + ok(mr == MMSYSERR_INVALPARAM, "expected 11, got %d!\n", mr); > + ok(hdr.cbDstLengthUsed == 0, "expected 0, got %d\n", hdr.cbDstLengthUsed); > + > + hdr.cbDstLength = sizeof(pcm); > + mr = acmStreamUnprepareHeader(has, &hdr, 0); > + ok(mr == MMSYSERR_NOERROR, "unprepare failed: 0x%x\n", mr); > + ok(hdr.fdwStatus == 0, "header wasn't unprepared: 0x%x\n", hdr.fdwStatus); > + > mr = acmStreamClose(has, 0); > ok(mr == MMSYSERR_NOERROR, "close failed: 0x%x\n", mr); > }

2 1

Re: msvcp90: basic_string_wchar_dtor should return NULL on i386.
by Sebastian Lackner 23 Nov '15

23 Nov '15

On 23.11.2015 13:33, Piotr Caban wrote: > Probably the commit message would be more readable if it says: > msvcp90: basic_string_wchar_dtor should set EAX to 0 on i386. EAX is used to store the return value, so both commit messages are basically equivalent. If your suggested subject is preferred, I have no problem when its changed while applying the patch or to resend later. > > According to my knowledge the application depends on that. > > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > > > >

2 1

Re: [PATCH 2/2] comctl32: Item with negative cChildren acts as if it actually had children
by Alexandre Julliard 23 Nov '15

23 Nov '15

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/comctl32/tests/treeview.c | 22 +++++++++++++++++++++- > dlls/comctl32/treeview.c | 5 +++-- > 2 files changed, 24 insertions(+), 3 deletions(-) What application is this fixing? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msi: Use the intended attributes when overwriting the target file in cabinet_copy_file.
by Hans Leidekker 23 Nov '15

23 Nov '15

On Mon, 2015-11-23 at 14:13 +0100, Thomas Faber wrote: > The current code uses the old file's attributes, which means it would > make the file read-only again. This would e.g. prevent the deletion of > the file at the end of test_readonlyfile_cab (and should probably even > make this CreateFileW call fail since it specifies GENERIC_WRITE). > > The reason this currently works in Wine is that CreateFile keeps the > existing file attributes in this case (see the todo_wine in > test_NtCreateFile). > > The patch fixes msi to use the correct attributes as returned by the > callback. Looks good but if it doesn't fix a real installer I think we should hold off until the freeze is over.

1 0

Re: [PATCH 01/3] msvcp110: Add tr2_sys__Read_dir implementation.(try 3)
by Piotr Caban 23 Nov '15

23 Nov '15

Hi, the patches looks good for me. Since they are not fixing any regression/don't make application running I think you will need to send them after code freeze. Thanks, Piotr

1 0

Re: [PATCH] wldap32: Properly implement ldap_encode_sort_control[A,W] (Coverity)
by Hans Leidekker 23 Nov '15

23 Nov '15

On Sun, 2015-11-22 at 15:31 +0300, Nikolay Sivov wrote: > ULONG CDECL ldap_encode_sort_controlA( WLDAP32_LDAP *ld, PLDAPSortKeyA *sortkeys, > - PLDAPControlA control, BOOLEAN critical ) > + PLDAPControlA ret, BOOLEAN critical ) > { > - return ldap_create_sort_controlA( ld, sortkeys, critical, &control ); > + LDAPControlA *control; > + ULONG result; > + > + if ((result = ldap_create_sort_controlA( ld, sortkeys, critical, &control )) == WLDAP32_LDAP_SUCCESS) > + { > + ret->ldctl_oid = strdupU(control->ldctl_oid); > + ret->ldctl_value.bv_len = control->ldctl_value.bv_len; > + ret->ldctl_value.bv_val = strdupU(control->ldctl_value.bv_val); bv_val is not a string. Otherwise the patch looks good.

1 0

Re: [PATCH] user32: Allow WM_CAPTURECHANGE indicating SetCapture() parameter.
by Marvin 23 Nov '15

23 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18427 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] include/ddk: Fix memory layout of IRP and IO_STACK_LOCATION in wine64.
by Nikolay Sivov 22 Nov '15

22 Nov '15

On 22.11.2015 23:11, Rafał Harabień wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=39648 > > Signed-off-by: Rafał Harabień <rafalh1992(a)o2.pl> > --- > include/ddk/wdm.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/ddk/wdm.h b/include/ddk/wdm.h > index 0c51527..63baed2 100644 > --- a/include/ddk/wdm.h > +++ b/include/ddk/wdm.h > @@ -400,7 +400,6 @@ typedef struct _KAPC { > BOOLEAN Inserted; > } KAPC, *PKAPC, *RESTRICTED_POINTER PRKAPC; > > -#include <pshpack1.h> > typedef struct _IRP { > CSHORT Type; > USHORT Size; > @@ -456,7 +455,6 @@ typedef struct _IRP { > } Tail; > } IRP; > typedef struct _IRP *PIRP; > -#include <poppack.h> This one looks fine. > > typedef VOID (WINAPI *PINTERFACE_REFERENCE)( > PVOID Context); > @@ -833,7 +831,6 @@ typedef NTSTATUS (WINAPI *PIO_COMPLETION_ROUTINE)( > #define SL_INVOKE_ON_SUCCESS 0x40 > #define SL_INVOKE_ON_ERROR 0x80 > > -#include <pshpack1.h> > typedef struct _IO_STACK_LOCATION { > UCHAR MajorFunction; > UCHAR MinorFunction; > @@ -974,7 +971,6 @@ typedef struct _IO_STACK_LOCATION { > PIO_COMPLETION_ROUTINE CompletionRoutine; > PVOID Context; > } IO_STACK_LOCATION, *PIO_STACK_LOCATION; > -#include <poppack.h> This one doesn't - according to Win10 DDK, it should use pshpack4 for i386 case, or to be precise for platforms that are not AMD64, ARM or ARM64. > > /* MDL definitions */ > >

2 1

Re: Assorted spelling fixes.
by Marvin 22 Nov '15

22 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18413 Your paranoid android. === w1064 (32 bit device) === device.c:1147: Test failed: Got unexpected hr 0, test 16. device.c:1147: Test failed: Got unexpected hr 0x87a0001, test 39. === w1064 (64 bit device) === device.c:1201: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1201: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1201: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1201: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1147: Test failed: Got unexpected hr 0, test 39. device.c:1201: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1201: Test failed: Got usage 160, expected 60, test 42, buffer 15.

1 0

Re: Assorted spelling fixes.
by Marvin 22 Nov '15

22 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18410 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 716 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 726 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 735 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 739 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 745 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 746 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 747 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 748 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 761 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 762 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 763 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 764 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 783 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 784 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 785 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 786 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 787 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 788 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 789 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 790 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 791 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 792 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 793 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 794 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 795 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 796 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 797 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 798 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 799 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1389 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1390 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1391 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1392 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1393 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1394 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1395 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1396 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1398 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1401 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1402 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1403 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1404 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1405 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1406 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1407 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === w2003std (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 716 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 726 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 735 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 739 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 745 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 746 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 747 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 748 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 761 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 762 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 763 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 764 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 783 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 784 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 785 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 786 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 787 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 788 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 789 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 790 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 791 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 792 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 793 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 794 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 795 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 796 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 797 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 798 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 799 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1389 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1390 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1391 (got 'C:\Documents and Settings\Administrator\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1392 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1393 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1394 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1395 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1396 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1398 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1401 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1402 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1403 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1404 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1405 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1406 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1407 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar')

1 0

Re: [v9 05/11] ddraw: Do refcounting only through wined3d_texture_{inc, dec}ref().
by Stefan Dösinger 22 Nov '15

22 Nov '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-11-19 um 20:34 schrieb Riccardo Bortolato: > @@ -532,10 +529,9 @@ static void ddraw_surface_cleanup(struct ddraw_surface *surface) > ... > + wined3d_texture_decref(surface->wined3d_texture); > + if (surface->sub_resource_idx == 0) > wined3d_texture_decref(surface->wined3d_texture); If I follow this correctly the unconditionally released reference is the one added by ddraw_surface_init, and the one that's released if sub_resource_idx == 0 is the initial reference that the texture is returned with from wined3d_texture_create. In this case I think it would be better to release the idx == 0 reference after calling wined3d_surface_create and retrieving the ddraw parent. Please correct me if I am wrong... (This would also remove a non-obvious non-problem in the flip code if one of the involved surfaces has a non-zero index and the other one has a zero index and holds an extra reference to its wined3d texture. In practice it's a non-issue because swapchains never have mipmaps and the code swaps both the wined3d texture and the sub resource index) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWURGCAAoJEN0/YqbEcdMwXVQP/AqWEh17bjHO5KjWJ7eMdhvM xS0GCfUK4xcr9i5Xr0AHmOHzhd2NB3vkmYaqQyn6VTXzNbjoYf2uIlTlm9bkhLJi xfDYjedsx8lcwrCjPUEuwrmam7mKOMNsTq4NZ6IClGeVaQBEYgC/Q9vJ3HgwZYz+ EdW0UNbed0TJaxuaymWVK9SyOUQcMYA90vNvxJNWV/A78jxIktOEGqAEpmIRTEyi ZzS6iNVQCXc5c90X1ZFeh31g+yX+ZuHLOQ4mlL8dsu5B+dtnb9Mou2FBkcOW51u7 shHbkNGK49sgkmSLKbZaAYFO4+cMWbJpFAqMMbikBZT6+8ATHE+r72USBrc/myya nnaYlyJuVIZB022zzLxSMcNsyyxMVUZDF+//KfE/VdZ7NfIh8h0gnh/PW7y0i9H9 dYMU/l87+SlVVJCyX4BZYJr1/U3WT2GHJB0eyWHUikIF5hUL5PntbMUwNAVFEM6y B4QGSE5sfay6DQ6U+FNTfUN35A7KKn4RfFgs6M3wAIh6dXKAcivLbSaPNdRhBGoK xSR9wA2IN19mkAGdf5VqFOR33AG4VUaKy6q9+DViac7QgGB9eCS4VGBqtbof5/K4 elRJ+jzj4C+1GdQUOYpl77CaKxwRescNP7sOiRyJGxOHOOQ/oP0MhRYRG9deak+W BhwM31xUd2UpEzECH5EK =a+jA -----END PGP SIGNATURE-----

2 2

Re: [pkg-wine-party] Bug#805655: wine-development: FTBFS on hurd-i386
by Nikolay Sivov 22 Nov '15

22 Nov '15

On 21.11.2015 20:16, Michael Gilbert wrote: > On Sat, Nov 21, 2015 at 11:47 AM, Svante Signell wrote: >> Signed-off by: svante.signell(a)gmail.com >> >> Hello, >> >> Submitting this patch directly to wine-patches on request from Jens >> Ryer. >> >> BTW: There are still some parts of the code using PATH_MAX, but does >> not seem to be triggered with the debian builds. Is it of interest to >> remove also the remaining entries? > > The PATH_MAX in libs/wine/loader.c is in an #ifdef __sun block, so > it's not very relevant. There are two other instances which would > probably be nice to fix. winepulse.drv makes perfect sense, since this buffer is used with Win32 API, and pa_proplist_sets() dynamically allocates property value, so it could be of any length. The rest: - loader.c is fine I think; - mountmgr.sys/diskarb.c and dbghelp/macho_module.c are macos-only, so maybe it's okay too if PATH_MAX defined specifically for macos. Ken, could you please comment? > > Best wishes, > Mike > >

2 2

Re: [v9 01/11] ddraw: Check if surface is a mipmap sublevel or a non-positive X top level surface through caps in ddraw_surface7_GetPriority().
by Stefan Dösinger 22 Nov '15

22 Nov '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Am 2015-11-19 um 20:34 schrieb Riccardo Bortolato: > - else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed) || !surface->wined3d_texture) > + else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed) > + || (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL) > + || ((surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP) > + && !(surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP_POSITIVEX))) The patch and test looks good to me (and passes), but I don't think it's something we want to apply during the code freeze because it doesn't fix an actual bug by itself. This applies to the general series, but you're welcome to resend it with fixes, then we can pick it up after the release. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWUQ2iAAoJEN0/YqbEcdMwXK0P/jeYTfGSWQ6SFsi9+dnpepW7 UPAP3XnMG1M8wWRA81UjPWKGO/yzIUS9u9eqU6lgA4eZxtTlNbWoOK4iuXqBH9uP c9K8s+ccP9phx/DIXdGed8l20z2UmEaRdOWYw/w75g2+Du62tJ9XZNPzRsuus8BP 1OJWe93/bS7PdFI2BxnoX+JLZ6SJ1ly0VLhav1o4KdymVfg+NbyBn5nYgOOrpzab cmAuVNOlL+TCgTCMwVXihM/OThCh9OAAZSFi6NOT2SSVp+w8UUpVDlgzee3jRY6k SvAwtSiblFfyzDcDR9XrFQmpaU/9QiifLJl37yTbKHwbZ9ZcxoA4tiHXGoei9dS+ sQCwWzlQxMSiESEVbNFCjev9r8BV9haTEA4zE1k5aEN/VORPzyD9acs6q8JhsuKv +CchBOPSQ2kwK4egHTRB/5NmL8u0gAWIO37teeuZ0OMw64jYu9lmmHaRAWM5cmmV D2pRI8bxbDUwSCA9D0DchkgGXTo1jsjKMhmf4VPJamfEMNiZstaTzg9KEqs/pNDm SIerM7mv1hOumQPVRTGVlTSBcChItaq7ze5EpP0Xi9RdgrJ/OB6P+M2gn4nvuoPc dFH7Nz+NAFCc1+YSagXATEfj83jNEvTczpOxBIBjepjoPRDKUknJbnCgnfCnb0fu p6PXVd95kGGBDLpukVln =7eyD -----END PGP SIGNATURE-----

2 1

Re: [v9 06/11] wined3d: Call wined3d_texture_incref() instead of wined3d_surface_incref() from surface_resource_incref().
by Stefan Dösinger 22 Nov '15

22 Nov '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-11-19 um 20:34 schrieb Riccardo Bortolato: > -ULONG __cdecl wined3d_surface_incref(struct wined3d_surface *surface); This causes a compile error in d3d9: ../../../../src/wine/dlls/d3d9/surface.c:74:9: warning: implicit declaration of function ‘wined3d_surface_incref’ [-Wimplicit-function-declaration] wined3d_surface_incref(surface->wined3d_surface); ^ surface.o: In function `d3d9_surface_AddRef': /home/stefan/build/wine/dlls/d3d9/../../../../src/wine/dlls/d3d9/surface.c:74: undefined reference to `wined3d_surface_incref' collect2: error: ld returned 1 exit status -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWURLoAAoJEN0/YqbEcdMwnRsP/2O2sa8HlCSuwqIMM/T6j5u4 MsGvxJ8cWu2PNs6VyM7Zc2DlaU7JxR0RveJnketp6GA0Rln7afVIQztuW64SVADg Rv7kmTuteHqPQZYFr/9SHZgs1o/Dj+uSmo0gOFM62qWzwb3+vT+F+xK+745lOu9s /bAI8djIttNbwArkbDPhkYScLNOyk1jhZYPo0bs0t1T4fWzM+SIMsqPaTVhNlJNc f0lHQYMSqClNsvUbKksV6UTzoViLNPUM4UvrXy2cbgVQxeyG32yUIqWHnIeMJCBO U7NNwjxNV3/eM0f8F7R8lfHbMoq0l3fErV6jJXp04sVYRioqlRiB6qUx7sY+MDWg zwBuzIuZuQTaQjXYhiwz4TTO/UY2hCASeCQoDoUWHuDA6WJLZYYHOfLnVa1acBuu lPlZriSNu6i4ovO7DrMuhplFI4a1DGVFK2BDGxo2YsE71U95U4kj6XZVxr8Bvct7 YvB3rl/h+DvfwIHJspwMYC99eF/JS3ANB2bCUGlJEuHDN5ni4IYc7UioMax/IcV+ LqDp+C0vvIo8XzXHlFXkG5Razkq0v2KiJZjJKIwLYLNXFQ1QwKtS7ekbiwVVR3HU UeLTZjrPOO1996iB9mVMRh8b26N4wwns/ZWEj2zMTXY+3KRmhy6qQcq4ob6g+7jK Ud8ySMIm/lwN7Bv7rbIc =7k15 -----END PGP SIGNATURE-----

2 1

Re: [v9 04/11] ddraw7/tests: Test SetColorKey() on cubemap surfaces.
by Stefan Dösinger 22 Nov '15

22 Nov '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Now that I am back from the mentor summit and a follow-up vacation I can send this patch myself. I'll do that once my current 5 patches are either applied or rejected. I'll change the patch to use a different color key on the Z- surface to see if a follow-up GetColorKey(Z-) returns the key set on X+ or Z-. I still don't think we should bother about rendering or blitting. Color keyed cube maps seem like a pretty rare corner case. So far I've only seen one app using cube maps in ddraw at all (the EnvCube.exe d3d7 sample). Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWUQnSAAoJEN0/YqbEcdMwyOoP/3R0kjn2+zCM2nMnTpyZPuZ2 tnhyoT/QJYgpJBs01P6QMmdRGJh+3A++VgUvtmzd6Itio6/6gkLf1Ap3DEjnHwgH 9MRLMPVZEn1qL6j91SsCVVLFFhP9Y1JCNwHFUSuMx0DidOlR4NnkEupVPwdUj/fJ XcyyxNoGsLKFn19Sx83/STzOe6RGvJtHVKTanspm4tmOtJIqd+F8tCxwYwyP6WxW twaAq0bSXq2N7JLGUK6H1Mjqo7xYm1Kh8zAepJrYXK7llE+AsYSb0mKnBvU3ZrYb kXNeB4F3qmPznDuSy3oCnOO6KKHAZK4qUefsEryvByueKaJVPIhYDTpblchqqPMV YDGldBbvZBggJyICyxdPyXcECCuKC8xHsQbM+1TQBp+8kRg1d+JViFJZpjvAcEli 6/tzFBirdAwwrI0bivM+Ak6tNHKPtl/6kDil1vjbLcF6xjuPRUgkedCPT9Lr2JUD p6J5EHTdxHyQpxo4JP6/LsLqr3HbKXQSY8N+LIFlyyjaTtwIj23cEDt2znZKXaMG 3JTfJfC+iZVQXETCFMkFu6Wj6kX7D61/TM2Sc/nN+4JSldRm/wD2+TnChwd8p8l6 CQshOj5iToFeXBM1LTG6VDC2zdfqESaZHcshyTBgdNlGAHq09CIoDGX9NWws40FF QAfHlQ46Eb2cGv/4VTmg =bKoJ -----END PGP SIGNATURE-----

1 0

Setting some windows relations.
by John Found 21 Nov '15

21 Nov '15

Hi All. I am developing in Linux a GUI toolkit, that has port for Windows and I test in under WINE. Surprisingly, I stuck on two problems that look different, but probably has the same origin. The first is the setting of the owner window for the modal dialogs. In Windows it is common practice to set it through SetWindowLong with GWL_HWNDPARENT and it works - the owner window stay always under the . In WINE, setting the owner this way does not work. The owner window can be raised above the modal dialog. On the other hand, setting the hWndParent in CreateWindowEx works as intended. The problem is that when I create the dialog window I don't know the owner window I will use later and it can change during program execution. The second problem is with the windows that have to change from WS_POPUP to WS_OVERLAPPED and back by the same SetWindowLong. When I create a window as WS_OVERLAPPED and then change the style to WS_POPUP, the window looks like WS_POPUP, but does not behave as such. For example in Linux it has override_redirect=0, steals the focus from the main window, etc. When the window is created initially with WS_POPUP, nothing of this happens. Again in Windows, changing the style by SetWindowLong works as intended. Is there some simple workaround of these problems? In order to fight it I must redesign the whole library in order to create the windows with the right parameters. Some of the features I want to make need to destroy the windows and recreate them instead of simply change the needed parameters. -- http://fresh.flatassembler.net http://asm32.info John Found <johnfound(a)asm32.info>

4 9

Re: [PATCH 1/2] kernel32: Use correct virtual-key code for the Delete key when using wineconsole
by Alexandre Julliard 20 Nov '15

20 Nov '15

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > VK_DEL is 0x2e. The existing code used 127 (0x7F), which is VK_F16. These are character codes, not vkeys. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: mshtml: Make msec argument of setTimeout optional.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18383 Your paranoid android. === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w1064 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found === w1064 (64 bit) === No test summary line found

2 1

Re: [PATCH 1/3 v2] winex11.drv: Send WM_DROPFILES if IDropTarget_Drop failed or DROPEFFECT_NONE was set
by Piotr Caban 20 Nov '15

20 Nov '15

Hi Damjan, On 11/20/15 11:43, Piotr Caban wrote: > With these patches OLE Drag&Drop still doesn't behave exactly the same > as on Windows. E.g. IDropTarget::* failures or DROPEFFECT_NONE are > handled incorrectly in some places. I'm planning to send more patches > after code freeze. Here are the patches I'm planning to send after the code freeze (generated on top of this series). Thanks, Piotr

1 0

Re: [PATCH] d3d11: OMSetBlendState blend states is optional (try 2)
by Józef Kucia 20 Nov '15

20 Nov '15

Hi, The subject is not very accurate. On Thu, Nov 19, 2015 at 10:29 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Fixed failed tests. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3d11/device.c | 7 ++++++- > dlls/d3d11/tests/d3d11.c | 2 ++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c > index f2bc4d6..c6e54cf 100644 > --- a/dlls/d3d11/device.c > +++ b/dlls/d3d11/device.c > @@ -603,10 +603,15 @@ static void STDMETHODCALLTYPE d3d11_immediate_context_OMSetRenderTargetsAndUnord > } > > static void STDMETHODCALLTYPE d3d11_immediate_context_OMSetBlendState(ID3D11DeviceContext *iface, > - ID3D11BlendState *blend_state, const FLOAT blend_factor[4], UINT sample_mask) > + ID3D11BlendState *blend_state, const FLOAT arg_blend_factor[4], UINT sample_mask) > { > struct d3d_device *device = device_from_immediate_ID3D11DeviceContext(iface); > const D3D11_BLEND_DESC *desc; > + const FLOAT blend_default[4] = {1.0f, 1.0f, 1.0f, 1.0f}; > + const FLOAT *blend_factor = blend_default; > + > + if(arg_blend_factor) > + blend_factor = arg_blend_factor; There is a missing space after "if". > > TRACE("iface %p, blend_state %p, blend_factor {%.8e %.8e %.8e %.8e}, sample_mask 0x%08x.\n", > iface, blend_state, blend_factor[0], blend_factor[1], blend_factor[2], blend_factor[3], sample_mask); We should print actual arguments. If blend_factor is allowed to be NULL it should be treated as a pointer. > diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c > index 7021c6f..f42edf7 100644 > --- a/dlls/d3d11/tests/d3d11.c > +++ b/dlls/d3d11/tests/d3d11.c > @@ -2777,6 +2777,8 @@ static void test_blend(void) > > ID3D11DeviceContext_ClearRenderTargetView(context, backbuffer_rtv, red); > > + ID3D11DeviceContext_OMSetBlendState(context, src_blend, NULL, D3D11_DEFAULT_SAMPLE_MASK); > + A test showing that passing NULL to OmSetBlendState() resets the blend factor to (1.0, 1.0, 1.0 ,1.0) would be useful. Unfortunately, d3d11_immediate_context_OMGetBlendState() is not implemented yet. Also, the test_blend() is not the best place for this test as it is a visual test. The test should be probably placed in test_clear_state() but it is not ported from d3d10core tests yet. I think the best way would be to fix this issue in D3D10 as well and add a test in test_clear_state(). The test_clear_state() will be eventually ported to d3d11 tests. Thanks, Józef Kucia

1 0

Re: [PATCH] server: Trace process ID.
by Alexandre Julliard 20 Nov '15

20 Nov '15

Qian Hong <qhong(a)codeweavers.com> writes: > Signed-off-by: Qian Hong <qhong(a)codeweavers.com> > --- > server/request.h | 1 + > server/trace.c | 12 ++++++------ > 2 files changed, 7 insertions(+), 6 deletions(-) There are a lot more places that would have to be changed, but I'm not sure it's worth making all the traces larger for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3d11/test: Stop crash when CreateBlendState fails
by Józef Kucia 20 Nov '15

20 Nov '15

Hi, The subject prefix is wrong. It should be "d3d11/tests:". On Fri, Nov 20, 2015 at 7:51 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3d11/tests/d3d11.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c > index f42edf7..95ba8c0 100644 > --- a/dlls/d3d11/tests/d3d11.c > +++ b/dlls/d3d11/tests/d3d11.c > @@ -2139,6 +2139,11 @@ static void test_create_blend_state(void) > > hr = ID3D11Device_CreateBlendState(device, current_desc, &blend_state1); > ok(SUCCEEDED(hr), "Failed to create blend state, hr %#x.\n", hr); > + if (FAILED(hr)) > + { > + win_skip("Failed to create CreateBlendState, skipping test %u.\n", i); > + continue; > + } At this point the test already failed so there is no point to continue. What we should do is determine if CreateBlendState() should succeed or fail based on the device feature level. win_skip() is not correct as we won't be able to support independent blending on lower feature levels in Wine. Thanks, Józef Kucia

1 0

Re: [3/3] user32: Change value for WM_MDICALCCHILDSCROLL to 0x003f.
by Alexandre Julliard 20 Nov '15

20 Nov '15

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This appears to be what Windows uses. Is there an app where this makes a difference, or is it just because of the test? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: advapi32: Add a manifest to prevent registry virtualization.
by Alexandre Julliard 20 Nov '15

20 Nov '15

Vincent Povirk <madewokherd(a)gmail.com> writes: > While we could modify our test to detect this seemingly impossible > situation, I think it's better to just prevent registry > virtualization. (Then again, if we ever want to write tests for > registry virtualization, they should probably go in advapi32, so maybe > editing the test is better.) We will want to add tests for virtualization, so yes, I think that fixing the test would be preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] user32: Change value for WM_MDICALCCHILDSCROLL to 0x003f.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18381 Your paranoid android. === w8 (32 bit win) === win.c:3601: Test failed: hwnd 00020114 message 0118 === w1064 (32 bit win) === win.c:6842: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6864: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6842: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6842: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6842: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6842: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6842: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6864: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6842: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6864: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w864 (64 bit win) === win.c:3601: Test failed: hwnd 000000000002019A message 0118

1 0

Re: [1/3] user32/tests: Add some tests for mdiclient scrolling.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18379 Your paranoid android. === w8 (32 bit win) === win.c:3605: Test failed: hwnd 000201D2 message 0118 === w1064 (32 bit win) === win.c:6846: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6868: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6846: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6846: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6846: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6846: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6846: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6868: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6846: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6868: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w864 (64 bit win) === win.c:3605: Test failed: hwnd 000000000002019A message 0118

2 1

Re: [2/3] user32: Don't add scroll bars to mdiclient if the window style doesn't allow it.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18380 Your paranoid android. === w8 (32 bit win) === win.c:3603: Test failed: hwnd 000201D2 message 0118 === w1064 (32 bit win) === win.c:6844: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6866: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6844: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6844: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6844: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6844: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6844: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6866: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6844: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6866: Test failed: 0x80/0x1410000: window rect 0,0-1024,768

1 0

Re: winex11.drv: Send WM_DROPFILES if IDropTarget_Drop failed
by Piotr Caban 20 Nov '15

20 Nov '15

On 11/20/15 08:45, Piotr Caban wrote: > This partially fixes following regression: > https://bugs.winehq.org/show_bug.cgi?id=39445 > unfortunately there's another regression caused by > 3f99e71fde8231524597901e512e5c1909a82e1e commit in this application. > Please ignore this patch for now, I'll send a more complete solution for bug 39445. Thanks, Piotr

1 0

Re: [v8 04/11] ddraw7/tests: Test SetColorKey() on cubemap surfaces.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18368 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:8401: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8405: Test failed: Got unexpected priority 0, type cubemap. ddraw7.c:8410: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8412: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8420: Test failed: Got unexpected priority 1, type cubemap. === w1064 (32 bit ddraw7) === ddraw7.c:2243: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3084: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3086: Test failed: Got unexpected screen width 1024. ddraw7.c:3088: Test failed: Got unexpected screen height 768. ddraw7.c:3101: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3103: Test failed: Got unexpected screen width 1024. ddraw7.c:3105: Test failed: Got unexpected screen height 768. ddraw7.c:3109: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3111: Test failed: Got unexpected screen width 1024. ddraw7.c:3113: Test failed: Got unexpected screen height 768. ddraw7.c:3132: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3134: Test failed: Got unexpected screen width 1024. ddraw7.c:3136: Test failed: Got unexpected screen height 768. ddraw7.c:3140: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3142: Test failed: Got unexpected screen width 1024. ddraw7.c:3144: Test failed: Got unexpected screen height 768. ddraw7.c:3164: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3166: Test failed: Got unexpected screen width 1024. ddraw7.c:3168: Test failed: Got unexpected screen height 768. ddraw7.c:3173: Test failed: Got unexpected screen width 1024. ddraw7.c:3175: Test failed: Got unexpected screen height 768. ddraw7.c:3188: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3190: Test failed: Got unexpected screen width 1024. ddraw7.c:3192: Test failed: Got unexpected screen height 768. ddraw7.c:3196: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3198: Test failed: Got unexpected screen width 1024. ddraw7.c:3200: Test failed: Got unexpected screen height 768. ddraw7.c:3208: Test failed: Got unexpected screen width 1024. ddraw7.c:3210: Test failed: Got unexpected screen height 768. ddraw7.c:3222: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3224: Test failed: Got unexpected screen width 1024. ddraw7.c:3226: Test failed: Got unexpected screen height 768. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4081: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4094: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4110: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4129: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5937: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:8401: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8405: Test failed: Got unexpected priority 0, type cubemap. ddraw7.c:8410: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8412: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8420: Test failed: Got unexpected priority 1, type cubemap.

1 0

Re: advapi32: Add a manifest to prevent registry virtualization.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18371 Your paranoid android. === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w1064 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found === w1064 (64 bit) === No test summary line found

1 0

Re: [v9 04/11] ddraw7/tests: Test SetColorKey() on cubemap surfaces.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18370 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2243: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3084: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3086: Test failed: Got unexpected screen width 1024. ddraw7.c:3088: Test failed: Got unexpected screen height 768. ddraw7.c:3101: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3103: Test failed: Got unexpected screen width 1024. ddraw7.c:3105: Test failed: Got unexpected screen height 768. ddraw7.c:3109: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3111: Test failed: Got unexpected screen width 1024. ddraw7.c:3113: Test failed: Got unexpected screen height 768. ddraw7.c:3132: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3134: Test failed: Got unexpected screen width 1024. ddraw7.c:3136: Test failed: Got unexpected screen height 768. ddraw7.c:3140: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3142: Test failed: Got unexpected screen width 1024. ddraw7.c:3144: Test failed: Got unexpected screen height 768. ddraw7.c:3164: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3166: Test failed: Got unexpected screen width 1024. ddraw7.c:3168: Test failed: Got unexpected screen height 768. ddraw7.c:3173: Test failed: Got unexpected screen width 1024. ddraw7.c:3175: Test failed: Got unexpected screen height 768. ddraw7.c:3188: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3190: Test failed: Got unexpected screen width 1024. ddraw7.c:3192: Test failed: Got unexpected screen height 768. ddraw7.c:3196: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3198: Test failed: Got unexpected screen width 1024. ddraw7.c:3200: Test failed: Got unexpected screen height 768. ddraw7.c:3208: Test failed: Got unexpected screen width 1024. ddraw7.c:3210: Test failed: Got unexpected screen height 768. ddraw7.c:3222: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3224: Test failed: Got unexpected screen width 1024. ddraw7.c:3226: Test failed: Got unexpected screen height 768. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4081: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4094: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4110: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4129: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5937: Test failed: Failed to set display mode, hr 0x80004001.

1 0

Re: [v9 02/11] ddraw7/tests: Test GetPriority() on cubemap surfaces.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18369 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2183: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3024: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3026: Test failed: Got unexpected screen width 1024. ddraw7.c:3028: Test failed: Got unexpected screen height 768. ddraw7.c:3041: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3043: Test failed: Got unexpected screen width 1024. ddraw7.c:3045: Test failed: Got unexpected screen height 768. ddraw7.c:3049: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3051: Test failed: Got unexpected screen width 1024. ddraw7.c:3053: Test failed: Got unexpected screen height 768. ddraw7.c:3072: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3074: Test failed: Got unexpected screen width 1024. ddraw7.c:3076: Test failed: Got unexpected screen height 768. ddraw7.c:3080: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3082: Test failed: Got unexpected screen width 1024. ddraw7.c:3084: Test failed: Got unexpected screen height 768. ddraw7.c:3104: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3106: Test failed: Got unexpected screen width 1024. ddraw7.c:3108: Test failed: Got unexpected screen height 768. ddraw7.c:3113: Test failed: Got unexpected screen width 1024. ddraw7.c:3115: Test failed: Got unexpected screen height 768. ddraw7.c:3128: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3130: Test failed: Got unexpected screen width 1024. ddraw7.c:3132: Test failed: Got unexpected screen height 768. ddraw7.c:3136: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3138: Test failed: Got unexpected screen width 1024. ddraw7.c:3140: Test failed: Got unexpected screen height 768. ddraw7.c:3148: Test failed: Got unexpected screen width 1024. ddraw7.c:3150: Test failed: Got unexpected screen height 768. ddraw7.c:3162: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3164: Test failed: Got unexpected screen width 1024. ddraw7.c:3166: Test failed: Got unexpected screen height 768. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4021: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4034: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4050: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4069: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5877: Test failed: Failed to set display mode, hr 0x80004001.

1 0

Re: [v8 02/11] ddraw7/tests: Test GetPriority() on cubemap surfaces.
by Marvin 20 Nov '15

20 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18367 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:8341: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8345: Test failed: Got unexpected priority 0, type cubemap. ddraw7.c:8350: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8352: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8360: Test failed: Got unexpected priority 1, type cubemap. === w864 (32 bit ddraw7) === ddraw7.c:8341: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8345: Test failed: Got unexpected priority 0, type cubemap. ddraw7.c:8350: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8352: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8360: Test failed: Got unexpected priority 1, type cubemap. === w1064 (32 bit ddraw7) === ddraw7.c:2183: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3024: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3026: Test failed: Got unexpected screen width 1024. ddraw7.c:3028: Test failed: Got unexpected screen height 768. ddraw7.c:3041: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3043: Test failed: Got unexpected screen width 1024. ddraw7.c:3045: Test failed: Got unexpected screen height 768. ddraw7.c:3049: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3051: Test failed: Got unexpected screen width 1024. ddraw7.c:3053: Test failed: Got unexpected screen height 768. ddraw7.c:3072: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3074: Test failed: Got unexpected screen width 1024. ddraw7.c:3076: Test failed: Got unexpected screen height 768. ddraw7.c:3080: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3082: Test failed: Got unexpected screen width 1024. ddraw7.c:3084: Test failed: Got unexpected screen height 768. ddraw7.c:3104: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3106: Test failed: Got unexpected screen width 1024. ddraw7.c:3108: Test failed: Got unexpected screen height 768. ddraw7.c:3113: Test failed: Got unexpected screen width 1024. ddraw7.c:3115: Test failed: Got unexpected screen height 768. ddraw7.c:3128: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3130: Test failed: Got unexpected screen width 1024. ddraw7.c:3132: Test failed: Got unexpected screen height 768. ddraw7.c:3136: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3138: Test failed: Got unexpected screen width 1024. ddraw7.c:3140: Test failed: Got unexpected screen height 768. ddraw7.c:3148: Test failed: Got unexpected screen width 1024. ddraw7.c:3150: Test failed: Got unexpected screen height 768. ddraw7.c:3162: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3164: Test failed: Got unexpected screen width 1024. ddraw7.c:3166: Test failed: Got unexpected screen height 768. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4021: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4034: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4050: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4069: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5877: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:8341: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8345: Test failed: Got unexpected priority 0, type cubemap. ddraw7.c:8350: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8352: Test failed: Got unexpected hr 0, type cubemap. ddraw7.c:8360: Test failed: Got unexpected priority 1, type cubemap.

1 0

Re: winex11.drv: Send WM_DROPFILES if IDropTarget_Drop failed
by Damjan Jovanovic 20 Nov '15

20 Nov '15

On Fri, Nov 20, 2015 at 9:45 AM, Piotr Caban <piotr(a)codeweavers.com> wrote: > This partially fixes following regression: > https://bugs.winehq.org/show_bug.cgi?id=39445 > unfortunately there's another regression caused by > 3f99e71fde8231524597901e512e5c1909a82e1e commit in this application. > > Hi Which "[an]other regression"? Thank you Damjan > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/winex11.drv/xdnd.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > >

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel