- wine-devel - winehq.org

Re: [2/2] ntdll: Do not check if object was signaled after user APC in server_select. (resend)
by Marvin 23 Oct '15

23 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17602 Your paranoid android. === w1064 (64 bit sync) === sync.c:1694: Test failed: SleepConditionVariableCS should still return TRUE on crit unlock delay

1 0

Re: [PATCH 2/2] ws2_32: Add support for TF_REUSE_SOCKET to TransmitFile.
by Marvin 23 Oct '15

23 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17597 Your paranoid android. === w2008s64 (32 bit sock) === sock.c:7350: Test failed: bytesReturned isn't supposed to be 1 sock.c:7374: Test failed: GetOverlappedResult failed, error 997

1 0

Re: [PATCH 1/2] ws2_32: Add support for TF_DISCONNECT to TransmitFile.
by Sebastian Lackner 23 Oct '15

23 Oct '15

On 23.10.2015 02:03, Erich E. Hoover wrote: > Now that we have TransmitFile support, there are a couple important > flags that are frequently used by applications utilizing this feature > (particularly in async mode). This patch adds support for the > TF_DISCONNECT flag, which closes out the socket handle once the > TransmitFile operation is complete. I would prefer a solution without NtClose from an APC callback. I have tests in the Staging tree, which show that NtClose will throw an exception for invalid handles, when a debugger is attached.

1 0

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1 (try 2)
by Henri Verbeet 22 Oct '15

22 Oct '15

On 22 October 2015 at 09:00, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +static void test_create_device_swap_chain(void) You should probably just port d3d11/tests' test_create_device().

1 0

Re: quartz: Add stub IAMStreamSelect to MPEG-1 Stream Splitter. (try 2, resend)
by Nikolay Sivov 22 Oct '15

22 Oct '15

On 22.10.2015 17:35, Anton Baskanov wrote: > + if ( IsEqualIID(riid, &IID_IUnknown) > + || IsEqualIID(riid, &IID_IPersist) > + || IsEqualIID(riid, &IID_IMediaFilter) > + || IsEqualIID(riid, &IID_IBaseFilter) ) > + *ppv = iface; > + > + if ( IsEqualIID(riid, &IID_IAMStreamSelect) ) > + *ppv = &This->IAMStreamSelect_iface; This is usually done with 'else if'. > +static HRESULT WINAPI StreamSelect_QueryInterface(IAMStreamSelect *iface, REFIID riid, LPVOID *ppv) > +{ > + MPEGSplitterImpl *This = impl_from_IAMStreamSelect(iface); > + > + return IBaseFilter_QueryInterface(&This->Parser.filter.IBaseFilter_iface, riid, ppv); > +} Unfortunately we don't have a written rule for that (I think), so I guess I'm just sharing my habits: I personally try to use exact interface names for implementation functions, with leading 'I' stripped, so AMStreamSelect_* in this case. This makes it clear what's this is about, and you don't need to invent another name that doesn't exist anywhere. > +static const IAMStreamSelectVtbl StreamSelect_Vtbl = > +{ Same here, AMStreamSelectVtbl is easier imho. (quartz is not a best example in that regard) Also please, no LPVOID. > + HRESULT Count( > + [out] DWORD * pcStreams); > + > + HRESULT Info( > + [in] long lIndex, > + [out] AM_MEDIA_TYPE ** ppmt, > + [out] DWORD * pdwFlags, > + [out] LCID * plcid, > + [out] DWORD * pdwGroup, > + [out] WCHAR ** ppszName, > + [out] IUnknown ** ppObject, > + [out] IUnknown ** ppUnk); > + > + HRESULT Enable( > + [in] long lIndex, > + [in] DWORD dwFlags); You are using exact naming PSDK has, please do it in your own words, with better, cleaner names, like 'streams' or 'index', spacing in pointer notation could be fixed as well.

1 0

Re: ieframe: Capitalize some menu items‏
by Jacek Caban 22 Oct '15

22 Oct '15

Hi Jared, The patch still has NEW status, but I don't think I can sign it of myself. I'm not native speaker and I recall discussions about similar case on wine-devel in the past. I hope someone else can comment. Thanks, Jacek On 10/19/15 23:30, Jared Smudde wrote: > Signed-off-by: Jared Smudde <computerwhiz02(a)hotmail.com> > > Some of the second words on menu items are not capitalized. This looks weird as some of the other menu items are all capitalized. > > > dlls/ieframe/ieframe.rc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/ieframe/ieframe.rc b/dlls/ieframe/ieframe.rc > index aed8483..d4ccf3c 100644 > --- a/dlls/ieframe/ieframe.rc > +++ b/dlls/ieframe/ieframe.rc > @@ -32,11 +32,11 @@ IDR_BROWSE_MAIN_MENU MENU > } > MENUITEM "&Open...", ID_BROWSE_OPEN > MENUITEM "&Save", ID_BROWSE_SAVE > - MENUITEM "Save &as...", ID_BROWSE_SAVE_AS > + MENUITEM "Save &As...", ID_BROWSE_SAVE_AS > MENUITEM SEPARATOR > - MENUITEM "Print &format...", ID_BROWSE_PRINT_FORMAT > + MENUITEM "Print &Format...", ID_BROWSE_PRINT_FORMAT > MENUITEM "Pr&int...", ID_BROWSE_PRINT > - MENUITEM "Print previe&w", ID_BROWSE_PRINT_PREVIEW > + MENUITEM "Print Previe&w", ID_BROWSE_PRINT_PREVIEW > MENUITEM SEPARATOR > MENUITEM "&Properties", ID_BROWSE_PROPERTIES > MENUITEM "&Close", ID_BROWSE_QUIT > @@ -45,8 +45,8 @@ IDR_BROWSE_MAIN_MENU MENU > { > POPUP "&Toolbars" > { > - MENUITEM "&Standard bar", ID_BROWSE_BAR_STD > - MENUITEM "&Address bar", ID_BROWSE_BAR_ADDR > + MENUITEM "&Standard Bar", ID_BROWSE_BAR_STD > + MENUITEM "&Address Bar", ID_BROWSE_BAR_ADDR > } > } > POPUP "&Favorites"

3 2

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1 (try 2)
by Józef Kucia 22 Oct '15

22 Oct '15

On Thu, Oct 22, 2015 at 9:00 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=39278 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3d10_1/d3d10_1.spec | 2 +- > dlls/d3d10_1/d3d10_1_main.c | 71 ++++++++++++++++++++++++++++++++++++++++++ > dlls/d3d10_1/tests/Makefile.in | 2 +- > dlls/d3d10_1/tests/d3d10_1.c | 63 +++++++++++++++++++++++++++++++++++++ > include/d3d10_1.idl | 3 ++ > 5 files changed, 139 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3d10_1/d3d10_1.spec b/dlls/d3d10_1/d3d10_1.spec > index b3d2da7..5582558 100644 > --- a/dlls/d3d10_1/d3d10_1.spec > +++ b/dlls/d3d10_1/d3d10_1.spec > @@ -3,7 +3,7 @@ > @ stub D3D10CompileShader > @ stub D3D10CreateBlob > @ stdcall D3D10CreateDevice1(ptr long ptr long long long ptr) > -@ stub D3D10CreateDeviceAndSwapChain1 > +@ stdcall D3D10CreateDeviceAndSwapChain1(ptr long ptr long long long ptr ptr ptr) > @ stdcall D3D10CreateEffectFromMemory(ptr long long ptr ptr ptr) d3d10.D3D10CreateEffectFromMemory > @ stub D3D10CreateEffectPoolFromMemory > @ stdcall D3D10CreateStateBlock(ptr ptr ptr) d3d10.D3D10CreateStateBlock > diff --git a/dlls/d3d10_1/d3d10_1_main.c b/dlls/d3d10_1/d3d10_1_main.c > index a619004..e51019c 100644 > --- a/dlls/d3d10_1/d3d10_1_main.c > +++ b/dlls/d3d10_1/d3d10_1_main.c > @@ -168,3 +168,74 @@ HRESULT WINAPI D3D10CreateDevice1(IDXGIAdapter *adapter, D3D10_DRIVER_TYPE drive > > return hr; > } > + > +HRESULT WINAPI D3D10CreateDeviceAndSwapChain1(IDXGIAdapter *adapter, D3D10_DRIVER_TYPE driver_type, > + HMODULE swrast, UINT flags, D3D10_FEATURE_LEVEL1 hw_level, UINT sdk_version, > + DXGI_SWAP_CHAIN_DESC *swapchain_desc, IDXGISwapChain **swapchain, ID3D10Device1 **device) > +{ > + IDXGIDevice *dxgi_device; > + IDXGIFactory *factory; > + HRESULT hr; > + > + TRACE("adapter %p, driver_type %s, swrast %p, flags %#x, hw_level %s, sdk_version %d, " > + "swapchain_desc %p, swapchain %p, device %p\n", > + adapter, debug_d3d10_driver_type(driver_type), swrast, flags, > + debug_d3d10_feature_level(hw_level), sdk_version, swapchain_desc, swapchain, device); > + It's generally preferred to end messages with dot in new D3D code. It also applies to WARN(), ERR(), FIXME() and ok() messages in tests. > + if(!device) > + return E_INVALIDARG; There should be a space after 'if': if (!device) Please fix this in tests as well. > + > + hr = D3D10CreateDevice1(adapter, driver_type, swrast, flags, hw_level, sdk_version, device); > + if (FAILED(hr)) > + { > + WARN("Failed to create a device, returning %#x\n", hr); > + *device = NULL; > + return hr; > + } It's generally preferred to check if function failed in a single line in new code, i.e. if (FAILED(hr = D3D10CreateDevice1(adapter, driver_type, swrast, flags, hw_level, sdk_version, device)) > + > + TRACE("Created ID3D10Device1 %p\n", *device); > + > + hr = ID3D10Device1_QueryInterface(*device, &IID_IDXGIDevice, (void **)&dxgi_device); > + if (FAILED(hr)) > + { > + ERR("Failed to get a dxgi device from the d3d10 device, returning %#x\n", hr); > + ID3D10Device1_Release(*device); > + *device = NULL; > + return hr; > + } > + > + hr = IDXGIDevice_GetAdapter(dxgi_device, &adapter); > + IDXGIDevice_Release(dxgi_device); > + if (FAILED(hr)) > + { > + ERR("Failed to get the device adapter, returning %#x\n", hr); > + ID3D10Device1_Release(*device); > + *device = NULL; > + return hr; > + } > + > + hr = IDXGIAdapter_GetParent(adapter, &IID_IDXGIFactory, (void **)&factory); > + IDXGIAdapter_Release(adapter); > + if (FAILED(hr)) > + { > + ERR("Failed to get the adapter factory, returning %#x\n", hr); > + ID3D10Device1_Release(*device); > + *device = NULL; > + return hr; > + } > + > + hr = IDXGIFactory_CreateSwapChain(factory, (IUnknown *)*device, swapchain_desc, swapchain); > + IDXGIFactory_Release(factory); > + if (FAILED(hr)) > + { > + ID3D10Device1_Release(*device); > + *device = NULL; > + > + WARN("Failed to create a swapchain, returning %#x\n", hr); > + return hr; > + } > + > + TRACE("Created IDXGISwapChain %p\n", *swapchain); > + > + return S_OK; > +} > diff --git a/dlls/d3d10_1/tests/Makefile.in b/dlls/d3d10_1/tests/Makefile.in > index f6f17bd..256bb40 100644 > --- a/dlls/d3d10_1/tests/Makefile.in > +++ b/dlls/d3d10_1/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = d3d10_1.dll > -IMPORTS = d3d10_1 > +IMPORTS = d3d10_1 user32 > > C_SRCS = \ > d3d10_1.c > diff --git a/dlls/d3d10_1/tests/d3d10_1.c b/dlls/d3d10_1/tests/d3d10_1.c > index 534689c..c760b0d 100644 > --- a/dlls/d3d10_1/tests/d3d10_1.c > +++ b/dlls/d3d10_1/tests/d3d10_1.c > @@ -377,8 +377,71 @@ static void test_create_blend_state(void) > ok(!refcount, "Device has %u references left.\n", refcount); > } > > +static void test_create_device_swap_chain(void) > +{ > + HRESULT hr; > + ID3D10Device1 *device; > + IDXGISwapChain *swapchain; > + DXGI_SWAP_CHAIN_DESC swapchain_desc; > + HWND window; > + > + window = CreateWindowA("d3d10_test_wc", "d3d10_test_swap", WS_OVERLAPPEDWINDOW, > + 0, 0, 640, 480, NULL, NULL, NULL, NULL); > + ok(!!window, "Failed to create a window.\n"); > + > + memset(&swapchain_desc, 0, sizeof(swapchain_desc)); > + swapchain_desc.BufferCount = 1; > + swapchain_desc.BufferDesc.Width = 640; > + swapchain_desc.BufferDesc.Height = 480; > + swapchain_desc.BufferDesc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; > + swapchain_desc.BufferDesc.RefreshRate.Numerator = 60; > + swapchain_desc.BufferDesc.RefreshRate.Denominator = 1; > + swapchain_desc.BufferUsage = DXGI_USAGE_RENDER_TARGET_OUTPUT; > + swapchain_desc.SampleDesc.Count = 1; > + swapchain_desc.SampleDesc.Quality = 0; > + swapchain_desc.Windowed = TRUE; > + > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, &swapchain, NULL); > + ok(hr == E_INVALIDARG, "got %#x.\n", hr); > + > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, NULL, &device); > + todo_wine ok(hr == S_OK, "got %#x.\n", hr); > + if(hr == S_OK) > + ID3D10Device1_Release(device); > + > + /* swapchain_desc.OutputWindow = NULL */ > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, &swapchain, &device); > + todo_wine ok(hr == DXGI_ERROR_INVALID_CALL, "got %#x.\n", hr); > + > + swapchain_desc.OutputWindow = window; > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, &swapchain, &device); > + if(FAILED(hr)) > + { > + skip("Failed to create device.\n"); > + return; > + } You are leaking HWND. Also I am not sure why you use skip() here. > + > + IDXGISwapChain_Release(swapchain); > + ID3D10Device1_Release(device); > + > + DestroyWindow(window); > +} > + > START_TEST(d3d10_1) > { > + WNDCLASSA wc = {0}; > + > + wc.lpfnWndProc = DefWindowProcA; > + wc.lpszClassName = "d3d10_test_wc"; > + RegisterClassA(&wc); > + > test_create_shader_resource_view(); > test_create_blend_state(); > + test_create_device_swap_chain(); > + > + UnregisterClassA("d3d10_test_wc", GetModuleHandleA(NULL)); > } You don't need a new window class. Please use "static". > diff --git a/include/d3d10_1.idl b/include/d3d10_1.idl > index 4ee49c6..05d22b5 100644 > --- a/include/d3d10_1.idl > +++ b/include/d3d10_1.idl > @@ -151,3 +151,6 @@ const UINT D3D10_1_SDK_VERSION = 0x20; > > cpp_quote("HRESULT WINAPI D3D10CreateDevice1(IDXGIAdapter*,D3D10_DRIVER_TYPE,") > cpp_quote(" HMODULE,UINT,D3D10_FEATURE_LEVEL1,UINT,ID3D10Device1**);") > +cpp_quote("HRESULT WINAPI D3D10CreateDeviceAndSwapChain1(IDXGIAdapter *,") > +cpp_quote(" D3D10_DRIVER_TYPE, HMODULE, UINT, D3D10_FEATURE_LEVEL1,") > +cpp_quote(" UINT, DXGI_SWAP_CHAIN_DESC *, IDXGISwapChain **, ID3D10Device1 **);") Please avoid cpp_quote and include parameter names. See D3D11CreateDeviceAndSwapChain() in d3d11.idl. > -- > 1.9.1 > > >

1 0

Re: [PATCH 2/6] d3d11: Use CreateDXGIFactory1 to create factory in D3D11CreateDevice.
by Stefan Dösinger 22 Oct '15

22 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-22 um 01:52 schrieb Józef Kucia: > - hr = CreateDXGIFactory(&IID_IDXGIFactory, (void **)&factory); > + hr = CreateDXGIFactory1(&IID_IDXGIFactory, (void **)&factory); Shouldn't you request an IDXGIFactory1 interface now? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWKLJpAAoJEN0/YqbEcdMwEowQAI86raf6TRlQgfOeUiKzQTMr 2cUKnGqoaCVNwTWgFwX8WBusGAuOtak409h2VvQ3CHcvXBqAzS0XO6eXvXqZuKtn dihGyCGtLGTOzldCsI0k50xhQj2/9+UbkCs4YAL0muFzrlpA/i1CSi+XWb9arySc KJNjMx7wa77cbCDlWqJTrtAWK1ftHA0hWpddogxy5y16TpYq5fvBS5Nf0VkMZ28K +EFpINsnT3ed7xJbbWgDOKxb/8K8JgkB5N2PwYn3eyDAugawIeZTU6/WG1r1nFuq KbZnN/RZv1rB4Hqixl7Ic1sNWIB2zNQ0r0NsrHCVMLXe9Qq7cVnv2iMhYuXAs5Cj HdBZE5nJ2V2Tncd12m7qo8vAX+Fl+caUWYIPUlHz27IYVYZ1NFmvnZKVIuqXhJu/ 5xI1G5+ycYZ6+giWQY5WGm5YmPvc7ni/lcYu+KGOCk0xMFkz+9VmnZQ0N/LEHu9Y H/ufWYUexXmFMNyZKvZbTtXttynhVY6JxuiAuW3BACIoeaygYVNumk3n6ckfh3rF XBjoz8FbynUIf/3RUjEQukMKmwhYBJjMQvloqZMUYsptpMBYOtBww57uLZdRv8bD jFds+0vHI99uYFYhAn9ujtiBIbn2bsb0hLJvAgKNg+qRAAj1kuwhf/4mEQKvWUJT KKoUf43d/WBfnDH1/Sdz =OkwT -----END PGP SIGNATURE-----

2 1

Re: [8/8] webservices: Implement WsSetInputToBuffer.
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17568 Your paranoid android. === w7u (32 bit reader) === reader.c:1390: Test failed: wrong data L"valueest" === w864 (32 bit reader) === reader.c:1390: Test failed: wrong data L"valueP\5868P" === w1064 (32 bit reader) === reader.c:1390: Test failed: wrong data L"valuez\c5d8z\2980z\2980z\2980z\26b8z\2980z\2980z\2980z\2980z\2980z\26b8z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\26b8z\70d3\6a13\e609" === w7pro64 (64 bit reader) === reader.c:1390: Test failed: wrong data L"value]" === w864 (64 bit reader) === reader.c:1390: Test failed: wrong data L"valueU" === w1064 (64 bit reader) === reader.c:1390: Test failed: wrong data L"value0"

1 0

Re: [PATCH 08/10] wined3d: make wined3d_device_update_surface operate with wined3d_texture and sub_resource_idx
by Henri Verbeet 22 Oct '15

22 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > @@ -3774,12 +3764,25 @@ float CDECL wined3d_device_get_npatch_mode(const struct wined3d_device *device) > /* FIXME: Callers should probably use wined3d_device_update_sub_resource() > * instead. */ > HRESULT CDECL wined3d_device_update_surface(struct wined3d_device *device, > - struct wined3d_surface *src_surface, const RECT *src_rect, > - struct wined3d_surface *dst_surface, const POINT *dst_point) > + struct wined3d_texture *src_texture, unsigned int src_idx, const RECT *src_rect, > + struct wined3d_texture *dst_texture, unsigned int dst_idx, const POINT *dst_point) You should probably use wined3d_device_update_sub_resource() instead.

3 11

Re: [PATCH 06/10] d3d9: use wined3d_rendertarget_view_create instead of wined3d_rendertarget_view_create_from_surface in d3d9_surface_get_rendertarget_view
by Henri Verbeet 22 Oct '15

22 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > + desc.format_id = resource_desc.format; > + desc.u.texture.level_idx = surface->sub_resource_idx; > + desc.u.texture.layer_idx = 0; This is wrong for cube texture surfaces.

2 8

Re: [3/8] webservices: Add a stub implementation of WsGetXmlAttribute.
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17566 Your paranoid android. === w7u (32 bit reader) === reader.c:1329: Test failed: wrong data L"valueest" === w864 (32 bit reader) === reader.c:1329: Test failed: wrong data L"valueD\5868D" === w1064 (32 bit reader) === reader.c:1329: Test failed: wrong data L"valueo\c5d8o\2980o\2980o\2980o\26b8o\2980o\2980o\2980o\2980o\2980o\26b8o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\26b8o\5ee6\5456\8e4e" === w7pro64 (64 bit reader) === reader.c:1329: Test failed: wrong data L"valueb" === w864 (64 bit reader) === reader.c:1329: Test failed: wrong data L"valueT" === w1064 (64 bit reader) === reader.c:1329: Test failed: wrong data L"value'"

1 0

Re: [PATCH 5/5] wined3d: Use the core version of the debug messages functions.
by Henri Verbeet 22 Oct '15

22 Oct '15

On 22 October 2015 at 00:21, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Fixes bug 39478. > > Do we want to introduce some additional tag for this kind of info? > In general, no. The way you search for bugs fixed by a particular commit is to search for the commit ID in bugzilla. Bug ID's aren't necessarily stable over the lifetime of the git repository, and for Wine in particular it isn't necessarily clear beforehand what bugs a patch is going to fix. I also would have preferred a (short) description of the issue in the commit message over having to look it up in bugzilla.

1 0

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Sebastian Lackner 22 Oct '15

22 Oct '15

On 21.10.2015 02:43, Hugh McMaster wrote: > + if (osvi.dwMajorVersion >= 6) /* Windows Vista or higher */ > + { > + COORD c; > + c = GetConsoleFontSize(std_output, cfi.nFont); > + todo_wine ok(cfi.dwFontSize.X == c.X, "got %d, expected %d\n", cfi.dwFontSize.X, c.X); > + todo_wine ok(cfi.dwFontSize.Y == c.Y, "got %d, expected %d\n", cfi.dwFontSize.Y, c.Y); > + } > + else > + { > + CONSOLE_SCREEN_BUFFER_INFO csbi; > + short int width, height; > + GetConsoleScreenBufferInfo(std_output, &csbi); > + width = csbi.srWindow.Right - csbi.srWindow.Left + 1; > + height = csbi.srWindow.Bottom - csbi.srWindow.Top + 1; > + ok(cfi.dwFontSize.X == width, "got %d, expected %d\n", cfi.dwFontSize.X, width); > + ok(cfi.dwFontSize.Y == height, "got %d, expected %d\n", cfi.dwFontSize.Y, height); > + } I haven't reviewed the whole patch, but wanted to point that we usually do not test or implement Windows version specific behavior, unless an application depends on it. Often only one of both is implemented, and the other version is marked as broken. If you decide to implement the pre-Vista behavior (which would make sense, because Wine still uses WinXP as default version), it seems like no wineserver changes are required at all (at least as long as font.index is always 0).

3 2

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1 (try 2)
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17563 Your paranoid android. === wvistau64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w2008s64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w7u (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w7pro64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w8 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w864 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w1064 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === wvistau64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w2008s64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w7pro64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w864 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w1064 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002.

1 0

Re: [PATCH] vbscript/tests Add array out of bounds test
by Jacek Caban 22 Oct '15

22 Oct '15

Hi Alistair, On 10/20/15 10:05, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/vbscript/tests/lang.vbs | 5 +++++ > dlls/vbscript/tests/run.c | 17 ++++++++++++++++- > 2 files changed, 21 insertions(+), 1 deletion(-) This seems more complicated than it has to be. Is there any reason you don't use parse_script_ar helper? Thanks, Jacek

2 1

Re: [PATCH 6/6] dxgi/tests: Remove test_device_interfaces().
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17561 Your paranoid android. === w1064 (32 bit device) === device.c:1141: Test failed: Got unexpected hr 0, test 16. device.c:1141: Test failed: Got unexpected hr 0x87a0001, test 39. === w1064 (64 bit device) === device.c:1195: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1195: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1195: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1195: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1141: Test failed: Got unexpected hr 0, test 39. device.c:1195: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1195: Test failed: Got usage 160, expected 60, test 42, buffer 15.

1 0

Re: [PATCH] quartz: show fixme for Parser_OutputPin_QueryInterface only once
by Nikolay Sivov 21 Oct '15

21 Oct '15

On 20.10.2015 21:56, Jonas Maebe wrote: > This prevents the game Majesty Gold HD from flooding the console with > "No interface for {56a868a5-0ad4-11ce-b03a-0020af0ba770}" messages. > > Signed-off-by: Jonas Maebe <jonas.maebe(a)elis.ugent.be> > --- > dlls/quartz/parser.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dlls/quartz/parser.c b/dlls/quartz/parser.c > index cd8d93d..a9384a5 100644 > --- a/dlls/quartz/parser.c > +++ b/dlls/quartz/parser.c > @@ -634,6 +634,7 @@ static HRESULT WINAPI Parser_OutputPin_BreakConnect(BaseOutputPin *This) > > static HRESULT WINAPI Parser_OutputPin_QueryInterface(IPin * iface, REFIID riid, LPVOID * ppv) > { > + static int once = 0; > Parser_OutputPin *This = unsafe_impl_Parser_OutputPin_from_IPin(iface); > > TRACE("(%s, %p)\n", qzdebugstr_guid(riid), ppv); > @@ -654,7 +655,11 @@ static HRESULT WINAPI Parser_OutputPin_QueryInterface(IPin * iface, REFIID riid, > return S_OK; > } > > - FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); > + if (!once) > + { > + FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); > + once = 1; > + } > > return E_NOINTERFACE; > } > This is too much, because it will disable every failed QI fixme after first one. Base output pin already supports IQualityControl case, by forwarding it. So proper fix is to try to write some tests for this pin implementation to see if it's supposed to be supported, and then act from there.

2 3

Re: [PATCH] configure: Check for linker relocation support before relying on prelink
by Alexandre Julliard 21 Oct '15

21 Oct '15

Michael Cronenworth <mike(a)cchtml.com> writes: > @@ -1167,8 +1173,9 @@ static void build(struct options* opts) > spawn(opts->prefix, link_args, 0); > strarray_free (link_args); > > - /* set the base address */ > - if (opts->image_base && !opts->target) > + /* set the base address with prelink if linker support is not present */ > + if (opts->image_base && !opts->target && > + try_link(opts->prefix, link_args, strmake("-Wl,-Ttext-segment=%s", opts->image_base))) It looks OK now, but please avoid calling try_link() twice for the same check. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1
by Henri Verbeet 21 Oct '15

21 Oct '15

On 21 October 2015 at 05:25, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > --- > dlls/d3d10_1/d3d10_1.spec | 2 +- > dlls/d3d10_1/d3d10_1_main.c | 68 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 1 deletion(-) > Tests, please.

1 0

Re: [PATCH 1/2] kernel32/tests: Add tests for GetCurrentConsoleFont (v2)
by Marvin 21 Oct '15

21 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17535 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: fltmgr.sys: add FltInitializePushLock stub (try 4)
by Dmitry Timoshkov 21 Oct '15

21 Oct '15

Austin English <austinenglish(a)gmail.com> wrote: > +void WINAPI FltInitializePushLock( PEX_PUSH_LOCK *lock ) According to MSDN this is wrong. -- Dmitry.

1 0

ws2_32: Implement a basic synchronous TransmitFile.
by Hugh McMaster 21 Oct '15

21 Oct '15

Hi Erich, When checking another Wine component, I noticed build warnings for dlls/ws2_32/socket.c. The relevant commit is 4d081f36efefd3ccf702cacea4d20c5616cfbae1, which was your patch, so I thought I'd let you know. socket.c: In function ‘WS2_TransmitFile’: socket.c:2826:46: warning: ‘iosb.Information’ may be used uninitialized in this function [-Wmaybe-uninitialized] wsa->write.iovec[0].iov_len = iosb.Information; ^ socket.c:2808:25: note: ‘iosb.Information’ was declared here IO_STATUS_BLOCK iosb; ^ Adding iosb.Information = 0 before status = WS2_ReadFile( wsa->file, &iosb, wsa->buffer, bytes_per_send ); fixes the warning, but I have no idea if that is correct for for ws2_32. -- Hugh McMaster

2 1

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Marvin 21 Oct '15

21 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17531 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH 1/4 v2] server: Add console font table information
by Sebastian Lackner 21 Oct '15

21 Oct '15

On 21.10.2015 02:43, Hugh McMaster wrote: > Changes since version 1: > * Removed an unintentional newline > * Simplified a few comments > > We must use the server because kernel32 does not export a function for this purpose. > The struct font_info can also be expanded to support all elements from CONSOLE_FONT_INFOEX. > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > server/console.c | 19 +++++++++++++++++++ > server/protocol.def | 7 ++++++- > 2 files changed, 25 insertions(+), 1 deletion(-) > font.index is unused, it would make more sense to add it later, when it is actually required. Also see my previous mail, where I point out that you could implement the XP-version of those functions without any wineserver changes at all.

1 0

Re: kernel32/tests: Remove unnecessary busy loop (PVS-Studio).
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17527 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE)

1 0

Re: [PATCH] shell32: Implement IShellDispatch2::ShellExecute
by Huw Davies 20 Oct '15

20 Oct '15

On 20 Oct 2015, at 19:25, Andrew Eikum wrote: > -static HRESULT WINAPI ShellDispatch_ShellExecute(IShellDispatch6 *iface, BSTR file, VARIANT args, VARIANT dir, > - VARIANT op, VARIANT show) > +static HRESULT WINAPI ShellDispatch_ShellExecute(IShellDispatch6 *iface, > + BSTR file, VARIANT v_args, VARIANT v_dir, VARIANT v_op, VARIANT v_show) > { > - FIXME("(%s): stub\n", debugstr_w(file)); > - return E_NOTIMPL; > + VARIANT args_str, dir_str, op_str, show_str; > + WCHAR *args = NULL, *dir = NULL, *op = NULL; > + INT show = 0; > + HINSTANCE ret; > + > + TRACE("(%s, %s, %s, %s, %s)\n", debugstr_w(file), debugstr_variant(&v_args), > + debugstr_variant(&v_dir), debugstr_variant(&v_op), debugstr_variant(&v_show)); > + > + VariantInit(&v_args); Did you mean to args_str here? > + VariantChangeType(&args_str, &v_args, 0, VT_BSTR); > + if (V_VT(&v_args) == VT_BSTR) > + args = V_BSTR(&v_args); and also args_str here? (and similar occurrences below). Huw.

2 1

Marvin says... (was: [v2] d3d8: Adjust D3DCOLOR_ARGB to avoid shift overflow.)
by Gerald Pfeifer 20 Oct '15

20 Oct '15

On Tue, 20 Oct 2015, Marvin wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Committed". > > This means that your patch has been approved, and committed to the > main git tree. Congratulations! Sooo, this is officially cool. For casual contributors like me, this is especially nice and helpful, and it saves me time to check (git and/or mailing list archives) manually. Thank you! Gerald

1 0

Re: [PATCH 03/10] d3d9: move GetDC check to actual d3d9_surface_GetDC call
by Henri Verbeet 20 Oct '15

20 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > @@ -360,7 +379,6 @@ static const struct wined3d_parent_ops d3d9_surface_wined3d_parent_ops = > void surface_init(struct d3d9_surface *surface, struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx, > struct wined3d_surface *wined3d_surface, const struct wined3d_parent_ops **parent_ops) > { > - struct wined3d_resource_desc desc; > IDirect3DBaseTexture9 *texture; > > surface->IDirect3DSurface9_iface.lpVtbl = &d3d9_surface_vtbl; > @@ -379,23 +397,6 @@ void surface_init(struct d3d9_surface *surface, struct wined3d_texture *wined3d_ > IDirect3DBaseTexture9_Release(texture); > } > > - wined3d_resource_get_desc(wined3d_surface_get_resource(wined3d_surface), &desc); > - switch (d3dformat_from_wined3dformat(desc.format)) > - { > - case D3DFMT_A8R8G8B8: > - case D3DFMT_X8R8G8B8: > - case D3DFMT_R5G6B5: > - case D3DFMT_X1R5G5B5: > - case D3DFMT_A1R5G5B5: > - case D3DFMT_R8G8B8: > - surface->getdc_supported = TRUE; > - break; > - > - default: > - surface->getdc_supported = FALSE; > - break; > - } > - > *parent_ops = &d3d9_surface_wined3d_parent_ops; > } I guess you're moving this to avoid wined3d_texture_get_sub_resource() in surface_init(), but you don't really need that. You can get the format from the texture, since it's the same for all sub-resources.

2 2

Re: [PATCH 02/10] d3d9: avoid using a wined3d_surface in get_desc calls inside d3d9_device_StretchRect
by Henri Verbeet 20 Oct '15

20 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > + if (!(sub_resource = wined3d_texture_get_sub_resource(dst->wined3d_texture, dst->sub_resource_idx))) > + goto done; This should never fail.

2 2

Re: d3d9/tests: Test the return of CreateDepthStencilSurface()
by Henri Verbeet 20 Oct '15

20 Oct '15

On 20 October 2015 at 09:48, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > hr = IDirect3DDevice9_CreateDepthStencilSurface(device, 640, 480, D3DFMT_D24S8, > D3DMULTISAMPLE_NONE, 0, TRUE, &ds, NULL); > + ok(SUCCEEDED(hr), "Failed to create depth stencil surface, hr = %08x.\n", hr); Please use the same style as the other messages in the test. (I.e., "hr %#x.\n".)

1 0

Re: [PATCH] wintrust/tests: Use proper return types when calling provider funcs (PVS-Studio)
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17516 Your paranoid android. === w1064 (32 bit softpub) === softpub: unhandled exception c0000005 at 757DC81B === w864 (64 bit softpub) === softpub: unhandled exception c0000005 at 00007FFB7AFF266C === w1064 (64 bit softpub) === softpub.c:255: Test failed: Expected S_OK, got 00000001 softpub.c:258: Test failed: Expected S_OK, got 00000001 softpub: unhandled exception c0000005 at 00007FF85A339A5D

1 0

Re: [PATCH] usp10/tests: Use BOOL variable for BOOL retval (PVS-Studio)
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17515 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1244: Test failed: 0: uJustification incorrect (0) usp10.c:1244: Test failed: 1: uJustification incorrect (0) usp10.c:1244: Test failed: 2: uJustification incorrect (0) usp10.c:1244: Test failed: 3: uJustification incorrect (0) usp10.c:1244: Test failed: 4: uJustification incorrect (0) usp10.c:1244: Test failed: 5: uJustification incorrect (0) usp10.c:1244: Test failed: 6: uJustification incorrect (0) usp10.c:1244: Test failed: 7: uJustification incorrect (0) usp10.c:1244: Test failed: 8: uJustification incorrect (0) usp10.c:1244: Test failed: 9: uJustification incorrect (0) usp10.c:1260: Test failed: 3: uJustification incorrect (0) usp10.c:1260: Test failed: 5: fDiacritic incorrect (1) usp10.c:1260: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1260: Test failed: 15: fDiacritic incorrect (1) usp10.c:1260: Test failed: 15: fZeroWidth incorrect (1)

2 1

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17510 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [RFC PATCH 1/2] msvcrt: Split simple string/memory routines to a separate file
by Alexandre Julliard 20 Oct '15

20 Oct '15

Martin Storsjo <martin(a)martin.st> writes: > These are simple functions that don't touch the global CRT state > (not touching errno etc). These are functions that are part of > vcruntime140.dll in the new ucrtbase/vcruntime split. > > Signed-off-by: Martin Storsjo <martin(a)martin.st> > --- > I'm not sure if "memory" is the best filename here, other suggestions > are welcome. I don't think you need a separate file for this. Simply duplicate the handful of functions that you need inside vcruntime140. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ddraw/tests: Test the return of DrawPrimitive()
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17507 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2183: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3024: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3026: Test failed: Got unexpected screen width 1024. ddraw7.c:3028: Test failed: Got unexpected screen height 768. ddraw7.c:3041: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3043: Test failed: Got unexpected screen width 1024. ddraw7.c:3045: Test failed: Got unexpected screen height 768. ddraw7.c:3049: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3051: Test failed: Got unexpected screen width 1024. ddraw7.c:3053: Test failed: Got unexpected screen height 768. ddraw7.c:3072: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3074: Test failed: Got unexpected screen width 1024. ddraw7.c:3076: Test failed: Got unexpected screen height 768. ddraw7.c:3080: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3082: Test failed: Got unexpected screen width 1024. ddraw7.c:3084: Test failed: Got unexpected screen height 768. ddraw7.c:3104: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3106: Test failed: Got unexpected screen width 1024. ddraw7.c:3108: Test failed: Got unexpected screen height 768. ddraw7.c:3113: Test failed: Got unexpected screen width 1024. ddraw7.c:3115: Test failed: Got unexpected screen height 768. ddraw7.c:3128: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3130: Test failed: Got unexpected screen width 1024. ddraw7.c:3132: Test failed: Got unexpected screen height 768. ddraw7.c:3136: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3138: Test failed: Got unexpected screen width 1024. ddraw7.c:3140: Test failed: Got unexpected screen height 768. ddraw7.c:3148: Test failed: Got unexpected screen width 1024. ddraw7.c:3150: Test failed: Got unexpected screen height 768. ddraw7.c:3162: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3164: Test failed: Got unexpected screen width 1024. ddraw7.c:3166: Test failed: Got unexpected screen height 768. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4021: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4034: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4050: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4069: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5877: Test failed: Failed to set display mode, hr 0x80004001. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

2 1

Re: gdi32: Return default palette entries from GetSystemPaletteEntries for non-palette-based devices. (try 5)
by Huw Davies 20 Oct '15

20 Oct '15

On 17 Oct 2015, at 16:35, Anton Baskanov wrote: > +static void test_system_palette_entries() You're missing a 'void' inside the parenthesis. Otherwise, this looks good. Huw.

1 0

Re: [PATCH] dpnet: Add Server tests
by Stefan Dösinger 19 Oct '15

19 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, My apologies for the late review. I've been sick the past days and also had to put a lot of attention towards other stuff. Am 2015-10-13 um 11:05 schrieb Alistair Leslie-Hughes: > +static const WCHAR localhost[] = {'1','2','7','.','0','.','0','.','1',0}; Minor nitpick: Is there a reason why you use "127.0.0.1" instead of "localhost"? > +static int destroy_dnt = 0; What does "dnt" stand for? > +static HRESULT WINAPI DirectPlayMessageHandler(void *pvUserContext, DWORD dwMessageId, void *pMsgBuffer) You got rid of CamelCase in the global variables. Please do it here as well and call the function direct_play_message_handler or similar. Also avoid things like dwThisIsADword and pDidIMentionThisIsaPointer. > + case DPN_MSGID_INDICATE_CONNECT: > + trace("DPN_MSGID_CREATE_PLAYER\n"); Copy-paste mistake. > +static HRESULT WINAPI DirectPlayClientMsHandler(void *context, DWORD dwMessageId, void *buffer) "MsHandler"? > +{ > + HRESULT hr; > + > + switch(dwMessageId) > + { > + case DPN_MSGID_ENUM_HOSTS_RESPONSE: > + { > + DPNMSG_ENUM_HOSTS_RESPONSE *host_msg; > + host_msg = (PDPNMSG_ENUM_HOSTS_RESPONSE)buffer; PDPNMSG_ENUM_HOSTS_RESPONSE -> DPNMSG_ENUM_HOSTS_RESPONSE * please. > + memset(&hostdesc, 0, sizeof(DPN_APPLICATION_DESC)); You can use sizeof(hostdesc) instead of sizeof(DPN_APPLICATION_DESC) here. > + memcpy(&hostdesc, host_msg->pApplicationDescription, sizeof(DPN_APPLICATION_DESC) ); Same. > + hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); > + ok(hr == S_OK, "CoCreateInstance failed with 0x%x\n", hr); > + if(hr != S_OK) > + return; You don't need the if() check here. If CoCreateInstance fails the test already failed and you can just let it crash. > + memset( &appdesc, 0, sizeof(DPN_APPLICATION_DESC) ); > + appdesc.dwSize = sizeof( DPN_APPLICATION_DESC ); > + appdesc.guidApplication = appguid; > + > + connect = CreateEventA( NULL, TRUE, FALSE, NULL); > + hostenum = CreateEventA( NULL, TRUE, FALSE, NULL); Inconsistent parenthesis placement. It seems the code was copypasted together from other places. > + hr = IDirectPlay8Client_Initialize(client, NULL, DirectPlayClientMsHandler, 0); > + ok(hr == S_OK, "IDirectPlay8Client_Initialize failed with %x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&host); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(host, &CLSID_DP8SP_TCPIP); > + ok(hr == S_OK, "IDirectPlay8Address_SetSP failed with 0x%08x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&device); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); You're using LPCRAP here again. I think you're not making any productive use of the address object you create here and you're leaking it. Later on you're creating a separate address and overwrite this one. > + hr = IDirectPlay8Address_AddComponent(host, DPNA_KEY_HOSTNAME, localhost, sizeof(localhost), > + DPNA_DATATYPE_STRING); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); This is obviously something for a different patch / test, but do you know how the various components play together with the service provider? I'd assume that a Serial or Modem service provider requires different components than the TCPIP service provider. > @@ -109,5 +269,9 @@ START_TEST(server) > > create_server(); > > + create_client(); > + > + cleanup(); It is difficult to see what is going on by just reading the main function of the test. create_foo() and cleanup() suggest that they create / destroy helper objects, but all of them do a serious amount of testing. You cannot disable the tests separately without breaking the entire test. I'd suggest to have helper functions that create server and client and one enumeration test, a test for connecting to a server, ..., and call the creation functions in each individual test, similar to how e.g. create_device() is working in various d3d tests. This makes this patch more complicated, but it will be very helpful in the long run when more tests are added that need fresh objects. Sooner or later you'll also want to be able to disable individual tests for debugging and / or faster execution times if you work on a new test. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWJSi7AAoJEN0/YqbEcdMwz3sP/ArVZHXjUMVD45/bGbqJ7ZIX oKYP/GTHEBVJtA3EICapjIhN/92intcsQxtjYy0sK5ol4U2Yeg3HDon/PTSihEgC oK0cr1Jf8Z1lN7+kuIgDc4agMrW7UxAhBuJ4CqMFsOkLFbuem30VXnFj+/1VhCRC zYqhirihyFyH+8ac4g6kQLJBnPP5gtJ3YKbDYoE+LM0wF1eIUTfvcEuMfxp8tF4s gO4k7fpjvOzrf7J/z1MK/J+1OUQxvyGPp+HikZ8ZUXD16A6Dqwc7nATL3f+wMV85 JICLuXiyqV7slnkb0A2rIbMIM2Y5cF7pHAjz08thGYSWno+wJFXAcGtH12JPT1uD 61XQfh/lPZKXgeJRKwpwq3meztVVxzb1V4mfQsNWvi81nzEnu2VRvs8PZqAyR09E vU7yFNXq/cDikRN9NrtX/tTv7ZaHwM1HwZVqGzA+mB4vlQ8pApzycYLQh1sOVQRm g39eSq2qNx/7pk53G7Chxm/8sQ3Xa7s5D0F7PqvDTxlXA0xo8Q1r3+zH/NQDGvS8 UsKz0br6rRFdArpyzv9VUxF2Ynn+xig25JPk0ofbJx90H677kAJJ2QMyik4DOWGb sojlCQ0n9W5zR1kY3mbNWxa6mFiBsnexvoJ+eSiqnybkc+b+SDz1vJrSsOcKp1ys XUIIuCpcMtvVp85zcZG3 =/XJU -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/5] winepulse: Add format and period probing
by Alexandre Julliard 19 Oct '15

19 Oct '15

Andrew Eikum <aeikum(a)codeweavers.com> writes: > From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > dlls/winepulse.drv/mmdevdrv.c | 128 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 128 insertions(+) It breaks the tests here: ../../../tools/runtest -q -P wine -T ../../.. -M devenum.dll -p devenum_test.exe.so devenum && touch devenum.ok wine: Unhandled page fault on execute access to 0x7dd57d70 at address 0x7dd57d70 (thread 0026), starting debugger... Unhandled exception: page fault on execute access to 0x7dd57d70 in 32-bit code (0x7dd57d70). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7dd57d70 ESP:0053e900 EBP:0053e928 EFLAGS:00010206( R- -- I - -P- ) EAX:00000000 EBX:7dd64260 ECX:00000087 EDX:7dd64830 ESI:7d6004b8 EDI:7dd64830 Stack dump: 0x0053e900: 7dd64830 0053e942 0000000a 7dce2a74 0x0053e910: 7d6004f8 7d6007f0 7dd57d5b 7dd1a000 0x0053e920: 7d6004b8 00000000 7dd57d50 7dce26d2 0x0053e930: 7d604e40 00000003 ffffffff 00000000 0x0053e940: 575704b8 57575757 0000009c 25aac200 0x0053e950: 0053e9e8 00000801 7dce2629 7dd1a000 Backtrace: =>0 0x7dd57d70 (0x0053e928) 1 0x7dce26d2 pa_mainloop_poll+0xb1() in libpulse.so.0 (0x7dd57d50) 2 0x7dce2def pa_mainloop_iterate+0x3e() in libpulse.so.0 (0x0053e9e8) 3 0x7dce2eac pa_mainloop_run+0x2b() in libpulse.so.0 (0x0053e9e8) 4 0x7dd57d18 (0x0053e9e8) 5 0x7bc7ea60 call_thread_func_wrapper+0xb() in ntdll (0x0053ea08) 6 0x7bc817cf call_thread_func+0xde(entry=0x7dd57cb0, arg=0x0(nil), frame=0x53eb08) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2732] in ntdll (0x0053eae8) 7 0x7bc7ea3e call_thread_entry_point+0x11() in ntdll (0x0053eb08) 8 0x7bc89483 start_thread+0xa2(info=0x7ffd4fb8) [/home/julliard/wine/wine/dlls/ntdll/thread.c:449] in ntdll (0x0053f358) 9 0xf755defb start_thread+0xca() in libpthread.so.0 (0x0053f428) 0x7dd57d70: -- no code accessible -- Modules: Module Address Debug info Name (108 modules) ELF 7b800000-7ba60000 Deferred kernel32<elf> \-PE 7b810000-7ba60000 \ kernel32 ELF 7bc00000-7bcec000 Dwarf ntdll<elf> \-PE 7bc10000-7bcec000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7d4f4000-7d600000 Deferred libasound.so.2 ELF 7d764000-7d794000 Deferred winealsa<elf> \-PE 7d770000-7d794000 \ winealsa ELF 7d794000-7d7c1000 Deferred libvorbis.so.0 ELF 7d7c1000-7d7ca000 Deferred libogg.so.0 ELF 7d7ca000-7d7df000 Deferred libgpg-error.so.0 ELF 7d7df000-7d852000 Deferred libpcre.so.3 ELF 7d852000-7d8de000 Deferred libvorbisenc.so.2 ELF 7d8de000-7d93f000 Deferred libflac.so.8 ELF 7d93f000-7d95c000 Deferred libgcc_s.so.1 ELF 7d95c000-7da0d000 Deferred libgcrypt.so.20 ELF 7da0d000-7da36000 Deferred liblzma.so.5 ELF 7da36000-7da4d000 Deferred libresolv.so.2 ELF 7da4d000-7da75000 Deferred libselinux.so.1 ELF 7da75000-7da7b000 Deferred libuuid.so.1 ELF 7da7b000-7da81000 Deferred libattr.so.1 ELF 7da81000-7da88000 Deferred libasyncns.so.0 ELF 7da88000-7db01000 Deferred libsndfile.so.1 ELF 7db01000-7db0b000 Deferred libwrap.so.0 ELF 7db0b000-7db97000 Deferred libsystemd.so.0 ELF 7db97000-7db9f000 Deferred libxtst.so.6 ELF 7db9f000-7dba9000 Deferred libsm.so.6 ELF 7dba9000-7dbc6000 Deferred libice.so.6 ELF 7dbc6000-7dbcf000 Deferred librt.so.1 ELF 7dbcf000-7dc2b000 Deferred libdbus-1.so.3 ELF 7dc2b000-7dcb5000 Deferred libpulsecommon-7.0.so ELF 7dcb5000-7dcc1000 Deferred libjson-c.so.2 ELF 7dcc1000-7dd1b000 Dwarf libpulse.so.0 ELF 7dd65000-7dd87000 Deferred mmdevapi<elf> \-PE 7dd70000-7dd87000 \ mmdevapi ELF 7dd87000-7ddbd000 Deferred uxtheme<elf> \-PE 7dd90000-7ddbd000 \ uxtheme ELF 7ddbd000-7de32000 Deferred shlwapi<elf> \-PE 7ddd0000-7de32000 \ shlwapi ELF 7de32000-7df2a000 Deferred comctl32<elf> \-PE 7de40000-7df2a000 \ comctl32 ELF 7df2a000-7df74000 Deferred dsound<elf> \-PE 7df30000-7df74000 \ dsound ELF 7df74000-7e061000 Deferred quartz<elf> \-PE 7df90000-7e061000 \ quartz ELF 7e061000-7e117000 Deferred winmm<elf> \-PE 7e070000-7e117000 \ winmm ELF 7e172000-7e175000 Deferred libx11-xcb.so.1 ELF 7e175000-7e19e000 Deferred msvfw32<elf> \-PE 7e180000-7e19e000 \ msvfw32 ELF 7e19e000-7e1c7000 Deferred msacm32<elf> \-PE 7e1a0000-7e1c7000 \ msacm32 ELF 7e1c7000-7e1db000 Deferred avicap32<elf> \-PE 7e1d0000-7e1db000 \ avicap32 ELF 7e1db000-7e202000 Deferred devenum<elf> \-PE 7e1e0000-7e202000 \ devenum ELF 7e224000-7e22b000 Deferred libxfixes.so.3 ELF 7e22b000-7e237000 Deferred libxcursor.so.1 ELF 7e237000-7e24a000 Deferred libxi.so.6 ELF 7e24a000-7e24e000 Deferred libxcomposite.so.1 ELF 7e24e000-7e25b000 Deferred libxrandr.so.2 ELF 7e25b000-7e267000 Deferred libxrender.so.1 ELF 7e267000-7e26e000 Deferred libxxf86vm.so.1 ELF 7e26e000-7e272000 Deferred libxinerama.so.1 ELF 7e272000-7e279000 Deferred libxdmcp.so.6 ELF 7e279000-7e27d000 Deferred libxau.so.6 ELF 7e27d000-7e2a3000 Deferred libxcb.so.1 ELF 7e2a3000-7e3f5000 Deferred libx11.so.6 ELF 7e3f5000-7e40a000 Deferred libxext.so.6 ELF 7e40a000-7e410000 Deferred libcap.so.2 ELF 7e434000-7e4c0000 Deferred winex11<elf> \-PE 7e440000-7e4c0000 \ winex11 ELF 7e4c0000-7e4e3000 Deferred imm32<elf> \-PE 7e4d0000-7e4e3000 \ imm32 ELF 7e5c3000-7e5ed000 Deferred libexpat.so.1 ELF 7e5ed000-7e62f000 Deferred libfontconfig.so.1 ELF 7e62f000-7e65c000 Deferred libpng12.so.0 ELF 7e65c000-7e679000 Deferred libz.so.1 ELF 7e679000-7e728000 Deferred libfreetype.so.6 ELF 7e728000-7e74c000 Deferred libtinfo.so.5 ELF 7e74c000-7e772000 Deferred libncurses.so.5 ELF 7e79c000-7e81a000 Deferred rpcrt4<elf> \-PE 7e7b0000-7e81a000 \ rpcrt4 ELF 7e81a000-7e833000 Deferred version<elf> \-PE 7e820000-7e833000 \ version ELF 7e833000-7e94a000 Deferred gdi32<elf> \-PE 7e840000-7e94a000 \ gdi32 ELF 7e94a000-7ea97000 Deferred user32<elf> \-PE 7e960000-7ea97000 \ user32 ELF 7ea97000-7eb0a000 Deferred advapi32<elf> \-PE 7eaa0000-7eb0a000 \ advapi32 ELF 7eb0a000-7ec3c000 Deferred ole32<elf> \-PE 7eb20000-7ec3c000 \ ole32 ELF 7ec3c000-7ed69000 Deferred oleaut32<elf> \-PE 7ec50000-7ed69000 \ oleaut32 ELF 7ef69000-7ef76000 Deferred libnss_files.so.2 ELF 7ef76000-7ef90000 Deferred libnsl.so.1 ELF 7ef90000-7efd6000 Deferred libm.so.6 ELF 7efe8000-7f000000 Deferred devenum_test<elf> \-PE 7eff0000-7f000000 \ devenum_test ELF f73a6000-f73ab000 Deferred libdl.so.2 ELF f73ab000-f7556000 Dwarf libc.so.6 ELF f7557000-f7573000 Dwarf libpthread.so.0 ELF f7574000-f7580000 Deferred libnss_nis.so.2 ELF f7594000-f759d000 Deferred libnss_compat.so.2 ELF f759d000-f7753000 Dwarf libwine.so.1 ELF f7755000-f7777000 Deferred ld-linux.so.2 ELF f7777000-f7778000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\julliard\wine\wine\dlls\devenum\tests\devenum_test.exe 00000028 0 00000027 0 00000026 0 <== 00000009 0 0000000e services.exe 0000001e 0 0000001d 0 00000017 0 00000016 0 00000014 0 00000010 0 0000000f 0 00000012 winedevice.exe 0000001c 0 00000019 0 00000018 0 00000013 0 0000001a plugplay.exe 00000020 0 0000001f 0 0000001b 0 00000021 explorer.exe 00000025 0 00000024 0 00000023 0 00000022 0 System information: Wine build: wine-1.7.53-39-g51c5fea1f275 Platform: i386 Host system: Linux Host version: 3.16.0-4-amd64 Makefile:161: recipe for target 'devenum.ok' failed make: *** [devenum.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] hidclass.sys: fixed size passed IOCTL_HID_GET_INPUT_REPORT (Coverity)
by Sebastian Lackner 19 Oct '15

19 Oct '15

On 17.10.2015 14:52, Marcus Meissner wrote: > 1327477 Wrong sizeof argument > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c > index e7e7e11..dcc7d3c 100644 > --- a/dlls/hidclass.sys/device.c > +++ b/dlls/hidclass.sys/device.c > @@ -277,7 +277,7 @@ static DWORD CALLBACK hid_device_thread(void *args) > packet->reportId = 0; > > irp = IoBuildDeviceIoControlRequest(IOCTL_HID_GET_INPUT_REPORT, > - device, NULL, 0, packet, sizeof(packet), TRUE, events[0], > + device, NULL, 0, packet, sizeof(*packet)+ext->preparseData->caps.InputReportByteLength, TRUE, events[0], > &irp_status); > > irpsp = IoGetNextIrpStackLocation(irp); > This looks wrong, you have to allocate a separate buffer, and then copy it (like in the code below). I don't know why some of these buffers are HEAP_ZERO_MEMORY though, and others not? Adding Aric, he might want to review this part again, especially since Coverity detected more issues in this code (unnecessary assignment of "rc" for example).

4 8

Re: [PATCH v4] Remove whitespaces and tabs
by Frédéric Delanoy 19 Oct '15

19 Oct '15

On Sun, Oct 18, 2015 at 11:44 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Supersedes 115416 As a general rule, pure whitespace patches are not accepted. No point sending them over and over. Frédéric Delanoy

5 4

Re: wined3d: Recognize Radeon HD 3850 AGP
by Henri Verbeet 19 Oct '15

19 Oct '15

Did you test this? You don't add anything that matches CARD_AMD_RADEON_HD3850.

1 0

Re: [PATCH 2/5] d3d11: Implement d3d10_device_CreateShaderResourceView1().
by Henri Verbeet 19 Oct '15

19 Oct '15

On 19 October 2015 at 01:41, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static HRESULT STDMETHODCALLTYPE d3d10_device_CreateShaderResourceView1(ID3D10Device1 *iface, > + ID3D10Resource *resource, const D3D10_SHADER_RESOURCE_VIEW_DESC1 *desc, ID3D10ShaderResourceView1 **view); Things like this are always a bit awkward because on the one hand you'd like to preserve the vtbl order, while on the other you'd like to avoid forward declarations. I think it's better to just move the implementation of d3d10_device_CreateShaderResourceView1() to be above d3d10_device_CreateShaderResourceView().

1 0

Re: [RFC PATCH 2/2] vcruntime140: Add the new MSVC 2015 compiler specific DLL.
by Nikolay Sivov 19 Oct '15

19 Oct '15

On 18.10.2015 22:20, Martin Storsjo wrote: > +EXTRADEFS = -D_MT -D_MSVCR_VER=140 -DVCRUNTIME Is it not enough to have MSVCR_VER only? E.g. is it possible to have MSVCR_VER defined to 140 and undefined VCRUNTIME at the same time? > + case DLL_PROCESS_ATTACH: > +// msvcrt_init_exception(hinstDLL); > + if(!msvcrt_init_tls()) { Debug leftovers? > diff --git a/dlls/msvcrt/main-vcruntime.c b/dlls/msvcrt/main-vcruntime.c > new file mode 100644 > index 0000000..ccbe6a9 > --- /dev/null > +++ b/dlls/msvcrt/main-vcruntime.c This looks like a workaround to me. Will it work to duplicate this in vcruntime140 or consolidate it in some way making it usable from msvcrt and vcruntime*?

2 3

Re: patches: Make Author and Reviewer titles centered
by Nikolay Sivov 19 Oct '15

19 Oct '15

I'm not sure if it's better when centered to be honest. I personally find it easier to read when names are left aligned, same as with subject field. Other fields have limited number of possible values (or fixed char length for a long period of time), so it's not that jumpy when centered. In any case looks like Reviewer fields uses same 'author' class, so only that need changes to do what you want.

2 1

Re: [PATCH 4/5] ddraw: Accept all 3 versions of D3DFINDDEVICERESULT
by Stefan Dösinger 18 Oct '15

18 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-04 um 19:52 schrieb Andrew D'Addesio: > + /* Write ddHwDesc */ > + desc_ptr = (BYTE*)&fdr->ddHwDesc; > + memcpy(desc_ptr, &desc1, desc_size); > + ((D3DDEVICEDESC*)desc_ptr)->dwSize = desc_size; > + > + /* Write ddSwDesc */ > + desc_ptr += desc_size; > + memcpy(desc_ptr, &desc1, desc_size); > + ((D3DDEVICEDESC*)desc_ptr)->dwSize = desc_size; Is there a nicer way? I can't think of one to be honest, but this code feels somewhat unsatisfying. Also I guess we're lucky that all versions of D3DDEVICEDESC have a DWORD-aligned size, so we don't have to worry about padding between them. Native ddraw doesn't support d3d in 64 bit. Ours does though, mostly out of laziness. Did you run the test in a 64 bit build? It might fail due to different struct alignment. > + /* Invalid D3DDEVICEDESC sizes should fail */ > + search.dwSize = sizeof(search); > + search.dwFlags = 0; > + clear_device_result(&result, (D3D1_DESC_SIZE-4), (D3D1_DESC_SIZE-4)); > hr = IDirect3D_FindDevice(Direct3D1, &search, &result); > - ok(hr == D3D_OK, > - "Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", hr); > + ok(hr == DDERR_INVALIDPARAMS, > + "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); What happens when you use something between D3D1_DESC_SIZE and D3D2_DESC_SIZE, or e.g. the largest size + 4? I recommend to put the valid and invalid tests in a table together with an expect HRESULT. That way you don't have to duplicate the structure assignment code + FindDevice call and can just iterate over the table. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWEiUOAAoJEN0/YqbEcdMwTCgP/AqlzZ9yyJktv2U+OTgxVGTU 9tj/ZbsKIVk7S0FQFDvyUaKCmP7CcYH+ARoJapn7it6peMdNKHB7zbAgsR7koWph hKECmx+xJ4w4Fjvkj159XYL28DokEHqDmZeaeghwldPbCcXTMO5BulJrooO5F1MI Q2/lwhr+pOO3EDOlLvvLntrOszuYJdy0CbWB34ORlV0PQfk/7Wwm+9rkDzVTDS4r xnpNAzEPaFHNrlhmXlaoFa6arsKTILcwhpmt6wzXTMhcyGs8NRcHA1F5lgIbnH3X m6q84FI5Law/epfKwJSyXTI1eDdWB0PKGqw+xEUv4T79q8oRVRe+W/Sjvq9bluEa fDYshHOP2uVRQ0kcObqSTx9iOWW9RtCdTdHxhloHDOOPIAJyxyoENOkYV/5V+QBT P3pKUG9qjNFODFxQvHb6rvbUisVUXGPihC1fbdAkoNYD4Mf2V5rZ+K88RgXQmofS +zbxziLAr6ItmeCw4/nAvt3/8HoQAtWkF7Bb6ZxhtViOzRraNkLvjqPtJ1HAmz8F TueLADA2bRXpGmkW+9bjLbQ0Z6aK2fqQHYy4Rmkt1LJwGSqrMz5ctq63XChZgA+G +c2OXfvcC+zJsVfLxFHmPjPv1eQ0CQ3gyssjRVGPXq9JAQNHqJxm4ldK5e/dJcTS VBxzcIjMMFVLld6a+dS5 =TBrC -----END PGP SIGNATURE-----

3 5

Re: msrle32/tests: Add uncompressed video tests using MRLE as codec (try 2)
by Nikolay Sivov 18 Oct '15

18 Oct '15

On 18.10.2015 19:47, Bruno Jesus wrote: > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > > try 2: > Create the required video file on runtime, I squeezed the avi file as > much as I could to make it still functional. I don't think blob in sources is better. Clean way is to have a separate avi file, compile it as resource, and create temporary file from resource. That's how it's already done in qedit/tests, and in gdi32/dwrite for font files. And of course ideally it should be as small as possible, that has improved significantly from try1 (~450 bytes vs 20K). > > original: > While studying bug https://bugs.winehq.org/show_bug.cgi?id=33022 I > noticed that the game mouse cursors are stored in an uncompressed AVI > file, wine currently is not able to process such videos as ICLocate > will fail without finding a valid codec. > > Windows always returns the MRLE codec in such cases so this test opens > an uncompressed video and use explicitly MRLE to check if it is able > to decompress the video and it does. > > > >

1 0

Re: msrle32/tests: Add uncompressed video tests using MRLE as codec (try 2)
by Marvin 18 Oct '15

18 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17431 Your paranoid android. === w8 (32 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w864 (32 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w1064 (32 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w864 (64 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w1064 (64 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data

1 0

Undocumented Toolbar common control message is now documented by Microsoft
by Alan Feldman 18 Oct '15

18 Oct '15

Hello Wine developers, I don't know if you guys are interested in this or not, but I figured I'd let you know that Microsoft has now documented one of the undocumented toolbar messages. include/commctrl.h (Wine) #define TB_UNKWN45D (WM_USER + 93) include\um\commctrl.h (Windows) #define TB_SETBOUNDINGSIZE (WM_USER + 93) TB_SETBOUNDINGSIZE message https://msdn.microsoft.com/en-us/library/ee663584(v=vs.85).aspx << Sets the bounding size for a multi-column toolbar control. >> That would mean you could also make the corresponding changes to this code as well: dlls/comctl32/toolbar.c case TB_UNKWN45D: return TOOLBAR_Unkwn45D(hwnd, wParam, lParam); /* UNDOCUMENTED MESSAGE: This appears to set some kind of size. Perhaps it * is the maximum size of the toolbar? */ static LRESULT TOOLBAR_Unkwn45D(HWND hwnd, WPARAM wParam, LPARAM lParam) Anyway, just figured I'd share that with you guys. Cheers, Alan Feldman

2 1

Re: fltmgr.sys: add FltInitializePushLock stub (try 3)
by Dmitry Timoshkov 17 Oct '15

17 Oct '15

Austin English <austinenglish(a)gmail.com> wrote: > +void WINAPI FltInitializePushLock(EX_PUSH_LOCK *lock) > +{ > + FIXME("(%p): stub\n", lock); > +} > diff --git a/include/ddk/ntifs.h b/include/ddk/ntifs.h > index a8d90a1..8d22d41 100644 > --- a/include/ddk/ntifs.h > +++ b/include/ddk/ntifs.h > @@ -19,6 +19,9 @@ > #ifndef __NTIFS_H__ > #define __NTIFS_H__ > > +#define EX_PUSH_LOCK ULONG_PTR > +#define PEX_PUSH_LOCK PULONG_PTR I'd guess that's not what Alexandre meant with an opaque pointer (anyway 'ULONG_PTR *' and 'ULONG_PTR' are two different things, not sure what you tried to achieve with any of them), you may try with 'void *' instead. -- Dmitry.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel