- wine-devel - winehq.org

Re: [PATCH 7/7] d3d11/tests: Add test for device interfaces.
by Henri Verbeet 20 Aug '15

20 Aug '15

On 20 August 2015 at 01:48, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + hr = ID3D11Device_QueryInterface(device, &IID_ID3D10Device1, (void **)&iface); > + todo_wine ok(hr == E_NOINTERFACE, "Device should not ID3D10Device1 interface, hr %#x.\n", hr); I think you're missing an "implement" here.

1 0

Re: [PATCH 2/7] d3d11: Rename d3d10_device to d3d_device.
by Henri Verbeet 20 Aug '15

20 Aug '15

On 20 August 2015 at 01:47, Józef Kucia <jkucia(a)codeweavers.com> wrote: > --- I think this is fine, but it doesn't need to be in the middle of the series, you can do it either before or after moving the implementation to d3d11.

1 0

Re: [PATCH 1/7] d3d11: Move d3d10core to d3d11.
by Henri Verbeet 20 Aug '15

20 Aug '15

On 20 August 2015 at 01:47, Józef Kucia <jkucia(a)codeweavers.com> wrote: > -#include "d3d10core_private.h" > +#include "d3d11_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d10core); I think you should rename the debug channel as well. I don't think we need layer.c.

1 0

Re: [3/4] ntdll: Implement FileRenameInformation support.
by Alexandre Julliard 20 Aug '15

20 Aug '15

Sebastian Lackner <sebastian(a)fds-team.de> writes: > --- > dlls/ntdll/file.c | 44 ++++++++++++++++++ > dlls/ntdll/tests/file.c | 76 +++++++++++++++++-------------- > server/fd.c | 115 ++++++++++++++++++++++++++++++++++++++++++++++-- > server/protocol.def | 8 +++ > 4 files changed, 205 insertions(+), 38 deletions(-) You need to validate the path name, probably the same way create_file() does. Also I think it would be cleaner with a separate request. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Implement 'echo/'
by Marvin 20 Aug '15

20 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16108 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 716 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 726 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 735 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 739 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 745 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 746 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 747 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 748 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 761 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 762 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 763 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 764 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 783 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 784 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 785 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 786 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 787 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 788 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 789 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 790 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 791 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 792 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 793 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 794 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 795 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 796 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 797 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 798 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 799 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1383 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1384 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1385 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1386 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1387 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1388 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1389 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1390 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1392 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1395 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1396 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1397 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1398 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1399 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1400 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1401 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === w2003std (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 716 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 726 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 735 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 739 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 745 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 746 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 747 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 748 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 761 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 762 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 763 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 764 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 783 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 784 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 785 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 786 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 787 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 788 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 789 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 790 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 791 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 792 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 793 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 794 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 795 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 796 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 797 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 798 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 799 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1383 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1384 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1385 (got 'C:\Documents and Settings\Administrator\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1386 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1387 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1388 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1389 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1390 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1392 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1395 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1396 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1397 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1398 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1399 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1400 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1401 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === wvistau64 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 334 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 334 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 334 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: [PATCH 4/4] ieframe: Fixed and improved navigation command state tests.
by Marvin 20 Aug '15

20 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16093 Your paranoid android. === w2000pro (32 bit webbrowser) === webbrowser.c:2970: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEBACK_FALSE webbrowser.c:2975: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEFORWARD_FALSE webbrowser.c:2970: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEBACK_FALSE webbrowser.c:2975: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEFORWARD_FALSE webbrowser.c:2970: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEBACK_FALSE webbrowser.c:2975: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEFORWARD_FALSE

1 0

Re: msi: Only remove environment strings that were added on install.
by Marvin 20 Aug '15

20 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16087 Your paranoid android. === w7u (32 bit action) === The test timed out === w8 (32 bit action) === The test timed out

1 0

Re: Assorted spelling and typos fixes (resend)
by Marvin 19 Aug '15

19 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16085 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:485: Test failed: 42: Wrong exception address 7751ED97/002C0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003F0000/003F0001 exception: unhandled exception 80000004 at 003F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/003F0001 === w8 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 005D0000/005D0001 exception: unhandled exception 80000004 at 005D0000 exception.c:485: Test failed: 42: Wrong exception address 77174D17/005D0001

1 0

Re: [PATCH] ucrtbase: Add the new universal CRT DLL.
by Martin Storsjö 19 Aug '15

19 Aug '15

On Thu, 13 Aug 2015, Martin Storsjo wrote: > Since MSVC 2015/Windows 10, the C runtime has now been split into two > parts, ucrtbase, which is the generic C runtime which is now considered > a system component (in Windows 10, and as an extra installed runtime > component for older Windows version), and vcruntimeX which is specific > to the compiler version. > > This uses the msvcrt implementation, just like the earlier msvcr* DLLs. > > Functions with names that existed in msvcr120 are hooked up so far. > --- > This is based on ucrtbase.dll from Windows 10 RTM. > > Sending this as a standalone patch, with the other pieces coming > in smaller bunches once this is applied. > --- > configure.ac | 1 + > dlls/ucrtbase/Makefile.in | 33 + > dlls/ucrtbase/ucrtbase.spec | 2542 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 2576 insertions(+) > create mode 100644 dlls/ucrtbase/Makefile.in > create mode 100644 dlls/ucrtbase/ucrtbase.spec Any further comments on this? I resent it as a single patch without the rest of the patchset, as suggested on IRC, but still haven't seen any comment on it. // Martin

1 0

Re: Assorted spelling and typos fixes (resend)
by Marvin 19 Aug '15

19 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16084 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004230EA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004230EA === wxppro (32 bit marshal) === marshal.c:3054: Test failed: wait timed out marshal.c:3058: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00420B8C === w2003std (32 bit marshal) === marshal.c:3054: Test failed: wait timed out marshal.c:3058: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00420B8C === w8 (32 bit marshal) === marshal.c:3315: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3332: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3370: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3388: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3352: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3315: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3332: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3370: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3388: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3352: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3315: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3332: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3370: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3388: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0x320 instead of 0xea8 marshal.c:3352: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0x320 instead of 0xea8

1 0

Re: [tools] winetest: Add Windows 10 to group Win10 (try 2)
by Sebastian Lackner 19 Aug '15

19 Aug '15

On 19.08.2015 18:33, André Hentschel wrote: > diff --git a/winetest/dissect b/winetest/dissect > index cd24fc3..0a99773 100755 > --- a/winetest/dissect > +++ b/winetest/dissect > @@ -207,6 +207,13 @@ if ($plid==1 && $major==4) { > $version = "win8"; > } > } > + } elsif ($major==10) { > + if ($minor == 0) { This looks a bit weird, did you want to remove the "}" in the line before?

1 0

Windows Service + CreateWindowEx
by Robert D Kocisko 19 Aug '15

19 Aug '15

I am attempting to make some tweaks to Wine so it can run a (3rd party) windows service that uses CreateWindowEx, and I'm not sure whether I'm on the right track or not. What is happening is that when the service calls CreateWindowEx, I get this error: Application tried to create a window, but no driver could be loaded. The explorer process failed to start. I traced it down to the following source code line in wine/dlls/user32/driver.c: UINT guid_atom = HandleToULong( GetPropW( hwnd, display_device_guid_propW )); What is happening is that guid_atom returns 0 which ultimately ends up disallowing any connection to a graphics driver. Now it seems to me that the explorer.exe process is supposed to be providing a desktop window and setting that atom value. But if I try to run wine explorer.exe it doesn't make any difference. I am keeping Wine alive by running wine notepad & and I am also running wine services to make sure that the SCM is alive and available for the services. OS: Elementary OS Freya 0.3 Is this something that Wine should support? I have had success getting other 3rd party services to work so it seems that it shouldn't be too difficult to make this work. Could anyone provide guidance on how I should proceed to tweak the code to support this? Or if this is going to be a huge project to make this work I would appreciate knowing that too :). Thanks much, Bob Kocisko

2 2

Re: [PATCH 3/4] d3dx9/tests: Add tests for DDS file format size validation.
by Matteo Bruni 19 Aug '15

19 Aug '15

2015-08-16 22:28 GMT+02:00 Józef Kucia <jkucia(a)codeweavers.com>: > --- > dlls/d3dx9_36/tests/surface.c | 172 ++++++++++++++++++++++++++++-------------- > 1 file changed, 116 insertions(+), 56 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index 7a4dff8..9da3628 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > + { { 32, DDS_PF_RGB, 0, 24, 0xff0000, 0x00ff00, 0x0000ff, 0x000000 }, DDS_MIPMAPCOUNT, 256, 256, 0, 0, 196607, { D3DXERR_INVALIDDATA, 0 } }, > + { { 32, DDS_PF_RGB, 0, 24, 0xff0000, 0x00ff00, 0x0000ff, 0x000000 }, DDS_MIPMAPCOUNT, 256, 256, 0, 0, 196608, { D3D_OK, 1 } }, I would add another test for DDS_MIPMAPCOUNT with a count of 0 but a larger data size. I wonder if 0 actually means something like "as many levels as they fit in the file".

1 0

Re: [1/2] kernel32/tests: Fix compilation with PSDK.
by Michael Stefaniuc 19 Aug '15

19 Aug '15

Hello Dmitry, On 08/19/2015 06:23 AM, Dmitry Timoshkov wrote: > --- > dlls/kernel32/tests/process.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c > index 113ec35..a8abdc1 100644 > --- a/dlls/kernel32/tests/process.c > +++ b/dlls/kernel32/tests/process.c > @@ -2302,7 +2302,7 @@ static void test_TerminateJobObject(void) > > static void test_QueryInformationJobObject(void) > { > - char buf[FIELD_OFFSET(JOBOBJECT_BASIC_PROCESS_ID_LIST, ProcessIdList[5])]; > + char buf[sizeof(JOBOBJECT_BASIC_PROCESS_ID_LIST) + sizeof(ULONG_PTR) * 5]; this change looks odd. Using offsetof (or FIELD_OFFSET) is the standard Wine way of getting the size of a struct with a variable length array. I have done quite a few patches on Alexandre's request that replace sizeof+sizeof*x with offsetof. E.g. 14e20162f9448a648f3973a86e03aea17387c040 Last but not least you're not allocating the same amount of memory: offsetof(struct, field[n]) == sizeof(struct) + (n-1) * sizeof(field) bye michael

2 1

Re: [1/3] comdlg32: Implement SetControlItemState for menu controls.
by Dmitry Timoshkov 19 Aug '15

19 Aug '15

Vincent Povirk <madewokherd(a)gmail.com> wrote: > This required some rethinking because menus and combo boxes don't > provide a way to "hide" items, just remove them, and native always > shows items in the order they were added even when hidden and shown. You can always add an item at a particular position. That should allow implementing hide/show for menus and combo/listboxes pretty easily using standard functionality. -- Dmitry.

2 1

Re: [PATCH 5/5] d3drm: Implement IDirect3DRM{2-3}::CreateDeviceFromClipper.
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16135 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3drm: Implement IDirect3DRMDevice*::GetDirect3DDevice (resend).
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16134 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3drm: Implement IDirect3DRM::CreateDeviceFromClipper.
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16133 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3drm: Implement IDirect3DRM{2-3}::CreateDeviceFromClipper.
by Aaryaman Vasishta 18 Aug '15

18 Aug '15

Please ignore this patchset. Just realized this patchset was already committed 13 hours ago. Is the bot on IRC not working? Cheers, Jam On Wed, Aug 19, 2015 at 12:17 AM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > --- > dlls/d3drm/d3drm.c | 54 > +++++++++++++++++++++++++++++++++++++++++------- > dlls/d3drm/tests/d3drm.c | 36 ++++++++++++++++---------------- > 2 files changed, 64 insertions(+), 26 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index e4cc4fa..61d0a25 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -697,18 +697,24 @@ static HRESULT WINAPI > d3drm2_CreateDeviceFromClipper(IDirect3DRM2 *iface, > IDirectDrawClipper *clipper, GUID *guid, int width, int height, > IDirect3DRMDevice2 **device) > { > - struct d3drm_device *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM2(iface); > + IDirect3DRMDevice3 *device3; > HRESULT hr; > - FIXME("iface %p, clipper %p, guid %s, width %d, height %d, device > %p.\n", > + > + TRACE("iface %p, clipper %p, guid %s, width %d, height %d, device > %p.\n", > iface, clipper, debugstr_guid(guid), width, height, device); > > - hr = d3drm_device_create(&object); > + if (!device) > + return D3DRMERR_BADVALUE; > + *device = NULL; > + hr = IDirect3DRM3_CreateDeviceFromClipper(&d3drm->IDirect3DRM3_iface, > clipper, guid, width, height, &device3); > if (FAILED(hr)) > return hr; > > - *device = IDirect3DRMDevice2_from_impl(object); > + hr = IDirect3DRMDevice3_QueryInterface(device3, > &IID_IDirect3DRMDevice2, (void**)device); > + IDirect3DRMDevice3_Release(device3); > > - return D3DRM_OK; > + return hr; > } > > static HRESULT WINAPI d3drm2_CreateTextureFromSurface(IDirect3DRM2 *iface, > @@ -1103,18 +1109,50 @@ static HRESULT WINAPI > d3drm3_CreateDeviceFromClipper(IDirect3DRM3 *iface, > IDirectDrawClipper *clipper, GUID *guid, int width, int height, > IDirect3DRMDevice3 **device) > { > + struct d3drm *d3drm = impl_from_IDirect3DRM3(iface); > struct d3drm_device *object; > + IDirectDraw *ddraw; > + IDirectDrawSurface *render_target; > HRESULT hr; > - FIXME("iface %p, clipper %p, guid %s, width %d, height %d, device > %p.\n", > + > + TRACE("iface %p, clipper %p, guid %s, width %d, height %d, device > %p.\n", > iface, clipper, debugstr_guid(guid), width, height, device); > > + if (!device) > + return D3DRMERR_BADVALUE; > + *device = NULL; > + > + if (!clipper || !width || !height) > + return D3DRMERR_BADVALUE; > + > + hr = DirectDrawCreate(NULL, &ddraw, NULL); > + if (FAILED(hr)) > + return hr; > + > hr = d3drm_device_create(&object); > if (FAILED(hr)) > + { > + IDirectDraw_Release(ddraw); > return hr; > + } > > - *device = IDirect3DRMDevice3_from_impl(object); > + hr = d3drm_device_create_surfaces_from_clipper(object, ddraw, > clipper, width, height, &render_target); > + if (FAILED(hr)) > + { > + IDirectDraw_Release(ddraw); > + d3drm_device_destroy(object); > + return hr; > + } > > - return D3DRM_OK; > + hr = d3drm_device_init(object, 3, &d3drm->IDirect3DRM_iface, ddraw, > render_target); > + IDirectDraw_Release(ddraw); > + IDirectDrawSurface_Release(render_target); > + if (FAILED(hr)) > + d3drm_device_destroy(object); > + else > + *device = IDirect3DRMDevice3_from_impl(object); > + > + return hr; > } > > static HRESULT WINAPI d3drm3_CreateShadow(IDirect3DRM3 *iface, IUnknown > *object, IDirect3DRMLight *light, > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index c797ccd..2d25bf3 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -2134,7 +2134,7 @@ static void test_create_device_from_clipper2(void) > IDirect3DRM2 *d3drm2 = NULL; > IDirectDraw *ddraw = NULL; > IUnknown *unknown = NULL; > - IDirect3DRMDevice2 *device2 = NULL; > + IDirect3DRMDevice2 *device2 = (IDirect3DRMDevice2 *)0xdeadbeef; > IDirect3DDevice2 *d3ddevice2 = NULL; > IDirectDrawClipper *clipper = NULL, *d3drm_clipper = NULL; > IDirectDrawSurface *surface = NULL, *ds = NULL, *d3drm_primary = NULL; > @@ -2164,24 +2164,24 @@ static void test_create_device_from_clipper2(void) > ref2 = get_refcount((IUnknown *)d3drm2); > > hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, clipper, &driver, > 0, 0, &device2); > - todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == > D3DRMERR_BADVALUE, got %x.\n", hr); > - if (SUCCEEDED(hr)) > - IDirect3DRMDevice2_Release(device2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + ok(device2 == NULL, "Expected device returned == NULL, got %p.\n", > device2); > > /* If NULL is passed for clipper, CreateDeviceFromClipper returns > D3DRMERR_BADVALUE */ > hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, NULL, &driver, 300, > 200, &device2); > - todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == > D3DRMERR_BADVALUE, got %x.\n", hr); > - if (SUCCEEDED(hr)) > - IDirect3DRMDevice2_Release(device2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + > + hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, clipper, &driver, > 300, 200, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > > hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, clipper, &driver, > 300, 200, &device2); > ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice2 interface (hr = > %x).\n", hr); > ref3 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref3 > ref1, "expected ref3 > ref1, got ref1 = %u , ref3 > = %u.\n", ref1, ref3); > + ok(ref3 > ref1, "expected ref3 > ref1, got ref1 = %u , ref3 = %u.\n", > ref1, ref3); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref2, "expected ref3 == ref2, got ref2 = %u , ref3 = > %u.\n", ref2, ref3); > cref2 = get_refcount((IUnknown *)clipper); > - todo_wine ok(cref2 > cref1, "expected cref2 > cref1, got cref1 = %u , > cref2 = %u.\n", cref1, cref2); > + ok(cref2 > cref1, "expected cref2 > cref1, got cref1 = %u , cref2 = > %u.\n", cref1, cref2); > > /* Fetch immediate mode device in order to access render target */ > hr = IDirect3DRMDevice2_GetDirect3DDevice2(device2, &d3ddevice2); > @@ -2322,7 +2322,7 @@ static void test_create_device_from_clipper3(void) > IDirect3DRM3 *d3drm3 = NULL; > IDirectDraw *ddraw = NULL; > IUnknown *unknown = NULL; > - IDirect3DRMDevice3 *device3 = NULL; > + IDirect3DRMDevice3 *device3 = (IDirect3DRMDevice3 *)0xdeadbeef; > IDirect3DDevice2 *d3ddevice2 = NULL; > IDirectDrawClipper *clipper = NULL, *d3drm_clipper = NULL; > IDirectDrawSurface *surface = NULL, *ds = NULL, *d3drm_primary = NULL; > @@ -2352,24 +2352,24 @@ static void test_create_device_from_clipper3(void) > ref2 = get_refcount((IUnknown *)d3drm3); > > hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm3, clipper, &driver, > 0, 0, &device3); > - todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == > D3DRMERR_BADVALUE, got %x.\n", hr); > - if (SUCCEEDED(hr)) > - IDirect3DRMDevice3_Release(device3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + ok(device3 == NULL, "Expected device returned == NULL, got %p.\n", > device3); > > /* If NULL is passed for clipper, CreateDeviceFromClipper returns > D3DRMERR_BADVALUE */ > hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm3, NULL, &driver, 300, > 200, &device3); > - todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == > D3DRMERR_BADVALUE, got %x.\n", hr); > - if (SUCCEEDED(hr)) > - IDirect3DRMDevice3_Release(device3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + > + hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm3, clipper, &driver, > 300, 200, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > > hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm3, clipper, &driver, > 300, 200, &device3); > ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice3 interface (hr = > %x).\n", hr); > ref3 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref3 > ref1, "expected ref3 > ref1, got ref1 = %u , ref3 > = %u.\n", ref1, ref3); > + ok(ref3 > ref1, "expected ref3 > ref1, got ref1 = %u , ref3 = %u.\n", > ref1, ref3); > ref3 = get_refcount((IUnknown *)d3drm3); > ok(ref3 == ref2, "expected ref3 == ref2, got ref2 = %u , ref3 = > %u.\n", ref2, ref3); > cref2 = get_refcount((IUnknown *)clipper); > - todo_wine ok(cref2 > cref1, "expected cref2 > cref1, got cref1 = %u , > cref2 = %u.\n", cref1, cref2); > + ok(cref2 > cref1, "expected cref2 > cref1, got cref1 = %u , cref2 = > %u.\n", cref1, cref2); > > /* Fetch immediate mode device in order to access render target */ > hr = IDirect3DRMDevice3_GetDirect3DDevice2(device3, &d3ddevice2); > -- > 2.3.2 (Apple Git-55) > >

2 2

Re: d3drm: Implement GetDirect3DDevice
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16107 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Implement GetDirect3DDevice2.
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16106 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Implement IDirect3DRM{2-3}::CreateDeviceFromClipper
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16105 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Implement IDirect3DRM::CreateDeviceFromClipper
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16104 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Add version specific tests frr CreateDeviceFrom* methods.
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16103 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromD3D (try 10).
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16102 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Implement GetDirect3DDevice
by Aaryaman Vasishta 18 Aug '15

18 Aug '15

Apologies! All the patches sent this minute were sent by mistake - I'll be sending the proper patch set now. Jam On Tue, Aug 18, 2015 at 7:23 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > --- > dlls/d3drm/device.c | 27 ++++++++++++++++++++++++--- > dlls/d3drm/tests/d3drm.c | 4 ++-- > 2 files changed, 26 insertions(+), 5 deletions(-) > > diff --git a/dlls/d3drm/device.c b/dlls/d3drm/device.c > index b703077..bb8eeae 100644 > --- a/dlls/d3drm/device.c > +++ b/dlls/d3drm/device.c > @@ -418,7 +418,14 @@ static D3DRMTEXTUREQUALITY WINAPI > d3drm_device1_GetTextureQuality(IDirect3DRMDev > > static HRESULT WINAPI d3drm_device1_GetDirect3DDevice(IDirect3DRMDevice > *iface, IDirect3DDevice **d3d_device) > { > - FIXME("iface %p, d3d_device %p stub!\n", iface, d3d_device); > + struct d3drm_device *device = impl_from_IDirect3DRMDevice(iface); > + TRACE("iface %p, d3d_device %p!\n", iface, d3d_device); > + > + if (device->device) > + { > + *d3d_device = device->device; > + return D3DRM_OK; > + } > > return E_NOTIMPL; > } > @@ -772,7 +779,14 @@ static D3DRMTEXTUREQUALITY WINAPI > d3drm_device2_GetTextureQuality(IDirect3DRMDev > > static HRESULT WINAPI d3drm_device2_GetDirect3DDevice(IDirect3DRMDevice2 > *iface, IDirect3DDevice **d3d_device) > { > - FIXME("iface %p, d3d_device %p stub!\n", iface, d3d_device); > + struct d3drm_device *device = impl_from_IDirect3DRMDevice2(iface); > + TRACE("iface %p, d3d_device %p!\n", iface, d3d_device); > + > + if (device->device) > + { > + *d3d_device = device->device; > + return D3DRM_OK; > + } > > return E_NOTIMPL; > } > @@ -1139,7 +1153,14 @@ static D3DRMTEXTUREQUALITY WINAPI > d3drm_device3_GetTextureQuality(IDirect3DRMDev > > static HRESULT WINAPI d3drm_device3_GetDirect3DDevice(IDirect3DRMDevice3 > *iface, IDirect3DDevice **d3d_device) > { > - FIXME("iface %p, d3d_device %p stub!\n", iface, d3d_device); > + struct d3drm_device *device = impl_from_IDirect3DRMDevice3(iface); > + TRACE("iface %p, d3d_device %p!\n", iface, d3d_device); > + > + if (device->device) > + { > + *d3d_device = device->device; > + return D3DRM_OK; > + } > > return E_NOTIMPL; > } > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 959dbc3..4b5cd92 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -2008,7 +2008,7 @@ static void test_create_device_from_clipper1(void) > > /* Fetch immediate mode device in order to access render target */ > hr = IDirect3DRMDevice_GetDirect3DDevice(device1, &d3ddevice1); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface > (hr = %x).\n", hr); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface (hr = > %x).\n", hr); > if (FAILED(hr)) > goto cleanup; > > @@ -2103,7 +2103,7 @@ static void test_create_device_from_clipper1(void) > ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice interface (hr = > %x).\n", hr); > > hr = IDirect3DRMDevice_GetDirect3DDevice(device1, &d3ddevice1); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface > (hr = %x).\n", hr); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface (hr = > %x).\n", hr); > if (FAILED(hr)) > goto cleanup; > > -- > 2.3.2 (Apple Git-55) > >

1 0

Re: tempory patch by slackner
by Aaryaman Vasishta 18 Aug '15

18 Aug '15

My bad, I sent the wrong folder of patches -.- ignore all patches sent this minute please. Jam On Tue, Aug 18, 2015 at 7:23 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > --- > dlls/windowscodecs/icnsformat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/windowscodecs/icnsformat.c > b/dlls/windowscodecs/icnsformat.c > index 54c7707..5d48a1a 100644 > --- a/dlls/windowscodecs/icnsformat.c > +++ b/dlls/windowscodecs/icnsformat.c > @@ -179,7 +179,7 @@ static ULONG WINAPI > IcnsFrameEncode_Release(IWICBitmapFrameEncode *iface) > if (This->icns_image != NULL) > HeapFree(GetProcessHeap(), 0, This->icns_image); > > - > IWICBitmapFrameEncode_Release(&This->encoder->IWICBitmapFrameEncode_iface); > + > IWICBitmapEncoder_Release(&This->encoder->IWICBitmapEncoder_iface); > HeapFree(GetProcessHeap(), 0, This); > } > > -- > 2.3.2 (Apple Git-55) > >

1 0

Re: [PATCH 1/2] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromSurface (try 8).
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16101 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] msvcr120: Implement strtof and _strtof_l (try 3)
by Henri Verbeet 18 Aug '15

18 Aug '15

On 14 August 2015 at 04:44, Bernhard Übelacker <bernhardu(a)vr-web.de> wrote: > + /*strtof*/ > + f = p_strtof(float1, &end); > + ok(compare_float(f, 12.1, 4096), "f = %lf\n", f); Is it really that inaccurate, or did you just copy 4096 from the ddraw tests?

2 4

Re: mshtml: Wine Gecko 2.40 release.
by Austin English 18 Aug '15

18 Aug '15

You forgot to push the tag: http://sourceforge.net/p/wine/wine-gecko/ref/master/tags/ On Tue, Aug 11, 2015 at 8:11 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/appwiz.cpl/addons.c | 6 +- > dlls/mshtml/nsembed.c | 6 +- > dlls/mshtml/nsiface.idl | 114 ++++++++++++++++++++-------------- > dlls/mshtml/nsio.c | 155 > +++++++++++++++++++++++++++++++++++++---------- > 4 files changed, 199 insertions(+), 82 deletions(-) > > > > > -- -Austin

2 2

Re: ntdll: Move cookie initialization code from memory management to loader.
by Dmitry Timoshkov 18 Aug '15

18 Aug '15

Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=39040 > > Manually testing reveals that the security cookie is not initialized by NtMapViewOfSection. > > However, I guess nobody will be surprised, that this testing revealed even more differences. > In fact, the whole relocation logic is implemented at the wrong place, it should also be > moved to the loader to be compatible with modern versions of Windows (tested on Windows 7). Last attempt in trying to get some comments/attention was the following patch (which didn't receive any responce just like previous two e-mails): https://www.winehq.org/pipermail/wine-patches/2012-April/113746.html I'll resend once again if Alexandre is willing to review it it provide some suggestions. Alexandre? -- Dmitry.

2 1

Re: Assorted spelling and typos fixes
by Marvin 18 Aug '15

18 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16053 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 004290B9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004230EA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004230EA === wxppro (32 bit marshal) === marshal.c:3054: Test failed: wait timed out marshal.c:3058: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00420B8C === w2003std (32 bit marshal) === marshal.c:3054: Test failed: wait timed out marshal.c:3058: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00420B8C === w8 (32 bit marshal) === marshal.c:3315: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3332: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3370: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3388: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3352: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3315: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3332: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3370: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3388: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3352: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3315: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3316: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3332: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3333: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3370: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3371: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3388: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3389: Test failed: info->dwServerPid was 0x374 instead of 0xf34 marshal.c:3352: Test failed: info->cbSize was 194370934 instead of 48 marshal.c:3353: Test failed: info->dwServerPid was 0x374 instead of 0xf34

1 0

Re: Assorted spelling and typos fixes
by Marvin 17 Aug '15

17 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16052 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:485: Test failed: 42: Wrong exception address 7751ED97/002C0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003F0000/003F0001 exception: unhandled exception 80000004 at 003F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/003F0001 === w8 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:485: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [PATCH 4/4] msvcp110: Add tr2_sys__Stat_wchar and tr2_sys__Lstat_wchar implementation and test.
by Marvin 17 Aug '15

17 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16062 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] msvcp110: Add tr2_sys__Statvfs_wchar implementation and test.(resend)
by Marvin 17 Aug '15

17 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16061 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] msvcp110: Add tr2_sys__Rename_wchar implementation and test.(resend)
by Marvin 17 Aug '15

17 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16060 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] msvcp110: Add tr2_sys__Copy_file_wchar implementation and test.(try 2)
by Marvin 17 Aug '15

17 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16059 Your paranoid android. === build (build) === Patch failed to apply

1 0

Request for help with running Unreal ED 3.0 in Wine (from developer Running With Scissors)
by Jon M 17 Aug '15

17 Aug '15

Greetings everyone, I work as a project manager and developer for Running with Scissors. We have a game called POSTAL 2 that natively supports Linux and runs on the Unreal 2 engine, and includes modding Steam workshop features. Sadly, the Level editor (based on UnrealED 3.0) is not supported in Linux, and rewriting it to support it natively is out of the question. However, when running the Windows build under Wine, almost everything works perfectly, including navigating the viewports and rebuilding the maps. It’s so close to being perfectly usable as a level editor, with one major caveat - not being able to select actors or surfaces by clicking or access their right click menus to add actors. It is possible select actors with marquee select in the orthographic views, and you are able to add static meshes to a level via the Insert button in the Static Mesh browser. The texture browser also has issues with selection which can be worked around by increasing the size in the View menu. It run a bit slow but well enough for practical use (20 FPS in the viewports on bigger maps on a 2.8ghz CPU). There is a log on the WineHQ database regarding this here which focuses on the UT2004 editor, but the problems are much the same. https://appdb.winehq.org/objectManager.php?sClass=version&iId=4638 Reason I'm interested in this is because, with that one thing fixed, we could use a Wine wrapper and put the SDK up for Linux on Steam and elsewhere. We'd even have it so it hands off to the native Linux version of the game when testing the map from the editor. It would be quite a thing to be one of the few games with a full SDK for Linux on Steam. No one is maintaining this it seems in WineHQ, but there is a a least a chance the fix it needs may not be too hard to work out, so I'm hoping to find someone that's willing to see if they can fix this (and any other problems we come across in QA). Thank you for your time in reading this, Jon

2 3

Re: Assorted spelling and typos fixes
by Henri Verbeet 17 Aug '15

17 Aug '15

On 17 August 2015 at 15:14, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > - TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p," > + TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p,\n" > "\tshader_byte_code_length %lu, input_layout %p\n", This is the same as 113682, same comment applies.

1 0

Implementation patches for d3drm's CreateDeviceFromD3D.
by Aaryaman Vasishta 17 Aug '15

17 Aug '15

Attached is the patches for implementing CreateDeviceFromD3D. Please take a look and provide feedback, if any. Thank you! Aaryaman

2 8

Re: [PATCH 2/2] d3d10core: Add missing \n in trace.
by Henri Verbeet 17 Aug '15

17 Aug '15

On 16 August 2015 at 22:21, Józef Kucia <jkucia(a)codeweavers.com> wrote: > - TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p," > + TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p,\n" > "\tshader_byte_code_length %lu, input_layout %p\n", I'd rather just remove the '\t'. In particular, having newlines in the middle of TRACEs makes it a bit harder to extract all calls from a single thread from a log.

1 0

Re: [PATCH 1/2] includes: Add D3D11CreateDeviceAndSwapChain declaration to d3d11.idl.
by Henri Verbeet 17 Aug '15

17 Aug '15

On 16 August 2015 at 22:21, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +cpp_quote("HRESULT WINAPI D3D11CreateDeviceAndSwapChain(IDXGIAdapter*,D3D_DRIVER_TYPE,HMODULE,UINT,") > +cpp_quote(" const D3D_FEATURE_LEVEL*,UINT,UINT,const DXGI_SWAP_CHAIN_DESC*,IDXGISwapChain**,ID3D11Device**,") > +cpp_quote(" D3D_FEATURE_LEVEL*,ID3D11DeviceContext**);") The existing declarations aren't really helping here, but could you please avoid using cpp_quote and include parameter names?

1 0

Re: [PATCH] shell32: Fix SHFileOperation(FO_MOVE) for creating subdirectories.
by Olivier F. R. Dierick 15 Aug '15

15 Aug '15

Hello, I noticed tests failures in shlfileop while trying to add a new test. The failures were in parts that are not touched by my patches (same errors that you got). I have a patch ready for submission that correct the failures in the existing tests. You may want to wait until I submit my patch and it is committed before submitting your patch again. I'll submit my patch as soon as possible. Regards. Le vendredi 14 août 2015 à 21:18 +0800, Zhenbo Li a écrit : > This patch fixes bug 25207. Seems that a dozen of apps are affected by > this bug, so please tell me how I can improve this patch if this patch > can't be committed directly. > > There will be a test error: > shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR > > It is not related to my patch. > > Hope you enjoy your weekend. > > --- > dlls/shell32/shlfileop.c | 11 +++++++++-- > dlls/shell32/tests/shlfileop.c | 6 +++--- > 2 files changed, 12 insertions(+), 5 deletions(-) > > -- Olivier F. R. Dierick o.dierick(a)piezo-forte.be

2 4

Re: monthcal.c patch.txt
by Nikolay Sivov 15 Aug '15

15 Aug '15

On 14.08.2015 19:54, s.p. wrote: > Countries use different rules for determining week numbers. For the > classic month calendar however, windows seems to ignore the first week > of the year registry setting. The attached file 'patch.txt' addresses > this quirk by simply implementing the rules of ISO8601. Although this > patch works and has been tested, it is not intended as a complete fix. > For that it probably needs some more investigation. Usage: > > > cd wine/dlls/comctl32 > patch monthcal.c < patch.txt > > Greets, sbmpost Hi, what is that registry settings you're talking about? I think I heard about different week numbering used in different countries, what are you using as a test case? I think what we actually want is locale-dependent algorithm for that (but it will require some research and testing, because monthcal could differ from what you'd expect).

1 0

Re: [PATCH 9/9] msvcp110: Add tr2_sys__Unlink implementation and test.
by Marvin 15 Aug '15

15 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16028 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 8/9] msvcp110: Add tr2_sys__Symlink implementation and test.
by Marvin 15 Aug '15

15 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16027 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 7/9] msvcp110: Add tr2_sys__Link implementation and test.
by Marvin 15 Aug '15

15 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16026 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/9] msvcp120/tests: Add test of tr2_sys__Open_dir, tr2_sys__Read_dir and tr2_sys__Close_dir.
by Marvin 15 Aug '15

15 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16025 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/9] msvcp120/tests: Add tr2_sys__Last_write_time test.
by Marvin 15 Aug '15

15 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16024 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/9] msvcp110: Add tr2_sys__Last_write_time implementation and test.
by Marvin 15 Aug '15

15 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16023 Your paranoid android. === build (build) === Patch failed to apply

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel