- wine-devel - winehq.org

Re: shell32/tests: Don't leave behind open explorer windows.
by Marvin 23 Jun '15

23 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14594 Your paranoid android. === w2003std (32 bit progman_dde) === progman_dde.c:377: Test failed: Window "C:\Documents and Settings\All Users\Start Menu\Programs\Group1" was not created in 45 seconds - assumed failure. [S_G:12] === w7u (32 bit progman_dde) === progman_dde.c:519: Test failed: DeleteGroup Group1: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_G:13] === wvistau64 (64 bit progman_dde) === progman_dde.c:571: Test failed: DeleteItem f2g1Name.lnk: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_I:5]

1 0

Re: [PATCH 1/2] user32: Send BM_SETCHECK before WM_CAPTURECHANGED and add tests.
by Marvin 23 Jun '15

23 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14585 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10547: Test failed: expected PeekMessage to return FALSE, got 1

1 0

Re: ntdll: Randomize security cookie when available
by Alexandre Julliard 23 Jun '15

23 Jun '15

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -3620,7 +3620,30 @@ typedef struct _FPO_DATA { > WORD cbFrame : 2; > } FPO_DATA, *PFPO_DATA; > > -typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY { > +typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY64 { > + DWORD Size; > + DWORD TimeDateStamp; > + WORD MajorVersion; > + WORD MinorVersion; > + DWORD GlobalFlagsClear; > + DWORD GlobalFlagsSet; > + DWORD CriticalSectionDefaultTimeout; > + ULONGLONG DeCommitFreeBlockThreshold; > + ULONGLONG DeCommitTotalFreeThreshold; > + ULONGLONG LockPrefixTable; > + ULONGLONG MaximumAllocationSize; > + ULONGLONG VirtualMemoryThreshold; > + ULONGLONG ProcessAffinityMask; > + DWORD ProcessHeapFlags; > + WORD CSDVersion; > + WORD Reserved1; > + ULONGLONG EditList; > + ULONGLONG SecurityCookie; > + ULONGLONG SEHandlerTable; > + ULONGLONG SEHandlerCount; > +} IMAGE_LOAD_CONFIG_DIRECTORY64, *PIMAGE_LOAD_CONFIG_DIRECTORY64; > + > +typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY32 { > DWORD Size; > DWORD TimeDateStamp; > WORD MajorVersion; You'll need to update the generated tests: gcc -c -o generated.o ../../../../wine/dlls/ntdll/tests/generated.c -I. \ -I../../../../wine/dlls/ntdll/tests -I../../../include -I../../../../wine/include -D__WINESRC__ \ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla \ -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -g -O2 -fno-diagnostics-show-caret ../../../../wine/dlls/ntdll/tests/generated.c: In function ‘test_pack_IMAGE_LOAD_CONFIG_DIRECTORY’: ../../../../wine/dlls/ntdll/tests/generated.c:842:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:865:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:866:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:868:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:869:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:870:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:873:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:874:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:875:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:876:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:877:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:878:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:879:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:882:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:883:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:884:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:885:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:888:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:891:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:894:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:895:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:896:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:897:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:898:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:899:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:900:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:901:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:902:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:903:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c: In function ‘test_pack_PIMAGE_LOAD_CONFIG_DIRECTORY’: ../../../../wine/dlls/ntdll/tests/generated.c:2108:5: error: size of unnamed array is negative Makefile:348: recipe for target 'generated.o' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: Fix RegEnumValueW when enumerating long values.
by Bernhard Übelacker 23 Jun '15

23 Jun '15

Hello, please ignore this patch for now. It seems that systemfontfileenumerator_GetCurrentFontFile uses RegEnumValueW in a way not supported on Windows - with giving NULL parameters for value and/or val_count [1]. When RegEnumValueW is called with proper value parameter the problem with not returning correct count would not happen already. So, as far as I see, first all uses of RegEnumValue with NULL parameters for value or val_count need a fix. Kind regards, Bernhard [1] https://testbot.winehq.org/JobDetails.pl?Key=14533

4 5

[7/11]hidclass.sys: Implement HID devices
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/device.c | 560 ++++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 86 +++++++ dlls/hidclass.sys/main.c | 4 + 4 files changed, 651 insertions(+) create mode 100644 dlls/hidclass.sys/device.c

2 2

[2/11]hidclass.sys: add a wine native hid device driver service
by Aric Stewart 22 Jun '15

22 Jun '15

Allow for Minidriver registration --- configure | 2 + configure.ac | 1 + dlls/hidclass.sys/Makefile.in | 8 ++++ dlls/hidclass.sys/hid.h | 53 +++++++++++++++++++++++++ dlls/hidclass.sys/hidclass.sys.spec | 2 + dlls/hidclass.sys/main.c | 78 +++++++++++++++++++++++++++++++++++++ loader/wine.inf.in | 13 +++++++ 7 files changed, 157 insertions(+) create mode 100644 dlls/hidclass.sys/Makefile.in create mode 100644 dlls/hidclass.sys/hid.h create mode 100644 dlls/hidclass.sys/hidclass.sys.spec create mode 100644 dlls/hidclass.sys/main.c

2 2

[9/11]hidclass.sys: Add Plug-and-play interfaces
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hidclass.sys/Makefile.in | 4 +- dlls/hidclass.sys/descriptor.c | 1092 ++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 8 + dlls/hidclass.sys/main.c | 1 + dlls/hidclass.sys/pnp.c | 301 +++++++++++ 5 files changed, 1405 insertions(+), 1 deletion(-) create mode 100644 dlls/hidclass.sys/descriptor.c create mode 100644 dlls/hidclass.sys/pnp.c

2 2

Re: [1/2] msi/tests: Fix test failures on win2k3.
by Marvin 22 Jun '15

22 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14545 Your paranoid android. === wvistau64 (32 bit install) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit install) === The test timed out

1 0

Re: [PATCH 3/5] wined3d: Remove ffp_proj_control flag from the GLSL shader backend.
by Henri Verbeet 22 Jun '15

22 Jun '15

On 19 June 2015 at 00:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Using the GLSL shader backend implies GLSL vp and fp replacements, An argument could perhaps be made that it should, but currently that's not true. You can still use the the GLSL shader backend with e.g. fixed function fragment processing with some level of success. The only reason it doesn't happen much in practice is the way select_vertex_implementation() and select_fragment_implementation() are implemented, but that's external to the shader backend.

3 2

[4/11]hidclass.sys: Implement a report ring buffer
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/buffer.c | 166 ++++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 13 ++++ 3 files changed, 180 insertions(+) create mode 100644 dlls/hidclass.sys/buffer.c

2 1

Re: gdi32/tests: Japanese Win 7 uses MS Shell Dlg as its default GUI font.
by Akihiro Sagawa 22 Jun '15

22 Jun '15

Hello Huw, Could you improve commit c81ff0f8cfc1a7b6fa7546d8ffb656e290ef5e7e? I know this fixes longstanding test failure on Windows 7 testbot running with Japanese locale. But, the change leads to test failures on my Japanese Windows 7: > font.c:5799: Test failed: 4(1): expected height 15, got 12 > font.c:5808: 4(1): default gui font is MS UI Gothic As both systems are running with Japanese locale, I compared my Windows 7 settings with testbot's one. And, I found that testbot returns different GetSystemDefaultUILanguage() value. In other words, testbot returns 0x0409 (English US)[1], but my PC returns 0x0411 (Japanese). [1] https://testbot.winehq.org/JobDetails.pl?Key=14511&log_206=1#k206 I'm not sure if the configuration is on purpose, or not. However, the test needs to be updated on that point. Akihiro Sagawa

3 4

Re: [PATCH (resend)] winealsa: Make string "Unknown sound card" translatable.
by Alexandre Julliard 22 Jun '15

22 Jun '15

Alex Henrie <alexhenrie24(a)gmail.com> writes: > --- > dlls/winealsa.drv/Makefile.in | 4 +++- > dlls/winealsa.drv/mmdevdrv.c | 9 +++++++-- > dlls/winealsa.drv/resource.h | 19 +++++++++++++++++++ > dlls/winealsa.drv/winealsa.rc | 29 +++++++++++++++++++++++++++++ > 4 files changed, 58 insertions(+), 3 deletions(-) > create mode 100644 dlls/winealsa.drv/resource.h > create mode 100644 dlls/winealsa.drv/winealsa.rc Adding translation in drivers doesn't work very well, it needs some more makefile support. It would be better to do this some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winetest: Add SystemDefaultUILanguage setting to OS info.
by Akihiro Sagawa 22 Jun '15

22 Jun '15

On Sun, 21 Jun 2015 14:15:15 +0900, Akihiro Sagawa wrote: > Some of testbots have a different value as expected. And, a certain GDI > function seems to be affected by this setting. So, it's worth to be > logging. > --- > programs/winetest/main.c | 1 + > 1 file changed, 1 insertion(+) Please ignore this patch. I confirmed SystemDefaultUILanguage doesn't affect GDI functions. Akihiro Sagawa

1 0

Re: winedbg: Avoid direct comparison of enum with -1 in packet_set_breakpoint.
by Michael Stefaniuc 22 Jun '15

22 Jun '15

Hello Gerald, On 06/19/2015 11:48 PM, Gerald Pfeifer wrote: > clang 3.4.1 complains as follows when compiling this: > > gdbproxy.c:2147:23: warning: comparison of constant -1 with > expression of type 'enum be_xpoint_type' is always false > > I see two ways to address this: adding a dummy set to -1 to the > enum, or casting the enum to int before comparing against -1. > > The patch below implements the first approach; if you prefer, > I'll provide a patch for the other approach. adding an element be_xpoint_free to the enum is better than a cast. > > Gerald > --- > programs/winedbg/gdbproxy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/programs/winedbg/gdbproxy.c b/programs/winedbg/gdbproxy.c > index dd63f7d..181b32a 100644 > --- a/programs/winedbg/gdbproxy.c > +++ b/programs/winedbg/gdbproxy.c > @@ -2144,7 +2144,7 @@ static enum packet_return packet_set_breakpoint(struct gdb_context* gdbctx) > /* really set the Xpoint */ > for (xpt = &gdbctx->Xpoints[NUM_XPOINT - 1]; xpt >= gdbctx->Xpoints; xpt--) > { > - if (xpt->type == -1) > + if ((int)xpt->type == -1) > { > if (be_cpu->insert_Xpoint(gdbctx->process->handle, > gdbctx->process->process_io, &gdbctx->context, > bye michael

1 0

[11/11]hidclass.sys: Add os x minidriver
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/hid.h | 3 + dlls/hidclass.sys/main.c | 6 + dlls/hidclass.sys/minidriver_osx.c | 546 +++++++++++++++++++++++++++++++++++++ 4 files changed, 556 insertions(+) create mode 100644 dlls/hidclass.sys/minidriver_osx.c

1 0

[10/11]include: add HID_REVISION
by Aric Stewart 22 Jun '15

22 Jun '15

--- include/ddk/hidclass.h | 2 ++ 1 file changed, 2 insertions(+)

1 0

[8/11]include: add IRP_MJ_POWER minor function codes
by Aric Stewart 22 Jun '15

22 Jun '15

--- include/ddk/wdm.h | 5 +++++ 1 file changed, 5 insertions(+)

1 0

[6/11]include: HID_XFER_PACKET to hidclass.h
by Aric Stewart 22 Jun '15

22 Jun '15

--- include/ddk/hidclass.h | 6 ++++++ 1 file changed, 6 insertions(+)

1 0

[5/11]include: new ddk/hidtypes.h include file
by Aric Stewart 22 Jun '15

22 Jun '15

--- include/ddk/hidtypes.h | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 include/ddk/hidtypes.h

1 0

[3/11]hidclass.sys: Implement helper IoCallMinidriver
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hidclass.sys/hid.h | 1 + dlls/hidclass.sys/main.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+)

1 0

[1/11]loader: add Dev Class for HID devices
by Aric Stewart 22 Jun '15

22 Jun '15

--- loader/wine.inf.in | 2 ++ 1 file changed, 2 insertions(+)

1 0

[14/14]hid: Implement HidP_GetScaledUsageValue
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++------ include/ddk/hidpi.h | 1 + 3 files changed, 48 insertions(+), 7 deletions(-)

1 0

[13/14]hid: Implement HidP_MaxUsageListLength
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 2 +- 3 files changed, 55 insertions(+), 2 deletions(-)

1 0

[12/14]hid: Implement HidD_GetAttributes
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidd.c | 20 +++++++++++++++++++- include/ddk/hidsdi.h | 9 +++++++++ 3 files changed, 29 insertions(+), 2 deletions(-)

1 0

[11/14]hid: Implement HidD_GetInputReport
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidd.c | 8 ++++++++ include/ddk/hidsdi.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-)

1 0

[10/14]hid: Implement HidD_GetPreparsedData and HidD_FreePreparsedData
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 4 ++-- dlls/hid/hidd.c | 25 +++++++++++++++++++++++++ include/ddk/hidclass.h | 9 +++++++++ include/ddk/hidsdi.h | 2 ++ 4 files changed, 38 insertions(+), 2 deletions(-)

1 0

[9/14]hid: Implement HidP_InitializeReportForID
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + 3 files changed, 63 insertions(+), 1 deletion(-)

1 0

[8/14]hid: Implement HidP_GetUsageValue
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + 3 files changed, 64 insertions(+), 1 deletion(-)

1 0

[7/14]hid: Implement HidP_GetUsages
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + 3 files changed, 125 insertions(+), 1 deletion(-)

1 0

[6/14]hid: Implement HidP_GetValueCaps
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 2 ++ 3 files changed, 62 insertions(+), 1 deletion(-)

1 0

[5/14]hid: Implement HidP_GetButtonCaps
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + include/wine/hid.h | 2 +- 4 files changed, 58 insertions(+), 2 deletions(-)

1 0

[4/14]hid: Implement HidP_GetCaps
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/Makefile.in | 1 + dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 53 ++++++++++++++++ include/ddk/hidpi.h | 168 +++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidsdi.h | 2 +- include/wine/hid.h | 80 ++++++++++++++++++++++++ 6 files changed, 304 insertions(+), 2 deletions(-) create mode 100644 dlls/hid/hidp.c create mode 100644 include/ddk/hidpi.h create mode 100644 include/wine/hid.h

1 0

[3/14]hid: translated HidD_ functions to their IOCTLs
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/hidd.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-)

1 0

[2/14]hid: break HidD_ functions out into their own module
by Aric Stewart 22 Jun '15

22 Jun '15

--- dlls/hid/Makefile.in | 1 + dlls/hid/hidd.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++ dlls/hid/main.c | 40 +------------------------------- 3 files changed, 67 insertions(+), 39 deletions(-) create mode 100644 dlls/hid/hidd.c

1 0

[1/14]include: add ddk/hidclass.h
by Aric Stewart 22 Jun '15

22 Jun '15

--- include/ddk/hidclass.h | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 include/ddk/hidclass.h

1 0

HID work, two sets of patches
by Aric Stewart 22 Jun '15

22 Jun '15

Hi all, So I have been working on HID support for the last few months. I have something ready for public review. It is not quite in shape to submit but since this is such a huge bit of work with so many moving pieces I thought it would be useful to have people able to help me make sure it works right. Answer to question #1, This is only implemented for Mac right now. That is because I know the mac HID stuff well and could do it. There will of course be a need for a linux minidriver as well, (like the mac minidriver) but I am not qualified to write that. I would be more than happy to help someone write it. Answer to question #2, No, this is not hooked up anywhere yet. Ideally it will get hooked up to be the bases for the winejoystick.drv, dinput, xinput and RawInput. I have a very rough implementation for winejoystick.drv but it is so rough that I am not presenting it yet. Answer to question #3, yes it works. I both have written my own HID client as well as the Microsoft hclient.exe test application and they work using this code as expected. Answer to question #4, No, this will most likely NOT support windows minidrivers. Mostly because of the lack of any sort of real plug and play support. There are some architecture bits that may be tricky with windows native minidrivers in .sys format. It is not outside the realm of doable eventually but I do not expect it to work right now. Finally, this is only the start. It is not implementing output or feature reports and there are still a lot of things to improve and implement. But I feel like I need to start getting this out into the public. Yes I will be submitting these and going through the whole process, but the more eyes and people willing to help me make these correct the better. That is why they are going to wine-devel first. So all comments welcome, but be kind. this was a lot of work and I am sure I made some stupid mistakes somewhere. -aric

1 0

Re: gdi32/freetype: Properly handle loading of FT_Long-sized types (Valgrind)
by Marc Bessières 21 Jun '15

21 Jun '15

Hi Nicolay, May I ask you a question on your patch? Why is the last line of the below extract still using reg_load_dword, and not reg_load_ftlong, while the cast was removed? It doesn't seem good to me, or there is something special about the flags? Cheers, Marc @@ -1541,10 +1549,10 @@ static void load_face(HKEY hkey_face, WCHAR *face_name, Family *family, void *bu else face->FullName = NULL; - reg_load_dword(hkey_face, face_index_value, (DWORD*)&face- >face_index); + reg_load_ftlong(hkey_face, face_index_value, &face->face_index); reg_load_dword(hkey_face, face_ntmflags_value, &face->ntmFlags); - reg_load_dword(hkey_face, face_version_value, (DWORD*)&face- >font_version); - reg_load_dword(hkey_face, face_flags_value, (DWORD*)&face->flags); + reg_load_ftlong(hkey_face, face_version_value, &face->font_version); + reg_load_dword(hkey_face, face_flags_value, &face->flags);

2 2

Re: server: return NULL from device_open_file on failure to allocate fd
by Sebastian Lackner 19 Jun '15

19 Jun '15

On 20.06.2015 00:22, Daniel Lehman wrote: > > Does this patch address a real issue or is it just by looking at the source? &file->obj should not lead to an invalid memory access because its just a more convenient way to do a type conversion. If file == NULL, then &file->obj will also be NULL. Of course its a matter of taste what is easier to read. Regards, Sebastian

2 1

Re: DInput axis mapping explanation
by Michael Gardner 19 Jun '15

19 Jun '15

Thank you, Aric! I have a couple more questions, if you have time to answer them. 1) Is Wine affected by the joystick mapping that can be done via jscal (and if not, why)? 2) How would I see the list of values as returned by the device, so I know what mapping to construct?

1 0

Re: [PATCH 5/5] wined3d: Add a setting for requesting OpenGL core profile usage.
by Henri Verbeet 19 Jun '15

19 Jun '15

On 19 June 2015 at 00:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -199,6 +200,14 @@ static BOOL wined3d_dll_init(HINSTANCE hInstDLL) > > if (hkey || appkey) > { > + if (!get_config_key( hkey, appkey, "UseCore", buffer, size)) > + { > + if (!strcmp(buffer,"enabled")) > + { > + TRACE("Requested OpenGL Core profile.\n"); > + wined3d_settings.use_core = TRUE; > + } > + } > if ( !get_config_key( hkey, appkey, "UseGLSL", buffer, size) ) > { > if (!strcmp(buffer,"disabled")) Would it make sense to express this in terms of the maximum (desktop) GL version to use instead? I imagine that at some point we'll want to use GL versions beyond 3.2, at which point it may be useful to have something a bit more flexible than just core/classic. > @@ -1711,6 +1709,7 @@ struct wined3d_gl_limits > > struct wined3d_gl_info > { > + BOOL legacy_gl; > DWORD glsl_version; > struct wined3d_gl_limits limits; > DWORD reserved_glsl_constants, reserved_arb_constants; This could probably just be an entry in the wined3d_gl_extension enum, which I suppose might have advantages if we need this information for building e.g. state or format tables.

2 2

Re: [PATCH 1/8] kernel32: Implement GetVolumePathName.
by Nikolay Sivov 19 Jun '15

19 Jun '15

> + const WCHAR fallbackpathW[] = { 'C',':','\\',0 }; This doesn't look right, could we make it dynamic using actual system drive? Same goes for tests, where you got hardcoded C:\ drive. According to docs this function should follow symlinks, will it potentially work with this implementation? Was it tested? I think it makes sense to submit tests first, maybe combining them a little, to have 1 tests patch instead of 4.

2 1

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Theodore Dubois 19 Jun '15

19 Jun '15

> First, yes, we do have hacks in CrossOver, but I think 'a lot' is > unfair. We really try to avoid those hacks, and we work hard to > eliminate them. For example, I reviewed our tracker that lists our > hacks. We have about 100 outstanding; in the last 6 months, we removed > 4 with upstream fixes, and added 1 new one. Further, we have long felt > that our diff with winehq was tragically large. But nicely, I can now > compare it to wine-staging, and claim that it is relatively modest > <grin>. We touch 28K lines in 228 files versus 100K lines in 509 files > for wine-staging [1]. May I suggest you eliminate those hacks by merging them into the Wine codebase? Right now I have a feeling that Wine is wonderful, but Codeweavers is evil. It seems that this feeling is shared by many non-Codeweavers Wine developers. Codeweavers has done a lot of work on Wine, which I really appreciate, but I wish they would be much more open. I think there should, at least, be a public database listing all the hacks that are in Crossover. That way, I would know what the heck was going on inside those windowless walls. This may sound unthinkable, but I would also suggest going further and releasing the source code for the hacks. Not the Crossover-only ones like sendwndcmd.exe. Or the ones that can't be released because of NDAs. I mean the ones that would improve the vanilla Wine distribution. It seems possible to me that you're not releasing these hacks because they would improve vanilla Wine to the point where nobody would be willing to pay for Crossover anymore. If that is true, it's the other reason that I think Codeweavers is evil. I mean, can't you make enough money on consulting for companies that think that Crossover/Codeweavers is better because it costs more money? If there's no openness about what Crossover is doing to Wine, I just can't trust them to develop it. ~Theodore

20 29

Re: gdi32/tests: Japanese Win 7 uses MS Shell Dlg as its default GUI font.
by Marvin 19 Jun '15

19 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14490 Your paranoid android. === wvistau64 (32 bit font) === The test timed out === wvistau64 (64 bit font) === The test timed out

2 1

Re: [etags] repair make etags
by Alexandre Julliard 18 Jun '15

18 Jun '15

marc.bessieres(a)mykolab.com writes: > @@ -68,7 +68,7 @@ TAGSFLAGS = --langmap='c:+.idl.l.rh,make:(Make*.in)' > > TAGS etags: > $(RM) TAGS > - (test -d .git && git ls-files || find -L $(top_srcdir) -name '*.[ch]' -print) | xargs etags -a $(TAGSFLAGS) > + (test -d .git && git ls-files '*.[chly]' '*.idl' || find -L $(top_srcdir) -name '*.[ch]' -print) | xargs etags -a This will make the results less useful. You could add different commands based on the available etags, though installing exuberant-ctags may be an easier fix... -- Alexandre Julliard julliard(a)winehq.org

2 1

d3drm patch feedback
by Stefan Dösinger 18 Jun '15

18 Jun '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Here's the feedback for the patch you posted on IRC: > + GUID driver = IID_IDirect3DRGBDevice; Do you need this? Can't you just pass &IID_IDirect3DRGBDevice to CreateDeviceFromClipper? It may generate a const warning though. > + hr = DirectDrawCreateClipper(0, &clipper, NULL); > + ok(hr == DD_OK, "Cannot get IDirectDrawClipper interface (hr = %x).\n", hr); > + hr = IDirectDrawClipper_SetHWnd(clipper, 0, window); > + ok(hr == DD_OK, "Cannot set HWnd to Clipper (hr = %x).\n", hr); Can you pass a NULL clipper? If this crashes, just put a comment in the test. What if the clipper has no HWND and no clip list? Call GetClipper on the render target and see if the clipper is assigned. > + hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, clipper, &driver, 300, 200, &device2); For the sake of completeness pass 0 width and height. I expect one of the two results: Either it returns an error, or d3drm starts to use the window dimensions for the render target now. > + todo_wine ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %d , ref2 = %d\n", ref1, ref2); Minor detail: Use %u for unsigned. > + ok((surface_desc.dwWidth == 300) && (surface_desc.dwHeight == 200), "Expected surface dimentions = 300, 200, got %d, %d.\n", > + surface_desc.dwWidth, surface_desc.dwHeight); > + ok((surface_desc.ddsCaps.dwCaps & (DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE)) == (DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE), > + "Expected caps containing %x, got %x.\n", DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE, surface_desc.ddsCaps.dwCaps); > + expected_flags = DDSD_PIXELFORMAT | DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | DDSD_PITCH; > + ok(surface_desc.dwFlags == expected_flags, "Expected %x for flags, got %x.\n", expected_flags, surface_desc.dwFlags); Test the pixel format here. First query the current bpp with EnumDisplaySettings and check that the pixel format matches the screen properties. > + /* Check if ddraw supports change of display mode */ The comment is somewhat outdated. Either remove it or say something like "Test if the render target format follows the screen format". > + ok(surface_desc.ddpfPixelFormat.dwRGBBitCount == 16, "Expected 16bpp, got %dbpp.\n", > + surface_desc.ddpfPixelFormat.dwRGBBitCount); Similar to the %u -> %u above Once these are fixed the patch can go to wine-patches as far as I'm concerned. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVgt8QAAoJEN0/YqbEcdMwOTYP/jXwDY+gUs/zmAyqB5hJp8by FO0YSZsi0Z3QMMzfqenCy9+/PmqjMHyRPQvhM8CFpcdWsUi8bH6PzTiooAYOcvzf GXEnj46T1O0wiJfLK+RnzfvYNzITLWf2XK6ek1OtP1z6Y3JhADXwoLW/tSM+kKp7 Crih31t9ewiSMG5iebcSdviI59WrFtUHmS9Mdp5UnWVQB8smZII8c+VAOf/SmWZ1 cGKosFncJVNuXpF0fq5gWiy3m1VcJ1xoWsG1rXbrOzVFvpw+20twa1FgZm9Z6I3c Pxj2prH2Lz9u7tDZUr75dg3ucRPcUe2QP2bTwwBDDq4oaUZYKgXBLrz94AVZ/Y+j datcVFY7KwY2byGmxmO+0I+iWyj26CIg13jo20gqfRfjt92DFlfi5/Mm/e97rCa1 0V38s0kqN5o4rvU+QbUwHfvHIgr4kAFWZPjDmZd3YececQuoeC7FszND/43UD0tK MTd1Na3hFa5m6zO7oe4fPfGYX55tVhEzphiRkH4K0R0ZTxRsZGGqQoSFAHeAJDH6 0hPd3XjVHxSpHQNd8/8aFeOMJ8pBR+4MRUMcFBDn0XlDUYw0kUdvRkttKoNVCSGw H0BS00wj/fs/G4D/pCLEFEX7wF9qDM5O6xKQRoyXG3+i9oN+zdzCNMs6SV1J2Bci Jedz7Aw7+yAByiH/GePR =aa6D -----END PGP SIGNATURE-----

2 1

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Theodore Dubois 17 Jun '15

17 Jun '15

> While it seems Theodore didn't do his homework and didn't know about that source distribution, one of his point remains: > it's not a database, git, or something easily readable, just a blob Yes, I really hate that it’s a huge blob. I’m working on a little project to try and diff Crossover’s wine and wine 1.7.25, and identify all the hacks. The github repo is tbodt/crossover-wine, but I haven’t actually done any real work on it yet. Currently, it’s nothing but a fork of wine-mirror/wine. We’ll see when I get around to it. ~Theodore

1 0

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Theodore Dubois 17 Jun '15

17 Jun '15

I originally sent this email to Jeremy, but forgot to CC the mailing list. ~Theodore On Jun 16, 2015, at 1:48 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >> I'm obviously very sad that you perceive us as evil. Do you mind me >> asking where you got that feeling from? If there is an information >> source that is revealing all of our evil secrets, I'd like to know about >> it. <grin> > > I thought you were evil because I didn't realize that all your hacks are actually already public. (And those <evil grin>s.) I'm sorry. > >> All of our Wine code, including our hacks, is publicly released, here: >> https://www.codeweavers.com/products/faq/source/ > > I had seen that source page, but I didn't realize it contained all the hacks. I thought it was just the main Wine source code. > >> Um, nearly all of the work that we do on CrossOver is done by sending >> public emails to this mailing list. How is that not open? Or perhaps I >> should ask - what gave you the impression that we did not develop openly? > > I thought that because you were evil, you must have some non-public mailing list. I guess I was wrong. > > Well, now I don't feel CodeWeavers is evil anymore. You are doing some awesome work on Wine. Without it, Wine would not have gotten to the point where it could run Crysis. > > ~Theodore

1 0

Re: [1/2] winhttp/tests: Fix a test failure on win2k.
by Marvin 17 Jun '15

17 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14399 Your paranoid android. === w8 (32 bit winhttp) === winhttp.c:864: Test failed: failed to send request 2148074273 winhttp.c:868: Test failed: failed to retrieve certificate context 12019 winhttp.c:873: Test failed: failed to retrieve key bitness 4317 winhttp.c:877: Test failed: failed to retrieve certificate info 12019 winhttp.c:890: Test failed: failed to receive response 12019 winhttp.c:895: Test failed: failed unexpectedly 12019 winhttp.c:896: Test failed: request failed unexpectedly 3735928559 winhttp.c:907: Test failed: WinHttpReadData failed: 12019. winhttp.c:911: Test failed: read_size = 0

1 0

IDirect3DRM*::CreateDeviceFrom* tests
by Aaryaman Vasishta 17 Jun '15

17 Jun '15

Testing if pixel format of the render target changes when the mode is changed: https://testbot.winehq.org/JobDetails.pl?Key=14395 <https://testbot.winehq.org/JobDetails.pl?Key=14356> All the three tests together: https://testbot.winehq.org/JobDetails.pl?Key=14403 Please review the code and let me know of any modifications that are required. Thank you! Jam

1 1

Re: [2/2] Add stub dll d3dcompiler_47 (try 2)
by Matteo Bruni 17 Jun '15

17 Jun '15

2015-06-17 8:01 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > Removed LPVOID > > Changelog: > Add stub dll d3dcompiler_47 > > > Best Regards > Alistair Leslie-Hughes Both patches look good to me. Thanks Alistair!

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel