- wine-devel - winehq.org

Re: [PATCH 1/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromClipper (try 2).
by Henri Verbeet 11 Jun '15

11 Jun '15

On 11 June 2015 at 13:51, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + cleanup: > + IDirectDrawClipper_Release(clipper); I'm mostly leaving this for Stefan to actually review, but this seems like an indentation accident.

1 0

Re: dpnet: Correct adding components in Duplicate
by Marvin 11 Jun '15

11 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14153 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: PATCH: d3d8: mark one more function as hotpatchable
by Henri Verbeet 11 Jun '15

11 Jun '15

I think the original subject was slightly better because it's more specific, although the proper name of the function is d3d8_swapchain_Present() of course.

1 0

Re: odbccp32: Implement SQLGetPrivateProfileString ( try 2)
by Alexandre Julliard 11 Jun '15

11 Jun '15

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -101,6 +102,21 @@ static inline WCHAR *heap_strdupAtoW(const char *str) > return ret; > } > > +static char *WtoA(LPCWSTR wstr) > +{ > + int length; > + char *result; > + > + length = WideCharToMultiByte(CP_UTF8, 0, wstr, -1, NULL, 0, NULL, NULL); > + > + result = HeapAlloc(GetProcessHeap(), 0, length); > + > + if (result) > + WideCharToMultiByte(CP_UTF8, 0, wstr, -1, result, length, NULL, NULL); > + > + return result; UTF-8 makes no sense here, and you shouldn't need that function in the first place. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: ParseX509EncodedCertificateForListBoxEntry stub
by Alexandre Julliard 11 Jun '15

11 Jun '15

Marcus Meissner <marcus(a)jet.franken.de> writes: > From db29dec04c5c02ab2a96010d42aec00aaeccbec2 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 25 Feb 2015 01:04:56 -0600 > Subject: wininet: add ParseX509EncodedCertificateForListBoxEntry stub (try 2) > > Try 2: Fix prototype/spec file, add to winineti.h > Fixes https://bugs.winehq.org/show_bug.cgi?id=29842 It's still wrong. If you want to help, review the patch, figure out what's wrong, email the original author (CC'ing wine-devel), and ask them to fix their patch and resubmit. And if you can't figure out what's wrong, then maybe you shouldn't be submitting other people's patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac.drv: Improved App name on windows and menus (Mac Driver)
by Nikolay Sivov 11 Jun '15

11 Jun '15

On 06/10/2015 05:48 PM, Vitor Marques wrote: > + // Application name > bundleName = [[NSBundle mainBundle] objectForInfoDictionaryKey:(NSString*)kCFBundleNameKey]; > + if (!bundleName || ![bundleName lenght]) bundleName = @"Wine"; I can't say I understand objc, but this looks like a typo.

1 0

Re: dpnet: Simplify the storing of component data
by Stefan Dösinger 11 Jun '15

11 Jun '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I am OK with this patch in principle if you believe that it is an improvement. It reduces the code size, but on the other hand it means that you're having tiny allocations for DWORDs and GUIDs. Keep in mind that such allocations mean overhead in memory use, run time and memory fragmentation. I'd like to point out an alternative approach: You can give struct component a variable size, similar to how struct wined3d_private_data in include/wine/wined3d.h works. But overall I think this is a minor detail considering the overall state of the directplay libs and that there are more important issues to solve. I don't want to stand in your way by arguing about small things like this. I can't promise Alexandre agrees though. Either way, two style comments: The test is a good test to add, but should be in its own patch. Am 2015-06-10 um 06:41 schrieb Alistair Leslie-Hughes: > found = TRUE; > > - if(entry->type == DPNA_DATATYPE_STRING_ANSI) > - heap_free(entry->data.ansi); > - else if(entry->type == DPNA_DATATYPE_STRING) > - heap_free(entry->data.string); > - else if(entry->type == DPNA_DATATYPE_BINARY) > - heap_free(entry->data.binary); > + heap_free(entry->data); > > break; The added heap_free line is indented by 11 chars. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVeAC0AAoJEN0/YqbEcdMws9oP/RyusEIcZnV4GWTAmfaSKfFn 0iheACWwmeL3GlWeqmY51S8ImuKcoD0HoZ/vQm6jMhTTJFK3jENVJkMk/Mjx8Kk6 ZPcit6nPB184lDgzLXV0gHbMlPkFxdTPJi++1ZfKa9LskJ3zIrgF7LcJFidtCSeG 7yHdg6C0BiQH4oXjBzY+fVRzaQluKEihncaa2tYdErfMUCzUf+RAi99/tnete2Re EiejXowzg5HcxjBHMupsGEcFocUnXtUlPzJf0UIawbptxzPYXk3H0VYPohIrLVm6 f/chcdKlvAi5xdUlCuF4nLw9TQxyC5h3mf5p7l/JdDbgRE8knCO1w/HrzOHJJJRB TnkU5EdrnIc3Bx6Tw/kQGTKsM3SAuSapdjBsQRracNaQVzdqYKfsMPaiQeRVmdQO LJbyeECFw3l3opf/LFd/TUguDws2hChASaBAOf25vorhD6wH8fnaoNnEh1qMtBH5 x1jJjxB+B0Uwa4nYKProoOc0Qw0/zoaVlv3vCKiiEggz+BkXEuYb58ZDysSg4A1w JVO0S6GAfumFPWvHMtoIEPsFxiPl6xHiwXsKzrHc8K5EpUTZ2Jcv0lam53x39Tb1 cJmluv1SyxrdrTWT1nCtgg+ma8ezid8HEpOj+aIWVwYcKwR9uF09jvDEaAzwSuAr V6ogftbNHriUDl15YrO+ =zne3 -----END PGP SIGNATURE-----

2 1

Re: [1/1] advapi32/tests: Add preliminary event tracing tests. (v2 resend)
by Marvin 11 Jun '15

11 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14142 Your paranoid android. === w2000pro (32 bit eventlog) === eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wxppro (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2003std (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wvistau64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2008s64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w7u (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w8 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87

1 0

Re: [PATCH 5/5] d3d9/tests: Test the default colors for fixed function vertex processing.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14137 Your paranoid android. === w8 (32 bit visual) === visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test.

1 0

Re: [PATCH 4/5] d3d9/tests: Test the default diffuse color for vertex shaders.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14136 Your paranoid android. === w8 (32 bit visual) === visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test.

1 0

Re: [PATCH 4/4] d3drm/tests: Add refcount tests for IDirect3DRMDevice*
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14110 Your paranoid android. === w2000pro (32 bit d3drm) === d3drm.c:2037: Test failed: Expected 32 bpp, got 24d3drm.c:2054: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2058: Test failed: Expected 640x480, got 1024x768 d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === wxppro (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === w2003std (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840.

2 1

Re: [PATCH 2/2] mshtml: Implement IHTMLXMLHttpRequest as a stub. (try 2)
by Alexandre Julliard 10 Jun '15

10 Jun '15

Zhenbo Li <litimetal(a)gmail.com> writes: > try 2: > add test_disp in dom.c for DIID_DispHTMLXMLHttpRequest It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok dom.c:6110: Test failed: unexpected guid {3051040a-98b5-11cf-bb82-00aa00bdce0b} make: *** [dom.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winebuild: Set a valid major and minor linker version.
by Nikolay Sivov 10 Jun '15

10 Jun '15

On 10.06.2015 10:08, Sebastian Lackner wrote: > From: Michael Müller <michael(a)fds-team.de> > > Some apps expect a nonzero linker version. > Just out of curiosity, could you name some of those applications?

2 1

Re: [PATCH 3/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromD3D.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14109 Your paranoid android. === w2000pro (32 bit d3drm) === d3drm.c:2037: Test failed: Expected 32 bpp, got 24d3drm.c:2054: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2058: Test failed: Expected 640x480, got 1024x768 d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === wxppro (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === w2003std (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840.

1 0

Re: [PATCH 2/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromSurface.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14108 Your paranoid android. === w2000pro (32 bit d3drm) === d3drm.c:2037: Test failed: Expected 32 bpp, got 24d3drm.c:2054: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2058: Test failed: Expected 640x480, got 1024x768 d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. === wxppro (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. === w2003std (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840.

1 0

Re: [PATCH 1/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromClipper.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14107 Your paranoid android. === w2000pro (32 bit d3drm) === d3drm.c:2037: Test failed: Expected 32 bpp, got 24d3drm.c:2054: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2058: Test failed: Expected 640x480, got 1024x768 === wxppro (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. === w2003std (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32.

1 0

Re: [3/3] kernel32: Forward SetFileInformationByHandle FileDispositionInfo class to ntdll.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14103 Your paranoid android. === wvistau64 (32 bit file) === file.c:446: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:446: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [1/3] kernel32: Improve stub for SetFileInformationByHandle.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14101 Your paranoid android. === wvistau64 (32 bit file) === file.c:446: Test failed: attributes of file "testfile.xxx" are 0x0820 === w7u (32 bit file) === file.c:4204: Test failed: SetFileValidData failed 87 file.c:4207: Test failed: SetFileValidData failed 87 === wvistau64 (64 bit file) === file.c:446: Test failed: attributes of file "testfile.xxx" are 0x0820

2 1

Re: regedit: Need 3 bytes of room at end of buffer for \r\n\0 to avoid endless loop.
by Sebastian Lackner 10 Jun '15

10 Jun '15

On 21.05.2015 13:14, Jiaxing Wang wrote: > --- > programs/regedit/regproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > The patch looks correct to me, and the issue can be easily reproduced by trying to import for example http://ix.io/j1Y. (md5sum: 6928e59d2c1a92666377a088a1523666) The only problem I see is that the code for A/W has diverged a lot over time. I'm not sure, but I assume Alexandre might expect to merge or at least synchronize it, before fixing specific parser bugs.

1 0

Re: include: Fix definition of FILE_DISPOSITION_INFO.
by Nikolay Sivov 10 Jun '15

10 Jun '15

On 09.06.2015 10:09, Sebastian Lackner wrote: > A member called DeleteFile cannot be accessed because its defined as > DeleteFile_must_be_suffixed_with_W_or_A_in_this_context. > > --- > include/winbase.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > This is how it's defined in SDK though, I don't think you can change that.

3 4

Re: rpcrt4: Restore original error code when ReadFile fails with ERROR_MORE_DATA.
by Alexandre Julliard 09 Jun '15

09 Jun '15

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Required when named pipe messagemode is implemented. Restoring last error is in general wrong. You'll need a better reason to justify this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: gdiplus: Implement trivial case of GdipCreateRegionRgnData for empty and infinite regions
by Dmitry Timoshkov 09 Jun '15

09 Jun '15

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > First bits for https://bugs.winehq.org/show_bug.cgi?id=34843 What is the reason of reimplementing it when wine-staging already includes full implementation with tests? https://github.com/wine-compholio/wine-staging/blob/master/patches/gdiplus-… -- Dmitry.

6 14

Re: gdiplus: Implement trivial case of GdipCreateRegionRgnData for empty and infinite regions (try2)
by Vincent Povirk 09 Jun '15

09 Jun '15

Looks good to me, thanks. On Tue, Jun 9, 2015 at 1:37 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > try2: check for both possible magic values > > >

1 0

mciqtz32: Guarantees that CoInitialize and CoUninitialize run on the same thread.
by Joerg-Cyril.Hoehle＠t-systems.com 09 Jun '15

09 Jun '15

Aki, if I understand your critical section well, you serialize all accesses to the individual player thread. This may be ok for commands that return immediately, e.g. STATUS, but the MCI knows commands that may take a long time, in particular PLAY, RECORD and even SEEK. Did you run a test like this: CreateTask { SetEvent started MCICommand(MCI_PLAY, "av_file_that_takes_3_minutes.avi", MCI_WAIT); } Wait(started); Repeat 10 times { MCICommand(MCI_STATUS,MCI_POSITION); printf MCICommand(MCI_STATUS,MCI_MODE); Printf Sleep(2s); } Wait(thread); I would expect all MCI commands "STATUS POSITION" etc. to work while another thread is busy playing a file synchronously (using MCI_WAIT). Furthermore +static LRESULT MCIQTZ_relayTaskMessage [...] + if (WaitForSingleObject(wma->task.done, INFINITE) == WAIT_OBJECT_0) Are you sure it's ok to block the user thread like this? Shouldn't the code use a loop that also pumps the MS-Windows message queue and dispatches messages? E.g. there may be a need to dispatch REFRESH and PAINT messages? Did you cross-check what MS-Windows does here? On a related note, IIRC some wine devices use a more reliable approach to waiting: WaitForMultiple(2 objects: [task.done, task.threadId], INFINITE); That way, should the player crash or exit somehow, the main (user) task doesn't hang. Regards, Jörg Höhle

2 4

Re: kernel32: Treat empty locale name as LANG_INVARIANT.
by Alexandre Julliard 09 Jun '15

09 Jun '15

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/kernel32/locale.c | 7 +++++++ > dlls/kernel32/tests/locale.c | 6 ++++-- > 2 files changed, 11 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so locale && touch locale.ok locale.c:2421: Test failed: Expected lcid = 0x7F, got 0000047f, error -559038737 make: *** [locale.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/7] qmgr: Add support for Basic authentication.
by Jacek Caban 09 Jun '15

09 Jun '15

Hi Hans, On 06/08/15 14:32, Hans Leidekker wrote: > static HRESULT WINAPI http_negotiate_BeginningTransaction( > IHttpNegotiate *iface, LPCWSTR url, LPCWSTR headers, DWORD reserved, LPWSTR *add_headers) > { > DLBindStatusCallback *callback = impl_from_IHttpNegotiate(iface); > - FIXME("(%p)->(%s %s %u %p)\n", callback, debugstr_w(url), debugstr_w(headers), reserved, add_headers); > - return E_NOTIMPL; > + BackgroundCopyJobImpl *job = callback->file->owner; > + WCHAR *str, *auth_header; > + DWORD len; > + > + TRACE("(%p)->(%s %s %d %p)\n", callback, debugstr_w(url), debugstr_w(headers), reserved, add_headers); > + > + if ((auth_header = build_auth_header(&job->http_options.creds))) > + { > + if (!job->http_options.headers) > + { > + *add_headers = auth_header; > + return S_OK; > + } > + else > + { > + len = strlenW(auth_header) + strlenW(job->http_options.headers); > + if (!(str = CoTaskMemAlloc((len + 1) * sizeof(WCHAR)))) > + { > + CoTaskMemFree(auth_header); > + return E_OUTOFMEMORY; > + } > + strcpyW(str, auth_header); > + strcatW(str, job->http_options.headers); > + CoTaskMemFree(auth_header); > + *add_headers = str; > + return S_OK; > + } > + } > + else if (job->http_options.headers) > + { > + if (!(*add_headers = co_strdupW(job->http_options.headers))) return E_OUTOFMEMORY; > + return S_OK; > + } > + > + *add_headers = NULL; > + return S_OK; It doesn't sound like a good idea to manually handle that here. We should most likely use IAuthenticate (although it's not yet supported in urlmon). Jacek

2 6

Re: [wine-tools] patches: Add a "Staging" status.
by Austin English 09 Jun '15

09 Jun '15

On Fri, Jun 5, 2015 at 11:30 AM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > --- > patches/expire | 1 + > patches/patches.css | 1 + > patches/update | 2 ++ > 3 files changed, 4 insertions(+) > > diff --git a/patches/expire b/patches/expire > index f143ab1..3cf75e6 100755 > --- a/patches/expire > +++ b/patches/expire > @@ -37,6 +37,7 @@ my %status_expiry = > "split" => 7, > "depend" => 7, > "sequence" => 7, > + "staging" => 30, > "superseded" => 1, > "testcase" => 7, > "testfail" => 7, > diff --git a/patches/patches.css b/patches/patches.css > index 745ec75..5746057 100644 > --- a/patches/patches.css > +++ b/patches/patches.css > @@ -154,6 +154,7 @@ tr.odd { background-color: #f8e8e8; } > .sequence, .sequence :link, .sequence :visited { color: #e08000; } > .deferred, .deferred :link, .deferred :visited { color: #e08000; } > .testcase, .testcase :link, .testcase :visited { color: #e08000; } > +.staging, .staging :link, .staging :visited { color: #e08000; } > .other, .other :link, .other :visited { color: #e08000; } > .applyfail, .applyfail :link, .applyfail :visited { color: red; } > .buildfail, .buildfail :link, .buildfail :visited { color: red; } > diff --git a/patches/update b/patches/update > index 4ccc910..335af0b 100755 > --- a/patches/update > +++ b/patches/update > @@ -40,6 +40,7 @@ my %status_descr = > "depend" => "Dependency", > "superseded" => "Superseded", > "sequence" => "Bad sequence", > + "staging" => "Staging", > "testcase" => "Needs tests", > "testfail" => "Test failure", > ); > @@ -57,6 +58,7 @@ my @legend = > "<li>Someone else fixed the problem already.</li></ul>" ], > [ "testcase", "<ul><li>You need to write some test cases demonstrating that the patch is correct.</li></ul>" ], > [ "deferred", "<ul><li>The patch is deferred because of code freeze for an upcoming release. Either resend after the release, make the patch less intrusive, or make a convincing argument that it needs to be included in the release.</li></ul>" ], > + [ "staging", "<ul><li>The patch needs more work or wider testing. Please get it in over Wine Staging.</li></ul>" ], > [ "other", "<ul><li>The patch belongs to another WineHQ project (website, appdb, etc.) and will be applied by the respective maintainer.</li></ul>" ], > [ "applyfail", "<ul><li>The patch got mangled in transit.</li>" . > "<li>It's not relative to the latest git.</li>" . > -- > 2.4.2 I'm not sure we want to encourage wine-stating from Upstream (I'm not convinced either way), but in any case, the grammar seems wrong to me as a native speaker, how about: "The patch needs more work or wider testing. Please try to get into Wine-Staging." or something similar? -- -Austin

5 4

Re: odbccp32: Implement SQLGetPrivateProfileString
by Nikolay Sivov 09 Jun '15

09 Jun '15

On 09.06.2015 13:00, Alistair Leslie-Hughes wrote: > @@ -415,12 +416,56 @@ int WINAPI SQLGetPrivateProfileString(LPCSTR lpszSection, LPCSTR lpszEntry, > LPCSTR lpszDefault, LPCSTR RetBuffer, int cbRetBuffer, > LPCSTR lpszFilename) I turns out our definition is wrong, PSDK uses LPSTR/LPWSTR for output buffer. Fixing that (including header of course) will fix casts that you had to use to cast const away. Also I think we want SQLGetPrivateProfileStringW to be implemented first, and forward SQLGetPrivateProfileString to it, unless there's a reason not to do that, like differences in behavior that some tests reveal.

1 0

Re: [PATCH 1/2] mshtml: Implement IHTMLXMLHttpRequestFactory as a stub.
by Jacek Caban 09 Jun '15

09 Jun '15

Hi Zhenbo, On 06/08/15 17:04, Zhenbo Li wrote: > --- a/dlls/mshtml/htmlwindow.c > +++ b/dlls/mshtml/htmlwindow.c > @@ -1965,8 +1965,23 @@ static HRESULT WINAPI HTMLWindow5_put_XMLHttpRequest(IHTMLWindow5 *iface, VARIAN > static HRESULT WINAPI HTMLWindow5_get_XMLHttpRequest(IHTMLWindow5 *iface, VARIANT *p) > { > HTMLWindow *This = impl_from_IHTMLWindow5(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + HTMLInnerWindow *window = This->inner_window; > + > + TRACE("(%p)->(%p)\n", This, p); > + > + if(!window->xml_factory) { > + HRESULT hres; > + > + hres = HTMLXMLHttpRequestFactory_Create(window, &window->xml_factory); > + if(FAILED(hres)) > + return hres; > + } This instance will be leaked. You need to release it when HTMLInnerWindow is freed. Cheers, Jacek

1 0

Re: [1/2] xaudio2_7: Implement IXaudio2 interface as stub (try 5)
by Jacek Caban 09 Jun '15

09 Jun '15

Hi Guillaume, On 06/09/15 10:46, Guillaume Charifi wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=26808 > > Thanks Jacek, I applied most of your tips (except those I was unable to understand how they was related to the code) It looks better now, but: > +static HRESULT WINAPI XAudio2CF_QueryInterface(IClassFactory *iface, REFIID riid, void **ppobj) > +{ > + return IClassFactory_QueryInterface(iface, riid, ppobj); > +} Why did you change it? This can't work, it will cause infinite recursion when called. Cheers, Jacek

1 0

Re: [PATCH] advapi32: test and fix ChangeServiceConfig2 when given a zero length or a null description (try 2) (was: succeed
by Marvin 09 Jun '15

09 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14026 Your paranoid android. === w7u (32 bit service) === service.c:1421: Test failed: Active services mismatch 1 service.c:1422: Test failed: Inactive services mismatch 4294967295

2 1

Re: [PATCH 2/2] d3dx9_36: Implement triangle filter when create textures
by Matteo Bruni 09 Jun '15

09 Jun '15

2015-06-09 10:49 GMT+02:00 Sergey Isakov <isakov-sl(a)bk.ru>: > This algo just tested long ago. > May be it can be rewritten to float point math but it requires additional efforts. > > It does differ from MS algo because it is my algo not related to MS. > > Manually observe? I did this and sent a picture. Can't imagine what should be done with tests suit. The test I mentioned is not meant for the Wine test suite (even though it would be nice to have some kind of Wine test eventually). You would write a standalone application (or hack something in the d3dx9 tests, it might be easier) along the lines of what I described and run it against native d3dx9_36.dll, ideally on Windows. You'd save the filtered images and eyeball them to try to figure out what's the filtering algorithm used by MS. I have no idea whether it will be doable in practice or not but it seems worth a try.

2 1

Re: kernel32/tests: Some tests for invalid classes in SetFileInformationByHandle()
by Marvin 09 Jun '15

09 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14013 Your paranoid android. === wvistau64 (32 bit file) === file.c:446: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:446: Test failed: attributes of file "testfile.xxx" are 0x0820

2 1

Re: [PATCH 2/2] d3dx9_36: Implement triangle filter when create textures
by Nikolay Sivov 09 Jun '15

09 Jun '15

On 08.06.2015 10:02, Sergey Isakov wrote: > > On 08.06.2015, at 9:48, Nikolay Sivov wrote: > >> On 07.06.2015 23:13, Sergey Isakov wrote: >>> It is probably not triangle filter but works with similar result so I place it in appropriate places. >>> As well load surface and volume works with DXTn textures now. External conversion is a stub. >>> The best test will be graphical. See two sscreenshots: textures made by DxTex.exe (from DirectXSDK), one with point filter, second with triangle filter my version. >>> PS. About copyright. It is my mathematics. (c)Isakov S.L. >>> >> >>> +#ifdef DXTN_COMPESSION_SUPPORTED >>> + switch (format) >>> + { >>> + case D3DFMT_DXT1: >>> + if (!wined3d_dxtn_supported()) return NULL; >>> + return encode ? wined3d_dxt1_encode : wined3d_dxt1_decode; >> >> This diff is not against wine-git tree, there's no wined3d_dxtn_supported() funtion in wine. > > So why this is a stub. > Sure, this diff against wine-git tree recent version. > You mean that's why it's #ifdefed? I don't know if we need this part, that can't be even built, as it's not clear how DXTN_COMPRESSION_SUPPORTED is supposed to be defined and where; but I leave this to actual wined3d devs to respond. P.S. please CC wine-devel next time you reply.

4 4

Re: [3/3] advapi32/tests: Add preliminary event tracing tests.
by Nikolay Sivov 09 Jun '15

09 Jun '15

On 08.06.2015 6:56, Zebediah Figura wrote: > + /* test ERROR_DISK_FULL */ > + properties->MaximumFileSize = 1000000000000; /* 1 EB */ > + SetLastError(0xdeadbeef); > + ret = StartTraceA(&handle, sessionname, properties); > + todo_wine > + { > + ok(ret != ERROR_SUCCESS, "Expected failure\n"); > + ok(GetLastError() == ERROR_DISK_FULL, "Expected ERROR_DISK_FULL, got %d\n", GetLastError()); > + } > + properties->MaximumFileSize = 0; Patches look fine to me, but I have to ask - is it possible that this test will actually try to write that much?

2 2

Re: gdiplus: Implement trivial case of GdipCreateRegionRgnData for empty and infinite regions
by Vincent Povirk 09 Jun '15

09 Jun '15

+ if (region_header->magic != VERSION_MAGIC) + return InvalidParameter; We should probably accept 0xdbc01002 as well here.

2 1

Re: [1/4] msvcirt: Add implementation of streambuf::allocate (try 2, resend)
by Piotr Caban 08 Jun '15

08 Jun '15

On 06/08/15 15:56, Iván Matellanes wrote: > + ok(sb.ebuf - sb.base == 512 , "wrong reserve area size, expected 512 got %d\n", sb.ebuf - sb.base); > + ok(sb2.ebuf - sb2.base == 512 , "wrong reserve area size, expected 512 got %d\n", sb2.ebuf - sb2.base); This will produce warning on 64-bit build. You can e.g. display both pointers in error message. Sorry for not spotting it earlier, Piotr

1 0

Wineconf proposal: discuss 64-bit?
by Josh DuBois 08 Jun '15

08 Jun '15

I'm wondering whether it would be useful to discuss 64-bit support in Wine at wineconf this year. I'm interested in feedback on whether it's a useful topic. With games in particular, 64-bit seems to be becoming a more common requirement, especially with newer DirectX 11 games (which may start running in wine ... sometime). I guess the basics work on Intel Linux. Several issues remain, however: - OS X support: compiler toolchains are an issue, there are problems with thread-local storage. - ARM support: I think Andre H. believes that 64-bit will be hard to support on ARM. As far as I know there aren't yet a lot of real-world use-cases for that, but there are certainly a lot of ARM chips around nowdays and maybe Windows 10 will start appearing on ARM devices. - MSI: I think there are MSI limitations which prevent some 64-bit apps from installing (e.g., bug 29941) . I think this blocks 64-bit MS Office. - Mono / .NET ? - Other ... ? It might be that there's not a great deal to do at wineconf other than catalog the issues. If it's worth a short (not an hour - maybe if we have some 10-15 minute segments) discussion while everyone is in the same place, I'd be happy to try and catalog them.

2 2

Re: [5/7] qmgr: Implement IBackgroundCopyJob::Cancel.
by Jacek Caban 08 Jun '15

08 Jun '15

Hi Hans, On 06/08/15 14:32, Hans Leidekker wrote: > --- > dlls/qmgr/file.c | 1 + > dlls/qmgr/job.c | 33 +++++++++++++++++++++++++++++++-- > 2 files changed, 32 insertions(+), 2 deletions(-) I don't know qmgr, but shouldn't it result in IBinding::Abort() call on underlying binding object? Jacek

2 2

Wineconf talk proposal: Wine and Valgrind
by Austin English 08 Jun '15

08 Jun '15

Howdy all, If anyone is interested, I can give a presentation on Wine/Valgrind, i.e. current status, major outstanding issues on either side, issues found/fixed, etc. Please let me know if you'd be interested. -Austin

2 1

Re: [PATCH 1/2] d3dx9_36: Implemented D3DXSaveVolumeToFile including DDS files
by Nikolay Sivov 08 Jun '15

08 Jun '15

On 08.06.2015 10:01, Sergey Isakov wrote: > It is hard to distill what part of codes comes from where. My patches depends on previous patches and so they must be included too. > OK, all copylefts must be included if I will know how to do this. > If Christian Costa will say what to do I will do this. Sure, let's hear his opinion. > > On 08.06.2015, at 9:43, Nikolay Sivov wrote: > >> On 07.06.2015 23:02, Sergey Isakov wrote: >>> I decided to improve builtin d3dx9_36 library with support of more file >>> formats, texture formats, volume textures. >> >> It's not your work though, it looks to me like 3 or so patches from Christian Costa squashed together. Why didn't you mention it? >

3 3

Re: xaudio2_7: Implement IXaudio2 interface as stub (try 4)
by Jacek Caban 08 Jun '15

08 Jun '15

Hi Guillaume, On 06/08/15 10:06, Guillaume Charifi wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=26808 > > --- > dlls/xaudio2_7/Makefile.in | 2 > dlls/xaudio2_7/xaudio_dll.c | 300 > ++++++++++++++++++++++++++++++++++++- > dlls/xaudio2_7/xaudio_classes.idl | 28 +++ > 3 files changed, 319 insertions(+), 11 deletions(-) > > > xaudio_2.7.dll.IXAudio2_stub.patch > > > diff --git a/dlls/xaudio2_7/Makefile.in b/dlls/xaudio2_7/Makefile.in > index 853d1d6..6bdf362 100644 > --- a/dlls/xaudio2_7/Makefile.in > +++ b/dlls/xaudio2_7/Makefile.in > @@ -3,3 +3,5 @@ IMPORTS = advapi32 kernel32 ole32 user32 uuid > > C_SRCS = \ > xaudio_dll.c > + > +IDL_SRCS = xaudio_classes.idl Adding registration IDL deserves a separated patch. > diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c > index c8b7904..07c4780 100644 > --- a/dlls/xaudio2_7/xaudio_dll.c > +++ b/dlls/xaudio2_7/xaudio_dll.c > @@ -30,12 +30,15 @@ > #include "wine/debug.h" > #include <propsys.h> > #include "initguid.h" > + > #include "xaudio2.h" > > WINE_DEFAULT_DEBUG_CHANNEL(xaudio2); > > static HINSTANCE instance; > > +static HRESULT XAudio2_create(IUnknown *pUnkOuter, LPVOID *ppObj); > + > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > { > TRACE("(%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > @@ -52,35 +55,310 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > return TRUE; > } > > -HRESULT WINAPI DllCanUnloadNow(void) > +typedef struct { > + IClassFactory IClassFactory_iface; > + HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, LPVOID *ppObj); Please avoid using LP* types. This should be void**, but using IUnknown** would be even better. > +} IClassFactoryImpl; > + > +static inline IClassFactoryImpl *impl_from_IClassFactory(IClassFactory *iface) > { > - return S_FALSE; > + return CONTAINING_RECORD(iface, IClassFactoryImpl, IClassFactory_iface); > +} > + > +static HRESULT WINAPI XAudio2CF_QueryInterface(IClassFactory *iface, REFIID riid, void **ppobj) > +{ > + if(IsEqualGUID(riid, &IID_IUnknown) > + || IsEqualGUID(riid, &IID_IClassFactory)) > + { > + IClassFactory_AddRef(iface); > + *ppobj = iface; > + return S_OK; > + } > + > + *ppobj = NULL; > + WARN("(%p)->(%s, %p): interface not found\n", iface, debugstr_guid(riid), ppobj); > + return E_NOINTERFACE; > +} > + > +static ULONG WINAPI XAudio2CF_AddRef(IClassFactory *iface) > +{ > + return 2; > +} > + > +static ULONG WINAPI XAudio2CF_Release(IClassFactory *iface) > +{ > + return 1; > } > > +static HRESULT WINAPI XAudio2CF_CreateInstance(IClassFactory *iface, IUnknown *pOuter, > + REFIID riid, void **ppobj) > +{ > + IClassFactoryImpl *This = impl_from_IClassFactory(iface); > + HRESULT hr; > + LPUNKNOWN punk; Same here, use IUnknown* instead. > + > + TRACE("(%p)->(%p,%s,%p)\n", This, pOuter, debugstr_guid(riid), ppobj); > + > + *ppobj = NULL; > + hr = This->pfnCreateInstance(pOuter, (LPVOID *) &punk); > + if (FAILED(hr)) > + return hr; > + > + hr = IUnknown_QueryInterface(punk, riid, ppobj); > + IUnknown_Release(punk); > + return hr; > +} > + > +static HRESULT WINAPI XAudio2CF_LockServer(IClassFactory *iface, BOOL dolock) > +{ > + IClassFactoryImpl *This = impl_from_IClassFactory(iface); > + FIXME("(%p)->(%d): stub!\n", This, dolock); > + return S_OK; > +} > + > +static const IClassFactoryVtbl XAudio2CF_Vtbl = > +{ > + XAudio2CF_QueryInterface, > + XAudio2CF_AddRef, > + XAudio2CF_Release, > + XAudio2CF_CreateInstance, > + XAudio2CF_LockServer > +}; > + > +static IClassFactoryImpl xaudio2_cf = { { &XAudio2CF_Vtbl }, XAudio2_create }; > + > HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) > { > + IClassFactory *factory = NULL; > + > TRACE("(%s, %s, %p)\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); > > - if (ppv == NULL) { > - WARN("invalid parameter\n"); > - return E_INVALIDARG; > + if(IsEqualGUID(rclsid, &CLSID_XAudio2)) { > + factory = &xaudio2_cf.IClassFactory_iface; How about simply return IClassFactory_QueryInterface(...) here? > } > + if(!factory) return CLASS_E_CLASSNOTAVAILABLE; > > - *ppv = NULL; > + return IClassFactory_QueryInterface(factory, riid, ppv); > +} > > - WARN("(%s, %s, %p): no class found.\n", debugstr_guid(rclsid), > - debugstr_guid(riid), ppv); > - return CLASS_E_CLASSNOTAVAILABLE; > +HRESULT WINAPI DllCanUnloadNow(void) > +{ > + return S_FALSE; > } > > HRESULT WINAPI DllRegisterServer(void) > { > TRACE("\n"); > - return __wine_register_resources( instance ); > + return __wine_register_resources(instance); > } > > HRESULT WINAPI DllUnregisterServer(void) > { > TRACE("\n"); > - return __wine_unregister_resources( instance ); > + return __wine_unregister_resources(instance); > +} > + > +typedef struct { > + IXAudio2 IXAudio2Impl_iface; > + LONG ref; > +} IXAudio2Impl; > + > +static inline IXAudio2Impl *impl_from_IXAudio2(IXAudio2 *iface) > +{ > + return CONTAINING_RECORD(iface, IXAudio2Impl, IXAudio2Impl_iface); > } > + > +static const struct IXAudio2Vtbl XAudio2_Vtbl; This is not needed. Please move XAudio2_create below the vtbl. > +HRESULT XAudio2_create(IUnknown *pUnkOuter, LPVOID *ppObj) > +{ > + IXAudio2Impl* object; > + > + TRACE("(%p, %p)\n", pUnkOuter, ppObj); > + > + if(pUnkOuter) > + return CLASS_E_NOAGGREGATION; > + > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IXAudio2Impl)); > + if(!object) > + return E_OUTOFMEMORY; > + > + object->IXAudio2Impl_iface.lpVtbl = &XAudio2_Vtbl; > + object->ref = 1; > + > + *ppObj = object; You shouldn't assign object type here, even if the pointer is the same ans interface. Use &object->IXAudio2Impl_iface instead. > + > + return S_OK; > +} > + > +/*** IUnknown methods ***/ > +static HRESULT WINAPI IXAudio2Impl_QueryInterface(IXAudio2 *iface, REFIID riid, void **ppvObject) > +{ > + IXAudio2Impl *This = impl_from_IXAudio2(iface); > + > + TRACE("(%p)->(%s, %p)\n", This, debugstr_guid(riid), ppvObject); > + > + if(IsEqualGUID(riid, &IID_IUnknown) || > + IsEqualGUID(riid, &IID_IXAudio2)) > + { > + IXAudio2_AddRef(iface); > + *ppvObject = iface; > + return S_OK; > + } > + > + ERR("(%p)->(%s,%p), not found\n", This,debugstr_guid(riid), ppvObject); This should be FIXME instead (or WARN, it depends on how likely apps are to call it with an interface that shouldn't be implemented). Also, QI is expected to set ppvObject to NULL on error. Thanks, Jacek

1 0

Re: dlls/winsta: add initial winsta.h (try 2)
by Alexandre Julliard 08 Jun '15

08 Jun '15

Austin English <austinenglish(a)gmail.com> writes: > updated TS_ALL_PROCESSES_INFO to one from > https://msdn.microsoft.com/en-us/library/cc248681.aspx Looks like you forgot that part. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Fail properly for unsupported classes in GetFileInformationByHandleEx
by Marvin 08 Jun '15

08 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13968 Your paranoid android. === wvistau64 (32 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820

2 1

Re: [3/3] advapi32/tests: Add preliminary event tracing tests.
by Marvin 08 Jun '15

08 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13996 Your paranoid android. === w2000pro (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wxppro (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2003std (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wvistau64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2008s64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w7u (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w8 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wvistau64 (64 bit eventlog) === eventlog.c:695: Test failed: Expected failure eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got -559038737 eventlog.c:755: Test failed: Expected ERROR_INVALID_PARAMETER, got 183 eventlog.c:798: Test failed: Expected success === w2008s64 (64 bit eventlog) === eventlog.c:695: Test failed: Expected failure eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got -559038737 eventlog.c:755: Test failed: Expected ERROR_INVALID_PARAMETER, got 183 eventlog.c:798: Test failed: Expected success

1 0

Re: inetcpl: implement default page button (resend)
by Alexandre Julliard 08 Jun '15

08 Jun '15

Jared Smudde <computerwhiz02(a)hotmail.com> writes: > @@ -35,6 +35,7 @@ > WINE_DEFAULT_DEBUG_CHANNEL(inetcpl); > > static const WCHAR about_blank[] = {'a','b','o','u','t',':','b','l','a','n','k',0}; > +static const WCHAR default_home[] = {'h','t','t','p',':','/','/','w','w','w','.','w','i','n','e','h','q','.','o','r','g',0}; This should come from the registry. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msvcirt: Add implementation of streambuf::allocate
by Piotr Caban 08 Jun '15

08 Jun '15

On 06/07/15 20:54, Iván Matellanes wrote: > + return CALL_VTBL_FUNC(this, 40, int, (streambuf*), (this)); The code will be easier to read if you define call_streambuf_doallocate macro and use it here. It would be also nice to change order of allocate and doallocate functions. Cheers, Piotr

1 0

Re: [PATCH 2/2] d3dx9_36: Implement triangle filter when create textures
by Nikolay Sivov 08 Jun '15

08 Jun '15

On 07.06.2015 23:13, Sergey Isakov wrote: > It is probably not triangle filter but works with similar result so I place it in appropriate places. > As well load surface and volume works with DXTn textures now. External conversion is a stub. > The best test will be graphical. See two sscreenshots: textures made by DxTex.exe (from DirectXSDK), one with point filter, second with triangle filter my version. > PS. About copyright. It is my mathematics. (c)Isakov S.L. > > +#ifdef DXTN_COMPESSION_SUPPORTED > + switch (format) > + { > + case D3DFMT_DXT1: > + if (!wined3d_dxtn_supported()) return NULL; > + return encode ? wined3d_dxt1_encode : wined3d_dxt1_decode; This diff is not against wine-git tree, there's no wined3d_dxtn_supported() funtion in wine.

1 0

Re: [PATCH 1/2] d3dx9_36: Implemented D3DXSaveVolumeToFile including DDS files
by Nikolay Sivov 08 Jun '15

08 Jun '15

On 07.06.2015 23:02, Sergey Isakov wrote: > I decided to improve builtin d3dx9_36 library with support of more file > formats, texture formats, volume textures. It's not your work though, it looks to me like 3 or so patches from Christian Costa squashed together. Why didn't you mention it?

1 0

Re: [1/3] ws2_32: Fix uninitialized memory access in do_poll (Coverity).
by Nikolay Sivov 07 Jun '15

07 Jun '15

On 30.05.2015 18:20, Sebastian Lackner wrote: > --- > dlls/ws2_32/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I guess it fixes a warning, but timeout == 0 means no timeout and you don't need a timestamp. select() is the only user of it, and it has this: --- if (ws_timeout) timeout = (ws_timeout->tv_sec * 1000) + (ws_timeout->tv_usec + 999) / 1000; ret = do_poll(pollfds, count, timeout); --- so probably 0 value should be handled differently within a loop, or need to have a separate case that call poll() once and return right away.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel