- wine-devel - winehq.org

Wine GSoC 2015 | mshtml.dll
by Zhenbo Li 18 Mar '15

18 Mar '15

Hello, everyone I'm Zhenbo Li, a college student who participated in GSoC 2014 for mshtml.dll. I'm glad to continue working on mshtml this year. My idea is to implement IHTMLXMLHttpRequest+IHTMLStorage(sessionStorage) as my project. 1.IHTMLXMLHttpRequest ================== XMLHttpRequest is used heavily in AJAX programming.[1] Wine has implemented most of it in msxml component, but it's a stub in mshtml. Most js code doesn't treat wine IE as IE6 or earlier, so they will not choost ActiveX[2] to work around it(like Firebug Lite[3]) My current implementation only works fine for absolute urls[4]. I've located the first obstacle: typedef struct { //... IUri *base_uri; //... } httprequest; After finding a way to pass base_uri from mshtml.dll to msxml3.dll, Wine Gecko should support IHTMLXMLHttpRequest for relative urls[5]. 2. sessionStorage =============== IHTMLStorage[6] is used widely, including Firebug Lite[3]. A well-implemented IHTMLStorage interface should support both sessionStorage and localStorage. I tried to write both of them, but found that it may be necessary to adjust wine-gecko code to support that(Thank Jacek). Therefore, implementing sessionStorage can be the first step of implementing localStorage. This is my idea for GSoC 2015, I appreciate for any comment. Thank you. [1]: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest [2]: http://en.wikipedia.org/wiki/XMLHttpRequest#Support_in_Internet_Explorer_ve… [3]: https://getfirebug.com/firebuglite [4]: http://lzbtesthustoj1000.u.qiniudn.com/xmlhttprequest_absolute_path.html [5]: http://lzbtesthustoj1000.u.qiniudn.com/new_xmlhttp.html [6]: https://msdn.microsoft.com/en-us/library/cc288313%28v=vs.85%29.aspx -- Have a nice day! Zhenbo Li

1 1

Re: [PATCH 7/7] wined3d: Don't use the builtin FFP uniform for the modelview matrix.
by Stefan Dösinger 18 Mar '15

18 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi I've given this only a very quick look. My first impression is that a few things can be split out into separate patches, e.g. get_modelview_matrix. That's a fairly minor thing though. On a somewhat related subject, I think we should check at some point that the state linking still works as intended and doesn't accidentally merge everything together into one huge state that's always updated. Am 2015-03-17 um 15:52 schrieb Matteo Bruni: > @@ -775,6 +777,15 @@ static void shader_glsl_load_constants(void *shader_priv, struct wined3d_context > checkGLcall("glUniform4fv"); > } > > + if (update_mask & WINED3D_SHADER_CONST_FFP_MODELVIEW) > + { > + struct wined3d_matrix mat; > + > + get_modelview_matrix(context, state, &mat); > + GL_EXTCALL(glUniformMatrix4fv(prog->vs.modelview_matrix_location, 1, FALSE, (GLfloat *)&mat)); > + checkGLcall("glUniformMatrix4fv"); > + } > + > if (update_mask & WINED3D_SHADER_CONST_PS_F) > shader_glsl_load_constantsF(pshader, gl_info, state->ps_consts_f, > prog->ps.uniform_f_locations, &priv->pconst_heap, priv->stack, constant_version); Is it a good idea to put this in shader_glsl_load_constants? It may make sense to split fixed function and shader constants into separate functions. We'll never need shader constants and the modelview matrix in the same program. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVCKLoAAoJEN0/YqbEcdMw9wIQAIrMIkc5I9LTRiYnUI+VRAxq wkSX0Uwny7D1sVPCpJxrUu6I04K0u2oWIr0o5XmYQzzETrgthPCsifaHVGlInuaq BfJQCGE1OFEEtFKBtIIB8TCQpMM6dwxYnCc4Zo+rPX2oodJFe9TplJnQw/WUw/Td OeMXNKD316ESUbTa9O5CdMyEcw9+U0TKc2MUGHX5QjGMqKEoYA8wfP+r5VU/dNHo 5hMNenwMawaXgICAsxwQQr/YmCRrUuLvLeAJSCNLGgqSH6v5S4tVmW9tgTjT9Idv RHtFkrsiKg0FKDcyQc1vdmFYtpijE44bM4ULdFCJfIgeRl76Gt0WI17aEZpVvJOx HG5nZsidn/TXwkGWla8CT6k7l4JF8rDNgFbOWkQ7JMTRBThamphABgGR9I57L+9+ mCDUqm775VWpBMHbS4iEM4y1s/K17zDRisd9lbP9JFTOGJ2qT31d3+6Ba4t6FGJR mRZiLE+QVWaScWEJaktC4Cbcl1xKQfu653XdL6YumxRBU5fWBEGZnbSwGh/ePpim YZrC0zHE8E1pVwu6hUfNzahB8L/7P7NoPoWb813NBkk8tul7dCCWcZZ0W75cJgac R0sb4mPaLZ+TrWR4YaQ1jZ66WsABKcDPiGZmAzJpxnCcIVy2uZcC3C3zxXDTQqHZ A3SrlC8X/Vx4iFLg1eD7 =jJVx -----END PGP SIGNATURE-----

2 1

Re: [PATCH 7/7] wined3d: Don't use the builtin FFP uniform for the modelview matrix.
by Henri Verbeet 18 Mar '15

18 Mar '15

On 17 March 2015 at 15:52, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +void get_identity_matrix(struct wined3d_matrix *mat) > +{ > + static const struct wined3d_matrix identity = > + {{{ > + 1.0f, 0.0f, 0.0f, 0.0f, > + 0.0f, 1.0f, 0.0f, 0.0f, > + 0.0f, 0.0f, 1.0f, 0.0f, > + 0.0f, 0.0f, 0.0f, 1.0f, > + }}}; > + > + memcpy(mat, &identity, sizeof(identity)); Shouldn't that just be "*mat = identity;"? And yeah, if you could split this up a bit that would be nice, as it is I think the state handler changes in particular are a bit hard to review properly.

1 0

Re: [PATCH 1/7] wined3d: Report ATI1N and ATI2N volume textures as not supported.
by Henri Verbeet 18 Mar '15

18 Mar '15

On 17 March 2015 at 15:52, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > This causes test failures here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d8.dll -p d3d8_test.exe.so device && touch device.ok ... device.c:6019: Test succeeded inside todo block: Got unexpected hr 0 for format ATI1N, pool D3DPOOL_DEFAULT, size 1x1x1. etc.

1 0

GSoC 2015 proposal
by Iván Matellanes 18 Mar '15

18 Mar '15

Hi devs! I'm a last-year Computer Engineering student from the Basque Country (Spain), and I'd like to take part in the upcoming edition of the Google Summer of Code. I've already explored the wiki and have some ideas to discuss with you. As some of you might remember, I sent some patches back in October/November about msvcrt file operations. If possible, I'd like to continue developing that API since it's the one I'm most comfortable with. I've thought of the following so far: 1. Implement some stream functions from msvcirt: choose some subset of these functions and implement them. 2. Implement internal exception-related functions from msvcrt (like _crt_debugger_hook, __CxxExceptionFilter, and so on): these are needed by several apps apparently, but mostly undocumented. I wonder if low-level details knowledge is required for this task (x86 assembly maybe?). 3. Implement part of the concurrency runtime: having a brief look at the documentation on MSDN, it seems a huge API and I wouldn't really know where to begin. I've worked with OpenMP before, but this one looks like more complex. I'm open to suggestions and new ideas, of course. Thanks for your time, and I look forward to hear your thoughts and comments. And thanks as well to other students who posted their ideas in this list. Best, Iván

2 1

RFC: Add an icon to hh.exe?
by Francois Gouget 18 Mar '15

18 Mar '15

I noticed that winemenubuilder falls back to the default Wine icon for a number of Windows menus, and in particular for all the help / documentation shortcuts. The reason is that we define no default icon for .chm files. On Windows this icon is in hh.exe but in Wine hh.exe has no icon. So would it be ok if I send a patch that copies the winhlp32 default icon and uses that for hh.exe and then .chm files? Is there a way to reuse the winhlp32.exe icon without copying it to programs/hh? Is that actually desired? (it makes programs/hh depend on programs/winhlp32 which we may not want) Do we instead want a different icon? On Windows the hh.exe icon is totally different from the winhlp32.exe one but it's actually absolutely ugly so I don't really want anything like it. Still it's possible to come up with something. Yet another way would be to not add an icon to hh.exe and instead point the .chm default icon to winhlp32.exe. But presumably we'll have to add the hh.exe icon sooner or later anyway so we might as well now. -- Francois Gouget <fgouget(a)codeweavers.com>

2 1

Re: Assorted spelling fixes.
by Henri Verbeet 18 Mar '15

18 Mar '15

On 18 March 2015 at 08:44, Francois Gouget <fgouget(a)free.fr> wrote: > diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c > index 68012ac..f8a74eb 100644 > --- a/dlls/d3d10core/tests/device.c > +++ b/dlls/d3d10core/tests/device.c > @@ -1238,7 +1238,7 @@ struct gs_out > }; > > [maxvertexcount(4)] > -void main(point float4 vin[1] : POSTION, inout TriangleStream<gs_out> vout) > +void main(point float4 vin[1] : POSITION, inout TriangleStream<gs_out> vout) In principle this change is correct, but if you do that it no longer matches the shader bytecode.

1 0

Re: [PATCH] include: Add undocumented theming hook structs to winuser.h.
by Dmitry Timoshkov 18 Mar '15

18 Mar '15

Mark Harmstone <hellas(a)burntcomma.com> wrote: > Adds the undocumented structs to winuser.h which are needed for uxtheme to hook > into user32. As researched by ReactOS: see https://www.reactos.org/wiki/Techwiki:RegisterUserApiHook Referencing reactos as a source of the information makes it unlikely to improve the chances of including the patch in Wine. Moreover, as was already discussed many times, theme interface is completely undocumented and different between Windows versions, therefore it's very unlikely that there is an application that depends on the details of this interface, thus making it unnecessary to duplicate it in Wine. -- Dmitry.

1 0

Re: Assorted spelling fixes.
by Marvin 18 Mar '15

18 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12263 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2557: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2562: Test failed: The focus window is active. device.c:2570: Test failed: Got unexpected hr 0x88760869. device.c:2576: Test failed: Got unexpect screen size 800x600. device.c:2591: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2600: Test failed: Got unexpect screen size 800x600. device.c:2613: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2621: Test failed: Got unexpect width 640. device.c:2622: Test failed: Got unexpect height 480.

1 0

Re: [PATCH] vbscript: Implemented GetLocale(try 2)
by Nikolay Sivov 18 Mar '15

18 Mar '15

On 17.03.2015 11:29, Shuai Meng wrote: > + return return_int(res, GetSystemDefaultLCID()); How did you test that it's system default and not user default or current thread locale?

2 1

Re: [3/4] msvcp120/tests: Add file_size test.
by Piotr Caban 18 Mar '15

18 Mar '15

Hi, On 17/03/15 16:41, YongHao Hu wrote: > +static void test_tr2_sys_file_size(void) > +{ > + unsigned long long val; > + val = p_tr2_sys_file_size("dir/d1/d1f1"); > + ok(val==0, "test fail: file_size is %llu\n", val); The tests needs to pass on wine. You can test your patch by running `make test` in dlls/msvcp120/tests directory. Because of that you can't test a function that is defined as stub in spec file. GetProcAddress will load such function but when called stub will cause an exception. When the function is implemented you can add tests that doesn't work on wine and mark them with todo_wine. Thanks, Piotr

2 1

Re: [PATCH 2/3] ddraw/tests: Port test_color_fill to earlier versions.
by Marvin 18 Mar '15

18 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12260 Your paranoid android. === w8 (32 bit ddraw1) === ddraw1.c:6215: Test failed: Got unexpected color 0x00000000. ddraw1.c:6217: Test failed: Got unexpected color 0x00000000. ddraw1.c:6219: Test failed: Got unexpected color 0x00000000. ddraw1.c:6221: Test failed: Got unexpected color 0x00000000.

1 0

Re: [2/4] msvcp120/tests: Add 64bit and arm's initialization of xtime functions.
by Nikolay Sivov 18 Mar '15

18 Mar '15

On 17.03.2015 18:41, YongHao Hu wrote: > + if(sizeof(void*) == 8) { /* 64-bit initialization */ > + SET(p__Xtime_diff_to_millis2, > + "_Xtime_diff_to_millis2"); > + SET(p_xtime_get, > + "xtime_get"); > + } else { > +#ifdef __arm__ > + SET(p__Xtime_diff_to_millis2, > + "_Xtime_diff_to_millis2"); > + SET(p_xtime_get, > + "xtime_get"); > +#else > + SET(p__Xtime_diff_to_millis2, > + "_Xtime_diff_to_millis2"); > + SET(p_xtime_get, > + "xtime_get"); > +#endif Why do you need this if export name is always the same?

2 1

Re: [PATCH 2/2] d3drm/tests: Add more interfaces for d3drm1_QueryInterface and remove dependency on InitFunctionPtrs().
by Stefan Dösinger 17 Mar '15

17 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-17 um 18:49 schrieb Aaryaman Vasishta: > -static BOOL InitFunctionPtrs(void) > -{ > - d3drm_handle = LoadLibraryA("d3drm.dll"); > - > - if(!d3drm_handle) > - { > - skip("Could not load d3drm.dll\n"); > - return FALSE; > - } > - > - D3DRM_GET_PROC(Direct3DRMCreate) > - > - return TRUE; > -} Removing this is a good change, but it should be in a separate patch. Please do the same for vector.c, in another separate patch. > + { &IID_IDirect3DRM, &IID_IDirect3DRM, S_OK, FALSE }, > + { &IID_IDirect3DRMDevice, NULL, CLASS_E_CLASSNOTAVAILABLE, FALSE }, Minor issue: Is the line misalignment here intentional? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVCJ+8AAoJEN0/YqbEcdMwBw8P/RmJiYSf0C75cddsSSYqZb2v JdPPqOhHHt5kedsMCrV68rYzqTwKpztaFszWiffOyZgEvxMh+a6qoLM2BnfT8mxQ PdNxftnKcsyI0RQCAYOBBBDSS9YXGCs1ohB0sLZIdX5kSgc5M6JGiziPb51rXicW Kv2eJxaYM96YsEXDjw6ShAGCCYByQ/qHVeAmztmGF36FEgH92FzaVdFujGdEz1Px nG4trHla0OYmVk9Q6Pppd3LA4KOBvbdYhPM5DHqNOk7FVNRGfdKi7ZjWUnP11Kc3 NXSZE2koQXpPYYtVNVKSr244mLmJjqNjXlHwPa42LQ3cwUnoqVBqCwvXaFlnu/CE R/gsDbHoUnWoMBbHZc5MUxRS+zDXXjAsKdbPBI4sDQQI8XoXNLoGudW05VjFXb1w qQObPWTLs62j8u8iHyJ+GpVyohaqtixX6i4P8uBjS7X+sOCyuR6bC9s4w1HPeP6A 04O3IwzE2+E6xV6sFeJj7Ibu8OCy96zJ/dKnH/iorI9kGdl5amQBvCjhROw20b8D ApXallY+3p44RFqNis/xHvqYxVXRzqMu7ZQAjm77jXNAvC96n2iMYmgdGRLth5Of Mxzw6NOWXnT6g9D/h6G+VtLrIWHXS/4ExaKoIIpyyqK1JNSSRLbeHQCrpLUpm4ks sTiU6Hr+oM1c/H7+Tlg2 =x4GY -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/2] d3drm/tests: Add more interfaces for d3drm1_QueryInterface and remove dependency on InitFunctionPtrs().
by Aaryaman Vasishta 17 Mar '15

17 Mar '15

Made d3drm use wine's implementation instead of loading dll at runtime. On Tue, Mar 17, 2015 at 11:19 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > --- > dlls/d3drm/tests/Makefile.in | 2 +- > dlls/d3drm/tests/d3drm.c | 132 > +++++++++++++++++++++++++++---------------- > 2 files changed, 84 insertions(+), 50 deletions(-) > > diff --git a/dlls/d3drm/tests/Makefile.in b/dlls/d3drm/tests/Makefile.in > index dc6e8d1..b5fdb56 100644 > --- a/dlls/d3drm/tests/Makefile.in > +++ b/dlls/d3drm/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = d3drm.dll > -IMPORTS = dxguid ddraw user32 uuid > +IMPORTS = d3drm dxguid ddraw user32 uuid > > C_SRCS = \ > d3drm.c \ > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index f9925ae..edc451b 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -26,9 +26,6 @@ > > #include "wine/test.h" > > -static HMODULE d3drm_handle = 0; > - > -static HRESULT (WINAPI * pDirect3DRMCreate)(IDirect3DRM **d3drm); > > #define CHECK_REFCOUNT(obj,rc) \ > { \ > @@ -37,28 +34,6 @@ static HRESULT (WINAPI * pDirect3DRMCreate)(IDirect3DRM > **d3drm); > ok(count == rc_new, "Invalid refcount. Expected %d got %d\n", > rc_new, count); \ > } > > -#define D3DRM_GET_PROC(func) \ > - p ## func = (void*)GetProcAddress(d3drm_handle, #func); \ > - if(!p ## func) { \ > - trace("GetProcAddress(%s) failed\n", #func); \ > - FreeLibrary(d3drm_handle); \ > - return FALSE; \ > - } > - > -static BOOL InitFunctionPtrs(void) > -{ > - d3drm_handle = LoadLibraryA("d3drm.dll"); > - > - if(!d3drm_handle) > - { > - skip("Could not load d3drm.dll\n"); > - return FALSE; > - } > - > - D3DRM_GET_PROC(Direct3DRMCreate) > - > - return TRUE; > -} > > static int get_refcount(IUnknown *object) > { > @@ -242,7 +217,7 @@ static void test_MeshBuilder(void) > D3DCOLOR color; > CHAR cname[64] = {0}; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = IDirect3DRM_CreateMeshBuilder(d3drm, &pMeshBuilder); > @@ -538,7 +513,7 @@ static void test_MeshBuilder3(void) > DWORD size; > CHAR cname[64] = {0}; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > if (FAILED(hr = IDirect3DRM_QueryInterface(d3drm, &IID_IDirect3DRM3, > (void **)&d3drm3))) > @@ -644,7 +619,7 @@ static void test_Mesh(void) > DWORD size; > CHAR cname[64] = {0}; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = IDirect3DRM_CreateMesh(d3drm, &mesh); > @@ -685,7 +660,7 @@ static void test_Face(void) > CHAR cname[64] = {0}; > int icount; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = IDirect3DRM_CreateFace(d3drm, &face1); > @@ -925,7 +900,7 @@ static void test_Frame(void) > DWORD count; > CHAR cname[64] = {0}; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = IDirect3DRM_CreateFrame(d3drm, NULL, &pFrameC); > @@ -1257,7 +1232,7 @@ static void test_Viewport(void) > window = CreateWindowA("static", "d3drm_test", WS_OVERLAPPEDWINDOW, > 0, 0, 300, 200, 0, 0, 0, 0); > GetClientRect(window, &rc); > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = DirectDrawCreateClipper(0, &pClipper, NULL); > @@ -1308,7 +1283,7 @@ static void test_Light(void) > DWORD size; > CHAR cname[64] = {0}; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = IDirect3DRM_CreateLightRGB(d3drm, D3DRMLIGHT_SPOT, 0.5, 0.5, > 0.5, &light); > @@ -1363,7 +1338,7 @@ static void test_Material2(void) > DWORD size; > CHAR cname[64] = {0}; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > if (FAILED(hr = IDirect3DRM_QueryInterface(d3drm, &IID_IDirect3DRM3, > (void **)&d3drm3))) > @@ -1447,7 +1422,7 @@ static void test_Texture(void) > DWORD size; > CHAR cname[64] = {0}; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > initimg.buffer1 = &pixel; > @@ -1488,7 +1463,7 @@ static void test_Device(void) > window = CreateWindowA("static", "d3drm_test", WS_OVERLAPPEDWINDOW, > 0, 0, 300, 200, 0, 0, 0, 0); > GetClientRect(window, &rc); > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = DirectDrawCreateClipper(0, &pClipper, NULL); > @@ -1551,7 +1526,7 @@ static void test_frame_transform(void) > IDirect3DRMFrame *frame; > D3DRMMATRIX4D matrix; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > hr = IDirect3DRM_CreateFrame(d3drm, NULL, &frame); > @@ -1589,7 +1564,7 @@ static void test_d3drm_load(void) > D3DRMLOADMEMORY info; > const GUID* req_refiids[] = { &IID_IDirect3DRMMeshBuilder, > &IID_IDirect3DRMFrame, &IID_IDirect3DRMMaterial }; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > info.lpMemory = data_d3drm_load; > @@ -1665,7 +1640,7 @@ static void test_frame_mesh_materials(void) > IDirect3DRMTexture *texture; > int i; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Direct3DRMCreate returned %x\n", hr); > > info.lpMemory = data_frame_mesh_materials; > @@ -1736,7 +1711,7 @@ struct qi_test > }; > > static void test_qi(const char *test_name, IUnknown *base_iface, > - REFIID refcount_iid, const struct qi_test *tests, > UINT entry_count) > + REFIID refcount_iid, const struct qi_test *tests, UINT > entry_count) > { > ULONG refcount, expected_refcount; > IUnknown *iface1, *iface2; > @@ -1788,15 +1763,79 @@ static void test_d3drm_qi(void) > { > static const struct qi_test tests[] = > { > - { &IID_IDirect3DRM3, &IID_IDirect3DRM3, S_OK, TRUE }, > - { &IID_IDirect3DRM2, &IID_IDirect3DRM2, S_OK, TRUE }, > - { &IID_IDirect3DRM, &IID_IDirect3DRM, S_OK, FALSE }, > - { &IID_IUnknown, &IID_IDirect3DRM, S_OK, FALSE }, > + { &IID_IDirect3DRM3, &IID_IDirect3DRM3, S_OK, > TRUE }, > + { &IID_IDirect3DRM2, &IID_IDirect3DRM2, S_OK, > TRUE }, > + { &IID_IDirect3DRM, &IID_IDirect3DRM, S_OK, > FALSE }, > + { &IID_IDirect3DRMDevice, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMObject, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMObject2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMDevice2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMDevice3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMViewport, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMViewport2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFrame, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFrame2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFrame3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMVisual, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMesh, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMeshBuilder, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMeshBuilder2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMeshBuilder3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFace, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFace2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMLight, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMTexture, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMTexture2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMTexture3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMWrap, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMaterial, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMaterial2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimation, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimation2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimationSet, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimationSet2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMObjectArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMDeviceArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMViewportArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFrameArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMVisualArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMLightArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMPickedArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFaceArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimationArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMUserVisual, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMShadow, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMShadow2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMInterpolator, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMProgressiveMesh, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMPicked2Array, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMClippedVisual, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawClipper, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface4, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw4, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DLight, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IUnknown, &IID_IDirect3DRM, S_OK, > FALSE }, > }; > HRESULT hr; > IDirect3DRM *d3drm; > > - hr = pDirect3DRMCreate(&d3drm); > + hr = Direct3DRMCreate(&d3drm); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > > test_qi("d3drm_qi", (IUnknown *)d3drm, &IID_IDirect3DRM, tests, > sizeof(tests) / sizeof(*tests)); > @@ -1806,9 +1845,6 @@ static void test_d3drm_qi(void) > > START_TEST(d3drm) > { > - if (!InitFunctionPtrs()) > - return; > - > test_MeshBuilder(); > test_MeshBuilder3(); > test_Mesh(); > @@ -1823,6 +1859,4 @@ START_TEST(d3drm) > test_d3drm_load(); > test_frame_mesh_materials(); > test_d3drm_qi(); > - > - FreeLibrary(d3drm_handle); > } > -- > 1.9.3 (Apple Git-50) > >

1 0

Re: winemenubuilder - MIME type handling GSoC - bad idea
by Rosanne DiMesio 17 Mar '15

17 Mar '15

On Sun, 15 Mar 2015 16:03:21 +0100 Michael Müller <michael(a)fds-team.de> wrote: > > Maybe Rosanne can share her opinion on this topic, since she has more > contact with users complaining about this "feature". > I'm not the least bit qualified to say what would or wouldn't be a good GSoC project, but if you're asking whether I think users would benefit from adding elaborate controls to winecfg that duplicate functions already provided by the desktop environment's tools, the answer is no. I agree with Damjan that those settings should be controlled through the host system, not Wine, and users need to learn how to use the configuration tools provided by their DE. I also see a significant downside to trying to control mimetype associations in winecfg: configuring would have to be done individually for each and every wineprefix. That's more work, not less, and speaking as a user with multiple wineprefixes, a headache I'd rather not have. As for bug 19182, the OR never asked for the complicated controls people have been proposing lately; all he wanted was a user-friendly way to completely disable mimetype associations and menu entries. A simple checkbox on the desktop integration tab to disable winemenubuilder would accomplish that.

5 6

GSoC Implement OpenMP
by lijianwei 17 Mar '15

17 Mar '15

HI I'm a graduate student of Northwestern Polytenical University.I have been studing on paralle for two year.So,I can fix the bug Implement OpenMP. But,How can I attend your program. Best Regard Jianwei

1 0

Re: [quick-hack] Sims 2 launch fix, vertex shaders from 256 to 4096
by Henri Verbeet 17 Mar '15

17 Mar '15

On 17 March 2015 at 10:03, Chris Giles <drathian(a)gmail.com> wrote: > Originally idea by Robert Showalter, adapted to later wine versions by Luke > Horwell, altered by me. Windows emulates 8192 vertex shaders, sims 2 > requires at least half that to launch properly (although it is only supposed > to ask for 1024), the blue texture glitches exist with this, can be futher > debugged. Bug 8051, discussion previewed in > https://appdb.winehq.org/objectManager.php?sClass=version&iId=2633 > As it is, the patch is just wrong. But if it actually works, and you can write the corresponding tests to show that it's correct, just not applying the D3D9_MAX_VERTEX_SHADER_CONSTANTF clamp on SWVP devices would probably be fine.

1 0

Re: [PATCH] vbscript: Implemented GetLocale(try 2)
by Marvin 17 Mar '15

17 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12234 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: user32/tests: Add tests for removing already seen messages from the queue.
by Marvin 17 Mar '15

17 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12229 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0017014A msg.c:12252: Test failed: bad time 309b0/309c0

1 0

An issue with msvcp110 test's design
by YongHao Hu 16 Mar '15

16 Mar '15

Hi, all Thanks for Piotr's comment on my GSOC ideas. In order to have a good knowledge of functions from tr2 namespace, I had made a test and written some functions' implementation. However, I had an issue with msvcp test's design when I need to free library of msvcp90 and load msvcp110. 619 static HMODULE msvcr, msvcp; 620 #define SETNOFAIL(x,y) x = (void*)GetProcAddress(msvcp,y) 621 #define SET(x,y) do { SETNOFAIL(x,y); ok(x != NULL, "Export '%s' not found\ n", y); } while(0) In my patch, I use a hmodule variable named msvcp90 to save msvcp90 hmodule and then reuse msvcp to save msvcp110. As far as I am concerned, the name msvcp90 or msvcp90_saver is not good enough. Could you give it a good name? And the other method I came up with is undefining SETNOFAIL and SET and using msvcp110 to define it again, which I think is ugly. By the way, my crosstest on all the testbots[1] show that msvcp110.dll or msvcrt110.dll not installed. It seems testbot doesn't install msvcp110. I will be grateful for any advice you can provide. [1]: https://testbot.winehq.org/JobDetails.pl?Key=12146&log_110=1#k110

5 6

Re: [PATCH] ddraw: Add validation and tests for DDBLT_ROP (v2).
by Marvin 16 Mar '15

16 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12219 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9/tests: Add a test for UpdateTexture.
by Stefan Dösinger 16 Mar '15

16 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-10 um 19:29 schrieb Matteo Bruni: > + /* This works on AMD but fails on Nvidia (it draws black). > */ + /* {8, 8, 8, 8, 4, 4, D3DFMT_A8R8G8B8, D3DFMT_R5G6B5}, > */ /* Different format */ What does AMD draw in this case? Does it convert the format from A8R8G8B8 to R5G6B5 like StretchRect would? Or does it just memcpy? In the latter case I'd expect a memory corruption due to the size mismatch. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVAA/0AAoJEN0/YqbEcdMwKlcP/RVMf9nx/D4Emx4Viu9U3iGZ P1XV8AvAjKxJ/BNQ58HGCVH+9X3GXLLOJiv3H5CanOt7MxpwT+MX9hADYz9aZZTr lo45Gp5H4i2d9X2fNNNTcoY7y0lYV1R3YCEcSiQlick3o/0KTXPV5a6+m+Z1QDcV hlSjkj0SpZICVpzUwuU/FQuSyKE/ihcyZNGwtfxt+q+QdJDPzDp86QBV+s80snKD Yzsif4pAU2bLzrrM181qsRv0MB8mvfmfT25gPtjrZq5JekRe+WWhZ2uLrqQhkxAH y6A3TeVuIiRY0qwOMe05eEXAEZjLxDswJJDD7fLps3XcYYkpbIBLECjNqHhEFtK1 7DCjb7nQtJBFy+cX4ZBxRZ6X15Rsri6iQfP04e2/V44JWZrO6EHQvEybUw2i57+Y R1yLsf3KzDzpcy9At7gH4sFIvjDfuCROlblsdYmEwacwq+rO8kyRI6DhixPRtWDG beW6eMRUAVVyeQvXVCuLW6uPIpWuEdpmQZ7neug1YFfdqsG4YfR76RgQv6Gkj32V f3G/wGri8fF6PUWavZscdVdcD51LbkUQRyNy8CpRpxJe5AABGaecVj+nirskoKEo qFXcWxSUK5YHQ055WWn0UwQ2NabX62FNTki35tNqbZru/iivVbsEb4kcYeaYsMe9 TZrdk2aXSVrmHbd52LSi =xL1U -----END PGP SIGNATURE-----

2 7

Re: [PATCH 5/5] ddraw/tests: Add tests for DDBLT_ROP.
by Matteo Bruni 16 Mar '15

16 Mar '15

2015-03-16 14:48 GMT+01:00 Stefan Dösinger <stefan(a)codeweavers.com>: > --- > dlls/ddraw/surface.c | 16 ++++++++ > dlls/ddraw/tests/ddraw7.c | 98 +++++++++++++++++++++++++++++++++++++++-------- > 2 files changed, 98 insertions(+), 16 deletions(-) This patch also changes the implementation while the title suggests only additions to the tests. This might come as a surprise a few months down the line in the (admittedly unlikely) case this causes regressions or something similar, so I'd either change the name of the patch or split the implementation change from the test part. Again, it's not that important in this specific case so I don't care much.

2 1

Re: [PATCH] wine.inf: Add some knownfolders to the registry
by Alexandre Julliard 16 Mar '15

16 Mar '15

Andrew Eikum <aeikum(a)codeweavers.com> writes: > This time with a cleaned up win8 testbot. > > dlls/shell32/tests/shellpath.c | 212 ++++++++++++++++++++--------------------- > loader/wine.inf.in | 24 +++++ > 2 files changed, 129 insertions(+), 107 deletions(-) Shouldn't this be generated from the data we already have in shell32? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] dsound: Apply filters before sound is multipled to speakers.
by Andrew Eikum 16 Mar '15

16 Mar '15

On Sun, Mar 15, 2015 at 05:51:32PM +0000, Mark Harmstone wrote: > - for (i = 0; i < count; i++) > - for (channel = 0; channel < dsb->mix_channels; channel++) > - dsb->put(dsb, i * ostride, channel, get_current_sample(dsb, > - dsb->sec_mixpos + i * istride, channel)); > + float* buf; > + > + buf = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, count * dsb->mix_channels * sizeof(float)); Is it necessary to zero this buffer? I think the whole thing gets overwritten in the following lines. I'm a bit concerned that splitting the processing out into another buffer will affect performance. Similarly in the resampling case below, you're adding another loop over every sample. We already have a performance issue introduced by the higher quality resampler: https://bugs.winehq.org/show_bug.cgi?id=30639 Could we take the slower path in each case only if we have filters to apply? BTW do you have an application that uses DMOs? I'd be curious to take a look and add it to my list of dsound test applications. Andrew

1 0

Re: d3drm: Add tests for querying between IDirect3DRM interfaces
by Stefan Dösinger 16 Mar '15

16 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-15 um 11:45 schrieb Aaryaman Vasishta: > + hr = IUnknown_QueryInterface(base_iface, tests[i].iid, (void > **)&iface1); It looks like your mail client line-wrapped the patch. Unfortunately it won't apply this way :-( . > + if (!GetProcAddress(GetModuleHandleA("d3drm.dll"), "Direct3DRMCreate")) > + { > + win_skip("Direct3DRMCreate not available, skipping test.\n"); > + return; > + } You should not need this. If Direct3DRMCreate is not available InitFunctionPtrs() will return false and your test is never run. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVBWQHAAoJEN0/YqbEcdMwq/IP/20pRxWk3tYXzbZmKILCNH65 JRTlm/fvqtO/Q+Q1C57WkOMiusE2w4i25/AQNsaIYOW/e8nATIGni3PPRlK6v9gT /JzzntJLD0I4mEOBxrZvnQhQ3iZ91YMla+Sg326b3PkwONEfkWhORP4YGrkt75is 5YNCKVZG/msPT7IxUIbZji7K8McDEX/OsLLFEFDr3mg4i5z7WMxAJVBIxOGuN8re 2N2TKGfcWLEIaE5Hpyh+r9xYbS8x7JyIN5md5EdQrnBR/9KMn18VFLWX3u+4jfm3 o8uGOjhhOUqjjtzYomRe317l3ujtqjora6xNZ5upGrcxwBWSZKDB5gk233o/62W4 FJuHGeHnCaUgctBUYQstFHr9FsBFt3KkgFqhds3nnSz4MF3/I46+X7KprCiAIaMZ q/YNasm8lGGAdNZp5DkViq9K06umOG7iz+21XY+dP9hRrTVqq11eEqEmveqRHU2+ GuOiNcKeo45Sj+4yl+r78fD3JNN2Ltki3O/z/KVjfE2aE+e5cHKn1oGAEFUaGzDl zHd2KcI6W6e6eDy3qgo8TezfiQYogQzTriyVd9Kyxi9CxKAVnZOrskKoFj2tT3M4 PEn2qX13OtcBcIaO83QJdHtwxg1g3yQ771uIPK0MHU1zjSHAz2sHf+amn6/gF8N+ MT9amN40cQrxGXpaplzm =d/6Z -----END PGP SIGNATURE-----

3 2

Re: vcomp: Add _vcomp_enter_critsect, _vcomp_leave_critsect, omp_init_lock stubs
by Michael Stefaniuc 16 Mar '15

16 Mar '15

Hello Andrey, On 03/14/2015 03:00 PM, Andrey Gusev wrote: > Based on an old patch from Dan Kegel with the addition. > Fixes https://bugs.winehq.org/show_bug.cgi?id=36457 > > vcomp-Add-_vcomp_enter_critsect-_vcomp_leave_critsec.txt you can't just stub out locking functions. It is far superior to have a program crash straight ahead than to silently corrupt data. That's the reason the initial submission by Dan was rejected. I don't find any documentation on a quick search for this functions. But they look to me just like wrappers around the standard EnterCriticalSection / LeaveCriticalSection functions. You could try that out and see if your application is happy with that. bye michael > > > From b4c7617b344ee0dcdb058030b19ede5101787824 Mon Sep 17 00:00:00 2001 > Message-Id: <b4c7617b344ee0dcdb058030b19ede5101787824.1426341234.git.andrey.goosev(a)gmail.com> > From: Andrey Gusev <andrey.goosev(a)gmail.com> > Date: Sat, 14 Mar 2015 15:53:29 +0200 > Subject: [PATCH] vcomp: Add _vcomp_enter_critsect, _vcomp_leave_critsect, > omp_init_lock stubs > > --- > dlls/vcomp/main.c | 15 +++++++++++++++ > dlls/vcomp/vcomp.spec | 6 +++--- > 2 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/dlls/vcomp/main.c b/dlls/vcomp/main.c > index ab2a372..3c43a4e 100644 > --- a/dlls/vcomp/main.c > +++ b/dlls/vcomp/main.c > @@ -71,6 +71,11 @@ double CDECL omp_get_wtime(void) > return GetTickCount() / 1000.0; > } > > +void CDECL omp_init_lock(int lock) > +{ > + TRACE("(%d): stub\n", lock); > +} > + > void CDECL omp_set_dynamic(int val) > { > TRACE("(%d): stub\n", val);

1 0

Re: [PATCH 1/2] riched20: Implement IOleWindow interface.
by Nikolay Sivov 16 Mar '15

16 Mar '15

On 16.03.2015 10:36, Jactry Zeng wrote: > + create_interfaces(&w, &reOle, &txtDoc, NULL); > + hres = IRichEditOle_GetClientSite(reOle, &clientSite); > + ok(hres == S_OK, "IRichEditOle_QueryInterface: 0x%08x\n", hres); > + refcount1 = get_refcount((IUnknown *)clientSite); > + todo_wine ok(refcount1 == 1, "got wrong ref count: %d\n", refcount1); > + > + hres = IOleClientSite_QueryInterface(clientSite, &IID_IOleClientSite, (void **)&clientSite1); > + ok(hres == S_OK, "IOleClientSite_QueryInterface: 0x%08x\n", hres); > + ok(clientSite == clientSite1, "Should not return a new pointer.\n"); > + refcount1 = get_refcount((IUnknown *)clientSite); > + todo_wine ok(refcount1 == 2, "got wrong ref count: %d\n", refcount1); Hi, Jactry. Do we have a test somewhere showing that IRichEditOle cannot be queried directly for IOleClientSite and IOleWindow?

2 2

Re: [PATCH 2/2] riched20: Implement IOleWindow::GetWindow.
by Nikolay Sivov 16 Mar '15

16 Mar '15

On 16.03.2015 10:36, Jactry Zeng wrote: > static HRESULT WINAPI IOleWindow_fnGetWindow(IOleWindow *iface, HWND *phwnd) > { > IOleClientSiteImpl *This = impl_from_IOleWindow(iface); > - FIXME("not implemented: (%p)->(%p)\n", This, phwnd); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, phwnd); > + *phwnd = This->reOle->editor->hWnd; > + return S_OK; > } Could you add a test for NULL argument too?

1 0

GSoC WINE -Deep Learning with Caffe & OpenCV Proposal
by Yida Wang 16 Mar '15

16 Mar '15

Posted by Yida Wang Passion with OpenCV and other Open Source Communities Hello, I am Yida Wang, a first year Master Student in Pattern Recognition of PRIS Lab in SICE school of BUPT. I have wonderful experience with OpenCV and several other open source communities. I have won the 1st prize in Scilab Open Source Contest 2014 and Excellent Developer in CSDN Summer of Code 2014 in BladeRF commmunity. All certificate could be provided if it is necessary. As for WINE project, I have developed a PCANet structure to automatically match opencv source figures with Microsoft figures sot that the editor in linux platform could match the correct figure copied from Microsoft Office. This time I think it is convenient to use Caffe and OpenCV for deep learning and other CV issues for some pattern recognition applications. I have also own an Nvidia K40 GPU donated by Nvidia for research, I think I can extend the package for GPU calculation! Motivation for Proposal Framework in Computer Vision- Deep Learning Project I’m Concentrating on Deep Learning coding with OpenCV and other open source project like Caffe and cuDNN for a period of time. My project contains two meaningful contents, the 1st one is a BP algorithm eliminated CNN structure which is far less time consuming than traditional CNN and the 2nd one is an entire Deep Leaning structure on image recognition based on Caffe. New Idea for a Fast CNN My idea is based on the thriving pattern recognition method called ’Deep Neural Networks ’ which has been used by Google to build the amazing recognition structure last year. As Deep Neural Network behaves amazingly in pattern recognition, there are already useful tools such as Caffe being implemented for research. Some of the useful codes could be modified and embedded in OpenCV for the development of DNN. But at the same time, the problem lies in the dependence on hardware such as powerful GPU which is not easy to be got by ordinary people. The time consuming process is mainly caused by 2 points: the Randomness of the convolutional kernel and the countless back propagation step. I have been studying on a powerful single direction fast CNN called PCANet for research and commercial use. Here are some benefit in such structure: 1. Such structure hasn’t the BP algorithm used in DNN which cost much operation. 2. It has some tiny PCA filters instead. The filters’ shape is just like the shape in the training results of normal CNN. 3. My structure could be used in initiating the CNN in the future to optimize the training time in CNN. 4. Combination of Caffe and PCANet in WINE The ‘blob’ structure defined in Caffe is clear for the layer based CNN and the input data of convolution kernel and bias in one layer could be replaced by the PCANet filter for initialization. So the modified structure combined with Caffe and PCANet could be powerful both in speed of convergence and recognition stability with the help of OpenCV. So my idea consists 2 stage: PCANet implementation and Caffe modifying for OpenCV. The 1st direction called Fast-CNN(CellNet) My 1st idea is an implementation of PCANet which has different structure of local filters learning from different databases while holding the stability and generality of general CNN at the same time. Here is the General model of PCANet: I have been using this algorithm in one of the most difficult face database called ‘LFW’ and achieves 92% recognition rate with just this algorithm alone. My friend Qian Hong, has guild me to help him solve the general figure recognition problem recently to reduce the human labor cost in selecting the most likely figure in open source figure database to the Microsoft official figure. I use PCANet for such problem with particular parameters and got the result partly shown below: Target database Open source database The matching result shows the accuracy of PCANet, they are all extract from raw database, and there are many shape alike matches. My algorithm just could select the best substitute. Now I have modified the structure for general visual object classification problems and join the Detection-Feature extraction-Classification process together into an entire extension neural network both for my study and the project itself. By attempting to modify my previous Matlab codes about CellNet into C++ codes with the help of OpenCV(especially in Matrix operations), I could get some raw features extracted from a photo through the network these days. The performance is still as excellent as I mentioned last few weeks, but I am concerning about another confusion related to what you have told me. The 2nd direction: Modifying Caffe with OpenCV in WINE In fact besides studying in artificial architecture, I am also research in normal neural networks at the same time, so came the 2nd content I just showed. Deep learning is powerful indeed, it could exceed the human capabilities in the future due to Big Data and fast 2-D computation (including GPU). But the complex back and forth process cost really much even in the future. So I am still searching the better solution between one-way network and two-way network. I noticed that OpenCV has posted that it would be cool if OpenCV could load and run deep networks trained with popular DNN packages like Caffe or Torch. I am glad to hear that because I am also doing some experiment on CNN with Caffe. Than there are some main task to be done in the future: 1. Modify the Caffe’s data structure with OpenCV, especially the ‘blob’ structure defined in Caffe. The layer really appears more clear with the help of ‘blob’, but the basic element could be more flexible with the OpenCV data structure. 2. Some prerequisites should be simplified including BLAS & Boost. We may just need some basic dependencies to form a CNN. 3. Whether including GPU calculating process is under consideration due to the short time. Conclusion Just as described in detail, my idea is composed of a fast DNN which is almost completed and a Caffe based DNN. I attached the paper describing the fast DNN called “PCANet”. The source code is published on Github with the name of CellNet with the URL: https://github.com/Wangyida/CellNet As for the Caffe based DNN, I thought it is much more easy to develop a CPU version rather than a GPU version at first. I am worried about that the time might not be enough to apply OpenCV on Caffe without bugs from now on though there are already some utilizations of OpenCV in Caffe. I wonder if the idea is meaningful enough? Especially the 1st part.

2 1

GSOC-2015 Tools - Implement resource editor and / or dialog editor
by Rukshan Chathuranga 16 Mar '15

16 Mar '15

Hi Marcus Meissner and André Hentschel, I'm rukshan chathuranga from university of moratuwa, Sri Lanka. I'm hope to apply to GSOC 2015 with Wine project. For that i hope to work with "Tools - Implement resource editor and / or dialog editor" project. Because i have C/C++/QT/QML programming experience. Also i am seeking more information and requirement about this topic. Can you help me to understand the scope well? Thanks and regards. *Rukshan Chathuranga.* *Department Of Computer Science & Engineering,* *Faculty Of Engineering,* *University Of Moratuwa. **Sri Lanka.* *WEB: http://www.rukspot.com/ <http://rukspot.com/>*

1 0

Re: winemenubuilder - MIME type handling GSoC - bad idea
by Damjan Jovanovic 16 Mar '15

16 Mar '15

Hi I welcome this discussion. Of course manually deleting files in ~/.local is not user friendly, and it was never intended to be done that way. I did not write the part of the Wiki entry suggesting that applet :-). If you install a Windows app on Windows, and it creates menus and file associations, you don't get to opt out, and have to use a 3rd party tool to edit or delete those afterwards. If you install a Linux app on Linux, and it creates menus and file associations, you also don't get to opt out, and have to use a 3rd party tool (a Freedesktop menu/association editing tool) to edit or delete those afterwards. Why is Wine so special? What are people actually looking for? For Wine not to create menu/associations when running on a non-"~/.wine" WINEPREFIX? For a way to stop the annoying use of Wine's "Internet Explorer" to open jpeg files? Anything else? BTW you don't need distro binfmt handlers to double-click .exe (and .msi and .lnk) files: Wine's tools/wine.desktop handles those. You only need binfmt handlers to run .exe directly from the command line - when you aren't in a desktop where you can use "xdg-open /path/to/file.exe". I suspect the Ubuntu package installs a binfmt handler because it doesn't know that. Regards Damjan On Sun, Mar 15, 2015 at 5:03 PM, Michael Müller <michael(a)fds-team.de> wrote: > Hi Damjan, > > the idea of the GSOC project is to make the mime type association more > user friendly for ordinary users. Manually deleting files in > ~/.local/share/mime/ (which some users don't even find because it is a > hidden folder) or requiring a 3rd party program is not user friendly. If > Wine creates these associations it should also provide you with a way to > get rid of them. Even the wiki entry mentions that an applet would be > useful to manage these associations. > > There is also no obvious way to disable the integration, there is no > checkbox or something like this in winecfg, you will need to lookup that > winemenubuilder is the component responsible for this and disable it > manually with library overrides. We are talking about users who use wine > by double clicking on an executable (using the binfmt handler installed > by their distro) or by using a menu entry and who wonder why all their > txt files now open with notepad and how to get rid of this. > > There is also no easy and obvious way to create mime types only for a > specific program, i.e. disable the integration but later decide to > enable it only for Word and .doc* files. There might be different > solutions for this problem, but I think you can't deny that there is > something going wrong if you get a bug report with 72 comments and 4 > duplicates. Arguing that providing a way to disable the integration > again would be a new feature and not a bug fix doesn't help us in this > case. If you have better ideas how to make the integration more user > friendly, feel free to share them with us, but your comments didn't > convince me so far that this GSOC idea is bad. > > Maybe Rosanne can share her opinion on this topic, since she has more > contact with users complaining about this "feature". > > Regards, > Michael > > Am 15.03.2015 um 11:02 schrieb Damjan Jovanovic: >> Hi >> >> As the author of most of winemenubuilder, I am disappointed at how >> poorly understood it remains. >> >> The "Winecfg / winemenubuilder - enhance MIME type handling" GSoC idea >> suggests "The idea of this task is to provide a GUI (most probably as >> part of winecfg) to control the creation of such MIME type assignments >> and therefore making Wine more user friendly." >> >> If you read about the design of winemenubuilder's file associations on >> http://wiki.winehq.org/FileTypesIntegration you'll see that >> winemenubuilder logs each file association mapping to the registry on >> creation, and doesn't recreate it if it's already in the registry and >> the .desktop file is gone. This allows you not just to customize and >> delete file associations by editing the registry, but also by editing >> the Freedesktop associations (and menus btw) with Freedesktop tools - >> .desktop files you've deleted in those tools won't be recreated by >> Wine (unless you uninstall and reinstall the Windows app). >> >> I believe people have been spoiled by installing everything through >> their distro package manager, and thus don't know about/use >> Freedesktop menu/association editing tools, so they now expect Wine to >> do something that even Windows doesn't. >> >> If Freedesktop tools don't let you edit file associations, surely >> that's a missing feature in those tools, not a GSoC project in Wine? >> Additionally Windows apps for editing menus and file associations >> (example list at http://forums.techarena.in/tips-tweaks/989159.htm) >> should work under Wine. >> >> Thank you >> Damjan >> >

2 1

Re: [2/2] ws2_32/tests: Check the OOB mark in the right place
by Marvin 15 Mar '15

15 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12177 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: d3drm: Add tests for querying between IDirect3DRM interfaces
by Marvin 15 Mar '15

15 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12174 Your paranoid android. === build (build) === Patch failed to apply

1 0

Subtle Denial of Medical Treatment by the Singapore Government for Mr. Teo En Ming (Zhang Enming)
by Teo En Ming (Zhang Enming) 15 Mar '15

15 Mar '15

Dear Sir/Madam, Please refer to the following PDF document: http://oss.clusterlabs.org/pipermail/pacemaker/2015-March/023574.html It is a very important letter. Please read the letter very carefully, word by word. The letter details how the Singapore Government led by Prime Minister Lee Hsien Loong has *subtly* denied me medical treatment for ***suspected*** coronary heart disease. Thank you very much. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) Singapore Citizen

1 0

Testing
by Teo En Ming (Zhang Enming) 15 Mar '15

15 Mar '15

Testing -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) Singapore Citizen

1 0

Re: combase: implement WindowsSubstring
by Marvin 15 Mar '15

15 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12173 Your paranoid android. === w8 (32 bit string) === string.c:258: Test failed: Duplicated string created new string

1 0

Re: [PATCH] vbscript: Implemented GetLocale
by Nikolay Sivov 15 Mar '15

15 Mar '15

> +static HRESULT Global_GetLocale(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > +{ > + return return_int(res, GetACP()); > +} This looks completely wrong. Docs say it should return locale id (as name suggests), not a codepage value.

2 1

Re: [PATCH] d3d9/tests: Extend the colorfill test (v2).
by Alexandre Julliard 15 Mar '15

15 Mar '15

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This supersedes patch 109855. > > Version 2: Don't check the fill value of D3DFMT_P8. The testbot deviates > from real HW. I could mark it broken, but it doesn't seem worth the > effort because the format is essentially useless. It can only be used > for ColorFill and StretchRect between P8 surfaces. It doesn't work here (GeForce 320M, Nouveau driver): ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so visual && touch visual.ok visual.c:904: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_YUY2. visual.c:910: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_YUY2. visual.c:916: Test succeeded inside todo block: Got unexpected hr 0x8876086c, fmt=D3DFMT_YUY2. visual.c:904: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_UYVY. visual.c:910: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_UYVY. visual.c:916: Test succeeded inside todo block: Got unexpected hr 0x8876086c, fmt=D3DFMT_UYVY. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3drm: Add tests for querying between IDirect3DRM interfaces
by Marvin 15 Mar '15

15 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12171 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] vbscript: Implemented GetLocale
by Marvin 15 Mar '15

15 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12170 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

GSoC 2015 project
by TARUN GUPTA 14 Mar '15

14 Mar '15

Hi, I am an aspirant of GSoC 2015 and interested in tools project. I have good C knowledge. I am ready to put in my best in these projects. How should i get started?

1 0

Regarding WineHQ development
by Shubham kumar 14 Mar '15

14 Mar '15

Sir, I want to start contributing to this project but the thing is i don't know how to start or what are the right tools to achieve the tasks mentioned in winehq bugzilla and I was unable to find a guide that can help me. For instance, What am i supposed to do with bug 10000? It has a picture of some application which uses some language other than english and i was only able to make out that since windows api documentation is wrong and incomplete we should use the link from that application to correct it or something like that.... Please guide me on how to start and what are the development kits that i might need. I have installed wine on my Ubuntu package from "https://www.winehq.org/download/ubuntu" but i think this is meant for users not developers.. Thank you

1 0

Re: ntdll/tests: Remove an unneeded NONAMELESSSTRUCT directive. (try2)
by Marvin 14 Mar '15

14 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12159 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:485: Test failed: 42: Wrong exception address 7751ED97/003E0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w8 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:485: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: ntdll: Remove unneeded NONAMELESSXXX directives.
by Francois Gouget 14 Mar '15

14 Mar '15

Ignore this patch, it does not compile... but only in 64bit mode. I'll send an updated one. On Fri, 13 Mar 2015, Francois Gouget wrote: [...] > diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c [...] > -#define NONAMELESSUNION > #define NONAMELESSSTRUCT This is the problem: 64bit code does not compile if NONAMELESSSTRUCT is defined but not NONAMELESSUNION. That's because the 64bit KNONVOLATILE_CONTEXT_POINTERS struct then looks like this: { ... union { ... struct { ... } s; }; // Normally called u. union { ... struct { ... } s; }; // Normally called u2. }; So there is no way to determine whether one is accessing the content of the first struct or the second struct. Unfortunately we are stuck as that's really how it is in the PSDK. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.

1 0

Re: ntdll/tests: Remove unneeded NONAMELESSSXXX directives.
by Marvin 13 Mar '15

13 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12157 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 3/3] dwrite: Fix GetClusterMetrics() return value (try2)
by Marvin 13 Mar '15

13 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12142 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1109: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1109: Test failed: got 0x80004002

1 0

Re: [PATCH 2/3] dwrite: Store vertical orientation property (resend)
by Marvin 13 Mar '15

13 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12141 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1110: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1110: Test failed: got 0x80004002

1 0

Re: [PATCH 3/3] dwrite: Fix GetClusterMetrics() return value
by Marvin 13 Mar '15

13 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12139 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel