- wine-devel - winehq.org

Re: user32: Allow making window visible by WM_SETREDRAW message.
by Dmitry Timoshkov 06 Mar '15

06 Mar '15

Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/user32/win.c | 7 ++----- > dlls/user32/win.h | 1 - > dlls/user32/winpos.c | 3 --- > 3 files changed, 2 insertions(+), 9 deletions(-) This change needs quite a bit of tests. -- Dmitry.

2 1

Re: mmdevapi/tests: Remove an unused assignment (PVS-Studio)
by Marvin 06 Mar '15

06 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11941 Your paranoid android. === w7u (32 bit render) === render.c:1975: Test failed: Got wrong volume: 0.501088 render.c:2004: Test failed: Got wrong volume: 0.501088 === w8 (32 bit render) === render.c:1975: Test failed: … [View More]

2 1

Re: [3/4] dpnet: Always update type since it might change (try 5)
by Marvin 06 Mar '15

06 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11938 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [1/4] dpnet:Add check for mismatched string lengths (try 5)
by Marvin 06 Mar '15

06 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11937 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [PATCH 1/4] windowscodecs: Add helper to create internal COM classes without CoCreateInstance call if possible
by Vincent Povirk 06 Mar '15

06 Mar '15

Thanks for working on this. The series looks good to me. + hr = WICCreateImagingFactory_Proxy(WINCODEC_SDK_VERSION, &factory); + ok(hr == S_OK, "CoCreateInstance error %#x\n", hr); This message doesn't match the call.

1 0

hostname: Remove redundant codepath and replace with FormatMessage
by Hugh McMaster 05 Mar '15

05 Mar '15

How does patch 109550 need to improve? (http://source.winehq.org/patches/data/109550) Thanks, Hugh

1 0

Re: [PATCH 1/4] reg: Add path/key conversion functions
by Stefan Dösinger 05 Mar '15

05 Mar '15

I think these patches can be split further. And yeah, I could have thought of some of this sooner :-( . 1.1: A patch that replaces the if chains with the table 1.2: A patch that merges the duplicated string splitting with reg_open 2.1: Implement REG_MULTI_SZ. Use this patch to strip LPCRAP from the function definition 2.2: Improve REG_DWORD. I think you can merge the REG_DWORD_BIG_ENDIAN support into this patch, since it is just another REG_DWORD. 2.3: Add REG_NONE. Just a one-liner and … [View More]

1 0

Re: [PATCH] vbscript: Implemented String
by Marvin 05 Mar '15

05 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11930 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test … [View More]

1 0

Re: [PATCH] vbscript: Implemented String
by Marvin 05 Mar '15

05 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11929 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test … [View More]

1 0

Re: [3/3] dpnet: Always update Component type since it can change (try 3)
by Stefan Dösinger 05 Mar '15

05 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-05 um 09:55 schrieb Alistair Leslie-Hughes: > hr = IDirectPlay8Address_GetComponentByName(localaddr, DPNA_KEY_HOSTNAME, buffer, &size, &type); > ok(hr == S_OK, "got 0x%08x\n", hr); > - todo_wine ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); > + ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); > todo_wine ok(!lstrcmpW(buffer, localhost), "… [View More]

1 0

Re: [1/4] ntdll: Implement TpSimpleTryPost and basic threadpool infrastructure.
by Alexandre Julliard 05 Mar '15

05 Mar '15

Sebastian Lackner <sebastian(a)fds-team.de> writes: > diff --git a/dlls/ntdll/Makefile.in b/dlls/ntdll/Makefile.in > index ed4bb94..2cecac6 100644 > --- a/dlls/ntdll/Makefile.in > +++ b/dlls/ntdll/Makefile.in > @@ -47,6 +47,7 @@ C_SRCS = \ > tape.c \ > thread.c \ > threadpool.c \ > + threadpool2.c \ Please put that stuff in the existing threadpool.c, it's not large and it will be easier to find that way. -- Alexandre Julliard julliard(a)winehq.org

1 0

GSOC 2015 : D3DX9 - Implement missing D3DX9 APIs
by Abhishek Kumar 05 Mar '15

05 Mar '15

Hi, I am Abhishek and am interested in the project titled "D3DX9 - Implement missing D3DX9 APIs". I am good at data-structures and algorithms and have worked with C,C++, PHP, Javascript and Python. I have some questions about the task: 1)Can domain-specific knowledge be a issue..? From just the name of the apis listed on ideas page, i can guess that some advanced domain knowledge in the concerned field is needed. How difficult would it be to write the apis without that knowledge..? 2) How … [View More]

2 1

My GSOC2015 ideas
by YongHao Hu 05 Mar '15

05 Mar '15

Hello, folks I'm YongHao Hu, a college student who study and send patches about msvcp,msvcrt. Thanks for Zhenbo's ideas. Here are my ideas for GSoC 2015. 1. Add needed functions about tr2 and finish my patch about cin>>complex ================== Though msvcp has almost 80%[1] functions implemented, it still has many unimplemented functions, which is used heavily in many softwares. For example, almost all the functions in namespace std::tr2::sys[2] need to implement, which causes a … [View More]bug[3] now. 2. Optimize printf,sprintf functions using Grisu algorithm ================== I had found a bug[4] which is about inconsistent rounding behaviour for sprintf function. In order to fix it, I had made a patch[5] using Dragon4 algorithm. However, this implementation is a little slower than MSVC++ 2010, even four times slower[6] when printing 64-bit values with the minimal number of significant digits to identify the number like sprintf(buffer, "%.17g", value). As functions like printf and sprintf are dependent on pf_printf function, to which the patch applies, I guess efficency is important. As a result, using Grisu algorithm[7] to optimize the patch is a good choice. Grisu algorithm speeds up 99.4 percent of all 64-bit floating point numbers by only using small-integer arithmetic, while the remaining 0.6% still need to use a variant of Dragon4. My idea is to improve my patch based on Dragon4 algorithm so that it can be commited, after which I will add Grisu algorithm to optimize it. 3. Implement series undocumented functions about _Pad ================== There are two bugs needed unimplemented function of _pad in msvcp now[8][9]. I have studied and tested _pad function, finding that _pad is an undocumented function. I also implied that _Pad::Launch is a wrapper of _Thrd_create, thus, it is a tough job which needs to imply and implement many functions. Though my ideas for GSOC2015 may not mature enough, but I hope that they will be helpful. What's more, I am glad to choose some of them as my proposal, if they meet the criteria for GSoC. Thank you for reading this email. I will be grateful for any advice you can provide. [1]: https://www.winehq.org/winapi_stats [2]: https://msdn.microsoft.com/en-us/eg/library/hh874769.aspx [3]: https://bugs.winehq.org/show_bug.cgi?id=35774 [4]: https://bugs.winehq.org/show_bug.cgi?id=37913 [5]: http://source.winehq.org/patches/data/109456 [6]: http://www.ryanjuckett.com/programming/printing-floating-point-numbers/part… [7]: http://www.cs.tufts.edu/~nr/cs257/archive/florian-loitsch/printf.pdf [8]: https://bugs.winehq.org/show_bug.cgi?id=36996 [9]: https://bugs.winehq.org/show_bug.cgi?id=37694 [View Less]

2 1

Re: [1/3] dpnet: Add check for mismatched string lengths (try 4)
by Marvin 05 Mar '15

05 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11922 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [PATCH 2/3] include/ole32/user32/winemac.drv/winex11.drv: do not allow dropping drags through obscuring native windows
by Ken Thomases 05 Mar '15

05 Mar '15

Hi, On Mar 1, 2015, at 10:32 PM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Currently Wine does not support dragging from a Wine window to a > native Window, but does from a Wine window to another Wine window. > What is a big surprise though, is that if a Wine window is obscured by > a native window that's on top of it in the z-order, it looks like you > are dropping onto the native window, but you are actually dropping > THROUGH the native window into the Wine … [View More]window - in other words, the > wrong application gets the drop! > > This patch fixes that problem by giving ole32 awareness of native > windows (represented by a ULONG_PTR) via new Wine-specific functions > in user32 that are implemented by the display drivers winex11.drv and > winemac.drv (of which only the former is implemented by this patch). > The ole32 drag loop can thus tell whether the window under the mouse > is a Wine window or a native window, and obtain IDropTarget from > either window type, something that is used by the next patch to > implement dragging from Wine to native windows. I appreciate your work on this, but I think this isn't the right approach. I think if you solve the other problem (dragging from Wine to other apps) by having the driver take over drags and translating them into a native drag operation, then this problem gets solved automatically. The native drag operation will target the proper window under the cursor, eliminating the problem of dropping through non-Wine windows. If the drag goes over a Wine window, then the native drag will get translated back into Win32 by the existing code in the drivers for receiving drops. I understand your point from the next patch email that this may result in code duplication between the drivers, but I think that's largely inevitable because of the requirements of driving a native drag operation. Also, I don't believe your design where the driver implements IDropTarget and ole32 calls its methods can be made to work on the Mac. As is often the case, Cocoa has a much more closed API for drag and drop than X11. We can't really arbitrarily do pieces of the drag operation in isolation and effectively start and stop the drag (as the cursor moves from Wine window to native window and back to a Wine window). We can only start the drag and then Cocoa takes it from there. It calls relevant methods on the drag source object along the way, of course, but we don't have a lot of control over the drag operation other than that. -Ken [View Less]

3 3

Re: [PATCH] vbscript: Implemented Asc(try 4)
by Marvin 04 Mar '15

04 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11905 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test … [View More]

1 0

Re: [PATCH] vbscript: Implemented Asc(try 3)
by Nikolay Sivov 04 Mar '15

04 Mar '15

On 04.03.2015 9:19, Shuai Meng wrote: > + switch(V_VT(arg)) { > + case VT_NULL: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + case VT_BSTR: > + bstr = V_BSTR(arg); > + break; > + default: > + hres = to_string(arg, &bstr); > + if(FAILED(hres)) > + return hres; > + } > + > + ret = bstr[0]; > + SysFreeString(bstr); > + > + if(ret == 0) > + return MAKE_VBSERROR(… [View More]

2 1

Re: [1/3] dpnet: Add check for mismatched string lengths (try 3)
by Stefan Dösinger 04 Mar '15

04 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2015-03-04 um 04:15 schrieb Alistair Leslie-Hughes: > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, "testing", 8, DPNA_DATATYPE_STRING_ANSI); > + ok(hr == S_OK, "got 0x%08x\n", hr); This still uses a hardcoded size. I recommend to add an array const char test_str[] = "testing" similar to the localhost WCHAR. That way you can use the variable in all places. > + if (((strlenW((WCHAR*)… [View More]lpvData)+1)*sizeof(WCHAR)) != dwDataSize) > + { > + WARN("Invalid STRING size, returning DPNERR_INVALIDPARAM\n"); > + return DPNERR_INVALIDPARAM; > + } There is a theoretical issue here that I don't know if we should care about. Assume e.g. dwDataSize is 10, but lpvData points to a blob that doesn't have a NULL byte before the end of the last defined page. In this case strlen will search for a string termination and segfault. strnlen could abort and return an error instead of segfault. I did some quick testing on Windows and it seems that this function uses a try / catch block to return gracefully in case of an invalid pointer. Generally we don't add tests that cause exceptions and I don't think we should test this here. And I have found no case where strnlen is used in Wine, and we have no strnlenW, so I don't think we should use it here. If I pass an invalid non-null pointer I get 0x80004003. If I pass a length = 0 I get DPNERR_INVALIDSTRING. Also checking !((char *)lpvData)[dwDataSize - 1] would be wrong, windows gracefully returns DPNERR_INVALIDPARAM on lpvData="123", size=999999. > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, "testing", sizeof("Testing")+2, DPNA_DATATYPE_STRING_ANSI); > + ok(hr == DPNERR_INVALIDPARAM, "got 0x%08x\n", hr); Really minor issue: sizeof("testing") vs sizeof("Testing"). The result is the same, but a stupid compiler might place both strings in the executable. The variable I suggested above would avoid this issue here as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU9zGdAAoJEN0/YqbEcdMw8MkP/0Mf46JYgZmA3IwqErfl5lRf fLq1ekHnsKWVXA8pMvl3A0bm2j9fP7UAErFo6mA+oW4KkqHtkqw9z87boJ5Ul5ko wy1T12fizUXXtxdq4Q+TKLCCl+SUX/CUS36Cvw7BeyHGldlUHUrgwQcv2UQg3T1Y dfug2KtrH1M8xTcZBmF9lRMGUqAUpcPxdH0wPh7AoOJsmNpXQUL3jZofsc2s6x7r JFffHxG2EdX96VSjhC+IG3vQLwH+SzlocblcGFFxhv/fjf0u0lgSZegmJVxDxfqc CVWSvMCpnXsd6O57ft8b25eJCmOkZLpYkvaOPiakj+Lz4I8h+lGzGck/Wfvy+bR2 Z0gqrNVjbABkYTlYHw6AsLHnliOnbvs3PROMG3mYsmmGOaLWIwFYhmIFBQCE6Kzv EWnvr3JSux2M689zurKvvJF/GYyS52SntMSpmJmcZ5TndFVi/xspL/+AUUMkr6tQ KK/ykTayv65ioa5T+VCFVclatama9wUcBkHQIU/ej9c4Njj9yXqTlBS7FC5Jieqo GBVHwuv0jNqMHBcAT5jR/V09wfbb3dmoz4yzdKJFGNRfpTeDFfF8qEbOO4AIN3Vy TRQQJJXXoz+UO+Ml0ZfYHxBsOnXSmiIHC8Pcdd9MTsY9XPUw1fFi+zLpXu8urm9Q vb7jaq/Ns9dXETrLE1m9 =jMxz -----END PGP SIGNATURE----- [View Less]

1 1

Re: ntdll: Fix a spelling error.
by Nikolay Sivov 04 Mar '15

04 Mar '15

> - * The returned unix_fd should be closed iff needs_close is non-zero. > + * The returned unix_fd should be closed if needs_close is non-zero. It's not necessary misspelled, 'iff' is a short form of 'if and only if'.

2 1

Re: msvcrt: Use Dragon4 algorithm to fix inconsistent rounding behaviour for sprintf and add tests. (try 2)
by Dmitry Timoshkov 04 Mar '15

04 Mar '15

YongHao Hu <christopherwuy(a)gmail.com> wrote: > +typedef int int32_t; > +typedef unsigned char uint8_t; > +typedef unsigned long uint32_t; > +typedef unsigned long long uint64_t; Please use appropriate win32 types instead. Besides using 'typedef unsigned long uint32_t' is wrong. -- Dmitry.

2 1

Re: ws2_32/tests: Remove an unused assignment (PVS-Studio)
by Marvin 04 Mar '15

04 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11891 Your paranoid android. === w2003std (32 bit sock) === sock: unhandled exception c0000005 at 00000000

2 1

Re: [PATCH 1/4] wined3d: Properly up-scale WINED3DFMT_R5G5_SNORM_L6_UNORM.
by Matteo Bruni 04 Mar '15

04 Mar '15

2015-03-02 22:29 GMT+01:00 Stefan Dösinger <stefan(a)codeweavers.com>: > Simply left-shifting is not enough in positive ranges. 0xff / 255 != > 0xff00 / 65535. > > Using the compiler to read 5 bit signed values seems a lot easier than > operating with masks. > --- > dlls/wined3d/utils.c | 44 +++++++++++++++++++++++++------------------- > 1 file changed, 25 insertions(+), 19 deletions(-) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index … [View More]

2 1

Re: [2/3] dpnet: Free previous allocated data (try 2)
by Stefan Dösinger 04 Mar '15

04 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-04 um 04:15 schrieb Alistair Leslie-Hughes: > + if(entry->type == DPNA_DATATYPE_STRING_ANSI) > + heap_free(entry->data.ansi); > + else if(entry->type == DPNA_DATATYPE_STRING) > + heap_free(entry->data.string); > + else if(entry->type == DPNA_DATATYPE_BINARY) > + heap_free(entry->data.binary); This code is OK with me. What I … [View More]

1 0

Help with testing new Gecko downloader
by Jacek Caban 04 Mar '15

04 Mar '15

Hi all, My today patch [1] together with changes in Wine code from yesterday changed the way we interact with SourceForge for downloading Gecko. It's a risky change that could use wider testing from different locations. If you'd like to help, you need to: - Remove wine_gecko-2.36*.msi if you already have it. If you used downloader to get it, it's most likely in ~/.cache/wine. If you downloaded it manually, you know where to find it. - Create new wineprefix The most important thing is to … [View More]

2 2

Re: include: add initial d3dx10core.h
by Matteo Bruni 04 Mar '15

04 Mar '15

Can you replace the names of the methods arguments with some non-Hungarian alternatives? If nothing else, just to avoid having those declarations match those in the MS header character by character. Also please avoid tabs.

3 3

GSOC 2015 Applicant
by Balkrishna Srivastava 04 Mar '15

04 Mar '15

Hi, I am Balkrishna Srivastava, a 3rd year dual degree undergraduate from BITS Pilani, Pilani Campus, India. I completed my computer programming course in C. I have also been doing extensive competitive coding on codechef.com in c ( profile: http://www.codechef.com/users/bali161616 ). I wish to contribute to your organisation this GSOC. I know c, java, python and c++. Please guide me how to go about contributing to your organization. -- *Regards* *BALKRISHNA SRIVASTAVA* *Undergraduate … [View More]

2 1

Re: ntdll: Assert when trying to replace an exiting file descriptor in fd_cache.
by Alexandre Julliard 04 Mar '15

04 Mar '15

Sebastian Lackner <sebastian(a)fds-team.de> writes: > The condition "prev_fd != -1" should never be true. If this is the case then something > is going terrible wrong, and it is better to assert instead of just closing the file > descriptor. It can happen if the handle was closed on the server side but not yet removed from the cache. Yes, handling of that case is not ideal, but an assert is not an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] vbscript: Implemented Asc(try 3)
by Marvin 04 Mar '15

04 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11880 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: shell32: fix a test failure in shlfileop.c
by Zhenbo Li 04 Mar '15

04 Mar '15

Excuse me, Is there anything to do to improve this patch? Thanks. Zhenbo Li 2015-02-27 8:52 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > I cross-compiled dlls/shell32/tests, and found that wvistau64 failed[1]. > This tiny patch should fix it > > > [1]: http://testbot.winehq.org/JobDetails.pl?Key=11761 > shell32_crosstest: > shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR > > > --- > dlls/shell32/tests/shlfileop.c | 3 ++- … [View More]

2 1

Re: [3/3] dpnet: Always update Component type since it can change (try 2)
by Marvin 04 Mar '15

04 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11876 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [1/3] dpnet: Add check for mismatched string lengths (try 3)
by Marvin 04 Mar '15

04 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11875 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: Shuai Meng : shell32: Also return Attributes in GetFolderDefinition.
by Bruno Jesus 04 Mar '15

04 Mar '15

On Tue, Mar 3, 2015 at 12:42 PM, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 0becff824466b330675fabbd59241a150eebabeb > URL: http://source.winehq.org/git/wine.git/?a=commit;h=0becff824466b330675fabbd5… > > Author: Shuai Meng <mengshuaicalendr(a)gmail.com> > Date: Mon Mar 2 16:12:19 2015 +0800 > > shell32: Also return Attributes in GetFolderDefinition. I may be dreaming but is this the right … [View More]

2 1

Re: ws2_32: Implement returning the proper time with SO_CONNECT_TIME. (resend)
by Bruno Jesus 04 Mar '15

04 Mar '15

On Tue, Mar 3, 2015 at 9:51 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > I know that Bruno was also planning to work on this, but haven't seen any > attempt since my last submission over three months ago. If there is a better > solution for all this, I am pretty sure that it still can be changed later. I'm fine with it, I have many non-finished patches pending here but I don't have time to work on them now. I just don't understand why we can't simply return the time … [View More]

1 0

Re: ws2_32: Implement returning the proper time with SO_CONNECT_TIME. (resend)
by Marvin 04 Mar '15

04 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11869 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at C0000241

2 1

Re: [PATCH] vbscript: Implemented Asc(try 2)
by Nikolay Sivov 03 Mar '15

03 Mar '15

On 03.03.2015 18:00, Shuai Meng wrote: > > > 2015-03-03 18:09 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead@gmail.com>>: > > You're still leaking memory. > > > Thanks for commenting~ But I would be appreciated if you can explain > this more explicitly, I am not quite familiar with the string functions. Take a look at what to_string() does - you're supposed to free what it returns.

1 0

Re: rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()
by Dmitry Timoshkov 03 Mar '15

03 Mar '15

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + if (((ULONG_PTR)Buffer % 8) != 0) > + return RPC_X_INVALID_BUFFER; Shouldn't this be 'if ((ULONG_PTR)Buffer & 7)' instead? -- Dmitry.

2 1

Re: rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()
by Marvin 03 Mar '15

03 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11860 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3d9/tests: Add a test for signed formats.
by Matteo Bruni 03 Mar '15

03 Mar '15

2015-03-02 22:29 GMT+01:00 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* The input data was designed for D3DFMT_L6V5U5 and then transfered > + * to the other formats because L6V5U5 is the lowest precision format. > + * It tests the extreme values -1.0 (-16) and 1.0 (15) for U/V and > + * 0.0 (0) and 1.0 (63) for L, the neutral point 0 as well as -1 and 1. > + * Some other intermediate values are tested too. For the 8 bit formats > + * the … [View More]equivalents of -1 and 1 are -8 and 8, that's why there is no > + * 0xffff input for these formats. The input value -15 (min + 1) is > + * tested as well. Unlike what OpenGL 4.4 says in section 2.3.4.1, this > + * value does not represent -1.0. For 8 bit singed data -127 is tested > + * in the Q channel of D3DFMT_Q8W8V8U8. Here d3d seems to follow the > + * rules from the GL spec. AMD's r200 is broken though and returns a > + * value < -1.0 for -128. The difference between using -127 or -128 as > + * the lowest possible value gets lost in the slop of 1 though. */ For the 8-bit format you mean that 1 is not representable in the signed u/v components, correct? Also "singed" typo, but otherwise good to me. > + static const USHORT content_v8u8[4][4] = > + { > + {0x0000, 0x7f7f, 0x8880, 0x0000}, > + {0x0080, 0x8000, 0x7f00, 0x007f}, > + {0x193b, 0xe8c8, 0x0808, 0xf8f8}, > + {0x4444, 0xc0c0, 0xa066, 0x22e0}, > + }; > + static const DWORD content_v16u16[4][4] = > + { > + {0x00000000, 0x7fff7fff, 0x88008000, 0x00000000}, > + {0x00008000, 0x80000000, 0x7fff0000, 0x00007fff}, > + {0x19993bbb, 0xe800c800, 0x08880888, 0xf800f800}, > + {0x44444444, 0xc000c000, 0xa0006666, 0x2222e000}, > + }; > + static const DWORD content_q8w8v8u8[4][4] = > + { > + {0x00000000, 0xff7f7f7f, 0x7f008880, 0x817f0000}, > + {0x10000080, 0x20008000, 0x30007f00, 0x4000007f}, > + {0x5020193b, 0x6028e8c8, 0x70020808, 0x807ff8f8}, > + {0x90414444, 0xa000c0c0, 0x8261a066, 0x834922e0}, > + }; > + static const DWORD content_x8l8v8u8[4][4] = > + { > + {0x00000000, 0x00ff7f7f, 0x00008880, 0x00ff0000}, > + {0x00000080, 0x00008000, 0x00007f00, 0x0000007f}, > + {0x0041193b, 0x0051e8c8, 0x00040808, 0x00fff8f8}, > + {0x00824444, 0x0000c0c0, 0x00c2a066, 0x009222e0}, > + }; > + /* D3DFMT_L6V5U5 has poor precision on some GPUs. On a GeForce 7 the highest U and V value (15) > + * results in the output color 0xfb, which is 4 steps away from the correct value 0xff. It is > + * not the ~0xf0 you'd get if you blindly left-shifted the 5 bit values to form an 8 bit value > + * though. > + * > + * There may also be an off-by-one bug involved: The value -7 should result in the output 0x47, > + * but ends up as 0x4d. Likewise, -3 becomes 0x6e instead of 0x67. Those values are close to > + * the proper results of -6 and -2. */ > + static const USHORT content_l6v5u5[4][4] = > + { > + {0x0000, 0xfdef, 0x0230, 0xfc00}, > + {0x0010, 0x0200, 0x01e0, 0x000f}, > + {0x4067, 0x53b9, 0x0421, 0xffff}, /* 0x4067, 0x53b9, 0x0421, 0xffff */ > + {0x8108, 0x0318, 0xc28c, 0x909c}, /* 0x8108, 0x0318, 0xc28c, 0x909c */ > + }; What did you mean to put in the comments here? Those currently there match the actual content of the array. > + for (y = 0; y < 4; y++) > + { > + for (x = 0; x < tests[j].width; x++) > + { > + expected_color = expected_colors[y][x]; > + if (!formats[i].blue) > + expected_color |= 0x000000ff; This is clearly my brain failing right now, but why is blue expected to be 0xff when the texture component is missing? > + hr = IDirect3DTexture9_GetSurfaceLevel(texture, 0, &dst_surface); > + ok(SUCCEEDED(hr), "Failed to get surface, hr %#x.\n", hr); > + IDirect3DTexture9_GetSurfaceLevel(texture_sysmem, 0, &src_surface); > + ok(SUCCEEDED(hr), "Failed to get surface, hr %#x.\n", hr); > + > + hr = IDirect3DDevice9_UpdateSurface(device, src_surface, > + &tests[j].src_rect, dst_surface, &tests[j].dst_point); > + ok(SUCCEEDED(hr), "Failed to update surface, hr %#x.\n", hr); > + > + IDirect3DSurface9_Release(dst_surface); > + IDirect3DSurface9_Release(src_surface); > + > + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x00003300, 0.0f, 0); > + ok(SUCCEEDED(hr), "Failed to clear, hr %#x.\n", hr); > + hr = IDirect3DDevice9_BeginScene(device); > + ok(SUCCEEDED(hr), "Failed to begin scene, hr %#x.\n", hr); > + hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_TRIANGLESTRIP, 2, &quad[0], sizeof(*quad)); > + ok(SUCCEEDED(hr), "Failed to draw, hr %#x.\n", hr); > + hr = IDirect3DDevice9_EndScene(device); > + ok(SUCCEEDED(hr), "Failed to end scene, hr %#x.\n", hr); > + > + for (y = 0; y < 4; y++) > + { > + for (x = 0; x < tests[j].width; x++) > + { > + if (tests[j].width == 4) > + expected_color = expected_colors2[y][x]; > + else > + expected_color = expected_colors3[y]; > + > + if (!formats[i].blue) > + expected_color |= 0x000000ff; > + > + color = getPixelColor(device, 80 + 160 * x, 60 + 120 * y); > + ok(color_match(color, expected_color, 1) > + || color_match(color, expected_color, formats[i].slop_broken), > + "Expected color 0x%08x, got 0x%08x, format %s, location %ux%u.\n", > + expected_color, color, formats[i].name, x, y); > + } > + } Cool additional test for UpdateSurface, thank you for that. Here and in the previous test I guess you might want to put the slop_broken check into a broken(), unless that also fails on Linux. [View Less]

2 1

Re: [PATCH] vbscript: Implemented Asc(try 2)
by Marvin 03 Mar '15

03 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11857 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test … [View More]

1 0

Re: [PATCH] vbscript: Implemented Asc(try 2)
by Nikolay Sivov 03 Mar '15

03 Mar '15

You're still leaking memory.

1 0

Re: [PATCH] uxtheme: Support images in GetThemeBackgroundRegion. (try 2)
by Alexandre Julliard 03 Mar '15

03 Mar '15

Mark Harmstone <hellas(a)burntcomma.com> writes: > + /* loop through the image looking for transparent pixels, > + * grouping together horizontal runs into one rect */ > + ptr = bits; > + for (y = 0; y < r.bottom; y++) { > + BOOL trans = FALSE; > + int transstart; > + > + for (x = 0; x < r.right; x++) { > + COLORREF colour = ptr[2] << 16 | ptr[1] << 8 | ptr[0]; > + ptr += 4; > + … [View More]

1 0

Re: [1/3] dpnet: Add check for mismatched string lengths (try 2)
by Marvin 03 Mar '15

03 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11855 Your paranoid android. === w8 (32 bit address) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [1/3] dpnet: Add check for mismatched string lengths (try 2)
by Nikolay Sivov 03 Mar '15

03 Mar '15

On 03.03.2015 11:57, Alistair Leslie-Hughes wrote: > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, &localhost, sizeof(localhost)+2, DPNA_DATATYPE_STRING); > + ok(hr == DPNERR_INVALIDPARAM, "got 0x%08x\n", hr); What happens with size == sizeof(localhost)/2 (or any size that cuts off a string)? Does it make a partial copy? > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, "testing", 8+2, DPNA_DATATYPE_STRING_ANSI); … [View More]

1 0

Re: [2/3] dpnet: Free previous allocated data
by Nikolay Sivov 03 Mar '15

03 Mar '15

On 03.03.2015 11:59, Alistair Leslie-Hughes wrote: > + if(entry->type == DPNA_DATATYPE_STRING_ANSI) > + heap_free(entry->data.ansi); > + else if(entry->type == DPNA_DATATYPE_STRING) > + heap_free(entry->data.string); > + else if(entry->type == DPNA_DATATYPE_BINARY) > + heap_free(entry->data.string); > + You can as well just call heap_free(entry->data.binary) for all those … [View More]

1 0

Google Summer of 2015 has begun
by Austin English 02 Mar '15

02 Mar '15

Howdy all, Wine has been accepted to Google's Summer Of Code for 2015: https://www.google-melange.com/gsoc/org2/google/gsoc2015/wine Developers, if you'd like to be a mentor, please go here to make a connection with the wine project, and then Andre or I will approve you: https://www.google-melange.com/gsoc/homepage/google/gsoc2015 Students, you can apply starting March 16 at 19:00 UTC. Now is a good time to start introducing yourself, explore the source, send patches, and discuss your … [View More]

1 0

GSOC 2015 Applicant
by Saurabh Goyal 02 Mar '15

02 Mar '15

Hi, I am Saurabh Goyal a third year undergraduate from Indian institute of Technology BHU. I have taken basic Machine Learning course on coursera, created few android applications and know algorithms and data structures in c++ and i use linux(ubuntu) for my programming work. I want to participate and work on your organisation as part of GSOC this summer and i am willing to put as many hours as required per day to match the skill set required provided i get directions from my mentor and … [View More]

2 1

Re: [PATCH 5/5] wine.inf: Add some knownfolders to the registry
by Marvin 02 Mar '15

02 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11831 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: user32: Enforce that surfaces are flushed after ReleaseDC.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -1116,6 +1116,7 @@ HDC WINAPI GetWindowDC( HWND hwnd ) > */ > INT WINAPI ReleaseDC( HWND hwnd, HDC hdc ) > { > + flush_window_surfaces( FALSE ); > return release_dc( hwnd, hdc, FALSE ); > } I don't think we can afford to do that, we'd be flushing constantly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] vbscript: Implemented Asc
by Nikolay Sivov 02 Mar '15

02 Mar '15

On 02.03.2015 11:12, Shuai Meng wrote: > + HRESULT hres; > + BSTR bstr; > + WCHAR ret; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + switch(V_VT(arg)) { > + case VT_NULL: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + case VT_EMPTY: > + return MAKE_VBSERROR(VBSE_ILLEGAL_FUNC_CALL); > + case VT_BSTR: > + bstr = V_BSTR(arg); > + default: > + hres = to_string(arg, &bstr); > + … [View More]

2 1

Re: [PATCH 1/3] ntdll/tests: Tests for RtlIpv6StringToAddress (try 4)
by Stefan Dösinger 02 Mar '15

02 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2015-03-02 um 00:08 schrieb Mark Jansen: > + for (n = 0; name_a[n]; ++n) > + name[n] = name_a[n]; > + name[n] = 0; As discussed on IRC please use RtlMultiByteToUnicodeN here. Other tests use it for similar purposes, so I think it is OK to load and use here as well. Note that the other tests assume the function is available, so you don't need to add a skip() check for it. There are a few things where I don't know if … [View More]Alexandre cares about them: The long lines (it may make sense to add some line breaks e.g. in long table entries), adding things like "ex_fails" in patch 1 rather than patch 2 where they are actually used (I think it's better to keep it your way, moving this to the other patch will be lots of work and won't improve readability), and the W test could in theory be moved to a separate patch. Personally I am fine with keeping those things the way they currently are. - From Patch 2: > + init_ip6(&expected_ip, ipv6_tests[i].ip); > + > + /* we do not test ip if the ex has a special case failure here. */ > + if (res == expect_ret) > + { > + ok(!memcmp(ip.s6_addr, expected_ip.s6_addr, sizeof(ip._S6_un)), > + "[%s] ip = %x:%x:%x:%x:%x:%x:%x:%x, expected %x:%x:%x:%x:%x:%x:%x:%x\n", I'm not sure what the comment means. Afaics you're always checking the IP except in case of win_broken_6. ex_fail_6 doesn't matter here. You can move the init_ip6 call into the if branch since you're not using it otherwise. - From Patch 3: > + //ok(terminator == ipv4_tests[i].address + ipv4_tests[i].terminator_offset, > + // "[%s] terminator = %p, expected %p\n", > + // ipv4_tests[i].address, terminator, ipv4_tests[i].address + ipv4_tests[i].terminator_offset); Leftover code from the A test? Since Ex doesn't write the terminator you can just remove that I think. Personally I am not too fond of the test changing its own input data (i.e., the !(ipv4_tests[i].flags & strict_diff_4) case), but since this is existing code I'd say keep it that way. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU9DszAAoJEN0/YqbEcdMwo6AP/jU5NK5YqSXGuUYi1eOoaSAu 23nR4KvoaS/lXnPsZ2QPm+kyeSsWynwj0UYZ4dJJczve81m+5YYDLe4zc5Io/Fz0 C4x8WIMiBGPbhYM+iyIVAItz1wnL/9sB2IrlocQ/N9gYU1m25FLMBLvORePfQQs5 UEOOeZbaws7Qd8n+XDR7JRY9e946B7OVG8TFfq4in8IlPUsmmy+m65jQXGgQeBcF JZgOqJH+fSqW0yf3sHhok9wj7KrRpDVUgBlowBXooBz5uuEJwbQ3IwlrbL28PNIj PylUAHdVjeoHmKRif8gykwOt0laOe+RenSxegJbYbz3nw/d9Jmicj5n6W0W92hvb EPMR0a/HbNF2P6TKQIKSMwoaKhtxRXzfcgBz3Ff3LH63qtRYHxMAneU/yaueBMxR ZmfgWT9FHofH5dk2b4rRuP8XhKB/UFyqhlmimIBeDATO/aasNYuRjYlmce1NnfDa pQqW+ntq/H8TEz1jc2IQS0dm9iQZITSMkQnyJdcMi2GTQEh8y41wa0MuOTC+DavF 8HqmTmo7+/VeaZfAmWx1ndtrSktcPDr4wM70aYPcRP1+JyLsLDfkoV5VDXaelZc2 PwH1MBp6ZTv8t5ckaer4wCpvuDH972/jjB56FnbRF1SiFoYcMEs+ZuHHF5YpMn5A Pd6IazMRvRk6dd+ewaSJ =aaY5 -----END PGP SIGNATURE----- [View Less]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel