- wine-devel - winehq.org

Re: [PATCH 4/5] mshtml: Implement DocumentType node's name prop.
by Marvin 29 Jul '22

29 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120170 Your paranoid android. === w10pro64_ja (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH 3/5] mshtml: Implement document.doctype.
by Marvin 29 Jul '22

29 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120169 Your paranoid android. === w1064v1809 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally

1 0

[PATCH vkd3d 2/3] vkd3d-shader: Introduce a compile option to use Unknown format for typed UAV reads.
by Conor McCarthy 29 Jul '22

29 Jul '22

Specifying R32ui for UAVs created with a vector format, e.g. R32G32B32A32_FLOAT, results in only the red being loaded/stored, potentially causing images to contain only the red component. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> --- include/vkd3d_shader.h | 18 ++++++++++++++++++ libs/vkd3d-shader/spirv.c | 16 +++++++++++++++- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index ebddbba7..4175223f 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -99,6 +99,22 @@ enum vkd3d_shader_compile_option_buffer_uav VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_BUFFER_UAV), }; +/** + * Determines how typed UAVs are declared. + */ +enum vkd3d_shader_compile_option_typed_uav +{ + /** Use R32ui format for UAVs which are read from. This is the default value. */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_R32UI = 0x00000000, + /** + * Use Unknown format for UAVs which are read from. This should only be set if + * shaderStorageImageReadWithoutFormat is enabled in the target environment. + */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN = 0x00000001, + + VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV), +}; + enum vkd3d_shader_compile_option_formatting_flags { VKD3D_SHADER_COMPILE_OPTION_FORMATTING_NONE = 0x00000000, @@ -127,6 +143,8 @@ enum vkd3d_shader_compile_option_name VKD3D_SHADER_COMPILE_OPTION_FORMATTING = 0x00000003, /** \a value is a member of enum vkd3d_shader_api_version. \since 1.3 */ VKD3D_SHADER_COMPILE_OPTION_API_VERSION = 0x00000004, + /** \a value is a member of enum vkd3d_shader_compile_option_typed_uav. \since 1.5 */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV = 0x00000005, VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_NAME), }; diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c index 776533cb..6450f818 100644 --- a/libs/vkd3d-shader/spirv.c +++ b/libs/vkd3d-shader/spirv.c @@ -2228,6 +2228,7 @@ struct vkd3d_dxbc_compiler bool strip_debug; bool ssbo_uavs; + bool uav_read_without_format; struct rb_tree symbol_table; uint32_t temp_id; @@ -2379,6 +2380,15 @@ struct vkd3d_dxbc_compiler *vkd3d_dxbc_compiler_create(const struct vkd3d_shader case VKD3D_SHADER_COMPILE_OPTION_API_VERSION: break; + + case VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV: + if (option->value == VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_R32UI) + compiler->uav_read_without_format = false; + else if (option->value == VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN) + compiler->uav_read_without_format = true; + else + WARN("Ignoring unrecognised value %#x for option %#x.\n", option->value, option->name); + break; } } @@ -5856,14 +5866,18 @@ static uint32_t vkd3d_dxbc_compiler_get_image_type_id(struct vkd3d_dxbc_compiler const struct vkd3d_shader_descriptor_info *d; uint32_t sampled_type_id; SpvImageFormat format; + bool uav_read; format = SpvImageFormatUnknown; if (reg->type == VKD3DSPR_UAV) { d = vkd3d_dxbc_compiler_get_descriptor_info(compiler, VKD3D_SHADER_DESCRIPTOR_TYPE_UAV, range); - if (raw_structured || (d->flags & VKD3D_SHADER_DESCRIPTOR_INFO_FLAG_UAV_READ)) + uav_read = !!(d->flags & VKD3D_SHADER_DESCRIPTOR_INFO_FLAG_UAV_READ); + if (raw_structured || (uav_read && !compiler->uav_read_without_format)) format = image_format_for_image_read(data_type); + else if (uav_read) + vkd3d_spirv_enable_capability(builder, SpvCapabilityStorageImageReadWithoutFormat); } sampled_type_id = vkd3d_spirv_get_type_id(builder, data_type, 1); -- 2.36.1

3 10

[PATCH v2] ntdll/signalx86_64: Add CFI for __wine_syscall_dispatcher
by Keno Fischer 29 Jul '22

29 Jul '22

In a debugger that is capable of loading both PE and ELF libraries (e.g. the wine-enhanced GDB version at [1]), this unwind information will allow proper unwind across the __wine_syscall_dispatcher. The CFI itself is relatively straightforward, though the implementation looks a little complex, because support for proper CFI encoding is somewhat limitied in the GNU toolchain. Essentially, as registers are stored in the rcx buffer in this function, we switch their cfi description to point at that rcx buffer, so the registers may be freely used thereafter without affecting the unwind. Eventually the rcx buffer is tracked in rbp instead at which point we pivot the CFI information as well and keep it there for most of the rest of the function. [1] https://github.com/JuliaComputing/gdb-solib-wine Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> --- v2: Fix accidental build issues introduced during cleanup. (And missed in my build test, because I forgot to enable win64, sigh). dlls/ntdll/unix/signal_x86_64.c | 181 ++++++++++++++++++++++++++++++++ 1 file changed, 181 insertions(+) diff --git a/dlls/ntdll/unix/signal_x86_64.c b/dlls/ntdll/unix/signal_x86_64.c index d6f19dbfa84..2d33df8bccd 100644 --- a/dlls/ntdll/unix/signal_x86_64.c +++ b/dlls/ntdll/unix/signal_x86_64.c @@ -442,6 +442,10 @@ static USHORT fs32_sel; /* selector for %fs in 32-bit mode */ * Definitions for Dwarf unwind tables */ +/* For use in inline-assembly and other contexts where C enums are unavailable */ +#define PP_DW_CFA_def_cfa_expression 0xf +#define PP_DW_CFA_expression 0x10 + enum dwarf_call_frame_info { DW_CFA_advance_loc = 0x40, @@ -472,6 +476,14 @@ enum dwarf_call_frame_info DW_CFA_val_expression = 0x16, }; +/* DWARF State machine ops */ +#define PP_DW_OP_const1u 0x08 +#define PP_DW_OP_breg_base 0x70 +#define PP_DW_OP_minus 0x1c +#define PP_DW_OP_deref 0x06 +#define PP_DW_OP_plus 0x22 +#define PP_DW_OP_plus_uconst 0x23 + enum dwarf_operation { DW_OP_addr = 0x03, @@ -3288,35 +3300,177 @@ __ASM_GLOBAL_FUNC( signal_exit_thread, __ASM_CFI(".cfi_rel_offset %r15,8\n\t") "call *%rsi" ) + +/*********************************************************************** + * CFI Utility definitions + * + * These utility definitions help encode CFI unwind information (for consumption + * in gdb and similar debuggers), improving the accuracy of backtraces. + */ + +/* DWARF Register ordering for x86_64 */ +#define X86_64_DWARF_RAX 0x00 +#define X86_64_DWARF_RDX 0x01 +#define X86_64_DWARF_RCX 0x02 +#define X86_64_DWARF_RBX 0x03 +#define X86_64_DWARF_RSI 0x04 +#define X86_64_DWARF_RDI 0x05 +#define X86_64_DWARF_RBP 0x06 +#define X86_64_DWARF_RSP 0x07 +#define X86_64_DWARF_R8 0x08 +#define X86_64_DWARF_R9 0x09 +#define X86_64_DWARF_R10 0x0a +#define X86_64_DWARF_R11 0x0b +#define X86_64_DWARF_R12 0x0c +#define X86_64_DWARF_R13 0x0d +#define X86_64_DWARF_R14 0x0e +#define X86_64_DWARF_R15 0x0f +#define X86_64_DWARF_RIP 0x10 + +/* __ASM_REG_IS_DEREF_REF_OFFSET(REG_SAVE, REG, OFFSET) + * + * Declare that the register with DWARF register number `REG` is + * saved at offset `OFFSET` from the register with DWARF register + * number `REG_SAVE`. I.e.: + * + * REG (in previous frame) = *(%REG_SAVE + OFFSET) + */ +#define _STR(R) #R +#define __STR(R) _STR(R) +#define __ASM_REG_IS_DEREF_REF_OFFSET(REG_SAVE, REG, OFFSET) \ + ".cfi_escape " __STR(PP_DW_CFA_expression) ", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x02," /* 2 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET ";\n\t" + +/* __ASM_REG_IS_DEREF_REF_OFFSET2(REG_SAVE, REG, OFFSET1, OFFSET2) + * + * Like __ASM_REG_IS_DEREF_REF_OFFSET, expect for offsets of more than + * 7 bits. Takes an SLEB128 encoded offset as two bytes. Thus to e.g. + * encode an offset of 0x70, convert to SLEB128 first: + * + * HEX: 0x70 + * BINARY: 01110000 + * SLEB128: 11110000 00000000 + * |||||||| |||||||| + * |||||||| \------- High bits + * |\------ Low bits + * \- Continuation Bit + * + * SLEB128: 0xf0 0x00 + */ +#define __ASM_REG_IS_DEREF_REF_OFFSET2(REG_SAVE, REG, OFFSET1, OFFSET2) \ + ".cfi_escape " __STR(PP_DW_CFA_expression) ", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x03," /* 3 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET1 ", " #OFFSET2 ";\n\t" + +/* __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, REG, OFFSET, OFFSET_SUB) + * + * Like __ASM_REG_IS_DEREF_REF_OFFSET, except encodes that the saved + * register value is at `*(%REG_SAVE + OFFSET - OFFSET_SUB). + */ +#define __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, REG, OFFSET, OFFSET_SUB) \ + ".cfi_escape " __STR(PP_DW_CFA_expression) ", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x05," /* 5 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET "," \ + __STR(PP_DW_OP_const1u) ", " #OFFSET_SUB "," __STR(PP_DW_OP_minus) ";\n\t" + +/* __ASM_CFA_AT_REG_OFFSET(REG_SAVE, OFFSET) + * + * Declares the CFA of set frame to be stored at *(REG_SAVE + OFFSET). + * Note that the CFA is ordinarily the same as the stack pointer at the end + * of the previous frame, but these are technically separate concepts. + */ +#define __ASM_CFA_AT_REG_OFFSET(REG_SAVE, OFFSET) \ + ".cfi_escape " __STR(PP_DW_CFA_def_cfa_expression) "," \ + " 0x03," /* 3 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET ", " \ + __STR(PP_DW_OP_deref) ";\n\t" + +/* __ASM_CFA_AT_REG_OFFSET2(REG_SAVE, OFFSET_HIGH, OFFSET_LOW) + * + * Like __ASM_CFA_AT_REG_OFFSET, except used for larger offsets. `OFFSET_LOW` encodes + * the low 7 bits of the offset. `OFFSET_HIGH` the next 7 bits. + */ +#define __ASM_CFA_AT_REG_OFFSET2(REG_SAVE, OFFSET_HIGH, OFFSET_LOW) \ + ".cfi_escape " __STR(PP_DW_CFA_def_cfa_expression) "," \ + " 0x04," /* 4 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET_LOW " | 0x80 , " #OFFSET_HIGH ", " \ + __STR(PP_DW_OP_deref) ";\n\t" + +#define __ASM_REG_IS_DEREF_RCX_OFFSET(REG, OFFSET) \ + __ASM_REG_IS_DEREF_REF_OFFSET(X86_64_DWARF_RCX, REG, OFFSET) +#define __ASM_REG_IS_DEREF_RCX_OFFSET2(REG, OFFSET_HIGH, OFFSET_LOW) \ + __ASM_REG_IS_DEREF_REF_OFFSET2(X86_64_DWARF_RCX, REG, OFFSET_LOW | 0x80, OFFSET_HIGH) + +/* __ASM_REGSAVE_AT_DWARF_REG_MINUS(REG_SAVE, OFFSET_SUB) + * + * Declares that a `struct syscall_frame` containing the previous frame's registers may + * be found at `*(struct syscall_frame*)(%REG_SAVE - OFFSET_SUB)` and declares both the + * CFA and saved registers may be found in the corresponding offset. + */ +#define __ASM_REGSAVE_AT_DWARF_REG_MINUS(REG_SAVE, OFFSET_SUB) \ + /* N.B.: First argument is SLEB128 encoded, so move the high bit over \ + to the subtraction */ \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RIP, 0x00, OFFSET_SUB - 0x70) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RAX, 0x00, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RBX, 0x08, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RDX, 0x18, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RSI, 0x20, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RDI, 0x28, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_R12, 0x00, OFFSET_SUB - 0x50) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_R14, 0x10, OFFSET_SUB - 0x50) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RSP, 0x08, OFFSET_SUB - 0x80) \ + /* -0x10 in 7bit 2's complement */ \ + __ASM_CFA_AT_REG_OFFSET(REG_SAVE, 0x70) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RBP, 0x18, OFFSET_SUB - 0x80) + /*********************************************************************** * __wine_syscall_dispatcher */ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "movq %gs:0x30,%rcx\n\t" + __ASM_CFI(".cfi_undefined rcx\n\t") "movq 0x328(%rcx),%rcx\n\t" /* amd64_thread_data()->syscall_frame */ "popq 0x70(%rcx)\n\t" /* frame->rip */ + __ASM_CFI(".cfi_adjust_cfa_offset -8\n\t") + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RIP, 0x00, 0x70) "pushfq\n\t" + __ASM_CFI(".cfi_adjust_cfa_offset 8\n\t") "popq 0x80(%rcx)\n\t" + __ASM_CFI(".cfi_adjust_cfa_offset -8\n\t") "movl $0,0x94(%rcx)\n\t" /* frame->restore_flags */ ".globl " __ASM_NAME("__wine_syscall_dispatcher_prolog_end") "\n" __ASM_NAME("__wine_syscall_dispatcher_prolog_end") ":\n\t" "movq %rax,0x00(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RAX, 0x00) "movq %rbx,0x08(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RBX, 0x08) "movq %rdx,0x18(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RDX, 0x18) "movq %rsi,0x20(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RSI, 0x20) "movq %rdi,0x28(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RDI, 0x28) "movq %r12,0x50(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_R12, 0x00, 0x50) "movq %r13,0x58(%rcx)\n\t" "movq %r14,0x60(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_R14, 0x00, 0x60) "movq %r15,0x68(%rcx)\n\t" "movw %cs,0x78(%rcx)\n\t" "movw %ds,0x7a(%rcx)\n\t" "movw %es,0x7c(%rcx)\n\t" "movw %fs,0x7e(%rcx)\n\t" "movq %rsp,0x88(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RSP, 0x01, 0x08) + __ASM_CFA_AT_REG_OFFSET2(X86_64_DWARF_RCX, 0x01, 0x08) "movw %ss,0x90(%rcx)\n\t" "movw %gs,0x92(%rcx)\n\t" "movq %rbp,0x98(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RBP, 0x01, 0x18) /* Legends of Runeterra hooks the first system call return instruction, and * depends on us returning to it. Adjust the return address accordingly. */ "subq $0xb,0x70(%rcx)\n\t" @@ -3341,6 +3495,8 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "jmp 3f\n" "2:\tfxsave64 0xc0(%rcx)\n" "3:\tleaq 0x98(%rcx),%rbp\n\t" + __ASM_CFI(".cfi_remember_state\n\t") + __ASM_REGSAVE_AT_DWARF_REG_MINUS(X86_64_DWARF_RBP, 0x98) #ifdef __linux__ "testl $12,%r14d\n\t" /* SYSCALL_HAVE_PTHREAD_TEB | SYSCALL_HAVE_WRFSGSBASE */ "jz 2f\n\t" @@ -3402,35 +3558,60 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "jmp 4f\n" "3:\tfxrstor64 0xc0(%rcx)\n" "4:\tmovq 0x98(%rcx),%rbp\n\t" + __ASM_CFI(".cfi_restore_state\n\t") "movq 0x68(%rcx),%r15\n\t" + __ASM_CFI(".cfi_same_value r15\n\t") "movq 0x60(%rcx),%r14\n\t" + __ASM_CFI(".cfi_same_value r14\n\t") "movq 0x58(%rcx),%r13\n\t" + __ASM_CFI(".cfi_same_value r13\n\t") "movq 0x50(%rcx),%r12\n\t" + __ASM_CFI(".cfi_same_value r12\n\t") "movq 0x28(%rcx),%rdi\n\t" + __ASM_CFI(".cfi_same_value rdi\n\t") "movq 0x20(%rcx),%rsi\n\t" + __ASM_CFI(".cfi_same_value rsi\n\t") "movq 0x08(%rcx),%rbx\n\t" + __ASM_CFI(".cfi_same_value rbx\n\t") "testl $0x3,%edx\n\t" /* CONTEXT_CONTROL | CONTEXT_INTEGER */ "jnz 1f\n\t" + __ASM_CFI(".cfi_remember_state\n\t") "movq 0x80(%rcx),%r11\n\t" /* frame->eflags */ + __ASM_CFI(".cfi_same_value r11\n\t") "pushq %r11\n\t" "popfq\n\t" "movq 0x88(%rcx),%rsp\n\t" + __ASM_CFI(".cfi_same_value rsp\n\t") "movq 0x70(%rcx),%rcx\n\t" /* frame->rip */ + __ASM_CFI(".cfi_register rip, rcx\n\t") "jmpq *%rcx\n\t" "1:\tleaq 0x70(%rcx),%rsp\n\t" + __ASM_CFI(".cfi_restore_state\n\t") + __ASM_CFI(".cfi_remember_state\n\t") "testl $0x2,%edx\n\t" /* CONTEXT_INTEGER */ "jnz 1f\n\t" "movq 0x10(%rsp),%r11\n\t" /* frame->eflags */ + __ASM_CFI(".cfi_same_value r11\n\t") "movq (%rsp),%rcx\n\t" /* frame->rip */ + __ASM_CFI(".cfi_register rip, rcx\n\t") "iretq\n" "1:\tmovq 0x00(%rcx),%rax\n\t" + __ASM_CFI(".cfi_restore_state\n\t") + __ASM_CFI(".cfi_same_value rax\n\t") "movq 0x18(%rcx),%rdx\n\t" + __ASM_CFI(".cfi_same_value rdx\n\t") "movq 0x30(%rcx),%r8\n\t" + __ASM_CFI(".cfi_same_value r8\n\t") "movq 0x38(%rcx),%r9\n\t" + __ASM_CFI(".cfi_same_value r9\n\t") "movq 0x40(%rcx),%r10\n\t" + __ASM_CFI(".cfi_same_value r10\n\t") "movq 0x48(%rcx),%r11\n\t" + __ASM_CFI(".cfi_same_value r11\n\t") "movq 0x10(%rcx),%rcx\n" + __ASM_REG_IS_DEREF_REF_OFFSET(X86_64_DWARF_RSP, X86_64_DWARF_RIP, 0) "iretq\n" + __ASM_REGSAVE_AT_DWARF_REG_MINUS(X86_64_DWARF_RBP, 0x98) "5:\tmovl $0xc000000d,%edx\n\t" /* STATUS_INVALID_PARAMETER */ "movq %rsp,%rcx\n\t" ".globl " __ASM_NAME("__wine_syscall_dispatcher_return") "\n" -- 2.25.1

1 0

[PATCH] ntdll/signalx86_64: Add CFI for __wine_syscall_dispatcher
by Keno Fischer 29 Jul '22

29 Jul '22

In a debugger that is capable of loading both PE and ELF libraries (e.g. the wine-enhanced GDB version at [1]), this unwind information will allow proper unwind across the __wine_syscall_dispatcher. The CFI itself is relatively straightforward, though the implementation looks a little complex, because support for proper CFI encoding is somewhat limitied in the GNU toolchain. Essentially, as registers are stored in the rcx buffer in this function, we switch their cfi description to point at that rcx buffer, so the registers may be freely used thereafter without affecting the unwind. Eventually the rcx buffer is tracked in rbp instead at which point we pivot the CFI information as well and keep it there for most of the rest of the function. [1] https://github.com/JuliaComputing/gdb-solib-wine Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> --- dlls/ntdll/unix/signal_x86_64.c | 180 ++++++++++++++++++++++++++++++++ 1 file changed, 180 insertions(+) diff --git a/dlls/ntdll/unix/signal_x86_64.c b/dlls/ntdll/unix/signal_x86_64.c index d6f19dbfa84..a6b79335fab 100644 --- a/dlls/ntdll/unix/signal_x86_64.c +++ b/dlls/ntdll/unix/signal_x86_64.c @@ -442,6 +442,10 @@ static USHORT fs32_sel; /* selector for %fs in 32-bit mode */ * Definitions for Dwarf unwind tables */ +/* For use in inline-assembly and other contexts where C enums are unavailable */ +#define PP_DW_CFA_def_cfa_expression 0xf +#define PP_DW_CFA_expression 0x10 + enum dwarf_call_frame_info { DW_CFA_advance_loc = 0x40, @@ -472,6 +476,14 @@ enum dwarf_call_frame_info DW_CFA_val_expression = 0x16, }; +/* DWARF State machine ops */ +#define PP_DW_OP_const1u 0x08 +#define PP_DW_OP_breg_base 0x70 +#define PP_DW_OP_minus 0x1c +#define PP_DW_OP_deref 0x06 +#define PP_DW_OP_plus 0x22 +#define PP_DW_OP_plus_uconst 0x23 + enum dwarf_operation { DW_OP_addr = 0x03, @@ -3288,35 +3300,176 @@ __ASM_GLOBAL_FUNC( signal_exit_thread, __ASM_CFI(".cfi_rel_offset %r15,8\n\t") "call *%rsi" ) + +/*********************************************************************** + * CFI Utility definitions + * + * These utility definitions help encode CFI unwind information (for consumption + * in gdb and similar debuggers), improving the accuracy of backtraces. + */ + +/* DWARF Register ordering for x86_64 */ +#define X86_64_DWARF_RAX 0x00 +#define X86_64_DWARF_RDX 0x01 +#define X86_64_DWARF_RCX 0x02 +#define X86_64_DWARF_RBX 0x03 +#define X86_64_DWARF_RSI 0x04 +#define X86_64_DWARF_RDI 0x05 +#define X86_64_DWARF_RBP 0x06 +#define X86_64_DWARF_RSP 0x07 +#define X86_64_DWARF_R8 0x08 +#define X86_64_DWARF_R9 0x09 +#define X86_64_DWARF_R10 0x0a +#define X86_64_DWARF_R11 0x0b +#define X86_64_DWARF_R12 0x0c +#define X86_64_DWARF_R13 0x0d +#define X86_64_DWARF_R14 0x0e +#define X86_64_DWARF_R15 0x0f +#define X86_64_DWARF_RIP 0x10 + +/* __ASM_REG_IS_DEREF_REF_OFFSET(REG_SAVE, REG, OFFSET) + * + * Declare that the register with DWARF register number `REG` is + * saved at offset `OFFSET` from the register with DWARF register + * number `REG_SAVE`. I.e.: + * + * REG (in previous frame) = *(%REG_SAVE + OFFSET) + */ +#define _STR(R) #R +#define __ASM_REG_IS_DEREF_REF_OFFSET(REG_SAVE, REG, OFFSET) \ + ".cfi_escape " #PP_DW_CFA_expression", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x02," /* 2 bytes follow */ \ + #PP_DW_OP_breg_base " + " _STR(REG_SAVE) ", " #OFFSET ";\n\t" + +/* __ASM_REG_IS_DEREF_REF_OFFSET2(REG_SAVE, REG, OFFSET1, OFFSET2) + * + * Like __ASM_REG_IS_DEREF_REF_OFFSET, expect for offsets of more than + * 7 bits. Takes an SLEB128 encoded offset as two bytes. Thus to e.g. + * encode an offset of 0x70, convert to SLEB128 first: + * + * HEX: 0x70 + * BINARY: 01110000 + * SLEB128: 11110000 00000000 + * |||||||| |||||||| + * |||||||| \------- High bits + * |\------ Low bits + * \- Continuation Bit + * + * SLEB128: 0xf0 0x00 + */ +#define __ASM_REG_IS_DEREF_REF_OFFSET2(REG_SAVE, REG, OFFSET1, OFFSET2) \ + ".cfi_escape " #PP_DW_CFA_expression", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x03," /* 3 bytes follow */ \ + #PP_DW_OP_breg_base " + " _STR(REG_SAVE) ", " #OFFSET1 ", " #OFFSET2 ";\n\t" + +/* __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, REG, OFFSET, OFFSET_SUB) + * + * Like __ASM_REG_IS_DEREF_REF_OFFSET, except encodes that the saved + * register value is at `*(%REG_SAVE + OFFSET - OFFSET_SUB). + */ +#define __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, REG, OFFSET, OFFSET_SUB) \ + ".cfi_escape " #PP_DW_CFA_expression", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x05," /* 5 bytes follow */ \ + #PP_DW_OP_breg_base " + " _STR(REG_SAVE) ", " #OFFSET "," \ + #PP_DW_OP_const1u ", " #OFFSET_SUB "," #PP_DW_OP_minus ";\n\t" + +/* __ASM_CFA_AT_REG_OFFSET(REG_SAVE, OFFSET) + * + * Declares the CFA of set frame to be stored at *(REG_SAVE + OFFSET). + * Note that the CFA is ordinarily the same as the stack pointer at the end + * of the previous frame, but these are technically separate concepts. + */ +#define __ASM_CFA_AT_REG_OFFSET(REG_SAVE, OFFSET) \ + ".cfi_escape " #PP_DW_CFA_def_cfa_expression "," \ + " 0x03," /* 3 bytes follow */ \ + #PP_DW_OP_breg_base " + " _STR(REG_SAVE) ", " #OFFSET ", " \ + #PP_DW_OP_deref ";\n\t" + +/* __ASM_CFA_AT_REG_OFFSET2(REG_SAVE, OFFSET_HIGH, OFFSET_LOW) + * + * Like __ASM_CFA_AT_REG_OFFSET, except used for larger offsets. `OFFSET_LOW` encodes + * the low 7 bits of the offset. `OFFSET_HIGH` the next 7 bits. + */ +#define __ASM_CFA_AT_REG_OFFSET2(REG_SAVE, OFFSET_HIGH, OFFSET_LOW) \ + ".cfi_escape " DW_CFA_def_cfa_expression "," \ + " 0x04," /* 4 bytes follow */ \ + #PP_DW_OP_breg_base " + " _STR(REG_SAVE) ", " #OFFSET_LOW " | 0x80 , " #OFFSET_HIGH ", " \ + #PP_DW_OP_deref ";\n\t" + +#define __ASM_REG_IS_DEREF_RCX_OFFSET(REG, OFFSET) \ + __ASM_REG_IS_DEREF_REF_OFFSET(X86_64_DWARF_RCX, REG, OFFSET) +#define __ASM_REG_IS_DEREF_RCX_OFFSET2(REG, OFFSET_HIGH, OFFSET_LOW) \ + __ASM_REG_IS_DEREF_REF_OFFSET2(X86_64_DWARF_RCX, REG, OFFSET_LOW | 0x80, OFFSET_HIGH) + +/* __ASM_REGSAVE_AT_DWARF_REG_MINUS(REG_SAVE, OFFSET_SUB) + * + * Declares that a `struct syscall_frame` containing the previous frame's registers may + * be found at `*(struct syscall_frame*)(%REG_SAVE - OFFSET_SUB)` and declares both the + * CFA and saved registers may be found in the corresponding offset. + */ +#define __ASM_REGSAVE_AT_DWARF_REG_MINUS(REG_SAVE, OFFSET_SUB) \ + /* N.B.: First argument is SLEB128 encoded, so move the high bit over \ + to the subtraction */ \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RIP, 0x00, OFFSET_SUB - 0x70) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RAX, 0x00, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RBX, 0x08, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RDX, 0x18, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RSI, 0x20, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RDI, 0x28, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_R12, 0x00, OFFSET_SUB - 0x50) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_R14, 0x10, OFFSET_SUB - 0x50) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RSP, 0x08, OFFSET_SUB - 0x80) \ + /* -0x10 in 7bit 2's complement */ \ + __ASM_CFA_AT_REG_OFFSET(REG_SAVE, 0x70) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RBP, 0x18, OFFSET_SUB - 0x80) + /*********************************************************************** * __wine_syscall_dispatcher */ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "movq %gs:0x30,%rcx\n\t" + __ASM_CFI(".cfi_undefined rcx\n\t") "movq 0x328(%rcx),%rcx\n\t" /* amd64_thread_data()->syscall_frame */ "popq 0x70(%rcx)\n\t" /* frame->rip */ + __ASM_CFI(".cfi_adjust_cfa_offset -8\n\t") + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RIP, 0x00, 0x70) "pushfq\n\t" + __ASM_CFI(".cfi_adjust_cfa_offset 8\n\t") "popq 0x80(%rcx)\n\t" + __ASM_CFI(".cfi_adjust_cfa_offset -8\n\t") "movl $0,0x94(%rcx)\n\t" /* frame->restore_flags */ ".globl " __ASM_NAME("__wine_syscall_dispatcher_prolog_end") "\n" __ASM_NAME("__wine_syscall_dispatcher_prolog_end") ":\n\t" "movq %rax,0x00(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RAX, 0x00) "movq %rbx,0x08(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RBX, 0x08) "movq %rdx,0x18(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RDX, 0x18) "movq %rsi,0x20(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RSI, 0x20) "movq %rdi,0x28(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RDI, 0x28) "movq %r12,0x50(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_R12, 0x00, 0x50) "movq %r13,0x58(%rcx)\n\t" "movq %r14,0x60(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_R14, 0x00, 0x60) "movq %r15,0x68(%rcx)\n\t" "movw %cs,0x78(%rcx)\n\t" "movw %ds,0x7a(%rcx)\n\t" "movw %es,0x7c(%rcx)\n\t" "movw %fs,0x7e(%rcx)\n\t" "movq %rsp,0x88(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RSP, 0x01, 0x08) + __ASM_CFA_AT_REG_OFFSET2(X86_64_DWARF_RCX, 0x01, 0x08) "movw %ss,0x90(%rcx)\n\t" "movw %gs,0x92(%rcx)\n\t" "movq %rbp,0x98(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RBP, 0x01, 0x18) /* Legends of Runeterra hooks the first system call return instruction, and * depends on us returning to it. Adjust the return address accordingly. */ "subq $0xb,0x70(%rcx)\n\t" @@ -3341,6 +3494,8 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "jmp 3f\n" "2:\tfxsave64 0xc0(%rcx)\n" "3:\tleaq 0x98(%rcx),%rbp\n\t" + __ASM_CFI(".cfi_remember_state\n\t") + __ASM_REGSAVE_AT_DWARF_REG_MINUS(X86_64_DWARF_RBP, 0x98) #ifdef __linux__ "testl $12,%r14d\n\t" /* SYSCALL_HAVE_PTHREAD_TEB | SYSCALL_HAVE_WRFSGSBASE */ "jz 2f\n\t" @@ -3402,35 +3557,60 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "jmp 4f\n" "3:\tfxrstor64 0xc0(%rcx)\n" "4:\tmovq 0x98(%rcx),%rbp\n\t" + __ASM_CFI(".cfi_restore_state\n\t") "movq 0x68(%rcx),%r15\n\t" + __ASM_CFI(".cfi_same_value r15\n\t") "movq 0x60(%rcx),%r14\n\t" + __ASM_CFI(".cfi_same_value r14\n\t") "movq 0x58(%rcx),%r13\n\t" + __ASM_CFI(".cfi_same_value r13\n\t") "movq 0x50(%rcx),%r12\n\t" + __ASM_CFI(".cfi_same_value r12\n\t") "movq 0x28(%rcx),%rdi\n\t" + __ASM_CFI(".cfi_same_value rdi\n\t") "movq 0x20(%rcx),%rsi\n\t" + __ASM_CFI(".cfi_same_value rsi\n\t") "movq 0x08(%rcx),%rbx\n\t" + __ASM_CFI(".cfi_same_value rbx\n\t") "testl $0x3,%edx\n\t" /* CONTEXT_CONTROL | CONTEXT_INTEGER */ "jnz 1f\n\t" + __ASM_CFI(".cfi_remember_state\n\t") "movq 0x80(%rcx),%r11\n\t" /* frame->eflags */ + __ASM_CFI(".cfi_same_value r11\n\t") "pushq %r11\n\t" "popfq\n\t" "movq 0x88(%rcx),%rsp\n\t" + __ASM_CFI(".cfi_same_value rsp\n\t") "movq 0x70(%rcx),%rcx\n\t" /* frame->rip */ + __ASM_CFI(".cfi_register rip, rcx\n\t") "jmpq *%rcx\n\t" "1:\tleaq 0x70(%rcx),%rsp\n\t" + __ASM_CFI(".cfi_restore_state\n\t") + __ASM_CFI(".cfi_remember_state\n\t") "testl $0x2,%edx\n\t" /* CONTEXT_INTEGER */ "jnz 1f\n\t" "movq 0x10(%rsp),%r11\n\t" /* frame->eflags */ + __ASM_CFI(".cfi_same_value r11\n\t") "movq (%rsp),%rcx\n\t" /* frame->rip */ + __ASM_CFI(".cfi_register rip, rcx\n\t") "iretq\n" "1:\tmovq 0x00(%rcx),%rax\n\t" + __ASM_CFI(".cfi_restore_state\n\t") + __ASM_CFI(".cfi_same_value rax\n\t") "movq 0x18(%rcx),%rdx\n\t" + __ASM_CFI(".cfi_same_value rdx\n\t") "movq 0x30(%rcx),%r8\n\t" + __ASM_CFI(".cfi_same_value r8\n\t") "movq 0x38(%rcx),%r9\n\t" + __ASM_CFI(".cfi_same_value r9\n\t") "movq 0x40(%rcx),%r10\n\t" + __ASM_CFI(".cfi_same_value r10\n\t") "movq 0x48(%rcx),%r11\n\t" + __ASM_CFI(".cfi_same_value r11\n\t") "movq 0x10(%rcx),%rcx\n" + __ASM_REG_IS_DEREF_REF_OFFSET(X86_64_DWARF_RSP, X86_64_DWARF_RIP, 0) "iretq\n" + __ASM_REGSAVE_AT_DWARF_REG_MINUS(X86_64_DWARF_RBP, 0x98) "5:\tmovl $0xc000000d,%edx\n\t" /* STATUS_INVALID_PARAMETER */ "movq %rsp,%rcx\n\t" ".globl " __ASM_NAME("__wine_syscall_dispatcher_return") "\n" -- 2.25.1

2 1

Re: [PATCH v4 01/11] winmm/tests: Add tests for visibility of video window.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120073 Your paranoid android. === w7u_adm (32 bit report) === winmm: midi.c:1039: Test failed: bad message 1e/0 from midiStreamOut, expect 3c9/22f940 midi.c:1048: Test failed: bad message 3c9/22f940 from midiStreamClose, expect 3c8/0 === w7u_el (32 bit report) === winmm: midi.c:988: Test failed: bad message 1e/0 from midiStreamOpen, expect 3c7/0 midi.c:1039: Test failed: bad message 3c7/0 from midiStreamOut, expect 3c9/22f940 midi.c:1048: Test failed: bad message 3c9/22f940 from midiStreamClose, expect 3c8/0

1 0

Re: [PATCH v3 2/2] ddraw/tests: Add some video memory accounting tests.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120071 Your paranoid android. === w8adm (32 bit report) === ddraw: ddraw7.c:18888: Test failed: Got unexpected color 0x0000ff00. === w864 (32 bit report) === ddraw: ddraw7.c:18888: Test failed: Got unexpected color 0x0000ff00. === w1064_tsign (32 bit report) === ddraw: ddraw7.c:18888: Test failed: Got unexpected color 0x00000040. === debian11 (32 bit Chinese:China report) === Report validation errors: ddraw1: Timeout === debian11 (build log) === WineRunWineTest.pl:error: The task timed out

1 0

Re: [PATCH 3/3] mshtml: Implement "text" type response for XMLHttpRequest.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120063 Your paranoid android. === w10pro64_ja (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE === w10pro64_zh_CN (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Access to graphics memory mappings on upcoming WOW64 implementation
by Derek Lesho 28 Jul '22

28 Jul '22

Hi All, In the wake of the new WOW64 implementation (recent explanation [1]), there has been discussion in informal channels about how to we are going to handle pointers to mapped graphics resource memory which we receive from the graphics API, as the possibility exists that it will fall outside of the 32-bit address space. Over time, a few creative solutions have been proposed and discussed, with a common theme being that we need changes in either the kernel or the graphics drivers to do this properly. As we already know the requirements for a solution to this problem, I think it would be responsible to hash this out now and then work with the relevant project maintainers earlier as to avoid blocking work on the wine side too long and to possibly allow more users to test the new path earlier. The solutions which I've seen laid out so far: - Use the mremap(2) interface, allowing us to duplicate the mapping we receive into the 32-bit address space. This solution would match what is already done for Crossover Mac's 32on64 support using Mac's mach_vm_remap functionality [2]. However, right now it is not possible to use the MREMAP_DONTUNMAP flag with mappings that aren't private and anonymous, which rules out there use on mapped FDs from libdrm. Due to this, a kernel change would be necessary. Pro: A uniform solution across all APIs, which could help in the future with any unforeseen need to access host-allocated memory in 32-bit windows code. Cons: Requires a kernel change, which of all the options may take the longest to get up-streamed and in the hands of users. - Work with Khronos to introduce extensions into the relevant APIs enabling us to tell drivers where in the address space we want resources mapped. Pro: Wouldn't require going around the backs of the driver, resulting in a more hardened solution. (Out there, but what if a creative driver returns a mapping without read or write permission and handles accesses through a page fault handler?) Cons: The extension would have to be implemented by each individual vendor for every relevant API. This would implicitly drop support for those with cards whose graphics drivers are no longer being updated. - Hook the driver's mmap call when we invoke memory mappings function, overriding the address to something in the 32-bit address space. Pro: Unlike the other solutions, this wouldn't require any changes to other projects, and shares the advantage of the first solution. Cons: Susceptible to breakage if the driver uses their own mapping mechanism separate from mmap. (Custom IOCTL, CPU driver returning something from the heap) 1: https://www.winehq.org/pipermail/wine-devel/2022-April/213677.html 2: https://www.codeweavers.com/crossover/source - see function `remap_memory` in `wine/dlls/winemac.drv/opengl.c`

10 15

Re: [PATCH 2/3] mshtml: Implement responseType prop for XMLHttpRequest.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120062 Your paranoid android. === w10pro64 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH 11/11] mciqtz32: Show the default video window when switching from another one.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120094 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === debian11 (32 bit report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit German report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit French report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (64 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12)

1 0

Re: [PATCH 10/11] mciqtz32: Hide the default video window when switching to another one.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120093 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === debian11 (32 bit report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit German report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit French report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (64 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12)

1 0

Re: [PATCH 09/11] mciqtz32: Reset the video size when switching video destination.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120092 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === debian11 (32 bit report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit German report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit French report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (64 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12)

1 0

Re: [PATCH 08/11] mciqtz32: Correct initial video window dimensions.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120091 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH 07/11] mciqtz32: Fix MCI_DGV_WHERE_WINDOW behavior.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120090 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH 06/11] mciqtz32: Correct video window behavior by creating default window.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120089 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH 05/11] winmm/tests: Add tests for destination of video window.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120088 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1612: Test failed: 2: window command result doesn't match, expected (0,0)-(112,51), got (0,10)-(112,51) === debian11 (64 bit WoW report) === winmm: mci.c:1612: Test failed: 0: window command result doesn't match, expected (0,0)-(112,51), got (0,10)-(112,51)

1 0

Re: [PATCH 04/11] winmm/tests: Add tests for dimensions of video window.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120087 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH v4 11/11] mciqtz32: Show the default video window when switching from another one.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120083 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === debian11 (32 bit report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit German report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit French report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (64 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12)

1 0

Re: [PATCH v4 10/11] mciqtz32: Hide the default video window when switching to another one.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120082 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === debian11 (32 bit report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit German report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit French report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (64 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12)

1 0

Re: [PATCH v4 09/11] mciqtz32: Reset the video size when switching video destination.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120081 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === debian11 (32 bit report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit German report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit French report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (32 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12) === debian11 (64 bit WoW report) === winmm: mci.c:1657: Test failed: 0: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 1: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 2: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 3: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 4: got (0,0)-(32,24), expected (0,0)-(64,12) mci.c:1657: Test failed: 5: got (0,0)-(32,24), expected (0,0)-(64,12)

1 0

Re: [PATCH v4 08/11] mciqtz32: Correct initial video window dimensions.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120080 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH v4 07/11] mciqtz32: Fix MCI_DGV_WHERE_WINDOW behavior.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120079 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH v4 06/11] mciqtz32: Correct video window behavior by creating default window.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120078 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1600: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1600: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1600: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1600: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1600: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1600: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH v4 05/11] winmm/tests: Add tests for destination of video window.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120077 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (125,125)-(261,187), got (125,125)-(257,187) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (26,26)-(162,89), got (26,26)-(166,89) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (104,104)-(240,167), got (104,104)-(244,167) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1606: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1606: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1606: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1606: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1606: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1606: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH v4 04/11] winmm/tests: Add tests for dimensions of video window.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120076 Your paranoid android. === w7u_2qxl (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_adm (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (100,100)-(236,162), got (100,100)-(232,162) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (175,175)-(311,237), got (175,175)-(307,237) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w7u_el (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (75,75)-(211,137), got (75,75)-(207,137) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (25,25)-(161,87), got (25,25)-(157,87) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,62), got (0,0)-(132,62) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (150,150)-(286,212), got (150,150)-(282,212) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,63), got (1,1)-(133,63) === w8 (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w8adm (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (32 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64) === w864 (64 bit report) === winmm: mci.c:1601: Test failed: 0: window rectangle doesn't match, expected (156,156)-(292,219), got (156,156)-(296,219) mci.c:1601: Test failed: 1: window rectangle doesn't match, expected (52,52)-(188,115), got (52,52)-(192,115) mci.c:1601: Test failed: 2: window rectangle doesn't match, expected (130,130)-(266,193), got (130,130)-(270,193) mci.c:1601: Test failed: 3: window rectangle doesn't match, expected (0,0)-(136,63), got (0,0)-(140,63) mci.c:1601: Test failed: 4: window rectangle doesn't match, expected (78,78)-(214,141), got (78,78)-(218,141) mci.c:1601: Test failed: 5: window rectangle doesn't match, expected (1,1)-(137,64), got (1,1)-(141,64)

1 0

Re: [PATCH v3 1/2] ddraw: Don't account video memory for sysmem surfaces' draw textures.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120070 Your paranoid android. === debian11 (32 bit Chinese:China report) === Report validation errors: ddraw7: Timeout === debian11 (build log) === WineRunWineTest.pl:error: The task timed out

1 0

[PATCH v2 0/6] MR370: mciqtz32: Simplify video window management by creating default window.
by Akihiro Sagawa (＠sgwaki) 28 Jul '22

28 Jul '22

-- v2: mciqtz32: Update parent window's title instead of the video window's one. mciqtz32: Update parent window's state instead of the video window's one. winmm/tests: Add more window command tests. mciqtz32: Implement MCI_DGV_STATUS_HWND. winmm/tests: Add basic video window tests. mciqtz32: Simplify video window management by creating default window. https://gitlab.winehq.org/wine/wine/-/merge_requests/370

5 12

[PATCH] server: Write terminating '\0' in the strings.
by Dmitry Timoshkov 28 Jul '22

28 Jul '22

I have an application that creates its special registry key using NtCreateKey(parent, "Something\0"), and then expects to be able to open this key with NtOpenKey("Something\0") on start up. Currently this fails because terminating '\0' in the key name doesn't survive saving/loading the registry. parse_strW() helper already supports loading such key names. As the tests show after creating a kernel object with name "Something\0" it's possible to only open it as "Something\0", an attempt opening it as "Something" fails with STATUS_OBJECT_NAME_NOT_FOUND, and vice versa. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- server/unicode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/unicode.c b/server/unicode.c index 86a1217b01f..a146677cf21 100644 --- a/server/unicode.c +++ b/server/unicode.c @@ -219,7 +219,6 @@ int dump_strW( const WCHAR *str, data_size_t len, FILE *f, const char escape[2] } if (*str < 32) /* octal or C escape */ { - if (!*str && len == 1) continue; /* do not output terminating NULL */ if (escapes[*str] != '.') pos += sprintf( pos, "\\%c", escapes[*str] ); else if (len > 1 && str[1] >= '0' && str[1] <= '7') -- 2.37.1

1 0

[PATCH 2/2] ntdll/tests: Add a bunch of tests for creating kernel objects with the names containing '\0'.
by Dmitry Timoshkov 28 Jul '22

28 Jul '22

As the tests show after creating a kernel object with name "wine_test\0" it's possible to only open it as "wine_test\0", an attempt opening it as "wine_test" fails with STATUS_OBJECT_NAME_NOT_FOUND, and vice versa. Also the tests show that "wine\0test" is a valid kernel object name. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/ntdll/tests/om.c | 350 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 349 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c index 7fe0fb59f89..f98a8843d62 100644 --- a/dlls/ntdll/tests/om.c +++ b/dlls/ntdll/tests/om.c @@ -1580,7 +1580,8 @@ static void _test_object_name( unsigned line, HANDLE handle, const WCHAR *expect ok_(__FILE__,line)( status == STATUS_SUCCESS, "NtQueryObject failed %lx\n", status ); ok_(__FILE__,line)( len >= sizeof(OBJECT_NAME_INFORMATION) + str->Length, "unexpected len %lu\n", len ); todo_wine_if (todo) - ok_(__FILE__,line)(compare_unicode_string( str, expected_name ), "wrong name %s\n", debugstr_w( str->Buffer )); + ok_(__FILE__,line)(compare_unicode_string( str, expected_name ), "got %s, expected %s\n", + debugstr_w(str->Buffer), debugstr_w(expected_name)); } static void test_query_object(void) @@ -2722,6 +2723,352 @@ static void test_query_directory(void) pNtClose( dir ); } +#define test_object_name_with_null(a,b) _test_object_name_with_null(__LINE__,a,b) +static void _test_object_name_with_null(unsigned line, HANDLE handle, UNICODE_STRING *expect) +{ + char buffer[1024]; + UNICODE_STRING *str = (UNICODE_STRING *)buffer; + ULONG len = 0; + NTSTATUS status; + + memset(buffer, 0, sizeof(buffer)); + status = pNtQueryObject(handle, ObjectNameInformation, buffer, sizeof(buffer), &len); + ok_(__FILE__,line)(status == STATUS_SUCCESS, "got %08lx\n", status); + ok_(__FILE__,line)(len >= sizeof(OBJECT_NAME_INFORMATION) + str->Length, "got %lu\n", len); + ok_(__FILE__,line)(str->Length == expect->Length, "got %lu, expected %lu\n", str->Length, expect->Length); + ok_(__FILE__,line)(!wcsnicmp(str->Buffer, expect->Buffer, str->Length/sizeof(WCHAR)), "got %s, expected %s\n", + debugstr_w(str->Buffer), debugstr_w(expect->Buffer)); +} + +static void test_null_in_object_name(void) +{ + WCHAR name[256], name3[256], *p, *name_exp, *name3_exp; + HANDLE handle, handle2; + NTSTATUS status; + OBJECT_ATTRIBUTES attr, attr2, attr3; + UNICODE_STRING nameU, name2U, name3U, name2U_exp, name3U_exp; + LARGE_INTEGER size; +#ifndef _WIN64 + BOOL is_wow64 = FALSE; +#endif + + trace("running as %d bit\n", (int)sizeof(void *) * 8); + + swprintf(name, ARRAY_SIZE(name), L"\\Sessions\\%u\\BaseNamedObjects\\wine_test", NtCurrentTeb()->Peb->SessionId); + swprintf(name3, ARRAY_SIZE(name3), L"\\Sessions\\%u\\BaseNamedObjects\\wine_test", NtCurrentTeb()->Peb->SessionId); + p = wcsrchr(name3, '\\'); + p[5] = 0; /* => \\wine\0test */ + + RtlInitUnicodeString(&nameU, name); + InitializeObjectAttributes(&attr, &nameU, 0, 0, NULL); + + name2U = nameU; + name2U.Length += sizeof(WCHAR); /* add terminating \0 to string length */ + InitializeObjectAttributes(&attr2, &name2U, 0, 0, NULL); + + name3U = nameU; + name3U.Buffer = name3; + InitializeObjectAttributes(&attr3, &name3U, 0, 0, NULL); + + status = pNtCreateEvent(&handle, GENERIC_ALL, &attr, NotificationEvent, FALSE); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateEvent(&handle, GENERIC_ALL, &attr2, NotificationEvent, FALSE); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateEvent(&handle, GENERIC_ALL, &attr3, NotificationEvent, FALSE); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenEvent(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateDebugObject(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + pNtClose(handle); + status = pNtCreateDebugObject(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + pNtClose(handle); + status = pNtCreateDebugObject(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + pNtClose(handle); + + status = pNtCreateMutant(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateMutant(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateMutant(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenMutant(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateSemaphore(&handle, GENERIC_ALL, &attr, 1, 2); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateSemaphore(&handle, GENERIC_ALL, &attr2, 1, 2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateSemaphore(&handle, GENERIC_ALL, &attr3, 1, 2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenSemaphore(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateKeyedEvent(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateKeyedEvent(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtClose(handle); + status = pNtCreateKeyedEvent(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenKeyedEvent(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateIoCompletion(&handle, GENERIC_ALL, &attr, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenIoCompletion(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateIoCompletion(&handle, GENERIC_ALL, &attr2, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenIoCompletion(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateIoCompletion(&handle, GENERIC_ALL, &attr3, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenIoCompletion(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateJobObject(&handle, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenJobObject(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateJobObject(&handle, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenJobObject(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateJobObject(&handle, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenJobObject(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + status = pNtCreateTimer(&handle, GENERIC_ALL, &attr, NotificationTimer); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenTimer(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateTimer(&handle, GENERIC_ALL, &attr2, NotificationTimer); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenTimer(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateTimer(&handle, GENERIC_ALL, &attr3, NotificationTimer); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenTimer(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + size.QuadPart = 4096; + status = pNtCreateSection(&handle, GENERIC_ALL, &attr, &size, PAGE_READWRITE, SEC_COMMIT, 0); + ok(!status, "got %08lx\n", status); + test_object_name(handle, name, FALSE); + status = pNtOpenSection(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name, FALSE); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateSection(&handle, GENERIC_ALL, &attr2, &size, PAGE_READWRITE, SEC_COMMIT, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U); + status = pNtOpenSection(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name2U); + pNtClose(handle2); + pNtClose(handle); + status = pNtCreateSection(&handle, GENERIC_ALL, &attr3, &size, PAGE_READWRITE, SEC_COMMIT, 0); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U); + status = pNtOpenSection(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle2, &name3U); + pNtClose(handle2); + pNtClose(handle); + + wcscpy(name, L"\\Registry\\Machine\\Software\\wine_test"); + wcscpy(name3, L"\\Registry\\Machine\\Software\\wine_test"); + p = wcsrchr(name3, '\\'); + p[5] = 0; /* => \\wine\0test */ + + RtlInitUnicodeString(&nameU, name); + name2U = nameU; + name3U = nameU; + name3U.Buffer = name3; +#ifdef _WIN64 + name_exp = name; + name3_exp = name3; + name2U_exp = name2U; +#else + if (IsWow64Process(GetCurrentProcess(), &is_wow64) && is_wow64) + { + name_exp = (WCHAR *)L"\\Registry\\Machine\\Software\\WOW6432Node\\wine_test"; + name3_exp =(WCHAR *) L"\\Registry\\Machine\\Software\\WOW6432Node\\wine\0test"; + } + else + { + name_exp = name; + name3_exp = name3; + } + RtlInitUnicodeString(&name2U_exp, name_exp); +#endif + name3U_exp = name2U_exp; + name3U_exp.Buffer = name3_exp; + name2U.Length += sizeof(WCHAR); /* add terminating \0 to string length */ + name2U_exp.Length += sizeof(WCHAR); /* add terminating \0 to string length */ + + status = pNtCreateKey(&handle, GENERIC_ALL, &attr, 0, NULL, 0, NULL); + ok(!status || status == STATUS_ACCESS_DENIED || broken(status == STATUS_OBJECT_PATH_NOT_FOUND) /* win8 */, "got %08lx\n", status); + if (!status) + { + test_object_name(handle, name_exp, FALSE); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr); + ok(!status, "got %08lx\n", status); + test_object_name(handle2, name_exp, FALSE); + pNtClose(handle2); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr2); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtDeleteKey(handle); + pNtClose(handle); + status = pNtCreateKey(&handle, GENERIC_ALL, &attr2, 0, NULL, 0, NULL); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U_exp); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr2); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name2U_exp); + pNtClose(handle2); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr); + ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "got %08lx\n", status); + pNtDeleteKey(handle); + pNtClose(handle); + status = pNtCreateKey(&handle, GENERIC_ALL, &attr3, 0, NULL, 0, NULL); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U_exp); + status = pNtOpenKey(&handle2, GENERIC_ALL, &attr3); + ok(!status, "got %08lx\n", status); + test_object_name_with_null(handle, &name3U_exp); + pNtClose(handle2); + pNtDeleteKey(handle); + pNtClose(handle); + } + else + skip("Limited access to \\Registry\\Machine\\Software key, skipping the tests\n"); +} + START_TEST(om) { HMODULE hntdll = GetModuleHandleA("ntdll.dll"); @@ -2767,6 +3114,7 @@ START_TEST(om) pNtDuplicateObject = (void *)GetProcAddress(hntdll, "NtDuplicateObject"); pNtCompareObjects = (void *)GetProcAddress(hntdll, "NtCompareObjects"); + test_null_in_object_name(); test_case_sensitive(); test_namespace_pipe(); test_name_collisions(); -- 2.37.1

1 0

[PATCH 1/2] ntdll/tests: Fix compilation with PSDK.
by Dmitry Timoshkov 28 Jul '22

28 Jul '22

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/ntdll/tests/om.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c index ddbdce0281c..7fe0fb59f89 100644 --- a/dlls/ntdll/tests/om.c +++ b/dlls/ntdll/tests/om.c @@ -2078,7 +2078,7 @@ static void test_token(void) status = pNtOpenThreadToken( GetCurrentThread(), TOKEN_ALL_ACCESS, TRUE, (HANDLE *)0xdeadbee0 ); ok( status == STATUS_ACCESS_VIOLATION, "NtOpenProcessToken failed: %lx\n", status); handle = (HANDLE)0xdeadbeef; - status = NtOpenProcessToken( (HANDLE)0xdead, TOKEN_ALL_ACCESS, &handle ); + status = pNtOpenProcessToken( (HANDLE)0xdead, TOKEN_ALL_ACCESS, &handle ); ok( status == STATUS_INVALID_HANDLE, "NtOpenProcessToken failed: %lx\n", status); ok( !handle || broken(handle == (HANDLE)0xdeadbeef) /* vista */, "handle set %p\n", handle ); handle = (HANDLE)0xdeadbeef; @@ -2526,7 +2526,7 @@ static void test_query_directory(void) RtlInitUnicodeString( &string, L"\\BaseNamedObjects\\winetest" ); InitializeObjectAttributes( &attr, &string, 0, 0, NULL ); - status = NtCreateDirectoryObject( &dir, DIRECTORY_QUERY, &attr ); + status = pNtCreateDirectoryObject( &dir, DIRECTORY_QUERY, &attr ); ok( !status, "got %#lx\n", status ); context = 0xdeadbeef; @@ -2717,9 +2717,9 @@ static void test_query_directory(void) ok( !memcmp( &info[1], &empty_info, sizeof(*info) ), "entry was not cleared\n" ); } - NtClose( child1 ); - NtClose( child2 ); - NtClose( dir ); + pNtClose( child1 ); + pNtClose( child2 ); + pNtClose( dir ); } START_TEST(om) -- 2.37.1

1 0

Re: [PATCH v2 2/2] ddraw/tests: Add some video memory accounting tests.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119983 Your paranoid android. === w7u_2qxl (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w1064 (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x00000040. === w1064_tsign (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x0000ff00. === debian11 (32 bit Chinese:China report) === Report validation errors: ddraw1: Timeout === debian11 (build log) === WineRunWineTest.pl:error: The task timed out

1 0

Re: [PATCH v3 5/9] mshtml: Implement lastElementChild for Elements.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119953 Your paranoid android. === w10pro64 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w10pro64_ar (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH v3 4/9] mshtml: Implement hasAttributeNS for Elements.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119952 Your paranoid android. === w10pro64 (32 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w1064_2qxl (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE === w1064_adm (64 bit report) === mshtml: script.c:3119: Test failed: ReportResult failed: 80ef0001

1 0

Re: [PATCH v3 3/9] mshtml: Implement removeAttributeNS for Elements.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119951 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

1 0

Re: [PATCH v4 1/1] d3drm/tests: Show Clear sets background color
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120010 Your paranoid android. === debian11 (32 bit report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Arabic:Morocco report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit German report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit French report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Hebrew:Israel report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Hindi:India report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Japanese:Japan report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Chinese:China report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit WoW report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (64 bit WoW report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f.

1 0

Re: [PATCH v3 2/9] mshtml: Implement setAttributeNS for Elements.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119950 Your paranoid android. === w10pro64 (32 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

1 0

Re: [PATCH 5/6] comctl32/listview: Don't send LVN_ODSTATECHANGED for empty ranges.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119995 Your paranoid android. === debian11 (32 bit report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit Chinese:China report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (64 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds

1 0

Re: [PATCH 4/6] comctl32/listview: Send LVN_ODSTATECHANGED notification for LVS_OWNERDATA listview on selection changes.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119994 Your paranoid android. === debian11 (32 bit report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit Chinese:China report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (64 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds

1 0

[PATCH v4 0/7] Fix LVS_OWNERDATA list view multi select.
by Angelo Haller 28 Jul '22

28 Jul '22

From: Angelo Haller <angelo(a)szanni.org> The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v4 fixing the log buffer overflow on the debian test machine by moving some of the up/down key sequences to a later patch. Patch 1/7 still includes the necessary up/down key sequences to validate the fixes in the following patches. The matching up/down key sequences for 1/7 are then introduced in 7/7. I was sadly unable to introduce the test sequence with each fix, as this would require inventing entirely new test sequences, just to work around the debian 32KB log buffer limit. I hope this is ok as it stands. I am also attaching the my remarks from v3, as I don't know if they got ignored due to failing tests: I was sadly not able to trigger any deselect sequences through emulating mouse clicks. I was actually completely unable even send a lef mouse button down at all. Both SendMessage and SendInput fail, on wind and windows. I am unsure if programmatic mouse clicks are even supported in list views? Some forums seem to suggest, that this is only the case for buttons and similar elements. I was following the code snippets in other parts of the comctl32 tests. The other thing might be that the signal is getting caught somewhere in the test code. If anybody has any more insight in this regard, I'd be happy to add additional mouse click tests as well. The other thing I was unable to do is activate the single select tests via SHIFT/+COMMAND to show we need patch 6/6. Windows weirdly informs about the selected item twice, once to inform the item has been selected and then in another call later about the item being focused as well. This seemingly only affects LVS_OWNERDATA listviews from my tests. Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. Angelo Haller (7): Add more test cases to ownderdata listviews: comctl32/listview: Fix deselect on LVS_OWNERDATA. comctl32/listview: Move sending LVN_ODSTATECHANGED notifications to a function. comctl32/listview: Send LVN_ODSTATECHANGED only for virtual lists. comctl32/listview: Send LVN_ODSTATECHANGED notification. comctl32/listview: Send LVN_ODSTATECHANGED only for true ranges. comctl32/tests: Expand ownerdata listview tests. dlls/comctl32/listview.c | 55 ++++--- dlls/comctl32/tests/listview.c | 253 +++++++++++++++++++++++++++++++-- 2 files changed, 281 insertions(+), 27 deletions(-) Signed-off-by: Angelo Haller <angelo(a)szanni.org> -- 2.36.1

2 11

Re: [PATCH v2 9/9] mshtml: Implement HTMLTitleElement's text property.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119867 Your paranoid android. === w10pro64_ar (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w10pro64_ja (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

1 0

Re: [PATCH v2 8/9] mshtml: Implement childElementCount for Elements.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119866 Your paranoid android. === w1064v1809 (64 bit report) === mshtml: script.c:3119: Test failed: ReportResult failed: 80ef0001

1 0

Re: [PATCH v6 9/9] mshtml: Implement HTMLTitleElement's text property.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119981 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 error: patch failed: dlls/mshtml/htmlelem.c:6611 error: patch failed: dlls/mshtml/tests/dom.js:90 error: patch failed: dlls/mshtml/htmlhead.c:103 error: patch failed: dlls/mshtml/tests/dom.js:533 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 error: patch failed: dlls/mshtml/htmlelem.c:6611 error: patch failed: dlls/mshtml/tests/dom.js:90 error: patch failed: dlls/mshtml/htmlhead.c:103 error: patch failed: dlls/mshtml/tests/dom.js:533 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 error: patch failed: dlls/mshtml/htmlelem.c:6611 error: patch failed: dlls/mshtml/tests/dom.js:90 error: patch failed: dlls/mshtml/htmlhead.c:103 error: patch failed: dlls/mshtml/tests/dom.js:533 Task: Patch failed to apply

1 0

Re: [PATCH v6 8/9] mshtml: Implement childElementCount for Elements.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119980 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 error: patch failed: dlls/mshtml/htmlelem.c:6611 error: patch failed: dlls/mshtml/tests/dom.js:90 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 error: patch failed: dlls/mshtml/htmlelem.c:6611 error: patch failed: dlls/mshtml/tests/dom.js:90 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 error: patch failed: dlls/mshtml/htmlelem.c:6611 error: patch failed: dlls/mshtml/tests/dom.js:90 Task: Patch failed to apply

1 0

Re: [PATCH v6 7/9] mshtml: Implement previousElementSibling for Elements.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119979 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 error: patch failed: dlls/mshtml/htmlelem.c:6553 error: patch failed: dlls/mshtml/tests/dom.js:98 Task: Patch failed to apply

1 0

Re: [PATCH v6 6/9] mshtml: Implement nextElementSibling for Elements.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119978 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 error: patch failed: dlls/mshtml/htmlelem.c:6560 error: patch failed: dlls/mshtml/tests/dom.js:94 Task: Patch failed to apply

1 0

Re: [PATCH v6 5/9] mshtml: Implement lastElementChild for Elements.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119977 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 error: patch failed: dlls/mshtml/htmlelem.c:6524 error: patch failed: dlls/mshtml/tests/dom.js:89 Task: Patch failed to apply

1 0

Re: [PATCH v6 4/9] mshtml: Implement hasAttributeNS for Elements.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119976 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 error: patch failed: dlls/mshtml/htmlelem.c:4925 error: patch failed: dlls/mshtml/tests/documentmode.js:1418 Task: Patch failed to apply

1 0

Re: [PATCH v6 3/9] mshtml: Implement removeAttributeNS for Elements.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119975 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 error: patch failed: dlls/mshtml/htmlelem.c:4886 error: patch failed: dlls/mshtml/tests/documentmode.js:1480 Task: Patch failed to apply

1 0

Re: [PATCH v6 2/9] mshtml: Implement setAttributeNS for Elements.
by Marvin 27 Jul '22

27 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119974 Your paranoid android. === build (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mshtml/htmlelem.c:4813 error: patch failed: dlls/mshtml/nsembed.c:998 error: patch failed: dlls/mshtml/htmlelem.c:4845 error: patch failed: dlls/mshtml/tests/documentmode.js:1408 Task: Patch failed to apply

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel