- wine-devel - winehq.org

MS releases vintage DOS source code
by Michael Stefaniuc 28 Mar '14

28 Mar '14

Not directly relevant to us as DOS got outsourced to dosbox but here it is nevertheless: http://www.computerhistory.org/atchm/microsoft-ms-dos-2-0-source-code/ If they keep releasing the source roughly 30 years after the OS hit the market, then Windows 3.11 is still 10 years out. bye michael

3 2

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Alexandre Julliard 28 Mar '14

28 Mar '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/rpcrt4/tests/server.c | 55 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/rpcrt4/tests/server.idl | 5 ++++ > 2 files changed, 60 insertions(+) It doesn't work on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M rpcrt4.dll -p rpcrt4_test.exe.so server && touch server.ok server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process make[1]: *** [server.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/6] winemac: Make ChangeDisplaySettingsEx() operate on the display named by the devname parameter.
by Ken Thomases 28 Mar '14

28 Mar '14

Hi, The first two patches in this series aren't quite right. Please don't commit them. They don't do the right thing with the registry settings. Patches 3 through 6 can be applied independently and are useful, so they can still be committed. (Bug 34978 won't quite be solved because DisplayFusion will be confused by enumerating the wrong modes for the second display.) -Ken

1 0

Re: user32: Change SetForegroundWindow behavior on windows with parent and no WS_CHILD flag
by Marvin 27 Mar '14

27 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6025 Your paranoid android. === w8 (32 bit win) === win.c:6433: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6433: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6433: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:6216: Test failed: wrong error 31

1 0

Re: loader: Add registry keys for Hidden and HideFileExt.
by Alexandre Julliard 26 Mar '14

26 Mar '14

Rico Schüller <kgbricola(a)web.de> writes: > --- > loader/wine.inf.in | 2 ++ > 1 file changed, 2 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlfolder && touch shlfolder.ok shlfolder.c:817: Test failed: SetNameOf failed! hr = 80004005 make: *** [shlfolder.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Change SetFocus behavior on windows with parent and no WS_CHILD flag
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6004 Your paranoid android. === w8 (32 bit win) === win.c:6205: Test failed: wrong error 31

1 0

Re: [PATCH 10/10] d3d9/tests: Use a separate device for alphatest_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6001 Your paranoid android. === w8 (32 bit visual) === visual.c:7387: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 09/10] d3d9/tests: Use a separate device for viewport_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6000 Your paranoid android. === w8 (32 bit visual) === visual.c:7387: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 08/10] d3d9/tests: Use a separate device for test_constant_clamp_vs().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5999 Your paranoid android. === w8 (32 bit visual) === visual.c:7387: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 07/10] d3d9/tests: Use a separate device for test_compare_instructions().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5998 Your paranoid android. === w8 (32 bit visual) === visual.c:7357: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7342: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7342: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 06/10] d3d9/tests: Use a separate device for test_mova().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5997 Your paranoid android. === w8 (32 bit visual) === visual.c:7325: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7310: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7310: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 05/10] d3d9/tests: Use a separate device for loop_index_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5996 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 04/10] d3d9/tests: Use a separate device for sincos_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5995 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 03/10] d3d9/tests: Use a separate device for sgn_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5994 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 02/10] d3d9/tests: Use a separate device for clip_planes_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5993 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 01/10] d3d9/tests: Use a separate device for test_vshader_input().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5992 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [2/2] netcfgx: Add INetCfgLock support (try 2)
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5989 Your paranoid android. === build (build) === Make failed

2 1

Re: [2/2] netcfgx: Add INetCfgLock support
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5988 Your paranoid android. === build (build) === Make failed

1 0

Re: setupapi: Don't confuse ARM with ARM64
by Qian Hong 25 Mar '14

25 Mar '14

On Wed, Mar 26, 2014 at 2:46 AM, André Hentschel <nerv(a)dawncrow.de> wrote: > "You screwed up but AJ missed it, send a fix before someone notices" ;-) André, you really should hide some bugs in your code as an evidence to proving someone stolen your code <grin> -- Regards, Qian Hong - http://www.winehq.org

2 1

Re: mshtml: Added IHTMLTableRow::bgColor property implementation.
by Alexandre Julliard 25 Mar '14

25 Mar '14

Zhenbo Li <litimetal(a)gmail.com> writes: > As MSDN said, bgColor property can be a VARIANT of type VT_BSTR or > VT_I4 that receives one of the color names or RGB values in the Color > Table.[1] So I declared variant_to_nscolor(from htmlbody.c) in > mshtml_private.h > > [1]: http://msdn.microsoft.com/en-us/library/aa741715%28v=vs.85%29.aspx > --- > dlls/mshtml/htmlbody.c | 2 +- > dlls/mshtml/htmltablerow.c | 29 +++++++++++++++++++++++++---- > dlls/mshtml/mshtml_private.h | 2 ++ > dlls/mshtml/tests/dom.c | 37 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 65 insertions(+), 5 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok dom.c:5641: Test failed: get_bgColor returned L"red" dom.c:5653: Test failed: get_bgColor returned L"#Ff0000" make: *** [dom.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32: Avoid a variable-length array.
by Bruno Jesus 25 Mar '14

25 Mar '14

On Tue, Mar 25, 2014 at 7:59 AM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > > #ifdef HAS_IRDA > +#define MAX_IRDA_DEVICES 10 > + I guess you could #undef before the #endif for HAS_IRDA since the define is no longer used, but that is just my opinion.

2 1

Re: [PATCH 1/5] d3d9/tests: Use a separate device for test_vshader_input().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5937 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

2 1

Re: [PATCH 5/5] d3d9/tests: Use a separate device for loop_index_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5941 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for sincos_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5940 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for sgn_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5939 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for clip_planes_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5938 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf. (try 2)
by Nikolay Sivov 25 Mar '14

25 Mar '14

On 3/19/2014 17:02, Jactry Zeng wrote: > Update: > - Add a todo_wine. > > + ITextDocument_Open(txtDoc, &testfile, tomReadOnly|tomRTF, CP_ACP); It's a common practice to check a return value. > + /* open a rtf without } in the end */ > + result = ITextDocument_Open(txtDoc, &testfile, tomReadOnly, CP_ACP); > + /* 0x80070026 is HRESUILT_FROM_WIN32(ERROR_HANDLE_EOF) */ > + todo_wine ok(result == 0x80070026, "ITextDocument_Open: Should return an ERROR_HANDLE_EOF error.\n"); No need to put a magic number, use HRESULT_FROM_WIN32(), and don't forget to use proper type for return value. Also a typo in a comment, but that it go anyway.

2 1

Re: wintab: Incorrectly classifying cursor as stylus instead of eraser
by Alexandre Julliard 25 Mar '14

25 Mar '14

Eriks Dobelis <eriks.dobelis(a)biti.lv> writes: > Did not attach the patch in my last email :( > > For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly > detected as stylus. > The tablet returns its eraser cursor name as: > Wacom Intuos PT S Pen eraser > and type as: > ERASER > > Current code classifies this as STYLUS, because name of the cursor > contains the word 'Pen'. It is very unlikely that a cursor with type > ERASER is STYLUS. There is already a check for eraser type, you should be able to use that instead. -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: user32: Fix side effect in SubtractRect()
by Nikolay Sivov 24 Mar '14

24 Mar '14

Hi, Jose. Please add a test case for this change to user32/tests/uitools.c

2 3

Re: user32: Workaround SetForegroundWindow failure due to foreground lock timeout
by Marvin 24 Mar '14

24 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5923 Your paranoid android. === w8 (32 bit win) === win.c:6403: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6425: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6403: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6403: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6425: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6403: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6425: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:6186: Test failed: wrong error 31

1 0

Re: [PATCH 2/2] wininet: Fixed tests on some old Windows versions.
by Marvin 24 Mar '14

24 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5909 Your paranoid android. === w8 (32 bit http) === http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:4292: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800000, expected 800000 http.c:4292: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800000, expected 800000 http.c:4295: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800080, expected 800080 http.c:4295: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800080, expected 800080 http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:957: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 2 times, received 1 times http.c:958: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 2 times, received 1 times http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:4620: Test failed: expected ERROR_HTTP_HEADER_NOT_FOUND, got 0

2 1

Re: [PATCH 1/2] wininet: Merge GetLastError() test into other request tests.
by Marvin 24 Mar '14

24 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5908 Your paranoid android. === w2000pro (32 bit http) === http.c:3058: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 1 times, received 0 times http.c:3059: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 1 times, received 0 times === w8 (32 bit http) === http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:4284: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800000, expected 800000 http.c:4284: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800000, expected 800000 http.c:4287: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800080, expected 800080 http.c:4287: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800080, expected 800080 http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:957: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 2 times, received 1 times http.c:958: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 2 times, received 1 times http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:4612: Test failed: expected ERROR_HTTP_HEADER_NOT_FOUND, got 0

1 0

Re: dxdiagn: Added properties for hardware acceleration capabilities
by Stefan Dösinger 24 Mar '14

24 Mar '14

Am 23.03.2014 um 04:18 schrieb Markus Weiland <mw(a)graph-ix.net>: > This patch addresses bug http://bugs.winehq.org/show_bug.cgi?id=11114 I filed four years ago. It hardcodes the b3DAccelerationExists, b3DAccelerationEnabled, and bDDAccelerationEnabled properties to TRUE. IDirect3D9::GetDeviceCaps with D3DDEVTYPE_HAL should do. If the call suceeds you have hardware acceleration.

3 3

Regarding GSoC
by Ashwani Agarwal 24 Mar '14

24 Mar '14

Hello, I've submitted my proposal for GSoC 2014 on Tools - Winetest Graphical User Interface. Can someone review it, so if there is any changes to make, can be done. and also can I know who is the potential mentor for this project? So I can contact him and proceed further.

2 1

Mass effect 2 - Bink movies freezes game
by Tomas Gustavsson 23 Mar '14

23 Mar '14

Hi! Have tried for a while to get Mass Effect 2 working through Wine and though it's very playable for me it has a large drawback, I have to disable all movie playbacks with the -nomoviestartup argument. If I don't, the game freezes up and I can hear the sound stuck in a loop - it does not unfreeze itself. By looking through AppDB it seems that there are a large group of people that doesn't have this problem. I assume it's either related to my processor (AMD A10-6700) or GPU (HD5770, Catalyst driver)? I have tried to several Wine versions but it didn't help. The interesting thing is that there are many Windows users with the exact problem. Here's a link http://answers.ea.com/t5/Mass-Effect-2/Can-t-run-ME2-without-nomoviestartup…. So though the game works rather well, an important part (and some locations in the game supposedly breaks when you use nomoviestartup) is lost when movies are turned off, at least for me. Is there any way to debug the bink movie playback functionality? Because I really would like to be able to play the game without losing the ability to watch the ingame movies. Best regards /Tomas Gustavsson

2 2

Re: [PATCH] ntdll: test also FullDirectoryInformation (2nd)
by Marvin 23 Mar '14

23 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5880 Your paranoid android. === w2000pro (32 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === wxppro (32 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === wvista (32 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === wvistau64 (32 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === w2008s64 (32 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === w7pro64 (32 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === w8 (32 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === wvistau64 (64 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === w2008s64 (64 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory === w7pro64 (64 bit directory) === directory.c:250: Test failed: not enough data in directory directory.c:250: Test failed: not enough data in directory

1 0

Re: [PATCH] kernel32: implemented "Basic" mode of findfirstfilex
by Marvin 23 Mar '14

23 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5879 Your paranoid android. === w2000pro (32 bit file) === file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed === wxppro (32 bit file) === file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed === wvista (32 bit file) === file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed === wvistau64 (32 bit file) === file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed === w2008s64 (32 bit file) === file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed === wvistau64 (64 bit file) === file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed === w2008s64 (64 bit file) === file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed file.c:2630: Test failed: FindFirstFile failed (err=87) file.c:2631: Test failed: First entry should be '.', is file2 file.c:2635: Test failed: Fetching second file failed file.c:2636: Test failed: Second entry should be '..' is file2 file.c:2638: Test failed: Fetching third file failed file.c:2652: Test failed: Fetching fourth file failed file.c:2655: Test failed: Fetching fifth file failed

1 0

Re: [PATCH] ntdll: test also FullDirectoryInformation
by Marvin 23 Mar '14

23 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5878 Your paranoid android. === w2000pro (32 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === wxppro (32 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === wvista (32 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === wvistau64 (32 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === w2008s64 (32 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === w7pro64 (32 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === w8 (32 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === wvistau64 (64 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === w2008s64 (64 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory === w7pro64 (64 bit directory) === directory.c:248: Test failed: not enough data in directory directory.c:248: Test failed: not enough data in directory

1 0

Re: [mshtml] add text/jscript as valid mime type for javascript files
by Jacek Caban 23 Mar '14

23 Mar '14

Hi Vijay, On 03/22/14 11:39, Vijay Kiran Kamuju wrote: > This is identified by Focht in bug #35827, patch fixes it. > > Changelog: > add text/jscript as valid mime type for javascript files > fixes bug# 35827 Please add a test case. Something like setting type on script element in exectest.html should be enough. Thanks, Jacek

1 0

Re: gdiplus: skip some tests if Arial is not installed
by Dmitry Timoshkov 23 Mar '14

23 Mar '14

Austin English <austinenglish(a)gmail.com> wrote: > + status = GdipCreateFontFamilyFromName(Arial, NULL, &family); > + if (status == FontFamilyNotFound) > + { > + skip("Arial not installed\n"); > + return; > + } Why do you need this? This test doesn't depend on Arial font presence. -- Dmitry.

2 2

Re: gdi32: skip some tests if Times New Roman is not installed
by Marvin 22 Mar '14

22 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5864 Your paranoid android. === w8 (32 bit font) === font.c:3615: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3615: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c

1 0

Re: ws2_32: skip some tests on broken ISPs
by Marvin 22 Mar '14

22 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5855 Your paranoid android. === w2000pro (32 bit sock) === sock: unhandled exception c0000005 at C0000241 === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 71AB3F3A === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

2 1

Ignore me
by Jeremy Newman 22 Mar '14

22 Mar '14

I am a test post... -N

1 0

Add a program to Wine Programs menu
by Robson 21 Mar '14

21 Mar '14

Hello, I saw the post below with a way to add a program to Wine Programs menu: https://answers.launchpad.net/ubuntu/+source/wine/+question/148594 Suggestion: add a tab in the configuration interface of wine to add remove or edit program shortcuts. With that the User can easily and quickly organize your shortcuts to favorite programs. Thanks.

1 0

GSoC 2014 proposal - Implement VBScript built-in functions
by 孟帅 21 Mar '14

21 Mar '14

Hi all! I'm Shuai Meng, a student from software school of Beihang University, China, GMT+08:00. I'm pursuing a master degree and now in grade one. You can call me shuaimeng, that's my nickname used in irc. Now I'm here to apply for GSoC to work for Wine. I'm familiar with C, and I can code with python as well. Besides, I know a little about html and vbscript. From May to August, I have plenty of free time. About one year ago I started my way to linux, it's not smooth for a person who had got used to windows then embrace linux. Soon I got a problem: QQ(the most popular IM software in China) doesn't support linux, but I really need it. Fortunately I knew wine through searching google, it helped me solve this problem.Since then I have become a wine user. In the past three months, I had focused on dlls/vbscript/global.c, searching MSDN for related documents[1]~[4]. Accordding those documents, I added more tests in dlls/vbscript/tests/api.vbs, then got some similar bugs and only reported one[5]. In order to fix them, I read wine source code in dlls/vbscript/global.c, again and again. Finally I finished a few draft patches[6] and I will send them to wine-patches later. As I have made so much effort in this module and gain a little experience, during GSoC this part will go on to occupy most of my attention. On the basis of difficulty to be implemented, I divide all the functions in dlls/vbscript/global.c into four groups as following: 1: Abs ScriptEngine ScriptEngineBuildVersion ScriptEngineMajorVersion IsArray IsDate IsNumeric IsObject Sgn TypeName VarType These are the easiest to implement, I will take about one week to finish the unimplemented. 2: FormatCurrency FormatDateTime FormatPercent Hour FormatNumber Join Minute Month Oct Rnd Second Space TimeValue Year The second group will occupy two weeks of the whole GSoC time. They are not as easy as the first group and there are more to be accomplished. Most of them are involved in time functions while a few is about strings. 3: Asc Ant Cos DateAdd DateDiff DatePart DateSerial Day Exp LBound Log Replace Sin Sqr String Tan TimeSerial UBound Weekday CBool CByte CCur CDate CDbl CInt CLng CSng CStr InStrRev Int Fix StrComp Timer These are more difficult. However a large part is conversion functions and they have been implemented or improved by me. You can find the details in attchment. Optimistically speaking, I need at least three weeks to complete all of them. When I finish that, this bug[7] will be fixed. 4: Array Date DateValue Escape Eval Filter GetLocale GetRef InputBox LoadPicture Now RGB SetLocale Split Time Unescape Here come the most difficult ones. I am not so sure whether I can fix or even understand them, but I will try my best. Maybe after I have finish the above three groups, I can gain a little confidence to face them. This group would cost me four weeks or even longer. If I have a good luck, maybe I can fix this bug[8]. To be prudent, I'll spare at least one week to do a review on all my codes. Write a summary as a guidence for my work to be continued after GSoC. Though I have a rough plan now, as a greenhand to wine, I hava too much to learn and I badly need advice from all of you. I hope I can make a proper schedule after communicating with my mentor. Any comment or advice is greatly appreciated. Thank you! [1]http://msdn.microsoft.com/en-us/library/9e7a57cf(v=vs.84).aspx [2]http://msdn.microsoft.com/en-us/library/t7zd6etz(v=vs.84).aspx [3]http://msdn.microsoft.com/en-us/library/3ca8tfek(v=vs.84).aspx [4]http://msdn.microsoft.com/en-us/library/10wcf65z(v=vs.84).aspx [5]http://bugs.winehq.org/show_bug.cgi?id=35441 [6]In the attachment [7]http://bugs.winehq.org/show_bug.cgi?id=34913 [8]http://bugs.winehq.org/show_bug.cgi?id=35472

4 4

Re: netcfgx: Add INetCfg interface support
by Marvin 21 Mar '14

21 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5820 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

3 2

Re: [1/3] widl: Pass type attributes from write_array_tfs to write_pointer_description. Take 2.
by Nikolay Sivov 21 Mar '14

21 Mar '14

On 3/21/2014 11:09, Dmitry Timoshkov wrote: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). > > This version of the patch limits write_array_tfs() to pass attributes > to write_pointer_description() only for strings and avoids unwanted > changes to other pointer types. > --- > tools/widl/typegen.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index 37d18f5..889d8c5 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -2728,7 +2728,7 @@ static int write_varying_array_pointer_descriptions( > return pointer_count; > } > > -static void write_pointer_description(FILE *file, type_t *type, > +static void write_pointer_description(FILE *file, const attr_list_t *attrs, type_t *type, > unsigned int *typestring_offset) > { > unsigned int offset_in_buffer; > @@ -2757,7 +2757,7 @@ static void write_pointer_description(FILE *file, type_t *type, > if (is_conformant_array(type) && > (type_array_is_decl_as_ptr(type) || !current_structure)) > write_conformant_array_pointer_descriptions( > - file, NULL, type, 0, typestring_offset); > + file, attrs, type, 0, typestring_offset); > else if (type_get_type(type) == TYPE_STRUCT && > get_struct_fc(type) == RPC_FC_CPSTRUCT) > { > @@ -2962,7 +2962,7 @@ static unsigned int write_array_tfs(FILE *file, const attr_list_t *attrs, type_t > print_file(file, 2, "0x%x,\t/* FC_PP */\n", RPC_FC_PP); > print_file(file, 2, "0x%x,\t/* FC_PAD */\n", RPC_FC_PAD); > *typestring_offset += 2; > - write_pointer_description(file, type, typestring_offset); > + write_pointer_description(file, is_string_type(attrs, type) ? attrs : NULL, type, typestring_offset); I think it'd be cleaner to let write_pointer_description() handle that, as now you pass all needed info in anyway.

2 1

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 21 Mar '14

21 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5825 Your paranoid android. === build (build) === Make failed

1 0

GSoC 2014: Student application period is almost over!
by Austin English 20 Mar '14

20 Mar '14

Howdy everyone, If you're a student that wants to apply for GSoC 2014, you have until tomorrow*, **March 21 at 19:00 UTC*, to submit your proposals. See https://www.google-melange.com/gsoc/events/google/gsoc2014 for the timeline, and https://www.google-melange.com/gsoc/org2/google/gsoc2014/wine I'd like to also remind students that a patch or testcase must have been submitted to wine before to be considered. It is not required to have been accepted, but you must show that you are able to build/tinker on wine's source code. See http://wiki.winehq.org/SummerOfCode and http://wiki.winehq.org/SubmittingPatches for more info. Good luck! -- -Austin

1 0

Re: [PATCH 3/6] d3d8: Use the private store api for buffers.
by Henri Verbeet 20 Mar '14

20 Mar '14

On 20 March 2014 12:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (stored_data->flags & WINED3DSPD_IUNKNOWN) > + { > + *(IUnknown **)data = stored_data->content.object; > + IUnknown_AddRef(*(IUnknown **)data); > + } > + else > + memcpy(data, stored_data->content.data, stored_data->size); + if (stored_data->flags & WINED3DSPD_IUNKNOWN) + IUnknown_AddRef(stored_data->content.object); + memcpy(data, stored_data->content.data, stored_data->size);

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel