- wine-devel - winehq.org

PLEASE add bug links!
by Ken Sharp 18 Aug '13

18 Aug '13

There's little point in my continually asking users to add bug links to the AppDB if maintainers and/or administrators don't bother themselves. It takes longer to create a bug report than it does to link it to the database. It really isn't that hard. I've added hundreds over the past few weeks and this is not the first time I have said it, nor am I the first one to do so. It's even on the Wiki. http://wiki.winehq.org/Bugs

8 20

Re: mshtml: Use winehq snapshot instead of the main page in tests.
by Marvin 18 Aug '13

18 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26726 Your paranoid android. === WXPPROSP2 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00289218) != exmon(002683C0) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00289218) != exmon(002683C0) htmldoc.c:5715: Test failed: mon(00289218) != exmon(002683C0) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(002CFA10) != exmon(002854D0) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(002CFA10) != exmon(002854D0) htmldoc.c:5715: Test failed: mon(002CFA10) != exmon(002854D0) === WXPX64 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(0067F130) != exmon(00653D78) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(0067F130) != exmon(00653D78) htmldoc.c:5715: Test failed: mon(0067F130) != exmon(00653D78) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(006A5D60) != exmon(0069E610) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(006A5D60) != exmon(0069E610) htmldoc.c:5715: Test failed: mon(006A5D60) != exmon(0069E610) === WVISTAX64 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(006F6E18) != exmon(006F6018) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(006F6E18) != exmon(006F6018) htmldoc.c:5715: Test failed: mon(006F6E18) != exmon(006F6018) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(006F6518) != exmon(006F5F18) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(006F6518) != exmon(006F5F18) htmldoc.c:5715: Test failed: mon(006F6518) != exmon(006F5F18) === W7PROX64 (32 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00708F30) != exmon(00708670) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00708F30) != exmon(00708670) htmldoc.c:5715: Test failed: mon(00708F30) != exmon(00708670) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00708C30) != exmon(007081B0) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00708C30) != exmon(007081B0) htmldoc.c:5715: Test failed: mon(00708C30) != exmon(007081B0) === WXPX64 (64 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(0000000000297C90) != exmon(000000000027FD00) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(0000000000297C90) != exmon(000000000027FD00) htmldoc.c:5715: Test failed: mon(0000000000297C90) != exmon(000000000027FD00) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00000000002D1AC0) != exmon(00000000002FC160) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00000000002D1AC0) != exmon(00000000002FC160) htmldoc.c:5715: Test failed: mon(00000000002D1AC0) != exmon(00000000002FC160) === WVISTAX64 (64 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(000000000089DD50) != exmon(0000000000823490) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(000000000089DD50) != exmon(0000000000823490) htmldoc.c:5715: Test failed: mon(000000000089DD50) != exmon(0000000000823490) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(000000000089E1D0) != exmon(0000000000823A90) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(000000000089E1D0) != exmon(0000000000823A90) htmldoc.c:5715: Test failed: mon(000000000089E1D0) != exmon(0000000000823A90) === W7PROX64 (64 bit htmldoc) === htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00000000007621D0) != exmon(0000000000761750) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:2507: Test failed: unexpected call UpdateUI htmldoc.c:2809: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00000000007621D0) != exmon(0000000000761750) htmldoc.c:5715: Test failed: mon(00000000007621D0) != exmon(0000000000761750) htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3139: Test failed: unexpected call Invoke_AMBIENT_SILENT htmldoc.c:3124: Test failed: unexpected state L"uninitialized", expected 1 htmldoc.c:3124: Test failed: VT_I4(out)=0, expected 1 htmldoc.c:3136: Test failed: unexpected call Invoke_AMBIENT_OFFLINEIFNOTCONNECTED htmldoc.c:3204: Test failed: unexpected call Invoke_OnReadyStateChange_Loading htmldoc.c:2861: Test failed: mon(00000000046C9830) != exmon(0000000000761C50) htmldoc.c:2460: Test failed: unexpected call GetHostInfo htmldoc.c:3412: Test failed: dwFlags = 8 htmldoc.c:7326: Test failed: mon(00000000046C9830) != exmon(0000000000761C50) htmldoc.c:5715: Test failed: mon(00000000046C9830) != exmon(0000000000761C50)

2 1

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)
by John Chadwick 17 Aug '13

17 Aug '13

Nikolay, does this patch look good to you? I was advised on #winehackers to get some acknowledgement that the patch is OK. Hopefully doing so can get things moving along.

2 1

open bugs / multi thread / recommendation on new system
by Damian Ivanov 17 Aug '13

17 Aug '13

Hi guys, As you have a track of open bugs: 1) ATI or nVidia for new GPU? Does SLI/Crossfire work with wine? 2) FX 8320 or intel same price class CPU? As the AMD has far inferior single thread performance but far superior multi thread performance - does wine run a win32 single thread app as multi thread? does wine make use of multithread in general? Thanks in advance :) Damian

1 0

Re: [PATCH 4/6] oleaut32: TKIND_ALIAS improvements
by Piotr Caban 17 Aug '13

17 Aug '13

On 08/16/13 21:40, Andrew Eikum wrote: > @@ -8502,7 +8502,7 @@ static HRESULT WINAPI ICreateTypeLib2_fnCreateTypeInfo(ICreateTypeLib2 *iface, > info->cbSizeInstance = 2; > break; > case TKIND_ALIAS: > - info->cbSizeInstance = -0x75; > + info->cbSizeInstance = 4; > break; > default: > FIXME("unrecognized typekind %d\n", info->typekind); > cbSizeInstance and cbAligment value depends on alias type. As long as alias type is not set cbSizeInstance stores some strange values (-0x75 is matching what one of native versions of dll stores there). Both of these values should be set in SetTypeDescAlias function.

1 0

Re: imm32/tests: Fix a trailing '\n' in an ok() call.
by Qian Hong 17 Aug '13

17 Aug '13

> - ok(ic != NULL, "ImmLockIMC failed\n!"); > + ok(ic != NULL, "ImmLockIMC failed!\n"); Oh, good catch... Thanks! -- Regards, Qian Hong - http://www.winehq.org

1 0

Re: Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.
by Marvin 16 Aug '13

16 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26722 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [website] Added templates/zh-cn/cvs.template translation
by Frédéric Delanoy 16 Aug '13

16 Aug '13

On Fri, Aug 16, 2013 at 8:13 AM, xulixin <xulixin1990(a)gmail.com> wrote: > From 860262aed3d58f42012e6dd5264eb29bd29deffb Mon Sep 17 00:00:00 2001 > From: xulixin <xulixin1990(a)gmail.com> > Date: Fri, 16 Aug 2013 13:56:36 +0800 > Subject: add templates/zh-cn/cvs.template > > --- > templates/zh-cn/cvs.template | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/templates/zh-cn/cvs.template b/templates/zh-cn/cvs.template > index ba10a25..a9bc5d1 100644 > --- a/templates/zh-cn/cvs.template > +++ b/templates/zh-cn/cvs.template > @@ -13,9 +13,9 @@ > > <h1 id="sourcetree">通过 Web 方式浏览源码树</h1> > > -<p>The source code of the entire Wine tree is (<a > href="http://lxr.linux.no/">LXR</a>-based) > - cross-referenced and available for browsing, including a search engine. > - This cross-references source is based on the snapshot-releases and is > made available at:</p> > +<p>Wine tree的源码 (<a href="http://lxr.linux.no/">LXR</a>-based) > + 是相互参照且可供浏览的，包括一个搜索引擎。 > + 这交叉参考的源码是基于snapshot-releases版本，可从下面网站获得：</p> > <ul> > <li><a href="http://source.winehq.org/">source.winehq.org</a></li> > </ul> Hi, the real name is required when sending patches. Also, lxr.linux.no isn't used anymore, so the original file would need to be updated beforehand. -- Frédéric Delanoy

3 5

Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.
by Alexandre Julliard 16 Aug '13

16 Aug '13

Kai Tietz <ktietz70(a)googlemail.com> writes: > diff --git a/dlls/msvcrt/dir.c b/dlls/msvcrt/dir.c > index 44802b3..3b9e3c7 100644 > --- a/dlls/msvcrt/dir.c > +++ b/dlls/msvcrt/dir.c > @@ -365,14 +365,25 @@ int CDECL MSVCRT__chdrive(int newdrive) > { > WCHAR buffer[] = {'A', ':', 0}; > > + if (newdrive < 1 || newdrive > 31) > + { > + *MSVCRT___doserrno () = ERROR_INVALID_DRIVE; > + *MSVCRT__errno () = MSVCRT_EACCES; > + return -1; > + } > buffer[0] += newdrive - 1; > - if (!SetCurrentDirectoryW( buffer )) > + > + _lock (_ENV_LOCK); > + > + if (!SetCurrentDirectoryW (buffer)) > { > - msvcrt_set_errno(GetLastError()); > - if (newdrive <= 0) > - *MSVCRT__errno() = MSVCRT_EACCES; > + msvcrt_set_errno (GetLastError ()); > + _unlock (_ENV_LOCK); > return -1; > } > + > + _unlock (_ENV_LOCK); > + > return 0; > } Please add test cases at least for the error values. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ntdll: empty APC queue before starting an application
by Alexandre Julliard 16 Aug '13

16 Aug '13

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > --- > dlls/ntdll/loader.c | 3 +++ > dlls/ntdll/ntdll.spec | 2 +- > dlls/ntdll/sync.c | 16 ++++++++++++++++ > 3 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index b3abad0..1eaa123 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -2747,6 +2747,9 @@ void WINAPI LdrInitializeThunk( void *kernel_start, ULONG_PTR unknown2, > > virtual_release_address_space(); > virtual_clear_thread_stack(); > + > + NtTestAlert(); > + > wine_switch_to_stack( start_process, kernel_start, NtCurrentTeb()->Tib.StackBase ); This would have to run on the thread stack. Also please try to add some tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [website] Update git URL
by Michael Stefaniuc 16 Aug '13

16 Aug '13

On 08/16/2013 03:32 PM, Frédéric Delanoy wrote: > --- > templates/en/cvs.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/en/cvs.template b/templates/en/cvs.template > index 202cf60..300b9e4 100644 > --- a/templates/en/cvs.template > +++ b/templates/en/cvs.template > @@ -3,9 +3,9 @@ > > <h1 class="title">The Wine CVS Tree</h1> Schouldn't the title change too? And nowadays people know what git is and that's kinda the default SCM that people expect. > > -<p><strong>Note: We have switched development from CVS to <a href="http://git.or.cz">Git</a>. > +<p><strong>Note: We have switched development from CVS to <a href="http://git-scm.com/">Git</a>. > Wine can no longer be downloaded via CVS. > - Instructions for using the <a href="{$root}/site/git">Wine Git tree</a> > + Instructions for using the Wine Git tree > can be found on the <a href="http://wiki.winehq.org/GitWine">GitWine</a> > page on the <a href="http://wiki.winehq.org">Wine Wiki</a>.</strong></p> bye michael

2 1

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.
by Alexandre Julliard 16 Aug '13

16 Aug '13

Kai Tietz <ktietz70(a)googlemail.com> writes: > Due line wrap, I sent patch as attachment. > > Kai > > From 3fcedb770626535b56a789467951a4c9be5f08dc Mon Sep 17 00:00:00 2001 > From: Kai Tietz <ktietz70(a)googlemail.com> > Date: Thu, 8 Aug 2013 12:29:33 +0200 > Subject: [PATCH 01/11] widl: New option --rt for enabling rt's specific > language extensions. > > --- > tools/widl/widl.c | 6 ++++++ > tools/widl/widl.h | 1 + > 2 files changed, 7 insertions(+), 0 deletions(-) Please update the usage message and the manpage accordingly. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] apphelp: Add definitions
by Dmitry Timoshkov 16 Aug '13

16 Aug '13

Mislav Blazevic <krofnica996(a)gmail.com> wrote: > --- > dlls/apphelp/apphelp.c | 10 +- > dlls/apphelp/apphelp.h | 272 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 273 insertions(+), 9 deletions(-) > create mode 100644 dlls/apphelp/apphelp.h Where all of this comes from? Is there an application that calls apphelp APIs and doesn't work because of failures? How are you testing your implementation? -- Dmitry.

3 6

Re: comsvcs: Add dll comsvcs (resend)
by André Hentschel 16 Aug '13

16 Aug '13

Am 16.08.2013 12:39, schrieb Alistair Leslie-Hughes: > Hi, > > > Changelog: > comsvcs: Add dll comsvcs > > > Best Regards > Alistair Leslie-Hughes you missed the configure.ac part?

1 0

Re: [3/3] ntdll/tests: Add a bunch of overlapped IO tests for files.
by Marvin 16 Aug '13

16 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26708 Your paranoid android. === WXPX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === WVISTAX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1884: Test failed: expected STATUS_SUCCESS, got 0 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1903: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === W7PROX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === TEST64_W7SP1 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1884: Test failed: expected STATUS_SUCCESS, got 0 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1903: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3

2 1

Re: [2/3] ntdll/tests: Use official path for temporary files instead of current directory.
by Marvin 16 Aug '13

16 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26707 Your paranoid android. === WXPX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === WVISTAX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === W7PROX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === TEST64_W7SP1 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3

1 0

Re: [3/3] ntdll: Implement compatible typelib section
by Marvin 16 Aug '13

16 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26698 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout === WXPPROSP2 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WXPX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W2K3R2SESP2 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WVISTAX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W7PROX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === TEST64_W7SP1 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WXPX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WVISTAX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W7PROX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === TEST64_W7SP1 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043

1 0

Re: [2/3] ntdll: Added support for all typelib section attributes
by Marvin 16 Aug '13

16 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26697 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout === WXPPROSP2 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WXPX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W2K3R2SESP2 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WVISTAX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W2K8SE (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W7PROX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === TEST64_W7SP1 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WXPX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === WVISTAX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === W7PROX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === TEST64_W7SP1 (64 bit actctx) === actctx.c:1357: Test failed: got 409

1 0

Re: [1/3] kernel32: Some tests for typelib sections
by Marvin 16 Aug '13

16 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26696 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout

1 0

Re: mscoree: Redirect .NET 1.0 to .NET 2.0
by Alexandre Julliard 15 Aug '13

15 Aug '13

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > mscoree: Redirect .NET 1.0 to .NET 2.0 It doesn't work: ../../../tools/runtest -q -P wine -M mscoree.dll -T ../../.. -p mscoree_test.exe.so mscoree.c && touch mscoree.ok mscoree.c:179: Test failed: version is L"v1.1.4322" , expected L"v2.0.50727" mscoree.c:187: Test failed: GetRequestedRuntimeInfo returned 80131700 mscoree.c:188: Test failed: version is L"" , expected L"v2.0.50727" make: *** [mscoree.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: configure.ac: allow disabling winemac.drv (try 2)
by Alexandre Julliard 15 Aug '13

15 Aug '13

Austin English <austinenglish(a)gmail.com> writes: > try 2: don't unconditionally disable ApplicationServices.h > > Tested on 10.7 > diff --git a/configure.ac b/configure.ac > index 0e3df61..5e1fe10 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -70,6 +70,7 @@ AC_ARG_WITH(pthread, AS_HELP_STRING([--without-pthread],[do not use the pthrea > AC_ARG_WITH(sane, AS_HELP_STRING([--without-sane],[do not use SANE (scanner support)])) > AC_ARG_WITH(tiff, AS_HELP_STRING([--without-tiff],[do not use TIFF])) > AC_ARG_WITH(v4l, AS_HELP_STRING([--without-v4l],[do not use v4l1 (v4l support)])) > +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build native Mac (Cocoa) driver])) It should be --disable-winemac.drv, and it should work fine already, same as with any other dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mscoree: Attempt to load the assembly from the application directory
by Vincent Povirk 15 Aug '13

15 Aug '13

This seems suspicious to me. You appear to be taking the namespace of the class and assuming it's an assembly name. Is there really no other information in the registry that could be used to identify the assembly?

3 4

Re: msvcrt: add support for _chsize_s
by Ken Sharp 14 Aug '13

14 Aug '13

On 14/08/13 20:08, morphiend wrote: > -@ stub _chsize_s > +@ cdecl _chsize_s(long int64) msvcrt._chsize > +#@ stub _chsize_s Oops..

1 0

Re: mscoree: Redirect .NET 1.0 to .NET 2.0
by Vincent Povirk 14 Aug '13

14 Aug '13

Looks good, thanks.

1 0

Possibility of adding a new patch status
by Hugh McMaster 14 Aug '13

14 Aug '13

Hi everyone, Wine patches currently have a status described in http://source.winehq.org/patches, yet for patches with the status of 'New', the status becomes confusing. The legend describes 'New' status as "Patch not even looked at yet, there's still hope...". This is ideal for new patches submitted within that 24-hour commit cycle. But I'm finding it difficult to follow patches that remain with a status of 'New' for longer than the 24-hour patch cycle. Obviously, on the weekend, patches are held over till Monday, so a longer lead-time is expected. During weekdays, however, it is unclear what is happening with some patches. This, ultimately, raises the question of timeliness. Has the patch been looked at? If it has, the status often describes what action was taken - committed, rejected, superseded, etc. This is fine, but some patches remain with a status of 'New'. Experience has told me that patches remaining with a status of 'New' are incorrect in some way. But this is not always the case. If the patch is incorrect, but close to being accepted, the patch's status should reflect this, by changing to something like "Revision needed". Of course, the "Rejected" status is also appropriate, depending on the severity of coding error. Also, there are likely to be many times when the maintainer has not had time to evaluate some patches. This means the patch is not new (i.e. recently submitted), but is awaiting review. Once again, I believe the patch status should reflect this situation. The status could be "Not yet reviewed". In summary, the 'New' status should be reserved for patches that are actually new. Just some thoughts.

3 7

Re: gdiplus: Only clip strings if rectangle width and height are positive.
by Dmitry Timoshkov 14 Aug '13

14 Aug '13

Vincent Povirk <madewokherd(a)gmail.com> wrote: > if (!(format_flags & StringFormatFlagsNoClip) && > - scaled_rect.Width != 1 << 23 && scaled_rect.Height != 1 << 23) > + scaled_rect.Width != 1 << 23 && scaled_rect.Height != 1 << 23 && > + rect->Width > 0.0 && rect->Height > 0.0) > { > /* FIXME: If only the width or only the height is 0, we should probably still clip */ > rgn = CreatePolygonRgn(corners, 4, ALTERNATE); Probably FIXME should be removed then. -- Dmitry.

2 1

wine-bugs change?
by Thomas Spear 13 Aug '13

13 Aug '13

Hi all, I've been subscribed to the lists for several years now, archiving all of the conversations in case a situation ever arises where a backup copy is needed. I've had a filter setup in gmail for wine-bugs that has worked perfectly fine for a long time now, but over the last couple of days, I've noticed that all emails sent to or from wine-bugs are now being directed to my inbox in addition to the folder I have the filter setup for. I'm planning on contacting Google as well, but thought I should cover all of the bases by asking here if there have been any changes made to that list specifically that might have caused the filter to not work. I've tried editing the filter so that I can see what messages it searches for, and it appears to be working properly, in that it appears to locate the emails I have the filter setup for, including those that are currently in both my inbox and the folder I specified to have them moved to, so it could be that there is an issue with the "Skip Inbox" setting of the filter, specifically. But again, I thought I would ask (because Google will and I'll need to have an answer for them) what changes, if any, have been made recently on the mailman side of things. Thank you, Thomas

4 6

Wine Gecko repo
by Jacek Caban 13 Aug '13

13 Aug '13

Hi, A few months ago, SourceForge did some deep changes in their Git (and not only) repo hosting. While doing it, the location of repos has changed (which is extremely stupid, if you ask me). The problem is that while doing the update, they also switched to their own Web interface for git. And this shiny new interface doesn't work at all for Wine Gecko repo (wine-gecko.git probably too big and complicated). See [1], it claims to be analyzing the repo, but it has been like that since the switch was done. I contacted them [2] and they are aware of the problem, but it's still not fixed. I already got some questions about outdated sources. Also, our Wiki points to this Git in a few places. I never updated those links because I was waiting for the new repo to work. I think it's time to move the repo. The question is, where should it go? - Github seems to be the choice for most project currently and it's already used by Wine Mono. - Reconsider source.winehq.org. This was not chosen due to account management overhead, but that's the only way to avoid problems similar to recent Sourceforge one (Github nor anyone else is going to give us any guarantees) - Other ideas? I'd appreciate opinions. Thanks, Jacek [1] https://sourceforge.net/p/wine/wine-gecko/ci/master/tree/ [2] https://sourceforge.net/p/forge/site-support/4299/

3 2

Process for reporting security bugs?
by achurch+wine-devel＠achurch.org 13 Aug '13

13 Aug '13

[Please cc: me on any replies since I'm not subscribed to the list.] Hi, Is there a specific process for reporting security-related bugs in Wine? I've looked through winehq.org but haven't found any mention of such; I just wanted to make sure I haven't overlooked anything before posting the bug in a publicly visible manner. Thanks, --Andrew Church achurch+wine-devel(a)achurch.org http://achurch.org/

3 5

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events
by Hugh McMaster 13 Aug '13

13 Aug '13

On Monday, 12 August 2013, Ruslan Kabatsayev wrote: >I've tried applying your both patches, and it appears that Ctrl+C at >cmd prompt still closes cmd, although pressing it while "dir /s /w" is running works as expected. Hi Ruslan, I've just tested the Ctrl-C patches on the most recent version of Wine available from the Git repository. After patching, compiling and installing, I found no problems with either of the patches as you described. Ctrl-C did nothing when cmd.exe was open and no command was running. To be clear, I was running cmd.exe via wineconsole in Linux Mint 14: 1. wineconsole cmd.exe 2. Press Ctrl-C --> cmd.exe remains open. But if you run cmd.exe via wine itself, the terminal will terminate cmd.exe when Ctrl-C is pressed. 1. wine cmd.exe 2. Press Ctrl-C --> returned to terminal prompt. I hope this helps. If the patch still doesn't seem to work correctly, please let me know what operating system you use, and I'll run further tests. Hugh

2 2

Re: Compiler warnings on Debian Sid kfreebsd-i386
by Ken Sharp 12 Aug '13

12 Aug '13

On 12/08/13 20:15, Mislav Blazevic wrote: > It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. It does seem that way. :-) Or maybe :-(

1 0

Re: Compiler warnings on Debian Sid kfreebsd-i386
by Mislav Blazevic 12 Aug '13

12 Aug '13

It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. On Mon, Aug 12, 2013 at 9:15 PM, Mislav Blazevic <krofnica996(a)gmail.com>wrote: > It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. > > > > On Mon, Aug 12, 2013 at 9:11 PM, Ken Sharp <kennybobs(a)o2.co.uk> wrote: > >> Following my previous e-mail (http://www.winehq.org/** >> pipermail/wine-devel/2013-**August/100754.html<http://www.winehq.org/pipermail/wine-devel/2013-August/100754.html>) >> I have since moved from Wheezy to Sid to work around a Debian bug. >> >> libxml2 has been updated (2.8.0+dfsg1-7+nmu1 --> 2.9.1+dfsg1-3) as a >> result and introduced some new compiler warnings: >> >> /home/ken/wine-git/dlls/**msxml3/node.c: In function >> ‘htmldtd_dumpcontent’: >> /home/ken/wine-git/dlls/**msxml3/node.c:908:9: warning: passing argument >> 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled >> by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->ExternalID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c:912:13: warning: passing >> argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type >> [enabled by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->SystemID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c:918:9: warning: passing argument >> 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled >> by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->SystemID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c: In function >> ‘node_transform_node’: >> /home/ken/wine-git/dlls/**msxml3/node.c:974:21: warning: passing >> argument 1 of ‘xmlBufferContent’ from incompatible pointer type [enabled by >> default] >> content = xmlBufferContent(output->**buffer); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:734:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferContent (const xmlBufferPtr buf); >> ^ >> >> Hopefully these mean something to someone. >> >> >> >

1 0

Compiler warnings on Debian Sid kfreebsd-i386
by Ken Sharp 12 Aug '13

12 Aug '13

Following my previous e-mail (http://www.winehq.org/pipermail/wine-devel/2013-August/100754.html) I have since moved from Wheezy to Sid to work around a Debian bug. libxml2 has been updated (2.8.0+dfsg1-7+nmu1 --> 2.9.1+dfsg1-3) as a result and introduced some new compiler warnings: /home/ken/wine-git/dlls/msxml3/node.c: In function ‘htmldtd_dumpcontent’: /home/ken/wine-git/dlls/msxml3/node.c:908:9: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->ExternalID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c:912:13: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->SystemID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c:918:9: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->SystemID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c: In function ‘node_transform_node’: /home/ken/wine-git/dlls/msxml3/node.c:974:21: warning: passing argument 1 of ‘xmlBufferContent’ from incompatible pointer type [enabled by default] content = xmlBufferContent(output->buffer); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:734:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferContent (const xmlBufferPtr buf); ^ Hopefully these mean something to someone.

1 0

Question about implementing application compatibility
by Mislav Blazevic 12 Aug '13

12 Aug '13

For past two weeks I've been implementing apphelp.dll. I got that one working and moved onto kernel32 part of magic. According to various papers and blogs it seems that windows logs all exes and dlls ever executed in registry[1] and uses it as cache to lookup if binary needs to be shimmed or patched (if file isn't found, hard lookup of shim database is done) It is loaded on boot and saved back to registry on shutdown. This is awfully overcomplicated (plus I do not know how to make such a "global" variable in wine) so I was wondering is it OK to implement this differently than windows does it. It would be simpler to control app compat with environmental variable. It would mean that Base*Appcompat* kernel32 APIs would remain unimplemented but as far as I know, no application uses them anyway, other than windows internally. What do you think? [1] https://github.com/mandiant/ShimCacheParser

2 1

Re: ntdll/tests: test FileDispositionInformation file class
by Marvin 12 Aug '13

12 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26661 Your paranoid android. === WXPX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === WVISTAX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === W7PROX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === TEST64_W7SP1 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002)

1 0

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events
by Ruslan Kabatsayev 11 Aug '13

11 Aug '13

Hi, On Sun, Aug 11, 2013 at 12:33 PM, Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote: > Jason Edmeades and I have developed a patch that handles Ctrl-C and Ctrl-Break events in wineconsole's cmd.exe. > > The patch supports interactive mode, batch contexts and both the cmd /c and cmd /k modes, meaning that pressing Ctrl-C no longer closes cmd.exe. I've tried applying your both patches, and it appears that Ctrl+C at cmd prompt still closes cmd, although pressing it while "dir /s /w" is running works as expected. > > For loops, commands such as 'dir /s /w' and other such commands can be stopped. Batch scripts prompt the user whether the current batch execution should end. > > --- > programs/cmd/builtins.c | 95 ++++++++++++++++++++++++++++++++++++++++++----- > programs/cmd/cmd.rc | 2 + > programs/cmd/wcmd.h | 7 ++++ > programs/cmd/wcmdmain.c | 65 +++++++++++++++++++++++++++++++- > 4 files changed, 158 insertions(+), 11 deletions(-) > > > Regards, Ruslan

1 0

Compiler warnings on Debian kfreebsd-i386
by Ken Sharp 11 Aug '13

11 Aug '13

Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: ‘find_owning_pid’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/jscript/parser.y: conflicts: 1 shift/reduce, 18 reduce/reduce /home/ken/wine-git/dlls/msi/sql.y: conflicts: 1 reduce/reduce /home/ken/wine-git/dlls/ntdll/directory.c: In function ‘wine_getdirentries’: /home/ken/wine-git/dlls/ntdll/directory.c:1710:5: warning: passing argument 4 of ‘getdirentries’ from incompatible pointer type [enabled by default] In file included from /home/ken/wine-git/dlls/ntdll/directory.c:29:0: /usr/include/dirent.h:313:18: note: expected ‘__off_t * __restrict__’ but argument is of type ‘long int *’ /home/ken/wine-git/dlls/vbscript/parser.y: conflicts: 6 shift/reduce /home/ken/wine-git/programs/winedbg/dbg.y: conflicts: 1 shift/reduce, 1 reduce/reduce /home/ken/wine-git/programs/winedbg/dbg.y: conflicts: 1 shift/reduce, 1 reduce/reduce

2 5

Is it a little bug in wbemprox?
by Jing Li 10 Aug '13

10 Aug '13

Hi, When I ran a simple win32 program just via WMI with query of "SELECT * from Win32_Directory", wine1.6 crashed. And when I checked the related code I found that the function of "static UINT seed_dirs( struct dirstack *dirstack, const struct expr *cond, WCHAR root, UINT *count )", in dlls/wbemprox/builtin.c:1086, accessing cond's member without checking if it's NULL! Unfortunately a NULL is passed to it. That's why my program crashed. It's a bug, right?

2 1

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.
by André Hentschel 09 Aug '13

09 Aug '13

Am 08.08.2013 17:51, schrieb Kai Tietz: > Hi, > > this patch adds new --rt option to widl. By it you can control, if > RT's IDL-language-extension(?s) getting active. > This initial patch just adds the option-scanning and the global > flag-variable to widl. > > Ok for apply? I'd say no, you are adding dead code, so you might want to merge it with 2/11 to avoid that.

3 2

Re: [2/2] wineserver: perform access check when creating event objects (try 2)
by Andrew Cook 09 Aug '13

09 Aug '13

Actually ignore this patch, the problem was introduced by 92db6d2c back in 2007, server: Don't do access checks on the security descriptors of newly created objects which fixes sync.c:363 "CreateEventW with blank sd failed" i'll need to take another look at this, calling CreateEventEx with generic flags fails to correctly set permissions, the patch as it stands though will likely cause regressions. On 02/08/13 21:58, Andrew Cook wrote: > --- > dlls/ntdll/tests/om.c | 4 ++-- > server/event.c | 5 +---- > 2 files changed, 3 insertions(+), 6 deletions(-) > >

1 0

Re: configure.ac: allow disabling winemac.drv
by Ken Thomases 08 Aug '13

08 Aug '13

On Aug 8, 2013, at 5:56 PM, Austin English wrote: > +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build native Mac (Cocoa) driver]), > + [if test "x$withval" = "xno"; then ac_cv_header_ApplicationServices_ApplicationServices_h=no; fi]) A switch to disable the Mac driver is fine with me, but you can't pretend that the ApplicationServices framework header isn't present. There are other places within Wine which check that. http://source.winehq.org/source/dlls/windowscodecs/icnsformat.c#L24 http://source.winehq.org/source/dlls/winspool.drv/info.c#L48 -Ken

1 0

Re: [PATCH 04/11] widl: Handle default value for public vs hidden attribute.
by André Hentschel 08 Aug '13

08 Aug '13

Am 08.08.2013 17:57, schrieb Kai Tietz: > - if (! is_attr(attrs, ATTR_PUBLIC)) > + if (! is_attr(attrs, ATTR_PUBLIC) && ! is_attr (attrs, ATTR_HIDDEN)) style issue: space after !

2 1

Re: [PATCH 09/11] widl: Handle LLP64 target same as LP64 one.
by André Hentschel 08 Aug '13

08 Aug '13

Am 08.08.2013 18:07, schrieb Kai Tietz: > Hi, > > this thing here puzzles me most. I reject this patch, but would like > to get here some discussion to find the actual intended meaning of > this xstrtoul function. Then you should remove it from the patchset and send it as RFC to wine-devel

1 0

Re: Synchronization-patches of widl
by André Hentschel 08 Aug '13

08 Aug '13

Am 08.08.2013 10:56, schrieb Kai Tietz: > All these changes were necessary to support the VLC-people to begin > with their WinRT port. By this we began on mingw-w64 to improve - > thanks to Jacek - our IDL-generated header-sources. So you are on a good way with WinRT, nice. What about Windows RT, was there already some ARM work? > A general note I would like to make about the use of sizeof(void*) in > widl to make out what type-library-variant to be choosen. That seems > to be a bit wacky variant, as it makes widl non-useable as cross-tool > on host with different pointer-size. isn't that controled by command line arguments?

1 0

winetestbot question
by Stefan Leichter 08 Aug '13

08 Aug '13

Hello, i like to know why the WXPX64 VM of winetestbot does not have the 32 bit vc runtime 2008. The other 64 bit VMs have the runtime installed. Because of the missing runtime each patch for the unit tests of the dlls msvcr90 and msvcp90 is marked as "Failed" at http://source.winehq.org/patches -- Stefan

2 1

re: msvcrt: strncpy doesn't compliant C standard (try 3)
by Dan Kegel 08 Aug '13

08 Aug '13

Minor problem: +static void test_strncpy(void) +{ + size_t len = 10; + char *ret; + char dst[len + 1]; Hmm. That last line is a VLA, and might not compile in all C compilers because it's not allowed in C89. http://stackoverflow.com/questions/448844/variable-sized-arrays-in-c Wine seems to want to build in c89 compilers: http://www.winehq.org/pipermail/wine-cvs/2011-April/076721.html Try using a #define with a more unique name for the length instead, or better yet, replace len=10 with len=sizeof(dst)-1 or something. Larger problem: ret = strncpy(dst, not_null_less, len); This is ill-defined. You're copying 10 bytes from a 5 byte buffer. Don't do that. Also, passing a not-null-terminated string in as a special test case doesn't seem interesting... just pass in the longer null-terminated string, and specify a shorter length. Fewer test strings needed, easier to read code. Please run 'make check', and test using http://testbot.winehq.org, before submitting patches.

2 1

Re: [PATCH 1/1] msvcrt: Set ?: environment variable in _(w)chdir functions.
by Marvin 08 Aug '13

08 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26639 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msvcrt: strncpy doesn't compliant C standard (try 3)
by Marvin 07 Aug '13

07 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26638 Your paranoid android. === W2KPROSP4 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WXPPROSP2 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WXPX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === W2K3R2SESP2 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WVISTAX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === W2K8SE (32 bit string) === string.c:2585: Test failed: dst != 012345 === W7PROX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === TEST64_W7SP1 (32 bit string) === string.c:2585: Test failed: dst != 012345

1 0

Re: msvcp90/tests: Add dynamically loaded functions for ARM
by Marvin 07 Aug '13

07 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26637 Your paranoid android. === WXPX64 (32 bit misc) === No test summary line found === WXPX64 (32 bit ios) === No test summary line found

1 0

Re: Request to add wow64 keyword to bugzilla
by Ken Sharp 07 Aug '13

07 Aug '13

+1 from me. On 07/08/13 15:03, Rosanne DiMesio wrote: > On Wed, 07 Aug 2013 14:23:53 +0100 > Ken Sharp <kennybobs(a)o2.co.uk> wrote: > > >> Would I be right in assuming you would like to see bugs in 32-bit >> applications that are only present in a wow64 WINEPREFIX? Are there many? > > Yes. As to how many there are, I've been able to find 7 by doing searches of summaries/comments for things like "wow64" and "64" and then reading the bugs to see if they fit, but since people have such wildly varying ways of phrasing things, I don't know if that's all of them. I have seen it often enough on the forum that I now routinely tell 64 bit users to try a 32 bit wineprefix and have added instructions on how to create one to the FAQ. That's why I'd like an easier way to track these bugs. I see. A lot of people say this over and over again. +1 from me for a wow64 keyword. They may even be fairly easy to solve (picking the right paths / registry entries). > > As to keyword usage, some of those bugs were tagged with the win64 keyword, some weren't. I know there is also a win32 keyword, and perhaps that is meant to be used for the kinds of bugs I am looking for, but if so, that is not at all clear from the keyword definition, and it is not how people are using the keywords. > There's no win32 keyword?

3 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel