- wine-devel - winehq.org

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.
by Nikolay Sivov 30 Jul '13

30 Jul '13

On 7/9/2013 16:50, Qian Hong wrote: > Fixed a crash in MS Office 2010 Chinese version. > Thanks Jiang Yike for the helps on testing :) > > --- > dlls/imm32/imm.c | 6 ++++++ > dlls/imm32/tests/imm32.c | 13 +++++++++++++ > 2 files changed, 19 insertions(+) > > > > > + if (IsBadReadPtr(internal, sizeof(HIMCC))) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + Do you really need this for Office 2010 or null check is enough? If it's passing 0 handle here that's what you should check imho. If HIMCC is really a handle and not a struct pointer like in wine, that's not how a handle validity check will look like.

2 4

Call for Windows tests
by Bruno Jesus 30 Jul '13

30 Jul '13

Hi, I'm looking for help to test WSAEnumProtocols, I need to collect more information about the values returned from different versions of windows, especially 7 and 8. If you can help please download the file below, unzip, run the .bat and send me back the result.txt file (sources included). http://influenza.blog.br/wsa.zip There is no need to answer to the list. Virustotal.com scan: http://bit.ly/1catW4a Thanks in advance, Bruno

1 0

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.
by Vincent Povirk 30 Jul '13

30 Jul '13

There's a TIFF_VERSION define that seems to have been renamed to TIFF_VERSION_CLASSIC in 4.0. It doesn't make sense to do the check at runtime, given we're only going to link to one of the versions.

3 7

Re: [1/2] msxml3: Implement IMXAttributes_removeAttributes()
by Jacek Caban 30 Jul '13

30 Jul '13

Hi Nikolay, On 07/30/13 12:42, Nikolay Sivov wrote: > + dst = &This->attr[index]; > + src = &This->attr[index+1]; > + > + memmove(dst, src, This->length-index-1); *sizeof(*dst) Cheers, Jacek

1 0

Re: [2/2] wininet: Handle NULL input string in str_to_buffer.
by Marvin 30 Jul '13

30 Jul '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26482 Your paranoid android. === WXPX64 (64 bit http) === http.c:4661: Test failed: 4832: expected status 100 got 10 http.c:4661: Test failed: 4876: expected status 100 got 40 http.c:4634: Test failed: ar->dwResult = 0, expected 1 http.c:4661: Test failed: 4885: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0

Re: [1/2] wininet: Ignore INTERNET_FLAG_NO_CACHE_WRITE only for GET requests.
by Marvin 30 Jul '13

30 Jul '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26481 Your paranoid android. === WXPX64 (32 bit http) === http.c:4588: Test failed: 4759: expected status 100 got 10 http.c:4588: Test failed: 4803: expected status 100 got 40 http.c:4561: Test failed: ar->dwResult = 0, expected 1 http.c:4588: Test failed: 4812: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA

1 0

Re: [2/2] iphlpapi: Add partial support for the module classes in GetExtendedTcpTable and GetExtendedUdpTable.
by Marvin 30 Jul '13

30 Jul '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26480 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === W7PROX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 77E03915 === WVISTAX64 (64 bit iphlpapi) === Timeout === W7PROX64 (64 bit iphlpapi) === No test summary line found

1 0

Re: [1/2] iphlpapi: Add support for the listener and connection classes in GetExtendedTcpTable.
by Marvin 30 Jul '13

30 Jul '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26479 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === WVISTAX64 (64 bit iphlpapi) === Timeout

1 0

Re: riched20: ITextDocument stubs for ITextServices (retry)
by Caibin Chen 30 Jul '13

30 Jul '13

Anybody reviewing this patch? It's almost all stubs, so although it's long, it shouldn't be hard to review 2013/7/15 Caibin Chen <tigersoldi(a)gmail.com>: > (Retry with real name in mail. The name in the patch is already my real name) > > This patch implements a standalone stub of ITextDocument. The stub is > currently used in txtsrv.c and will replace the stub in richole.c > > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/tests/txtsrv.c | 16 ++- > dlls/riched20/txtdoc.c | 282 +++++++++++++++++++++++++++++++++++++++++++ > dlls/riched20/txtdoc.h | 46 +++++++ > dlls/riched20/txtsrv.c | 6 + > 5 files changed, 350 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/txtdoc.c > create mode 100644 dlls/riched20/txtdoc.h

2 4

[PATCH 1/2] ntdll: Implement NtQuerySystemInformation class 0x37
by Chris Moeller 30 Jul '13

30 Jul '13

2 1

GetNumaHighestNodeNumber tests
by Chris Moeller 29 Jul '13

29 Jul '13

Here is a basic stand-alone test program, which I should probably learn how to implement into the standard testing array. On my test Windows 7 system with a single processor (4 cores), it outputs the following: Testing NtQuerySystemInformationSystemNumaHighestNodeNumber = 0x37, ...): ... with invalid size returned c0000004 ... with valid size returned 0, HighestNodeNumber = 0, ResultLength = 4 Testing GetNumaHighestNodeNumber: ... returned 1, HighestNodeNumber = 0

1 0

[PATCH 2/2] kernel32: Implement GetNumaHighestNodeNumber
by Chris Moeller 29 Jul '13

29 Jul '13

1 0

[PATCH 0/2] Implement basic GetNumaHighestNodeNumber
by Chris Moeller 29 Jul '13

29 Jul '13

This patch against HEAD does the following in two parts: Part 1) Implements NtQuerySystemInformation class 0x37, which I have given the name SystemNumaHighestNodeNumber, since that appears to be all it does. It currently is limited to simulating a single node system, and returns the correct error status if queried with too small a return buffer. Part 2) Implements GetNumaHighestNodeNumber based on the above interface, and behaves just like a Windows 7 32-bit kernel32.dll does in case of errors in that function.

1 0

kernel32: Correct log on / logon (noun / verb)
by Ken Sharp 29 Jul '13

29 Jul '13

Evening Winos, Attached is a patch to correct some winerr messages. Specifically change a noun to a verb, and update the .po files with it. Firstly, could you take a look and point out any obvious errors I may have made? I have marked some of the translations fuzzy because it's not clear if the original translator realised that this should have been the verb and not the noun. A quick look through the translations on Wikipedia suggests that most languages do use different terms for the noun and the verb. https://cs.wikipedia.org/wiki/Login https://de.wikipedia.org/wiki/Login_(Informationstechnik) https://es.wikipedia.org/wiki/Login and so on. Some of these listings seem to use completely different words to the current translation in Wine so I wouldn't dare make a guess. Secondly, what do people think about the use of "Can't" as opposed to "Cannot"? I have not made the change in the patch but I'm wondering if people think that this should be done. Can't is informal and as my old English teacher would say, "Can't is not a word!" It is, but being pedantic "cannot" is probably the better choice. I assume Windows uses "can't" seen as it listed in winerror.mc. Thanks all! Ken

2 1

Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Matteo Bruni 29 Jul '13

29 Jul '13

2013/7/30 Chris Moeller <kode54(a)gmail.com>: > > On Jul 29, 2013, at 11:22 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > >> 2013/7/29 Chris Moeller <kode54(a)gmail.com>: >>> without looking very deeply into the CRT source code. >> >> You're talking about MS source code, right? That makes you tainted for >> contributing to Wine at >> the very least for C runtime-related code :( >> If you haven't looked into any other source code, this patch might be >> okay (barring other issues, I haven't read the patch at all). At least >> http://wiki.winehq.org/DeveloperFaq#head-fed5011434f62ae1a88baebfb8193a37ea… >> seems to suggest so. > > I did not look at any CRT source code to determine how to implement the functionality of this patch. I only looked at CRT source code to determine why the CRT was crashing in the first place. The HighestNode function popping a warning in my wine logs should have been hint enough to discover that function was stubbed. > > I actually determined how these functions worked by testing their behavior against a working system, and also with the aid of another developer, who pointed out a handy Win32 function for retrieving a suitable value for the free memory check. That's probably fine, although as a general rule you should stay as far as possible from Microsoft's source code. Cheers, Matteo.

1 0

[1/1] kernel32: Implemented basic NUMA functions to replace the stubs
by Chris Moeller 29 Jul '13

29 Jul '13

Main changes from HEAD: 1) Implements GetNumaHighestNodeNumber which simulates a typical single node system. 2) Implements GetNumaNodeProcessorMask which returns the global processor affinity mask for node 0, otherwise returns an error. 3) Implements GetNumaAvailableMemoryNode which returns available physical memory for node 0, otherwise returns an error. This much of the behavior was observed based on a single processor (4 cores) Windows 7 system. These functions are utilized by the synchronization and threading primitives incorporated in the MSVC 2012 and newer C and C++ runtime libraries. concrt.h/Concurrency::critical_section, which is used by both std::mutex and std::thread, will throw an exception the moment the object is locked if GetNumaHighestNodeNumber fails, and there are at least a few examples of software which don't bother to catch this exception and thus crash, such as the alpha version of Cube World, and certain versions of the foo_wave_seekbar component for the foobar2000 audio player. The associated scheduling code appears to make use of GetNumaNodeProcessorMask as well to control how many threads are allowed to spin up at once, or so I guess without looking very deeply into the CRT source code.

3 2

Re: [PATCH] Ignore MotionNotify when XI2 is handling mouse motion
by Alexandre Julliard 29 Jul '13

29 Jul '13

Josef Schimke <sgtcapslock(a)lavabit.com> writes: > Hello, > > When XInput2 takes over the mouse, regular MotionNotify events continue to be > handled alongside it. This causes the cursor to erratically skip around when > the slower method (X11 input) tries to reposition the cursor while XInput2 is > already handling future events. We want to process MotionNotify to resync the cursor position, XInput events are not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

How to get involved in Windows Store API implement?
by 中川祥 29 Jul '13

29 Jul '13

I do not know much about the store apps development. What is Windows.winmd? Do I need disassemble it and create wine version ?If I need C++,I wouldn't do. Is there any planning to support them?

2 1

NtCreateFile fails
by Mislav Blazevic 29 Jul '13

29 Jul '13

First of all, pardon my ignorance, I am new to wine and winapi. I am trying to implement apphelp.dll and I ran into issues with NtCreateFile: It always returns 0xc0000103, STATUS_NOT_A_DIRECTORY, and I am not sure what that means. Here is code: /* This function is not in API, but written for internal use */ HANDLE WINAPI SdbOpenFile( LPCWSTR path, PATH_TYPE type ) { /* SNIP */ if (type == DOS_PATH) if (!RtlDosPathNameToNtPathName_U(path, &str, NULL, NULL)) return NULL; InitializeObjectAttributes(&attr, &str, OBJ_CASE_INSENSITIVE, NULL, NULL); status = NtCreateFile(&file, GENERIC_READ | SYNCHRONIZE | FILE_READ_ATTRIBUTES, &attr, &io, NULL, FILE_ATTRIBUTE_NORMAL, FILE_SHARE_READ, FILE_OPEN, FILE_DIRECTORY_FILE, NULL, 0); /* SNIP */ return file; } Function is called like this: WCHAR szFileName[1024] = {0}; ExpandEnvironmentStringsW(L"%SystemRoot%\\sample.sdb", szFileName, 1024); // for testing purposes SdbOpenFile(szFileName, DOS_PATH); Compiled with winegcc. I am sure that C:\windows\sample.sdb exists. What am I doing wrong?

3 2

Re: [PATCH 3/5] d3dx9: Add support for structs to ID3DXConstantTable.
by Matteo Bruni 28 Jul '13

28 Jul '13

2013/7/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/shader.c | 79 > ++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 77 insertions(+), 2 deletions(-) > So there was actually a logic (an insane one, but yeah...). Have you found any game actually using this? Annoying question: have you checked if it's the same with newer d3dx9 dlls (e.g. d3dx9_43)? It still looks to me like buggy behavior and it might be that MS fixed that in later d3dx9 versions. This is not blocking the patch of course.

2 1

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds.
by Vincent Povirk 27 Jul '13

27 Jul '13

I have no opinion on this sort of work-around (it should work afaict, and I haven't found any other places where we currently use toff_t), but did you file a bug with whatever distro has such broken headers?

3 3

Windows 7 64-bit?
by Ken Sharp 27 Jul '13

27 Jul '13

I have to ask: Do we really think that this user is running Wine 1.0.1 on Windows 7 64-bit? http://appdb.winehq.org/objectManager.php?sClass=version&iId=28587&iTesting…

3 4

Need help with debugging a directx9 game crashing
by Qian Hong 25 Jul '13

25 Jul '13

Hello, I was debugging on a popular game [1] [2] (9 GB), it crashes on start. +relay,+seh,+tid log show that there are some calls to wined3d.wined3d_mutex_lock / wined3d.wined3d_buffer_map / wined3d.wined3d_mutex_unlock before crashing, so I turn on +d3d9 trace to get a new log in details. To my surprise, the game doesn't crash anymore with +d3d9 trace! After a serials of bisect, I found d3d9_AddRef is the key function call related to the crashing. If I remove the TRACE statement in line 71, the game will crash with +d3d9 as well; if I upgrade the TRACE in 71 to FIXME, the game will not crash even without +d3d9. 66 static ULONG WINAPI d3d9_AddRef(IDirect3D9Ex *iface) 67 { 68 struct d3d9 *d3d9 = impl_from_IDirect3D9Ex(iface); 69 ULONG refcount = InterlockedIncrement(&d3d9->refcount); 70 71 TRACE("%p increasing refcount to %u.\n", iface, refcount); 72 73 return refcount; 74 } Further tests show that the simplest hack to avoid crashing is replacing line 71 to: FIXME("anything %x\n", 0xdeadbeef); I have no idea what the real fix is, any suggestion what is the next step to debug? Thanks in advance! Environment: Wine 1.6-rc5 Ubuntu 12.04.2 LTS gcc 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) The installer ship with native d3dx9_40.dll Backtrace on crash: Wine-dbg>c Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0x0649e6e9). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:0649e6e9 ESP:0033cc60 EBP:00000000 EFLAGS:00210206( R- -- I - -P- ) EAX:00000001 EBX:19b871e0 ECX:00000000 EDX:00000000 ESI:23f420b0 EDI:23f4f20c Stack dump: 0x0033cc60: 80004005 19c0e0c0 00000000 19b871e0 0x0033cc70: 00000000 23f420b0 23f4f1f0 19b871e0 0x0033cc80: 00000018 00000040 0000001c 00000000 0x0033cc90: 0a9101df 00000020 00000034 7bc34159 0x0033cca0: 00110064 ffffffff 0033ccd8 7bc34d2d 0x0033ccb0: 00000000 0000000c 00000010 00000001 Backtrace: =>0 0x0649e6e9 in kg3dengine (+0x16e6e9) (0x00000000) 0x0649e6e9: movl 0x0(%eax),%ecx [1] http://jx3.xoyo.com/download [2] http://jx3.client.cdn.kingsoft.com/JXOnline3-v3.0.4.4980/JXOnline3-v3.0.4.4… -- Regards, Qian Hong - http://www.winehq.org

4 11

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 3)
by Ken Thomases 25 Jul '13

25 Jul '13

On Jul 25, 2013, at 10:49 AM, Charles Davis wrote: > Try 3: Don't advertise WGL_EXT_swap_control if vsync is disabled. Looks good. Thanks, Ken

1 0

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)
by Ken Thomases 25 Jul '13

25 Jul '13

On Jul 24, 2013, at 9:34 PM, Charles Davis wrote: > Try 2: Don't duplicate a constant string; we might need to add more legacy > extensions. (Hopefully not. ;) Thanks for making that change. Looks good to me. Cheers, Ken

1 2

Re: [PATCH 1/6] scrrun: Store reference count inside IFileSystem3 object
by Nikolay Sivov 25 Jul '13

25 Jul '13

On 7/25/2013 16:35, Piotr Caban wrote: > --- > dlls/scrrun/filesystem.c | 163 > +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 123 insertions(+), 40 deletions(-) Why do you need this?

2 1

What to do when an application misuses an API ...
by Michael Casadevall 25 Jul '13

25 Jul '13

Hey all, I've been working on trying to get Sid Meier's Civilization V (Civ5) up to a point where it works relatively flawlessly on WINE. The largest issue is that installing the latest expansion pack has completely hosed the game under WINE unless some rather ugly workarounds have been taken. Specifically, the main issue is that Civ5 loads its data files in the order returned by Find{First,Next}File(), and breaks spectacularly if that order is disrupted. I documented my findings here: http://bugs.winehq.org/show_bug.cgi?id=34122 As I sat to look at a possible patch, I'm not sure what I can actually do. Its clearly stated on the MSDN page that the order returned is dependent on the underlying filesystem, and Googling suggests that while NTFS seems to always return in a roughly alphabetical order, FAT32 will return by creation date, and with network drives all bets are off. I was even able to reproduce similar bugs in Civ5 by launching it from a network drive (which I had already tested in advance to make sure it returned an odd file order). FindFirstFile essentially calls down to NtQueryDirectoryFile, which in turn either calls a system specific syscall or readdir to get a list of files in a directory. My first thought is to extend the underlying read_directory_* functions in ntdll/directory.c so that they return an alphabetized list (essentially taking the results from getdents/getdirentries/readdir, sort them, then returning in the sort order whichever entry is next in line). This would produce a behavior similar (but not identical) to what is seen when operating under an NTFS filesystem. This approach seems wrong to me, and is further compounded by the fact this is a bug in an application, and not in WINE specifically; Under the correct circumstances, Windows will return a "non-sorted" list of files and in those cases Civilization V breaks. The flipside is that in the most common case, it works correctly, and furthermore, given how easy it is to assume that Find*File does return a sorted list, I won't be surprised if this issue has cropped up elsewhere (figuring out the underlying cause was exceedingly annoying). Any insight in to what the most correct course of action would be most appreciated I'm perfectly willing to put the legwork in fixing this bug, but I want to make sure I'm fixing it in a way that will be accepted :-). Regards, Michael

3 3

Re: [PATCH] winemac.drv: Also return the number of pixel formats if the caller didn't supply a PIXELFORMATDESCRIPTOR.
by Ken Thomases 24 Jul '13

24 Jul '13

On Jul 23, 2013, at 10:26 PM, Charles Davis wrote: > This is akin to what glxdrv already does, and apparently what Windows > does. It allows the GLView sample from the OpenGL SuperBible to > correctly enumerate pixel formats with the Mac driver. > --- > dlls/winemac.drv/opengl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/winemac.drv/opengl.c b/dlls/winemac.drv/opengl.c > index 0922371..fb294d1 100644 > --- a/dlls/winemac.drv/opengl.c > +++ b/dlls/winemac.drv/opengl.c > @@ -3281,7 +3281,7 @@ int macdrv_wglDescribePixelFormat(HDC hdc, int fmt, UINT size, PIXELFORMATDESCRI > > TRACE("hdc %p fmt %d size %u descr %p\n", hdc, fmt, size, descr); > > - if (fmt <= 0 || fmt > ret) return ret; > + if (fmt <= 0 || fmt > ret || !descr) return ret; > if (size < sizeof(*descr)) return 0; > > pf = &pixel_formats[fmt - 1]; > -- > 1.7.5.4 Looks good to me. Thanks! -Ken

1 0

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string.
by Ken Thomases 24 Jul '13

24 Jul '13

Hi, On Jul 23, 2013, at 10:26 PM, Charles Davis wrote: > @@ -1226,8 +1227,10 @@ static BOOL init_gl_info(void) > gl_info.glVersion = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1); > strcpy(gl_info.glVersion, str); > str = (const char*)opengl_funcs.gl.p_glGetString(GL_EXTENSIONS); > - gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1); > + gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) + > + sizeof(" WGL_EXT_extensions_string WGL_EXT_swap_control")); > strcpy(gl_info.glExtensions, str); > + strcat(gl_info.glExtensions, " WGL_EXT_extensions_string WGL_EXT_swap_control"); As a minor nitpick, I would prefer to avoid that duplicated string literal. Otherwise, looks good to me. Cheers, Ken

1 0

Re: [PATCH 4/5] scrrun: Add IFileSystem3::GetTempName implementation
by Alexandre Julliard 24 Jul '13

24 Jul '13

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -174,6 +174,7 @@ BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls( hinst ); > scrrun_instance = hinst; > + srand(GetTickCount()); You don't want to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update English (US) resource
by Francois Gouget 24 Jul '13

24 Jul '13

On Mon, 22 Jul 2013, Ken Sharp wrote: > Logon/Log on as with the British/neutral patch. > > msgid "Can't logon with inter-domain trust account.\n" > -msgstr "Can't logon with inter-domain trust account.\n" > +msgstr "Can't log on with inter-domain trust account.\n" [...] I think these fixes should really be applied to the source winerror.mc file instead. If I remember correctly en_US.po is just a dummy translation where msgid and msgstr strings should be identical (there might (with maybe one or two exceptions for things like um -> µm). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

2 1

Re: [PATCH 1/3] msvcrt: Fix _mktemp implementation
by Marvin 24 Jul '13

24 Jul '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26413 Your paranoid android. === W2KPROSP4 (32 bit file) === file: unhandled exception c0000005 at 7801B5A7 === WXPPROSP2 (32 bit file) === file: unhandled exception c0000005 at 77C2F1C3 === W2K3R2SESP2 (32 bit file) === file: unhandled exception c0000005 at 77BC00A3 === WXPX64 (64 bit file) === Timeout

1 0

Re: [PATCH 1/3] d3dx9: Fix initialization of D3DXPC_OBJECTs.
by Rico Schüller 23 Jul '13

23 Jul '13

On 23.07.2013 11:46, Rico Schüller wrote: > --- > dlls/d3dx9_36/effect.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > > > > These may not apply correctly. Sorry for the noise. I'll resend a new version. Cheers Rico

1 0

Re: [docs] "sgml" is not a valid output format
by Francois Gouget 23 Jul '13

23 Jul '13

On Tue, 23 Jul 2013, Frédéric Delanoy wrote: [...] > -ALLFORMATS = html pdf sgml ps txt > +ALLFORMATS = html pdf ps txt 'make sgml' can be used to generate the translated SGML source files for our many documentation translations. So I don't think this patch should be applied. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.

1 0

Re: [docs] "sgml" is not a valid output format
by Frédéric Delanoy 23 Jul '13

23 Jul '13

On Tue, Jul 23, 2013 at 5:26 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > Make.rules.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Make.rules.in b/Make.rules.in > index fda8e81..d326247 100644 > --- a/Make.rules.in > +++ b/Make.rules.in > @@ -100,7 +100,7 @@ dummy: > > # Manual Dependencies > > -ALLFORMATS = html pdf sgml ps txt > +ALLFORMATS = html pdf ps txt Please discard this patch ; it seems to be used in the translated guides to generate sgml from english version+po file

1 0

Re: [1/5] oledb32: Stub for IRowPosition
by Marvin 23 Jul '13

23 Jul '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26406 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 1/2] wined3d: Implement special fog behavior for orthogonal projection matrices.
by Henri Verbeet 23 Jul '13

23 Jul '13

On 22 July 2013 20:24, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -3614,10 +3614,19 @@ void wined3d_ffp_get_vs_settings(const struct wined3d_state *state, const struct > & WINED3D_FFP_LIGHT_TYPE_MASK) << WINED3D_FFP_LIGHT_TYPE_SHIFT(i); > } > > + settings->ortho_fog = 0; > if (!state->render_states[WINED3D_RS_FOGENABLE]) > settings->fog_mode = WINED3D_FFP_VS_FOG_OFF; > else if (state->render_states[WINED3D_RS_FOGTABLEMODE] != WINED3D_FOG_NONE) > + { > settings->fog_mode = WINED3D_FFP_VS_FOG_DEPTH; > + > + if (state->transforms[WINED3D_TS_PROJECTION].u.m[0][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[1][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[2][3] == 0.0f > + && state->transforms[WINED3D_TS_PROJECTION].u.m[3][3] == 1.0f) > + settings->ortho_fog = 1; > + } I'm going to guess "No, because the projection matrix is ignored.", but does this "feature" apply to transformed vertices as well?

1 0

Re: [PATCH 2/2] include/ddk: add usbioctl.h
by Nikolay Sivov 22 Jul '13

22 Jul '13

On 7/22/2013 22:38, Damjan Jovanovic wrote: > Changelog: > * add usbioctl.h > > Damjan Jovanovic Hi, Damjan. You forgot patches.

3 2

Re: appwiz: Correct Wine Mono installer messages
by Alexandre Julliard 22 Jul '13

22 Jul '13

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Where the correction is obvious I have done so, but where a full > translation is needed I have simply removed the incorrect one. This > will mark that line as untranslated and hopefully someone will see > that. It will also default to English with the correct message until > translated. That's what fuzzy is for, there's no reason to remove them. -- Alexandre Julliard julliard(a)winehq.org

3 3

Wine 1.6 list of deferred patches
by Bruno Jesus 22 Jul '13

22 Jul '13

This is the list of (hopefully) all deferred patches for wine 1.6, all authors are in bcc. I hope it's useful for developers. 97187 Deferred Dmitry Timoshkov [3/3] kernel32: GetShortPathName for a non-existent short file name should fail. 97131 Deferred Rosen Diankov [ole32] Bugfix for implicit MTA apartment initialization 97130 Deferred Rosen Diankov [oleaut32] Bugfix patches for marshaling VT_UNKNOWN in SAFEARRAYS 97124 Deferred Maarten Lankhorst [RFC PATCH] loader: allow overriding pthread_create correctly on linux 97119 Deferred Fabian Ebner [PATCH] dinput: Check the message queue in GetDeviceState * 97085 Deferred Dmitry Timoshkov ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file. 96974 Deferred Stefan Dösinger [PATCH 2/2] wined3d: Avoid calculating 1 / (fog_end - fog_start) in the shader 96961 Deferred Mathis Beer ntdll: make msync() call asynchronous in NtFlushVirtualMemory (try 3.5, alternate version) 96925 Deferred Hans Leidekker server: The token user SID must be present in the default DACL. 96899 Deferred Stefan Dösinger [PATCH 1/5] wined3d: Consolidate d3d_info BOOLs into a flags field 96855 Deferred Alistair Leslie-Hughes oledb32: Add IErrorInfo Support OK 96854 Deferred Alistair Leslie-Hughes msdaps: Add support for ISourcesRowset (try 2) 96831 Deferred Christian Costa [PATCH] d3dxof: Remove LP stuff and rename variables for IDirectXFile methods. 96819 Deferred Nikolay Sivov comctl32: Properly handle repainting for HDF_OWNERDRAW items 96797 Deferred André Hentschel ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32 (try 2) 96793 Deferred Christian Costa [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests. 96791 Deferred morphiend msvcrt: add support for _chsize_s 96765 Deferred Christian Costa [PATCH 2/4] d3dxof: Handle float in binary mode and remove code that becomes useless. * this patch was already commited.

1 0

Re: [PATCH 3/4] d3dx9: Improve ID3DXConstantTable::Set*().
by Alexandre Julliard 22 Jul '13

22 Jul '13

Rico Schüller <kgbricola(a)web.de> writes: > +static UINT set(struct ID3DXConstantTableImpl *table, IDirect3DDevice9 *device, struct ctab_constant *constant, > + const void **indata, D3DXPARAMETER_TYPE intype, UINT *size, UINT incol, D3DXPARAMETER_CLASS inclass, UINT index, > + BOOL is_pointer) > +{ > + DWORD (*get_index)(const void **indata, UINT index) = NULL; > + D3DXCONSTANT_DESC *desc = &constant->desc; > + UINT l, i, regcount = 1, regsize = 1, cin = 1, rin = 1, ret, last = 0; > + DWORD tmp; > + > + if (is_pointer) get_index = &get_index_pointer; > + else get_index = &get_index_array; It would be cleaner and easier to follow to have a simple helper with a is_pointer flag, rather than using function pointers with such trivial functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 2)
by Nikolay Sivov 21 Jul '13

21 Jul '13

On 7/20/2013 23:37, John Chadwick wrote: > This patch changes the create_selection interface to accept a wide string > instead of an xmlChar string. This is a transitional change, which will be > needed as libxml2's XPath parser is phased out. > > The last submission had a memory leak (sorry, I isolated this change > from some other changes and accidentally axed a heap_free in the > process.) Looks ok, I didn't try tests, but I hope you did.. One thing though: > +static inline WCHAR *heap_strcatW(WCHAR *a, const WCHAR *b) > +{ > + int len = strlenW(a) + strlenW(b); > + WCHAR *c = heap_realloc(a, (len + 1) * sizeof(WCHAR)); > + WCHAR *ptr = c; > + > + while(*ptr) > + ptr++; > + while(*b) > + *(ptr++) = *(b++); > + c[len] = 0; > + > + return c; > +} > + I'm assuming you didn't use strcatW() to avoid one more strlenW()? Even if you don't want to use it for some reason, you don't need first loop cause you already know 'a' length, and second loop is just strcpyW(). Also I suggest to use 'dst', 'src' names for parameters.

1 0

Coverity Status
by Marcus Meissner 20 Jul '13

20 Jul '13

Hi, For Wine 1.6 we have the following Coverity stats: - 3,648,322 Lines of Code scanned - Defect Density 0.51 - 8321 total defects - 1852 outstanding (unresolved) defects - 1964 dismissed defects - 4505 fixed defects git shortlog wine-1.4..wine-1.6|grep -i Coverity|wc -l 225 Thanks to AmineKhaldi uploading the builds and everyone reviewing and fixing coverity issues :) Ciao, Marcus

1 0

Another major milestone
by Jeremy White 19 Jul '13

19 Jul '13

Alright folks, I have to confess that the 1.6 release came and I didn't immediately get up and dance. In fact, a new Wine release was almost...boring. I think we have to consider that a major milestone in of itself. New, useful releases are just a matter of course for us now. Woohoo! Now I'm dancing <grin>. Cheers, Jeremy

8 9

Re: [docs] winelib: Use proper entity escaping for '&','<' and '>'
by Julian Rüger 19 Jul '13

19 Jul '13

Hi Frédéric, > - $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $< | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ > + $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $lt; | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ looks like you forgot the "&". Best, Julian

2 1

Re: [2/2] gdiplus: Store graphics clipping region in device coordinates.
by Vincent Povirk 19 Jul '13

19 Jul '13

I'm curious what happens if the world transform has some rotation. It seems like transform_rectf would break in that case.

2 2

Re: [1/2] windowscodecs: Add a test for global GIF palette exposed by recent Windows versions.
by Vincent Povirk 19 Jul '13

19 Jul '13

The series looks good to me.

1 0

Re: [1/4] wincodecs: Added IWICBitmapClipper stub
by Vincent Povirk 19 Jul '13

19 Jul '13

This series looks good to me.

1 0

Re: riched20: Add tests for ITextRange interface.
by Nikolay Sivov 19 Jul '13

19 Jul '13

On 7/18/2013 20:28, Caibin Chen wrote: > Add tests for start and end point, setting and getting text. > --- > dlls/riched20/tests/Makefile.in | 3 +- > dlls/riched20/tests/txtrng.c | 343 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 345 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/tests/txtrng.c You could just use existing file, richole.c fits I think.

2 7

Re: Patches I maintain
by Rico Schüller 18 Jul '13

18 Jul '13

Hi Roland, I'm not exactly sure what your goal is... but there is a rule one patch per mail only! There is likely no chance to get something like that mixture committed. You may have a look here: http://wiki.winehq.org/SubmittingPatches On 18.07.2013 01:23, Roland Haeder wrote: > +HRESULT D3DXCreatePolygon(LPDIRECT3DDEVICE9 device, float length, UINT sides, LPD3DXMESH *mesh, LPD3DXBUFFER adjacency) Well this looks a little bit wrong. You may have a look here http://msdn.microsoft.com/en-us/library/windows/desktop/bb172785%28v=vs.85%… . Don't copy and paste it. A patch which by accident works, is not something which should be applied at all. There are several issues alone in that line. Cheers Rico

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel