- wine-devel - winehq.org

Patch 96895
by Fabian Ebner 02 Jul '13

02 Jul '13

Is something wrong with this patch? It's just a translation update and Matteo Bruni said it looks good to him: http://www.winehq.org/pipermail/wine-devel/2013-June/100264.html ~Fabian

1 0

Re: Fix to support input of characters with diacritic symbols using AltGr
by Ken Thomases 01 Jul '13

01 Jul '13

On Jul 1, 2013, at 3:29 PM, Юрий Воротилов wrote: > Fix to support input of characters with diacritic symbols using AltGr (e.g. Latvian - AltGr+a=ā). > Tested on Ubuntu 12.04 and Centos 6. > I also have a bug opened in Crossover tracker: > http://www.codeweavers.com/support/tickets/browse/?ticket_id=935141 > > --- > dlls/winex11.drv/keyboard.c | 45 +++++++++++++++++++++++++------------------ > include/winuser.h | 1 + > server/queue.c | 5 ++++- > 3 files changed, 31 insertions(+), 20 deletions(-) > <0001-Support-input-of-characters-with-diacritic-symbols-usi.txt> I don't believe this is the correct approach. You don't want to be modifying the server and you can't arbitrarily add a new KEYEVENTF_* value. You can't assume that applications won't leave junk in the non-standard bits of the flags when they call SendInput() or keybd_event(). This needs to be implemented entirely within the X11 driver. It needs to properly translate your X11 keyboard layout into Win32 behavior. If the problem is that AltGr is mapping to VK_MENU, and thus causing key events to generate WM_SYSKEYDOWN/UP and not go through translation, then you need to make AltGr not map to VK_MENU. Although you really need to test that on Windows. My understanding is that AltGr appears to Windows apps as Alt+Control. In any case, I know that, on Mac OS X, the Option key is used similarly to AltGr. It accesses additional characters from the keyboard layout. This works when Option is configured in the X keymap to generate XK_Mode_switch. It requires no changes to Wine. So perhaps the right approach is to make XK_ISO_Level3_Shift and XK_ISO_Group_Shift behave the same way as XK_Mode_switch. (You could also just change your X keymap to actually map the key to XK_Mode_switch.) -Ken

1 1

[PATCH v7 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 01 Jul '13

01 Jul '13

Main changes from v6: 1) Fix LOCK_DELETE mandatory lock detection for O_DENYDELETE opens. 2) Add ESHAREDENIED error code definition for alpha, mips, parisc and sparc arches. 3) Remove code changes in do_last function if sharelocks are disabled. Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is replaced by 'sharelock' (function names, code comments, patch descriptions). Main changes from v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanism, but that approach is non-atomic. This patchset builds new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. The patchset introduces 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag can't be implemented for NFS due to the protocol restrictions). The patchset avoids data races problem on newely created files: open with O_CREAT can return new -ESHAREDENIED error code for a successfully created file if this files was locked with a sharelock by another task. Also, it turns off flock/LOCK_MAND capability for mounts with 'sharelock' option. This lets us not mix one share reservation approach with another. The #1 and #2 patches add flags to fcntl and implements VFS part. The patches #3 and #4 are related to CIFS-specific changes, #5 and #6 describe NFS and NFSD parts, #7 turns off flock/LOCK_MAND for mounts with 'sharelock' option. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND --- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts arch/alpha/include/uapi/asm/errno.h | 2 + arch/mips/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/errno.h | 2 + arch/sparc/include/uapi/asm/errno.h | 2 + fs/cifs/cifsacl.c | 8 +- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 +++- fs/cifs/cifsproto.h | 8 +- fs/cifs/cifssmb.c | 50 ++++++----- fs/cifs/dir.c | 16 ++-- fs/cifs/file.c | 25 ++++-- fs/cifs/inode.c | 21 ++--- fs/cifs/link.c | 25 ++---- fs/cifs/netmisc.c | 2 +- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 ++-- fs/cifs/smb2file.c | 10 +-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 +-- fs/fcntl.c | 5 +- fs/locks.c | 160 ++++++++++++++++++++++++++++++++--- fs/namei.c | 56 +++++++++++- fs/nfs/dir.c | 4 + fs/nfs/internal.h | 3 +- fs/nfs/nfs4file.c | 4 + fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 +- fs/nfs/nfs4xdr.c | 21 ++++- fs/nfs/super.c | 6 +- fs/nfsd/nfs4state.c | 46 +++++++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 14 +++ include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 +++ include/uapi/linux/fs.h | 1 + 39 files changed, 464 insertions(+), 135 deletions(-) -- 1.8.1.5

1 7

Re: po: Update Czech translation - 2nd attempt
by Nikolay Sivov 01 Jul '13

01 Jul '13

On 6/28/2013 18:21, Pavel Borecki wrote: Hi, Pavel. Looks like you're using poedit or something with similar habit of touching lines location headers: --- > -#: appwiz.rc:66 appwiz.rc:42 cryptui.rc:343 msacm32.rc:37 winecfg.rc:191 > -#: winecfg.rc:228 wordpad.rc:245 > +#: appwiz.rc:66 > +#: appwiz.rc:42 > +#: cryptui.rc:343 > +#: msacm32.rc:37 > +#: winecfg.rc:191 > +#: winecfg.rc:228 > +#: wordpad.rc:245 > msgid "&Remove" > msgstr "Odeb&rat" --- This adds a lot of diff lines that you don't really want.

1 0

Re: [PATCH] advapi32: RegDeleteKey tests for merged view of HKCR
by wine.dev＠web.de 01 Jul '13

01 Jul '13

Hi George. > [PATCH] advapi32: RegDeleteKey tests for merged view of HKCR > http://newtestbot.winehq.org/JobDetails.pl?Key=1403 > --- > dlls/advapi32/tests/registry.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) I can't test atm, but it looks good while reading. Please add a [try 2] to the subject and send it to wine-patches. -- Detlef

1 0

Re: [RFC PATCH] loader: allow overriding pthread_create correctly on linux
by Austin English 01 Jul '13

01 Jul '13

On Fri, Jun 28, 2013 at 3:53 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > This should be enough to fix bug #30557 in the most thorough possible way. > Only tested on ubuntu precise 32-bits atm, but I believe it should work on 64-bits too. > > TODO: pthread_create_2_0 is not handled correctly right now, so it will fail on ancient glibc's < 2.2. > But because NPTL requires a slightly newer glibc than that I do not believe it will be a real issue. > > Comments welcome :-) > --- > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 01a8026..e9775c3 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -33,6 +33,7 @@ > #ifdef HAVE_SYS_SYSCALL_H > #include <sys/syscall.h> > #endif > +#include <errno.h> > > #define NONAMELESSUNION > #include "ntstatus.h" > @@ -58,6 +59,7 @@ struct startup_info > TEB *teb; > PRTL_THREAD_START_ROUTINE entry_point; > void *entry_arg; > + BOOL native_thread; > }; > > static PEB *peb; > @@ -186,6 +188,20 @@ done: > return status; > } > > +#ifdef __linux__ > +extern typeof(pthread_create) *__glob_pthread_create, *call_pthread_create; > +static typeof(pthread_create) __hook_pthread_create; > + > +static void thread_wrap_init(void) > +{ > + call_pthread_create = __hook_pthread_create; > +} > + > +#else > +#define __glob_pthread_create pthread_create > +#define thread_wrap_init() > +#endif > + > /*********************************************************************** > * thread_init > * > @@ -204,6 +220,7 @@ HANDLE thread_init(void) > struct ntdll_thread_data *thread_data; > static struct debug_info debug_info; /* debug info for initial thread */ > > + thread_wrap_init(); > virtual_init(); > > /* reserve space for shared user data */ > @@ -327,11 +344,7 @@ void terminate_thread( int status ) > pthread_exit( UIntToPtr(status) ); > } > > - > -/*********************************************************************** > - * exit_thread > - */ > -void exit_thread( int status ) > +static void exit_thread_common( int status ) > { > static void *prev_teb; > TEB *teb; > @@ -377,9 +390,60 @@ void exit_thread( int status ) > close( ntdll_get_thread_data()->wait_fd[1] ); > close( ntdll_get_thread_data()->reply_fd ); > close( ntdll_get_thread_data()->request_fd ); > +} > + > +void exit_thread( int status ) > +{ > + exit_thread_common(status); > pthread_exit( UIntToPtr(status) ); > } > > +#ifdef __linux__ > + > +struct unix_arg { > + void *(*start)(void *); > + void *arg; > +}; > + > +/* dummy used for comparison */ > +static DWORD native_unix_start; > + > +static void call_native_cleanup(void *arg) > +{ > + RtlFreeThreadActivationContextStack(); > + exit_thread_common(0); > +} > + > +static int > +__hook_pthread_create(pthread_t *thread, const pthread_attr_t *attr, > + void *(*start_routine) (void *), void *parm) > +{ > + NTSTATUS ret; > + struct unix_arg arg; > + arg.start = start_routine; > + arg.arg = parm; > + > + TRACE("Overriding thread creation!\n"); > + if (attr) > + FIXME("thread attributes ignored!\n"); > + > + ret = RtlCreateUserThread( NtCurrentProcess(), NULL, FALSE, NULL, 0, 0, (void*)&native_unix_start, &arg, NULL, (void*)thread ); > + if (ret != STATUS_SUCCESS) > + FIXME("ret: %08x\n", ret); > + switch (ret) { > + case STATUS_SUCCESS: > + return 0; > + case STATUS_NO_MEMORY: > + return ENOMEM; > + case STATUS_TOO_MANY_OPENED_FILES: > + return EMFILE; > + default: > + ERR("Unhandled ntstatus %08x\n", ret); > + return ENOMEM; > + } > +} > + > +#endif > > /*********************************************************************** > * start_thread > @@ -412,9 +476,18 @@ static void start_thread( struct startup_info *info ) > if (TRACE_ON(relay)) > DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", GetCurrentThreadId(), func, arg ); > > - call_thread_entry_point( (LPTHREAD_START_ROUTINE)func, arg ); > -} > +#ifdef __linux__ > + if (info->native_thread) { > + void *(*start)(void*) = (void*)func; > > + FIXME("Started native thread %08x\n", GetCurrentThreadId()); > + pthread_cleanup_push(call_native_cleanup, NULL); > + pthread_exit(start(arg)); > + pthread_cleanup_pop(1); > + } else > +#endif > + call_thread_entry_point( (LPTHREAD_START_ROUTINE)func, arg ); > +} > > /*********************************************************************** > * RtlCreateUserThread (NTDLL.@) > @@ -497,8 +570,18 @@ NTSTATUS WINAPI RtlCreateUserThread( HANDLE process, const SECURITY_DESCRIPTOR * > > info = (struct startup_info *)(teb + 1); > info->teb = teb; > - info->entry_point = start; > - info->entry_arg = param; > +#ifdef __linux__ > + info->native_thread = (void*)start == (void*)&native_unix_start; > + if (info->native_thread) { > + struct unix_arg *arg = param; > + info->entry_point = (void*)arg->start; > + info->entry_arg = arg->arg; > + } else > +#endif > + { > + info->entry_point = start; > + info->entry_arg = param; > + } > > thread_data = (struct ntdll_thread_data *)teb->SpareBytes1; > thread_data->request_fd = request_pipe[1]; > @@ -513,7 +596,7 @@ NTSTATUS WINAPI RtlCreateUserThread( HANDLE process, const SECURITY_DESCRIPTOR * > (char *)teb->Tib.StackBase - (char *)teb->DeallocationStack ); > pthread_attr_setscope( &attr, PTHREAD_SCOPE_SYSTEM ); /* force creating a kernel thread */ > interlocked_xchg_add( &nb_threads, 1 ); > - if (pthread_create( &pthread_id, &attr, (void * (*)(void *))start_thread, info )) > + if (__glob_pthread_create( &pthread_id, &attr, (void * (*)(void *))start_thread, info )) > { > interlocked_xchg_add( &nb_threads, -1 ); > pthread_attr_destroy( &attr ); > @@ -523,6 +606,11 @@ NTSTATUS WINAPI RtlCreateUserThread( HANDLE process, const SECURITY_DESCRIPTOR * > pthread_attr_destroy( &attr ); > pthread_sigmask( SIG_SETMASK, &sigset, NULL ); > > +#ifdef __linux__ > + if (native_thread && id) > + *(pthread_t*)id = pthread_id; > + else > +#endif > if (id) id->UniqueThread = ULongToHandle(tid); > if (handle_ptr) *handle_ptr = handle; > else NtClose( handle ); > diff --git a/dlls/winegstreamer/glibthread.c b/dlls/winegstreamer/glibthread.c > index 25eceb8..7417941 100644 > --- a/dlls/winegstreamer/glibthread.c > +++ b/dlls/winegstreamer/glibthread.c > @@ -43,6 +43,7 @@ > #include <stdlib.h> > #include <stdio.h> > > +#if 0 > #include "windef.h" > #include "winbase.h" > #include "winnls.h" > @@ -388,3 +389,15 @@ void g_thread_impl_init (void) > g_thread_self_tls = TlsAlloc (); > g_thread_init(&g_thread_functions_for_glib_use_default); > } > + > +#else > + > +void g_thread_impl_init (void) > +{ > + static gboolean beenhere = FALSE; > + > + if (!beenhere++) > + g_thread_init(NULL); > +} > + > +#endif > diff --git a/libs/wine/loader.c b/libs/wine/loader.c > index 094e5e1..69f4a38 100644 > --- a/libs/wine/loader.c > +++ b/libs/wine/loader.c > @@ -69,6 +69,11 @@ char **__wine_main_argv = NULL; > WCHAR **__wine_main_wargv = NULL; > char **__wine_main_environ = NULL; > > +#ifdef __linux__ > +#include <pthread.h> > +typeof(pthread_create) *call_pthread_create, *__glob_pthread_create; > +#endif > + > struct dll_path_context > { > unsigned int index; /* current index in the dll path list */ > diff --git a/libs/wine/wine.map b/libs/wine/wine.map > index 2159fac..694869a 100644 > --- a/libs/wine/wine.map > +++ b/libs/wine/wine.map > @@ -117,6 +117,8 @@ WINE_1.0 > wine_utf8_mbstowcs; > wine_utf8_wcstombs; > wine_wctype_table; > + __glob_pthread_create; > + call_pthread_create; > > local: *; > }; > diff --git a/loader/main.c b/loader/main.c > index ac67290..14b2428 100644 > --- a/loader/main.c > +++ b/loader/main.c > @@ -202,6 +202,27 @@ static int pre_exec(void) > > #endif > > +#ifdef __linux__ > + > +extern typeof(pthread_create) *call_pthread_create, *__glob_pthread_create; > + > +int pthread_create(pthread_t *thread, const pthread_attr_t *attr, > + void *(*start_routine) (void *), void *arg) > +{ > + return call_pthread_create(thread, attr, start_routine, arg); > +} > + > +static void init_thread_hook(void) { > + call_pthread_create = __glob_pthread_create = dlvsym(RTLD_NEXT, "pthread_create", "GLIBC_2.2"); > + if (!__glob_pthread_create) > + call_pthread_create = __glob_pthread_create = dlvsym(RTLD_NEXT, "pthread_create", "GLIBC_2.1"); > +} > + > +#else > + > +#define init_thread_hook() > + > +#endif > > /********************************************************************** > * main > @@ -211,6 +232,8 @@ int main( int argc, char *argv[] ) > char error[1024]; > int i; > > + init_thread_hook(); > + > if (!getenv( "WINELOADERNOEXEC" )) /* first time around */ > { > static char noexec[] = "WINELOADERNOEXEC=1"; Fails to compile here (as mentioned on bug 30557): gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -o thread.o thread.c thread.c: In function ‘RtlCreateUserThread’: thread.c:610:9: error: ‘native_thread’ undeclared (first use in this function) thread.c:610:9: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [thread.o] Error 1 make[1]: Leaving directory `/home/austin/wine-git/dlls/ntdll' make: *** [dlls/ntdll] Error 2 I tried Ruslan's fixed patch, which failed as well: gcc -m32 -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -fno-builtin -o main.o main.c gcc -m32 -o wine -Wl,--export-dynamic -Wl,--section-start,.interp=0x7bf00400 main.o -L../libs/wine -lwine ../libs/port/libwine_port.a -lpthread -Wl,--rpath,\$ORIGIN/../libs/wine /usr/bin/ld: main.o: undefined reference to symbol 'dlvsym@@GLIBC_2.1' /usr/bin/ld: note: 'dlvsym@@GLIBC_2.1' is defined in DSO /lib/libdl.so.2 so try adding it to the linker command line /lib/libdl.so.2: could not read symbols: Invalid operation collect2: error: ld returned 1 exit status make[1]: *** [wine] Error 1 make[1]: Leaving directory `/home/austin/wine-git/loader' make: *** [loader] Error 2 this is 32-bit wine on fedora 64 (against 1.6-rc4). -- -Austin

1 0

Re: winex11.drv: When skipping unknown attribute also skip it's value.
by Michael Stefaniuc 30 Jun '13

30 Jun '13

On 06/30/2013 11:29 PM, Ričardas Barkauskas wrote: > --- > dlls/winex11.drv/opengl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > 0001-winex11.drv-When-skipping-unknown-attribute-also-skip-.txt > > > diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c > index 0f937cb..c7f78c5 100644 > --- a/dlls/winex11.drv/opengl.c > +++ b/dlls/winex11.drv/opengl.c > @@ -921,7 +921,7 @@ static int ConvertAttribWGLtoGLX(const int* iWGLAttr, int* oGLXAttr, struct wgl_ > TRACE("pAttr[%d] = GLX_RGBA_UNSIGNED_FLOAT_TYPE_EXT: %x\n", cur, pop); > break ; > default: > - FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur]); > + FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur++]); Side effects in the debug output functions should be avoided. > break; > } > ++cur; > bye michael

1 0

Re: [patch]update po/ja.po for wine ver.1.6-rc4
by Akihiro Sagawa 30 Jun '13

30 Jun '13

Hi Akira, Thank you for your contribution. Regarding Japanese translation, please consider following things. Firstly, those untranslated terms cannot be fully translated into Japanese. This is the reason why I didn't translate 100% message. In po file, please keep untranslated if we don't need to translate the message. Secondly, I don't translate the message before nearly 100% sure about message context. We should learn the conetext and test how the message is shown in the application. In my opinion, untranslated English terms are easy to search web pages. This helps a user who don't familiar to technical words. If we translate to ill-defined message, a user cannot help himself/herself with search engines. Thirdly, these untranslated messages are not so important for average applications... Did you notice these untranslated messages on some applications? Anyway, I continue to commented on this. On Sun, 30 Jun 2013 22:03:21 +0900, Akira Nakagawa wrote: > #: crypt32.rc:83 > msgid "Serialized Signature Serial Number" > -msgstr "" > +msgstr "整序された署名の順番" This translated message doesn't mean "Serial Number". > #: crypt32.rc:84 > msgid "Principal Name" > -msgstr "" > +msgstr "主要名称" "主要名称" looks like Chinese term. Not used in Japan at all. How about プリンシパル名? > #: crypt32.rc:94 > msgid "Policy Mappings" > -msgstr "" > +msgstr "ポリシーの表示" Mappings doesn't mean 表示 (=display?). > #: crypt32.rc:96 > msgid "Cross-Certificate Distribution Points" > -msgstr "" > +msgstr "複数の署名の配布ポイント" Cross-Certificate doesn't mean 複数の署名 (=multiple signatures?). > #: crypt32.rc:98 > msgid "Application Policy Mappings" > -msgstr "" > +msgstr "アプリケーションのポリシーの表示" Mappings doesn't mean 表示. (ditto) Please avoid ～の～の～ form. > #: crypt32.rc:99 > msgid "Application Policy Constraints" > -msgstr "" > +msgstr "アプリケーションのポリシーの制約" ditto. > #: crypt32.rc:107 > msgid "PKCS 7 Signed" > -msgstr "" > +msgstr "署名付きのPKCS 7" PKCS #7 is Cryptographic Message Syntax Standard and updated in RFC 5652. RFC 5652 defines six content types: data, signed-data, enveloped-data, digested-data, encrypted-data, and authenticated-data. So, "PKCS 7 Signed" means the second data type. > #: crypt32.rc:108 > msgid "PKCS 7 Enveloped" > -msgstr "" > +msgstr "保護されたPKCS 7" ditto. PKCS 7 is not enveloped. The data is enveloped by PKCS 7. > #: crypt32.rc:109 > msgid "PKCS 7 Signed Enveloped" > -msgstr "" > +msgstr "保護された署名付きのPKCS 7" ditto. > #: crypt32.rc:110 > msgid "PKCS 7 Digested" > -msgstr "" > +msgstr "ダイジェストのPKCS 7" ditto. > #: crypt32.rc:111 > msgid "PKCS 7 Encrypted" > -msgstr "" > +msgstr "暗号化されたPKCS 7" ditto. > #: crypt32.rc:112 > msgid "Previous CA Certificate Hash" > -msgstr "" > +msgstr "以前のCA 署名のハッシュ" Certificate doesn't mean "署名" (signature). A space character is needed before "CA". > #: crypt32.rc:113 > msgid "Virtual Base CRL Number" > -msgstr "" > +msgstr "仮想CRLナンバー" This message doesn't contain "Base" term. A space character is needed both sides of "CRL". > #: crypt32.rc:114 > msgid "Next CRL Publish" > -msgstr "" > +msgstr "次のCRL 公開" A space character is needed before "CRL". > #: crypt32.rc:119 > msgid "Dummy Signer" > -msgstr "" > +msgstr "ダミーの署名" Signer is a person or an authority. Please don't confuse signer with sign. > #: crypt32.rc:122 > msgid "Enforce Certificate Chain Policy" > -msgstr "" > +msgstr "証明書チェーンのポリシーを適用" Enforce is more powerful word. > #: crypt32.rc:193 > msgid "End Entity" > -msgstr "" > +msgstr "終了値" In this case "End" might not mean closure. This might mean "End user"'s end. > #: cryptdlg.rc:29 > msgid "Policy Qualifier Info" > -msgstr "" > +msgstr "ポリシーの修飾子情報" This message doesn't need space between words. > #: cryptui.rc:298 > msgid "Personal Information Exchange/PKCS #12 (*.pfx; *.p12)" > -msgstr "" > +msgstr "個人情報交換ファイル/PKCS #12 (*.pfx; *.p12)" "個人情報交換ファイル" isn't commonly used term. Where is the source of this term? I searched this term with google, only 9 pages are found. But "Personal Information Exchange" is used over 47,000 pages --- of course, I limited to Japanese pages. Thus I ask you to keep this term untranslated. > #: cryptui.rc:405 > msgid "&DER-encoded X.509 (*.cer)" > -msgstr "&DER符号化された X.509 (*.cer)" > +msgstr "DER符号化された X.509(&D) (*.cer)" I think this style is redundant. > #: cryptui.rc:407 > msgid "Ba&se64-encoded X.509 (*.cer):" > -msgstr "Ba&se64符号化された X.509 (*.cer):" > +msgstr "Base64で符号化された X.509(&S) (*.cer):" ditto. > #: cryptui.rc:409 > msgid "&Cryptographic Message Syntax Standard/PKCS #7 Message (*.p7b)" > -msgstr "&Cryptographic Message Syntax Standard/PKCS #7 メッセージ (*.p7b)" > +msgstr "暗号メッセージ構文/PKCS #7 メッセージ(&C) (*.p7b)" "Standard" term is omitted. > #: cryptui.rc:413 > msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" > -msgstr "" > +msgstr "個人情報交換ファイル(&P)/PKCS #12 (*.pfx)" "個人情報交換ファイル" is not common usage. (ditto) (&P) position doesn't match previous message. > #: cryptui.rc:75 > msgid "Personal Information Exchange (*.pfx; *.p12)" > -msgstr "" > +msgstr "個人情報交換ファイル (*.pfx; *.p12)" ditto. > #: cryptui.rc:94 > msgid "Personal Information Exchange" > -msgstr "" > +msgstr "個人情報変換ファイル" Why not use 交換 for Exchange as in previous message? This message use 変換 for Exchange term. > #: cryptui.rc:158 > msgid "Personal Information Exchange (*.pfx)" > -msgstr "" > +msgstr "個人情報変換ファイル (*.pfx)" ditto. ------------------- Following shell directory names are not translated in Windows Vista Japanese edition. Wine follows Vista's notation. We discussed about this two years ago [1]. [1] http://www.winehq.org/pipermail/wine-devel/2011-January/088390.html So, you don't need translate into Japanese for now. > #: shell32.rc:201 > msgid "My Documents" > -msgstr "" > +msgstr "マイドキュメント" > > #: shell32.rc:202 > msgid "Favorites" > -msgstr "" > +msgstr "お気に入り" > > #: shell32.rc:203 > msgid "StartUp" > -msgstr "" > +msgstr "スタートアップ" > > #: shell32.rc:204 > msgid "Start Menu" > -msgstr "" > +msgstr "スタートメニュー" > > #: shell32.rc:205 > msgid "My Music" > -msgstr "" > +msgstr "マイミュージック" > > #: shell32.rc:206 > msgid "My Videos" > -msgstr "" > +msgstr "マイビデオ" > > #: shell32.rc:207 > msgctxt "directory" > msgid "Desktop" > -msgstr "" > +msgstr "デスクトップ" > > #: shell32.rc:208 > msgid "NetHood" > -msgstr "" > +msgstr "ネットワーク内" > > #: shell32.rc:209 > msgid "Templates" > -msgstr "" > +msgstr "テンプレート" > > #: shell32.rc:210 > msgid "PrintHood" > -msgstr "" > +msgstr "プリンタ内" > > #: shell32.rc:211 winhlp32.rc:45 > msgid "History" > -msgstr "" > +msgstr "ヒストリ" > > #: shell32.rc:212 > msgid "Program Files" > @@ -7959,7 +7962,7 @@ msgstr "Program Files" > > #: shell32.rc:214 > msgid "My Pictures" > -msgstr "" > +msgstr "マイピクチャ" > > #: shell32.rc:215 > msgid "Common Files" > @@ -7967,23 +7970,23 @@ msgstr "Common Files" > > #: shell32.rc:216 shell32.rc:147 shell32.rc:232 > msgid "Documents" > -msgstr "" > +msgstr "ドキュメント" > > #: shell32.rc:217 > msgid "Administrative Tools" > -msgstr "" > +msgstr "管理者用ツール" > > #: shell32.rc:218 > msgid "Music" > -msgstr "" > +msgstr "ミュージック" > > #: shell32.rc:219 > msgid "Pictures" > -msgstr "" > +msgstr "ピクチャ" > > #: shell32.rc:220 > msgid "Videos" > -msgstr "" > +msgstr "ビデオ" > > #: shell32.rc:213 > msgid "Program Files (x86)" > @@ -7991,19 +7994,19 @@ msgstr "Program Files (x86)" > > #: shell32.rc:221 > msgid "Contacts" > -msgstr "" > +msgstr "連絡先" > > #: shell32.rc:222 winefile.rc:110 > msgid "Links" > -msgstr "" > +msgstr "リンク" > > #: shell32.rc:223 > msgid "Slide Shows" > -msgstr "" > +msgstr "スライドショー" > > #: shell32.rc:224 > msgid "Playlists" > -msgstr "" > +msgstr "プレイリスト" > > #: shell32.rc:148 taskmgr.rc:326 > msgid "Status" > @@ -8019,35 +8022,35 @@ msgstr "機種名" > > #: shell32.rc:225 > msgid "Sample Music" > -msgstr "" > +msgstr "サンプルミュージック" > > #: shell32.rc:226 > msgid "Sample Pictures" > -msgstr "" > +msgstr "サンプルピクチャ" > > #: shell32.rc:227 > msgid "Sample Playlists" > -msgstr "" > +msgstr "サンプルプレイリスト" > > #: shell32.rc:228 > msgid "Sample Videos" > -msgstr "" > +msgstr "サンプルビデオ" > > #: shell32.rc:229 > msgid "Saved Games" > -msgstr "" > +msgstr "保存済みのゲーム" > > #: shell32.rc:230 > msgid "Searches" > -msgstr "" > +msgstr "検索" > > #: shell32.rc:231 > msgid "Users" > -msgstr "" > +msgstr "ユーザー" > > #: shell32.rc:233 > msgid "Downloads" > -msgstr "" > +msgstr "ダウンロード" > ------------------- > #: netstat.rc:28 > msgid "Proto" > -msgstr "" > +msgstr "合意" Proto means protocol, but there is no enough space to display it. > #: oleview.rc:138 > msgid "Registry" > -msgstr "" > +msgstr "レジストリ" Oleview has a small issue. When I try this translation before, it can't display well if this message is Japanese. So, please verify that these messages are shown properly in the application. > #: oleview.rc:139 > msgid "Implementation" > -msgstr "" > +msgstr "実装" ditto. > #: oleview.rc:140 > msgid "Activation" > -msgstr "" > +msgstr "発動" ditto. > #: winefile.rc:109 > msgid "Index/Inode" > -msgstr "" > +msgstr "索引・Iノード" Although easily guess it, Iノード is not widely used. iノード might be preferred but more common term is "inode". inode (as Japanese technical term) is used in Wikipedia[1], Linux Japanese Manual (debugfs [2]), WDIC[3]. [1] http://ja.wikipedia.org/wiki/Inode [2] http://linuxjm.sourceforge.jp/html/e2fsprogs/man8/debugfs.8.html [3] http://www.wdic.org/w/TECH/inode Contact me for any questions. Regards, Akihiro Sagawa

1 0

Re: [PATCH] advapi32: RegDeleteKey tests
by Dmitry Timoshkov 30 Jun '13

30 Jun '13

George Stephanos <gaf.stephanos(a)gmail.com> wrote: > + res = RegOpenKeyExA( hkey, "subkey1", 0, KEY_READ, &hkeysub1 ); > + ok(res != ERROR_SUCCESS, "test key found in user's classes: %d\n", res); ... > + res = RegOpenKeyExA( hklm, "subkey1", 0, KEY_READ, &hklmsub1 ); > + ok(res != ERROR_SUCCESS, "test key found in hklm: %d\n", res); Testing for res != ERROR_SUCCESS is not very useful, please check for a particular error code. Also please close successfully opened handles. -- Dmitry.

2 1

[website] Wine 1.6-rc4 freigegeben
by André Hentschel 30 Jun '13

30 Jun '13

--- news/de/2013062801.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 news/de/2013062801.xml

1 0

Re: msxml3/tests: add additional conformance tests that show incorrect xpath behavior in wine
by Nikolay Sivov 29 Jun '13

29 Jun '13

On 6/27/2013 11:46, John Chadwick wrote: > + /* msxml's selectNodes returns a document ordered nodelist, regardless of > + * whether or not the xpath nodelist was document ordered... */ > + ole_check(IXMLDOMNode_selectNodes(rootNode,_bstr_("ancestor-or-self::node()"), &list)); > + todo_expect_list_and_release(list, "D1 E2.D1"); Please use explicit check for return value, like ok(hr == S_OK, "...");, also you probably don't need another macro for list checking, isn't it enough to wrap expect_list_and_release() in todo_wine {} ?

1 0

Need help with a rsaenh bug
by Qian Hong 28 Jun '13

28 Jun '13

Hello, I was investigating Bug 33898 [1] hardly and get a partial result, I have a special test case demonstrate the behavior of Aliwangwang [2], however, I failed to expand the special case to a common test case. My attempting is shown in [3]. The hack in [3] works for Aliwangwang, but the test case in [3] doesn't fully pass on Windows as I expected [4]. I'm not sure if there is an APP bug rather than Wine bug here, is it valid to call multiple CryptDecrypt with only one CryptDeriveKey called? If true, is it correct to assume the second CryptDecrypt call should behavior identical as the first one? If there is a Wine bug here, what is the right way to write a common test case for it? Any hints on this bug is great appreciated! Thanks very much! [1] http://bugs.winehq.org/show_bug.cgi?id=33898 [2] http://bugs.winehq.org/attachment.cgi?id=44996 [3] http://bugs.winehq.org/attachment.cgi?id=44997&action=diff [4] https://testbot.winehq.org/JobDetails.pl?Key=26138 -- Regards, Qian Hong - http://www.winehq.org

3 9

Re: ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file.
by Alexandre Julliard 28 Jun '13

28 Jun '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 2770, hopefully it's still > acceptable during code freeze. Is there an application that's fixed by this? According to bug 2770, that app only crashes a little further on (which is of course an improvement, but not worth the risk during code freeze). -- Alexandre Julliard julliard(a)winehq.org

2 1

riched20: ITextDocument implementation
by Tiger Soldier 28 Jun '13

28 Jun '13

As bug 17042 [1] reported, the IUnknown object returned by CreateTextServices() does not support ITextDocument. I believe that's the root cause of some apps crash. richole.c has a very limited implementation of ITextDocument for IRichEditOle, which is totally unreusable. I'm trying to implement ITextDocument for both ITextServices and IRichEditOle. ME_Editor type provides most of the editor functionalities, and both of ITextServices and IRichEditOle use it. So I'm going to use it to implement ITextDocument. The proposal is: struct tagReTxtDoc { IUnknown *parentObj; ME_Editor *editor; } ReTxtDoc; ReTxtDoc *CreateReTxtDoc(IUnknown *parentObj, ME_Editor *editor); void DestroyReTxtDoc(ReTxtDoc); ReTxtDoc_addRef/QueryInterface/Release -> delegate to parentObj Other ITextDocument methods: use ME_Editor to implement. This is my first time to develop WINE. Any comments/suggestions? [1] http://bugs.winehq.org/show_bug.cgi?id=17042

3 2

Re: widl: Do not generate C structure for empty interfaces.
by André Hentschel 27 Jun '13

27 Jun '13

Hi, The whitespace changes are bad, please don't do that.

3 4

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin 27 Jun '13

27 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin 27 Jun '13

27 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.
by Henri Verbeet 26 Jun '13

26 Jun '13

On 23 June 2013 21:57, Christian Costa <titan.costa(a)gmail.com> wrote: > When D3DTA_CONSTANT is use in a texture stage, the generated shader uses variables that are not defined making thus the compilation to fail. > This patch declare these variables with the value from the related texture stage state D3D_TSS_CONSTANT. > This fixes the text display in Spin Tires demo. This patch has several issues. Even without those, it should probably be deferred anyway.

4 11

Re: server: Update German translation of manpage.
by Alexandre Julliard 26 Jun '13

26 Jun '13

Julian Rüger <jr98(a)gmx.net> writes: > I'm unsure about the second line. Is that supposed to be the "last > modified" date of the manpage, the wineserver or what? The English > version says October 2005. In general, it would be the last time there were changes to the program that required a manpage update. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: po: Update Ukrainian translation
by Nikolay Sivov 26 Jun '13

26 Jun '13

On 6/26/2013 13:10, Микола wrote: Hi, please resubmit this patch with your full name transliterated in English.

1 0

Re: wined3d: print the architecture when showing driver problems
by Henri Verbeet 26 Jun '13

26 Jun '13

On 23 June 2013 07:10, Austin English <austinenglish(a)gmail.com> wrote: > Please consider applying before the release of 1.6. It has no > functional changes, but would really help when diagnosing user > problems. > This is not really a wined3d patch. That said, while I agree that printing the architecture would be useful here, you can probably avoid the #ifdef by using something along the lines of sizeof(void *) == 8 ? "64-bit" : "32-bit", although ideally we'd probably get the actual architecture from somewhere like ntdll.

2 2

Re: widl: Do not generate empty Vtbl structure for empty interfaces.
by Alexandre Julliard 25 Jun '13

25 Jun '13

Thomas Faber <thfabba(a)gmx.de> writes: > An alternative solution would be not to generate a vtable structure at all, > and instead add a dummy member to the class directly. That would be in line > with what the defined(__cplusplus) && !defined(CINTERFACE) case results in, > but require a slightly larger change to widl. I'm not sure it makes sense to even define a C structure at all, since there's nothing you can do with it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Czech language for Wine
by Alexandre Julliard 25 Jun '13

25 Jun '13

Pavel VlÄek <paaajavlca(a)gmail.com> writes: > @@ -1415,19 +1400,19 @@ > > #: crypt32.rc:74 > msgid "Title" > -msgstr "Titul" > +msgstr "" > > #: crypt32.rc:75 > msgid "Given Name" > -msgstr "Jm©no" > +msgstr "" > > #: crypt32.rc:76 > msgid "Initials" > -msgstr "Inici¡ly" > +msgstr "" > > #: crypt32.rc:77 > msgid "Surname" > -msgstr "Pjmen" > +msgstr "" Why are you removing all these existing translations? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)
by Dmitry Timoshkov 25 Jun '13

25 Jun '13

Marcus Meissner <marcus(a)jet.franken.de> wrote: > --- a/dlls/ole32/ifs.c > +++ b/dlls/ole32/ifs.c > @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(LPMALLOC iface,LPVOID pv,DWORD cb) { > IMallocSpy_Release(Malloc32.pSpy); > Malloc32.SpyReleasePending = FALSE; > Malloc32.pSpy = NULL; > + /* cb == 0 case will release it some lines below. */ > + if (cb) LeaveCriticalSection(&IMalloc32_SpyCS); > } > > if (0==cb) { Why not unconditionally release the lock before the '0==cb' check? -- Dmitry.

2 3

Re: d3dx9: Implement adjacency in D3DXCreateSphere
by Rico Schüller 24 Jun '13

24 Jun '13

On 20.06.2013 21:25, Nozomi Kodama wrote: > + if (adjacency) > + { > + DWORD *buffer, size; > + ID3DXBuffer *temp; > + > + size = 3 * sphere->lpVtbl->GetNumFaces(sphere) * sizeof(DWORD); > + hr = D3DXCreateBuffer(size, &temp); > + if (hr != D3D_OK) > + return hr; > + > + buffer = (DWORD *)(ID3DXBuffer_GetBufferPointer(temp)); Are the outer parentheses needed? Is the cast needed? > + hr = sphere->lpVtbl->GenerateAdjacency(sphere, -0.000001f, buffer); > + if (hr != D3D_OK) > + return hr; This may leak the temp ID3DXBuffer in the error case. Cheers Rico

2 1

Re: msvcr90/tests: skip tests of function ?_name_internal_method if it is not present
by Marvin 24 Jun '13

24 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26093 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

Re: ws2_32: Fix interface-bound filter to accept locally generated targeted packets.
by Jonas Maebe 24 Jun '13

24 Jun '13

On 24 Jun 2013, at 04:30, Erich E. Hoover wrote: > <0001-ws2_32-Fix-interface-bound-filter-to-accept-locally-.patch> The added "struct sock_filter ip_memaddr" field doesn't seem to be used. Jonas

2 1

Re: ol32: Make enumx implementation look more like a COM interface.
by Dmitry Timoshkov 24 Jun '13

24 Jun '13

This patch should be quite obvious in its intent: it changes vtable type to IUnknown which helps to remove This* to IUnknown* casts in order to avoid obvious problems with vtable pointer placement inside of object implementation. Basically this is just a clean up patch. Is there anything else to clear the pending patch state? -- Dmitry.

2 5

Re: [PATCH]winhttp:session.c fix a bug(return value is null)
by Hans Leidekker 24 Jun '13

24 Jun '13

On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote: > diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c > index 660eae5..dfe23d4 100644 > --- a/dlls/winhttp/session.c > +++ b/dlls/winhttp/session.c > @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD flags, LPWSTR *url ) > { > static int fixme_shown; > if (!fixme_shown++) FIXME("discovery via DHCP not supported\n"); > + flags = WINHTTP_AUTO_DETECT_TYPE_DNS_A; > + ret=TRUE; > } > if (flags & WINHTTP_AUTO_DETECT_TYPE_DNS_A) > { We shouldn't perform DNS detection if the app didn't ask for it. Do you have an app that fails because we return an error here?

1 0

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime.
by Hans Leidekker 24 Jun '13

24 Jun '13

On Sun, 2013-06-23 at 18:55 +0200, Sylvain Petreolle wrote: > +static WCHAR *get_localdatetime(void) > +{ > + static const WCHAR fmtW[] = > + {'%','0','4','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u', > + '.','%','0','6','u','+','0','0','0',0}; > + SYSTEM_TIMEOFDAY_INFORMATION ti; > + TIME_FIELDS tf; > + WCHAR *ret; > + > + if (!(ret = heap_alloc( 26 * sizeof(WCHAR) ))) return NULL; > + > + NtQuerySystemInformation( SystemTimeOfDayInformation, &ti, sizeof(ti), NULL ); > + RtlTimeToTimeFields( &ti.liKeBootTime, &tf ); > + sprintfW( ret, fmtW, tf.Year, tf.Month, tf.Day, tf.Hour, tf.Minute, tf.Second, tf.Milliseconds * 1000 ); > + return ret; > +} This will not return local time.

1 0

Re: wbemprox: Implement some properties of Win32_BIOS. (resend 4)
by Hans Leidekker 24 Jun '13

24 Jun '13

On Sat, 2013-06-22 at 12:17 +0900, Kim Jung Eon (김중언) wrote: > static const struct column col_bios[] = > { > + { prop_biosversionW, CIM_STRING|CIM_FLAG_ARRAY}, > { prop_descriptionW, CIM_STRING }, > { prop_manufacturerW, CIM_STRING }, > { prop_releasedateW, CIM_DATETIME }, > @@ -508,6 +511,7 @@ struct record_baseboard > }; > struct record_bios > { > + const struct array *biosversion; > const WCHAR *description; > const WCHAR *manufacturer; > const WCHAR *releasedate; > @@ -695,9 +699,13 @@ static const struct record_baseboard data_baseboard[] = > { > { baseboard_manufacturerW, baseboard_serialnumberW, baseboard_tagW } > }; > +static const struct array data_bios_biosversion = > +{ > + 1, (void*)bios_versionW > +}; This can't work. BIOSVersion is of type CIM_STRING|CIM_FLAG_ARRAY, which translates to a pointer to an array of string pointers.

1 0

Re: po: Update Simplified Chinese translation (resend)
by Qian Hong 24 Jun '13

24 Jun '13

Hi Caibin, Welcome to Wine! Thanks for the great work, patch looks perfect to me. It's a bit pity that Julliard just finishing today's patch committing several minutes ago, hopefully this patch would be committed next week, if we have rc4 :) Cheers. On Sat, Jun 22, 2013 at 12:36 AM, Tiger Soldier <tigersoldi(a)gmail.com> wrote: > - Used real name in commit message > - Superseded patch 96985 > --- > po/zh_CN.po | 373 > +++++++++++++++++++++++++++++++----------------------------- > 1 file changed, 190 insertions(+), 183 deletions(-) > > > > -- Regards, Qian Hong - http://www.winehq.org

4 4

Patch 96965
by Christian Costa 23 Jun '13

23 Jun '13

Hi, This patch http://source.winehq.org/patches/data/96965 is in the pending state. Is there anything wrong or missing. Basically this patch only changes the test to check exactly the returned value to show the difference in behaviour between A and Version of the API. The rest is just to things to make this difference clearer.

1 0

(no subject)
by namit maheshwari 23 Jun '13

23 Jun '13

1 0

Accentuate names.
by Tae Wong 22 Jun '13

22 Jun '13

There are lots of Czech developers (Macek and Semerad) being unaccentuated plus Caolan and Znidarsic. They need to be accentuated.

1 0

talking about web-based translation again -- transifex
by qing xianhao 21 Jun '13

21 Jun '13

hi all, firstly, i didn't use launchpad so much, but i used transifex for a mouths help to translate several opensource projects including the transifex itself. i found it can answer these needs as commented following. Quoted from http://www.winehq.org/pipermail/wine-devel/2011-September/092047.html > Launchpad tracks who translated what string and if we choose the > 'Closed' permissions model only approved translators can update the > translations. So that means we should be able to get patches with > full attribution. transifex has coordinator and translator roles division. coordinator could review the translation[1]. > Launchpad would need to pull updated PO files from Wine regularly. > Ideally that would be automatic and happen daily (both to account > for translations happening outside Launchpad and to take changes in > the resource files into account quickly). transifex has option to pull form outside, and the frequency is about daily[2]. > Conversely Launchpad should submit patches back to Wine. Ideally that > would be automated as much as possible but I'm fuzzy on the details > here (especially on how to preserve attribution). As for the > periodicity, maybe the best would be weekly or just before Alexandre > makes a release. the transifex has command line client[3] to pull the translation changes. if a unix guy got the command line tool, what could he do. ;) Quoted from http://www.winehq.org/pipermail/wine-devel/2012-January/093908.html >trace every Wine commit to a specific person transifex itself is open source project that can be self-hosted[4]. xfce team is hosting their own with it, every the commit was tracked and can view the diff easyly. [4] community edition installation http://help.transifex.com/server/ [3] transifex client http://support.transifex.com/customer/portal/topics/440187-transifex-client… [2] How often are the stats auto-updated http://help.transifex.com/intro/faq.html#how-often-are-the-stats-auto-updat… [1] coordinator review http://help.transifex.com/intro/translating.html#proofreading-translations -- qingxianhao

2 1

Re: user32: Invalidate window after resizing for WM_SYSCOMMAND/SC_SIZE.
by Alexandre Julliard 21 Jun '13

21 Jun '13

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/user32/winpos.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) That's only hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wined3d: Avoid calculating 1 / (fog_end - fog_start) in the shader
by Henri Verbeet 21 Jun '13

21 Jun '13

On 21 June 2013 12:06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This also works for fog_start == fog_end on drivers that don't handle > this situation correctly with fixed function fog. Tested on nvidia, > r300g, r600g. What does this fix?

2 1

Re: [PATCH 2/2] msvcrt: Add some _mbstok tests
by Marvin 21 Jun '13

21 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26066 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

2 1

Re: [PATCH] winetest: Add support for wineconsole output
by Fabian Ebner 20 Jun '13

20 Jun '13

Am 20.06.2013 17:55, schrieb Bruno Jesus: > On Thu, Jun 20, 2013 at 12:42 PM, Fabian Ebner <f.ebner94(a)gmail.com> wrote: >> Allow winetest to output stuff inside a wineconsole. >> Fixes http://bugs.winehq.org/show_bug.cgi?id=28191 >> --- >> programs/winetest/gui.c | 6 +++--- >> programs/winetest/main.c | 2 +- >> programs/winetest/util.c | 25 +++++++++++++++++++++++++ >> programs/winetest/winetest.h | 1 + >> 4 files changed, 30 insertions(+), 4 deletions(-) >> + //No logfile means printing to stdout Ok, thanks > C++ comments are not allowed AFAIK. > >> + if (!logfile) { The surrounding code uses this style when it is an if or a while, when it's a function it uses new-line {. But there are only two other occurences of {}-braces, should I change them with my patch and use new-line all along? > You should use the coding style of the surrounding code, it looks like > the rest of the file uses the { in the next line, I may be wrong about > this. > > Best wishes, > Bruno

1 0

Re: ntdll: make msync() call asynchronous in NtFlushVirtualMemory (try 3)
by Alexandre Julliard 20 Jun '13

20 Jun '13

Mathis Beer <default_357-line(a)yahoo.de> writes: > As such, this patch changes msync to be called asynchronously. > > This is revision three of this patch. It leaves the original #define > MS_SYNC 0 in place and instead changes NtFlushVirtualMemory to use > MS_ASYNC only if mman.h was found earlier. (It also adds comments) That doesn't make sense, all interesting platforms have mman.h, that doesn't imply they have MS_ASYNC. It may well be that nowadays they all have MS_ASYNC too, so we could use it unconditionally and see if someone reports breakage. This will have to wait until after code freeze though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/4] ddraw: Device2 and Device3 do not have a lighting render state
by Henri Verbeet 20 Jun '13

20 Jun '13

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Light state */ > DWORD material; > + DWORD dummy_rs_lighting; > Considering the render state doesn't exist in early ddraw versions, do we really care that its value is preserved? It seems unlikely that anything except our tests would depend on it.

2 3

Re: [website] Added Portuguese translation for call for translators
by Frédéric Delanoy 20 Jun '13

20 Jun '13

2013/6/19 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013061601.xml | 9 +++++++++ > 1 file changed, 9 insertions(+) > create mode 100644 news/pt/2013061601.xml > > diff --git a/news/pt/2013061601.xml b/news/pt/2013061601.xml > new file mode 100644 > index 0000000..86bf5a8 > --- /dev/null > +++ b/news/pt/2013061601.xml > @@ -0,0 +1,9 @@ > +<news> > +<date>16 de Junho de 2013</date> > +<title>Procura-se tradutores!</title> > +<body> Just wondering: does it make sense to translate a call for translators? I mean, if a volunteer can't understand the English from the call, (s)he wouldn't be able to translate correctly anyway. Frédéric

3 2

Re: [PATCH 2/4] ddraw: Send device2_Draw* through device3_Draw*
by Henri Verbeet 20 Jun '13

20 Jun '13

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - return IDirect3DDevice7_DrawPrimitive(&device->IDirect3DDevice7_iface, device->primitive_type, > + return IDirect3DDevice3_DrawPrimitive(&device->IDirect3DDevice3_iface, device->primitive_type, > device->vertex_type, device->sysmem_vertex_buffer, device->nb_vertices, device->render_flags); This is not introduced by your patch of course, but I don't think there's much of a point in going through the vtbl here.

2 1

Re: [PATCH 1/4] ddraw: SPECULARENABLE defaults to true in IDirect3DDevice2
by Henri Verbeet 20 Jun '13

20 Jun '13

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -4250,7 +4250,12 @@ static HRESULT WINAPI d3d2_CreateDevice(IDirect3D2 *iface, REFCLSID riid, > wined3d_mutex_lock(); > hr = d3d_device_create(ddraw, surface_impl, 2, &device_impl, NULL); > if (SUCCEEDED(hr)) > + { > *device = &device_impl->IDirect3DDevice2_iface; > + hr = IDirect3DDevice2_SetRenderState(*device, D3DRENDERSTATE_SPECULARENABLE, TRUE); > + if (FAILED(hr)) > + ERR("SetRenderState failed\n"); > + } Why not do this together with the other render state setup in d3d_device_init()?

1 0

Re: [PATCH 2/3] d3d9/tests: Reset texture 0 to NULL at the end of texop_test().
by Henri Verbeet 20 Jun '13

20 Jun '13

On 19 June 2013 21:59, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > While it doesn't really matter for the test results (it only affects the > alpha component of the following test but that isn't checked anyway) I feel > it's a good idea to properly cleanup and avoid dependencies between > tests. Yeah, though ideally we'd do that by using create_device() from individual tests instead of reusing a single device.

1 0

Re: [Wine] German translation - netstat.exe
by Joerg Schiermeier 19 Jun '13

19 Jun '13

On Tuesday, 18 Jun 2013 at 19:35:02 André Hentschel wrote: > when you scroll down a bit on that page, you see everything needed to get rid of false positives. Ah, I didn't scrolled down sooo deep. :( > Oh and fgouget is Fran?ois Gouget Thanks for this hint. I will deal with it in the right manner. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: gdi32: Get the default character index, not its value.
by Alexandre Julliard 19 Jun '13

19 Jun '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/gdi32/freetype.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:1356: Test failed: GetGlyphIndicesW should have returned a 0080 not 0000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update Italian translation (try 3)
by Matteo Bruni 19 Jun '13

19 Jun '13

2013/6/17 Fabian Ebner <f.ebner94(a)gmail.com>: > Typo fixed (finally) > --- > po/it.po | 40 ++++++++++++++-------------------------- > 1 file changed, 14 insertions(+), 26 deletions(-) > This one looks good to me, thanks :)

1 0

Re: mlang.dll implementation fix
by Christian Costa 19 Jun '13

19 Jun '13

Hi and welcome, Patches should be sent included in the mail. Adding tests is recommended. You can follow status at http://source.winehq.org/patches/. But currently we're in code freeze so you may have to wait Wine 1.6. Christian 2013/6/19 Bartosz <gang65(a)poczta.onet.pl> > My name is Bartosz and I would like to start hacking wine. > At beginning I implemented BreakLine methods (available in mlang.dll): > http://msdn.microsoft.com/en-us/library/aa741037%28v=vs.85%29.aspx > > I prepared patch which is available at: > http://bugs.winehq.org/attachment.cgi?id=44854&action=diff > http://bugs.winehq.org/show_bug.cgi?id=32126 > > Could you please take a look at these methods and push it into git repo? > > Should I write tests for that? > > Thanks in advance > Bartosz > > >

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel