- wine-devel - winehq.org

Re: [PATCH 4/5] d3drm: Avoid LPDIRECT3DRMTEXTURE.
by Christian Costa 27 May '13

27 May '13

Le 27/05/2013 09:22, Henri Verbeet a écrit : > --- > dlls/d3drm/d3drm.c | 20 ++++++++------------ > dlls/d3drm/frame.c | 22 +++++++--------------- > dlls/d3drm/meshbuilder.c | 14 +++++++------- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > include/d3drm.h | 4 ++-- > include/d3drmobj.h | 26 +++++++++++++------------- > 6 files changed, 45 insertions(+), 57 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index 8dfa4bb..fe728a8 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -317,24 +317,20 @@ static HRESULT WINAPI IDirect3DRMImpl_CreateUserVisual(IDirect3DRM* iface, D3DRM > return E_NOTIMPL; > } > > -static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM* iface, const char* filename, > - LPDIRECT3DRMTEXTURE* Texture) > +static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM *iface, > + const char *filename, IDirect3DRMTexture **texture) > { > - IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); > - > - FIXME("(%p/%p)->(%s,%p): stub\n", iface, This, filename, Texture); > + FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > > Do you really need to change the way traces are displayed?

2 6

Re: jscript: Added RegExp.toString() implementation.
by Marvin 27 May '13

27 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25722 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: riched20: Added tests for ITextDocument::Open
by Alexandre Julliard 27 May '13

27 May '13

Jactry Zeng <jactry92(a)gmail.com> writes: > diff --git a/dlls/riched20/tests/test.txt b/dlls/riched20/tests/test.txt > new file mode 100644 > index 0000000..e69de29 If you need an external file you have to create a temp file in the test. You can't rely on running from inside the source tree. -- Alexandre Julliard julliard(a)winehq.org

2 1

Spam again ...
by Joerg Schiermeier 27 May '13

27 May '13

Hi maintainer, ---<cite>--- Message: 1 Date: Sun, 26 May 2013 01:07:06 +0000 (UTC) From: xerox_xerox2000(a)yahoo.co.uk To: <wine-devel(a)winehq.org>, <vidar268(a)yahoo.com>, <vladdy(a)utchat.com> Subject: RE: Message-ID: <823277.37895.bm(a)smtp104.mail.ir2.yahoo.com> Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06 ---</cite>--- UCE/Spam again in this list ...! Please remove this user. Thanks a lot. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

d3dx9: Avoid useless computations in D3DXMatrixTransformation2D
by Nozomi Kodama 26 May '13

26 May '13

Hello What happens for this patch? Nozomi

1 1

Re: [PATCH] wininet: do avoid overwriting the buffer (Coverity)
by Marvin 26 May '13

26 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25714 Your paranoid android. === WXPX64 (32 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA === WXPX64 (64 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0

RE:
by xerox_xerox2000＠yahoo.co.uk 26 May '13

26 May '13

Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06

1 0

Re: [PATCH] kernel32: Don't move fixed memory area in GlobalReAlloc().
by Marvin 25 May '13

25 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25705 Your paranoid android. === W7PROX64 (32 bit heap) === heap.c:234: Test failed: got 00000000 heap.c:400: Test failed: got 00000000 === TEST64_W7SP1 (32 bit heap) === heap.c:234: Test failed: got 00000000 heap.c:400: Test failed: got 00000000

1 0

Re: [2/2] server: A being destroyed object may need to access other objects using a handle.
by Alexandre Julliard 24 May '13

24 May '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- a/server/handle.c > +++ b/server/handle.c > @@ -165,7 +165,6 @@ static void handle_table_destroy( struct object *obj ) > for (i = 0, entry = table->entries; i <= table->last; i++, entry++) > { > struct object *obj = entry->ptr; > - entry->ptr = NULL; > if (obj) release_object( obj ); You can't do that, the object can't be accessed after being released. -- Alexandre Julliard julliard(a)winehq.org

2 5

Adding names to the authors file.
by Tae Wong 24 May '13

24 May '13

The only Croatian person is Marko Nikolić, but with no accented letter. Could you also add Joško Nikolić (the Croatian translator) and Volkan Gezer (the Turkish translator) to the authors file as well? The file name (in all capitals) is AUTHORS. It is very great so that you have to accentuate Marko's name at the message. But you use "straight quotes" or “smart quotes”. And Van Schaik's name is credited under the surname (and not on the particle). Here is the sort that you want for the section: va. South African and Namibian names in Dutch should have been sorted on the prefix (particle), but not in the surname. Vainer, Moshe Valoska, Hleb Valtonen, Hannu Vance, Carroll Vanek, Tomas van Schaik, Carl (Note that this is on a letter by letter sort.) Vaughn, Charles

1 0

Re: po: Added Croatian translation.
by Frédéric Delanoy 24 May '13

24 May '13

On Thu, May 23, 2013 at 3:45 PM, Joško Nikolić <josko.nikolic1(a)gmail.com> wrote: > > --- > configure | 1 + > po/LINGUAS | 1 + > po/hr.po | 13923 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 13925 insertions(+) > create mode 100644 po/hr.po As mentioned on IRC, you should remove the #| msgid "foo" lines, and modify 'configure.ac' instead of 'configure', which is autogenerated. Frédéric

1 0

Re: [5/5] oledb32: GetConversionSize only returns a valid size of BSTR
by Marvin 24 May '13

24 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25680 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] oledb32: DataConvert only variant length types can have a null dst
by Marvin 24 May '13

24 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25679 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] oledb32: DataConvert Support NULL variant
by Marvin 24 May '13

24 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25677 Your paranoid android. === WVISTAX64 (64 bit convert) === No test summary line found === W7PROX64 (64 bit convert) === No test summary line found === TEST64_W7SP1 (64 bit convert) === No test summary line found

1 0

Re: [5/5] oledb32: GetConversionSize only returns a valid size of BSTR
by Nikolay Sivov 23 May '13

23 May '13

On Thu, May 23, 2013 at 11:48 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oledb32: GetConversionSize only returns a valid size of BSTR > + if(V_VT((VARIANT*)src) != VT_BSTR) + *dst_len = 110; else - return hr; + *dst_len = (SysStringLen(V_BSTR((VARIANT*)src)) + 1) * sizeof(WCHAR); + + return S_OK; So it returns previous result if type is invalid, meaning it's not VT_BSTR? You can't just return a random constant that appears in tests just because of previously made call (which is my guess). If you really want to implement this broken behaviour it will need more tests, at least one more that shows it returns a result from last successful call. > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: advapi32/tests: Fix copy&paste typo
by Guo Jian 23 May '13

23 May '13

Hi Andre, According to my test plan of the registry merging project, I will add new tests for HKCR. At first I tried to add them to the old code but I find it become too long and hard-reading. I had to rewrite them to a series of strict and neat tests, classified as read/write operations, including keys & values enumerating and deleting. I used many pre-definitions which make the test look fluent, but I'm not sure if the code is acceptable. http://newtestbot.winehq.org/JobDetails.pl?Key=942 static void test_classesroot(void) { DWORD res, len, i; HKEY hkey; char name[32]; #define CREATE_KEY(key, path) \ { \ HKEY tmp; \ if ((res = RegCreateKeyExA( key, path, 0, NULL, 0, \ KEY_ENUMERATE_SUB_KEYS|KEY_SET_VALUE|KEY_QUERY_VALUE|KEY_CREATE_SUB_KEY, \ NULL, &tmp, NULL )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegCreateKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ RegCloseKey(tmp); \ } \ } #define DELETE_KEY(key, path) \ { \ DWORD res; \ if ((res = RegDeleteKey(key, path)) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegDeleteKey %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ } #define SET_VALUE(key, path, name, value) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_SET_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ if ((res = RegSetValueEx( tmp, name, 0, REG_SZ, \ (CONST BYTE*)value, strlen(value) )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegSetValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define CHECK_EXIST_KEY(key, path) \ ok(exist_key(key, path), "key %p\\%s should exist\n", key, path); #define CHECK_NOT_EXIST_KEY(key, path) \ ok(!exist_key(key, path), "key %p\\%s should exist\n", key, path); #define CHECK_VALUE(key, path, name, value) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ char buf[32]; \ DWORD type = REG_SZ, size = sizeof(buf); \ if ((res = RegQueryValueEx( tmp, name, 0, &type, \ (BYTE*)buf, &size )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegQueryValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ ok(!strcmp(value, buf), "%s expected '%s' but got '%s' in %p\\%s\n", name, value, buf, key, path); \ RegCloseKey(tmp); \ } \ } #define CHECK_NON_VALUE(key, path, name) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ char buf[32]; \ DWORD type = REG_SZ, size = sizeof(buf); \ if ((res = RegQueryValueEx( tmp, name, 0, &type, \ (BYTE*)buf, &size )) == ERROR_SUCCESS) \ { \ ok(FALSE, "%s should not exist in %p\\%s\n", name, key, path); \ } \ else if (res != ERROR_FILE_NOT_FOUND) \ { \ ok(FALSE, "RegQueryValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define DELETE_VALUE(key, path, name) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_SET_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ if ((res = RegDeleteValueA(tmp, name)) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegDeleteValue %s in %p\\%s failed with %08X\n", name, key, path, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define CHECK_KEY_INFO(key, path, c1, c2) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ DWORD n1, n2; \ if (ERROR_SUCCESS != (res = RegQueryInfoKeyA( tmp, NULL, NULL, NULL, \ &n1, NULL, NULL, &n2, NULL, NULL, NULL, NULL ))) \ { \ ok(FALSE, "RegQueryInfoKeyA failed with %08X\n\n", res); \ return; \ } \ ok(n1 == c1, "subkey count expected %d but got %d in %p\\%s\n", c1, n1, key, path); \ ok(n2 == c2, "value count expected %d but got %d in %p\\%s\n", c2, n2, key, path); \ RegCloseKey(tmp); \ } \ } /* test create_key priority */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, STANDARD_RIGHTS_READ, &hkey )) != ERROR_SUCCESS) { skip("classes merging not supported\n"); cleanup_classes(); return; } /* test create_key priority */ /* create from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hklm then hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hkcu then hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); /* further test based on the below */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, KEY_CREATE_SUB_KEY, &hkey )) != ERROR_SUCCESS) { ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", hkey, "WineTestCls", res); return; } /* create subkey under the handle opened from the key that exists only in hkcu but not hklm */ CREATE_KEY(hkey, "subkey1"); RegCloseKey(hkey); /* check that subkey is created in hklm, proving that the handle from hkcr is not same as opened in hkcu, even when it does not conflict with hklm */ CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey1"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); /* test delete_key priority */ /* create from hkcu and delete from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hklm and delete from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hkcu and hklm and delete twice from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* delete again */ DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* test set_value priority */ /* set new value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* set value from hkcu and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* set value from hklm and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* set value from hkcu and hklm and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* set value from hklm in a key not conflict with hkcu and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hkcr"); /* test delete_value priority, no need to test when not conflict */ /* set value from hkcu and hklm then delete twice from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); DELETE_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1"); CHECK_NON_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* delete again */ DELETE_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* test query_value priority, noneed to test when not conflict */ /* set value to hkcu and create the key in hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); /* set value to hklm and create the key in hkcu then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hklm"); /* set conflict value both to hkcu and hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); /* set non conflict value both to hkcu and hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hklm"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val2", "hklm"); /* test query_info_key priority, no need to test when queried key does not conflict */ /* check subkey and value count for conflict subkeys from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 1, 1); /* check subkey and value count for non conflict subkeys from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey2"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hkcu"); CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 2, 2); /* test enum_key priority, no need to test when enumerated key does not conflict */ /* create subkeys and values in hkcu and hklm */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey3"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val3", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey3"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey2"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val3", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hkcu"); /* check the count */ CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 3, 3); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, KEY_ENUMERATE_SUB_KEYS|KEY_QUERY_VALUE, &hkey )) != ERROR_SUCCESS) { ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", hkey, "WineTestCls", res); return; } /* check the names and order of subkeys when enumerating */ i = 0; len = sizeof(name); while (ERROR_SUCCESS == (res = RegEnumKeyExA(hkey, i, name, &len, NULL, NULL, NULL, NULL))) { ++ i; if (i > 3) { ok(FALSE, "got extra subkey name %s\n", name); } else if (strncmp(name, "subkey", 6) || name[6] != (i + '0') || name[7]) { ok(FALSE, "got unexpected subkey name or order %s at index %d\n", name, i); } len = sizeof(name); } if (res != ERROR_NO_MORE_ITEMS) { ok(FALSE, "RegEnumKeyExA failed with %08X\n", res); return; } if (i < 3) { ok(FALSE, "expected 3 subkeys but got only %d\n", i); } /* check the names and order of values when enumerating */ i = 0; len = sizeof(name); while (ERROR_SUCCESS == (res = RegEnumValueA(hkey, i, name, &len, NULL, NULL, NULL, NULL))) { ++ i; if (i > 3) { ok(FALSE, "got extra value name %s\n", name); } else if (strncmp(name, "val", 3) || name[3] != (i + '0') || name[4]) { ok(FALSE, "got unexpected value name or order %s at index %d\n", name, i); } len = sizeof(name); } if (res != ERROR_NO_MORE_ITEMS) { ok(FALSE, "RegEnumValueA failed with %08X\n", res); return; } if (i < 3) { ok(FALSE, "expected 3 value but got only %d\n", i); } RegCloseKey(hkey); cleanup_classes(); } -- Regards, Guo Jian

1 0

Regression for bash.exe redirection of ctest.exe for wine-1.5.30 compared to wine-1.5.19
by Alan W. Irwin 22 May '13

22 May '13

Generally I have found in still fairly limited testing that MSYS bash.exe redirection is fine on wine-1.5.30 (which I have now been able to build in 32-bit mode on Debian wheezy x86_64 thanks to the 32-bit library symlink trick discussed in my previous recent thread). However, I have just discovered a puzzling case where MSYS bash.exe redirection now fails for ctest.exe compared to wine-1.5.19. To reproduce this regression download the Windows binary version of cmake-1.8.10.2 (which includes cmake.exe and ctest.exe) and install it. Also download and install MinGW/MSYS. In the past, I have found results depend very much on how you get into the MSYS bash.exe environment. In my case I execute wineconsole --backend=curses MinGW_4.7.0/msys/1.0/bin/bash.exe to do that, and then from that interactive environment execute the commands below. Here is how I try the --version option for cmake and ctest with redirection under bash.exe. bash.exe-3.1$ cmake --version >& cmake_version.out bash.exe-3.1$ ctest --version >& ctest_version.out For Wine-1.5.19 bash.exe-3.1$ head *.out ==> cmake_version.out <== cmake version 2.8.10.2 ==> ctest_version.out <== ctest version 2.8.10.2 For Wine-1.5.30 bash.exe-3.1$ head *.out ==> cmake_version.out <== cmake version 2.8.10.2 ==> ctest_version.out <== N.B. note the incorrect empty ctest_version.out file for Wine-1.5.30. For both Wine-1.5.19 and Wine-1.5.30 if I don't redirect the output I simply get the following results bash.exe-3.1$ cmake --version cmake version 2.8.10.2 bash.exe-3.1$ ctest --version ctest version 2.8.10.2 So somehow bash.exe redirection for ctest (but not cmake and a small number of other commands I have tried) generates an incorrect empty file for Wine-1.5.30. I never have had trouble with bash.exe redirection for any command (including ctest) on either Linux bash or MSYS bash.exe on Wine-1.5.19. So it is likely there is some minor (but probably standard) variation in how ctest handles its stdout that is triggering this Wine-1.5.30 regression compared to Wine-1.5.19. So there might be other commands as well where bash.exe redirection doesn't work for Wine-1.5.30. If it is already known that MSYS bash.exe redirection is sometimes problematic with Wine-1.5.30 compared to earlier versions, is there some patch I could try to see if it fixes this specific issue? My primary motivation is developing my own free software. Therefore, I only have limited time to help figure out wine bugs although I am willing to report the ones I discover here (and on the bug tracker once discussed here to reduce bug tracker noise). That said, it does appear that git-bisect would be an ideal way to find which commit between Wine-1.5.19 and Wine-1.5.30 caused the bash.exe redirection issue with ctest.exe. Unfortunately, I have zero experience with git-bisect. However, if somebody could give me some step-by-step instructions I could follow by rote that would be great. Ideally, those instructions would be a simple template bash script I could run unattended overnight from Linux that used git-bisect to detect the first commit between Wine-1.5.19 and Wine-1.5.30 where ctest --version >& ctest_version.out produces an empty file under MSYS bash.exe. I can fill in the parts of that template script concerning the wine build for each git commit that is being tested since I have such builds (including necessary *.so links for later wine versions) largely automated now. But I am not sure about how you get into MSYS bash.exe directly (my normal method using wineconsole as above appears to be interactive rather than something you could run unattended) from a Linux bash script so I would need advice about that. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

2 3

Patches 96314 & 96328
by Christian Costa 22 May '13

22 May '13

Hi, Is there any problem with these patches? http://source.winehq.org/patches/data/96314 http://source.winehq.org/patches/data/96328 Christian

1 0

Re: [PATCH 2/5] dinput: Support SendForceFeedbackCommand for OSX joysticks
by Charles Davis 22 May '13

22 May '13

On May 21, 2013, at 1:34 PM, Andrew Eikum wrote: > --- > dlls/dinput/joystick_osx.c | 34 ++++++++++++++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 94398e7..8fb675d 100644 > --- a/dlls/dinput/joystick_osx.c > +++ b/dlls/dinput/joystick_osx.c > @@ -1135,6 +1135,36 @@ static HRESULT WINAPI JoystickAImpl_CreateEffect(IDirectInputDevice8A *iface, > type, params, out, outer); > } > > +static HRESULT WINAPI JoystickWImpl_SendForceFeedbackCommand(IDirectInputDevice8W *iface, > + DWORD flags) > +{ > + JoystickImpl *This = impl_from_IDirectInputDevice8W(iface); > + HRESULT hr; > + > + TRACE("%p 0x%x\n", This, flags); > + > + if(!This->ff) > + return DI_NOEFFECT; > + > + hr = FFDeviceSendForceFeedbackCommand(This->ff, flags); > + if(FAILED(hr)){ > + WARN("FFDeviceSendForceFeedbackCommand failed: %08x\n", hr); > + return hr; You can't return the straight HRESULT from ForceFeedback here. That's because the codes in the FACILITY_NULL range on Mac get their values from the 16-bit COM runtime (cf. <CoreFoundation/CFPlugInCOM.h>). You must turn them into their corresponding Win32 codes. Chip

2 1

wine-osX developer for winmm joystick project?
by DavidL 22 May '13

22 May '13

To anybody interested, I think I've found a solution to an old problem of implementing winmm joystick support in WINE for Mac, but lack the necessary skills and experience to code it up myself. WINE-Linux has had it implemented for awhile, but it was never coded up for OS X. winmm is an older interface used for a lot of different peripherals, included joysticks in quite a few classic games. As there were also some problems with dinput for WINE-OSX, originally it was thought the problems with winmm were also a bug. However, the problems with dinput have been solved and it seems the necessary code for winmm joystick support, rather than being buggy, was never actually written for WINE for the Mac. Thus it is an issue in need of development rather than a bug report. So I thought I'd ask if anyone was interested in developing the code to get winmm working in in the Mac-WINE environment? I have an idea about what needs to be written but I lack the experience in Mac-system level programming to be of much use. I did take a look but found the API very arcane. That's why I am asking for someone with more experience. From what I can tell, the code should not be difficult to write for someone who knew what they were doing with regards to Mac system programming. There aren't many functions that need to be written and what ones there are seem simple enough. I have an outline about what functions need to written and modified to get winmm functionality working for the Mac-WINE environment. The requisite changes are here: ( http://bugs.winehq.org/show_bug.cgi?id=18424#c75) It is written in a bug report because originally it was part of the same conversation as the dinput bug. I look forward to hearing back from anyone interested in taking this (I think) short development project up. I'd be happy to learn and help test the code with some classic games that require winmm. Cheers, David

1 0

Re: [PATCH 2/4] ddraw/tests: Add EXCLUSIVE->NORMAL coop level switching tests
by Henri Verbeet 22 May '13

22 May '13

On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static void test_coop_level_versions(void) It may make more sense to move that to ddraw2.c and ddraw4.c instead. (IIRC you can't QI a ddraw1 interface from ddraw7.)

2 2

Re: [PATCH 1/4] ddraw: Restore resolution on EXCLUSIVE->NORMAL switch
by Henri Verbeet 22 May '13

22 May '13

On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The new code does not deliver the resolution change messages to the > correct window, see the todo_wine markers in the next patch. Getting > this right isn't simply a matter of passing the correct window to > wined3d_device_restore_fullscreen_window because the delivery of the > correct messages in the new window == old window case is mostly a lucky > side effect of the window style hacks. Those hacks fail if we pass a > different window, because the style of the new window is different from > what wined3d expects, so it doesn't send any messages. Well, wined3d_device_restore_fullscreen_window() isn't really supposed to generate messages at all, the resize on mode changes happens in device_parent_mode_changed(). The implication seems to be that restoring the display mode is supposed to happen after the new swapchain is created, but before "ddraw->cooperative_level" is updated. > /***************************************************************************** > + * IDirectDraw7::RestoreDisplayMode > + * > + * Restores the display mode to what it was at creation time. Basically. > + * > + * Returns > + * DD_OK on success > + * DDERR_NOEXCLUSIVE mode if the device isn't in fullscreen mode > + * > + *****************************************************************************/ I don't think that really adds anything. > -static HRESULT WINAPI ddraw7_SetCooperativeLevel(IDirectDraw7 *iface, HWND window, DWORD cooplevel) > +static HRESULT WINAPI ddraw_set_cooperative_level(struct ddraw *ddraw, HWND window, > + DWORD cooplevel, BOOL restore_mode) Shadowing the global "restore_mode" is a bit unfortunate. > - TRACE("iface %p, window %p, flags %#x.\n", iface, window, cooplevel); > + TRACE("ddraw %p, window %p, flags %#x, restore_mode %s.\n", ddraw, window, cooplevel, > + restore_mode ? "true" : "false"); I think %#x is generally clear enough for BOOLs. > if(cooplevel & DDSCL_ALLOWREBOOT) > - WARN("(%p) Unhandled flag DDSCL_ALLOWREBOOT, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_ALLOWREBOOT, harmless\n", ddraw); > if(cooplevel & DDSCL_ALLOWMODEX) > - WARN("(%p) Unhandled flag DDSCL_ALLOWMODEX, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_ALLOWMODEX, harmless\n", ddraw); > if(cooplevel & DDSCL_FPUSETUP) > - WARN("(%p) Unhandled flag DDSCL_FPUSETUP, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_FPUSETUP, harmless\n", ddraw); The "(%p)" there is pretty pointless, I usually remove them if I'm editing the line anyway. > @@ -86,6 +86,7 @@ struct ddraw > > /* DirectDraw things, which are not handled by WineD3D */ > DWORD cooperative_level; > + BOOL setcooplevel_ddraw1; > We should probably consolidate the various BOOLs in struct ddraw into a flags field.

2 2

Question about legal requirement on gsoc page
by Christian Costa 22 May '13

22 May '13

*Hi, * *I read on the GSoC page this: * *"You are not allowed to analyze Windows files with the trace functions of Wine" * *What does that mean? * *Thanks * *Christian *

2 2

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called (try 2).
by Alexandre Julliard 22 May '13

22 May '13

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -5383,7 +5383,11 @@ int WINAPI WSAEventSelect(SOCKET s, WSAEVENT hEvent, LONG lEvent) > ret = wine_server_call( req ); > } > SERVER_END_REQ; > - if (!ret) return 0; > + if (!ret) > + { > + _enable_event(SOCKET2HANDLE(s), 0, FD_WINE_NONBLOCKING, 0); > + return 0; > + } You shouldn't need 2 server calls for this. > @@ -3578,6 +3584,12 @@ static void test_events(int useMessages) > goto end; > } > > + if (set_blocking(src2, TRUE)) > + { > + ok(0, "set_blocking failed, error %d\n", WSAGetLastError()); > + goto end; > + } There's no reason to abort on every failure. -- Alexandre Julliard julliard(a)winehq.org

2 1

Troubles configuring and building wine-1.5.30 on Debian wheezy
by Alan W. Irwin 22 May '13

22 May '13

My use case is building and testing software packages on Wine. My 32-bit build of wine-1.5.19 on x86_64 hardware was fine for this purpose for MinGW/MSYS builds so I stuck with it until today when I attempted to expand my building and testing of software to the Cygwin on Wine platform. I immediately ran into some issues with the Cygwin setup.exe installer so my first instinct was to try the latest experimental wine release, wine-1.5.30, but it's build has changed quite a bit since when I built wine-1.5.19, and I need some help figuring out what to do. The first issue was the configure script complained that the 32-bit version of the X libraries was missing and errored out. I then decided to try the 64-bit version of wine instead (since my Debian system has mostly 64-bit libraries). I got that 64-bit-only build and install to work perfectly, but I could not run anything with it. For example: wine@raven> wine64 wine64: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory I then looked at http://wiki.winehq.org/Wine64 which recommended a WoW64 configuration, where you build both 64-bit and 32-bit versions of Wine and install both. So following those directions, the 64-bit version again built and installed without issues (in fact I just renamed what I did before) but the 32-bit version again errored out on lack of a 32-bit X library. Now Debian wheezy has multiarch implemented properly for some (but not all) packages so I was able to install libx11-dev:i386 which coexisted fine with the installed libx11-dev:amd64 and also solved the 32-bit X issue. But then the 32-bit wine-1.5.30 configure continued further and ran into a similar issue with missing 32-bit freetype6. The error message was configure: error: FreeType 32-bit development files not found. Fonts will not be built. Use the --without-freetype option if you really want this. Accordingly I attempted to install libfreetype6-dev:i386 but on Debian wheezy that conflicts with libfreetype6-dev:amd64, and it appears the only way around this packaging issue for now (until the libfreetype6-dev:i386 and libfreetype6-dev:amd64 packages are taught to coexist) is to create a pure 32-bit Debian wheezy system (which I don't want to do). So here are my questions and further comments: 1. Is there a way to stick with a pure 64-bit Wine system, or is that normally pretty useless because downloaded applications such as the Cygwin installer which apparently is 32-bit, i.e., wine@raven> file setup.exe setup.exe: PE32 executable (GUI) Intel 80386 (stripped to external PDB), for MS Windows, UPX compressed wont run on it? 2. If the WoW64 configuration is really the best solution, what are the consequences of dropping libfreetype from the 32-bit configuration (but obviously including it in the 64-bit configuration). IOW, if I just say --without-freetype for the 32-bit configuration (suggested as a possibility above by that error message) will the fonts be built and installed by the 64-bit configuration that includes libfreetype? 3. I would have liked to continue with pure 32-bit wine since that was what I have been used to all these years, but it appears wine-1.5.30 32-bit dependencies are really fearsome compared to the relative modest 32-bit dependencies for wine-1.5.19 so this effectively makes it impossible to build a standalone 32-bit wine system on Debian Wheezy (because no fonts will be built if --without-freetype is used) and might also compromise WoW64 builds (see question 2 above). It obviously doesn't affect pure 64-bit Wine builds, but I couldn't get that to work at all at run time (missing libwine.so.1 (see above)), but if there are workarounds for that issue, then it still might be useless (see question 1 above). Any help/comments on the correct way to build wine-1.5.30 would be much appreciated for the case (as on Debian wheezy) where 32-bit and 64-bit libfreetype packages cannot be installed simultaneously. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

5 8

Re: server: Always redraw children when parent's pos/size changed in any way (Try 2).
by Sergey Guralnik 21 May '13

21 May '13

On 2013-05-06 13:24, Sergey Guralnik wrote: > Alexandre Julliard writes: >> ... >> It doesn't make sense to have all these complicated tests if we are >> going to always repaint anyway, which is essentially what your patch >> does. There has to be more to it than that. > > This version uses the same logic as used before, but also it > removes all redundant checks. > > --- > dlls/user32/tests/win.c | 1 - > server/window.c | 32 ++++++-------------------------- > 2 files changed, 6 insertions(+), 27 deletions(-) Is there some problem with this patch? -- Sergey

2 1

Re: dbghelp: Add stub SymGetLineNextW64
by Alexandre Julliard 21 May '13

21 May '13

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -1717,6 +1717,17 @@ BOOL WINAPI SymGetLineNext64(HANDLE hProcess, PIMAGEHLP_LINE64 Line) > } > > /****************************************************************** > + * SymGetLineNextW64 (DBGHELP.@) > + * > + */ > +BOOL WINAPI SymGetLineNextW64(HANDLE hProcess, PIMAGEHLP_LINEW64 Line) > +{ > + FIXME("(%p %p) stub \n", hProcess, Line); > + > + return FALSE; > +} It wouldn't be much harder to implement this properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20: Added tests for ITextDocument::Open
by Nikolay Sivov 21 May '13

21 May '13

On Tue, May 21, 2013 at 3:45 PM, Jactry Zeng <jactry92(a)gmail.com> wrote: > > > > > If the whole purpose of storing flags names is to output readable debug info I think it's better to have a single separate function that takes flags combination and returns static buffer pointer with a name. This way it will need just to append after bitwise 'and' check. + /* tests for ITextDocument::Open */ + for(; tomNunSingle >= 0; tomNunSingle--) Do you really need to go from the tail here?

1 0

Re: Alexandre Julliard : msvcrt: Don't bother to clean up at process exit.
by Dmitry Timoshkov 21 May '13

21 May '13

Alexandre Julliard <julliard(a)winehq.org> wrote: > case DLL_PROCESS_DETACH: > - msvcrt_free_popen_data(); > msvcrt_free_io(); > + if (lpvReserved) break; > + msvcrt_free_popen_data(); > msvcrt_free_mt_locks(); > msvcrt_free_console(); > msvcrt_free_args(); Shouldn't msvcrt_free_io() be also protected by this guard? -- Dmitry.

3 6

Re: [PATCH] d3dxof: Cleanup separators handling and allow multi-semicolons + single comma separator.
by Alexandre Julliard 21 May '13

21 May '13

Christian Costa <titan.costa(a)gmail.com> writes: > There is one test becoming todo. This will be fixed in another patch. > This patch also should fix bug 30897. > --- > dlls/d3dxof/parsing.c | 35 ++++++++++------------------------- > dlls/d3dxof/tests/d3dxof.c | 22 +++++++++++----------- > 2 files changed, 21 insertions(+), 36 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:275: Test failed: Cannot load mesh data (hr = 88760311) d3drm.c:280: Test failed: Retrieved name '' instead of 'Object' d3drm.c:283: Test failed: IDirect3DRMMeshBuilder_GetName returned hr = 0 d3drm.c:298: Test failed: Wrong number of vertices 0 (must be 4) d3drm.c:301: Test failed: Wrong number of faces 0 (must be 3) d3drm.c:305: Test failed: Wrong number of vertices 0 (must be 4) d3drm.c:306: Test failed: Wrong number of normals 0 (must be 4) d3drm.c:307: Test failed: Wrong number of face data bytes 0 (must be 22) d3drm.c:315: Test failed: Wrong component n[1].x = 0.000000 (expected -0.229416) d3drm.c:318: Test failed: Wrong component n[2].x = 0.000000 (expected -0.229416) d3drm.c:319: Test failed: Wrong component n[2].y = 4021199976020422122536960.000000 (expected 0.688247) d3drm.c:320: Test failed: Wrong component n[2].z = 9973638011820690691325952.000000 (expected 0.688247) d3drm.c:321: Test failed: Wrong component n[3].x = 0.000000 (expected -0.577350) d3drm.c:323: Test failed: Wrong component n[3].z = 1387759860774554023173815085733773312.000000 (expected 0.577350) d3drm.c:329: Test failed: Cannot get texture coordinates (hr = 88760316) d3drm.c:330: Test failed: Wrong coordinate 1.230000 (must be 0.0) etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin 21 May '13

21 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25647 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin 21 May '13

21 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25646 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Jacek Caban 21 May '13

21 May '13

Hi Zhan, On 05/17/13 16:53, Zhan Jianyu wrote: > This patch is built based on Jaceks's newly-submitted patch: > > commit 48a862306288d69d3623d5ecdc0f5a5a40addafe > ( vbscript: Round half to even in to_int) > > Thanks, Jacek. :-) > > With his patch, CInt could be implementd in a clean way, without > any introduced helper function. > > This patch also add tests for any corner cases, and it has passed testbot's > testing. > > --- > dlls/vbscript/global.c | 14 ++++++++++++-- > dlls/vbscript/tests/api.vbs | 23 +++++++++++++++++++++++ > 2 files changed, 35 insertions(+), 2 deletions(-) As you may check here: http://source.winehq.org/patches/ your patch is marked as 'Apply failure'. Did you prepare the patch against recent Wine Git? Please rebase and resend the patch. Cheers, Jacek

1 0

Re: Troubles configuring and building wine-1.5.30 on Debian wheezy
by Hugh McMaster 21 May '13

21 May '13

On Monday May 20 at 22:24:58, Alan W. Irwin wrote: >wine at raven> wine64 >wine64: error while loading shared libraries: libwine.so.1: cannot >open shared object file: No such file or directory Hi Alan, This error is caused by a regression in Wine 1.5.30. It is not present in version 1.5.29. The general source for Wine 1.5.30 on WineHQ does contain a patch to resolve the issue. The patch is available from http://source.winehq.org/git/wine.git/patch/ce4b6451aabbe83809c7483c748cfa0…. To apply it, you will need to save the patch with either the extension .patch or .txt in the Wine source directory. You will then need to run the patch command from the source directory: patch -p1 < name.patch Alternatively, you can use Git to obtain the latest source: git clone git://source.winehq.org/git/wine.git ~/wine-git This option will come with the patch already applied and a lot of other changes. --- Hugh

1 0

Re: [1/4] server: Add support for console font size, maximum window size, etc.
by Dmitry Timoshkov 21 May '13

21 May '13

Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote: > This patch modifies server/protocol.def and server/console.c to add support > for console font size detection and console window size rendering. It also > tidies up a few inconsistencies in the repeated usage of aspects of the > screen buffer struct. Your patches are full of formatting and white space changes, please don't do that. -- Dmitry.

2 1

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Charles Davis 20 May '13

20 May '13

On May 19, 2013, at 9:14 PM, Dmitry Timoshkov wrote: > diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c > index f8904df..646f3a7 100644 > --- a/dlls/windowscodecs/bitmap.c > +++ b/dlls/windowscodecs/bitmap.c > @@ -446,6 +471,226 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl = { > BitmapImpl_SetResolution > }; > > +static HRESULT WINAPI IMILBitmapImpl_QueryInterface(IMILBitmapSource *iface, REFIID iid, > + void **ppv) > +{ > + BitmapImpl *This = impl_from_IMILBitmapSource(iface); > + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > + > + if (!ppv) return E_INVALIDARG; > + > + if (IsEqualIID(&IID_IUnknown, iid) || > + IsEqualIID(&IID_IMILBitmapSource, iid)) > + { > + *ppv = &This->IMILBitmapSource_iface; > + IUnknown_AddRef((IUnknown*)*ppv); > + return S_OK; > + } You're violating COM rules here: when you QI an object for an interface pointer, the QI must always return the same result no matter what. Here, however, you're returning this interface pointer in response to a query for IUnknown, when the already-existing QueryInterface method on the IWICBitmap interface returns *itself* for IUnknown! Now when you QI for IUnknown on both of these interfaces, they won't compare equal. (I suspect you're not convinced. After all, native might violate COM rules here, too. I doubt that (see below), but it might. So, write a test that QI's for IUnknown from both interfaces, and checks if they're equal or not. Then we'll see who's right.) > diff --git a/dlls/windowscodecs/wincodecs_private.h b/dlls/windowscodecs/wincodecs_private.h > index dddb327..29f7726 100644 > --- a/dlls/windowscodecs/wincodecs_private.h > +++ b/dlls/windowscodecs/wincodecs_private.h > @@ -27,6 +27,46 @@ DEFINE_GUID(GUID_WineContainerFormatTga, 0x0c44fda1,0xa5c5,0x4298,0x96,0x85,0x47 > > DEFINE_GUID(GUID_VendorWine, 0xddf46da1,0x7dc1,0x404e,0x98,0xf2,0xef,0xa4,0x8d,0xfc,0x95,0x0a); > > +DEFINE_GUID(IID_IMILBitmapSource,0x7543696a,0xbc8d,0x46b0,0x5f,0x81,0x8d,0x95,0x72,0x89,0x72,0xbe); > +#define INTERFACE IMILBitmapSource > +DECLARE_INTERFACE_(IMILBitmapSource,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; You know you can just use the STDMETHOD() macro (no trailing underscore), e.g.: STDMETHOD(QueryInterface)(THIS_ REFIID,void **) PURE; for methods that return an HRESULT, right? Or do you prefer explicitly declaring the return type like that, even if it is more typing? > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > + /*** IMILBitmapSource methods ***/ > + STDMETHOD_(HRESULT,GetSize)(THIS_ UINT *,UINT *); > + STDMETHOD_(HRESULT,GetPixelFormat)(THIS_ int *); > + STDMETHOD_(HRESULT,GetResolution)(THIS_ double *,double *); > + STDMETHOD_(HRESULT,CopyPalette)(THIS_ IWICPalette *); > + STDMETHOD_(HRESULT,CopyPixels)(THIS_ const WICRect *,UINT,UINT,BYTE *); > + STDMETHOD_(HRESULT,UnknownMethod1)(THIS_ void **); > +}; > +#undef INTERFACE > + > +#define INTERFACE IMILUnknown1 > +DECLARE_INTERFACE_(IMILUnknown1,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > +}; > +#undef INTERFACE Wouldn't that just make this interface a plain old IUnknown? Or does it have its own IID? (Or does that not even matter, given that it's returned from that "UnknownMethod1" above?) If it is nothing more than a plain IUnknown, why did you even add this, since it doesn't really extend the IUnknown interface with any new methods? It's telling that its v-table is the very first v-table in the object. This probably indicates that this really is the canonical IUnknown (i.e. the one that gets returned when you QI for IUnknown), and the other interfaces' IUnknown methods just delegate to this one. If I haven't missed my guess about this object's QI implementation, then this is the IUnknown that should get returned from a QI for IUnknown. This might actually be an object that supports aggregation; you may want to test for that, too ;). Chip

2 1

Re: [PATCH 6/6] d3d9/tests: d3d9ex video memory accounting tests
by Henri Verbeet 20 May '13

20 May '13

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > These tests have the potential to break on Windows when other > applications create or release a large number of video memory resources > while the test is running. > Yeah, maybe we don't really need this to be in the tree, although it's good to see for reference.

4 3

Re: msvcm80: Remove pre-attach handler for a dll with manifest.
by Alexandre Julliard 20 May '13

20 May '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Manifest prevents loading of a native dll anyway. Not if it's installed globally. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.
by Dmitry Timoshkov 20 May '13

20 May '13

Qian Hong <qhong(a)codeweavers.com> wrote: > Fixed http://bugs.winehq.org/show_bug.cgi?id=33076 > > Reference: > http://msdn.microsoft.com/en-us/library/windows/desktop/ms741621%28v=vs.85%… > > See also comment in WSAIoctl: > /* AsyncSelect()'ed sockets are always nonblocking */ This change requires a test case, MSDN is often wrong, so its claims at least need to be very carefully checked. -- Dmitry.

2 5

Re: oledb32: Support DBSTATUS_S_ISNULL when converting to VARIANT
by Marvin 20 May '13

20 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25629 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Marvin 20 May '13

20 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25624 Your paranoid android. === WVISTAX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77370897 === W2K8SE (32 bit bitmap) === bitmap: unhandled exception c0000005 at 778A81CB === W7PROX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77E035F2 === TEST64_W7SP1 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77593772 === W7PROX64 (64 bit bitmap) === No test summary line found === TEST64_W7SP1 (64 bit bitmap) === Timeout

1 0

Duplicate relocations in DLL
by Alessandro Pignotti 19 May '13

19 May '13

Hi everyone, Packaged with a game, I found a peculiar DLL which has duplicate blocks in the relocation table. I mean that the same pages are relocated twice and this of course breaks the DLL. I'm not sure about what could be a right way to support such (broken) DLLs. A possibility would be to keep track of already relocated pages and skip them if needed. Suggestions are welcome. Regards, Alessandro Pignotti

3 7

wineconsole screen scenarios
by Hugh McMaster 19 May '13

19 May '13

In my effort to improve wineconsole and its calculations of the largest possible window size, three scenarios come into play. 1. wineconsole with --backend=user (or more simply, 'wineconsole app.exe, in which case 'user' is the default). 2. wineconsole with --backend=curses. 3. wineconsole with --backend=curses, but no X server running. Detecting the screen resolution is a simple task with (1) and (2). SystemParametersInfo for (1) and wine's own XRandR for (2) can be used. My concern is with scenario (3). Wine is designed to be used with an X server, but wineconsole can be used in non-X-based environment. While this is possible, it would seem unlikely. Nonetheless, the issue has come up on the wine-devel list before. The question is, should I worry about supporting such a scenario?

5 6

Re: [PATCH] ieframe: Add a IServiceProvider stub to IBindStatusCallback
by Alistair Leslie-Hughes 19 May '13

19 May '13

On 18/05/2013 11:11 PM, Detlef Riekenberg wrote: > -- > By by ... Detlef > > --- > dlls/ieframe/navigate.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 51 insertions(+), 0 deletions(-) Tests to prove the interface exists. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow (resend)
by Marvin 18 May '13

18 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25614 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: GSoC proposal
by George Stephanos 17 May '13

17 May '13

As we know already from [1], the merge is going to happen according to certain rules. The list at the end of the page signifies which subkeys are going to be *merged* from HKLM\Software\Classes\subkey and HKCU\Software\Classes\subkey and not simply linked to. Now there's a comment on the article that says that list is stored in a key. That lead me into thinking that the list is dynamic and should be determined at runtime using that key. However that key doesn't exist on my Win8 box or the web even. Should I just assume the list is static and build my tests/code according to it? Is there something I'm missing? [1] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… On Wed, May 8, 2013 at 1:26 AM, George Stephanos <gaf.stephanos(a)gmail.com>wrote: > I'm done. Sorry for the font massacre. They're not changing :| > > > On Tue, May 7, 2013 at 6:45 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > >> I'll leave it open till tomorrow (my time.) Thanks, >> --Juan >> >> >> On Tue, May 7, 2013 at 9:44 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >> >>> Oh, hang on, I just flipped it so you can modify it. >>> >>> >>> On Tue, May 7, 2013 at 9:43 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >>> >>>> I think you can add more of a timeline in a response. Will that work? >>>> --Juan >>>> >>>> >>>> On Tue, May 7, 2013 at 9:40 AM, George Stephanos < >>>> gaf.stephanos(a)gmail.com> wrote: >>>> >>>>> I had responded already but yes I'm a little bit shallow on the >>>>> timeline details. Alright. >>>>> Could you give me permission to modify the proposal? >>>>> >>>> >>>> >>> >> >

2 2

Re: [PATCH 4/6] gdi32: Use the default character when the glyph is missing.
by Alexandre Julliard 17 May '13

17 May '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This change is useful for a bitmap font. Because its glyph index 0 isn't the > default glyph in some cases. This doesn't seem to match what GetGlyphIndices does, and we probably don't want to do that in two different places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin 17 May '13

17 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25605 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin 17 May '13

17 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25604 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Only display a fixme when software processing is requested in wined3d_device_set_software_vertex_processing.
by Austin English 17 May '13

17 May '13

On Thu, May 16, 2013 at 2:26 PM, Christian Costa <titan.costa(a)gmail.com> wrote: > Also remove fixme in wined3d_device_get_software_vertex_processing since it does what it is supposed to do. > --- > dlls/wined3d/device.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index 47da78b..89fc525 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4281,9 +4281,9 @@ void CDECL wined3d_device_set_software_vertex_processing(struct wined3d_device * > > TRACE("device %p, software %#x.\n", device, software); > > - if (!warned) > + if (software && !warned) > { > - FIXME("device %p, software %#x stub!\n", device, software); > + FIXME("Software vertex processing not supported. Fake it and use harware one."); > warned = TRUE; Typo, should be hardware. -- -Austin

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel