- wine-devel - winehq.org

Re: [AppDB] version: Only display comments section in case version has maintainers
by Rosanne DiMesio 29 Apr '13

29 Apr '13

> > So volunteer to be a maintainer. > > > > > That is all good and well, but most of the time I check the wine page > before I buy a game. If there are no maintainers and this is active, > there will be no comments, I will be unsure about the likelihood of it > working. Reports would still be helpful, but most of the time, the > majority of the information ends up in the comments section. > All the more reason to disable comments. The information belongs in test reports. Comments get deleted periodically, test reports don't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

[AppDB]: Recent UCE/Spam waves in AppDBs comments
by Joerg Schiermeier 28 Apr '13

28 Apr '13

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

Re: winex11.drv: Fixed XInput2 errors with mislabeled mice axis.
by Dmitry Timoshkov 28 Apr '13

28 Apr '13

"Cope, Christopher Edward" <ccope3(a)utk.edu> wrote: > @@ -1638,16 +1636,14 @@ static void X11DRV_RawMotion( XGenericEventCookie *xev ) > if (XIMaskIsSet( event->valuators.mask, class->number )) > { > double val = *values++; > - if (class->label == x11drv_atom( Rel_X ) || > - (!class->label && class->number == 0 && class->mode == XIModeRelative)) > + if (class->label == x11drv_atom( Rel_X ) || class->mode == XIModeRelative) > { > input.u.mi.dx = dx = val; > if (class->min < class->max) > input.u.mi.dx = val * (virtual_screen_rect.right - virtual_screen_rect.left) > / (class->max - class->min); > } > - else if (class->label == x11drv_atom( Rel_Y ) || > - (!class->label && class->number == 1 && class->mode == XIModeRelative)) > + else if (class->label == x11drv_atom( Rel_Y ) || class->mode == XIModeRelative) > { > input.u.mi.dy = dy = val; > if (class->min < class->max) How is this supposed to distinguish motion in X and Y direction? -- Dmitry.

1 0

Re: qedit/tests: Improve test messages
by Marvin 27 Apr '13

27 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

1 0

Re: qedit/tests: Improve test messages
by Marvin 27 Apr '13

27 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

1 0

[AppDB]: Recent UCE/Spam waves in AppDBs comments
by Joerg Schiermeier 27 Apr '13

27 Apr '13

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: netapi32: Add stub for NetGetAnyDCName
by Christian Costa 27 Apr '13

27 Apr '13

Hi, + FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername), + debugstr_w(domainname), bufptr); + return ERROR_NO_SUCH_DOMAIN; +} Please use 4 spaces indentation as the rest of the file. Christian Le 27/04/2013 14:05, Ruslan Kabatsayev a écrit : > Hello, > > This patch adds a stub for netapi32!NetGetAnyDCName(), which is needed > for e.g. KDE's dolphin to launch first time. I've done it similarly to > already present NetGetDCName() stub, but with another error code > return, which is among valid ones listed in MSDN. > > Regards, > Ruslan > >

2 1

Re: user32: SetTimer should respect the minimum and maximum timeout limits (try 2).
by Alexandre Julliard 26 Apr '13

26 Apr '13

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > So, this particular patch fixes the minimum and maximum timeout limits > for SetTimer, which has a significant impact on any application using > SetTimer to render video (Bug #32489). The old minimum timeout (55 > ms) is nowhere near short enough to render video at 24 FPS, causing > "choppy" video behavior in a variety of Silverlight apps. Even though > MSDN indicates that the minimum timeout should be 10 ms, I'm using the > value established from the included tests instead (15 ms). That doesn't mean you can change the constant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt.h: Use inline function to forward hypot to _hypot.
by Alexandre Julliard 26 Apr '13

26 Apr '13

Jacek Caban <jacek(a)codeweavers.com> writes: > This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. > Previous versions had a separated library that contained forwards from > underscored functions to non-underscored, which I believe made using > hypot work. Those were currently moved directly to msvcr* import libs, > which we don't use in favour of our our own ones. Don't you need to do that for the other functions too? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Jacek Caban 26 Apr '13

26 Apr '13

Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217,6 +221,27 @@ static HRESULT to_string(VARIANT *v, BSTR *ret) > return S_OK; > } > > + > +static HRESULT banker_rounding(double dbval, int *result_val) > +{ > + double frac_part; > + double int_part; > + > + *result_val = round(dbval); This has two problems: - you don't handle values that are out of int range by assigning double value to int - round is not portable. As I mentioned you before, Wine needs to be C89 compatible. If we need some features that are not part of C89, we need to be careful about that and it often requires things like configure checks. In case of round, replacing it with floor(x+0.5) does the trick pretty well. Cheers, Jacek

2 3

Names with particles on South Africa and Namibia should be in the particle on the AUTHORS file.
by Tae Wong 26 Apr '13

26 Apr '13

You have posted a message to show how surnames with particles of South Africa and Namibia show in the credits, like van Schayck listed in S and not under V: For example, van Schayck is under S and not in V. Note that the name of the file is in all capitals. Here is a correction of the va section, with van Schyack placed on the letter by letter system. The file name is AUTHORS. It is a file in all capitals and the file content contains just the heading and some names of the developers. Note that the file is out of date. Vainer, Moshe Valoska, Hleb Valtonen, Hannu Vance, Carroll Vanek, Tomas van Schaik, Carl Vaughn, Charles

1 0

Re: [PATCH 1/2] wined3d: Set GL_NONE for glReadBuffer / glDrawBuffer on FBO initialization.
by Henri Verbeet 26 Apr '13

26 Apr '13

Seems ok, though a small comment explaining the issue this patch fixes probably wouldn't hurt. On 25 April 2013 20:43, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (target == GL_READ_FRAMEBUFFER) > + context_bind_fbo(context, GL_DRAW_FRAMEBUFFER, draw_binding ? &draw_binding : 0); > + else > + context_bind_fbo(context, GL_READ_FRAMEBUFFER, read_binding ? &read_binding : 0); > I don't think using 0 here is strictly wrong, but a proper NULL would probably be clearer. As a followup, I think we can actually get rid of the glGenFramebuffers() in context_bind_fbo() these days and just pass a GLuint instead of a pointer. The only place left that actually creates FBOs should be context_apply_fbo_entry().

2 2

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool(try 3)
by Marvin 25 Apr '13

25 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25302 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Marvin 25 Apr '13

25 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25301 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] wined3d: Add a new structure for for d3d limits and other info
by Stefan Dösinger 25 Apr '13

25 Apr '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Please ignore this patch. I figured that my series might collide with Henri's, so I canceled the send process. And indeed there are conflicts, so I'll resend my patches rebased on top of Henri's. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJReSS/AAoJEN0/YqbEcdMwElkP/AiDEqVSaMxTW+sOaQava97g a0cOBpHTU+lInUuUXIS2WVe65D+IhkdYJHnMIrSUVdquvT1x+pLVgr+2J4jczFX7 /9Ay0gAjMVbKsKIYO4tvOQgSru/RdAljTg6uaIw+qTDrHZvQLW/sJu3JcbAp0GW7 9pGEzPvRr6hNsOyXE+DQlTEsT3vkbEUTRr01j4+znF50laYV2s3e5saZHyXULyY8 ObEf3n2ppQgcO4keQg7wAPLydw+xiNcYOw9724fh/xyezj8MXoT1CDHeio7yPfhg xp76kNWzNERQcWaDT7QXwuWLRXy5H3VodWm4PEMXvqXyxkJJycm2jECvTOTjrrke iswKGqh9n0gTWQjse2eUY/fKxpjhh/ySxDcJq093swHHbvrCngL8Q5dYu/Ch3cFu JbLu4pHla3iAmJKftVTT/iRq6vwsLB7tzloCoA7e8T+GFmsA39RPFI6zttCIoA60 kui5a4Ofd6/sGMFaqg2VBK+2crGJzVzN6VRvglg63A0hNr0UGbkFC/6iQK8FzxyA A+uPGr5Xrd/vGpKZksMMH68JiK5kYXm+fsiVI1F1rcAcfdh6STQBoThcig1N/HXu fA8daluv4+PgQ9RhgzlioBsVFGxkZ1FbM8XjKlcnKQb0ZK3DXLHLEzspvmBnr3Pi MK94F9BvqMDa6Wi57sgT =Wh/i -----END PGP SIGNATURE-----

1 0

Re: [0/4] Improve wineconsole and kernel32
by Frédéric Delanoy 25 Apr '13

25 Apr '13

On Wed, Apr 24, 2013 at 9:15 AM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This series of four patches will improve various three functions in > kernel32: > > * GetConsoleFontSize > * GetCurrentConsoleFont > * GetLargestConsoleWindowSize > > This is achieved by moving logical calculations to wineconsole itself. > kernel32.dll only receives the final values. > > The first and second patches should be applied to source before compiling > Wine. If this is not done, the compiler will exit with errors. (The first > is a patch for server/protocol.def and requires tools/make_requests to be > run). > After each patch, Wine should be able to compile correctly (e.g. for regression testing) If not, you should split your patches differently IMO. Frédéric

2 1

Wine Gecko 2.21-beta1
by Jacek Caban 25 Apr '13

25 Apr '13

Hi all, As some of you might have noticed, the final Wine Gecko 2.20 was never been released, although it was scheduled for about three weeks ago. This is mostly due to my lack of time, combined with the fact that part of that time I was busy with some Gecko work that would be nice to have in Wine. Being 3 weeks late means that we also have 3 weeks until the next Firefox release, so we may just wait a bit longer and do another release based on newer upstream code base. This way I may use the new beta to include some of the changes that I did lately, which would be too risky to go straight to release. Those new improvements contain, among others, a fix for Adobe CS4 products installers. In this beta, the testing is easier than ever. Our auto installer knows about the beta which, combined with the fact that we cache downloaded packages now, means that the attached Wine patch is all you need to comfortably test the new package. Just apply the patch you the Wine tree and everything should work. All tests are appreciated. Thanks, Jacek

1 0

Re: [PATCH 2/5] wined3d: Introduce a wined3d_vertex_pipe_ops structure.
by Rico Schüller 25 Apr '13

25 Apr '13

On 25.04.2013 09:59, Henri Verbeet wrote: > -static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct fragment_pipeline *fragment_pipe) > +static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct wined3d_vertex_pipe_ops *vertex_pipe, > + const struct fragment_pipeline *fragment_pipe) > { > struct shader_arb_priv *priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*priv)); > struct fragment_caps fragment_caps; > - void *fragment_priv; > + void *vertex_priv, *fragment_priv; > + > + if (!(vertex_priv = vertex_pipe->vp_alloc(&arb_program_shader_backend, priv))) > + { > + ERR("Failed to initialize vertex pipe.\n"); > + HeapFree(GetProcessHeap(), 0, priv); > + return E_FAIL; > + } > > if (!(fragment_priv = fragment_pipe->alloc_private(&arb_program_shader_backend, priv))) > { > ERR("Failed to initialize fragment pipe.\n"); > + fragment_pipe->free_private(device); Shouldn't that vertex_pipe->vp_free(device)? > HeapFree(GetProcessHeap(), 0, priv); > return E_FAIL; > }

2 1

Clang static analyzer results / wine-1.5.28-66-g6899279
by Austin English 25 Apr '13

25 Apr '13

With wine-1.5.20 and clang 3.2, the test suite is in the same state on my Fedora 18 machine as gcc-4.7.2 llvm version: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@17976891177308-0d34-0410-b5e6-… clang version: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@17977191177308-0d34-0410-b5e6-9… ./configure --disable-tests was used to reduce noise [austin@localhost ~]$ sha1sum scan-build-2013-04-18-2.tar.bz2 51e28c96a04ebe9ef937678149f9e7e3ed4cb20f scan-build-2013-04-18-2.tar.bz2 [austin@localhost ~]$ du -h scan-build-2013-04-18-2.tar.bz2 35M scan-build-2013-04-18-2.tar.bz2 http://www.mediafire.com/?xwb05d6er0aclfe -- -Austin

5 7

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)
by Sam Edwards 24 Apr '13

24 Apr '13

This series has been waiting in the queue for a few days now. Does this need further discussion, or can it be committed? Thanks, Sam On 04/20/2013 08:08 AM, Sam Edwards wrote: >

1 0

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)
by Christian Costa 24 Apr '13

24 Apr '13

2013/4/24 James Eder <jimportal(a)gmail.com> > This version should either pass or skip on W2KPROSP4. > --- > dlls/kernel32/cpu.c | 23 ++++++++++++++++++----- > dlls/psapi/tests/psapi_main.c | 36 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+), 5 deletions(-) > > diff --git a/dlls/kernel32/cpu.c b/dlls/kernel32/cpu.c > index 0ebf8f3..124e5c0 100644 > --- a/dlls/kernel32/cpu.c > +++ b/dlls/kernel32/cpu.c > @@ -216,16 +216,29 @@ BOOL WINAPI IsProcessorFeaturePresent ( > */ > BOOL WINAPI K32GetPerformanceInfo(PPERFORMANCE_INFORMATION info, DWORD > size) > { > - NTSTATUS status; > + MEMORYSTATUSEX mem_status; > > TRACE( "(%p, %d)\n", info, size ); > > - status = NtQuerySystemInformation( SystemPerformanceInformation, > info, size, NULL ); > - > - if (status) > + if(size < sizeof(PERFORMANCE_INFORMATION)) > { > - SetLastError( RtlNtStatusToDosError( status ) ); > + SetLastError(ERROR_BAD_LENGTH); > return FALSE; > } > + > + mem_status.dwLength = sizeof(mem_status); > + if (!GlobalMemoryStatusEx( &mem_status )) > + return FALSE; > + > + memset(info, 0, sizeof(PERFORMANCE_INFORMATION)); > + > + info->cb = sizeof(PERFORMANCE_INFORMATION); > + info->CommitLimit = min((mem_status.ullTotalPageFile / > system_info.PageSize), MAXDWORD); > + info->PhysicalTotal = min((mem_status.ullTotalPhys / > system_info.PageSize), MAXDWORD); > + info->PhysicalAvailable = min((mem_status.ullAvailPhys / > system_info.PageSize), MAXDWORD); > + info->PageSize = system_info.PageSize; > + > + FIXME("stub\n"); > + > Hi James, That would be better to change the trace at the beginning by FIXME( "(%p, %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): partial stub\n", info, size ); instead of adding another fixme (which is not really correct since it's not a stub). Christian

2 3

Re: msvcr110.dll: add a stub for crtGetShowWindowMode (try 2)
by Alexandre Julliard 24 Apr '13

24 Apr '13

Austin English <austinenglish(a)gmail.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=33195 > > try 2: return SW_SHOWWINDOW instead of SW_HIDE It's not much harder to return the correct value. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] shell32: Add a semi-stub for SHGetStockIconInfo
by Nikolay Sivov 24 Apr '13

24 Apr '13

On Wed, Apr 24, 2013 at 6:38 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > -- > By by ... Detlef > --- > dlls/shell32/iconcache.c | 42 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/shell32/shell32.spec | 1 + > 2 files changed, 43 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c > index 637dbca..df6675d 100644 > --- a/dlls/shell32/iconcache.c > +++ b/dlls/shell32/iconcache.c > @@ -46,6 +46,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(shell); > > +static const WCHAR shell32dll[] = > {'\\','s','h','e','l','l','3','2','.','d','l','l',0}; > + > Please put this in function that needs it.

1 0

Re: [PATCH 4/5] d3d9/tests: Don't test for equality in d3d9's depth_blit_test
by Henri Verbeet 24 Apr '13

24 Apr '13

On 24 April 2013 11:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This makes the test pass on nv40 GPUs on Linux. I'm not sure if testing > equality was intentional or an accident, if it was intentional please > ignore this patch. > I don't quite remember, but probably not. Arguably the nicer way to fix it is to change the z-value for quad1 to 0.33f though.

1 0

Re: oledb32: Implement DataConvert DBTYPE_BOOL->VARIANT
by Jacek Caban 24 Apr '13

24 Apr '13

On 04/24/13 10:41, Alistair Leslie-Hughes wrote: > + case DBTYPE_BOOL: > + V_VT(v) = VT_BOOL; > + V_BOOL(v) = *(BOOL*)src; You're mixing BOOL and VARIANT_BOOL here. This can't work, they even have a different size. From your test I guess that you meant to cast src to VARIANT_BOOL*. Cheers, Jacek

1 0

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo
by Marvin 24 Apr '13

24 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25251 Your paranoid android. === W2KPROSP4 (32 bit psapi_main) === psapi_main.c:76: Test failed: GetProcAddress(GetPerformanceInfo) failed

1 0

Application for GSoC 2013 - improve Richedit
by Jactry Zeng 23 Apr '13

23 Apr '13

Hi folks, I am Jactry Zeng, a sophomore majoring in Electronic Science from China. My nickname in #winehackers is Jactry. I would like to apply for this year's GSoC to work for wine. I have reported some bugs[1] of wine and submitted a few easy patches[2] for wine. And I feel quite good to study in wine community. I am so interested in Richedit module[3]. Because a lot of software I tested was blocked by bugs of Richedit, such as wordpad, GTalk, QQ, Weibo Desktop and AliWangwang etc. I would like to work for this module during GSoC. I've reported a few bugs regarding Richedit[4]. And for bug 33191[5], I have written a simple testcase to reproduce this bug. And I found ITextDocument is just a stub now, I want to implement some function of it, such as ITextDocument::New, ITextDocument::Open, ITextDocument::Save, ITextDocument::Range, ITextDocument ::GetName and ITextDocument::GetDefaultTabStop etc. These functions are documented in MSDN[6], what's better, thanks to kind people on codeproject[7], there are some sample applications for study, which will give me a lot of help on re-implementing ITextDocument. I think if I can finish this work, there are a lot of software will benefit from it[8]. I appreciate for any comment. Thank you. :-) [1] http://bugs.winehq.org/buglist.cgi?email1=jactry92%40gmail.com&emailtype1=e… [2]http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Jactry [3] http://bugs.winehq.org/buglist.cgi?cmdtype=runnamed&namedcmd=richedit&list_… [4]bug of Richedit I reported: http://bugs.winehq.org/buglist.cgi?emailreporter1=1&emailtype1=exact&query_… [5]bug 33191: http://bugs.winehq.org/show_bug.cgi?id=33191 [6]http://social.msdn.microsoft.com/Search/en-US?query=ITextDocument&ac=4 [7]http://www.codeproject.com/search.aspx?q=ITextDocument&x=0&y=0&sbo=kw [8]bug of ITextDocument: http://bugs.winehq.org/buglist.cgi?quicksearch=ITextDocument&list_id=104255 -- Regards, Jactry Zeng

2 2

Re: [PATCH 3/3] mshtml: Support IObjectIdentity interface in HTMLWindow object
by Marvin 23 Apr '13

23 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25244 Your paranoid android. === WXPPROSP2 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (64 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 Timeout

1 0

Re: [PATCH 2/3] mshtml: Added IOmHistory::get_length test
by Marvin 23 Apr '13

23 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25243 Your paranoid android. === WXPX64 (32 bit htmldoc) === htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call

1 0

Re: oledb32: Implement GetConversionSize DBTYPE_STR->DBTYPE_WSTR
by Marvin 23 Apr '13

23 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25234 Your paranoid android. === W2KPROSP4 (32 bit convert) === convert.c:2537: Test failed: 12

1 0

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Ken Thomases 23 Apr '13

23 Apr '13

On Apr 22, 2013, at 6:40 PM, Sam Edwards wrote: > On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote: >> As I understand it, some fonts deliberately have glyphs larger than >> their metrics bounding boxes. Clipping them is almost certainly not a >> good idea. > > Forgive my disbelief, but can you provide an example? It seems like Windows has the same clipping behavior (see my test http://source.winehq.org/patches/data/95792). > > From my understanding, the intent of the ascent metric is that it indicates the maximum ascender on any glyph in the font (and likewise for descent), so the only real reason for the ascent/descent metrics to be wrong is if the font designer made a mistake. (And some tools, like FontForge, will automatically set the ascent/descent metrics correctly for you on export.) > > I can't think of any reason why a font author would want to create a font with an invalid ascent/descent metric. I can't speak to how Windows would render it, but one such font is Zapfino. It's an "exuberant" calligraphic font with lots of flourishes, some of which have strokes extending into the line above or below. http://en.wikipedia.org/wiki/Zapfino https://www.google.com/images?q=zapfino -Ken

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory. (try 2)
by Rico Schüller 23 Apr '13

23 Apr '13

On 22.04.2013 23:08, Christian Costa wrote: > +typedef struct { > + DWORD bc2Size; > + DWORD bc2Width; > + DWORD bc2Height; > + WORD bc2Planes; > + WORD bc2BitCount; > + DWORD bc2Compression; > + DWORD bc2SizeImage; > + DWORD bc2XRes; > + DWORD bc2YRes; > + DWORD bc2ClrUsed; > + DWORD bc2ClrImportant; > + /* same as BITMAPINFOHEADER until this point */ > + WORD bc2ResUnit; > + WORD bc2Reserved; > + WORD bc2Orientation; > + WORD bc2Halftoning; > + DWORD bc2HalftoneSize1; > + DWORD bc2HalftoneSize2; > + DWORD bc2ColorSpace; > + DWORD bc2AppData; > +} BITMAPCOREHEADER2; Do we really need a typedef here? For only locally used structs, I think we shouldn't use a typedef. Also the struct is only used to determine the size and for nothing else? There may be a better way to do that... Maybe something like in dlls/windowscodecs/icoformat.c ? I think you got inspired by dlls/windowscodecs/bmpdecode.c, there is the same issue. Why do we need a typedef, if we only use it in one file to calculate the size? > > + BITMAPFILEHEADER *header; > > + if ((header_size == sizeof(BITMAPINFOHEADER)) || > + (header_size == sizeof(BITMAPV4HEADER)) || > + (header_size == sizeof(BITMAPV5HEADER)) || > + (header_size == sizeof(BITMAPCOREHEADER2))) > + { > + /* All structures have the same memory layout as BITMAPINFOHEADER */ > + BITMAPINFOHEADER*header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > > + else if (header_size == sizeof(BITMAPCOREHEADER)) > + { > + BITMAPCOREHEADER*header = (BITMAPCOREHEADER*)*data; I don't think it's a good idea to use variable names multiple times. While this works fine it may be a bit confusing... Cheers Rico

2 1

d3dx9: Implement D3DXSHMultilpy5
by Nozomi Kodama 23 Apr '13

23 Apr '13

Is there a problem with this patch? http://source.winehq.org/patches/data/95555 Nozomi

4 8

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Dmitry Timoshkov 23 Apr '13

23 Apr '13

Sam Edwards <cfsworks(a)gmail.com> wrote: > This change only affects malformed fonts that have glyphs with splines > that go above the maximum ascent as specified in the font's hhea/os2 > table. For that reason, any tests for this change would have to include > a malformed font, so I did not write tests. If we want in-tree tests, > we'll need to figure out how to include a malformed font to test against. Please add a test case, Wine test suite already includes custom fonts, you can either use an existing font, or add a new one. -- Dmitry.

3 2

kernel32/path: Potential off-by-one error, help needed!
by Kirill Smirnov 23 Apr '13

23 Apr '13

Hi! While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. Unfortunately, I'm not familiar with this part of wine and I don't know how to write corresponding test case. If you familiar with this module, please, take a look at this wanna-be-a-bug and the proposed patch. -- Kirill

2 1

Re: user32: add assembly wrapper for calling hook procedures.
by James Eder 23 Apr '13

23 Apr '13

Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

2 1

Wine History
by André Hentschel 22 Apr '13

22 Apr '13

Hi, meanwhile everyone should know that Wine turns 20 this year. AJ said in this years Keynote we'll need to find a way to celebrate this in June. So i did some research on this and found "Wine History" mails by Dan Kegel from 2002 and much earlier Bob Amstadt talking about late May or early June 1993. The date listed on Wikipedia is July the 4th, but i was still curious about that late May. I think i finally found this late May (30th) discussion and want to share it: https://groups.google.com/d/msg/comp.os.linux/7TFhxP6IUVQ/gVHAeP_ZBVUJ It's of course hard to tell when a project was really born, but as far as i understand, this discussion inspired Bob to write an initial loader. I was just 5 at this time, so maybe someone can tell some more about it? :) Some more Links: http://en.wikipedia.org/wiki/Wine_%28software%29 http://www.winehq.org/pipermail/wine-devel/2002-November/010567.html http://www.winehq.org/pipermail/wine-devel/2002-November/010603.html https://groups.google.com/d/msg/comp.os.linux/RKpNL1M8vSE/Z-rgUyrSFlYJ https://groups.google.com/d/msg/comp.os.linux/mb1BwP7LckY/IV44zjGkO98J http://www.linuxjournal.com/article/2757 and of course http://wiki.winehq.org/WineHistory Ok, i somehow lost the mentioning of "late may", but it's already quite late here, sry.

2 1

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()
by Qian Hong 22 Apr '13

22 Apr '13

Hi Dan, Thanks for working on it! It is really an annoying bug, however, is adding DECLSPEC_NOINLINE a workaround or a real fix? If it is only a workaround, would that hide some real bug behind it? Or is that possible that there is a gcc bug here that we want to report to gcc? Thanks for your time!

4 7

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation
by Henri Verbeet 22 Apr '13

22 Apr '13

On 21 April 2013 16:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (texture && texture->target == GL_TEXTURE_RECTANGLE_ARB) > - sample_flags |= WINED3D_GLSL_SAMPLE_RECT; > + if (priv->cur_ps_args->np2_fixup & (1 << sampler_idx)) > + { > + sample_flags |= WINED3D_GLSL_SAMPLE_NPOT; > + } I don't think the added braces are an improvement, but otherwise this looks ok.

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.
by Alexandre Julliard 22 Apr '13

22 Apr '13

Christian Costa <titan.costa(a)gmail.com> writes: > + if (header_size == sizeof(BITMAPINFOHEADER)) > + { > + BITMAPINFOHEADER *header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > + > + if (!count && header->biBitCount <= 8) > + count = 1 << header->biBitCount; > + > + offset = sizeof(BITMAPFILEHEADER) + header_size + sizeof(RGBQUAD) * count; This isn't correct for all DIB types. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] extrac32: Add /D switch support.
by Alexandre Julliard 22 Apr '13

22 Apr '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -202,6 +228,9 @@ int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int sho > WCHAR path[MAX_PATH]; > LPCWSTR cabfile = NULL; > > + extr_printf = (void*)GetProcAddress(LoadLibraryA("msvcrt"), "printf"); > + if(!extr_printf) > + return 1; Mixing C runtimes is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)
by Vincent Povirk 22 Apr '13

22 Apr '13

Dealing with the bits of a floating point number directly is a bit odd, and it makes it hard to review the code. Is there a reason you don't want to use things like modf, floor, and ceil?

2 3

re: Google Summer of Code 2013
by Dan Kegel 20 Apr '13

20 Apr '13

Hi Anulesh, improving wine's support of cygwin is a toughie. ( I gave http://bugs.winehq.org/show_bug.cgi?id=15679 the old college try, but failed. ) You should probably be more specific about what you have in mind. - Dan

1 0

re: Willing to work on CMD - implement more robust parser
by Dan Kegel 20 Apr '13

20 Apr '13

Hi Gaurab! Glad to hear you're interested in wine, and in cmd. You might start by reading previous discussion on the topic, e.g. the full thread following http://www.winehq.org/pipermail/wine-devel/2009-December/080643.html and http://kegel.com/wine/sweng/2010/ Two tips that might help smooth your way: There is a lot of bison in wine already, so using bison might be the path of least resistance. Switching just one command to bison, while leaving the rest using the existing code, would likely be much easier to get committed than a big patch that changed lots of things. Good luck! - Dan

1 0

Willing to work on CMD - implement more robust parser
by Gaurab Patra 20 Apr '13

20 Apr '13

Respected sir/madam, Through this mail I'd like to inform you that I am a Computer Science student at Bengal Engineering and Science University, Shibpur (India) in my 3rd year of undergraduate studies. I have gone through the project CMD - implement more robust parser and would like to work on this project this summer. As it is mentioned in the required skill set I am quite proficient in C, CMD commands, datastructure and algorithm etc. I'm attaching my resume with this mail. If you want to give me the opportunity to work on this please reply with some necessary resources and guide me with more information on this. Thank you GaurabPatraResume(1).pdf<https://docs.google.com/file/d/0B99XscJv40waenczeWh3ZVNkVlk/edit?usp=drive_…> Gaurab Patra 3rd yr Computer Science BESU, Shibpur

1 0

Re: oledb32: Implement GetConversionSize DBTYPE_WSTR->DBTYPE_WSTR
by Nikolay Sivov 20 Apr '13

20 Apr '13

On 4/20/2013 13:43, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > oledb32: Implement GetConversionSize DBTYPE_WSTR->DBTYPE_WSTR > > > Best Regards > Alistair Leslie-Hughes Please add a test when caller supplies source length, at least one case is interesting - supplied length is less than lstrlenW result. Another case would be embedded nulls and source length larger than null terminated length.

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool(try 2)
by Marvin 20 Apr '13

20 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25206 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)
by Marvin 20 Apr '13

20 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25204 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] wined3d: Use ARB_internalformat_query2 to check for texture format rendering and blending support, where available.
by Henri Verbeet 19 Apr '13

19 Apr '13

On 18 April 2013 21:19, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (!format->glInternal) continue; > + > + gl_info->gl_ops.ext.p_glGetInternalformativ(GL_TEXTURE_2D, format->glInternal, > + GL_FRAMEBUFFER_RENDERABLE, 1, &value); > + if (value == GL_FULL_SUPPORT) > + { > + TRACE("Format %s is supported as FBO color attachment.\n", debug_d3dformat(format->id)); > + format->flags |= WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FBO_ATTACHABLE; > + format->rtInternal = format->glInternal; > + > + if (!(format->flags & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + query_format_flag(gl_info, format, format->glInternal, GL_FRAMEBUFFER_BLEND, > + WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING, "post-pixelshader blending"); > + } This may be a bit dangerous, since you're now potentially adding WINED3DFMT_FLAG_RENDERTARGET for formats like e.g. WINED3DFMT_R8G8B8A8_SNORM that didn't previously had it, and where it's a bit questionable if it's really going to work as intended. Also, the depth/stencil check that follows is either redundant, or we're now also potentially setting WINED3DFMT_FLAG_RENDERTARGET for depth/stencil formats. At least initially we'll probably want to stick with formats that already have WINED3DFMT_FLAG_RENDERTARGET set, and only clear it if unsupported. At a later point we may want to do something more centered around the information we get from internalformat_query2, but I suspect it will be a bit harder than just checking if there's no fixup, no conversion function, etc.

2 1

Re: [PATCH 2/7] wined3d: Store vs_clipping in the adapter
by Henri Verbeet 19 Apr '13

19 Apr '13

On 19 April 2013 11:20, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Potential alternatives include keeping the status quo or introducing a > separate structure that holds these derived limits that is owned by the > device and linked in the contexts. We could also put it into gl_info, > but I dislike this idea because these limits are not GL limits, but > limits of our shader and fixed function pipeline implementations. I think we'll want a separate structure for this. Note that you essentially have two different kinds of data you're concerned with here though. One is derived state like e.g. the texture unit map, the stream info, or the view_indent from patch 1/7. We don't really want that in wined3d_state, because there's no reason for e.g. every stateblock to have a copy of that. Having the derived state structure be owned by the device is probably ok, although there may also be something to be said for making it part of the context instead. The other type of data is immutable data like derived caps and limits, as in this patch and following ones. In principle the adapter is the right place for that, but I do think we want a separate structure for that, and probably a pointer to it in the context, for similar reasons as having one to gl_info. Arguably things like the state table, format info and the shader backend would belong in the same structure. I.e., essentially we'd have a setup like wined3d_gl_info, but for more wined3d specific / derived info.

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel