- wine-devel - winehq.org

Re: [PATCH 3/7] wined3d: Use ARB_internalformat_query2 for the other texture format caps too.
by Henri Verbeet 19 Apr '13

19 Apr '13

On 18 April 2013 21:20, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + /* FIXME: We can't handle "partial" sRGB decode support right now, we could > + * introduce a new format flag and check for that. */ As mentioned on IRC, I don't think this is really an issue. The patch looks otherwise ok.

1 0

Re: [PATCH 1/3] msvcrt: Added _mbsncoll and _mbsncoll_l implementation.
by Akihiro Sagawa 19 Apr '13

19 Apr '13

On Fri, 19 Apr 2013 14:42:50 +0800, Jactry Zeng wrote: > +/********************************************************************* > + * _mbsncoll_l(MSVCRT.@) > + */ > +int CDECL _mbsncoll_l(const unsigned char *str1, const unsigned char *str2, MSVCRT_size_t count, > + MSVCRT__locale_t locale) > +{ > + return _mbsnbcoll_l(str1, str2, count, locale); > +} According to MSDN, _mbsncoll_l receives a number of characters, but _mbsnbcoll_l receives a number of bytes. This is a big difference in multibyte code page. So you should properly handle this situation, or add FIXME message based on multibyte code page if your application just needs this function. Regards, Akihiro Sagawa

2 1

Google Summer of Code 2013
by Anulesh Tiwari 19 Apr '13

19 Apr '13

Sir, I will be applying for GSoC 2013 under your mentoring team. Sorry for contacting very late with you as I was not aware of this program. I came to know yesterday that Gsoc is going to start. As a CS student and I have a well understanding of C C++ and Java and Data structures I am always very keenly interested in programming and coding. I devote my daily 8 hrs to it. As a potential linux user I have chosen Ideas from your list Cygwin Improvement I wish to apply on this topic and devote my each and every day of this summer to help my friends and colleagues to run Wine without bugs. Well one more thing to say Sir please give more Information and details what I have to do to assure my project to be done. Regards Anulesh Tiwari Bachelor of Science Department of Computer Science BHU INDIA

1 0

Fun with GCC 4.8
by James Eder 18 Apr '13

18 Apr '13

As many of you no doubt know, GCC recently released 4.8.0. This new version introduces a new optimization level enabled by -Og with the following description (from the man page): "Optimize debugging experience. -Og enables optimizations that do not interfere with debugging. It should be the optimization level of choice for the standard edit-compile-debug cycle, offering a reasonable level of optimization while maintaining fast compilation and a good debugging experience." Of course I had to try it out. I found that building Wine lead to GCC dieing with ... dlls/kernel32/console.c:1691:1: internal compiler error: Segmentation fault I also found ... dlls/kernel32/computername.c:701:1: internal compiler error: Segmentation fault I eventually stumbled my way into the enclosed patch which lets GCC build Wine with -Og. I'm not sure if this change (or something similar) makes sense for Wine. I'm fairly certain some changes make sense for GCC (I suspect that GCC should not segfault). I haven't submitted a bug for GCC because I suspect they'll want me to provide something simpler to compile than the Wine source tree. I certainly won't be upset if someone beats me too it. I'm not sure how much time in the near future I'll spend on it. "Eventually" is probably the word that fits. At any rate, I wanted to at least share my experiences in case anyone is interested in heading down the same path. -- Jim

3 3

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications
by Alexandre Julliard 18 Apr '13

18 Apr '13

Simon Lipp <sloonz(a)gmail.com> writes: > @@ -389,6 +389,10 @@ static int process_events( Display *display, Bool (*filter)(Display*, XEvent*,XP > count++; > if (XFilterEvent( &event, None )) > { > + KeySym keysym = 0; > + XLookupString(&event.xkey, NULL, 0, &keysym, NULL); > + BOOL is_dead = (keysym >= XK_dead_grave && keysym <=XK_dead_semivoiced_sound); You can't assume that you have a key event here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32/tests: Use if(0) instead of #if 0 to make sure the code still compiles.
by Marvin 18 Apr '13

18 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25164 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

testbot: Default set of VMs to run the tests
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

Hi all, recently the set of VMs suggested to run the tests on by default has changed. It no more includes NT4, XP and Vista (although it does include win2000), 32-bit VMs for NT4, XP and Vista don't even exist in the list of available VMs (64-bit XP and Vista do exist, but for some reason are not used). Is there a reason for that? -- Dmitry.

2 5

Re: GetKeyboardState problems in Age of Empires II
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

[please don't omit wine-devel when replying] Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > > Another (minor) problem raised in the bugzilla entry is that, if a > > > key is pressed when changing window, and released before returning, > > > GetKeyboardState() will claim the key is still pressed (0x80). But > > > this is easy to workaround, just hit the key again inside the game > > > and it will stop scrolling. > > > > dlls/winex11.drv/keyboard.c,X11DRV_KeymapNotify() should take care of > > that, if it doesn't - please debug why (probably a bug in your WM). > > I think this function only applies to "modifier keys". It was tested > with arrow keys. It should work for all keys. > Anyway I don't think it's a big issue, since it doesn't cause > any big problem, and it doesn't happen very often. It was just a > situation where Windows and Wine exhibited slightly different behavior. > > The first bug is much more annoying since one has to completely exit > the game each time. My comment was targeting both problems that you mentioned. -- Dmitry.

2 2

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Jacek Caban 18 Apr '13

18 Apr '13

On 04/17/13 18:18, larmbr zhan wrote: > + double tmp; > + WCHAR trueW[] = {'T','r','u','e','\0'}; > + WCHAR falseW[] = {'F','a','l','s','e','\0'}; > + > + TRACE("%s\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + switch(V_VT(arg)) { > + case VT_I2: > + tmp = V_I2(arg); > + break; > + case VT_I4: > + tmp = V_I4(arg); > + break; I don't think converting to double is a good idea here. Why don't you do conversions directly to BOOL for all cases? > + case VT_R4: > + tmp = V_R4(arg); > + break; > + case VT_R8: > + tmp = V_R8(arg); > + break; > + default: > + ERR("Not a numeric vaule: %s\n", debugstr_variant(arg)); > + return E_FAIL; > + } > + > + if (tmp < 0.0 || tmp > 0.0) > + str = SysAllocString(trueW); > + else > + str = SysAllocString(falseW); > + > + > + return return_bstr(res, str); Are you sure you want to return string type here? I'd expect a bool value (of type VT_BOOL) here... > } > > static HRESULT Global_CByte(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs > index 6bd4065..9b25e87 100644 > --- a/dlls/vbscript/tests/api.vbs > +++ b/dlls/vbscript/tests/api.vbs > @@ -442,4 +442,9 @@ Call ok(CInt(36.50) = 36, "CInt(36.50) = " & CInt(36.50)) > Call ok(CInt(36.75) = 37, "CInt(36.75) = " & CInt(36.75)) > Call ok(CInt(300) = 300, "CInt(300) = " & CInt(300)) > Call ok(CInt(-300) = -300, "CInt(-300) = " & CInt(-300)) > + > +Call ok(CBool(5) = "True", "CBool(5) = " & CBool(5)) > +Call ok(CBool(0) = "False", "CBool(0) = " & CBool(0)) > +Call ok(CBool(-5) = "True", "CBool(-5) = " & CBool(-5)) ...and that's why getVT(...) test would be nice here. Thanks, Jacek

2 1

Application for GSoC 2013
by larmbr zhan 18 Apr '13

18 Apr '13

Hi all, I'm a junior student from a non-famous college, I apply to parcitipate in GSoC , to help do some vbscript module implementation. I've just submitted a patchset on this. Thanks. -- Regards, Zhan Jianyu

3 4

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Jacek Caban 18 Apr '13

18 Apr '13

On 04/17/13 18:17, larmbr zhan wrote: > +static HRESULT to_int_banker_rounding(VARIANT *v, int *ret) > +{ I wonder if this conversion is used in any other place as well. I think this does not need a helper function until we find other use cases as well, esp. since you could simplify that to: if(V_VT(v) == VT_R8) { //... your conversion }else { hres = to_int(v); } + case VT_R8: { + double n = rint(V_R8(v)); rint is not portable. Please avoid using it. @@ -424,4 +424,22 @@ Call ok(getVT(vbYes) = "VT_I2", "getVT(vbYes) = " & getVT(vbYes)) Call ok(vbNo = 7, "vbNo = " & vbNo) Call ok(getVT(vbNo) = "VT_I2", "getVT(vbNo) = " & getVT(vbNo)) +Call ok(CInt(-36.75) = -37, "CInt(-36.75) = " & CInt(-36.75)) +Call ok(CInt(-36.50) = -36, "CInt(-36.50) = " & CInt(-36.50)) +Call ok(CInt(-36.25) = -36, "CInt(-36.25) = " & CInt(-36.25)) Please add some tests using getVT to verify underlying types. Thanks, Jacek

1 0

Re: [2/3] mountmgr.sys: Remove an artificial limitation for removable drive letters.
by Alexandre Julliard 18 Apr '13

18 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Under Windows removable drives (USB sticks) can have drive letters such > as J: or K:. They are not considered floppy devices though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] kernel32: Count precise amount of child process failures.
by Marvin 18 Apr '13

18 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25160 Your paranoid android. === W2K8SE (32 bit loader) === lloader.c:1686: Test failed: expected exit code 0, got 196

2 1

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 3)
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

Austin English <austinenglish(a)gmail.com> wrote: > +LPTOP_LEVEL_EXCEPTION_FILTER MSVCR110__crtSetUnhandledExceptionFilter(LPTOP_LEVEL_EXCEPTION_FILTER filter) > +{ > + return SetUnhandledExceptionFilter(filter); > +} msvcrt APIs need an explicit calling convention specifier. -- Dmitry.

2 1

GetKeyboardState problems in Age of Empires II
by Stevie Trujillo 18 Apr '13

18 Apr '13

"Age of Empires II scrolling gets stuck after Alt-Tab away and back" ( http://bugs.winehq.org/show_bug.cgi?id=30814 ) has been debugged now. The problem is that GetKeyboardState starts returning 0x40 after changing window. Documentation seems to only define LSB and MSB ( http://msdn.microsoft.com/en-us/library/windows/desktop/ms646299(v=vs.85).a… ). This leads Age of Empires II to believe that all keys are pressed after changing window, making it scroll unstoppably. Should this be fixed by removing extra bits in GetKeyboardState like in the bugzilla entry, or should it be fixed in wineserver? Also does the similar functions GetAsyncKeyboardState() and GetKeyState() need fixing? Another (minor) problem raised in the bugzilla entry is that, if a key is pressed when changing window, and released before returning, GetKeyboardState() will claim the key is still pressed (0x80). But this is easy to workaround, just hit the key again inside the game and it will stop scrolling.

2 1

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

larmbr zhan <nasa4836(a)gmail.com> wrote: > + case VT_BOOL: > + *ret = V_BOOL(v) ? -1 : 0; > + break; Shouldn't this be VARIANT_TRUE/VARIANT_FALSE instead of -1/0? -- Dmitry.

1 0

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Marvin 17 Apr '13

17 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25139 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Marvin 17 Apr '13

17 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25138 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/5] wined3d: Enable GL_ARB_texture_rectangle in GLSL ffp fragment shaders
by Henri Verbeet 16 Apr '13

16 Apr '13

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (gl_info->supported[ARB_TEXTURE_RECTANGLE]) > + shader_addline(buffer, "#extension GL_ARB_texture_rectangle : enable\n"); > + This may be a good idea anyway, but is this strictly required? IIRC ARB_texture_rectangle is the one special extension that's always implicitly enabled in GLSL if it's supported.

2 2

Re: [PATCH 2/5] d3d9/tests: Test NPOT texture creation
by Henri Verbeet 16 Apr '13

16 Apr '13

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - * Copyright (C) 2006 Chris Robinson > + * Copyright (C) 2006 Chris Robinsontes This looks unintentional. > + UINT refcount; Technically refcounts are ULONGs, although I suppose it doesn't matter a whole lot.

1 0

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications
by Dmitry Timoshkov 16 Apr '13

16 Apr '13

Simon Lipp <sloonz(a)gmail.com> wrote: > + * Moreover, let dead chars be processed or we will never have > + * WM_DEADCHAR events That's how it's supposed to work. Wine should never generate WM_DEADCHAR message, it relies in the driver to handle dead keys and generate final events. X11 even has an ability to support user defined key sequences which are handled by XFilterEvent and which will be broken by your patch. -- Dmitry.

3 4

Re: kernel32: Add a test to check event and mutex states during process termination.
by Alexandre Julliard 16 Apr '13

16 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/loader.c | 40 +++++++++++++++++++++++++++++++++------- > 1 file changed, 33 insertions(+), 7 deletions(-) That's not a very meaningful test if nobody holds the mutex. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin 16 Apr '13

16 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25096 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: [PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin 16 Apr '13

16 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25086 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21 === WVISTAX64 (64 bit webbrowser) === webbrowser.c:978: Test failed: unexpected dispIdMember 271 webbrowser.c:1604: Test failed: unexpected call TranslateUrl webbrowser.c:454: Test failed: unexpected nCmdID 14 Timeout

2 1

Re: [PATCH 5/6] ieframe: Return document as IHTMLDocument2 iface from get_document.
by Marvin 15 Apr '13

15 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25085 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3060: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: [PATCH 1/1] d3d8: Don't assert on invalid IDirect3DBaseTexture8 interfaces.
by Stefan Dösinger 15 Apr '13

15 Apr '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-04-14 16:53, schrieb Rico Schüller: > + if (iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DTexture8_Vtbl + && iface->lpVtbl != (const > IDirect3DBaseTexture8Vtbl *)&Direct3DCubeTexture8_Vtbl + > && iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DVolumeTexture8_Vtbl) + { + WARN("%p is not a > valid IDirect3DBaseTexture8 interface.\n", iface); + return > NULL; + } A test would be a good idea. Are you sure that the assert is the actual problem, and not some memory corruption that changes the vtable poiner? What does e.g. GetTexture do after a bogous SetTexture call? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRa7lTAAoJEN0/YqbEcdMwNjEP/RLeLk3+009+Cp2n5sWOUprn Z5ED8iL3RXRjsCJNU5Fi2JIkCcVRmdkkn2RTBN9Q9KEkUL0qjg6B7Admy5sWtMIk LDtYpjS6BeDIJm8e0D0HwGItv2ekxW37ggg9fsArcXUO/lKf2GrJmUiyAjQfzmT9 IDlewcLSzUiAdbzZ4WUZzkqIa9lQgDpZBAvOgvgqhY2suf+YpJi6oTMfgwzpiSyB L2mlXx4cb0/hYaPAdWZUbc9uHvsCQ5ZwE4EhIxWpMlZM8FENMN3Gc0vrpzWAXoBo XRifoh3n0VKaYyZ+Wi+zGRaFX40P4ouBUKuFcBdjEPq6Fhz46GEGY8KFf1MVZKwM 7pzkhv6yc8/GTr2q5wthhmnZxDLHIZNyVEoMU0AFB1M0V/k0sJQfXpCCA/6vql+g dgUtyPggMSefwT0lc/7S/UwQdvuRYyIcdVd47alDJyRfU5NOMx091IiqkKXm9nby nqGAfdO3GDQoOIXJpWD5E1UMPHt6AGXGsfypkuVTtTljvOx+U7S9ngBeFkjuor8+ VFwStSFGboPxAjfKqzubdFcPcp4t8E5/qqkXR+Nc2UBJV5XeC3Pg5GOZxBsDZvbz zU4btX6kgC1Si1vIkf+D8CyZgaoPSwiVgGfVkTaqYSqnO39JZ0SpjYlv7e4yuhfa jkXNYd+XevrLq435YYir =TVml -----END PGP SIGNATURE-----

2 3

GSoC '13 - Hello!
by Eric Zheng 15 Apr '13

15 Apr '13

Hello everyone, My name is Eric Zheng, I'm a junior in Computer Engineering at the University of Illinois Urbana-Champaign. I just wanted to introduce myself and state my interest in the "Xinput / Xbox 360 controller compatibility" project. I hope to be able to jump on IRC later in the week to speak with you all. Best, Eric Zheng

2 1

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 15 Apr '13

15 Apr '13

--- On Sun, 14/4/13, Vincent Povirk <madewokherd(a)gmail.com> wrote: > Well, here's a simple thing you can > check: Does your zlib dll link to > _lseek or _lseeki64? The first one uses a 32-bit offset. > Wine's > implementation (http://source.winehq.org/source/dlls/msvcrt/file.c#L1090) > expands that to 64-bit and later truncates the file offset > to 32-bit. > For a file larger than 2 GB, that could account for the > large negative > value you're seeing. > > And since this would only matter in cases where zlib uses > lseek (the > first time through I guess it wouldn't, as it has to read > the whole > everything up to the offset you give at least once) and is > at least 2 > GB into the file, that might also explain why it doesn't > fail > initially. > > But without really digging into the zlib code, all I can do > it speculate. > > I should probably also check coapp's build of zlib > sometime. It is not a dll - as you suggested and I already wrote, due to past experience of other's packaging of slightly outdated, it is being built against a private *source* copy of the latest zlib. Also the bogus offset is not large negative but large (larger than 2^32) positive. Here is an example of the debug output under wine: --------------- set_filepos failed at 34307 returning 134127533721091 Re-opening to re-try Retry successful set_filepos failed at 96919 returning 146686018157207 Re-opening to re-try Retry successful set_filepos failed at 128254 returning 12103217968382 Re-opening to re-try Retry successful ... --------------- This is generated by this code snipplet which is called inside a loop, all wrapped in the c++ class: --------------- off_t offset = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset != filepos) { //implicitly converted to off_t by template streamoff() LOG.printLOG("set_filepos failed at " + LOG.streampos2str(filepos) + " returning " + LOG.off_t2str(offset) + "\n"); LOG.printLOG("Re-opening to re-try\n"); close(); open(); off_t offset1 = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset1 == filepos) LOG.printLOG("Retry successful\n"); else LOG.error("Retry failed\n"); // this also aborts } ------------------- This code runs silently on linux i.e. the "if (offset != filepos)" condition is not triggered.

2 2

request.h: size of unnamed array is negative
by Hugh McMaster 15 Apr '13

15 Apr '13

I've been adding a new handler to Wine's server. Unfortunately, I've run into a problem with C_ASSERT that I can't seem to resolve. In server/request.h, I've added the following code: C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_request, spi_workarea) == 16 ); C_ASSERT( sizeof(struct get_desktop_workarea_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_x) == 4 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_y) == 4 ); C_ASSERT( sizeof(struct get_desktop_workarea_reply) == 8 ); But the compiler ends with output errors, as in the following: In file included from request.c:69:0: request.h:1527:1: error: size of unnamed array is negative request.h:1528:1: error: size of unnamed array is negative request.h:1529:1: error: size of unnamed array is negative request.h:1530:1: error: size of unnamed array is negative request.h:1531:1: error: size of unnamed array is negative Each error represents the C_ASSERT code listed above. I'm probably missing something obvious here. Can someone please offer any advice on resolving these errors? Thank you.

3 8

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 14 Apr '13

14 Apr '13

------------------------------ On Sun, Apr 14, 2013 22:34 BST Vincent Povirk wrote: >> considering how old zlib is and the vast number of windows application which uses zlib > >Given how many people duplicate the effort to package zlib, the fact >that they're rarely updated, and the sort of problems gnulib exists to >work around, it would not surprise me if your particular zlib binary >is broken somehow. got nobody else to blame - because of exactly the issue you outlined encountered in the past, i am building the application with a private copy of the source of zlib 1.2.7.

2 1

zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 14 Apr '13

14 Apr '13

I am porting an application which uses zlib's gzseek quite extensively to do pseudo- random access of the content of large gz'ed files, in the same manner of some's use of posix's lseek. On small test data, it works correctly on wine. (identical result as linux). On production data - a large 9GB file - it gives gabbage. I thought it is 32-bit file access problem, until I check the return value of gzseek explicitly. It is supposed to return the same value as input on success, -1 on error. On wine, it does neither, *occasionally*! I found that a first gzseek works correctly, then a 2nd fails. It does not fails with a -1, but fails with a large bogus value. Currently I am working around this strange behavior by closing the file and re-opening until it gets a correct offset. The large bogus value increases gradually and wrap around about 8-10 such repeated set of gzseek calls. Anybody has any suggestion why gzseek would behave badly *intermittently* in wine? I assume it works correctly in windows - hardly to think that it doesn't work, considering how old zlib is and the vast number of windows application which uses zlib. On a separate note, the application seems extraordinary slow in wine (again I haven't tried in windows..) - even when it works correctly without the work-around, it is hundreds of times slower in wine than in linux.

2 1

Re: [PATCH 1/4] wined3d: 1x1 texures have a power of two size
by Henri Verbeet 14 Apr '13

14 Apr '13

On 13 April 2013 16:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -965,8 +965,6 @@ static HRESULT texture_init(struct wined3d_texture *texture, UINT width, UINT he > && !(format->id == WINED3DFMT_P8_UINT && gl_info->supported[EXT_PALETTED_TEXTURE] > && wined3d_settings.rendertargetlock_mode == RTL_READTEX)) > { > - if (width != 1 || height != 1) > - texture->flags &= ~WINED3D_TEXTURE_POW2_MAT_IDENT; > > texture->pow2_matrix[0] = (float)width; > texture->pow2_matrix[5] = (float)height; I think we'll want the empty line here gone as well, but otherwise the series looks ok.

1 0

Google Summer of Code
by Liu Tuo 13 Apr '13

13 Apr '13

Hi, How much knowledge should I have before applying for the wine project of implementing missing D3DX9 apis? Currently I have learnt opengl; I am familiar with the opengl and glut functions and the concepts behind these functions. Thanks for your help, Liu Tuo

1 0

Re: gdiplus: fix a clipping problem
by Vincent Povirk 13 Apr '13

13 Apr '13

This looks wrong. scaled_rect is an internally calculated value, not something supplied by the user, and comparing it to 0.5 doesn't make sense, especially since by this point the width was altered to add padding.

1 0

GSoC 2013 proposal: Implement XPath from scratch
by John Chadwick 12 Apr '13

12 Apr '13

Hello, I am a student of computer science interested in entering Wine development via GSoC 2013. Upon looking at the various suggested proposals, the project of reimplementing XPath without libxml2 looked particularly interesting. I am familiar with the C language, W3C DOM and XPath, and I believe this is something I could do. I have a few questions I'd be interested in seeing answered: * One of the 'important things to keep in mind' is that "changes should be incremental, with a fallback to libxml2 until new processor is fully functional." Does this mean at compile time, or at runtime, when the evaluator recognizes unimplemented features in an expression, or something else entirely? * Is only MSXML 3.0 supported? It appears to be the only version implemented in the Wine source tree. * What should I aim at doing first? Because what I'd be working on is a library, I would probably need some application to test features with (test cases aside.) Should I be using an existing program, or writing a new one? Thanks, John Chadwick

3 2

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 5).
by Sergey Guralnik 12 Apr '13

12 Apr '13

On 2013-04-10 14:28, Sergey Guralnik wrote: >> >> It's better, but testing the message sequence doesn't seem very >> useful, >> particularly since you don't differentiate parent and child >> messages. >> Also you should test the region before the move to show that it's >> the >> move that's changing it. > > Changes since last version: > - message sequence testing removed at all > - added update region testing for all windows > before and after moving. > > --- > dlls/user32/tests/win.c | 68 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 68 insertions(+), 0 deletions(-) Is something wrong with this version? -- Sergey

1 0

Re: [PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used
by Henri Verbeet 12 Apr '13

12 Apr '13

On 11 April 2013 11:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1069,17 +1069,17 @@ static void shader_generate_glsl_declarations(const struct wined3d_context *cont > shader_addline(buffer, "uniform sampler1D %s_sampler%u;\n", prefix, i); > break; > case WINED3DSTT_2D: > - texture = state->textures[i]; > + tex_rect = version->type == WINED3D_SHADER_TYPE_PIXEL && (ps_args->np2_fixup & (1 << i)); The basic idea is ok, but the conditions for when np2_fixup is set are a bit more complicated than that. Specifically, look at how the WINED3D_TEXTURE_POW2_MAT_IDENT texture flag is set / cleared in texture_init().

2 4

Re: [3/3] server: Add support for NtTerminateProcess(0). Resend.
by Alexandre Julliard 12 Apr '13

12 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 33331. Before you can start killing threads, you'll need to fix the various synchronization primitives (with appropriate tests of course) to take process shutdown into account, otherwise it will deadlock all over the place. Other things like protecting the loader data structures will also need more thought. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fresh WineWiki Theme, Straight from the Farm
by Kyle Auble 11 Apr '13

11 Apr '13

So as usual, my estimate of how long it would take was way off, but I'm finally done adapting the WineHQ theme to Moinmoin. It's not perfect, but I feel it's ready to submit for switching over. I've tested it in Firefox, Chromium, Midori, and Opera (briefly in IE8 & IE9 too). I did do everything through Moinmoin's stand-alone server, but while I know there always seem to be ghosts in the machine, I'm guessing that Apache shouldn't interfere with layout issues. I mostly followed the WineHQ & current WineWiki theme for large things, just tweaking the CSS to make it fit what Moinmoin spits out. I did make more design choices of my own on the smaller stuff though. After wrestling with Moinmoin's theme system, I was surprised how many things are still hard-coded (at least as of v1.5). For example, Moinmoin wraps some things in divs without providing a CSS class for the div, just the child element. The fortune cookie on the RecentChanges page & the edit page are two cases of that. The dummy content in the search bar is another tricky one. It's set in the javascript for the search bar (don't remember where it was in the source tree) so I left that one alone. One other tricky issue was handling overflows & RTL support. They both seem to work ok in isolation, but go crazy when you mix them. I haven't checked RTL in IE, but if you force an RTL page to overflow in Webkit, it positions things based on what's actually in the window (so the sidebar winds up floating in the middle of the page). Firefox simply doesn't try to apply any of the overflow rules in RTL (which I guess is nice in a Hippocratic sense). Opera alone handled things exactly like I hoped. As for the tables, I think they should display ok now, although I don't know if everyone wants my exact values for paddings & such. The old theme had some table-based layout that may have had conflicting CSS rules, but I've div-vied everything up so the only table tags now should be when Moinmoin itself chooses them over a div and well... tables. I've pushed all of the changes to my Bitbucket repo at: https://bitbucket.org/kauble/wine-wiki-migration The "refined" branch is the one you want although I expect that once the code is hosted at WineHQ's git repo, it would become the new master branch. At that point, I can just reset my repo to point to the WineHQ one as the origin. - Kyle

3 4

Re: user32: SetTimer should respect the minimum and maximum timeout limits.
by Marvin 11 Apr '13

11 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25036 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === msg.c:8247: Test failed: did not get expected count for minimum timeout (57 != ~64).

1 0

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.
by Ken Thomases 11 Apr '13

11 Apr '13

On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > --- a/dlls/secur32/schannel_macosx.c > +++ b/dlls/secur32/schannel_macosx.c > @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef transport, const void *buff, > return ret; > } > > +DWORD schan_imp_enabled_protocols(void) > +{ > + /* NOTE: No support for TLS 1.1 and TLS 1.2 */ > + return SP_PROT_SSL2_CLIENT | SP_PROT_SSL3_CLIENT | SP_PROT_TLS1_0_CLIENT; > +} Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. You can test at build time with: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 ... #else ... #endif If we want to support building on 10.8 for deployment to earlier versions, we'd do something like: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 SSLProtocol maxProtocol; if (SSLGetProtocolVersionMax != NULL && SSLGetProtocolVersionMax(context, &maxProtocol) == noErr) { ... compare maxProtocol against kTLSProtocol11 and kTLSProtocol12 ... } ... #else ... #endif The idea is that SSLGetProtocolVersionMax() would be weak linked, so we'd check if it was actually available before calling it. Of course, the other complication is that that function requires a context parameter, but we can create one just for the query if we're interested in the framework capabilities (as opposed to what's been configured for a particular context). -Ken

3 10

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.
by Alexandre Julliard 11 Apr '13

11 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Alexandre Julliard <julliard(a)winehq.org> wrote: > >> > As far as I can see ExitProcess returns 'failures' as the child process exit >> > code, but variable 'failures' is not visible from the tests. Do you have a >> > suggestion how to fix that? >> >> You need to report the status a different way. For instance you could >> store it in a file. > > How does this one look like? (In theory this approach could be used > to transfer other child process information to the parent). Something like this would work, but it should be done in the test that needs it, not in the generic code. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 2/2] wined3d: Store ps 1.4 texture types in ps_compile_args
by Henri Verbeet 11 Apr '13

11 Apr '13

On 11 April 2013 11:40, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + for (i = 0; i < 6; ++i) > + { This could probably do with an appropriate constant. > +enum shader_tex_types > +{ > + shader_tex_2d = 0, > + shader_tex_3d = 1, > + shader_tex_cube = 2, > +}; Please use uppercase for enum elements. Some "wined3d" prefixes probably wouldn't hurt either, although I guess it doesn't matter so much for things that are only used internally.

1 0

Google Summer of Code
by Liu Tuo 10 Apr '13

10 Apr '13

Hi, I am Liu Tuo from National University of Singapore. I am interested in implementing missing D3DX9 APIs, how can I know more about this project and how can I apply for it? Is there anyone who can help me with this? Regards, Liu Tuo

2 1

We're in GSoC 2013
by Austin English 10 Apr '13

10 Apr '13

If you're interested in mentoring, please apply at: https://www.google-melange.com/gsoc/org/google/gsoc2013/wine In either case, please take a look at http://wiki.winehq.org/SummerOfCodeand update/remove/any projects you're familiar with. If you have any questions, feel free to contact me. Thanks for your help everyone! -- -Austin

2 2

Re: [PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/wined3d/utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index da8fc7b..5010676 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -1038,6 +1038,9 @@ static void check_fbo_compat(const struct wined3d_gl_info *gl_info, struct wined > GLenum status; > GLuint tex; > > + if (!(format->flags & WINED3DFMT_FLAG_TEXTURE)) > + return; > + I'm not sure about this one, what exactly should this achieve? In either case, this probably belongs in init_format_fbo_compat_info(), together with the other similar checks.

2 3

[PATCH v5 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 10 Apr '13

10 Apr '13

Main changes fom v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This let us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -EBUSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -EBUSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +-- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++++- fs/cifs/cifsproto.h | 8 +-- fs/cifs/cifssmb.c | 50 ++++++++++--------- fs/cifs/dir.c | 16 +++--- fs/cifs/file.c | 20 +++++--- fs/cifs/inode.c | 16 +++--- fs/cifs/link.c | 25 +++------- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 +++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +-- fs/cifs/smb2proto.h | 14 +++--- fs/fcntl.c | 5 +- fs/locks.c | 105 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 45 +++++++++++++++-- fs/nfs/internal.h | 3 +- fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++-- fs/nfs/nfs4xdr.c | 21 ++++++-- fs/nfs/super.c | 7 ++- fs/nfsd/nfs4state.c | 46 ++++++++++++++++- fs/proc_namespace.c | 1 + include/linux/fs.h | 8 +++ include/uapi/asm-generic/fcntl.h | 11 ++++ include/uapi/linux/fs.h | 1 + 29 files changed, 364 insertions(+), 130 deletions(-) -- 1.8.1.5

4 14

Re: [PATCH 1/2] wined3d: Handle texture types via ps/vs_compile_args
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 13:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch only changes the way the texture types are fed into the > shader generation code. Generating the proper shader code (hardcoded > values instead of relying on the dummy textures) is a task I've left for > Matteo, who worked on this problem before. > > This patch originates from my work-in-progress command stream work. It > is one of the few that I think makes sense on its own. > --- Why do you need the sampler type for anything other than SM1 pixel shaders? Also, while in principle I'm all for not accessing wined3d_state from the shader backend, I don't think there should be anything in the command stream patches that would prevent that.

4 4

Re: [PATCH 1/8] wined3d: Remove useless glClearxxx calls.
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - /* Clear the screen */ > - gl_info->gl_ops.gl.p_glClearColor(1.0f, 0.0f, 0.0f, 0.0f); > - checkGLcall("glClearColor"); > - gl_info->gl_ops.gl.p_glClearIndex(0); > - gl_info->gl_ops.gl.p_glClearDepth(1); > - gl_info->gl_ops.gl.p_glClearStencil(0xffff); > - > - checkGLcall("glClear"); > And actually potentially harmful, if the new context is created after an existing one already did drawing on the same drawable. (Although that's fairly unlikely, especially with "AlwaysOffscreen" enabled.)

2 1

Re: tools: add ProductId to the Windows NT Current Version block
by Alexandre Julliard 10 Apr '13

10 Apr '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -3019,6 +3019,7 @@ HKLM,%CurrentVersionNT%,"CSDVersion",2,"Service Pack 3" > HKLM,%CurrentVersionNT%,"CurrentBuildNumber",2,"2600" > HKLM,%CurrentVersionNT%,"CurrentType",2,"Uniprocessor Free" > HKLM,%CurrentVersionNT%,"ProductName",2,"Microsoft Windows XP" > +HKLM,%CurrentVersionNT%,"ProductId",,"12345-oem-0000001-54321" I'm not sure it's a good idea to hardcode this. -- Alexandre Julliard julliard(a)winehq.org

2 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel