- wine-devel - winehq.org

Re: include: Make sure interlocked_cmpxchg128 is defined on ARM64
by André Hentschel 18 Jan '13

18 Jan '13

Am 18.01.2013 18:05, schrieb André Hentschel: > --- > include/wine/port.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/wine/port.h b/include/wine/port.h > index bd6f513..d6904c0 100644 > --- a/include/wine/port.h > +++ b/include/wine/port.h > @@ -435,7 +435,7 @@ extern __int64 interlocked_cmpxchg64( __int64 *dest, __int64 xchg, __int64 compa > extern int interlocked_xchg( int *dest, int val ); > extern void *interlocked_xchg_ptr( void **dest, void *val ); > extern int interlocked_xchg_add( int *dest, int incr ); > -#ifdef _WIN64 > +#if defined(__x86_64__) || defined(__aarch64__) || defined(_WIN64) > extern unsigned char interlocked_cmpxchg128( __int64 *dest, __int64 xchg_high, > __int64 xchg_low, __int64 *compare ); > #endif > > > > oops that's not fully correct, I'll fix it next week, not a bad warning. -- Best Regards, André Hentschel

1 0

Re: qcap: Fix compilation on older systems.
by Damjan Jovanovic 18 Jan '13

18 Jan '13

What does this patch do? libv4l1.h includes libv4l1-videodev.h which is a copy of linux/videodev.h. You should only need the one or the other. Are you saying there is a system where libv4l1.h is present but incomplete, and you need to include linux/videodev.h together with it? Thank you Damjan On Tue, Jan 15, 2013 at 6:47 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/qcap/v4l.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/qcap/v4l.c b/dlls/qcap/v4l.c > index f5baaeb..2562c48 100644 > --- a/dlls/qcap/v4l.c > +++ b/dlls/qcap/v4l.c > @@ -47,7 +47,8 @@ > #endif > #ifdef HAVE_LIBV4L1_H > #include <libv4l1.h> > -#elif defined(HAVE_LINUX_VIDEODEV_H) > +#endif > +#ifdef HAVE_LINUX_VIDEODEV_H > #include <linux/videodev.h> > #endif > #ifdef HAVE_UNISTD_H > -- > 1.8.0.2 > > >

3 4

Re: configure.ac: check for a recent enough libv4l1.h
by Alexandre Julliard 18 Jan '13

18 Jan '13

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * configure.ac: check for a recent enough libv4l1.h > > libv4l1.h can only be used instead of linux/videodev.h as of version > 0.8.3, so check for the version using pkg-config (the only possible > way) and don't try to compile with older versions. This fixes > compilation on systems like FreeBSD 8.2, where there is no > linux/videodev.h, and libv4l1.h is too old. You should check for the definitions we need, not the version number. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used. (try 2) (resend)
by Alexandre Julliard 18 Jan '13

18 Jan '13

Charles Davis <cdavis5x(a)gmail.com> writes: > Try 2: Clarify that this is a Mac OS-only change. Don't use $CC as the assembler. Use the right flags to select 32/64-bit assembly with Clang. > > The configure script invokes the system compiler to figure out if .cfi > pseudo-ops are supported, on the assumption that it will invoke the > system assembler. Winebuild, on the other hand, invokes the system > assembler directly. This caused a problem on Mac OS hosts when compiling > with Clang: configure would detect that .cfi ops were supported, because > Clang's integrated assembler supports them; however, when winebuild then > emitted assembly with .cfi ops in them, the system assembler would then > choke. This patch makes winebuild invoke Clang's assembler if a) we are > on Mac OS, b) $CC is detected to be Clang, and c) it is using (whether > by request or by default) its built-in assembler. You can't use ifdefs in winebuild. This would have to be a runtime check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] vbscript: Added VBScript.RegExp version 5.5 typelib
by Jacek Caban 18 Jan '13

18 Jan '13

Hi Piotr, On 01/18/13 11:48, Piotr Caban wrote: > +#define DISPID_SUBMATCHES_ITEM 0 > +#define DISPID_SUBMATCHES_COUNT 1 > +#define DISPID_SUBMATCHES__NEWENUM -4 > + > +#define DISPID_MATCHCOLLECTION_ITEM 0 > +#define DISPID_MATCHCOLLECTION_COUNT 1 > +#define DISPID_MATCHCOLLECTION__NEWENUM -4 > + > +#define DISPID_MATCH_VALUE 0 Please use DISPID_VALUE and DISPID_NEWENUM instead. Jacek

1 0

Re: [PATCH 3/3] msvcrt: Added basic _popen tests (try2)
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23996 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] msvcrt: Added basic _popen tests
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23995 Your paranoid android. === WNT4WSSP6 (32 bit misc) === misc.c:340: Test failed: errno = -559038737 === W2KPROSP4 (32 bit misc) === misc.c:340: Test failed: errno = -559038737 === W2K3R2SESP2 (32 bit misc) === misc.c:340: Test failed: errno = -559038737

1 0

Re: [PATCH 3/3] d3dx9_36: Make variables static in xfile tests.
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23990 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: user32/tests: Test standard scrollbar's initialization (try 2).
by Sergey Guralnik 18 Jan '13

18 Jan '13

On 2013-01-15 12:27, Sergey Guralnik wrote: > I have no feedback yet. Is it not clear enough? -- Sergey

1 0

Re: po: Update Russian translation
by Dmitry Timoshkov 18 Jan '13

18 Jan '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > #: jscript.rc:40 > msgid "Can't have 'break' outside of loop" > -msgstr "Выражение 'break' не может находится вне цикла" > +msgstr "Оператор 'break' не может находится вне цикла" > > #: jscript.rc:41 > msgid "Can't have 'continue' outside of loop" > -msgstr "Выражение 'continue' не может находится вне цикла" > +msgstr "Оператор 'continue' не может находится вне цикла" It would be also nice to fix obvious spelling errors, it really hurts the eyes :) - "не может находит[ь]ся", and run spell checker for the whole translation. -- Dmitry.

1 0

Re: ws2_32/tests: Add SO_ERROR [set|get]sockopt tests
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23986 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] kernel32/path : use code from copyfileW to implement copyfileexW
by Alexandre Julliard 17 Jan '13

17 Jan '13

Patrick Rudolph <siro(a)das-labor.org> writes: > From 6ff3329003b6b9001ad608f802f235f5433b1c5d Mon Sep 17 00:00:00 2001 > From: Patrick Rudolph <siro(a)das-labor.org> > Date: Fri, 11 Jan 2013 15:55:32 +0100 > Subject: a > > --- > dlls/kernel32/path.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 86 insertions(+), 5 deletions(-) You need to move the code, not duplicate it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests : added tests for copyfileex try4
by Alexandre Julliard 17 Jan '13

17 Jan '13

Patrick Rudolph <siro(a)das-labor.org> writes: > + if(!GetTempPathA( MAX_PATH,tmppath )) > + { > + win_skip("GetTempPathA failed\n"); > + return; > + } > + > + if(!GetTempFileNameA( tmppath,"CopyFileExAin",0,source_name )) > + { > + win_skip("GetTempFileNameA failed\n"); > + return; > + } > + > + if(!GetTempFileNameA( tmppath,"CopyFileExAout",0,dest_name )) > + { > + win_skip("GetTempFileNameA failed\n"); > + return; > + } > + > + source_handle = CreateFileA( source_name, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0 ); > + if(!source_handle) > + { > + win_skip("CreateFileA failed, no write permissions ?\n"); > + return; > + } > + > +#define COPYFILEEXFILESIZE 10000000 > + > + /* create a dummy file for copy tests */ > + buffer = malloc(COPYFILEEXFILESIZE); > + if(!WriteFile(source_handle,buffer,COPYFILEEXFILESIZE,&ret,NULL)) > + { > + free(buffer); > + win_skip("WriteFile failed, enough free disk space ?\n"); > + return; > + } > + free(buffer); > + CloseHandle(source_handle); There are better ways to create a test file than writing 10Mb of uninitialized data. Also you should check how GetTempFileName works. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character. (try 4)
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23979 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] winealsa.drv: Cleanup modLongData and Fix F0 and F7 byte insertion + memory leak.
by Alexandre Julliard 17 Jan '13

17 Jan '13

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -927,12 +927,12 @@ static DWORD modData(WORD wDevID, DWORD dwParam) > } > > /************************************************************************** > - * modLongData [internal] > + * modLongData internal] > */ > static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > { > - int len_add = 0; > - LPBYTE lpData, lpNewData = NULL; > + int len_add = 0; > + BYTE *lpData, *lpNewData = NULL; > snd_seq_event_t event; > > TRACE("(%04X, %p, %08X);\n", wDevID, lpMidiHdr, dwSize); > @@ -941,23 +941,23 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > * but it seems to be used only for midi input. > * Taking a look at the WAVEHDR structure (which is quite similar) confirms this assumption. > */ > - > + > if (wDevID >= MODM_NumDevs) return MMSYSERR_BADDEVICEID; > if (!MidiOutDev[wDevID].bEnabled) return MIDIERR_NODEVICE; > > - if (midiSeq == NULL) { > - WARN("can't play !\n"); > - return MIDIERR_NODEVICE; > + if (!midiSeq) { > + WARN("Can't play !\n"); > + return MIDIERR_NODEVICE; > } > > - lpData = (LPBYTE) lpMidiHdr->lpData; > - > - if (lpData == NULL) > - return MIDIERR_UNPREPARED; > + lpData = (BYTE*)lpMidiHdr->lpData; > + > + if (!lpData) > + return MIDIERR_UNPREPARED; > if (!(lpMidiHdr->dwFlags & MHDR_PREPARED)) > - return MIDIERR_UNPREPARED; > + return MIDIERR_UNPREPARED; > if (lpMidiHdr->dwFlags & MHDR_INQUEUE) > - return MIDIERR_STILLPLAYING; > + return MIDIERR_STILLPLAYING; > lpMidiHdr->dwFlags &= ~MHDR_DONE; > lpMidiHdr->dwFlags |= MHDR_INQUEUE; Please avoid gratuitous formatting changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] wmiutils: Implement IWbemPath::RemoveNamespaceAt.
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23977 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] wmiutils: Implement IWbemPath::GetNamespaceAt.
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23975 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/5] wmiutils: Implement IWbemPath::SetClassName.
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23974 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

kernel32/path: tests and patches
by Patrick Rudolph 16 Jan '13

16 Jan '13

Any comments on my copyfileexW patches ?

1 0

Re: [PATCH 2/3] d3d8/tests: Create a plain DS surface in test_reset_resources
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23963 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: mshtml: Remove duplicated property entries in preprocess_dispex_data
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23961 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Reload a DLL and _getptd returns zero
by Michael Ost 16 Jan '13

16 Jan '13

On 01/12/2013 05:21 PM, Dan Kegel wrote: >> The library in question is using static vc runtime linkage, so _getptd() >> is linked in > > That's somewhat worrisome. So you have multiple instances > of the C runtime library active in the same app? > > Maybe you're not unloading that dll gracefully enough. > > Might be heap corruption. I wonder if Valgrind might be helpful. > > I second the suggestion to post a minimal testcase. Here's a link to a zip file that includes the prebuilt .exe and .dll windows binaries that crash in wine. Plus the code. https://dl.dropbox.com/u/97386125/msvcrt-dll-problem.zip So, again, the bug is that MSVCRT calls are failing when called from a DLL that has been reloaded. If the calls come from a thread and if the DLL is built with static MSVCRT runtimes. There is no crash for the program in Windows. I also tried rebuilding the code for winelib, and it doesn't appear to have the same behavior. So the problem doesn't happen if Wine's MSVCRT is used, only if a windows DLL that uses static MSVCRT linkage is reloaded. Thanks -- mo

2 5

Re: [12/15] kernel32/tests: Add ARM64 support
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23957 Your paranoid android. === WINEBUILD (build) === Making build dependencies failed

2 1

My Wine static analysis tool
by Damjan Jovanovic 15 Jan '13

15 Jan '13

Hi I've hacked together a simple tool for analyzing Wine code. Currently it can do the following: 1. Find BOOL functions returning non-BOOL. 2. Find HRESULT functions returning non-HRESULTs. 3. Generate a TRACE() for each function showing all its parameters. It isn't really a formal C parser, as it ignores all preprocessor directives, but this makes it *much* simpler and shorter than a real C parser, and it sees original Windows types like LPCWSTR etc. It's not 100% accurate, but it's very effective. 3 of my recent patches have been generated with its help - and I've barely gotten started. I'd like to add the following features at some stage: * Populate all functions with a TRACE() of their arguments, if they don't already have it. * Scan all GUIDs in include/ and generate a full list of all GUIDs and their names. Then patch debugstr_guid() to also output the name of the GUID when available, and/or search and replace GUIDs in WINEDEBUG traces after they've been recorded. * Update .spec files from .c file contents, and verify .spec file accuracy. * It could be extended to examine contents of functions and enforce the absence of W->A and 32->16 calls, etc. * etc. Anybody interested in using it or helping develop it? Regards Damjan

3 4

Re: [PATCH 1/5] dsound: rework ugly mixer logic
by Andrew Eikum 15 Jan '13

15 Jan '13

On Tue, Jan 15, 2013 at 06:51:59PM +0100, Maarten Lankhorst wrote: > Op 07-01-13 16:58, Andrew Eikum schreef: > > This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA > > without PulseAudio. I didn't test OSS. It skips around on the ship's > > shooting noises. I've attached good and bad logs on ALSA here. > > > > [1] > > http://www.classic-retro-games.com/Zaxxon_70.html > > > I don't see anything suspicious in the log. Did it work after the complete patch series was applied or did you not test? Yeah, I was testing with the whole series when I found the problem, and rolled back patch-by-patch until I found that the first one caused it. Andrew

1 0

Re: gdi32/tests: GetTextExtentPoint should give repeatable results
by Alexandre Julliard 15 Jan '13

15 Jan '13

Daniel Jelinski <djelinski1(a)gmail.com> writes: > These are tests for bug 32529. Since commit ebaf5ea17623268fb1c0f68b1cf9a5984bd4e46e > (Don't load bitmap glyphs when using subpixel rendering in GetGlyphOutline) > GetTextExtentPoint returns different results before and after glyphs are loaded, > at least for wine's Tahoma. I don't see that here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:4818: Test succeeded inside todo block: extents different: first 76, second 76 -- Alexandre Julliard julliard(a)winehq.org

2 1

Truncate MIDI SysEx messages after termination byte
by Joerg-Cyril.Hoehle＠t-systems.com 15 Jan '13

15 Jan '13

Hi, Christian Costa wrote: >I took a look at the >alsa code and this code simply does not do what it is supposed to. I also looked at it today and noted those bogus lines you quote. Needs a patch (+ fix memory leak). However, Johannes' change is presumably different, as he wants to scan the buffer contents for a F7 terminator and ignore subsequent bytes. If I were to decide, I'd like to see more supporting evidence. I'd appreciate if Johannes would open a bug report and attach some WINEDEBUG=+midi,+mmdevapi,+alsa,+winmm,+driver,+tid,+timestamp logs to bugzilla, much like bug #26928. http://bugs.winehq.org/show_bug.cgi?id=26928 Having some logs with *complete* SysEx contents helps. There's also a "closed as abandoned" bug about microKORG http://bugs.winehq.org/show_bug.cgi?id=17608 which might be of interest to Johannes. Regards, Jörg Höhle

2 7

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices
by Henri Verbeet 15 Jan '13

15 Jan '13

On 15 January 2013 00:13, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWND focus_window, BOOL windowed) > +static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWND focus_window, BOOL windowed, > + DWORD flags) > { > D3DPRESENT_PARAMETERS present_parameters = {0}; > IDirect3DDevice9 *device; > @@ -90,7 +91,7 @@ static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWN > present_parameters.AutoDepthStencilFormat = D3DFMT_D24S8; > > if (SUCCEEDED(IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, focus_window, > - D3DCREATE_HARDWARE_VERTEXPROCESSING, &present_parameters, &device))) return device; > + flags, &present_parameters, &device))) return device; > If this fails, we're going to try hardware vertex processing again, but I don't think this is something we want to specify for every single test anyway. If this is just for a single test that needs software vertex processing, just write it out. If you already know there are going to be multiple tests like this, you could probably introduce a function like create_swvp_device().

2 1

Re: [PATCH 3/3] d3d8/tests: Add a software vertexprocessing buffer discard test (try 2)
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23943 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] mshtml: Added IHTMLScriptElement::put_text tests
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23941 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/5] ddraw: Only modify the ddraw destination window at the end of ddraw7_SetCooperativeLevel().
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23930 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] ddraw: Add a small tests for SetCooperativeLevel() calls with different windows.
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23929 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Wine Wiki needs your help!
by Dimi Paun 15 Jan '13

15 Jan '13

Yes it is done. Ill update the spreadsheet bit later... André Hentschel <nerv(a)dawncrow.de> wrote: >Am 14.01.2013 21:40, schrieb Andrew Eikum: >> On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote: >>> OK, we might be onto something. I've wrote a script >>> to determine the deleted pages: 20162. >>> >>> Should I just go ahead and nuke those? >>> >> >> Probably, yes. >> >> One common way for spammers to abuse wikis is to intentionally get the >> pages deleted, so that they live on permanently in the revision >> history. >> >> See this example from today: >> It's rightfully deleted as spam: >> http://wiki.winehq.org/SheriOci >> But the "Get Info" link leads you to the old revision, with the >> linkspam intact: >> http://wiki.winehq.org/SheriOci?action=recall&rev=1 >> >> I don't know if there's a way to keep Moinmoin from preserving >> revision history on deleted pages, but it might be sufficient to >> simply disable that. I doubt there's much useful history on deleted >> pages anyway. > >seems done, and know what? The wiki seems to be more than 10 times faster. (i tried e.g. editing -> preview) >good choice! >Thanks Dimi for working on this!!! > > >-- > >Best Regards, André Hentschel

1 0

Re: [PATCH 5/5] d3d8/tests: Add a software vertexprocessing buffer discard test
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23928 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9/tests: Add a software vertexprocessing buffer discard test
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23926 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23925 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: comctl32/listview: fix icon spacing calculation [try 2]
by Nikolay Sivov 14 Jan '13

14 Jan '13

On 1/15/2013 00:53, Daniel Jelinski wrote: > + if(lParam == -1) > + return LISTVIEW_SetIconSpacing(infoPtr, -1, -1); > + return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), HIWORD(lParam)); Why do you need to handle this case specially? If it's -1 for 64bit comctl32 it should give you the same values with HIWORD/LOWORD as it does for 32bit.

2 7

Patches for winspool.drv and other locations
by Detlef Riekenberg 14 Jan '13

14 Jan '13

Hi Tatyana Welcome to Wine. Wine has a test suite to make sure, that new code is correct. Example, what you never tested: > - if(!pDeviceName) { > + if(!pDeviceName && !*pDeviceName) { Your code will crash, when pDeviceName is NULL. I expect, you want to use a logical OR, but i did not test such a code change. -- By by ... Detlef

1 0

Re: user32/tests: Add test for SetScrollInfo().
by Alexandre Julliard 14 Jan '13

14 Jan '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +static void test_setscrollinfo ( HWND hwnd, INT nBar ) > +{ > + SCROLLINFO cur, expected; > + char ok_format[] = "unexpected state: (bar: %d)\n" > + " expected: min: %d, max: %d, page: %d, pos: %d\n" > + " got: min: %d, max: %d, page: %d, pos: %d\n"; > +#define SCROLL_OK_ARGS nBar, \ > + expected.nMin, expected.nMax, expected.nPage, expected.nPos, \ > + cur.nMin, cur.nMax, cur.nPage, cur.nPos Please avoid that sort of macro abuse. Write an inline function if you don't want to duplicate the ok statement. -- Alexandre Julliard julliard(a)winehq.org

1 0

testbot
by Daniel Jelinski 14 Jan '13

14 Jan '13

Hello, the testbot does not revert patches submitted through testbot.winehq.org after testing. As a result it is almost impossible to test another patch affecting the same area in code as a previous one. Could anyone please fix it? Or at least add git reset to cron... Regards, Daniel

1 0

Re: comctl32/listview: fix icon spacing calculation [try 2]
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23921 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: include: flesh out d3d11.idl (try 2)
by Dmitry Timoshkov 14 Jan '13

14 Jan '13

Austin English <austinenglish(a)gmail.com> wrote: > Try 2: > Remove L suffixes, C++ comment. > +/* Forward declarations */ You've copied too much from the PSDK version, better leave it to someone else, and do it step by step when particular functionality gets implemented. -- Dmitry.

3 4

Re: vbscript: Added support for more constants
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23911 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] xmllite: Support whitespace nodes reporting
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23910 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters (try 3)
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23904 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters (try 3)
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23904 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] wmiutils: Implement IWbemPath::GetClassName.
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23902 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] kernel32: implement condition variables
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23900 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Implement CreateBitmapFromHICON. Take 2.
by Vincent Povirk 14 Jan '13

14 Jan '13

Looks good to me.

1 0

Re: windowscodecs: Implement CreateBitmapFromHICON. Take 2.
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23899 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel