- wine-devel - winehq.org

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Jacek Caban 09 Jan '13

09 Jan '13

Hi Andrew, On 01/09/13 16:56, Andrew Eikum wrote: > --- > > This should fix the Office 2007 half of Bug 17271. > > try2: Fix test failures on XP by expanding the expected path name. > > dlls/ieframe/navigate.c | 7 +++++- > dlls/ieframe/tests/webbrowser.c | 56 ++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 59 insertions(+), 4 deletions(-) > > > 0001-ieframe-Strip-file-from-file-URLs-in-BEFORENAVIGATE2.patch > > > diff --git a/dlls/ieframe/navigate.c b/dlls/ieframe/navigate.c > index dd4a976..2601ba8 100644 > --- a/dlls/ieframe/navigate.c > +++ b/dlls/ieframe/navigate.c > @@ -566,6 +566,8 @@ static void on_before_navigate2(DocHost *This, LPCWSTR url, SAFEARRAY *post_data > VARIANT var_url, var_flags, var_frame_name, var_post_data, var_post_data2, var_headers; > DISPPARAMS dispparams; > VARIANTARG params[7]; > + WCHAR file_path[MAX_PATH]; > + DWORD file_path_len = sizeof(file_path) / sizeof(*file_path); > > dispparams.cArgs = 7; > dispparams.cNamedArgs = 0; > @@ -607,7 +609,10 @@ static void on_before_navigate2(DocHost *This, LPCWSTR url, SAFEARRAY *post_data > V_VT(params+5) = (VT_BYREF|VT_VARIANT); > V_VARIANTREF(params+5) = &var_url; > V_VT(&var_url) = VT_BSTR; > - V_BSTR(&var_url) = SysAllocString(url); > + if(PathCreateFromUrlW(url, file_path, &file_path_len, 0) == S_OK) > + V_BSTR(&var_url) = SysAllocString(file_path); > + else > + V_BSTR(&var_url) = SysAllocString(url); > > V_VT(params+6) = (VT_DISPATCH); > V_DISPATCH(params+6) = (IDispatch*)This->wb; > diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c > index 25cce8a..70c785b 100644 > --- a/dlls/ieframe/tests/webbrowser.c > +++ b/dlls/ieframe/tests/webbrowser.c > @@ -151,7 +151,7 @@ static VARIANT_BOOL exvb; > static IWebBrowser2 *wb; > > static HWND container_hwnd, shell_embedding_hwnd; > -static BOOL is_downloading, is_first_load, use_container_olecmd, test_close, is_http, use_container_dochostui; > +static BOOL is_downloading, is_first_load, use_container_olecmd, test_close, is_http, is_file, use_container_dochostui; > static HRESULT hr_dochost_TranslateAccelerator = E_NOTIMPL; > static HRESULT hr_site_TranslateAccelerator = E_NOTIMPL; > static const char *current_url; > @@ -690,8 +690,14 @@ static void test_OnBeforeNavigate(const VARIANT *disp, const VARIANT *url, const > ok(V_VT(V_VARIANTREF(url)) == VT_BSTR, "V_VT(V_VARIANTREF(url))=%d, expected VT_BSTR\n", > V_VT(V_VARIANTREF(url))); > ok(V_BSTR(V_VARIANTREF(url)) != NULL, "V_BSTR(V_VARIANTREF(url)) == NULL\n"); > - ok(!strcmp_wa(V_BSTR(V_VARIANTREF(url)), current_url), "unexpected url %s, expected %s\n", > - wine_dbgstr_w(V_BSTR(V_VARIANTREF(url))), current_url); > + if(is_file){ > + char full_path[MAX_PATH]; > + GetLongPathNameA(current_url, full_path, sizeof(full_path)); I think expanding the path would be better done while constructing the URL instead of here. + test_DoVerb(webbrowser); + test_Navigate2(webbrowser, file_url); + + IWebBrowser2_Release(webbrowser); This is not enough for proper clean up. You may verify that by checking ref count here. At least setting client site to NULL is needed. Cheers, Jacek

1 0

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23818 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23816 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3320: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3320: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3320: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3461: Test failed: Creating WebBrowser object failed: 80040154 webbrowser: unhandled exception c0000005 at 0040816F === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2607: Test failed: expected GetOverridesKeyPath webbrowser.c:2612: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2613: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3046: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21 === WXPPROSP3 (32 bit webbrowser) === webbrowser.c:693: Test failed: unexpected url L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\wine_test.html", expected C:\DOCUME~1\winetest\LOCALS~1\Temp\wine_test.html === W2K3R2SESP2 (32 bit webbrowser) === webbrowser.c:693: Test failed: unexpected url L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\wine_test.html", expected C:\DOCUME~1\winetest\LOCALS~1\Temp\wine_test.html

1 0

Re: Truncate MIDI SysEx messages after termination byte
by Christian Costa 09 Jan '13

09 Jan '13

Le 09/01/2013 03:12, Johannes Kroll a écrit : > While using the KORG Kontrol Editor software [1] under Wine to configure > my nanoPAD2 MIDI controller, I noticed that uploading parameters to the > hardware doesn't work. The program displays a timeout message. > > The program relies on the MIDI driver to remove data after the SysEx > termination byte [2], but the Wine's winmm implementation doesn't do > this. The complete MIDIHDR buffer is sent, including excess bytes in the > case when the buffer is larger than the MIDI message. > > The attached patch fixes the problem by truncating SysEx messages after > the termination byte, ignoring any excess bytes. > > I tested the patch with KORG Kontrol Editor under Ubuntu 12.04 64-bit > (32-bit wine). > > [1] http://www.korg.co.uk/support/downloads/nano2_dl.php > [2] http://home.roadrunner.com/~jgglatt/tech/midispec/sysex.htm > > Hi, Please be consistent when using space. 1 space before and after operators (<, ==, =, ...). Christian

2 3

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback
by Nikolay Sivov 09 Jan '13

09 Jan '13

On 1/8/2013 22:19, Patrick Rudolph wrote: > + BOOL progressRoutine_enabled = progressRoutine != 0; Why do you need this? You could always check for callback pointer directly.

2 2

Re: vbscript: Added support for a few more constants
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23812 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23802 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [2/2] windowscodecs: BMP decoder should always return valid image resolution.
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23803 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback
by Nikolay Sivov 08 Jan '13

08 Jan '13

On 1/8/2013 22:19, Patrick Rudolph wrote: > This should fix bug http://bugs.winehq.org/show_bug.cgi?id=29232 > It fixes lots of tests on wine. That's suspicious cause you don't have test diff in this patch. > >

1 0

Re: kernel32/tests : added tests for copyfileex
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23794 Your paranoid android. === WVISTAADM (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === W2K8SE (32 bit path) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W7PRO (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === W7PROX64 (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === TEST64_W7SP1 (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === W7PROX64 (64 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === TEST64_W7SP1 (64 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0

1 0

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.
by Nikolay Sivov 08 Jan '13

08 Jan '13

On 1/8/2013 16:34, Tatyana Fokina wrote: > + > + memset(a, 'a', sizeof(a)); > + SetLastError(NO_ERROR); > + ret = CompareStringA(lcid, 0, a, sizeof(a), a, sizeof(a)); > + error = GetLastError(); > + ok(!error && ret == CSTR_EQUAL, "ret %d (expected %d), error %d\n", ret, CSTR_EQUAL, error); It's better to set it to some value you don't expect to be ever used as error code, like 0xdeadbeef or 0xb19b00b5.

2 1

[PATCH] winspool.drv: Ignore pDevModeInput if fMode not equal DM_IN_BUFFER
by Tatyana Fokina 08 Jan '13

08 Jan '13

1 0

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23793 Your paranoid android. === W2K8SE (32 bit locale) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [2/3] xmllite: Report value for PI nodes
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23792 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/3] xmllite: Report node value for comment nodes
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23791 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d8/tests: Merge d3d8_main.c into device.c.
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23788 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] dplayx: check return of CoCreateInstance (Coverity)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23787 Your paranoid android. === W2K8SE (32 bit dplayx) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] dplayx: check return of CoCreateInstance (Coverity)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23787 Your paranoid android. === W2K8SE (32 bit dplayx) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws (try 2)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23786 Your paranoid android. === W2K8SE (32 bit ddraw7) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W2K8SE (32 bit ddraw4) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] advapi32: close scm_handle on error exit (Coverity)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23785 Your paranoid android. === W2KPROSP4 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === WXPPROSP3 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === W2K3R2SESP2 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === W2K8SE (32 bit service) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 7/7] d3dcompiler43/tests: Don't use IUnknown_Release(). (resend)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23784 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/7] d3dx9: Handle invalid byte code in D3DXGetShaderConstantTableEx(). (resend)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23783 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] d3dx9: Always set the table = NULL in D3DXGetShaderConstantTableEx(). (resend)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23782 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Don't copy extra data from the end of a row.
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23777 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section. [try 2]
by Alexandre Julliard 07 Jan '13

07 Jan '13

Ken Thomases <ken(a)codeweavers.com> writes: > @@ -731,11 +731,13 @@ case $host_os in > AC_SUBST(IOKITLIB,"-framework IOKit -framework CoreFoundation") > AC_SUBST(APPLICATIONSERVICESLIB,"-framework ApplicationServices") > AC_SUBST(CORESERVICESLIB,"-framework CoreServices") > + AC_SUBST(WINE_INFO_PLIST,"wine_info.plist") > + AC_CONFIG_FILES(loader/$WINE_INFO_PLIST) This should be generated from the Makefile. The convention is that configure generates makefiles, and makefiles generate the rest. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section.
by Charles Davis 07 Jan '13

07 Jan '13

On Jan 6, 2013, at 6:54 PM, Ken Thomases wrote: > diff --git a/loader/wine_info.plist.in b/loader/wine_info.plist.in > new file mode 100644 > index 0000000..c332649 > --- /dev/null > +++ b/loader/wine_info.plist.in > @@ -0,0 +1,28 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> > +<plist version="1.0"> > +<dict> > + <key>CFBundleDevelopmentRegion</key> > + <string>English</string> > + <key>CFBundleExecutable</key> > + <string>wine</string> > + <key>CFBundleIdentifier</key> > + <string>org.winehq.wine</string> > + <key>CFBundleInfoDictionaryVersion</key> > + <string>6.0</string> > + <key>CFBundleName</key> > + <string>Wine</string> > + <key>CFBundlePackageType</key> > + <string>APPL</string> > + <key>CFBundleShortVersionString</key> > + <string>@PACKAGE_VERSION@</string> > + <key>CFBundleSignature</key> > + <string>????</string> > + <key>CFBundleVersion</key> > + <string>@PACKAGE_VERSION@</string> > + <key>LSMinimumSystemVersion</key> > + <string>10.6</string> With this, you won't be able to launch Wine from the Finder or with open(1) prior to 10.6. Chip > + <key>NSPrincipalClass</key> > + <string>WineApplication</string> > +</dict> > +</plist> >

4 4

Re: wininet: Fixed handling NULL buffer in INTERNET_OPTION_PROXY queries
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23776 Your paranoid android. === W2K8SE (32 bit internet) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/5] dsound: rework ugly mixer logic
by Andrew Eikum 07 Jan '13

07 Jan '13

This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA without PulseAudio. I didn't test OSS. It skips around on the ship's shooting noises. I've attached good and bad logs on ALSA here. [1] http://www.classic-retro-games.com/Zaxxon_70.html Andrew On Wed, Jan 02, 2013 at 02:46:43PM +0100, Maarten Lankhorst wrote: > --- > dlls/dsound/dsound.c | 1 - > dlls/dsound/dsound_main.c | 6 - > dlls/dsound/dsound_private.h | 6 +- > dlls/dsound/mixer.c | 253 +++++++++++-------------------------------- > dlls/dsound/primary.c | 95 ++++++---------- > 5 files changed, 99 insertions(+), 262 deletions(-)

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLStyle::put_pixelLeft implementation
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23774 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] mshtml: Added IHTMLStyle::get_pixelLeft implementation
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23773 Your paranoid android. === W2K8SE (32 bit style) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [3/3] xmllite: Support name reporting for comments and PIs
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23772 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] xmllite: Support streams starting with comments, simplify tests
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23771 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/3] xmllite: Implement PI parsing
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23770 Your paranoid android. === W2K8SE (32 bit reader) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [PATCH] kernel32: implement condition variables
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23769 Your paranoid android. === W2K8SE (32 bit sync) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] kernel32: improve condition variable testcase
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23768 Your paranoid android. === W2K8SE (32 bit sync) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: d3dx9_36: Make error_dxfile_to_d3dxfile() and test_templates() static.
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23767 Your paranoid android. === W2K8SE (32 bit xfile) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [cmd] Add beginnings of support for delayed expansion
by Marvin 06 Jan '13

06 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23766 Your paranoid android. === W2K8SE (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] advapi32: close hTemp on error (Coverity)
by Marvin 06 Jan '13

06 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23763 Your paranoid android. === W2K8SE (32 bit security) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [1/2] winedbg: Add modified immediate dataprocessing operators to Thumb2 disassembler
by André Hentschel 06 Jan '13

06 Jan '13

Am 06.01.2013 17:57, schrieb André Hentschel: > After that patch i'll consider the parser as fully implemented and every missing thing should be filed as a bug > i'm now planning to better detect which instructionsset we need to disassemble > > --- > programs/winedbg/be_arm.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 95 insertions(+) sry, wrong subject, i just sent a new one

1 0

Re: [PATCH 3/5] wined3d: state->user_stream is always FALSE in device_stream_info_from_declaration().
by Stefan Dösinger 06 Jan '13

06 Jan '13

Am 04.01.2013 um 12:02 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > Since user pointer draws were removed, state->user_stream will only ever be > set for "strided" draws, and device_stream_info_from_declaration() is never > called for those. I have some patches in my tree that remove draw_primitive_strided and user_stream entirely but didn't get around to sending them yet due to reasons unrelated to the patches. I think I should have time to rebase and send them on monday.

2 1

Re: comctl32/listview: support header images
by Nikolay Sivov 06 Jan '13

06 Jan '13

On 1/6/2013 02:55, Daniel Jelinski wrote: > They are unrelated, except by file modified, and I'm sending them as I > create them, but of course I can defer sending them a little. > Do you mean message sequence tests or something else? I tested that > visually with delphi, but I guess that's not what you're asking for. I mean to test that header gets image list after it's set for listview, and that same handle is reused. > > 2013/1/5 Nikolay Sivov <bunglehead(a)gmail.com>: >> On 1/6/2013 02:25, Daniel Jelinski wrote: >> >> This one needs tests. Also even if each patch applies cleanly, please send >> them in series, it makes it easier to review.

1 0

Re: comctl32/listview: support header images
by Nikolay Sivov 05 Jan '13

05 Jan '13

On 1/6/2013 02:25, Daniel Jelinski wrote: This one needs tests. Also even if each patch applies cleanly, please send them in series, it makes it easier to review.

1 0

Re: comctl32/listview: fix calculating item height
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23746 Your paranoid android. === W2K8SE (32 bit listview) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

3 2

Re: msvcrt/tests: Add a trailing '\n' to a win_skip() call.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23752 Your paranoid android. === W2K8SE (32 bit string) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23751 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23750 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23749 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23748 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23747 Your paranoid android. === W2K8SE (32 bit hlsl) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)
by Dmitry Timoshkov 05 Jan '13

05 Jan '13

Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > + BYTE buffer[MAX_PATH]; This should be WCHAR if you decided to test unicode version of the API (although testing ANSI variant would be much easier), that will help to avoid all those casts, and protect from insufficient buffer size. Also please use a font that exists in Wine, such as sserife.fon, but be prepared that it could be not found since font file name is locale dependent. -- Dmitry.

2 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel