- wine-devel - winehq.org

Re: [PATCH 5/5] ddraw/tests: Add some display mode set / restore tests with multiple ddraw objects.
by Marvin 16 Oct '12

16 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22275 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:2526: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2543: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2551: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2553: Test failed: Got unexpected screen width 800. ddraw2.c:2555: Test failed: Got unexpected screen height 600. ddraw2.c:2574: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2582: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2584: Test failed: Got unexpected screen width 800. ddraw2.c:2586: Test failed: Got unexpected screen height 600. ddraw2.c:2606: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2608: Test failed: Got unexpected screen width 800. ddraw2.c:2610: Test failed: Got unexpected screen height 600. ddraw2.c:2615: Test failed: Got unexpected screen width 800. ddraw2.c:2617: Test failed: Got unexpected screen height 600. ddraw2.c:2630: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2638: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2640: Test failed: Got unexpected screen width 800. ddraw2.c:2642: Test failed: Got unexpected screen height 600. ddraw2.c:2650: Test failed: Got unexpected screen width 800. ddraw2.c:2652: Test failed: Got unexpected screen height 600. ddraw2.c:2664: Test failed: SetDipslayMode failed, hr 0x887600e1. === WNT4WSSP6 (32 bit ddraw1) === ddraw1.c:2389: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2406: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2414: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2416: Test failed: Got unexpected screen width 800. ddraw1.c:2418: Test failed: Got unexpected screen height 600. ddraw1.c:2437: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2445: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2447: Test failed: Got unexpected screen width 800. ddraw1.c:2449: Test failed: Got unexpected screen height 600. ddraw1.c:2469: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2471: Test failed: Got unexpected screen width 800. ddraw1.c:2473: Test failed: Got unexpected screen height 600. ddraw1.c:2478: Test failed: Got unexpected screen width 800. ddraw1.c:2480: Test failed: Got unexpected screen height 600. ddraw1.c:2493: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2501: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2503: Test failed: Got unexpected screen width 800. ddraw1.c:2505: Test failed: Got unexpected screen height 600. ddraw1.c:2513: Test failed: Got unexpected screen width 800. ddraw1.c:2515: Test failed: Got unexpected screen height 600. ddraw1.c:2527: Test failed: SetDipslayMode failed, hr 0x887600e1.

1 0

Re: [PATCH] user32: Add tests showing that MapWindowPoints, ClientToScreen and ScreenToClient never fail.
by Henri Verbeet 16 Oct '12

16 Oct '12

On 16 October 2012 20:12, Christian Costa <titan.costa(a)gmail.com> wrote: > + //SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom / 2, 0); C99 comment. I don't think these are very interesting cases though, it's probably more interesting what happens with e.g. a destroyed window, or a fullscreen window.

3 3

Re: [PATCH] user32: Add tests showing that MapWindowPoints, ClientToScreen and ScreenToClient never fail.
by Austin English 16 Oct '12

16 Oct '12

On Tue, Oct 16, 2012 at 11:12 AM, Christian Costa <titan.costa(a)gmail.com> wrote: ... > + wnd = CreateWindowA("static", NULL, 0, 0, 0, rect.right / 2, rect.bottom / 2, 0, 0, 0, 0); > + //SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom / 2, 0); Leftover debug code. Cheers, Austin

2 1

Re: programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Mac OS/X
by Alexandre Julliard 16 Oct '12

16 Oct '12

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -403,6 +404,13 @@ static HRESULT convert_to_native_icon(IStream *icoFile, int *indices, int numInd > WINE_ERR("error 0x%08X creating IWICBitmapDecoder\n", hr); > goto end; > } > +#ifdef __APPLE__ > + hr = IWICImagingFactory_CreateBitmapScaler(factory, &scaler); > + if (FAILED(hr)) > + { > + WINE_WARN("error 0x%08X creating IWICBitmapScaler\n", hr); > + } > +#endif Please try to do that without adding #ifdefs in generic functions. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] cmd: Properly handle multibyte characters in batch files.
by Alexandre Julliard 16 Oct '12

16 Oct '12

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -244,7 +244,8 @@ WCHAR *WCMD_fgets(WCHAR *buf, DWORD noChars, HANDLE h) > > if (!WCMD_is_console_handle(h) && i != charsRead) { > /* Sets file pointer to the start of the next line, if any */ > - filepos.QuadPart += i + 1 + (buf[i] == '\r' ? 1 : 0); > + INT bytes = WideCharToMultiByte(GetConsoleCP(), 0, buf, i, NULL, 0, NULL, NULL); > + filepos.QuadPart += bytes + 1 + (buf[i] == '\r' ? 1 : 0); There's no guarantee that all characters would round-trip properly, this should be based on the original multibyte length somehow. -- Alexandre Julliard julliard(a)winehq.org

1 0

user32 tests patch
by Christian Costa 16 Oct '12

16 Oct '12

Forget my user32 patch. MapWindowPoints tests are wrong.

1 0

Re: [PATCH 2/6] d3dcompiler: Improve a Nvidia GPU recognition fallback.
by Matteo Bruni 16 Oct '12

16 Oct '12

Ehh, this patch should have been called something like "wined3d: Improve a Nvidia GPU recognition fallback.", but well...

1 0

Re: [PATCH 7/8] mshtml: Added IHTMLScriptElement::put_src tests
by Marvin 16 Oct '12

16 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22264 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: dwrite: Implement GetMetrics() for IDWriteFont
by Dmitry Timoshkov 16 Oct '12

16 Oct '12

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + static const WCHAR arialW[] = {'A','r','i','a','l',0}; Please don't use fonts which Wine doesn't provide. Testing Tahoma is fine. -- Dmitry.

2 1

Re: [PATCH] user32: Don't ignore return value of MapWindowPoints
by Nikolay Sivov 16 Oct '12

16 Oct '12

On 10/16/2012 04:10, danielfsantos(a)att.net wrote: > ScreenToClient should return zero if the operation fails, but is always > returning TRUE. This patch corrects the problem and solves a crash bug > in Lord of the Rings Online (bug #31979) > > Credit for this patch goes to some one else, as yet unidentified, since > it originally came from a closed forum for beta testers of the LoTRO > Riders of Rohan expansion and the forum has subsequently been wiped. > --- > dlls/user32/winpos.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c > index 5a2f1f2..3855b19 100644 > --- a/dlls/user32/winpos.c > +++ b/dlls/user32/winpos.c > @@ -250,8 +250,7 @@ BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt ) > */ > BOOL WINAPI ScreenToClient( HWND hwnd, LPPOINT lppnt ) > { > - MapWindowPoints( 0, hwnd, lppnt, 1 ); > - return TRUE; > + return MapWindowPoints( 0, hwnd, lppnt, 1 ) != 0; > } > This needs a test.

1 0

Re: [3/4] comctl32: fix notifications and return value when collapsing already collapsed node (rebased)
by Nikolay Sivov 15 Oct '12

15 Oct '12

Hi, Daniel. You forgot a patch.

2 1

Re: jscript: Move 'inline' to the beginning of the declaration.
by Francois Gouget 15 Oct '12

15 Oct '12

On Mon, 15 Oct 2012, Michael Stefaniuc wrote: [...] > --- a/dlls/jscript/jsstr.h > +++ b/dlls/jscript/jsstr.h > @@ -28,7 +28,7 @@ struct _jsstr_t { > > #define JSSTR_FLAG_NULLBSTR 1 > > -static unsigned inline jsstr_length(jsstr_t *str) > +inline static unsigned jsstr_length(jsstr_t *str) 'static inline' is the more common format in Wine (4166 occurences versus 0 for 'inline static'). But yes, moving it before the return type makes sense. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

1 0

Re: [2/4] comctl32: do not send TVN_ITEMEXPANDING when expanding item with no children
by Alexandre Julliard 15 Oct '12

15 Oct '12

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 4ce8e5ea93897e03e1c3bbd0be90c9179890a37a Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Thu, 27 Sep 2012 21:06:48 +0200 > Subject: comctl32/treeview: do not send TVN_ITEMEXPANDING when expanding item > with no children > > also, send it when re-expanding expanded item or re-collapsing collapsed one. > Tests in later commit (look for VK_ADD/VK_SUBSTRACT) This causes the explorerframe tests to hang. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3d9 implementation
by Luchezar Belev 15 Oct '12

15 Oct '12

hello i have been writing some d3d9/d3d8 implementation on top of opengl as a pet project i mainly work on it under windows, but also made it run under wine. i thought you guys might find it interesting to try it out. It works fine with all the games i got - there are no major problems. they are guild wars (1), wow, league of legends, tomb raider underworld, titan quest, skyrim. it requires opengl 3.3 or higher. attached is zip archive with binaries (2 files) and a readme. (i'm not sure i want to give away the sources yet.)

2 1

Re: [PATCH] d3d9/tests: Do not crash, when CreateTexture failed
by Henri Verbeet 15 Oct '12

15 Oct '12

On 14 October 2012 01:12, Detlef Riekenberg <wine.dev(a)web.de> wrote: > Needed to avoid a crash on an Intel integrated graphics. > http://test.winehq.org/data/ee59341721b90e58165a7bb12cbf2906fbd680d1/xp_dr-… > It should probably use CheckDeviceFormat() before even creating the device.

1 0

Re: vbscript: Added Chr implementation
by Marvin 15 Oct '12

15 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22203 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Dan Kegel 15 Oct '12

15 Oct '12

In general, patches to wine should have some demonstrated benefit, either by increasing the number of passing conformance tests, or by making some app work better, or both. Your current patch doesn't seem to do either of these things. Getting into a pissing match with AJ about patent and copyright law is not a good strategy for potential contributors to wine. He generally knows his stuff, and I think he's right in this case. If I were you, I'd go off and reflect for a while, then pick some other way to contribute.

3 4

Re: ole32/tests: Add tests for IRunnableObject_Run call.
by Dmitry Timoshkov 15 Oct '12

15 Oct '12

Roman Dadkov <romand(a)etersoft.ru> wrote: > + hr = CLSIDFromProgID(WordApp, &clsid); > + if (SUCCEEDED(hr)) > + { > + hr = CoCreateInstance(&clsid, NULL, CLSCTX_ALL, &IID_IUnknown, (void **)&pUnknown); > + ok_ole_success(hr, "CoCreateInstance"); > + > + hr = IUnknown_QueryInterface(pUnknown, &IID_IRunnableObject, (void**)&pRunnableObject); > + ok_ole_success(hr, "IUnknown_QueryInterface"); > + if (FAILED(hr)) Shouldn't 'SUCCEEDED(hr)' be used here instead? > + { > + hr = IRunnableObject_Run(pRunnableObject, NULL); > + ok_ole_success(hr, "IRunnableObject_Run"); > + } > + } Probably you should add Release() calls where appropriate. -- Dmitry.

1 0

Fwd: Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Max TenEyck Woodbury 13 Oct '12

13 Oct '12

On 10/12/2012 10:25 PM, Dan Kegel wrote: > Hi Max, > here's a little test program that shows that your patch changes how > UIntToPtr works: > > #include <stdio.h> > #include <stdint.h> > > #define UIntToPtrA(i) ((void *)(intptr_t)((unsigned int)i)) > #define UIntToPtrB(i) ((void *)(intptr_t)(i)) > > int main(int argc, char **argv) > { > short x = 65534; > printf("%d -> %p\n", x, UIntToPtrA(x)); > printf("%d -> %p\n", x, UIntToPtrB(x)); > return 0; > } > > On a 64 bit machine, this outputs > > -2 -> 0xfffffffe > -2 -> 0xfffffffffffffffe > > This could change the behavior of functions that call UIntToPtr, like > say EnumResourceTypesA(). > > I would suggest writing a conformance test to expose whether the > change brings Wine closer to native behavior, or further away, adding > that to your patch, and then verifying with winetestbot that the patch > improves wine's conformance. > > My guess is that the current behavior is right, but hey, the test will > show what's really up. > - Dan > I 'greped' the entire wine tree for uses of these macros. There was only a couple places where the argument was an expression and in those cases I did not see that the change would cause problems. Frankly, I do not think I could come up with a test where the change would make a difference. I am submitting the patch against the weird possibility that such a case does exist. The change is strictly preventative maintenance with just a hint of aesthetic improvement to make them coordinate with the 'Handle' variants of these macros. Now, if you are going to tell me that these definitions were *copied* from a Microsoft *source* rather than derived from a Microsoft specification, you would have a point, but then there would be a whole bunch of copyright issues that would need to be worked through.

2 2

Fwd: Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Max TenEyck Woodbury 13 Oct '12

13 Oct '12

On 10/12/2012 09:49 PM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > >>>> -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) >>>> -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) >>>> -#define LongToPtr(l) ((void *)(LONG_PTR)((LONG)l)) >>>> -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)ul)) >>>> +#define IntToPtr(i) ((void *)(INT_PTR)(i)) >>>> +#define UIntToPtr(ui) ((void *)(UINT_PTR)(ui)) >>>> +#define LongToPtr(l) ((void *)(LONG_PTR)(l)) >>>> +#define ULongToPtr(ul) ((void *)(ULONG_PTR)(ul)) >>> >>> You forgot to explain what's bad with it. >>> >> >> The original applied the extra conversion to ONLY THE FIRST >> component of the expression, not to the WHOLE expression. That >> can (although it's not likely to) cause hard to diagnose problems. > > What 'the first component' are you talking about? This code is win32 only. > 'i', 'ui', 'l' and 'ul' are parameters to the macros, When the macros are used, you put in an expression as the argument to the macro. As originally written for example, the cast to LONG in ((LONG)l) is applied to only the first component of the expression substituted in place of 'l'. In order to get the cast to apply to the whole expression, you need parenthesis around the parameter. That is literally (l). Then the cast applies to the whole expression. That is (LONG_PTR)(l) casts the entire expression substituted into 'l' to a LONG_PTR value. The macros that convert to 'Handle' rather than 'Ptr' do this properly. In the vast majority of cases the expression substituted into 'l' is a simple variable and there is no problem. In almost all of the remaining cases, casting the first element of the expression coerces the rest of the expression to the proper type. In rare cases, other elements of the expression might force the expression's value to some other type. In most of those cases the cast to LONG_PTR fixes the problem. In a really odd case there might be a problem caused by the extra cast to LONG. Since that cast is buried in a macro definition, it will be difficult to spot that cast as the source of such a problem from the source code. The original definitions include three casts in sequence. The first of those casts is done improperly. Even if it were done properly, the next cast in the sequence makes it redundant. I removed the improper cast since it IS redundant. NUFF SAID?

1 0

Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Dmitry Timoshkov 13 Oct '12

13 Oct '12

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) > -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) > -#define LongToPtr(l) ((void *)(LONG_PTR)((LONG)l)) > -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)ul)) > +#define IntToPtr(i) ((void *)(INT_PTR)(i)) > +#define UIntToPtr(ui) ((void *)(UINT_PTR)(ui)) > +#define LongToPtr(l) ((void *)(LONG_PTR)(l)) > +#define ULongToPtr(ul) ((void *)(ULONG_PTR)(ul)) You forgot to explain what's bad with it. -- Dmitry.

3 3

Re: [PATCH] regedit: err() on printing
by Dmitry Timoshkov 12 Oct '12

12 Oct '12

Marcus Meissner <meissner(a)suse.de> wrote: > + ERR("printing is not yet implemented.\n"); Printing a FIXME seems more appropriate. -- Dmitry.

2 1

Re: TestBot job 22150 results: [2/3] dwrite: Implement GetWeight() for IDWriteFont
by Nikolay Sivov 12 Oct '12

12 Oct '12

This is caused by previously committed patches while testbot was resting, I'll fix these failures after today series gets in if it's okay.

1 0

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)
by Dmitry Timoshkov 12 Oct '12

12 Oct '12

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > * Renamed DUMMYUNIONNAME to u. ... > +typedef struct _FILE_ID_DESCRIPTOR { > + DWORD dwSize; > + FILE_ID_TYPE Type; > + union { > + LARGE_INTEGER FileId; > + GUID ObjectId; > + } u; > +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR; This change is clearly wrong. -- Dmitry.

3 5

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.
by Charles Davis 12 Oct '12

12 Oct '12

On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: > This patch alone makes SunSpider 0.9 17x faster. Seems to me that something is really wrong with our BSTR implementation if replacing it with a home-grown implementation speeds this up by a factor of 17. Chip

2 1

Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)
by Henri Verbeet 12 Oct '12

12 Oct '12

On 9 October 2012 11:26, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > scrrun: Implement IDictionary_Add and Count > Actually, does it ever make sense to use a linked list at all to implement a dictionary? It seems to me that if you only ever have a handful of entries a simple array would be better suited, while if you have more than that you'd want some kind of search tree or a hash table.

3 2

Fwd: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)
by Per Johansson 12 Oct '12

12 Oct '12

On Fri, Oct 12, 2012 at 8:48 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > I will have a look at some sort of hash table. > I'd use wine existing tree implementation, unless there's some specific reason to use a hash table. Hash tables are good in theory but with in practice trees are just as effective in my experience (especially AVL trees). Regards, -- Per Johansson

1 0

Re: [PATCH] amstream: Display new ref in AddRef and Release.
by Nikolay Sivov 12 Oct '12

12 Oct '12

On 10/12/2012 00:46, Christian Costa wrote: > --- > dlls/amstream/mediastreamfilter.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilter.c > index ee9d970..0e56a68 100644 > --- a/dlls/amstream/mediastreamfilter.c > +++ b/dlls/amstream/mediastreamfilter.c > @@ -133,17 +133,21 @@ static HRESULT WINAPI MediaStreamFilterImpl_QueryInterface(IMediaStreamFilter *i > > static ULONG WINAPI MediaStreamFilterImpl_AddRef(IMediaStreamFilter *iface) > { > - return BaseFilterImpl_AddRef((IBaseFilter*)iface); > + ULONG ref = BaseFilterImpl_AddRef((IBaseFilter*)iface); > + > + TRACE("(%p)->(): new ref = %u\n", iface, ref); > + > + return ref; > } You should get rid of casts like that. Also I don't see a reason to print anything but refcount itself life (%p)->(%u). > > static ULONG WINAPI MediaStreamFilterImpl_Release(IMediaStreamFilter *iface) > { > IMediaStreamFilterImpl *This = impl_from_IMediaStreamFilter(iface); > - ULONG refCount = BaseFilterImpl_Release((IBaseFilter*)iface); > + ULONG ref = BaseFilterImpl_Release((IBaseFilter*)iface); > > - TRACE("(%p)->() Release from %d\n", iface, refCount + 1); > + TRACE("(%p)->(): new ref = %u\n", iface, ref); > > - if (!refCount) > + if (!ref) > { > int i; > for (i = 0; i < This->nb_streams; i++) > @@ -154,7 +158,7 @@ static ULONG WINAPI MediaStreamFilterImpl_Release(IMediaStreamFilter *iface) > HeapFree(GetProcessHeap(), 0, This); > } > > - return refCount; > + return ref; > } > > /*** IPersist methods ***/ > > > >

2 1

Re: [PATCH] amstream: Check params in IAMMultiMediaStreamImpl_OpenFile.
by Nikolay Sivov 12 Oct '12

12 Oct '12

On 10/12/2012 00:59, Christian Costa wrote: > --- > dlls/amstream/amstream.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > > - TRACE("(%p/%p)->(%s,%x)\n", This, iface, debugstr_w(pszFileName), dwFlags); > + TRACE("(%p/%p)->(%s,%x)\n", This, iface, debugstr_w(filename), flags); > + > + if (!filename) > + return E_POINTER; > + > + if (flags & ~(AMMSF_NOCLOCK | AMMSF_NORENDER | AMMSF_RENDERALLSTREAMS | AMMSF_RENDERTOEXISTING | AMMSF_RUN)) > + return E_INVALIDARG; This needs tests.

1 0

Re: [1/3] cmd/tests: Show name of current test file on standard output
by Alexandre Julliard 11 Oct '12

11 Oct '12

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > When there are several test files, indicates which file error line numbers relate to, making > "debugging" easier. That's what trace() is for. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: use HandleToULong inline function to convert handle to index instead of casting
by Dmitry Timoshkov 11 Oct '12

11 Oct '12

Daniel Lehman <dlehman(a)esri.com> wrote: > 0xffffffff000026a8 becomes 0xc00009aa instead of just 0x9aa It can't, the code explicitly casts handle to unsigned before the shift. -- Dmitry.

3 2

Re: [2/2] shlwapi/tests: Add more PathCreateFromUrl() tests.
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22127 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.
by Henri Verbeet 11 Oct '12

11 Oct '12

On 11 October 2012 12:16, Jacek Caban <jacek(a)codeweavers.com> wrote: > > +struct _jsstr_t { > + unsigned length_flags; > + unsigned ref; > + WCHAR str[1]; > +}; It's probably much too late for jscript, and perhaps Wine in general, but strictly speaking the _t suffix is reserved by POSIX.

2 1

Re: [PATCH 5/6] mshtml: Added createStyleSheet and get_styleSheet tests
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22123 Your paranoid android. === WVISTAADM (32 bit dom) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: msvcp90: fix parsing in num_get<>::_Getifld
by Piotr Caban 11 Oct '12

11 Oct '12

On 10/11/12 00:27, Daniel Lehman wrote: - if(!base && first->strbuf && first->val==digits[0]) { + if(first->strbuf && first->val==digits[0]) { + found_zero = TRUE; istreambuf_iterator_wchar_inc(first); if(first->strbuf && (first->val==mb_to_wc('x', &this->cvt) || first->val==mb_to_wc('x', &this->cvt))) { There's a comparision to 'x' 2 times, one of them should be 'X'. Cheers, Piotr

1 0

Re: [PATCH 17/25] winmm/tests: Add initial set of MCI MIDI tests (incl. DeleteFile)
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22026 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 4/4] mshtml: Added IHTMLDocument::get_charset implementation
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22114 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] dinput/tests: Test for DIPROP_INSTANCENAME and DIPROP_GUIDANDPATH
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22112 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: wined3d: recognize Radeon HD 6670
by Henri Verbeet 11 Oct '12

11 Oct '12

On 5 October 2012 22:12, Austin English <austinenglish(a)gmail.com> wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=31891 > That doesn't look right (and doesn't do what you think it does anyway), did you verify this against the Windows driver? It probably just needs an entry to map "HD 6670" to CARD_AMD_RADEON_HD6600, although it's a bit curious that most of the existing entries for NI have generic strings like "HD 6600".

2 1

Re: shell32: Standardize on the ShellExecuteEx() terminology.
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22104 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: shell32/tests: Test ShellExecute()'s URL handling.
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22103 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1438: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' shlexec.c:1790: Test failed: ShellExecute(file="notaproto://foo") succeeded: rc=2 shlexec.c:1793: Test failed: ShellExecute(file="fakeproto://foo/bar") expected SE_ERR_ACCESSDENIED got rc=2 shlexec.c:152: Test failed: ShellExecute(file="shlproto://foo/bar") Got different return value with empty string: 42 2 shlexec.c:152: Test failed: ShellExecute(file="shlproto://foo/bar.lnk") Got different return value with empty string: 42 2 shlexec.c:1822: Test failed: argvA4 expected 'shlproto://C:\TEMP\wt1.tmp/bar', got 'shlproto://%TMPDIR%/bar' shlexec.c:137: Test failed: ShellExecute(file="file://shlproto://foo/bar") WaitForSingleObject returned 258 shlexec.c:152: Test failed: ShellExecute(file="file://shlproto://foo/bar") Got different return value with empty string: 42 2 shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=42 === W2KPROSP4 (32 bit shlexec) === shlexec.c:1438: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' shlexec.c:1822: Test failed: argvA4 expected 'shlproto://C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp/bar', got 'shlproto://%TMPDIR%/bar' shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=5 === WVISTAADM (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W2K8SE (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W7PRO (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W7PROX64 (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === TEST64_W7SP1 (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W7PROX64 (64 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === TEST64_W7SP1 (64 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2

1 0

Re: vbscript: Fixed tests on some non-English configs (without '.' as decimal point)
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22091 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Undefined variables resolve as EMPTY without Option Explicit
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22090 Your paranoid android. === W2KPROSP4 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === WXPPROSP3 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W2K3R2SESP2 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W7PROX64 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === TEST64_W7SP1 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W7PROX64 (64 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === TEST64_W7SP1 (64 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5"

1 0

Re: shell32: Fix ShellExecute()'s handling of file URLs.
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22079 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1440: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1440: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: shell32/tests: Simplify shlexec's test_directory() and add some more tests.
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22078 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: d3dx9_36 [patch 5/5, try 3]: Implement D3DXSHEvalSphericalLight
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:49, Nozomi Kodama wrote: > math.c:2994: Test failed: Red: case 9, order 7: expected[10] = 0.000000, > received -134495294795062701298349336420239278080.000000 > math.c:2994: Test failed: Red: case 9, order 7: expected[15] = 0.000000, > received -131556728585661638158151798785793064960.000000 But the values are different each time? So no app could depend on the returned values? Does this implementation return the same values? Is everyone else ok with accessing the array out of bounds? > > + for (i = 0; i < order ; i++) > > + scale = cap[i] * coeff[i]; > > + for (order = D3DXSH_MINORDER ; order <= D3DXSH_MAXORDER; order++) Spaces. These are also in the D3DXSHEvalConeLight patch. Is there a point against using the same coeff variables in D3DXSHEvalConeLight and D3DXSHEvalSphericalLight? Maybe they should be static or the capintegral simply should integrate the multiplication if the capintegral function is only used in these two functions. I think there is no need to add the same variables twice. > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; sqrtf .... These are also in the D3DXSHEvalConeLight patch. Does the compiler optimize the function call away to a constant value? If not it may be better to use something like 1.7724538509f for sqrtf(pi)... Cheers Rico

1 0

Re: msvcp90: in codecvt<wchar_t>::do_out, copy local buffer to *to_next
by Piotr Caban 10 Oct '12

10 Oct '12

On 10/10/12 19:42, Daniel Lehman wrote: + memcpy_s(*to_next, MB_LEN_MAX, buf, size); You may use memory after to_end in this code. to_next buffer size should be probably following: memcpy_s(*to_next, to_end-to_next, buf, size); Cheers, Piotr

1 0

Re: [PATCH 5/5] kernel32: Added implementation for OpenFileById.
by Dmitry Timoshkov 10 Oct '12

10 Oct '12

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > + objectName.Buffer = (WCHAR *)&lpFileID->DUMMYUNIONNAME.FileId; This doesn't look right. > + if (status) > + { > + SetLastError( RtlNtStatusToDosError( status ) ); > + return INVALID_HANDLE_VALUE; > + } > + else if (!result) > + { > + return INVALID_HANDLE_VALUE; > + } > + else > + { > + return result; > + } It looks like some braces and all 'else' statements may go. -- Dmitry.

2 2

Re: [PATCH 3/3] vbscript: Added RTrim implementation
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22088 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Add more font transformation tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22066 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel