- wine-devel - winehq.org

Re: gdiplus: Add more font transformation tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22066 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22064 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22063 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] shell32/tests: Some more type consistency fixes for the ShellExecute() return value checks.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22057 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22056 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] shell32/tests: Improve the shell_execute{_ex}() tracing.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22055 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] shell32/tests: Fix test_one_cmdline() and add a few more tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22054 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d10: Handle blend state in d3d10_effect_object_apply().
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22053 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: mshtml: Return dispinterface from PHEventSink::QueryInterface
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22047 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: vbscript: Added CStr implementation
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22046 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] windowscodecs: Test GIF metadata using a specially created GIF image with a bunch of extensions.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22045 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] windowscodecs: Add a bunch of tests for GIF Comment Extenstion metadata reader.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22044 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] gdiplus: Add a font transformation test.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22043 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [6/6] dwrite: Implement GetString()
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22042 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [5/6] dwrite: Implement GetStringLength method
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22041 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/6] dwrite: Added IDWriteFontFace stub
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22040 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/6] dwrite: Added IDWriteLocalizedStrings stub
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22039 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/6] dwrite: Store font family name in IDWriteFontFamily implementation
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22038 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 25/25] mciseq: MCI tempo is expressed in beats per minute, not microseconds.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22031 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: oledb32: Add IDBProperties support in IDBInitialize
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22030 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 18/25] winmm/tests: Add more MCI MIDI tests (auto-open).
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22027 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 17/25] winmm/tests: Add initial set of MCI MIDI tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22025 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/3] shell32/tests: Greatly expand the test_argify() tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22024 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] shell32/tests: Merge shlexec's test_exes_long() with the other parameter passing tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22023 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] ole32: Implement StgConvertVariantToProperty.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22019 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] ole32: Add tests for StgConvertVariantToProperty.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22018 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] winemaker: Generate def file from spec file with winebuild (try 2)
by Alexandre Julliard 10 Oct '12

10 Oct '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2569,6 +2570,7 @@ sub generate_project_files($) > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.def)\n"; > } elsif (@$target[$T_TYPE] == $TT_DLL) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.spec)\n"; > + print FILEO "\t\$(WINEBUILD) --def -E \$(${canon}_MODULE:.dll=.spec) -o lib\$(${canon}_MODULE:.dll=.def)\n"; That's not much better. You should have a proper target for it, and a dependency from the modules that import that dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 2/5, try 3]: Implement D3DXSHEvalHemisphereLight
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:44, Nozomi Kodama wrote: > + if ( green_out ) Same as last time: I'd use "if (x == y)" without spaces on all occurrences... there are a couple of them in the patch! Please make all consistent in the patch.

1 0

Re: d3dx9_36 [patch 3/5, try 3]: Implement handy computations for small orders in D3DXSHRotate
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:45, Nozomi Kodama wrote: > + CONST FLOAT coeff[]={ > > + out[7] -= (matrix->u.m[1][0] * matrix->u.m[0][2] + matrix->u.m[1][2] * matrix->u.m[0][0]) * in[4]; > + > + out[7] += (matrix->u.m[1][0] * matrix->u.m[2][2] + matrix->u.m[1][2] * matrix->u.m[2][0]) * in[5]; Empty line too much? > + for ( l = 0; l < 1; l++) > > + if (l == 0) > + out_temp = out; > + else > + out_temp = in; The test change is completely new in the try... What do you like to achieve with this? l is always 0, isn't it? Beside this, there are some white space issues.

1 0

Re: [PATCH 1/5] include: Added definitions used by GetFileInformationByHandleEx.
by Dmitry Timoshkov 10 Oct '12

10 Oct '12

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > +typedef struct _FILE_ID_DESCRIPTOR { > + DWORD dwSize; > + FILE_ID_TYPE Type; > + union { > + LARGE_INTEGER FileId; > + GUID ObjectId; > +#if (_WIN32_WINNT >= 0x0602) > + EXT_FILE_ID_128 ExtendedFileId; > +#endif > + } DUMMYUNIONNAME; > +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR; The '#if/#endif' part is useless in Wine (here in in other places as well). Also you should add new structures in every patch that needs them, one by one, not adding a bunch of not used stuff at once. P.S. In PSDK 7.1 (targeting Windows 7) some of the structures look different. Where does this come from? -- Dmitry.

1 0

Wine test bot
by Christian Costa 09 Oct '12

09 Oct '12

Hi, Is there a problem with Wine test bost? Jobs seem to be stuck and some VMs show problem of memory. Christian

1 1

Re: wbemprox: support for getting methods from WBEM objects
by Hans Leidekker 09 Oct '12

09 Oct '12

On Tue, 2012-10-09 at 20:30 +0200, Daniel Jelinski wrote: > diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c > index c414aa9..71c62c8 100644 > --- a/dlls/wbemprox/table.c > +++ b/dlls/wbemprox/table.c > @@ -63,6 +63,7 @@ UINT get_type_size( CIMTYPE type ) > return sizeof(INT64); > case CIM_DATETIME: > case CIM_STRING: > + case CIM_OBJECT: > return sizeof(WCHAR *); This should be fixed differently. I already have a patch in my tree.

1 0

Updated Wine Wiki Repo
by Kyle Auble 09 Oct '12

09 Oct '12

Just wanted to let everyone know I've created a git repo for the Wine Wiki from the CVS one at SourceForge. You can find it at: https://bitbucket.org/kauble/wine-wiki-migration Since it's a fresh repo, I thought editing the history should be ok (just moved the right info into Author & Committer fields and made the commit message formatting more consistent). I do still have the unedited branches from cvsimport and can put those up too if there's any demand for them. I've been talking with Dimi about what we would need to upgrade MoinMoin, and once he can find some time, he said he would setup a regular archive of the Wine Wiki's data. I also like the idea of using tags to mark which wiki version is in use, but I'm not sure how many times the wiki has been upgraded. If anyone knows what versions of MoinMoin we've used and when the upgrades took place, I can add the extra tags. I don't know if there's much interest in just moving this to the Wine git repo yet. If not, I can probably review patches, but would be happy to add someone else as an admin if they have a bitbucket account. - Kyle

4 6

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run. (try 2)
by Austin English 09 Oct '12

09 Oct '12

On Tue, Oct 9, 2012 at 4:27 AM, Roman Dadkov <romand(a)etersoft.ru> wrote: > This patch change dwClsContext parameter of a CoCreateInstance call in > function DefaultHandler_Run. > Because even if there is some clsid in the registry, the function will not > be able to run the newly created object. > Unfortunately, the test for this case can't be added to Wine, because it > leads a crash. You could put the test inside if(0), so that it's still documented, see, for example, dlls/ole32/tests/stg_prop.c or dlls/user32/tests/input.c. Cheers, Austin

1 0

Re: d3dx9_36 [patch 5/5]: Implement D3DXSHEvalSphericalLight
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:50, Nozomi Kodama wrote: > + CONST FLOAT coeff[6] = { > + 2.0f * sqrtf(D3DX_PI), 2.0f * sqrtf(D3DX_PI / 3.0f), 0.4f * sqrtf(5.0f * D3DX_PI), > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; Pretty much the same comments as for D3DXSHEvalConeLight apply here too. Beside that, does it make sens to define the coeffs with a better name as static and reuse them? They seem to be the same for both usages. Cheers Rico

1 0

Re: d3dx9_36 [patch 4/5]: Implement D3DXSHEvalConeLight
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:50, Nozomi Kodama wrote: > +static void CapIntegrale(FLOAT *out, FLOAT order, FLOAT angle) > +{ I'd use a lower case name. > + if (order == 5) > + return; Indentation. If you break to a new line, please indent 8 spaces (in the case for ok(...)). > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; sqrtf. > + FLOAT cap[6], clamped_angle, norm, scale, temp[36]; No need for temp/scale? (see below) > + TRACE("order %u, dir %p, radius %f, red %f, green %f, blue %f, rout %p, gout %p, bout %p\n", order, dir, radius, Rintensity, Gintensity, Bintensity, rout, gout, bout); Long line. Please break. > + for (i = 0; i < order ; i++) Space. > + if (gout) > + for (i = 0; i < order; i++) > + { > + scale = cap[i] * Gintensity * coeff[i] / norm; > + for (j = 0; j < 2 * i + 1; j++) > + gout[i * i + j] = temp[i * i + j] * scale; > + } > + > + if (bout) > + for (i = 0; i < order; i++) > + { > + scale = cap[i] * Bintensity * coeff[i] / norm; > + for (j = 0; j < 2 * i + 1; j++) > + bout[i * i + j] = temp[i * i + j] * scale; > + } Pretty much the same calculation is done again and again. What happens if order is 100? You'll get a access violation. This is also true for cap and coeff in my sample here (It needs some tests ... Order may be clamped to D3DXSH_MAXORDER ... Does native crash in that case? Should we touch the values for order >= D3DXSH_MAXORDER at all?): D3DXSHEvalDirection(rout, order, dir); for (i = 0; i < order; i++) { FLOAT scale = cap[i] * coeff[i] / norm; for (j = 0; j < 2 * i + 1; j++) { FLOAT temp = rout[i * i + j] * scale; rout[i * i + j] = temp * Rintensity; if (gout) gout[i * i + j] = temp * Gintensity; if (bout) bout[i * i + j] = temp * Bintensity; } } Cheers Rico

1 0

Re: d3dx9_36 [patch 3/5]: Implement handy computations for small orders in D3DXSHRotate
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:49, Nozomi Kodama wrote: > + FLOAT temp[25]; > + CONST FLOAT coeff[]={ > + matrix->u.m[1][0] * matrix->u.m[0][0], matrix->u.m[1][1] * matrix->u.m[0][1], > + matrix->u.m[1][1] * matrix->u.m[2][1], matrix->u.m[1][0] * matrix->u.m[2][0], > + matrix->u.m[2][0] * matrix->u.m[2][0], matrix->u.m[2][2] * matrix->u.m[2][2], > + matrix->u.m[2][1] * matrix->u.m[2][1], matrix->u.m[0][0] * matrix->u.m[2][0], > + matrix->u.m[0][1] * matrix->u.m[2][1], matrix->u.m[0][1] * matrix->u.m[0][1], > + matrix->u.m[1][0] * matrix->u.m[1][0], matrix->u.m[1][1] * matrix->u.m[1][1], > + matrix->u.m[0][0] * matrix->u.m[0][0], matrix->u.m[1][2] * matrix->u.m[1][2], }; > > + out[4] = temp[0] * in[4] + temp[1] * in[5] + temp[2] * in[6] + temp[3] * in[7] + temp[4] * in[8]; Do we really need that much temps? They aren't reused? What are the coeff used for and why are they calculated separately? Are those variables used more than once (coeff[5] and [13] are only used once), maybe it's a mathematical background? What about something like: temp = (matrix->u.m[1][1] * matrix->u.m[0][0] + matrix->u.m[0][1] * matrix->u.m[1][0]) * in[4]; temp -= (matrix->u.m[1][0] * matrix->u.m[2][1] + matrix->u.m[1][1] * matrix->u.m[2][0]) * in[5]; temp += ... out[4] = temp; (using out[4] += may also work, but I'm not sure for cases where in = out, if it's working, we don't need the temp at all, it may be needed to reorder the calculation in that case to start with the index needed in the result ... out[5] = y * in[5]; out[5] += x * in[4]; out[5] += z * in[6]; ...). Cheers Rico

1 0

Re: gdiplus: Add more font transformation tests.
by Vincent Povirk 09 Oct '12

09 Oct '12

> +todo_wine > + expectf(133.203125, bounds.Height); Should we have this level of precision in our font tests?

2 1

Re: d3dx9_36 [patch 2/5]: Implement D3DXSHEvalHemisphereLight
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:49, Nozomi Kodama wrote: > +HRESULT WINAPI D3DXSHEvalHemisphereLight(UINT order, CONST D3DXVECTOR3 *dir, D3DXCOLOR top, D3DXCOLOR bottom, FLOAT *rout, FLOAT *gout, FLOAT *bout) The number of columns used for the code seems to be a little high again. > + if (j >= 4 && j < order * order) > + expected = 0.0f; > + else if ( j >= order * order ) I'd use "if (x == y)" without spaces on all occurrences... there are a couple of them in the patch. Cheers Rico

1 0

Fwd: Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run.
by Nikolay Sivov 09 Oct '12

09 Oct '12

Forwarding to wine-devel as well P.S. Roman, please reply to wine-devel list next time. -------- Original Message -------- Subject: Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run. Date: Tue, 09 Oct 2012 15:27:10 +0400 From: Roman Dadkov <romand(a)etersoft.ru> Organization: Etersoft To: Nikolay Sivov <bunglehead(a)gmail.com> Yes, it's my fail, I forgot, that can be use one enumeration CLSCTX_ALL in this case. Unfortunately, the test for this case can't be added to Wine, because it leads a crash. But I have attached a small test program that shows a problem. It uses CLSID which entered into the registry after installing Office using Wine. Nikolay Sivov 08.10.2012 10:07: > On 10/6/2012 19:29, Roman Dadkov wrote: >> This patch change dwClsContext parameter of a CoCreateInstance call >> in function DefaultHandler_Run. >> Because even if there is some clsid in the registry, the function >> will not be able to run the newly created object. >> >> >> >> - hr = CoCreateInstance(&This->clsid, NULL, CLSCTX_LOCAL_SERVER, >> + hr = CoCreateInstance(&This->clsid, NULL, >> + CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER| >> + CLSCTX_LOCAL_SERVER|CLSCTX_REMOTE_SERVER, >> &IID_IOleObject, (void **)&This->pOleDelegate); > This could be replaced with CLSCTX_ALL. > > Is it possible to add a test for that?

1 0

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run.
by Roman Dadkov 09 Oct '12

09 Oct '12

Unfortunately, the test for this case can't be added to Wine, because it leads a crash. But I have attached a small test program that shows a problem. It uses CLSID which entered into the registry after installing Office using Wine.

1 0

Re: [3/3] winemaker: Generate def file from spec file with winebuild
by Alexandre Julliard 09 Oct '12

09 Oct '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2576,7 +2577,9 @@ sub generate_project_files($) > if (@$target[$T_TYPE] == $TT_DLL && (@$project_settings[$T_FLAGS] & $TF_HASDEF)) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.def)\n"; > } elsif (@$target[$T_TYPE] == $TT_DLL) { > - print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.spec)\n"; > + print FILEO "lib\$(${canon}_MODULE:.dll=.def): \$(${canon}_MODULE:.dll=.spec)\n"; > + print FILEO "\t\$(WINEBUILD) --def -E \$(${canon}_MODULE:.dll=.spec) -o lib\$(${canon}_MODULE:.dll=.def)\n\n"; > + print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.spec) lib\$(${canon}_MODULE:.dll=.def)\n"; The .so doesn't depend on the .def. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Fix the edit class extra byte count on non-x86 platforms (try 2)
by Alexandre Julliard 08 Oct '12

08 Oct '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -5173,10 +5173,10 @@ const struct builtin_class_descr EDIT_builtin_class = > editW, /* name */ > CS_DBLCLKS | CS_PARENTDC, /* style */ > WINPROC_EDIT, /* proc */ > -#ifdef __i386__ > - sizeof(EDITSTATE *) + sizeof(WORD), /* extra */ > -#else > +#ifdef _WIN64 > sizeof(EDITSTATE *), /* extra */ > +#else > + sizeof(EDITSTATE *) + sizeof(WORD), /* extra */ > #endif Why do you need that? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/2] gdi32/tests: Fixed broken tests on non English system Part 2.
by Qian Hong 08 Oct '12

08 Oct '12

Hello Dmitry, Any feedback for this patch? Thanks a lot for any comments! On Thu, Oct 4, 2012 at 3:02 PM, Qian Hong <fracting(a)gmail.com> wrote: > Dmitry, could you review this patch? Thanks a lot ;-) > > This series of patch fix some broken tests on Japanese Windows and Chinese Windows: -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

2 2

Re: [1/3] scrrun: Implement IDictionary_Add and Count
by Alexandre Julliard 08 Oct '12

08 Oct '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > static HRESULT WINAPI dictionary_get_Count(IDictionary *iface, LONG *pCount) > { > dictionary *This = impl_from_IDictionary(iface); > > - FIXME("(%p)->(%p)\n", This, pCount); > + TRACE("(%p)->(%p)\n", This, pCount); > > - *pCount = 0; > + *pCount = list_count(&This->items); You don't want to use list_count(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] gdiplus: Add a font transformation test.
by Vincent Povirk 08 Oct '12

08 Oct '12

Series looks good to me.

1 0

Re: [3/4] ole32: Move the propvariant serialization into a helper function.
by Alexandre Julliard 08 Oct '12

08 Oct '12

Vincent Povirk <madewokherd(a)gmail.com> writes: > From eb900b2807167f25ad8f4e97c558dec8b71b070c Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Thu, 4 Oct 2012 16:58:48 -0500 > Subject: [PATCH 3/4] ole32: Move the propvariant serialization into a helper > function. It doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so suminfo.c && touch suminfo.ok suminfo.c:441: Test succeeded inside todo block: value incorrect suminfo.c:450: Test failed: MsiSummaryInfoSetProperty failed 0 make: *** [suminfo.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Add retail NVIDIA GeForce GTX 660Ti/660/650
by Henri Verbeet 08 Oct '12

08 Oct '12

On 8 October 2012 03:52, Jimmy Hon <honyuenkwun(a)gmail.com> wrote: > + CARD_NVIDIA_GEFORCE_GTX650 = 0x0FC6, > + CARD_NVIDIA_GEFORCE_GTX660 = 0x11C0, > + CARD_NVIDIA_GEFORCE_GTX660TI = 0x1183, Please use lower case constants like everywhere else.

1 0

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run.
by Nikolay Sivov 08 Oct '12

08 Oct '12

On 10/6/2012 19:29, Roman Dadkov wrote: > This patch change dwClsContext parameter of a CoCreateInstance call in > function DefaultHandler_Run. > Because even if there is some clsid in the registry, the function will > not be able to run the newly created object. > > > - hr = CoCreateInstance(&This->clsid, NULL, CLSCTX_LOCAL_SERVER, > + hr = CoCreateInstance(&This->clsid, NULL, > + CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER| > + CLSCTX_LOCAL_SERVER|CLSCTX_REMOTE_SERVER, > &IID_IOleObject, (void **)&This->pOleDelegate); This could be replaced with CLSCTX_ALL. Is it possible to add a test for that?

1 0

Re: iphlpapi/tests: Skip tests if functions are not supported
by Dmitry Timoshkov 08 Oct '12

08 Oct '12

André Hentschel <nerv(a)dawncrow.de> wrote: > For Mac, BSD, Solaris If it's Wine specific, then probably there shouild be a todo_wine somewhere to make it clear that under Windows there is no skips. -- Dmitry.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel