- wine-devel - winehq.org

Please remove this email address
by Ken Sharp 07 Oct '12

07 Oct '12

Hi, I have been receiving daily digests from this mailbox for a while. I tried emailing the "list owner" according to the website but that had no effect. I have been filtering the digests away so I didn't see that people had replied (thanks to everyone who did, sorry I haven't replied). I have tried changing the preferences but it just tells me that this email address doesn't exist. I can't do anything with this. Could someone with relevant access please remove me so that I can add myself again, properly? Thanks, Ken

1 0

Help getting amd64 assembly patch into wine?
by Joerg-Cyril.Hoehle＠t-systems.com 06 Oct '12

06 Oct '12

Dan, I found your message very unclear. >The patch adds support for OpenMP programs like this: And then you start talking about vcomp_fork without telling us where it comes from and what it should do. So I'll guess from the names. - vcomp_for_static/sections_init sound like startup code initialisation of BSS and DATA segments. - fork sounds like running code with thread-local copies to BSS and DATA I guess vcomp eats up one register or parameter to keep a pointer to the thread-local storage. > p_vcomp_fork(0, 1, _test_vcomp_fork_worker1, &ncalls); Your code does not explain what the first parameter is. I believe that va_list etc. is not going to lead you anywhere. First, va_* is only one side. E.g. include/wine/test.h uses va_list and __builtin_ms_va_list You need the other side too, namely, given a va_* structure, call a function X with the parameters given in that structure. The GNU ffcall library http://www.gnu.org/software/libffcall/ distinguishes both. One half is called vacall, the other one avcall :-) Your tests show that you need 2 different va_lists: > p_vcomp_fork(0, 5, _test_vcomp_fork_worker5, 1, 2, 3, 4, 5); 1. On the receiver side, va_start would create a va_list for the parameter set (0, 5, function pointer, 1, 2, 3, 4, 5) 2. But now you need to call something with the apparent parameter set (1, 2, 3, 4, 5) (I say apparent because you don't explain the vcomp execution model. Is a hidden parameter added somewhere? What's that first parameter 0 to fork?) Obviously, if you don't know the internals of a va_list, you'll not be able to transform one structure into the other. So bad, now what is actually needed? Think assembly. Using your test example: + p_vcomp_fork(0, 5, _test_worker5, 1, 2, 3, 4, 5); _vcomp_fork finds data: 1. on the stack 2. in registers 3. in FP registers The C stack layout is (topmost first): 0, then 5, &_test_worker5, 1, 2, etc. What you obviously need to do is, supposing the first parameters are duplicated in registers: - Save registers and possibly FP registers into a structure - Remember the stack pointer and number of elements, -- hereby creating a va_args structure whose layout you know. - CreateThread?? etc. - Restore registers - Shift register parameters by 3 items: (assuming 5 such registers) register-for-param-1 (1) <- register-for-param-4 register-for-param-2 (2) <- register-for-param-5 - Copy from stack into registers register-for-param-3 (3) <- from stack register-for-param-4 (4) <- from stack register-for-param-5 (5) <- from stack - POP 0 and 5 - POP &_test_worker5 into scratch register - JMPTO _test_worker5 via scratch register This assumes there's nothing like CreateThread so you can run from the original stack. If there were, you'd need to copy the 5 elements from the stack to the new one (which is presumably why vcomp_fork receives their number as parameter). Does this help? Jörg Höhle

3 3

Windows audio architecture
by Saulius Krasuckas 06 Oct '12

06 Oct '12

One link catched my eye here: "The evolution of a data structure – the WAVEFORMAT" https://www.assembla.com/spaces/portaudio/wiki/Win32AudioBackgroundInfo Maybe it is of some use for Wine developers too:) Some URLs need adjustment, though. Eg. Creative Labs description of Vista audio architecture changed to: http://forums.creative.com/showthread.php?t=302341 S.

1 0

Re: [patch 1/1] dlls/windowscodecs/pngformat.c: implemented 'PngDecoder_Block_GetCount'
by Nikolay Sivov 05 Oct '12

05 Oct '12

On 10/5/2012 06:43, max+git(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max+git(a)mtew.isa-geek.net> > > --- > dlls/windowscodecs/pngformat.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/dlls/windowscodecs/pngformat.c b/dlls/windowscodecs/pngformat.c > index 686f9c6..e8e7cbe 100644 > --- a/dlls/windowscodecs/pngformat.c > +++ b/dlls/windowscodecs/pngformat.c > @@ -899,8 +899,10 @@ static HRESULT WINAPI PngDecoder_Block_GetContainerFormat(IWICMetadataBlockReade > static HRESULT WINAPI PngDecoder_Block_GetCount(IWICMetadataBlockReader *iface, > UINT *pcCount) > { > - FIXME("%p,%p: stub\n", iface, pcCount); > - return E_NOTIMPL; > + PngDecoder *This = impl_from_IWICMetadataBlockReader(iface); > + if (!pcCount) return E_INVALIDARG; > + *pcCount = This->ref; > + return S_OK; > } > > static HRESULT WINAPI PngDecoder_Block_GetReaderByIndex(IWICMetadataBlockReader *iface, Return reference count as block count?

3 6

Re: [PATCH 2/3] ntoskrnl.exe: Improve IoGetCurrentProcess stub.
by Dmitry Timoshkov 05 Oct '12

05 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > +EPROCESS process_info; > + > #ifdef __i386__ > #define DEFINE_FASTCALL1_ENTRYPOINT( name ) \ > __ASM_STDCALL_FUNC( name, 4, \ > @@ -1200,8 +1203,11 @@ NTSTATUS WINAPI FsRtlRegisterUncProvider(PHANDLE MupHandle, PUNICODE_STRING Redi > */ > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + FIXME("(): partial stub\n"); > + > + process_info.UniqueProcessId = (PVOID)PsGetCurrentProcessId(); > + > + return &process_info; > } Why do you think that returning the structure filled with garbage is better than returning NULL? -- Dmitry.

3 7

Re: [PATCH 1/3] ntoskrnl.exe: Add include/ddk/ntifs.h header with EPROCESS struct definition.
by Paul Chitescu 05 Oct '12

05 Oct '12

On Friday 05 October 2012 10:00:00 am Christian Costa wrote: > --- > include/ddk/ntifs.h | 555 > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 555 > insertions(+) > create mode 100644 include/ddk/ntifs.h > > diff --git a/include/ddk/ntifs.h b/include/ddk/ntifs.h > new file mode 100644 > [...] What version of Windows were these extracted from?

2 2

Re: [PATCH 1/3] ntoskrnl.exe: Add include/ddk/ntifs.h header with EPROCESS struct definition.
by Dmitry Timoshkov 05 Oct '12

05 Oct '12

Did you check the DDK where it's supposed to be declared? -- Dmitry.

1 0

Help getting amd64 assembly patch into wine?
by Dan Kegel 04 Oct '12

04 Oct '12

As you might know from watching too many of my patches scroll by, I've been working on adding support for OpenMP to wine. (A handful of games, and a lot of serious apps, seem to use that api.) After getting it nicely organized and cleaned up to the point where it passed all the tests I could throw at it, I submitted it as http://source.winehq.org/patches/data/90524, Alexandre rejected the patch, saying it had multiple problems, but declining to provide any further hints. He suggested I find someone to work with to get it in... so here I am, hat in hand, asking for help. The patch adds support for OpenMP programs like this: // Compile with "cl test.c /openmp" #include <omp.h> #include <stdio.h> int main (int argc, char **argv) { #pragma omp parallel { printf("%d\n", omp_get_thread_num()); } } Later patches add support for other OpenMP constructs. My patch doesn't actually parallelize the app, but it does let it run rather than crash on unimplemented _vcomp_fork. Visual C will happily provide an assembly listing of this program showing how _vcomp_fork is called, so understanding that interface well enough to pass simple tests wasn't hard. The main challenge was figuring out how to get the variable list of arguments off the stack, and then put them back onto the stack when calling the provided function pointer. This bit of varargs hackery can't be done in pure C as far as I can tell, so I used assembly. I started programming in machine language long ago, so getting that working wasn't too hard once I realized that's what was needed. Getting it to pass the Alexandre test is another matter. Alexandre did give feedback on one earlier iteration of the patch, telling me I was re-inventing the wheel, so I tossed my old assembly and copied the helper-calling code nearly verbatim from call_method in oleaut32/typelib.c. Maybe he objects to not passing copies of the arguments in the floating point registers on amd64... but the arguments are always pointers, so that shouldn't be needed. I'm definitely not yet comfortable with the ASM_CFI stuff, so perhaps there's a problem there, but I did at least verify that injecting a fault into _test_vcomp_fork_worker5() still yielded a good stack trace on both x86 and amd64 in winedbg. There aren't many comments, and the ones I did add aren't the greatest, but I doubt that's the issue. Perhaps he objects to breaking up _vcomp_fork into three functions, but I couldn't see any other way to write it without making later patches like http://source.winehq.org/patches/data/90527 (and a future patch that adds actual multiple threads) put more logic than seems wise into assembly. So maybe it's none of the above. If someone can suggest what I might be missing, I'd appreciate it. Even just "It will break if..." or "Better compare how this was done in..." would be very helpful. Thanks!

2 2

Re: [PATCH 2/2] mshtml: Added ActiveX event binding test
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22013 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 5/5] winex11: Don't send SC_RESTORE when a maximized window switches to fullscreen.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > - if (style & WS_MAXIMIZE) > + if ((style & WS_MAXIMIZE) && (style & WS_CAPTION) == WS_CAPTION) Probably you should test for WS_MAXIMIZEBOX instead. -- Dmitry.

1 0

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + TRACE("()\n"); > + > + /* Return current process id since PEPROCESS is opaque and drivers should not access the struct directly */ > + return (PEPROCESS)PsGetCurrentProcessId(); > } The returned pointer is supposed to be passed to various other ntoskrnl APIs, and it's needs to be a valid pointer to the kernel object. Besides many not trivial kernel drivers (if not all) really dig into internal kernel structures. Same for KeGetCurrentThread. -- Dmitry.

4 4

Re: [PATCH] reg.exe: comparing the names of registry keys
by Jacek Caban 04 Oct '12

04 Oct '12

On 10/04/12 08:03, Mieczyslaw Nalewaj wrote: > +static BOOL strings_equal(LPWSTR lpString1, const WCHAR *lpString2) > +{ > + int cchCount; Please avoid Hungarian style variable names. Also is seems like the function not exactly compares strings, so something like is_subkey could be more appropriate function name. > + if ((!lpString1 || !*lpString1) && (!lpString2 || !*lpString2)) /* both empty */ > + return TRUE; > + if ( !lpString1 || !*lpString1 || !lpString2 || !*lpString2 ) /* one empty */ > + return FALSE; How about simplifying it to: if(!str1 || !*str1) return !str2 || !*str2; if(!str2 || !*str2) return FALSE; > + cchCount = strlenW(lpString2); > + if (strlenW(lpString1)<cchCount) /* too short */ > + return FALSE; > + > + if ( (CompareStringW(CP_ACP,NORM_IGNORECASE,lpString1,cchCount,lpString2,cchCount)==CSTR_EQUAL) > + && ((lpString1[cchCount] == 0) || (lpString1[cchCount] == (WCHAR){'\\'}))) > + return TRUE; > + else > + return FALSE; This could be simplified: len = strlenW(str2); return !strncmpiW(str1, str2, len) && (!str1[len] || str1[len] == '\\'); Cheers, Jacek

1 0

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Qian Hong <fracting(a)gmail.com> wrote: > --- > dlls/gdi32/tests/font.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) On what system do you see broken results? I'm asking because i did run this test with japanese locale at the time I touched it last time. -- Dmitry.

2 5

Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > + /* Read memory from the client process memory */ > + if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), mdl->ByteCount, &bytes)) This kind of casts is broken. -- Dmitry.

2 1

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22000 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21999 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21998 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier 03 Oct '12

03 Oct '12

Hello André, AH> In the meantime you could change your preferences in the appdb (Send email notifications) Than I'm in peace - that's right. But this have a side-effect: I also will not be informed by AppDB if someone add a new test or a comment in my attended applications: the mails to remain an applications maintainer to do his work are also switched off. This isn't really what I want. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 3

Overriding the check for ownership of a prefix
by Scott Ritchie 03 Oct '12

03 Oct '12

So, I believe I have a legitimate use case for ignoring this, and want to know what sort of patch would go forward. Imagine a distro package containing a Windows game in the form of a read-only copy of an installed prefix (into, say, /opt). When the user launches the app (via desktop file) this in turn launches a script that does the following: 1) Makes a temporary folder 2) Sets up a unionfs-fuse copy-on-write mount between ~/.appname and the read-only packaged prefix in /opt, mounted in the temporary folder 3) Runs the app with WINEPREFIX= the temp folder 4) When the app is finished, unmounts the temp folder This all works quite fine: new (or modified) files within the prefix get stored in ~/.appname, to be restored the next time the user runs the app. Distinct users can run the app simultaneously, as they each have their own prefix. Excess file-copying is avoided, as only the user-modified files need to be stored in the home folders. There is one major snag, however: unionfs displays the owner as root until the user has modified/copied it. This means Wine refuses to launch as the user with the "root-owned" prefix. Simply commenting out this part of the code makes Wine work fine, however I'd like to be able to have a proper solution. Would something like a command-line switch or environment variable be acceptable here? Thanks, Scott Ritchie * Note that there is a problem with this setup if the app modifies the registry and we then need to update the prefix-default registry, but that's a different feature request

2 3

Re: [PATCH] advapi32: avoid memory leaks (Coverity)
by Alexandre Julliard 03 Oct '12

03 Oct '12

Marcus Meissner <marcus(a)jet.franken.de> writes: > @@ -530,8 +530,10 @@ static void test_enum_providers(void) > /* alloc provider to half the size required > * cbName holds the size required */ > providerLen = cbName / 2; > - if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) > + if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) { > + LocalFree(pszProvName); > return; > + } Actually, checking for allocation failures in tests is not useful, it's not going to happen. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error
by Jacek Caban 03 Oct '12

03 Oct '12

Hi Marcus, On 10/01/12 23:00, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if nothing > happened. > > Second reiteration with Jaceks comment applied Sorry for not catching this later, I was concentrated on your comment instead of the code, but the important thing is that true call_ret means success (and wininet doing request asynchronously is signalled as an error). It means that in this case we want to return RPC_S_OK. What is the exact problem? Jacek

2 2

Re: [PATCH 2/2] vbscript: Added Right() implementation
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21987 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

ImmIsUIMessageA/W
by Aric Stewart 03 Oct '12

03 Oct '12

Hi Andre, I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 25 16:13:41 2011 +0200 imm32: Test and fix ImmIsUIMessageA/W. in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. if (!IMM_GetThreadData()->hwndDefault) ImmGetDefaultIMEWnd(NULL); also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. These changes cause the IME to stop working for IME unaware applications. Where the changed intentional and if so based on what documentation? thanks! -aric

3 9

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier 03 Oct '12

03 Oct '12

Hello Rosanne, sorry for misspelling your first name in my mail before. > I tried deleting the spammer's account, and the system asked me if > I really wanted to, but it didn't delete it even after I said yes. > I'm not sure that would have helped anyway, as he could easily just > create a new account. couldn't you simply reset the spammers password? So if his account is powned he will have to get a new one. > We really do need some sort of moderation for > AppDB comments similar to what's on the forum. In general this is a good idea. -- Regards Joerg Schiermeier Bielefeld/Germany

1 0

AppDB: Could someone please block this Spammer (UCE)
by newsletter [at] Schiermeier-Software 03 Oct '12

03 Oct '12

Hello everybody, could someone of the AppDB admin team please block this UCE-Mails which comes via AppDB-notifications? I'm speaking about this: 1.) Tue, 02 Oct 2012 04:58:05 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631#Comment-8…> 2.) Tue, 02 Oct 2012 12:01:08 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992#Comment-8…> 3.) Tue, 02 Oct 2012 15:11:12 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631> 4.) Tue, 02 Oct 2012 15:35:39 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992> Please Rosane, help us...! Thanks a lot! -- Gruss von Joerg Schiermeier

3 2

Re: [1/2] vbscript: Support vb* constants for message box buttons
by Jacek Caban 03 Oct '12

03 Oct '12

Hi Nikolay, On 10/03/12 13:34, Nikolay Sivov wrote: > Support vb* constants for message box buttons How about using MB_* constants from winuser.h instead of hardcoding them here? Other than that, the patch looks good to me. Jacek

2 1

Re: imm32: have IMM class return TRUE for WM_QUERYENDSESSION
by Alexandre Julliard 03 Oct '12

03 Oct '12

Aric Stewart <aric(a)codeweavers.com> writes: > resolves bug 31832 > --- > dlls/imm32/imm.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Is there any reason why we are not simply calling DefWindowProc? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] vbscript: Support vb* constants for message box return value (try2)
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21981 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] vbscript: Support vb* constants for message box buttons (try2)
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21980 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] vbscript: Support vb* constants for message box return value
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] vbscript: Support vb* constants for message box buttons
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21978 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] oledb32: Add support for IDBInitialize interface in IDataInitialize
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21975 Your paranoid android. === WNT4WSSP6 (32 bit marshal) === marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e marshal: unhandled exception c0000005 at 004165D0

1 0

Re: wininet: Fixed failing test
by Dmitry Timoshkov 03 Oct '12

03 Oct '12

Piotr Caban <piotr(a)codeweavers.com> wrote: > - ok(ret, "GetUrlCacheEntryInfoExW failed with error %d\n", GetLastError()); > + ok(ret || broken(!ret) /* IE6 */, "GetUrlCacheEntryInfoExW failed with error %d\n", GetLastError()); This kind of blanket test results coverage is broken from the start. -- Dmitry.

1 0

Re: [PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails.
by Jacek Caban 03 Oct '12

03 Oct '12

On 10/02/12 23:02, Erich E. Hoover wrote: > If a cleanup occurs because HTML Help window creation fails then > list_remove() causes a crash, since the window was never added to the > window list. The attached patch fixes this issue, allowing safe > reloading of files (needed for part 2). This looks like a hack. It would be better to have always valid list entry (if this really can't be added to the list earlier, you may always initialize it by list_init) or make sure to not call ReleaseHelpViewer before HHInfo is fully initialized. Jacek

1 0

Re:cmd: /r is equivalent to /c
by Ann and Jason Edmeades 03 Oct '12

03 Oct '12

Concept of patch is fine (and we ought to support it), but I dont think this would work as coded (if (tolowerW(c)=='c'||'r') will always be true). Also, can you add a quick test for it (there's cmd.exe /c tests - just add a cmd.exe /r echo test worked). PS You might want to just hold off until the patch I submitted last night gets committed as well otherwise there will be merge conflicts ("Change command line parsing away from argv/argc")

1 0

Re: cmd: /r is equivalent to /c
by Dmitry Timoshkov 03 Oct '12

03 Oct '12

Ken Sharp <kennybobs(a)o2.co.uk> wrote: > - if (tolowerW(c)=='c') { > + if (tolowerW(c)=='c'||'r') { In C it doesn't work this way. -- Dmitry.

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW().
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21950 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW().
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21949 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 7/7] mshtml: Added script 'for' and 'event' attributes tests
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21945 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wininet/tests(1/2): Test CommitUrlCacheEntry with the original URL parameter
by Piotr Caban 02 Oct '12

02 Oct '12

On 10/02/12 03:30, Juan Lang wrote: + /* On the other hande, GetUrlCacheEntryInfoEx allows you to query the + * original URL. + */ There's a typo, should be "On the other hand". + /* Strangely, you can create a cache entry redirected to itself. */ + ret = CreateUrlCacheEntry(test_url, 0, "html", filenameA, 0); + ok(ret, "CreateUrlCacheEntry failed with error %d\n", GetLastError()); + create_and_write_file(filenameA, &zero_byte, sizeof(zero_byte)); + ret = CommitUrlCacheEntry(test_url, filenameA, filetime_zero, filetime_zero, + NORMAL_CACHE_ENTRY, NULL, 0, NULL, test_url); In this case original url is ignored. Probably it's a more appropriate comment. Your test is leaving an entry in index.dat file. Please remove test_original_url entry from cache after testing it. Cheers, Piotr

1 0

Re: [PATCH 2/3] vbscript: Added LTrim() implementation
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21943 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] vbscript: Added Trim() implementation
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21942 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wininet(2/2): Fail to commit a url cache entry when the original URL is specified and no local filename is given
by Piotr Caban 02 Oct '12

02 Oct '12

On 10/02/12 03:31, Juan Lang wrote: @@ -3084,6 +3084,11 @@ static BOOL CommitUrlCacheEntryInternal( SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } + if (lpszOriginalUrl && !lpszLocalFileName) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } if (lpszOriginalUrl) WARN(": lpszOriginalUrl ignored\n"); The function should succeed if lpszOriginalUrl is specified and it operates on history container. Probably the check for lpszLocalFileName with STICKY_CACHE_ENTRY is also redundant. I guess that the lpszLocalFileName should be validated in following way: if(pContainer->default_entry_type==NORAML_CACHE_ENTRY && !lpszLocalFileName) { SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } I haven't check what happens for cookies containers. Cheers, Piotr

1 0

Re: [PATCH] scsiport.sys: Add stub implementaton of scsiport.sys.
by André Hentschel 02 Oct '12

02 Oct '12

Am 02.10.2012 00:10, schrieb Christian Costa: > This is needed by prosync1.sys (StarForce protection) used in Obscure. > --- > configure | 284 +++++++++++++++++------------------ > configure.ac | 1 > dlls/scsiport.sys/Makefile.in | 9 + > dlls/scsiport.sys/scsiport.c | 39 +++++ > dlls/scsiport.sys/scsiport.sys.spec | 48 ++++++ > 5 files changed, 238 insertions(+), 143 deletions(-) > create mode 100644 dlls/scsiport.sys/Makefile.in > create mode 100644 dlls/scsiport.sys/scsiport.c > create mode 100644 dlls/scsiport.sys/scsiport.sys.spec > > diff --git a/configure b/configure > index 54675b4..801dcf8 100755 > --- a/configure > +++ b/configure > @@ -1,11 +1,13 @@ > #! /bin/sh > # Guess values for system-dependent variables and create Makefiles. > -# Generated by GNU Autoconf 2.69 for Wine 1.5.14. > +# Generated by GNU Autoconf 2.68 for Wine 1.5.14. You should not include configure changes

2 1

Wine Mono 0.0.8 Release
by Vincent Povirk 01 Oct '12

01 Oct '12

Since I messed up the 0.0.6 release, here's another one, almost identical. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.4: * Updated the visual basic class libraries from upstream. * Updated mono from 2.11.1 to 2.11.4. Unfortunately, there wasn't a nice changelog like 2.11.1 had. Here are some highlights: * Beginnings of support for hosting ActiveX controls inside winforms. (Alistair Leslie-Hughes) * Various HttpClient-related fixes. (Martin Baulig) * "Intermediate" state check boxes now rendered in winforms. (Steven Boswell II) * ACL support on Windows. (James Bellinger) * One can now specify WINE_MONO_TRACE=wrapper to log all transitions between native and managed code, which is sort of the Mono equivalent of a relay log. * RVA fields can now be accessed properly via the ldsfld[a] instruction. This should help with Managed C++ support. * Fix for winehq bug 30947 - Mono would cause a hang when a dll is loaded after Mono is loaded but before it is used to run any .NET code. * Because of a problem with the build system, MonoPosixHelper.dll was not present, and this prevented some builtin methods in Mono from working correctly. This has been resolved. * Added hashes for all included files in the msi package, which is needed for msi to replace the files on upgrade. * Added 64-bit registry entries to the msi package. * Build process now fails immediately if wine or gmcs is missing, instead of waiting until they're used. (Austin English)

1 0

Re: ws2_32: Fix TRACE format in WS_getsockname (try 2)
by Dmitry Timoshkov 01 Oct '12

01 Oct '12

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, namelen?*namelen:0); Adding some spaces to make this slightly more readable wouldn't hurt IMHO. -- Dmitry.

2 1

Re: [PATCH 6/6] wininet/tests: Remove all temporary files
by Marvin 01 Oct '12

01 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21929 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 5/6] wininet: Set entry type based on container type
by Marvin 01 Oct '12

01 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21928 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] wininet: Added support for cache entries overwritting
by Marvin 01 Oct '12

01 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21927 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] Assorted spelling fixes.
by Julian Rüger 01 Oct '12

01 Oct '12

Hi Francois, > - * size [I] How much percent of cache space should be free. > + * size [I] How many percents of the cache should be free. Maybe something like "Precentage of cache that should be free" would sound more natural. However I'm not sure of the intended meaning here, it could be "freed". Best regards, Julian

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel