- wine-devel - winehq.org

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19007 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19006 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.
by Nikolay Sivov 13 Jun '12

13 Jun '12

On 6/12/2012 11:52, Ulrik Dickow wrote: > Patch 1 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . > > > > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; > + > + VARIANT var; > + HRESULT hr; > + BSTR str; > + > + /* create on element and try to alter namespace after that */ > + doc = (doc_version == 0 ? > + create_document(&IID_IXMLDOMDocument) : > + create_document_version(60, &IID_IXMLDOMDocument)); > + if (!doc) return; Please use something like CLSID array with every available Document CLSID, instead of only testing 2 of them. There's a lot of examples for that in saxreader.c. > + test_namespaces_change(0); > + test_namespaces_change(60); > > free_bstrs(); > } It's better to avoid nested test calls like that imho, you could just add another call in main test list. > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; ... > + > + IXMLDOMElement_Release(elem); > + IXMLDOMDocument_Release(doc); > +} > + When this is running on all CLSIDs please add free_bstrs() here.

3 4

Re: d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1
by Matteo Bruni 13 Jun '12

13 Jun '12

2012/6/12 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > > + if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) I think the second comparison should be '<=', if you want to avoid getting NaNs.

2 2

Re: wined3d: Avoid sizeof on structs with variable length arrays.
by Henri Verbeet 13 Jun '12

13 Jun '12

On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); That's not really a VLA, just a somewhat stupid array of size 1.

2 2

Misspelt Portuguese in msvcrt
by Francois Gouget 13 Jun '12

13 Jun '12

Is there a reason why Portuguese is misspelt in these two places? diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 97b82ec..b26a9c8 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -85,7 +85,7 @@ static const char * const _country_synonyms[] = "german-swiss", "des", "italian-swiss", "its", "german-austrian", "dea", - "portugese", "ptb", + "portuguese", "ptb", "portuguese-brazil", "ptb", "spanish-mexican", "esm", "norwegian-bokmal", "nor", diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index 8d6a34f..638a3d2 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -472,7 +472,7 @@ static void test_setlocale(void) if(ret) ok(!strcmp(ret, "Polish_Poland.1250"), "ret = %s\n", ret); - ret = setlocale(LC_ALL, "portugese"); + ret = setlocale(LC_ALL, "portuguese"); ok(ret != NULL || broken (ret == NULL), "ret == NULL\n"); if(ret) ok(!strcmp(ret, "Portuguese_Brazil.1252"), "ret = %s\n", ret); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ E-Voting: Those who cast the votes decide nothing. Those who count the votes decide everything.

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).
by Jacek Caban 13 Jun '12

13 Jun '12

Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and some additional cleanup. It is important to > note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. Many > apologizes to Jacek Caban for missing some of his comments in his > original reply. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. The patch looks much better. There is one remaining problem: + int pos = sizeof(html_encoded_symbols)/sizeof(html_encoded_symbols[0]); + float step = pos/2; + int dir = +1; + + do + { + const char *encoded_symbol; + + pos += -dir*ceil(step); Using float here is definitely not needed, esp. that you always use ceil() on it. You've made it more complicated than it really is. See [1] for an example. Also feel free to send linear search with FIXME comment. That's fine for the first iteration patch. Jacek [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/dispex.c#l709

1 0

Re: [11/11] windowscodecs: Implement GetMetadataFormat.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd

1 0

Re: [10/11] windowscodecs: Handle IFD fields with count 0 same way as with count 1.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18988 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd

1 0

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd

1 0

Re: [08/11] windowscodecs: Add tests for more types of IFD fields.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18986 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd

1 0

Re: po: Update Russian translation (try 3) (resend)
by Francois Gouget 13 Jun '12

13 Jun '12

msgid "KeyID=" -msgstr "Код ключа=" +msgstr "Код ключа: " [...] msgid "Other Name=" -msgstr "Другое имя=" +msgstr "Альтернативное имя: " and many more like this. Why did you not fix this? Replacing the equal sign with a colon looks wrong to me but then I don't speak Russian. Still I have not seen anything to suggest that the typographic rules would be different in this regard. But Nikolay Sivov, who speaks Russian, seems to concur. Note that this was reported to you back in May: http://www.winehq.org/pipermail/wine-devel/2012-May/095672.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [PATCH 4/5] wined3d: Set undefined vertex attributes to 0.0.
by Stefan Dösinger 12 Jun '12

12 Jun '12

Am Dienstag, 12. Juni 2012, 17:03:49 schrieb Henri Verbeet: > + if (state->vertex_shader->reg_maps.input_registers & (1 << i)) > + GL_EXTCALL(glVertexAttrib4fARB(i, 0.0f, 0.0f, 0.0f, 0.0f)); Does an application need this? Afair Windows drivers have implementation- specific behavior here that pretty much matches their GL counterparts.

1 0

re: Command line parameters
by Dan Kegel 12 Jun '12

12 Jun '12

John asked > [ How do I launch Windows apps from Unix apps and pass filenames to them?] > execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Relative unix paths will often work with Windows apps, but in general, you will have to translate command_line_parameter_for_windows_app, and any paths that appear in data files, from Unix to Windows before launching the app. The winepath utility may help there, or you can translate them yourself once you know how Wine maps filenames. Also, I recall being in a situation where I had to put the commandline in a batch file and do wine cmd.exe /c foo.bat because there wasn't another other way to make the windows app happy... something about the commandline that made me need to use CreateProcess, and cmd.exe was the easiest way to use CreateProcess. - Dan

5 10

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).
by Jacek Caban 12 Jun '12

12 Jun '12

Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control. It is important > to note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You didn't address most of my comments. Feel free to ask for clarifications if something was not clear enough. Jacek

2 1

Re: configure.ac: Get the needed libs from cups-config (for OpenBSD)
by Alexandre Julliard 12 Jun '12

12 Jun '12

André Hentschel <nerv(a)dawncrow.de> writes: > Inspired by Matias Colli, see bug 17896. > I made sure it doesn't hurt on other OS and send it because it doesn't seem he will do it and it's a oneliner. It doesn't work for me on Debian testing, not without manually creating symlinks for the libs that cups-config requires. It sounds like OpenBSD should fix their libcups build. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ntprint: Do not fail when the spooler service was stopped
by Alexandre Julliard 12 Jun '12

12 Jun '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -88,22 +92,25 @@ static void test_PSetupDestroyMonitorInfo(VOID) > { > HANDLE mi; > > - > SetLastError(0xdeadbeef); > pPSetupDestroyMonitorInfo(NULL); > - /* lasterror is returned */ > - trace("returned with %u\n", GetLastError()); > + /* lasterror is untouched */ > + ok(GetLastError() == 0xdeadbeef, "returned with 0x%x\n", GetLastError()); Testing last error on success is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin 12 Jun '12

12 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18972 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH] loader: On Mac OS, don't use external symbols for the DOS and shared heap segments.
by Alexandre Julliard 11 Jun '12

11 Jun '12

Charles Davis <cdavis(a)mymail.mines.edu> writes: > My first idea was to just add some '.globl' directives in the code. But > then I asked myself: why are we using an indirect symbol at all? Why are > we treating this like an external symbol when it clearly isn't? So now, > the arrays are declared static, and their owning section is explicitly > declared to the C compiler. While compile times have gone up, at least > the compiled loader executable actually works. This core dumps instantly when build with gcc on Mac OS 10.5, and doesn't even compile on 10.6. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] winspool: Install the ppd files into the driver directory.
by Alexandre Julliard 11 Jun '12

11 Jun '12

Huw Davies <huw(a)codeweavers.com> writes: > @@ -488,18 +638,70 @@ static void *cupshandle; > DO_FUNC(cupsGetPPD); \ > DO_FUNC(cupsParseOptions); \ > DO_FUNC(cupsPrintFile); > +#define CUPS_OPT_FUNCS \ > + DO_FUNC(cupsGetPPD3); > > #define DO_FUNC(f) static typeof(f) *p##f > CUPS_FUNCS; > +CUPS_OPT_FUNCS; > #undef DO_FUNC This still requires the function to be defined: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SPOOL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o info.o info.c info.c:732: error: 'cupsGetPPD3' undeclared here (not in a function) info.c:732: warning: type defaults to 'int' in declaration of 'pcupsGetPPD3' info.c: In function 'cupsGetPPD3_wrapper': info.c:741: error: called object 'pcupsGetPPD3' is not a function info.c: In function 'get_cups_ppd': info.c:771: error: 'CUPS_HTTP_DEFAULT' undeclared (first use in this function) info.c:771: error: (Each undeclared identifier is reported only once info.c:771: error: for each function it appears in.) make[1]: *** [info.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update Russian translation (try 3) (resend)
by Nikolay Sivov 11 Jun '12

11 Jun '12

On 6/9/2012 07:43, Oleg Yarigin wrote: > To avoid encode breaks I send a patch as an attachment. > > I packed it into *.GZ archive, becouse (I suppose so) some > intermediate servers can block messages with big attachments. > > Please split it to several patches with changes grouped by some criteria, it's really hard to review when it's that long.

1 0

Re: po: Update Italian translation
by Matteo Bruni 11 Jun '12

11 Jun '12

Hi Luca, just a couple of nitpicks: -"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a href=" -"\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> per i " -"dettagli." +"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a " +"href=\"http://wiki.winehq.org/Mono\">http://wiki.winehq.org/Mono</a> " +"per i dettagli." This sounds a bit awkward, I'd go for something like "Nota: si raccomanda di usare i pacchetti forniti dalla tua distribuzione." #: cryptui.rc:413 -#, fuzzy -#| msgid "&Personal Information Exchange/PKCS #12 (.pfx)" msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" -msgstr "Scambia di Informazioni &Personali/PKCS #12 (.pfx)" +msgstr "Scambia di Informazioni &Personali/PKCS #12 (*.pfx)" "Scambio". #: joy.rc:33 msgid "Joysticks" -msgstr "" +msgstr "Joysticks" I'm quite sure foreign words are always wrote in singular form in Italian language, so this would be "Joystick".

1 0

Re: [1/4] msi: Add support for 64-bit registry components. (resend)
by Marvin 11 Jun '12

11 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18942 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 1/4] kernel32/tests: Move a cdrom test to its own file
by Alexandre Julliard 11 Jun '12

11 Jun '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > The cdrom test file will be used to test ioctl (results, structure size...) > Each drive is tested and skipped gracefully if ioctl not supported or not a CDROM drive. I don't see a need for a new file, particularly since disk extents are not CDROM-specific. But even DVD ioctls can be tested in volume.c. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard 11 Jun '12

11 Jun '12

Andrew Eikum <aeikum(a)codeweavers.com> writes: > There's a lengthy comment in ready_pulse() describing why we're using > pthreads syncro primitives instead of Win32 primitives. I was under > the impression (thanks to the CoreAudio driver, mostly) that threads > not created through CreateThread() cannot use CRITICAL_SECTION, ERR, > WARN, TRACE, and so on. However, when I was testing, I noticed that > debug printing _does_ work in callbacks from the pthread thread. You can't do that, you need to create a proper Win32 thread, and solve the loader lock issue some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] loader: On Mac OS, don't emit a __PAGEZERO segment.
by Alexandre Julliard 11 Jun '12

11 Jun '12

Charles Davis <cdavis(a)mymail.mines.edu> writes: > This is the reason we couldn't put the WINE_DOS segment at address 0. We don't need page zero, we don't run DOS apps on the Mac. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin 11 Jun '12

11 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18940 Your paranoid android. === W2K8SE (32 bit http) === http.c:533: Test failed: req_error = 12007 http.c:544: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:533: Test failed: req_error = 12007 http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:562: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:583: Test failed: Wrong URL http://test.winehq.org/tests/redirect http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:269: Test failed: unexpected status 11 (INTERNET_STATUS_NAME_RESOLVED)

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Dmitry Timoshkov 11 Jun '12

11 Jun '12

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > configure.ac | 31 +- > dlls/mmdevapi/main.c | 4 +- > dlls/winepulse.drv/Makefile.in | 9 + > dlls/winepulse.drv/mmdevdrv.c | 3216 +++++++++++++++++++++++++++++++++ > dlls/winepulse.drv/winepulse.drv.spec | 5 + > 5 files changed, 3261 insertions(+), 4 deletions(-) > create mode 100644 dlls/winepulse.drv/Makefile.in > create mode 100644 dlls/winepulse.drv/mmdevdrv.c > create mode 100644 dlls/winepulse.drv/winepulse.drv.spec How does it follow the Alexandre's requirement to split the patch into smaller pieces before submitting? -- Dmitry.

1 0

Re: [PATCH] kernel32: Don't use putenv(3) on temporary strings.
by Ken Thomases 10 Jun '12

10 Jun '12

The putenv() calls occur in a forked grandchild process just before an exec(). The strings are sure to survive the current process image. After that, it's the kernel's problem. Regards, Ken On Jun 10, 2012, at 11:47 AM, Charles Davis wrote: > The Darwin manpage for putenv() warns that it no longer makes a copy of > its input, but directly stores the pointer in environ. Wine was passing > stack- and heap-allocated strings to putenv(), which could have caused a > crash. We were very lucky it didn't. Instead, use setenv(3), which still > copies its inputs. > > Found while tracking down an insidious bug in Clang-built optimized > (-O2) Wine. > --- > dlls/kernel32/process.c | 24 +++++++++++------------- > 1 files changed, 11 insertions(+), 13 deletions(-) > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 42716c2..1ec3e3d 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -1741,17 +1741,14 @@ static const char *get_alternate_loader( char **ret_env ) > int len = strlen( loader_env ); > if (!is_win64) > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len + 2 ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len + 2 ))) return NULL; > + strcpy( env, loader_env ); > strcat( env, "64" ); > } > else > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > - len += sizeof("WINELOADER=") - 1; > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len ))) return NULL; > + strcpy( env, loader_env ); > if (!strcmp( env + len - 2, "64" )) env[len - 2] = 0; > } > if (!loader) > @@ -1860,14 +1857,14 @@ static pid_t exec_loader( LPCWSTR cmd_line, unsigned int flags, int socketfd, > /* Reset signals that we previously set to SIG_IGN */ > signal( SIGPIPE, SIG_DFL ); > > - sprintf( socket_env, "WINESERVERSOCKET=%u", socketfd ); > - sprintf( preloader_reserve, "WINEPRELOADRESERVE=%lx-%lx", > + sprintf( socket_env, "%u", socketfd ); > + sprintf( preloader_reserve, "%lx-%lx", > (unsigned long)binary_info->res_start, (unsigned long)binary_info->res_end ); > > - putenv( preloader_reserve ); > - putenv( socket_env ); > - if (winedebug) putenv( winedebug ); > - if (wineloader) putenv( wineloader ); > + setenv( "WINESERVERSOCKET", socket_env, 1 ); > + setenv( "WINEPRELOADRESERVE", preloader_reserve, 1 ); > + if (winedebug) setenv( "WINEDEBUG", winedebug, 1 ); > + if (wineloader) setenv( "WINELOADER", wineloader, 1 ); > if (unixdir) chdir(unixdir); > > if (argv) > @@ -1976,6 +1973,7 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW > static const WCHAR WINEDEBUG[] = {'W','I','N','E','D','E','B','U','G','=',0}; > if (!winedebug && !strncmpW( env_end, WINEDEBUG, sizeof(WINEDEBUG)/sizeof(WCHAR) - 1 )) > { > + env_end += sizeof(WINEDEBUG)/sizeof(WCHAR) - 1; > DWORD len = WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, NULL, 0, NULL, NULL ); > if ((winedebug = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, winedebug, len, NULL, NULL ); > -- > 1.7.5.4 > > >

1 0

Re: [PATCH 4/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdCopyrightDescriptor) test
by Marvin 10 Jun '12

10 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18927 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:85: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 3/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test
by Marvin 10 Jun '12

10 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18926 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:84: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.
by Jacek Caban 10 Jun '12

10 Jun '12

Hi Erich, On 06/07/12 23:09, Erich E. Hoover wrote: > + /* Post the HTML text to the document */ > + array = SafeArrayCreateVector(VT_VARIANT, 0, 1); > + if(!array) > + goto cleanup; > + hr = SafeArrayAccessData(array, (LPVOID*)&array_param); > + if (FAILED(hr)) > + goto cleanup; > + V_VT(array_param) = VT_BSTR; > + V_BSTR(array_param) = SysAllocString(html_fragment); > + hr = SafeArrayUnaccessData(array); > + if (FAILED(hr)) > + goto cleanup; > + hr = IHTMLDocument2_write(html_parsing_doc, array); Did you test indexes like '<script>alert("really!?")</script>' ? :) Seriously, HTMLDocument is not the right tool for the job. Cheers, Jacek

2 4

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2
by Jacek Caban 10 Jun '12

10 Jun '12

Hi Vijay, On 06/08/12 03:15, Vijay Kiran Kamuju wrote: > + *ppvObject = NULL; > + if ( IsEqualGUID( riid, &IID_IDictionary ) || > + IsEqualGUID( riid, &IID_IPersist ) || > + IsEqualGUID( riid, &IID_IDispatch ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = This; > + } That's not the right way to cast object to interface. See http://wiki.winehq.org/COMGuideline Cheers, Jacek

2 2

joy.cpl icon
by Joel Holdsworth 10 Jun '12

10 Jun '12

Hi All, I've just submitted an icon for joy.cpl to wine-patches. Unfortunatly I've uncovered a problem with the buildimage script. When I first wrote the script, I used the "rsvg" command to convert svg to png. rsvg has been depreciated in favour of rsvg-convert, which has slightly different semantics: rsvg-convert in.svg > out.png instead of rsvg in.svg out.png Moving over to rsvg-convert is trivial of course, except one question. Is it present on enough platforms? I'm using Ubunut 12.04. Is maintainer mode meant to work on Debian Squeeze? We could support both, but I'd rather not do that. Joel

2 1

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.
by Dan Kegel 08 Jun '12

08 Jun '12

-#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) +#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || defined(HAVE_STRUCT_IP_STATS_IPS_TOTAL)) Isn't this a no-op? I thought that an undefined symbol was treated as false by the preprocessor. When I compile #if defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) defined #else not defined #endif with gcc -E or cl /E, I get not defined

3 4

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Alexandre Julliard 08 Jun '12

08 Jun '12

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/tests/Makefile.in | 2 +- > dlls/wininet/tests/http.c | 38 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 39 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:3020: Test failed: InternetGetSecurityInfoByURLA returned: 1(12028), exected 12028 http.c:3153: Test failed: InternetGetSecurityInfoByURLA returned: 1(997), exected 12028 make[1]: *** [http.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18903 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3293: Test failed: HttpSendRequest failed: 12002

2 1

Re: msxml3: Implement IXMLParser Get/Set Flags
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18891 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 4/4] mshtml: Added IWindowForBindingUI tests
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18890 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration. Resend.
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18888 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Re: Patch 2/2 - [scrrun] - Add initial tests for Dictionary - resend
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18875 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/1] shell32: Fix FindExecutable search path when a default directory is supplied.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18869 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] === W2KPROSP4 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe]

1 0

Re: [4/5] propsys: Implement IPropertyStoreCache::SetState.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18853 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/5] propsys: Implement IPropertyStoreCache::GetValueAndState.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18852 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] propsys: Implement IPropertyStoreCache::GetState.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18851 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] windowscodecs: Implement a better stub for MetadataHandler_GetCount.
by Vincent Povirk 07 Jun '12

07 Jun '12

It should be trivial to implement this correctly. On Wed, Jun 6, 2012 at 11:21 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/metadatahandler.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c > index 013fe04..0ea404b 100644 > --- a/dlls/windowscodecs/metadatahandler.c > +++ b/dlls/windowscodecs/metadatahandler.c > @@ -152,7 +152,8 @@ static HRESULT WINAPI MetadataHandler_GetCount(IWICMetadataWriter *iface, > if (!pcCount) return E_INVALIDARG; > > FIXME("(%p,%p): stub\n", iface, pcCount); > - return E_NOTIMPL; > + *pcCount = 0; > + return S_OK; > } > > static HRESULT WINAPI MetadataHandler_GetValueByIndex(IWICMetadataWriter *iface, > -- > 1.7.10.1 > > >

2 1

Re: [PATCH 1/7] urlmon: Use file content to verify MIME type reported by file protocol handler
by Jacek Caban 07 Jun '12

07 Jun '12

On 06/07/12 15:40, Jacek Caban wrote: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) > Please skip this one. I didn't mean to send it in the series. Thanks, Jacek

1 0

Re: mscoree: Use .NET 2.0 for 1.0 assemblies
by Vincent Povirk 07 Jun '12

07 Jun '12

I was planning to do something like this eventually, as I was advised on #mono this was the way to go, but I didn't expect it to be that simple. +1. On Thu, Jun 7, 2012 at 4:27 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Mono will use .NET 2.0 when a .NET 1.0/1.1 application is run. > > http://www.mono-project.com/Release_Notes_Mono_2.8 > Find: Removed .NET 1.1 Profile > > > Changelog: > mscoree: Use .NET 2.0 for 1.0 assemblies > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

Re: po: Update Russian translation (try 2)
by Nikolay Sivov 07 Jun '12

07 Jun '12

On 6/5/2012 11:16, Архад wrote: Please, configure your mail client to use your real name in sent mails. > > #: appwiz.rc:28 > msgid "Add/Remove Programs" > -msgstr "Установка/удаление программ" > +msgstr "Установка/Удаление программ" Looks better as it is. Only start letter of a sentence supposed to be capital, if it's not a part of some name of course, which is not in this case. > > > #: appwiz.rc:35 shell32.rc:141 shell32.rc:238 regedit.rc:122 winefile.rc:104 > msgid "Name" > -msgstr "Имя" > +msgstr "Название" I don't think so. > > > > #: appwiz.rc:39 > msgid "Programs (*.exe)" > -msgstr "Программы (*.exe)" > +msgstr "Исполняемые файлы (*.exe)" No reason for that. > > #: appwiz.rc:40 avifil32.rc:30 cryptui.rc:80 shell32.rc:196 notepad.rc:73 > #: oleview.rc:101 progman.rc:79 regedit.rc:195 winedbg.rc:39 winhlp32.rc:87 > @@ -248,7 +247,7 @@ msgid "" > "file." > msgstr "" > "Ошибка контрольной суммы загруженного файла. Установка поврежденного файла " > -"отменяется." > +"будет отменена." English string doesn't say that it 'will be aborted', it says 'aborting' which means it's already in process to abort it. > > > > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" It's better as it is. > > #: comdlg32.rc:160 comdlg32.rc:182 > msgid "List Files of &Type:" > -msgstr "Показывать файлы &типа:" > +msgstr "&Тип файлов:" This doesn't reflect original meaning. > > > > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" String length matters for this dialog as I remember. > > > > #: comdlg32.rc:315 comdlg32.rc:336 > msgid "Match &Whole Word Only" > @@ -817,20 +816,18 @@ msgid "" > "File does not exist.\n" > "Do you want to create file?" > msgstr "" > -"Файла не существует.\n" > -"Хотите ли вы его создать?" > +"Файла не существует. Создать?" This supposed to match original line splitting probably. > > > #: comdlg32.rc:68 > msgid "Unknown printer driver." > -msgstr "Неизвестный драйвер принтера." > +msgstr "Неопознанный драйвер принтера." This sounds like 'unknown' from UFO now. > > #: crypt32.rc:55 > msgid "On-line Certificate Status Protocol" > @@ -1371,7 +1367,7 @@ msgstr "Имя SSL-сервера Netscape" > > #: crypt32.rc:67 > msgid "Netscape Comment" > -msgstr "Комментарий Netscape" > +msgstr "Комментарии Netscape" Original word is in singular. ... I'm skipping the rest as it's too much to comment at once, but I think you got the idea how to improve that. Also winerror strings should be left as it is, cause nobody cares much anyway. And please pay attention to actual dialog testing, cause updated strings should fit in.

1 0

Re: Command line parameters
by Hin-Tak Leung 07 Jun '12

07 Jun '12

--- On Thu, 7/6/12, John Emmas <johne53(a)tiscali.co.uk> wrote: <snipped> > Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. > John "Use the source, Luke!"... THe relevant code is in dlls/ntdll/file.c and dlls/ntdll/path.c which do the right thing. As a general windows programming note, in windows' land, file path related WIN32 APIs tend to have two variants, those ending with *A, and those ending with *W. The former expects ascii inputs, the latter expects WCHAR (I think it is basically UT16LE). The long answer is that wine leaves the former unchanged (except path separator translation, e.g. from unix "/" to windows "\", adding or removing drive letter prefixes, depending on the direction of translation), but will convert from utf8 to WCHAR for the latter, so that the application itself receives the right thing. It is still up to the application's author to use the right Windows APIs for reading/writing files, and whether the application itself expects ascii file paths or unicode (WCHAR) file paths. The short answer is that wine *does* translate from unix-like to windows-like file paths so that the application receives the right stuff. You have nothing to worry about.

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel