- wine-devel - winehq.org

Command line parameters
by John Emmas 07 Jun '12

07 Jun '12

Originally, I was going to post this on wine-users but after I wrote it, it seemed like wine-devel might be more appropriate. Please let me know if I need to re-submit it to wine-users. I understand that Wine is mostly used for running Windows apps on Linux - i.e. in most cases, the user will be launching the Windows app manually. But what about a Linux application that needs to launch a Windows app? What does Wine do (if anything) about command-line parameters..? After using fork() to create a new process, this would be a typical program command to start Wine and the Windows app:- execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Notice that execl() passes two command-line parameters to Wine (one of which gets passed to the Windows app). Let's assume this is a file path as that's easy to visualize. In the vast majority of cases, those command-line parameters will get passed to Wine as UTF8 strings. Wine will hopefully understand this when interpreting 'path_to_the_windows_program'. However, Windows programs themselves don't understand UTF8 at all - except for a very limited set of (mostly English) characters. So if that parameter was a file path (e.g. a file that the Windows program needed to open) it would only get understood in an English speaking locale. Non-English characters (accented characters etc) would only get understood if a locale translation takes place. Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. John

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18837 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 2

re: comctl: allow label edit only if treeview style allows editing
by Dan Kegel 06 Jun '12

06 Jun '12

> I stopped doing > make test on my machine some time ago Bad developer, no donut :-) > , when I found out that some > tests do consistently fail on my machine (clean prefix or not), and > others consistently hang, thus preventing make test -k. I had the same problem, and wrote a little script to skip the bad tests. It was written for buildbot, but can be run standalone. Try downloading http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh and http://winezeug.googlecode.com/svn/trunk/buildbot/dotests_blacklist.txt then run sh dotests.sh goodtests That will skip all the tests known to hang or fail. (The list might be a bit out of date, but it's easy to add new tests to the blacklist.) > I don't install wine-gecko, maybe that's the reason. Run https://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh then you'll never have to install it again. (Until it's updated, anyway.) - Dan

2 1

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Alexandre Julliard 06 Jun '12

06 Jun '12

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

1.4 has dropped off the list for AppDB submissions
by Rosanne DiMesio 06 Jun '12

06 Jun '12

As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test reports for 1.4. We could avoid having this problem every time there's a new stable release if users were allowed to submit test reports for any version. Bugzilla lists every version, I don't see why the AppDB doesn't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 2

Re: [PATCH 2/3] server: STATUS_MORE_PROCESSING_REQUIRED does not indicate that an async operation is complete (try 4).
by Alexandre Julliard 06 Jun '12

06 Jun '12

"Erich E. Hoover" <compholio(a)gmail.com> writes: > @@ -285,7 +285,9 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > if (async->timeout) remove_timeout_user( async->timeout ); > async->timeout = NULL; > async->status = status; > - if (async->data.cvalue) > + if (status == STATUS_MORE_PROCESSING_REQUIRED) > + async->status = STATUS_PENDING; > + else if (async->data.cvalue) Why are you marking the async pending? That doesn't seem right, it's terminated at that point. -- Alexandre Julliard julliard(a)winehq.org

2 1

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono
by Dan Kegel 06 Jun '12

06 Jun '12

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now also installs mono. It should be probably be called wine-install-addons.sh now, maybe I'll rename it that soon. If you have a better idea for the name, let me know. (I've also deprecated the copy that was in winezeug; that one now just tells users to get it from the winetricks repo.)

11 20

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader to TIFF decoder.
by Vincent Povirk 06 Jun '12

06 Jun '12

Looks good. Here are some notes in case you get around to implementing this before I do: I found it very surprising that no metadata handlers seem to implement IWICMetadataBlockReader, while many of them advertise that they can be found in other metadata formats. I'm guessing that metadata handlers return child IWICMetadataReader objects from the IWICMetadataReader interface, but I haven't tested this. It probably doesn't make sense to reimplement GetEnumerator for each decoder, and we should be able to make a common implementation based on the other methods. We should probably implement GetReaderByIndex based on CreateMetadataReaderFromContainer, which I'm guessing expects a copy of the image stream (using IWICStream because we can't use IStream::Clone) seeked to the beginning of some metadata, or a region of the image stream, maybe depending on the container format.

1 0

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Marvin 06 Jun '12

06 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18815 Your paranoid android. === WXPPROSP3 (32 bit protocol) === protocol.c:1046: Test failed: unexpected call ReportResult protocol.c:1051: Test failed: hrResult = 00000000, expected: 80004004 protocol.c:2838: Test failed: Read failed: 00000001

2 1

Re: [2/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region. Take 2.
by Alexandre Julliard 06 Jun '12

06 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the test tries harder to avoid races that could cause > the test failures. It's not races, it's failing consistently here, even with your latest version. I don't think you can reliably test expose events processing from a Windows app. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] shell32: do not crash "wine control.exe nonexisting"
by Jacek Caban 06 Jun '12

06 Jun '12

Hi Marcus, On 06/06/12 10:17, Marcus Meissner wrote: > Hi, > > wine control.exe joy crashed in this line, as it should be wine control.exe joy.cpl. > > The list is just not setup yet as we fail... > > Ciao, Marcus > --- > dlls/shell32/control.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c > index cb080d5..b3eddb6 100644 > --- a/dlls/shell32/control.c > +++ b/dlls/shell32/control.c > @@ -55,7 +55,7 @@ void Control_UnloadApplet(CPlApplet* applet) > } > if (applet->proc) applet->proc(applet->hWnd, CPL_EXIT, 0L, 0L); > FreeLibrary(applet->hModule); > - list_remove( &applet->entry ); > + if (applet->entry.next) list_remove( &applet->entry ); > HeapFree(GetProcessHeap(), 0, applet->cmd); > HeapFree(GetProcessHeap(), 0, applet); > } The way Wine standard list implementation works, it should not be NULL here. It seems that list_init call is missing where the CPlApplet is allocated. Cheers, Jacek

3 6

Re: [PATCH 3/5] d3drm: Handle texture associated with the materail when loading a mesh.
by Alexandre Julliard 06 Jun '12

06 Jun '12

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3drm/meshbuilder.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:375: Test failed: No texture should be present wine: Unhandled page fault on write access to 0x00162708 at address 0x68353cb7 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/action.c | 30 +++++++--- > dlls/msi/msi_main.c | 1 + > dlls/msi/msipriv.h | 1 + > dlls/msi/package.c | 2 - > dlls/msi/tests/install.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 162 insertions(+), 12 deletions(-) This breaks the Gecko installer on 64-bit for me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [1/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/user32/tests/win.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so ../../../../wine/dlls/user32/tests/win.c && touch win.ok win.c:7111: Test succeeded inside todo block: expected next window 0x400ea, got 0x400ea win.c:7114: Test succeeded inside todo block: expected previous window 0x400f0, got 0x400f0 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] server: Make sure that region and rectangle have the same origin before calling rect_in_region().
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2457,7 +2457,9 @@ DECL_HANDLER(update_window_zorder) > if (!(ptr->style & WS_VISIBLE)) continue; > if (ptr->ex_style & WS_EX_TRANSPARENT) continue; > if (!intersect_rect( &tmp, &ptr->visible_rect, &rect )) continue; > - if (ptr->win_region && !rect_in_region( ptr->win_region, &rect )) continue; > + tmp = rect; > + offset_rect( &tmp, -ptr->client_rect.left, -ptr->client_rect.top ); > + if (ptr->win_region && !rect_in_region( ptr->win_region, &tmp )) continue; The window region is not in client coordinates. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] wined3d: Use NAN.
by Ruslan Kabatsayev 05 Jun '12

05 Jun '12

Hello, This patch stops wine from building on my system with following errors: In file included from arb_program_shader.c:35:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from device.c:32:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from ati_fragment_shader.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from context.c:27:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from directx.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from gl_compat.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) make[1]: *** [ati_fragment_shader.o] Error 1 Regards, Ruslan On Wed, May 30, 2012 at 6:14 PM, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > --- > dlls/wined3d/drawprim.c | 2 ++ > dlls/wined3d/utils.c | 2 ++ > dlls/wined3d/wined3d_private.h | 4 ++-- > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c > index 2e30175..c8944e5 100644 > --- a/dlls/wined3d/drawprim.c > +++ b/dlls/wined3d/drawprim.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d_draw); > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index dc63d8b..f8f301a 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d); > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 096fe60..6632f6e 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -200,7 +200,7 @@ static inline float float_16_to_32(const unsigned short *in) { > return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / 1024.0f)); > } else { > if(m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > @@ -222,7 +222,7 @@ static inline float float_24_to_32(DWORD in) > else > { > if (m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > -- > 1.7.3.4 > > >

2 2

Re: [PATCH 5/5] d3dcompiler: Parse variable declarations.
by Stefan Dösinger 05 Jun '12

05 Jun '12

Am Montag, 4. Juni 2012, 17:58:24 schrieb Matteo Bruni: > +struct hlsl_type > +{ > ... > + unsigned int dimx; > + unsigned int dimy; > ... > +}; One thing I noticed when I wrote my compiler was that a float1x1 is not the same as a float1 or float. I did not implement this difference nor do I know if any games depend on it. (That's no reason to hold up this patch, just something to keep in mind for further work)

3 4

Re: [4/5] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin 05 Jun '12

05 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18792 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Marvin 05 Jun '12

05 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18791 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: oleaut32: Add a test for BSTR cache. Take 3.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > + for (i = 0; i < sizeof(bstr)/sizeof(bstr[0]); i++) > + { > + INTERNAL_BSTR *data = Get(bstr[i]); > + > + for (j = 0; j < i; j++) str[j] = '0' + i % 10; > + > + if (data->dwLen == i * sizeof(WCHAR)) > + good_length_entries++; > + if (!memcmp(data->szString, str, i * sizeof(WCHAR))) > + good_string_entries++; > + } > + > + trace("good_length_entries %d, good_string_entries %d\n", good_length_entries, good_string_entries); > + ok(good_length_entries >= 95, "good_length_entries %d out of 256\n", good_length_entries); > +todo_wine > + ok(good_string_entries >= 190, "good_string_entries %d out of 256\n", good_string_entries); That doesn't seem very useful. What use case would there be for an app to rely on some random 75% of its strings to remain valid? -- Alexandre Julliard julliard(a)winehq.org

3 6

Wine in Humble Indie Bundle
by Dan Kegel 04 Jun '12

04 Jun '12

I see the Humble Indie Bundle includes a game ported via wine, http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. So I put together a pro-wine petition: http://www.ipetitions.com/petition/use-wine-as-needed-in-future-humble-indi… How's that look? If you agree with it, please sign and forward to your friends. Thanks, Dan

5 5

Re: [PATCH 1/2] joystick.cpl: First version of the joystick configuration applet
by Alexandre Julliard 04 Jun '12

04 Jun '12

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > This adds a control panel applet to configure the joysticks. It is > a property sheet and has 3 pages: > > * Joystick listing > * Axes and Button Testing > * Force Feedback testing > > All the function are stubs at the moment, the panel has no icon too. > > --- > configure.ac | 1 + > dlls/joystick.cpl/Makefile.in | 14 +++ > dlls/joystick.cpl/forcefeedback.c | 60 +++++++++++ > dlls/joystick.cpl/joystick.cpl.spec | 3 + > dlls/joystick.cpl/joystick.h | 63 ++++++++++++ > dlls/joystick.cpl/joystick.rc | 55 ++++++++++ > dlls/joystick.cpl/list.c | 57 +++++++++++ > dlls/joystick.cpl/main.c | 191 +++++++++++++++++++++++++++++++++++ > dlls/joystick.cpl/test.c | 60 +++++++++++ > 9 files changed, 504 insertions(+) > create mode 100644 dlls/joystick.cpl/Makefile.in > create mode 100644 dlls/joystick.cpl/forcefeedback.c > create mode 100644 dlls/joystick.cpl/joystick.cpl.spec > create mode 100644 dlls/joystick.cpl/joystick.h > create mode 100644 dlls/joystick.cpl/joystick.rc > create mode 100644 dlls/joystick.cpl/list.c > create mode 100644 dlls/joystick.cpl/main.c > create mode 100644 dlls/joystick.cpl/test.c It's called joy.cpl on Windows. Please also use compatible exports, and avoid creating a lot of empty source files. I'd expect that a single source file is sufficient for this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/4] server: Move completion from async object to async queue.
by Alexandre Julliard 04 Jun '12

04 Jun '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > It seems that the completion information should be associated with > the async queue, rather than the async object, since the completion > information for a file handle can be updated after an async IO has > been queued. So, the attached patch moves the completion information > from the async object into the async queue so that we can properly > handle associating a completion with a file descriptor after an async > IO is queued (part 2). Does it even need to be stored in the queue then? Why not retrieve it from the fd when needed? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [website] Publish a sign button for the Wine in Humble Indie Bundle petition
by Jeremy Newman 04 Jun '12

04 Jun '12

I'm not sure this belongs in the news section on WineHQ. I need some further convincing. -Newman On 06/04/2012 01:11 PM, André Hentschel wrote: > http://www.winehq.org/pipermail/wine-devel/2012-June/095722.html needs more cow bell > > --- > news/en/2012060401.xml | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100644 news/en/2012060401.xml > > diff --git a/news/en/2012060401.xml b/news/en/2012060401.xml > new file mode 100644 > index 0000000..1bcd3d5 > --- /dev/null > +++ b/news/en/2012060401.xml > @@ -0,0 +1,23 @@ > +<news> > +<date>June 4, 2012</date> > +<title>Wine in Humble Indie Bundle</title> > +<body> > +<div style="float: left; margin: 0 20px 20px 0; display:block; clear:both; text-align: left; background: #000 url(http://www.ipetitions.com/assets/images/widgets/black.png) no-repeat top left; width: 200px;"> > +<iframe src="http://www.ipetitions.com/widget/view/black/437775" marginheight="0" marginwidth="0" style="width: 200px; height:150px; border:0;" scrolling="no"></iframe> > +<div style="text-align:center; font-family:Arial;font-size: 9px; width: 196px; margin-top: -3px; padding: 1px 2px 2px; color: #8a8a8a; font-style: italic;"> > +<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com/">Petitions</a> by<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com">iPetitions.com</a> > +</div> > +</div> > +<p> > + The Humble Indie Bundle includes a game (Limbo) > +<a href="http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition">ported via wine</a>. > +</p> > +<p> > + That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. > +</p> > +<p> > + So Dan Kegel put together a pro-wine petition: > +<a href="http://www.ipetitions.com/petition/use-wine-as-needed-in-future-humble-indi…">Use Wine as needed in future Humble Indie Bundles</a> > +</p> > +</body> > +</news> > > > >

1 0

Re: wininet: Added support for undocumented InternetQueryOption(98)
by Marvin 04 Jun '12

04 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18739 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3203: Test failed: HttpSendRequest failed: 12007 http.c:3208: Test failed: expected secure flag to be set http.c:3220: Test failed: expected a non-empty subject name http.c:3223: Test failed: expected a non-empty issuer name http.c:3232: Test failed: expected a non-zero key size http.c:3252: Test failed: expected a non-empty subject name http.c:3255: Test failed: expected a non-empty issuer name http.c:3264: Test failed: expected a non-zero key size

1 0

Re: Fix the FIXME message to reflect the real problem.
by Piotr Caban 04 Jun '12

04 Jun '12

On 06/02/12 13:35, max(a)mtew.isa-geek.net wrote: > @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal( > goto cleanup; > } > > - FIXME("entry already in cache - don't know what to do!\n"); > + FIXME("collision handler needed - the entry is already in use!\n"); This message is not about entry being used. I think the old message is quite accurate. The "don't know what to do" part is quite strange but I don't see reason to change it.

2 1

Re: comctl: allow label edit only if treeview style allows editing
by Alexandre Julliard 04 Jun '12

04 Jun '12

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sat, 2 Jun 2012 07:23:32 +0200 > Subject: comctl: allow label edit only if treeview style allows editing > > Native comctl behaves this way - noticed when debugging regedit It breaks the tests: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok brsfolder.c:225: Test failed: The new folder did not get the name foo brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder' make: *** [brsfolder.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Alistair Leslie-Hughes 04 Jun '12

04 Jun '12

Hi Vijay, On 4/06/2012 8:06 PM, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > +static HRESULT WINAPI dictionary_put_Item(IDictionary *iface, VARIANT *key, VARIANT *item) > +{ > + FIXME("%p %p\n", iface, key); Please include all parameters in FIXME, they all seem to be missing the last one. Best Regards Alistair Leslie-Hughes

1 0

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Jacek Caban 04 Jun '12

04 Jun '12

Hi Vijay On 06/04/12 12:06, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > The first patch will add dictionary.c > The second will add the necessary changes to Makefile and the scrrun.c > (mistake done will doing git commit - hence two patches) This split doesn't make sense. Please merge those patches. +static ULONG WINAPI dictionary_AddRef(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 2; +} + +static ULONG WINAPI dictionary_Release(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 1; +} Dictionary object should be heap-based. That requires proper reference counting and object structure. Cheers, Jacek

1 0

Re: [scrrun] - Add initial support for Dictionary - tests - patch 3/3
by Marvin 04 Jun '12

04 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18733 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: oleaut32: Add a test for BSTR cache.
by Marvin 04 Jun '12

04 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18731 Your paranoid android. === W2KPROSP4 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 98 out of 256 === WXPPROSP3 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 99 out of 256

1 0

Re: [3/3] iphlpapi: Check for the right TCP statistics structure name (for DragonFly BSD)
by Juan Lang 03 Jun '12

03 Jun '12

Hi André, +#if HAVE_STRUCT_TCPSTAT_TCPS_CONNATTEMPT + struct tcpstat tcp_stat; +#elif HAVE_STRUCT_TCP_STATS_TCPS_CONNATTEMPT + struct tcp_stats tcp_stat; +#endif struct tcpstat tcp_stat; I think you meant to remove the declaration outside of the #if. --Juan

2 1

Re: [1/4] user32/tests: remove WM_DESTROY processing in test (it is of no use and causes tests skipping) (try 2)
by Marvin 03 Jun '12

03 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18723 Your paranoid android. === W7PROX64 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === W7PROX64 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible.

1 0

Mono?!?
by Max TenEyck Woodbury 03 Jun '12

03 Jun '12

When did WINE start requiring MONO? I have a VERY strong DISLIKE for MONO and do NOT want it on my machines. Seems to be a recent addition. Is it possible to NOT use it? PLEASE!

6 15

Re: shell32: fix compilation error with strcpy_chk: buffer overflow detected
by Nikolay Sivov 02 Jun '12

02 Jun '12

A static string constant would be better here. On Sat, Jun 2, 2012 at 12:42 PM, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > --- > dlls/shell32/pidl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index c394e5b..5906a4f 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -1752,16 +1752,17 @@ LPITEMIDLIST _ILCreateDrive(LPCWSTR lpszNew) > LPITEMIDLIST _ILCreateEntireNetwork(void) > { > LPITEMIDLIST pidlOut; > + DWORD alen = sizeof("Entire Network"); > > TRACE("\n"); > > - pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[sizeof("Entire Network")])); > + pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[alen])); > if (pidlOut) > { > LPPIDLDATA pData = _ILGetDataPointer(pidlOut); > > pData->u.network.dummy = 0; > - strcpy(pData->u.network.szNames, "Entire Network"); > + memcpy(pData->u.network.szNames, "Entire Network", alen + 1); > } > return pidlOut; > } > -- > 1.7.9.7 > > -- > С уважением, > Виталий Липатов, > Etersoft > >

1 0

Re: shell32: Make ShellExecute use native file association databases as fallback path
by Francois Gouget 02 Jun '12

02 Jun '12

On Thu, 31 May 2012, Erik van Pienbroek wrote: [...] > Tested successfully on a Fedora 17 environment using the start.exe > command and Outlook 2007 by trying to open a .pdf file (where there > is no file association registered inside the wine prefix) There are two issues with this patch: * In some cases xdg-open returns 0 whether or not there is a native file association. This is the case in KDE for instance. That would cause ShellExecute() to be unable to return anything but success. * There is a risk of infinite loops if the native association calls Wine. One such scenario is if you create the native association using Wine but later wipe out the Wine prefix so that there is no handler on the Wine side anymore. However I believe it can also happen simply because Windows' associations are based on extensions and Unix's on MIME types so that neither thinks they handle that case. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.
by Alexandre Julliard 01 Jun '12

01 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Any chance for at least a comment? You did get a comment from Huw that you need to allocate extra bytes, you still haven't done that AFAICS. -- Alexandre Julliard julliard(a)winehq.org

2 5

size of wine packages
by Marcus Meissner 01 Jun '12

01 Jun '12

Hi, As we have crossed the 100MB installed size (stripped) for the Wine RPM packages (stripped), this makes a Wow64 capable installation taking around 200MB these days. Can we reduce this size? eg. kernel32.dll.so has 1.6MB of static data inside itself, which is puzzling me a bit. (winerror.res is 1.3MB, winerror.mc is 0.068 MB ... Huh? Translations blowing this up?) Out of 100MB /usr/lib/wine/, e.g. I have here 67 MB of .text (73MB on x86_64) 11 MB of .data (static data) Ciao, Marcus

1 0

Judge rules: APIs can not be copyrighted.
by Detlef Riekenberg 01 Jun '12

01 Jun '12

1 0

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)
by Dmitry Timoshkov 31 May '12

31 May '12

sir-lexa <sir-lexa(a)yandex.ru> wrote: > case WM_DESTROY: > - PostQuitMessage(0); > + /* PostQuitMessage(0); It lets some tests to be skipped */ > return TRUE; This is not acceptable, there is much more behind the scene. You need to figure out the real reason of skipping the tests. -- Dmitry.

2 2

Re: [PATCH 3/5] ddraw/tests: Add test_coop_level_mode_set() for older ddraw versions.
by Marvin 31 May '12

31 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18687 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:2282: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2284: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2310: Test failed: Expected surface width 640, got 800. ddraw2.c:2312: Test failed: Expected surface height 480, got 600. ddraw2.c:2327: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2338: Test failed: Expected surface width 640, got 800. ddraw2.c:2340: Test failed: Expected surface height 480, got 600. ddraw2.c:2406: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2408: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2434: Test failed: Expected surface width 640, got 800. ddraw2.c:2436: Test failed: Expected surface height 480, got 600. ddraw2.c:2451: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2462: Test failed: Expected surface width 640, got 800. ddraw2.c:2464: Test failed: Expected surface height 480, got 600. === WNT4WSSP6 (32 bit ddraw1) === ddraw1.c:2145: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2147: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2173: Test failed: Expected surface width 640, got 800. ddraw1.c:2175: Test failed: Expected surface height 480, got 600. ddraw1.c:2190: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2201: Test failed: Expected surface width 640, got 800. ddraw1.c:2203: Test failed: Expected surface height 480, got 600. ddraw1.c:2269: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2271: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2297: Test failed: Expected surface width 640, got 800. ddraw1.c:2299: Test failed: Expected surface height 480, got 600. ddraw1.c:2314: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2325: Test failed: Expected surface width 640, got 800. ddraw1.c:2327: Test failed: Expected surface height 480, got 600.

1 0

Re: [PATCH 3/3] ntdll/tests: Add tests for RtlGetProductInfo [resend]
by Alexandre Julliard 31 May '12

31 May '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > Clone the kernel32 tests to verify, that the NULL pointer > check is present in ntdll.dll That's not useful, it's clearly the same function, it doesn't need to be tested twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] win16/int21: make found filename uppercase.
by Alexandre Julliard 31 May '12

31 May '12

Oleksij Rempel <bug-track(a)fisher-privat.net> writes: > @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context ) > INT21_FindPath = dta->fullPath = NULL; > } > dta->count = n; > + p = dta->filename; > + for ( ; *p; p++) *p = toupper(*p); Using toupper is probably not a good idea on OEM codepage strings. Which app depends on this? -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [4/4] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18675 Your paranoid android. === WXPPROSP3 (32 bit metadata) === metadata: unhandled exception c0000005 at 4CCA826D === W2K8SE (32 bit metadata) === metadata: unhandled exception c0000005 at 72C28045

1 0

Re: [3/4] windowscodecs: Add test for IWICMetadataBlockReader interface.
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18674 Your paranoid android. === WXPPROSP3 (32 bit metadata) === metadata: unhandled exception c0000005 at 4CCA826D === W2K8SE (32 bit metadata) === metadata: unhandled exception c0000005 at 72C28045

1 0

crypt32/tests(1/6): Don't shadow a variable with a variable of a different type
by Juan Lang 30 May '12

30 May '12

--Juan

1 0

Re: [2/2]kernel32/test: added test for OutputDebugStringA called with NULL pointer
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18671 Your paranoid android. === WXPPROSP3 (32 bit debugger) === Timeout === W2K3R2SESP2 (32 bit debugger) === Timeout

1 0

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)
by Dmitry Timoshkov 30 May '12

30 May '12

Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + offset.QuadPart = 0; > + size.u.LowPart = 0xffffffff; > + size.u.HighPart = 0xffffffff; > + return IWICStream_InitializeFromIStreamRegion(iface, pIStream, offset, size); What prevents you from discovering correct stream size? -- Dmitry.

3 5

Re: [1/2] mscoree: Install Wine Mono on prefix update.
by Alexandre Julliard 30 May '12

30 May '12

Vincent Povirk <madewokherd(a)gmail.com> writes: > From d271ba591f6afb4e0b2356da24841f54d5f11b9b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Tue, 29 May 2012 10:35:36 -0500 > Subject: [PATCH 1/2] mscoree: Install Wine Mono on prefix update. > > --- > dlls/mscoree/mscoree_main.c | 120 +++++++++++++++++++++++++++++++++++++++++++ > tools/wine.inf.in | 1 + > 2 files changed, 121 insertions(+) This is breaking 64-bit prefixes, because things are not done in the correct order. It also looks like the package is not creating the 64-bit registry keys. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 4/4] jscript: Added VT_I2 tests
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18657 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel