- wine-devel - winehq.org

Re: [PATCH 2/3] jscript: Get rid of ret_nan hack
by Ruslan Kabatsayev 30 May '12

30 May '12

Hello, This patch (committed as d0a719a79dae001df341db907fcae54118691d35) leads to compilation error: make[1]: Entering directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -I/opt/Xorg-7.5/include -L/opt/Xorg-7.5/lib -o string.o string.c lex.c: In function ‘cc_token’: lex.c:936:71: error: ‘NAN’ undeclared (first use in this function) lex.c:936:71: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [lex.o] Error 1 I've tried doing git clean -xdf, but this still doesn't compile. Regards, Ruslan On Tue, May 29, 2012 at 2:53 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/jscript/date.c | 28 ++++++++++++++-------------- > dlls/jscript/error.c | 3 ++- > dlls/jscript/global.c | 2 +- > dlls/jscript/jscript.h | 7 ------- > dlls/jscript/jsutils.c | 6 +++--- > dlls/jscript/lex.c | 2 +- > 6 files changed, 21 insertions(+), 27 deletions(-) > > > > >

2 1

ru.po: improved an Russian translation
by Oleg Yarigin 30 May '12

30 May '12

There are some improvements of a style (now it is more official) and non-translated empty lines. To avoid an character encoding interruption, I send the diff file as a packed text file attachment (ru_diff.txt.bz2, 22.3 KB).

3 2

stub for SetThreadStackGuarantee
by Daniel Jelinski 29 May '12

29 May '12

Hello, SQL Server Management Studio 2005 needs SetThreadStackGuarantee to either be absent or return TRUE - otherwise it refuses to run at all. Is there a reason for this stub to return FALSE? Regards, Daniel

1 0

Re: kernel32/volume: Don't modify the last error in GetVolumeInformation
by Alexandre Julliard 29 May '12

29 May '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, > } > else > { > + /* At this point, last error is ERROR_NOT_SUPPORTED. Restoring the previous one */ > + SetLastError(lastError); You should never need to do that sort of thing, there are no guarantees about last error on success. -- Alexandre Julliard julliard(a)winehq.org

2 1

Implementing joystick ids in DirectInput
by Lucas Zawacki 29 May '12

29 May '12

Hey guys, asking for a little code review here... I was looking at the solution for this bug http://bugs.winehq.org/show_bug.cgi?id=30705 and it comes down to implementing the DIPROP_JOYSTICKSID property for joystick devices. After some research on what this is I know it's always a number between (0,n), where n is the number of joysticks connected, and is analogous to the winmm driver joystick id. The solution I came up is in the attached patch, it's a little weird but I found it hard to give a unique ID to each joystick on Linux when they can come from different drivers. This solution uses the order which dinput puts the joysticks on it's device list and will work regardless. If someone has a better way to do it I'd like to know. Cheers,

2 2

Re: [PATCH 1/3] ntdll: Implement RtlGetProductInfo and use it for GetProductInfo
by Alexandre Julliard 29 May '12

29 May '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > The wrapper in kernel32 is not needed. > RtlGetProductInfo and GetProductInfo have the same signature and > tests show the same results. No they don't have the same signature, look closer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] d3dx9: Implement D3DXSaveSurfaceToFileInMemory.
by Vincent Povirk 28 May '12

28 May '12

> - hr = IWICImagingFactory_CreateStream(factory, &stream); > + hr = IWICImagingFactory_CreateStream(factory, &wic_stream); > IWICImagingFactory_Release(factory); > if (FAILED(hr)) goto cleanup_err; > > - hr = IWICStream_InitializeFromFilename(stream, dst_filename, GENERIC_WRITE); > + hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); > if (FAILED(hr)) goto cleanup_err; > > + hr = IWICStream_InitializeFromIStream(wic_stream, stream); Why bother creating an IWICStream here? Just use your HGLOBAL stream to initialize the encoder.

1 0

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream.
by Vincent Povirk 28 May '12

28 May '12

> +static HRESULT WINAPI StreamOnStream_Seek(IStream *iface, > + LARGE_INTEGER dlibMove, DWORD dwOrigin, ULARGE_INTEGER *plibNewPosition) > +{ > + StreamOnStream *This = StreamOnStream_from_IStream(iface); > + HRESULT hr=S_OK; > + TRACE("(%p)\n", This); > + > + EnterCriticalSection(&This->lock); > + hr = IStream_Seek(This->stream, dlibMove, dwOrigin, plibNewPosition); > + LeaveCriticalSection(&This->lock); > + > + return hr; > +} The IWICStream needs to have an independent position from the underlying stream. Also, why not just forward to InitializeFromIStreamRegion?

1 0

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)
by Marvin 28 May '12

28 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18630 Your paranoid android. === W7PROX64 (32 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === TEST64_W7SP1 (32 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === W7PROX64 (64 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === TEST64_W7SP1 (64 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible.

1 0

Re: d3dx9_36/tests: Add tests for D3DXCreatePolygon
by Marvin 27 May '12

27 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18615 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

func or pFunc in tests ?
by GOUJON Alexandre 27 May '12

27 May '12

Hi, I'm planning to add a test in the wine test suite and I noticed a difference. Some tests call directly the function by its name (i.e. GetWindowsDirectory, CreateFileA, CloseHandle...) while others declare a pointer to the function (prefixing its name by 'p' and followed by a capital letter) retrieved via GetProcAddress. I know that tests have been written by lots of different people at different times and the general rule is "follow the style of the test file to be consistent" but here, both styles exist in the same file (kernel32/tests/volume.c). Is there any rule concerning using func over pFunc ? Is it related to the module it comes from ? Thanks

2 2

[website] Logo license? Usable in a propritary App?
by André Hentschel 25 May '12

25 May '12

Hey, they use the "old" WineHQ Logo in this 99 Cent App: https://play.google.com/store/apps/details?id=com.appdevandroid.framework.w… Is that ok? If not, could the creater please contact them. The Icon could be misleading. -- Best Regards, André Hentschel

1 0

Fwd: [Freerdp-devel] WinPR: Windows Portable Runtime
by Pau Garcia i Quiles 25 May '12

25 May '12

FYI ---------- Forwarded message ---------- From: Marc-André Moreau <marcandre.moreau(a)gmail.com> Date: Fri, May 25, 2012 at 3:04 AM Subject: [Freerdp-devel] WinPR: Windows Portable Runtime To: freerdp-devel <freerdp-devel(a)lists.sourceforge.net> Dear FreeRDP community, I have an announcement to make regarding a new spin-off project which I've been preparing for a while. Please read as this will set the tone of future development :) You can find most current WinPR development work on the winpr branch: https://github.com/FreeRDP/FreeRDP/tree/winpr WinPR is a spin-off project of FreeRDP which aims at providing a portable implementation of important portions of the Windows API. Just like FreeRDP, WinPR is released under the Apache license. Unlike Wine, WinPR does not provide binary compatibility, and does not require applications to be built for Windows. Instead, WinPR provides API compatibility for applications targeting non-Windows environments. When on Windows, the original native API is being used instead of the equivalent WinPR implementation, without having to modify the code using it. WinPR is the result of long and thoughtful process that came up after years of FreeRDP development. RDP, as you know, is a protocol designed by Microsoft and is primarily “Windows to Windows”. In many instances, protocol messages rely heavily on Windows-specific APIs which have no direct equivalent on other operating systems. For instance, core graphical messages are based on GDI, network level authentication makes use of the Microsoft SSPI authentication modules (CredSSP, NTLM), and terminal server gateway makes use of both SSPI and MSRPC. That’s not even mentioning all the effort that went into mapping keyboard systems and time zones. Developing FreeRDP is in many ways all about implementing Windows APIs outside of Windows. Immense efforts have gone into the implementation of such features, to the point where they begin having value outside of FreeRDP itself. At this point, one of the most valuable part of WinPR is the set of SSPI modules. Various NTLM implementations exist, all with different interfaces, but the WinPR implementation is a direct replacement of the original. This is an advantage because the API is already well documented, with expected inputs and outputs. FreeRDP can also optionally build against the native SSPI modules when on Windows. Making this code easily reusable to any one means that application developers now have an easy way of porting their applications to make use of the Windows authentication architecture. WinPR is also a response to a recurrent problem in FreeRDP development: the proliferation of custom helpers and utility functions. While those are useful, they often need to be modified and updated to meet new requirements, causing frequent API changes. Breaking the API regularly obviously makes a lot of developers unhappy. By choosing to implement an existing and mature API, we can effectively get rid of the core of the problem. If a certain API has been used for years and it fits the needs of most people, you are less likely to need to break it yourself. Besides the argument of API stability, there is another huge advantage in using the Windows API over custom utility functions: the ability to easily share code with other projects that aim at implementing the same API. For instance, the SSPI modules currently developed in WinPR are of high interest to the ReactOS project. If the code was filled with custom utility functions, it would be much harder to use outside of FreeRDP, hindering such collaboration opportunities. For instance, instead of wrapping calls to MultiByteToWideChar() in a custom unicode conversion utility, we can use MultiByteToWideChar() as the utility function and provide an implementation on non-Windows systems. As a general rule in WinPR, if a utility function can be replaced by a part of the Windows API, then the Windows API will have precedence. Otherwise, a utility method can be used, keeping in mind the downsides of it. WinPR is also designed to be as modular as possible, using the MinWin architecture as a reference. MinWin is a refactoring effort of the Windows API which is more cleaner and comprehensive than the original. The API has been separated into logical sets, each with a DLL. Not a lot of documentation is available online about MinWin, but one can find its structure in the MSDN article “Windows API Sets”: http://msdn.microsoft.com/en-us/library/hh802935/ Just like MinWin, WinPR aims at being minimalistic and modular, such that one can have fine grained control over what is to be used. For projects making use of only a small amounts of WinPR, it should be possible to depend only on the minimum required. At last, why not simply use Wine or code from other projects like ReactOS or Samba? In all of these cases, there are both licensing and architectural problems which make it fairly hard for us to use in FreeRDP. For instance, Wine provides binary compatibility, and it’s not easy for a native Linux application to make use of parts of it without being built for Windows. Samba has an interesting MSRPC implementation, but it’s a fairly big dependency, without counting the fact that we can forget about portability on mobile platforms like Android and iOS. Unfortunately, none of these provide a highly portable implementation of the Windows API in the way we would like and under a license which is suitable to us, justifying the existence of WinPR. Through WinPR, investment done in FreeRDP development will take a new life and become even more valuable. We will open new doors to even higher levels of interoperability. We will foster collaboration with other projects following similar goals and reach new heights at an increasingly faster pace. Stay tuned, you will be amazed! ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freerdp-devel mailing list Freerdp-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer)

1 0

Re: [5/5] propsys: Implement IPropertyStore::GetCount.
by Marvin 24 May '12

24 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18573 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] propsys: Implement IPropertyStore::SetValue and GetValue.
by Marvin 24 May '12

24 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18572 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Reimplement GdipIsEmptyRegion.
by Dmitry Timoshkov 24 May '12

24 May '12

Hello, I'm surprised that such a trivial patch wasn't accepted yet. But just in case it matters, current implementation doesn't work for paths and combined/complex regions. -- Dmitry.

2 2

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader interface.
by Vincent Povirk 24 May '12

24 May '12

Please add a test showing that some builtin metadata handler implements this interface. On Thu, May 24, 2012 at 4:39 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/metadatahandler.c | 69 ++++++++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c > index afcff21..ffe6763 100644 > --- a/dlls/windowscodecs/metadatahandler.c > +++ b/dlls/windowscodecs/metadatahandler.c > @@ -39,6 +39,7 @@ typedef struct MetadataHandler { > IWICMetadataWriter IWICMetadataWriter_iface; > LONG ref; > IWICPersistStream IWICPersistStream_iface; > + IWICMetadataBlockReader IWICMetadataBlockReader_iface; > const MetadataHandlerVtbl *vtable; > MetadataItem *items; > DWORD item_count; > @@ -55,6 +56,11 @@ static inline MetadataHandler *impl_from_IWICPersistStream(IWICPersistStream *if > return CONTAINING_RECORD(iface, MetadataHandler, IWICPersistStream_iface); > } > > +static inline MetadataHandler *impl_from_IWICMetadataBlockReader(IWICMetadataBlockReader *iface) > +{ > + return CONTAINING_RECORD(iface, MetadataHandler, IWICMetadataBlockReader_iface); > +} > + > static void MetadataHandler_FreeItems(MetadataHandler *This) > { > int i; > @@ -92,6 +98,10 @@ static HRESULT WINAPI MetadataHandler_QueryInterface(IWICMetadataWriter *iface, > { > *ppv = &This->IWICPersistStream_iface; > } > + else if (IsEqualIID(&IID_IWICMetadataBlockReader, iid)) > + { > + *ppv = &This->IWICMetadataBlockReader_iface; > + } > else > { > *ppv = NULL; > @@ -317,6 +327,64 @@ static const IWICPersistStreamVtbl MetadataHandler_PersistStream_Vtbl = { > MetadataHandler_SaveEx > }; > > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_QueryInterface(IWICMetadataBlockReader *iface, > + REFIID iid, void **ppv) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_QueryInterface(&This->IWICMetadataWriter_iface, iid, ppv); > +} > + > +static ULONG WINAPI MetadataHandler_MetadataBlockReader_AddRef(IWICMetadataBlockReader *iface) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_AddRef(&This->IWICMetadataWriter_iface); > +} > + > +static ULONG WINAPI MetadataHandler_MetadataBlockReader_Release(IWICMetadataBlockReader *iface) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_Release(&This->IWICMetadataWriter_iface); > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetContainerFormat( > + IWICMetadataBlockReader *iface, GUID *guid) > +{ > + FIXME("(%p,%p): stub\n", iface, guid); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetCount( > + IWICMetadataBlockReader *iface, UINT *count) > +{ > + FIXME("(%p,%p): stub\n", iface, count); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetReaderByIndex( > + IWICMetadataBlockReader *iface, UINT index, IWICMetadataReader **reader) > +{ > + FIXME("(%p,%u,%p): stub\n", iface, index, reader); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetEnumerator( > + IWICMetadataBlockReader *iface, IEnumUnknown **enum_metadata) > +{ > + FIXME("(%p,%p): stub\n", iface, enum_metadata); > + return E_NOTIMPL; > +} > + > +static const IWICMetadataBlockReaderVtbl MetadataHandler_MetadataBlockReader_Vtbl = > +{ > + MetadataHandler_MetadataBlockReader_QueryInterface, > + MetadataHandler_MetadataBlockReader_AddRef, > + MetadataHandler_MetadataBlockReader_Release, > + MetadataHandler_MetadataBlockReader_GetContainerFormat, > + MetadataHandler_MetadataBlockReader_GetCount, > + MetadataHandler_MetadataBlockReader_GetReaderByIndex, > + MetadataHandler_MetadataBlockReader_GetEnumerator > +}; > + > HRESULT MetadataReader_Create(const MetadataHandlerVtbl *vtable, IUnknown *pUnkOuter, REFIID iid, void** ppv) > { > MetadataHandler *This; > @@ -333,6 +401,7 @@ HRESULT MetadataReader_Create(const MetadataHandlerVtbl *vtable, IUnknown *pUnkO > > This->IWICMetadataWriter_iface.lpVtbl = &MetadataHandler_Vtbl; > This->IWICPersistStream_iface.lpVtbl = &MetadataHandler_PersistStream_Vtbl; > + This->IWICMetadataBlockReader_iface.lpVtbl = &MetadataHandler_MetadataBlockReader_Vtbl; > This->ref = 1; > This->vtable = vtable; > This->items = NULL; > -- > 1.7.10.1 > > >

1 0

Testing regedit
by Daniel Jelinski 24 May '12

24 May '12

Hello, I just noticed that wine's regedit has a few interesting bugs that appear when running with native comctl32. Can I/should I file them in the bugzilla? Regards, Daniel

3 3

Re: [PATCH variant 1] dsound: use a low-quality FIR for games
by Andrew Eikum 23 May '12

23 May '12

Thanks Alexander. Thoughts below... On Sat, May 19, 2012 at 09:09:35PM +0600, Alexander E. Patrakov wrote: > There are two ways to implement a high-performance resampler, and I > have prepared (conflicting, pick no more than one) patches for both: > > 1 (this patch): Use a shorter FIR with the existing code. This has the > advantage of higher quality (unwanted frequencies are at least > attempted to be rejected) and almost no new code. > 2 (the other patch): Write new code. E.g., linear interpolation. This > is what Windows XP does at its lowest quality setting, and it eats > less CPU than variant 1. > Do you have an opinion on which of these patches to use? The low-quality FIR has the advantage of not introducing another codepath. On the other hand, the linear resampler codepath is very simple, and even easier on the CPU. I'm leaning towards the linear resampler for its larger CPU usage benefits. > Also note that, as evicenced by the debugging patch, a Core 2 Duo > E6420 @ 2.13 GHz _can_ resample more than 32 streams simultaneously > from various weird rates to 48000 Hz. As GTA:SA reportedly creates > only 16 secondary buffers, it _should_ have more than enough CPU time > to mix them. IMHO, this makes bug #30639 look somewhat strange: on > GyB's computer, GTA:SA stutters, while Darwinia (which looks more > demanding about sound) doesn't. It may well be that in fact none of my > patches are needed, and that the real bug is that the CPU-intensive > cp_fields() function is called from a wrong thread or process. I don't > have the expertise needed to debug this. > I did some research on this. Darwinia creates up to 32 buffers, like you said. GTA:SA creates and destroys buffers as needed, and I saw it go as high as 31 in a quick test. Darwinia's buffer frequencies range in the 40-90 kHz range and resample to 22050 Hz, while GTA:SA's range around 10-20 kHz and resample to 48 kHz. So in each time step, GTA:SA requires about 1000-2000 get_current_sample() calls, but 4800 FIR convolutions per buffer. Darwinia requires 4000-9000 get_current_sample() calls, but only about 2200 convolutions per buffer. I suspect the convolutions are considerably more expensive than the get_current_sample() calls, so I would actually expect GTA:SA to be more CPU taxing. That should explain what's going on here. We could test this on Gyb's machine by setting DefaultSampleRate=22050 and hacking <dlls/dsound/primary.c:primarybuffer_SetFormat> to return S_OK without actually changing the primary buffer's format. That should give GTA:SA similar cp_fields performance to Darwinia, and I expect it would fix the lag issue. Andrew

2 2

Re: vbscript: Add support for integer values in conditional jumps.
by Marvin 23 May '12

23 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18547 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

2 1

Re: [2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.
by Bruno Jesus 22 May '12

22 May '12

On Mon, Apr 30, 2012 at 6:52 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/gdi32/freetype.c | 35 +++++++++++++++++++- > dlls/gdi32/tests/font.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 116 insertions(+), 2 deletions(-) I don't know if this patch was directly related to a bug or not but now we are sure it does really fix at least this bug: http://bugs.winehq.org/show_bug.cgi?id=12476 Best wishes, Bruno

1 0

Re: wineqtdecoder: Recreate audio extraction session when we run out of frames.
by Alexandre Julliard 22 May '12

22 May '12

Aric Stewart <aric(a)codeweavers.com> writes: > This is instead of waiting until a movie is fully loaded before being > able to start playing. This eliminates the up to several second pause > when starting some, mostly avi, movies. > --- > dlls/wineqtdecoder/qtsplitter.c | 66 > +++++++++++++++++++++++++++++++++------ > 1 files changed, 56 insertions(+), 10 deletions(-) What about the comment that says that we can't do that? -- Alexandre Julliard julliard(a)winehq.org

2 1

winetricks & DLL overrides
by wylda＠volny.cz 22 May '12

22 May '12

Hi Dan, i'm happy user of winetricks and thanks for all that work. Today i found out, that i wasn't able to reveal, that apps uses some native dll when using: winetricks settings alldlls=builtin further checking revealed, that winetricks(20120308) has several no longer available dll override compared to winecfg and some are missing, thus application uses them as native. So i add/del dlls from override_all_dlls list based on winecfg (1.5.3-164-gdec3d50) and the result is attached as a patch. Probably unusable for you, because: * no care about line length * i do not know whether removing no longer available dll's override is allowed (what's happen for users using old wine-1.0 and need dlls's override no longer available in wine-1.5.3) * shouldn’t be the dll's override in user.reg simply overwritten? As i noticed the names are there twice - 2nd one with "*" prefix making it confusing, which value will be used and the list in winecfg is twice as long. Thanks and regards, W.

2 2

Re: [1/2] ole32: Forward OleCreateLinkFromData and OleCreateStaticFromData to OleCreateFromData.
by Alexandre Julliard 22 May '12

22 May '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +/****************************************************************************** > + * OleCreateLinkFromData [OLE32.@] > + */ > +HRESULT WINAPI OleCreateLinkFromData(LPDATAOBJECT data, REFIID iid, > + DWORD renderopt, LPFORMATETC fmt, > + LPOLECLIENTSITE client_site, LPSTORAGE stg, > + LPVOID *obj) > +{ > + return OleCreateFromData(data, iid, renderopt, fmt, client_site, stg, obj); > +} > + > +/****************************************************************************** > + * OleCreateStaticFromData [OLE32.@] > + */ > +HRESULT WINAPI OleCreateStaticFromData(LPDATAOBJECT data, REFIID iid, > + DWORD renderopt, LPFORMATETC fmt, > + LPOLECLIENTSITE client_site, LPSTORAGE stg, > + LPVOID *obj) > +{ > + return OleCreateFromData(data, iid, renderopt, fmt, client_site, stg, obj); > +} Surely there's more to these functions than that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: quartz/tests: Fix compilation on systems that don't support nameless structs.
by Marvin 21 May '12

21 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18512 Your paranoid android. === WNT4WSSP6 (32 bit filtermapper) === filtermapper.c:96: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:233: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:347: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:405: Test failed: CoCreateInstance failed with 80040154

2 1

Re: [PATCH 3/3] shell32: Move the pidl handling to the ExtractIcon_Constructor
by Nikolay Sivov 20 May '12

20 May '12

On 5/20/2012 18:47, Detlef Riekenberg wrote: > } else if (IsEqualIID(riid,&IID_IExtractIconA)&&(cidl == 1)) { > - pidl = ILCombine(This->pidlRoot, apidl[0]); > - pObj = (LPUNKNOWN) IExtractIconA_Constructor(pidl); > - SHFree(pidl); > - hr = S_OK; > + return IExtractIconAW_Constructor(This->pidlRoot, apidl[0], FALSE, ppvOut); > } else if (IsEqualIID(riid,&IID_IExtractIconW)&&(cidl == 1)) { > - pidl = ILCombine(This->pidlRoot, apidl[0]); > - pObj = (LPUNKNOWN) IExtractIconW_Constructor(pidl); > - SHFree(pidl); > - hr = S_OK; > + return IExtractIconAW_Constructor(This->pidlRoot, apidl[0], TRUE, ppvOut); > } else if ((IsEqualIID(riid,&IID_IShellLinkW) || IsEqualIID(riid,&IID_IShellLinkA)) I think it's better to pass riid to constructor helper and return appropriate vtable according to that riid. That will also collapse this to a single 'if' testing for both interfaces. > +HRESULT IExtractIconAW_Constructor(LPCITEMIDLIST root, LPCITEMIDLIST item, BOOL is_unicode, void ** ppvOut) > { > - IExtractIconWImpl *ei; > + IExtractIconWImpl *ei = HeapAlloc(GetProcessHeap(), 0, sizeof(IExtractIconWImpl)); > + LPITEMIDLIST pidl = ILCombine(root, item); > > - TRACE("%p\n", pidl); > + if (!pidl || !ei) { > + SHFree(pidl); > + HeapFree(GetProcessHeap(), 0, ei); > + return E_OUTOFMEMORY; > + } > > - ei = HeapAlloc(GetProcessHeap(), 0, sizeof(*ei)); > ei->ref=1; > ei->IExtractIconW_iface.lpVtbl =&eivt; > ei->IExtractIconA_iface.lpVtbl =&eiavt; > ei->IPersistFile_iface.lpVtbl =&pfvt; > ei->pidl=ILClone(pidl); > > - pdump(pidl); Same here as in previous patch - storing combined result vs. making another clone.

1 0

Re: [PATCH 1/3] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf [try 2]
by Nikolay Sivov 20 May '12

20 May '12

On 5/20/2012 18:47, Detlef Riekenberg wrote: > +HRESULT IQueryInfo_Constructor(LPCITEMIDLIST root, LPCITEMIDLIST item, void ** ppvOut) > +{ > + IQueryInfoImpl *qi = HeapAlloc(GetProcessHeap(), 0, sizeof(IQueryInfoImpl)); > + LPITEMIDLIST pidl = ILCombine(root, item); > + > + if (!pidl || !qi) { > + SHFree(pidl); > + HeapFree(GetProcessHeap(), 0, qi); > + return E_OUTOFMEMORY; > + } > + > + qi->IQueryInfo_iface.lpVtbl =&IQueryInfo_vtbl; > + qi->ref = 1; > + qi->pidl = ILClone(pidl); > + > + SHFree(pidl); I don't see a reason to ILClone() here. You could just store ILCombine() result.

1 0

Re: dsound: Fixed compilation error caused by 942f2ce7
by Jacek Caban 19 May '12

19 May '12

Hi Alexander, On 5/19/12 3:35 PM, Alexander E. Patrakov wrote: > There is no dummy union u anymore. > This doesn't seem right. They are still present, just generated by widl. Jacek

2 2

re: [appdb] Applications working flawlessly using patched wine should be rated Gold
by Dan Kegel 18 May '12

18 May '12

Frédéric Delanoy wrote: -Application works flawlessly with some DLL overrides, other settings or third party software. +Application works flawlessly with some DLL overrides, some patches applied, other settings or third party software. Really? IMHO they should still be silver. Patches are very hard for the average user to deploy without a third party front end like POL, and appdb is not about POL. - Dan

7 13

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling (try 3)
by Marvin 18 May '12

18 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18480 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === Timeout

1 0

Re: [PATCH 1/5] programs: First version of the joystick testing tool. Just lists connected joysticks.
by Alexandre Julliard 18 May '12

18 May '12

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > --- > configure.ac | 1 + > programs/joystick/Makefile.in | 17 +++++++ > programs/joystick/main.c | 102 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 120 insertions(+) > create mode 100644 programs/joystick/Makefile.in > create mode 100644 programs/joystick/main.c I don't think it makes sense to add a command-line application for this. If there are really things that the user needs to configure, it should be a control panel. But ideally we should retrieve the settings from the Unix environment. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: quartz: COM cleanup for Parser_OutputPin
by Michael Stefaniuc 18 May '12

18 May '12

Hello Aric, On 05/18/2012 04:27 PM, Aric Stewart wrote: > diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c > index 5027e90..bac1b24 100644 > --- a/dlls/quartz/avisplit.c > +++ b/dlls/quartz/avisplit.c > @@ -288,7 +288,7 @@ static HRESULT AVISplitter_next_request(AVISplitterImpl *This, DWORD streamnumbe > > static HRESULT AVISplitter_Receive(AVISplitterImpl *This, IMediaSample *sample, DWORD streamnumber) > { > - Parser_OutputPin *pin = (Parser_OutputPin *)This->Parser.ppPins[1+streamnumber]; > + Parser_OutputPin *pin = impl_Parser_OutputPin_from_IPin(This->Parser.ppPins[1+streamnumber]); this isn't right. impl_from_... should be used only from methods of the respective implementation. You can either: - Make This->Parser.ppPins an array of Parser_OutputPin instead of IPin - Or if you need to support application provided IPin then you'll need an unsafe_impl_from_... > HRESULT hr; > LONGLONG start, stop, rtstart, rtstop; > StreamData *stream = &This->streams[streamnumber]; bye michael

2 1

Logging issue ?
by GOUJON Alexandre 18 May '12

18 May '12

Hi, To understand why a game does not work with the disc while it does with the ISO (created from the same disc), I made a log with +tid,+relay,+volume in both cases and noticed : - some lines (call or ret) are not printed / missing - some lines are half-printed and joined with the following I know sometimes a trailing \n is missing in TRACE() so the output is uncertain. But that doesn't seem to be the case here. Maybe it's not thread safe or something like that ? I tried using taskset 1 wine .. to force using one core but no luck. Here a small part of my log (order not modified, I just remove lines from other threads): 0030:Call KERNEL32.GetVolumeInformationA(09732288 "D:",097321ec,0000007f,00000000,00000000,097321d8,00000000,00000000) ret=0057b045 0030:trace:volume:GetVolumeInformationW L"\\??\\D:\\": found fs type 50009:Call wined3d.wined3d_mutex_unlock() ret=7ed6e3a6 0030:Ret KERNEL32.CreateFileA() retval=000001f4 ret=00c8b5ab 0030:Call KERNEL32.DeviceIoControl(000001f4,00041018,00000000,00000000,09732190,00000008,097321a4,00000000) ret=00c8b64a The game calls GetVolumeInformationA .. the trace is mixed with output of another thread .. I guess the game open the device (no call line) .. and then do some ioctl. No trace of how the game opened the device.. I can do several logs and try to compare each other to have a complete puzzle but that's not very handy. Any thought ? idea ? advice ? (I'm using packaged wine on x86_64) Thanks

2 1

Fwd: Re: Logging issue ?
by GOUJON Alexandre 18 May '12

18 May '12

Also replying to wine-devel -------- Original Message -------- Subject: Re: Logging issue ? Date: Fri, 18 May 2012 16:52:34 +0200 From: GOUJON Alexandre <ale.goujon(a)gmail.com> To: Nikolay Sivov <bunglehead(a)gmail.com> On 05/18/2012 05:31 PM, Nikolay Sivov wrote: > On 5/18/2012 17:23, GOUJON Alexandre wrote: >> Any thought ? idea ? advice ? > I believe there was a discussion about that in the past, It usually > helps to use a ">>" redirect that appends to log file instead of > replacing its contents. But you'll obviously need to clean a log file > before starting anything Using>> instead of> seems to work. It's weird but if it works... Thanks for the advice !

1 0

Re: [PATCH 3/4] shell32: Add IQueryInfo to more shellfolder
by Nikolay Sivov 18 May '12

18 May '12

On 5/18/2012 14:06, Detlef Riekenberg wrote: > + } else if (IsEqualIID(riid,&IID_IQueryInfo)&& (cidl == 1)) { > + pidl = ILCombine (This->pidlRoot, apidl[0]); > + pObj = (IUnknown *) IQueryInfo_Constructor (pidl); > + SHFree (pidl); > + hr = S_OK; > } else { Patch doesn't have a cast here, and looks really redundant. If you really need that it's better to make IQueryInfo_Constructor look more like class factory call - with HRESULT and void** parameter. Also it looks like you always need to combine pidls and cleanup after that, I think it's better to combine them in constructor and keep result in QueryInfo impl. (instead of making a clone). So constructor could look like "HRESULT constructor(root, pidl, pObj)".

1 0

Re: [PATCH 1/4] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf
by Nikolay Sivov 18 May '12

18 May '12

On 5/18/2012 14:06, Detlef Riekenberg wrote: > + if (ppv == NULL) > + return E_POINTER; This is usually redundant. > + > + if (IsEqualGUID(&IID_IUnknown, riid) || > + IsEqualGUID(&IID_IQueryInfo, riid)) { > + *ppv =&This->IQueryInfo_iface; > + IUnknown_AddRef((IUnknown*)*ppv); > + TRACE("returning IQueryInfo: %p\n", *ppv); > + return S_OK; > + } Instead of using IUnknown for some reason a clean way could be to call IQueryInfo_AddRef(iface). Trace is not needed here - you have a trace on top of that and FIXME trace on a failure, so you'll know. > + > + *ppv = NULL; > + FIXME("(%p)->(%s %p) interface not supported\n", This, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; > +} > +IQueryInfo *IQueryInfo_Constructor(LPCITEMIDLIST pidl) > +{ > + IQueryInfoImpl *qi; > + > + TRACE("(%p)\n", pidl); > + > + qi = HeapAlloc(GetProcessHeap(), 0, sizeof(IQueryInfoImpl)); > + qi->IQueryInfo_iface.lpVtbl =&IQueryInfo_vtbl; > + qi->ref=1; > + qi->pidl=ILClone(pidl); > + > + TRACE("==> %p (pidl: %p)\n", qi, qi->pidl); > + return&qi->IQueryInfo_iface; > +} This doesn't handle HeaoAlloc() or ILClone failures.

1 0

Installing 64 bit visual c++ 2010 runtime?
by Dan Kegel 17 May '12

17 May '12

I'd like to try a real 64 bit app, so on a 64 bit Ubuntu 12.04, I tried sudo apt-get install wine rm -rf ~/.wine export WINEARCH=win64 wget http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650… wine vcredist_x64 and that installs fine... but only puts anything in c:\windows\syswow64, and the 64 bit app I'm trying is rather upset that it can't find mfc100.dll. The log it writes into c:\users\$LOGNAME\*.html says (if you look at the source, or click 'verbose' in a web browser) "platform not supported". This happens even if I use winecfg to set win7 mode. Happily, it looks like one can just grab the file from the .cab with something like this: mkdir foo cd foo cabextract ../vcredist_x64.exe cabextract vc_red.cab cp F_CENTRAL_mfc100_x86 ~/.wine/windows/system32 cd .. rm -rf foo That gets the app I'm trying to the point where it needs a newer builtin vcrun100, http://source.winehq.org/git/wine.git/?a=commit;h=6cb3713e26aa4d89d4dc67601… which is great. (Now I just have to get around to following up on previous posts about how to build biarch wine on ubuntu 12.04.) But I still wonder why the installer doesn't want to install the 64 bit files.

1 1

Re: comctl32: When created with TCS_VERTICAL, TCS_MULTILINE is set automatically
by Stefan Leichter 17 May '12

17 May '12

Thursday 17 May 2012 Nikolay Sivov <nsivov(a)codeweavers.com> > - DWORD dwStyle; > + DWORD style; Any reason for changing the name?

2 1

Re: kernel32: check the last parameter of K32EnumProcessModules for NULL before use (with test)
by Nikolay Sivov 17 May '12

17 May '12

On 5/17/2012 11:46, Stefan Leichter wrote: > SetLastError(0xdeadbeef); > + pEnumProcessModules(hpQI,&hMod, sizeof(HMODULE), NULL); > + ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = pEnumProcessModules(hpQV,&hMod, sizeof(HMODULE), NULL); > + ok(!ret, "succeeded\n"); > + ok(GetLastError() == ERROR_NOACCESS, "expected error=ERROR_NOACCESS but got %d\n", GetLastError()); > + Why don't you check return value from the first call?

2 1

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold
by K.King 17 May '12

17 May '12

<< A "runs well with patched wine" checkbox might be useful, but would be very confusing. Maybe if it forced the rating to be garbage that would be ok. >> If it was possible my preference would be to be able to see separate rating per vanilla and per non vanilla. The per vanilla should be first and more obvious. If I see a rating of Garbage infers even with patching it would not run? problem with "runs well with patched wine" is it's an on or off, whereas you could start wishing for an indication of how well it can be made to run? Keeping the steps, results, capabilities, not tested, etc for patched wine could/should maybe be kept quite separate to the quick and obvious vanilla out of box results section? K.

1 0

kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions
by Alex Henrie 16 May '12

16 May '12

Hello, This patch was marked committed yesterday--thank you for accepting it!--but it still isn't showing up in Git. Maybe it was accidentally skipped? It needs to be committed before I can submit the UTF-7 implementation I wrote that builds on it. -Alex

2 1

AppDB, ratings and native vs. builtin trouble
by Alexey Loukianov 16 May '12

16 May '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all subscribers of this list, I've got a small decision trouble I have to deal with as an AppDB maintainer. I know that years ago there had been discussion on this topic, but I want to bring this once on a surface once again so we would get a fresh modern look an thus minor problem. As we all know, Wine isn't perfect, thus applications often require native DLLs to behave properly. AppDb treats such cases as being "Gold" rating. It's easy to distinguish between "Platinum" and "Gold" case most of the time, but sometimes there are cases where native dll overrides happen automagically as a result of app installed installing third-party lib redists himself. Good example is idSoftware's Rage game which require XAudio2 to functions - which is not implemented in Wine. User would have to install and use native lib for game to function, but most of the times it would be done automatically by Steam (its "auto-install required libs" feature would try to install DirectX redist at the first time user would try to launch the game). How should we treat situations like that? From user PoV it's "Platinum" - app is working out of the box. From real side of things - it is "Gold", as native dll override is required for app to function - Wine's stubbed xaudio2 implementation is obviously not enough for game to work. With the recent release of Diablo III we're are at the same spot: game installer auto-installs vcrun2008 redist as a part of installation process, so end-user experience is like this game "works out of a box". Problem is that D3 installed isn't working unless user patches Wine's AcceptEx implementation with Erichs patchset, so for vast majority of Wine's userbase installing D3 would be something like "copy already installed D3 from other PC" - and that would bring the problem of the game requiring native VC++ 2008 runtime on the surface. How should we treat/assign ratings for these cases? P.S. Aside from that, I want to once again bring up the discussion on extending AppDB so more detailed test reports would be possible. IMO it might be reasonable to add to AppDB test report form is an ability to specify whether the version used was "vanilla" or "patched with some out-of-tree patches" one. For most reporters sane default would be "vanilla", while at some circumstances most of the test reports would come for "patched" version: good examples are SW:KOTR, WoT, D3 and many other games that require out-of-tree patches to function best under Wine. Thanks for spending your time reading this, and thanks in advance for your answers. - -- Best regards, Alexey Loukianov mailto:mooroon2@mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPs34GAAoJEPB9BOdTkBUL5KMH+gOtjQv1ckZ4tZ9X+kysZ/+0 gM1uCSHvuUdHuY+aVlUs688NU76mJcUu+ORPSuMrdltm7BCn5DbAN3ITjMSf2Y7y KHvvDFbGcKkiDupCyQhdNHpEyfC3PFzWjuI7o8nG/2eZGum5zRwGdbgvDvSc2Qo1 md208/6WDAGNjN2943orolG5pqhKapDvjvpoKSavgW1ykHeKDiTvCiNKXvcRU2ox bRZomHY93DNV0RoLnExcp8HnA/DooWQdGfwF4uTp+wgmIbwbWM4iw3Zw5CuXim+6 VzetXUPU9iVr2h3xqBgmVq5a7rMri7mykDXACo7ex30ekWM9XQBqSgT0jxqIi14= =16iP -----END PGP SIGNATURE-----

3 6

Re: [1/2] wmvcore: Add stub for WMCreateSyncReader (try 2) (resend)
by Nikolay Sivov 16 May '12

16 May '12

On 5/16/2012 19:46, André Hentschel wrote: > + wmsdkidl.idl \ > + wmsbuffer.idl \ This is supposed to be sorted. Also I think you need to add .gitignore changes as well.

1 0

RE: localspl: Only store the file part of the filenames in the registry
by Detlef Riekenberg 16 May '12

16 May '12

Hi Huw. We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. Which native driver makes problems? Why do you add spaces before and after the the function args and change idention, bracket style and variable names everywhere in the patch? HP is using a subdirectory for some driver files, but i can't remember the driver name at the moment. -- By by ... Detlef

2 1

re: AppDB, ratings and native vs. builtin trouble
by Dan Kegel 16 May '12

16 May '12

16.05.2012 17:34, Rosanne DiMesio wrote: > If the user didn't have to manually do anything, it should be rated > platinum. Agreed. appdb ratings are from the point of view of someone who simply uses their linux distro to install wine, and then tries to install a game. If no fiddling is required, and the game works perfectly, it's platinum even if under the hood the game has snuck in a native (and Microsoft-copyrighted) DLL. (DLLs not copyrighted by Microsoft are not generally a concern.) In parallel, people who care about making Wine run without any native DLLs should make sure there's a "purist" bug in wine's bugzilla describing what breaks if you force wine to use its own builtin DLL for the game. (And should then try to fix that bug. :-) - Dan

2 1

Re: [2/2] gdiplus: Implement GdipImageGetFrameCount and GdipImageSelectActiveFrame.
by Vincent Povirk 16 May '12

16 May '12

Er, you removed the FIXME, but GdipImageSelectActiveFrame is still a stub? You're not changing the image data.

2 1

Re: [PATCH 2/2] ieframe: Added GetExternal tests
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18421 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3402: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3377: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c0000005 at 0040AE8E === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2594: Test failed: expected GetOverridesKeyPath webbrowser.c:2599: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2600: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3019: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402FCA

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

2 1

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling
by Nikolay Sivov 16 May '12

16 May '12

On 5/15/2012 22:53, Daniel Jelinski wrote: > > > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + /* this sequence should NOT send WM_CONTEXTMENU */ > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); Please use defined names for wParam and a MAKELPARAM macro to make a coordinate dword. > + test_mouse(); Also this deserves a more descriptive name, something like test_rbutton().

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel