- wine-devel - winehq.org

Re: mstask/tests: Add missing call to the tested function.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18417 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task === W2KPROSP4 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WXPPROSP3 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K3R2SESP2 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WVISTAADM (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K8SE (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PRO (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000

1 0

Re: [PATCH] devenum: Do not fail with a IBindCtx (with tests)
by Dmitry Timoshkov 16 May '12

16 May '12

Detlef Riekenberg <wine.dev(a)web.de> wrote: > static HRESULT WINAPI DEVENUM_IMediaCatMoniker_BindToStorage(IMoniker *iface, IBindCtx *pbc, > IMoniker *pmkToLeft, REFIID riid, void **ppvObj) > { > + static IBindCtx *old_bc; > MediaCatMoniker *This = impl_from_IMoniker(iface); > > TRACE("(%p)->(%p, %p, %s, %p)\n", This, pbc, pmkToLeft, debugstr_guid(riid), ppvObj); > > *ppvObj = NULL; > > - if (pbc || pmkToLeft) > + if (pbc != old_bc) > + { > + FIXME("ignoring IBindCtx %p\n", pbc); > + old_bc = pbc; > + } This doesn't look sane. -- Dmitry.

1 0

wine/clang warnings
by Austin English 15 May '12

15 May '12

Howdy, I tried Wine with LLVM/Clang from svn recently, thought others may like some of the results. I've also ran the static analyzer. For reference, this is with: wine-1.5.4-61-g8327e6f, plus the following patch: diff --git a/include/windef.h b/include/windef.h index 9cf98e7..e95388a 100644 --- a/include/windef.h +++ b/include/windef.h @@ -53,7 +53,7 @@ extern "C" { #ifndef __stdcall # ifdef __i386__ # ifdef __GNUC__ -# ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ +# if defined (__APPLE__) || defined (__clang__) /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ # define __stdcall __attribute__((__stdcall__)) __attribute__((__force_align_arg_pointer__)) # else # define __stdcall __attribute__((__stdcall__)) see http://wiki.winehq.org/Clang for more info. Wine was compiled using: #!/bin/bash export CC="clang" export CXX="$CC" export CFLAGS="-g -O0 -std=gnu89 -Wno-conversion -Wno-invalid-source-encoding" ./configure -Wno-invalid-source-encoding, because clang does not like our encoding of strings in winex11/keyboard.c. There are 851 warnings of: clang -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/include/freetype2 -g -O0 -std=gnu89 -Wno-conversion -o keyboard.o keyboard.c keyboard.c:267:17: warning: illegal character encoding in string literal [-Winvalid-source-encoding] "`","1!","2\"","3<A3>","4$","5%","6^","7&","8*","9(","0)","-_","=+", The static analyzer found 2231 bugs (--disable-tests was used). http://www.sendspace.com/file/qsbv3k austin@aw21 ~ $ du -h scan-build-2012-05-15-2.tar.bz2 42M scan-build-2012-05-15-2.tar.bz2 austin@aw21 ~ $ sha1sum scan-build-2012-05-15-2.tar.bz2 442cf6faddb45515792d116717c992282496dfbe scan-build-2012-05-15-2.tar.bz2 Cheers, Austin

1 0

Re: comctl32: Fix message sequence when right-clicking a treeview
by Nikolay Sivov 15 May '12

15 May '12

On 5/15/2012 21:30, Daniel Jelinski wrote: > Patch dropped out of the pending list, resending. Please add a test for this fix.

2 2

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation (try2)
by Alexandre Julliard 15 May '12

15 May '12

Piotr Caban <piotr(a)codeweavers.com> writes: > This patch serie is based on Andrew Eikum's and Rein Klazes's work. > --- > dlls/user32/menu.c | 94 > ++++++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 87 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:11511: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:12297: Test failed: popup menu command: 17: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12297: Test failed: popup menu command: 18: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12297: Test failed: popup menu command: 19: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12297: Test failed: popup menu command: 21: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12297: Test failed: popup menu command: 22: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12315: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12315: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12315: Test failed: submenu of a popup menu command: 28: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12315: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12315: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12363: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12363: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12363: Test failed: submenu of a popup menu command: 28: the msg 0x0111 was expected, but got msg 0x0212 instead msg.c:12363: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0111 instead msg.c:12363: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 make[1]: *** [msg.ok] Error 19 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Forward AddAttachedSurface to the correct equivalent
by Stefan Dösinger 15 May '12

15 May '12

Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: > + hr = ddraw_surface3_AddAttachedSurface(&This- >IDirectDrawSurface3_iface, > + attachment_impl ? &attachment_impl->IDirectDrawSurface3_iface : NULL); It isn't immediately clear to me why Surface3 is correct instead of Surface7. Do you have tests or bug reports to back this up?

3 3

Re: [PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway
by Alexander E. Patrakov 15 May '12

15 May '12

Andrew Eikum wrote: > - > - TRACE("Mixed at least %d from all buffers\n", minlen); > - return minlen; Hi. You have removed the message that could say "Mixed at least 0 from all buffers" (as seen, e.g., for Armored Fist 3 and sometimes even for foobar2000). What was the reason for that "0" (or, rather, 1024, 1024, 1024, 0, 2048, 1024, ... sequence) seen in some games? Was it also fixed by your patch? (this mail is a question, not an objection) -- Alexander E. Patrakov

2 1

Re: [PATCH 1/4] dsound: Change mix_buffer to float instead of INT
by Alexander E. Patrakov 15 May '12

15 May '12

Andrew Eikum wrote: > +static LONG f_to_24(float value) > +{ > if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFF / 0x800000) > + return 0x7FFFFF00; > + return lrintf(value * 0x80000000U); > } ... > +static inline LONG f_to_32(float value) > +{ > + if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFFFF / 0x80000000U) /* this rounds to 1.f */ > + return 0x7FFFFFFF; > + return le32(lrintf(value * 0x80000000U)); > +} [sorry for a possible duplicate, the previous mail contained a typo] Minor nitpick: I'd say these functions are identical on little-endian systems if the least significant bits are discarded. Are you sure that we indeed want two functions here, and not, say, use f_to_32() in put24()? -- Alexander E. Patrakov

1 0

Wine Mono 0.0.4 Release - I'm serious now!
by Vincent Povirk 14 May '12

14 May '12

I have published version 0.0.4 of Wine Mono on Sourceforge. I fully intend to make this release a part of Wine. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.2: * With Wine 1.5.4 and Wine Mono 0.0.4, it's now possible to run mixed-mode assemblies. * The random hang that was introduced in Mono 2.11 is now fixed (0.0.2 contained a hacky work-around). * A replacement for XNA 4.0 based on MonoGame is now included, to be used if MS XNA 4.0 is not installed. * Updated Mono from 2.11.0 to 2.11.1, bringing in the changes listed here: http://mono.1490590.n4.nabble.com/Mono-2-11-1-is-out-td4575466.html * Changes from Hans Leidekker to make upgrading and removing the msi work better. * Added more registry keys to prevent native .NET from trying to install while Wine Mono is installed. * Various improvements to the build script. Some programs that worked with the official Mono for Windows package will fail with this one because gluezilla (Mono's web browser component) is missing. In all other respects I expect this to work as well as or better than the official Mono for Windows package, and if not I'd like to hear about it. If nothing new seems to be horribly wrong with this build other than the lack of gluezilla, I will try to make it an official part of Wine. It's not really clear where the bugs should be reported at the moment, but I think Wine bugzilla is appropriate.

1 0

XINPUT JOYSTICK PATCH
by Giovanni Ongaro 14 May '12

14 May '12

I have written a modification of the xinput1_3 dll that simulates xbox joystick with a logitech rumblepad 2 joystick,also provided is a way to disable dinput joysticks through an environment variable, it seems to work well,may it be of interest to the wine project?

2 1

Re: wmvcore: Add stub for WMCreateSyncReader
by Nikolay Sivov 14 May '12

14 May '12

On 5/14/2012 19:34, André Hentschel wrote: > Otherwise GTA San Andreas runs into it and crashes. This stub let's it work again. > a workaround is to disable wmvcore in winecfg... > --- > dlls/wmvcore/wmvcore.spec | 2 +- > dlls/wmvcore/wmvcore_main.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/dlls/wmvcore/wmvcore.spec b/dlls/wmvcore/wmvcore.spec > index 1c6cb1f..e0fa2e9 100644 > --- a/dlls/wmvcore/wmvcore.spec > +++ b/dlls/wmvcore/wmvcore.spec > @@ -11,7 +11,7 @@ > @ stub WMCreateProfileManager > @ stub WMCreateReader > @ stub WMCreateReaderPriv > -@ stub WMCreateSyncReader > +@ stdcall WMCreateSyncReader(ptr long ptr) > @ stub WMCreateWriter > @ stub WMCreateWriterFileSink > @ stub WMCreateWriterNetworkSink > diff --git a/dlls/wmvcore/wmvcore_main.c b/dlls/wmvcore/wmvcore_main.c > index 096328b..5fce972 100644 > --- a/dlls/wmvcore/wmvcore_main.c > +++ b/dlls/wmvcore/wmvcore_main.c > @@ -22,6 +22,7 @@ > > #include "windef.h" > #include "winbase.h" > +#include "objbase.h" > #include "wine/debug.h" > > WINE_DEFAULT_DEBUG_CHANNEL(wmvcore); > @@ -43,3 +44,10 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > return TRUE; > } > + > +HRESULT WINAPI WMCreateSyncReader(IUnknown *pcert, DWORD rights, > + IUnknown /* FIXME: IWMSyncReader */ **syncreader) > +{ > + FIXME("(%p, %x, %p): stub\n", pcert, rights, syncreader); > + return E_NOTIMPL; > +} You'll be probably requested to add a proper .idl for that with interface definition. Also it makes sense to init out parameter to 0, as a common practice for such creation methods/calls. >

1 0

Re: [1/2] gdiplus: Measure the passed in string without height clipping in order to compute correct Y offset. Take 3.
by Vincent Povirk 14 May '12

14 May '12

Looks good to me.

1 0

Re: Using an IDE on Wine?
by Michael Ost 14 May '12

14 May '12

On 5/13/12 10:00 AM, wine-devel-request(a)winehq.org wrote: > How many of you use an Integrated Development Environment (IDE) when > working on Wine? > > If you do, which one do you use and how, how useful is it and how hard > was it to set up? I use Qt Creator for Linux for our winelib application. Our app is a hybrid winelib + Qt/X11 app, so we get the extra Qt "goodies" with Qt Creator. But it does work for other project types too. Getting the integrated gdb debugger to work was a trick. The main thing is to set WINELOADERNOEXEC=1 in the environment and run /usr/bin/wine as the debuggee. We also built and copied in a debug version of /usr/bin/wine to keep Qt Creator from complaining when a debug session got underway. The last "gotcha" was that we had to hack out alpha channel support for cursors when running under GDB. (IIRC) the DIB engine uses segfaults in normal operation which confuses GDB. I can send along that patch if you are interested. Of course, if you are trying to debug a straight windows application then all of this is irrelevant! But if you are doing winelib, then these tricks can help. -- Michael Ost

1 0

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.
by Vincent Povirk 14 May '12

14 May '12

If the string wraps, and you don't give the width to GdipMeasureString, won't it return a too small height? On Mon, May 14, 2012 at 9:11 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > GdipMeasureString() clips the string extents to passed rectangle width and > height, but that leads to wrong offsety calculation if the string doesn't > fit into that rectangle. > --- > dlls/gdiplus/graphics.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 38335a8..1c9780d 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -5162,14 +5162,18 @@ GpStatus WINGDIPAPI GdipDrawString(GpGraphics *graphics, GDIPCONST WCHAR *string > /* Should be no need to explicitly test for StringAlignmentNear as > * that is default behavior if no alignment is passed. */ > if(format->vertalign != StringAlignmentNear){ > + static const RectF empty_rect = { 0.0, 0.0, 0.0, 0.0 }; > RectF bounds; > - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &empty_rect, format, &bounds, 0, 0); > + > + TRACE("bounds %s\n", debugstr_rectf(&bounds)); > > if(format->vertalign == StringAlignmentCenter) > offsety = (rect->Height - bounds.Height) / 2; > else if(format->vertalign == StringAlignmentFar) > offsety = (rect->Height - bounds.Height); > } > + TRACE("vertical align %d, offsety %f\n", format->vertalign, offsety); > } > > save_state = SaveDC(hdc); > -- > 1.7.10.1 > > >

2 3

Re: [PATCH 1/5] d3dcompiler: Make SlWriteBytecode return the shader size.
by Stefan Dösinger 14 May '12

14 May '12

Am Montag, 14. Mai 2012, 17:24:01 schrieb Matteo Bruni: > - CopyMemory(pos, messages, strlen(messages) + 1); > + memcpy(pos, messages, strlen(messages) + 1); > ... > - if (shader == NULL) > + if (!shader) This looks unrelated. The changes are OK, but should be in another patch.

1 0

Re: [1/3] user32/tests: Add GetUserObjectInformation tests
by Alexandre Julliard 14 May '12

14 May '12

Owen Rudge <orudge(a)codeweavers.com> writes: > There appears to be a bug in the GetUserObjectInformationA function on > Windows that results in an incorrect buffer length being returned when > the buffer size provided by the caller is insufficient. The 'A' > function returns the Unicode length instead of the ANSI length. These > patches modify Wine's behaviour to provide that incorrect > behaviour. They also fix an issue whereby the wrong error code is set > when the buffer is too short. Using the number of Unicode chars multiplied by 2 is a reasonable upper bound on the A string size, and it's used in a number of places. This can't really be considered a Windows bug. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.
by Vincent Povirk 14 May '12

14 May '12

> - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0); You probably shouldn't use the same GpRect* for both parameters there.

2 3

Re: msxml3: avoid a dangling else (LLVM/Clang)
by Michael Stefaniuc 14 May '12

14 May '12

Hello Austin, On 05/14/2012 08:01 AM, Austin English wrote: > diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c > index 6805c75..14fd01b 100644 > --- a/dlls/msxml3/domdoc.c > +++ b/dlls/msxml3/domdoc.c > @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML( > > /* skip leading spaces if needed */ > if (This->properties->version == MSXML_DEFAULT || This->properties->version == MSXML26) > + { > while (*ptr) > if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the "else" on a separate line. > + } > > xmldoc = doparse(This, (char*)ptr, strlenW(ptr)*sizeof(WCHAR), XML_CHAR_ENCODING_UTF16LE); > if ( !xmldoc ) bye michael

2 2

Re: wininet: Fixed typo in tests and accompanying implementation
by Marvin 14 May '12

14 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18349 Your paranoid android. === W7PROX64 (64 bit http) === http.c:2853: Test failed: HttpSendRequest failed: 12002

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Jacek Caban 14 May '12

14 May '12

Hi Austin, On 05/14/12 08:19, Austin English wrote: > clang -c -I. -I. -I../../../include -I../../../include > -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT > -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits > -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith > -I/usr/include/freetype2 -g -O0 -std=gnu89 -o http.o http.c > http.c:212:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^ ~~~~~~~~~~~~~~~~~~~~~~ > http.c:212:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^~~~~~~~~~~~~~~~~~~~~~~~ > | > http.c:218:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > ^ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > http.c:218:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Thanks for the patch. The problem found by those warnings was more serious as we were tested a wrong thing, causing the implementation to be wrong. That said, we need to fix tests and implementation as well. I've sent a patch. Thanks, Jacek

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Marvin 14 May '12

14 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18347 Your paranoid android. === WXPPROSP3 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K3R2SESP2 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === WVISTAADM (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K8SE (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PRO (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154)

1 0

Re: [2/2] msxml3: Support iso-8859-x encodings in writer
by Marvin 14 May '12

14 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18346 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-3: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-4: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-5: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-7: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-9: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-13: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> === WXPPROSP3 (32 bit saxreader) === saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-3: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?>

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin 13 May '12

13 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18345 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin 13 May '12

13 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18345 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Using an IDE on Wine?
by Max TenEyck Woodbury 13 May '12

13 May '12

How many of you use an Integrated Development Environment (IDE) when working on Wine? If you do, which one do you use and how, how useful is it and how hard was it to set up? Max

4 3

re: Using an IDE on Wine?
by Dan Kegel 13 May '12

13 May '12

I suspect most people don't use IDEs with wine. Someone recently posted how to use eclipse during debugging, though: http://www.winehq.org/pipermail/wine-devel/2012-April/095162.html

1 0

Re: d3dx9_36: Equality between floats is too strict.
by Marvin 12 May '12

12 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18337 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W2K3R2SESP2 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === WVISTAADM (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W2K8SE (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PRO (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PROX64 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === TEST64_W7SP1 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PROX64 (64 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === TEST64_W7SP1 (64 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0

1 0

Re: [2/8] d3dx9: Check the size of a DDS file in D3DXGetImageInfoFromFileInMemory.
by Stefan Dösinger 12 May '12

12 May '12

Am Mittwoch, 9. Mai 2012, 23:32:05 schrieb Józef Kucia: > + *pitch = width * format_desc->bytes_per_pixel; > + *size = *pitch * height; Usually surface pitches are either 4 or 8 byte aligned(depending on the API and pool). I recommend to write some tests for this. The most likely problematic formats are D3DFMT_P8, any 16 bit format like R5G6B5 and 24 bit R8G8B8. Maybe you're supposed to honor the pitch_or_linear_size member of the DDSURFACEDESC.

3 5

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation
by Alexandre Julliard 12 May '12

12 May '12

Piotr Caban <piotr(a)codeweavers.com> writes: > + __TRY > + { > + mbi.cbSize = pmbi->cbSize; > + if (mbi.cbSize == sizeof(MENUBARINFO)) > + memcpy(pmbi, &mbi, sizeof(MENUBARINFO)); > + } > + __EXCEPT_PAGE_FAULT > + { > + SetLastError(ERROR_NOACCESS); > + return FALSE; > + } > + __ENDTRY Do you really have an app that requires an exception handler? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] d3dx9: Forward D3DXSaveSurfaceToFileA to D3DXSaveSurfaceToFileW.
by Józef Kucia 11 May '12

11 May '12

On Wed, May 2, 2012 at 2:55 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > --- > dlls/d3dx9_36/surface.c | 24 ++++++++++++++++++++---- > 1 files changed, 20 insertions(+), 4 deletions(-) > > diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c > index 44d4e06..70627fd 100644 > --- a/dlls/d3dx9_36/surface.c > +++ b/dlls/d3dx9_36/surface.c > @@ -1364,11 +1364,27 @@ HRESULT WINAPI D3DXLoadSurfaceFromSurface(LPDIRECT3DSURFACE9 pDestSurface, > } > > > -HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR pDestFile, D3DXIMAGE_FILEFORMAT DestFormat, > - LPDIRECT3DSURFACE9 pSrcSurface, const PALETTEENTRY* pSrcPalette, const RECT* pSrcRect) > +HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, > + IDirect3DSurface9 *src_surface, const PALETTEENTRY *src_palette, const RECT *src_rect) > { > - FIXME("(%p, %d, %p, %p, %p): stub\n", pDestFile, DestFormat, pSrcSurface, pSrcPalette, pSrcRect); > - return D3DERR_INVALIDCALL; > + int len; > + LPWSTR filename; > + HRESULT hr; > + > + TRACE("(%s, %d, %p, %p, %p): relay\n", > + wine_dbgstr_a(dst_filename), file_format, src_surface, src_palette, src_rect); > + > + if (!dst_filename) return D3DERR_INVALIDCALL; > + > + len = MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, NULL, 0); > + filename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); > + if (!filename) return E_OUTOFMEMORY; > + MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, filename, len); > + > + hr = D3DXSaveSurfaceToFileW(filename, file_format, src_surface, src_palette, src_rect); > + > + HeapFree(GetProcessHeap(), 0, filename); > + return hr; > } > > HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR pDestFile, D3DXIMAGE_FILEFORMAT DestFormat, > -- > 1.7.8.6 > This mail is the lost mail from 2nd May. Please ignore it.

1 0

Re: [PATCH 1/2 resend] mshtml.idl: Added DispHTMLHistory declaration
by Jacek Caban 11 May '12

11 May '12

There must have been some problem with mail servers. These mails were sent last week and should replace already committed patches. The fix from try 2 (fixing tests on old IEs) is also already committed. Cheers, Jacek

1 0

Re: [1/8] d3dx9: Add missing pixel formats.
by Matteo Bruni 11 May '12

11 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c > index 4dbf44c..ad8a6ea 100644 > --- a/dlls/d3dx9_36/util.c > +++ b/dlls/d3dx9_36/util.c > @@ -62,6 +62,7 @@ static const PixelFormatDesc formats[] = > {D3DFMT_G16R16, {0, 16, 16, 0}, { 0, 0, 16, 0}, 4, 1, 1, 4, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_A8, {8, 0, 0, 0}, { 0, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_A8L8, {8, 8, 0, 0}, { 8, 0, 0, 0}, 2, 1, 1, 2, FORMAT_ARGB, la_from_rgba, la_to_rgba}, > + {D3DFMT_A4L4, {4, 4, 0, 0}, { 4, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, la_from_rgba, la_to_rgba}, > {D3DFMT_DXT1, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 8, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_DXT2, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_DXT3, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL }, I guess it would make sense to add all the new pixel formats to the table, assuming it doesn't break the tests or other stuff.

3 2

Re: [PATCH 3/4] dmusic: COM cleanup of IReferenceClock.
by Nikolay Sivov 11 May '12

11 May '12

On 5/11/2012 09:19, Christian Costa wrote: > > diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h > index 73a05d4..96334c9 100644 > --- a/dlls/dmusic/dmusic_private.h > +++ b/dlls/dmusic/dmusic_private.h > @@ -167,13 +167,14 @@ extern HRESULT WINAPI DMUSIC_CreateDMSynthPort(REFIID riid, LPVOID *ppobj, LPUNK > * IReferenceClockImpl implementation structure > */ > struct IReferenceClockImpl { > - /* IUnknown fields */ > - const IReferenceClockVtbl *lpVtbl; > - LONG ref; > + /* IUnknown fields */ > + IReferenceClock IReferenceClock_iface; > + const IReferenceClockVtbl *lpVtbl; You forgot to remove that, right? > + LONG ref; > > >

2 1

Re: Vincent Povirk : windowscodecs: Add wrapper functions for IWICPalette methods.
by Charles Davis 11 May '12

11 May '12

On May 10, 2012, at 1:17 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 2fc7cdc93f6dc8ed67498b74193423c44e5bb770 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2fc7cdc93f6dc8ed67498b741… > > Author: Vincent Povirk <vincent(a)codeweavers.com> > Date: Tue May 8 10:49:22 2012 -0500 > > windowscodecs: Add wrapper functions for IWICPalette methods. I have to say, these patches all seem really mechanical. Correct me if I'm wrong, but I think MIDL has an option to generate the proxy wrappers automatically. Even if it doesn't, I'm sure this would be a good feature to add to widl (if we don't already have it) so we don't have to laboriously write and maintain each and every one of the proxy wrappers. Chip

2 1

Re: [PATCH 2/2 try 2] mshtml: Added IHTMLWindow2::get_history implementation
by Marvin 10 May '12

10 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18319 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

GSoC Joystick Configuration Tools
by Lucas Zawacki 10 May '12

10 May '12

Hello all, I'll use this thread to post information and ask questions regarding my GSoC project. First there's a wiki which aggregates some information and lists tasks I'm working on: http://lfzawacki.heroku.com/wine/published/HomePage Then there's a github repo: https://github.com/lfzawacki/wine-joysticks In the repository you'll find the different tools I'll be implementing. They can be easily built and tested, even before they make it into wine. At the moment there's an intial version of the command line joystick tester. This tool is useful for listing connected joysticks, testing if they work correctly in wine, testing axis remapping, watching for dinput trace messages, etc... It's also the basis for the joystick testing GUI. I'll start cleaning up, splitting this code and commiting it to wine next week. For now I'll make a similar tool to this one that tests force feedback. I'll try to make it in the style of the Linux fftest program, but using the dinput interfaces so that a user can test the differences. Cheers, Lucas

2 2

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.
by Józef Kucia 10 May '12

10 May '12

On Wed, May 9, 2012 at 11:32 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index ab56593..3d5a50f 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -917,6 +917,20 @@ static void test_D3DXCreateVolumeTexture(IDirect3DDevice9 *device) > } > } > > +static void test_D3DXCreateTextureFromFileInMemory(IDirect3DDevice9 *device) > +{ > + HRESULT hr; > + IDirect3DTexture9 *texture; > + > + hr = D3DXCreateTextureFromFileInMemory(device, dds_16bit, sizeof(dds_16bit), &texture); > + ok(hr == D3D_OK, "D3DCreateTextureFromFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); > + > + hr = D3DXCreateTextureFromFileInMemory(device, dds_24bit, sizeof(dds_24bit), &texture); > + ok(hr == D3D_OK, "D3DXCreateTextureFromFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); > +} > + I noticed that I put more and more texture functions tests in tests/surface.c, because these tests needs the dds files which are in tests/surface.c. I wonder if it would be better to copy needed dds files to tests/texture.c and move texture function tests to their proper place. I think the dds files could be used to tests other texture functions, e.g. D3DXCreateTextureFromFileInMemoryEx doesn't seem to have any tests.

2 1

Re: [1/5] gdiplus: Retrive LOGFONT from a GpFont using GdipGetLogFontW instead of accessing it directly.
by Alexandre Julliard 10 May '12

10 May '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -4926,12 +4925,15 @@ GpStatus WINGDIPAPI GdipMeasureCharacterRanges(GpGraphics* graphics, > TRACE("(%p %s %d %p %s %p %d %p)\n", graphics, debugstr_w(string), > length, font, debugstr_rectf(layoutRect), stringFormat, regionCount, regions); > > - if (!(graphics && string && font && layoutRect && stringFormat && regions)) > + if (!graphics || !string || !font || !layoutRect || !stringFormat || !regions) > return InvalidParameter; Please avoid mixing that sort of gratuitous change with the real changes. > + stat = GdipGetLogFontW((GpFont *)font, graphics, &lfw); > + if (stat != Ok) return stat; I'm not sure it's an improvement, since you need to add these ugly casts. You should find a way that doesn't require that. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions (try 4)
by Juan Lang 10 May '12

10 May '12

Hi Alex, first, thanks for taking the time to respond to feedback. Showing responsiveness helps a great deal. Next, on your patch: I'm trying to help you get this committed, so this is meant to be constructive feedback. +static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR src, + INT srclen, LPSTR dst, INT dstlen, + LPCSTR defchar, BOOL* used, + const char* test_description, + DWORD expected_error) +{ + SetLastError(ERROR_SUCCESS); + WideCharToMultiByte(page, flags, src, srclen, dst, dstlen, defchar, used); + ok(GetLastError() == expected_error, + "codepage %i, %s, expected error %i got error %i\n", page, + test_description, expected_error, GetLastError()); +} + +static void test_MultiByteToWideChar_error(UINT page, DWORD flags, LPCSTR src, + INT srclen, LPWSTR dst, INT dstlen, + const char* test_description, + DWORD expected_error) +{ + SetLastError(ERROR_SUCCESS); + MultiByteToWideChar(page, flags, src, srclen, dst, dstlen); + ok(GetLastError() == expected_error, + "codepage %i, %s, expected error %i got error %i\n", page, + test_description, expected_error, GetLastError()); +} These helpers don't really gain you anything here, there's really not enough code to be worth using helpers. Please just copy/paste the changes everyplace you're currently using them. Also, a common convention we use is to set last error to 0xdeadbeef prior to a test we expect to set last error on failure. Thanks, --Juan

2 1

Re: [PATCH] winmm: Don't call MMDevAPI during process exit
by Alexandre Julliard 10 May '12

10 May '12

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > This fixes bug 30631, introduced by > 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1. > > In addition to safely exiting on process exit, we do much more > thorough cleanup on process detach. There shouldn't be any reason to do cleanup on process exit (and you can't really do anything reliably at that point anyway). -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.
by Matteo Bruni 10 May '12

10 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > --- > +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void *src_data, UINT srd_data_size, > + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const D3DXIMAGE_INFO *src_info) DECLSPEC_HIDDEN; ... > +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void *src_data, UINT srd_data_size, > + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const D3DXIMAGE_INFO *src_info) I guess that was meant to be called "src_data_size". More to the point, anyway, you're not using that value right now, you should probably add a check against it or remove the parameter altogether.

2 1

Re: [4/8] d3dx9: Implement D3DXCreateCubeTextureFromFileInMemoryEx.
by Matteo Bruni 10 May '12

10 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > + mip_levels = min(src_info->MipLevels, IDirect3DCubeTexture9_GetLevelCount(cube_texture)); > + for (face = D3DCUBEMAP_FACE_POSITIVE_X; face <= D3DCUBEMAP_FACE_NEGATIVE_Z; face++) > + { > + size = src_info->Width; > + for (mip_level = 0; mip_level < mip_levels; mip_level++) > + { > + hr = calculate_dds_surface_size(src_info, size, size, &src_pitch, &mip_level_size); > + if (FAILED(hr)) return hr; > + > + SetRect(&src_rect, 0, 0, size, size); > + > + IDirect3DCubeTexture9_GetCubeMapSurface(cube_texture, face, mip_level, &surface); > + hr = D3DXLoadSurfaceFromMemory(surface, palette, NULL, pixels, src_info->Format, src_pitch, > + NULL, &src_rect, filter, color_key); > + IDirect3DSurface9_Release(surface); > + if (FAILED(hr)) return hr; > + > + pixels += mip_level_size; > + size = max(1, size / 2); > + } > + > + /* if texture has fewer mip levels than DDS file, skip excessive mip levels */ > + while (mip_level < src_info->MipLevels) > + { > + calculate_dds_surface_size(src_info, size, size, &src_pitch, &mip_level_size); > + pixels += mip_level_size; > + size = max(1, size / 2); > + mip_level++; > + } > + } Really a nitpick, you could merge the "while" into the "for" loop above. > + if ((caps.Caps2 & D3DCAPS2_DYNAMICTEXTURES) && (pool != D3DPOOL_DEFAULT) && (usage != D3DUSAGE_DYNAMIC)) > + { > + hr = D3DXCreateCubeTexture(device, size, mip_levels, usage, format, pool, &tex); > + buftex = NULL; > + } > + else > + { > + hr = D3DXCreateCubeTexture(device, size, mip_levels, usage, format, D3DPOOL_SYSTEMMEM, &buftex); > + tex = buftex; > + } The "if" condition doesn't look correct to me, since e.g. you don't need a temporary texture if pool == D3DPOOL_DEFAULT and usage == D3DUSAGE_DYNAMIC.

2 1

Re: [2/8] d3dx9: Check the size of a DDS file in D3DXGetImageInfoFromFileInMemory.
by Matteo Bruni 10 May '12

10 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > +static HRESULT get_image_info_from_dds(const void *buffer, UINT length, D3DXIMAGE_INFO *info) > { > + UINT i; > + UINT faces = 0; ... > + /* calculate the expected length */ > + width = info->Width; > + height = info->Height; > + for (i = 0; i < info->MipLevels; i++) > + { > + UINT pitch, size = 0; > + calculate_dds_surface_size(info, width, height, &pitch, &size); > + expected_length += size; > + width = max(1, width / 2); > + height = max(1, width / 2); > + } > + > + if (length < expected_length) > + return D3DXERR_INVALIDDATA; It looks like you're not actually using the faces variable.

2 1

Re: [PATCH] dmusic: Variable spelling fix.
by Andrew Eikum 10 May '12

10 May '12

On Thu, May 10, 2012 at 07:52:58AM +0200, Christian Costa wrote: > static HRESULT read_from_stream(IStream *stream, void *data, ULONG size) > { > - ULONG readed; > + ULONG read; > HRESULT hr; > > - hr = IStream_Read(stream, data, size, &readed); > + hr = IStream_Read(stream, data, size, &read); > if(FAILED(hr)){ I called it that to prevent shadowing read(3). It probably doesn't matter since we almost never use that call in Wine, but that was the rationale. Andrew

2 1

Re: [PATCH 1/2] comctl32: LVM_SETITEMTEXT is not supported on LVS_OWNERDATA
by Nikolay Sivov 10 May '12

10 May '12

On 5/10/2012 12:01, Piotr Caban wrote: > > Thanks to this patch we no longer ask about the item text inside this > notification before returning error. > --- > dlls/comctl32/listview.c | 1 + > dlls/comctl32/tests/listview.c | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletions(-) > > case LVM_SETITEMTEXTA: > case LVM_SETITEMTEXTW: > + if (infoPtr->dwStyle& LVS_OWNERDATA) return FALSE; > return LISTVIEW_SetItemTextT(infoPtr, (INT)wParam, (LPLVITEMW)lParam, > uMsg == LVM_SETITEMTEXTW); Please place this inside LISTVIEW_SetItemTextT().

1 0

[PATCH 0/6] Extended file stat system call
by David Howells 10 May '12

10 May '12

Implement a pair of new system calls to provide extended and further extensible stat functions. The second of the associated patches is the main patch that provides these new system calls: ssize_t ret = xstat(int dfd, const char *filename, unsigned atflag, unsigned mask, struct xstat *buffer); ssize_t ret = fxstat(int fd, unsigned atflag, unsigned mask, struct xstat *buffer); which are more fully documented in the first patch's description. These new stat functions provide a number of useful features, in summary: (1) More information: creation time, inode generation number, data version number, flags/attributes. A subset of these is available through a number of filesystems (such as CIFS, NFS, AFS, Ext4 and BTRFS). (2) Lightweight stat: Ask for just those details of interest, and allow a netfs (such as NFS) to approximate anything not of interest, possibly without going to the server. (3) Heavyweight stat: Force a netfs to go to the server, even if it thinks its cached attributes are up to date. (4) Allow the filesystem to indicate what it can/cannot provide: A filesystem can now say it doesn't support a standard stat feature if that isn't available. (5) Make the fields a consistent size on all arches, and make them large. (6) Can be extended by using more request flags and appending further data after the end of the standard return data. Note that no lstat() equivalent is required as that can be implemented through xstat() with atflag == 0. ======= PATCHES ======= Patch 1 defines the xstat() and fxstat() system calls. Patches 2-6 implement extended stat facilities for Ext4, AFS, NFS and CIFS, and make eCryptFS go to the lower filesystem for such details. ============== CONSIDERATIONS ============== Should fxstat() be implemented as xstat() with a NULL filename, using dfd as fd? Should the default for a network fs be to do an unconditional (heavyweight) stat with a flag to suppress going to the server to update the locally held attributes and flushing pending writebacks? Should things like the Windows Archive, Hidden and System bits be handled through IOC flags, perhaps expanded to 64-bits? Are these things useful to userspace other than Samba and userspace NFS servers? Is it useful to pass the volume ID out? Or is statfs() sufficient for this? Should I add a sixth argument to xstat(), mark it reserved and require that must be supplied as 0 to hedge against future use? Is there anything else I can usefully add at the moment? ========== TO BE DONE ========== Autofs, ntfs, btrfs, ... I should perhaps use u8/u32/u64 rather than uint8/32/64_t. Handle remote filesystems being offline and indicate this with XSTAT_INFO_OFFLINE. ======= TESTING ======= There's a test program attached to the description for the main patch. It can be run as follows: [root@andromeda tmp]# ./xstat -R /mnt/foo xstat(/mnt/foo) = 0 0000: 000081a40000ffef 0000000000000001 0000020000000000 0000100000080000 0020: 0000000000000000 0000000600000008 000000004f88499a 0000000136fd9208 0040: 000000004f88499a 0000000136fd9208 000000004f8849b9 0000000106daf187 0060: 000000004f8849b9 0000000106daf187 000000000000000c 000000000000000f 0080: 0000000000000008 00000000484ebbef 0000000000000025 5949ebd4711efd82 00a0: d3250b5c15d5e380 0000000000000000 0000000000000000 0000000000000000 00c0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 00e0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 results=ffef Size: 15 Blocks: 8 IO Block: 4096 regular file Device: 08:06 Inode: 12 Links: 1 Access: (0644/-rw-r--r--) Uid: 0 Gid: 0 Access: 2012-04-13 16:43:22.922587656+0100 Modify: 2012-04-13 16:43:53.115011975+0100 Change: 2012-04-13 16:43:53.115011975+0100 Create: 2012-04-13 16:43:22.922587656+0100 Inode version: 484ebbefh Data version: 25h Inode flags: 00080000 (-------- ----e--- -------- --------) Information: 00000200 (-------- -------- ------a- --------) Volume ID: 82fd1e71d4eb4959-80e3d5155c0b25d3 David --- David Howells (6): xstat: eCryptFS: Return extended attributes xstat: CIFS: Return extended attributes xstat: NFS: Return extended attributes xstat: AFS: Return extended attributes xstat: Ext4: Return extended attributes xstat: Add a pair of system calls to make extended file stats available arch/x86/syscalls/syscall_32.tbl | 2 arch/x86/syscalls/syscall_64.tbl | 2 fs/afs/inode.c | 29 ++- fs/afs/super.c | 7 + fs/cifs/cifsfs.h | 4 fs/cifs/cifsglob.h | 16 +- fs/cifs/dir.c | 2 fs/cifs/inode.c | 120 +++++++++++-- fs/ecryptfs/inode.c | 14 +- fs/ext4/ext4.h | 2 fs/ext4/file.c | 2 fs/ext4/inode.c | 32 +++ fs/ext4/namei.c | 2 fs/ext4/super.c | 1 fs/ext4/symlink.c | 2 fs/nfs/inode.c | 49 ++++- fs/nfs/super.c | 1 fs/stat.c | 350 +++++++++++++++++++++++++++++++++++--- include/linux/fcntl.h | 1 include/linux/fs.h | 4 include/linux/stat.h | 126 +++++++++++++- include/linux/syscalls.h | 7 + 22 files changed, 694 insertions(+), 81 deletions(-)

10 65

Re: [7/8] d3dx9/tests: Add tests for compressed pixel formats support in D3DXLoadSurface functions.
by Stefan Dösinger 10 May '12

10 May '12

Am Mittwoch, 9. Mai 2012, 23:32:10 schrieb Józef Kucia: > +#define check_pixel_3bpp(lockrect, x, y, color) \ > +ok(((BYTE*)(lockrect).pBits)[3 * (x) + (y) * (lockrect).Pitch + 0] == > ... Inline functions are generally prefered over macros where possible. I think it is possible to pass a different line number to ok() to make the messages more useful when they are called from a helper function, but I don't know how off the top of my head. If you have to use a macro, please use capital letters.

2 1

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions
by Nikolay Sivov 10 May '12

10 May '12

On 5/10/2012 00:52, Alex Henrie wrote: > This patch was a lot harder to figure out than I thought it was going to be. > > The MSDN documentation of most of these behaviors can be found at > http://msdn.microsoft.com/en-us/library/windows/desktop/dd319072(v=vs.85).a… Does any application depend on that? > > --- > dlls/kernel32/locale.c | 38 ++++++++++++++--- > dlls/kernel32/tests/locale.c | 94 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 126 insertions(+), 6 deletions(-) This is a wrong file to place tests into. > > diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c > index 3216ef9..9cbb124 100644 > --- a/dlls/kernel32/tests/locale.c > +++ b/dlls/kernel32/tests/locale.c > @@ -3137,6 +3137,99 @@ static void test_IdnToUnicode(void) > } > } > > +static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR src, > + INT srclen, LPSTR dst, INT dstlen, > + LPCSTR defchar, BOOL* used, > + const char* test_description, > + DWORD expected_error) > +{ > + SetLastError(ERROR_SUCCESS); > + WideCharToMultiByte(page, flags, src, srclen, dst, dstlen, defchar, used); > + ok(GetLastError() == expected_error, > + "codepage %i, %s, expected error %i got error %i\n", page, > + test_description, expected_error, GetLastError()); > +} > + > +static void test_MultiByteToWideChar_error(UINT page, DWORD flags, LPCSTR src, > + INT srclen, LPWSTR dst, INT dstlen, > + const char* test_description, > + DWORD expected_error) > +{ > + SetLastError(ERROR_SUCCESS); > + MultiByteToWideChar(page, flags, src, srclen, dst, dstlen); > + ok(GetLastError() == expected_error, > + "codepage %i, %s, expected error %i got error %i\n", page, > + test_description, expected_error, GetLastError()); > +} > + Looks ugly enough, it's better to place some test data in table and loop through it, if you really want to test that.

2 3

Re: [PATCH 2/3] dmsynth: Add some clock tests.
by Marvin 10 May '12

10 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18298 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

kernel32: Add UTF-7 support
by Alex Henrie 09 May '12

09 May '12

Hi all, Could I get some feedback on http://source.winehq.org/patches/data/85898 ? It was marked "Rejected" a week ago without explanation. Most of the code was authored by Katayama Hirofumi, whose patches have been accepted into Wine before. He gave permission to use his code under the LGPL at http://bugs.winehq.org/show_bug.cgi?id=27388 What more needs to be done before this patch can be accepted? -Alex

3 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel