- wine-devel - winehq.org

Re: [PATCH 3/4] ws2_32/tests: Test for AcceptEx IOCP behavior for a duplicated handle.
by Marvin 01 May '12

01 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18133 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W2K8SE (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PRO (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PROX64 (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PROX64 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120

1 0

Patches 85862 & 85862
by Christian Costa 30 Apr '12

30 Apr '12

What's wrong with these patches : - http://source.winehq.org/patches/data/85862 - http://source.winehq.org/patches/data/85862 There are marked as pending but can't see anything wrong. Maybe I'm missing something. Christian

1 0

Re: [1/3] d3dx9: Define DDS structures. (try 3)
by Stefan Dösinger 30 Apr '12

30 Apr '12

The patches look good to me. Am Sonntag, 29. April 2012, 21:43:08 schrieb Józef Kucia: > This patch series implements the DDS support for D3DXGetImageInfo functions. > > Try 2: Define pitch as LONG. > Try 3: Revert it back to DWORD. > --- > dlls/d3dx9_36/surface.c | 66 > ++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 65 > insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c > index 567282c..3319927 100644 > --- a/dlls/d3dx9_36/surface.c > +++ b/dlls/d3dx9_36/surface.c > @@ -28,9 +28,73 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3dx); > > > /* Wine-specific WIC GUIDs */ > - > DEFINE_GUID(GUID_WineContainerFormatTga, > 0x0c44fda1,0xa5c5,0x4298,0x96,0x85,0x47,0x3f,0xc1,0x7c,0xd3,0x22); > > +/* dds_header.flags */ > +#define DDS_CAPS 0x1 > +#define DDS_HEIGHT 0x2 > +#define DDS_WIDTH 0x2 > +#define DDS_PITCH 0x8 > +#define DDS_PIXELFORMAT 0x1000 > +#define DDS_MIPMAPCOUNT 0x20000 > +#define DDS_LINEARSIZE 0x80000 > +#define DDS_DEPTH 0x800000 > + > +/* dds_header.caps */ > +#define DDS_CAPS_COMPLEX 0x8 > +#define DDS_CAPS_TEXTURE 0x1000 > +#define DDS_CAPS_MIPMAP 0x400000 > + > +/* dds_header.caps2 */ > +#define DDS_CAPS2_CUBEMAP 0x200 > +#define DDS_CAPS2_CUBEMAP_POSITIVEX 0x400 > +#define DDS_CAPS2_CUBEMAP_NEGATIVEX 0x800 > +#define DDS_CAPS2_CUBEMAP_POSITIVEY 0x1000 > +#define DDS_CAPS2_CUBEMAP_NEGATIVEY 0x2000 > +#define DDS_CAPS2_CUBEMAP_POSITIVEZ 0x4000 > +#define DDS_CAPS2_CUBEMAP_NEGATIVEZ 0x8000 > +#define DDS_CAPS2_VOLUME 0x200000 > + > +/* dds_pixel_format.flags */ > +#define DDS_PF_ALPHA 0x1 > +#define DDS_PF_ALPHA_ONLY 0x2 > +#define DDS_PF_FOURCC 0x4 > +#define DDS_PF_RGB 0x40 > +#define DDS_PF_YUV 0x200 > +#define DDS_PF_LUMINANCE 0x20000 > + > +struct dds_pixel_format > +{ > + DWORD size; > + DWORD flags; > + DWORD fourcc; > + DWORD bpp; > + DWORD rmask; > + DWORD gmask; > + DWORD bmask; > + DWORD amask; > +}; > + > +struct dds_header > +{ > + DWORD signature; > + DWORD size; > + DWORD flags; > + DWORD height; > + DWORD width; > + DWORD pitch_or_linear_size; > + DWORD depth; > + DWORD miplevels; > + DWORD reserved[11]; > + struct dds_pixel_format pixel_format; > + DWORD caps; > + DWORD caps2; > + DWORD caps3; > + DWORD caps4; > + DWORD reserved2; > +}; > + > + > /************************************************************ > * D3DXGetImageInfoFromFileInMemory > *

1 0

Re: wined3d: Fix build with MSVC (try 2).
by Stefan Dösinger 30 Apr '12

30 Apr '12

Am Samstag, 28. April 2012, 10:16:13 schrieb Thomas Faber: > Apparently NAN and INFINITE are C99 as well (I should really get a > version of the old standard instead of mostly reading C99 :|). > > How about a simple const variable that will trick MSVC, while not > changing semantics. How about a function in libs/port or a macro in one of its headers? I believe the NAN/INFINITE issue is not specific to wined3d. With the const variable, msvc compiles the code, but still produces a warning.

2 2

Re: [1/2] gdi32: GetGlyphOutline should fail for a bitmap font.
by Huw Davies 30 Apr '12

30 Apr '12

On Sat, Apr 28, 2012 at 05:52:13PM +0900, Dmitry Timoshkov wrote: > --- > dlls/gdi32/freetype.c | 6 ++++++ > dlls/gdi32/tests/font.c | 17 ++++++++++++----- > 2 files changed, 18 insertions(+), 5 deletions(-) This will break the display of bitmap fonts in winex11.drv . Do you have an app that depends on this? Huw.

2 1

Wine developer example sessions?
by Dan Kegel 27 Apr '12

27 Apr '12

I'm bringing a new intern up to speed, and while I was showing him how to diagnose one particular wine bug, I recorded the session on a web page, http://kegel.com/wine/bug30486.html It occurred to me that recorded sessions like that might be useful to other beginners (above and beyond the more structured wine developer doc), so I created http://wiki.winehq.org/DeveloperExamples and linked to it from there. Does that seem useful, and are there other tutorials that could be linked to?

2 2

Re: user32/tests: Update DlgDirList tests
by Bruno Jesus 27 Apr '12

27 Apr '12

On Sat, Apr 14, 2012 at 21:57, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 Is there anything else I could provide in helping to get this patch accepted? http://source.winehq.org/patches/data/85434 Regards, Bruno

1 0

Re: [1/3] d3dx9: Define DDS structures.
by Stefan Dösinger 27 Apr '12

27 Apr '12

Am Donnerstag, 26. April 2012, 11:47:51 schrieb Józef Kucia: > + DWORD pitch_or_linear_size; Are you aware that lPitch is a (signed) LONG in the original DDSURFACEDESC structure? Honestly I have no idea why, and I have never seen an app that passes a negative pitch, but it might lead to obscure bugs if it is not checked.

3 2

Re: [3/3] d3dx9: Implement conversion from DDS pixel format to D3DFORMAT.
by Matteo Bruni 26 Apr '12

26 Apr '12

Il 26 aprile 2012 11:47, Józef Kucia <joseph.kucia(a)gmail.com> ha scritto: > static D3DFORMAT dds_pixel_format_to_d3dformat(const struct dds_pixel_format *pixel_format) > { > - FIXME("Pixel format conversion not implemented.\n"); > + if (pixel_format->flags & DDS_PF_FOURCC) > + return dds_fourcc_to_d3dformat(pixel_format->fourcc); > + else if (pixel_format->flags & DDS_PF_RGB) > + return dds_rgb_to_d3dformat(pixel_format); > + else if (pixel_format->flags & DDS_PF_LUMINANCE) > + return dds_luminance_to_d3dformat(pixel_format); > + else if (pixel_format->flags & DDS_PF_ALPHA_ONLY) > + return dds_alpha_to_d3dformat(pixel_format); You don't need all those 'else's, the 'return's imply that you get there only when the 'if' condition isn't true. The same applies in other areas of this patch. I don't mind much, but since you have to resend the series anyway...

1 0

Re: [1/3] d3dx9: Define DDS structures.
by Henri Verbeet 26 Apr '12

26 Apr '12

Is there no header that should define these?

2 2

Re: [2/3] d3dx9: Add partial DDS support implementation for D3DXGetImageInfo functions.
by Henri Verbeet 26 Apr '12

26 Apr '12

On 26 April 2012 11:47, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > +static HRESULT get_image_info_from_dds(LPCVOID buffer, DWORD length, D3DXIMAGE_INFO *info) Please avoid types like LPCVOID.

1 0

Re: [PATCH 1/2] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 4)
by Marvin 26 Apr '12

26 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18050 Your paranoid android. === WVISTAADM (32 bit amstream) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: gdiplus: GdipDrawString is not supposed to use the layout rectangle for clipping. Take 2.
by Dmitry Timoshkov 25 Apr '12

25 Apr '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > There is a dedicated clip region in the graphics object. Please ignore that patch or mark it as rejected, the real problem has been fixed by 9b5b04c1c1a7b32dd3e1e453b6d739082c4ccede. -- Dmitry.

1 0

Re: [PATCH 1/2] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 3)
by Alexandre Julliard 25 Apr '12

25 Apr '12

Christian Costa <titan.costa(a)gmail.com> writes: > Try3: Put sample stuff in stream_sample.c > Try2: Fix QueryInterface. It was better without creating a new file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] make_unicode: Create tables with data needed by nameprep algorithm
by Alexandre Julliard 25 Apr '12

25 Apr '12

Piotr Caban <piotr(a)codeweavers.com> writes: > + dump_nameprep_range($INPUT, $nameprep_flags{"unassigned"}, \@flags_table) if (/A.1/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.1.2/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.2.2/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.3/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.4/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.5/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.6/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.7/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.8/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.9/); > + dump_nameprep_range($INPUT, $nameprep_flags{"bidi_ral"}, \@flags_table) if (/D.1/); > + dump_nameprep_range($INPUT, $nameprep_flags{"bidi_l"}, \@flags_table) if (/D.2/); > + > + dump_nameprep_map($INPUT, \@mapping_table) if (/B.1/); > + dump_nameprep_map($INPUT, \@mapping_table) if (/B.2/); These names are confusing, the functions are loading data not dumping it. > + for (my $i = 0; $i < 65536; $i++) > + { > + next unless defined $flags_table[$i]; > + $flags_table[$i] += $i; > + } > + > + open OUTPUT,">$filename.new" or die "Cannot create $filename"; > + print "Building $filename\n"; > + print OUTPUT "/* Nameprep algorithm related data */\n"; > + print OUTPUT "/* generated from $STRINGPREP */\n"; > + print OUTPUT "/* DO NOT EDIT!! */\n\n"; > + print OUTPUT "#include \"wine/unicode.h\"\n\n"; > + DUMP_CASE_TABLE( "nameprep_char_type", @flags_table ); It doesn't make sense to use a case table for this, it's just flags. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: vbscript: 'property' may be both keyword and identifier
by Marvin 25 Apr '12

25 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18045 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] server: Revise completion behavior to allow completions for cancelled sockets (try 2).
by Alexandre Julliard 24 Apr '12

24 Apr '12

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch changes how the close socket operation works so that if > an async operation is registered then closing the handle will be > deferred until the async operation has completed. I would find it very suprising if this were how it's supposed to work, particularly since multiple handles can of course be opened to the same socket. You'll need very convincing tests for this... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] gdi32: Introduce a list of font file/data.
by Alexandre Julliard 24 Apr '12

24 Apr '12

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -962,6 +972,22 @@ static Family *find_family_from_any_name(const WCHAR *name) > return NULL; > } > > +static Font *find_font_file(const char *file) > +{ > + if (file != NULL) > + { > + Font *font; > + > + LIST_FOR_EACH_ENTRY(font, &font_list, Font, entry) > + { > + if (font->file != NULL && strcmp(font->file, file) == 0) > + return font; > + } > + } > + > + return NULL; > +} You can't compare files this way, different paths can point to the same file. > @@ -2927,7 +2988,8 @@ static BOOL get_fontdir( const char *unix_name, struct fontdir *fd ) > DWORD type; > > if (!ft_face) return FALSE; > - face = create_face( ft_face, 0, unix_name, NULL, 0, 0, FALSE ); > + font.file = (char *)unix_name; Don't do that. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: gdi32: Add support for emulating bold faces of bitmap fonts.
by Dmitry Timoshkov 24 Apr '12

24 Apr '12

Hello, Any feedback on this patch? -- Dmitry.

1 0

Re: winex11.drv: Windows always generates VK_DECIMAL for Del/. on a keypad.
by Dmitry Timoshkov 24 Apr '12

24 Apr '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Windows always generates VK_DECIMAL for Del/. on a keypad while some > X11 keyboard layouts generate XK_KP_Separator instead of XK_KP_Decimal > in order to produce a locale dependent numeric separator. > > X11 handles XK_KP_Separator same way as XK_KP_Decimal for all tested > keyboard layouts, so passing XK_KP_Separator instead of XK_KP_Decimal > to XKeysymToKeycode doesn't break things. Pressing Del/. with NumLock > turned on still correctly generates '.' or ',' depending on keyboard > layout and matches what Windows does. > > This patch fixes an application which uses VK_DECIMAL as a sign to break > the input string and insert a separator while entering a currency/price. Is there anything else I could provide in helping to get this patch accepted? -- Dmitry.

1 1

Re: [3/5] mapi32: Convert sendmail_extended_mapi to Unicode
by Alexandre Julliard 24 Apr '12

24 Apr '12

Owen Rudge <orudge(a)codeweavers.com> writes: > + > +/* Macro to test for validity before freeing a pointer */ > +#define mapi_heap_free(_ptr) if (_ptr) { HeapFree(GetProcessHeap(), 0, (_ptr)); } You don't need that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Mono packaging status
by Vincent Povirk 24 Apr '12

24 Apr '12

So, I've finally had some time to work on Mono packaging. I think I have a sort of "first draft" ready. The goal is to create an MSI package of Mono, similar to the one we use for Gecko, which Wine will install automatically when updating a prefix, unless native mscoree is installed. This package will include all the Mono runtime files, as well as any registry keys and files that need to be installed to the Windows system for .NET compatibility. Anything .NET that we want to replace (including XNA, WPF, and msvcm libraries) will be included. Ideally, with this package installed, any official installers for .NET components will decide they are already installed and do nothing. To install native .NET, it will be necessary to uninstall the Mono package (using "wine uninstaller --remove '{E45D8920-A758-4088-B6C6-31DBB276992E}'", which will continue to work for the foreseeable future). Before the Mono package is installed, and after it is removed, no .NET registry keys or files will be present, so in theory the installers will just work (but in practice they probably will require work-arounds for Wine bugs). There will be only one package for 32-bit and 64-bit. Most of the compiled code is architecture-independent, so it doesn't make much sense to have separate packages. The Mono package versions will be loosely tied to Wine version. On prefix creation time, Wine will attempt to install the version it "prefers". Due to limitations of MSI, this may mean that Wine will upgrade Mono automatically but never downgrade it. Because the Mono API is stable, it should be possible to use any Mono package with any Wine version back to 1.5.1, which was the first version to search for the Mono runtime dll based on architecture. I'm currently publishing the source code at https://github.com/madewokherd/wine-mono, but I'm not sure if that is a good permanent home. I do want to keep it on github so I can make and accept pull requests. I'm using submodules, so it will be necessary to clone with --recursive and update the submodules from time to time. The build process requires mingw-w64 (both 32-bit and 64-bit), Wine, and a version of the Mono C sharp compiler (gmcs or dmcs, I think), and not surprisingly is done by running build-winemono.sh. There should never be any more requirements, and I'd like to keep the version requirements on those as broad as I can. I want this to be easy to build, so other people can work on it. The 64-bit part appears to work on Windows, but it is not useful on Wine currently. I'll be working on fixing that, or at least getting Alexandre bug reports and test cases so he can work on it. I think that when it is fixed, we'll have a lot more 64-bit processes than we used to, for better or worse. For now, the only way to install the package is with msiexec. The current version is based on Mono 2.11.0, which has a serious deadlock bug on Windows. This will need to be resolved before I can do an actual release. Otherwise, I'm not expecting much difference from the official Mono 2.10 packages for Windows. The XNA, WPF, and msvcm stuff is not ready yet. So, I know it's kind of crappy right now, and I'm not asking for testing so much as comments. If you are a packager of Wine, I would like to make sure you can build it, and that the resulting build works apart from that deadlock bug. If for some reason you want to try it, the current version is at https://github.com/downloads/madewokherd/wine-mono/winemono-0.0.2.msi. I think I will need a new home for the binaries, because github only gives me enough space for about 5 of them. So, uh, don't count on that URL sticking around.

4 5

Re: [2/2] gdi32: Enumerated font size should not be too large.
by Huw Davies 23 Apr '12

23 Apr '12

On 23/04/2012 15:32, Dmitry Timoshkov wrote: > This reverts commit f4625d1ae1109ee9a30faa8254b10779853f0ac2. > --- > dlls/gdi32/freetype.c | 2 +- > dlls/gdi32/tests/font.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 3875e4f..401cfd1 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -5048,7 +5048,7 @@ static void GetEnumStructs(Face *face, LPENUMLOGFONTEXW pelf, > font = alloc_font(); > > if(face->scalable) { > - height = -2048; /* 2048 is the most common em size */ > + height = 100; > width = 0; > } else { > height = face->size.y_ppem>> 6; You'll need to fix the ntmTm.ntmCellHeight and ntmTm.ntmAvgWidth values. Huw.

2 3

Re: gdiplus: Use symbolic name of the font style.
by Nikolay Sivov 23 Apr '12

23 Apr '12

On 4/23/2012 17:31, Dmitry Timoshkov wrote: > --- > dlls/gdiplus/font.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c > index 169e28f..8157b0a 100644 > --- a/dlls/gdiplus/font.c > +++ b/dlls/gdiplus/font.c > @@ -767,7 +767,7 @@ GpStatus WINGDIPAPI GdipGetLineSpacing(GDIPCONST GpFontFamily *family, > static INT CALLBACK font_has_style_proc(const LOGFONTW *elf, > const TEXTMETRICW *ntm, DWORD type, LPARAM lParam) > { > - INT fontstyle=0; > + INT fontstyle = FontStyleRegular; > > if (!ntm) return 1; > Maybe it's better to make it 'enum FontStyle' after all.

2 1

Re: [PATCH 1/4] amstream: rename mediastream to ddrawmediastream. (resend)
by Alexandre Julliard 23 Apr '12

23 Apr '12

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/amstream/Makefile.in | 2 > dlls/amstream/amstream.c | 6 + > dlls/amstream/amstream_private.h | 2 > dlls/amstream/ddrawmediastream.c | 256 ++++++++++++++++++++++++++++++++++++++ > dlls/amstream/mediastream.c | 251 ------------------------------------- > 5 files changed, 263 insertions(+), 254 deletions(-) > create mode 100644 dlls/amstream/ddrawmediastream.c > delete mode 100644 dlls/amstream/mediastream.c There's no reason to rename the file. Just put everything in there. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: iphlpapi: Move get_pid_map() and find_owning_pid() under #ifdef #ifdef __linux__.
by Alexandre Julliard 23 Apr '12

23 Apr '12

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > ...like their sole user. > > Otherwise this warns on everything which is not __linux__. ;-) That's a feature. It needs to be implemented on other platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] dmusic: Pass creation parameters to DMUSIC_CreateDirectMusicBufferImpl then allocate data buffer and set format accordingly.
by Alexandre Julliard 23 Apr '12

23 Apr '12

Christian Costa <titan.costa(a)gmail.com> writes: > +HRESULT WINAPI DMUSIC_CreateDirectMusicBufferImpl(LPDMUS_BUFFERDESC desc, LPVOID* ret_iface) > +{ > + IDirectMusicBufferImpl* dmbuffer; > + > + TRACE("(%p, %p)\n", desc, ret_iface); > + > + dmbuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicBufferImpl)); > + if (!dmbuffer) { > + *ret_iface = NULL; > + return E_OUTOFMEMORY; > + } > + > + dmbuffer->lpVtbl = &DirectMusicBuffer_Vtbl; > + dmbuffer->ref = 0; /* Will be inited by QueryInterface */ > + > + memcpy(&dmbuffer->format, &desc->guidBufferFormat, sizeof(GUID)); > + dmbuffer->size = (desc->cbBuffer + 3) & ~3; /* Buffer size must be multiple of 4 bytes */ > + > + dmbuffer->data = HeapAlloc(GetProcessHeap(), 0, sizeof(dmbuffer->size)); > + if (!dmbuffer->data) { > + HeapFree(GetProcessHeap(), 0, dmbuffer); > + *ret_iface = NULL; > + return E_OUTOFMEMORY; > + } > + > + return IDirectMusicBufferImpl_QueryInterface((LPDIRECTMUSICBUFFER)dmbuffer, &IID_IDirectMusicBuffer, ret_iface); While you are changing the function please also make it handle errors properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] dmsynth: Check the rigth CLSID to create the DirectMusicSynthSink object. (resend)
by Marvin 21 Apr '12

21 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17990 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

winedbg and program stdout
by Ilya Basin 21 Apr '12

21 Apr '12

When I debug a program with winedbg, it's output never goes to the same terminal. If it's compiled with -mconsole, it goes to a new console window; if compiled with -mwindows, the output is discarded. Any way to change this behavior?

2 1

Re: d3dx9_36: Add adjacency for D3DXCreateCylinder
by Rico Schüller 20 Apr '12

20 Apr '12

Am 20.04.2012 16:20, schrieb David Adam: > > + if (adjacency) > > I'm not sure that this is correct, but why is adjacency not touched? What should be returned for adjacency, maybe a test will show it? I guess the temp ID3DXBuffer should be returned instead of leaked when all is successful... Cheers Rico

1 0

Re: jscript: Added regexp 'pre-parser' to support non-backslash-sequenced non-terminating '/' in characted classes
by Marvin 20 Apr '12

20 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Are we missing the small folder_open icons?
by Francois Gouget 20 Apr '12

20 Apr '12

In dlls/shell32/shell32.rc I see the following fixme: /* FIXME: Following three resources are not yet added */ /* @makedep: folder_open.ico */ IDI_SHELL_FOLDER_OPEN_SMALL ICON folder_open.ico /* @makedep: folder_open.ico */ IDI_SHELL_FOLDER_OPEN_LARGE ICON folder_open.ico /* @makedep: folder_open.ico */ IDI_SHELL_FOLDER_SMALL_XP ICON folder_open.ico However folder_open.ico is generated from an SVG file and we seem to be having it in multiple sizes. Also this fixme has been there forever. So is there really still something to be fixed? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

2 1

Updating GSoC proposal
by Jacek Caban 19 Apr '12

19 Apr '12

Hi all, GSoC is starting this year and, if we want to have good applications, we need to update our proposals. Usually the most attention is directed into adding new ones, while we keep obviously bad (or just bad IMO) proposals on the page. I'm planning to remove following project proposals: Security - implement sandboxing Theming - Implement Wine theming support NTDLL - support performance registry keys Winelib Aware Scons (or cmake) Cleanup Winemenubuilder to support generating Application Bundles on Mac OS X Wine-based application virtualization If someone knows a reason to not remove them, please reply. Cheers, Jacek

2 1

Re: d3dx9/tests: Add DDS pixel format tests for D3DXGetImageInfoFromFileInMemory.
by Matteo Bruni 19 Apr '12

19 Apr '12

Il 19 aprile 2012 19:37, Józef Kucia <joseph.kucia(a)gmail.com> ha scritto: > --- > dlls/d3dx9_36/tests/surface.c | 65 +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 65 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index 87aa03e..51d6ebd 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -22,6 +22,8 @@ > #include "wine/test.h" > #include "d3dx9tex.h" > #include "resources.h" > +#undef MAKE_DDHRESULT > +#include "ddraw.h" > I'm not sure that's a good idea. ddraw.h is not included in recent DirectX SDKs and the relevant definitions are "gone", as far as I know. So I think d3dx9 or its tests should not depend on that header. I'd just (re)declare the stuff you need privately in the test source file instead. You don't even need to use the same types/defines/variables names as those from ddraw.h, you just have to keep them compatible. On that point, I see that MSDN mentions the equivalent DDS_HEADER and DDS_PIXELFORMAT structures (http://msdn.microsoft.com/en-us/library/windows/desktop/bb943991%28v=vs.85%…), except those don't seem to be defined in the MS headers either. I guess you are free to use whatever names you like...

3 3

Re: [PATCH 4/4] jscript: Added Number.toPrecision implementation
by Marvin 19 Apr '12

19 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17957 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] jscript: Added Number.toExpontential implementation
by Marvin 19 Apr '12

19 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17956 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] jscript: Added Number.toFixed implementation
by Marvin 19 Apr '12

19 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17955 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] ws2_32: Revise AcceptEx behavior to send completions for canceled sockets (resend 3, deferred).
by Alexandre Julliard 19 Apr '12

19 Apr '12

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > @@ -256,10 +256,12 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > else > { > if (async->timeout) remove_timeout_user( async->timeout ); > + if (async->completion && async->data.cvalue && status != STATUS_ALERTED) > + add_completion( async->completion, async->comp_key, async->data.cvalue, status, total ); > + else if (async->completion && async->data.cvalue && status == STATUS_ALERTED) > + status = STATUS_SUCCESS; This looks pretty hackish, the server shouldn't have to care about the status values or patch them up for the client. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wininet: Add a new common module information struct
by Piotr Caban 18 Apr '12

18 Apr '12

On 04/16/12 22:03, Morten Rønne wrote: > Add a new common module information struct for urlcache and functions to > do initialization of the struct. This is intended to be a new way to > more easily create Ansi and Unicode version of the functions, by doing a > Ansi/Unicode preamble code that calls a common worker function that do > the real work. Is there any reason not to call Ansi function inside Unicode function? (This is the other way then it is done in most parts of wine, the reason for this is that urlcache stores ansi strings internally. Unicode urls should probably be converted using punycode encoding (IdnToAscii?)). This patch is also introducing lots of unneeded Ansi/Unicode conversions. I'm not sure if storing all url entry related information inside a structure makes anything easier/more readable. Especially when you need to make sure that a field is initialized before accessing it.

2 1

Re: [PATCH 1/2] wininet: Update structs with more information in preparation for implementation of more functionality.
by Piotr Caban 18 Apr '12

18 Apr '12

On 04/16/12 22:00, Morten Rønne wrote: + DWORD AllocationTable[0xF6C]; There are defines describing allocation table size. It's better to define it as BYTE AllocationTable[ALLOCATION_TABLE_SIZE];

2 1

Patch 85420
by Christian Costa 18 Apr '12

18 Apr '12

Hi, Patch http://source.winehq.org/patches/data/85420 is marked as pending. I've taken a look but I still don't understand what's wrong. Is there anything I've missed ? Thanks Christian

3 3

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending. Resend.
by Dmitry Timoshkov 18 Apr '12

18 Apr '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > This patch makes printing of PNG and other images work from applications > which use gdiplus for that. > > Printer drivers can't support transparency or alpha blending in any way. > This patch was tested with wide range of images (some mixed with other > graphics and text), and output matches what native gdiplus does. Is there anything else I could provide in helping to get this patch accepted? -- Dmitry.

2 2

Re: mshtml: Copy filter value in HTMLElement_clone
by Marvin 18 Apr '12

18 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17938 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] wininet: Add a new common module information struct
by Jacek Caban 18 Apr '12

18 Apr '12

Hi Morten, On 04/16/12 22:03, Morten Rønne wrote: > typedef struct _HASH_CACHEFILE_ENTRY > { > CACHEFILE_ENTRY CacheFileEntry; > DWORD dwAddressNext; > DWORD dwHashTableNumber; > - struct _HASH_ENTRY HashTable[HASHTABLE_SIZE]; > -} HASH_CACHEFILE_ENTRY; > + HASH_ENTRY HashTable[HASHTABLE_SIZE]; > +} HASH_CACHEFILE_ENTRY, *LPHASH_CACHEFILE_ENTRY; > > typedef struct _DIRECTORY_DATA > { > @@ -187,13 +187,56 @@ typedef struct _URLCACHECONTAINER > HANDLE hMapping; /* handle of file mapping */ > DWORD file_size; /* size of file when mapping was opened */ > HANDLE hMutex; /* handle of mutex */ > -} URLCACHECONTAINER; > +} URLCACHECONTAINER, *LPURLCACHECONTAINER; Please don't use this kind of defined. LP* types make the code less readable for no good reason. Cheers, Jacek

1 0

Re: [PATCH 2/2] jscript: Correctly handle empty matches in String.replace
by Marvin 18 Apr '12

18 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17935 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [7/7] server: Propagate an error code returned by token_access_check() to the client. Resend.
by Marvin 18 Apr '12

18 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17934 Your paranoid android. === TEST64_W7SP1 (32 bit sync) === sync.c:924: Test failed: ChangeTimerQueueTimer

1 0

SymEnumSymbolsForAddr in dbghelp.dll
by Roger Cruz 18 Apr '12

18 Apr '12

I wrote a simple piece of code that uses dbghelp.dll's SymEnumSymbolsForAddr() but when I went to search for its code in Wine, it looks to be missing. The dbghelp.spec has that function listed as "stub". What does stub mean in this context? Does it mean the function is not implemented? Are there any plans to? Thanks Roger R. Cruz

2 4

Re: wsnmp32: New stub dll (resend)
by Alexandre Julliard 17 Apr '12

17 Apr '12

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -0,0 +1,49 @@ > +# imported from D-Link EMS by ordinal > +320 stub SnmpSetPort > +# > +@ stub SnmpCancelMsg > +@ stub SnmpCleanup > +@ stub SnmpClose > +@ stub SnmpContextRoStr > +@ stub _SnmpConveyAgentAddress > +@ stub SnmpCountVbl > +@ stub SnmpCreatePdu > +@ stub SnmpCreateSession > +@ stub SnmpCreateVbl > +@ stub SnmpDecodeMsg > +@ stub SnmpDeleteVb > +@ stub SnmpDuplicatePdu > +@ stub SnmpDuplicateVbl > +@ stub SnmpEncodeMsg > +@ stub SnmpEntityTpStr > +@ stub SnmpFreeContext > +@ stub SnmpFreeDescriptor > +@ stub SnmpFreeEntity > +@ stub SnmpFreePdu > +@ stub SnmpFreeVbl > +@ stub SnmpGetLastError > +@ stub SnmpGetPduData > +@ stub SnmpGetRetransmitMode > +@ stub SnmpGetRetry > +@ stub SnmpGetTimeout > +@ stub SnmpGetVb > +@ stub SnmpGetVendorInfo > +@ stub SnmpListen > +@ stub SnmpOidCompare > +@ stub SnmpOidCopy > +@ stub SnmpOidToStr > +@ stub SnmpOpen > +@ stub SnmpRecvMsg > +@ stub SnmpRegister > +@ stub SnmpSendMsg > +@ stub _SnmpSetAgentAddress > +@ stub SnmpSetPdu > +@ stub SnmpSetRetransmitMode > +@ stub SnmpSetRetry > +@ stub SnmpSetTimeout > +@ stub SnmpSetTranslateMode > +@ stub SnmpSetVb > +@ stub SnmpStartup > +@ stub SnmpStrToContext > +@ stub SnmpStrToEntity > +@ stub SnmpStrToOid They should probably all be ordinals, also some of the names are wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0

New forum software
by Vitaliy Margolen 17 Apr '12

17 Apr '12

Can I ask when we'll have the new forum software installed? It's been discussed ages ago and we still using the same old crappy version. Vitaliy.

4 4

Re: gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments (try 2)
by Alexandre Julliard 17 Apr '12

17 Apr '12

Daniel Lehman <dlehman(a)esri.com> writes: > Was mistakenly sent to wine-devel > > try 2 - integrate into existing tests; updated commit message > > I think the only points in the middle of the points array can cause > the crash I was seeing. wide_pen_lines trims coincident points/empty > segments from the beginning and end of the array, so the > wine_line_segment calls before and after the for loop I modified will > always return valid faces It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c && touch dib.ok dib.c:1324: Test failed: 8888: wide pen - empty segments: expected hash 5bac9c515315bced1ac5cb46a771690d02040278 got 56cc0584aaeb790419b343dae0ea09591c384ac4 dib.c:1324: Test failed: 8888 - bitfields: wide pen - empty segments: expected hash 5bac9c515315bced1ac5cb46a771690d02040278 got 56cc0584aaeb790419b343dae0ea09591c384ac4 dib.c:1324: Test failed: a8b8g8r8: wide pen - empty segments: expected hash 1aa5e414c797fd74fe1400757548ef79650fe994 got ee5a5dc02ec61af2462c265424943049ea7c23eb dib.c:1324: Test failed: r10g10b10: wide pen - empty segments: expected hash 65f7fc7219e7cc29d20aeab7d38a60ac6c303726 got d7ee8801ea0c3e7cf012153b77bd7ba9b388f459 dib.c:1324: Test failed: r6g6b6: wide pen - empty segments: expected hash b1e3aeac484f49b1874033509924627ef0a4c3bc got 906c2d8da24180ccbe84fd4fd5ba964d8f9a3a44 dib.c:1324: Test failed: 24: wide pen - empty segments: expected hash f11f301314f9729ab351294a4d8a72b72fc2491d got 9433b11e4190cf1d77f4b84017e8561884ccd73c dib.c:1324: Test failed: r5g5b5: wide pen - empty segments: expected hash ffa75c684138fdb296f4001e2dc36ed1ae33065b got e141eb6b73e91eb2e4b5fd31688084d4b4c70d30 dib.c:1324: Test failed: r4g4b4: wide pen - empty segments: expected hash 9aa687dc13503e3ff4e12e67c361ca140cbdb48d got 27afb67bda17491c7806f1a42650deb9d47bba71 dib.c:1324: Test failed: 8 color: wide pen - empty segments: expected hash 7897ba51f37e01c6a54a2733459e79285b52d213 got d905bc3cd08fc4a7110608ec8b80e494077e859e dib.c:1324: Test failed: 8 grayscale: wide pen - empty segments: expected hash 88eb0c6542a2c03036241cdb5e08f13401a92f31 got bef8347c9bc96d709aaf002fcf6b4da66e5267e7 dib.c:1324: Test failed: 8: wide pen - empty segments: expected hash 00b34f58bb4876b597fad1a275bccb2c9a95967b got 3f318b982da1b8d26eff59ed8c6d7ce6a84f857a dib.c:1324: Test failed: 4: wide pen - empty segments: expected hash 9b5ecb81cf32c34c43cb13310e4b479b6909f3ec got 10271cb9b746fb9b507a9322c16f1279deb69a95 dib.c:1324: Test failed: 4 grayscale: wide pen - empty segments: expected hash 048ce4615962675d66b648631dc556238a86b4df got 9cf16c3165ac241aa6fb50bb0a05c3548fbaeb43 dib.c:1324: Test failed: 1: wide pen - empty segments: expected hash 1dde794388a3ca3ac710acc0aff97f7df70687e5 got e203905ad4c0a609b5ac78e66714b66ffe792b8b make[1]: *** [dib.ok] Error 14 -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel