There is no need to call uri_escape() on integers.
Also the URL is simple (no ampersand) and does not need to go through
escapeHTML().
Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
---
testbot/web/PatchesList.pl | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/testbot/web/PatchesList.pl b/testbot/web/PatchesList.pl
index 943b9c5bb..48c8382e7 100644
--- a/testbot/web/PatchesList.pl
+++ b/testbot/web/PatchesList.pl
@@ -25,7 +25,6 @@ package PatchesBlock;
use ObjectModel::CGI::CollectionBlock;
our @ISA = qw(ObjectModel::CGI::CollectionBlock);
-use URI::Escape;
use WineTestBot::Patches;
@@ -54,9 +53,7 @@ sub GenerateDataView($$$)
$Row->{Item}->Disposition =~ /job ([0-9]+)$/)
{
my $JobId = $1;
- my $URI = "/JobDetails.pl?Key=" . uri_escape($JobId);
- print "<a href='" . $self->escapeHTML($URI) . "'>" .
- "Job " . $self->escapeHTML($JobId) . "</a>";
+ print "<a href='/JobDetails.pl?Key=$JobId'>Job $JobId</a>";
}
else
{
--
2.30.2