wine-devel

wine-devel@winehq.org

9 participants
84397 discussions

[PATCH 1/2] ntdll/tests: Fix compilation with PSDK.
by Dmitry Timoshkov 28 Jul '22

28 Jul '22

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/ntdll/tests/om.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/tests/om.c b/dlls/ntdll/tests/om.c index ddbdce0281c..7fe0fb59f89 100644 --- a/dlls/ntdll/tests/om.c +++ b/dlls/ntdll/tests/om.c @@ -2078,7 +2078,7 @@ static void test_token(void) status = pNtOpenThreadToken( GetCurrentThread(), TOKEN_ALL_ACCESS, TRUE, (HANDLE *)0xdeadbee0 ); ok( status == STATUS_ACCESS_VIOLATION, "NtOpenProcessToken failed: %lx\n", status); handle = (HANDLE)0xdeadbeef; - status = NtOpenProcessToken( (HANDLE)0xdead, TOKEN_ALL_ACCESS, &handle ); + status = pNtOpenProcessToken( (HANDLE)0xdead, TOKEN_ALL_ACCESS, &handle ); ok( status == STATUS_INVALID_HANDLE, "NtOpenProcessToken failed: %lx\n", status); ok( !handle || broken(handle == (HANDLE)0xdeadbeef) /* vista */, "handle set %p\n", handle ); handle = (HANDLE)0xdeadbeef; @@ -2526,7 +2526,7 @@ static void test_query_directory(void) RtlInitUnicodeString( &string, L"\\BaseNamedObjects\\winetest" ); InitializeObjectAttributes( &attr, &string, 0, 0, NULL ); - status = NtCreateDirectoryObject( &dir, DIRECTORY_QUERY, &attr ); + status = pNtCreateDirectoryObject( &dir, DIRECTORY_QUERY, &attr ); ok( !status, "got %#lx\n", status ); context = 0xdeadbeef; @@ -2717,9 +2717,9 @@ static void test_query_directory(void) ok( !memcmp( &info[1], &empty_info, sizeof(*info) ), "entry was not cleared\n" ); } - NtClose( child1 ); - NtClose( child2 ); - NtClose( dir ); + pNtClose( child1 ); + pNtClose( child2 ); + pNtClose( dir ); } START_TEST(om) -- 2.37.1

1 0

Re: [PATCH v2 2/2] ddraw/tests: Add some video memory accounting tests.
by Marvin 28 Jul '22

28 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119983 Your paranoid android. === w7u_2qxl (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w1064 (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x00000040. === w1064_tsign (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x0000ff00. === debian11 (32 bit Chinese:China report) === Report validation errors: ddraw1: Timeout === debian11 (build log) === WineRunWineTest.pl:error: The task timed out

1 0

Re: [PATCH v3 5/9] mshtml: Implement lastElementChild for Elements.
by Marvin 28 Jul '22

28 Jul '22

1 0

Re: [PATCH v3 4/9] mshtml: Implement hasAttributeNS for Elements.
by Marvin 28 Jul '22

28 Jul '22

1 0

Re: [PATCH v3 3/9] mshtml: Implement removeAttributeNS for Elements.
by Marvin 28 Jul '22

28 Jul '22

1 0

Re: [PATCH v4 1/1] d3drm/tests: Show Clear sets background color
by Marvin 28 Jul '22

28 Jul '22

1 0

Re: [PATCH v3 2/9] mshtml: Implement setAttributeNS for Elements.
by Marvin 28 Jul '22

28 Jul '22

1 0

Re: [PATCH 5/6] comctl32/listview: Don't send LVN_ODSTATECHANGED for empty ranges.
by Marvin 28 Jul '22

28 Jul '22

1 0

Re: [PATCH 4/6] comctl32/listview: Send LVN_ODSTATECHANGED notification for LVS_OWNERDATA listview on selection changes.
by Marvin 28 Jul '22

28 Jul '22

1 0

[PATCH v4 0/7] Fix LVS_OWNERDATA list view multi select.
by Angelo Haller 28 Jul '22

28 Jul '22

From: Angelo Haller <angelo(a)szanni.org> The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v4 fixing the log buffer overflow on the debian test machine by moving some of the up/down key sequences to a later patch. Patch 1/7 still includes the necessary up/down key sequences to validate the fixes in the following patches. The matching up/down key sequences for 1/7 are then introduced in 7/7. I was sadly unable to introduce the test sequence with each fix, as this would require inventing entirely new test sequences, just to work around the debian 32KB log buffer limit. I hope this is ok as it stands. I am also attaching the my remarks from v3, as I don't know if they got ignored due to failing tests: I was sadly not able to trigger any deselect sequences through emulating mouse clicks. I was actually completely unable even send a lef mouse button down at all. Both SendMessage and SendInput fail, on wind and windows. I am unsure if programmatic mouse clicks are even supported in list views? Some forums seem to suggest, that this is only the case for buttons and similar elements. I was following the code snippets in other parts of the comctl32 tests. The other thing might be that the signal is getting caught somewhere in the test code. If anybody has any more insight in this regard, I'd be happy to add additional mouse click tests as well. The other thing I was unable to do is activate the single select tests via SHIFT/+COMMAND to show we need patch 6/6. Windows weirdly informs about the selected item twice, once to inform the item has been selected and then in another call later about the item being focused as well. This seemingly only affects LVS_OWNERDATA listviews from my tests. Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. Angelo Haller (7): Add more test cases to ownderdata listviews: comctl32/listview: Fix deselect on LVS_OWNERDATA. comctl32/listview: Move sending LVN_ODSTATECHANGED notifications to a function. comctl32/listview: Send LVN_ODSTATECHANGED only for virtual lists. comctl32/listview: Send LVN_ODSTATECHANGED notification. comctl32/listview: Send LVN_ODSTATECHANGED only for true ranges. comctl32/tests: Expand ownerdata listview tests. dlls/comctl32/listview.c | 55 ++++--- dlls/comctl32/tests/listview.c | 253 +++++++++++++++++++++++++++++++-- 2 files changed, 281 insertions(+), 27 deletions(-) Signed-off-by: Angelo Haller <angelo(a)szanni.org> -- 2.36.1

2 11

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel