wine-devel

wine-devel@winehq.org

8 participants
84486 discussions

[RFC] creating Wine's own 'assert' variant
by Lionel Ulmer 26 Oct '02

26 Oct '02

Hi all, Currently, Wine's code is full of 'asserts'. The problem I have with that if that when such an assert is reached, only the thread being asserted is aborted, but Wine is not 'shut down' properly. Moreover, if I want the debugger to be launched on assert, I would need first to start the application with the debugger and add a breakpoint on some libc internal function. So, don't you think it would be better to have our own 'wine_assert' macro / function that could be configurable (ie abort or start the debugger) and that would also shut-down Wine properly ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

4 5

Re: interrupts in when in NT version
by John K. Hohm 26 Oct '02

26 Oct '02

> Tough all safedisc programs depend on this, I have decided not to make an > official patch. The reason is that additional info is needed for a proper > fix. Safedisc depends on that EXCEPTION_ACCESS_VIOLATION is returned on an > int 0x01 call. But it should be checked what exceptions are raised on > different windows versions when int 0x01 is called. And maybe the same should > be done with other interrupts. > It would be good if somebody could make that test program. Else I will keep > the non proper fix. You may think me a rube, but I just made a test program that calls an arbitrary interrupt and prints the exception information. I don't set up any registers, so perhaps it generates an exception when it ought not in some cases, but anyone else is free to improve it. Source and a VC6-compiled MSVCRT-using version, along with results for all 255 interrupts on Windows XP Professional, is here: http://petra.trnty.edu/~jhohm/intexcep.zip

2 1

Re: dlls/user: w[v]snprintf[A|W] fixes
by Alexandre Julliard 26 Oct '02

26 Oct '02

"Jaco Greeff" <jaco(a)puxedo.org> writes: > Changelog: > * dlls/user/wsprintf.c Jaco Greeff <jaco(a)puxedo.org> > - Changed the wsprintf[A|W] and wvsprintf[A|W] functions to > determine the size of the destination buffer before writing > to it. Previously the size was hardcoded to 1024 bytes. The size is supposed to be hardcoded to 1024, that's how wsprintf works. You can't make it dynamic since the buffer is allocated by the application. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: msvcrt: printf family (Bug #321)
by Alexandre Julliard 26 Oct '02

26 Oct '02

"Jaco Greeff" <jaco(a)puxedo.org> writes: > * dlls/msvcrt/file.c Jaco Greeff <jaco(a)puxedo.org> > - Allow for the processing of %S and %C format specifiers as per > bug #321 > - Code duplicated/shared between dlls/user/wsprintf.c, > dlls/shlwapi/wsprintf.c and now dlls/msvcrt/file.c That's not correct. wsprintf is not a normal printf, it lacks a lot of features so it's not good enough for msvcrt. We either need a full printf implementation in msvcrt, or we need to patch the %S/%C in the format string and call the libc printf. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - hInst = GetWindowLongA( lpofn->hwndOwner, GWL_HINSTANCE ); > + hInst = (HINSTANCE)(ULONG_PTR)GetWindowLongA( lpofn->hwndOwner, GWL_HINSTANCE ); Why can't you cast here directly to HINSTANCE? -- Dimi.

2 1

Control Panel Application does not start
by Stefan Leichter 26 Oct '02

26 Oct '02

Hello, i am currently tracking down a problem with a program (Nokia PC Suite 4; NclConf.exe) that is unable to start its control panel application. The control panel application should be started by the rundll32.exe. It does not get started because of the path in the filename. The applet is searched in the correct directory but it does not get found because the path was not stripped from the filename. So a filename with path is compared to the filename without path read from the directoy. This will never match. I have attached a logfile with the relevant line (i hope). Will please someone be so kind and look at it and tell me what ithe reason for the problem is. Thanks Stefan -------------------------------------------------------------------------------------------------------------------------- 0831f930:Call shell32.Control_RunDLL(00020025,00400000,40370bb5,0000000a) ret=00401380 0831f930:Call kernel32.LoadLibraryA(403d0028 "\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"") ret=409bb0f4 trace:dosfs:DOSFS_GetFullName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" (last=1) trace:string:lstrcpynA (0x406d1c50, "/wine_app/wine_app", 1024) trace:string:lstrcpynA (0x406d1c63, "Programme/Gemeinsame Dateien/Nokia/NCLTools", 1005) trace:string:lstrcpynW (0x406d2056, L"PROG~1F2\\GEME~SR3\\NOKIA\\NCLTOOLS", 1021) trace:dosfs:DOSFS_FindUnixName /wine_app/wine_app/Programme/Gemeinsame Dateien/Nokia/NCLTools,L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" trace:dosfs:DOSFS_ToDosFCBFormat (L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"", 0x406d1b78) trace:dosfs:DOSFS_OpenDir "/wine_app/wine_app/Programme/Gemeinsame Dateien/Nokia/NCLTools" trace:dosfs:DOSFS_ReadDir Read: long_name: L".", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"." trace:dosfs:DOSFS_ReadDir Read: long_name: L"..", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L".." trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_I.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_I.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_D.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_D.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_E.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_E.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_F.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_F.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_G.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_G.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_N.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_N.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_S.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_S.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_SV.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_SV.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NclConf.exe", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NclConf.exe" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NclConf.cpl", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NclConf.cpl" warn:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" not found in '/wine_app/wine_app/Programme/Gemeinsame Dateien/Nokia/NCLTools' warn:module:MODULE_LoadLibraryExA Failed to load module 'C:\WINDOWS\SYSTEM32'; error=2 0831f930:Ret kernel32.LoadLibraryA() retval=00000000 ret=409bb0f4 0831f930:Call kernel32.FreeLibrary(00000000) ret=409bb088 0831f930:Ret kernel32.FreeLibrary() retval=00000000 ret=409bb088 0831f930:Ret shell32.Control_RunDLL() retval=00000001 ret=00401380

4 7

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - chf32a->hInstance=chf16->hInstance; > + chf32a->hInstance=(HINSTANCE)(ULONG_PTR)chf16->hInstance; Shouldn't we have a HINSTANCE_32 macro, for uniformity? -- Dimi.

2 1

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - bRet = DialogBoxIndirectParam16( hInst, lfs->hDlgTmpl16, lpofn->hwndOwner, > + bRet = DialogBoxIndirectParam16( (HINSTANCE16)LOWORD(hInst), lfs->hDlgTmpl16, lpofn->hwndOwner, And here we should have a HINSTANCE_16 macro... -- Dimi.

1 0

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - FillRect(hDC, &lpp->old3angle, GetClassLongA( hwnd, GCL_HBRBACKGROUND)); > + FillRect((HDC)hDC, &lpp->old3angle, (HBRUSH)GetClassLongA( hwnd, GCL_HBRBACKGROUND)); This is not right. At that point, hDC should be a HDC, if it's not, you have to modify the code around it. Such casting should happen in the WindowProc, all functions should work with the proper type. Alexandre, please do not apply the patch in this form: it silence warnings, and it makes it very difficult to properly correct the code in the future. -- Dimi.

1 0

Re: interrupts in when in NT version
by Zsolt Rizsanyi 26 Oct '02

26 Oct '02

I have forgotten to cc this discussion to wine-devel. But who is interested can catch up from this mail. On Saturday 26 October 2002 14:07, Eric Pouech wrote: > > > > Could somebody answer/test if calling interrupt int 0x01 is allowed > > > > from a win32 program in WinNT environment? I would pretty like to > > > > know that! > > > > > > I don't think it is > > > > Should I write then a patch, which would deny calling of int 0x01 from > > win32 code when winver is NT? > > Would that be applied? > > the rule of thumb is: if there's a program which depends on this to be > implemented, then yes patch will be applied > otherwise, leave it as it is Tough all safedisc programs depend on this, I have decided not to make an official patch. The reason is that additional info is needed for a proper fix. Safedisc depends on that EXCEPTION_ACCESS_VIOLATION is returned on an int 0x01 call. But it should be checked what exceptions are raised on different windows versions when int 0x01 is called. And maybe the same should be done with other interrupts. It would be good if somebody could make that test program. Else I will keep the non proper fix. > > > it was allowed on Win9x, and is used in this context IIRC as a ring 3 > > > to ring 0 transition code (how to create a cheap call gate) > > > > How good it would be if I could understand what you are speaking about :( > > But could you explain what a call gate is? > > If it is too long, then dont bother tough... > > I'll try to make it short > context: > - i386 have 4 levels of privilege => ring 3 (less privilege) up to ring > 0 > - certain operations are only allowed at ring 0 (or 1) > - user code runs in ring 3 > - kernel code runs in ring 0 (to be exact, NT had been designed to have > kernel in ring 0, and device drivers in ring 1, but this has been > altered - some drivers run in ring 0 too) > - you can always call into a less priviledged level (ring 0 => ring 3 > for example) > - the other way around requires what is known as call gates (ring 0 for > example defines the "entry points" in some way) > - most of the interrupt handlers run in ring 0 > > what the safedisc code was doing was: > 0/ code is running in ring 3 > 1/ install an interrupt handler for division by zero (IIRC) > 2/ trigger the division > 3/ have the interrupt handler called, but this is done in ring 0, even > if the code has been loaded from a user space program. here, in the > interrupt handler, you can do any ring 0 operation you want > > that's why I called it a cheap call gate (no real call gate has been > installed, and the code run in ring 0 isn't decided by the kernel but > the app) > > NT doesn't allow this to run. step 1 is not allowed (only the kernel can > decide to change an interrupt handler, which makes lots of sense) Thanks for the detailed explanation. And for completeness I will include here the explanation of Laurent Pinchart why a safedisc program calls int 0x01 : > - the last attempt to detect a debugger uses int 0x01 (enter SMM/ICE mode), > which checks if an external hardware emulator is connected to the > processor. I haven't been able to understand what the code is supposed to > do. Regards Zsolt

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel