wine-devel

wine-devel@winehq.org

8 participants
84486 discussions

Fixing OLE_GetFormatW
by Medland, Bill 23 Oct '02

23 Oct '02

I am just about to fix OLE_GetFormatW. (As far as I can see it can't have worked since rev 1.1). Before correcting the minor error I want to check something. Can anyone with access to NT answer this for me? If you pass a format string to GetDateFormatW that contains time-formatting characters I presume it just throws them away. Similarly if you pass a format string to GetTimeFormatW that contains date-formatting characters I presume it throws them away. Bill

1 0

fairly old wine regression: no$gmb no longer works
by Jonathan Gevaryahu 23 Oct '02

23 Oct '02

In wine builds from early? last year until January 29th, 2002, no$gmb (Nocash gameboy emulator) worked reasonably in wine (yes it would crash if you did 'animate trace' for too long, but that's a seperate issue). the commit which broke it was to wine/dlls/comctl32/status.c, on January 29th at 11:54 am. However, the fix that was done to status.c seems to be valid (later fixes to status.c do the same as what the fix did, I believe), so I suspect that the bug stems from some other issue which causes it to need the incorrect behavior in status.c in order to work. (personally I think it was something done during January that makes it need the incorrect status.c behavior, but I'm probably wrong) The nocash website is http://www.work.de/nocash/ or http://nocash.work.de/ Jonathan Gevaryahu

2 2

Bug tracked down in mci.c
by Erland Lewin 23 Oct '02

23 Oct '02

Hello, I just got the latest wine from cvs, and it crashed when I tried to run Half Life. The problem turned out to be in mci.c, in the mciSendStringA function. The variable lpCmd is set to point into the (in my case mciavi) driver's command table, at the word "open". However, towards the end of the mciSendStringA function, there is the following code: if (strcmp(verb, "open") == 0) { if ((dwRet = MCI_FinishOpen(wmd, (LPMCI_OPEN_PARMSA)data, dwFlags))) MCI_UnLoadMciDriver(iData, wmd); /* FIXME: notification is not properly shared across two opens */ } else { dwRet = MCI_SendCommand(wmd->wDeviceID, MCI_GetMessage(lpCmd), dwFlags, (DWORD)data, TRUE); } TRACE("=> 1/ %lx (%s)\n", dwRet, lpstrRet); dwRet = MCI_HandleReturnValues(iData, dwRet, wmd, lpCmd, data, lpstrRet, uRetLen); The problem is that MCI_UnLoadMciDriver is called, which causes the driver to be removed from memory, which means that lpCmd points to invalid memory. When MCI_HandleReturnValues then tries to use its lpCmd parameter, a segmentation fault will occur, becuase it tries to read from unmapped memory. I did a quick hack to work around the problem (lpCmd = strdup( lpCmd )) before the MCI_FinishOpen. I'd appreciate it if someone else could add a better permanent fix... Thanks for the good work on Wine!

2 1

RE: [RFC] Adding an include/wine/wine directory?
by Patrik Stridvall 23 Oct '02

23 Oct '02

> Actually there is a portable solution. Here's what i did when > I compiled > the Wine tests on Windows: > > Run 'vcvars32.bat' first. When you install Microsoft Visual C++ you > can either tell it to add environment variables with the useful stuff > (either in autoexec.bat or the registry for NT), or just rely on > 'vcvars32.bat'. This script is usually in the include directory: > c:\Program Files\Microsoft Visual Studio\VC98\include\vcvars32.bat > > Well, so I run it on the command line and then in the > makefile (a realy > .mak file) I put: > > INCLUDE=$(TOTOP)\include;$(INCLUDE) > > Then I don't use -I at all and the compiler will automatically use the > environment variable. If using the .mak file directly from the IDE you > don't even need to run vcvars32.bat, First of all I use .dsw/.dsp files not Makefile. OK, they are sort of Makefile but not quite. Secondly the idea is that have different targets so you can easily switch between them. So that does quite cut it. > However I still had include order problems: part of the headers were > coming from MS and part from Wine but did not have time to > look into it > in detail. So I ended up extracting the tests from the Wine > tree. But if > you are able to avoid the header mixup then the above could work. As Alexandre suggested I copied the needed header files. It work eventhough it is a little kludgy. Oh well, it will do for now. Now I just have to properly fix all compile error instead of just kludging them...

1 0

RE: [RFC] Adding an include/wine/wine directory?
by Patrik Stridvall 23 Oct '02

23 Oct '02

> Patrik Stridvall <ps(a)leissner.se> writes: > > Of course compiling every DLL with the Microsoft headers requires > > fixing all of include/wine/ but then as long as we have a solution > > when we get where eventually is good enough IMHO, doing that is no > > particular rush. Having the Wine tests work properly sooner > > rather than later is much more important though. > > I agree getting the Wine tests to work soon is important, but you > don't really need the final header organization for that; you can > easily work around the current problem by copying files around or > specifying an absolute -I option. True. I have already done so. It works. Patch posted to wine-patches. > I don't think we have found a fully satisfying solution yet, and IMO > the situation will be clearer when the dll separation is finished and > the loose ends are cleaned up, so I'd prefer to wait until then to > decide on the final structure. OK. As you wish. > (And my secret hope is that by then we > will be able to switch to Subversion which should make renaming files > a lot easier; but that's another topic...) Ah, nice. :-)

1 0

message box fix.
by Rein Klazes 23 Oct '02

23 Oct '02

Hi, Fix for recent Messagebox breakage. windows/ : msgbox.c In MessageBoxIndirectW call FindResourceEx with arguments in the right order. Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 1

Docu fix for builtin/native apps
by Sylvain Petreolle 23 Oct '02

23 Oct '02

Changelog : Added valid entries into samples/config to specify if an app should be loaded builtin or native. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

wine not detecting wine printers
by Dan Fer 23 Oct '02

23 Oct '02

Has anyone tried using cups under Wine in any of the latest builds? I tried to builds from this month and none detect any printer. Is there a patch? Anything I could use to fix it? _________________________________________________________________ MSN. Más Útil Cada Día http://www.msn.es/intmap/

1 0

Re: Treeview fix
by Jeff Smith 23 Oct '02

23 Oct '02

This patch did the trick. Well I cannot test it at the moment, but as the value INT_MAX (0x7fffffff) was the issue, I know this will fix it. The limit works a lot better (is a lot safer) than the 'special' value. ... - if (i == 0x7fff) + if (i >= 0x7fff) i = hdpa->nItemCount; ... >From: "Dimitrie O. Paun" <dpaun(a)rogers.com> > >On October 23, 2002 01:29 am, Jeff Smith wrote: > > Oops, your previous message got lost in the shuffle... > > I'm sure anything is better than the little patch I wrote. > > I was just taking a minimalist approach to get treeview working. > >No, your patch was quite good. Would have certainly fixed the treeview, >but I think apps depend on the extended behavior. Does my patch fix >the problems you were experiencing? > >-- >Dimi. _________________________________________________________________ Broadband? Dial-up? Get reliable MSN Internet Access. http://resourcecenter.msn.com/access/plans/default.asp

1 0

Re: Treeview fix
by Jeff Smith 23 Oct '02

23 Oct '02

Oops, your previous message got lost in the shuffle... I'm sure anything is better than the little patch I wrote. I was just taking a minimalist approach to get treeview working. -- Jeff S Dimi wrote: >On October 23, 2002 12:44 am, Jeff Smith wrote: > > I discovered treeview uses DSA's and Dimi recently > > changed the max element number in DSA's to 0x7fff (SHRT_MAX). > > Note this value has the special meaning in DSA_InsertPtr > > functions of 'add new element to end of array'. > >This was my initial reaction to this thing, as well. But I >think my fix (sent earlier with Subject DPA_InsertPtr) is >better. Please try it out -- it should fix your problem. > >BTW, I've also audited all other uses of DPA_InsertPtr, >and they are fine. We should be back to normal now (well, >after my patch is applied, of course). > >-- >Dimi. _________________________________________________________________ Surf the Web without missing calls! Get MSN Broadband. http://resourcecenter.msn.com/access/plans/freeactivation.asp

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel