wine-devel

wine-devel@winehq.org

84463 discussions

Re: Major tidy up of Scroll.c to add foundations for flatscroll bars
by Alexandre Julliard 09 Oct '02

09 Oct '02

"Andrew M. Johnston" <johnstonam(a)logica.com> writes: > controls.h - improve the scroll bar nonclient separation > nonclient.c - remove NC_TrackScrollBar and use scrollbar WINAPI routine > scrollbar.c - complete rewrite using similar structure and logic > - unified drawing code > - simpler event processing logic > - minimised drawing > - better conformance to windows on LINEUP and LINEDOWN events All the flat scrollbar stuff has nothing to do in scroll.c, the normal scrollbars shouldn't need to know anything about flatsb at all. The flatsb control should intercept messages it needs to change by subclassing the windows, and call down to the normal scrollbar where necessary. > Note: it is possible to split the scroll changes up into three consistent parts if > really necessary That would be nice. Also if you could avoid unnecessary changes like renaming SCROLLBAR_INFO to SCROLL_INFO that would make it easier to see what is really being changed. -- Alexandre Julliard julliard(a)winehq.com

3 5

Listview
by Dimitrie O. Paun 09 Oct '02

09 Oct '02

Hi folks, Here's a quick status update on the listview. Currently, the listview goes through a major cleanup. It is required -- the file is huge (over 10000 lines when I started, now it's 9200 with more features!), and has accumulated a lot of cruft over the last few years. This is very normal for such a complex control as listview, and we need to prep the code to add more features. At the same time, I go over the code, review it for correctness, fix bugs, and implement the missing functionality. While it may look I do mostly code reorganizations, this is not the case: a lot of corner bugs have been fixed, functionality has been enhanced, code has been cleaned up, and simplified. Due to the cleaner code base, we are in a better position to fix problem, and add features. The downside of all this is that (1) old bugs, and missing functionality is exposed, (2) new bugs are introduced. On top of it all, two major efforts were happening simultaneously: Guy's ICON mode work, and mine. Guy did a wonderful job at fixing some of the issues in ICON mode, unfortunately my changes interacted with his in a nasty way. So we have some problems. I am aware of some of them, and I'm working to fix them. But it will take some time, as I trying to fix a problem, I see some cleanup that needs doing _before_ I work on the bug itself. Currently, I am aware of the following problems: -- selection (clicking on items sometimes does not select them) -- drawing (focus, background, etc.) -- calculating item rectangles If you are experience problems with the listview, I'd like to hear from you. If you want to help, some test cases will help quite a bit. -- Dimi.

3 10

wine on sparc solaris
by Juraj Hercek 09 Oct '02

09 Oct '02

Hi, Since no one had similar problems as I did on sparc solaris (no reply to my previous email sent to wine-devel on /Wed Oct 02 2002 - 09:38:12 CDT/ ). I started to debug it. First problem lies here: $WINE_ROOT/dlls/ntdll/virtual.c:986 There is a condition that says: (char *)base + size > (char *)ADDRESS_SPACE_LIMIT If base+size is above address space limit, NtAllocateVirtualMemory fails. Problem is, that addresses returned by wine_anon_mmap function ($WINE_ROOT/library/port.c:458) - which in turn calls system mmap - are far behind ADDRESS_SPACE_LIMIT (ADDRESS_SPACE_LIMIT=0xc0000000, definition in $WINE_ROOT/dlls/ntdll/virtual.c:110). Just to be precise, they are around 0xfe000000 and higher. I changed address space limit to -1, just to avoid this problem (I know, this is probably not the best solution, but I didn't find better one at the moment). After this change NtAllocateVirtualMemory passed. When I run it again, I got stuck in setup_dos_mem() function ($WINE_ROOT/msdos/dosmem.c:489) where is error saying: "Cannot use first megabyte for DOS address space, please report." After deeper insight I figured out that try_mmap_fixed() function failed ($WINE_ROOT/library/port.c:431), because memory page we were trying to allocate was alredy mapped. So, question is: Is there any way how to solve these two problems (address space limit, already mapped pages) correctly? Thanks for reply. Juraj

1 0

LoadLibrary during PROCESS_ATTACH
by Uwe Bonnes 09 Oct '02

09 Oct '02

Hallo, I am trying to debug Xilinx webpack version 5.1. If I understand things right, the "ise" application crashed because it unloads a dll, but later still accesses this dll. This seems to happen, because during MODULE_InitDLL of the dll it calls a Loadlibrary on itself. As MODULE_InitDLL sets WINE_MODREF_MARKER, and the flow of execution in LoadLibrary checks for WINE_MODREF_MARKER before incrementing the RefCount, the refcount gets wrong and the application unloaded. Forcing the increment of RefCount in MODULE_LoadLibraryExA unconditional of WINE_MODREF_MARKER makes the application continue. Do we need the check for WINE_MODREF_MARKER in MODULE_LoadLibraryEx? Do we still need MODULE_LoadLibraryEx at all? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Registry problem
by steve.lustbader＠philips.com 09 Oct '02

09 Oct '02

I started having a problem with today's source that appears to be either registry or sound related. When I tried to install Winamp (v 2.81 lite) in wine, I get this error: wine client error:8091280: sendmsg: Bad file descriptor Output from +reg,+relay ends with 08091280:Call ntdll.NtQueryValueKey(00000048,40124878,00000002,406e2acc,00000100,406e2ac0) ret=40977acc trace:reg:NtQueryValueKey (0x48,L"WaveMapper",2,0x406e2acc,256) wine client error:8091280: sendmsg: Bad file descriptor (the last 100 lines of the output can be seen at http://www.lustbader.net/winamp.txt) I tried getting rid of my ~/fake_c and ~/.wine directories and running wineinstall again, but that didn't help. -Steve

4 4

Re: Re: jack audio driver
by chrismorgan＠rcn.com 08 Oct '02

08 Oct '02

> > From: Eric Pouech <eric.pouech(a)wanadoo.fr> > Date: 2002/10/08 Tue PM 03:48:04 EDT > To: Chris Morgan <cmorgan(a)alum.wpi.edu> > CC: wine-devel(a)winehq.com > Subject: Re: jack audio driver > > Chris Morgan a écrit : > > > > I have an audio driver for the jack audio server, > > http://jackit.sourceforge.net. This is a callback based server, so each time > > the server needs audio data it executes a client callback function. I was > > wondering if there was any interest in having this driver as part of mainline > > wine code as an example of how to write a wine audio driver for a callback > > based architecture. > well, it depends what you look at > jack way well be the standardized API for audio application > interoperability on Linux > but, some folks may argue that arts may well become the same > as of today, I don't like the number of sound drivers that we already > have (OSS, alsa, arts, nas) just for linux > it, of course, reflects the mess in low level audio interface in linux It really is a mess. It seems clear that we should do away for the most part with having applications interface directly with sound drivers like oss/alsa, and instead go through sound servers like arts/jack/etc. In technical aspects a callback based architecture is far superior to a polling based architecture. It has a lower latency and enforces a cleaner sound implementation on applications. What I haven't seen yet is a widely used audio server that people agree upon. Someone really needs to take the lead and start pushing a callback based sound server that is under active development(arts appears not to be) that is not kde/gnome specific.</rant> > what I really fear is the real maintenance of those drivers > as of today, OSS is maintained, I cannot really tell the same for the > others > it's never a bad idea to share code, but I fear we're not going to be > able to maintain all the drivers (but we don't maintain them all today > anyway) > so go for it > (sorry for thinking while writing ;-) Wonder when we can phase out the OSS driver and concentrate on the ALSA one. Seems like a waste to support two drivers that fulfill the same role. Chris

2 1

jack audio driver
by Chris Morgan 08 Oct '02

08 Oct '02

I have an audio driver for the jack audio server, http://jackit.sourceforge.net. This is a callback based server, so each time the server needs audio data it executes a client callback function. I was wondering if there was any interest in having this driver as part of mainline wine code as an example of how to write a wine audio driver for a callback based architecture. Chris

2 1

sound problem
by Rein Klazes 08 Oct '02

08 Oct '02

Hi, Last nights cvs commits gives a problem with sound in Agent. It is the ping played when new mail is received. The first time goes alright, the second time it kills agent: | trace:wave:OSS_wodMessage (0, 0005, 42E12C74, 42E12CA4, 00030008); | trace:wave:wodOpen (0, 0x42e12ca4, 00030008); | warn:wave:OSS_RawOpenDevice Couldn't open out /dev/dsp (Device or resource busy) | err:wave:wodOpen ioctl can't 'SNDCTL_DSP_GETOSPACE' ! | trace:wave:OSS_wodMessage (1, 0005, 42E12C74, 42E12CA4, 00030008); | trace:wave:wodOpen (1, 0x42e12ca4, 00030008); | warn:wave:OSS_RawOpenDevice Couldn't open out /dev/dsp1 (No such device) | err:wave:wodOpen ioctl can't 'SNDCTL_DSP_GETOSPACE' ! | trace:wave:OSS_wodMessage (2, 0005, 42E12C74, 42E12CA4, 00030008); | trace:wave:wodOpen (2, 0x42e12ca4, 00030008); | warn:wave:OSS_RawOpenDevice Couldn't open out /dev/dsp2 (No such device) | err:wave:wodOpen ioctl can't 'SNDCTL_DSP_GETOSPACE' ! | wine client error:806fe00: sendmsg: Bad file descriptor And the wine returns to the prompt in the xterm from which it is started. Some other thread continues: | trace:wave:OSS_wodMessage (0, 0005, 42E12C48, 42E12C78, 00030008); | trace:wave:wodOpen (0, 0x42e12c78, 00030008); | warn:wave:OSS_RawOpenDevice Couldn't open out /dev/dsp (Device or resource busy) | err:wave:wodOpen ioctl can't 'SNDCTL_DSP_GETOSPACE' ! [these 4 messages repated 11 times] | trace:wave:OSS_wodMessage (1, 0005, 42E12C48, 42E12C78, 00030008); | trace:wave:wodOpen (1, 0x42e12c78, 00030008); | warn:wave:OSS_RawOpenDevice Couldn't open out /dev/dsp1 (No such device) | err:wave:wodOpen ioctl can't 'SNDCTL_DSP_GETOSPACE' ! [those too] | trace:wave:OSS_wodMessage (2, 0005, 42E12C48, 42E12C78, 00030008); | trace:wave:wodOpen (2, 0x42e12c78, 00030008); | warn:wave:OSS_RawOpenDevice Couldn't open out /dev/dsp2 (No such device) | err:wave:wodOpen ioctl can't 'SNDCTL_DSP_GETOSPACE' ! [and those] | err:ntdll:RtlpWaitForCriticalSection section 0x40875b7c "../../windows/user.c: USER_SysLevel" wait timed out, retrying (60 sec) tid=08fc03c0 this happens sometimes. If so it is followed by an attempt to start the debugger. Any suggestions? Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 1

automagical .sym symbol loading in winedbg?
by Greg Turner 08 Oct '02

08 Oct '02

Is there any way to get winedbg to automagically load .sym files from some particular directory? winedbg> "symbolfile [full unix path of .sym file]/[filename.sym]" it seems to work; but what a hassle! All that crap is in "/var/src/nosrc/DOTwine/fake_windows/windows/Symbols," quite a lot to type over and over (yes, I have cut-and-paste capabilities... but it still sucks). I see it looking for ".dbg" files but not ".sym". I'm experimenting with the Windows 98/98SE DDK symbol files, installed into my fake_windows. I also noticed _NT_SYMBOL_PATH references floating around in there, but that's for ".pdb" files, and unlikely to help, right? Anyways, I tried it, it doesn't help. :( -- gmt "If ye love wealth better than liberty, the tranquility of servitude better than the animating contest of freedom, go home from us in peace. We ask not your counsels or your arms. Crouch down and lick the hands, which feed you. May your chains set lightly upon you, and may posterity forget that ye were our countrymen." -Samuel Adams

2 1

Re: Re: Environment passing
by chrismorgan＠rcn.com 08 Oct '02

08 Oct '02

A very similar approach to what I was working on and it looks like the right thing to do. I haven't had time to test it yes but if you have it should be ok to go in. I'll mail another patch or two to fix other issues relating to environment passing soon. Thanks, Chris > > From: Alexandre Julliard <julliard(a)winehq.com> > Date: 2002/10/08 Tue PM 12:24:28 EDT > To: Chris Morgan <cmorgan(a)alum.wpi.edu> > CC: <wine-devel(a)winehq.com> > Subject: Re: Environment passing > > Chris Morgan <cmorgan(a)alum.wpi.edu> writes: > > > I've been looking into exactly what is broken with environment passing in > > CreateProcess() and the functions it uses. What appears to be breaking > > things at this point is just what Eric mentioned, that we mess with the PATH > > environment variable inside of fork_and_exec() and then we call out to > > execve() with this modified environment. It appears that we really do need > > to mess with the PATH environment variable to ensure that execve() finds > > things in the correct unix path locations. I was thinking that before we > > execve() that we could copy the current PATH into a variable called __PATH. > > We would then restore PATH in PROCESS_InitWine() from this __PATH. > > Yes, I wrote a patch some time ago to do this, here it is. I think it > should still work but I haven't tested it. Let me know if it works for > you and I'll put it in. > > Index: files/directory.c > =================================================================== > RCS file: /opt/cvs-commit/wine/files/directory.c,v > retrieving revision 1.54 > diff -u -r1.54 directory.c > --- files/directory.c 13 Sep 2002 18:52:01 -0000 1.54 > +++ files/directory.c 8 Oct 2002 15:09:58 -0000 > @@ -160,17 +160,21 @@ > DRIVE_Chdir( drive, DIR_Windows.short_name + 2 ); > } > > - PROFILE_GetWineIniString(wineW, pathW, path_dirW, longpath, MAX_PATHNAME_LEN); > - if (strchrW(longpath, '/')) > + /* Set the environment variables */ > + > + /* set PATH only if not set already */ > + if (!GetEnvironmentVariableW( path_capsW, longpath, MAX_PATHNAME_LEN )) > { > - MESSAGE("Fix your wine config to use DOS drive syntax in [wine] 'Path=' statement! (no '/' allowed)\n"); > - PROFILE_UsageWineIni(); > - ExitProcess(1); > + PROFILE_GetWineIniString(wineW, pathW, path_dirW, longpath, MAX_PATHNAME_LEN); > + if (strchrW(longpath, '/')) > + { > + MESSAGE("Fix your wine config to use DOS drive syntax in [wine] 'Path=' statement! (no '/' allowed)\n"); > + PROFILE_UsageWineIni(); > + ExitProcess(1); > + } > + SetEnvironmentVariableW( path_capsW, longpath ); > } > > - /* Set the environment variables */ > - > - SetEnvironmentVariableW( path_capsW, longpath ); > SetEnvironmentVariableW( temp_capsW, tmp_dir.short_name ); > SetEnvironmentVariableW( tmp_capsW, tmp_dir.short_name ); > SetEnvironmentVariableW( windirW, DIR_Windows.short_name ); > Index: memory/environ.c > =================================================================== > RCS file: /opt/cvs-commit/wine/memory/environ.c,v > retrieving revision 1.37 > diff -u -r1.37 environ.c > --- memory/environ.c 24 Sep 2002 18:29:40 -0000 1.37 > +++ memory/environ.c 8 Oct 2002 15:10:07 -0000 > @@ -152,7 +152,11 @@ > /* Compute the total size of the Unix environment */ > > size = sizeof(BYTE) + sizeof(WORD) + sizeof(ENV_program_name); > - for (e = environ; *e; e++) size += strlen(*e) + 1; > + for (e = environ; *e; e++) > + { > + if (!memcmp( *e, "PATH=", 5 )) continue; > + size += strlen(*e) + 1; > + } > > /* Now allocate the environment */ > > @@ -164,7 +168,10 @@ > > for (e = environ; *e; e++) > { > - strcpy( p, *e ); > + /* skip Unix PATH and store WINEPATH as PATH */ > + if (!memcmp( *e, "PATH=", 5 )) continue; > + if (!memcmp( *e, "WINEPATH=", 9 )) strcpy( p, *e + 4 ); > + else strcpy( p, *e ); > p += strlen(p) + 1; > } > > Index: scheduler/process.c > =================================================================== > RCS file: /opt/cvs-commit/wine/scheduler/process.c,v > retrieving revision 1.200 > diff -u -r1.200 process.c > --- scheduler/process.c 3 Oct 2002 19:54:57 -0000 1.200 > +++ scheduler/process.c 8 Oct 2002 15:10:10 -0000 > @@ -820,9 +820,16 @@ > /* now put the Windows environment strings */ > for (p = env; *p; p += strlen(p) + 1) > { > - if (memcmp( p, "PATH=", 5 ) && > - memcmp( p, "HOME=", 5 ) && > - memcmp( p, "WINEPREFIX=", 11 )) *envptr++ = (char *)p; > + if (!memcmp( p, "PATH=", 5 )) /* store PATH as WINEPATH */ > + { > + char *winepath = malloc( strlen(p) + 5 ); > + strcpy( winepath, "WINE" ); > + strcpy( winepath + 4, p ); > + *envptr++ = winepath; > + } > + else if (memcmp( p, "HOME=", 5 ) && > + memcmp( p, "WINEPATH=", 9 ) && > + memcmp( p, "WINEPREFIX=", 11 )) *envptr++ = (char *)p; > } > *envptr = 0; > } > > -- > Alexandre Julliard > julliard(a)winehq.com > > >

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel